[valgrind] [Bug 389065] valgrind meets gcc flag -Wlogical-op

[Ivo Raisr]

https://bugs.kde.org/show_bug.cgi?id=389065

Ivo Raisr  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #5 from Ivo Raisr  ---
Fixed in commit f19a956e0a96b4f6b37c50b00ae24ecf09a7a3f5.

https://sourceware.org/git/?p=valgrind.git;a=commitdiff;h=f19a956e0a96b4f6b37c50b00ae24ecf09a7a3f5

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 389065] valgrind meets gcc flag -Wlogical-op

[Ivo Raisr]

https://bugs.kde.org/show_bug.cgi?id=389065

Ivo Raisr  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #4 from Ivo Raisr  ---
The attached patch enables -Wlogical-op (if supported) and fixes an obvious
typo.
I used https://github.com/mirage/xen/blob/master/tools/libxc/xc_monitor.c for
an inspiration.

My gcc 7.2.0 on Ubuntu 17.10 did not report a problem in priv/guest_arm_toIR.c
with -Wlogical-op. I guess the first reported problem must have been caused by
some other factor.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 389065] valgrind meets gcc flag -Wlogical-op

[Ivo Raisr]

https://bugs.kde.org/show_bug.cgi?id=389065

Ivo Raisr  changed:

   What|Removed |Added

   Assignee|jsew...@acm.org |iv...@ivosh.net

--- Comment #3 from Ivo Raisr  ---
Created attachment 109970
  --> https://bugs.kde.org/attachment.cgi?id=109970=edit
patch

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 389065] valgrind meets gcc flag -Wlogical-op

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=389065

--- Comment #2 from dcb...@hotmail.com ---
>Would you like to supply a patch for both the occurrences?
>Would you like to supply a patch for extending Valgrind build

No thanks. I just find them. Folks who know the code are 
in a better state to fix them.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 389065] valgrind meets gcc flag -Wlogical-op

[Ivo Raisr]

https://bugs.kde.org/show_bug.cgi?id=389065

Ivo Raisr  changed:

   What|Removed |Added

 CC||iv...@ivosh.net
 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #1 from Ivo Raisr  ---
Thank you for the bug report.
Indeed, the second one is a bug in Valgrind code.
The first one is not a bug but merely a mental note for maintainer that this
piece of code handles both pkhbt (tb == 0) and pkhbt (tb == 1) variants.

Would you like to supply a patch for both the occurrences?
Would you like to supply a patch for extending Valgrind build with -Wlogical-op
(have a look at configure.ac, similar flags are enabled there).

-- 
You are receiving this mail because:
You are watching all bug changes.