[valgrind] [Bug 409678] improvement suggestion for dhat
https://bugs.kde.org/show_bug.cgi?id=409678 --- Comment #5 from Nick Nethercote --- FWIW, you can run some tests of DHAT's viewer by loading dhat with `?test=1` appended to the URL. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 409678] improvement suggestion for dhat
https://bugs.kde.org/show_bug.cgi?id=409678 --- Comment #4 from Philippe Waroquiers --- (In reply to plasmahh from comment #3) > > Seems there is no doc changed, no test changed. > I wasn't aware of that its necessary to do all this, you can then close this > ticket, I was just sharing our changes in the hope it might be useful for > other people that want to know the same information. Yes, of course, any contribution is welcome. A change has however more chances to be integrated if it is clear what it does, and the more complete the patch is, e.g. with doc updated, with a test, ... -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 409678] improvement suggestion for dhat
https://bugs.kde.org/show_bug.cgi?id=409678 --- Comment #3 from plasm...@gmx.net --- (In reply to Philippe Waroquiers from comment #1) > The attached patch is in an unusual format, e.g. contains various control > characters. whoops, my fault, I wasn't aware of that the "git diff" colour output is also present when redirecting to a file, did it explicitly without. > > Also, what is the idea that the patch is implementing ? As I said it not only tells which byte was accessed, but also in what way (read/write) > > Seems there is no doc changed, no test changed. I wasn't aware of that its necessary to do all this, you can then close this ticket, I was just sharing our changes in the hope it might be useful for other people that want to know the same information. > > So, that makes it not easy to see what you propose to add. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 409678] improvement suggestion for dhat
https://bugs.kde.org/show_bug.cgi?id=409678 Julian Seward changed: What|Removed |Added CC||n.netherc...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 409678] improvement suggestion for dhat
https://bugs.kde.org/show_bug.cgi?id=409678 --- Comment #2 from plasm...@gmx.net --- Created attachment 121461 --> https://bugs.kde.org/attachment.cgi?id=121461=edit patch against git VALGRIND_3_14_0-225-g514f89938 -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 409678] improvement suggestion for dhat
https://bugs.kde.org/show_bug.cgi?id=409678 Philippe Waroquiers changed: What|Removed |Added CC||philippe.waroquiers@skynet. ||be --- Comment #1 from Philippe Waroquiers --- The attached patch is in an unusual format, e.g. contains various control characters. Also, what is the idea that the patch is implementing ? Seems there is no doc changed, no test changed. So, that makes it not easy to see what you propose to add. -- You are receiving this mail because: You are watching all bug changes.
