Re: KF6 porting. KSelectAction::triggered signal
El dimecres, 3 de gener de 2024, a les 9:01:11 (CET), Sune Vuorela va escriure: > Hi > > I just - during KF6 porting of an app - fall in an api trap: > > Original code: > | connect(d->aZoom, QOverload::of(::triggered), > | this, ::slotZoom); > > The wrong porting code: > | connect(d->aZoom, ::triggered, this, ::slotZoom); > > The gotcha is that the QAction* overload, while with the same name, is > emitted under different rules than the only remaining triggered function > (from QAction) > > The correct porting would have been: > | connect(d->aZoom, ::actionTriggered, this, > | ::slotZoom); > > So, just a heads up to whomever might hit this as well. (I wonder if one > has enough sources checked out to be able to grep this to see what might > be relevant. scripty has everything checked out so if you tell me what to grep for, I can run a query on it. Cheers, Albert > > /Sune
Re: KDE Gear projects with failing CI (release/23.08) (2 January 2024)
On Dienstag, 2. Januar 2024 23:18:58 CET Ben Cooksley wrote: > On Wed, Jan 3, 2024 at 10:51 AM Volker Krause wrote: > > On Dienstag, 2. Januar 2024 22:01:25 CET Albert Astals Cid wrote: > > > Please work on fixing them, otherwise i will remove the failing CI > > > jobs on their 4th failing week, it is very important that CI is passing > > > > for > > > > > multiple reasons. > > > > > > Bad news: 2 new repositories are failing :( > > > > > > > > > == Something is up with kdiagram == > > > > > > kdepim-addons: > > > * https://invent.kde.org/pim/kdepim-addons/-/pipelines/572121 > > > > Build is still running on FreeBSD, but this should be fixed. > > > > > == Something is up with kweathercore == > > > > > > kweather: > > > * https://invent.kde.org/utilities/kweather/-/pipelines/572137 > > > > This one is more complicated. KWeatherCore master is Qt6-only, but there > > is no > > branch for past releases, only tags. So the CI has no Qt5 build of it > > anymore, > > which however is needed for the Qt5-based KWeather build. > > > > The best I can think of right now is adding a dummy kf5 branch on the v0.7 > > tag? > > That is what I would recommend at this point. We don't support publishing > CI artifacts from tags at the moment as that requires marking them as > protected (which may cause other issues and would need to be looked into > seperately) That almost worked: the v0.7 tag is so old that it still has the dysfunctional CI template include style. So I had to move the kf5 branch to right before the Qt5 support removal, but I don't think that matters much here. One more reason for KWeatherCore to also move to one of the automated release schemes IMHO. Regards, Volker signature.asc Description: This is a digitally signed message part.
KF6 porting. KSelectAction::triggered signal
Hi I just - during KF6 porting of an app - fall in an api trap: Original code: | connect(d->aZoom, QOverload::of(::triggered), | this, ::slotZoom); The wrong porting code: | connect(d->aZoom, ::triggered, this, ::slotZoom); The gotcha is that the QAction* overload, while with the same name, is emitted under different rules than the only remaining triggered function (from QAction) The correct porting would have been: | connect(d->aZoom, ::actionTriggered, this, | ::slotZoom); So, just a heads up to whomever might hit this as well. (I wonder if one has enough sources checked out to be able to grep this to see what might be relevant. /Sune
