D29006: Allow to copy or move selection to the other split view

2020-05-11 Thread Elvis Angelaccio 
elvisangelaccio added inline comments.

INLINE COMMENTS

> dolphinview.h:377
> + */
> +void copySelectedItems(const KFileItemList , const QUrl 
> );
> +

Let's just call it `destinationUrl`. This can be any URL, not necessarily the 
URL of a split pane.

> dolphinview.h:383
> + */
> +void moveSelectedItems(const KFileItemList , const QUrl 
> );
> +

Same here.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29006

To: aprcela, #dolphin, elvisangelaccio, ngraham, meven, dfaure
Cc: yurchor, kde-doc-english, dfaure, meven, kfm-devel, waitquietly, azyx, 
nikolaik, pberestov, iasensio, aprcela, fprice, gennad, fbampaloukas, alexde, 
Codezela, feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, 
skadinna, emmanuelp, rdieter, mikesomov

D29006: Allow to copy or move selection to the other split view

2020-05-11 Thread Antonio Prcela 
aprcela marked an inline comment as done.
aprcela added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in dolphinview.h:367-377
> Not anymore since d1a70c0b62 
>  ;)

Thanks. I renamed those now :)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29006

To: aprcela, #dolphin, elvisangelaccio, ngraham, meven, dfaure
Cc: yurchor, kde-doc-english, dfaure, meven, kfm-devel, waitquietly, azyx, 
nikolaik, pberestov, iasensio, aprcela, fprice, gennad, fbampaloukas, alexde, 
Codezela, feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, 
skadinna, emmanuelp, rdieter, mikesomov

D29006: Allow to copy or move selection to the other split view

2020-05-11 Thread Antonio Prcela 
aprcela updated this revision to Diff 82609.
aprcela added a comment.


  - Merge branch 'master' of https://anongit.kde.org/dolphin into 
arcpatch-D29006
  - Merge branch 'master' of https://anongit.kde.org/dolphin into 
arcpatch-D29006
  - Rename to (copy|move)SelectedItems

REPOSITORY
  R318 Dolphin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29006?vs=81872=82609

BRANCH
  arcpatch-D29006

REVISION DETAIL
  https://phabricator.kde.org/D29006

AFFECTED FILES
  doc/index.docbook
  src/dolphinmainwindow.cpp
  src/dolphintabwidget.cpp
  src/dolphintabwidget.h
  src/dolphinui.rc
  src/views/dolphinview.cpp
  src/views/dolphinview.h

To: aprcela, #dolphin, elvisangelaccio, ngraham, meven, dfaure
Cc: yurchor, kde-doc-english, dfaure, meven, kfm-devel, waitquietly, azyx, 
nikolaik, pberestov, iasensio, aprcela, fprice, gennad, fbampaloukas, alexde, 
Codezela, feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, 
skadinna, emmanuelp, rdieter, mikesomov

D29667: Export metalist to json file

2020-05-11 Thread Carson Black 
cblack updated this revision to Diff 82608.
cblack added a comment.


  Dump output information as well

REPOSITORY
  R264 KApiDox

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29667?vs=82603=82608

BRANCH
  cblack/metadata (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29667

AFFECTED FILES
  src/kapidox/hlfunctions.py

To: cblack, ochurlaud
Cc: bcooksley, kde-frameworks-devel, kde-doc-english, ognarb, LeGast00n, 
cblack, gennad, fbampaloukas, michaelh, ngraham, bruns, skadinna

D29667: Export metalist to json file

2020-05-11 Thread Carson Black 
cblack created this revision.
cblack added a reviewer: ochurlaud.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
cblack requested review of this revision.

REVISION SUMMARY
  This will allow tooling to better introspect the generated pages.

REPOSITORY
  R264 KApiDox

BRANCH
  cblack/metadata (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29667

AFFECTED FILES
  src/kapidox/hlfunctions.py

To: cblack, ochurlaud
Cc: bcooksley, kde-frameworks-devel, kde-doc-english, ognarb, LeGast00n, 
cblack, gennad, fbampaloukas, michaelh, ngraham, bruns, skadinna

D29006: Allow to copy or move selection to the other split view

2020-05-11 Thread Elvis Angelaccio 
elvisangelaccio added inline comments.

INLINE COMMENTS

> aprcela wrote in dolphinview.h:367-377
> `copySelectedItems()` is already used to copy to clipboard. See L365.

Not anymore since d1a70c0b62 
 ;)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29006

To: aprcela, #dolphin, elvisangelaccio, ngraham, meven, dfaure
Cc: yurchor, kde-doc-english, dfaure, meven, kfm-devel, waitquietly, azyx, 
nikolaik, pberestov, iasensio, aprcela, fprice, gennad, fbampaloukas, alexde, 
Codezela, feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, 
skadinna, emmanuelp, rdieter, mikesomov