D21695: Add FindTaglib.cmake

2020-06-11 Thread Elvis Angelaccio 
elvisangelaccio added a comment.


  New attempt at 
https://invent.kde.org/frameworks/extra-cmake-modules/-/merge_requests/6

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21695

To: heikobecker, kde-buildsystem, kde-frameworks-devel, dfaure
Cc: asturmlechner, ngraham, elvisangelaccio, cgiboudeaux, dfaure, LeGast00n, 
cblack, bencreasy, michaelh, bruns

KDE CI: Frameworks » kcrash » kf5-qt5 FreeBSDQt5.14 - Build # 20 - Fixed!

2020-06-11 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20FreeBSDQt5.14/20/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Thu, 11 Jun 2020 22:04:55 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.12 - Build # 152 - Fixed!

2020-06-11 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.12/152/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 11 Jun 2020 18:37:45 +
 Build duration:
7 min 27 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5WidgetsAddons-5.71.0.xmlcompat_reports/KF5WidgetsAddons_compat_report.htmllogs/KF5WidgetsAddons/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)43%
(74/172)43%
(74/172)34%
(5247/15349)25%
(1867/7485)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(20/20)100%
(20/20)99%
(1674/1683)49%
(773/1568)examples.kmessagebox0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/2)src47%
(54/116)47%
(54/116)29%
(3573/12509)19%
(1094/5758)tests0%
(0/35)0%
(0/35)0%
(0/1140)0%
(0/157)

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.14 - Build # 32 - Fixed!

2020-06-11 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.14/32/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Thu, 11 Jun 2020 18:37:45 +
 Build duration:
8 min 3 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5WidgetsAddons-5.71.0.xmlcompat_reports/KF5WidgetsAddons_compat_report.htmllogs/KF5WidgetsAddons/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)43%
(74/172)43%
(74/172)34%
(5272/15349)25%
(1886/7489)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(20/20)100%
(20/20)99%
(1677/1686)49%
(775/1572)examples.kmessagebox0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/2)src47%
(54/116)47%
(54/116)29%
(3595/12506)19%
(/5758)tests0%
(0/35)0%
(0/35)0%
(0/1140)0%
(0/157)

KDE CI: Frameworks » plasma-framework » kf5-qt5 WindowsMSVCQt5.14 - Build # 111 - Still unstable!

2020-06-11 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20WindowsMSVCQt5.14/111/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Thu, 11 Jun 2020 18:37:58 +
 Build duration:
6 min 45 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.coronatestFailed: projectroot.autotests.plasma_dialogstatetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_themetest

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 FreeBSDQt5.14 - Build # 35 - Fixed!

2020-06-11 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20FreeBSDQt5.14/35/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Thu, 11 Jun 2020 18:37:45 +
 Build duration:
2 min 4 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s)

KDE CI: Frameworks » plasma-framework » kf5-qt5 WindowsMSVCQt5.14 - Build # 110 - Aborted!

2020-06-11 Thread CI System 
BUILD ABORTED
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20WindowsMSVCQt5.14/110/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Wed, 10 Jun 2020 14:35:48 +
 Build duration:
1 day 3 hr and counting

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 FreeBSDQt5.14 - Build # 34 - Unstable!

2020-06-11 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20FreeBSDQt5.14/34/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Thu, 11 Jun 2020 17:19:31 +
 Build duration:
8 min 13 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.ktooltipwidgettest

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.12 - Build # 151 - Unstable!

2020-06-11 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.12/151/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 11 Jun 2020 17:19:31 +
 Build duration:
6 min 43 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5WidgetsAddons-5.71.0.xmlcompat_reports/KF5WidgetsAddons_compat_report.htmllogs/KF5WidgetsAddons/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.ktooltipwidgettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)42%
(72/172)42%
(72/172)33%
(5010/15334)24%
(1797/7485)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests95%
(19/20)95%
(19/20)92%
(1544/1681)46%
(723/1568)examples.kmessagebox0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/2)src46%
(53/116)46%
(53/116)28%
(3466/12496)19%
(1074/5758)tests0%
(0/35)0%
(0/35)0%
(0/1140)0%
(0/157)

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.14 - Build # 29 - Still Unstable!

2020-06-11 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.14/29/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Thu, 11 Jun 2020 16:33:12 +
 Build duration:
52 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.bug313759Failed: projectroot.autotests.kateindenttest_testPascalName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.14 - Build # 31 - Unstable!

2020-06-11 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.14/31/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Thu, 11 Jun 2020 17:19:31 +
 Build duration:
5 min 19 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5WidgetsAddons-5.71.0.xmlcompat_reports/KF5WidgetsAddons_compat_report.htmllogs/KF5WidgetsAddons/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.ktooltipwidgettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)42%
(72/172)42%
(72/172)33%
(5039/15338)24%
(1820/7489)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests95%
(19/20)95%
(19/20)92%
(1547/1684)46%
(728/1572)examples.kmessagebox0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/2)src46%
(53/116)46%
(53/116)28%
(3492/12497)19%
(1092/5758)tests0%
(0/35)0%
(0/35)0%
(0/1140)0%
(0/157)

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 29 - Still Unstable!

2020-06-11 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/29/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Thu, 11 Jun 2020 16:33:12 +
 Build duration:
16 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.71.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.bug313759Failed: projectroot.autotests.kateindenttest_testPascalName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)87%
(260/298)87%
(260/298)67%
(33018/49207)49%
(14806/30098)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src97%
(37/38)97%
(37/38)93%
(4791/5129)49%
(1812/3680)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5526/5568)58%
(984/1708)src.buffer88%
(15/17)88%
(15/17)89%
(1677/1892)74%
(1082/1472)src.completion100%
(11/11)100%
(11/11)57%
(1785/3131)42%
(1008/2423)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(182/457)21%
(73/340)src.dialogs0%
(0/4)0%
(0/4)0%
(0/858)0%
(0/180)src.document100%
(4/4)100%
(4/4)61%
(1937/3176)48%
(1419/2977)src.export0%
(0/4)0%
(0/4)0%
(0/121)0%
(0/156)src.include.ktexteditor93%
(14/15)93%
(14/15)84%
(187/223)55%
(125/226)src.inputmode100%
(8/8)100%
(8/8)63%
(192/304)51%
(39/77)src.mode88%
(7/8)88%
(7/8)36%
(378/1050)16%
(146/897)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/862)0%
(0/278)src.render100%
(7/7)100%
(7/7)77%
(949/1226)67%
(611/916)src.schema29%
(2/7)29%
(2/7)1%
(19/1468)1%
(6/625)src.script100%
(16/16)100%
(16/16)68%
(706/1038)54%

D26503: [Dialog Shadows] Port to KWindowSystem shadows API

2020-06-11 Thread Vlad Zahorodnii 
zzag closed this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26503

To: zzag, #plasma, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D26503: [Dialog Shadows] Port to KWindowSystem shadows API

2020-06-11 Thread Vlad Zahorodnii 
zzag edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  port-to-shadows-api

REVISION DETAIL
  https://phabricator.kde.org/D26503

To: zzag, #plasma, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D26503: [Dialog Shadows] Port to KWindowSystem shadows API

2020-06-11 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  port-to-shadows-api

REVISION DETAIL
  https://phabricator.kde.org/D26503

To: zzag, #plasma, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D26503: [Dialog Shadows] Port to KWindowSystem shadows API

2020-06-11 Thread Vlad Zahorodnii 
zzag updated this revision to Diff 83261.
zzag added a comment.


  Fix merge conflict.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26503?vs=74590=83261

BRANCH
  port-to-shadows-api

REVISION DETAIL
  https://phabricator.kde.org/D26503

AFFECTED FILES
  src/plasmaquick/dialogshadows.cpp
  src/plasmaquick/dialogshadows_p.h
  src/plasmaquick/waylandintegration.cpp
  src/plasmaquick/waylandintegration_p.h

To: zzag, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28745: Skip caching thumbnails on encrypted filesystems

2020-06-11 Thread Méven Car 
meven added a comment.


  In D28745#675033 , @marcingu wrote:
  
  > Ok, so, what I want to do now is to create static method `findByPath` which 
is going to return Solid::StorageVolume instance (is there a case in which we 
can expect something different than StorageVolume?).
  
  
  I don't think so, Storage Volume is any block device.
  This function may fail if the input path is not valid for instance.
  
  > Should it be `StorageVolume Device::findByPath(QString)` or rather 
`StorageVolume StorageVolume::findByPath(QString)`?
  
  My preference is `StorageVolume Device::findByPath(QString)`, to keep all 
entry points to Solid in Device and somewhat similar to the `Device::listFrom*` 
functions.
  
  > For implementation itself I want to create structure with mountpoints and 
StorageVolumes which will be updated if new Device is added/removed and we 
learn this via Solid notifications.
  
  Yeah that's what I imagined as well, but this is already taken care of by the 
base DeviceManager.
  
  > I am thinking it should either be part of `DeviceManagerStorage` or 
separate class similar to DeviceManagerStorage. Not sure which.
  
  Either way you can simply wrap the base DeviceManager.
  Your method should only be a utility function not adding new Structures, 
everything is in Solid already.
  
  > I don't know how to get a mountpoint for StorageVolume.
  
  You make me realize you should filter StorageVolume (any block device) that 
are also StorageAccess (anything that can be mounted) which has the mountpoints 
in `filePath()`.
  
  https://api.kde.org/frameworks/solid/html/classSolid_1_1StorageVolume.html 
  https://api.kde.org/frameworks/solid/html/classSolid_1_1StorageAccess.html
  
  > What do you think about it?
  
  I like it

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns
Cc: thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, 
waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, 
cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov

D28745: Skip caching thumbnails on encrypted filesystems

2020-06-11 Thread Marcin Gurtowski 
marcingu added a comment.


  Ok, so, what I want to do now is to create static method `findByPath` which 
is going to return Solid::StorageVolume instance (is there a case in which we 
can expect something different than StorageVolume?).
  
  Should it be `StorageVolume Device::findByPath(QString)` or rather 
`StorageVolume StorageVolume::findByPath(QString)`?
  
  For implementation itself I want to create structure with mountpoints and 
StorageVolumes which will be updated if new Device is added/removed and we 
learn this via Solid notifications.
  I am thinking it should either be part of `DeviceManagerStorage` or separate 
class similar to DeviceManagerStorage. Not sure which.
  
  I don't know how to get a mountpoint for StorageVolume.
  
  What do you think about it?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns
Cc: thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, 
waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, 
cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov