[Akonadi] [Bug 393002] Akonadi-ews does not save password in kwallet

[Igor Poboiko]

https://bugs.kde.org/show_bug.cgi?id=393002

Igor Poboiko  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit|https://commits.kde.org/kde |https://commits.kde.org/kde
   |pim-runtime/b5ee6ff11cd3a7e |pim-runtime/7afd99abbfa141f
   |0c28305b351d28c5f244f101e   |6e6dfbe69b01827af8f16ba27
 Status|REOPENED|RESOLVED

--- Comment #18 from Igor Poboiko  ---
Git commit 7afd99abbfa141f6e6dfbe69b01827af8f16ba27 by Igor Poboiko.
Committed on 20/03/2020 at 16:10.
Pushed by poboiko into branch 'master'.

[resources/ews] Save password to wallet

Summary:
Seems like the password entered via the UI actually never gets saved anywhere.
Just do it explicitly.
Related: bug 390798, bug 402780, bug 414789

Test Plan:
1) Try to setup EWS account using autodiscovery, using Username/Password auth
2) Set Username, Password, hit "Try connect" -> it works fine
3) Hit "OK" -> observe "Authentication failure" resource error
4) Browse `akonadi-ews` via `KWalletManager` -> it's empty
5) Apply the patch, repeat 1-4 - authentication succeeds, password entry inside
wallet appears

Reviewers: dvratil, nowicki

Reviewed By: dvratil

Subscribers: kde-pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D27813

M  +1-0resources/ews/ewsconfigdialog.cpp

https://commits.kde.org/kdepim-runtime/7afd99abbfa141f6e6dfbe69b01827af8f16ba27

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Akonadi] [Bug 393002] Akonadi-ews does not save password in kwallet

[John Scott]

https://bugs.kde.org/show_bug.cgi?id=393002

John Scott  changed:

   What|Removed |Added

 CC||jsc...@posteo.net

--- Comment #17 from John Scott  ---
Affects Akonadi 19.08.3 on Debian unstable. I worked around by making the
appropriate entry with KWalletManager, though this would surely not be useful
for anyone using OAuth2.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Akonadi] [Bug 393002] Akonadi-ews does not save password in kwallet

[Gaël de Chalendar]

https://bugs.kde.org/show_bug.cgi?id=393002

--- Comment #16 from Gaël de Chalendar (aka Kleag)  ---
I used again the workaround I explained above, but this time, the akonadi
resource name changed. I used akonadiconsole to find the new name.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Akonadi] [Bug 393002] Akonadi-ews does not save password in kwallet

[Sefa Eyeoglu]

https://bugs.kde.org/show_bug.cgi?id=393002

Sefa Eyeoglu  changed:

   What|Removed |Added

 CC||cont...@scrumplex.net

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Akonadi] [Bug 393002] Akonadi-ews does not save password in kwallet

[S.Trzmiel]

https://bugs.kde.org/show_bug.cgi?id=393002

S.Trzmiel  changed:

   What|Removed |Added

 CC||x...@x-s.com.pl

--- Comment #15 from S.Trzmiel  ---
Same here, Fedora 31 with Plasma 5.16.5-1/KF5 5.61.0-1/Qt 5.12.5-1.
D-Buss call from console used as workaround.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Akonadi] [Bug 393002] Akonadi-ews does not save password in kwallet

[Gaël de Chalendar]

https://bugs.kde.org/show_bug.cgi?id=393002

--- Comment #14 from Gaël de Chalendar (aka Kleag)  ---
Configuring today a new laptop with KDE Neon, same problem, same solution.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Akonadi] [Bug 393002] Akonadi-ews does not save password in kwallet

[Gaël de Chalendar]

https://bugs.kde.org/show_bug.cgi?id=393002

--- Comment #13 from Gaël de Chalendar (aka Kleag)  ---
Same problem today after expiration of my password. And same solution using the
dbus call.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Akonadi] [Bug 393002] Akonadi-ews does not save password in kwallet

[Gaël de Chalendar]

https://bugs.kde.org/show_bug.cgi?id=393002

Gaël de Chalendar (aka Kleag)  changed:

   What|Removed |Added

 CC||kl...@free.fr

--- Comment #12 from Gaël de Chalendar (aka Kleag)  ---
I had the same problem after having to change my password due to timeout
policy.

I was able to set my password with this dbus call:
qdbus org.freedesktop.Akonadi.Resource.akonadi_ews_resource_4 /Settings
org.kde.Akonadi.Ews.Wallet.setPassword "XXX"

I think that this bug is a real blocker for people in organizations that are
depending on a MS IS architecture.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Akonadi] [Bug 393002] Akonadi-ews does not save password in kwallet

[Aaron Williams]

https://bugs.kde.org/show_bug.cgi?id=393002

Aaron Williams  changed:

   What|Removed |Added

 CC||aar...@doofus.org

--- Comment #11 from Aaron Williams  ---
I just ran into the same issue again. I'm using the latest OpenSUSE release. I
don't know if it's due to special characters in my password or not, but I have
to manually add it to kwallet.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Akonadi] [Bug 393002] Akonadi-ews does not save password in kwallet

[Alexander Olofsson]

https://bugs.kde.org/show_bug.cgi?id=393002

Alexander Olofsson  changed:

   What|Removed |Added

 CC||a...@haxalot.com

--- Comment #10 from Alexander Olofsson  ---
Ran into the same issue here as well after doing system upgrades. PIM 18.12.0

I tried creating a password manually in kwalletmanager as well, but didn't
realize that the title was the resource id followed by 'rc', so of course it
didn't read that one either.

I was able to set a new password as mentioned in
https://bugs.kde.org/show_bug.cgi?id=389369#c5 though, which is what revealed
the naming difference to me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Akonadi] [Bug 393002] Akonadi-ews does not save password in kwallet

[Tom Kijas]

https://bugs.kde.org/show_bug.cgi?id=393002

Tom Kijas  changed:

   What|Removed |Added

 CC||t.ki...@gmail.com

--- Comment #9 from Tom Kijas  ---
I created account in KMail (EWS), opened kwallet manager, added password into
"passwords" in "akonadi-ews" and nothing changed.

In terminal it says Service
'org.freedesktop.Akonadi.Resource.akonadi_ews_resource_5/' is not a valid name.

KMail is totally useless now for work/corporate.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Akonadi] [Bug 393002] Akonadi-ews does not save password in kwallet

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=393002

nlcomputerserv...@gmail.com changed:

   What|Removed |Added

 CC||nlcomputerserv...@gmail.com

--- Comment #8 from nlcomputerserv...@gmail.com ---
I can confirm the exact same issue, KDE neon stable

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Akonadi] [Bug 393002] Akonadi-ews does not save password in kwallet

[Benjamin Buch]

https://bugs.kde.org/show_bug.cgi?id=393002

Benjamin Buch  changed:

   What|Removed |Added

Version|unspecified |GIT (master)

--- Comment #7 from Benjamin Buch  ---
Same here, I use KDE neon git stable branch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Akonadi] [Bug 393002] Akonadi-ews does not save password in kwallet

[Benjamin Buch]

https://bugs.kde.org/show_bug.cgi?id=393002

Benjamin Buch  changed:

   What|Removed |Added

 CC||benni.b...@gmail.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Akonadi] [Bug 393002] Akonadi-ews does not save password in kwallet

[Jan Kriho]

https://bugs.kde.org/show_bug.cgi?id=393002

Jan Kriho  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---
 CC||erbur...@seznam.cz

--- Comment #6 from Jan Kriho  ---
After upgrading to KDE PIM 18.12 I recreated the EWS account, however storing
password into KWallet no longer works.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Akonadi] [Bug 393002] Akonadi-ews does not save password in kwallet

[michele mazza]

https://bugs.kde.org/show_bug.cgi?id=393002

michele mazza  changed:

   What|Removed |Added

 CC||michele.ma...@gmail.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Akonadi] [Bug 393002] Akonadi-ews does not save password in kwallet

[Krzysztof Nowicki]

https://bugs.kde.org/show_bug.cgi?id=393002

Krzysztof Nowicki  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://commits.kde.org/kde
   ||pim-runtime/b5ee6ff11cd3a7e
   ||0c28305b351d28c5f244f101e
 Resolution|--- |FIXED

--- Comment #5 from Krzysztof Nowicki  ---
Git commit b5ee6ff11cd3a7e0c28305b351d28c5f244f101e by Krzysztof Nowicki.
Committed on 29/05/2018 at 10:02.
Pushed by nowicki into branch 'Applications/18.04'.

resources/ews: Fix saving passwords to KWallet

This is a regression after switching to asynchronous wallet
opening. When saving the password the wallet is opened and a callback is
registered to write the password once the wallet is ready. Unfortunately
all this is done in an instance of the EwsSettings class that is local
to the configuration dialog class. This means that this instance is
destroyed once the configuration dialog is dismissed, so when opening
the wallet takes a split second too long the object dies before the
callback has a chance to do its job.

The fix is not to use a local instance of the EwsSettings class in the
configuration dialog and instead work on a pointer to this object kept
by the root resource class, which is alive at all times.

M  +3-2resources/ews/ewsconfigdialog.cpp
M  +4-2resources/ews/ewsconfigdialog.h
M  +1-1resources/ews/ewsresource.cpp

https://commits.kde.org/kdepim-runtime/b5ee6ff11cd3a7e0c28305b351d28c5f244f101e

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Akonadi] [Bug 393002] Akonadi-ews does not save password in kwallet

[Christophe Giboudeaux]

https://bugs.kde.org/show_bug.cgi?id=393002

Christophe Giboudeaux  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED
 CC||kdepim-bugs@kde.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Akonadi] [Bug 393002] Akonadi-ews does not save password in kwallet

[Krzysztof Nowicki]

https://bugs.kde.org/show_bug.cgi?id=393002

Krzysztof Nowicki  changed:

   What|Removed |Added

   Assignee|kdepim-bugs@kde.org |kri...@op.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Akonadi] [Bug 393002] Akonadi-ews does not save password in kwallet

[Christian]

https://bugs.kde.org/show_bug.cgi?id=393002

Christian  changed:

   What|Removed |Added

 CC||gen...@moin.fi

--- Comment #3 from Christian  ---
Bug still present in version 17.12.3 - can't find this version number in the
version dropdown though.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Akonadi] [Bug 393002] Akonadi-ews does not save password in kwallet

[Christian]

https://bugs.kde.org/show_bug.cgi?id=393002

Christian  changed:

   What|Removed |Added

 CC||ereno...@hotmail.com

--- Comment #2 from Christian  ---
*** Bug 389369 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Akonadi] [Bug 393002] Akonadi-ews does not save password in kwallet

[Anders Bolager]

https://bugs.kde.org/show_bug.cgi?id=393002

Anders Bolager  changed:

   What|Removed |Added

 CC||and...@bolager.com

--- Comment #1 from Anders Bolager  ---
It seems I have the same issue. After I examined the kwallet at work (with an
older version of akonadi and the ews client), I found that if I entered an
entry "akonadi_ews_resourceXrc"* to the akonadi-ews main entry in kwallet, the
password field in the configuration is filled out. I still get an 401 error
when trying to fetch the folder list.

* Where X is the resource number

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Akonadi] [Bug 393002] Akonadi-ews does not save password in kwallet

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=393002

4z1...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.