https://bugs.kde.org/show_bug.cgi?id=376073

David Faure <fa...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED
   Version Fixed In|                            |18.04
      Latest Commit|                            |https://commits.kde.org/mai
                   |                            |lcommon/381a28fa201488cea4a
                   |                            |9d7a84f1cf8261d08e8c1

--- Comment #1 from David Faure <fa...@kde.org> ---
Git commit 381a28fa201488cea4a9d7a84f1cf8261d08e8c1 by David Faure.
Committed on 01/12/2017 at 12:52.
Pushed by dfaure into branch 'master'.

Implement reordering of favorite folders using DnD

Summary:
In order to separate favorites from the "entity order" QSFPM
used by the folder tree widget (it was always weird that filtering or
changing the sort order for the folder tree widget would affect favorites),
we need the favorites to get their own "ordering" proxy (otherwise
ordering is random, based on ETM population order). So while at it,
I implemented manual reordering of favorites.
FIXED-IN: 18.04

Test Plan:
I can reorder favorites (in listview mode) using DnD
and the order is persisted

Reviewers: dvratil, mlaurent

Reviewed By: mlaurent

Subscribers: #kde_pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D8884

M  +3    -0    autotests/CMakeLists.txt
A  +131  -0    autotests/favoritestest.cpp     [License: LGPL (v2+)]
M  +2    -0    autotests/unittestenv/config.xml
M  +3    -1    src/CMakeLists.txt
A  +59   -0    src/folder/favoritecollectionorderproxymodel.cpp     [License:
GPL (v2)]
A  +47   -0    src/folder/favoritecollectionorderproxymodel.h     [License: GPL
(v2)]
M  +35   -0    src/widgets/favoritecollectionwidget.cpp
M  +4    -0    src/widgets/favoritecollectionwidget.h

https://commits.kde.org/mailcommon/381a28fa201488cea4a9d7a84f1cf8261d08e8c1

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to