[korganizer] [Bug 356053] Crash if I close the korganizer window while adding a new attachment

[Denis Kurz]

https://bugs.kde.org/show_bug.cgi?id=356053

--- Comment #4 from Denis Kurz  ---
Nice catch, thanks Christoph!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[korganizer] [Bug 356053] Crash if I close the korganizer window while adding a new attachment

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=356053

Christoph Feck  changed:

   What|Removed |Added

   Version Fixed In|5.6.1   |5.7.2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[korganizer] [Bug 356053] Crash if I close the korganizer window while adding a new attachment

[Denis Kurz]

https://bugs.kde.org/show_bug.cgi?id=356053

Denis Kurz  changed:

   What|Removed |Added

   Version Fixed In||5.6.1
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/inc
   ||idenceeditor/c1f5f69291226f
   ||b08d1d744059243f71b91fbacb

--- Comment #3 from Denis Kurz  ---
Git commit c1f5f69291226fb08d1d744059243f71b91fbacb by Denis Kurz.
Committed on 04/02/2018 at 20:12.
Pushed by dkurz into branch 'Applications/17.12'.

Fix use-after-free

Summary:
We now detect if IncidenceAttachment is deleted while the
AttachmentEditDialog is shown. There were three potential crashes
(deletion of item; access to mAttachmentView; call checkDirtyStatus);
the first of them actually was met in the wild in Bug 356053. Fixing
only the deletion of item led to the other two.
FIXED-IN: 5.6.1

Test Plan:
Compiled; repeated the steps described in Bug 356053. The crash
happens without the patch; doesn't happen with the patch.

Reviewers: #kde_pim, dvratil

Reviewed By: #kde_pim, dvratil

Subscribers: winterz

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D7591

M  +10   -8src/incidenceattachment.cpp

https://commits.kde.org/incidenceeditor/c1f5f69291226fb08d1d744059243f71b91fbacb

-- 
You are receiving this mail because:
You are the assignee for the bug.

[korganizer] [Bug 356053] Crash if I close the korganizer window while adding a new attachment

[Denis Kurz]

https://bugs.kde.org/show_bug.cgi?id=356053

Denis Kurz  changed:

   What|Removed |Added

 Ever confirmed|0   |1
  Component|general |incidence editors
 Status|UNCONFIRMED |CONFIRMED
Version|4.13.2  |5.6.0
 CC||kde...@posteo.de

--- Comment #2 from Denis Kurz  ---
Sorry to say, Santhiar, but this bug will not be fixed by us in the version you
used. 4.x versions have been unsupported for several years now.

However, I submitted a patch to phabricator [1] which might be backported by
your distributor. As soon as the patch passes review, you might want to ask
them. I hope that 5.6.1 will be the first released version that contains the
fix.

The bug is still reproducible in 5.6.0, which is why I bothered investigating
it :-P

[1] https://phabricator.kde.org/D7591

-- 
You are receiving this mail because:
You are the assignee for the bug.