Re: [PATCH 6/6] kexec-tools: Use default rpmbuild definations
Am 24.03.2010 12:30, schrieb Simon Horman: On Sat, Mar 20, 2010 at 10:43:49AM +0100, Bernhard Walle wrote: Am 19.03.2010 21:37, schrieb Eric W. Biederman: Ameya Palande 2am...@gmail.com writes: Since current mechanism for building rpm into custom directory is not working, remove it and switch to system defaults for rpmbuild. Does RPM really bit rot that quickly? I know at the time I added the code it was the only way I could get rpm to build an rpm without being root. Something that seems desirable. It works here on openSUSE 11.1 when I change -RPMDIR=rpm +RPMDIR=$(shell pwd)/rpm Of course only after applying the other patches... That seems reasonable to me, care to make it a proper patch? Since 529ad47e356a8e68be9cde771af8e909a784c3fc has been applied which removes that code, this is no longer possible. ;) However, I'm fine with that change. The user can always create a custom ~/.rpmmacros like %_topdir /home/bwalle/src/packages to build the RPM in a local tree. Regards, Bernhard ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
Re: [PATCH] kexec-tools: Fix unused return value warning for fread
On Thu, Mar 25, 2010 at 01:23:53PM +0200, Ameya Palande wrote: On Wed, 2010-03-24 at 12:31 +0100, ext Simon Horman wrote: On Fri, Mar 19, 2010 at 03:55:04PM +0200, Ameya Palande wrote: From: Ameya Palande ameya.pala...@nokia.com Signed-off-by: Ameya Palande ameya.pala...@nokia.com Thanks, applied. BTW, which gcc and CFLAGS were you using to see that warning? I guess -Werror and gcc 4 (I don't know exact version since I was compiling it for arm on a build server). Thanks. Though I don't seem to see them here with a similar (though non-arm) setup. ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
Re: [PATCH 6/6] kexec-tools: Use default rpmbuild definations
On Thu, Mar 25, 2010 at 09:34:52PM +0100, Bernhard Walle wrote: Am 24.03.2010 12:30, schrieb Simon Horman: On Sat, Mar 20, 2010 at 10:43:49AM +0100, Bernhard Walle wrote: Am 19.03.2010 21:37, schrieb Eric W. Biederman: Ameya Palande 2am...@gmail.com writes: Since current mechanism for building rpm into custom directory is not working, remove it and switch to system defaults for rpmbuild. Does RPM really bit rot that quickly? I know at the time I added the code it was the only way I could get rpm to build an rpm without being root. Something that seems desirable. It works here on openSUSE 11.1 when I change -RPMDIR=rpm +RPMDIR=$(shell pwd)/rpm Of course only after applying the other patches... That seems reasonable to me, care to make it a proper patch? Since 529ad47e356a8e68be9cde771af8e909a784c3fc has been applied which removes that code, this is no longer possible. ;) ;) However, I'm fine with that change. The user can always create a custom ~/.rpmmacros like %_topdir /home/bwalle/src/packages to build the RPM in a local tree. Ok, that seems reasonable to me too. ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
