Re: [PATCH] kexec_file: add kexec_file flag to support debug printing
On 03/15/24 at 09:39am, Simon Horman wrote: > On Fri, Mar 15, 2024 at 04:11:50PM +0800, Baoquan He wrote: > > On 11/27/23 at 01:32pm, Simon Horman wrote: > > > On Tue, Nov 14, 2023 at 11:20:30PM +0800, Baoquan He wrote: > > > > This add KEXEC_FILE_DEBUG to kexec_file_flags so that it can be passed > > > > to kernel when '-d' is added with kexec_file_load interface. With that > > > > flag enabled, kernel can enable the debugging message printing. > > > > > > > > Signed-off-by: Baoquan He > > > > > > Thanks, > > > > > > this looks fine to me. > > > But perhaps the corresponding Kernel patch should land first? > > > Let me know what you think. > > > > Ping, the relevant kernel patches landed in mainline kernel, please help > > merge this patch. > > Thanks, applied. Great, thanks a lot. ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
Re: [PATCH] kexec_file: add kexec_file flag to support debug printing
On Fri, Mar 15, 2024 at 04:11:50PM +0800, Baoquan He wrote: > On 11/27/23 at 01:32pm, Simon Horman wrote: > > On Tue, Nov 14, 2023 at 11:20:30PM +0800, Baoquan He wrote: > > > This add KEXEC_FILE_DEBUG to kexec_file_flags so that it can be passed > > > to kernel when '-d' is added with kexec_file_load interface. With that > > > flag enabled, kernel can enable the debugging message printing. > > > > > > Signed-off-by: Baoquan He > > > > Thanks, > > > > this looks fine to me. > > But perhaps the corresponding Kernel patch should land first? > > Let me know what you think. > > Ping, the relevant kernel patches landed in mainline kernel, please help > merge this patch. Thanks, applied. ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
Re: [PATCH] kexec_file: add kexec_file flag to support debug printing
On 11/27/23 at 01:32pm, Simon Horman wrote: > On Tue, Nov 14, 2023 at 11:20:30PM +0800, Baoquan He wrote: > > This add KEXEC_FILE_DEBUG to kexec_file_flags so that it can be passed > > to kernel when '-d' is added with kexec_file_load interface. With that > > flag enabled, kernel can enable the debugging message printing. > > > > Signed-off-by: Baoquan He > > Thanks, > > this looks fine to me. > But perhaps the corresponding Kernel patch should land first? > Let me know what you think. Ping, the relevant kernel patches landed in mainline kernel, please help merge this patch. ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
Re: [PATCH] kexec_file: add kexec_file flag to support debug printing
On 11/27/23 at 01:32pm, Simon Horman wrote: > On Tue, Nov 14, 2023 at 11:20:30PM +0800, Baoquan He wrote: > > This add KEXEC_FILE_DEBUG to kexec_file_flags so that it can be passed > > to kernel when '-d' is added with kexec_file_load interface. With that > > flag enabled, kernel can enable the debugging message printing. > > > > Signed-off-by: Baoquan He > > Thanks, > > this looks fine to me. > But perhaps the corresponding Kernel patch should land first? > Let me know what you think. Yes, agree. I will ping you once kernel patches are taken. Thanks. ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
Re: [PATCH] kexec_file: add kexec_file flag to support debug printing
On Tue, Nov 14, 2023 at 11:20:30PM +0800, Baoquan He wrote: > This add KEXEC_FILE_DEBUG to kexec_file_flags so that it can be passed > to kernel when '-d' is added with kexec_file_load interface. With that > flag enabled, kernel can enable the debugging message printing. > > Signed-off-by: Baoquan He Thanks, this looks fine to me. But perhaps the corresponding Kernel patch should land first? Let me know what you think. ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
[PATCH] kexec_file: add kexec_file flag to support debug printing
This add KEXEC_FILE_DEBUG to kexec_file_flags so that it can be passed to kernel when '-d' is added with kexec_file_load interface. With that flag enabled, kernel can enable the debugging message printing. Signed-off-by: Baoquan He --- kexec/kexec-syscall.h | 1 + kexec/kexec.c | 1 + 2 files changed, 2 insertions(+) diff --git a/kexec/kexec-syscall.h b/kexec/kexec-syscall.h index 2559bffb93da..73e52543e1b0 100644 --- a/kexec/kexec-syscall.h +++ b/kexec/kexec-syscall.h @@ -119,6 +119,7 @@ static inline long kexec_file_load(int kernel_fd, int initrd_fd, #define KEXEC_FILE_UNLOAD 0x0001 #define KEXEC_FILE_ON_CRASH0x0002 #define KEXEC_FILE_NO_INITRAMFS0x0004 +#define KEXEC_FILE_DEBUG 0x0008 /* These values match the ELF architecture values. * Unless there is a good reason that should continue to be the case. diff --git a/kexec/kexec.c b/kexec/kexec.c index 08edfca2349a..b5393e3b20aa 100644 --- a/kexec/kexec.c +++ b/kexec/kexec.c @@ -1477,6 +1477,7 @@ int main(int argc, char *argv[]) return 0; case OPT_DEBUG: kexec_debug = 1; + kexec_file_flags |= KEXEC_FILE_DEBUG; break; case OPT_NOIFDOWN: skip_ifdown = 1; -- 2.41.0 ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
