Re: [PATCH] [PATCH] Move $(LIBS) on the end

2008-08-26 Thread Bernhard Walle
* Yinghai Lu [2008-08-26 01:21]:

 On Tue, Aug 26, 2008 at 1:16 AM, Bernhard Walle [EMAIL PROTECTED] wrote:
  1 file changed, 1 insertion(+), 2 deletions(-)
  kexec/Makefile |3 +--
 
 
  To make static compilation work with
 
 LDFLAGS=-static ./configure
 make
 
 thanks. can you put that two lines into INSTALL.

Adding is not possible since there is no such file. However, I hacked a
small INSTALL file now, I hope that's ok, see the next patch mail.


Bernhard
-- 
Bernhard Walle, SUSE LINUX Products GmbH, Architecture Development

___
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec


Re: [PATCH] [PATCH] Move $(LIBS) on the end

2008-08-26 Thread Bernhard Walle
* Yinghai Lu [2008-08-26 01:40]:

 On Tue, Aug 26, 2008 at 1:34 AM, Bernhard Walle [EMAIL PROTECTED] wrote:
  * Yinghai Lu [2008-08-26 01:21]:
 
  On Tue, Aug 26, 2008 at 1:16 AM, Bernhard Walle [EMAIL PROTECTED] wrote:
   1 file changed, 1 insertion(+), 2 deletions(-)
   kexec/Makefile |3 +--
  
  
   To make static compilation work with
  
  LDFLAGS=-static ./configure
  make
 
  thanks. can you put that two lines into INSTALL.
 
  Adding is not possible since there is no such file. However, I hacked a
  small INSTALL file now, I hope that's ok, see the next patch mail.
 
 
 there is one in the git tree
 
 http://git.kernel.org/?p=linux/kernel/git/horms/kexec-tools.git;a=blob;f=INSTALL;h=e422868c2b9411c38949dd605d674455f96f1ae2;hb=HEAD

Ah, I didn't notice because I used the tarball to create that patch ...
I now merged the two and wrote a patch to actually include that INSTALL
file in the tarball.


Bernhard
-- 
Bernhard Walle, SUSE LINUX Products GmbH, Architecture Development

___
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec


Re: [PATCH] [PATCH] Move $(LIBS) on the end

2008-08-26 Thread Simon Horman
On Tue, Aug 26, 2008 at 10:16:49AM +0200, Bernhard Walle wrote:
 1 file changed, 1 insertion(+), 2 deletions(-)
 kexec/Makefile |3 +--
 
 
 To make static compilation work with
 
 LDFLAGS=-static ./configure
 make
 
 we have to move $(LIBS) on the end of the compiler line. Static compilation 
 has
 been requested by Yinghai Lu [EMAIL PROTECTED]. Although I don't see the
 practical benefit in most cases, I don't think we should not support it. Since
 kexec does not use name resolution functions of libc, it's valid to use static
 linking.
 
 Tested on x86_64-suse-linux.
 
 
 Signed-off-by: Bernhard Walle [EMAIL PROTECTED]

Thanks. I agree that static is entirely sensible for kexec-tools.

Applied


___
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec