[Koha-devel] {Disarmed} Re: Label generator broken?

2009-10-15 Thread Bernard Shiundu
Hi Chris,

Sorry I took so long to get back to you. Just tested. Fixed for layouts + 
profiles but problem still persists for templates. Logs below

1. Log output when I choose a template to edit:

[Thu Oct 15 19:40:46 2009] [error] [client ] [Thu Oct 15 19:40:46 2009] 
label-edit-template.pl: operation = edit, referer: 
http://.../cgi-bin/koha/labels/label-manage.pl?label_element=templatehttp://localhost:8008/cgi-bin/koha/labels/label-manage.pl?label_element=template
[Thu Oct 15 19:40:46 2009] [error] [client ...] [Thu Oct 15 19:40:46 2009] 
label-edit-template.pl: Use of uninitialized value in numeric eq (==) at 
/.../labels/label-edit-template.pl line 103., referer: 
http://.../cgi-bin/koha/labels/label-manage.pl?label_element=templatehttp://localhost:8008/cgi-bin/koha/labels/label-manage.pl?label_element=template

2. Log output on save
[Thu Oct 15 19:41:04 2009] [error] [client ...] [Thu Oct 15 19:41:04 2009] 
label-edit-template.pl: operation = save, referer: 
http:///cgi-bin/koha/labels/label-edit-template.pl?op=editamp;element_id=2http://localhost:8008/cgi-bin/koha/labels/label-edit-template.pl?op=editelement_id=2
[Thu Oct 15 19:41:04 2009] [error] [client ...] [Thu Oct 15 19:41:04 2009] 
label-edit-template.pl: Can't bless non-reference value at 
//C4/Labels/Profile.pm line 89., referer: 
http://localhost:8008/cgi-bin/koha/labels/label-edit-template.pl?op=editamp;element_id=2http://localhost:8008/cgi-bin/koha/labels/label-edit-template.pl?op=editelement_id=2



On Wed, 2009-10-14 at 20:45 +0300, Chris Nighswonger wrote:
Hi Bernard,

On Mon, Oct 12, 2009 at 12:20 PM, Chris Nighswonger 
cnighswon...@foundations.edumailto:cnighswon...@foundations.edu wrote:
On Mon, Oct 12, 2009 at 11:30 AM, Chris Nighswonger

cnighswon...@foundations.edumailto:cnighswon...@foundations.edu wrote:
 On Mon, Oct 12, 2009 at 9:36 AM, Chris Nighswonger
 cnighswon...@foundations.edumailto:cnighswon...@foundations.edu wrote:
 On Mon, Oct 12, 2009 at 5:36 AM, Bernard Shiundu
 bshiu...@strathmore.edumailto:bshiu...@strathmore.edu wrote:
 Still no joy.

 Applied the patch and it sorted out the bug with the printer profiles (they 
 are now saved correctly when editing) however I still have the same error 
 when trying to save templates/layouts after editing and the changes are not 
 saved. The error also comes when creating new templates/layouts - however 
 these are saved.

 Additional info:
 The logs show:
 [Mon Oct 12 12:32:07 2009] [error] [client ...] 
 label-edit-template.plhttp://label-edit-template.pl: Use of uninitialized 
 value in numeric eq (==) at 
 /../labels/label-edit-template.plhttp://label-edit-template.pl line 100., 
 referer: 
 http://../cgi-bin/koha/labels/label-manage.pl?label_element=templatehttp://label-manage.pl?label_element=template
 [Mon Oct 12 12:32:12 2009] [error] [client ...] 
 label-edit-template.plhttp://label-edit-template.pl: Can't bless 
 non-reference value at /.../C4/Labels/Profile.pm line 89., referer: 
 http://.../cgi-bin/koha/labels/label-edit-template.pl?op=editamp;element_id=1http://label-edit-template.pl?op=editamp;element_id=1

 I'm working on a fix for this bug. Would you mind filing a bug report
 at http://bugs.koha.org and include this information?

 Ok, I'm submitting a patch to fix this.

 I'll also file the bug.


Bug 3706 submitted
(http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3706) along
with a patch to fix.

Bernard, If you have time, please apply the patch and test.


I am wondering if you have had time to test if the patches I submitted fixed 
the issues you were having? They have been pushed to the HEAD, so you could get 
them that way as well.

If this does resolve the issue, just let me know so I can close the bug.

Kind Regards,
Chris


Strathmore University provides all-round education in an atmosphere of freedom 
and responsibility.
This email and any files transmitted with it are intended solely for use by the 
recipient(s) to whom it is addressed and may contain confidential information. 
If you have received this email in error please notify the sender immediately 
and permanently delete this email and/or any files attached to it from your 
computer. Please note that any views or opinions presented in this email are 
solely those of the author and do not necessarily represent those of Strathmore 
University. The University accepts no liability whatsoever for any loss or 
damages incurred, or suffered, resulting, or arising, from the use of this 
email and/or its attachments. The University warrants neither the integrity of 
the e-mail nor its freedom from errors, viruses, interception or any other form 
of interference.
….
Website: www.strathmore.edu


___
Koha-devel mailing list
Koha-devel@lists.koha.org
http://lists.koha.org/mailman/listinfo/koha-devel

Re: [Koha-devel] {Disarmed} Re: Label generator broken?

2009-10-15 Thread Chris Nighswonger
Hi Bernard,

On Thu, Oct 15, 2009 at 12:48 PM, Bernard Shiundu
bshiu...@strathmore.eduwrote:

  Hi Chris,

 Sorry I took so long to get back to you. Just tested. Fixed for layouts +
 profiles but problem still persists for templates. Logs below

 1. Log output when I choose a template to edit:

 [Thu Oct 15 19:40:46 2009] [error] [client ] [Thu Oct 15 19:40:46 2009]
 label-edit-template.pl: operation = edit, referer: *MailScanner has
 detected a possible fraud attempt from localhost08 claiming to 
 be*http://.../cgi-bin/koha/labels/label-manage.pl?label_element=templatehttp://localhost:8008/cgi-bin/koha/labels/label-manage.pl?label_element=template
 [Thu Oct 15 19:40:46 2009] [error] [client ...] [Thu Oct 15 19:40:46 2009]
 label-edit-template.pl: Use of uninitialized value in numeric eq (==) at
 /.../labels/label-edit-template.pl line 103., referer: *MailScanner has
 detected a possible fraud attempt from localhost08 claiming to 
 be*http://.../cgi-bin/koha/labels/label-manage.pl?label_element=templatehttp://localhost:8008/cgi-bin/koha/labels/label-manage.pl?label_element=template

 2. Log output on save
 [Thu Oct 15 19:41:04 2009] [error] [client ...] [Thu Oct 15 19:41:04 2009]
 label-edit-template.pl: operation = save, referer: *MailScanner has
 detected a possible fraud attempt from localhost08 claiming to 
 be*http:///cgi-bin/koha/labels/label-edit-template.pl?op=editamp;element_id=2http://localhost:8008/cgi-bin/koha/labels/label-edit-template.pl?op=editelement_id=2
 [Thu Oct 15 19:41:04 2009] [error] [client ...] [Thu Oct 15 19:41:04 2009]
 label-edit-template.pl: Can't bless non-reference value at
 //C4/Labels/Profile.pm line 89., referer: *MailScanner has detected a
 possible fraud attempt from localhost08 claiming to 
 be*http://localhost:8008/cgi-bin/koha/labels/label-edit-template.pl?op=editamp;element_id=2http://localhost:8008/cgi-bin/koha/labels/label-edit-template.pl?op=editelement_id=2


Ok. I found two other places that needed some conditionals and have
submitted a patch for them. This should resolve the issue completely (I
hope). Please test and let me know how it goes.

Kind Regards,
Chris
___
Koha-devel mailing list
Koha-devel@lists.koha.org
http://lists.koha.org/mailman/listinfo/koha-devel

Re: [Koha-devel] {Disarmed} Re: Label generator broken?

2009-10-15 Thread Bernard Shiundu
Thanks Chris,

Grabbed your patch off bugs.koha.org ...
1. New templates now created and saved without croaking.
2. Editing new + existing templates still fails on save

Log output on save:

[Thu Oct 15 23:27:47 2009] [error] [client ...] [Thu Oct 15 23:27:47 2009] 
label-edit-template.pl: Can't bless non-reference value at 
/.../C4/Labels/Profile.pm line 89., referer: 
http://.../cgi-bin/koha/labels/label-edit-template.pl?op=editamp;element_id=9

Regards
Bernard

From: Chris Nighswonger [cnighswon...@foundations.edu]
Sent: Thursday, October 15, 2009 8:41 PM
To: Bernard Shiundu
Cc: Koha Development List
Subject: Re: {Disarmed} Re: [Koha-devel] Label generator broken?

Hi Bernard,

Ok. I found two other places that needed some conditionals and have submitted a 
patch for them. This should resolve the issue completely (I hope). Please test 
and let me know how it goes.

Kind Regards,
Chris







Strathmore University provides all-round education in an atmosphere of freedom 
and responsibility.
This email and any files transmitted with it are intended solely for use by the 
recipient(s) to whom it is addressed and may contain confidential information. 
If you have received this email in error please notify the sender immediately 
and permanently delete this email and/or any files attached to it from your 
computer. Please note that any views or opinions presented in this email are 
solely those of the author and do not necessarily represent those of Strathmore 
University.  The University accepts no liability whatsoever for any loss or 
damages incurred, or suffered, resulting, or arising, from the use of this 
email and/or its attachments.  The University warrants neither the integrity of 
the e-mail nor its freedom from errors, viruses, interception or any other form 
of interference.
….
Website: www.strathmore.edu


___
Koha-devel mailing list
Koha-devel@lists.koha.org
http://lists.koha.org/mailman/listinfo/koha-devel

Re: [Koha-devel] {Disarmed} Re: Label generator broken?

2009-10-15 Thread Chris Nighswonger
On Thu, Oct 15, 2009 at 4:29 PM, Bernard Shiundu bshiu...@strathmore.eduwrote:

 Thanks Chris,

 Grabbed your patch off bugs.koha.org ...
 1. New templates now created and saved without croaking.
 2. Editing new + existing templates still fails on save

 Log output on save:

 [Thu Oct 15 23:27:47 2009] [error] [client ...] [Thu Oct 15 23:27:47 2009]
 label-edit-template.pl: Can't bless non-reference value at
 /.../C4/Labels/Profile.pm line 89., referer: http://
 .../cgi-bin/koha/labels/label-edit-template.pl?op=editamp;element_id=9


Ok, Bernard...

This is the first time I have not been able reproduce the error. So, maybe a
bit more information will help me.

1. What version was this install of Koha at when you first installed it?
(I'm curious if it was installed before the labels re-right.)

2. Can you open a mysql console and send me the results of the following:

SELECT * FROM printers_profile;

I think there might be some corrupt data somewhere.

Kind Regards,
Chris
___
Koha-devel mailing list
Koha-devel@lists.koha.org
http://lists.koha.org/mailman/listinfo/koha-devel