Re: [kopete-devel] Review Request: kconf_update script for the Gaim-Pidgin style conversion
2009/5/15 Raphael Kubo da Costa kub...@gmail.com: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/701/ --- Review request for Kopete. Summary --- The attached patch includes a kconf_update script that changes styleName=Gaim to styleName=Pidgin in the Appearance section of kopeterc. I had never coded in Perl before, but I hope the script is small enough not to have allowed me to screw things up -- besides, I don't know if the regular expression will match if it's being run on Windows (I don't know if kopeterc is separated by \r\n there). This is the first time I've written a kconf_update file too, so I don't know if that's the best ID or those are the correct options. This addresses bug 187192. https://bugs.kde.org/show_bug.cgi?id=187192 Diffs - /trunk/KDE/kdenetwork/kopete/kopete/kconf_update/CMakeLists.txt 967791 /trunk/KDE/kdenetwork/kopete/kopete/kconf_update/kopete-gaim_to_pidgin_style.pl PRE-CREATION /trunk/KDE/kdenetwork/kopete/kopete/kconf_update/kopete-gaim_to_pidgin_style.upd PRE-CREATION Diff: http://reviewboard.kde.org/r/701/diff Testing --- Running the script with a kopeterc with styleName=Gaim correctly renames the entry. Thanks, Raphael Did anyone have time to look at this? This change is pretty harmless and solves a critical bug. I can commit it if that's OK. ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: [kopete-devel] Review Request: kconf_update script for the Gaim-Pidgin style conversion
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/701/#review1157 --- Ship it! I don't know much about perl or update script but if it works you can commit it. - Roman On 2009-05-14 20:48:56, Raphael Kubo da Costa wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/701/ --- (Updated 2009-05-14 20:48:56) Review request for Kopete. Summary --- The attached patch includes a kconf_update script that changes styleName=Gaim to styleName=Pidgin in the Appearance section of kopeterc. I had never coded in Perl before, but I hope the script is small enough not to have allowed me to screw things up -- besides, I don't know if the regular expression will match if it's being run on Windows (I don't know if kopeterc is separated by \r\n there). This is the first time I've written a kconf_update file too, so I don't know if that's the best ID or those are the correct options. This addresses bug 187192. https://bugs.kde.org/show_bug.cgi?id=187192 Diffs - /trunk/KDE/kdenetwork/kopete/kopete/kconf_update/CMakeLists.txt 967791 /trunk/KDE/kdenetwork/kopete/kopete/kconf_update/kopete-gaim_to_pidgin_style.pl PRE-CREATION /trunk/KDE/kdenetwork/kopete/kopete/kconf_update/kopete-gaim_to_pidgin_style.upd PRE-CREATION Diff: http://reviewboard.kde.org/r/701/diff Testing --- Running the script with a kopeterc with styleName=Gaim correctly renames the entry. Thanks, Raphael ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
[kopete-devel] Review Request: kconf_update script for the Gaim-Pidgin style conversion
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/701/ --- Review request for Kopete. Summary --- The attached patch includes a kconf_update script that changes styleName=Gaim to styleName=Pidgin in the Appearance section of kopeterc. I had never coded in Perl before, but I hope the script is small enough not to have allowed me to screw things up -- besides, I don't know if the regular expression will match if it's being run on Windows (I don't know if kopeterc is separated by \r\n there). This is the first time I've written a kconf_update file too, so I don't know if that's the best ID or those are the correct options. This addresses bug 187192. https://bugs.kde.org/show_bug.cgi?id=187192 Diffs - /trunk/KDE/kdenetwork/kopete/kopete/kconf_update/CMakeLists.txt 967791 /trunk/KDE/kdenetwork/kopete/kopete/kconf_update/kopete-gaim_to_pidgin_style.pl PRE-CREATION /trunk/KDE/kdenetwork/kopete/kopete/kconf_update/kopete-gaim_to_pidgin_style.upd PRE-CREATION Diff: http://reviewboard.kde.org/r/701/diff Testing --- Running the script with a kopeterc with styleName=Gaim correctly renames the entry. Thanks, Raphael ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
