Re: [kopete-devel] Review Request: Fix for kopete blank line bug
On 2009-07-10 11:24:36, Matt Rogers wrote: Does a Kopete developer need to commit this, or do you have access to commit it? Welsh_Dwarf wrote: Sorry, I don't have an SVN account (yet...) so I'll need some kind soul to commit it for me :) Committed - Roman --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/768/#review1537 --- On 2009-06-29 04:21:56, Welsh_Dwarf wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/768/ --- (Updated 2009-06-29 04:21:56) Review request for Kopete. Summary --- This patch fixes bug 91409: an empty line is sometimes inserted at the start of a message if the type holds down the enter key for too long. This addresses bug 91409. https://bugs.kde.org/show_bug.cgi?id=91409 Diffs - /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopetechatwindow.h 989078 /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopetechatwindow.cpp 989078 /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopeterichtextwidget.h 989078 /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopeterichtextwidget.cpp 989078 Diff: http://reviewboard.kde.org/r/768/diff Testing --- I've sent test messages using a patched kopete and held down, and repeatedly pressed the enter key to insure that it is no longer possible to insert a blank line at the start of a message. This fixes the bug. A possible complication would be if the user re-configured send to another key and tried to insert a blank line at the start of the message (to do some ascii art or something like that). If such a case arrose, the user would have to put another caracter in fromt (a space or some introductory text) in order to be able to use new lines. Thanks, Welsh_Dwarf ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: [kopete-devel] Review Request: Fix for kopete blank line bug
On 2009-07-10 11:24:36, Matt Rogers wrote: Does a Kopete developer need to commit this, or do you have access to commit it? Sorry, I don't have an SVN account (yet...) so I'll need some kind soul to commit it for me :) - Welsh_Dwarf --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/768/#review1537 --- On 2009-06-29 04:21:56, Welsh_Dwarf wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/768/ --- (Updated 2009-06-29 04:21:56) Review request for Kopete. Summary --- This patch fixes bug 91409: an empty line is sometimes inserted at the start of a message if the type holds down the enter key for too long. This addresses bug 91409. https://bugs.kde.org/show_bug.cgi?id=91409 Diffs - /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopetechatwindow.h 989078 /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopetechatwindow.cpp 989078 /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopeterichtextwidget.h 989078 /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopeterichtextwidget.cpp 989078 Diff: http://reviewboard.kde.org/r/768/diff Testing --- I've sent test messages using a patched kopete and held down, and repeatedly pressed the enter key to insure that it is no longer possible to insert a blank line at the start of a message. This fixes the bug. A possible complication would be if the user re-configured send to another key and tried to insert a blank line at the start of the message (to do some ascii art or something like that). If such a case arrose, the user would have to put another caracter in fromt (a space or some introductory text) in order to be able to use new lines. Thanks, Welsh_Dwarf ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: [kopete-devel] Review Request: Fix for kopete blank line bug
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/768/#review1537 --- Ship it! Does a Kopete developer need to commit this, or do you have access to commit it? - Matt On 2009-06-29 04:21:56, Welsh_Dwarf wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/768/ --- (Updated 2009-06-29 04:21:56) Review request for Kopete. Summary --- This patch fixes bug 91409: an empty line is sometimes inserted at the start of a message if the type holds down the enter key for too long. This addresses bug 91409. https://bugs.kde.org/show_bug.cgi?id=91409 Diffs - /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopetechatwindow.h 989078 /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopetechatwindow.cpp 989078 /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopeterichtextwidget.h 989078 /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopeterichtextwidget.cpp 989078 Diff: http://reviewboard.kde.org/r/768/diff Testing --- I've sent test messages using a patched kopete and held down, and repeatedly pressed the enter key to insure that it is no longer possible to insert a blank line at the start of a message. This fixes the bug. A possible complication would be if the user re-configured send to another key and tried to insert a blank line at the start of the message (to do some ascii art or something like that). If such a case arrose, the user would have to put another caracter in fromt (a space or some introductory text) in order to be able to use new lines. Thanks, Welsh_Dwarf ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: [kopete-devel] Review Request: Fix for kopete blank line bug
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/768/ --- (Updated 2009-06-29 04:21:56.753258) Review request for Kopete. Changes --- Updated diff Summary --- This patch fixes bug 91409: an empty line is sometimes inserted at the start of a message if the type holds down the enter key for too long. This addresses bug 91409. https://bugs.kde.org/show_bug.cgi?id=91409 Diffs (updated) - /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopetechatwindow.h 989078 /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopetechatwindow.cpp 989078 /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopeterichtextwidget.h 989078 /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopeterichtextwidget.cpp 989078 Diff: http://reviewboard.kde.org/r/768/diff Testing --- I've sent test messages using a patched kopete and held down, and repeatedly pressed the enter key to insure that it is no longer possible to insert a blank line at the start of a message. This fixes the bug. A possible complication would be if the user re-configured send to another key and tried to insert a blank line at the start of the message (to do some ascii art or something like that). If such a case arrose, the user would have to put another caracter in fromt (a space or some introductory text) in order to be able to use new lines. Thanks, Welsh_Dwarf ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: [kopete-devel] Review Request: Fix for kopete blank line bug
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/768/#review1418 --- Ship it! looks good to me. - Matt On 2009-06-29 04:21:56, Welsh_Dwarf wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/768/ --- (Updated 2009-06-29 04:21:56) Review request for Kopete. Summary --- This patch fixes bug 91409: an empty line is sometimes inserted at the start of a message if the type holds down the enter key for too long. This addresses bug 91409. https://bugs.kde.org/show_bug.cgi?id=91409 Diffs - /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopetechatwindow.h 989078 /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopetechatwindow.cpp 989078 /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopeterichtextwidget.h 989078 /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopeterichtextwidget.cpp 989078 Diff: http://reviewboard.kde.org/r/768/diff Testing --- I've sent test messages using a patched kopete and held down, and repeatedly pressed the enter key to insure that it is no longer possible to insert a blank line at the start of a message. This fixes the bug. A possible complication would be if the user re-configured send to another key and tried to insert a blank line at the start of the message (to do some ascii art or something like that). If such a case arrose, the user would have to put another caracter in fromt (a space or some introductory text) in order to be able to use new lines. Thanks, Welsh_Dwarf ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: [kopete-devel] Review Request: Fix for kopete blank line bug
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/768/ --- (Updated 2009-06-28 08:53:25.711046) Review request for Kopete. Changes --- Final version. Summary --- This patch fixes bug 91409: an empty line is sometimes inserted at the start of a message if the type holds down the enter key for too long. This addresses bug 91409. https://bugs.kde.org/show_bug.cgi?id=91409 Diffs (updated) - /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopeterichtextwidget.cpp 988755 /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopeterichtextwidget.h 988755 /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopetechatwindow.h 988755 /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopetechatwindow.cpp 988755 Diff: http://reviewboard.kde.org/r/768/diff Testing --- I've sent test messages using a patched kopete and held down, and repeatedly pressed the enter key to insure that it is no longer possible to insert a blank line at the start of a message. This fixes the bug. A possible complication would be if the user re-configured send to another key and tried to insert a blank line at the start of the message (to do some ascii art or something like that). If such a case arrose, the user would have to put another caracter in fromt (a space or some introductory text) in order to be able to use new lines. Thanks, Welsh_Dwarf ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: [kopete-devel] Review Request: Fix for kopete blank line bug
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/768/ --- (Updated 2009-06-24 00:31:09.728092) Review request for Kopete. Changes --- This is the current state of my patch. Notes: -I still need to add the code to update the sendkeysequence when the shortcut changes -I've noticed that there are KDE equivalents of QKeySequence and QAction, should I use those instead of the QT ones? Summary --- This patch fixes bug 91409: an empty line is sometimes inserted at the start of a message if the type holds down the enter key for too long. This addresses bug 91409. https://bugs.kde.org/show_bug.cgi?id=91409 Diffs (updated) - /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopetechatwindow.h 985405 /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopetechatwindow.cpp 985405 /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopeterichtextwidget.h 985405 /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopeterichtextwidget.cpp 985405 Diff: http://reviewboard.kde.org/r/768/diff Testing --- I've sent test messages using a patched kopete and held down, and repeatedly pressed the enter key to insure that it is no longer possible to insert a blank line at the start of a message. This fixes the bug. A possible complication would be if the user re-configured send to another key and tried to insert a blank line at the start of the message (to do some ascii art or something like that). If such a case arrose, the user would have to put another caracter in fromt (a space or some introductory text) in order to be able to use new lines. Thanks, Welsh_Dwarf ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: [kopete-devel] Review Request: Fix for kopete blank line bug
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/768/#review1374 --- I seen various messages about this on the mailing list. Is this ready to be committed? - Matt On 2009-05-31 08:13:12, Welsh_Dwarf wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/768/ --- (Updated 2009-05-31 08:13:12) Review request for Kopete. Summary --- This patch fixes bug 91409: an empty line is sometimes inserted at the start of a message if the type holds down the enter key for too long. This addresses bug 91409. https://bugs.kde.org/show_bug.cgi?id=91409 Diffs - /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopeterichtextwidget.h 974406 /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopeterichtextwidget.cpp 974406 Diff: http://reviewboard.kde.org/r/768/diff Testing --- I've sent test messages using a patched kopete and held down, and repeatedly pressed the enter key to insure that it is no longer possible to insert a blank line at the start of a message. This fixes the bug. A possible complication would be if the user re-configured send to another key and tried to insert a blank line at the start of the message (to do some ascii art or something like that). If such a case arrose, the user would have to put another caracter in fromt (a space or some introductory text) in order to be able to use new lines. Thanks, Welsh_Dwarf ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: [kopete-devel] Review Request: Fix for kopete blank line bug
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/768/ --- (Updated 2009-05-31 07:59:26.052800) Review request for Kopete. Changes --- I've re-written the patch based on Ronan's recommendations. Summary --- This patch fixes bug 91409: an empty line is sometimes inserted at the start of a message if the type holds down the enter key for too long. This addresses bug 91409. https://bugs.kde.org/show_bug.cgi?id=91409 Diffs (updated) - /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chattexteditpart.cpp 974406 /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopeterichtextwidget.h 974406 /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopeterichtextwidget.cpp 974406 Diff: http://reviewboard.kde.org/r/768/diff Testing --- I've sent test messages using a patched kopete and held down, and repeatedly pressed the enter key to insure that it is no longer possible to insert a blank line at the start of a message. This fixes the bug. A possible complication would be if the user re-configured send to another key and tried to insert a blank line at the start of the message (to do some ascii art or something like that). If such a case arrose, the user would have to put another caracter in fromt (a space or some introductory text) in order to be able to use new lines. Thanks, Welsh_Dwarf ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: [kopete-devel] Review Request: Fix for kopete blank line bug
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/768/ --- (Updated 2009-05-31 08:10:29.921145) Review request for Kopete. Summary --- This patch fixes bug 91409: an empty line is sometimes inserted at the start of a message if the type holds down the enter key for too long. This addresses bug 91409. https://bugs.kde.org/show_bug.cgi?id=91409 Diffs (updated) - /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopeterichtextwidget.h 974406 /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopeterichtextwidget.cpp 974406 Diff: http://reviewboard.kde.org/r/768/diff Testing --- I've sent test messages using a patched kopete and held down, and repeatedly pressed the enter key to insure that it is no longer possible to insert a blank line at the start of a message. This fixes the bug. A possible complication would be if the user re-configured send to another key and tried to insert a blank line at the start of the message (to do some ascii art or something like that). If such a case arrose, the user would have to put another caracter in fromt (a space or some introductory text) in order to be able to use new lines. Thanks, Welsh_Dwarf ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: [kopete-devel] Review Request: Fix for kopete blank line bug
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/768/ --- (Updated 2009-05-31 08:13:12.023969) Review request for Kopete. Summary --- This patch fixes bug 91409: an empty line is sometimes inserted at the start of a message if the type holds down the enter key for too long. This addresses bug 91409. https://bugs.kde.org/show_bug.cgi?id=91409 Diffs (updated) - /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopeterichtextwidget.h 974406 /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopeterichtextwidget.cpp 974406 Diff: http://reviewboard.kde.org/r/768/diff Testing --- I've sent test messages using a patched kopete and held down, and repeatedly pressed the enter key to insure that it is no longer possible to insert a blank line at the start of a message. This fixes the bug. A possible complication would be if the user re-configured send to another key and tried to insert a blank line at the start of the message (to do some ascii art or something like that). If such a case arrose, the user would have to put another caracter in fromt (a space or some introductory text) in order to be able to use new lines. Thanks, Welsh_Dwarf ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: [kopete-devel] Review Request: Fix for kopete blank line bug
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/768/#review1243 --- Hm, looks like I've mislead you (and you didn't test the patch :P ) The keysequence has to be taken from action collection from KopeteChatWindow so you have to set it in KopeteChatWindow::setActiveView So in setActiveView you should add something like m_activeView-editPart()-textEdit()-setSendKeySequence( theSequence ); Also we may in KopeteChatWindow check if the send action has changed (the key sequence) with something like connect( sendAction, SIGNAL(changed()), this, SLOT(updateSendKeySequence()) ); and in KopeteChatWindow::updateSendKeySequence call the m_activeView-editPart()-textEdit()-setSendKeySequence too - Roman On 2009-05-31 08:13:12, Welsh_Dwarf wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/768/ --- (Updated 2009-05-31 08:13:12) Review request for Kopete. Summary --- This patch fixes bug 91409: an empty line is sometimes inserted at the start of a message if the type holds down the enter key for too long. This addresses bug 91409. https://bugs.kde.org/show_bug.cgi?id=91409 Diffs - /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopeterichtextwidget.h 974406 /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopeterichtextwidget.cpp 974406 Diff: http://reviewboard.kde.org/r/768/diff Testing --- I've sent test messages using a patched kopete and held down, and repeatedly pressed the enter key to insure that it is no longer possible to insert a blank line at the start of a message. This fixes the bug. A possible complication would be if the user re-configured send to another key and tried to insert a blank line at the start of the message (to do some ascii art or something like that). If such a case arrose, the user would have to put another caracter in fromt (a space or some introductory text) in order to be able to use new lines. Thanks, Welsh_Dwarf ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: [kopete-devel] Review Request: Fix for kopete blank line bug
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/768/ --- (Updated 2009-05-29 04:52:23.574751) Review request for Kopete. Changes --- Fixed the branch tag Summary --- This patch fixes bug 91409: an empty line is sometimes inserted at the start of a message if the type holds down the enter key for too long. This addresses bug 91409. https://bugs.kde.org/show_bug.cgi?id=91409 Diffs - kdenetwork/kopete/kopete/chatwindow/chattexteditpart.cpp 973260 Diff: http://reviewboard.kde.org/r/768/diff Testing --- I've sent test messages using a patched kopete and held down, and repeatedly pressed the enter key to insure that it is no longer possible to insert a blank line at the start of a message. This fixes the bug. A possible complication would be if the user re-configured send to another key and tried to insert a blank line at the start of the message (to do some ascii art or something like that). If such a case arrose, the user would have to put another caracter in fromt (a space or some introductory text) in order to be able to use new lines. Thanks, Welsh_Dwarf ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: [kopete-devel] Review Request: Fix for kopete blank line bug
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/768/#review1219 --- Hi, you somehow added wrong path for the diff so the diff isn't shown. Here's the review: The QString txt = text( Qt::PlainText ); in slotTextChanged is redundant. I think it would be better to fix it in KopeteRichTextWidget::event. I suggest to add keyEvent-key() == Qt::Key_Return || keyEvent-key() == Qt::Key_Enter also for Press or Release event (depends on which on we should override). The best thing would be to get action keysequence for chat_send from d-actionCollection and cache it and then use it in KopeteRichTextWidget::event - Roman On 2009-05-26 12:56:52, Welsh_Dwarf wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/768/ --- (Updated 2009-05-26 12:56:52) Review request for Kopete. Summary --- This patch fixes bug 91409: an empty line is sometimes inserted at the start of a message if the type holds down the enter key for too long. This addresses bug 91409. https://bugs.kde.org/show_bug.cgi?id=91409 Diffs - kdenetwork/kopete/kopete/chatwindow/chattexteditpart.cpp 973260 Diff: http://reviewboard.kde.org/r/768/diff Testing --- I've sent test messages using a patched kopete and held down, and repeatedly pressed the enter key to insure that it is no longer possible to insert a blank line at the start of a message. This fixes the bug. A possible complication would be if the user re-configured send to another key and tried to insert a blank line at the start of the message (to do some ascii art or something like that). If such a case arrose, the user would have to put another caracter in fromt (a space or some introductory text) in order to be able to use new lines. Thanks, Welsh_Dwarf ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
