Re: XMPP Patches
On Friday 02 February 2018 13:00:12 Shawn Sörbom wrote: > On Friday, February 2, 2018 12:41:41 PM PST Pali Rohár wrote: > > On Friday 02 February 2018 12:25:18 Shawn Sörbom wrote: > > > find_qjson.diff: Xmpp was missing a required dependency in its build > > > script - I added it. > > > > Seems this patch is not needed anymore. Wrong/old configuration for > > QJSON was already removed from kopete git. > > At the time, I wrote these patches against kf5-master, which has since been > merged(?) Wasn't aware the issue has been fixed. I will pull and rebuild :) Fix is by Michael Palimaka and it was committed at 2018-02-02 13:47:36. So its new change. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: PGP signature
Re: XMPP Patches
On Friday 02 February 2018 21:41:41 Pali Rohár wrote: > > disable-libjingle: Unfortunately fixing the xmpp issue also enabled > > libjingle, > > which caused the compiler to error out, so I set the default to disabled. > > I'm going to look at this problem. libjingle should build fine. Should be fixed in git master. Compilation with libjingle should work fine. I tested voice call on localhost with two jabber accounts and I sound works too! -- Pali Rohár pali.ro...@gmail.com signature.asc Description: PGP signature
Re: XMPP Patches
On Friday, February 2, 2018 12:41:41 PM PST Pali Rohár wrote: > Hi! > > On Friday 02 February 2018 12:25:18 Shawn Sörbom wrote: > > Hi, > > My mail to kde.org keeps getting bounced, but I would like to have this on > > record anyway. I found some issues with Jabber in kopetes build scripts. > > Im > > including the patches to fix them. > > > > find_qjson.diff: Xmpp was missing a required dependency in its build > > script - I added it. > > Seems this patch is not needed anymore. Wrong/old configuration for > QJSON was already removed from kopete git. > > > disable-libjingle: Unfortunately fixing the xmpp issue also enabled > > libjingle, which caused the compiler to error out, so I set the default > > to disabled. > I'm going to look at this problem. libjingle should build fine. > > > XMPP Now builds! Vive open chat protocols! At the time, I wrote these patches against kf5-master, which has since been merged(?) Wasn't aware the issue has been fixed. I will pull and rebuild :)
Re: XMPP Patches
Hi! On Friday 02 February 2018 12:25:18 Shawn Sörbom wrote: > Hi, > My mail to kde.org keeps getting bounced, but I would like to have this on > record anyway. I found some issues with Jabber in kopetes build scripts. Im > including the patches to fix them. > > find_qjson.diff: Xmpp was missing a required dependency in its build script - > I > added it. Seems this patch is not needed anymore. Wrong/old configuration for QJSON was already removed from kopete git. > disable-libjingle: Unfortunately fixing the xmpp issue also enabled > libjingle, > which caused the compiler to error out, so I set the default to disabled. I'm going to look at this problem. libjingle should build fine. > XMPP Now builds! Vive open chat protocols! -- Pali Rohár pali.ro...@gmail.com signature.asc Description: PGP signature
