Re: Build regressions/improvements in v4.2-rc8

2015-08-24 Thread Geert Uytterhoeven
On Mon, Aug 24, 2015 at 10:34 AM, Geert Uytterhoeven
ge...@linux-m68k.org wrote:
 JFYI, when comparing v4.2-rc8[1] to v4.2-rc7[3], the summaries are:
   - build errors: +4/-7

4 regressions:
  + /home/kisskb/slave/src/include/linux/kvm_host.h: error: array
subscript is above array bounds [-Werror=array-bounds]:  = 430:19
(arch/powerpc/kvm/book3s_64_mmu.c: In function 'kvmppc_mmu
_book3s_64_tlbie':)

powerpc-randconfig (seen before in a v3.15-rc1 build?)

  + error: initramfs.c: undefined reference to `__stack_chk_guard':
= .init.text+0x1cb0)
(init/built-in.o: In function `parse_header':)

x86_64-randconfig

  + error: pci.c: undefined reference to `pci_ioremap_io':  = .init.text+0x3c4)
(arch/arm/mach-versatile/built-in.o: In function `pci_versatile_setup')

arm-randconfig

 [1] http://kisskb.ellerman.id.au/kisskb/head/9289/ (253 out of 254 configs)
 [3] http://kisskb.ellerman.id.au/kisskb/head/9260/ (253 out of 254 configs)

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say programmer or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line unsubscribe kvm-ppc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH trivial] KVM: s390: Spelling s/intance/instance/

2015-03-09 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be
---
 arch/s390/kvm/kvm-s390.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/s390/kvm/kvm-s390.h b/arch/s390/kvm/kvm-s390.h
index fda3f3146eb636d3..83f32a147d72c0f3 100644
--- a/arch/s390/kvm/kvm-s390.h
+++ b/arch/s390/kvm/kvm-s390.h
@@ -125,7 +125,7 @@ static inline void kvm_s390_set_psw_cc(struct kvm_vcpu 
*vcpu, unsigned long cc)
vcpu-arch.sie_block-gpsw.mask |= cc  44;
 }
 
-/* test availability of facility in a kvm intance */
+/* test availability of facility in a kvm instance */
 static inline int test_kvm_facility(struct kvm *kvm, unsigned long nr)
 {
return __test_facility(nr, kvm-arch.model.fac-mask) 
-- 
1.9.1

--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


mips: Accidental removal of paravirt_cpus_done?

2014-06-13 Thread Geert Uytterhoeven
Hi Ralf,

It seems you accidentally assimilated an (unwanted?) kvm change in my
patch:

On Tue, Jun 10, 2014 at 3:31 AM, Linux Kernel Mailing List
linux-ker...@vger.kernel.org wrote:
 Gitweb: 
 http://git.kernel.org/linus/;a=commit;h=5e888e8fb55cf3da870b85d04fef6bfe0d57c974
 Commit: 5e888e8fb55cf3da870b85d04fef6bfe0d57c974
 Parent: a1eace4ba53546bc7a6670b1c380cd5c1287ae8b
 Refname:refs/heads/master
 Author: Geert Uytterhoeven ge...@linux-m68k.org
 AuthorDate: Tue Apr 22 12:51:13 2014 +0200
 Committer:  Ralf Baechle r...@linux-mips.org
 CommitDate: Mon Jun 2 16:34:41 2014 +0200

 mips: Update the email address of Geert Uytterhoeven

 All my Sony addresses are defunct.

 Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org
 Cc: linux-m...@linux-mips.org
 Patchwork: https://patchwork.linux-mips.org/patch/6817/
 Signed-off-by: Ralf Baechle r...@linux-mips.org
 ---
  arch/mips/include/asm/nile4.h |2 +-
  arch/mips/paravirt/paravirt-smp.c |5 -
  arch/mips/pci/ops-pmcmsp.c|2 +-
  arch/mips/pci/ops-tx3927.c|2 +-
  4 files changed, 3 insertions(+), 8 deletions(-)

 diff --git a/arch/mips/paravirt/paravirt-smp.c 
 b/arch/mips/paravirt/paravirt-smp.c
 index 73a123e..0164b0c 100644
 --- a/arch/mips/paravirt/paravirt-smp.c
 +++ b/arch/mips/paravirt/paravirt-smp.c
 @@ -99,10 +99,6 @@ static void paravirt_smp_finish(void)
 local_irq_enable();
  }

 -static void paravirt_cpus_done(void)
 -{
 -}
 -
  static void paravirt_boot_secondary(int cpu, struct task_struct *idle)
  {
 paravirt_smp_gp[cpu] = (unsigned long)task_thread_info(idle);
 @@ -141,7 +137,6 @@ struct plat_smp_ops paravirt_smp_ops = {
 .send_ipi_mask  = paravirt_send_ipi_mask,
 .init_secondary = paravirt_init_secondary,
 .smp_finish = paravirt_smp_finish,
 -   .cpus_done  = paravirt_cpus_done,
 .boot_secondary = paravirt_boot_secondary,
 .smp_setup  = paravirt_smp_setup,
 .prepare_cpus   = paravirt_prepare_cpus,

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say programmer or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH -next] ia64, metag: Do not export min_low_pfn in arch-specific code

2013-04-27 Thread Geert Uytterhoeven
As of commit 787dcbe6984b3638e94f60d807dcb51bb8a07211 (MIPS: Export
symbols used by KVM/MIPS module), min_low_pfn is already exported by
the generic mm/bootmem.c, causing:

WARNING: vmlinux: 'min_low_pfn' exported twice. Previous export was in vmlinux

Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org
---
 arch/ia64/kernel/ia64_ksyms.c   |1 -
 arch/metag/kernel/metag_ksyms.c |1 -
 2 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/arch/ia64/kernel/ia64_ksyms.c b/arch/ia64/kernel/ia64_ksyms.c
index 5b7791d..ca95c8b 100644
--- a/arch/ia64/kernel/ia64_ksyms.c
+++ b/arch/ia64/kernel/ia64_ksyms.c
@@ -25,7 +25,6 @@ EXPORT_SYMBOL(copy_page);
 
 #ifdef CONFIG_VIRTUAL_MEM_MAP
 #include linux/bootmem.h
-EXPORT_SYMBOL(min_low_pfn);/* defined by bootmem.c, but not exported by 
generic code */
 EXPORT_SYMBOL(max_low_pfn);/* defined by bootmem.c, but not exported by 
generic code */
 #endif
 
diff --git a/arch/metag/kernel/metag_ksyms.c b/arch/metag/kernel/metag_ksyms.c
index ec872ef..08e9b6f 100644
--- a/arch/metag/kernel/metag_ksyms.c
+++ b/arch/metag/kernel/metag_ksyms.c
@@ -12,7 +12,6 @@ EXPORT_SYMBOL(copy_page);
 #ifdef CONFIG_FLATMEM
 /* needed for the pfn_valid macro */
 EXPORT_SYMBOL(max_pfn);
-EXPORT_SYMBOL(min_low_pfn);
 #endif
 
 /* TBI symbols */
-- 
1.7.0.4

--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] x86: Add a Kconfig shortcut for a kvm-bootable kernel

2013-04-18 Thread Geert Uytterhoeven
On Thu, Apr 18, 2013 at 11:46 AM, Borislav Petkov b...@alien8.de wrote:
 ok, maybe I wasn't clear enough. My proposal was to actually add all (or
 maybe not *all* of them, but most) those selects above to the KVM_GUEST
 config option. Because, you very probably want to select all that stuff
 above anyway if you want to build a kvm guest kernel, no?

 IOW, something which says Enable KVM guest support should enable all
 the stuff needed for that.

needed yes,
probably no, as there's no way to disable them if they're selected
unconditionally.

Perhaps you can make the probably selects depend on !EXPERT to fix this?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say programmer or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: usr/include/linux/kvm_para.h:26: included file 'asm-m68k/kvm_para.h' is not exported

2012-10-03 Thread Geert Uytterhoeven
On Wed, Oct 3, 2012 at 3:44 AM, Fengguang Wu fengguang...@intel.com wrote:
 FYI, something goes wrong since

 commit: 2bbc89a8e9c652ee71c6c3b2e0679b7ecedb1a09  m68k: Use Kbuild logic to 
 import asm-generic headers
 config: m68k-allmodconfig

 All error/warnings:

 usr/include/linux/kexec.h:49: userspace cannot reference function or variable 
 defined in the kernel
 usr/include/linux/kvm_para.h:26: included file 'asm-m68k/kvm_para.h' is not 
 exported
 usr/include/linux/soundcard.h:1054: userspace cannot reference function or 
 variable defined in the kernel

Yes, this is a known issue, cfr. e.g. https://lkml.org/lkml/2012/9/16/77
The kvm and kbuild people have to get their act together and agree on
a solution.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say programmer or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] powerpc/epapr: export epapr_hypercall_start

2012-08-11 Thread Geert Uytterhoeven
On Sat, Aug 11, 2012 at 12:21 AM, Scott Wood scottw...@freescale.com wrote:
 +EXPORT_SYMBOL(epapr_hypercall_start);

EXPORT_SYMBOL_GPL?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say programmer or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] powerpc/epapr: export epapr_hypercall_start

2012-08-11 Thread Geert Uytterhoeven
On Sat, Aug 11, 2012 at 12:21 AM, Scott Wood scottw...@freescale.com wrote:
 +EXPORT_SYMBOL(epapr_hypercall_start);

EXPORT_SYMBOL_GPL?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say programmer or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line unsubscribe kvm-ppc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: asm/kvm_para.h from asm-generic (was: Re: linux-next: triage for April 19, 2012)

2012-06-13 Thread Geert Uytterhoeven
On Tue, Jun 12, 2012 at 11:07 PM, Geert Uytterhoeven
ge...@linux-m68k.org wrote:
 On Wed, May 30, 2012 at 10:52 AM, Geert Uytterhoeven
 ge...@linux-m68k.org wrote:
 On Mon, May 28, 2012 at 5:04 PM, Geert Uytterhoeven
 ge...@linux-m68k.org wrote:
 On Mon, May 28, 2012 at 4:37 PM, Avi Kivity a...@redhat.com wrote:
 On 05/25/2012 11:59 PM, Geert Uytterhoeven wrote:
 On Fri, Apr 20, 2012 at 4:00 AM, Paul Gortmaker
 paul.gortma...@windriver.com wrote:
 The parisc got borked by some kvm header shuffle it seems?
 Now complaining about file 'asm-generic/kvm_para.h' is not exported
 [ http://kisskb.ellerman.id.au/kisskb/buildresult/6137786/ ]

 Not only parisc.

 This breakage has now entered mainline:

 parisc deconfig http://kisskb.ellerman.id.au/kisskb/buildresult/6365677/
 m68k allmodconfig: 
 http://kisskb.ellerman.id.au/kisskb/buildresult/6365681/


 Does the following patch help?

 Thanks, that fixes it!

 Tested-by: Geert Uytterhoeven ge...@linux-m68k.org

 From: Avi Kivity a...@redhat.com
 Date: Mon, 28 May 2012 17:35:22 +0300
 Subject: [PATCH] KVM: Export asm-generic/kvm_para.h

 Prevents build failures on non-KVM archs.

 Signed-off-by: Avi Kivity a...@redhat.com
 ---
  include/asm-generic/Kbuild |    1 +
  1 file changed, 1 insertion(+)

 diff --git a/include/asm-generic/Kbuild b/include/asm-generic/Kbuild
 index 53f91b1..2c85a0f 100644
 --- a/include/asm-generic/Kbuild
 +++ b/include/asm-generic/Kbuild
 @@ -8,6 +8,7 @@ header-y += int-ll64.h
  header-y += ioctl.h
  header-y += ioctls.h
  header-y += ipcbuf.h
 +header-y += kvm_para.h
  header-y += mman-common.h
  header-y += mman.h
  header-y += msgbuf.h

 I just noticed include/asm-generic/Kbuild.asm already had

 ifneq ($(wildcard $(srctree)/arch/$(SRCARCH)/include/asm/kvm_para.h \
                  $(srctree)/include/asm-$(SRCARCH)/kvm_para.h),)
 header-y  += kvm_para.h
 endif

 but this doesn't seem to work.

 Kbuild people: which one is correct?

 Oops...

 After linux-next commit 2bbc89a8e9c652ee71c6c3b2e0679b7ecedb1a09
 (m68k: Use Kbuild logic to import asm-generic headers), which does:
  - remove arch/m68k/include/asm/kvm_para.h, which just included the
    asm-generic version,
  - add generic-y += kvm_para.h to arch/m68k/include/asm/Kbuild,
 it fails again:

 $ make ARCH=m68k headers_check
  CHK     include/linux/version.h
  INSTALL include/asm-generic (35 files)
  INSTALL include/linux (372 files)
  CHECK   include/asm-generic (35 files)
  CHECK   include/linux (372 files)
 usr/include/linux/kexec.h:49: userspace cannot reference function or
 variable defined in the kernel
 usr/include/linux/kvm_para.h:26: included file 'asm-m68k/kvm_para.h'
 is not exported
 usr/include/linux/soundcard.h:1054: userspace cannot reference
 function or variable defined in the kernel
 make[2]: *** [usr/include/linux/.check] Error 123
 make[1]: *** [linux] Error 2
 make: *** [headers_check] Error 2
 $

 After reverting Avi's fix (commit
 7beb8e723c8d7da7decbbe217b79525aef73fccb. (KVM:
 Export asm-generic/kvm_para.h)) it works again. Note that it now _removes_
 kvm_para.h:

 $ make ARCH=m68k headers_check
  CHK     include/linux/version.h
  REMOVE  kvm_para.h
  INSTALL include/asm-generic (34 files)
  REMOVE  kvm_para.h
  INSTALL include/linux (371 files)
  CHECK   include/asm-generic (34 files)
  CHECK   include/linux (371 files)
 usr/include/linux/kexec.h:49: userspace cannot reference function or
 variable defined in the kernel
 usr/include/linux/soundcard.h:1054: userspace cannot reference
 function or variable defined in the kernel
 $

 What's the proper way to get this working in both cases??
  1. arch has it's own asm/kvm_para.h (cfr. m68k and all other arches
 in mainline)
  2. arch includes asm-generic/kvm_para.h via Kbuild logic (cfr.
 (only) m68k in -next)
 Or is this not possible, and should I create arch/m68k/include/asm/kvm_para.h
 again, like all other arches seem to do?

I dived into this, and spent a little more time on it than is healthy for me :-(

make headers_check is also broken on m32r since Avi's fix, as m32r
doesn't even
have asm/kvm_param.h:

| usr/include/linux/kvm_para.h:26: included file 'asm-m32r/kvm_para.h'
is not exported

commit 3b5d56b9317fa7b5407dff1aa7b115bf6cdbd494 (kvmclock: Add functions to
check if the host has stopped the vm) created asm/kvm_para.h for
all architectures,
but forgot cris and m32r.

BTW, do we really want all these asm/kvm_para.h pointing to (empty)
asm-generic/kvm_para.h after exporting?

commit 7dcf2a9fced59e58e4694cdcf15850c01fdba89b (remove dummy asm/kvm.h files)
removed the similar dummy asm/kvm.h files, and added a rule to
include/asm-generic/Kbuild.asm instead:

ifneq ($(wildcard $(srctree)/arch/$(SRCARCH)/include/asm/kvm.h \
  $(srctree)/include/asm-$(SRCARCH)/kvm.h),)
header-y  += kvm.h
endif

There's a similar rule for kvm_para.h:

ifneq ($(wildcard $(srctree)/arch/$(SRCARCH)/include/asm/kvm_para.h \
  $(srctree)/include/asm-$(SRCARCH)/kvm_para.h),)
header-y

Re: asm/kvm_para.h from asm-generic (was: Re: linux-next: triage for April 19, 2012)

2012-06-13 Thread Geert Uytterhoeven
On Wed, Jun 13, 2012 at 2:46 PM, Geert Uytterhoeven
ge...@linux-m68k.org wrote:
 make headers_check is also broken on m32r since Avi's fix, as m32r
 doesn't even
 have asm/kvm_param.h:

BTW, you don't need to install any cross-compilers for headers_check, just do

make ARCH=xxx headers_check

if you want to give it a try...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say programmer or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 16/27] KVM: Move kvm_guest_init out of generic code

2010-07-02 Thread Geert Uytterhoeven
On Thu, 1 Jul 2010, Alexander Graf wrote:
 Currently x86 is the only architecture that uses kvm_guest_init(). With
 PowerPC we're getting a second user, but the signature is different there
 and we don't need to export it, as it uses the normal kernel init framework.

Making the signatures match (i.e. always return `int') wouldn't hurt,
since kvm_guest_init() apparently can fail on x86, too.

 So let's move the x86 specific definition of that function over to the x86
 specfic header file.

With kind regards,

Geert Uytterhoeven
Software Architect
Techsoft Centre

Technology and Software Centre Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium

Phone:+32 (0)2 700 8453
Fax:  +32 (0)2 700 8622
E-mail:   geert.uytterhoe...@sonycom.com
Internet: http://www.sony-europe.com/

A division of Sony Europe (Belgium) N.V.
VAT BE 0413.825.160 · RPR Brussels
Fortis · BIC GEBABEBB · IBAN BE41293037680010


The information contained in this message or any of its attachments may be 
confidential and is intended for the exclusive use of the addressee(s).  Any 
disclosure, reproduction, distribution or other dissemination or use of this 
communication is strictly prohibited without the express permission of the 
sender.  The views expressed in this email are those of the individual and not 
necessarily those of Sony or Sony affiliated companies.  Sony email is for 
business use only.

This email and any response may be monitored by Sony to be in compliance with 
Sony's global policies and standards


--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html