[Bug 103141] Host-triggerable NULL pointer oops

2015-08-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=103141

--- Comment #2 from felix felix.vo...@posteo.de ---
Created attachment 185681
  -- https://bugzilla.kernel.org/attachment.cgi?id=185681action=edit
Test program 2 (C99)

You mean can as in I think it does or it did for me?

And anyway, it seems to only fix the most proximate cause of the crash. My
biggest worry is that KVM_SET_USER_MEMORY_REGION ioctls with guest_phys_addr
around the 0xfff0 to 0x range seem not to register; starting the
VM looks like as if the region wasn't placed there.

I attach test program 2. Running that on my system with 0x44000 as an argument
outputs halted (as expected), but 0x45000 and larger multiples of 0x1000 give
internal error, subcode 1.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Bug 103141] Host-triggerable NULL pointer oops

2015-08-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=103141

felix felix.vo...@posteo.de changed:

   What|Removed |Added

 Attachment #185681|0   |1
is obsolete||

--- Comment #3 from felix felix.vo...@posteo.de ---
Created attachment 185691
  -- https://bugzilla.kernel.org/attachment.cgi?id=185691action=edit
Test program 2 (C99) [non-oopsing version]

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Bug 103141] Host-triggerable NULL pointer oops

2015-08-19 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=103141

Wanpeng Li wanpeng...@hotmail.com changed:

   What|Removed |Added

 CC||wanpeng...@hotmail.com

--- Comment #1 from Wanpeng Li wanpeng...@hotmail.com ---
The below commit can fix it.

commit 370777daab3f024f1645177039955088e2e9ae73
Author: Radim Krčmář rkrc...@redhat.com
Date:   Fri Jul 3 15:49:28 2015 +0200

KVM: VMX: fix vmwrite to invalid VMCS

fpu_activate is called outside of vcpu_load(), which means it should not
touch VMCS, but fpu_activate needs to.  Avoid the call by moving it to a
point where we know that the guest needs eager FPU and VMCS is loaded.

This will get rid of the following trace

 vmwrite error: reg 6800 value 0 (err 1)
  [8162035b] dump_stack+0x19/0x1b
  [a046c701] vmwrite_error+0x2c/0x2e [kvm_intel]
  [a045f26f] vmcs_writel+0x1f/0x30 [kvm_intel]
  [a04617e5] vmx_fpu_activate.part.61+0x45/0xb0 [kvm_intel]
  [a0461865] vmx_fpu_activate+0x15/0x20 [kvm_intel]
  [a0560b91] kvm_arch_vcpu_create+0x51/0x70 [kvm]
  [a0548011] kvm_vm_ioctl+0x1c1/0x760 [kvm]
  [8118b55a] ? handle_mm_fault+0x49a/0xec0
  [811e47d5] do_vfs_ioctl+0x2e5/0x4c0
  [8127abbe] ? file_has_perm+0xae/0xc0
  [811e4a51] SyS_ioctl+0xa1/0xc0
  [81630949] system_call_fastpath+0x16/0x1b

(Note: we also unconditionally activate FPU in vmx_vcpu_reset(), so the
 removed code added nothing.)

Fixes: c447e76b4cab (kvm/fpu: Enable eager restore kvm FPU for MPX)
Cc: sta...@vger.kernel.org
Reported-by: Vlastimil Holer vlastimil.ho...@gmail.com
Signed-off-by: Radim Krčmář rkrc...@redhat.com
Signed-off-by: Paolo Bonzini pbonz...@redhat.com

-- 
You are receiving this mail because:
You are watching the assignee of the bug.--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html