Re: [libreoffice-l10n] Weblate: XML check

2019-10-18 Thread Christian Lohmaier
Hi Olivier,

On Tue, Oct 15, 2019 at 3:02 PM Olivier Hallot
 wrote:
> The XML check looks buggy in the situation below:
>
> https://weblate.documentfoundation.org/translate/libo_help-master/textsbasicpython/pt_BR/?type=check:xml-tags
>
> The XML tags are there, but my translation has it in different (but
> consistent) order in the text.
>
> Is the XML check flagging a false positive?

Yes - the xml-tag check only does a simple parsing of the source and
target strings, and creates a list of tuple of tagname and attribute
names and then does a simple equality check...

https://github.com/WeblateOrg/weblate/blob/master/weblate/checks/markup.py#L172

So is a false positive check/only does what the code tells it to do..

ciao
Christian

-- 
To unsubscribe e-mail to: l10n+unsubscr...@global.libreoffice.org
Problems? https://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: https://wiki.documentfoundation.org/Netiquette
List archive: https://listarchives.libreoffice.org/global/l10n/
Privacy Policy: https://www.documentfoundation.org/privacy


Re: [libreoffice-l10n] Wrong translations of formula function names and identifiers [3/3]

2019-10-18 Thread Eike Rathke
Hi Guilhem,

On Thursday, 2019-10-17 20:33:28 +0200, Guilhem Moulin wrote:

> The problem was that your mail was multipart/signed, but the detached
> OpenPGP signature was stripped away (and replaced with the list footer),
> resulting in an invalid message which some MUA rightfully refused to
> show properly.

Ah that makes perfectly sense.

Thanks!
  Eike

-- 
GPG key 0x6A6CD5B765632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A

-- 
To unsubscribe e-mail to: l10n+unsubscr...@global.libreoffice.org
Problems? https://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: https://wiki.documentfoundation.org/Netiquette
List archive: https://listarchives.libreoffice.org/global/l10n/
Privacy Policy: https://www.documentfoundation.org/privacy



Re: [libreoffice-l10n] Wrong translations of formula function names and identifiers [1/3]

2019-10-18 Thread Christian Lohmaier
Hi Eike,

On Wed, Oct 16, 2019 at 8:36 PM Eike Rathke  wrote:
>
> I did a short investigation how some function name was translated and
> stumbled upon quite some mess in general in the formula module.
> Specifically, names in msgctxt "RID_STRLIST_FUNCTION_NAMES":

Thanks for that!

> * Translated function names MUST NOT contain spaces, parentheses,
>   hyphens, or anything else that would be an operator in spreadsheet
>   formula context. Function names may only contain letters (of any
>   alphabet or script of course, not just ASCII) or digits or '.' dot or
>   '_' underscore, and must start with a letter.
> […]
> grep -E -A1 'msgid "[A-Z0-9._]+"' 
> translations/source/*/formula/messages.po|grep -B1 'msgstr ".*[-+*/ ()~]'
>
> (all on one line) also repeated on top of the attached list.

Oh, if that ends up in actual translations repository (as opposed to
translations-weblate intermediate one on github), then the check for
function names in pocheck should be amended according.
Right now it checks for duplicates only it seems...
https://gerrit.libreoffice.org/plugins/gitiles/core/+/master/l10ntools/source/pocheck.cxx#136

(and likely should also be put into a custom check to weblate)

> * Translated identifiers like "#All" or "#Headers" if they start with
>   a '#' hash character MUST start with a '#' character also in the
>   translation, this is vital to recognize them as table reference
>   identifiers (or error constants possibly).

Thx - I think you already added the "L10n: preserve the leading '#'
hash character in translations." comment to all relevant strings?

> grep -E -A1 'msgid "#' translations/source/*/formula/messages.po | grep 
> -B1 'msgstr "[^#"]'
>
> While these wrong translations display correctly when loading
> a document, any attempt to compile such formula expression that does not
> meet the criteria will fail.
>
> PLEASE, check the attached lists for your language's translation (the
> list is sorted by language codes between translations/source/ and
> /formula/messages.po) and correct errors ASAP; corrections should also
> end up in the 6-3 branch, Cloph probably can help with that.

As they break functionality, I can at least make sure that no invalid
translations are in the repo, pocheck removes problematic translations

> Also, (possibly after any change) please load the 6.2 attachment
> https://bugs.documentfoundation.org/attachment.cgi?id=150855 of
> https://bugs.documentfoundation.org/show_bug.cgi?id=93992 in your
> translated UI, to check for duplicated function names.

ciao
Christian

-- 
To unsubscribe e-mail to: l10n+unsubscr...@global.libreoffice.org
Problems? https://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: https://wiki.documentfoundation.org/Netiquette
List archive: https://listarchives.libreoffice.org/global/l10n/
Privacy Policy: https://www.documentfoundation.org/privacy


Re: [libreoffice-l10n] Wrong translations of formula function names and identifiers [3/3]

2019-10-18 Thread Kolbjørn Stuestøl



Den 17.10.2019 23:51, skreiv Michael Wolf:

Kolbjørn Stuestøl schrieb:


Thank you.
It works, although the field for choosing languages do not always 
turns up. I found the errors and corrected them.


If you are in the components view for all languages, e. g. LibreOffice 
UI - master, and you go to the Search Menu, you will see the Search 
form without language select boxes.


If you are in the components view of a certain language, e. 
LibreOffice UI - master Norwegian Nynorsk, and you go to the Search 
menu, you will see the Search form with language select boxes.


Moreover, if you are in the components view for all languages, you 
will find a Search and replace feature in the Tools menu which is not 
available when you are in the components view of a certain language.



Michae

Ah. Thank you.
Kolbjørn

--
Denne e-posten har blitt sjekket for virus av antivirusprogramvare fra Avast
https://www.avast.com/antivirus


--
To unsubscribe e-mail to: l10n+unsubscr...@global.libreoffice.org
Problems? https://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: https://wiki.documentfoundation.org/Netiquette
List archive: https://listarchives.libreoffice.org/global/l10n/
Privacy Policy: https://www.documentfoundation.org/privacy