Re: [Languagetool] path changes in SVN
W dniu 2012-09-04 23:31, Daniel Naber pisze: On 04.09.2012, 10:38:55 Jaume Ortolà i Font wrote: Hi Jaume, After the path changes, I made a clean checkout. I'm using Windows 7 and Eclipse and I have found some problems: thanks, both issues should be fixed now. Please let me know if there's still a problem. It works now for me but I don't really understand the need to include org/languagetool in our compiled version. It makes finding the rule files a bit harder and breaks compatibility with previous versions. Is that really needed? Regards, Marcin -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Languagetool-devel mailing list Languagetool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/languagetool-devel
Re: [Languagetool] path changes in SVN
On 02.09.2012, 20:17:42 Richard Eckart de Castilho wrote: Hi Richard, There is a spelling error in the package of morfologik-speller in the org.carrot artifact (it's morflogik instead of morfologik), so I had to actually change the imports in LanguageTool to match that before the stuff would compile. should we contact them, asking to fix the error? I think we need 1.5.4 anyway because of some other bugfix - Marcin, do you remember? The situation is that we're entering feature freeze in two weeks [1] to prepare LT 1.9. Richard, is the current situation (minus the typo in the package) okay to get LT into Maven central? I know that splitting up the package is desirable, but I won't have enough time for that before feature freeze. Thus my idea is to have a pom.xml that works and that we can use to build the artifact for Maven central, but we keep using ant for our own *zip and *oxt builds for this release. What do you think? Regards Daniel [1] http://languagetool.wikidot.com/roadmap -- http://www.danielnaber.de -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Languagetool-devel mailing list Languagetool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/languagetool-devel
[Languagetool] path changes in SVN
Hi, to become a bit more Maven compatible, I'm going to move directories in SVN today: src/test will become src/test/java src/java will become src/main/java src/dev will become src/main/dev src/rules will become src/main/resources/rules src/resource will become src/main/resources/resource I will try to do that at 19:00 CET. You might want to commit any local changes before that or create a patch, as I'm not sure if merging in your changes will work when the paths change. The long-term goal is to build LT with mvn and to also host it in Maven central. That will of course mean a different build process, and I don't know yet how difficult that will be to implement. Anyway, I'll try to do that step-by-step, keeping everything working all the time. Regards Daniel -- http://www.danielnaber.de -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Languagetool-devel mailing list Languagetool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/languagetool-devel
Re: [Languagetool] path changes in SVN
Hello Daniel, that won't really make too much of a difference. I've set up a POM which takes into account the current project structure. A better situation for Maven compatibility would split the project into three code modules: - core - dev - openoffice and possibly a number of language resource modules. Maybe you want to start by having a look at the pom I crafted. -- Richard Am 02.09.2012 um 18:00 schrieb Daniel Naber: Hi, to become a bit more Maven compatible, I'm going to move directories in SVN today: src/test will become src/test/java src/java will become src/main/java src/dev will become src/main/dev src/rules will become src/main/resources/rules src/resource will become src/main/resources/resource I will try to do that at 19:00 CET. You might want to commit any local changes before that or create a patch, as I'm not sure if merging in your changes will work when the paths change. The long-term goal is to build LT with mvn and to also host it in Maven central. That will of course mean a different build process, and I don't know yet how difficult that will be to implement. Anyway, I'll try to do that step-by-step, keeping everything working all the time. Regards Daniel -- http://www.danielnaber.de -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Languagetool-devel mailing list Languagetool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/languagetool-devel -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Languagetool-devel mailing list Languagetool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/languagetool-devel
Re: [Languagetool] path changes in SVN
On 02.09.2012, 19:20:56 Richard Eckart de Castilho wrote: Hi Richard, that won't really make too much of a difference. I've set up a POM which takes into account the current project structure. I know it doesn't help with your short-term goal, but when we build LT with mvn, I think we should use the standard directory layout. Maybe you want to start by having a look at the pom I crafted. Could you send the URL again? I think the one in your artifact repo looked almost empty, i.e. there were no dependencies... maybe I just looked at the wrong place. Regards Daniel -- http://www.danielnaber.de -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Languagetool-devel mailing list Languagetool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/languagetool-devel
Re: [Languagetool] path changes in SVN
I have added a POM for the restructured trunk to the bug as well now. Please mind that Eclipse can be quite confused if you use the m2e plugin to switch the project to a Maven project, because there is already Eclipse metadata present in the source code repository. On the command line, everything should be mostly fine - some tests fail in 1.8 and some more fail in trunk. There is a spelling error in the package of morfologik-speller in the org.carrot artifact (it's morflogik instead of morfologik), so I had to actually change the imports in LanguageTool to match that before the stuff would compile. Cheers, -- Richard Am 02.09.2012 um 19:52 schrieb Richard Eckart de Castilho: Hello Daniel, that won't really make too much of a difference. I've set up a POM which takes into account the current project structure. I know it doesn't help with your short-term goal, but when we build LT with mvn, I think we should use the standard directory layout. That's a good idea. However, the standard layout only includes src/main/java and src/main/test. I think dev should best go to it's own module. Maybe you are already planning that. Risking that I repeat other things you already though about, I'll just mention what else I noticed when I build the POM: - the i18n properties files are in the regular source folder. In the standard Maven layout, they should to go to src/main/resources. - I think that rules and resource would best be kept somewhere under a org/langaugetool package to avoid any potential conflict with other artifacts. Maybe you want to start by having a look at the pom I crafted. Could you send the URL again? I think the one in your artifact repo looked almost empty, i.e. there were no dependencies... maybe I just looked at the wrong place. I am not sure where you were looking. I attached a POM for 1.8 to this issue https://sourceforge.net/tracker/index.php?func=detailaid=3564184group_id=110216atid=655717 I'll also add one for trunk now to the same issue. Probably I'll go on with trying to get cjftransform and ictclas4j to Maven Central next. Cheers, -- Richard -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Languagetool-devel mailing list Languagetool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/languagetool-devel
Re: [Languagetool] path changes in SVN
On 02.09.2012, 18:00:41 Daniel Naber wrote: to become a bit more Maven compatible, I'm going to move directories in SVN today: It would be nice if an Eclipse user could update the .profile and .classpath files accordingly. Regards Daniel -- http://www.danielnaber.de -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Languagetool-devel mailing list Languagetool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/languagetool-devel
Re: [Languagetool] path changes in SVN
Am 02.09.2012 um 21:37 schrieb Daniel Naber: On 02.09.2012, 18:00:41 Daniel Naber wrote: to become a bit more Maven compatible, I'm going to move directories in SVN today: It would be nice if an Eclipse user could update the .profile and .classpath files accordingly. If you plan to move to Maven, I'd recommend not keeping Eclipse metadata in the repository. That would only be useful for Eclipse users that do not use Maven. It would confuse things for Eclipse users that are actually using Maven. -- Richard -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Languagetool-devel mailing list Languagetool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/languagetool-devel
Re: [Languagetool] path changes in SVN
On 02.09.2012, 23:59:18 Daniel Naber wrote: Sorry for the hassle, but I need to move rules and resources again. This should be finished now, please don't forget to update. If something seems messed up you might want to consider a fresh re-checkout of https://languagetool.svn.sourceforge.net/svnroot/languagetool/trunk/JLanguageTool Regards Daniel -- http://www.danielnaber.de -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Languagetool-devel mailing list Languagetool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/languagetool-devel
