Re: [Ledger-smb-devel] Employee search question for 1.3
On 06/21/2011 04:02 PM, Chris Travers wrote: Hi John; In terms of the duplication issue can you: SELECT p.id as person_id, e.id as entity_id FROM person p JOIN entity e ON (e.id = p.entity_id) order by p.id; db= SELECT p.id as person_id, e.id as entity_id db- FROM person p db- JOIN entity e ON (e.id = p.entity_id) db- order by p.id; person_id | entity_id ---+--- 1 | 1 3 | 653 4 | 654 5 | 667 (4 rows) This should not contain any personal info but would allow me to look at the join issues involved, Best Wishes, Chris Travers -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ Ledger-smb-devel mailing list Ledger-smb-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ledger-smb-devel -- Simplify data backup and recovery for your virtual environment with vRanger. Installation's a snap, and flexible recovery options mean your data is safe, secure and there when you need it. Data protection magic? Nope - It's vRanger. Get your free trial download today. http://p.sf.net/sfu/quest-sfdev2dev ___ Ledger-smb-devel mailing list Ledger-smb-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ledger-smb-devel
Re: [Ledger-smb-devel] Employee search question for 1.3
On Wed, Jun 22, 2011 at 10:12 AM, John Locke m...@freelock.com wrote: On 06/21/2011 04:02 PM, Chris Travers wrote: Hi John; In terms of the duplication issue can you: SELECT p.id as person_id, e.id as entity_id FROM person p JOIN entity e ON (e.id = p.entity_id) order by p.id; db= SELECT p.id as person_id, e.id as entity_id db- FROM person p db- JOIN entity e ON (e.id = p.entity_id) db- order by p.id; person_id | entity_id ---+--- 1 | 1 3 | 653 4 | 654 5 | 667 (4 rows) And are you only seeing four rows total in the report? Best Wishes, Chris Travers -- Simplify data backup and recovery for your virtual environment with vRanger. Installation's a snap, and flexible recovery options mean your data is safe, secure and there when you need it. Data protection magic? Nope - It's vRanger. Get your free trial download today. http://p.sf.net/sfu/quest-sfdev2dev ___ Ledger-smb-devel mailing list Ledger-smb-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ledger-smb-devel
Re: [Ledger-smb-devel] Employee search question for 1.3
Ok, I was looking at svn #3301. Completely different now. Out of the available fields, I think I'd show employee number, first name, last name, role. My account is showing up 4 times in this list!?!? ... and an account I created a couple weeks ago has no employee id. Cheers, -- John Locke http://freelock.com On 06/20/2011 04:06 PM, Chris Travers wrote: On Mon, Jun 20, 2011 at 12:02 PM, John Locke m...@freelock.com wrote: Hi, Chris, The current defaults look reasonable to me... possibly adding the email field. If this can be changed in the database (as it sounds like you've set up), that should be fine to start. Actually currently there is no email column on the new code. We could add one though but this poses an issue to be discussed. One of the huge differences between 1.3 and 1.2 is that an employee, customer, or vendor can have any number of email addresses, postal addresses for sales/shipping (but only one address for billing), phone numbers, etc. If we want to display this info, how do we choose what to display? I suppose we could just display every email address, phone number, etc. However, I'm not getting correct data when I do a search... Maybe this is an update issue -- I ran the upgrade/3297-employee_changes.sql and upgrade/3299-person_functions.sql scripts, but the result of a search is a table with Number, Startdate and Role showing up but all the rest of the columns blank. And Number is blank on the most recent employee I added... You are still hitting the old code. SVN 3302 (iirc) and the 3302-menu_changes.sql correct that issue. Best Wishes, Chris Travers -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ Ledger-smb-devel mailing list Ledger-smb-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ledger-smb-devel -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ Ledger-smb-devel mailing list Ledger-smb-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ledger-smb-devel
Re: [Ledger-smb-devel] Employee search question for 1.3
On Tue, Jun 21, 2011 at 9:09 AM, John Locke m...@freelock.com wrote: Ok, I was looking at svn #3301. Completely different now. Out of the available fields, I think I'd show employee number, first name, last name, role. My account is showing up 4 times in this list!?!? sounds like a join problem. I'll get it fixed in a moment. As for safety on production databases, the old code isn't displaying much at all. No data changes.occur with these fixes outside the menu. So any problems shouild be self-contained to the display of this report. Best Wishes, Chris Travers ... and an account I created a couple weeks ago has no employee id. Cheers, -- John Locke http://freelock.com On 06/20/2011 04:06 PM, Chris Travers wrote: On Mon, Jun 20, 2011 at 12:02 PM, John Locke m...@freelock.com wrote: Hi, Chris, The current defaults look reasonable to me... possibly adding the email field. If this can be changed in the database (as it sounds like you've set up), that should be fine to start. Actually currently there is no email column on the new code. We could add one though but this poses an issue to be discussed. One of the huge differences between 1.3 and 1.2 is that an employee, customer, or vendor can have any number of email addresses, postal addresses for sales/shipping (but only one address for billing), phone numbers, etc. If we want to display this info, how do we choose what to display? I suppose we could just display every email address, phone number, etc. However, I'm not getting correct data when I do a search... Maybe this is an update issue -- I ran the upgrade/3297-employee_changes.sql and upgrade/3299-person_functions.sql scripts, but the result of a search is a table with Number, Startdate and Role showing up but all the rest of the columns blank. And Number is blank on the most recent employee I added... You are still hitting the old code. SVN 3302 (iirc) and the 3302-menu_changes.sql correct that issue. Best Wishes, Chris Travers -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ Ledger-smb-devel mailing list Ledger-smb-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ledger-smb-devel -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ Ledger-smb-devel mailing list Ledger-smb-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ledger-smb-devel -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ Ledger-smb-devel mailing list Ledger-smb-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ledger-smb-devel
Re: [Ledger-smb-devel] Employee search question for 1.3
Hi John; In terms of the duplication issue can you: SELECT p.id as person_id, e.id as entity_id FROM person p JOIN entity e ON (e.id = p.entity_id) order by p.id; This should not contain any personal info but would allow me to look at the join issues involved, Best Wishes, Chris Travers -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ Ledger-smb-devel mailing list Ledger-smb-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ledger-smb-devel
[Ledger-smb-devel] Employee search question for 1.3
I have set up the search function to allow for the menu to specify which column including checkboxes are to be checked. For those using 1.3, can you take a look and tell me which checkboxes you think should be checked by default? Best wishes, Chris Travers -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ Ledger-smb-devel mailing list Ledger-smb-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ledger-smb-devel
Re: [Ledger-smb-devel] Employee search question for 1.3
Hi, Chris, The current defaults look reasonable to me... possibly adding the email field. If this can be changed in the database (as it sounds like you've set up), that should be fine to start. However, I'm not getting correct data when I do a search... Maybe this is an update issue -- I ran the upgrade/3297-employee_changes.sql and upgrade/3299-person_functions.sql scripts, but the result of a search is a table with Number, Startdate and Role showing up but all the rest of the columns blank. And Number is blank on the most recent employee I added... Cheers, John Locke http://www.freelock.com On 06/20/2011 07:14 AM, Chris Travers wrote: I have set up the search function to allow for the menu to specify which column including checkboxes are to be checked. For those using 1.3, can you take a look and tell me which checkboxes you think should be checked by default? Best wishes, Chris Travers -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ Ledger-smb-devel mailing list Ledger-smb-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ledger-smb-devel -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ Ledger-smb-devel mailing list Ledger-smb-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ledger-smb-devel
Re: [Ledger-smb-devel] Employee search question for 1.3
On Mon, Jun 20, 2011 at 12:59 PM, John Locke m...@freelock.com wrote: Ok. Ran across a different issue related to the new tax account stuff, that might be related. LedgerSMB::DBObject provides an object wrapper around stored functions -- when called with a method that is not populated in the class definition, it looks for a stored function of that name, and then parses the parameters that function takes and populates a query with those properties on the object itself. The problem is when there are multiple functions with the same name, but a different parameter signature. I had two different account__save functions in my database, and the DBObject was picking the old one with fewer parameters. After deleting that, I got the new updated function. And of course, since the signature had changed, CREATE OR UPDATE FUNCTION didn't delete the old one. Right. I corrected Erik's script after the fact. Drop the function with fewer arguments. If you want to check for other functions which might be accidently overloaded, cd to the sql/modules/test directory (you have to be working from that directory), open psql, and run: \i System.sql Best Wishes, Chris Travers -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ Ledger-smb-devel mailing list Ledger-smb-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ledger-smb-devel
Re: [Ledger-smb-devel] Employee search question for 1.3
On Mon, 20 Jun 2011, Chris Travers wrote: On Mon, Jun 20, 2011 at 12:02 PM, John Locke m...@freelock.com wrote: Hi, Chris, The current defaults look reasonable to me... possibly adding the email field. If this can be changed in the database (as it sounds like you've set up), that should be fine to start. One of the huge differences between 1.3 and 1.2 is that an employee, customer, or vendor can have any number of email addresses, postal addresses for sales/shipping (but only one address for billing), phone numbers, etc. If we want to display this info, how do we choose what to display? I suppose we could just display every email address, phone number, etc. I wasn't following this. Display where? If you're talking about use, such as on invoices, orders, and what not, why not go with select fields? I can imagine, for example, a dropdown of email addresses, on the email page for where to send an invoice. Luke -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ Ledger-smb-devel mailing list Ledger-smb-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ledger-smb-devel
Re: [Ledger-smb-devel] Employee search question for 1.3
On Mon, 20 Jun 2011, Chris Travers wrote: Well, for billing, there really ought to be an authoritative contact record. Thinking about this for emailing we might want to create a new contact_class record for billing email with a unique constraint on the (credit_id, contact_class) field where the class id is this one. PostgreSQL's partial unique indexes can help here. I understand your reasoning for wanting a single contact for billing, but I will just observe, that I have at least one customer, wherein they expect me to send invoices for different classes of service, to different people within the company. I don't know how common that is, and I can only think of that one case, but in it there are three people that I routinely send invoices to, either depending on the size of the transaction, or the type of services provided. It's one customer for me, so I can work around it by manually mailing invoices and orders in those cases, but I thought I'd throw it out there as a point of discussion. Luke -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ Ledger-smb-devel mailing list Ledger-smb-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ledger-smb-devel
