Re: [mpeg2-dev] [PATCH] make headers compile standalone

2010-06-24 Thread Diego Biurrun
On Thu, Jun 24, 2010 at 10:41:22AM +0200, Diego Biurrun wrote:
 On Sat, Jun 12, 2010 at 10:37:48AM +0200, Diego Biurrun wrote:
  On Fri, Jun 11, 2010 at 11:56:09AM +0200, Sam Hocevar wrote:
   On Thu, Jun 10, 2010, Diego Biurrun wrote:
Here is a patch to make libmpeg2 headers compile standalone.
This allows #including them directly without worrying about
header inclusion order or having to #include system headers
before libmpeg2 headers.
   
  I am worried about the stdint.h inclusions. This will likely break
   compilation on Visual Studio until they have that header.
  
  How backwards can they be?  Do they have inttypes.h?
  
  In any case the rest of the patch should be worth applying nonetheless.
 
 Here is a version of the patch without the stdint.h #includes.
 Please apply.

*Here* is a version of said patch - *sigh*..

Diego
Index: include/mpeg2convert.h
===
--- include/mpeg2convert.h	(revision 1204)
+++ include/mpeg2convert.h	(working copy)
@@ -24,6 +24,8 @@
 #ifndef LIBMPEG2_MPEG2CONVERT_H
 #define LIBMPEG2_MPEG2CONVERT_H
 
+#include mpeg2.h
+
 mpeg2_convert_t mpeg2convert_rgb32;
 mpeg2_convert_t mpeg2convert_rgb24;
 mpeg2_convert_t mpeg2convert_rgb16;
Index: include/mmx.h
===
--- include/mmx.h	(revision 1204)
+++ include/mmx.h	(working copy)
@@ -24,6 +24,8 @@
 #ifndef LIBMPEG2_MMX_H
 #define LIBMPEG2_MMX_H
 
+#include attributes.h
+
 /*
  * The type of an value that fits in an MMX register (note that long
  * long constant values MUST be suffixed by LL and unsigned long long
Index: libmpeg2/mpeg2_internal.h
===
--- libmpeg2/mpeg2_internal.h	(revision 1204)
+++ libmpeg2/mpeg2_internal.h	(working copy)
@@ -24,6 +24,9 @@
 #ifndef LIBMPEG2_MPEG2_INTERNAL_H
 #define LIBMPEG2_MPEG2_INTERNAL_H
 
+#include attributes.h
+#include mpeg2.h
+
 #define STATE_INTERNAL_NORETURN ((mpeg2_state_t)-1)
 
 /* macroblock modes */
Index: libmpeg2/vlc.h
===
--- libmpeg2/vlc.h	(revision 1204)
+++ libmpeg2/vlc.h	(working copy)
@@ -24,6 +24,8 @@
 #ifndef LIBMPEG2_VLC_H
 #define LIBMPEG2_VLC_H
 
+#include mpeg2_internal.h
+
 #define GETWORD(bit_buf,shift,bit_ptr)\
 do {\
 bit_buf |= ((bit_ptr[0]  8) | bit_ptr[1])  (shift);	\
--
ThinkGeek and WIRED's GeekDad team up for the Ultimate 
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the 
lucky parental unit.  See the prize list and enter to win: 
http://p.sf.net/sfu/thinkgeek-promo___
Libmpeg2-devel mailing list
Libmpeg2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libmpeg2-devel


Re: [mpeg2-dev] [PATCH] make headers compile standalone

2010-06-12 Thread Diego Biurrun
On Fri, Jun 11, 2010 at 11:56:09AM +0200, Sam Hocevar wrote:
 On Thu, Jun 10, 2010, Diego Biurrun wrote:
  Here is a patch to make libmpeg2 headers compile standalone.
  This allows #including them directly without worrying about
  header inclusion order or having to #include system headers
  before libmpeg2 headers.
 
I am worried about the stdint.h inclusions. This will likely break
 compilation on Visual Studio until they have that header.

How backwards can they be?  Do they have inttypes.h?

In any case the rest of the patch should be worth applying nonetheless.

Diego

--
ThinkGeek and WIRED's GeekDad team up for the Ultimate 
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the 
lucky parental unit.  See the prize list and enter to win: 
http://p.sf.net/sfu/thinkgeek-promo
___
Libmpeg2-devel mailing list
Libmpeg2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libmpeg2-devel


Re: [mpeg2-dev] [PATCH] make headers compile standalone

2010-06-11 Thread Sam Hocevar
On Thu, Jun 10, 2010, Diego Biurrun wrote:
 Here is a patch to make libmpeg2 headers compile standalone.
 This allows #including them directly without worrying about
 header inclusion order or having to #include system headers
 before libmpeg2 headers.

   I am worried about the stdint.h inclusions. This will likely break
compilation on Visual Studio until they have that header.

-- 
Sam.

--
ThinkGeek and WIRED's GeekDad team up for the Ultimate 
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the 
lucky parental unit.  See the prize list and enter to win: 
http://p.sf.net/sfu/thinkgeek-promo
___
Libmpeg2-devel mailing list
Libmpeg2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libmpeg2-devel