[Libreoffice-commits] .: 3 commits - desktop/inc desktop/source sal/inc sal/qa sfx2/source vcl/aqua vcl/inc vcl/ios
desktop/inc/app.hxx |1
desktop/source/app/app.cxx | 259 +--
desktop/source/app/cmdlineargs.cxx |8
desktop/source/app/officeipcthread.cxx | 36 -
sal/inc/rtl/ustrbuf.hxx | 18
sal/qa/rtl/oustringbuffer/makefile.mk|1
sal/qa/rtl/oustringbuffer/test_oustringbuffer_appendchar.cxx | 63 ++
sfx2/source/appl/appdde.cxx | 43 +
vcl/aqua/source/app/vclnsapp.mm | 18
vcl/aqua/source/window/salmenu.cxx | 12
vcl/inc/vcl/svapp.hxx| 107
vcl/ios/source/app/vcluiapp.mm |3
12 files changed, 285 insertions(+), 284 deletions(-)
New commits:
commit e66e54fb00bf74d13b7059bd32b6207a029afa5e
Author: Stephan Bergmann sberg...@redhat.com
Date: Thu Nov 3 17:45:47 2011 +0100
Further clean up of areas touched by previous commit.
diff --git a/desktop/inc/app.hxx b/desktop/inc/app.hxx
index 87a774c..f30ac46 100644
--- a/desktop/inc/app.hxx
+++ b/desktop/inc/app.hxx
@@ -190,7 +190,6 @@ class Desktop : public Application
voidDoFirstRunInitializations();
static sal_Bool SaveTasks();
-static sal_Bool _bTasksSaved;
static void retrieveCrashReporterState();
static sal_Bool isUIOnSessionShutdownAllowed();
diff --git a/desktop/source/app/app.cxx b/desktop/source/app/app.cxx
index 00850aa..110 100644
--- a/desktop/source/app/app.cxx
+++ b/desktop/source/app/app.cxx
@@ -1346,8 +1346,6 @@ sal_Bool impl_callRecoveryUI(sal_Bool bEmergencySave ,
*
*/
-sal_Bool Desktop::_bTasksSaved = sal_False;
-
sal_Bool Desktop::SaveTasks()
{
return impl_callRecoveryUI(
@@ -2990,138 +2988,139 @@ String GetURL_Impl(
void Desktop::HandleAppEvent( const ApplicationEvent rAppEvent )
{
-if ( rAppEvent.GetEvent() ==
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(APPEAR))
!GetCommandLineArgs().IsInvisible() )
+switch ( rAppEvent.GetEvent() )
{
-css::uno::Reference css::lang::XMultiServiceFactory xSMGR =
::comphelper::getProcessServiceFactory();
-
-// find active task - the active task is always a visible task
-::com::sun::star::uno::Reference
::com::sun::star::frame::XFramesSupplier
-xDesktop( xSMGR-createInstance(
OUSTRING(RTL_CONSTASCII_USTRINGPARAM(com.sun.star.frame.Desktop)) ),
-::com::sun::star::uno::UNO_QUERY );
-::com::sun::star::uno::Reference ::com::sun::star::frame::XFrame
xTask = xDesktop-getActiveFrame();
-if ( !xTask.is() )
+case ApplicationEvent::TYPE_ACCEPT:
+// every time an accept parameter is used we create an acceptor
+// with the corresponding accept-string
+createAcceptor(rAppEvent.GetData());
+break;
+case ApplicationEvent::TYPE_APPEAR:
+if ( !GetCommandLineArgs().IsInvisible() )
{
-// get any task if there is no active one
-::com::sun::star::uno::Reference
::com::sun::star::container::XIndexAccess xList( xDesktop-getFrames(),
::com::sun::star::uno::UNO_QUERY );
-if ( xList-getCount()0 )
-xList-getByIndex(0) = xTask;
-}
+css::uno::Reference css::lang::XMultiServiceFactory xSMGR =
::comphelper::getProcessServiceFactory();
-if ( xTask.is() )
-{
-Reference com::sun::star::awt::XTopWindow xTop(
xTask-getContainerWindow(), UNO_QUERY );
-xTop-toFront();
-}
-else
-{
-// no visible task that could be activated found
-Reference XFrame xBackingFrame;
-Reference ::com::sun::star::awt::XWindow xContainerWindow;
-::com::sun::star::uno::Reference ::com::sun::star::frame::XFrame
xDesktopFrame( xDesktop, UNO_QUERY );
+// find active task - the active task is always a visible task
+::com::sun::star::uno::Reference
::com::sun::star::frame::XFramesSupplier
+ xDesktop( xSMGR-createInstance(
OUSTRING(RTL_CONSTASCII_USTRINGPARAM(com.sun.star.frame.Desktop)) ),
+::com::sun::star::uno::UNO_QUERY );
+::com::sun::star::uno::Reference ::com::sun::star::frame::XFrame
xTask = xDesktop-getActiveFrame();
+if ( !xTask.is() )
+{
+// get any task if there is no active one
+::com::sun::star::uno::Reference
::com::sun::star::container::XIndexAccess xList( xDesktop-getFrames(),
::com::sun::star::uno::UNO_QUERY );
+if ( xList-getCount()0 )
+xList-getByIndex(0) = xTask;
+}
-xBackingFrame =
[Libreoffice-commits] .: wizards/com
wizards/com/sun/star/wizards/ui/event/DataAware.java| 11 ---
wizards/com/sun/star/wizards/ui/event/MethodInvocation.java | 11 +++
2 files changed, 7 insertions(+), 15 deletions(-)
New commits:
commit 504b384dd1c74838f34d5caa27f3e916bb309a8c
Author: Ivan Timofeev timofeev@gmail.com
Date: Fri Nov 4 13:08:38 2011 +0400
suppress warnings about inexact argument type
diff --git a/wizards/com/sun/star/wizards/ui/event/DataAware.java
b/wizards/com/sun/star/wizards/ui/event/DataAware.java
index be7260d..608203c 100644
--- a/wizards/com/sun/star/wizards/ui/event/DataAware.java
+++ b/wizards/com/sun/star/wizards/ui/event/DataAware.java
@@ -291,15 +291,12 @@ public abstract class DataAware {
* @param obj the object which contains the property.
* @return the get method reflection object.
*/
-private static Class[] EMPTY_ARRAY = new Class[0];
-
protected Method createGetMethod(String propName, Object obj)
{
Method m = null;
try
{ //try to get a get method.
-
-m = obj.getClass().getMethod(get + propName, EMPTY_ARRAY);
+m = obj.getClass().getMethod(get + propName, (Class[]) null);
}
catch (NoSuchMethodException ex1)
{
@@ -307,13 +304,13 @@ public abstract class DataAware {
}
return m;
}
-
+
/* (non-Javadoc)
* @see
com.sun.star.wizards.ui.event.DataAware.Value#get(java.lang.Object)
*/
public Object get(Object target) {
try {
-return getMethod.invoke(target, EMPTY_ARRAY);
+return getMethod.invoke(target, (Object[]) null);
} catch (IllegalAccessException ex1) {
ex1.printStackTrace();
} catch (InvocationTargetException ex2) {
@@ -329,7 +326,7 @@ public abstract class DataAware {
return new short[0];
}
return null;
-
+
}
protected Method createSetMethod(String propName, Object obj, Class
paramClass) {
diff --git a/wizards/com/sun/star/wizards/ui/event/MethodInvocation.java
b/wizards/com/sun/star/wizards/ui/event/MethodInvocation.java
index adea073..621158e 100644
--- a/wizards/com/sun/star/wizards/ui/event/MethodInvocation.java
+++ b/wizards/com/sun/star/wizards/ui/event/MethodInvocation.java
@@ -42,10 +42,6 @@ import java.lang.reflect.Method;
*/
public class MethodInvocation
{
-
-static final Class[] EMPTY_ARRAY =
-{
-};
//the method to invoke.
Method mMethod;
//the object to invoke the method on.
@@ -66,7 +62,7 @@ public class MethodInvocation
public MethodInvocation(String methodName, Object obj, Class paramClass)
throws NoSuchMethodException
{
-this(paramClass == null ? obj.getClass().getMethod(methodName, null) :
obj.getClass().getMethod(methodName, new Class[]
+this(paramClass == null ? obj.getClass().getMethod(methodName,
(Class[]) null) : obj.getClass().getMethod(methodName, new Class[]
{
paramClass
}), obj, paramClass);
@@ -86,12 +82,11 @@ public class MethodInvocation
{
if (mWithParam)
{
-return mMethod.invoke(mObject, (Object) param
-);
+return mMethod.invoke(mObject, (Object) param);
}
else
{
-return mMethod.invoke(mObject, EMPTY_ARRAY);
+return mMethod.invoke(mObject, (Object[]) null);
}
}
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 3 commits - editeng/source icc/makefile.mk icc/makefiles.zip icc/SampleICC-makefiles.patch icc/source sc/source smoketestoo_native/data unusedcode.easy
dev/null |binary
editeng/source/editeng/impedit.hxx |4
editeng/source/editeng/impedit2.cxx| 14 --
editeng/source/editeng/impedit3.cxx|9 -
editeng/source/editeng/impedit4.cxx|5
icc/SampleICC-makefiles.patch | 176 +
icc/makefile.mk|3
icc/source/create_sRGB_profile/makefile.mk | 78
sc/source/ui/inc/invmerge.hxx |2
sc/source/ui/view/invmerge.cxx | 12 -
smoketestoo_native/data/Global.xml |5
unusedcode.easy|6
12 files changed, 266 insertions(+), 48 deletions(-)
New commits:
commit edf50b4d4fe0b1a2b0a670f896dc2301caf14212
Author: Caolán McNamara caol...@redhat.com
Date: Fri Nov 4 09:24:32 2011 +
binfilter test needs to have SOLARSRC set to find sample docs
diff --git a/smoketestoo_native/data/Global.xml
b/smoketestoo_native/data/Global.xml
index e956f45..8c549f8 100644
--- a/smoketestoo_native/data/Global.xml
+++ b/smoketestoo_native/data/Global.xml
@@ -120,7 +120,10 @@ Dim gDlgState as Integer
Sub SetGlobalDoc
gOutputDoc = ThisComponent
-oBinFilterComp = createUnoService(
quot;com.sun.star.comp.office.BF_MigrateFilterquot; )
+REM need to have the binfilter component, and SOLARSRC set to find sample
docs
+if Environ(quot;SOLARSRCquot;) lt;gt; quot;quot; then
+oBinFilterComp = createUnoService(
quot;com.sun.star.comp.office.BF_MigrateFilterquot; )
+End If
end Sub
Sub ClearStatus
commit b70fbfd9265d46a0bc088ff08b52fd78268a4834
Author: Caolán McNamara caol...@redhat.com
Date: Fri Nov 4 09:10:42 2011 +
update unused list
diff --git a/editeng/source/editeng/impedit.hxx
b/editeng/source/editeng/impedit.hxx
index 1cf6002..adf3c8e 100644
--- a/editeng/source/editeng/impedit.hxx
+++ b/editeng/source/editeng/impedit.hxx
@@ -597,7 +597,6 @@ private:
EditPaM ConnectContents( sal_uInt16 nLeftNode, sal_Bool
bBackward );
voidShowParagraph( sal_uInt16 nParagraph, sal_Bool bShow );
-sal_BoolIsParagraphVisible( sal_uInt16 nParagraph );
EditPaM PageUp( const EditPaM rPaM, EditView* pView);
EditPaM PageDown( const EditPaM rPaM, EditView* pView);
@@ -830,7 +829,6 @@ public:
sal_BoolIsInSelectionMode() { return bInSelection; }
-voidStopSelectionMode();
voidIndentBlock( EditView* pView, sal_Bool bRight );
@@ -952,8 +950,6 @@ public:
voidPutSpellingToSentenceStart( EditView rEditView );
//applies a changed sentence
voidApplyChangedSentence(EditView rEditView, const
::svx::SpellPortions rNewPortions, bool bRecheck );
-//deinitialize sentence spelling
-voidEndSpelling();
//adds one or more portions of text to the SpellPortions depending on
language changes
voidAddPortionIterated(
EditView rEditView,
diff --git a/editeng/source/editeng/impedit2.cxx
b/editeng/source/editeng/impedit2.cxx
index 297b06a..74d096c 100644
--- a/editeng/source/editeng/impedit2.cxx
+++ b/editeng/source/editeng/impedit2.cxx
@@ -3555,20 +3555,6 @@ EditSelection ImpEditEngine::MatchGroup( const
EditSelection rSel )
return aMatchSel;
}
-void ImpEditEngine::StopSelectionMode()
-{
-if ( ( IsInSelectionMode() || aSelEngine.IsInSelection() ) pActiveView )
-{
-pActiveView-pImpEditView-DrawSelection();
-EditSelection aSel( pActiveView-pImpEditView-GetEditSelection() );
-aSel.Min() = aSel.Max();
-pActiveView-pImpEditView-SetEditSelection( aSel );
-pActiveView-ShowCursor();
-aSelEngine.Reset();
-bInSelection = sal_False;
-}
-}
-
void ImpEditEngine::SetActiveView( EditView* pView )
{
// !
diff --git a/editeng/source/editeng/impedit3.cxx
b/editeng/source/editeng/impedit3.cxx
index 8f059a3..83695cf 100644
--- a/editeng/source/editeng/impedit3.cxx
+++ b/editeng/source/editeng/impedit3.cxx
@@ -3806,15 +3806,6 @@ void ImpEditEngine::ShowParagraph( sal_uInt16
nParagraph, sal_Bool bShow )
}
}
-sal_Bool ImpEditEngine::IsParagraphVisible( sal_uInt16 nParagraph )
-{
-ParaPortion* pPPortion = GetParaPortions().SaveGetObject( nParagraph );
-DBG_ASSERT( pPPortion, IsParagraphVisible: Paragraph does not exist! );
-if ( pPPortion )
-return pPPortion-IsVisible();
-return sal_False;
-}
-
EditSelection ImpEditEngine::MoveParagraphs( Range aOldPositions, sal_uInt16
nNewPos, EditView* pCurView )
{
DBG_ASSERT( GetParaPortions().Count() != 0, No paragraphs found:
MoveParagraphs );
diff --git a/editeng/source/editeng/impedit4.cxx
b/editeng/source/editeng/impedit4.cxx
index 80dcedc..27bbcdc 100644
---
[Libreoffice-commits] .: solenv/gbuild
solenv/gbuild/platform/unxgcc.mk | 38 --
1 file changed, 24 insertions(+), 14 deletions(-)
New commits:
commit d990bb8cd6d6e93c099c0bc196ef5b46a11f54c1
Author: Tor Lillqvist tlillqv...@suse.com
Date: Fri Nov 4 12:57:00 2011 +0200
Deduplication and generalization for cross-compilation
Introduce gb_Helper_LIBRARY_PATH_VAR that is the name of the
environment variable used to look up shared libraries, which differs
depending on OS_FOR_BUILD.
Set that environment variable instead of a hardcoded LD_LIBRARY_PATH
in gb_Helper_set_ld_path.
Make all the PRECOMMAND macros actually use gb_Helper_set_ld_path
instead of duplicating it.
This fixes cross-compilation to HOST platforms that use unxgcc.mk (for
instance Android) from BUILD platforms that don't (for instance
MacOSX).
diff --git a/solenv/gbuild/platform/unxgcc.mk b/solenv/gbuild/platform/unxgcc.mk
index e3e168d..d61c914 100644
--- a/solenv/gbuild/platform/unxgcc.mk
+++ b/solenv/gbuild/platform/unxgcc.mk
@@ -213,7 +213,17 @@ gb_COMPILERNOOPTFLAGS := -O0
gb_Helper_abbreviate_dirs_native = $(gb_Helper_abbreviate_dirs)
-gb_Helper_set_ld_path := LD_LIBRARY_PATH=$(OUTDIR_FOR_BUILD)/lib
+ifeq ($(OS_FOR_BUILD),MACOSX)
+gb_Helper_LIBRARY_PATH_VAR := DYLD_LIBRARY_PATH
+else ifeq ($(OS_FOR_BUILD),WNT)
+# In theory possible if cross-compiling to some Unix from Windows,
+# in practice strongly discouraged to even try that
+gb_Helper_LIBRARY_PATH_VAR := PATH
+else
+gb_Helper_LIBRARY_PATH_VAR := LD_LIBRARY_PATH
+endif
+
+gb_Helper_set_ld_path := $(gb_Helper_LIBRARY_PATH_VAR)=$(OUTDIR_FOR_BUILD)/lib
# convert parameters filesystem root to native notation
# does some real work only on windows, make sure not to
@@ -461,7 +471,7 @@ endef
# CppunitTest class
-gb_CppunitTest_CPPTESTPRECOMMAND := LD_LIBRARY_PATH=$(OUTDIR_FOR_BUILD)/lib
+gb_CppunitTest_CPPTESTPRECOMMAND := $(gb_Helper_set_ld_path)
gb_CppunitTest_SYSPRE := libtest_
gb_CppunitTest_EXT := .so
gb_CppunitTest_LIBDIR := $(gb_Helper_OUTDIRLIBDIR)
@@ -478,23 +488,23 @@ endef
define gb_JunitTest_JunitTest_platform
$(call gb_JunitTest_get_target,$(1)) : DEFS := \
-Dorg.openoffice.test.arg.soffice={OOO_TEST_SOFFICE:-path:$(OUTDIR)/installation/opt/program/soffice}
\
- -Dorg.openoffice.test.arg.env=LD_LIBRARY_PATH \
+ -Dorg.openoffice.test.arg.env=$(gb_Helper_LIBRARY_PATH_VAR) \
-Dorg.openoffice.test.arg.user=file://$(call
gb_JunitTest_get_userdir,$(1)) \
endef
# SdiTarget class
-gb_SdiTarget_SVIDLPRECOMMAND := LD_LIBRARY_PATH=$(OUTDIR_FOR_BUILD)/lib
+gb_SdiTarget_SVIDLPRECOMMAND := $(gb_Helper_set_ld_path)
# SrsPartMergeTarget
-gb_SrsPartMergeTarget_TRANSEXPRECOMMAND :=
LD_LIBRARY_PATH=$(OUTDIR_FOR_BUILD)/lib
+gb_SrsPartMergeTarget_TRANSEXPRECOMMAND := $(gb_Helper_set_ld_path)
# SrsPartTarget class
gb_SrsPartTarget_RSCTARGET := $(OUTDIR_FOR_BUILD)/bin/rsc
-gb_SrsPartTarget_RSCCOMMAND := LD_LIBRARY_PATH=$(OUTDIR_FOR_BUILD)/lib
SOLARBINDIR=$(OUTDIR_FOR_BUILD)/bin $(OUTDIR_FOR_BUILD)/bin/rsc
+gb_SrsPartTarget_RSCCOMMAND := $(gb_Helper_set_ld_path)
SOLARBINDIR=$(OUTDIR_FOR_BUILD)/bin $(OUTDIR_FOR_BUILD)/bin/rsc
define gb_SrsPartTarget__command_dep
$(call gb_Helper_abbreviate_dirs,\
@@ -510,25 +520,25 @@ endef
# ComponentTarget
-gb_XSLTPROCPRECOMMAND := LD_LIBRARY_PATH=$(OUTDIR_FOR_BUILD)/lib
+gb_XSLTPROCPRECOMMAND := $(gb_Helper_set_ld_path)
# UnoApiTarget
gb_UnoApiTarget_IDLCTARGET := $(OUTDIR)/bin/idlc
-gb_UnoApiTarget_IDLCCOMMAND := LD_LIBRARY_PATH=$(OUTDIR)/lib
SOLARBINDIR=$(OUTDIR)/bin $(gb_UnoApiTarget_IDLCTARGET)
+gb_UnoApiTarget_IDLCCOMMAND := $(gb_Helper_set_ld_path)
SOLARBINDIR=$(OUTDIR)/bin $(gb_UnoApiTarget_IDLCTARGET)
gb_UnoApiTarget_REGMERGETARGET := $(OUTDIR)/bin/regmerge
-gb_UnoApiTarget_REGMERGECOMMAND := LD_LIBRARY_PATH=$(OUTDIR)/lib
SOLARBINDIR=$(OUTDIR)/bin $(gb_UnoApiTarget_REGMERGETARGET)
+gb_UnoApiTarget_REGMERGECOMMAND := $(gb_Helper_set_ld_path)
SOLARBINDIR=$(OUTDIR)/bin $(gb_UnoApiTarget_REGMERGETARGET)
gb_UnoApiTarget_REGCOMPARETARGET := $(OUTDIR)/bin/regcompare
-gb_UnoApiTarget_REGCOMPARECOMMAND := LD_LIBRARY_PATH=$(OUTDIR)/lib
SOLARBINDIR=$(OUTDIR)/bin $(gb_UnoApiTarget_REGCOMPARETARGET)
+gb_UnoApiTarget_REGCOMPARECOMMAND := $(gb_Helper_set_ld_path)
SOLARBINDIR=$(OUTDIR)/bin $(gb_UnoApiTarget_REGCOMPARETARGET)
gb_UnoApiTarget_CPPUMAKERTARGET := $(OUTDIR)/bin/cppumaker
-gb_UnoApiTarget_CPPUMAKERCOMMAND := LD_LIBRARY_PATH=$(OUTDIR)/lib
SOLARBINDIR=$(OUTDIR)/bin $(gb_UnoApiTarget_CPPUMAKERTARGET)
+gb_UnoApiTarget_CPPUMAKERCOMMAND := $(gb_Helper_set_ld_path)
SOLARBINDIR=$(OUTDIR)/bin $(gb_UnoApiTarget_CPPUMAKERTARGET)
gb_UnoApiTarget_REGVIEWTARGET := $(OUTDIR)/bin/regview
-gb_UnoApiTarget_REGVIEWCOMMAND := LD_LIBRARY_PATH=$(OUTDIR)/lib
SOLARBINDIR=$(OUTDIR)/bin $(gb_UnoApiTarget_REGVIEWTARGET)
+gb_UnoApiTarget_REGVIEWCOMMAND := $(gb_Helper_set_ld_path)
SOLARBINDIR=$(OUTDIR)/bin
[Libreoffice-commits] .: postprocess/packcomponents scp2/source
postprocess/packcomponents/makefile.mk | 11 +++ scp2/source/ooo/file_library_ooo.scp |6 +- scp2/source/ooo/makefile.mk|4 ++-- 3 files changed, 10 insertions(+), 11 deletions(-) New commits: commit 65270c4e9318036100401ec1fb09443c1bdb239a Author: Caolán McNamara caol...@redhat.com Date: Fri Nov 4 11:20:09 2011 + fix encrypting odf documents xsec_fw is always built, so always register and install xsec_xmlsec is built when ENABLE_XMLSEC is true, match register and install plugin is built when WITH_MOZILLA is not NO, match register diff --git a/postprocess/packcomponents/makefile.mk b/postprocess/packcomponents/makefile.mk index 9d36059..eb10ee9 100644 --- a/postprocess/packcomponents/makefile.mk +++ b/postprocess/packcomponents/makefile.mk @@ -277,10 +277,13 @@ my_components += \ my_components += ldapbe2 .END -.IF $(ENABLE_NSS_MODULE) == YES || $(SYSTEM_MOZILLA) == YES -my_components += \ -component/xmlsecurity/util/xsec_fw \ -pl +.IF $(WITH_MOZILLA) != NO +my_components += pl +.END + +my_components += component/xmlsecurity/util/xsec_fw + +.IF $(ENABLE_XMLSEC) == YES .IF $(OS) == WNT my_components += component/xmlsecurity/util/xsec_xmlsec.windows .ELSE diff --git a/scp2/source/ooo/file_library_ooo.scp b/scp2/source/ooo/file_library_ooo.scp index d83d6cf..56592cf 100644 --- a/scp2/source/ooo/file_library_ooo.scp +++ b/scp2/source/ooo/file_library_ooo.scp @@ -1406,7 +1406,6 @@ File gid_File_Lib_XSec_XMLSecurity Styles = (PACKED); End -#if defined(ENABLE_NSS_MODULE) || defined(SYSTEM_MOZILLA) File gid_File_Lib_XSec_Framework TXT_FILE_BODY; #ifdef UNX @@ -1418,7 +1417,7 @@ File gid_File_Lib_XSec_Framework Styles = (PACKED); End -#if defined(ENABLE_NSS_MODULE) || defined(SYSTEM_MOZILLA) +#if defined(ENABLE_XMLSEC) File gid_File_Lib_XSec_XmlSec TXT_FILE_BODY; #ifdef UNX @@ -1429,7 +1428,6 @@ File gid_File_Lib_XSec_XmlSec Dir = SCP2_OOO_BIN_DIR; Styles = (PACKED); End -#endif #ifdef WNT File gid_File_Lib_LibXMLSec_xmlseccore @@ -1454,8 +1452,6 @@ File gid_File_Lib_LibXMLSec_xmlsecmscrypto Styles = (PACKED); End #endif - -//i20156 - end #endif File gid_File_Lib_Migrationoo2 diff --git a/scp2/source/ooo/makefile.mk b/scp2/source/ooo/makefile.mk index bf17b84..2a89eca 100644 --- a/scp2/source/ooo/makefile.mk +++ b/scp2/source/ooo/makefile.mk @@ -92,8 +92,8 @@ SCPDEFS+=-DENABLE_EVOAB2 SCPDEFS+=-DENABLE_DIRECTX .ENDIF -.IF $(ENABLE_NSS_MODULE)==YES -SCPDEFS+=-DENABLE_NSS_MODULE +.IF $(ENABLE_XMLSEC)==YES +SCPDEFS+=-DENABLE_XMLSEC .ENDIF .IF $(GUI)==UNX ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sfx2/source
sfx2/source/appl/shutdownicon.cxx |3 +++
1 file changed, 3 insertions(+)
New commits:
commit 9b699a2ce1e70f4752de9b9184765f46ffd274f8
Author: Michael Meeks michael.me...@suse.com
Date: Fri Nov 4 12:34:19 2011 +
WaE: calm down windows shutdownicon warning
diff --git a/sfx2/source/appl/shutdownicon.cxx
b/sfx2/source/appl/shutdownicon.cxx
index 82c1af7..81b814e 100644
--- a/sfx2/source/appl/shutdownicon.cxx
+++ b/sfx2/source/appl/shutdownicon.cxx
@@ -116,11 +116,14 @@ SFX_IMPL_ONEINSTANCEFACTORY( ShutdownIcon );
bool ShutdownIcon::bModalMode = false;
ShutdownIcon* ShutdownIcon::pShutdownIcon = NULL;
+#if !defined( ENABLE_QUICKSTART_APPLET ) || defined( UNX )
// To remove conditionals
extern C {
static void disabled_initSystray() { }
static void disabled_deInitSystray() { }
}
+#endif
+
#define DOSTRING( x ) #x
#define STRING( x ) DOSTRING( x )
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: solenv/gbuild
solenv/gbuild/platform/macosx.mk |1 +
solenv/gbuild/platform/winmingw.mk |1 +
2 files changed, 2 insertions(+)
New commits:
commit 6f9d6b6c518e0c9d98877d71c525c402a12083c9
Author: Norbert Thiebaud nthieb...@gmail.com
Date: Fri Nov 4 08:26:14 2011 -0500
populate gb_CCVER for mac and winmg build
diff --git a/solenv/gbuild/platform/macosx.mk b/solenv/gbuild/platform/macosx.mk
index 936b27c..055073f 100644
--- a/solenv/gbuild/platform/macosx.mk
+++ b/solenv/gbuild/platform/macosx.mk
@@ -48,6 +48,7 @@ endif
ifneq ($(origin CXX),default)
gb_CXX := $(CXX)
endif
+gb_CCVER := $(shell $(gb_CC) -dumpversion | $(gb_AWK) -F. -- '{ print
$$1*1+$$2*100+$$3 }')
gb_OSDEFS := \
-D$(OS) \
diff --git a/solenv/gbuild/platform/winmingw.mk
b/solenv/gbuild/platform/winmingw.mk
index 6255974..a6618e3 100644
--- a/solenv/gbuild/platform/winmingw.mk
+++ b/solenv/gbuild/platform/winmingw.mk
@@ -39,6 +39,7 @@ gb_AWK := awk
gb_CLASSPATHSEP := :
gb_YACC := bison
gb_RC := $(WINDRES)
+gb_CCVER := $(shell $(gb_CC) -dumpversion | $(gb_AWK) -F. -- '{ print
$$1*1+$$2*100+$$3 }')
gb_OSDEFS := \
-DWINVER=0x0500 \
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - sc/inc sc/source unusedcode.easy
sc/inc/document.hxx |4 -
sc/inc/table.hxx |3 -
sc/source/core/data/documen9.cxx | 65 --
sc/source/core/data/table1.cxx|9 ---
sc/source/core/data/table2.cxx| 11
sc/source/filter/xml/xmlsubti.cxx | 93 --
sc/source/filter/xml/xmlsubti.hxx |2
unusedcode.easy |2
8 files changed, 42 insertions(+), 147 deletions(-)
New commits:
commit c9c98ab207fba4df35261c66b3753b9ce5e997ba
Author: Laurent Godard oooc...@free.fr
Date: Fri Nov 4 15:24:53 2011 +0100
calc big doc : ScMyTables::NewSheet method cleaning
diff --git a/sc/source/filter/xml/xmlsubti.cxx
b/sc/source/filter/xml/xmlsubti.cxx
index 04f9a8e..2bc5b7c 100644
--- a/sc/source/filter/xml/xmlsubti.cxx
+++ b/sc/source/filter/xml/xmlsubti.cxx
@@ -184,17 +184,41 @@ void ScMyTables::NewSheet(const rtl::OUString
sTableName, const rtl::OUString
++nCurrentSheet;
maProtectionData = rProtectData;
+ScDocument *pDoc = ScXMLConverter::GetScDocument(rImport.GetModel());
+
+if (nCurrentSheet 0)
+{
+pDoc-AppendTabOnLoad(sTableName);
+}
+
+rImport.SetTableStyle(sStyleName);
+SetTableStyle(sStyleName);
+}
+
+NewTable(1);
+}
+
+void ScMyTables::SetTableStyle(const rtl::OUString sStyleName)
+{
+//these uno calls are a bit difficult to remove,
XMLTableStyleContext::FillPropertySet uses
+//SvXMLImportPropertyMapper::FillPropertySet
+if ( sStyleName.getLength() )
+{
+// #i57869# All table style properties for all sheets are now applied
here,
+// before importing the contents.
+// This is needed for the background color.
+// Sheet visibility has special handling in ScDocFunc::SetTableVisible
to
+// allow hiding the first sheet.
+// RTL layout is only remembered, not actually applied, so the shapes
can
+// be loaded before mirroring.
+
uno::Reference sheet::XSpreadsheetDocument xSpreadDoc(
rImport.GetModel(), uno::UNO_QUERY );
+
if ( xSpreadDoc.is() )
{
uno::Reference sheet::XSpreadsheets
xSheets(xSpreadDoc-getSheets());
-if (xSheets.is())
+if ( xSheets.is() )
{
-if (nCurrentSheet 0)
-{
-ScDocument *pDoc =
ScXMLConverter::GetScDocument(rImport.GetModel());
-pDoc-AppendTabOnLoad(sTableName);
-}
uno::Reference container::XIndexAccess xIndex( xSheets,
uno::UNO_QUERY );
if ( xIndex.is() )
{
@@ -202,65 +226,28 @@ void ScMyTables::NewSheet(const rtl::OUString
sTableName, const rtl::OUString
if ( xCurrentSheet.is() )
{
xCurrentCellRange.set(xCurrentSheet, uno::UNO_QUERY);
-if (!(nCurrentSheet 0))
+uno::Reference beans::XPropertySet
xProperties(xCurrentSheet, uno::UNO_QUERY);
+if ( xProperties.is() )
{
-uno::Reference container::XNamed
xNamed(xCurrentSheet, uno::UNO_QUERY );
-if ( xNamed.is() )
-try
-{
-xNamed-setName(sTableName);
-}
-catch ( uno::RuntimeException )
-{
-ScDocument *pDoc =
ScXMLConverter::GetScDocument(rImport.GetModel());
-if (pDoc)
-{
-ScXMLImport::MutexGuard
aGuard(rImport);
-String
sTabName(String::CreateFromAscii(Table));
-pDoc-CreateValidTabName(sTabName);
-rtl::OUString sOUTabName(sTabName);
-xNamed-setName(sOUTabName);
-}
-}
-}
-rImport.SetTableStyle(sStyleName);
-
-if ( sStyleName.getLength() )
-{
-// #i57869# All table style properties for all
sheets are now applied here,
-// before importing the contents.
-// This is needed for the background color.
-// Sheet visibility has special handling in
ScDocFunc::SetTableVisible to
-// allow hiding the first sheet.
-// RTL layout is only remembered, not actually
applied, so the shapes can
-// be loaded
[Libreoffice-commits] .: sd/source starmath/source
sd/source/core/drawdoc3.cxx|4
sd/source/ui/docshell/docshel3.cxx |4
sd/source/ui/docshell/docshell.cxx |5 -
sd/source/ui/func/fuinsfil.cxx |4
sd/source/ui/func/fuprlout.cxx |2 --
starmath/source/document.cxx |5 -
6 files changed, 24 deletions(-)
New commits:
commit 307535d98aeb171ee5e291b77f6c5028b4db936d
Author: Takeshi Abe t...@fixedpoint.jp
Date: Sat Nov 5 00:04:36 2011 +0900
removed unused macro
diff --git a/sd/source/core/drawdoc3.cxx b/sd/source/core/drawdoc3.cxx
index 97553d3..06e874d 100644
--- a/sd/source/core/drawdoc3.cxx
+++ b/sd/source/core/drawdoc3.cxx
@@ -81,10 +81,6 @@
using namespace ::com::sun::star;
-#define POOL_BUFFER_SIZE(sal_uInt16)32768
-#define BASIC_BUFFER_SIZE (sal_uInt16)8192
-#define DOCUMENT_BUFFER_SIZE(sal_uInt16)32768
-
/*
|*
|* Oeffnet ein Bookmark-Dokument
diff --git a/sd/source/ui/docshell/docshel3.cxx
b/sd/source/ui/docshell/docshel3.cxx
index 75cbaf8..b5ab8da 100644
--- a/sd/source/ui/docshell/docshel3.cxx
+++ b/sd/source/ui/docshell/docshel3.cxx
@@ -72,10 +72,6 @@ using namespace ::com::sun::star::uno;
namespace sd {
-#define POOL_BUFFER_SIZE(sal_uInt16)32768
-#define BASIC_BUFFER_SIZE (sal_uInt16)8192
-#define DOCUMENT_BUFFER_SIZE(sal_uInt16)32768
-
/*
|*
|* SFX-Requests bearbeiten
diff --git a/sd/source/ui/docshell/docshell.cxx
b/sd/source/ui/docshell/docshell.cxx
index ce1f946..67d526a 100644
--- a/sd/source/ui/docshell/docshell.cxx
+++ b/sd/source/ui/docshell/docshell.cxx
@@ -95,11 +95,6 @@ SFX_IMPL_INTERFACE(DrawDocShell, SfxObjectShell, SdResId(0))
namespace sd {
-#define POOL_BUFFER_SIZE(sal_uInt16)32768
-#define BASIC_BUFFER_SIZE (sal_uInt16)8192
-#define DOCUMENT_BUFFER_SIZE(sal_uInt16)32768
-
-
GraphicFilter* GetGrfFilter();
/*
diff --git a/sd/source/ui/func/fuinsfil.cxx b/sd/source/ui/func/fuinsfil.cxx
index fed1af0..5a976b8 100644
--- a/sd/source/ui/func/fuinsfil.cxx
+++ b/sd/source/ui/func/fuinsfil.cxx
@@ -85,10 +85,6 @@ namespace sd {
TYPEINIT1( FuInsertFile, FuPoor );
-#define POOL_BUFFER_SIZE(sal_uInt16)32768
-#define BASIC_BUFFER_SIZE (sal_uInt16)8192
-#define DOCUMENT_BUFFER_SIZE(sal_uInt16)32768
-
/*
|*
|* Konstruktor
diff --git a/sd/source/ui/func/fuprlout.cxx b/sd/source/ui/func/fuprlout.cxx
index 35cf5d4..037690d 100644
--- a/sd/source/ui/func/fuprlout.cxx
+++ b/sd/source/ui/func/fuprlout.cxx
@@ -75,8 +75,6 @@ SO2_DECL_REF(SvStorage)
TYPEINIT1( FuPresentationLayout, FuPoor );
-#define POOL_BUFFER_SIZE(sal_uInt16)32768
-#define DOCUMENT_BUFFER_SIZE(sal_uInt16)32768
#define DOCUMENT_TOKEN (sal_Unicode('#'))
/*
diff --git a/starmath/source/document.cxx b/starmath/source/document.cxx
index 5b00574..0ce9275 100644
--- a/starmath/source/document.cxx
+++ b/starmath/source/document.cxx
@@ -111,11 +111,6 @@ using namespace ::com::sun::star::lang;
using namespace ::com::sun::star::ucb;
using namespace ::com::sun::star::uno;
-
-#define DOCUMENT_BUFFER_SIZE(sal_uInt16)32768
-
-static const char pStarMathDoc[] = StarMathDocument;
-
#define SmDocShell
#include smslots.hxx
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'feature/new-autofilter-popup' - sc/inc sc/source
sc/inc/lookupcache.hxx |2
sc/source/core/data/table3.cxx | 15 --
sc/source/core/tool/interpr1.cxx | 51 ---
sc/source/filter/excel/excrecds.cxx | 20 -
sc/source/filter/inc/excrecds.hxx|2
sc/source/filter/xml/XMLExportDataPilot.cxx | 10 ++--
sc/source/filter/xml/XMLExportDatabaseRanges.cxx |4 -
sc/source/filter/xml/xmlfilti.cxx|6 +-
sc/source/ui/dbgui/filtdlg.cxx | 20 -
sc/source/ui/dbgui/pfiltdlg.cxx | 12 ++---
sc/source/ui/view/gridwin.cxx| 20 -
11 files changed, 87 insertions(+), 75 deletions(-)
New commits:
commit de9f1649fc5b7b2c8d662f082c1c3c514f55d5fe
Author: Kohei Yoshida kohei.yosh...@suse.com
Date: Fri Nov 4 12:18:47 2011 -0400
More on avoiding direct access to pStr, also fixed several memory leaks.
diff --git a/sc/inc/lookupcache.hxx b/sc/inc/lookupcache.hxx
index 01ab425..cdf3b42 100644
--- a/sc/inc/lookupcache.hxx
+++ b/sc/inc/lookupcache.hxx
@@ -110,7 +110,7 @@ public:
DBG_ERRORFILE( ScLookupCache::QueryCriteria not prepared
for this ScQueryOp);
}
if (rEntry.bQueryByString)
-setString( rEntry.pStr);
+setString(rEntry.GetQueryString());
else
setDouble( rEntry.nVal);
}
diff --git a/sc/source/core/data/table3.cxx b/sc/source/core/data/table3.cxx
index 8f3c985..ec9657f 100644
--- a/sc/source/core/data/table3.cxx
+++ b/sc/source/core/data/table3.cxx
@@ -1274,12 +1274,13 @@ bool ScTable::ValidQuery(SCROW nRow, const
ScQueryParam rParam,
}
if ( !bRealRegExp )
{
+rtl::OUString aQueryStr = rEntry.GetQueryString();
if ( rEntry.eOp == SC_EQUAL || rEntry.eOp == SC_NOT_EQUAL
|| rEntry.eOp == SC_CONTAINS || rEntry.eOp ==
SC_DOES_NOT_CONTAIN
|| rEntry.eOp == SC_BEGINS_WITH || rEntry.eOp ==
SC_ENDS_WITH
|| rEntry.eOp == SC_DOES_NOT_BEGIN_WITH || rEntry.eOp ==
SC_DOES_NOT_END_WITH )
{
-if ( !rEntry.bQueryByString rEntry.pStr-Len() == 0 )
+if (!rEntry.bQueryByString aQueryStr.isEmpty())
{
// #i18374# When used from functions (match, countif,
sumif, vlookup, hlookup, lookup),
// the query value is assigned directly, and the
string is empty. In that case,
@@ -1290,7 +1291,7 @@ bool ScTable::ValidQuery(SCROW nRow, const ScQueryParam
rParam,
}
else if ( bMatchWholeCell )
{
-bOk = pTransliteration-isEqual( aCellStr,
*rEntry.pStr );
+bOk = pTransliteration-isEqual(aCellStr, aQueryStr);
if ( rEntry.eOp == SC_NOT_EQUAL )
bOk = !bOk;
}
@@ -1300,7 +1301,7 @@ bool ScTable::ValidQuery(SCROW nRow, const ScQueryParam
rParam,
aCellStr, ScGlobal::eLnge, 0, aCellStr.Len(),
NULL ) );
String aQuer( pTransliteration-transliterate(
-*rEntry.pStr, ScGlobal::eLnge, 0,
rEntry.pStr-Len(),
+aQueryStr, ScGlobal::eLnge, 0,
aQueryStr.getLength(),
NULL ) );
xub_StrLen nIndex = (rEntry.eOp == SC_ENDS_WITH
|| rEntry.eOp == SC_DOES_NOT_END_WITH)?
(aCell.Len()-aQuer.Len()):0;
@@ -1337,7 +1338,7 @@ bool ScTable::ValidQuery(SCROW nRow, const ScQueryParam
rParam,
else
{ // use collator here because data was probably sorted
sal_Int32 nCompare = pCollator-compareString(
-aCellStr, *rEntry.pStr );
+aCellStr, aQueryStr);
switch (rEntry.eOp)
{
case SC_LESS :
@@ -1559,7 +1560,7 @@ static void lcl_PrepareQuery( ScDocument* pDoc, ScTable*
pTab, ScQueryParam rPa
{
sal_uInt32 nIndex = 0;
rEntry.bQueryByString = !( pDoc-GetFormatTable()-
-IsNumberFormat( *rEntry.pStr, nIndex, rEntry.nVal ) );
+IsNumberFormat(rEntry.GetQueryString(), nIndex,
rEntry.nVal));
if (rEntry.bQueryByDate)
{
if (!rEntry.bQueryByString ((nIndex %
SV_COUNTRY_LANGUAGE_OFFSET) != 0))
@@ -1903,7 +1904,9 @@ bool ScTable::CreateStarQuery(SCCOL nCol1, SCROW nRow1,
SCCOL nCol2, SCROW nRow2
// Vierte Spalte Wert
if (bValid)
{
-GetString(nCol1 + 3, nRow, *rEntry.pStr);
+String aStr;
[Libreoffice-commits] Changes to 'feature/fpicker-rework'
New branch 'feature/fpicker-rework' available with the following commits: commit 7963ee1d721864032d0c70b07cd824c593eca9f4 Author: Michael Meeks michael.me...@suse.com Date: Fri Nov 4 14:40:18 2011 + gtk: move the file-picker into vcl/ and add Application:: factory hooks drop un-necessary uno service related fluff, and component instantiation. nominal move to XMultiComponentFactory from XMultiServiceFactory Include fpicker in compilation for gtk3, but more work required here Simplify setting up transient parents for picker dialogs commit d1fd969050793ab48961ce2ceb13dc9c0920501b Author: Michael Meeks michael.me...@suse.com Date: Fri Nov 4 13:13:04 2011 + gtk: use a more sensibly unique version define ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: basic/source sd/source svx/source sw/source
basic/source/comp/exprtree.cxx |8 +++-
sd/source/ui/view/sdview2.cxx |2 +-
svx/source/svdraw/svdpage.cxx | 10 +-
sw/source/ui/dbui/dbmgr.cxx|4 +++-
4 files changed, 16 insertions(+), 8 deletions(-)
New commits:
commit 9b94d385f94562049bf93f2fc0dd0558d6a56dd1
Author: Ivan Timofeev timofeev@gmail.com
Date: Fri Nov 4 23:01:17 2011 +0400
cppcheck: avoid possible null pointer dereferences
diff --git a/basic/source/comp/exprtree.cxx b/basic/source/comp/exprtree.cxx
index 1c7ec1b..41caa05 100644
--- a/basic/source/comp/exprtree.cxx
+++ b/basic/source/comp/exprtree.cxx
@@ -983,8 +983,14 @@ SbiExpression* SbiExprList::Get( short n )
void SbiExprList::addExpression( SbiExpression* pExpr )
{
+if( !pFirst )
+{
+pFirst = pExpr;
+return;
+}
+
SbiExpression* p = pFirst;
-while( p p-pNext )
+while( p-pNext )
p = p-pNext;
p-pNext = pExpr;
diff --git a/sd/source/ui/view/sdview2.cxx b/sd/source/ui/view/sdview2.cxx
index 68e9a1f..b1a87b1 100644
--- a/sd/source/ui/view/sdview2.cxx
+++ b/sd/source/ui/view/sdview2.cxx
@@ -466,10 +466,10 @@ void View::DragFinished( sal_Int8 nDropAction )
nm--;
SdrMark* pM=mpDragSrcMarkList-GetMark(nm);
SdrObject* pObj=pM-GetMarkedSdrObj();
-sal_uInt32 nOrdNum=pObj-GetOrdNumDirect();
if( pObj pObj-GetPage() )
{
+sal_uInt32 nOrdNum=pObj-GetOrdNumDirect();
#ifdef DBG_UTIL
SdrObject* pChkObj =
#endif
diff --git a/svx/source/svdraw/svdpage.cxx b/svx/source/svdraw/svdpage.cxx
index 77f739b..63fe525 100644
--- a/svx/source/svdraw/svdpage.cxx
+++ b/svx/source/svdraw/svdpage.cxx
@@ -152,10 +152,10 @@ void SdrObjList::CopyObjects(const SdrObjList rSrcList)
SdrObject* pSO=rSrcList.GetObj(no);
SdrObject* pDO = pSO-Clone();
-pDO-SetModel(pModel);
-pDO-SetPage(pPage);
if (pDO!=NULL) {
+pDO-SetModel(pModel);
+pDO-SetPage(pPage);
NbcInsertObject(pDO,CONTAINER_APPEND,aReason);
} else {
nCloneErrCnt++;
@@ -425,11 +425,11 @@ SdrObject* SdrObjList::NbcRemoveObject(sal_uIntPtr
nObjNum)
SdrObject* pObj=maList[nObjNum];
RemoveObjectFromContainer(nObjNum);
-// flushViewObjectContacts() clears the VOC's and those invalidate
-pObj-GetViewContact().flushViewObjectContacts(true);
-
DBG_ASSERT(pObj!=NULL,Object zum Removen nicht gefunden);
if (pObj!=NULL) {
+// flushViewObjectContacts() clears the VOC's and those invalidate
+pObj-GetViewContact().flushViewObjectContacts(true);
+
DBG_ASSERT(pObj-IsInserted(),ZObjekt hat keinen Inserted-Status);
pObj-SetInserted(sal_False); // Ruft u.a. den UserCall
pObj-SetObjList(NULL);
diff --git a/sw/source/ui/dbui/dbmgr.cxx b/sw/source/ui/dbui/dbmgr.cxx
index a732303..cd0baba 100644
--- a/sw/source/ui/dbui/dbmgr.cxx
+++ b/sw/source/ui/dbui/dbmgr.cxx
@@ -1779,6 +1779,8 @@ sal_Bool SwNewDBMgr::GetColumnCnt(const String
rSourceName, const String rTabl
aData.nCommandType = -1;
pFound = FindDSData(aData, sal_False);
}
+if (!pFound)
+return sal_False;
//check validity of supplied record Id
if(pFound-aSelection.getLength())
{
@@ -1795,7 +1797,7 @@ sal_Bool SwNewDBMgr::GetColumnCnt(const String
rSourceName, const String rTabl
if(!bFound)
return sal_False;
}
-if(pFound pFound-xResultSet.is() !pFound-bAfterSelection)
+if(pFound-xResultSet.is() !pFound-bAfterSelection)
{
sal_Int32 nOldRow = 0;
try
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'feature/new-autofilter-popup' - 5 commits - sc/inc sc/source
sc/inc/queryparam.hxx |3 -
sc/source/core/data/table3.cxx | 83 +
sc/source/core/tool/queryparam.cxx | 12 -
3 files changed, 70 insertions(+), 28 deletions(-)
New commits:
commit 3ebf6c52dc469c199f090ac5190abebdc2934fad
Author: Kohei Yoshida kohei.yosh...@suse.com
Date: Fri Nov 4 16:13:17 2011 -0400
Do the simple string equality matching in ScQueryEntry instead.
diff --git a/sc/inc/queryparam.hxx b/sc/inc/queryparam.hxx
index 79330ae..f3d755c 100644
--- a/sc/inc/queryparam.hxx
+++ b/sc/inc/queryparam.hxx
@@ -72,7 +72,8 @@ public:
// creates pSearchParam and pSearchText if necessary, always RegExp!
utl::TextSearch* GetSearchTextPtr( bool bCaseSens ) const;
-boolMatchByString(const rtl::OUString rStr) const;
+boolIsQueryStringEmpty() const;
+boolMatchByString(const rtl::OUString rStr, bool bCaseSens)
const;
SC_DLLPUBLIC void SetQueryString(const rtl::OUString rStr);
SC_DLLPUBLIC rtl::OUString GetQueryString() const;
voidClear();
diff --git a/sc/source/core/data/table3.cxx b/sc/source/core/data/table3.cxx
index 4f0b540..7cae817 100644
--- a/sc/source/core/data/table3.cxx
+++ b/sc/source/core/data/table3.cxx
@@ -1077,7 +1077,7 @@ bool isQueryByValue(const ScTable rTable, const
ScQueryEntry rEntry, SCROW nRo
return rTable.HasValueData(static_castSCCOL(rEntry.nField), nRow);
}
-bool isTextMatchOnlyOp(const ScQueryEntry rEntry)
+bool isPartialTextMatchOp(const ScQueryEntry rEntry)
{
switch (rEntry.eOp)
{
@@ -1097,7 +1097,7 @@ bool isTextMatchOnlyOp(const ScQueryEntry rEntry)
bool isTextMatchOp(const ScQueryEntry rEntry)
{
-if (isTextMatchOnlyOp(rEntry))
+if (isPartialTextMatchOp(rEntry))
return true;
switch (rEntry.eOp)
@@ -1266,7 +1266,8 @@ bool ScTable::ValidQuery(SCROW nRow, const ScQueryParam
rParam,
else if (isQueryByString(*this, rEntry, nRow, pCell))
{
String aCellStr;
-if (isTextMatchOnlyOp(rEntry))
+if (isPartialTextMatchOp(rEntry))
+// may have to do partial textural comparison.
bMatchWholeCell = false;
if ( pCell )
@@ -1338,11 +1339,10 @@ bool ScTable::ValidQuery(SCROW nRow, const
ScQueryParam rParam,
}
if ( !bRealRegExp )
{
-// Simple string matching.
-rtl::OUString aQueryStr = rEntry.GetQueryString();
+// Simple string matching i.e. no regexp match.
if (isTextMatchOp(rEntry))
{
-if (!rEntry.bQueryByString aQueryStr.isEmpty())
+if (!rEntry.bQueryByString rEntry.IsQueryStringEmpty())
{
// #i18374# When used from functions (match, countif,
sumif, vlookup, hlookup, lookup),
// the query value is assigned directly, and the
string is empty. In that case,
@@ -1353,12 +1353,13 @@ bool ScTable::ValidQuery(SCROW nRow, const
ScQueryParam rParam,
}
else if ( bMatchWholeCell )
{
-bOk = pTransliteration-isEqual(aCellStr, aQueryStr);
+bOk = rEntry.MatchByString(aCellStr, rParam.bCaseSens);
if ( rEntry.eOp == SC_NOT_EQUAL )
bOk = !bOk;
}
else
{
+rtl::OUString aQueryStr = rEntry.GetQueryString();
String aCell( pTransliteration-transliterate(
aCellStr, ScGlobal::eLnge, 0, aCellStr.Len(),
NULL ) );
@@ -1400,7 +1401,7 @@ bool ScTable::ValidQuery(SCROW nRow, const ScQueryParam
rParam,
else
{ // use collator here because data was probably sorted
sal_Int32 nCompare = pCollator-compareString(
-aCellStr, aQueryStr);
+aCellStr, rEntry.GetQueryString());
switch (rEntry.eOp)
{
case SC_LESS :
diff --git a/sc/source/core/tool/queryparam.cxx
b/sc/source/core/tool/queryparam.cxx
index bfb31d2..ca7d3a2 100644
--- a/sc/source/core/tool/queryparam.cxx
+++ b/sc/source/core/tool/queryparam.cxx
@@ -33,6 +33,7 @@
#include queryparam.hxx
#include unotools/textsearch.hxx
+#include unotools/transliterationwrapper.hxx
using ::std::vector;
@@ -96,9 +97,16 @@ ScQueryEntry ScQueryEntry::operator=( const ScQueryEntry r
)
return *this;
}
-bool ScQueryEntry::MatchByString(const rtl::OUString rStr) const
+bool ScQueryEntry::IsQueryStringEmpty() const
{
-return rStr.equals(*pStr);
+return pStr-Len() == 0;
+}
+
+bool ScQueryEntry::MatchByString(const rtl::OUString rStr, bool
[Libreoffice-commits] .: scripting/source
scripting/source/pyprov/msgbox.py |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 974c15923465ebb2cc5c9c99180737298ed69c95 Author: Laurent Godard oooc...@free.fr Date: Fri Nov 4 15:02:34 2011 +0100 a very minor typo in a comment diff --git a/scripting/source/pyprov/msgbox.py b/scripting/source/pyprov/msgbox.py index c9ee80b..b276d76 100644 --- a/scripting/source/pyprov/msgbox.py +++ b/scripting/source/pyprov/msgbox.py @@ -96,7 +96,7 @@ class MsgBox(unohelper.Base): self.ButtonSize = size self.ButtonSpace = self.ButtonSize/2 else: -# boxsize i calculated form buttonsize +# boxsize is calculated from buttonsize self.boxSize = numberOfButtons * (self.ButtonSize + self.ButtonSpace) + self.ButtonSpace ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'feature/fpicker-rework' - 4 commits - cui/source .gitignore sfx2/inc sfx2/source vcl/AllLangResTarget_vcl.mk vcl/inc vcl/source vcl/unx
.gitignore | 17 ++
cui/source/options/optgdlg.cxx | 25 +---
sfx2/inc/sfx2/filedlghelper.hxx|1
sfx2/source/dialog/filedlghelper.cxx | 10 -
vcl/AllLangResTarget_vcl.mk|1
vcl/inc/salinst.hxx|2
vcl/inc/svids.hrc | 19 +++
vcl/inc/unx/gtk/gtkinst.hxx|2
vcl/inc/vcl/svapp.hxx |4
vcl/source/app/svapp.cxx |6 +
vcl/source/src/fpicker.src | 92
vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx | 78 +++--
vcl/unx/gtk/fpicker/SalGtkFilePicker.hxx |1
vcl/unx/gtk/fpicker/SalGtkFolderPicker.cxx | 15 --
vcl/unx/gtk/fpicker/SalGtkPicker.cxx |8 -
vcl/unx/gtk/fpicker/resourceprovider.cxx | 165 ++---
16 files changed, 238 insertions(+), 208 deletions(-)
New commits:
commit 5e5ef2f7578808250c0dcf180de4b8ef95bb0c8e
Author: Michael Meeks michael.me...@suse.com
Date: Fri Nov 4 22:32:52 2011 +
gtk3: port file-picker, using more standard combobox APIs etc.
diff --git a/vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx
b/vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx
index 7ffcb69..fb88175 100644
--- a/vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx
+++ b/vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx
@@ -59,8 +59,6 @@
#include gtk/fpicker/resourceprovider.hxx
#include gtk/fpicker/SalGtkFilePicker.hxx
-#if !GTK_CHECK_VERSION(3,0,0)
-
//
// namespace directives
//
@@ -211,7 +209,14 @@ SalGtkFilePicker::SalGtkFilePicker( const uno::Reference
uno::XComponentContext
m_pAligns[i] = gtk_alignment_new(0, 0, 0, 1);
-m_pLists[i] = gtk_combo_box_new_text();
+m_pListStores[i] = gtk_list_store_new (1, G_TYPE_STRING);
+m_pLists[i] =
gtk_combo_box_new_with_model(GTK_TREE_MODEL(m_pListStores[i]));
+g_object_unref (m_pListStores[i]); // owned by the widget.
+GtkCellRenderer *pCell = gtk_cell_renderer_text_new ();
+gtk_cell_layout_pack_start(
+GTK_CELL_LAYOUT(m_pLists[i]), pCell, TRUE);
+gtk_cell_layout_set_attributes(
+GTK_CELL_LAYOUT (m_pLists[i]), pCell, text, 0, NULL);
m_pListLabels[i] = gtk_label_new( );
@@ -497,8 +502,16 @@ dialog_remove_buttons( GtkDialog *pDialog )
{
g_return_if_fail( GTK_IS_DIALOG( pDialog ) );
+GtkWidget *pActionArea;
+
+#if GTK_CHECK_VERSION(3,0,0)
+pActionArea = gtk_dialog_get_action_area( pDialog );
+#else
+pActionArea = pDialog-action_area;
+#endif
+
GList *pChildren =
-gtk_container_get_children( GTK_CONTAINER( pDialog-action_area ) );
+gtk_container_get_children( GTK_CONTAINER( pActionArea ) );
for( GList *p = pChildren; p; p = p-next )
gtk_widget_destroy( GTK_WIDGET( p-data ) );
@@ -1136,14 +1149,20 @@ GtkWidget *SalGtkFilePicker::getWidget( sal_Int16
nControlId, GType *pType )
//
// XFilePickerControlAccess functions
//
-namespace
+static void HackWidthToFirst(GtkComboBox *pWidget)
{
-void HackWidthToFirst(GtkComboBox *pWidget)
-{
-GtkRequisition requisition;
-gtk_widget_size_request(GTK_WIDGET(pWidget), requisition);
-gtk_widget_set_size_request(GTK_WIDGET(pWidget), requisition.width,
-1);
-}
+GtkRequisition requisition;
+gtk_widget_size_request(GTK_WIDGET(pWidget), requisition);
+gtk_widget_set_size_request(GTK_WIDGET(pWidget), requisition.width, -1);
+}
+
+static void ComboBoxAppendText(GtkComboBox *pCombo, const rtl::OUString rStr)
+{
+ GtkTreeIter aIter;
+ GtkListStore *pStore = GTK_LIST_STORE(gtk_combo_box_get_model(pCombo));
+ rtl::OString aStr = rtl::OUStringToOString(rStr, RTL_TEXTENCODING_UTF8);
+ gtk_list_store_append(pStore, aIter);
+ gtk_list_store_set(pStore, aIter, 0, aStr.getStr(), -1);
}
void SalGtkFilePicker::HandleSetListValue(GtkComboBox *pWidget, sal_Int16
nControlAction, const uno::Any rValue)
@@ -1154,7 +1173,7 @@ void SalGtkFilePicker::HandleSetListValue(GtkComboBox
*pWidget, sal_Int16 nContr
{
OUString sItem;
rValue = sItem;
-gtk_combo_box_append_text(pWidget,
rtl::OUStringToOString(sItem, RTL_TEXTENCODING_UTF8).getStr());
+ComboBoxAppendText(pWidget, sItem);
if (!bVersionWidthUnset)
{
HackWidthToFirst(pWidget);
@@ -1169,8 +1188,7 @@ void SalGtkFilePicker::HandleSetListValue(GtkComboBox
*pWidget, sal_Int16 nContr
sal_Int32 nItemCount = aStringList.getLength();
for (sal_Int32 i =
[Libreoffice-commits] .: 4 commits - reportbuilder/util scripting/source solenv/gbuild swext/Extension_wiki-publisher.mk
reportbuilder/util/description-en-US.txt |2 - scripting/source/pyprov/description-en-US.txt |1 solenv/gbuild/AllLangResTarget.mk |5 +- solenv/gbuild/Configuration.mk|2 - solenv/gbuild/Extension.mk| 46 +++--- solenv/gbuild/SdiTarget.mk|3 + solenv/gbuild/gbuild.mk |2 - solenv/gbuild/platform/android.mk |3 - solenv/gbuild/platform/ios.mk | 16 - solenv/gbuild/platform/macosx.mk | 16 - solenv/gbuild/platform/solaris.mk | 16 - solenv/gbuild/platform/unxgcc.mk | 16 - solenv/gbuild/platform/windows.mk | 18 -- solenv/gbuild/platform/winmingw.mk| 15 swext/Extension_wiki-publisher.mk |1 15 files changed, 49 insertions(+), 113 deletions(-) New commits: commit 3fc888c2c518631d80d46e1d260378f810b3d7fe Author: Michael Stahl mst...@redhat.com Date: Fri Nov 4 23:14:46 2011 +0100 gbuild: clean up pointless proliferation of PRECOMMANDs, all alike diff --git a/solenv/gbuild/AllLangResTarget.mk b/solenv/gbuild/AllLangResTarget.mk index 5e0f89a..ba714df 100644 --- a/solenv/gbuild/AllLangResTarget.mk +++ b/solenv/gbuild/AllLangResTarget.mk @@ -48,9 +48,8 @@ # SrsPartMergeTarget class gb_SrsPartMergeTarget_TRANSEXTARGET := $(call gb_Executable_get_target_for_build,transex3) -# gb_SrsPartMergeTarget_TRANSEXPRECOMMAND is set by the platforms - -gb_SrsPartMergeTarget_TRANSEXCOMMAND := $(gb_SrsPartMergeTarget_TRANSEXPRECOMMAND) $(gb_SrsPartMergeTarget_TRANSEXTARGET) +gb_SrsPartMergeTarget_TRANSEXCOMMAND := \ + $(gb_Helper_set_ld_path) $(gb_SrsPartMergeTarget_TRANSEXTARGET) gb_SrsPartMergeTarget_SDFLOCATION := $(SRCDIR)/translations/$(INPATH)/misc/sdf/ define gb_SrsPartMergeTarget__command diff --git a/solenv/gbuild/Configuration.mk b/solenv/gbuild/Configuration.mk index 21497f5..c08719d 100644 --- a/solenv/gbuild/Configuration.mk +++ b/solenv/gbuild/Configuration.mk @@ -223,7 +223,7 @@ $(call gb_XcuLangpackTarget_get_outdir_target,%) : gb_XcuMergeTarget_CFGEXTARGET := $(call gb_Executable_get_target,cfgex) gb_XcuMergeTarget_CFGEXCOMMAND := \ - $(gb_CFGEXPRECOMMAND) $(gb_XcuMergeTarget_CFGEXTARGET) + $(gb_Helper_set_ld_path) $(gb_XcuMergeTarget_CFGEXTARGET) gb_XcuMergeTarget_SDFLOCATION := $(SRCDIR)/translations/$(INPATH)/misc/sdf/ # PRJNAME is computed from the stem (parameter $(2)) diff --git a/solenv/gbuild/Extension.mk b/solenv/gbuild/Extension.mk index aecae5e..5b9267f 100644 --- a/solenv/gbuild/Extension.mk +++ b/solenv/gbuild/Extension.mk @@ -35,7 +35,7 @@ gb_Extension_LICENSEFILE := LICENSE endif gb_Extension_XRMEXTARGET := $(call gb_Executable_get_target,xrmex) gb_Extension_XRMEXCOMMAND := \ - $(gb_XRMEXPRECOMMAND) $(gb_Extension_XRMEXTARGET) + $(gb_Helper_set_ld_path) $(gb_Extension_XRMEXTARGET) gb_Extension_SDFLOCATION := $(SRCDIR)/translations/$(INPATH)/misc/sdf/ # does not contain en-US because it is special cased in gb_Extension_Extension gb_Extension_LANGS := $(filter-out en-US,$(gb_WITH_LANG)) diff --git a/solenv/gbuild/SdiTarget.mk b/solenv/gbuild/SdiTarget.mk index f8d7b4c..d1fa175 100644 --- a/solenv/gbuild/SdiTarget.mk +++ b/solenv/gbuild/SdiTarget.mk @@ -33,7 +33,8 @@ # SdiTarget class gb_SdiTarget_SVIDLTARGET := $(call gb_Executable_get_target_for_build,svidl) -gb_SdiTarget_SVIDLCOMMAND := $(gb_SdiTarget_SVIDLPRECOMMAND) $(gb_SdiTarget_SVIDLTARGET) +gb_SdiTarget_SVIDLCOMMAND := \ + $(gb_Helper_set_ld_path) $(gb_SdiTarget_SVIDLTARGET) $(call gb_SdiTarget_get_target,%) : $(SRCDIR)/%.sdi | $(gb_SdiTarget_SVIDLTARGET) $(call gb_Output_announce,$*,$(true),SDI,1) diff --git a/solenv/gbuild/gbuild.mk b/solenv/gbuild/gbuild.mk index 4be10a4..9a47723 100644 --- a/solenv/gbuild/gbuild.mk +++ b/solenv/gbuild/gbuild.mk @@ -352,7 +352,7 @@ gb_XSLTPROCTARGET := gb_XSLTPROC := xsltproc else gb_XSLTPROCTARGET := $(call gb_Executable_get_target_for_build,xsltproc) -gb_XSLTPROC := $(gb_XSLTPROCPRECOMMAND) $(gb_XSLTPROCTARGET) +gb_XSLTPROC := $(gb_Helper_set_ld_path) $(gb_XSLTPROCTARGET) endif ifeq ($(SYSTEM_PYTHON),YES) diff --git a/solenv/gbuild/platform/android.mk b/solenv/gbuild/platform/android.mk index 8bf5acc..03f85ec 100644 --- a/solenv/gbuild/platform/android.mk +++ b/solenv/gbuild/platform/android.mk @@ -60,10 +60,4 @@ gb_UnoApiTarget_CPPUMAKERCOMMAND := $(gb_Helper_set_ld_path) SOLARBINDIR=$(OUTDI gb_UnoApiTarget_REGVIEWTARGET := $(OUTDIR_FOR_BUILD)/bin/regview gb_UnoApiTarget_REGVIEWCOMMAND := $(gb_Helper_set_ld_path) SOLARBINDIR=$(OUTDIR_FOR_BUILD)/bin $(gb_UnoApiTarget_REGVIEWTARGET) -# Configuration -gb_CFGEXPRECOMMAND := $(gb_Helper_set_ld_path) - -# Extension -gb_XRMEXPRECOMMAND := $(gb_Helper_set_ld_path) - # vim: set noet sw=4: diff --git a/solenv/gbuild/platform/ios.mk
[Libreoffice-commits] .: Branch 'feature/new-autofilter-popup' - 2 commits - sc/inc sc/source
sc/inc/queryparam.hxx |9 +++-
sc/source/core/data/table3.cxx |2 +
sc/source/core/tool/queryparam.cxx | 70 +
sc/source/ui/inc/gridwin.hxx |7 ++-
sc/source/ui/view/gridwin.cxx |2 +
sc/source/ui/view/gridwin2.cxx |4 ++
sc/source/ui/view/tabview.cxx |4 ++
7 files changed, 78 insertions(+), 20 deletions(-)
New commits:
commit be16da1407b237b18accc39f566b8a8509d66bf0
Author: Kohei Yoshida kohei.yosh...@suse.com
Date: Fri Nov 4 22:36:32 2011 -0400
Temporarily disabling the new autofilter popup due to a set-back.
Ugh! I need to refactor the query validation code first before working
on the new popup. I will
1) temporarily disable the new autofilter popup,
2) merge my changes so far to master, and
3) work on refactoring the query validation code without changing the
current functionality, then come back to working on the new popup.
Darn...
diff --git a/sc/source/ui/inc/gridwin.hxx b/sc/source/ui/inc/gridwin.hxx
index 00827d9..4271df2 100644
--- a/sc/source/ui/inc/gridwin.hxx
+++ b/sc/source/ui/inc/gridwin.hxx
@@ -42,6 +42,8 @@
#include memory
#include boost/scoped_ptr.hpp
+#define USE_NEW_AUTOFILTER 0
+
// ---
struct ScTableInfo;
@@ -341,8 +343,10 @@ public:
voidLaunchDataSelectMenu( SCCOL nCol, SCROW nRow, bool
bDataSelect );
voidDoScenarioMenue( const ScRange rScenRange );
-
+#if USE_NEW_AUTOFILTER
voidLaunchAutoFilterMenu(SCCOL nCol, SCROW nRow);
+voidUpdateAutoFilterFromMenu();
+#endif
voidLaunchPageFieldMenu( SCCOL nCol, SCROW nRow );
voidLaunchDPFieldMenu( SCCOL nCol, SCROW nRow );
@@ -379,7 +383,6 @@ public:
voidCheckNeedsRepaint();
-voidUpdateAutoFilterFromMenu();
voidUpdateDPFromFieldPopupMenu();
voidUpdateVisibleRange();
diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index dc7ff54..8293b6f 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -585,6 +585,7 @@ void ScGridWindow::ExecPageFieldSelect( SCCOL nCol, SCROW
nRow, sal_Bool bHasSel
}
}
+#if USE_NEW_AUTOFILTER
namespace {
class PopupAction : public ScMenuFloatingWindow::Action
@@ -700,6 +701,7 @@ void ScGridWindow::UpdateAutoFilterFromMenu()
pViewData-GetView()-Query(aParam, NULL, true);
pDBData-SetQueryParam(aParam);
}
+#endif
void ScGridWindow::LaunchPageFieldMenu( SCCOL nCol, SCROW nRow )
{
diff --git a/sc/source/ui/view/gridwin2.cxx b/sc/source/ui/view/gridwin2.cxx
index 2688e04..a3ecaae 100644
--- a/sc/source/ui/view/gridwin2.cxx
+++ b/sc/source/ui/view/gridwin2.cxx
@@ -165,7 +165,11 @@ bool ScGridWindow::DoAutoFilterButton( SCCOL nCol, SCROW
nRow, const MouseEvent
HideCursor();
mpFilterButton-draw();
ShowCursor();
+#if USE_NEW_AUTOFILTER
LaunchAutoFilterMenu(nCol, nRow);
+#else
+LaunchDataSelectMenu(nCol, nRow, false);
+#endif
return true;
}
diff --git a/sc/source/ui/view/tabview.cxx b/sc/source/ui/view/tabview.cxx
index 6e6863a..6804c36 100644
--- a/sc/source/ui/view/tabview.cxx
+++ b/sc/source/ui/view/tabview.cxx
@@ -2403,10 +2403,14 @@ void ScTabView::StartDataSelect()
aViewData.GetDocument()-GetAttr(
nCol, nRow, aViewData.GetTabNo(), ATTR_MERGE_FLAG));
+#if USE_NEW_AUTOFILTER
if (pAttr-HasAutoFilter())
pWin-LaunchAutoFilterMenu(nCol, nRow);
else
pWin-LaunchDataSelectMenu(nCol, nRow, true);
+#else
+pWin-LaunchDataSelectMenu(nCol, nRow, !pAttr-HasAutoFilter());
+#endif
}
void ScTabView::EnableRefInput(bool bFlag)
commit 7c387721b5de40d5a58189a9f05ebdcbea28d395
Author: Kohei Yoshida kohei.yosh...@suse.com
Date: Fri Nov 4 21:25:49 2011 -0400
Hide the query strings member, and add relevant methods for it.
diff --git a/sc/inc/queryparam.hxx b/sc/inc/queryparam.hxx
index f3d755c..6b87397 100644
--- a/sc/inc/queryparam.hxx
+++ b/sc/inc/queryparam.hxx
@@ -52,9 +52,8 @@ namespace utl {
struct ScQueryEntry
{
-private:
-String* pStr;
-public:
+typedef std::vectorrtl::OUString QueryStringsType;
+
boolbDoQuery;
boolbQueryByString;
boolbQueryByDate;
@@ -74,11 +73,15 @@ public:
boolIsQueryStringEmpty() const;
boolMatchByString(const rtl::OUString rStr, bool bCaseSens)
const;
+voidSwapQueryStrings(QueryStringsType rStrings);
+voidSortQueryStrings(bool bCaseSens);
SC_DLLPUBLIC void SetQueryString(const rtl::OUString rStr);
SC_DLLPUBLIC rtl::OUString GetQueryString() const;
voidClear();
ScQueryEntry operator=( const ScQueryEntry r );
bool
[Libreoffice-commits] .: Branch 'feature/new-autofilter-popup' - 0 commits -
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 3 commits - sc/inc sc/Library_sc.mk sc/qa sc/source
sc/Library_sc.mk |1
sc/inc/lookupcache.hxx | 43
sc/inc/queryentry.hxx| 78
sc/inc/queryparam.hxx| 48 -
sc/qa/unit/ucalc.cxx |1
sc/source/core/data/dociter.cxx |1
sc/source/core/data/documen3.cxx |1
sc/source/core/data/dpcachetable.cxx |1
sc/source/core/data/dpobject.cxx |2
sc/source/core/data/dpshttab.cxx |1
sc/source/core/data/dptablecache.cxx |1
sc/source/core/data/table2.cxx |1
sc/source/core/data/table3.cxx |1
sc/source/core/inc/interpre.hxx | 31 ---
sc/source/core/tool/dbdata.cxx |1
sc/source/core/tool/doubleref.cxx|1
sc/source/core/tool/interpr1.cxx | 31 +++
sc/source/core/tool/lookupcache.cxx | 43
sc/source/core/tool/queryentry.cxx | 191
sc/source/core/tool/queryparam.cxx | 212 ++-
sc/source/filter/excel/excimp8.cxx |1
sc/source/filter/excel/excrecds.cxx |1
sc/source/filter/xml/XMLExportDataPilot.cxx |1
sc/source/filter/xml/XMLExportDatabaseRanges.cxx |1
sc/source/filter/xml/xmldrani.cxx|1
sc/source/filter/xml/xmlfilti.cxx|1
sc/source/ui/dbgui/filtdlg.cxx |1
sc/source/ui/dbgui/pfiltdlg.cxx |1
sc/source/ui/docshell/dbdocfun.cxx |1
sc/source/ui/unoobj/cellsuno.cxx |1
sc/source/ui/unoobj/datauno.cxx |2
sc/source/ui/vba/vbarange.cxx|1
sc/source/ui/view/cellsh2.cxx|2
sc/source/ui/view/dbfunc.cxx |1
sc/source/ui/view/dbfunc3.cxx|1
sc/source/ui/view/gridwin.cxx|1
sc/source/ui/view/gridwin4.cxx |1
37 files changed, 412 insertions(+), 297 deletions(-)
New commits:
commit 9c8670847f0945c05c8f40e83f0d845c0d3cff6b
Author: Kohei Yoshida kohei.yosh...@suse.com
Date: Sat Nov 5 01:05:29 2011 -0400
Removed queryentry.hxx include from lookupcache.hxx header.
For better encapsulation of ScQueryEntry.
diff --git a/sc/inc/lookupcache.hxx b/sc/inc/lookupcache.hxx
index 49b5def..d70b1b5 100644
--- a/sc/inc/lookupcache.hxx
+++ b/sc/inc/lookupcache.hxx
@@ -32,7 +32,6 @@
#include address.hxx
#include global.hxx
#include queryparam.hxx
-#include queryentry.hxx
#include formula/token.hxx
#include svl/listener.hxx
#include tools/string.hxx
@@ -91,45 +90,9 @@ public:
public:
-explicit QueryCriteria( const ScQueryEntry rEntry ) :
-mfVal(0.0), mbAlloc(false), mbString(false)
-{
-switch (rEntry.eOp)
-{
-case SC_EQUAL :
-meOp = EQUAL;
-break;
-case SC_LESS_EQUAL :
-meOp = LESS_EQUAL;
-break;
-case SC_GREATER_EQUAL :
-meOp = GREATER_EQUAL;
-break;
-default:
-meOp = UNKNOWN;
-DBG_ERRORFILE( ScLookupCache::QueryCriteria not prepared
for this ScQueryOp);
-}
-if (rEntry.bQueryByString)
-setString(rEntry.GetQueryString());
-else
-setDouble( rEntry.nVal);
-}
-QueryCriteria( const QueryCriteria r ) :
-mfVal( r.mfVal),
-mbAlloc( false),
-mbString( false),
-meOp( r.meOp)
-{
-if (r.mbString r.mpStr)
-{
-mpStr = new String( *r.mpStr);
-mbAlloc = mbString = true;
-}
-}
-~QueryCriteria()
-{
-deleteString();
-}
+explicit QueryCriteria( const ScQueryEntry rEntry );
+QueryCriteria( const QueryCriteria r );
+~QueryCriteria();
QueryOp getQueryOp() const { return meOp; }
diff --git a/sc/source/core/tool/lookupcache.cxx
b/sc/source/core/tool/lookupcache.cxx
index 1fbc1ec..3c82a2a 100644
--- a/sc/source/core/tool/lookupcache.cxx
+++ b/sc/source/core/tool/lookupcache.cxx
@@ -31,6 +31,49 @@
#include lookupcache.hxx
#include document.hxx
+#include queryentry.hxx
+
+ScLookupCache::QueryCriteria::QueryCriteria( const ScQueryEntry rEntry ) :
+mfVal(0.0), mbAlloc(false), mbString(false)
+{
+switch (rEntry.eOp)
+{
+case SC_EQUAL :
+meOp = EQUAL;
+break;
+case SC_LESS_EQUAL :
+meOp = LESS_EQUAL;
+break;
+
[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 36991, which changed state. Bug 36991 Summary: crash when duplicating draw page with linked wmf pictures https://bugs.freedesktop.org/show_bug.cgi?id=36991 What|Old Value |New Value Resolution|FIXED | Status|RESOLVED|REOPENED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-qa] [libreoffice-projects] [ANN] LibreOffice 3.4.4 RC2 available
Hi Peter, *, Petr Mladek schrieb: Hello Heinz, On Thu, 2011-11-03 at 08:20 +0100, Heinz W. Simoneit wrote: drew schrieb: On Wed, 2011-11-02 at 17:24 +0100, Heinz W. Simoneit wrote: tried basics in (de-) - writer - calc - base (MySQL-DB) without any probs. One minor flaw in base: When opening a table by double-click it doesn't stay opened -- you have to right-click and open. Running Ubuntu 10.10 (AMD64), Gnome - no problem opening a table with dbl-click? (only checked for embedded DB and SQLite w/ODBC) running Debian testing (AMD64), KDE 4.6.5, MySQL Connector. When dbl-clicking table opens and closes at once. Right-click and open works fine. Great catch! I wonder if it is something new in 3.4.4 or if it was already in 3.4.3 or other earlier releases. didn'thave this issue in 3.4.3 -- but in earlier releases. Also, I wonder if it happens only with the MySQL connector (3rd party exstension?) or if you see it also with other database drivers. I'm using MySQL connector eternally. Tried ODBC with early OOo without great success... MySQL connector now: 1.0.1 Anyway, please, report it into bugzilla. Will do it later on. Thanks for testing and feedback. Welcome! :-) Best, Heinz -- Have a nice time! ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] String-rtl::OUString and removed unused code in vcl
On 11/03/2011 09:30 AM, Stephan Bergmann wrote:
On 11/03/2011 01:40 AM, August Sodora wrote:
It seems to me that class ApplicationAddress in vcl/svapp.hxx is
unused and that ApplicationEvent has two useless fields, one for the
application address and another string that is always empty and never
compared against or modified. I've attached a patch that cleans this
up a little bit and switches from String to rtl::OUString but
unfortunately I cannot compile the code that is in aqua, etc. Does
someone who has this capability mind building this and making sure
that nothing broke in those few areas?
Pushed now as
http://cgit.freedesktop.org/libreoffice/core/commit/?id=e04249337551653f63ba9b2a2302578961e38562.
Some notes:
- Changed the code in sfx2/source/appl/appdde.cxx again, so that it does
not replace '\n'-' ' within ''-quoted substrings. That's how the
original appears to have worked.
- Added
http://cgit.freedesktop.org/libreoffice/core/commit/?id=fb17dce09e29c4518129587d347cc3787f74c396
so that newly introduced ...append('\n') does the right thing
(traditionally, that would have been written as
...append(sal_Unicode('\n'))).
- Not sure whether changing ApplicationEvent::aEvent from UTF-8 to
UTF-16 is really useful, but changed that afterwards with
http://cgit.freedesktop.org/libreoffice/core/commit/?id=e66e54fb00bf74d13b7059bd32b6207a029afa5e
anyway, more aggressively optimizing aEvent into an enum.
- August, http://wiki.documentfoundation.org/Development/Developers
does not have a link in the License column for you. Can you please
add one? (And I assume your contributions are the standard LGPL3+/MPL1.1?)
Thanks again,
Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Extension dependencies
Hi all, As already mentioned briefly in my talk at LOCon, we need to make up our mind how to handle LO extension dependencies. Each .oxt extension can carry any number of dependencies, specifying conditions that need to be met by the hosting LO installation for the extension to be successfully deployable (see http://wiki.services.openoffice.org/wiki/Documentation/DevGuide/Extensions/Dependencies). The mechanism was designed to allow for any number of fine-grained dependency specifications (this extension requires availability of com.sun.star.whatever.Service), but only a coarse-grained OpenOffice.org-minimal-version ever got defined (and also a maximal-version one). After all, it is hard (or at least tedious) for extension developers to come up with a precise list of features they depend on, which would be needed to specify a precise list of fine-grained dependencies. A single minimal-version dependency appeared so much easier to use. The OpenOffice.org-minimal-version dependency worked fine as long as OOo was the de-facto standard, with derivatives tracking OOo development rather closely and producing new versions in sync with upstream OOo. The minimal-version dependency's version value was to be interpreted as the version of the underlying OOo reference version, so even if a derivative used a different versioning scheme everything worked out. An extension developed for one product could also be deployed in a different one (at least in theory; of course there are always minor glitches that spoil the picture). Now, LO and OOo (now AOOo) are no longer in such close relation. LO is heading towards its version 3.5 already while AOOo did not yet publish its version 3.4, and new features are routinely added to LO that are unlikely to be included into AOOo. This leads to the following items: ** How shall LO handle the OpenOffice.org-minimal-version dependency? Strictly speaking, LO 3.4/3.5 should still check against an OpenOffice.org-minimal-version value of 3.3, as that's the latest available (A)OOo version. However, for LO 3.4, this check has (probably accidentally) been changed to 3.4 (and with the current code towards LO 3.5 it has yet again changed to 3.5). I would argue to leave it at 3.4 for both LO 3.4 and LO 3.5. (For one, it can obviously no longer be changed back to 3.3 for LO 3.4, and changing it back to 3.3 for LO 3.5 would probably cause more confusion than its worth. For another, semantically the check will likely be more-or-less correct, matching the features an AOOo 3.4 will presumably come out with.) If no one objects, I will adapt LO 3.5 so that it still checks for 3.4, not 3.5. In the future, when AOOo releases new versions after AOOo 3.4, we would need to check whether it semantically makes sense for LO to bump its OpenOffice.org-minimal-version check (i.e., whether the features of that new AOOo version are also available in LO). ** How to specify dependencies for newly introduced LO features? One option would be to add an additional LibreOffice-minimal-version dependency. Another option would be to actually make use of fine-grained dependencies and introduce them as needed (i.e., whenever an extension developer wants to make use of a new LO feature, a corresponding dependency would have to be added). The former has as pro its ease of use. The latter has as pro that it shows a way out of the problems caused by OpenOffice.org-minimal-version and for an opportunity of continued sharing of extensions across products: If each extension only lists the features it requires, regardless of any product's version numbers, it becomes much easier to match that extension against a given product's capabilities, regardless of brand. I'd tend to give the fine-grained dependencies a try. That would require cooperation from extension developers (they would need to voice their demand for dependencies for specific features, and they would need to make accurate use of those dependencies in their extensions). To achieve cross-product extension compatibility, it would also require some sort of advertising of LO's newly introduced fine-grained dependencies (so that other products---where possible---would pick them up together with the corresponding features), but we would need a place to document any newly introduced dependencies, anyway. What do other people think here? ** What happens when LO 4 becomes incompatible? In that case, any OpenOffice.org-minimal-version dependency, regardless of version value, should be considered as not satisfied by LO 4. Similarly, if we did introduce a LibreOffice.org-minimal-version dependency, any version value of that dependency less than 4 should be considered as not satisfied. On the other hand, treatment of any fine-grained dependencies would have to be handled on a case-by-case basis. Stephan ___ LibreOffice mailing list
Re: [Libreoffice] [Libreoffice-qa] [libreoffice-projects] [ANN] LibreOffice 3.4.4 RC2 available
Heinz W. Simoneit píše v Pá 04. 11. 2011 v 08:27 +0100: Petr Mladek schrieb: I wonder if it is something new in 3.4.4 or if it was already in 3.4.3 or other earlier releases. didn'thave this issue in 3.4.3 -- but in earlier releases. I am a bit mixed. Did it work in 3.4.3? Was it broken in an earlier version? What was the earlier version? It sounds strange if it worked in 3.4.3, was broken in older versions and got broken again in 3.4.4. Also, I wonder if it happens only with the MySQL connector (3rd party exstension?) or if you see it also with other database drivers. I'm using MySQL connector eternally. Tried ODBC with early OOo without great success... MySQL connector now: 1.0.1 I see :-( Anyway, please, report it into bugzilla. Will do it later on. Thanks a lot in advance. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-qa] [libreoffice-projects] [ANN] LibreOffice 3.4.4 RC2 available
Hi Petr (sic!), *, Petr Mladek schrieb: Heinz W. Simoneit píše v Pá 04. 11. 2011 v 08:27 +0100: Petr Mladek schrieb: I wonder if it is something new in 3.4.4 or if it was already in 3.4.3 or other earlier releases. didn'thave this issue in 3.4.3 -- but in earlier releases. I am a bit mixed. Did it work in 3.4.3? Was it broken in an earlier version? What was the earlier version? It sounds strange if it worked in 3.4.3, was broken in older versions and got broken again in 3.4.4. sorry! :-) It worked in 3.4.3. Before that I tried 3.3. and some versions out of the Debian-repo. One of them was broken too - i don't exactly remember which one. :-[ Best, Heinz -- Have a nice time! ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 --- Comment #227 from Petr Mladek pmla...@suse.cz 2011-11-04 03:57:29 PDT --- (In reply to comment #224) Nominating Bug 40990. Entering array formulas in LO 3.4.3 with big ranges draw a lot of ressources. With a range around a thousand cells it eventually crashes. This shold be fixed otherwise using array formulas with vast ranges will be obsolete. Such performance improvement would be too big change for 3.4. It affects only limited group of users, so it even does not belong to the most annoying bugs. Kohei will try to fix it for LO-3.5. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [ANN] LibreOffice 3.4.4 RC2 available
Dear Community, The Document Foundation is happy to announce the second release candidate of LibreOffice 3.4.4. The upcoming 3.4.4 will be the fourth in a series of frequent bugfix releases for our 3.4 code line. Please be aware that LibreOffice 3.4.4 RC2 is not yet ready for production use, you should continue to use LibreOffice 3.3.4 and 3.4.3 for that. The release is available for Windows, Linux and Mac OS X from our QA builds download page at http://www.libreoffice.org/download/pre-releases/ Should you find bugs, please report them to the FreeDesktop Bugzilla: https://bugs.freedesktop.org For other ways to get involved with this exciting project - you can e.g. contribute code: https://www.libreoffice.org/get-involved/developers/ translate LibreOffice to your language: http://wiki.documentfoundation.org/Translation_for_3.4 or help with funding our operations: http://challenge.documentfoundation.org/ A list of known issues with 3.4.4 RC2 is available from our wiki: http://wiki.documentfoundation.org/Releases/3.4.4/RC2 Please find the list of changes against LibreOffice 3.4.4 RC1 here: http://download.documentfoundation.org/libreoffice/src/bugfixes-libreoffice-3-4-4-release-3.4.4.2.log Let us close again with a BIG Thank You! to all of you having contributed to the LibreOffice project - this release would not have been possible without your help. Yours, The Document Foundation Board pgp9E7Hbf3QNV.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Remove obsolete IsWin95A function
Hi all, This patch removes an obsolete Win95 function. Thanks, -- Jesús Corrius Deputy of the Board of Directors The Document Foundation Mobile: +34 661 11 38 26 Skype: jcorrius | Twitter: @jcorrius 0001-Remove-obsolete-IsWin95A-function.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Extension dependencies
Stephan Bergmann wrote: As already mentioned briefly in my talk at LOCon, we need to make up our mind how to handle LO extension dependencies. Skipping most of this - I'd tend to give the fine-grained dependencies a try. That won't work in practice, unless those can be (semi-)automatically generated. Experience shows that all programmers are lazy, and seldomly go extra miles. Having a simple version string, and some volunteers testing uploaded extensions on the extension repo sounds much more workable - and useful in practice, since no syntactic compatibility one could come up with would ensure semantic equality... Cheers, -- Thorsten pgp8m7dzjiqVo.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Extension dependencies
Hi, On Friday, 2011-11-04 13:02:02 +0100, Thorsten Behrens wrote: I'd tend to give the fine-grained dependencies a try. That won't work in practice, unless those can be (semi-)automatically generated. Experience shows that all programmers are lazy, and seldomly go extra miles. Seconded, but some do, if it's achievable without a hyper-duper incomprehensible framework.. Would it be possible to have both, a simple version dependency, and if fine grained dependencies are present use those as well? Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgpnxb0QokUGv.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] 3-4 cherry-pick fix to build with gcj 1.5.0
On 11/04/2011 12:41 PM, Caolán McNamara wrote:
i.e. com.sun.org.apache.xerces.internal.parsers.DOMParser is a
sun/oracle-only java api. Commit
http://cgit.freedesktop.org/libreoffice/core/commit/?id=04c5a36ab8d514cfbe8e40f4493787b2ab392ab5
(attached) I believe does the right thing, definitely builds anyway.
Looking at the patch,
javax.xml.parsers.DocumentBuilderFactory.newInstance() smells like it
internally uses the context class loader, even if that is not documented
at
http://download.oracle.com/javase/7/docs/api/javax/xml/parsers/DocumentBuilderFactory.html#newInstance()
(and at least in some Sun JRE 6 it indeed does so), so this could fail
if the context class loader is null---as can happen in LibO, see
https://issues.apache.org/ooo/show_bug.cgi?id=102164#c6.
That is, the call to DocumentBuilderFactory.newInstance() within
OfficeDocumentReportTarget would need to be wrapped in something like
DocumentBuilderFactory dbFactory;
ClassLoader old = Thread.currentThread().getContextClassLoader();
ClassLoader c = OfficeDocumentReportTarget.class.getClassLoader();
if (c != null) {
// otherwise, hope context class loader already contains a non-null value
OfficeDocumentReportTarget.class.getClassLoader(c);
}
try {
dbFactory = DocumentBuilderFactory.newInstance();
} finally {
if (c != null) {
Thread.currentThread().setContextClassLoader(old);
}
}
Stepha
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] minutes of tech. steering call ...
2011/11/3 Michael Meeks michael.me...@suse.com: * QA update (Rainer) + problems with UI translations for Farsi / Arabian AA: + chase it down cf. bug#42388 (Andras) I made a comment and closed the bug. It is not a bug that we can fix, translation is missing. Farsi is at ~50%. OTOH Arabic is at 96%, it is much better. Both languages have an active translator team. It just takes time to finish the translation. Best regards, Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] 3-4 cherry-pick fix to build with gcj 1.5.0
On Fri, 2011-11-04 at 14:01 +0100, Stephan Bergmann wrote: On 11/04/2011 12:41 PM, Caolán McNamara wrote: i.e. com.sun.org.apache.xerces.internal.parsers.DOMParser is a sun/oracle-only java api. Commit http://cgit.freedesktop.org/libreoffice/core/commit/?id=04c5a36ab8d514cfbe8e40f4493787b2ab392ab5 (attached) I believe does the right thing, definitely builds anyway. Looking at the patch, javax.xml.parsers.DocumentBuilderFactory.newInstance() smells like it internally uses the context class loader, even if that is not documented at http://download.oracle.com/javase/7/docs/api/javax/xml/parsers/DocumentBuilderFactory.html#newInstance() (and at least in some Sun JRE 6 it indeed does so), so this could fail if the context class loader is null---as can happen in LibO, see https://issues.apache.org/ooo/show_bug.cgi?id=102164#c6. That is, the call to DocumentBuilderFactory.newInstance() within OfficeDocumentReportTarget would need to be wrapped Erm... http://opengrok.libreoffice.org/search?q=DocumentBuilderFactory.newInstanceproject=coredefs=refs=path=hist= Looks we're fairly riddled with this pattern. So presumably if this problem affects DocumentBuilderFactory.newInstance we already suffer from it in our xsltfilter and other places ? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Translate more German comments
Hi all,
I've translated more German comments in sw/source/core/doc/.
I also translated a local variable in docchart.cxx. I know I shouldn't
do that, but I thought the risk of breaking something is very low (it
only occurs in this local scope).
Feel free to remove this if you want.
Philipp
From 9ea1779a4e622358dec75719a569f61290fb62da Mon Sep 17 00:00:00 2001
From: Philipp Weissenbacher p.weissenbac...@gmail.com
Date: Fri, 4 Nov 2011 14:46:42 +0100
Subject: [PATCH] Translate German comments
---
sw/source/core/doc/doc.cxx | 146 ++-
sw/source/core/doc/docbasic.cxx | 14 ++--
sw/source/core/doc/docbm.cxx| 31
sw/source/core/doc/docchart.cxx | 14 ++--
sw/source/core/doc/doccomp.cxx | 88 +++-
sw/source/core/doc/doccorr.cxx |8 +-
6 files changed, 140 insertions(+), 161 deletions(-)
diff --git a/sw/source/core/doc/doc.cxx b/sw/source/core/doc/doc.cxx
index b3d9472..bdded6f 100644
--- a/sw/source/core/doc/doc.cxx
+++ b/sw/source/core/doc/doc.cxx
@@ -81,32 +81,32 @@
#include swtable.hxx
#include pam.hxx
#include ndtxt.hxx
-#include swundo.hxx // fuer die UndoIds
+#include swundo.hxx // for the UndoIds
#include UndoCore.hxx
#include UndoInsert.hxx
#include UndoSplitMove.hxx
#include UndoTable.hxx
-#include pagedesc.hxx //DTor
+#include pagedesc.hxx // DTor
#include breakit.hxx
#include ndole.hxx
#include ndgrf.hxx
-#include rolbck.hxx // Undo-Attr
-#include doctxm.hxx // fuer die Verzeichnisse
+#include rolbck.hxx // Undo attr
+#include doctxm.hxx // for the directories
#include grfatr.hxx
-#include poolfmt.hxx // PoolVorlagen-Id's
-#include mvsave.hxx // fuer Server-Funktionalitaet
+#include poolfmt.hxx // pool template ids
+#include mvsave.hxx // for server functionality
#include SwGrammarMarkUp.hxx
#include scriptinfo.hxx
-#include acorrect.hxx // Autokorrektur
-#include mdiexp.hxx // Statusanzeige
+#include acorrect.hxx // auto correction
+#include mdiexp.hxx // status indicator
#include docstat.hxx
#include docary.hxx
#include redline.hxx
#include fldupde.hxx
#include swbaslnk.hxx
#include printdata.hxx
-#include cmdid.h // fuer den dflt - Printer in SetJob
-#include statstr.hrc // StatLine-String
+#include cmdid.h // for the dflt printer in SetJob
+#include statstr.hrc // StatLine string
#include comcore.hrc
#include SwUndoTOXChange.hxx
#include SwUndoFmt.hxx
@@ -140,11 +140,11 @@
using namespace ::com::sun::star;
using ::rtl::OUString;
-// Seiten-Deskriptoren
+// Page descriptors
SV_IMPL_PTRARR(SwPageDescs,SwPageDescPtr);
-// Verzeichnisse
+// Directories
SV_IMPL_PTRARR( SwTOXTypes, SwTOXTypePtr )
-// FeldTypen
+// Field types
SV_IMPL_PTRARR( SwFldTypes, SwFldTypePtr)
/* IInterface */
@@ -641,7 +641,7 @@ void SwDoc::setJobsetup(/*[in]*/ const JobSetup rJobSetup )
if( !pPrt )
{
-//Das ItemSet wird vom Sfx geloescht!
+//The ItemSet is deleted by Sfx!
SfxItemSet *pSet = new SfxItemSet( GetAttrPool(),
FN_PARAM_ADDPRINTER, FN_PARAM_ADDPRINTER,
SID_HTML_MODE, SID_HTML_MODE,
@@ -690,8 +690,8 @@ void SwDoc::setPrintData(/*[in]*/ const SwPrintData rPrtData )
/* Implementations the next Interface here */
/*
- * Dokumenteditieren (Doc-SS) zum Fuellen des Dokuments
- * durch den RTF Parser und fuer die EditShell.
+ * Document editing (Doc-SS) to fill the document
+ * by the RTF parser and for the EditShell.
*/
void SwDoc::ChgDBData(const SwDBData rNewData)
{
@@ -710,9 +710,8 @@ bool SwDoc::SplitNode( const SwPosition rPos, bool bChkTableStart )
return false;
{
-// BUG 26675: DataChanged vorm loeschen verschicken, dann bekommt
-// man noch mit, welche Objecte sich im Bereich befinden.
-// Danach koennen sie vor/hinter der Position befinden.
+// BUG 26675: Send DataChanged before deleting, so that we notice which objects are in scope.
+//After that they can be before/after the position.
SwDataChanged aTmp( this, rPos, 0 );
}
@@ -720,7 +719,7 @@ bool SwDoc::SplitNode( const SwPosition rPos, bool bChkTableStart )
if (GetIDocumentUndoRedo().DoesUndo())
{
GetIDocumentUndoRedo().ClearRedo();
-// einfuegen vom Undo-Object, z.Z. nur beim TextNode
+// insert from the Undo object (currently only for TextNode)
if( pNode-IsTxtNode() )
{
pUndo = new SwUndoSplitNode( this, rPos, bChkTableStart );
@@ -728,10 +727,9 @@ bool SwDoc::SplitNode( const SwPosition rPos, bool bChkTableStart )
}
}
-//JP 28.01.97: Sonderfall fuer SplitNode am Tabellenanfang:
-// steht die am Doc/Fly/Footer/..-Anfang oder direkt
-//
Re: [Libreoffice] [PUSHED] Translate more German comments
On Fri, Nov 4, 2011 at 8:55 AM, Philipp Weissenbacher p.weissenbac...@gmail.com wrote: Hi all, I've translated more German comments in sw/source/core/doc/. Lovely, thanks. I've tweak a couple of intentations issue, but otherwise: Pushed. Can you please add [PATCH] in the title of yours emails, when they have a patch attached (that make it easier to spot them) I also translated a local variable in docchart.cxx. I know I shouldn't do that, but I thought the risk of breaking something is very low (it only occurs in this local scope). That's fine, and in that context, indeed an improvement :-) Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Extension dependencies
At 13:02 4-11-2011, Thorsten Behrens wrote: Stephan Bergmann wrote: As already mentioned briefly in my talk at LOCon, we need to make up our mind how to handle LO extension dependencies. Skipping most of this - I'd tend to give the fine-grained dependencies a try. That won't work in practice, unless those can be (semi-)automatically generated. Experience shows that all programmers are lazy, and seldomly go extra miles. And all generalisations are true ;-) Even those who would be willing to use fine-grained metadata for dependencies would benefit from an automated check on these data. It is easy to modify the source code in the extension and then to forget to update the dependency metadata. Best regards, Christophe Having a simple version string, and some volunteers testing uploaded extensions on the extension repo sounds much more workable - and useful in practice, since no syntactic compatibility one could come up with would ensure semantic equality... Cheers, -- Thorsten -- Christophe Strobbe K.U.Leuven - Dept. of Electrical Engineering - SCD Research Group on Document Architectures Kasteelpark Arenberg 10 bus 2442 B-3001 Leuven-Heverlee BELGIUM tel: +32 16 32 85 51 http://www.docarch.be/ Twitter: @RabelaisA11y --- Open source for accessibility: results from the AEGIS project www.aegis-project.eu --- Please don't invite me to Facebook, Quechup or other social networks. You may have agreed to their privacy policy, but I haven't. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] 3-4 cherry-pick fix to build with gcj 1.5.0
On 11/04/2011 02:53 PM, Caolán McNamara wrote: On Fri, 2011-11-04 at 14:01 +0100, Stephan Bergmann wrote: That is, the call to DocumentBuilderFactory.newInstance() within OfficeDocumentReportTarget would need to be wrapped Erm... http://opengrok.libreoffice.org/search?q=DocumentBuilderFactory.newInstanceproject=coredefs=refs=path=hist= Looks we're fairly riddled with this pattern. So presumably if this problem affects DocumentBuilderFactory.newInstance we already suffer from it in our xsltfilter and other places ? The pattern probably here is that the problem is not noticed as long as the Java code is called from the main thread. (The empty context class loader problem arises only for native threads other than the initial JVM thread that are attached to the JVM via JNI. Threads spawned by the JVM inherit the calling thread's context class loader, and the thread on which the JVM is originally initialized explicitly obtains a non-null context class loader during initialization, IIRC). Anyway, you have been warned. ;) Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] 3-4 cherry-pick fix to build with gcj 1.5.0
On 11/04/2011 04:55 PM, Caolán McNamara wrote: On Fri, 2011-11-04 at 16:23 +0100, Stephan Bergmann wrote: Anyway, you have been warned. ;) Pfff, seems a sure route to madness to have to second guess every possible java api over and above its documentation in case it uses some ContextClassLoader under the hood. *shudder*, that'd be some audit effort. Direct uses are one thing, but indirect hidden ones. The context class loader is a dirty hack in the Java API, broken by design. Just goes to show how bad global variables are. Anyway, is your suggested wrapper correct ? Looks a bit odd now that I actually read it as opposed to boggle at it. Just wrote it down as a quick sketch, so surely contains all sorts of errors. Thread.currentThread().setContextClassLoader(c); //like so I guess? yes, sure Anyway, given the code in question is likely called from the main thread, so would not exhibit any more of a problem than all the already existing instances of DocumentBuilderFactory.newInstance(), and presumably already works fine in master, I'm indifferent to whether any context class loader handling would be needed for a 3.4 cherry-pick after all... Consider it as approvingly reviewed by me either way. (That said, I'll make a mental note to revisit the problem on master and maybe introduce some code abstraction to wrap around calls of DocumentBuilderFactory.newInstance() and similar constructs.) Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] 3-4 cherry-pick fix to build with gcj 1.5.0
On Fri, 2011-11-04 at 17:14 +0100, Stephan Bergmann wrote: I'm indifferent to whether any context class loader handling would be needed for a 3.4 cherry-pick after all... Consider it as approvingly reviewed by me either way. Fair enough, pushed to 3-4. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] a minor typo in a comment of msgbox.py
On Fri, Nov 04, 2011 at 03:18:42PM +0100, Laurent Godard oooc...@free.fr wrote: in order to progress in creating patches (thanks kohei, markus for git magic teahing), here is a small patch that corrects a minor typo in the msgbox.py file Pushed, thanks. pgpd0oBeCchnf.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] a minor typo in a comment of msgbox.py
Forgot subject. pgpk2OFwUMKhH.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] (no subject)
What's up! wow i just found this.. i just won my iPad2 for nothing, thats right nothing.. you need to hurry up and get yours before it to late heres the website.. http://so.ee/K50 code 39588976/HTML ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] Creating test cases for Litmus server
Sophie Gautier píše v Čt 03. 11. 2011 v 21:30 +0100: As you know Litmus was only a default choice because we didn't find anything better that could fit our needs. There is a new tool developed by the Mozilla Foundation, but it won't be available before some time from what I know. However, Rimas and Yi Fan have managed to make it more comfortable and it's what we use for now. I am very happy that we have Litmus and I really appreciate the work! I am just slightly nervous that we have only few test cases. Also I am not sure if we do test runs regularly... There must be many people around that would want to help with testing. Every localization team team had its own testers. We need to encourage them. I think that the feature freeze for 3.5 release will be good point to get attention. I wonder if we could make it easier with few more changes. The best way for the moment, would be to add the tests on the wiki and and admin to add them to Litmus. I know it's less easy and open than we would like however. Yes, it might be a good workaround if the transition works reasonable fast. We could create admins from people that contribute many good test cases. So, it might balance the load on admins. Alternatively, people might send test cases to the libreoffice-qa mailing list and add [TESTCASE] into the subject. It would work the same way like [PATCH] on the developer mailing list. Best Regards, Petr ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] [Libreoffice] [libreoffice-projects] [ANN] LibreOffice 3.4.4 RC2 available
Heinz W. Simoneit píše v Pá 04. 11. 2011 v 08:27 +0100: Petr Mladek schrieb: I wonder if it is something new in 3.4.4 or if it was already in 3.4.3 or other earlier releases. didn'thave this issue in 3.4.3 -- but in earlier releases. I am a bit mixed. Did it work in 3.4.3? Was it broken in an earlier version? What was the earlier version? It sounds strange if it worked in 3.4.3, was broken in older versions and got broken again in 3.4.4. Also, I wonder if it happens only with the MySQL connector (3rd party exstension?) or if you see it also with other database drivers. I'm using MySQL connector eternally. Tried ODBC with early OOo without great success... MySQL connector now: 1.0.1 I see :-( Anyway, please, report it into bugzilla. Will do it later on. Thanks a lot in advance. Best Regards, Petr ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 42575] Sum across sheets don't work if one of the terms of the sum is
https://bugs.freedesktop.org/show_bug.cgi?id=42575 vitriol vitriol_vitr...@katamail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Comment #2 from vitriol vitriol_vitr...@katamail.com 2011-11-03 23:11:28 UTC --- *** This bug has been marked as a duplicate of bug 37860 *** -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 37860] Formula returns #VALUE in 3.4RC2 but works as expected in 3.3
https://bugs.freedesktop.org/show_bug.cgi?id=37860 vitriol vitriol_vitr...@katamail.com changed: What|Removed |Added CC||marc.muehlfeld@medizinische ||-genetik.de --- Comment #24 from vitriol vitriol_vitr...@katamail.com 2011-11-03 23:11:28 UTC --- *** Bug 42575 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42581] New: EDITING: MinGW Crash with lots of error messages when using Duplicate Slide
https://bugs.freedesktop.org/show_bug.cgi?id=42581 Bug #: 42581 Summary: EDITING: MinGW Crash with lots of error messages when using Duplicate Slide Classification: Unclassified Product: LibreOffice Version: LibO Master Platform: Other OS/Version: All Status: UNCONFIRMED Status Whiteboard: BSA Severity: normal Priority: medium Component: Drawing AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: libreoff...@bielefeldundbuss.de Steps to reproduce with parallel installation of MinGW Master LibO-dev 3.5.0 – WIN7 Home Premium (64bit) English UI [(Build ID: 2ba5d12-e8c71c5-41e7bcd-4b83b90)] (daily/MinGW_cross-compilation2011-10-25_00.12.09): 1. Download and unzip sample document from Bug 36991 - crash when duplicating draw page with linked wmf pictures 2. Start LibO 3. Menu 'File - Open - Browse for Druckträger Aufgabe 3.odg and open it. Sometimes LibO will crash in this step, then restart 4. Click only existing slide in Pages pane (becomes selected / highlighted) 4. Menu 'Insert - Duplicate Slide' (Copy of existing slide will be created, second slide will be selected / highlighted) 5. Click slide 1 in Pages pane 6. Menu 'Insert - Duplicate Slide' Expected: second copy of existing slide will be created Actual: simple Crash, if you are lucky. If not: Endless list of error messages as visible in screenshot Browser: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0.1) Gecko/20110928 Firefox/7.0.1 SeaMonkey/2.4.1 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42581] EDITING: MinGW Crash with lots of error messages when using Duplicate Slide
https://bugs.freedesktop.org/show_bug.cgi?id=42581 --- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2011-11-04 00:04:50 PDT --- Created attachment 53138 -- https://bugs.freedesktop.org/attachment.cgi?id=53138 Screenshot Showing lots of error messages, please see original report -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42582] New: BUGZILLAASSISTANT: Monitoring for existing description for Attachment is missing
https://bugs.freedesktop.org/show_bug.cgi?id=42582 Bug #: 42582 Summary: BUGZILLAASSISTANT: Monitoring for existing description for Attachment is missing Classification: Unclassified Product: LibreOffice Version: unspecified Platform: Other OS/Version: All Status: UNCONFIRMED Status Whiteboard: BSA Severity: normal Priority: medium Component: WWW AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: libreoff...@bielefeldundbuss.de Steps to reproduce: 1. Start a Bug report using Assistant (I observed the problem when I reported Bug 42581 2. Browse for attachment and insert 3. Do not fill pane Explain what is attached 5. Click Submit Expected: error message Missing description Actual: Submission without attachment Browser: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0.1) Gecko/20110928 Firefox/7.0.1 SeaMonkey/2.4.1 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42555] FileSave
https://bugs.freedesktop.org/show_bug.cgi?id=42555 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added Severity|major |normal CC||c...@nouenoff.nl --- Comment #1 from Cor Nouws c...@nouenoff.nl 2011-11-04 01:09:00 PDT --- Hi Antonio, Thanks for your report. Is it on a local storage or in a network? Have you seen the effect more oftne (probably not..) Thanks, Cor -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42583] New: Writer crashes on opening docx document with double click
https://bugs.freedesktop.org/show_bug.cgi?id=42583 Bug #: 42583 Summary: Writer crashes on opening docx document with double click Classification: Unclassified Product: LibreOffice Version: LibO 3.4.3 release Platform: x86-64 (AMD64) OS/Version: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: slavi...@gmail.com Created attachment 53141 -- https://bugs.freedesktop.org/attachment.cgi?id=53141 docx file It crashes on open it with double click. Doesn't crash on open it with open dialog or drag and drop. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42577] UI [AR] toolbar view mirrored (docking and expand at the wrong side) when Insert Object Formula
https://bugs.freedesktop.org/show_bug.cgi?id=42577 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added OS/Version|All |Windows (All) Status|UNCONFIRMED |NEW Status Whiteboard|BSA |BSA, CONFIRMED CC||LibreOffice@bielefeldundbus ||s.de Ever Confirmed|0 |1 Summary|VIEWING: Menu button of |UI [AR] toolbar view |toolbars appear not |mirrored (docking and |correctly when insert a |expand at the wrong side) |formula in Writer. |when Insert Object Formula Component|UI |Localisation --- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2011-11-04 01:59:12 PDT --- [Reproducible] with LibreOffice 3.4.4RC2 - WIN7 Home Premium (64bit) German UI [OOO340m1 (Build:402)] - Reported with Bug Submission Assistant - -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42577] UI [AR] toolbar view mirrored (docking and expand at the wrong side) when Insert Object Formula
https://bugs.freedesktop.org/show_bug.cgi?id=42577 Ibrahim ibraheem5...@hotmail.com changed: What|Removed |Added OS/Version|Windows (All) |All Severity|normal |major Priority|medium |high -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42584] New: FILEOPEN: Parser errors and blank spreadsheet when opening XLS file
https://bugs.freedesktop.org/show_bug.cgi?id=42584 Bug #: 42584 Summary: FILEOPEN: Parser errors and blank spreadsheet when opening XLS file Classification: Unclassified Product: LibreOffice Version: LibO 3.4.3 release Platform: Other OS/Version: All Status: UNCONFIRMED Status Whiteboard: BSA Severity: normal Priority: medium Component: Spreadsheet AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: paal.nil...@gmail.com Created attachment 53142 -- https://bugs.freedesktop.org/attachment.cgi?id=53142 Example file that will produce parser errors Problem description: The problem persists when opening Excel exports from the JIRA issue tracker. The files work fine on version 3.3.4 of LibreOffice. When opening a file from Chrome or terminal the import dialog is not shown and the spreadsheet is blank. I figured out that I can work around the problem by clicking the File menu and selecting the document under Recent Documents. The import dialog will then show and after clicking OK, the spreadsheet shows data as expected. Steps to reproduce: 1. Open an XLS file via the File, Open or from an external program or terminal 2. The scalc program starts and shows a blank spreadsheet 3. If you open via terminal you will see a large amount of parser errors Current behavior: Parser errors, no import dialog and blank spreadsheet Expected behavior: No errors, show the import dialog and data in the spreadsheet after clicking OK on the import. Platform (if different from the browser): Confirmed on LibreOffice 3.4.3 on both Ubuntu 11.04 and 11.10 x86_64. Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/535.2 (KHTML, like Gecko) Chrome/15.0.874.106 Safari/535.2 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42583] FILEOPEN docx with double click causes CRASH
https://bugs.freedesktop.org/show_bug.cgi?id=42583 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added CC||LibreOffice@bielefeldundbus ||s.de Summary|Writer crashes on opening |FILEOPEN docx with double |docx document with double |click causes CRASH |click | Keywords||NEEDINFO --- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2011-11-04 03:25:25 PDT --- Might be related to or DUP of Bug 38514, Bug 39384, Bug 40579, Bug 40588, Bug 41679, Bug 42252, Bug 42450, Bug 42486, Bug 42583, Bug 42583. @Reporter: Why do you expect that this report contains completely new information? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 38463] writer crashes saving a big document as office open xml text .docx
https://bugs.freedesktop.org/show_bug.cgi?id=38463 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added CC||LibreOffice@bielefeldundbus ||s.de --- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2011-11-04 03:26:39 PDT --- Might be related to or DUP of Bug 38514, Bug 39384, Bug 40579, Bug 40588, Bug 41679, Bug 42252, Bug 42450, Bug 42486, Bug 42583, Bug 42583. @Reporter: Why do you expect that this report contains completely new information? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 38514] FILEOPEN DOCX with templates from Axure RP PROCRASH
https://bugs.freedesktop.org/show_bug.cgi?id=38514 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added OS/Version|All |Windows (All) Status|NEW |RESOLVED Status Whiteboard||CONFIRMED, target:3.5.0 Resolution||WORKSFORME CC||LibreOffice@bielefeldundbus ||s.de Summary|DOCX templates from Axure |FILEOPEN DOCX with |RP PRO crash Libre Office |templates from Axure RP |when opnened (fileopen) |PROCRASH --- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2011-11-04 03:32:07 PDT --- Might be related to or DUP of Bug 38514, Bug 39384, Bug 40579, Bug 40588, Bug 41679, Bug 42252, Bug 42450, Bug 42486, Bug 42583, Bug 42583. [Reproducible] with LibreOffice 3.4.4RC2 - WIN7 Home Premium (64bit) German UI [OOO340m1 (Build:402)] No Crash with Server installation of Master LibO-dev 3.5.0 – WIN7 Home Premium (64bit) English UI [(Build ID: d3d1481-3f8994a-2ba0a9f)] (110909). So WFM @Reporter: Why do you expect that this report contains completely new information? What is your OS? What Version did you use? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 40588] FILEOPEN Yet another instance of a DOCX file crashing LibreOffice Writer
https://bugs.freedesktop.org/show_bug.cgi?id=40588 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Keywords||NEEDINFO --- Comment #3 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2011-11-04 03:43:20 PDT --- Might be related to or DUP of Bug 38514, Bug 39384, Bug 40579, Bug 40588, Bug 41679, Bug 42252, Bug 42450, Bug 42486, Bug 42583, Bug 42583. I believe DUP of Bug 39384 - FILEOPEN - crashing when trying to open docx file. @Reporter: Why do you expect that this report contains completely new information? Please check workaround from Bug 39384#6! -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41679] FILEOPEN: file open docx crash
https://bugs.freedesktop.org/show_bug.cgi?id=41679 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added CC||LibreOffice@bielefeldundbus ||s.de Keywords||NEEDINFO --- Comment #3 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2011-11-04 03:44:15 PDT --- Might be related to or DUP of Bug 38514, Bug 39384, Bug 40579, Bug 40588, Bug 41679, Bug 42252, Bug 42450, Bug 42486, Bug 42583, Bug 42583. @Reporter: Why do you expect that this report contains completely new information? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42252] FILEOPEN docx CRASH
https://bugs.freedesktop.org/show_bug.cgi?id=42252 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added CC||LibreOffice@bielefeldundbus ||s.de Summary|open docx occure in a crash |FILEOPEN docx CRASH Keywords||NEEDINFO --- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2011-11-04 03:44:55 PDT --- Might be related to or DUP of Bug 38514, Bug 39384, Bug 40579, Bug 40588, Bug 41679, Bug 42252, Bug 42450, Bug 42486, Bug 42583, Bug 42583. @Reporter: Why do you expect that this report contains completely new information? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42486] FILEOPEN: Docx with content controls (text controls) CRAShes
https://bugs.freedesktop.org/show_bug.cgi?id=42486 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added CC||LibreOffice@bielefeldundbus ||s.de Summary|FILEOPEN: Docx document |FILEOPEN: Docx with content |with content controls (text |controls (text controls) |controls) crashes |CRAShes |Libreoffice | Keywords||NEEDINFO --- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2011-11-04 03:46:33 PDT --- Might be related to or DUP of Bug 38514, Bug 39384, Bug 40579, Bug 40588, Bug 41679, Bug 42252, Bug 42450, Bug 42486, Bug 42583, Bug 42583. @Reporter: Why do you expect that this report contains completely new information? Did that work with earlier version? What's your OS? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 --- Comment #227 from Petr Mladek pmla...@suse.cz 2011-11-04 03:57:29 PDT --- (In reply to comment #224) Nominating Bug 40990. Entering array formulas in LO 3.4.3 with big ranges draw a lot of ressources. With a range around a thousand cells it eventually crashes. This shold be fixed otherwise using array formulas with vast ranges will be obsolete. Such performance improvement would be too big change for 3.4. It affects only limited group of users, so it even does not belong to the most annoying bugs. Kohei will try to fix it for LO-3.5. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42583] FILEOPEN docx with double click causes CRASH
https://bugs.freedesktop.org/show_bug.cgi?id=42583 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Status Whiteboard||target:3.5.0 Resolution||WORKSFORME Keywords|NEEDINFO| --- Comment #3 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2011-11-04 03:59:33 PDT --- [Reproducible] with reporter's sample and LibreOffice 3.4.4RC2 - WIN7 Home Premium (64bit) German UI [OOO340m1 (Build:402)], also when I open from LibO File open dialog (LibO). I can say that workaround from Bug 39384#6 will not work. No crash with Server installation of Master LibO-dev 3.5.0 – WIN7 Home Premium (64bit) English UI [(Build ID: d3d1481-3f8994a-2ba0a9f)] (110909) No crash with parallel installation of MinGW Master LibO-dev 3.5.0 – WIN7 Home Premium (64bit) English UI [(Build ID: 2ba5d12-e8c71c5-41e7bcd-4b83b90)] (daily/MinGW_cross-compilation2011-10-25_00.12.09) So WFM, I believe it's too hard to check for DUPs. @reporter: Please feel free to reopen this bug if you find out that the problem still exists with 3.5 (Available in December / January) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 33816] Impress freeze when using Apple Remote Control
https://bugs.freedesktop.org/show_bug.cgi?id=33816 --- Comment #15 from Florian Effenberger flo...@documentfoundation.org 2011-11-04 05:10:41 PDT --- I now tried with a new Apple remote (the metal style ones), same problem. Upon starting the presentation, the system freezes. The only way of getting control again was - seriously - to SSH in from another box and do a killall soffice. It was not even possible to use cmd, alt, escape to kill the task. I consider this a major issue, since it freezes the whole system. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42252] FILEOPEN docx CRASH
https://bugs.freedesktop.org/show_bug.cgi?id=42252 --- Comment #2 from christian.bu...@web.de 2011-11-04 05:14:19 PDT --- I don't know what you mean. My information is that the attached file cause a crash. That is everything what I know. You (the devs) know the LibOf internals. You can analyse the problem. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42593] New: FILTER: ascii import does not recognize scientific numbers
https://bugs.freedesktop.org/show_bug.cgi?id=42593 Bug #: 42593 Summary: FILTER: ascii import does not recognize scientific numbers Classification: Unclassified Product: LibreOffice Version: LibO 3.4.3 release Platform: Other OS/Version: All Status: UNCONFIRMED Status Whiteboard: BSA Severity: normal Priority: medium Component: Spreadsheet AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: nathanael.schaef...@gmail.com Problem description: when reading an ascii file with numbers like 1.06e-11 or 1.06E-11, the numbers are treated as plain text. Steps to reproduce: 1. put 1.06e-11 in a file named blabla.csv 2. open blabla 3. see the number beeing read as text. Current behavior: Expected behavior: scientific numbers should be understood. Platform (if different from the browser): Browser: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20100101 Firefox/7.0.1 LibreOffice 3.4.3 OOO340m1 (Build:302) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42599] EDITING: LibO Calc 3.4.2 and 3.4.3 fail to properly restore positions of drawing objects
https://bugs.freedesktop.org/show_bug.cgi?id=42599 --- Comment #2 from matthias_luebberst...@yahoo.de 2011-11-04 09:23:55 PDT --- Created attachment 53150 -- https://bugs.freedesktop.org/attachment.cgi?id=53150 State of document after re-opening -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42113] missing functions/icons for line width using the Linestyle-Symbol from Symbol-Bar
https://bugs.freedesktop.org/show_bug.cgi?id=42113 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution||NOTABUG --- Comment #4 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2011-11-04 09:37:06 PDT --- For me everything works as expected, in 3.3 we had a combined style width selection, in 3.4 we only have a style selector icon, line width has to be modified via menu. No indications that that is not intended. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42600] New: Hypelinks with number coming from MS$ aren't recognize
https://bugs.freedesktop.org/show_bug.cgi?id=42600 Bug #: 42600 Summary: Hypelinks with number coming from MS$ aren't recognize Classification: Unclassified Product: LibreOffice Version: LibO 3.4.2 release Platform: Other OS/Version: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Spreadsheet AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: mailingl...@tdeo.fr Created attachment 53152 -- https://bugs.freedesktop.org/attachment.cgi?id=53152 Original xlsx file Thanks to a mailinglist conversation with Tom Davies I reopened an issue. The problem is that the first column of the file is not recognize as an hyperlink. Here is the tests I made : It doesn't seems to depends on : - The OS cause I tried on M$Exc and multiple linux - The release cause I tried with libreoffice 3.4.2 and latest OpenOffice on Win$ I tried without succes on https://viewer.zoho.com/converter I tried with succes to import in google docs I even tried on the M$ excel product on a Mac and it works. Finally thanks to Regina Henschel, we found the issue : https://issues.apache.org/ooo/show_bug.cgi?id=31050 that depends on the following one https://issues.apache.org/ooo/show_bug.cgi?id=91351 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 35939] With LibreOffice Writer, the Windows7 Magnifier doesn't follow the insertion point
https://bugs.freedesktop.org/show_bug.cgi?id=35939 --- Comment #2 from Bas Cancrinus bas.freedesk...@canict.com 2011-11-04 10:08:57 PDT --- Still seeing this with LibO 3.3.3 (OOO330m19 (Build:301)) on Windows 7 (X64). If there is anything that I can do or sort out, please let me know! This issue is blocking me from switching to LibO. Thanks!! -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 34406] Broken hyperlinks in impress
https://bugs.freedesktop.org/show_bug.cgi?id=34406 --- Comment #3 from Olivier Hallot olivier.hal...@documentfoundation.org 2011-11-04 11:41:44 PDT --- Bug still in master. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 40585] Format-Cells crashes Calc
https://bugs.freedesktop.org/show_bug.cgi?id=40585 --- Comment #10 from kyri...@alumni.princeton.edu 2011-11-04 16:24:40 PDT --- The bug persists in 3.4.4 RC2. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41317] FORMATTING lost cell's formula after merge
https://bugs.freedesktop.org/show_bug.cgi?id=41317 --- Comment #2 from markus.mohrh...@googlemail.com 2011-11-04 16:52:30 PDT --- function responsible for that is: http://opengrok.libreoffice.org/xref/core/sc/source/core/data/documen3.cxx#DoMergeContents moving the formula would be much harder -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41390] EDITING - Formula is including the path file information
https://bugs.freedesktop.org/show_bug.cgi?id=41390 --- Comment #2 from markus.mohrh...@googlemail.com 2011-11-04 16:55:23 PDT --- After a second look I doubt that this is a bug. with the $ sign you mark the reference as an absolute reference. Then it is correct to include the full path, could you try if this still happen when you remove the dollar sign and other wise close this bug. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 38435] Missing icons in index designer
https://bugs.freedesktop.org/show_bug.cgi?id=38435 --- Comment #2 from Julien Nabet serval2...@yahoo.fr 2011-11-04 17:27:59 PDT --- Still here on Master, future 3.5 (git updated today). Good catch ! -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42607] New: FORMATTING
https://bugs.freedesktop.org/show_bug.cgi?id=42607 Bug #: 42607 Summary: FORMATTING Classification: Unclassified Product: LibreOffice Version: unspecified Platform: Other OS/Version: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Spreadsheet AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: mikfi...@bigpond.net.au When I copy and paste a date in dd-mm- format it used to be the case that one day was gained! I've now noticed that in a lot of cases 4 years are also gained!! The latter included dates prior to a column freeze operation (to the immediate right). This bug applies to the recent versions of calc. Most annoying - can someone fix it? An example is 29-Apr-11 being reproduced as 30-Apr-15. In previous versions to 3.4.3 I had only noticed one day being gained; now it is years also! (As I say above it appears that the might be affected by a freeze operation?!). Mike F. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41915] named cells not highlighted when editing formulae
https://bugs.freedesktop.org/show_bug.cgi?id=41915 markus.mohrh...@googlemail.com changed: What|Removed |Added CC||markus.mohrhard@googlemail. ||com --- Comment #13 from markus.mohrh...@googlemail.com 2011-11-04 18:03:42 PDT --- I'm not sure that this is really a bug. The feature correctly is called Named Expression because can not only assign ranges to them but also formula parts. The question is if it really makes sense to highlight named expressions. I'll add Christoph as UX guy into this. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42147] FILEOPEN: Opening valid ODF text document crashes Writer
https://bugs.freedesktop.org/show_bug.cgi?id=42147 --- Comment #1 from Julien Nabet serval2...@yahoo.fr 2011-11-04 18:17:49 PDT --- Created attachment 53159 -- https://bugs.freedesktop.org/attachment.cgi?id=53159 crash at the opening with 3.4.3 I reproduce the crash on 3.4.3. Here are the logs : # A fatal error has been detected by the Java Runtime Environment: # # SIGSEGV (0xb) at pc=0xae69ec9b, pid=12092, tid=3026773712 # # JRE version: 6.0_23-b23 # Java VM: OpenJDK Client VM (20.0-b11 mixed mode, sharing linux-x86 ) # Derivative: IcedTea6 1.11pre # Distribution: Debian GNU/Linux unstable (sid), package 6b23~pre11-1 # Problematic frame: # C [libswli.so+0x3ebc9b] SwAnchoredObject** std::__copy_movefalse, true, std::random_access_iterator_tag::__copy_mSwAnchoredObject*(SwAnchoredObject* const*, SwAnchoredObject* const*, SwAnchoredObject**)+0xd31 # # An error report file with more information is saved as: # /home/maryline/compile-libreoffice/libo/hs_err_pid12092.log # # If you would like to submit a bug report, please include # instructions how to reproduce the bug and visit: # http://icedtea.classpath.org/bugzilla # [error occurred during error reporting , id 0xb] So i attached the hs_err file. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42147] FILEOPEN: Opening valid ODF text document crashes Writer
https://bugs.freedesktop.org/show_bug.cgi?id=42147 --- Comment #2 from Julien Nabet serval2...@yahoo.fr 2011-11-04 18:19:03 PDT --- Created attachment 53160 -- https://bugs.freedesktop.org/attachment.cgi?id=53160 logs at the opening on master I don't reproduce the crash on master (git updated today) but attached the logs. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 40585] Format-Cells crashes Calc
https://bugs.freedesktop.org/show_bug.cgi?id=40585 --- Comment #11 from Simon Yuan m8r-5hco...@mailinator.com 2011-11-04 21:33:51 PDT --- (In reply to comment #7) @Simon: where did you get your libreoffice package from? It might be that if you took your systems package they miss some of our icu patches I installed the Arch Linux provided package. Since I upgraded icu last week, I can no longer reproduce the crash. Thanks. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: [Libreoffice-ux-advise] new range name dialog proposal
On Fri, 2011-11-04 at 22:10 +0100, Christoph Noack wrote: Hi Kohei, all! A small disclaimer: currently there are so many topics at the same time, that I have difficulties to follow all the mails ... so please bear with me if I missed a comment from your side. Am Donnerstag, den 03.11.2011, 12:01 -0400 schrieb Kohei Yoshida: Hi Christoph, On Thu, 2011-11-03 at 08:06 +0100, Christoph Noack wrote: I assumed that because also Excel only provides to update one name or range at a time. Ah! Well, this needs a bit more explanation, I suppose. In short, this assumption of yours is not entirely correct. Thanks for the explanation below ... I wanted to have a look at Excel 2007 at work, since I don't have a version at home. So I have to rely on your description, my brain and the documentation in the web. Unfortunately, the information from the different sources seems to differ ;-) Just to remember: The original question was, whether people do experience bad performance, if only one range name is changed at once. You told me yes, so we need to offer a change multiply names, then apply the changes. I've asked why Excel can do this, since I understand their implementation that way. So here we go ... In Excel 2007 and up, the Name Manager dialog is in fact modal, and it launches a separate sub dialog to allow editing of individual names one at a time. An example of the Excel 2010 manage names dialog can be seen here: http://media.wiley.com/Lux/10/209010.image0.jpg I understand it the following way ... adding / editing a single entry launches a separate window that needs confirmation. It exists a shortcut to change the expression - but that also needs confirmation via the checkmark button. But, the manage names dialog itself is non-modal, since it generally seems to allow working with the document. Only one exception: You cannot use the Name Manager dialog box while you are changing the contents of the cell. according: http://office.microsoft.com/en-us/excel-help/define-and-use-names-in-formulas-HA010147120.aspx So, in general, the name manager is non-modal. Whether it updates the name directly in the model directly when it's updated in the dialog is unknown (since we don't know what Excel does internally), but because the main Name Manager dialog is modal, it won't perform re-calculation until that dialog is dismissed. What this means is that Excel's name manager dialog only performs re-calculation *once* even when you modify two or more names as long as you don't dismiss the main dialog between the editing of the names. If I understand the Excel help well enough, it works differently. The documentation (see link above) mentions several times: The Close button only closes the Name Manager dialog box. It is not required to commit changes that have already been made. This only indicates that Excel updates the names directly in the model from the dialog. But that alone has nothing to do with the modality of the dialog, and when the re-calculation occurs, which is the heart of this performance discussion. I already indicated that this may be what Excel does in my previous post, and based on what the above help says that's indeed what Excel seems to do. However, I also indicated that, even if we decide to update the name directly in the model (which basically removes the possibility of canceling the changes, but I guess that's the trend we are following), we could still turn off auto re-calc temporarily before launching the dialog, then turning it back on after dismissing the dialog, to hold of re-calculation until the dialog is dismissed, as long as the dialog is modal. And, since Excel's dialog is modal, Excel can do exactly that, to hold of re-calc until the dialog is closed. To me it seems that all the actions within the manage names dialog do handle one change per time - whether it is a modal dialog, or the expression field. That was my starting point to ask why Excel seems to perform well enough for such a interaction design. Again, what we are primarily focusing on in this discussion is when to perform the re-calculation, not when to modify the names in the model. These two are closely related, but they are not the same thing. Excel updates the model one change at a time, but it doesn't perform re-calculation at every name update; it performs it only when the dialog is dismissed, which happens only once. The only reason it can do that is because the dialog is modal. I hope that makes sense. And Christoph, I sincerely hope that you will find the opportunity to play with Excel 2007 or 2010 to see what this functionality works in person, and see when and how often Excel performs re-calculation in relation to name updates. Otherwise we could go back and forth with this endless see-saw. All the best, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___
