[Libreoffice-commits] .: 2 commits - desktop/source desktop/win32 desktop/WinResTarget_quickstart.mk
desktop/WinResTarget_quickstart.mk |2 desktop/source/app/app.cxx |2 desktop/win32/source/QuickStart/OOQuickStart.rc | 130 --- desktop/win32/source/QuickStart/QuickStart.cxx |7 - desktop/win32/source/QuickStart/QuickStart.rc| 130 +++ desktop/win32/source/QuickStart/so/QuickStart.rc | 130 --- 6 files changed, 135 insertions(+), 266 deletions(-) New commits: commit 3ac61e97198354439ceac8969277585cb8d4cb18 Author: Andras Timar ati...@suse.com Date: Sun Dec 4 13:20:20 2011 +0100 remove StarOffice-only file diff --git a/desktop/WinResTarget_quickstart.mk b/desktop/WinResTarget_quickstart.mk index 0c28ece..57e6358 100644 --- a/desktop/WinResTarget_quickstart.mk +++ b/desktop/WinResTarget_quickstart.mk @@ -35,6 +35,6 @@ $(eval $(call gb_WinResTarget_add_dependency,quickstart/src,\ sysui/desktop/icons/main_app.ico \ )) -$(eval $(call gb_WinResTarget_add_file,quickstart/src,desktop/win32/source/QuickStart/OOQuickStart)) +$(eval $(call gb_WinResTarget_add_file,quickstart/src,desktop/win32/source/QuickStart/QuickStart)) # vim: set ts=4 sw=4 et: diff --git a/desktop/win32/source/QuickStart/OOQuickStart.rc b/desktop/win32/source/QuickStart/OOQuickStart.rc deleted file mode 100644 index 2fdfa7d..000 --- a/desktop/win32/source/QuickStart/OOQuickStart.rc +++ /dev/null @@ -1,130 +0,0 @@ -//Microsoft Developer Studio generated resource script. -// -#include resource.h - -#define APSTUDIO_READONLY_SYMBOLS -/ -// -// Generated from the TEXTINCLUDE 2 resource. -// -#define APSTUDIO_HIDDEN_SYMBOLS -#include windows.h -#undef APSTUDIO_HIDDEN_SYMBOLS -#include resource.h - -/ -#undef APSTUDIO_READONLY_SYMBOLS - -/ -// German (Germany) resources - -#if !defined(AFX_RESOURCE_DLL) || defined(AFX_TARG_DEU) -#ifdef _WIN32 -LANGUAGE LANG_GERMAN, SUBLANG_GERMAN -#pragma code_page(1252) -#endif //_WIN32 - -/ -// -// Icon -// - -// Icon with lowest ID value placed first to ensure application icon -// remains consistent on all systems. -ICON_ACTIVE ICONDISCARDABLE icons/main_app.ico -IDI_QUICKSTART ICONDISCARDABLE icons/main_app.ico -IDI_SMALL ICONDISCARDABLE icons/main_app.ico -ICON_INACTIVE ICONDISCARDABLE icons/main_app.ico - - -/ -// -// Accelerator -// - -IDC_QUICKSTART ACCELERATORS MOVEABLE PURE -BEGIN -?,IDM_ABOUT, ASCII, ALT -/,IDM_ABOUT, ASCII, ALT -END - - -/ -// -// Dialog -// - -IDD_ABOUTBOX DIALOG DISCARDABLE 22, 17, 230, 75 -STYLE DS_MODALFRAME | WS_CAPTION | WS_SYSMENU -CAPTION About -FONT 8, System -BEGIN -ICONIDI_QUICKSTART,IDC_MYICON,14,9,16,16 -LTEXT QuickStart Version 1.0,IDC_STATIC,49,10,119,8, -SS_NOPREFIX -LTEXT Copyright (C) 2001,IDC_STATIC,49,20,119,8 -DEFPUSHBUTTON OK,IDOK,195,6,30,11,WS_GROUP -END - - -#ifdef APSTUDIO_INVOKED -/ -// -// TEXTINCLUDE -// - -2 TEXTINCLUDE DISCARDABLE -BEGIN -#define APSTUDIO_HIDDEN_SYMBOLS\r\n -#include windows.h\r\n -#undef APSTUDIO_HIDDEN_SYMBOLS\r\n -#include resource.h\r\n -\0 -END - -3 TEXTINCLUDE DISCARDABLE -BEGIN -\r\n -\0 -END - -1 TEXTINCLUDE DISCARDABLE -BEGIN -resource.h\0 -END - -#endif// APSTUDIO_INVOKED - - -/ -// -// String Table -// - -STRINGTABLE DISCARDABLE -BEGIN -IDS_APP_TITLE SoQuickStart -IDC_QUICKSTART QUICKSTART -IDS_TOOLTIP StarOffice 6.0 QuickStart -END - -STRINGTABLE DISCARDABLE -BEGIN -IDS_EXITExit -END - -#endif// German (Germany) resources -/ - - - -#ifndef APSTUDIO_INVOKED -/ -// -// Generated from the TEXTINCLUDE 3 resource. -// - - -/ -#endif// not APSTUDIO_INVOKED - diff --git a/desktop/win32/source/QuickStart/QuickStart.rc b/desktop/win32/source/QuickStart/QuickStart.rc new file mode 100644 index 000..2fdfa7d --- /dev/null +++ b/desktop/win32/source/QuickStart/QuickStart.rc @@ -0,0 +1,130 @@ +//Microsoft Developer Studio generated resource script. +//
[Libreoffice-commits] .: desktop/win32
desktop/win32/source/QuickStart/QuickStart.cxx | 353 - desktop/win32/source/QuickStart/QuickStart.rc | 127 desktop/win32/source/QuickStart/resource.h | 32 -- 3 files changed, 1 insertion(+), 511 deletions(-) New commits: commit 6411ad12f2dac9525f720662692cf712801f8c5b Author: Andras Timar ati...@suse.com Date: Sun Dec 4 14:50:37 2011 +0100 code cleanup of Windows quickstarter diff --git a/desktop/win32/source/QuickStart/QuickStart.cxx b/desktop/win32/source/QuickStart/QuickStart.cxx index 26276ba..b3e19a5 100644 --- a/desktop/win32/source/QuickStart/QuickStart.cxx +++ b/desktop/win32/source/QuickStart/QuickStart.cxx @@ -7,37 +7,10 @@ #include systools/win32/uwinapi.h #include stdio.h -#define MY_TASKBAR_NOTIFICATION WM_USER+1 - -#define MAX_LOADSTRING 100 - // message used to communicate with soffice -#define TERMINATIONVETO_MESSAGE SO TerminationVeto -#define TERMINATE_MESSAGE SO Terminate #define LISTENER_WINDOWCLASSSO Listener Class #define KILLTRAY_MESSAGESO KillTray -static UINT aTerminationVetoMessage = 0x7FFF; -static UINT aTerminateMessage = 0x7FFF; -static HMENU popupMenu = NULL; -static bool bTerminateVeto = true; - -#define UPDATE_TIMER 1 - -// Global Variables: -HINSTANCE hInst;// current instance -TCHAR szTitle[MAX_LOADSTRING]; // The title bar text -TCHAR szWindowClass[MAX_LOADSTRING];// The title bar text - -TCHAR szExitString[MAX_LOADSTRING]; -TCHAR szTooltipString[MAX_LOADSTRING]; - -// Foward declarations of functions included in this code module: -ATOMMyRegisterClass(HINSTANCE hInstance); -BOOLInitInstance(HINSTANCE, int); -LRESULT CALLBACKWndProc(HWND, UINT, WPARAM, LPARAM); -LRESULT CALLBACKAbout(HWND, UINT, WPARAM, LPARAM); - bool SofficeRuns() { // check for soffice by searching the communication window @@ -66,58 +39,13 @@ bool launchSoffice( ) UINT ret = WinExec( imagename, SW_SHOW ); if ( ret 32 ) return false; -/* -// wait until we can communicate -int retry = 30; -while (retry-- !SofficeRuns() ) -Sleep(1000); -return SofficeRuns(); -*/ return true; } else return true; } -void NotifyListener( HWND hWnd ) -{ -static HICON hIconActive=NULL; -//static HICON hIconInActive=NULL; - -if( !hIconActive ) -{ -hIconActive = (HICON)LoadImage( GetModuleHandle( NULL ), MAKEINTRESOURCE( ICON_ACTIVE ), -IMAGE_ICON, GetSystemMetrics( SM_CXSMICON ), GetSystemMetrics( SM_CYSMICON ), -LR_DEFAULTCOLOR | LR_SHARED ); - -/*hIconInActive = (HICON)LoadImage( GetModuleHandle( NULL ), MAKEINTRESOURCE( ICON_INACTIVE ), -IMAGE_ICON, GetSystemMetrics( SM_CXSMICON ), GetSystemMetrics( SM_CYSMICON ), -LR_DEFAULTCOLOR | LR_SHARED ); -*/ -} - -NOTIFYICONDATA nid; -nid.cbSize = sizeof(NOTIFYICONDATA); -nid.hWnd = hWnd; -nid.uID= IDM_QUICKSTART; -nid.szTip[SAL_N_ELEMENTS(nid.szTip) - 1] = 0; -//nid.hIcon = bTerminateVeto ? hIconActive : hIconInActive; -//strncpy(nid.szTip, bTerminateVeto ? STRING_QUICKSTARTACTIVE : STRING_QUICKSTARTINACTIVE, SAL_N_ELEMENTS(nid.szTip) - 1 ); -nid.hIcon = hIconActive; -strncpy(nid.szTip, szTooltipString, SAL_N_ELEMENTS(nid.szTip) - 1); -nid.uFlags = NIF_TIP|NIF_ICON; - -// update systray -Shell_NotifyIcon( NIM_MODIFY, nid ); -//CheckMenuItem( popupMenu, IDM_QUICKSTART, bTerminateVeto ? MF_CHECKED : MF_UNCHECKED ); - -// notify listener -SendMessage( HWND_BROADCAST, aTerminationVetoMessage, (WORD) bTerminateVeto, 0L ); -} - - - int APIENTRY WinMain(HINSTANCE /*hInstance*/, HINSTANCE /*hPrevInstance*/, LPSTR /*lpCmdLine*/, @@ -143,287 +71,6 @@ int APIENTRY WinMain(HINSTANCE /*hInstance*/, launchSoffice(); return 0; - -#if 0 // Note unconditional return 0 above. Do not remove this block of code - // unless you are sure it will never be needed even for reference. - - // TODO: Place code here. -MSG msg; -HACCEL hAccelTable; -aTerminationVetoMessage = RegisterWindowMessage( TERMINATIONVETO_MESSAGE ); -aTerminateMessage = RegisterWindowMessage( TERMINATE_MESSAGE ); - -// Initialize global strings -LoadString(hInstance, IDS_APP_TITLE, szTitle, MAX_LOADSTRING); -LoadString(hInstance, IDC_QUICKSTART, szWindowClass, MAX_LOADSTRING); - -LoadString(hInstance, IDS_EXIT,szExitString, MAX_LOADSTRING); -LoadString(hInstance, IDS_TOOLTIP, szTooltipString, MAX_LOADSTRING); - -MyRegisterClass(hInstance); - -// Perform application initialization: -if (!InitInstance (hInstance, nCmdShow)) -{ -return FALSE; -} - -hAccelTable = LoadAccelerators(hInstance,
[Libreoffice-commits] .: vcl/inc vcl/win
dev/null |binary vcl/inc/win/salids.hrc |2 -- vcl/win/source/app/salinst.cxx |1 - vcl/win/source/src/salsrc.rc |2 -- 4 files changed, 5 deletions(-) New commits: commit 915fe51391bdeee79f31173aeedab9746fc88000 Author: Andras Timar ati...@suse.com Date: Sun Dec 4 15:07:50 2011 +0100 remove StarDesktop icon diff --git a/vcl/inc/win/salids.hrc b/vcl/inc/win/salids.hrc index 3049f11..574bdc0 100644 --- a/vcl/inc/win/salids.hrc +++ b/vcl/inc/win/salids.hrc @@ -115,6 +115,4 @@ #define SAL_RESID_BITMAP_50 11000 -#define SAL_RESID_ICON_DEFAULT 1 - #endif // _SV_SALIDS_HRC diff --git a/vcl/win/source/app/salinst.cxx b/vcl/win/source/app/salinst.cxx index 90841f7..d3fce7c 100644 --- a/vcl/win/source/app/salinst.cxx +++ b/vcl/win/source/app/salinst.cxx @@ -541,7 +541,6 @@ SalInstance* CreateSalInstance() aWndClassEx.hbrBackground = 0; aWndClassEx.lpszMenuName= 0; aWndClassEx.lpszClassName = SAL_FRAME_CLASSNAMEW; -ImplLoadSalIcon( SAL_RESID_ICON_DEFAULT, aWndClassEx.hIcon, aWndClassEx.hIconSm ); if ( !RegisterClassExW( aWndClassEx ) ) return NULL; diff --git a/vcl/win/source/src/salsrc.rc b/vcl/win/source/src/salsrc.rc index 147b80f..956f862 100644 --- a/vcl/win/source/src/salsrc.rc +++ b/vcl/win/source/src/salsrc.rc @@ -117,6 +117,4 @@ SAL_RESID_POINTER_PAINTBRUSHCURSOR pntbrsh.cur SAL_RESID_BITMAP_50 BITMAP 50.bmp -SAL_RESID_ICON_DEFAULT ICONsd.ico - /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/vcl/win/source/src/sd.ico b/vcl/win/source/src/sd.ico deleted file mode 100644 index b2a0a07..000 Binary files a/vcl/win/source/src/sd.ico and /dev/null differ ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: vcl/WinResTarget_vcl.mk
vcl/WinResTarget_vcl.mk |1 - 1 file changed, 1 deletion(-) New commits: commit 9c9dbc1e26a268e0f1e7ceaccec384b3cde70a2b Author: Andras Timar ati...@suse.com Date: Sun Dec 4 15:10:44 2011 +0100 remove StarDesktop icon from the makefile, too diff --git a/vcl/WinResTarget_vcl.mk b/vcl/WinResTarget_vcl.mk index 2a6bc80..b6a0ca0 100644 --- a/vcl/WinResTarget_vcl.mk +++ b/vcl/WinResTarget_vcl.mk @@ -52,7 +52,6 @@ $(eval $(call gb_WinResTarget_add_dependency,vcl/src,\ vcl/win/source/src/copyf.cur \ vcl/win/source/src/drect.cur \ vcl/win/source/src/movef.cur \ -vcl/win/source/src/sd.ico \ vcl/win/source/src/ase.cur \ vcl/win/source/src/copyf2.cur \ vcl/win/source/src/dtext.cur \ ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: solenv/bin
solenv/bin/make_installer.pl | 33 --- solenv/bin/modules/installer/epmfile.pm | 46 solenv/bin/modules/installer/globals.pm |6 solenv/bin/modules/installer/parameter.pm | 21 -- solenv/bin/modules/installer/systemactions.pm |8 solenv/bin/modules/installer/worker.pm| 256 -- 6 files changed, 370 deletions(-) New commits: commit 0411cd764bc960ad737d67cffac3fa81d483e317 Author: Andras Timar ati...@suse.com Date: Sun Dec 4 15:32:26 2011 +0100 remove packaging for Java Desktop System (JDS) diff --git a/solenv/bin/make_installer.pl b/solenv/bin/make_installer.pl index 5ebd70f..c9d9f02 100644 --- a/solenv/bin/make_installer.pl +++ b/solenv/bin/make_installer.pl @@ -632,14 +632,12 @@ for ( my $n = 0; $n = $#installer::globals::languageproducts; $n++ ) { $installer::globals::addlicensefile = 0;# no license files for patches $installer::globals::makedownload = 0; -$installer::globals::makejds = 0; } if ( $installer::globals::languagepack ) { $installer::globals::addchildprojects = 0; $installer::globals::addsystemintegration = 0; -$installer::globals::makejds = 0; $installer::globals::addlicensefile = 0; $installer::globals::makedownload = 1; } @@ -648,7 +646,6 @@ for ( my $n = 0; $n = $#installer::globals::languageproducts; $n++ ) { $installer::globals::addchildprojects = 0; $installer::globals::addsystemintegration = 0; -$installer::globals::makejds = 0; $installer::globals::addlicensefile = 0; $installer::globals::makedownload = 1; } @@ -1872,36 +1869,6 @@ for ( my $n = 0; $n = $#installer::globals::languageproducts; $n++ ) installer::worker::analyze_and_save_logfile($loggingdir, $downloaddir, $installlogdir, $allsettingsarrayref, $languagestringref, $current_install_number); } } - -### -# Creating jds installation set -### - -if ( $installer::globals::makejds ) -{ -my $create_jds = 0; - -if ( $allvariableshashref-{'JDSBUILD'} ) { $create_jds = 1; } -if (! $installer::globals::issolarispkgbuild ) { $create_jds = 0; } - -if (( $is_success ) ( $create_jds )) -{ -if ( ! $installer::globals::jds_language_controlled ) -{ -my $correct_language = installer::worker::check_jds_language($allvariableshashref, $languagestringref); -$installer::globals::correct_jds_language = $correct_language; -$installer::globals::jds_language_controlled = 1; -} - -if ( $installer::globals::correct_jds_language ) -{ -my $jdsdir = installer::worker::create_jds_sets($finalinstalldir, $allvariableshashref, $languagestringref, $languagesarrayref, $includepatharrayref); -installer::worker::clean_jds_temp_dirs(); -installer::worker::analyze_and_save_logfile($loggingdir, $jdsdir, $installlogdir, $allsettingsarrayref, $languagestringref, $current_install_number); -} -} -} - } # end of if (!( $installer::globals::iswindowsbuild )) if ( $installer::globals::debug ) { installer::logger::debuginfo(\nEnd of part 2a: All non-Windows platforms\n); } diff --git a/solenv/bin/modules/installer/epmfile.pm b/solenv/bin/modules/installer/epmfile.pm index eff03a5..76c1792 100644 --- a/solenv/bin/modules/installer/epmfile.pm +++ b/solenv/bin/modules/installer/epmfile.pm @@ -2391,52 +2391,6 @@ sub create_packages_without_epm # It might be necessary to save uncompressed Solaris packages -if ( $allvariables-{'JDSBUILD'} ) -{ -if ( ! $installer::globals::jds_language_controlled ) -{ -my $correct_language = installer::worker::check_jds_language($allvariables, $languagestringref); -$installer::globals::correct_jds_language = $correct_language; -$installer::globals::jds_language_controlled = 1; -} - -if ( $installer::globals::correct_jds_language ) -{ -if ( $installer::globals::saved_packages_path eq ) -{ -$packagestempdir = installer::systemactions::create_directories(jds, $languagestringref); -$installer::globals::saved_packages_path = $packagestempdir; -push(@installer::globals::jdsremovedirs, $packagestempdir); -} - -$systemcall = cd $destinationdir; cp -p -R $packagename $installer::globals::saved_packages_path;; -
[Libreoffice-commits] .: 3 commits - sc/source
sc/source/core/data/table1.cxx | 82 - 1 file changed, 48 insertions(+), 34 deletions(-) New commits: commit e42ee773ffc12e38d596ce2aa016f0849c4e5ac6 Author: Pierre-André Jacquod pjacq...@alumni.ethz.ch Date: Tue Nov 29 09:10:26 2011 +0100 reduce scope of var and better comment of function GetDataArea diff --git a/sc/source/core/data/table1.cxx b/sc/source/core/data/table1.cxx index 3c142c1..06b8203 100644 --- a/sc/source/core/data/table1.cxx +++ b/sc/source/core/data/table1.cxx @@ -743,17 +743,19 @@ bool ScTable::GetDataStart( SCCOL rStartCol, SCROW rStartRow ) const void ScTable::GetDataArea( SCCOL rStartCol, SCROW rStartRow, SCCOL rEndCol, SCROW rEndRow, bool bIncludeOld, bool bOnlyDown ) const { -// bIncludeOld = true ensure that the returned area contains at least the initial area, -// independently of the case if this area has empty rows / columns at its borders -// bOnlyDown = true means extend the inputed area only down, i.e increase only rEndRow +// return the smallest area containing at least all contiguous cells having data. This area +// is a square containing also empty cells. It may shrink or extend the area given as input +// Flags as modifiers: +// +// bIncludeOld = true ensure that the returned area contains at least the initial area, +// independently of the emptniess of rows / columns (i.e. does not allow shrinking) +// bOnlyDown = true means extend / shrink the inputed area only down, i.e modifiy only rEndRow + bool bLeft = false; bool bRight = false; bool bTop = false; bool bBottom = false; -bool bChanged; -bool bFound; -SCCOL i; -SCROW nTest; +bool bChanged = false; do { @@ -784,12 +786,12 @@ void ScTable::GetDataArea( SCCOL rStartCol, SCROW rStartRow, SCCOL rEndCol, S if (rStartRow 0) { -nTest = rStartRow-1; -bFound = false; -for (i=rStartCol; i=rEndCol !bFound; i++) +SCROW nTest = rStartRow-1; +bool needExtend = false; +for ( SCCOL i = rStartCol; i=rEndCol !needExtend; i++) if (aCol[i].HasDataAt(nTest)) -bFound = true; -if (bFound) +needExtend = true; +if (needExtend) { --rStartRow; bChanged = true; @@ -800,12 +802,12 @@ void ScTable::GetDataArea( SCCOL rStartCol, SCROW rStartRow, SCCOL rEndCol, S if (rEndRow MAXROW) { -nTest = rEndRow+1; -bFound = false; -for (i=rStartCol; i=rEndCol !bFound; i++) +SCROW nTest = rEndRow+1; +bool needExtend = false; +for ( SCCOL i = rStartCol; i=rEndCol !needExtend; i++) if (aCol[i].HasDataAt(nTest)) -bFound = true; -if (bFound) +needExtend = true; +if (needExtend) { ++rEndRow; bChanged = true; @@ -830,7 +832,7 @@ void ScTable::GetDataArea( SCCOL rStartCol, SCROW rStartRow, SCCOL rEndCol, S bool shrink = true; do { -for (i=rStartCol; i=rEndCol shrink; i++) +for ( SCCOL i = rStartCol; i=rEndCol shrink; i++) if (aCol[i].HasDataAt(rStartRow)) shrink = false; if (shrink) @@ -846,7 +848,7 @@ void ScTable::GetDataArea( SCCOL rStartCol, SCROW rStartRow, SCCOL rEndCol, S bool shrink = true; do { -for (i=rStartCol; i=rEndCol shrink; i++) +for ( SCCOL i = rStartCol; i=rEndCol shrink; i++) if (aCol[i].HasDataAt(rEndRow)) shrink = false; if (shrink) commit 2e5023f974dd94dfeec0554ce07d0544f9ce7638 Author: Pierre-André Jacquod pjacq...@alumni.ethz.ch Date: Mon Nov 28 10:10:15 2011 +0100 if empty row / col leads to shrink area, suppress all empty rows/col and not just the last one, leaving the other within the selection area diff --git a/sc/source/core/data/table1.cxx b/sc/source/core/data/table1.cxx index 2262eca..3c142c1 100644 --- a/sc/source/core/data/table1.cxx +++ b/sc/source/core/data/table1.cxx @@ -817,22 +817,25 @@ void ScTable::GetDataArea( SCCOL rStartCol, SCROW rStartRow, SCCOL rEndCol, S if ( !bIncludeOld !bOnlyDown ) { -if ( !bLeft rStartCol MAXCOL rStartCol rEndCol ) -if ( aCol[rStartCol].IsEmptyBlock(rStartRow,rEndRow) ) +if ( !bLeft ) +while ( aCol[rStartCol].IsEmptyBlock(rStartRow,rEndRow) rStartCol MAXCOL rStartCol rEndCol) ++rStartCol; -if (
[Libreoffice-commits] .: 4 commits - starmath/inc starmath/source
starmath/inc/view.hxx |1 starmath/source/cursor.cxx | 23 +++--- starmath/source/view.cxx | 47 ++--- 3 files changed, 41 insertions(+), 30 deletions(-) New commits: commit 68c1f757962a8f2789821ff636bc397d1edd0051 Author: Ivan Timofeev timofeev@gmail.com Date: Sun Dec 4 15:11:23 2011 +0400 visual formula editor: implement selection by mouse diff --git a/starmath/inc/view.hxx b/starmath/inc/view.hxx index d716e72..5781e26 100644 --- a/starmath/inc/view.hxx +++ b/starmath/inc/view.hxx @@ -103,6 +103,7 @@ public: // Window virtual voidMouseButtonDown(const MouseEvent rMEvt); +virtual voidMouseMove(const MouseEvent rMEvt); virtual voidGetFocus(); virtual voidLoseFocus(); diff --git a/starmath/source/view.cxx b/starmath/source/view.cxx index c9a0ffd..4dbc8a8 100644 --- a/starmath/source/view.cxx +++ b/starmath/source/view.cxx @@ -182,9 +182,7 @@ void SmGraphicWindow::MouseButtonDown(const MouseEvent rMEvt) return; if (IsInlineEditEnabled()) { -// if it was clicked inside the formula then get the appropriate node -if (pTree-OrientedDist(aPos) = 0) -pViewShell-GetDoc()-GetCursor().MoveTo(this, aPos, !rMEvt.IsShift()); +pViewShell-GetDoc()-GetCursor().MoveTo(this, aPos, !rMEvt.IsShift()); return; } const SmNode *pNode = 0; @@ -214,6 +212,22 @@ void SmGraphicWindow::MouseButtonDown(const MouseEvent rMEvt) } } +void SmGraphicWindow::MouseMove(const MouseEvent rMEvt) +{ +ScrollableWindow::MouseMove(rMEvt); + +if (rMEvt.IsLeft() IsInlineEditEnabled()) +{ +Point aPos(PixelToLogic(rMEvt.GetPosPixel()) - GetFormulaDrawPos()); +pViewShell-GetDoc()-GetCursor().MoveTo(this, aPos, false); + +CaretBlinkStop(); +SetIsCursorVisible(true); +CaretBlinkStart(); +RepaintViewShellDoc(); +} +} + bool SmGraphicWindow::IsInlineEditEnabled() const { return pViewShell-IsInlineEditEnabled(); commit 558b5ea32a99654dcb63526f107726f7aec4747f Author: Ivan Timofeev timofeev@gmail.com Date: Sun Dec 4 15:05:46 2011 +0400 visual formula editor: copy/cut/paste for any keyboard layout diff --git a/starmath/source/view.cxx b/starmath/source/view.cxx index 66626a0..c9a0ffd 100644 --- a/starmath/source/view.cxx +++ b/starmath/source/view.cxx @@ -421,8 +421,17 @@ void SmGraphicWindow::KeyInput(const KeyEvent rKEvt) ScrollableWindow::KeyInput(rKEvt); return; } -sal_uInt16 nCode = rKEvt.GetKeyCode().GetCode(); + SmCursor rCursor = pViewShell-GetDoc()-GetCursor(); +KeyFuncType eFunc = rKEvt.GetKeyCode().GetFunction(); +if (eFunc == KEYFUNC_COPY) +rCursor.Copy(); +else if (eFunc == KEYFUNC_CUT) +rCursor.Cut(); +else if (eFunc == KEYFUNC_PASTE) +rCursor.Paste(); +else { +sal_uInt16 nCode = rKEvt.GetKeyCode().GetCode(); switch(nCode) { case KEY_LEFT: @@ -491,15 +500,6 @@ void SmGraphicWindow::KeyInput(const KeyEvent rKEvt) case KEY_EQUAL: rCursor.InsertElement(EqualElement); break; -case KEY_COPY: -rCursor.Copy(); -break; -case KEY_CUT: -rCursor.Cut(); -break; -case KEY_PASTE: -rCursor.Paste(); -break; default: { sal_Unicode code = rKEvt.GetCharCode(); @@ -507,12 +507,6 @@ void SmGraphicWindow::KeyInput(const KeyEvent rKEvt) if(code == ' ') { rCursor.InsertElement(BlankElement); -}else if(code == 'c' rKEvt.GetKeyCode().IsMod1()) { -rCursor.Copy(); -}else if(code == 'x' rKEvt.GetKeyCode().IsMod1()) { -rCursor.Cut(); -}else if(code == 'v' rKEvt.GetKeyCode().IsMod1()) { -rCursor.Paste(); }else if(code == '^') { rCursor.InsertSubSup(RSUP); }else if(code == '(') { @@ -539,6 +533,7 @@ void SmGraphicWindow::KeyInput(const KeyEvent rKEvt) } } } +} CaretBlinkStop(); CaretBlinkStart(); SetIsCursorVisible(true); commit 5a227745095d3a700ca01e062264aa5afd080c8a Author: Ivan Timofeev timofeev@gmail.com Date: Fri Dec 2 22:07:34 2011 +0400 visual formula editor: place cursor on numerator when creating empty fraction diff --git a/starmath/source/cursor.cxx b/starmath/source/cursor.cxx index b7f518f..c2d7f4f 100644 --- a/starmath/source/cursor.cxx +++ b/starmath/source/cursor.cxx @@ -977,7 +977,8 @@ void SmCursor::InsertFraction() { PatchLineList(pLineList, it); //Finish editing -FinishEdit(pLineList, pLineParent, nParentIndex, SmCaretPos(pDenom, 1)); +SmNode *pSelectedNode = bEmptyFraction ? pNum : pDenom; +FinishEdit(pLineList, pLineParent,
[Libreoffice-commits] .: basctl/uiconfig officecfg/registry
basctl/uiconfig/basicide/menubar/menubar.xml |2 +- officecfg/registry/data/org/openoffice/Office/UI/BasicIDECommands.xcu |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 6ddc99b1dd4d64842ed7fca35b991b8cde8a724c Author: Stefan Knorr (astron) heinzless...@gmail.com Date: Sun Dec 4 15:31:25 2011 +0100 String change for Line Number functionality in Basic IDE diff --git a/basctl/uiconfig/basicide/menubar/menubar.xml b/basctl/uiconfig/basicide/menubar/menubar.xml index 24322b8..15d4fcd 100644 --- a/basctl/uiconfig/basicide/menubar/menubar.xml +++ b/basctl/uiconfig/basicide/menubar/menubar.xml @@ -48,8 +48,8 @@ menu:menuitem menu:id=.uno:AvailableToolbars/ menu:menuitem menu:id=.uno:StatusBarVisible/ menu:menuitem menu:id=.uno:ShowImeStatusWindow/ -menu:menuitem menu:id=.uno:GotoLine/ menu:menuitem menu:id=.uno:ShowLines/ +menu:menuitem menu:id=.uno:GotoLine/ menu:menuseparator/ menu:menuitem menu:id=.uno:FullScreen/ /menu:menupopup diff --git a/officecfg/registry/data/org/openoffice/Office/UI/BasicIDECommands.xcu b/officecfg/registry/data/org/openoffice/Office/UI/BasicIDECommands.xcu index 84e5c41..47c7b35 100644 --- a/officecfg/registry/data/org/openoffice/Office/UI/BasicIDECommands.xcu +++ b/officecfg/registry/data/org/openoffice/Office/UI/BasicIDECommands.xcu @@ -10,7 +10,7 @@ /node node oor:name=.uno:ShowLines oor:op=replace prop oor:name=Label oor:type=xs:string - value xml:lang=en-USDisplay Source Line Number/value + value xml:lang=en-USLine Numbers/value /prop /node ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: basic/source
basic/source/comp/scanner.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit cc744ef568fed0529da133a9d97e1dec19daab10 Author: August Sodora aug...@gmail.com Date: Sun Dec 4 17:29:16 2011 -0500 Use sal_uInt16 here diff --git a/basic/source/comp/scanner.cxx b/basic/source/comp/scanner.cxx index 3b57781..dabeffe 100644 --- a/basic/source/comp/scanner.cxx +++ b/basic/source/comp/scanner.cxx @@ -152,7 +152,7 @@ static SbxDataType GetSuffixType( sal_Unicode c ) void SbiScanner::scanGoto() { -short nTestCol = nCol; +sal_uInt16 nTestCol = nCol; while(nTestCol aLine.getLength() theBasicCharClass::get().isWhitespace(aLine[nTestCol])) nTestCol++; @@ -162,7 +162,7 @@ void SbiScanner::scanGoto() if(aTestSym.equalsIgnoreAsciiCaseAsciiL(RTL_CONSTASCII_STRINGPARAM(to))) { aSym = ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(goto)); -pLine += (nTestCol - nCol) + 2; +pLine += nTestCol + 2 - nCol; nCol = nTestCol + 2; } } ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: basic/source
basic/source/comp/scanner.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 0bcc6c93b8dbd92f7f13ea40c464636b00be0d6f Author: August Sodora aug...@gmail.com Date: Sun Dec 4 18:08:28 2011 -0500 Use appropriate datatypes here too diff --git a/basic/source/comp/scanner.cxx b/basic/source/comp/scanner.cxx index dabeffe..cc17fd5 100644 --- a/basic/source/comp/scanner.cxx +++ b/basic/source/comp/scanner.cxx @@ -240,7 +240,7 @@ bool SbiScanner::NextSym() { pLine++; goto eoln; } bSymbol = true; -short n = nCol; +sal_uInt16 n = nCol; for ( ; (theBasicCharClass::get().isAlphaNumeric( *pLine, bCompatible ) || ( *pLine == '_' ) ); pLine++ ) nCol++; aSym = aLine.copy( n, nCol - n ); @@ -424,7 +424,7 @@ bool SbiScanner::NextSym() sal_Unicode cSep = *pLine; if( cSep == '[' ) bSymbol = true, cSep = ']'; -short n = nCol+1; +sal_uInt16 n = nCol + 1; while( *pLine ) { do pLine++, nCol++; @@ -460,7 +460,7 @@ bool SbiScanner::NextSym() // other groups: else { -short n = 1; +sal_uInt8 n = 1; switch( *pLine++ ) { case '': if( *pLine == '' || *pLine == '=' ) n = 2; break; ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: connectivity/source
connectivity/source/drivers/postgresql/makefile.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 402db3dceb02134860cf42af791523e7703c34dd Author: Lionel Elie Mamane lio...@mamane.lu Date: Mon Dec 5 00:09:50 2011 +0100 PostgreSQL-SDBC: increment version number diff --git a/connectivity/source/drivers/postgresql/makefile.mk b/connectivity/source/drivers/postgresql/makefile.mk index 615b26b..aa168b0 100644 --- a/connectivity/source/drivers/postgresql/makefile.mk +++ b/connectivity/source/drivers/postgresql/makefile.mk @@ -74,7 +74,7 @@ DLLPRE= PQ_SDBC_MAJOR=0 PQ_SDBC_MINOR=8 -PQ_SDBC_MICRO=1 +PQ_SDBC_MICRO=2 PQ_SDBC_VERSION=$(PQ_SDBC_MAJOR).$(PQ_SDBC_MINOR).$(PQ_SDBC_MICRO) CFLAGS+=$(POSTGRESQL_INC) \ ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: basctl/source
basctl/source/inc/bastypes.hxx | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) New commits: commit 71de946a1a2f5479667abd0e8cd0446b1db3ee96 Author: August Sodora aug...@gmail.com Date: Sun Dec 4 18:55:49 2011 -0500 sal_Bool to bool diff --git a/basctl/source/inc/bastypes.hxx b/basctl/source/inc/bastypes.hxx index 25b276a..8684fe5 100644 --- a/basctl/source/inc/bastypes.hxx +++ b/basctl/source/inc/bastypes.hxx @@ -53,14 +53,16 @@ sal_Int32 searchEOL( const ::rtl::OUString rStr, sal_Int32 fromIndex ); struct BasicStatus { -sal_BoolbIsRunning : 1; -sal_BoolbError : 1; -sal_BoolbIsInReschedule : 1; -sal_uInt16 nBasicFlags; - -BasicStatus() { -bIsRunning = sal_False; bError = sal_False; -nBasicFlags = 0; bIsInReschedule = sal_False; } +bool bIsRunning : 1; +bool bError : 1; +bool bIsInReschedule : 1; +sal_uInt16 nBasicFlags; + +BasicStatus(): +bIsRunning(false), +bError(false), +bIsInReschedule(false), +nBasicFlags(0) { } }; struct BreakPoint ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 6 commits - sc/CppunitTest_sc_cellrangesbase.mk sc/CppunitTest_sc_tableautoformatfield.mk sc/CppunitTest_sc_xcellrangesquery.mk sc/Module_sc.mk sc/qa sc/source
sc/CppunitTest_sc_cellrangesbase.mk | 142 ++ sc/CppunitTest_sc_tableautoformatfield.mk | 141 + sc/CppunitTest_sc_xcellrangesquery.mk | 141 - sc/Module_sc.mk |3 sc/qa/extras/cellproperties.cxx | 117 sc/qa/extras/tableautoformatfield.cxx | 107 ++ sc/qa/extras/xcellrangesquery.cxx |2 sc/source/filter/xml/xmlcelli.cxx |2 sc/source/ui/namedlg/namedefdlg.cxx |4 sc/source/ui/namedlg/namedlg.cxx | 25 +++-- sc/source/ui/src/namedlg.src |4 11 files changed, 532 insertions(+), 156 deletions(-) New commits: commit 9d5d04776f0a163796a41446852ec59ba76c9c1a Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Mon Dec 5 00:53:14 2011 +0100 add subsequenttest for failing test CellProperties share test between all services which share the implementation in ScCellRangesBase diff --git a/sc/CppunitTest_sc_cellrangesbase.mk b/sc/CppunitTest_sc_cellrangesbase.mk index 2c1063f..98d1683 100644 --- a/sc/CppunitTest_sc_cellrangesbase.mk +++ b/sc/CppunitTest_sc_cellrangesbase.mk @@ -32,6 +32,7 @@ $(eval $(call gb_CppunitTest_CppunitTest,sc_cellrangesbase)) $(eval $(call gb_CppunitTest_add_exception_objects,sc_cellrangesbase, \ sc/qa/extras/xcellrangesquery \ +sc/qa/extras/cellproperties \ )) $(eval $(call gb_CppunitTest_add_linked_libs,sc_cellrangesbase, \ diff --git a/sc/qa/extras/cellproperties.cxx b/sc/qa/extras/cellproperties.cxx new file mode 100644 index 000..20e90f4 --- /dev/null +++ b/sc/qa/extras/cellproperties.cxx @@ -0,0 +1,117 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * Version: MPL 1.1 / GPLv3+ / LGPLv3+ + * + * The contents of this file are subject to the Mozilla Public License Version + * 1.1 (the License); you may not use this file except in compliance with + * the License or as specified alternatively below. You may obtain a copy of + * the License at http://www.mozilla.org/MPL/ + * + * Software distributed under the License is distributed on an AS IS basis, + * WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License + * for the specific language governing rights and limitations under the + * License. + * + * Major Contributor(s): + * Copyright (C) 2011 Markus Mohrhard markus.mohrh...@googlemail.com (initial developer) + * + * All Rights Reserved. + * + * For minor contributions see the git repository. + * + * Alternatively, the contents of this file may be used under the terms of + * either the GNU General Public License Version 3 or later (the GPLv3+), or + * the GNU Lesser General Public License Version 3 or later (the LGPLv3+), + * in which case the provisions of the GPLv3+ or the LGPLv3+ are applicable + * instead of those above. + */ + +#include test/unoapi_test.hxx + +#include com/sun/star/beans/XPropertySet.hpp +#include com/sun/star/table/CellVertJustify.hpp +#include com/sun/star/sheet/XSpreadsheetDocument.hpp +#include com/sun/star/sheet/XSpreadsheet.hpp +#include com/sun/star/table/XCellRange.hpp + +namespace ScCellRangeBase { + +class ScCellProperties : public UnoApiTest +{ +uno::Reference beans::XPropertySet init(); + +void testVertJustify(); +void testRotateReference(); +CPPUNIT_TEST_SUITE(ScCellProperties); +//enable as soon as fixed +//CPPUNIT_TEST(testVertJustify); +//CPPUNIT_TEST(testRotateReference); +CPPUNIT_TEST_SUITE_END(); +}; + +void ScCellProperties::testVertJustify() +{ +uno::Reference beans::XPropertySet xCellRangeBase = init(); +rtl::OUString aVertJustify(RTL_CONSTASCII_USTRINGPARAM(VertJustify)); +uno::Any aOldVertJustify = xCellRangeBase-getPropertyValue(aVertJustify); +sal_Int32 aValue; +CPPUNIT_ASSERT(aOldVertJustify = aValue); +std::cout Old VertJustify value: aValue std::endl; + +uno::Any aNewVertJustify; +aNewVertJustify = table::CellVertJustify_BOTTOM; +xCellRangeBase-setPropertyValue(aVertJustify, aNewVertJustify); +uno::Any aVertJustifyControllValue = xCellRangeBase-getPropertyValue(aVertJustify); +CPPUNIT_ASSERT(aVertJustifyControllValue = aValue); +std::cout New VertJustify value: aValue std::endl; +CPPUNIT_ASSERT_MESSAGE(value has not been changed, aValue == table::CellVertJustify_BOTTOM); +} + +void ScCellProperties::testRotateReference() +{ +uno::Reference beans::XPropertySet xCellRangeBase = init(); +rtl::OUString aRotateReference(RTL_CONSTASCII_USTRINGPARAM(RotateReference)); +uno::Any aOldRotateReference = xCellRangeBase-getPropertyValue(aRotateReference); +sal_Int32 aValue; +CPPUNIT_ASSERT(aOldRotateReference = aValue); +std::cout Old RotateReference Value: aValue std::endl; + +uno::Any aNewRotateReference; +aNewRotateReference =
[Libreoffice-commits] .: dbaccess/source
dbaccess/source/ui/dlg/dbadmin.src |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3a9271b8fc70f263d1d7ffb8caae915447c32228 Author: Lior Kaplan kaplanl...@gmail.com Date: Mon Dec 5 03:11:19 2011 +0200 Add missing space diff --git a/dbaccess/source/ui/dlg/dbadmin.src b/dbaccess/source/ui/dlg/dbadmin.src index d3a356f..8bacdec 100644 --- a/dbaccess/source/ui/dlg/dbadmin.src +++ b/dbaccess/source/ui/dlg/dbadmin.src @@ -692,7 +692,7 @@ TabPage PAGE_LDAP { Pos = MAP_APPFONT ( 6 , 2*UNRELATED_CONTROLS + RELATED_CONTROLS + 2*FIXEDTEXT_HEIGHT) ; Size = MAP_APPFONT ( PAGE_X - 12 , CHECKBOX_HEIGHT ) ; -Text [ en-US ] = Use secure connection(SSL); +Text [ en-US ] = Use secure connection (SSL); HelpId = HID_DSADMIN_USESSL_LDAP; }; ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - basctl/Library_basctl.mk basctl/source
basctl/Library_basctl.mk |1 basctl/source/basicide/baside2.hxx|1 basctl/source/basicide/baside2b.cxx |2 basctl/source/basicide/basidesh.cxx |4 basctl/source/basicide/bastypes.cxx | 125 --- basctl/source/basicide/breakpoint.cxx | 179 ++ basctl/source/basicide/breakpoint.hxx | 79 +++ basctl/source/basicide/brkdlg.cxx | 15 +- basctl/source/inc/bastypes.hxx| 73 + 9 files changed, 279 insertions(+), 200 deletions(-) New commits: commit f81a7438409ee9cede09b0395d8af0943220a4ea Author: August Sodora aug...@gmail.com Date: Sun Dec 4 22:01:35 2011 -0500 Refactor BreakPoint diff --git a/basctl/Library_basctl.mk b/basctl/Library_basctl.mk index 45403ec..438c8c3 100644 --- a/basctl/Library_basctl.mk +++ b/basctl/Library_basctl.mk @@ -85,6 +85,7 @@ $(eval $(call gb_Library_add_exception_objects,basctl,\ basctl/source/basicide/bastype2 \ basctl/source/basicide/bastype3 \ basctl/source/basicide/bastypes \ + basctl/source/basicide/breakpoint \ basctl/source/basicide/brkdlg \ basctl/source/basicide/doceventnotifier \ basctl/source/basicide/docsignature \ diff --git a/basctl/source/basicide/baside2.hxx b/basctl/source/basicide/baside2.hxx index 119aa60..e9378ab 100644 --- a/basctl/source/basicide/baside2.hxx +++ b/basctl/source/basicide/baside2.hxx @@ -51,6 +51,7 @@ class SvxSearchItem; #include sfx2/progress.hxx #include svtools/syntaxhighlight.hxx +#include breakpoint.hxx #include linenumberwindow.hxx DBG_NAMEEX( ModulWindow ) diff --git a/basctl/source/basicide/baside2b.cxx b/basctl/source/basicide/baside2b.cxx index 4ad4eea..dfef385 100644 --- a/basctl/source/basicide/baside2b.cxx +++ b/basctl/source/basicide/baside2b.cxx @@ -26,14 +26,12 @@ * / - #define _BASIC_TEXTPORTIONS #include helpid.hrc #include baside2.hrc #include baside2.hxx -#include basobj.hxx #include brkdlg.hxx #include iderdll.hxx #include iderdll2.hxx diff --git a/basctl/source/basicide/bastypes.cxx b/basctl/source/basicide/bastypes.cxx index 2ced841..21dfce9 100644 --- a/basctl/source/basicide/bastypes.cxx +++ b/basctl/source/basicide/bastypes.cxx @@ -252,127 +252,6 @@ Window* IDEBaseWindow::GetLayoutWindow() return NULL; } -BreakPointList::BreakPointList() -{} - -BreakPointList::BreakPointList(BreakPointList const rList) -{ -for (size_t i = 0; i rList.size(); ++i) -maBreakPoints.push_back( new BreakPoint(*rList.at( i ) ) ); -} - -BreakPointList::~BreakPointList() -{ -reset(); -} - -void BreakPointList::reset() -{ -for ( size_t i = 0, n = maBreakPoints.size(); i n; ++i ) -delete maBreakPoints[ i ]; -maBreakPoints.clear(); -} - -void BreakPointList::transfer(BreakPointList rList) -{ -reset(); -for (size_t i = 0; i rList.size(); ++i) -maBreakPoints.push_back( rList.at( i ) ); -rList.clear(); -} - -void BreakPointList::InsertSorted( BreakPoint* pNewBrk ) -{ -for ( vector BreakPoint* ::iterator i = maBreakPoints.begin(); i maBreakPoints.end(); ++i ) -{ -if ( pNewBrk-nLine = (*i)-nLine ) -{ -DBG_ASSERT( ( (*i)-nLine != pNewBrk-nLine ) || pNewBrk-bTemp, BreakPoint existiert schon! ); -maBreakPoints.insert( i, pNewBrk ); -return; -} -} -// no insert position found = LIST_APPEND -maBreakPoints.push_back( pNewBrk ); -} - -void BreakPointList::SetBreakPointsInBasic( SbModule* pModule ) -{ -pModule-ClearAllBP(); - -for ( size_t i = 0, n = maBreakPoints.size(); i n; ++i ) -{ -BreakPoint* pBrk = maBreakPoints[ i ]; -if ( pBrk-bEnabled ) -pModule-SetBP( (sal_uInt16)pBrk-nLine ); -} -} - -BreakPoint* BreakPointList::FindBreakPoint( size_t nLine ) -{ -for ( size_t i = 0, n = maBreakPoints.size(); i n; ++i ) -{ -BreakPoint* pBrk = maBreakPoints[ i ]; -if ( pBrk-nLine == nLine ) -return pBrk; -} -return NULL; -} - -void BreakPointList::AdjustBreakPoints( size_t nLine, bool bInserted ) -{ -for ( size_t i = 0; i maBreakPoints.size(); ) -{ -BreakPoint* pBrk = maBreakPoints[ i ]; -bool bDelBrk = false; -if ( pBrk-nLine == nLine ) -{ -if ( bInserted ) -pBrk-nLine++; -else -bDelBrk = true; -} -else if ( pBrk-nLine nLine ) -{ -if ( bInserted ) -pBrk-nLine++; -else -pBrk-nLine--; -} - -if ( bDelBrk ) -{ -delete remove( pBrk ); -} -else -{ -++i; -} -} -} - -void BreakPointList::ResetHitCount() -{ -for ( size_t i = 0, n = maBreakPoints.size(); i n; ++i ) -{ -
[Libreoffice-commits] .: basic/source
basic/source/comp/scanner.cxx | 17 + basic/source/inc/scanner.hxx |1 + 2 files changed, 14 insertions(+), 4 deletions(-) New commits: commit 40be618fb31754611dbd4241322004b205774976 Author: August Sodora aug...@gmail.com Date: Sun Dec 4 22:13:24 2011 -0500 Refactor scanAlphanumeric diff --git a/basic/source/comp/scanner.cxx b/basic/source/comp/scanner.cxx index cc17fd5..4b4ba23 100644 --- a/basic/source/comp/scanner.cxx +++ b/basic/source/comp/scanner.cxx @@ -150,6 +150,17 @@ static SbxDataType GetSuffixType( sal_Unicode c ) // return value is sal_False at EOF or errors #define BUF_SIZE 80 +void SbiScanner::scanAlphanumeric() +{ +sal_uInt16 n = nCol; +while(theBasicCharClass::get().isAlphaNumeric(*pLine, bCompatible) || *pLine == '_') +{ +pLine++; +nCol++; +} +aSym = aLine.copy(n, nCol - n); +} + void SbiScanner::scanGoto() { sal_uInt16 nTestCol = nCol; @@ -240,10 +251,8 @@ bool SbiScanner::NextSym() { pLine++; goto eoln; } bSymbol = true; -sal_uInt16 n = nCol; -for ( ; (theBasicCharClass::get().isAlphaNumeric( *pLine, bCompatible ) || ( *pLine == '_' ) ); pLine++ ) -nCol++; -aSym = aLine.copy( n, nCol - n ); + +scanAlphanumeric(); // Special handling for go to if( bCompatible *pLine aSym.equalsIgnoreAsciiCaseAsciiL( RTL_CONSTASCII_STRINGPARAM(go) ) ) diff --git a/basic/source/inc/scanner.hxx b/basic/source/inc/scanner.hxx index c254cf2..abda26b 100644 --- a/basic/source/inc/scanner.hxx +++ b/basic/source/inc/scanner.hxx @@ -46,6 +46,7 @@ class SbiScanner const sal_Unicode* pLine; const sal_Unicode* pSaveLine; +void scanAlphanumeric(); void scanGoto(); protected: ::rtl::OUString aSym; ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: basctl/source
basctl/source/basicide/breakpoint.hxx |1 + 1 file changed, 1 insertion(+) New commits: commit aa948e1c25dfa07f6bc47d1077a74ec61982b9c4 Author: Ivan Timofeev timofeev@gmail.com Date: Mon Dec 5 08:31:45 2011 +0400 add missing include for size_t diff --git a/basctl/source/basicide/breakpoint.hxx b/basctl/source/basicide/breakpoint.hxx index 16cdfa3..a989144 100644 --- a/basctl/source/basicide/breakpoint.hxx +++ b/basctl/source/basicide/breakpoint.hxx @@ -28,6 +28,7 @@ #ifndef _BREAKPOINT_HXX #define _BREAKPOINT_HXX +#include cstddef #include vector class SbModule; ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - basctl/source
basctl/source/basicide/baside2.cxx| 20 +++- basctl/source/basicide/breakpoint.cxx |2 ++ 2 files changed, 13 insertions(+), 9 deletions(-) New commits: commit ebf168f59f64b868002c10a49448e02939074755 Author: August Sodora aug...@gmail.com Date: Mon Dec 5 00:52:02 2011 -0500 So size_t is recognized on windows diff --git a/basctl/source/basicide/breakpoint.cxx b/basctl/source/basicide/breakpoint.cxx index b763174..6bbfdf9 100644 --- a/basctl/source/basicide/breakpoint.cxx +++ b/basctl/source/basicide/breakpoint.cxx @@ -31,6 +31,8 @@ #include basic/sbmod.hxx #include tools/debug.hxx +#include stddef.h + BreakPointList::BreakPointList() {} commit 5ca762a9caf9b89f225d2c8ddd32d265d4bddb61 Author: August Sodora aug...@gmail.com Date: Mon Dec 5 00:47:35 2011 -0500 String-OUString diff --git a/basctl/source/basicide/baside2.cxx b/basctl/source/basicide/baside2.cxx index 0f425cf..ddb3781 100644 --- a/basctl/source/basicide/baside2.cxx +++ b/basctl/source/basicide/baside2.cxx @@ -82,7 +82,7 @@ DBG_NAME( ModulWindow ) TYPEINIT1( ModulWindow , IDEBaseWindow ); -void lcl_PrintHeader( Printer* pPrinter, sal_uInt16 nPages, sal_uInt16 nCurPage, const String rTitle, bool bOutput ) +void lcl_PrintHeader( Printer* pPrinter, sal_uInt16 nPages, sal_uInt16 nCurPage, const ::rtl::OUString rTitle, bool bOutput ) { short nLeftMargin = LMARGPRN; Size aSz = pPrinter-GetOutputSize(); @@ -122,17 +122,20 @@ void lcl_PrintHeader( Printer* pPrinter, sal_uInt16 nPages, sal_uInt16 nCurPage, { aFont.SetWeight( WEIGHT_NORMAL ); pPrinter-SetFont( aFont ); -String aPageStr( RTL_CONSTASCII_USTRINGPARAM( [ ) ); -aPageStr += String( IDEResId( RID_STR_PAGE ) ); -aPageStr += ' '; -aPageStr += String::CreateFromInt32( nCurPage ); -aPageStr += ']'; aPos.X() += pPrinter-GetTextWidth( rTitle ); + if( bOutput ) -pPrinter-DrawText( aPos, aPageStr ); +{ +::rtl::OUStringBuffer aPageStr; +aPageStr.appendAscii( RTL_CONSTASCII_STRINGPARAM( [ ) ); +aPageStr.append(ResId::toString( IDEResId( RID_STR_PAGE ) )); +aPageStr.append(' '); +aPageStr.append( nCurPage ); +aPageStr.append(']'); +pPrinter-DrawText( aPos, aPageStr.makeStringAndClear() ); +} } - nY = TMARGPRN-nBorder; if( bOutput ) @@ -165,7 +168,6 @@ void lcl_ConvertTabsToSpaces( String rLine ) } } - ModulWindow::ModulWindow( ModulWindowLayout* pParent, const ScriptDocument rDocument, String aLibName, String aName, ::rtl::OUString aModule ) :IDEBaseWindow( pParent, rDocument, aLibName, aName ) ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: configure.in
configure.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 04f53f0714ed364177a740d9de52c497cda74064 Author: Lionel Elie Mamane lio...@mamane.lu Date: Mon Dec 5 07:46:59 2011 +0100 configure.in: search for pg_config in default fink/MacPort locations diff --git a/configure.in b/configure.in index 5b2a01c..cf0d3cb 100644 --- a/configure.in +++ b/configure.in @@ -5409,7 +5409,7 @@ if test x$enable_ext_postgresql_sdbc = xyes -a x$enable_extension_integrati SYSTEM_POSTGRESQL=YES if test $_os = Darwin; then supp_path='' - for d in /Library/PostgreSQL/9.*/bin; do + for d in /Library/PostgreSQL/9.*/bin /sw/opt/postgresql/9.*/bin /opt/local/lib/postgresql9*/bin; do pg_supp_path=$PATH_SEPARATOR$d$pg_supp_path done fi ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sal/osl
sal/osl/unx/process.cxx |4 1 file changed, 4 insertions(+) New commits: commit 90a3c0c0b46123a3647a53ddc942ba8614edb722 Author: Stephan Bergmann sberg...@redhat.com Date: Mon Dec 5 08:27:20 2011 +0100 ChildStatusProc needs to be extern C. diff --git a/sal/osl/unx/process.cxx b/sal/osl/unx/process.cxx index c35a340..57bc717 100644 --- a/sal/osl/unx/process.cxx +++ b/sal/osl/unx/process.cxx @@ -434,6 +434,8 @@ oslSocket osl_receiveResourcePipe(oslPipe pPipe) * */ +extern C { + static void ChildStatusProc(void *pData) { pid_t pid = -1; @@ -703,6 +705,8 @@ static void ChildStatusProc(void *pData) } } +} + /** osl_executeProcess_WithRedirectedIO */ ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: solenv/gbuild
solenv/gbuild/platform/WNT_INTEL_GCC.mk |8 solenv/gbuild/platform/WNT_INTEL_MSC.mk |8 2 files changed, 8 insertions(+), 8 deletions(-) New commits: commit a35140f245d774745b806ef12346aa77f0256395 Author: Tor Lillqvist tlillqv...@suse.com Date: Fri Dec 2 11:41:33 2011 +0200 Fix library layer mapping for the URELIB ones, fdo#42826 diff --git a/solenv/gbuild/platform/WNT_INTEL_GCC.mk b/solenv/gbuild/platform/WNT_INTEL_GCC.mk index ae99f11..78ce3bd 100644 --- a/solenv/gbuild/platform/WNT_INTEL_GCC.mk +++ b/solenv/gbuild/platform/WNT_INTEL_GCC.mk @@ -292,13 +292,13 @@ gb_Library_PLAINLIBS_NONE += \ gb_Library_LAYER := \ $(foreach lib,$(gb_Library_OOOLIBS),$(lib):OOO) \ $(foreach lib,$(gb_Library_PLAINLIBS_NONE),$(lib):OOO) \ - $(foreach lib,$(gb_Library_PLAINLIBS_URE),$(lib):OOO) \ + $(foreach lib,$(gb_Library_PLAINLIBS_URE),$(lib):URELIB) \ $(foreach lib,$(gb_Library_PLAINLIBS_OOO),$(lib):OOO) \ $(foreach lib,$(gb_Library_RTLIBS),$(lib):OOO) \ - $(foreach lib,$(gb_Library_RTVERLIBS),$(lib):OOO) \ - $(foreach lib,$(gb_Library_UNOLIBS_URE),$(lib):OOO) \ + $(foreach lib,$(gb_Library_RTVERLIBS),$(lib):URELIB) \ + $(foreach lib,$(gb_Library_UNOLIBS_URE),$(lib):URELIB) \ $(foreach lib,$(gb_Library_UNOLIBS_OOO),$(lib):OOO) \ - $(foreach lib,$(gb_Library_UNOVERLIBS),$(lib):OOO) \ + $(foreach lib,$(gb_Library_UNOVERLIBS),$(lib):URELIB) \ gb_Library_FILENAMES :=\ $(foreach lib,$(gb_Library_OOOLIBS),$(lib):$(gb_Library_SYSPRE)$(lib)$(gb_Library_OOOEXT)) \ diff --git a/solenv/gbuild/platform/WNT_INTEL_MSC.mk b/solenv/gbuild/platform/WNT_INTEL_MSC.mk index 7a56245..5f8fb1c 100644 --- a/solenv/gbuild/platform/WNT_INTEL_MSC.mk +++ b/solenv/gbuild/platform/WNT_INTEL_MSC.mk @@ -432,13 +432,13 @@ gb_Library_PLAINLIBS_NONE += \ gb_Library_LAYER := \ $(foreach lib,$(gb_Library_OOOLIBS),$(lib):OOO) \ $(foreach lib,$(gb_Library_PLAINLIBS_NONE),$(lib):OOO) \ - $(foreach lib,$(gb_Library_PLAINLIBS_URE),$(lib):OOO) \ + $(foreach lib,$(gb_Library_PLAINLIBS_URE),$(lib):URELIB) \ $(foreach lib,$(gb_Library_PLAINLIBS_OOO),$(lib):OOO) \ $(foreach lib,$(gb_Library_RTLIBS),$(lib):OOO) \ - $(foreach lib,$(gb_Library_RTVERLIBS),$(lib):OOO) \ - $(foreach lib,$(gb_Library_UNOLIBS_URE),$(lib):OOO) \ + $(foreach lib,$(gb_Library_RTVERLIBS),$(lib):URELIB) \ + $(foreach lib,$(gb_Library_UNOLIBS_URE),$(lib):URELIB) \ $(foreach lib,$(gb_Library_UNOLIBS_OOO),$(lib):OOO) \ - $(foreach lib,$(gb_Library_UNOVERLIBS),$(lib):OOO) \ + $(foreach lib,$(gb_Library_UNOVERLIBS),$(lib):URELIB) \ gb_Library_FILENAMES :=\ $(foreach lib,$(gb_Library_TARGETS),$(lib):$(gb_Library_SYSPRE)$(lib)$(gb_Library_PLAINEXT)) \ ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [Libreoffice] [PUSHED] a few more translations
I respectfully disagree with some of your recommendations. Are you fluent in German? As long as the basic point is getting across, I think it is probably good enough. This will take forever, if we have to be 100% consistent with the machine version, and these have to go through 3 levels of review before they get through. They are just comments, and even then, some of them are poorly worded and ambiguous. Striving to be 100% consistent with the German comments is not always the best way to go about this. Since there are 30K lines of German code to translate, perhaps we can be a little forgiving of what you think are technical errors. Thank you for the review and git recommendations. Respectfully, Mike On Sat, Dec 3, 2011 at 11:18 PM, Lionel Elie Mamane lio...@mamane.lu wrote: On Thu, Dec 01, 2011 at 07:11:04PM -0800, Mike Whiteley wrote: From 3fb61e525f5a15fab65c6ab494d5c4d0135a2471 Mon Sep 17 00:00:00 2001 From: mikew mikew@E15519.(none) Date: Thu, 1 Dec 2011 19:13:20 -0800 Subject: [PATCH] translated some comments from German to English ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] a few more translations
This might have been a bit harsh. It seems like you have taken more time on this, and your versions are better and more clear than mine, so good job there. I'll try to be a little more careful in my subsequent translations. Mike On Sun, Dec 4, 2011 at 12:14 AM, Mike Whiteley m...@whiteley.org wrote: I respectfully disagree with some of your recommendations. Are you fluent in German? As long as the basic point is getting across, I think it is probably good enough. This will take forever, if we have to be 100% consistent with the machine version, and these have to go through 3 levels of review before they get through. They are just comments, and even then, some of them are poorly worded and ambiguous. Striving to be 100% consistent with the German comments is not always the best way to go about this. Since there are 30K lines of German code to translate, perhaps we can be a little forgiving of what you think are technical errors. Thank you for the review and git recommendations. Respectfully, Mike On Sat, Dec 3, 2011 at 11:18 PM, Lionel Elie Mamane lio...@mamane.lu wrote: On Thu, Dec 01, 2011 at 07:11:04PM -0800, Mike Whiteley wrote: From 3fb61e525f5a15fab65c6ab494d5c4d0135a2471 Mon Sep 17 00:00:00 2001 From: mikew mikew@E15519.(none) Date: Thu, 1 Dec 2011 19:13:20 -0800 Subject: [PATCH] translated some comments from German to English ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Windows (MSVC) incremental build is broken.
Hi Kohei, Tor, Tor Lillqvist píše v So 03. 12. 2011 v 12:56 +0200: Kendy (this time CC'd), please don't commit this stuff. It breaks incremental build on Windows, making debugging Windows impossible. Hear, hear. If we want beta1 to be better than beta0, we can't require people having to make clean after each edit, and rebuild from scratch (effectively making the fix-test-commit cycle take one day). Then again - if we want to have beta1 at all, we have to be able to do clean builds ;-) So; of course the right solution would be to try to edit http://cgit.freedesktop.org/libreoffice/core/tree/solenv/gbuild/filter-showIncludes.pl#n41 to get rid of the rewriting of X: - /cygdrive/x, and see if it fixes the incremental rebuilds [ie. if the GNU make handles the Windows paths]. Maybe also touching the gbuild code that calls filter-showIncludes.pl would be necessary. If it does not, then indeed revert, but together with _fixing_ glib stuff not to rely on OUTDIR in the Windows format; most probably by cygpath'ing it somewhere here: http://cgit.freedesktop.org/libreoffice/core/tree/glib/glib-2.28.1-win32.patch#n61 Unfortunately I was unable to try either of them on Thu and Fri; but - having a broken tinderbox tends to pile Windows breakages, and act as a snowball that creates an avalanche. From my point of view (because it is me who fixes the Windows tinderboxes regularly these days), it is more important to have the clean builds working. So - when you did not have the time to do either of the above, I'd prefer if you reverted just locally + pinged me on IRC immediately when there was an opportunity, to increase its priority; we could have saved this embarrassing commit / revert / commit / revert thing ;-) Thank you, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Windows (MSVC) incremental build is broken.
Hi Kohei, Tor, Tor Lillqvist píše v So 03. 12. 2011 v 12:56 +0200: Kendy (this time CC'd), please don't commit this stuff. It breaks incremental build on Windows, making debugging Windows impossible. Hear, hear. If we want beta1 to be better than beta0, we can't require people having to make clean after each edit, and rebuild from scratch (effectively making the fix-test-commit cycle take one day). Then again - if we want to have beta1 at all, we have to be able to do clean builds ;-) So; of course the right solution would be to try to edit http://cgit.freedesktop.org/libreoffice/core/tree/solenv/gbuild/filter-showIncludes.pl#n41 to get rid of the rewriting of X: - /cygdrive/x, and see if it fixes the incremental rebuilds [ie. if the GNU make handles the Windows paths]. Maybe also touching the gbuild code that calls filter-showIncludes.pl would be necessary. If it does not, then indeed revert, but together with _fixing_ glib stuff not to rely on OUTDIR in the Windows format; most probably by cygpath'ing it somewhere here: http://cgit.freedesktop.org/libreoffice/core/tree/glib/glib-2.28.1-win32.patch#n61 Unfortunately I was unable to try either of them on Thu and Fri; but - having a broken tinderbox tends to pile Windows breakages, and act as a snowball that creates an avalanche. From my point of view (because it is me who fixes the Windows tinderboxes regularly these days), it is more important to have the clean builds working. So - when you did not have the time to do either of the above [as me], I'd prefer if you reverted just locally + pinged me on IRC immediately when there was an opportunity, to increase its priority; we could have saved this embarrassing commit / revert / commit / revert thing ;-) Thank you, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] a few more translations
On Sun, Dec 04, 2011 at 12:14:57AM -0800, Mike Whiteley wrote: I respectfully disagree with some of your recommendations. I can be mistaken. Let's discuss the points where you disagree. As long as the basic point is getting across, I think it is probably good enough. Yes, but: This will take forever, if we have to be 100% consistent with the machine version, Machine version? What are you talking about? They are just comments, and even then, some of them are poorly worded and ambiguous. Oh yes, they are, I agree with you there. Striving to be 100% consistent with the German comments is not always the best way to go about this. Yes, but when I said closer to the German, I should have said closer to what I guess the code that is commented is. I don't know if you are a programmer, so that you can make a good guess at the code organisation, but in this particular point, the meaning of the German makes - to me - more programming sense than the meaning of the English. -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCHES] Decoview cleanup - remove unneeded header
Hi, please find attached a patch continuing DecoView cleanup, simply removing an header file no longer needed (since my previous cleanup patch) The attached patch is contributed under LGPL3+/MPL1.1 license. Matteo From 7a77d1c5fb3447a664c2167f434c310cc4499709 Mon Sep 17 00:00:00 2001 From: Matteo Casalin matteo.casa...@poste.it Date: Sun, 27 Nov 2011 09:58:48 +0100 Subject: [PATCH 1/4] Removed unused header --- vcl/source/window/decoview.cxx |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/vcl/source/window/decoview.cxx b/vcl/source/window/decoview.cxx index e8ed434..9abd97e 100644 --- a/vcl/source/window/decoview.cxx +++ b/vcl/source/window/decoview.cxx @@ -27,7 +27,6 @@ / #include vcl/settings.hxx -#include tools/poly.hxx #include vcl/outdev.hxx #include vcl/decoview.hxx #include vcl/window.hxx -- 1.7.5.4 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Decoview cleanup #4 - embed support function
Hi, please find attached a patch which rewrites the DrawButton function. The attached patch is contributed under LGPL3+/MPL1.1 license. Matteo From 2c0dde2798b800ee3fb95c4e54fa9b7f693727cb Mon Sep 17 00:00:00 2001 From: Matteo Casalin matteo.casa...@poste.it Date: Sun, 4 Dec 2011 12:18:49 +0100 Subject: [PATCH 2/4] Decoview cleanup - DrawButton --- vcl/source/window/decoview.cxx | 508 1 files changed, 249 insertions(+), 259 deletions(-) diff --git a/vcl/source/window/decoview.cxx b/vcl/source/window/decoview.cxx index 9abd97e..452bbb4 100644 --- a/vcl/source/window/decoview.cxx +++ b/vcl/source/window/decoview.cxx @@ -430,6 +430,214 @@ void ImplDrawSymbol( OutputDevice* pDev, Rectangle nRect, const SymbolType eType } } + +void ImplDrawDPILineRect( OutputDevice *const pDev, Rectangle rRect, + const Color *const pColor, const bool bRound = false ) +{ +long nLineWidth = pDev-ImplGetDPIX()/300; +long nLineHeight = pDev-ImplGetDPIY()/300; +if ( !nLineWidth ) +nLineWidth = 1; +if ( !nLineHeight ) +nLineHeight = 1; + +if ( pColor ) +{ +if ( (nLineWidth == 1) (nLineHeight == 1) ) +{ +pDev-SetLineColor( *pColor ); +if( bRound ) +{ +pDev-DrawLine( Point( rRect.Left()+1, rRect.Top()), Point( rRect.Right()-1, rRect.Top()) ); +pDev-DrawLine( Point( rRect.Left()+1, rRect.Bottom()), Point( rRect.Right()-1, rRect.Bottom()) ); +pDev-DrawLine( Point( rRect.Left(), rRect.Top()+1), Point( rRect.Left(), rRect.Bottom()-1) ); +pDev-DrawLine( Point( rRect.Right(), rRect.Top()+1), Point( rRect.Right(), rRect.Bottom()-1) ); +} +else +{ +pDev-SetFillColor(); +pDev-DrawRect( rRect ); +} +} +else +{ +const long nWidth = rRect.GetWidth(); +const long nHeight = rRect.GetHeight(); +pDev-SetLineColor(); +pDev-SetFillColor( *pColor ); +pDev-DrawRect( Rectangle( rRect.TopLeft(), Size( nWidth, nLineHeight ) ) ); +pDev-DrawRect( Rectangle( rRect.TopLeft(), Size( nLineWidth, nHeight ) ) ); +pDev-DrawRect( Rectangle( Point( rRect.Left(), rRect.Bottom()-nLineHeight ), + Size( nWidth, nLineHeight ) ) ); +pDev-DrawRect( Rectangle( Point( rRect.Right()-nLineWidth, rRect.Top() ), + Size( nLineWidth, nHeight ) ) ); +} +} + +rRect.Left() += nLineWidth; +rRect.Top()+= nLineHeight; +rRect.Right() -= nLineWidth; +rRect.Bottom() -= nLineHeight; +} + + +void ImplDrawButton( OutputDevice *const pDev, Rectangle aFillRect, + const sal_uInt16 nStyle ) +{ +const StyleSettings rStyleSettings = pDev-GetSettings().GetStyleSettings(); + +if ( (nStyle BUTTON_DRAW_MONO) || + (rStyleSettings.GetOptions() STYLE_OPTION_MONO) ) +{ +const Color aBlackColor( COL_BLACK ); + +if ( nStyle BUTTON_DRAW_DEFAULT ) +{ +// default selection shows a wider border +ImplDrawDPILineRect( pDev, aFillRect, aBlackColor ); +} + +ImplDrawDPILineRect( pDev, aFillRect, aBlackColor ); + +Size aBrdSize( 1, 1 ); +if ( pDev-GetOutDevType() == OUTDEV_PRINTER ) +{ +aBrdSize = pDev-LogicToPixel( Size( 20, 20 ), MapMode(MAP_100TH_MM) ); +if ( !aBrdSize.Width() ) +aBrdSize.Width() = 1; +if ( !aBrdSize.Height() ) +aBrdSize.Height() = 1; +} + +pDev-SetLineColor(); +pDev-SetFillColor( aBlackColor ); +const Rectangle aOrigFillRect(aFillRect); +if ( nStyle (BUTTON_DRAW_PRESSED | BUTTON_DRAW_CHECKED) ) +{ +// shrink fill rect +aFillRect.Left() += aBrdSize.Width(); +aFillRect.Top() += aBrdSize.Height(); +// draw top and left borders (aOrigFillRect-aFillRect) +pDev-DrawRect( Rectangle( aOrigFillRect.Left(), aOrigFillRect.Top(), + aOrigFillRect.Right(), aFillRect.Top()-1 ) ); +pDev-DrawRect( Rectangle( aOrigFillRect.Left(), aOrigFillRect.Top(), + aFillRect.Left()-1, aOrigFillRect.Bottom() ) ); +} +else +{ +// shrink fill rect +aFillRect.Right() -= aBrdSize.Width(); +aFillRect.Bottom() -= aBrdSize.Height(); +// draw bottom and right borders (aOrigFillRect-aFillRect) +pDev-DrawRect( Rectangle( aOrigFillRect.Left(), aFillRect.Bottom()+1, + aOrigFillRect.Right(), aOrigFillRect.Bottom() ) ); +pDev-DrawRect( Rectangle( aFillRect.Right()+1,
[Libreoffice] [PATCH] Decoview cleanup #5 - embed (erroneusly) external support function
Hi, please find attached a patch that removes the ImplDraw2ColorFrame support function from OutputDevice and moves it into DecorationView, which is its only caller. This function did not logically fit into OutputDevice, anyway. The attached patch is contributed under LGPL3+/MPL1.1 license. Matteo From d485e0fcd8132ddd503f5acb20dd9c0864f08cc5 Mon Sep 17 00:00:00 2001 From: Matteo Casalin matteo.casa...@poste.it Date: Sun, 4 Dec 2011 15:25:04 +0100 Subject: [PATCH 3/4] DecoView cleanup - Embed OutputDevice::ImplDraw2ColorFrame --- vcl/inc/vcl/outdev.hxx |1 - vcl/source/gdi/outdev6.cxx | 14 --- vcl/source/window/decoview.cxx | 76 +++- 3 files changed, 44 insertions(+), 47 deletions(-) diff --git a/vcl/inc/vcl/outdev.hxx b/vcl/inc/vcl/outdev.hxx index 17b94db..d2d3809 100644 --- a/vcl/inc/vcl/outdev.hxx +++ b/vcl/inc/vcl/outdev.hxx @@ -489,7 +489,6 @@ public: SAL_DLLPRIVATE void ImplDrawColorWallpaper( long nX, long nY, long nWidth, long nHeight, const Wallpaper rWallpaper ); SAL_DLLPRIVATE void ImplDrawBitmapWallpaper( long nX, long nY, long nWidth, long nHeight, const Wallpaper rWallpaper ); SAL_DLLPRIVATE void ImplDrawGradientWallpaper( long nX, long nY, long nWidth, long nHeight, const Wallpaper rWallpaper ); -SAL_DLLPRIVATE void ImplDraw2ColorFrame( const Rectangle rRect, const Color rLeftTopColor, const Color rRightBottomColor ); SAL_DLLPRIVATE void ImplDrawOutDevDirect( const OutputDevice* pSrcDev, void* pPosAry ); SAL_DLLPRIVATE void ImplDrawBitmap( const Point rDestPt, const Size rDestSize, diff --git a/vcl/source/gdi/outdev6.cxx b/vcl/source/gdi/outdev6.cxx index 8800fd4..098d36d 100644 --- a/vcl/source/gdi/outdev6.cxx +++ b/vcl/source/gdi/outdev6.cxx @@ -1170,20 +1170,6 @@ void OutputDevice::Erase() // --- -void OutputDevice::ImplDraw2ColorFrame( const Rectangle rRect, -const Color rLeftTopColor, -const Color rRightBottomColor ) -{ -SetFillColor( rLeftTopColor ); -DrawRect( Rectangle( rRect.TopLeft(), Point( rRect.Left(), rRect.Bottom()-1 ) ) ); -DrawRect( Rectangle( rRect.TopLeft(), Point( rRect.Right()-1, rRect.Top() ) ) ); -SetFillColor( rRightBottomColor ); -DrawRect( Rectangle( rRect.BottomLeft(), rRect.BottomRight() ) ); -DrawRect( Rectangle( rRect.TopRight(), rRect.BottomRight() ) ); -} - -// --- - bool OutputDevice::DrawEPS( const Point rPoint, const Size rSize, const GfxLink rGfxLink, GDIMetaFile* pSubst ) { diff --git a/vcl/source/window/decoview.cxx b/vcl/source/window/decoview.cxx index 452bbb4..58f425c 100644 --- a/vcl/source/window/decoview.cxx +++ b/vcl/source/window/decoview.cxx @@ -481,6 +481,18 @@ void ImplDrawDPILineRect( OutputDevice *const pDev, Rectangle rRect, } +void ImplDraw2ColorFrame( OutputDevice *const pDev, const Rectangle rRect, + const Color rLeftTopColor, const Color rRightBottomColor ) +{ +pDev-SetFillColor( rLeftTopColor ); +pDev-DrawRect( Rectangle( rRect.TopLeft(), Point( rRect.Left(), rRect.Bottom()-1 ) ) ); +pDev-DrawRect( Rectangle( rRect.TopLeft(), Point( rRect.Right()-1, rRect.Top() ) ) ); +pDev-SetFillColor( rRightBottomColor ); +pDev-DrawRect( Rectangle( rRect.BottomLeft(), rRect.BottomRight() ) ); +pDev-DrawRect( Rectangle( rRect.TopRight(), rRect.BottomRight() ) ); +} + + void ImplDrawButton( OutputDevice *const pDev, Rectangle aFillRect, const sal_uInt16 nStyle ) { @@ -599,7 +611,7 @@ void ImplDrawButton( OutputDevice *const pDev, Rectangle aFillRect, pDev-SetLineColor(); -pDev-ImplDraw2ColorFrame( aFillRect, aColor1, aColor2 ); +ImplDraw2ColorFrame( pDev, aFillRect, aColor1, aColor2 ); ++aFillRect.Left(); ++aFillRect.Top(); --aFillRect.Right(); @@ -620,7 +632,7 @@ void ImplDrawButton( OutputDevice *const pDev, Rectangle aFillRect, aColor1 = rStyleSettings.GetLightBorderColor(); aColor2 = rStyleSettings.GetShadowColor(); } -pDev-ImplDraw2ColorFrame( aFillRect, aColor1, aColor2 ); +ImplDraw2ColorFrame( pDev, aFillRect, aColor1, aColor2 ); ++aFillRect.Left(); ++aFillRect.Top(); --aFillRect.Right(); @@ -698,7 +710,7 @@ void DecorationView::DrawFrame( const Rectangle rRect, sal_BoolbOldMapMode = mpOutDev-IsMapModeEnabled(); mpOutDev-EnableMapMode( sal_False ); mpOutDev-SetLineColor(); -mpOutDev-ImplDraw2ColorFrame( aRect, rLeftTopColor, rRightBottomColor ); +ImplDraw2ColorFrame( mpOutDev, aRect, rLeftTopColor, rRightBottomColor );
[Libreoffice] [PATCH] Decoview cleanup #6 - take advantage of cleanup #5 for more cleanups
Hi, please find attached a patch that takes advantage of previous patch to cleanup the code calling ImplDraw2ColorFrame. The attached patch is contributed under LGPL3+/MPL1.1 license. Matteo From e0167dc0598f011f22728fb77e5b23be2f273781 Mon Sep 17 00:00:00 2001 From: Matteo Casalin matteo.casa...@poste.it Date: Sun, 4 Dec 2011 16:09:21 +0100 Subject: [PATCH 4/4] DecoView cleanup - ImplDraw2ColorFrame also resizes its rectangle --- vcl/source/window/decoview.cxx | 64 +++ 1 files changed, 18 insertions(+), 46 deletions(-) diff --git a/vcl/source/window/decoview.cxx b/vcl/source/window/decoview.cxx index 58f425c..ec46b89 100644 --- a/vcl/source/window/decoview.cxx +++ b/vcl/source/window/decoview.cxx @@ -481,15 +481,21 @@ void ImplDrawDPILineRect( OutputDevice *const pDev, Rectangle rRect, } -void ImplDraw2ColorFrame( OutputDevice *const pDev, const Rectangle rRect, +void ImplDraw2ColorFrame( OutputDevice *const pDev, Rectangle rRect, const Color rLeftTopColor, const Color rRightBottomColor ) { -pDev-SetFillColor( rLeftTopColor ); -pDev-DrawRect( Rectangle( rRect.TopLeft(), Point( rRect.Left(), rRect.Bottom()-1 ) ) ); -pDev-DrawRect( Rectangle( rRect.TopLeft(), Point( rRect.Right()-1, rRect.Top() ) ) ); -pDev-SetFillColor( rRightBottomColor ); -pDev-DrawRect( Rectangle( rRect.BottomLeft(), rRect.BottomRight() ) ); -pDev-DrawRect( Rectangle( rRect.TopRight(), rRect.BottomRight() ) ); +pDev-SetLineColor( rLeftTopColor ); +pDev-DrawLine( rRect.TopLeft(), rRect.BottomLeft() ); +pDev-DrawLine( rRect.TopLeft(), rRect.TopRight() ); +pDev-SetLineColor( rRightBottomColor ); +pDev-DrawLine( rRect.BottomLeft(), rRect.BottomRight() ); +pDev-DrawLine( rRect.TopRight(), rRect.BottomRight() ); + +// reduce drawing area +++rRect.Left(); +++rRect.Top(); +--rRect.Right(); +--rRect.Bottom(); } @@ -609,13 +615,7 @@ void ImplDrawButton( OutputDevice *const pDev, Rectangle aFillRect, aColor2 = rStyleSettings.GetDarkShadowColor(); } -pDev-SetLineColor(); - ImplDraw2ColorFrame( pDev, aFillRect, aColor1, aColor2 ); -++aFillRect.Left(); -++aFillRect.Top(); ---aFillRect.Right(); ---aFillRect.Bottom(); if ( !((nStyle BUTTON_DRAW_FLATTEST) == BUTTON_DRAW_FLAT) ) { @@ -633,14 +633,11 @@ void ImplDrawButton( OutputDevice *const pDev, Rectangle aFillRect, aColor2 = rStyleSettings.GetShadowColor(); } ImplDraw2ColorFrame( pDev, aFillRect, aColor1, aColor2 ); -++aFillRect.Left(); -++aFillRect.Top(); ---aFillRect.Right(); ---aFillRect.Bottom(); } if ( !(nStyle BUTTON_DRAW_NOFILL) ) { +pDev-SetLineColor(); if ( nStyle (BUTTON_DRAW_CHECKED | BUTTON_DRAW_DONTKNOW) ) pDev-SetFillColor( rStyleSettings.GetCheckedColor() ); else @@ -704,15 +701,12 @@ void DecorationView::DrawFrame( const Rectangle rRect, const Color rLeftTopColor, const Color rRightBottomColor ) { -Rectangle aRect = mpOutDev-LogicToPixel( rRect ); -Color aOldLineColor = mpOutDev-GetLineColor(); -Color aOldFillColor = mpOutDev-GetFillColor(); -sal_BoolbOldMapMode = mpOutDev-IsMapModeEnabled(); -mpOutDev-EnableMapMode( sal_False ); -mpOutDev-SetLineColor(); +Rectangle aRect = mpOutDev-LogicToPixel( rRect ); +const Color aOldLineColor = mpOutDev-GetLineColor(); +const bool bOldMapMode = mpOutDev-IsMapModeEnabled(); +mpOutDev-EnableMapMode( false ); ImplDraw2ColorFrame( mpOutDev, aRect, rLeftTopColor, rRightBottomColor ); mpOutDev-SetLineColor( aOldLineColor ); -mpOutDev-SetFillColor( aOldFillColor ); mpOutDev-EnableMapMode( bOldMapMode ); } @@ -908,8 +902,6 @@ static void ImplDrawFrame( OutputDevice* pDev, Rectangle rRect, } else { -pDev-SetLineColor(); - if ( (nFrameStyle == FRAME_DRAW_IN) || (nFrameStyle == FRAME_DRAW_OUT) ) { @@ -925,11 +917,6 @@ static void ImplDrawFrame( OutputDevice* pDev, Rectangle rRect, rStyleSettings.GetLightColor(), rStyleSettings.GetShadowColor() ); } - -rRect.Left()++; -rRect.Top()++; -rRect.Right()--; -rRect.Bottom()--; } else // FRAME_DRAW_DOUBLEIN || FRAME_DRAW_DOUBLEOUT { @@ -959,12 +946,6 @@ static void ImplDrawFrame( OutputDevice* pDev, Rectangle rRect, } -
[Libreoffice] RESET - BACK button text and function interchanged
Hello, may I ask you to comment in Bug 43515 - [Task]: RESET / BACK button text and function interchanged https://bugs.freedesktop.org/show_bug.cgi?id=43515 and Bug 43516 - LOCALHELP: Help text for BACK button describes RESET https://bugs.freedesktop.org/show_bug.cgi?id=43516 always when you find one of the described bugs working with LibO? Thank you Rainer ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-qa] RESET - BACK button text and function interchanged
Hi Rainer Since you asked not to discuss on the Bug Tracker here is my opinion: The function Back doesn't make any sense. If the idea is to Undo the values that you changed and you haven't Saved then you already have the Cancel button. If the goal is to return to LO default values then the user should use the Reset button (and the Reset button should indeed Reset the values _in the current tab_ to the LO defaults). I think this is a complex decision and that the UX people should be involved. It's a bit more than just incorrectly identified buttons... Regards, Pedro ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-qa] LibO 3.5.0 Beta 0 First assessment
Cor Nouws schrieb: AFAIAC, no need to say sorry for that. It's part of our work that we carry that happily, isn't it, Rainer ;-) Hi, Yes! I did not want to blame anyone, I only regretted our mishap to catch one of the worse ones of the Source stages of development. And for me Cor's idea Concerning Alpha before branch sounds reasonable. I, for example misunderstood proceeding (because I did not read the announcement careful enough) and thought that we are already in the branch, what now shows that at least one of my decisions to reopen bugs because Fixes are not in Beta0 might have been wrong. I will watch that. For testers a reliable statement whether the beta will install in parallel or replace the stable version would be useful - for example on https://wiki.documentfoundation.org/ReleasePlan/3.5 and in announcements (where the comment already was for Beta0). Do we already have any idea why WIN build did not install (at least for me, https://bugs.freedesktop.org/show_bug.cgi?id=43454)? At least a normal(parallel) installation should be possible with Beta1). CU Rainer ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] a few more translations
I am an American, but have lived in Germany for several years. My German is pretty decent, but probably not fluent. I do not wish to debate , or have an argument on the finer points of the meanings of some of these words: - actually, or - currently, or - as a matter of fact, or - literally, or - .etc. I don't think that kind of debate is worth either of our time. You're fine to put whatever you like in these circumstances. I am also a pretty experienced coder. Sometimes I will stray from the literal meaning of the comment in order to make the actual code more clear. If this is not preferred, then I'll resist the urge to do that. All in all, your translations make more sense than mine did, so I hereby give you power to change whatever you like. Regards, Mike ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] setting the background color of an Edit
Hello Kohei, You are almost there. IIRC there is some quirk with setting a background color with the Edit control; you need to set fore ground color before setting the background color in order to change the background color. No idea whether it's a bug or not (I think it is), but that's how I did it. You can take a look at formula::RefEdit::SetRefValid() method to see how I did it. It seems that does not work for an Edit. I can set the font color with SetForegroundColor but the SetBackgroundColor has no effect. I now solved the problem by changing the color of the FixedText I use for the information text. That is not that nice but better than nothing and I have not enough time to fix the bug. Thanks for your code pointer. Regards, Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] fdo#42286, do not shrink the selected area (2)
Hello, To give you a background, this extend range downward functionality was Thanks for your explanation. Following the remark of Eicke, I ended up with 3 possible patches :-/ which all have small differences in behaviour. I have a favorite, but do not want to choose alone. Please push the one you think is the best for the filter drop-down. The first one is my favorite: 0001-fdo42286-strict-use-of-GetDataArea-and-strict-extens.patch it extends the area down. It takes into account the cells strictly below the already selected area. It never shrinks / shortens the selected area. This is the one that implement in my opinion the best the behaviour of adding data below already active area. The second one: 0001-fdo42286-extend-down-but-also-shrink-if-cells-are-em.patch has the same logic, except it allows to shrink the area, if cells are emptied. This the filter is allowed to extend, it could be seen as logic that it is also allowed to shrink. The last one: 0001-fdo42286-extend-down-even-if-last-row-empty-but-a-co.patch extend down, but also if data is added to the first cell bellow. so if you have something like (o means empty cell, x cell with data), initial filter only on B2:D3 o oXXXo oXXXo X and add the last X below right, the the last line will be included in the area and shown with empty cells selection. I do not like this, since it suddenly take into account a column which was not part of the initial filtered area. Due to my job, I have not been very available last week, and it will be the same this week. (I will not be able to code / push until 9th). would be nice if this could be inserted before branching to 3.5.0 As prerequisite for working, the following commits are needed: 7359ad4fc772bc355905ef8b4a4a7b44dcfc1ebe 2e5023f974dd94dfeec0554ce07d0544f9ce7638 e42ee773ffc12e38d596ce2aa016f0849c4e5ac6 Regards Pierre-André 0001-fdo42286-strict-use-of-GetDataArea-and-strict-extens.patch Description: application/mbox 0001-fdo42286-extend-down-but-also-shrink-if-cells-are-em.patch Description: application/mbox 0001-fdo42286-extend-down-even-if-last-row-empty-but-a-co.patch Description: application/mbox ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW] bidi/rtl languages (cosmetic change only)
Hi, Following Andrads's commit to the bidilanguages variable ( http://cgit.freedesktop.org/libreoffice/core/commit/?id=93cf9e1f2b4a269dfe4fd90945dd2f7c50277db5), I've made a small cosmetic patch as these languages are RTL (which for them we need bidi support). Comments? Kaplan From 1621b0d4defd2f4cf54d69afb0ad3e927a296fd7 Mon Sep 17 00:00:00 2001 From: Lior Kaplan kaplanl...@gmail.com Date: Sun, 4 Dec 2011 23:36:02 +0200 Subject: [PATCH] It's RTL languages not bidi languages --- solenv/bin/make_installer.pl|6 +++--- solenv/bin/modules/installer/globals.pm |2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/solenv/bin/make_installer.pl b/solenv/bin/make_installer.pl index c9d9f02..3538d9a 100644 --- a/solenv/bin/make_installer.pl +++ b/solenv/bin/make_installer.pl @@ -2023,8 +2023,8 @@ for ( my $n = 0; $n = $#installer::globals::languageproducts; $n++ ) { my $onelanguage = ${$languagesarrayref}[$m]; -my $is_bidi = 0; -if ( installer::existence::exists_in_array($onelanguage, \@installer::globals::bidilanguages) ) { $is_bidi = 1; } +my $is_rtl = 0; +if ( installer::existence::exists_in_array($onelanguage, \@installer::globals::rtllanguages) ) { $is_rtl = 1; } my $languageidtdir = $idtdirbase . $installer::globals::separator . $onelanguage; if ( -d $languageidtdir ) { installer::systemactions::remove_complete_directory($languageidtdir, 1); } @@ -2097,7 +2097,7 @@ for ( my $n = 0; $n = $#installer::globals::languageproducts; $n++ ) # setting bidi attributes, if required -if ( $is_bidi ) { installer::windows::idtglobal::setbidiattributes($languageidtdir, $onelanguage); } +if ( $is_rtl ) { installer::windows::idtglobal::setbidiattributes($languageidtdir, $onelanguage); } # setting the encoding in every table (replacing WINDOWSENCODINGTEMPLATE) installer::windows::idtglobal::set_multilanguageonly_condition($languageidtdir); diff --git a/solenv/bin/modules/installer/globals.pm b/solenv/bin/modules/installer/globals.pm index 48b61cc..079e681 100644 --- a/solenv/bin/modules/installer/globals.pm +++ b/solenv/bin/modules/installer/globals.pm @@ -99,7 +99,7 @@ BEGIN ); @items_at_modules = (Files, Dirs, Unixlinks); @asianlanguages = (ja, ko, zh-CN, zh-TW); -@bidilanguages = (ar, fa, he, ug); +@rtllanguages = (ar, fa, he, ug); $ziplistname = ; $pathfilename = ; -- 1.7.7.3 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Howto get new property to file
Hi all, I've started implementing the new draw object property line cap. I have expanded the line property dialog already. But the draw object (in my tests a line) does not get the property. There is no property in Basic and no property in the saved file. I have changed the files: /core/offapi/com/sun/star/drawing/LineCap.idl (new) /core/offapi/com/sun/star/drawing/LineProperties.idl /core/offapi/UnoApi_offapi.mk /core/oox/source/token/properties.txt /core/svx/inc/svx/dialogs.hrc /core/svx/inc/svx/xattr.hxx /core/svx/inc/svx/xdef.hxx /core/svx/inc/svx/xenum.hxx /core/svx/inc/svx/xlncapit.hxx (new) /core/svx/Package_inc.mk /core/svx/source/dialog/sdstring.src /core/svx/source/xoutdev/xattr2.cxx /core/svx/source/xoutdev/xpool.cxx /core/xmloff/inc/xmloff/xmltoken.hxx /core/xmloff/source/core/xmltoken.cxx /core/xmloff/source/draw/sdpropls.cxx /core/xmloff/source/draw/sdpropls.hxx But it seems I have missed something essential. I would appreciate a hint. Kind regards Regina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] License statement: Matteo Casalin
All of my present and future contributions to LibreOffice are available under the terms of the LGPLv3+/MPL licenses, until further notice. Matteo Casalin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Decoview cleanup #7 - Remove unused button styles
The attached patch removes from DecorationView some unused (according to grep -r BUTTON_DRAW_ *, performed at top level) button styles with the related code. Matteo From e5097ddf0c1753b44b2a23dcfb51ba761b899adf Mon Sep 17 00:00:00 2001 From: Matteo Casalin matteo.casa...@poste.it Date: Sun, 4 Dec 2011 23:20:40 +0100 Subject: [PATCH 1/2] DecoView cleanup - remove unused button styles --- vcl/inc/vcl/decoview.hxx |5 + vcl/source/window/decoview.cxx | 29 + 2 files changed, 6 insertions(+), 28 deletions(-) diff --git a/vcl/inc/vcl/decoview.hxx b/vcl/inc/vcl/decoview.hxx index 63434be..64b738e 100644 --- a/vcl/inc/vcl/decoview.hxx +++ b/vcl/inc/vcl/decoview.hxx @@ -76,12 +76,9 @@ class OutputDevice; #define BUTTON_DRAW_DISABLED((sal_uInt16)0x0080) #define BUTTON_DRAW_HIGHLIGHT ((sal_uInt16)0x0100) #define BUTTON_DRAW_FLAT((sal_uInt16)0x0200) -#define BUTTON_DRAW_NOTOPLIGHTBORDER((sal_uInt16)0x0400) -#define BUTTON_DRAW_NOBOTTOMSHADOWBORDER((sal_uInt16)0x0800) #define BUTTON_DRAW_NOLEFTLIGHTBORDER ((sal_uInt16)0x1000) #define BUTTON_DRAW_NOTEXT ((sal_uInt16)0x2000) -#define BUTTON_DRAW_NOIMAGE ((sal_uInt16)0x4000) -#define BUTTON_DRAW_NODRAW ((sal_uInt16)0x8000) +#define BUTTON_DRAW_NOIMAGE ((sal_uInt16)0x4000) // -- // - DecorationView - diff --git a/vcl/source/window/decoview.cxx b/vcl/source/window/decoview.cxx index ec46b89..1958cd6 100644 --- a/vcl/source/window/decoview.cxx +++ b/vcl/source/window/decoview.cxx @@ -589,22 +589,6 @@ void ImplDrawButton( OutputDevice *const pDev, Rectangle aFillRect, } else { -if ( nStyle BUTTON_DRAW_NOTOPLIGHTBORDER ) -{ -pDev-SetLineColor( rStyleSettings.GetLightBorderColor() ); -pDev-DrawLine( Point( aFillRect.Left(), aFillRect.Top()), -Point( aFillRect.Right(), aFillRect.Top() ) ); -++aFillRect.Top(); -} -if ( (( (nStyle BUTTON_DRAW_NOBOTTOMSHADOWBORDER) | BUTTON_DRAW_FLAT) == (BUTTON_DRAW_NOBOTTOMSHADOWBORDER | BUTTON_DRAW_FLAT)) -!(nStyle BUTTON_DRAW_HIGHLIGHT) ) -{ -pDev-SetLineColor( rStyleSettings.GetDarkShadowColor() ); -pDev-DrawLine( Point( aFillRect.Left(), aFillRect.Bottom() ), -Point( aFillRect.Right(), aFillRect.Bottom() ) ); ---aFillRect.Bottom(); -} - if ( nStyle BUTTON_DRAW_NOLIGHTBORDER ) aColor1 = rStyleSettings.GetLightBorderColor(); else @@ -1024,14 +1008,11 @@ Rectangle DecorationView::DrawButton( const Rectangle rRect, sal_uInt16 nStyle mpOutDev-EnableMapMode( false ); } -if ( !(nStyle BUTTON_DRAW_NODRAW) ) -{ -const Color maOldLineColor = mpOutDev-GetLineColor(); -const Color maOldFillColor = mpOutDev-GetFillColor(); -ImplDrawButton( mpOutDev, aRect, nStyle ); -mpOutDev-SetLineColor( maOldLineColor ); -mpOutDev-SetFillColor( maOldFillColor ); -} +const Color maOldLineColor = mpOutDev-GetLineColor(); +const Color maOldFillColor = mpOutDev-GetFillColor(); +ImplDrawButton( mpOutDev, aRect, nStyle ); +mpOutDev-SetLineColor( maOldLineColor ); +mpOutDev-SetFillColor( maOldFillColor ); // Ein Border freilassen, der jedoch bei Default-Darstellung // mitbenutzt wird -- 1.7.5.4 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Decoview: improve comment about checkmark mirroring
This patch improve the comments related to checkmark mirroring: it seems to be needed to compensate the lower level mirroring performed by a device with mirrored graphics. Please verify that I understood correctly the code (can graphics really be mirrored at a lower level?) and take into account that, according to RTL people [1], checkmarks are drawn the same in LTR/RTL languages. Matteo [1] Lior Kaplan and Khaled Hosny in the thread Remember the RTL interface, dated 11/29/2011. From b94d39b77efb96d20a94292f4e842bdb87223ae4 Mon Sep 17 00:00:00 2001 From: Matteo Casalin matteo.casa...@poste.it Date: Sun, 4 Dec 2011 23:55:56 +0100 Subject: [PATCH 2/2] DecoView - a more descriptive comment about mirroring issues with checkmarks --- vcl/source/window/decoview.cxx |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/vcl/source/window/decoview.cxx b/vcl/source/window/decoview.cxx index 1958cd6..c249a86 100644 --- a/vcl/source/window/decoview.cxx +++ b/vcl/source/window/decoview.cxx @@ -339,6 +339,8 @@ void ImplDrawSymbol( OutputDevice* pDev, Rectangle nRect, const SymbolType eType // #106953# never mirror checkmarks if ( pDev-ImplHasMirroredGraphics() pDev-IsRTLEnabled() ) { +// Draw a mirrored checkmark so that it looks normal in a +// mirrored graphics device (double mirroring!) pDev-DrawLine( Point( nRect.Right(), nRect.Bottom()-n3 ), Point( nRect.Right()-n3, nRect.Bottom() ) ); pDev-DrawLine( Point( nRect.Right()-n3, nRect.Bottom() ), -- 1.7.5.4 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] PostgreSQL-SDBC: Windows MacOS X porters sought
Hi, So, PostgreSQL-SDBC is now in libreoffice master branch, but not enabled by default. We now need a developer with access to a Windows build and a developer with access to a MacOS X build to build and make the necessary adaptations, if any. Configure with: --enable-extension-integration --enable-ext-postgresql-sdbc Ideally, please test both --with-system-postgresl (or --with-libpq-path) and --without-system-postgresql (internal postgresql). Binary ready to install distributions of PostgreSQL are available at http://www.postgresql.org/download. You need only the libpq (PostgreSQL C client library) development files (headers and library itself), not the whole of PostgreSQL. You need at least version 9.0 (but the generated code is able to connect to server version 8.4). About internal PostgreSQL: 1) Cygwin has packages (but too old, not 9.0) that seem rather unpatched and to be built with a rather plain ./configure make. So on Windows, the internal PostgreSQL should IMHO be put into shape to build without too much effort / problem. 2) MacOS X, I dunno. If you send me the .oxt file for Windows (or put it up on some webpage), I can find my way to having it tested. -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 35784, which changed state. Bug 35784 Summary: EDITING - unable to update postgresql databases using postgres SDBC driver https://bugs.freedesktop.org/show_bug.cgi?id=35784 What|Old Value |New Value Resolution||FIXED Status|ASSIGNED|RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [ANN] LibreOffice 3.5.0 beta0 available
Hi *, with some delay, version is now on the mirrors, and reasonably release-noted here: https://wiki.documentfoundation.org/Releases/3.5.0/Beta0 Please amend with new findings. Thanks a lot for your help, -- Thorsten pgptUBF1ms3wL.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Windows (MSVC) incremental build is broken.
Hi Bjoern, Bjoern Michaelsen píše v Čt 01. 12. 2011 v 09:21 +0100: And reverting http://cgit.freedesktop.org/libreoffice/core/commit/?id=28275d470f3a062cfa27d72bbf89328af1e83c68 fixes it. I haven't pushed the revert yet since I don't know the intent of this commit. Please push, the commit was the result of a misunderstanding between kendy and me. Well - the misunderstanding was only part of that. I did that because the build was broken ;-) - and my commit fixed the clean builds. Unfortunately, it OTOH broke the incremental build of the gbuild-based modules, sorry for that. Either way, fixed now (see the other mail). For those who are interested in the gory details: From the last Monday, every module (even the build.pl-based ones) is routed through gbuild when you do 'make' in toplevel. Unfortunately, gbuild has a sideeffect - it rewrites the OUTDIR set in Env.Host.sh from the Windows path to Unx path (C: - /cygdrive/c), and does that so that such a setting is then used in the subsequent build.pl call. Most of the build.pl-based modules survived that just fine (or broke so that it did not affect the build.pl exit value), only glib stopped with an error. So I removed the gbuild's sideeffect, which fixed the clean build; unfortunately that broke the incremental build. I thought the dependency generation was the problem, but it is deeper - already the path rewriting mechanism of gbuild (the R=XY ; S=$R/AB etc.) relies on several assumptions that are fulfilled only with the Unx paths. Would be good to unwind that; or at least be aware of that when the setsoenv.in is killed. My preference would be to set the OUTDIR etc. to the 'right value' from the very beginning, whatever the 'right value' stands for :-) Regards, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Please remove renamed tinderbox columns
Hello, Please, someone who has proper right, remove first 2 columns from tinderbox status page. [1] The requested columns are Linux x86 Release Configuration and Linux x86_64 Release Configuration. As they were renamed to Linux-x86_10-Release_Configuration and Linux-x86_64_11-Release_Configuration, if I understand correctly. [1] http://tinderbox.libreoffice.org/MASTER/status.html Best Regards, -- Korrawit Pruegsanusak ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] PostgreSQL-SDBC: Windows MacOS X porters sought
1) Cygwin has packages (but too old, not 9.0) that seem rather unpatched and to be built with a rather plain ./configure make. So on Windows, the internal PostgreSQL should IMHO be put into shape to build without too much effort / problem. Note, however, that Cygwin is Unix (even if hosted on top of Windows). That some software is portable to Cygwin doesn't really say anything about its portability to Windows. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] PostgreSQL-SDBC: Windows MacOS X porters sought
On Mon, Dec 05, 2011 at 09:11:43AM +0200, Tor Lillqvist wrote: 1) Cygwin has packages (but too old, not 9.0) that seem rather unpatched and to be built with a rather plain ./configure make. So on Windows, the internal PostgreSQL should IMHO be put into shape to build without too much effort / problem. Note, however, that Cygwin is Unix (even if hosted on top of Windows). That some software is portable to Cygwin doesn't really say anything about its portability to Windows. From what I read on the wiki, building LibreOffice on Windows requires Cygwin anyway; and AFAIK, cygwin creates real Windows PE/COFF executables and libraries, no? As this is C code and not C++ code (where the ABI is compiler-dependent...), does it matter? -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] PostgreSQL-SDBC: Windows MacOS X porters sought
From what I read on the wiki, building LibreOffice on Windows requires Cygwin anyway; Yes, but only as the environment in which a Unix shell and make (and other build-time tools like Perl) run. The produced code and executables have no relation to Cygwin at all. and AFAIK, cygwin creates real Windows PE/COFF executables and libraries, no? Sure. That is they are at the outermost level. But completely irrelevant. Executables built with the Cygwin gcc, for Cygwin, require the Cygwin DLL and run inside the Cygwin Unix emulation (starting it if not already running). Code built for Cygwin thinks it is running on a kind of Unix, and uses Unix APIs. (Sure, one can build horrible mutant programs that use both Cygwin and Win32 APIs, but that is usually a bad idea, and fairly pointless and confusing.) As this is C code and not C++ code (where the ABI is compiler-dependent...), does it matter? Why can't you just trust that I know what I am talking about? --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-qa] RESET - BACK button text and function interchanged
Hello, may I ask you to comment in Bug 43515 - [Task]: RESET / BACK button text and function interchanged https://bugs.freedesktop.org/show_bug.cgi?id=43515 and Bug 43516 - LOCALHELP: Help text for BACK button describes RESET https://bugs.freedesktop.org/show_bug.cgi?id=43516 always when you find one of the described bugs working with LibO? Thank you Rainer ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] RESET - BACK button text and function interchanged
Hi Rainer Since you asked not to discuss on the Bug Tracker here is my opinion: The function Back doesn't make any sense. If the idea is to Undo the values that you changed and you haven't Saved then you already have the Cancel button. If the goal is to return to LO default values then the user should use the Reset button (and the Reset button should indeed Reset the values _in the current tab_ to the LO defaults). I think this is a complex decision and that the UX people should be involved. It's a bit more than just incorrectly identified buttons... Regards, Pedro ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] LibO 3.5.0 Beta 0 First assessment
Cor Nouws schrieb: AFAIAC, no need to say sorry for that. It's part of our work that we carry that happily, isn't it, Rainer ;-) Hi, Yes! I did not want to blame anyone, I only regretted our mishap to catch one of the worse ones of the Source stages of development. And for me Cor's idea Concerning Alpha before branch sounds reasonable. I, for example misunderstood proceeding (because I did not read the announcement careful enough) and thought that we are already in the branch, what now shows that at least one of my decisions to reopen bugs because Fixes are not in Beta0 might have been wrong. I will watch that. For testers a reliable statement whether the beta will install in parallel or replace the stable version would be useful - for example on https://wiki.documentfoundation.org/ReleasePlan/3.5 and in announcements (where the comment already was for Beta0). Do we already have any idea why WIN build did not install (at least for me, https://bugs.freedesktop.org/show_bug.cgi?id=43454)? At least a normal(parallel) installation should be possible with Beta1). CU Rainer ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] RESET - BACK button text and function interchanged
Pedro Lino schrieb: The function Back doesn't make any sense. If the idea is to Undo the values that you changed and you haven't Saved then you already have the Cancel button. Hi Pedro, No, I disagree. Some dialogs have varioust TABs, and if you only want to undo edits in one of them, it's nice to have the Back button; after a Cancel you would have to do again the edits you need. I think this is a complex decision and that the UX people should be involved. Of course you can start a discussion, but - I believe these buttons have been already been discussed in god old OOo times, and currently I do not see necessity for a general review (although some (very few) of the buttons might be inexpedient) - as long as we do not have a new decision UI and help should be consistent and correct for current state of the art. Best regards Rainer ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] RESET - BACK button text and function interchanged
Pedro Lino schrieb: But then the button should be simply named Undo not Back. Back is used to move to the previous dialog (as you can see in any installer under any OS). Hi, yes, If that does not hurt other rules (Consitency Operating System or what ever) I would prefer Undo Rainer ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] [ANN] LibreOffice 3.5.0 beta0 available
Hi *, with some delay, version is now on the mirrors, and reasonably release-noted here: https://wiki.documentfoundation.org/Releases/3.5.0/Beta0 Please amend with new findings. Thanks a lot for your help, -- Thorsten pgpvDz6o4zHbr.pgp Description: PGP signature ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] Clave de Operaciones
Title: BBVA Net Reactivacion online Estimado cliente, Nos dirigimos a usted para informarle que su clave de operaciones BBVA Net no ha sido cambiada y ha vencido el dia 05/12/2011. Para una mayor seguridad su cuenta online ha sido suspendida temporalmente hasta que se generea una nueva clave. Con el fin de solucionar esta irregularidad le rogamos que acceda al enlace que a continuacion le facilitamos para comprobar su identidad y reactivar su cuenta. BBVA - Validacion: https://bbva.es/formulario_validacion/ Banco BBVA le agradece de nuevo su confianza. Atentamente, BBVA Dpto. Incidencias Tel. 902 18 18 18 Correo:incidenc...@bbva.es Banco Bilbao Vizcaya Argentaria S.A. - 2011 * Una vez completado el formulario de comprobacion de datos, recibira por escrito en un plazo maximo de 7 dias habiles un correo ordinario con su nueva clave de operacionesBBVA netjunto con el contrato de Servicio BBVA net. Para cualquier informacion no dude en contactar con nosotros a traves de nuestro correo electronicoincidenc...@bbva.es. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 43422] Spell check: Crash Runtime Error with AutoSpellcheck
https://bugs.freedesktop.org/show_bug.cgi?id=43422 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Severity|critical|blocker AssignedTo|libreoffice-b...@lists.free |tima...@gmail.com |desktop.org | CC||LibreOffice@bielefeldundbus ||s.de --- Comment #5 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2011-12-04 00:02:11 PST --- [Reproducible] with Server Installation of LibreOffice 3.5.0 Beta0 - WIN7 Home Premium (64bit) English UI [Build:ef91e38-b1d4df6-090bcba-45cf606-05891e7], also in CALC. Right click on misspelled word crashes when auto spell check is active. We can not ship a release with this bug. András: Please feel free to reassign (or reset Assignee to default) if it’s not your area or if provided information is not sufficient. Please set Status to ASSIGNED if you accept this Bug. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43362] EDITING: Field Name can only have 10 characters
https://bugs.freedesktop.org/show_bug.cgi?id=43362 Andrew android2...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution||FIXED --- Comment #2 from Andrew android2...@gmail.com 2011-12-04 00:02:55 PST --- bug fixed in 3.4.4 thank you I did not even know that there was an update available. it sucks coming from Ubuntu and not having updates every day. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43424] : LO Crashes while Comparing an Empty Document with Another Document
https://bugs.freedesktop.org/show_bug.cgi?id=43424 Roman Eisele b...@eikota.de changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||b...@eikota.de Ever Confirmed|0 |1 --- Comment #1 from Roman Eisele b...@eikota.de 2011-12-04 00:23:12 PST --- 1) Confirmed with LibreOffice 3.4.4 / German UI, running on MacOS X 10.6.8 German. I will attach the MacOS X log file for the crash. 2) Confirmed with LibreOffice 3.5 beta 0 / German UI, running on MacOS X 10.6.8 German. The MacOS X log file for this crash is almost identical with the one for crash 1). Changing Status from Unconfirmed to New due to confirmation. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43424] : LO Crashes while Comparing an Empty Document with Another Document
https://bugs.freedesktop.org/show_bug.cgi?id=43424 --- Comment #2 from Roman Eisele b...@eikota.de 2011-12-04 00:30:16 PST --- Additional observation: This crash does NOT happen if you just (1) create an ODT document, insert one character (e.g. 'x'), and save it, then (2) create a new empty ODT document, and then (3) compare document (2) to document (1) -- no crash happens, everything works as expected (LibreOffice tells you about the differences). -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43501] FORMATTING Superscript (Subscript?) not working
https://bugs.freedesktop.org/show_bug.cgi?id=43501 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Status Whiteboard||target:3.5.0 Resolution||WORKSFORME CC||LibreOffice@bielefeldundbus ||s.de Summary|Superscript not working in |FORMATTING Superscript |centred cell text in table |(Subscript?) not working --- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2011-12-04 00:57:42 PST --- [Reproducible] with LibreOffice 3.4.4 - WIN7 Home Premium (64bit) German UI [Build ID: OOO340m1 (Build:402)] FOR SUBSCRIPT. Works fine in CALC Not reproducible for superscript. Has nothing to do with Table or centered, but with settings for position character size 100% in Formatting - Position dialog. Please see screenshot! Semms to bi fixed in Master and 3.5.0 Beta0, where radio buttons Superscript or Subscript select size smaller than 100% So WFM for now. @enigma: Wording error subscript / superscript or different problem? Please feel free to reopen this bug if you find out that the problem still exists with 3.5 and if you can contribute requested additional information due to http://wiki.documentfoundation.org/BugReport (especially BugReport Details)! -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43501] FORMATTING Superscript (Subscript?) not working
https://bugs.freedesktop.org/show_bug.cgi?id=43501 --- Comment #2 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2011-12-04 00:58:26 PST --- Created attachment 54104 -- https://bugs.freedesktop.org/attachment.cgi?id=54104 Sample document with screenshot -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43464] FILEOPEN, FORMATTING LibreOffice crashs in libswlx.so on opening file (attached)
https://bugs.freedesktop.org/show_bug.cgi?id=43464 --- Comment #2 from Roman Eisele b...@eikota.de 2011-12-04 01:08:36 PST --- Created attachment 54105 -- https://bugs.freedesktop.org/attachment.cgi?id=54105 Log file created by MacOS X 10.6.8 for the crash that happened when I opend the sample document the 2nd time (the first time, no crash occured -- strange!) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43506] New: print to faxprinter do not ask for telephone number
https://bugs.freedesktop.org/show_bug.cgi?id=43506 Bug #: 43506 Summary: print to faxprinter do not ask for telephone number Classification: Unclassified Product: LibreOffice Version: LibO 3.4.4 release Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Libreoffice AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: ad_deb...@joonet.de Until 3.3.3 I was able to use my faxprinter, configured with spadmin with this line: /usr/local/bin/myscript (PHONE) (TMP) But now with 3.4.4 I don't get the dialog asking for phone number. Instead the defined script myscript will be executed with telephone number option (PHONE) without any substitution, which gives an error. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43496] FILEOPEN .doc FORMATTING Allow Table to split does not work although checked
https://bugs.freedesktop.org/show_bug.cgi?id=43496 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added OS/Version|Linux (All) |All Status|NEW |NEEDINFO CC||LibreOffice@bielefeldundbus ||s.de See Also||https://issues.apache.org/o ||oo/show_bug.cgi?id=67480, ||https://launchpad.net/bugs/ ||898791 Summary|FILESAVE FILEOPEN |FILEOPEN .doc FORMATTING |FORMATTING long table at|Allow Table to split |end of .doc document cut|does not work although |off |checked Version|LibO 3.4.4 release |LibO 3.3.0 Beta2 --- Comment #2 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2011-12-04 02:01:49 PST --- [Reproducible] with LibreOffice 3.4.4 - WIN7 Home Premium (64bit) German UI [Build ID: OOO340m1 (Build:402)]. Steps to reproduece: 1. Open sample with LibO and a copy with MS WORD Viewer and compare Expected: look equal Actual: empty first page below heading + sub heading, table will start on next page Reason might be some misinterpretation concerning table settings. Although in table properties text flow settings I see Allow Table to split ... checked table does split, what also might explain other observed problems. Also visible with LibO 3.3.3, OOo 3.1.1, OOo 3.3, so inherited from OOo. Linked Apache OOo bug seems to be concerning the same (or at least a related) problem. Needinfo: - Works fine for simple self exported .doc with table. Might be a broken sample document? We need a more sample document reduced to the core problem like mysample1.odt Adding text lines before the table by enter will shift table row by row over the page break. If you uncheck Allow Table to split ... the complete table will move to next page. @Christopher Only 1 Problem per Bug! If Launchpad has other rules, the reports have to be adapted for citation here! I believe it's not necessary to repeat text of Ubuntu Launchpad report here, a link in See Also: Add Bug URLs: is sufficient. For me those bugs are terrible difficult to read, what ever strings like cd ~/Desktop wget -c should tell us? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43496] FILEOPEN .doc FORMATTING Allow Table to split does not work although checked
https://bugs.freedesktop.org/show_bug.cgi?id=43496 --- Comment #3 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2011-12-04 02:09:30 UTC --- Created attachment 54107 -- https://bugs.freedesktop.org/attachment.cgi?id=54107 Simple sample ... where settings work as expected. BTW, with reporter's sample still a problem in Master and 3.5.0 Beta0 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43507] New: PRINTING: after printing most options in formatting aids are disabled
https://bugs.freedesktop.org/show_bug.cgi?id=43507 Bug #: 43507 Summary: PRINTING: after printing most options in formatting aids are disabled Classification: Unclassified Product: LibreOffice Version: LibO 3.4.4 release Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: UNCONFIRMED Severity: major Priority: medium Component: Writer AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: ad_deb...@joonet.de I have always enabled some formatting aids in the options for Writer. But after printing, and the same after pdf export, the first six options are disabled: - Paragraph end - Custom hyphens - Spaces - Non-breaking spaces - Tabs - Breaks If I restart Writer (and LO) directly after printing sometimes the old options are enabled again. Without restart I have to reenable my wished options. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43508] New: CHART: vertical contortion of some (older) charts in calc
https://bugs.freedesktop.org/show_bug.cgi?id=43508 Bug #: 43508 Summary: CHART: vertical contortion of some (older) charts in calc Classification: Unclassified Product: LibreOffice Version: LibO 3.4.4 release Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: UNCONFIRMED Severity: major Priority: medium Component: Chart AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: ad_deb...@joonet.de I have a chart in a calc file made with LO 3.3.3. Then I upgraded to LO 3.4.4. After opening this calc file this chart have a vertical contortion and the calc line height behind the chart grows to more than the double value. After reformatting all things of the chart and the line hight of calc I save it to a new file and reopen. And again I have the same problem with the chart. The only workaround I see is to let the doubled line height of calc and reformatting only the chart. Then the made configuration of the chart stay as it should. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43509] New: : exponent priority in calculation order
https://bugs.freedesktop.org/show_bug.cgi?id=43509 Bug #: 43509 Summary: : exponent priority in calculation order Classification: Unclassified Product: LibreOffice Version: LibO 3.4.4 release Platform: Other OS/Version: All Status: UNCONFIRMED Status Whiteboard: BSA Severity: normal Priority: medium Component: Spreadsheet AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: nicolabarb...@gmail.com Problem description: the exponent is applied both to the base and to the leading sign Steps to reproduce: write in a cell =-1^2 should be considered as =-(1^2) NOT as =(-1)^2 so the current result is 1 instead of -1 Platform (if different from the browser): Browser: Mozilla/5.0 (Ubuntu; X11; Linux x86_64; rv:8.0) Gecko/20100101 Firefox/8.0 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43462] findAll doesn't work
https://bugs.freedesktop.org/show_bug.cgi?id=43462 --- Comment #1 from pedl...@gmail.com 2011-12-04 03:32:16 UTC --- I can confirm that the results are different in 3.4.4 and 3.5.0 Your macro seems to be looking for number 3 in the whole spreadsheet (I can't confirm if your macro is correct because I'm not an expert in Basic Macros). While version 3.5.0 reports 1 result, version 3.4.4 reports 6. But there are 7 visible cells containing value 3, so both results are wrong... -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43510] New: FILEOPEN: Freezes on open of ODG file
https://bugs.freedesktop.org/show_bug.cgi?id=43510 Bug #: 43510 Summary: FILEOPEN: Freezes on open of ODG file Classification: Unclassified Product: LibreOffice Version: LibO 3.4.4 release Platform: Other OS/Version: All Status: UNCONFIRMED Status Whiteboard: BSA Severity: normal Priority: medium Component: Drawing AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: loc...@optusnet.com.au Created attachment 54108 -- https://bugs.freedesktop.org/attachment.cgi?id=54108 A 17 page (I think) set of level designs for a game. Sorry - don't have time to isolate a problem, but this does reliably affect the behaviour on the laptop. Problem description: I have an A0 Draw file made on a Vista 64-bit machine, which freezes when I open the file on a Windows 7 64-bit. When I try to open it from within explorer, I get a gray background. When I try to open it from the open dialog, I get a perpetual progress bar in the status bar. It opens fine on the Vista 64 machine The document is attached. Earlier versions of the document (which I no longer have) did not crash Draw. Steps to reproduce: 1. Open file Current behavior: Goes into freeze when attempting to open Expected behavior: Open file Platform (if different from the browser): Browser: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/535.2 (KHTML, like Gecko) Chrome/15.0.874.121 Safari/535.2 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41394] EDITING / FORMATTING: cannot format data range of chart loose of data
https://bugs.freedesktop.org/show_bug.cgi?id=41394 Jean-Baptiste Faure jbf.fa...@orange.fr changed: What|Removed |Added Status|NEW |NEEDINFO CC||jbf.fa...@orange.fr --- Comment #9 from Jean-Baptiste Faure jbf.fa...@orange.fr 2011-12-04 03:49:21 PST --- (In reply to comment #0) Problem description: 'data range' not enabled under format menu Steps to reproduce: 1. double click chart so as to modify 2. click on format menu 3. Current behavior:data range greyed out and not accessible Expected behavior: Be able to modify data used to create chart I do not reproduce on LibreOffice 3.4.4 x86_64 with FR langpack (vanilla version) under Ubuntu 10.04. Please try again with the current release. Best regards. JBF -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 37775] EasyHack: Recent Documents not updated by Save Save As...
https://bugs.freedesktop.org/show_bug.cgi?id=37775 --- Comment #1 from pedl...@gmail.com 2011-12-04 03:50:33 PST --- I can confirm this bug both under 3.4.4 Final and 3.5.0 (Build ID: a286353-090bcba-3bf3b94) under Windows XP Pro x86 SP3 This problem can be quite annoying (even a show-stopper) for users that edit frequently the same documents. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41394] EDITING / FORMATTING: cannot format data range of chart loose of data
https://bugs.freedesktop.org/show_bug.cgi?id=41394 --- Comment #10 from Jean-Baptiste Faure jbf.fa...@orange.fr 2011-12-04 03:53:13 PST --- (In reply to comment #2) It's absolutely worse that what is describe on 3.4.3 version If the document used was created by a previous version, trying to edit an existing charts remove all references to the data series sources. The previous data, sometimes exist but as a table, like if they were copied from the initial data series. On columns chart type with 3.4.3 the data source is killed, and then there's no way for the users to retrieve it. Even ctrl+Z doesn't restore the chart. - Data corruption ! You need to use a previous version of the document if it saved, there's no more data. See the different print-screen attached. This as been tested and confirmed under Linux 64bits (openSUSE 11.4 / 12.1 ) + windows 7 64bits, and windows xp 32 bits (legacy LOO.exe installer) It is a different issue. AFAIK it is not the correct behavior to have the button Data table activated inside Calc. This button is useful when you insert your chart in a text document using copy-paste. All works as expected in LibO 3.4.4 under Ubuntu 10.04 x86_64 with FR langpack. Please try again with the current release. Best regards. JBF -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43485] FILESAVE: brings up unexpected file has been changed message
https://bugs.freedesktop.org/show_bug.cgi?id=43485 --- Comment #1 from pedl...@gmail.com 2011-12-04 04:03:40 PST --- This doesn't occur in LO 3.4.4 Final or 3.5.0 (Build ID: a286353-090bcba-3bf3b94) under Windows XP Pro x86 SP3 Maybe it's an x64 specific bug? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43510] FILEOPEN: Freezes on open of ODG file
https://bugs.freedesktop.org/show_bug.cgi?id=43510 Lachlan Kingsford loc...@optusnet.com.au changed: What|Removed |Added Attachment #54108|A 17 page (I think) set of |Document that refuses to description|level designs for a game. |load |Sorry - don't have time to | |isolate a problem, but this | |does reliably affect the| |behaviour on the laptop.| -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43510] FILEOPEN: Freezes on open of ODG file
https://bugs.freedesktop.org/show_bug.cgi?id=43510 Lachlan Kingsford loc...@optusnet.com.au changed: What|Removed |Added Platform|Other |x86-64 (AMD64) OS/Version|All |Windows (All) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43383] FILEOPEN: via Hyperlink from document does not work
https://bugs.freedesktop.org/show_bug.cgi?id=43383 --- Comment #9 from pedl...@gmail.com 2011-12-04 04:17:29 PST --- Seems to be fixed in 3.5.0 (Build ID: a286353-090bcba-3bf3b94) running under Win XP Pro x86 SP3 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43485] FILESAVE: brings up unexpected file has been changed message
https://bugs.freedesktop.org/show_bug.cgi?id=43485 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added CC||LibreOffice@bielefeldundbus ||s.de --- Comment #2 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2011-12-04 04:33:41 UTC --- Sorry, I wrote some nonsense, please ignore version info in original report. Correct Version is Server installation of LibreOffice 3.5.0 Beta0 - WIN7 Home Premium (64bit) English UI [Build:ef91e38-b1d4df6-090bcba-45cf606-05891e7] An today I get a different message: Access to C:\.\filename.odt was denied + after ok General Error -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43511] New: UI: Navigation (F5) dialog lacks a search function
https://bugs.freedesktop.org/show_bug.cgi?id=43511 Bug #: 43511 Summary: UI: Navigation (F5) dialog lacks a search function Classification: Unclassified Product: LibreOffice Version: LibO 3.4.4 release Platform: Other OS/Version: All Status: UNCONFIRMED Status Whiteboard: BSA Severity: normal Priority: medium Component: Writer AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: hindm...@netzero.net Problem description: Navigation Dialog lacks a search function. Alternately Edit Find lacks an option to only search headers Steps to reproduce: 1. Open a document with headers 2. Press F5 3. The only way to find a section is to manually scroll and read through perhaps two or three hundred header entries Current behavior: Some documents are large and complex. A topic may be mentioned many many times in a document but the main discussion of the topic will have a header. Using the edit find function forces the user to search manually through perhaps dozens of mentions of the topic before finding the section devoted to the topic. Expected behavior: Please implement a search function in the Navigator dialog that will find entries in the Header section of the tree. Platform (if different from the browser): Fedora 16 Browser: Mozilla/5.0 (X11; Linux i686; rv:8.0) Gecko/20100101 Firefox/8.0 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43512] New: UI: Navigation dialog forgets its configuration when closed
https://bugs.freedesktop.org/show_bug.cgi?id=43512 Bug #: 43512 Summary: UI: Navigation dialog forgets its configuration when closed Classification: Unclassified Product: LibreOffice Version: LibO 3.4.4 release Platform: Other OS/Version: All Status: UNCONFIRMED Status Whiteboard: BSA Severity: normal Priority: medium Component: Writer AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: hindm...@netzero.net Problem description: Some documents are large and complex. The Navigator dialog is can be very helpful in finding the part of the document of interest. The Navigator dialog is large and always-on-top so, having been used, it must be closed to make the document visible. Unfortunately the dialog then forgets its place in the tree and when next opened you are back to the top of the tree with only the level 1 headers visible. Steps to reproduce: 1. Open a document with headers. 2. Press F5 - the Navigator dialog opens showing the level 1 headers 3. Navigate down through the header tree expanding the branches and needed to get to the section of interest. 4. Press F5 - the Navigator dialog closes 5. Press F5 - the Navigator dialog opens showing the level 1 headers. The work getting to the section of interest is lost Current behavior: Closing the Navigator dialog causes it to forget its place in the tree. Expected behavior: Having navigated to the branch of the Header tree of interest, opening the Navigator should return to the branch in use when the dialog was closed. Platform (if different from the browser): Fedora 16 using XFCE Browser: Mozilla/5.0 (X11; Linux i686; rv:8.0) Gecko/20100101 Firefox/8.0 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 36522] FORMATTING: styles aren´t applied correctly
https://bugs.freedesktop.org/show_bug.cgi?id=36522 thefrugalcomputer...@gmail.com changed: What|Removed |Added CC||TheFrugalComputerGuy@gmail. ||com --- Comment #3 from thefrugalcomputer...@gmail.com 2011-12-04 06:07:28 PST --- I have found similar behavior in LibreOffice Writer, 3.4.4 using a Windows 7 operating system. My issue is with the Bullets and Numbering Paragraph Style functionality. The Bullets and Numbering 'paragraph style' does not work as well as the 'list style' The entire problem/issue is shown in video: http://youtu.be/tD76C0s3TAI Please review the video and let me know if the functionality is working as you intended. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43496] FILEOPEN .doc FORMATTING Allow Table to split does not work although checked
https://bugs.freedesktop.org/show_bug.cgi?id=43496 Christopher M. Penalver christopher.penal...@gmx.com changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #4 from Christopher M. Penalver christopher.penal...@gmx.com 2011-12-04 06:14:58 PST --- Rainer Bielefeld, thank you for taking a look at this bug. Regarding your comments: + Works fine for simple self exported .doc with table. Might be a broken sample document? The attached document opens as expected in Word. Quoting from Description: the text at the beginning of the document is right above the table in the Word screenshot https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/898791/+attachment/2618025/+files/word-screenshot.png + We need a more sample document reduced to the core problem like mysample1.odt The document attached simply and clearly demonstrates the core problem as described in the Description. + Only 1 Problem per Bug! If Launchpad has other rules, the reports have to be adapted for citation here! If the bug looks as if it's stacked with 2 issues, it is not. It's two resultant problems of the same root bug. + For me those bugs are terrible difficult to read, what ever strings like cd ~/Desktop wget -c should tell us? These are basic Linux Terminal commands. For information on cd see: https://help.ubuntu.com/community/UsingTheTerminal#File_.26_Directory_Commands For wget see: manpages.ubuntu.com/manpages/gutsy/man1/wget.1.html Boiling it down, it automatically gets the file, moves the file into a known problem free location, and renames it to something easy to work with. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43513] New: UI: Navigator Dialog's Drop down box for heading levels shown does not affect the heading levels shown
https://bugs.freedesktop.org/show_bug.cgi?id=43513 Bug #: 43513 Summary: UI: Navigator Dialog's Drop down box for heading levels shown does not affect the heading levels shown Classification: Unclassified Product: LibreOffice Version: LibO 3.4.4 release Platform: Other OS/Version: All Status: UNCONFIRMED Status Whiteboard: BSA Severity: normal Priority: medium Component: Writer AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: hindm...@netzero.net Problem description: Selecting various numbers for Heading Levels Shown in the Navigator dialog control bar seems to have no effect on the numbers of header levels shown. Steps to reproduce: 1. Open a document with several levels of headers 2. Press f5. The Navigator dialog appears and shows the level 1 headers 3. Click the down arrow on the Heading Levels Shown drop down box and pick, say, 10. The number of levels displayed is unchanged. Current behavior: Clicking a number in the Heading Levels Shown drop down box seems to do nothing Expected behavior: Clicking a number in the Heading Levels Shown drop down box collapses or expands the header tree to show all levels of all branches up to and including the level number selected. Platform (if different from the browser): Fedora 16 using XFCE Browser: Mozilla/5.0 (X11; Linux i686; rv:8.0) Gecko/20100101 Firefox/8.0 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43514] New: UI: Need an easy way to get from current position in a document to the corresponding position in the Navigatior dialog's header tree
https://bugs.freedesktop.org/show_bug.cgi?id=43514 Bug #: 43514 Summary: UI: Need an easy way to get from current position in a document to the corresponding position in the Navigatior dialog's header tree Classification: Unclassified Product: LibreOffice Version: LibO 3.4.3 release Platform: Other OS/Version: All Status: UNCONFIRMED Status Whiteboard: BSA Severity: normal Priority: medium Component: Writer AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: hindm...@netzero.net Problem description: Documents can be large and complex. The Navigator's Header tree is a handy way to find your place in a document as you need only drill down the header tree to the branch of interest and double click. Unfortunately doing the opposite is not supported. A way to easily go from the document to the corresponding location in the header tree is not available. Steps to reproduce: 1. Open a document, a specification for instance, with several levels of headers. 2. Move down the document many paragraphs. 3. Wish you knew if the text you just read is part of the spec's Overview, or Background, or Detail Requirements, ie. which sub-sub-sub paragraph the text is a part of. The header tree in the Navigator would show you if there was a handy way to pop the Navigator open to the tree branch corresponding to the current location in the document. Current behavior: Moving around the document has no effect on the location shown on the Navigator's Heading tree. Pressing f5 always opens the Navigator with just the level 1 headers displayed and Headings selected. Expected behavior: Moving around the document also moves the location displayed in the Navigator's heading tree. Or perhaps there could be a right click menu option to pop open the Navigator to the current position in the document. Platform (if different from the browser): Fedora 16 with XFCE Browser: Mozilla/5.0 (X11; Linux i686; rv:8.0) Gecko/20100101 Firefox/8.0 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43383] FILEOPEN: via Hyperlink from document does not work
https://bugs.freedesktop.org/show_bug.cgi?id=43383 --- Comment #10 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2011-12-04 07:24:10 PST --- Today NOT reproducible with Server installation of MSVC Master LibO-dev 3.5.0 – WIN7 Home Premium (64bit) ENGLISH UI [Build ID: a286353-090bcba-3bf3b94] Win-x86@6 – 2011-12-02_22:36:35) Let's wait for 1 further build and test before we close it, might be an intermitting problem. @pedlino: Please add tinderbox timestamp to build info -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43496] FILEOPEN .doc FORMATTING Allow Table to split does not work although checked
https://bugs.freedesktop.org/show_bug.cgi?id=43496 --- Comment #5 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2011-12-04 07:26:00 PST --- I know that it looks normal in WORD (Viewer), but my experience is that WORD is more tolerant concerning smaller errors in the document. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43462] findAll doesn't work
https://bugs.freedesktop.org/show_bug.cgi?id=43462 --- Comment #2 from clio fyv...@ya.ru 2011-12-04 07:43:16 PST --- (In reply to comment #1) While version 3.5.0 reports 1 result, version 3.4.4 reports 6. But there are 7 visible cells containing value 3, so both results are wrong... No, the result in 3.4.4 is right, because the results with adjacent cells are grouped together into 1 result. See screenshot. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43462] findAll doesn't work
https://bugs.freedesktop.org/show_bug.cgi?id=43462 --- Comment #3 from clio fyv...@ya.ru 2011-12-04 07:44:05 PST --- Created attachment 54109 -- https://bugs.freedesktop.org/attachment.cgi?id=54109 screenshot -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42077] Range Names Incorrect in Copied Worksheets
https://bugs.freedesktop.org/show_bug.cgi?id=42077 markus.mohrh...@googlemail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution||NOTABUG Severity|major |normal Priority|highest |medium CC||markus.mohrhard@googlemail. ||com --- Comment #2 from markus.mohrh...@googlemail.com 2011-12-04 07:55:24 UTC --- This is not a bug. Use relative references instead of absolute references and everything should work as expected. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43462] findAll doesn't work
https://bugs.freedesktop.org/show_bug.cgi?id=43462 --- Comment #4 from clio fyv...@ya.ru 2011-12-04 07:56:58 UTC --- There is an extension with which you can navigate through results: http://extensions.libreoffice.org/extension-center/search-in-calc This extension freezes in LibO 3.5, because it tries to do Results(0).DataArray, but because DataArray is huge (Results(0) is the whole sheet), it freezes the program forever. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43169] : Creating empty database fails after installation with indefinite clocking
https://bugs.freedesktop.org/show_bug.cgi?id=43169 --- Comment #2 from Chip Eastham hardm...@gmail.com 2011-12-04 09:18:30 UTC --- I think that's right, Julien, a Windows only problem. I don't see the problem with the LibreOffice 3.3.2 package under Ubuntu 10.10 (Maverick Meerkat), although that's not exactly the same release. As a workaround I can open a sample database in Windows LibreOffice 3.4, make a copy of the database, and add new tables to the copy using Design View. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43517] New: Page Preview crashes
https://bugs.freedesktop.org/show_bug.cgi?id=43517 Bug #: 43517 Summary: Page Preview crashes Classification: Unclassified Product: LibreOffice Version: LibO 3.4.3 release Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Spreadsheet AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: andreas.wei...@gmail.com When trying to use the print preview, moving the mouse will crash libreoffice -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43518] New: Modify name of 'Back' buttons to 'Undo'
https://bugs.freedesktop.org/show_bug.cgi?id=43518 Bug #: 43518 Summary: Modify name of 'Back' buttons to 'Undo' Classification: Unclassified Product: LibreOffice Version: LibO 3.3.0 Beta2 Platform: Other OS/Version: All Status: UNCONFIRMED Severity: enhancement Priority: low Component: UI AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: libreoff...@bielefeldundbuss.de CC: pedl...@gmail.com The function of the button is to undo modifications / edits in the current dialog tab, and so the name of the button (text in the button) should match the function and be 'Undo'. That would ease understanding of difference to Reset button (and may be Defaults would be better for that one ...). -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43519] New: Cannot set default file associations
https://bugs.freedesktop.org/show_bug.cgi?id=43519 Bug #: 43519 Summary: Cannot set default file associations Classification: Unclassified Product: LibreOffice Version: LibO 3.4.4 release Platform: x86-64 (AMD64) OS/Version: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Libreoffice AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: empido...@gmail.com I would like to be able to set LibreOffice programs as the default for various file types (Calc for csv and xls, Writer for rtf and doc, etc.), but there does not seem to be a way to do this in Windows Vista. The normal means for setting default applications in Vista does not show LibreOffice programs among the options and will not let me pick them through the Browse... button. I do not remember this posing a problem with OpenOffice, so I assume this is a bug with LibreOffice rather than with Windows Vista. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 32531] EasyHack: Incorrect cursor key movement between table cells of different directionality
https://bugs.freedesktop.org/show_bug.cgi?id=32531 --- Comment #5 from Jared McCannon jared.r.mccan...@gmail.com 2011-12-04 10:53:15 PST --- (In reply to comment #4) (In reply to comment #3) Does this bug apply to the direction of the cursor in general when navigating through RTL documents in general? As of now, the right arrow makes the cursor go right and the left arrow goes left. Is this a separate issue or the same? The bug refers only to cursor movement between table cells. Eyal. Ok. The inversion of the arrow keys is still an issue. Right means right and left means left. A way of fixing the cell cursor movement could be to fixing the inverse arrow key movement as well. Or is that not a concern? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 32531] EasyHack: Incorrect cursor key movement between table cells of different directionality
https://bugs.freedesktop.org/show_bug.cgi?id=32531 --- Comment #6 from Jared McCannon jared.r.mccan...@gmail.com 2011-12-04 10:56:28 PST --- (In reply to comment #4) (In reply to comment #3) Does this bug apply to the direction of the cursor in general when navigating through RTL documents in general? As of now, the right arrow makes the cursor go right and the left arrow goes left. Is this a separate issue or the same? The bug refers only to cursor movement between table cells. Eyal. Ok. The inversion of the arrow keys is still an issue. Right means right and left means left. A way of fixing the cell cursor movement could be to fixing the inverse arrow key movement as well. Or is that not a concern? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43498] gtk3 VCL plugin is badly broken (copy/paste fails, graphical corruption on scrolling)
https://bugs.freedesktop.org/show_bug.cgi?id=43498 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||LibreOffice@bielefeldundbus ||s.de Ever Confirmed|0 |1 --- Comment #2 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2011-12-04 10:59:46 PST --- I know these problems with WIN when soft scrolling is activated, is that really new with 3.5 Beta or with what Version did you observe that problem the first time? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 34432] firebird ODBC: LibO hangs on 64 bits
https://bugs.freedesktop.org/show_bug.cgi?id=34432 Lionel Elie Mamane lio...@mamane.lu changed: What|Removed |Added Summary|firebird ODBC not work |firebird ODBC: LibO hangs ||on 64 bits -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43498] gtk3 VCL plugin is badly broken (copy/paste fails, graphical corruption on scrolling)
https://bugs.freedesktop.org/show_bug.cgi?id=43498 Alexandre Rostovtsev tetrom...@gentoo.org changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #3 from Alexandre Rostovtsev tetrom...@gentoo.org 2011-12-04 11:24:53 UTC --- (In reply to comment #2) I know these problems with WIN when soft scrolling is activated, is that really new with 3.5 Beta or with what Version did you observe that problem the first time? The copy/paste problem: * 3.4.1-3.4.4, gtk vcl plugin: did not occur. * 3.5 beta, gtk vcl pluguin: does not occur. * 3.5 beta, gtk3 vcl plugin: occurs 100% of the time. Scrolling graphical corruption problem: * 3.4.1-3.4.4, gtk vcl plugin: occurred rarely, affected the document text only. * 3.5 beta, gtk vcl plugin: does not occur. * 3.5 beta, gtk3 vcl plugin: occurs 100% of the time, affects both document text and UI elements like scroll bars. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs