[Libreoffice-commits] .: configmgr/source

[Stephan Bergmann]

 configmgr/source/xcuparser.cxx |   10 ++
 1 file changed, 10 insertions(+)

New commits:
commit ab93e1b483d7af9bcac997e838e5a62a924e28c3
Author: Stephan Bergmann sberg...@redhat.com
Date:   Thu Jan 12 09:15:19 2012 +0100

Check for xcu node that should rather be prop.

diff --git a/configmgr/source/xcuparser.cxx b/configmgr/source/xcuparser.cxx
index 6ee5c82..2d65923 100644
--- a/configmgr/source/xcuparser.cxx
+++ b/configmgr/source/xcuparser.cxx
@@ -934,6 +934,16 @@ void XcuParser::handleGroupNode(
 state_.push(State(true)); // ignored
 return;
 }
+Node::Kind kind = child-kind();
+if (kind != Node::KIND_GROUP  kind != Node::KIND_SET) {
+throw css::uno::RuntimeException(
+(rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(bad node \)) +
+ name +
+ rtl::OUString(
+ RTL_CONSTASCII_USTRINGPARAM(\ of non group/set kind in )) +
+ reader.getUrl()),
+css::uno::Reference css::uno::XInterface ());
+}
 if (op != OPERATION_MODIFY  op != OPERATION_FUSE) {
 throw css::uno::RuntimeException(
 (rtl::OUString(
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: np_sdk/StaticLibrary_nputils.mk

[Matus Kukan]

 np_sdk/StaticLibrary_nputils.mk |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 842523e46f347680ad2648c628c63374524135cd
Author: Matúš Kukan matus.ku...@gmail.com
Date:   Thu Jan 12 09:43:26 2012 +0100

np_sdk: add missing dependency

diff --git a/np_sdk/StaticLibrary_nputils.mk b/np_sdk/StaticLibrary_nputils.mk
index b0c9764..ff63293 100644
--- a/np_sdk/StaticLibrary_nputils.mk
+++ b/np_sdk/StaticLibrary_nputils.mk
@@ -27,6 +27,8 @@
 
 $(eval $(call gb_StaticLibrary_StaticLibrary,nputils))
 
+$(eval $(call gb_StaticLibrary_add_package_headers,nputils,np_sdk_inc))
+
 $(eval $(call gb_StaticLibrary_use_externals,nputils,\
mozilla_headers \
 ))
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: sal/inc

[Stephan Bergmann]

 sal/inc/sal/log.hxx |9 +
 1 file changed, 9 insertions(+)

New commits:
commit ddc3458259222720d000ccc9cc5e6bd9b09ef3c9
Author: Stephan Bergmann sberg...@redhat.com
Date:   Thu Jan 12 10:57:41 2012 +0100

Make it clear that sal/log.hxx functionality may change again.

diff --git a/sal/inc/sal/log.hxx b/sal/inc/sal/log.hxx
index 6eb152b..816d57a 100644
--- a/sal/inc/sal/log.hxx
+++ b/sal/inc/sal/log.hxx
@@ -153,6 +153,9 @@ inline char const * unwrapStream(StreamIgnore const ) {
 Potentially not only useful within the log framework (where it is used
 automatically), but also when creating exception messages.
 
+@attention For now, this functionality should only be used internally 
within
+LibreOffice. It may change again in a future version.
+
 @since LibreOffice 3.5
 */
 #define SAL_WHERE SAL_DETAIL_WHERE
@@ -166,6 +169,9 @@ inline char const * unwrapStream(StreamIgnore const ) {
 
   SAL_INFO(foo, object:   (hasName ? obj-name : SAL_STREAM(obj)));
 
+@attention For now, this functionality should only be used internally 
within
+LibreOffice. It may change again in a future version.
+
 @since LibreOffice 3.5
 */
 #define SAL_STREAM(stream) \
@@ -251,6 +257,9 @@ inline char const * unwrapStream(StreamIgnore const ) {
 change.  The log output is printed to stderr without further text encoding
 conversion.
 
+@attention For now, this functionality should only be used internally 
within
+LibreOffice. It may change again in a future version.
+
 @since LibreOffice 3.5
 */
 
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: 2 commits - svx/source tools/inc tools/source

[Radek Doulík]

 svx/source/customshapes/EnhancedCustomShape2d.cxx |6 +++---
 tools/inc/tools/poly.hxx  |3 ++-
 tools/source/generic/poly.cxx |5 -
 3 files changed, 9 insertions(+), 5 deletions(-)

New commits:
commit 1e47b40c79ddb1d3d16d1521a5d8b5960cd37661
Author: Radek Doulik r...@novell.com
Date:   Thu Jan 12 11:07:51 2012 +0100

fix ooxml custom shapes with 360 degree arcs

diff --git a/svx/source/customshapes/EnhancedCustomShape2d.cxx 
b/svx/source/customshapes/EnhancedCustomShape2d.cxx
index 948fff5..ee8a365 100644
--- a/svx/source/customshapes/EnhancedCustomShape2d.cxx
+++ b/svx/source/customshapes/EnhancedCustomShape2d.cxx
@@ -1407,7 +1407,7 @@ void EnhancedCustomShape2d::SwapStartAndEndArrow( 
SdrObject* pObj ) //#108274
 pObj-SetMergedItem( aLineEndCenter );
 }
 
-basegfx::B2DPolygon CreateArc( const Rectangle rRect, const Point rStart, 
const Point rEnd, const sal_Bool bClockwise )
+basegfx::B2DPolygon CreateArc( const Rectangle rRect, const Point rStart, 
const Point rEnd, const sal_Bool bClockwise, sal_Bool bFullCircle = sal_False )
 {
 Rectangle aRect( rRect );
 Point aStart( rStart );
@@ -1430,7 +1430,7 @@ basegfx::B2DPolygon CreateArc( const Rectangle rRect, 
const Point rStart, cons
 }
 }
 
-Polygon aTempPoly( aRect, aStart, aEnd, POLY_ARC );
+Polygon aTempPoly( aRect, aStart, aEnd, POLY_ARC, bFullCircle );
 basegfx::B2DPolygon aRetval;
 
 if ( bClockwise )
@@ -1757,7 +1757,7 @@ void EnhancedCustomShape2d::CreateSubPath( sal_uInt16 
rSrcPt, sal_uInt16 rSegm
 OSL_TRACE(ARCANGLETO rect: %d, %d   x   %d, %d   
start: %d, %d end: %d, %d clockwise: %d,
   aRect.Left(), aRect.Top(), 
aRect.Right(), aRect.Bottom(),
   aStartPoint.X(), aStartPoint.Y(), 
aEndPoint.X(), aEndPoint.Y(), bClockwise);
-aNewB2DPolygon.append(CreateArc( aRect, bClockwise 
? aEndPoint : aStartPoint, bClockwise ? aStartPoint : aEndPoint, bClockwise));
+aNewB2DPolygon.append(CreateArc( aRect, bClockwise 
? aEndPoint : aStartPoint, bClockwise ? aStartPoint : aEndPoint, bClockwise, 
aStartPoint == aEndPoint  fSwingAngle  F_PI));
 }
 
 rSrcPt += 2;
commit 72c50c235447f293a3772105fdfdd4f45d09ff9e
Author: Radek Doulik r...@novell.com
Date:   Thu Jan 12 11:06:11 2012 +0100

make it possible to create 360 degrees arc (circle)

diff --git a/tools/inc/tools/poly.hxx b/tools/inc/tools/poly.hxx
index 5923266..480b357 100644
--- a/tools/inc/tools/poly.hxx
+++ b/tools/inc/tools/poly.hxx
@@ -140,7 +140,8 @@ public:
  sal_uInt16 nPoints = 0 );
 Polygon( const Rectangle rBound,
  const Point rStart, const Point rEnd,
- PolyStyle ePolyStyle = POLY_ARC );
+ PolyStyle ePolyStyle = POLY_ARC,
+ sal_Bool bWholeCircle = sal_False );
 Polygon( const Point rBezPt1, const Point rCtrlPt1,
  const Point rBezPt2, const Point rCtrlPt2,
  sal_uInt16 nPoints = 0 );
diff --git a/tools/source/generic/poly.cxx b/tools/source/generic/poly.cxx
index fa2d1f5..8c64a9f 100644
--- a/tools/source/generic/poly.cxx
+++ b/tools/source/generic/poly.cxx
@@ -510,7 +510,7 @@ Polygon::Polygon( const Point rCenter, long nRadX, long 
nRadY, sal_uInt16 nPoin
 // ---
 
 Polygon::Polygon( const Rectangle rBound,
-  const Point rStart, const Point rEnd, PolyStyle eStyle )
+  const Point rStart, const Point rEnd, PolyStyle eStyle, 
sal_Bool bFullCircle )
 {
 DBG_CTOR( Polygon, NULL );
 
@@ -547,6 +547,9 @@ Polygon::Polygon( const Rectangle rBound,
 if( fDiff  0. )
 fDiff += F_2PI;
 
+if ( bFullCircle )
+fDiff = F_2PI;
+
 // Punktanzahl proportional verkleinern ( fDiff / (2PI) );
 // ist eingentlich nur fuer einen Kreis richtig; wir
 // machen es hier aber trotzdem
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - 2 commits - svx/source tools/inc tools/source

[Radek Doulík]

 svx/source/customshapes/EnhancedCustomShape2d.cxx |6 +++---
 tools/inc/tools/poly.hxx  |3 ++-
 tools/source/generic/poly.cxx |5 -
 3 files changed, 9 insertions(+), 5 deletions(-)

New commits:
commit 1ceb8e1878be513f260c6d7fbe7066627fca0693
Author: Radek Doulik r...@novell.com
Date:   Thu Jan 12 11:07:51 2012 +0100

fix ooxml custom shapes with 360 degree arcs

diff --git a/svx/source/customshapes/EnhancedCustomShape2d.cxx 
b/svx/source/customshapes/EnhancedCustomShape2d.cxx
index 948fff5..ee8a365 100644
--- a/svx/source/customshapes/EnhancedCustomShape2d.cxx
+++ b/svx/source/customshapes/EnhancedCustomShape2d.cxx
@@ -1407,7 +1407,7 @@ void EnhancedCustomShape2d::SwapStartAndEndArrow( 
SdrObject* pObj ) //#108274
 pObj-SetMergedItem( aLineEndCenter );
 }
 
-basegfx::B2DPolygon CreateArc( const Rectangle rRect, const Point rStart, 
const Point rEnd, const sal_Bool bClockwise )
+basegfx::B2DPolygon CreateArc( const Rectangle rRect, const Point rStart, 
const Point rEnd, const sal_Bool bClockwise, sal_Bool bFullCircle = sal_False )
 {
 Rectangle aRect( rRect );
 Point aStart( rStart );
@@ -1430,7 +1430,7 @@ basegfx::B2DPolygon CreateArc( const Rectangle rRect, 
const Point rStart, cons
 }
 }
 
-Polygon aTempPoly( aRect, aStart, aEnd, POLY_ARC );
+Polygon aTempPoly( aRect, aStart, aEnd, POLY_ARC, bFullCircle );
 basegfx::B2DPolygon aRetval;
 
 if ( bClockwise )
@@ -1757,7 +1757,7 @@ void EnhancedCustomShape2d::CreateSubPath( sal_uInt16 
rSrcPt, sal_uInt16 rSegm
 OSL_TRACE(ARCANGLETO rect: %d, %d   x   %d, %d   
start: %d, %d end: %d, %d clockwise: %d,
   aRect.Left(), aRect.Top(), 
aRect.Right(), aRect.Bottom(),
   aStartPoint.X(), aStartPoint.Y(), 
aEndPoint.X(), aEndPoint.Y(), bClockwise);
-aNewB2DPolygon.append(CreateArc( aRect, bClockwise 
? aEndPoint : aStartPoint, bClockwise ? aStartPoint : aEndPoint, bClockwise));
+aNewB2DPolygon.append(CreateArc( aRect, bClockwise 
? aEndPoint : aStartPoint, bClockwise ? aStartPoint : aEndPoint, bClockwise, 
aStartPoint == aEndPoint  fSwingAngle  F_PI));
 }
 
 rSrcPt += 2;
commit e4cd111fae5f9b781471d4150915bb189eff90ef
Author: Radek Doulik r...@novell.com
Date:   Thu Jan 12 11:06:11 2012 +0100

make it possible to create 360 degrees arc (circle)

diff --git a/tools/inc/tools/poly.hxx b/tools/inc/tools/poly.hxx
index 5923266..480b357 100644
--- a/tools/inc/tools/poly.hxx
+++ b/tools/inc/tools/poly.hxx
@@ -140,7 +140,8 @@ public:
  sal_uInt16 nPoints = 0 );
 Polygon( const Rectangle rBound,
  const Point rStart, const Point rEnd,
- PolyStyle ePolyStyle = POLY_ARC );
+ PolyStyle ePolyStyle = POLY_ARC,
+ sal_Bool bWholeCircle = sal_False );
 Polygon( const Point rBezPt1, const Point rCtrlPt1,
  const Point rBezPt2, const Point rCtrlPt2,
  sal_uInt16 nPoints = 0 );
diff --git a/tools/source/generic/poly.cxx b/tools/source/generic/poly.cxx
index f062b9e..14b34d3 100644
--- a/tools/source/generic/poly.cxx
+++ b/tools/source/generic/poly.cxx
@@ -510,7 +510,7 @@ Polygon::Polygon( const Point rCenter, long nRadX, long 
nRadY, sal_uInt16 nPoin
 // ---
 
 Polygon::Polygon( const Rectangle rBound,
-  const Point rStart, const Point rEnd, PolyStyle eStyle )
+  const Point rStart, const Point rEnd, PolyStyle eStyle, 
sal_Bool bFullCircle )
 {
 DBG_CTOR( Polygon, NULL );
 
@@ -547,6 +547,9 @@ Polygon::Polygon( const Rectangle rBound,
 if( fDiff  0. )
 fDiff += F_2PI;
 
+if ( bFullCircle )
+fDiff = F_2PI;
+
 // Punktanzahl proportional verkleinern ( fDiff / (2PI) );
 // ist eingentlich nur fuer einen Kreis richtig; wir
 // machen es hier aber trotzdem
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: desktop/scripts

[Stephan Bergmann]

 desktop/scripts/soffice.sh |6 --
 1 file changed, 6 deletions(-)

New commits:
commit 4f00cdfec54a574e25f47dab2f65b299ea64ec73
Author: Stephan Bergmann sberg...@redhat.com
Date:   Thu Jan 12 11:34:10 2012 +0100

valgrind.log creates more problems than it solves.

diff --git a/desktop/scripts/soffice.sh b/desktop/scripts/soffice.sh
index 130f047..1ae4fb7 100755
--- a/desktop/scripts/soffice.sh
+++ b/desktop/scripts/soffice.sh
@@ -151,12 +151,6 @@ if [ -n $GDBTRACECHECK ] ; then
 exec $GDBTRACECHECK $sd_prog/soffice.bin $@
 fi
 
-# valgrind --log-file=valgrind.log does not work well with --trace-children=yes
-if [ -n $VALGRINDCHECK ] ; then
-echo redirecting the standard and the error output to valgrind.log
-exec valgrind.log
-fi
-
 # do not pass the request for command line help to oosplash
 if test $# -eq 1; then
 case $1 in
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: 6 commits - editeng/inc editeng/source hwpfilter/CppunitTest_hwpfilter_test_hwpfilter.mk svtools/inc svtools/source test/prj unusedcode.easy vcl/generic vcl/inc vcl/source xml

[Caolán McNamara]

 editeng/inc/editeng/unofdesc.hxx  |1 
 editeng/source/uno/unofdesc.cxx   |   24 -
 hwpfilter/CppunitTest_hwpfilter_test_hwpfilter.mk |1 
 svtools/inc/svtools/collatorres.hxx   |9 
 svtools/source/control/collatorres.cxx|   26 -
 test/prj/build.lst|2 
 unusedcode.easy   |4 
 vcl/generic/fontmanager/fontmanager.cxx   |  358 --
 vcl/generic/print/glyphset.cxx|   25 -
 vcl/generic/print/glyphset.hxx|3 
 vcl/inc/unx/strhelper.hxx |   44 --
 vcl/inc/vcl/fontmanager.hxx   |   27 -
 vcl/inc/vcl/strhelper.hxx |   70 ++--
 vcl/source/helper/strhelper.cxx   |7 
 xmlsecurity/source/framework/buffernode.cxx   |   34 --
 xmlsecurity/source/framework/buffernode.hxx   |1 
 16 files changed, 59 insertions(+), 577 deletions(-)

New commits:
commit 7d42c86f660b65f86a864a6b674dc8cba107911c
Author: Caolán McNamara caol...@redhat.com
Date:   Thu Jan 12 10:28:08 2012 +

pesky dependencies

diff --git a/hwpfilter/CppunitTest_hwpfilter_test_hwpfilter.mk 
b/hwpfilter/CppunitTest_hwpfilter_test_hwpfilter.mk
index a6722cc..7beda1a 100644
--- a/hwpfilter/CppunitTest_hwpfilter_test_hwpfilter.mk
+++ b/hwpfilter/CppunitTest_hwpfilter_test_hwpfilter.mk
@@ -78,7 +78,6 @@ $(eval $(call 
gb_CppunitTest_set_args,hwpfilter_test_hwpfilter,\
 # we need to explicitly depend on library hwp because it is not implied
 # by a link relation
 $(call gb_CppunitTest_get_target,hwpfilter_test_hwpfilter) : \
-$(call gb_Library_get_target,localedata_en) \
$(call gb_Library_get_target,hwp)
 
 # vim: set noet sw=4 ts=4:
diff --git a/test/prj/build.lst b/test/prj/build.lst
index a06591b..b58dc5b 100644
--- a/test/prj/build.lst
+++ b/test/prj/build.lst
@@ -1,2 +1,2 @@
-te test : unotest vcl i18npool NULL
+te test : unotest vcl i18npool filters NULL
 te test\source nmake - all source_cpp NULL
commit 87ceb5c987f8bf546bbc0c0fc3447c640780be91
Author: Caolán McNamara caol...@redhat.com
Date:   Thu Jan 12 09:30:09 2012 +

VCL_DLLPUBLIC is in the wrong place

and there's a unused duplicate header here too which can go

diff --git a/vcl/inc/unx/strhelper.hxx b/vcl/inc/unx/strhelper.hxx
deleted file mode 100644
index 78db605..000
--- a/vcl/inc/unx/strhelper.hxx
+++ /dev/null
@@ -1,44 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- *
- * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
- *
- * Copyright 2000, 2010 Oracle and/or its affiliates.
- *
- * OpenOffice.org - a multi-platform office productivity suite
- *
- * This file is part of OpenOffice.org.
- *
- * OpenOffice.org is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Lesser General Public License version 3
- * only, as published by the Free Software Foundation.
- *
- * OpenOffice.org is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Lesser General Public License version 3 for more details
- * (a copy is included in the LICENSE file that accompanied this code).
- *
- * You should have received a copy of the GNU Lesser General Public License
- * version 3 along with OpenOffice.org.  If not, see
- * http://www.openoffice.org/license.html
- * for a copy of the LGPLv3 License.
- *
- /
-#ifndef _SV_STRHELPER_HXX
-#define _SV_STRHELPER_HXX
-#include tools/string.hxx
-
-String GetCommandLineToken( int, const String );
-// gets one token of a unix command line style string
-// doublequote, singlequote and singleleftquote protect their respective
-// contents
-
-int GetCommandLineTokenCount( const String );
-// returns number of tokens (zero if empty or whitespace only)
-
-String WhitespaceToSpace( const String, BOOL bProtect = TRUE );
-
-#endif
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/inc/vcl/strhelper.hxx b/vcl/inc/vcl/strhelper.hxx
index 62e4fc0..fa8258d 100644
--- a/vcl/inc/vcl/strhelper.hxx
+++ b/vcl/inc/vcl/strhelper.hxx
@@ -35,47 +35,47 @@
 
 #include cstring
 
-namespace psp {
+namespace psp
+{
+VCL_DLLPUBLIC String GetCommandLineToken( int, const String );
+VCL_DLLPUBLIC rtl::OString GetCommandLineToken(int, const rtl::OString);
+// gets one token of a unix command line style string
+// doublequote, singlequote and singleleftquote protect their respective
+// contents
 
-String VCL_DLLPUBLIC GetCommandLineToken( int, const String );
-rtl::OString VCL_DLLPUBLIC GetCommandLineToken(int, const rtl::OString);
-// gets one token of a unix 

[Libreoffice-commits] .: Branch 'libreoffice-3-4' - l10ntools/scripts

[David Tardon]

 l10ntools/scripts/fast_merge.pl |   21 +
 1 file changed, 13 insertions(+), 8 deletions(-)

New commits:
commit d3dca82e81c32433756ab7d92b1b8f901b9b23b5
Author: David Tardon dtar...@redhat.com
Date:   Wed Jan 11 14:04:54 2012 +0100

fix writing of strings from the first module

Signed-off-by: Andras Timar tima...@gmail.com

diff --git a/l10ntools/scripts/fast_merge.pl b/l10ntools/scripts/fast_merge.pl
index e9c36d0..c84f00b 100644
--- a/l10ntools/scripts/fast_merge.pl
+++ b/l10ntools/scripts/fast_merge.pl
@@ -89,11 +89,10 @@ while( hasLines() )
 }
 write_lines();
 }
-if( $#current+1 ne 0 )
+# write content of the last localize.sdf file
+if( $#buffer ge 0 )
 {
-( $path , $localize_file ) = make_paths();
-add_to_buffer();
-write_buffer( $path , $localize_file );
+write_buffer( $last_path , $last_localize_file );
 }
 release_lock();
 exit( 0 );
@@ -248,15 +247,14 @@ sub make_paths
 
 return ( $path , $localizeFile );
 }
+
 sub write_lines
 {
 if( $first_run ){
-add_to_buffer();
 my( $path , $localize_file ) = make_paths();
 $last_path = $path;
 $last_localize_file = $localize_file;
-mkpath $path;
-write_buffer( $path , $localize_file );
+add_to_buffer();
 $first_run = '';
 }
 else
@@ -269,7 +267,6 @@ sub write_lines
 }
 else
 {
-mkpath $path;
 write_buffer( $last_path , $last_localize_file );
 add_to_buffer();
 $last_path = $path;
@@ -277,6 +274,11 @@ sub write_lines
 }
 }
 }
+
+# Adds all lines that contain strings from one source file from every input 
file.
+# TODO: Would it not be better to add lines for all files from a directory 
(i.e., replace
+# $afile eq $elem-file by $adir eq $elem-dir)? We could get rid of the 
delayed
+# writing then. But maybe there is a reason for doing it this way...
 sub add_to_buffer
 {
 my $plainline;
@@ -293,12 +295,15 @@ sub add_to_buffer
 } while ( !$elem-endoffile  $amodule eq $elem-module  $afile eq 
$elem-file );
 }
 }
+
+# Writes the buffer to currently selected localize.sdf file.
 sub write_buffer
 {
 my $path= shift;
 my $localize_file   = shift;
 my $cnt = $#buffer+1;
 print Write to $path $cnt lines\n;
+mkpath $path;
 open FILE , $localize_file or die Can't open file '$localize_file'\n;
 foreach ( @buffer )
 {
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - 2 commits - l10ntools/scripts

[David Tardon]

 l10ntools/scripts/fast_merge.pl |   29 -
 1 file changed, 16 insertions(+), 13 deletions(-)

New commits:
commit e0192b517564f43ea6a0f3ef5fe57def2bfd2a3c
Author: David Tardon dtar...@redhat.com
Date:   Wed Jan 11 14:04:54 2012 +0100

fix writing of strings from the first module

Signed-off-by: David Tardon dtar...@redhat.com

diff --git a/l10ntools/scripts/fast_merge.pl b/l10ntools/scripts/fast_merge.pl
index 5dc63cf..cc632e4 100644
--- a/l10ntools/scripts/fast_merge.pl
+++ b/l10ntools/scripts/fast_merge.pl
@@ -89,11 +89,10 @@ while( hasLines() )
 }
 write_lines();
 }
-if( $#current+1 ne 0 )
+# write content of the last localize.sdf file
+if( $#buffer ge 0 )
 {
-( $path , $localize_file ) = make_paths();
-add_to_buffer();
-write_buffer( $path , $localize_file );
+write_buffer( $last_path , $last_localize_file );
 }
 release_lock();
 exit( 0 );
@@ -248,15 +247,14 @@ sub make_paths
 
 return ( $path , $localizeFile );
 }
+
 sub write_lines
 {
 if( $first_run ){
-add_to_buffer();
 my( $path , $localize_file ) = make_paths();
 $last_path = $path;
 $last_localize_file = $localize_file;
-mkpath $path;
-write_buffer( $path , $localize_file );
+add_to_buffer();
 $first_run = '';
 }
 else
@@ -269,7 +267,6 @@ sub write_lines
 }
 else
 {
-mkpath $path;
 write_buffer( $last_path , $last_localize_file );
 add_to_buffer();
 $last_path = $path;
@@ -277,6 +274,11 @@ sub write_lines
 }
 }
 }
+
+# Adds all lines that contain strings from one source file from every input 
file.
+# TODO: Would it not be better to add lines for all files from a directory 
(i.e., replace
+# $afile eq $elem-file by $adir eq $elem-dir)? We could get rid of the 
delayed
+# writing then. But maybe there is a reason for doing it this way...
 sub add_to_buffer
 {
 my $plainline;
@@ -293,12 +295,15 @@ sub add_to_buffer
 } while ( !$elem-endoffile  $amodule eq $elem-module  $afile eq 
$elem-file );
 }
 }
+
+# Writes the buffer to currently selected localize.sdf file.
 sub write_buffer
 {
 my $path= shift;
 my $localize_file   = shift;
 my $cnt = $#buffer+1;
 print Write to $path $cnt lines\n;
+mkpath $path;
 open FILE , $localize_file or die Can't open file '$localize_file'\n;
 foreach ( @buffer )
 {
commit ab69b4e6c09651e7462758bf41f992eb41c038af
Author: David Tardon dtar...@redhat.com
Date:   Wed Jan 11 11:42:09 2012 +0100

Revert fast_merge: fix mis-merge of first module's strings

This is not enough, because the file is still wrong.

This reverts commit 47a8454f5f76030203ce6458cf63d4348bdacffe.

Signed-off-by: David Tardon dtar...@redhat.com

diff --git a/l10ntools/scripts/fast_merge.pl b/l10ntools/scripts/fast_merge.pl
index 73b824e..5dc63cf 100644
--- a/l10ntools/scripts/fast_merge.pl
+++ b/l10ntools/scripts/fast_merge.pl
@@ -91,7 +91,7 @@ while( hasLines() )
 }
 if( $#current+1 ne 0 )
 {
-( $path , $localize_file ) = make_paths($current[ 0 ]-module);
+( $path , $localize_file ) = make_paths();
 add_to_buffer();
 write_buffer( $path , $localize_file );
 }
@@ -240,8 +240,7 @@ sub hasLines
 
 sub make_paths
 {
-my $module = shift ;
-my $localizeFile = $merge_dir.\\.$module.\\.$current[ 0 ]-file;
+my $localizeFile = $merge_dir.\\.$current[ 0 ]-module.\\.$current[ 0 
]-file;
 my $path = getDir( $localizeFile );
 $path =~ s/\\/\//g;
 
@@ -252,9 +251,8 @@ sub make_paths
 sub write_lines
 {
 if( $first_run ){
-my $module = $current[ 0 ]-module;
 add_to_buffer();
-my( $path , $localize_file ) = make_paths($module);
+my( $path , $localize_file ) = make_paths();
 $last_path = $path;
 $last_localize_file = $localize_file;
 mkpath $path;
@@ -264,7 +262,7 @@ sub write_lines
 else
 {
 return , if ( $#current+1 eq 0 );
-my( $path , $localize_file ) = make_paths($current[ 0 ]-module);
+my( $path , $localize_file ) = make_paths();
 if( $path eq $last_path )
 {
 add_to_buffer();
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'libreoffice-3-4' - vcl/unx

[Stephan Bergmann]

 vcl/unx/source/fontmanager/fontconfig.cxx |   19 +++
 1 file changed, 15 insertions(+), 4 deletions(-)

New commits:
commit 29a7cd20ac892003e3bbc622657a6028adc83759
Author: Caolán McNamara caol...@redhat.com
Date:   Wed Jan 11 20:47:54 2012 +

Resolves:fdo#44078 fix unfortunate name alias mixups with DejaVu fonts

Cherry-picked from 
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5id=25b90909a7a22f6900abbe9df12570a24e528c9a.

Signed-off-by: Stephan Bergmann sberg...@redhat.com

diff --git a/vcl/unx/source/fontmanager/fontconfig.cxx 
b/vcl/unx/source/fontmanager/fontconfig.cxx
index a60da2a..ab2ff6b 100644
--- a/vcl/unx/source/fontmanager/fontconfig.cxx
+++ b/vcl/unx/source/fontmanager/fontconfig.cxx
@@ -297,7 +297,7 @@ public:
 boost::unordered_map rtl::OString, rtl::OString, rtl::OStringHash  
m_aFontNameToLocalized;
 boost::unordered_map rtl::OString, rtl::OString, rtl::OStringHash  
m_aLocalizedToCanonical;
 private:
-void cacheLocalizedFontNames(FcChar8 *origfontname, FcChar8 *bestfontname, 
const std::vector lang_and_element  lang_and_elements);
+void cacheLocalizedFontNames(const FcChar8 *origfontname, const FcChar8 
*bestfontname, const std::vector lang_and_element  lang_and_elements);
 };
 
 oslGenericFunction FontCfgWrapper::loadSymbol( const char* pSymbol )
@@ -659,6 +659,7 @@ namespace
 
 std::vectorlang_and_element::const_iterator aEnd = elements.end();
 bool alreadyclosematch = false;
+bool found_fallback_englishname = false;
 for( std::vectorlang_and_element::const_iterator aIter = 
elements.begin(); aIter != aEnd; ++aIter )
 {
 const char *pLang = (const char*)aIter-first;
@@ -670,7 +671,8 @@ namespace
 }
 else if( alreadyclosematch )
 {
-// override candidate only if there is a perfect match
+// current candidate matches lang of lang-TERRITORY
+// override candidate only if there is a full match
 continue;
 }
 else if( rtl_str_compare( pLang, sLangMatch.getStr()) == 0)
@@ -679,10 +681,18 @@ namespace
 candidate = aIter-second;
 alreadyclosematch = true;
 }
+else if( found_fallback_englishname )
+{
+// already found an english fallback, don't override candidate
+// unless there is a better language match
+continue;
+}
 else if( rtl_str_compare( pLang, en) == 0)
 {
-// fallback to the english element name
+// select a fallback candidate of the first english element
+// name
 candidate = aIter-second;
+found_fallback_englishname = true;
 }
 }
 return candidate;
@@ -690,7 +700,8 @@ namespace
 }
 
 //Set up maps to quickly map between a fonts best UI name and all the rest of 
its names, and vice versa
-void FontCfgWrapper::cacheLocalizedFontNames(FcChar8 *origfontname, FcChar8 
*bestfontname, const std::vector lang_and_element  lang_and_elements)
+void FontCfgWrapper::cacheLocalizedFontNames(const FcChar8 *origfontname, 
const FcChar8 *bestfontname,
+const std::vector lang_and_element  lang_and_elements)
 {
 std::vectorlang_and_element::const_iterator aEnd = 
lang_and_elements.end();
 for (std::vectorlang_and_element::const_iterator aIter = 
lang_and_elements.begin(); aIter != aEnd; ++aIter)
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: test/prj

[Caolán McNamara]

 test/prj/build.lst |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 66be03c7490e160721884806fc959c29faa8063f
Author: Caolán McNamara caol...@redhat.com
Date:   Thu Jan 12 12:43:18 2012 +

wrong depend

diff --git a/test/prj/build.lst b/test/prj/build.lst
index b58dc5b..a06591b 100644
--- a/test/prj/build.lst
+++ b/test/prj/build.lst
@@ -1,2 +1,2 @@
-te test : unotest vcl i18npool filters NULL
+te test : unotest vcl i18npool NULL
 te test\source nmake - all source_cpp NULL
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: sc/CppunitTest_sc_filters_test.mk sc/prj

[Stephan Bergmann]

 sc/CppunitTest_sc_filters_test.mk |1 +
 sc/prj/build.lst  |2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

New commits:
commit de9dd8f969b90b8eafa69d9527a7aeb53a585e3b
Author: Stephan Bergmann sberg...@redhat.com
Date:   Thu Jan 12 13:51:56 2012 +0100

Missing component dependency.

diff --git a/sc/CppunitTest_sc_filters_test.mk 
b/sc/CppunitTest_sc_filters_test.mk
index c6b69f1..4ad57ba 100644
--- a/sc/CppunitTest_sc_filters_test.mk
+++ b/sc/CppunitTest_sc_filters_test.mk
@@ -85,6 +85,7 @@ $(eval $(call gb_CppunitTest_add_type_rdbs,sc_filters_test,\
 ))
 
 $(eval $(call gb_CppunitTest_add_components,sc_filters_test,\
+basic/util/sb \
 chart2/source/controller/chartcontroller \
 chart2/source/tools/charttools \
 chart2/source/model/chartmodel \
diff --git a/sc/prj/build.lst b/sc/prj/build.lst
index 27b7c30..bbc6303 100644
--- a/sc/prj/build.lst
+++ b/sc/prj/build.lst
@@ -1,2 +1,2 @@
-sc  sc  :   filter TRANSLATIONS:translations vbahelper oovbaapi 
svx uui stoc BOOST:boost formula MDDS:mdds oox LIBXSLT:libxslt unoxml ure test 
xmloff desktop ucb package configmgr officecfg scripting NULL
+sc  sc  : basic filter TRANSLATIONS:translations vbahelper oovbaapi 
svx uui stoc BOOST:boost formula MDDS:mdds oox LIBXSLT:libxslt unoxml ure test 
xmloff desktop ucb package configmgr officecfg scripting NULL
 sc sc\prj nmake - all sc_prj   NULL
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: sysui/desktop

[Andras Timar]

 sysui/desktop/icons/base_app.ico|binary
 sysui/desktop/icons/calc_app.ico|binary
 sysui/desktop/icons/database.ico|binary
 sysui/desktop/icons/draw_app.ico|binary
 sysui/desktop/icons/drawing-template.ico|binary
 sysui/desktop/icons/drawing.ico |binary
 sysui/desktop/icons/empty-document.ico  |binary
 sysui/desktop/icons/empty-template.ico  |binary
 sysui/desktop/icons/formula.ico |binary
 sysui/desktop/icons/hicolor/256x256/apps/calc.png   |binary
 sysui/desktop/icons/hicolor/256x256/apps/writer.png |binary
 sysui/desktop/icons/impress_app.ico |binary
 sysui/desktop/icons/main_app.ico|binary
 sysui/desktop/icons/master-document.ico |binary
 sysui/desktop/icons/math_app.ico|binary
 sysui/desktop/icons/oasis-database.ico  |binary
 sysui/desktop/icons/oasis-drawing-template.ico  |binary
 sysui/desktop/icons/oasis-drawing.ico   |binary
 sysui/desktop/icons/oasis-empty-document.ico|binary
 sysui/desktop/icons/oasis-empty-template.ico|binary
 sysui/desktop/icons/oasis-formula.ico   |binary
 sysui/desktop/icons/oasis-master-document.ico   |binary
 sysui/desktop/icons/oasis-presentation-template.ico |binary
 sysui/desktop/icons/oasis-presentation.ico  |binary
 sysui/desktop/icons/oasis-spreadsheet-template.ico  |binary
 sysui/desktop/icons/oasis-spreadsheet.ico   |binary
 sysui/desktop/icons/oasis-text-template.ico |binary
 sysui/desktop/icons/oasis-text.ico  |binary
 sysui/desktop/icons/oasis-web-template.ico  |binary
 sysui/desktop/icons/open.ico|binary
 sysui/desktop/icons/presentation-template.ico   |binary
 sysui/desktop/icons/presentation.ico|binary
 sysui/desktop/icons/spreadsheet-template.ico|binary
 sysui/desktop/icons/spreadsheet.ico |binary
 sysui/desktop/icons/text-template.ico   |binary
 sysui/desktop/icons/text.ico|binary
 sysui/desktop/icons/writer_app.ico  |binary
 37 files changed

New commits:
commit bc4ff4382964da57b8c36c115b0517d884127df3
Author: Andras Timar ati...@suse.com
Date:   Thu Jan 12 13:32:38 2012 +0100

256x256 Windows icons fdo#39555

diff --git a/sysui/desktop/icons/base_app.ico b/sysui/desktop/icons/base_app.ico
index 02cf7a4..97b6110 100644
Binary files a/sysui/desktop/icons/base_app.ico and 
b/sysui/desktop/icons/base_app.ico differ
diff --git a/sysui/desktop/icons/calc_app.ico b/sysui/desktop/icons/calc_app.ico
index a9dd646..388ac6d 100644
Binary files a/sysui/desktop/icons/calc_app.ico and 
b/sysui/desktop/icons/calc_app.ico differ
diff --git a/sysui/desktop/icons/database.ico b/sysui/desktop/icons/database.ico
index 02cf7a4..97b6110 100644
Binary files a/sysui/desktop/icons/database.ico and 
b/sysui/desktop/icons/database.ico differ
diff --git a/sysui/desktop/icons/draw_app.ico b/sysui/desktop/icons/draw_app.ico
index 5297dae..48749da 100644
Binary files a/sysui/desktop/icons/draw_app.ico and 
b/sysui/desktop/icons/draw_app.ico differ
diff --git a/sysui/desktop/icons/drawing-template.ico 
b/sysui/desktop/icons/drawing-template.ico
index af2e9ff..9991270 100644
Binary files a/sysui/desktop/icons/drawing-template.ico and 
b/sysui/desktop/icons/drawing-template.ico differ
diff --git a/sysui/desktop/icons/drawing.ico b/sysui/desktop/icons/drawing.ico
index 5297dae..48749da 100644
Binary files a/sysui/desktop/icons/drawing.ico and 
b/sysui/desktop/icons/drawing.ico differ
diff --git a/sysui/desktop/icons/empty-document.ico 
b/sysui/desktop/icons/empty-document.ico
index 20e665f..ec11e8f 100644
Binary files a/sysui/desktop/icons/empty-document.ico and 
b/sysui/desktop/icons/empty-document.ico differ
diff --git a/sysui/desktop/icons/empty-template.ico 
b/sysui/desktop/icons/empty-template.ico
index 20e665f..ec11e8f 100644
Binary files a/sysui/desktop/icons/empty-template.ico and 
b/sysui/desktop/icons/empty-template.ico differ
diff --git a/sysui/desktop/icons/formula.ico b/sysui/desktop/icons/formula.ico
index fb2f651..07b3e8e 100644
Binary files a/sysui/desktop/icons/formula.ico and 
b/sysui/desktop/icons/formula.ico differ
diff --git a/sysui/desktop/icons/hicolor/256x256/apps/calc.png 
b/sysui/desktop/icons/hicolor/256x256/apps/calc.png
index 3ce322a..a3f5fd4 100644
Binary files a/sysui/desktop/icons/hicolor/256x256/apps/calc.png and 
b/sysui/desktop/icons/hicolor/256x256/apps/calc.png differ
diff --git a/sysui/desktop/icons/hicolor/256x256/apps/writer.png 
b/sysui/desktop/icons/hicolor/256x256/apps/writer.png
index 80af4bd..2f4abcb 100644
Binary files a/sysui/desktop/icons/hicolor/256x256/apps/writer.png and 
b/sysui/desktop/icons/hicolor/256x256/apps/writer.png differ
diff --git a/sysui/desktop/icons/impress_app.ico 

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - sysui/desktop

[Andras Timar]

 sysui/desktop/icons/base_app.ico|binary
 sysui/desktop/icons/calc_app.ico|binary
 sysui/desktop/icons/database.ico|binary
 sysui/desktop/icons/draw_app.ico|binary
 sysui/desktop/icons/drawing-template.ico|binary
 sysui/desktop/icons/drawing.ico |binary
 sysui/desktop/icons/empty-document.ico  |binary
 sysui/desktop/icons/empty-template.ico  |binary
 sysui/desktop/icons/formula.ico |binary
 sysui/desktop/icons/hicolor/256x256/apps/calc.png   |binary
 sysui/desktop/icons/hicolor/256x256/apps/writer.png |binary
 sysui/desktop/icons/impress_app.ico |binary
 sysui/desktop/icons/main_app.ico|binary
 sysui/desktop/icons/master-document.ico |binary
 sysui/desktop/icons/math_app.ico|binary
 sysui/desktop/icons/oasis-database.ico  |binary
 sysui/desktop/icons/oasis-drawing-template.ico  |binary
 sysui/desktop/icons/oasis-drawing.ico   |binary
 sysui/desktop/icons/oasis-empty-document.ico|binary
 sysui/desktop/icons/oasis-empty-template.ico|binary
 sysui/desktop/icons/oasis-formula.ico   |binary
 sysui/desktop/icons/oasis-master-document.ico   |binary
 sysui/desktop/icons/oasis-presentation-template.ico |binary
 sysui/desktop/icons/oasis-presentation.ico  |binary
 sysui/desktop/icons/oasis-spreadsheet-template.ico  |binary
 sysui/desktop/icons/oasis-spreadsheet.ico   |binary
 sysui/desktop/icons/oasis-text-template.ico |binary
 sysui/desktop/icons/oasis-text.ico  |binary
 sysui/desktop/icons/oasis-web-template.ico  |binary
 sysui/desktop/icons/open.ico|binary
 sysui/desktop/icons/presentation-template.ico   |binary
 sysui/desktop/icons/presentation.ico|binary
 sysui/desktop/icons/spreadsheet-template.ico|binary
 sysui/desktop/icons/spreadsheet.ico |binary
 sysui/desktop/icons/text-template.ico   |binary
 sysui/desktop/icons/text.ico|binary
 sysui/desktop/icons/writer_app.ico  |binary
 37 files changed

New commits:
commit 55f45dbf89233f0d529c4c6659c50c05f683add7
Author: Andras Timar ati...@suse.com
Date:   Thu Jan 12 13:32:38 2012 +0100

256x256 Windows icons fdo#39555

diff --git a/sysui/desktop/icons/base_app.ico b/sysui/desktop/icons/base_app.ico
index 02cf7a4..97b6110 100644
Binary files a/sysui/desktop/icons/base_app.ico and 
b/sysui/desktop/icons/base_app.ico differ
diff --git a/sysui/desktop/icons/calc_app.ico b/sysui/desktop/icons/calc_app.ico
index a9dd646..388ac6d 100644
Binary files a/sysui/desktop/icons/calc_app.ico and 
b/sysui/desktop/icons/calc_app.ico differ
diff --git a/sysui/desktop/icons/database.ico b/sysui/desktop/icons/database.ico
index 02cf7a4..97b6110 100644
Binary files a/sysui/desktop/icons/database.ico and 
b/sysui/desktop/icons/database.ico differ
diff --git a/sysui/desktop/icons/draw_app.ico b/sysui/desktop/icons/draw_app.ico
index 5297dae..48749da 100644
Binary files a/sysui/desktop/icons/draw_app.ico and 
b/sysui/desktop/icons/draw_app.ico differ
diff --git a/sysui/desktop/icons/drawing-template.ico 
b/sysui/desktop/icons/drawing-template.ico
index af2e9ff..9991270 100644
Binary files a/sysui/desktop/icons/drawing-template.ico and 
b/sysui/desktop/icons/drawing-template.ico differ
diff --git a/sysui/desktop/icons/drawing.ico b/sysui/desktop/icons/drawing.ico
index 5297dae..48749da 100644
Binary files a/sysui/desktop/icons/drawing.ico and 
b/sysui/desktop/icons/drawing.ico differ
diff --git a/sysui/desktop/icons/empty-document.ico 
b/sysui/desktop/icons/empty-document.ico
index 20e665f..ec11e8f 100644
Binary files a/sysui/desktop/icons/empty-document.ico and 
b/sysui/desktop/icons/empty-document.ico differ
diff --git a/sysui/desktop/icons/empty-template.ico 
b/sysui/desktop/icons/empty-template.ico
index 20e665f..ec11e8f 100644
Binary files a/sysui/desktop/icons/empty-template.ico and 
b/sysui/desktop/icons/empty-template.ico differ
diff --git a/sysui/desktop/icons/formula.ico b/sysui/desktop/icons/formula.ico
index fb2f651..07b3e8e 100644
Binary files a/sysui/desktop/icons/formula.ico and 
b/sysui/desktop/icons/formula.ico differ
diff --git a/sysui/desktop/icons/hicolor/256x256/apps/calc.png 
b/sysui/desktop/icons/hicolor/256x256/apps/calc.png
index 3ce322a..a3f5fd4 100644
Binary files a/sysui/desktop/icons/hicolor/256x256/apps/calc.png and 
b/sysui/desktop/icons/hicolor/256x256/apps/calc.png differ
diff --git a/sysui/desktop/icons/hicolor/256x256/apps/writer.png 
b/sysui/desktop/icons/hicolor/256x256/apps/writer.png
index 80af4bd..2f4abcb 100644
Binary files a/sysui/desktop/icons/hicolor/256x256/apps/writer.png and 
b/sysui/desktop/icons/hicolor/256x256/apps/writer.png differ
diff --git a/sysui/desktop/icons/impress_app.ico 

[Libreoffice-commits] .: l10ntools/source

[Michel Loiseleur]

 l10ntools/source/helpex.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 2994b7b983b6df38b9cc3c778728a1bd55a671c0
Author: Loiseleur Michel michel.loisel...@free.fr
Date:   Thu Jan 12 14:45:02 2012 +0100

fix build error in l10ntools

On gcc-4.4.3, it fixes this error : l10ntools/source/helpex.cxx:82: error: 
parameter may not have variably modified type 'rtl::OString [(((long unsigned 
int)(((long int)i) + -0x1)) + 1)]'

diff --git a/l10ntools/source/helpex.cxx b/l10ntools/source/helpex.cxx
index 2680c59..f06f618 100644
--- a/l10ntools/source/helpex.cxx
+++ b/l10ntools/source/helpex.cxx
@@ -79,7 +79,7 @@ sal_Bool ParseCommandLine( int argc, char* argv[])
 // parse command line
 for( int i = 1; i  argc; i++ )
 {
-rtl::OString aArg(rtl::OString(argv[i]).toAsciiUpperCase());
+rtl::OString aArg = rtl::OString(argv[i]).toAsciiUpperCase();
 if (aArg.equalsL(RTL_CONSTASCII_STRINGPARAM(-I)))
 nState = STATE_INPUT; // next tokens specifies source files
 else if (aArg.equalsL(RTL_CONSTASCII_STRINGPARAM(-O)))
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: writerperfect/source

[Fridrich Strba]

 writerperfect/source/filter/OdgGenerator.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e198eea5a87bff84783bd038cf134e6ea3b764ad
Author: Fridrich Å trba fridrich.st...@bluewin.ch
Date:   Thu Jan 12 15:01:13 2012 +0100

Logical error in writerperfect

diff --git a/writerperfect/source/filter/OdgGenerator.cxx 
b/writerperfect/source/filter/OdgGenerator.cxx
index 584e8cc..fbafb02 100644
--- a/writerperfect/source/filter/OdgGenerator.cxx
+++ b/writerperfect/source/filter/OdgGenerator.cxx
@@ -948,7 +948,7 @@ void OdgGenerator::drawPath(const WPXPropertyListVector 
path)
 
 void OdgGenerator::drawGraphicObject(const ::WPXPropertyList propList, const 
::WPXBinaryData binaryData)
 {
-if (!propList[libwpg:mime-type]  
propList[libwpg:mime-type]-getStr().len() = 0)
+if (!propList[libwpg:mime-type] || 
propList[libwpg:mime-type]-getStr().len() = 0)
 return;
 
 mpImpl-_writeGraphicsStyle();
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - 2 commits - writerperfect/source

[Fridrich Strba]

 writerperfect/source/filter/OdgGenerator.cxx |   10 +-
 1 file changed, 9 insertions(+), 1 deletion(-)

New commits:
commit 5d097dfb44ab1d7a41000b8be2ff2ee680de94f9
Author: Fridrich Å trba fridrich.st...@bluewin.ch
Date:   Thu Jan 12 15:01:13 2012 +0100

Logical error in writerperfect

Signed-off-by: Fridrich Å trba fridrich.st...@bluewin.ch

diff --git a/writerperfect/source/filter/OdgGenerator.cxx 
b/writerperfect/source/filter/OdgGenerator.cxx
index 584e8cc..fbafb02 100644
--- a/writerperfect/source/filter/OdgGenerator.cxx
+++ b/writerperfect/source/filter/OdgGenerator.cxx
@@ -948,7 +948,7 @@ void OdgGenerator::drawPath(const WPXPropertyListVector 
path)
 
 void OdgGenerator::drawGraphicObject(const ::WPXPropertyList propList, const 
::WPXBinaryData binaryData)
 {
-if (!propList[libwpg:mime-type]  
propList[libwpg:mime-type]-getStr().len() = 0)
+if (!propList[libwpg:mime-type] || 
propList[libwpg:mime-type]-getStr().len() = 0)
 return;
 
 mpImpl-_writeGraphicsStyle();
commit 8d5d687354bb470033ed9ab63d8875bc4e34c096
Author: Fridrich Å trba fridrich.st...@bluewin.ch
Date:   Thu Jan 12 12:15:29 2012 +0100

Consider the style:mirror property

Signed-off-by: Fridrich Å trba fridrich.st...@bluewin.ch

diff --git a/writerperfect/source/filter/OdgGenerator.cxx 
b/writerperfect/source/filter/OdgGenerator.cxx
index 4d70f8d..584e8cc 100644
--- a/writerperfect/source/filter/OdgGenerator.cxx
+++ b/writerperfect/source/filter/OdgGenerator.cxx
@@ -950,10 +950,16 @@ void OdgGenerator::drawGraphicObject(const 
::WPXPropertyList propList, const ::
 {
 if (!propList[libwpg:mime-type]  
propList[libwpg:mime-type]-getStr().len() = 0)
 return;
+
+mpImpl-_writeGraphicsStyle();
+
 TagOpenElement *pDrawFrameElement = new TagOpenElement(draw:frame);
 
 
 WPXString sValue;
+sValue.sprintf(gr%i, mpImpl-miGraphicsStyleIndex-1);
+pDrawFrameElement-addAttribute(draw:style-name, sValue);
+
 if (propList[svg:x])
 pDrawFrameElement-addAttribute(svg:x, propList[svg:x]-getStr());
 if (propList[svg:y])
@@ -1280,6 +1286,8 @@ void OdgGeneratorPrivate::_writeGraphicsStyle()
 else
 
pStyleGraphicsPropertiesElement-addAttribute(draw:marker-end-width, 
0.118in);
 }
+if (mxStyle[style:mirror])
+pStyleGraphicsPropertiesElement-addAttribute(style:mirror, 
mxStyle[style:mirror]-getStr());
 
 mGraphicsAutomaticStyles.push_back(pStyleGraphicsPropertiesElement);
 mGraphicsAutomaticStyles.push_back(new 
TagCloseElement(style:graphic-properties));
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - svx/inc svx/source writerfilter/inc writerfilter/Library_rtftok.mk writerfilter/source

[Miklos Vajna]

 svx/inc/svx/dialogs.hrc   |1 
 svx/source/stbctrls/stbctrls.src  |5 +++
 writerfilter/Library_rtftok.mk|1 
 writerfilter/inc/rtftok/RTFDocument.hxx   |4 ++
 writerfilter/source/filter/RtfFilter.cxx  |8 +
 writerfilter/source/rtftok/rtfdocumentfactory.cxx |5 ++-
 writerfilter/source/rtftok/rtfdocumentimpl.cxx|8 +++--
 writerfilter/source/rtftok/rtfdocumentimpl.hxx|4 ++
 writerfilter/source/rtftok/rtftokenizer.cxx   |   30 --
 writerfilter/source/rtftok/rtftokenizer.hxx   |3 +-
 10 files changed, 58 insertions(+), 11 deletions(-)

New commits:
commit fe2395678a2d31e5e809e52bb49495cc3ab8b381
Author: Miklos Vajna vmik...@frugalware.org
Date:   Tue Jan 10 18:53:55 2012 +0100

fdo#38057 implement RTF import progressbar

(cherry picked from commit 92c7b6733e55a6ab62bc231ecf0ffd5c0da7c8d2)

Conflicts:

writerfilter/source/rtftok/rtftokenizer.cxx

diff --git a/svx/inc/svx/dialogs.hrc b/svx/inc/svx/dialogs.hrc
index 079be0a..76b0c0a 100755
--- a/svx/inc/svx/dialogs.hrc
+++ b/svx/inc/svx/dialogs.hrc
@@ -1175,5 +1175,6 @@
 #define RID_SVXBMP_DOC_MODIFIED_FEEDBACK (SVX_OOO_BUILD_START + 3)
 #define RID_SVXSTR_DOC_MODIFIED_YES  (SVX_OOO_BUILD_START + 4)
 #define RID_SVXSTR_DOC_MODIFIED_NO   (SVX_OOO_BUILD_START + 5)
+#define RID_SVXSTR_DOC_LOAD  (SVX_OOO_BUILD_START + 6)
 
 #endif
diff --git a/svx/source/stbctrls/stbctrls.src b/svx/source/stbctrls/stbctrls.src
index c2e0999..dea916d 100644
--- a/svx/source/stbctrls/stbctrls.src
+++ b/svx/source/stbctrls/stbctrls.src
@@ -97,6 +97,11 @@ String RID_SVXSTR_DOC_MODIFIED_NO
 Text [ en-US ] = The document has not been modified since the last save.;
 };
 
+String RID_SVXSTR_DOC_LOAD
+{
+Text [ en-US ] = Loading document...;
+};
+
  // PopupMenu -
 Menu RID_SVXMNU_ZOOM
 {
diff --git a/writerfilter/Library_rtftok.mk b/writerfilter/Library_rtftok.mk
index 9ee5cde..3835a5d 100644
--- a/writerfilter/Library_rtftok.mk
+++ b/writerfilter/Library_rtftok.mk
@@ -56,6 +56,7 @@ $(eval $(call gb_Library_add_linked_libs,rtftok,\
utl \
tl \
resourcemodel \
+   vcl \
$(gb_STDLIBS) \
 ))
 
diff --git a/writerfilter/inc/rtftok/RTFDocument.hxx 
b/writerfilter/inc/rtftok/RTFDocument.hxx
index 72fe6bd..15b94eb 100644
--- a/writerfilter/inc/rtftok/RTFDocument.hxx
+++ b/writerfilter/inc/rtftok/RTFDocument.hxx
@@ -33,6 +33,7 @@
 #include com/sun/star/io/XInputStream.hpp
 #include com/sun/star/lang/XComponent.hpp
 #include com/sun/star/frame/XFrame.hpp
+#include com/sun/star/task/XStatusIndicator.hpp
 
 namespace writerfilter {
 namespace rtftok {
@@ -62,7 +63,8 @@ namespace writerfilter {
 ::com::sun::star::uno::Reference 
::com::sun::star::uno::XComponentContext  const  xContext,
 ::com::sun::star::uno::Reference 
::com::sun::star::io::XInputStream  const  xInputStream,
 ::com::sun::star::uno::Reference 
::com::sun::star::lang::XComponent  const  xDstDoc,
-::com::sun::star::uno::Reference 
::com::sun::star::frame::XFrame  const  xFrame);
+::com::sun::star::uno::Reference 
::com::sun::star::frame::XFrame  const  xFrame,
+::com::sun::star::uno::Reference 
::com::sun::star::task::XStatusIndicator  const  xStatusIndicator);
 };
 } // namespace rtftok
 } // namespace writerfilter
diff --git a/writerfilter/source/filter/RtfFilter.cxx 
b/writerfilter/source/filter/RtfFilter.cxx
index 8786539..067fae9 100644
--- a/writerfilter/source/filter/RtfFilter.cxx
+++ b/writerfilter/source/filter/RtfFilter.cxx
@@ -36,6 +36,7 @@
 #include dmapper/DomainMapper.hxx
 #include rtftok/RTFDocument.hxx
 #include com/sun/star/frame/XFrame.hpp
+#include com/sun/star/task/XStatusIndicator.hpp
 
 using namespace ::rtl;
 using namespace ::cppu;
@@ -89,14 +90,19 @@ sal_Bool RtfFilter::filter( const uno::Sequence 
beans::PropertyValue  aDescri
 uno::Referenceframe::XFrame xFrame = 
aMediaDesc.getUnpackedValueOrDefault(MediaDescriptor::PROP_FRAME(),
 uno::Referenceframe::XFrame());
 
+uno::Referencetask::XStatusIndicator xStatusIndicator = 
aMediaDesc.getUnpackedValueOrDefault(MediaDescriptor::PROP_STATUSINDICATOR(),
+uno::Referencetask::XStatusIndicator());
+
 writerfilter::Stream::Pointer_t pStream(
 new writerfilter::dmapper::DomainMapper(m_xContext, 
xInputStream, m_xDstDoc, writerfilter::dmapper::DOCUMENT_RTF));
 writerfilter::rtftok::RTFDocument::Pointer_t const pDocument(
-
writerfilter::rtftok::RTFDocumentFactory::createDocument(m_xContext, 
xInputStream, m_xDstDoc, xFrame));
+

[Libreoffice-commits] .: writerfilter/source

[Miklos Vajna]

 writerfilter/source/rtftok/rtfdocumentimpl.cxx |   14 --
 1 file changed, 8 insertions(+), 6 deletions(-)

New commits:
commit 9f15592e08f17908b1e54fed200d0ec6aff29509
Author: Miklos Vajna vmik...@frugalware.org
Date:   Thu Jan 12 15:36:31 2012 +0100

fdo#41034 improve RTF import of table cell spacings

1) for empty cells, not only paragraph properties, but but character 
properties should be emitted as well (e.g. font)
2) \sb and \sb is an attribute, not an sprm (it was ignored)
3) \sl was ~ignored due to a typo

diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx 
b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
index b799508..b2e2f7d 100644
--- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx
+++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
@@ -1348,9 +1348,11 @@ int RTFDocumentImpl::dispatchSymbol(RTFKeyword nKeyword)
 {
 if (m_bNeedPap)
 {
-// There were no runs in the cell, so we need to send 
paragraph properties here.
-RTFValue::Pointer_t pValue(new 
RTFValue(m_aStates.top().aParagraphAttributes, 
m_aStates.top().aParagraphSprms));
-m_aTableBuffer.push_back(make_pair(BUFFER_PROPS, pValue));
+// There were no runs in the cell, so we need to send 
paragraph and character properties here.
+RTFValue::Pointer_t pPValue(new 
RTFValue(m_aStates.top().aParagraphAttributes, 
m_aStates.top().aParagraphSprms));
+m_aTableBuffer.push_back(make_pair(BUFFER_PROPS, pPValue));
+RTFValue::Pointer_t pCValue(new 
RTFValue(m_aStates.top().aCharacterAttributes, 
m_aStates.top().aCharacterSprms));
+m_aTableBuffer.push_back(make_pair(BUFFER_PROPS, pCValue));
 }
 
 RTFValue::Pointer_t pValue;
@@ -1964,8 +1966,6 @@ int RTFDocumentImpl::dispatchValue(RTFKeyword nKeyword, 
int nParam)
 case RTF_LIN: nSprm = 0x845e; break;
 case RTF_RI: nSprm = NS_sprm::LN_PDxaRight; break;
 case RTF_RIN: nSprm = 0x845d; break;
-case RTF_SB: nSprm = NS_sprm::LN_PDyaBefore; break;
-case RTF_SA: nSprm = NS_sprm::LN_PDyaAfter; break;
 case RTF_ITAP: nSprm = NS_sprm::LN_PTableDepth; break;
 default: break;
 }
@@ -1983,6 +1983,8 @@ int RTFDocumentImpl::dispatchValue(RTFKeyword nKeyword, 
int nParam)
 {
 case RTF_SBASEDON: nSprm = NS_rtf::LN_ISTDBASE; break;
 case RTF_SNEXT: nSprm = NS_rtf::LN_ISTDNEXT; break;
+case RTF_SB: nSprm = NS_ooxml::LN_CT_Spacing_before; break;
+case RTF_SA: nSprm = NS_ooxml::LN_CT_Spacing_after; break;
 default: break;
 }
 if (nSprm  0)
@@ -2172,7 +2174,7 @@ int RTFDocumentImpl::dispatchValue(RTFKeyword nKeyword, 
int nParam)
 if (nParam  0)
 {
 // NS_sprm::LN_PDyaLine could be used, but that won't work 
with slmult
-
m_aStates.top().aParagraphAttributes-push_back(make_pair(nSprm, pIntValue));
+
m_aStates.top().aParagraphAttributes-push_back(make_pair(NS_ooxml::LN_CT_Spacing_line,
 pIntValue));
 }
 break;
 case RTF_SLMULT:
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - writerfilter/source

[Miklos Vajna]

 writerfilter/source/rtftok/rtfdocumentimpl.cxx |   14 --
 writerfilter/source/rtftok/rtftokenizer.cxx|4 ++--
 2 files changed, 10 insertions(+), 8 deletions(-)

New commits:
commit 375de2b8bcd591d013c3411ead2e24dc23a8115e
Author: Miklos Vajna vmik...@frugalware.org
Date:   Wed Jan 11 00:15:51 2012 -0500

fdo#41034 improve RTF import of table cell spacings

1) for empty cells, not only paragraph properties, but but character 
properties should be emitted as well (e.g. font)
2) \sb and \sb is an attribute, not an sprm (it was ignored)
3) \sl was ~ignored due to a typo
(cherry picked from commit 9f15592e08f17908b1e54fed200d0ec6aff29509)

diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx 
b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
index 3dd41c0..82b2a31 100644
--- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx
+++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
@@ -1351,9 +1351,11 @@ int RTFDocumentImpl::dispatchSymbol(RTFKeyword nKeyword)
 {
 if (m_bNeedPap)
 {
-// There were no runs in the cell, so we need to send 
paragraph properties here.
-RTFValue::Pointer_t pValue(new 
RTFValue(m_aStates.top().aParagraphAttributes, 
m_aStates.top().aParagraphSprms));
-m_aTableBuffer.push_back(make_pair(BUFFER_PROPS, pValue));
+// There were no runs in the cell, so we need to send 
paragraph and character properties here.
+RTFValue::Pointer_t pPValue(new 
RTFValue(m_aStates.top().aParagraphAttributes, 
m_aStates.top().aParagraphSprms));
+m_aTableBuffer.push_back(make_pair(BUFFER_PROPS, pPValue));
+RTFValue::Pointer_t pCValue(new 
RTFValue(m_aStates.top().aCharacterAttributes, 
m_aStates.top().aCharacterSprms));
+m_aTableBuffer.push_back(make_pair(BUFFER_PROPS, pCValue));
 }
 
 RTFValue::Pointer_t pValue;
@@ -1955,8 +1957,6 @@ int RTFDocumentImpl::dispatchValue(RTFKeyword nKeyword, 
int nParam)
 case RTF_LIN: nSprm = 0x845e; break;
 case RTF_RI: nSprm = NS_sprm::LN_PDxaRight; break;
 case RTF_RIN: nSprm = 0x845d; break;
-case RTF_SB: nSprm = NS_sprm::LN_PDyaBefore; break;
-case RTF_SA: nSprm = NS_sprm::LN_PDyaAfter; break;
 case RTF_ITAP: nSprm = NS_sprm::LN_PTableDepth; break;
 default: break;
 }
@@ -1974,6 +1974,8 @@ int RTFDocumentImpl::dispatchValue(RTFKeyword nKeyword, 
int nParam)
 {
 case RTF_SBASEDON: nSprm = NS_rtf::LN_ISTDBASE; break;
 case RTF_SNEXT: nSprm = NS_rtf::LN_ISTDNEXT; break;
+case RTF_SB: nSprm = NS_ooxml::LN_CT_Spacing_before; break;
+case RTF_SA: nSprm = NS_ooxml::LN_CT_Spacing_after; break;
 default: break;
 }
 if (nSprm  0)
@@ -2163,7 +2165,7 @@ int RTFDocumentImpl::dispatchValue(RTFKeyword nKeyword, 
int nParam)
 if (nParam  0)
 {
 // NS_sprm::LN_PDyaLine could be used, but that won't work 
with slmult
-
m_aStates.top().aParagraphAttributes-push_back(make_pair(nSprm, pIntValue));
+
m_aStates.top().aParagraphAttributes-push_back(make_pair(NS_ooxml::LN_CT_Spacing_line,
 pIntValue));
 }
 break;
 case RTF_SLMULT:
diff --git a/writerfilter/source/rtftok/rtftokenizer.cxx 
b/writerfilter/source/rtftok/rtftokenizer.cxx
index 0a989d8..897e316 100644
--- a/writerfilter/source/rtftok/rtftokenizer.cxx
+++ b/writerfilter/source/rtftok/rtftokenizer.cxx
@@ -65,8 +65,8 @@ int RTFTokenizer::resolveParse()
 int ret;
 // for hex chars
 int b = 0, count = 2;
-sal_uInt32 nPercentSize;
-sal_uInt32 nLastPos;
+sal_uInt32 nPercentSize = 0;
+sal_uInt32 nLastPos = 0;
 
 if (m_xStatusIndicator.is())
 {
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: extensions/Module_extensions.mk np_sdk/Module_np_sdk.mk

[Matus Kukan]

 extensions/Module_extensions.mk |   23 +++
 np_sdk/Module_np_sdk.mk |5 -
 2 files changed, 11 insertions(+), 17 deletions(-)

New commits:
commit 830a2b923528323e0f39259234dfee26d9d44d21
Author: Matúš Kukan matus.ku...@gmail.com
Date:   Thu Jan 12 09:08:13 2012 +0100

use ENABLE_NSPLUGIN again

diff --git a/extensions/Module_extensions.mk b/extensions/Module_extensions.mk
index 9719f2b..a94eee6 100644
--- a/extensions/Module_extensions.mk
+++ b/extensions/Module_extensions.mk
@@ -76,36 +76,27 @@ endif # DISABLE_ATL
 
 endif # WNT
 
-ifneq ($(WITH_MOZILLA),NO)
-
+ifeq ($(ENABLE_NSPLUGIN),YES)
 $(eval $(call gb_Module_add_targets,extensions,\
-   Library_pl \
Executable_nsplugin \
+   Library_npsoplugin \
+   WinResTarget_npsoplugin \
 ))
 
-ifeq ($(GUI),WNT)
+endif
+
+ifeq ($(WITH_MOZILLA),YES)
 $(eval $(call gb_Module_add_targets,extensions,\
-   Library_npsoplugin \
-   WinResTarget_npsoplugin \
+   Library_pl \
 ))
-endif # GUI=WNT
 
 ifeq ($(GUI),UNX)
-
 ifneq ($(GUIBASE),aqua)
-
 $(eval $(call gb_Module_add_targets,extensions,\
Executable_pluginapp.bin \
 ))
 
 endif # GUIBASE!=aqua
-
-ifneq ($(ENABLE_GTK),)
-$(eval $(call gb_Module_add_targets,extensions,\
-   Library_npsoplugin \
-))
-endif # ENABLE_GTK
-
 endif # GUI=UNX
 
 endif # WITH_MOZILLA=YES
diff --git a/np_sdk/Module_np_sdk.mk b/np_sdk/Module_np_sdk.mk
index bda8126..6c658d2 100644
--- a/np_sdk/Module_np_sdk.mk
+++ b/np_sdk/Module_np_sdk.mk
@@ -27,9 +27,12 @@
 
 $(eval $(call gb_Module_Module,np_sdk))
 
-ifeq ($(WITH_MOZILLA),YES)
 $(eval $(call gb_Module_add_targets,np_sdk,\
Package_inc \
+))
+
+ifeq ($(ENABLE_NSPLUGIN),YES)
+$(eval $(call gb_Module_add_targets,np_sdk,\
StaticLibrary_nputils \
 ))
 
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Repository.mk

[Matus Kukan]

 Repository.mk |   10 --
 1 file changed, 8 insertions(+), 2 deletions(-)

New commits:
commit 68b08a11babb7274048ef836a078959d126c97b7
Author: Matúš Kukan matus.ku...@gmail.com
Date:   Thu Jan 12 18:33:33 2012 +0100

ops, also adapt registering of the executable

diff --git a/Repository.mk b/Repository.mk
index 38a52d5..ac24a61 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -101,9 +101,15 @@ endif
 
 endif
 
-ifneq ($(WITH_MOZILLA),NO)
+ifeq ($(ENABLE_NSPLUGIN),YES)
+$(eval $(call gb_Helper_register_executables,OOO,\
+nsplugin \
+))
+
+endif
+
+ifeq ($(WITH_MOZILLA),YES)
 $(eval $(call gb_Helper_register_executables,OOO,\
-   nsplugin \
 pluginapp.bin \
 ))
 $(eval $(call gb_Helper_register_libraries,OOOLIBS, \
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: cui/source

[Ivan Timofeev]

 cui/source/customize/eventdlg.src |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b90940233f34d6cb468a2b4b8a38a78973e1d579
Author: Ivan Timofeev timofeev@gmail.com
Date:   Thu Jan 12 18:08:11 2012 +0400

move overlapped controls

diff --git a/cui/source/customize/eventdlg.src 
b/cui/source/customize/eventdlg.src
index c4ef082..4159a2d 100644
--- a/cui/source/customize/eventdlg.src
+++ b/cui/source/customize/eventdlg.src
@@ -65,7 +65,7 @@ TabPage RID_SVXPAGE_EVENTS
 {
 HelpID = cui:ListBox:RID_SVXPAGE_EVENTS:LB_SAVEIN;
 Border = TRUE ;
-Pos = MAP_APPFONT ( 54 , 238 ) ;
+Pos = MAP_APPFONT ( 62 , 238 ) ;
 Size = MAP_APPFONT ( 132 , 53 ) ;
 DropDown = TRUE ;
 };
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: boost/boost.6397.warnings.patch boost/makefile.mk

[Caolán McNamara]

 boost/boost.6397.warnings.patch |  222 
 boost/makefile.mk   |4 
 2 files changed, 226 insertions(+)

New commits:
commit 14359c82eb91b69212cbf0f743e819776a8f6d3a
Author: Caolán McNamara caol...@redhat.com
Date:   Thu Jan 12 20:40:36 2012 +

enable boost::multi_array

diff --git a/boost/boost.6397.warnings.patch b/boost/boost.6397.warnings.patch
new file mode 100644
index 000..a307c31
--- /dev/null
+++ b/boost/boost.6397.warnings.patch
@@ -0,0 +1,222 @@
+--- misc/boost_1_44_0/boost/multi_array/collection_concept.hpp 2012-01-12 
20:21:29.790009198 +
 misc/build/boost_1_44_0/boost/multi_array/collection_concept.hpp   
2012-01-12 20:28:55.457287835 +
+@@ -43,11 +43,11 @@
+   i = c.end();
+   c.swap(c);
+ }
+-void const_constraints(const Collection c) {
+-  ci = c.begin();
+-  ci = c.end();
+-  n = c.size();
+-  b = c.empty();
++void const_constraints(const Collection c_) {
++  ci = c_.begin();
++  ci = c_.end();
++  n = c_.size();
++  b = c_.empty();
+ }
+ Collection c;
+ bool b;
+--- misc/boost_1_44_0/boost/multi_array/concept_checks.hpp 2012-01-12 
20:21:29.790009198 +
 misc/build/boost_1_44_0/boost/multi_array/concept_checks.hpp   
2012-01-12 20:29:56.482879277 +
+@@ -39,8 +39,8 @@
+ 
+ template typename Array, typename IdxGen, typename Call_Type
+ static void call(Array a, const IdxGen idgen, Call_Type c) {
+-  typedef typename Array::index_range index_range;
+-  typedef typename Array::index index;
++  typedef typename Array::index_range index_range_;
++  typedef typename Array::index index_;
+   idgen_helperN-1::call(a,idgen[c],c);
+ }
+   };
+@@ -50,8 +50,8 @@
+ 
+ template typename Array, typename IdxGen, typename Call_Type
+ static void call(Array a, const IdxGen idgen, Call_Type) {
+-  typedef typename Array::index_range index_range;
+-  typedef typename Array::index index;
++  typedef typename Array::index_range index_range_;
++  typedef typename Array::index index_;
+   a[ idgen ];
+ }
+   };
+@@ -153,27 +153,27 @@
+   const_constraints(a);
+ }
+ 
+-void const_constraints(const Array a) {
++void const_constraints(const Array a_) {
+ 
+   //  value_type vt = a[ id ];
+ 
+   // Test slicing, keeping only the first dimension, losing the rest
+-  idgen_helperNumDims-1::call(a,idgen[range],id);
++  idgen_helperNumDims-1::call(a_,idgen[range],id);
+ 
+   // Test slicing, keeping all dimensions.
+-  idgen_helperNumDims-1::call(a,idgen[range],range);
++  idgen_helperNumDims-1::call(a_,idgen[range],range);
+ 
+-  st = a.size();
+-  st = a.num_dimensions();
+-  st = a.num_elements();
+-  stp = a.shape();
+-  idp = a.strides();
+-  idp = a.index_bases();
+-  cit = a.begin();
+-  cit = a.end();
+-  crit = a.rbegin();
+-  crit = a.rend();
+-  eltp = a.origin();
++  st = a_.size();
++  st = a_.num_dimensions();
++  st = a_.num_elements();
++  stp = a_.shape();
++  idp = a_.strides();
++  idp = a_.index_bases();
++  cit = a_.begin();
++  cit = a_.end();
++  crit = a_.rbegin();
++  crit = a_.rend();
++  eltp = a_.origin();
+ }
+ 
+ typedef typename Array::value_type value_type;
+--- misc/boost_1_44_0/boost/multi_array/extent_range.hpp   2012-01-12 
20:21:29.790009198 +
 misc/build/boost_1_44_0/boost/multi_array/extent_range.hpp 2012-01-12 
20:32:16.696241748 +
+@@ -26,11 +26,11 @@
+   typedef Extent index;
+   typedef SizeType size_type;
+ 
+-  extent_range(index start, index finish) :
+-super_type(start,finish) { }
++  extent_range(index start_, index finish_) :
++super_type(start_,finish_) { }
+ 
+-  extent_range(index finish) :
+-super_type(0,finish) { }
++  extent_range(index finish_) :
++super_type(0,finish_) { }
+ 
+   extent_range() : super_type(0,0) { }
+ 
+--- misc/boost_1_44_0/boost/multi_array/index_range.hpp2012-01-12 
20:21:29.790009198 +
 misc/build/boost_1_44_0/boost/multi_array/index_range.hpp  2012-01-12 
20:31:29.405781105 +
+@@ -60,8 +60,8 @@
+   degenerate_ = true;
+ }
+ 
+-explicit index_range(index start, index finish, index stride=1)
+-  : start_(start), finish_(finish), stride_(stride),
++explicit index_range(index i_start, index i_finish, index i_stride=1)
++  : start_(i_start), finish_(i_finish), stride_(i_stride),
+ degenerate_(false)
+ { }
+ 
+@@ -107,11 +107,11 @@
+ 
+ index stride() const { return stride_; }
+ 
+-void set_index_range(index start, index finish, index stride=1)
++void set_index_range(index i_start, index i_finish, index i_stride=1)
+ {
+-  start_ = start;
+-  finish_ = finish;
+-  stride_ = stride;
++  start_ = i_start;
++  finish_ = i_finish;
++  stride_ = i_stride;
+ }

[Libreoffice-commits] .: stoc/source

[Olivier Hallot]

 stoc/source/defaultregistry/defaultregistry.cxx   |   18 +++---
 stoc/source/implementationregistration/implreg.cxx|   16 +++---
 stoc/source/invocation/invocation.cxx |4 -
 stoc/source/javavm/javavm.cxx |   20 
+++
 stoc/source/loader/dllcomponentloader.cxx |2 
 stoc/source/proxy_factory/proxyfac.cxx|2 
 stoc/source/registry_tdprovider/rdbtdp_tdenumeration.cxx  |2 
 stoc/source/registry_tdprovider/tdcomp.cxx|2 
 stoc/source/registry_tdprovider/tdef.cxx  |2 
 stoc/source/registry_tdprovider/tdiface.cxx   |4 -
 stoc/source/registry_tdprovider/tdservice.cxx |4 -
 stoc/source/security/access_controller.cxx|   10 +--
 stoc/source/security/file_policy.cxx  |   10 +--
 stoc/source/security/permissions.cxx  |4 -
 stoc/source/servicemanager/servicemanager.cxx |4 -
 stoc/source/simpleregistry/simpleregistry.cxx |2 
 stoc/source/simpleregistry/textualservices.cxx|   26 
+-
 stoc/source/tdmanager/tdmgr.cxx   |2 
 stoc/source/tdmanager/tdmgr_check.cxx |2 
 stoc/source/uriproc/ExternalUriReferenceTranslator.cxx|4 -
 stoc/source/uriproc/UriReference.cxx  |   16 +++---
 stoc/source/uriproc/UriReferenceFactory.cxx   |   23 

 stoc/source/uriproc/UriSchemeParser_vndDOTsunDOTstarDOTexpand.cxx |7 --
 stoc/source/uriproc/UriSchemeParser_vndDOTsunDOTstarDOTscript.cxx |8 +--
 24 files changed, 95 insertions(+), 99 deletions(-)

New commits:
commit 71dc235aba9597c3485a791a319a34e4258138db
Author: Olivier Hallot olivier.hal...@alta.org.br
Date:   Thu Jan 12 17:01:19 2012 -0200

Fix for fdo43460 Part XXXV getLength() to isEmpty()

Part XXXV
Modules
stoc

diff --git a/stoc/source/defaultregistry/defaultregistry.cxx 
b/stoc/source/defaultregistry/defaultregistry.cxx
index b80167a..da291d2 100644
--- a/stoc/source/defaultregistry/defaultregistry.cxx
+++ b/stoc/source/defaultregistry/defaultregistry.cxx
@@ -276,7 +276,7 @@ OUString NestedKeyImpl::computeName(const OUString name)
 return m_defaultKey-getResolvedName(name);
 }
 
-if ( resLocalName.getLength()  0  
m_pRegistry-m_defaultReg-isValid() )
+if ( !resLocalName.isEmpty()  m_pRegistry-m_defaultReg-isValid() )
 {
 ReferenceXRegistryKey 
localRoot(m_pRegistry-m_localReg-getRootKey());
 ReferenceXRegistryKey 
defaultRoot(m_pRegistry-m_defaultReg-getRootKey());
@@ -289,7 +289,7 @@ OUString NestedKeyImpl::computeName(const OUString name)
 {
 count--;
 
-if (resLocalName.getLength() == 0 || 
resDefaultName.getLength() == 0)
+if (resLocalName.isEmpty() || resDefaultName.isEmpty())
 throw InvalidRegistryException();
 
 resLocalName = localRoot-getResolvedName(resDefaultName);
@@ -683,7 +683,7 @@ Reference XRegistryKey  SAL_CALL NestedKeyImpl::openKey( 
const OUString aKeyN
 
 OUString resolvedName = computeName(aKeyName);
 
-if ( resolvedName.getLength() == 0 )
+if ( resolvedName.isEmpty() )
 throw InvalidRegistryException();
 
 ReferenceXRegistryKey localKey, defaultKey;
@@ -719,7 +719,7 @@ Reference XRegistryKey  SAL_CALL 
NestedKeyImpl::createKey( const OUString aKe
 
 OUString resolvedName = computeName(aKeyName);
 
-if ( resolvedName.getLength() == 0 )
+if ( resolvedName.isEmpty() )
 throw InvalidRegistryException();
 
 if ( m_localKey.is()  m_localKey-isValid() )
@@ -788,7 +788,7 @@ void SAL_CALL NestedKeyImpl::deleteKey( const OUString 
rKeyName )
 {
 OUString resolvedName = computeName(rKeyName);
 
-if ( resolvedName.getLength() == 0 )
+if ( resolvedName.isEmpty() )
 {
 throw InvalidRegistryException();
 }
@@ -969,7 +969,7 @@ sal_Bool SAL_CALL NestedKeyImpl::createLink( const 
OUString aLinkName, const OU
 
 resolvedName = computeName(linkName);
 
-if ( resolvedName.getLength() == 0 )
+if ( resolvedName.isEmpty() )
 {
 throw InvalidRegistryException();
 }
@@ -1023,7 +1023,7 @@ void SAL_CALL NestedKeyImpl::deleteLink( const OUString 
rLinkName )
 
 resolvedName = computeName(linkName);
 
-if ( resolvedName.getLength() == 0 )
+if ( resolvedName.isEmpty() )
 {
 throw InvalidRegistryException();
 }
@@ -1067,7 +1067,7 @@ OUString SAL_CALL NestedKeyImpl::getLinkTarget( const 
OUString rLinkName )
 
 

[Libreoffice-commits] .: stoc/source

[Olivier Hallot]

 stoc/source/simpleregistry/textualservices.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ba713b5add1dfbcd17f8e6c14561dd3589a3db72
Author: Olivier Hallot olivier.hal...@alta.org.br
Date:   Thu Jan 12 19:33:28 2012 -0200

Fix mistake in type OUStringBuffer

Fix mistake in method for type OUStringBuffer

diff --git a/stoc/source/simpleregistry/textualservices.cxx 
b/stoc/source/simpleregistry/textualservices.cxx
index 611d0ea..37540c8 100644
--- a/stoc/source/simpleregistry/textualservices.cxx
+++ b/stoc/source/simpleregistry/textualservices.cxx
@@ -422,7 +422,7 @@ rtl::OUString pathToString(std::vector rtl::OUString  
const  path) {
 buf.append(sal_Unicode('/'));
 buf.append(*i);
 }
-if (buf.isEmpty()) {
+if (buf.getLength() == 0) {
 buf.append(sal_Unicode('/'));
 }
 return buf.makeStringAndClear();
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: 5 commits - android/qa fontconfig/fontconfig-2.8.0.patch

[Tor Lillqvist]

 android/qa/sc/Makefile|   16 +++-
 android/qa/sc/fonts.conf  |8 ++--
 fontconfig/fontconfig-2.8.0.patch |2 +-
 3 files changed, 18 insertions(+), 8 deletions(-)

New commits:
commit 81301aae9699472bd4e491755c8ee76920711b01
Author: Tor Lillqvist tlillqv...@suse.com
Date:   Fri Jan 13 01:27:37 2012 +0200

More workarounds for weird problem with vnd.sun.star.expand

diff --git a/android/qa/sc/Makefile b/android/qa/sc/Makefile
index 738d101..1b9ac87 100644
--- a/android/qa/sc/Makefile
+++ b/android/qa/sc/Makefile
@@ -133,20 +133,23 @@ copy-stuff:
mkdir -p assets/bin assets/lib assets/xml/ure
cp $(OUTDIR)/bin/udkapi.rdb assets/bin
cp $(OUTDIR)/bin/types.rdb assets/bin
-   cp $(OUTDIR)/xml/ure/services.rdb assets/xml/ure
 # For some reason the vnd.sun.star.expand:$LO_LIB_DIR doesn't seem to work, it 
expands to empty!?
 # So just hardcode the known APP_DATA_PATH for now...
+# Ditto for URE_INTERNAL_LIB_DIR
+   for F in xml/ure/services; do \
+   sed -e 
's!uri=vnd.sun.star.expand:$$URE_INTERNAL_LIB_DIR/!uri=$(APP_DATA_PATH)/lib/!g'
 $(OUTDIR)/$$F.rdb assets/$$F.rdb; \
+   done
for F in framework/util/fwk i18npool/util/i18npool sfx2/util/sfx 
unoxml/source/service/unoxml configmgr/source/configmgr; do \
mkdir -p assets/ComponentTarget/`dirname $$F`; \
-   sed -e 
's!uri=vnd.sun.star.expand:$$LO_LIB_DIR/!uri=$(APP_DATA_PATH)/lib/!' 
$(WORKDIR)/ComponentTarget/$$F.component 
assets/ComponentTarget/$$F.component; \
+   sed -e 
's!uri=vnd.sun.star.expand:$$LO_LIB_DIR/!uri=$(APP_DATA_PATH)/lib/!g' 
$(WORKDIR)/ComponentTarget/$$F.component 
assets/ComponentTarget/$$F.component; \
done
for F in ucb1 ucpfile1; do \
-   sed -e 
's!uri=vnd.sun.star.expand:$$LO_LIB_DIR/!uri=$(APP_DATA_PATH)/lib/!' 
$(OUTDIR)/xml/$$F.component  assets/xml/$$F.component; \
+   sed -e 
's!uri=vnd.sun.star.expand:$$LO_LIB_DIR/!uri=$(APP_DATA_PATH)/lib/!g' 
$(OUTDIR)/xml/$$F.component assets/xml/$$F.component; \
done
-   cp -R $(OUTDIR)/xml/registry assets/xml
for F in uno_services uno_types; do \
sed -e 's!uri=./!uri=$(APP_DATA_PATH)/lib/!g' 
$(SRC_ROOT)/testtools/$(INPATH)/lib/$$F.rdb assets/lib/$$F.rdb; \
done
+   cp -R $(OUTDIR)/xml/registry assets/xml
 # Then assets that are unpacked at run-time into the app's data directory.
mkdir -p assets/unpack/bin
for F in $(OUTDIR)/bin/*.res; do \
commit f7392b334aa95e0896c9dd88bd74c92bc7e8b183
Author: Tor Lillqvist tlillqv...@suse.com
Date:   Fri Jan 13 00:41:12 2012 +0200

Fontconfig must have a cachedir, so hardcode one for now

diff --git a/android/qa/sc/fonts.conf b/android/qa/sc/fonts.conf
index 73e8a35..0eb05a2 100644
--- a/android/qa/sc/fonts.conf
+++ b/android/qa/sc/fonts.conf
@@ -1,4 +1,4 @@
-?xml version=1.0 encoding=UTF-8?
+?xml version=1.0?
 !DOCTYPE fontconfig SYSTEM fonts.dtd
 !-- /etc/fonts/fonts.conf file to configure system font access --
 fontconfig
@@ -50,7 +50,11 @@
 
 !-- Font cache directory list --
 
-!-- NO THANKS --
+   !-- Yeah this hardcoding is wrong of course, will have to fix
+later to patch in proper code in fontonfig on Android to
+find out a good place.
+   --
+   cachedir/data/data/org.libreoffice.android.qa.sc/fontconfig/cachedir
 
config
 !--
commit 6e3457da7c95b8a36c4a9fb904bfc12129c98c80
Author: Tor Lillqvist tlillqv...@suse.com
Date:   Fri Jan 13 00:40:44 2012 +0200

Just tell to run it with make run

diff --git a/android/qa/sc/Makefile b/android/qa/sc/Makefile
index da85f08..738d101 100644
--- a/android/qa/sc/Makefile
+++ b/android/qa/sc/Makefile
@@ -167,7 +167,7 @@ build-ant: copy-stuff
 install: copy-stuff
unset JAVA_HOME  ant debug install
@echo
-   @echo 'Run it with something like what make run does (see Makefile)'
+   @echo 'Run it with make run'
@echo
 
 uninstall:
commit fe8cd7dba06786923ced29f46e9ee04e7de8240b
Author: Tor Lillqvist tlillqv...@suse.com
Date:   Fri Jan 13 00:39:49 2012 +0200

We now proceed further and need some more libraries

diff --git a/android/qa/sc/Makefile b/android/qa/sc/Makefile
index 3a9faad..da85f08 100644
--- a/android/qa/sc/Makefile
+++ b/android/qa/sc/Makefile
@@ -85,6 +85,8 @@ copy-stuff:
  jvmfwk \
  lnglo \
  localedata_en \
+ localedata_es \
+ localedata_euro \
  localedata_others \
  msfilterlo \
  reg \
@@ -92,6 +94,7 @@ copy-stuff:
  sblo \
  sfxlo \
  sotlo \
+ stocservices.uno \
  store \
  svllo \
  svtlo \
commit 201ade87705c36ce436da8661fb37afd5e064dac
Author: Tor Lillqvist tlillqv...@suse.com
Date:   Thu Jan 12 22:20:38 2012 +0200

[Libreoffice-commits] .: sc/source

[Lior Kaplan]

 sc/source/ui/dbgui/pivot.src |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 4c4c945f00f028a39bc3534f4f707bade677983b
Author: Lior Kaplan kaplanl...@gmail.com
Date:   Fri Jan 13 02:00:16 2012 +0200

Don't mention fields location, as they vary between LTR and RTL interfaces

diff --git a/sc/source/ui/dbgui/pivot.src b/sc/source/ui/dbgui/pivot.src
index 423ea67..f7e7c3e 100644
--- a/sc/source/ui/dbgui/pivot.src
+++ b/sc/source/ui/dbgui/pivot.src
@@ -106,7 +106,7 @@ ModelessDialog RID_SCDLG_PIVOT_LAYOUT
 Pos = MAP_APPFONT ( 6 , 200 ) ;
 Size = MAP_APPFONT ( 182 , 16 ) ;
 WordBreak = TRUE ;
-Text [ en-US ] = Drag the fields from the right into the desired 
position. ;
+Text [ en-US ] = Drag the fields into the desired position. ;
 };
 FixedLine FL_LAYOUT
 {
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - 5 commits - sc/inc sc/qa sc/source

[Kohei Yoshida]

 sc/inc/dpcachetable.hxx  |1 
 sc/inc/dpobject.hxx  |   25 ++
 sc/inc/dpsdbtab.hxx  |5 
 sc/inc/dptablecache.hxx  |   10 +
 sc/qa/unit/ucalc.cxx |   43 +++-
 sc/source/core/data/documen2.cxx |6 
 sc/source/core/data/dpcachetable.cxx |   10 -
 sc/source/core/data/dpobject.cxx |  311 ---
 sc/source/core/data/dpsdbtab.cxx |   15 -
 sc/source/core/data/dpshttab.cxx |7 
 sc/source/core/data/dptablecache.cxx |   18 ++
 sc/source/ui/unoobj/dapiuno.cxx  |   10 -
 sc/source/ui/view/dbfunc3.cxx|   11 +
 13 files changed, 381 insertions(+), 91 deletions(-)

New commits:
commit 6d7fcd016e661c07b664b6c9b454c42c02537f10
Author: Kohei Yoshida kohei.yosh...@suse.com
Date:   Thu Jan 12 21:49:24 2012 -0500

Test the new logic of our pivot data cache life cycle.

diff --git a/sc/inc/dpobject.hxx b/sc/inc/dpobject.hxx
index 685f7d2..47c1999 100644
--- a/sc/inc/dpobject.hxx
+++ b/sc/inc/dpobject.hxx
@@ -271,6 +271,7 @@ public:
 SheetCaches(ScDocument* pDoc);
 bool hasCache(const ScRange rRange) const;
 const ScDPCache* getCache(const ScRange rRange);
+size_t size() const;
 
 void updateReference(
 UpdateRefMode eMode, const ScRange r, SCsCOL nDx, SCsROW nDy, 
SCsTAB nDz);
@@ -294,6 +295,7 @@ public:
 NameCaches(ScDocument* pDoc);
 bool hasCache(const rtl::OUString rName) const;
 const ScDPCache* getCache(const ::rtl::OUString rName, const ScRange 
rRange);
+size_t size() const;
 private:
 void updateCache(const rtl::OUString rName, const ScRange rRange, 
std::setScDPObject* rRefs);
 void removeCache(const ::rtl::OUString rName);
@@ -329,6 +331,8 @@ public:
 public:
 DBCaches(ScDocument* pDoc);
 const ScDPCache* getCache(sal_Int32 nSdbType, const ::rtl::OUString 
rDBName, const ::rtl::OUString rCommand);
+size_t size() const;
+
 private:
 com::sun::star::uno::Referencecom::sun::star::sdbc::XRowSet 
createRowSet(
 sal_Int32 nSdbType, const ::rtl::OUString rDBName, const 
::rtl::OUString rCommand);
diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index d2ebcc2..9b86275 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -1323,6 +1323,7 @@ void Test::testDataPilot()
 bSuccess = checkDPTableOutput5(m_pDoc, aOutRange, aOutputCheck, 
DataPilot table output);
 CPPUNIT_ASSERT_MESSAGE(Table output check failed, bSuccess);
 }
+CPPUNIT_ASSERT_MESSAGE(There should be only one data cache., 
pDPs-GetSheetCaches().size() == 1);
 
 // Update the cell values.
 double aData2[] = { 100, 200, 300, 400, 500, 600 };
@@ -1361,15 +1362,22 @@ void Test::testDataPilot()
 CPPUNIT_ASSERT_MESSAGE(Table output check failed, bSuccess);
 }
 
+CPPUNIT_ASSERT_MESSAGE(There should be only one data cache., 
pDPs-GetSheetCaches().size() == 1);
+
 // Free the first datapilot object after the 2nd one gets reloaded, to
 // prevent the data cache from being deleted before the reload.
 pDPs-FreeTable(pDPObj);
 
+CPPUNIT_ASSERT_MESSAGE(There should be only one data cache., 
pDPs-GetSheetCaches().size() == 1);
+
 // This time clear the cache to refresh the data from the source range.
 CPPUNIT_ASSERT_MESSAGE(This datapilot should be based on sheet data., 
pDPObj2-IsSheetData());
 std::setScDPObject* aRefs;
 sal_uLong nErrId = pDPs-ReloadCache(pDPObj2, aRefs);
-CPPUNIT_ASSERT_MESSAGE(Cache removal failed., nErrId == 0);
+CPPUNIT_ASSERT_MESSAGE(Cache reload failed., nErrId == 0);
+CPPUNIT_ASSERT_MESSAGE(Reloading a cache shouldn't remove any cache.,
+   pDPs-GetSheetCaches().size() == 1);
+
 pDPObj2-ClearSource();
 pDPObj2-Output(aOutRange.aStart);
 
@@ -1395,6 +1403,8 @@ void Test::testDataPilot()
 
 // Swap the two sheets.
 m_pDoc-MoveTab(1, 0);
+CPPUNIT_ASSERT_MESSAGE(Swapping the sheets shouldn't remove the cache.,
+   pDPs-GetSheetCaches().size() == 1);
 CPPUNIT_ASSERT_MESSAGE(Cache should have moved., 
!pDPs-GetSheetCaches().hasCache(aSrcRange));
 aSrcRange.aStart.SetTab(1);
 aSrcRange.aEnd.SetTab(1);
@@ -1404,6 +1414,9 @@ void Test::testDataPilot()
 CPPUNIT_ASSERT_MESSAGE(There shouldn't be any data pilot table stored 
with the document.,
pDPs-GetCount() == 0);
 
+CPPUNIT_ASSERT_MESSAGE(There shouldn't be any more data cache.,
+   pDPs-GetSheetCaches().size() == 0);
+
 m_pDoc-DeleteTab(1);
 m_pDoc-DeleteTab(0);
 }
@@ -1673,6 +1686,9 @@ void Test::testDataPilotNamedSource()
 CPPUNIT_ASSERT_MESSAGE(Table output check failed, bSuccess);
 }
 
+CPPUNIT_ASSERT_MESSAGE(There should be one named range data cache.,
+   pDPs-GetNameCaches().size() == 1  

[Libreoffice-commits] .: 5 commits - sc/inc sc/qa sc/source

[Kohei Yoshida]

 sc/inc/dpcachetable.hxx  |1 
 sc/inc/dpobject.hxx  |   25 ++
 sc/inc/dpsdbtab.hxx  |5 
 sc/inc/dptablecache.hxx  |   10 +
 sc/qa/unit/ucalc.cxx |   43 +++-
 sc/source/core/data/documen2.cxx |6 
 sc/source/core/data/dpcachetable.cxx |   10 -
 sc/source/core/data/dpobject.cxx |  311 ---
 sc/source/core/data/dpsdbtab.cxx |   15 -
 sc/source/core/data/dpshttab.cxx |7 
 sc/source/core/data/dptablecache.cxx |   18 ++
 sc/source/ui/unoobj/dapiuno.cxx  |   10 -
 sc/source/ui/view/dbfunc3.cxx|   11 +
 13 files changed, 381 insertions(+), 91 deletions(-)

New commits:
commit 44cd9971649b9611c59bb3e423133b9a4d82a2fa
Author: Kohei Yoshida kohei.yosh...@suse.com
Date:   Thu Jan 12 21:49:24 2012 -0500

Test the new logic of our pivot data cache life cycle.

diff --git a/sc/inc/dpobject.hxx b/sc/inc/dpobject.hxx
index 685f7d2..47c1999 100644
--- a/sc/inc/dpobject.hxx
+++ b/sc/inc/dpobject.hxx
@@ -271,6 +271,7 @@ public:
 SheetCaches(ScDocument* pDoc);
 bool hasCache(const ScRange rRange) const;
 const ScDPCache* getCache(const ScRange rRange);
+size_t size() const;
 
 void updateReference(
 UpdateRefMode eMode, const ScRange r, SCsCOL nDx, SCsROW nDy, 
SCsTAB nDz);
@@ -294,6 +295,7 @@ public:
 NameCaches(ScDocument* pDoc);
 bool hasCache(const rtl::OUString rName) const;
 const ScDPCache* getCache(const ::rtl::OUString rName, const ScRange 
rRange);
+size_t size() const;
 private:
 void updateCache(const rtl::OUString rName, const ScRange rRange, 
std::setScDPObject* rRefs);
 void removeCache(const ::rtl::OUString rName);
@@ -329,6 +331,8 @@ public:
 public:
 DBCaches(ScDocument* pDoc);
 const ScDPCache* getCache(sal_Int32 nSdbType, const ::rtl::OUString 
rDBName, const ::rtl::OUString rCommand);
+size_t size() const;
+
 private:
 com::sun::star::uno::Referencecom::sun::star::sdbc::XRowSet 
createRowSet(
 sal_Int32 nSdbType, const ::rtl::OUString rDBName, const 
::rtl::OUString rCommand);
diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 88abad3..ad412ef 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -1323,6 +1323,7 @@ void Test::testDataPilot()
 bSuccess = checkDPTableOutput5(m_pDoc, aOutRange, aOutputCheck, 
DataPilot table output);
 CPPUNIT_ASSERT_MESSAGE(Table output check failed, bSuccess);
 }
+CPPUNIT_ASSERT_MESSAGE(There should be only one data cache., 
pDPs-GetSheetCaches().size() == 1);
 
 // Update the cell values.
 double aData2[] = { 100, 200, 300, 400, 500, 600 };
@@ -1361,15 +1362,22 @@ void Test::testDataPilot()
 CPPUNIT_ASSERT_MESSAGE(Table output check failed, bSuccess);
 }
 
+CPPUNIT_ASSERT_MESSAGE(There should be only one data cache., 
pDPs-GetSheetCaches().size() == 1);
+
 // Free the first datapilot object after the 2nd one gets reloaded, to
 // prevent the data cache from being deleted before the reload.
 pDPs-FreeTable(pDPObj);
 
+CPPUNIT_ASSERT_MESSAGE(There should be only one data cache., 
pDPs-GetSheetCaches().size() == 1);
+
 // This time clear the cache to refresh the data from the source range.
 CPPUNIT_ASSERT_MESSAGE(This datapilot should be based on sheet data., 
pDPObj2-IsSheetData());
 std::setScDPObject* aRefs;
 sal_uLong nErrId = pDPs-ReloadCache(pDPObj2, aRefs);
-CPPUNIT_ASSERT_MESSAGE(Cache removal failed., nErrId == 0);
+CPPUNIT_ASSERT_MESSAGE(Cache reload failed., nErrId == 0);
+CPPUNIT_ASSERT_MESSAGE(Reloading a cache shouldn't remove any cache.,
+   pDPs-GetSheetCaches().size() == 1);
+
 pDPObj2-ClearSource();
 pDPObj2-Output(aOutRange.aStart);
 
@@ -1395,6 +1403,8 @@ void Test::testDataPilot()
 
 // Swap the two sheets.
 m_pDoc-MoveTab(1, 0);
+CPPUNIT_ASSERT_MESSAGE(Swapping the sheets shouldn't remove the cache.,
+   pDPs-GetSheetCaches().size() == 1);
 CPPUNIT_ASSERT_MESSAGE(Cache should have moved., 
!pDPs-GetSheetCaches().hasCache(aSrcRange));
 aSrcRange.aStart.SetTab(1);
 aSrcRange.aEnd.SetTab(1);
@@ -1404,6 +1414,9 @@ void Test::testDataPilot()
 CPPUNIT_ASSERT_MESSAGE(There shouldn't be any data pilot table stored 
with the document.,
pDPs-GetCount() == 0);
 
+CPPUNIT_ASSERT_MESSAGE(There shouldn't be any more data cache.,
+   pDPs-GetSheetCaches().size() == 0);
+
 m_pDoc-DeleteTab(1);
 m_pDoc-DeleteTab(0);
 }
@@ -1673,6 +1686,9 @@ void Test::testDataPilotNamedSource()
 CPPUNIT_ASSERT_MESSAGE(Table output check failed, bSuccess);
 }
 
+CPPUNIT_ASSERT_MESSAGE(There should be one named range data cache.,
+   pDPs-GetNameCaches().size() == 1  

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - sc/qa

[Kohei Yoshida]

 sc/qa/unit/ucalc.cxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 4afe80425994cc9933649ed556e5fa6bdff59885
Author: Kohei Yoshida kohei.yosh...@suse.com
Date:   Thu Jan 12 22:06:45 2012 -0500

Removing debug statement.

diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 9b86275..23449b9 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -724,7 +724,6 @@ void testFuncCELL(ScDocument* pDoc)
 for (size_t i = 0; i  SAL_N_ELEMENTS(aChecks); ++i)
 {
 rtl::OUString aVal = pDoc-GetString(0, i, 0);
-cout  CELL:   aVal  endl;
 CPPUNIT_ASSERT_MESSAGE(Unexpected result for CELL, 
aVal.equalsAscii(aChecks[i].pRes));
 }
 }
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: sc/qa

[Kohei Yoshida]

 sc/qa/unit/ucalc.cxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 05fa6914d38abea3c29ab360c62d2f153896798a
Author: Kohei Yoshida kohei.yosh...@suse.com
Date:   Thu Jan 12 22:06:45 2012 -0500

Removing debug statement.

diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index ad412ef..1afe05f 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -724,7 +724,6 @@ void testFuncCELL(ScDocument* pDoc)
 for (size_t i = 0; i  SAL_N_ELEMENTS(aChecks); ++i)
 {
 rtl::OUString aVal = pDoc-GetString(0, i, 0);
-cout  CELL:   aVal  endl;
 CPPUNIT_ASSERT_MESSAGE(Unexpected result for CELL, 
aVal.equalsAscii(aChecks[i].pRes));
 }
 }
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: 2 commits - sw/source

[August Sodora]

 sw/source/ui/envelp/label1.cxx |   28 +++-
 sw/source/ui/envelp/labfmt.cxx |   10 --
 sw/source/ui/inc/initui.hxx|9 +
 sw/source/ui/inc/label.hxx |6 +++---
 sw/source/ui/utlui/initui.cxx  |   35 ++-
 5 files changed, 37 insertions(+), 51 deletions(-)

New commits:
commit dea42954b5e9a22f0d498cad0cc3c373ec5940e8
Author: August Sodora aug...@gmail.com
Date:   Thu Jan 12 21:28:57 2012 -0500

SvStringsDtor-std::vector

diff --git a/sw/source/ui/envelp/label1.cxx b/sw/source/ui/envelp/label1.cxx
index dcf87de..b1bde75 100644
--- a/sw/source/ui/envelp/label1.cxx
+++ b/sw/source/ui/envelp/label1.cxx
@@ -108,10 +108,7 @@ SwLabDlg::SwLabDlg(Window* pParent, const SfxItemSet rSet,
 SfxTabDialog( pParent, SW_RES(DLG_LAB), rSet, sal_False ),
 pNewDBMgr(pDBMgr),
 pPrtPage(0),
-
 aTypeIds( 50, 10 ),
-aMakes  (  5,  0 ),
-
 pRecs   ( new SwLabRecs() ),
 sBusinessCardDlg(SW_RES(ST_BUSINESSCARDDLG)),
 sFormat(SW_RES(ST_FIRSTPAGE_LAB)),
@@ -171,13 +168,13 @@ SwLabDlg::SwLabDlg(Window* pParent, const SfxItemSet 
rSet,
 const rtl::OUString* pMan = rMan.getConstArray();
 for(sal_Int32 nMan = 0; nMan  rMan.getLength(); nMan++)
 {
-aMakes.Insert( new String(pMan[nMan]), aMakes.Count() );
+aMakes.push_back(pMan[nMan]);
 if ( pMan[nMan] == aItem.aLstMake )
 nLstGroup = (sal_uInt16) nMan;
 }
 
-if ( aMakes.Count() )
-_ReplaceGroup( *aMakes[nLstGroup] );
+if ( !aMakes.empty() )
+_ReplaceGroup( aMakes[nLstGroup] );
 
 if (pExampleSet)
 pExampleSet-Put(aItem);
@@ -284,15 +281,15 @@ SwLabPage::SwLabPage(Window* pParent, const SfxItemSet 
rSet) :
 
 InitDatabaseBox();
 
-sal_uInt16 nLstGroup = 0;
+size_t nLstGroup = 0;
 
-const sal_uInt16 nCount = (sal_uInt16)GetParent()-Makes().Count();
-for (sal_uInt16 i = 0; i  nCount; ++i)
+const sal_uInt16 nCount = (sal_uInt16)GetParent()-Makes().size();
+for(size_t i = 0; i  nCount; ++i)
 {
-String rStr = *GetParent()-Makes()[i];
+rtl::OUString rStr = GetParent()-Makes()[i];
 aMakeBox.InsertEntry( rStr );
 
-if ( rStr == String(aItem.aLstMake) )
+if ( rStr == aItem.aLstMake)
 nLstGroup = i;
 }
 
@@ -578,15 +575,12 @@ void SwLabPage::Reset(const SfxItemSet rSet)
 aAddrBox.Check  ( aItem.bAddr );
 aWritingEdit.SetText( aWriting.ConvertLineEnd() );
 
-const sal_uInt16 nCount = (sal_uInt16)GetParent()-Makes().Count();
-for (sal_uInt16 i = 0; i  nCount; ++i)
+for(std::vectorrtl::OUString::const_iterator i = 
GetParent()-Makes().begin(); i != GetParent()-Makes().end(); ++i)
 {
-String rStr = *GetParent()-Makes()[i];
-if(aMakeBox.GetEntryPos(String(rStr)) == LISTBOX_ENTRY_NOTFOUND)
-aMakeBox.InsertEntry( rStr );
+if(aMakeBox.GetEntryPos(String(*i)) == LISTBOX_ENTRY_NOTFOUND)
+aMakeBox.InsertEntry(*i);
 }
 
-
 aMakeBox.SelectEntry( aItem.aMake );
 //save the current type
 String sType(aItem.aType);
diff --git a/sw/source/ui/envelp/labfmt.cxx b/sw/source/ui/envelp/labfmt.cxx
index aac84d8..2aa1e3b 100644
--- a/sw/source/ui/envelp/labfmt.cxx
+++ b/sw/source/ui/envelp/labfmt.cxx
@@ -552,15 +552,13 @@ IMPL_LINK( SwLabFmtPage, SaveHdl, PushButton *, EMPTYARG )
 {
 bModified = sal_False;
 const SequenceOUString rMan = 
GetParent()-GetLabelsConfig().GetManufacturers();
-SvStringsDtor rMakes = GetParent()-Makes();
-if(rMakes.Count()  (sal_uInt16)rMan.getLength())
+std::vectorrtl::OUString rMakes(GetParent()-Makes());
+if(rMakes.size()  (sal_uInt16)rMan.getLength())
 {
-rMakes.DeleteAndDestroy(0, rMakes.Count());
+rMakes.clear();
 const OUString* pMan = rMan.getConstArray();
 for(sal_Int32 nMan = 0; nMan  rMan.getLength(); nMan++)
-{
-rMakes.Insert( new String(pMan[nMan]), rMakes.Count() );
-}
+rMakes.push_back(pMan[nMan]);
 }
 aMakeFI.SetText(aItem.aMake);
 aTypeFI.SetText(aItem.aType);
diff --git a/sw/source/ui/inc/label.hxx b/sw/source/ui/inc/label.hxx
index 1824e49..8d8780a 100644
--- a/sw/source/ui/inc/label.hxx
+++ b/sw/source/ui/inc/label.hxx
@@ -48,7 +48,7 @@ class SwLabDlg : public SfxTabDialog
 SwLabPrtPage*   pPrtPage;
 
 std::vectorsal_uInt16 aTypeIds;
-SvStringsDtor   aMakes;
+std::vectorrtl::OUString aMakes;
 
 SwLabRecs*  pRecs;
 String  aLstGroup;
@@ -74,8 +74,8 @@ public:
   std::vectorsal_uInt16 TypeIds()   { return aTypeIds; }
 const std::vectorsal_uInt16 TypeIds() const { return aTypeIds; }
 
-  SvStringsDtor  Makes() { return aMakes;   }
-const SvStringsDtor  Makes()   const { return aMakes;   }
+std::vectorrtl::OUString Makes() { 

[Libreoffice-commits] .: 2 commits - sw/inc sw/source

[August Sodora]

 sw/inc/doc.hxx |2 +-
 sw/inc/editsh.hxx  |2 +-
 sw/source/core/doc/doc.cxx |6 +++---
 sw/source/core/edit/editsh.cxx |2 +-
 sw/source/core/unocore/unocoll.cxx |4 ++--
 sw/source/ui/fldui/flddinf.cxx |6 +++---
 sw/source/ui/fldui/flddok.cxx  |   18 +-
 sw/source/ui/fldui/fldfunc.cxx |8 
 sw/source/ui/fldui/fldmgr.cxx  |   19 +--
 sw/source/ui/fldui/fldref.cxx  |6 +++---
 sw/source/ui/fldui/fldvar.cxx  |   24 
 sw/source/ui/inc/fldmgr.hxx|3 ++-
 sw/source/ui/utlui/content.cxx |7 +++
 sw/source/ui/utlui/gloslst.cxx |   12 +---
 14 files changed, 58 insertions(+), 61 deletions(-)

New commits:
commit c1400c98ce137dddb252f9759ca9a89ab3452764
Author: August Sodora aug...@gmail.com
Date:   Thu Jan 12 23:15:09 2012 -0500

SvStringsDtor-std::vector

diff --git a/sw/inc/doc.hxx b/sw/inc/doc.hxx
index 11f8cd8..e85ba27 100644
--- a/sw/inc/doc.hxx
+++ b/sw/inc/doc.hxx
@@ -1704,7 +1704,7 @@ public:
 
 // Return names of all references that are set in document.
 // If array pointer is 0 return only whether a RefMark is set in document.
-sal_uInt16 GetRefMarks( SvStringsDtor* = 0 ) const;
+sal_uInt16 GetRefMarks( std::vectorString* = 0 ) const;
 
 // Insert label. If a FlyFormat is created, return it.
 SwFlyFrmFmt* InsertLabel( const SwLabelType eType, const String rTxt, 
const String rSeparator,
diff --git a/sw/inc/editsh.hxx b/sw/inc/editsh.hxx
index 70af368..11e3376 100644
--- a/sw/inc/editsh.hxx
+++ b/sw/inc/editsh.hxx
@@ -741,7 +741,7 @@ public:
 
 //  Return names of all references set in document.
 //  If ArrayPointer == 0 then return only whether a RefMark is set in 
document.
-sal_uInt16 GetRefMarks( SvStringsDtor* = 0 ) const;
+sal_uInt16 GetRefMarks( std::vectorString* = 0 ) const;
 
 // Call AutoCorrect
 void AutoCorrect( SvxAutoCorrect rACorr, sal_Bool bInsertMode = sal_True,
diff --git a/sw/source/core/doc/doc.cxx b/sw/source/core/doc/doc.cxx
index 8be6aa7..8c61466 100644
--- a/sw/source/core/doc/doc.cxx
+++ b/sw/source/core/doc/doc.cxx
@@ -1822,7 +1822,7 @@ const SwFmtRefMark* SwDoc::GetRefMark( sal_uInt16 nIndex 
) const
 // Return the names of all set references in the Doc
 //JP 24.06.96: If the array pointer is 0, then just return whether a RefMark 
is set in the Doc
 // OS 25.06.96: From now on we always return the reference count
-sal_uInt16 SwDoc::GetRefMarks( SvStringsDtor* pNames ) const
+sal_uInt16 SwDoc::GetRefMarks( std::vectorString* pNames ) const
 {
 const SfxPoolItem* pItem;
 const SwTxtRefMark* pTxtRef;
@@ -1836,8 +1836,8 @@ sal_uInt16 SwDoc::GetRefMarks( SvStringsDtor* pNames ) 
const
 {
 if( pNames )
 {
-String* pTmp = new String( 
((SwFmtRefMark*)pItem)-GetRefName() );
-pNames-Insert( pTmp, nCount );
+String pTmp(((SwFmtRefMark*)pItem)-GetRefName());
+pNames-insert(pNames-begin() + nCount, pTmp);
 }
 nCount ++;
 }
diff --git a/sw/source/core/edit/editsh.cxx b/sw/source/core/edit/editsh.cxx
index d984598..41d113a 100644
--- a/sw/source/core/edit/editsh.cxx
+++ b/sw/source/core/edit/editsh.cxx
@@ -519,7 +519,7 @@ const SwFmtRefMark* SwEditShell::GetRefMark( const String 
rName ) const
 }
 
 // returne die Namen aller im Doc gesetzten Referenzen
-sal_uInt16 SwEditShell::GetRefMarks( SvStringsDtor* pStrings ) const
+sal_uInt16 SwEditShell::GetRefMarks( std::vectorString* pStrings ) const
 {
 return GetDoc()-GetRefMarks( pStrings );
 }
diff --git a/sw/source/core/unocore/unocoll.cxx 
b/sw/source/core/unocore/unocoll.cxx
index 36de7ef..4996bd3 100644
--- a/sw/source/core/unocore/unocoll.cxx
+++ b/sw/source/core/unocore/unocoll.cxx
@@ -1948,12 +1948,12 @@ uno::Sequence OUString  
SwXReferenceMarks::getElementNames(void) throw( uno::R
 uno::SequenceOUString aRet;
 if(IsValid())
 {
-SvStringsDtor aStrings;
+std::vectorString aStrings;
 sal_uInt16 nCount = GetDoc()-GetRefMarks( aStrings );
 aRet.realloc(nCount);
 OUString* pNames = aRet.getArray();
 for(sal_uInt16 i = 0; i  nCount; i++)
-pNames[i] = *aStrings.GetObject(i);
+pNames[i] = aStrings[i];
 }
 else
 throw uno::RuntimeException();
diff --git a/sw/source/ui/fldui/flddinf.cxx b/sw/source/ui/fldui/flddinf.cxx
index f89b64b..7160fc2 100644
--- a/sw/source/ui/fldui/flddinf.cxx
+++ b/sw/source/ui/fldui/flddinf.cxx
@@ -139,9 +139,9 @@ void SwFldDokInfPage::Reset(const SfxItemSet )
 nSelEntryData = static_cast sal_uInt16 (sVal.ToInt32());
 }
 
-SvStringsDtor aLst;
+std::vectorString aLst;
 GetFldMgr().GetSubTypes(nTypeId, aLst);
-for (sal_uInt16 i = 0; i  aLst.Count(); ++i)
+for(size_t i = 0; i  aLst.size(); ++i)
 {
 

[Libreoffice-commits] .: sd/CppunitTest_sd_regression_test.mk sd/qa

[Markus Mohrhard]

 sd/CppunitTest_sd_regression_test.mk |  141 
 sd/qa/unit/regression-test.cxx   |  203 +++
 2 files changed, 344 insertions(+)

New commits:
commit 2b2fbf7350cbc53b878a7faf9ab353146fb598bf
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date:   Fri Jan 13 04:30:48 2012 +0100

add test concept for draw/impress, import file and export to svg

the idea behind this concept:
* have a file containing some test data
* import file without UI
* export file to svg through XStorable::storeToURL
* compare exported svg file to a reference file and complain if they
* differ

advantages:
* easy to create test cases, even for non coders
* no special handling of sd internal code needed
* svg is showing differences in the representation and not in the model
* external programs that can be used to check the output
* can be used for all input formats

disadvantages:
* changes to svg filter code might break test cases while the change is
correct
* slow test, import + export
* might need external program for xml diff

diff --git a/sd/CppunitTest_sd_regression_test.mk 
b/sd/CppunitTest_sd_regression_test.mk
new file mode 100644
index 000..85b5c6d
--- /dev/null
+++ b/sd/CppunitTest_sd_regression_test.mk
@@ -0,0 +1,141 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#*
+# Version: MPL 1.1 / GPLv3+ / LGPLv3+
+#
+# The contents of this file are subject to the Mozilla Public License Version
+# 1.1 (the License); you may not use this file except in compliance with
+# the License or as specified alternatively below. You may obtain a copy of
+# the License at http://www.mozilla.org/MPL/
+#
+# Software distributed under the License is distributed on an AS IS basis,
+# WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License
+# for the specific language governing rights and limitations under the
+# License.
+#
+# Major Contributor(s):
+# Copyright (C) 2011 Red Hat, Inc., Caolán McNamara caol...@redhat.com
+#  (initial developer)
+#
+# All Rights Reserved.
+#
+# For minor contributions see the git repository.
+#
+# Alternatively, the contents of this file may be used under the terms of
+# either the GNU General Public License Version 3 or later (the GPLv3+), or
+# the GNU Lesser General Public License Version 3 or later (the LGPLv3+),
+# in which case the provisions of the GPLv3+ or the LGPLv3+ are applicable
+# instead of those above.
+#*
+
+$(eval $(call gb_CppunitTest_CppunitTest,sd_regression_test))
+
+$(eval $(call gb_CppunitTest_add_exception_objects,sd_regression_test, \
+sd/qa/unit/regression-test2 \
+))
+
+$(eval $(call gb_CppunitTest_add_linked_libs,sd_regression_test, \
+avmedia \
+basegfx \
+comphelper \
+cppu \
+cppuhelper \
+drawinglayer \
+editeng \
+fileacc \
+for \
+forui \
+i18nisolang1 \
+msfilter \
+oox \
+sal \
+salhelper \
+sax \
+sd \
+sfx \
+sot \
+svl \
+svt \
+svx \
+svxcore \
+   test \
+tl \
+tk \
+ucbhelper \
+   unotest \
+utl \
+vcl \
+xo \
+   $(gb_STDLIBS) \
+))
+
+$(eval $(call gb_CppunitTest_set_include,sd_regression_test,\
+-I$(realpath $(SRCDIR)/sd/source/ui/inc) \
+-I$(realpath $(SRCDIR)/sd/inc) \
+$$(INCLUDE) \
+-I$(OUTDIR)/inc \
+))
+
+$(eval $(call gb_CppunitTest_add_api,sd_regression_test,\
+offapi \
+udkapi \
+))
+
+$(eval $(call gb_CppunitTest_uses_ure,sd_regression_test))
+
+$(eval $(call gb_CppunitTest_add_type_rdbs,sd_regression_test,\
+types \
+))
+
+$(eval $(call gb_CppunitTest_add_components,sd_regression_test,\
+basic/util/sb \
+comphelper/util/comphelp \
+configmgr/source/configmgr \
+dbaccess/util/dba \
+desktop/source/deployment/deployment \
+fileaccess/source/fileacc \
+filter/source/config/cache/filterconfig1 \
+filter/source/svg/svgfilter \
+forms/util/frm \
+framework/util/fwk \
+i18npool/util/i18npool \
+oox/util/oox \
+package/source/xstor/xstor \
+package/util/package2 \
+sax/source/expatwrap/expwrap \
+sax/source/fastparser/fastsax \
+sd/util/sd \
+sd/util/sdfilt \
+sd/util/sdd \
+sfx2/util/sfx \
+sot/util/sot \
+svl/source/fsstor/fsstorage \
+toolkit/util/tk \
+unotools/util/utl \
+unoxml/source/rdf/unordf \
+unoxml/source/service/unoxml \
+xmlsecurity/util/xsec_fw \
+xmlsecurity/util/xmlsecurity \
+))
+
+$(eval $(call gb_CppunitTest_add_old_components,sd_regression_test,\
+embobj \
+ucb1 \
+ucpexpand1 \
+ucpfile1 \
+ucpgio \
+ucppkg1 \
+ucptdoc1 \
+))
+
+$(eval $(call gb_CppunitTest_set_args,sd_regression_test,\
+--headless \
+--protector 

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - sc/source

[Jan Holesovsky]

 sc/source/core/data/dpsdbtab.cxx |2 +-
 sc/source/core/data/dpshttab.cxx |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit d6f876434ff957ea6b5fd938fb3b779e4527c63f
Author: Jan Holesovsky ke...@suse.cz
Date:   Fri Jan 13 08:57:46 2012 +0100

Fix MinGW build.

diff --git a/sc/source/core/data/dpsdbtab.cxx b/sc/source/core/data/dpsdbtab.cxx
index 1cfa2f8..576beb5 100644
--- a/sc/source/core/data/dpsdbtab.cxx
+++ b/sc/source/core/data/dpsdbtab.cxx
@@ -140,7 +140,7 @@ void ScDatabaseDPData::CreateCacheTable()
 
 if (!aCacheTable.hasCache())
 {
-fprintf(stdout, ScDatabaseDPData::CreateCacheTable:   NOT GOOD!\n);
+OSL_FAIL(Cache table should be created with a live data cache 
instance at all times.);
 // This better not happen!!  Cache table should be created with a live
 // data cache instance at all times.
 return;
diff --git a/sc/source/core/data/dpshttab.cxx b/sc/source/core/data/dpshttab.cxx
index 14a6f7b..8832b23 100644
--- a/sc/source/core/data/dpshttab.cxx
+++ b/sc/source/core/data/dpshttab.cxx
@@ -192,7 +192,7 @@ void ScSheetDPData::CreateCacheTable()
 
 if (!aCacheTable.hasCache())
 {
-fprintf(stdout, ScSheetDPData::CreateCacheTable:   NOT GOOD!!!\n);
+OSL_FAIL(Cache table should be created with a live data cache 
instance at all times.);
 // This better not happen!!  The cache table should be created with a
 // live data cache at all times.
 return;
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [Libreoffice] libvisio: how can I help?

[Fridrich Strba]

Hello,

Thanks for filing the bugs. I really did not see that mistake with 
justified text, since I don't have many documents with justified text 
and since the problem with line-breaks and tabs are still preventing us 
from having the text completely correct and thus, I did not pay 
attention so much to visual differences in the text. Now


On 11/01/12 23:52, Bruno Girin wrote:

I saw you had a look at all of the bugs I filed. Thanks for the
feedback! I will have a go at progressing the arrowhead ones (#44551 and
#44576) and the pattern one (#44552).


Yeah, I flagged them as entry-level tasks because they are reasonably 
contained in one function and can be used for deeper understanding of 
libvisio and its API. Especially the arrowheads should be +/- easy to 
start with since Eilidh did already an initial implementation.



Having said this, it raises a newby question: I have a git clone of the
LO code in one folder and a git clone of the libvisio code in another.
What is the simplest way to build and run LO so that it uses the
libvisio library I'm working on rather than the one that came with it so
that I can test my fixes?


OK, here is what I do:

1) I install the git versions of libwpd/libwpg/libwps/libvisio (and 
libcdr for master builds) in the usual system prefix. For my 64-bit 
system it is --prefix=/usr --libdir=/usr/lib64


2) After that, I configure libreoffice master --with-system-libwpd, 
--with-system-libwpg, --with-system-libwps --with-system-libvisio 
--with-system-libcdr. Like that, once your build is finished and made 
dev-install, it will be using the system libraries that one can rebuild 
and reinstall.


3) For changes in writerperfect module then it is enough to have a 
terminal with sourced environment and after modifying something, just do 
build in the module. The dev-install should be using links to what the 
build produces.


Alternatively, you can build also the writerperfect module from the 
libwpd's git and install it. This will give you a vsd2odg binary that 
will output on your standard output the resulting odg from the 
conversion when called on a visio file:


vsd2odg filename.vsd | xmllint --format -

Because vsd2odt does not produce any line-breaks, so that command 
produces a nice readable xml that LO 3.5 loads nicely.


Don't hesitate to ask more, it allows me to document some things on this 
list. If you feel like that, you can move some of this information 
somewhere on a wiki :) I am a bit too lazy for that :)



Cheers

F.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [REVIEW: 3-4] possible missing translations

[David Tardon]

Hi,

commit 196885980bbb51562264cb5aad9a3e01133d1d7d fixes a situation where
some translated strings may be missing from installation because of a
bug in one of our tools. I would like to see it in 3.4 .

Details:

The fast_merge.pl script creates hierarchy of localize.sdf files (one
per source directory) from sdf files containing all translations for a
language. It reads from the source files by chunks, always all lines
that contain translations for one source file. If the first two source
files in the input sdfs are from different directories, the translations
for the first are lost, because the localize.sdf is created in the
directory of the second file.

It seems that the order of the source files in the input sdfs is random
(but they are grouped per directory), which suggests they are created
by crawling the directory structure in translations/source. This makes
the bug system specific.

See https://bugzilla.redhat.com/show_bug.cgi?id=771108 as an example.
Here the top translations evidently came from
framework/source/classes/resource.src and
framework/source/services/fwk_services.src and translations from the
former were lost.

Note: Miklos tried to fix it before, but unfortunately his fix was not
complete and I reverted it.

D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] Translate German comments

[David Tardon]

On Wed, Jan 11, 2012 at 04:10:36PM +0100, Philipp Weissenbacher wrote:
 Hi lo-devs,
 
 More translations. Business as usual.

Thanks :)

D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Trying to diagnose base running extremely slowly

[Stephan Bergmann]

On 10/20/2011 09:08 AM, Stephan Bergmann wrote:

On 10/19/2011 07:17 PM, Andrew Haley wrote:

On 10/19/2011 05:57 PM, Michael Meeks wrote:


On Wed, 2011-10-19 at 17:32 +0200, Stephan Bergmann wrote:

What the LibO hsqldb code does a lot is call JNI's
Attach/DetachCurrentThread. Googling around,
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6929067 Stack
guard pages should be removed when thread is detached suggests that
reading /proc/self/maps might have been added into
Attach/DetachCurrentThread as part of a bug fix. That would explain
things.


Good catch ! The irony ... :-) this Java bug was kindly fixed for us
indirectly via Andrew Haley to address the bad stack page left around
when
we had run some java. That page was causing crashes in calc formula
computation
in large sheets.

It seems we can't win at some stage here. Andrew - I wonder are other
people getting frustrated by performance here too ? it seems there is
some huge /proc/self/maps thrash as we enter/exit Java now on Linux.


Hmmm, I thought this had been fixed.

See http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6978641


This might still hit us, if the LibO hsqldb code runs in the main thread
(which I'm pretty sure it does). That code calls
Attach/DetachCurrentThread frequently.

I think the best solution here would be to change the LibO hsqldb code,
to call Attach/DetachCurrentThread rarely rather than frequently, but
according to Ocke Janssen (who used to maintain that code) that was no
easy option.


One rather easy fix would be to confine the 
com.sun.star.comp.sdbc.JDBCDriver UNO code to a thread-affine apartment, 
see the attached patch.  That way, all code related to this UNO service 
(which is the code that calls Attach/DetachCurrentThread so frequently 
and thus causes the performance degradation) is run in a single, 
dedicated thread.


That thread is guaranteed not to be the main thread (as the 
thread-affine apartment explicitly creates it), so JVM versions that 
include the fix for 
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6978641 Fix for 
6929067 introduces additional overhead in thread creation/termination 
paths (which significantly reduces the overhead of 
Attach/DetachCurrentThread for all but the main thread again) should 
return to an acceptable performance.  Trying it out on Fedora 16, which 
includes version 1.6.0_22 of OpenJDK, the patch noticeably improves 
performance of the test scenario described at 
https://bugzilla.redhat.com/show_bug.cgi?id=661738#c0.


One drawback of using the thread-affine apartment is that all code 
related to the JDBC driver is effectively serialized, removing any 
potential performance advantage from accessing the driver from multiple 
treads.  I do not know whether that is acceptable or not.


I did not find problems with using the thread-affine apartment, but then 
again my Base skills are virtually non-existent, so this would probably 
need some QA.  However, there is also already another SDBC driver that 
uses the thread-affine apartment, namely the Windows-specific ADO driver 
(com.sun.star.comp.sdbc.ado.ODriver).


Stephan
diff --git a/connectivity/source/drivers/jdbc/exports.dxp b/connectivity/source/drivers/jdbc/exports.dxp
index 7003307..f0e1c69 100755
--- a/connectivity/source/drivers/jdbc/exports.dxp
+++ b/connectivity/source/drivers/jdbc/exports.dxp
@@ -1 +1,2 @@
+component_getImplementationEnvironment
 component_getFactory
diff --git a/connectivity/source/drivers/jdbc/jservices.cxx b/connectivity/source/drivers/jdbc/jservices.cxx
index 59c73ff..85df771 100644
--- a/connectivity/source/drivers/jdbc/jservices.cxx
+++ b/connectivity/source/drivers/jdbc/jservices.cxx
@@ -83,7 +83,21 @@ struct ProviderRequest
 void* getProvider() const { return xRet.get(); }
 };
 
-//---
+extern C SAL_DLLPUBLIC_EXPORT void SAL_CALL
+component_getImplementationEnvironment(
+char const ** ppEnvTypeName, uno_Environment **)
+{
+// Recent Java 6 VMs make calls to JNI Attach/DetachCurrentThread (which
+// this code does extensively) very expensive.  A follow-up JVM fix reduced
+// the overhead significantly again for all threads but the main thread.  So
+// a quick hack to improve performance of this component again is to confine
+// it in the affine apartment (where all code will run on a single,
+// dedicated thread that is guaranteed no to be the main thread).  However,
+// a better fix would still be to redesign the code so that it does not call
+// Attach/DetachCurrentThread so frequently:
+*ppEnvTypeName = CPPU_CURRENT_LANGUAGE_BINDING_NAME :affine;
+}
+
 extern C SAL_DLLPUBLIC_EXPORT void* SAL_CALL component_getFactory(
 const sal_Char* pImplementationName,
 void* pServiceManager,
diff --git a/connectivity/source/drivers/jdbc/makefile.mk b/connectivity/source/drivers/jdbc/makefile.mk
index befdc73..4229c8f 

Re: [Libreoffice] crasher in writer (footer)

[Cedric Bosdonnat]

Hi Michael,

On Tue, 2012-01-10 at 22:28 +0100, Michael Stahl wrote:
 should be fixed now on master and libreoffice-3-5:
 
 http://cgit.freedesktop.org/libreoffice/core/commit/?id=0e898354fc76339a9a007b30f1ebe123981d0426
 
 http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5id=debb4be8886a4c5fd0a714dfd1b53306b836b800

Thank you for fixing that one: I wasn't aware of the root cause of this
one.

--
Cedric

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEWED: 3-4] possible missing translations

[Andras Timar]

Hi David,

2012/1/12 David Tardon dtar...@redhat.com:
 Hi,

 commit 196885980bbb51562264cb5aad9a3e01133d1d7d fixes a situation where
 some translated strings may be missing from installation because of a
 bug in one of our tools. I would like to see it in 3.4 .


+1 from me. I tested your version on 3.4.5 and 3.5 and it worked well.
Please push it.

Best regards,
Andras
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Dumping to valgrind.log from soffice shell script needed?

[Stephan Bergmann]

On 11/11/2011 09:36 AM, Stephan Bergmann wrote:

On 10/26/2011 09:00 PM, Stephan Bergmann wrote:

On 10/26/2011 01:55 PM, Petr Mladek wrote:

What is your preferred way of use?
What exactly do you hate and/or miss?


One problem is output of multiple (batched, like make subsequentcheck)
valgrind'ed invocations of soffice.bin is lost.

Another problem is attaching a debugger (VALGRIND_OPTS=--db-attach=yes)
does not work.


So, meanwhile I had thought that I can somehow live with the
inconvenience the automatic-valgrind.log feature brings, trying to
remember to remove the relevant line from the soffice script in
scenarios where it matters.

But today I had to find out that even a single invocation of the
sw/qa_complex test internally starts multiple soffice instances in a
row, and coming back to a multi-hour valgrind run of that test all I got
was a most unhelpful valgrind.log for a single soffice invocation.

This feature turns out to be a real productivity problem for me after
all. Petr, can you please re-consider whether it is really too much to
ask your clients to type

VALGRIND=memcheck soffice 2valgrind.log

instead of

VALGRIND=memcheck soffice


Removed that feature now, after yet another round of frustrations. 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=4f00cdfec54a574e25f47dab2f65b299ea64ec73


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=37361

Petr Mladek pmla...@suse.cz changed:

   What|Removed |Added

 Depends on||38515

--- Comment #87 from Petr Mladek pmla...@suse.cz 2012-01-12 02:51:48 PST ---
(In reply to comment #82)
 Bug 38515 - LibreOffice crashes in Bibliography dialog when pressing Enter
 – Because it's a crash and has been in LibO at least since 3.4

I crashes even when adding TOC, so let's add it


 Bug 44602 - Modeless Word Count window hides when user clicks into a note
 – Because it's a new feature that doesn't always work as advertised

I think that this one is rather funny than annoying. I think that we do not
need to prioritize it that much.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW-3-5] progressbar for rtf import

[Andras Timar]

Hi Michael,

2012/1/12 Michael Meeks michael.me...@suse.com:
 Hi Miklos,

 On Wed, 2012-01-11 at 21:26 +0100, Miklos Vajna wrote:
 I've implemented a progressbar for rtf import yesterday:

        Nice work ! :-)

 http://cgit.freedesktop.org/libreoffice/core/commit/?id=92c7b6733e55a6ab62bc231ecf0ffd5c0da7c8d2

 There are two bugreports requesting this: fdo#38057 and fdo#44157. The
 second calls this a 3.4 - 3.5 regression, which is true.

        I think we're fairly happy about regressions here given the
 improvements in the code, but it'd be nice to fix for sure.

 What is better - should I cherry-pick this to -3-5, introducing a new
 string to be localized or respect string freeze and ignore this being a
 regression? (It's unfortune that till now I was not aware so far that
 this is a regression, sure.)

        IIRC the translators would need to approve any such break; Andras -
 what review / approval mechanism do we use there ? Given that the exact
 same string Loading Document ... occurs in starmath and writer
 already, I'd hope that they'd be sympathetic :-)

We don't have process for that. The best solution would be, if I
leveraged translation from sw for each language. So translators won't
even notice. What a pity that writerfilter cannot use sw's resources
directly. :)

Best regards,
Andras
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Trying to diagnose base running extremely slowly

[Michael Meeks]

On Thu, 2012-01-12 at 10:44 +0100, Stephan Bergmann wrote:
  I think the best solution here would be to change the LibO hsqldb code,
  to call Attach/DetachCurrentThread rarely rather than frequently, but
  according to Ocke Janssen (who used to maintain that code) that was no
  easy option.
 
 One rather easy fix would be to confine the 
 com.sun.star.comp.sdbc.JDBCDriver UNO code to a thread-affine apartment, 
 see the attached patch.  That way, all code related to this UNO service 
 (which is the code that calls Attach/DetachCurrentThread so frequently 
 and thus causes the performance degradation) is run in a single, 
 dedicated thread.

That sounds like a rather elegant fix to me :-) as long as that thread
is not the main thread - we use rather deep stacks in the calc code
there  this is how the original bug was found etc. it'd be a good fix.

 One drawback of using the thread-affine apartment is that all code 
 related to the JDBC driver is effectively serialized, removing any 
 potential performance advantage from accessing the driver from multiple 
 treads.  I do not know whether that is acceptable or not.

Given the generally tangled locking everywhere I would expect that
virtually everything is serialised anyway ;-) so ...

It'd be great to have a fix for the base guys I guess.

Thanks !

Michael.

-- 
michael.me...@suse.com  , Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] error in writerperfect?

[Ivan Timofeev]

Hi,

glancing over the git-log I have noticed the following code

writerperfect/source/filter/OdgGenerator.cxx:951

if (!propList[libwpg:mime-type]  
propList[libwpg:mime-type]-getStr().len() = 0)

return;

Is there should be || instead of  ?

Regards,
Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] New Tinderbox Linux-RHEL6-x86_64-check

[Stephan Bergmann]

I added a new tinderbox Linux-RHEL6-x86_64-check to 
http://tinderbox.libreoffice.org/MASTER/status.html (and it will spam 
suspects with messages about failing builds in the usual way).


The box does a rather complete build (--enable-binfilter, no 
--with-system switches) and especially enables the debug features 
--enable-dbgutil and --enable-werror.  Additionally, it calls tinbuild2 
with -t switch, i.e., it runs all the subsequent tests via a toplevel 
make check.  The turnaround time is approximately four hours.


make check does still suffer from sporadic soffice.bin failures, but 
the given box appears to run rather stable now.  In the last couple of 
weeks, the vast majority of builds succeeded, and the few that failed 
consistently did so for one of two reasons.


One was the issue (hopefully) fixed now by 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=0e4b36269097f8865bdbc1b9d299a2776ae0cc06 
ScGlobal::GetAutoFormat not always required to create fresh instance.


The other is a sporadic failure of forms_unoapi, an soffice.bin crash 
somewhere underneath



[...]
#12 in SdrPageView::DrawLayer at svx/source/svdraw/svdpagv.cxx:398
#13 in SwViewImp::PaintLayer at sw/source/core/view/vdraw.cxx:148
#14 in SwRootFrm::Paint at sw/source/core/layout/paintfrm.cxx:2976
#15 in ViewShell::Paint at sw/source/core/view/viewsh.cxx:1678
#16 in SwCrsrShell::Paint at sw/source/core/crsr/crsrsh.cxx:1165
#17 in SwEditWin::Paint at sw/source/ui/docvw/edtwin2.cxx:535
#18 in Window::ImplCallPaint at vcl/source/window/window.cxx:2417
#19 in Window::ImplCallPaint at vcl/source/window/window.cxx:2441
#20 in Window::ImplCallPaint at vcl/source/window/window.cxx:2441
#21 in Window::ImplCallPaint at vcl/source/window/window.cxx:2441
#22 in Window::ImplCallPaint at vcl/source/window/window.cxx:2441
#23 in Window::ImplCallPaint at vcl/source/window/window.cxx:2441
#24 in Window::ImplCallPaint at vcl/source/window/window.cxx:2441
#25 in Window::ImplCallOverlapPaint at vcl/source/window/window.cxx:2477
#26 in Window::ImplHandlePaintHdl at vcl/source/window/window.cxx:2497
#27 in Window::LinkStubImplHandlePaintHdl at vcl/source/window/window.cxx:2491
#28 in Link::Call at solver/unxlngx6/inc/tools/link.hxx:140
#29 in Timer::Timeout at vcl/source/app/timer.cxx:256
[...]


on the main thread while an URP thread is simultaneously executing 
SwXTextDocument::close.  Looks like SwXTextDocument::close destroys data 
that is still accessed within SwEditWin::Paint, but I haven't yet come 
around to find the cause here.  (Problem can only be observed 
sporadically, and valgrind didn't help yet.)  I plan to follow up on 
this, however.  Please ignore tinderbox failure mails that are due to 
this crash in the meantime.


The one local change I did to tinbuild2 is


diff --git a/bin/tinbuild_internals.sh b/bin/tinbuild_internals.sh
index e9f4f3d..680aecb 100644
--- a/bin/tinbuild_internals.sh
+++ b/bin/tinbuild_internals.sh
@@ -354,7 +354,8 @@ do_build()
 if [ -n ${last_checkout_date} ] ; then
report_error committer $last_checkout_date `printf 
${report_msgs?}:\n\n` $(cat build_error.
 ==
-$(tail -n50 ${report_log?} | grep -A25 'internal build errors' | grep 'ERROR:' 
)
+Last 400 lines of ${report_log?}:
+$(tail -n400 ${report_log?} )
report_to_tinderbox ${last_checkout_date?} build_failed 
yes
 else
 log_msgs Failed to primed branch '$TINDER_BRANCH'. see 
build_error.log


so that a failing test produces meaningful log output in the failure 
mails (i.e., the last 400 lines of the log, which should be enough to 
include the backtraces from the crashed soffice.bin process, if any).


The state of make check at least for this given box looks rather 
promising, so I would encourage other tinderbox owners to try whether 
adding the -t tinbuild2 switch would work well for their boxes as well.


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] New Tinderbox Linux-RHEL6-x86_64-check

[Michael Stahl]

On 12/01/12 14:44, Stephan Bergmann wrote:
 I added a new tinderbox Linux-RHEL6-x86_64-check to 
 http://tinderbox.libreoffice.org/MASTER/status.html (and it will spam 
 suspects with messages about failing builds in the usual way).
 
 The box does a rather complete build (--enable-binfilter, no 
 --with-system switches) and especially enables the debug features 
 --enable-dbgutil and --enable-werror.  Additionally, it calls tinbuild2 
 with -t switch, i.e., it runs all the subsequent tests via a toplevel 
 make check.  The turnaround time is approximately four hours.

great news!

 The other is a sporadic failure of forms_unoapi, an soffice.bin crash 
 somewhere underneath
 
 [...]
 #12 in SdrPageView::DrawLayer at svx/source/svdraw/svdpagv.cxx:398
 #13 in SwViewImp::PaintLayer at sw/source/core/view/vdraw.cxx:148
 #14 in SwRootFrm::Paint at sw/source/core/layout/paintfrm.cxx:2976
 #15 in ViewShell::Paint at sw/source/core/view/viewsh.cxx:1678
 #16 in SwCrsrShell::Paint at sw/source/core/crsr/crsrsh.cxx:1165
 #17 in SwEditWin::Paint at sw/source/ui/docvw/edtwin2.cxx:535
 #18 in Window::ImplCallPaint at vcl/source/window/window.cxx:2417
 #19 in Window::ImplCallPaint at vcl/source/window/window.cxx:2441
 #20 in Window::ImplCallPaint at vcl/source/window/window.cxx:2441
 #21 in Window::ImplCallPaint at vcl/source/window/window.cxx:2441
 #22 in Window::ImplCallPaint at vcl/source/window/window.cxx:2441
 #23 in Window::ImplCallPaint at vcl/source/window/window.cxx:2441
 #24 in Window::ImplCallPaint at vcl/source/window/window.cxx:2441
 #25 in Window::ImplCallOverlapPaint at vcl/source/window/window.cxx:2477
 #26 in Window::ImplHandlePaintHdl at vcl/source/window/window.cxx:2497
 #27 in Window::LinkStubImplHandlePaintHdl at 
 vcl/source/window/window.cxx:2491
 #28 in Link::Call at solver/unxlngx6/inc/tools/link.hxx:140
 #29 in Timer::Timeout at vcl/source/app/timer.cxx:256
 [...]
 
 on the main thread while an URP thread is simultaneously executing 
 SwXTextDocument::close.  Looks like SwXTextDocument::close destroys data 
 that is still accessed within SwEditWin::Paint, but I haven't yet come 
 around to find the cause here.  (Problem can only be observed 
 sporadically, and valgrind didn't help yet.)  I plan to follow up on 
 this, however.  Please ignore tinderbox failure mails that are due to 
 this crash in the meantime.

sounds bad; that looks like a SolarMutex guard is missing somewhere...

but if that's the only problem we have, then you must have fixed quite a
few bugs :)

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEWED] progressbar for rtf import

[Michael Meeks]

On Thu, 2012-01-12 at 14:11 +0100, Andras Timar wrote:
 We don't have process for that. The best solution would be, if I
 leveraged translation from sw for each language. So translators won't
 even notice. What a pity that writerfilter cannot use sw's resources
 directly. :)

Which sounds to me as if you should push it Miklos, and Andras will
clean up after you ;-)

Thanks !

Michael.

-- 
michael.me...@suse.com  , Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW-3-5] progressbar for rtf import

[Michael Stahl]

On 11/01/12 21:26, Miklos Vajna wrote:
 Hi,
 
 I've implemented a progressbar for rtf import yesterday:
 
 http://cgit.freedesktop.org/libreoffice/core/commit/?id=92c7b6733e55a6ab62bc231ecf0ffd5c0da7c8d2
 
 There are two bugreports requesting this: fdo#38057 and fdo#44157. The
 second calls this a 3.4 - 3.5 regression, which is true.
 
 What is better - should I cherry-pick this to -3-5, introducing a new
 string to be localized or respect string freeze and ignore this being a
 regression? (It's unfortune that till now I was not aware so far that
 this is a regression, sure.)

looks good to me (except that i have no idea how this l10n stuff works)

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=37361

--- Comment #89 from Lionel Elie Mamane lio...@mamane.lu 2012-01-12 06:30:52 
PST ---
Nominate bug 44721: Cannot resize a control with the mouse in Report Builder.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [ANN] LibreOffice 3.5.0 beta3 available

[Thorsten Behrens]

Hi *,

for the upcoming new version 3.5.0, we continue with a beta3 build
that is now feature-complete. For further milestones on the way
towards 3.5.0, please refer to our release plan timings here:

 http://wiki.documentfoundation.org/ReleasePlan#3.5_release

Builds are now being uploaded to a public (but non-mirrored - so don't
spread news too widely!) place, as soon as they're available. Grab
them here:

 http://dev-builds.libreoffice.org/pre-releases/

If you've a bit of time, please give them a try  report *critical*
bugs not yet in bugzilla here, so we can incorporate them into the
release notes. Please note that it takes approximately 24 hours to
populate the mirrors, so that's about the time we have to collect
feedback.

The list of fixed bugs relative to beta2 is here:

 
http://dev-builds.libreoffice.org/pre-releases/src/bugfixes-libreoffice-3-5-release-3.4.99.3.log

So playing with the areas touched there also greatly appreciated - and
validation that those bugs are really fixed.

Thanks a lot for your help,

-- Thorsten


pgpU0pOfbD5NG.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] progressbar for rtf import

[Miklos Vajna]

On Thu, Jan 12, 2012 at 01:59:39PM +, Michael Meeks 
michael.me...@suse.com wrote:
 
 On Thu, 2012-01-12 at 14:11 +0100, Andras Timar wrote:
  We don't have process for that. The best solution would be, if I
  leveraged translation from sw for each language. So translators won't
  even notice. What a pity that writerfilter cannot use sw's resources
  directly. :)
 
   Which sounds to me as if you should push it Miklos

Pushed, thanks for the review.


pgpJhEvtjD6Xo.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] How can we use extensions' plugins ?

[Matúš Kukan]

Hi there,

I was wondering, mainly because there are still problems to compile extensions:

there are two *plugin* directories:
extensions/source/plugin/
 - We build there Library which has pl.component file, so I understand
we can use it.
   There is also Executable for Linux which I guess is called from the
library. This is ok.

extensions/source/nsplugin/
 - Here we also build Executable and Library but how can we use them ?
   Because the library npsoplugin has no .component file associated to it.
   Maybe here the executable loads the library ? But who is running
the executable ?

Thanks,

Matus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=37361

--- Comment #92 from Petr Mladek pmla...@suse.cz 2012-01-12 07:37:43 PST ---
I understand it the way that all bugs are kind of nominated because they could
be added and removed from the dependencies at any time if there are good
reasons.

I think that the main confusion is whether to update bug dependencies together
with the explanation comment or wait for someone to accept it.

My suggestion is to update dependencies immediately if you are pretty sure that
it is annoying for many users. You could just leave a comment if you are not
sure.
It is how it works now and I think that it works well.

I agree with Rainer that we do not want long discussions about every bug. Most
people nominate reasonable bugs. This is why the initial comment suggest to add
the dependency immediately.

By other words, both approaches are good. You can't do a mistake :-)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [REVIEW][3-4] date change regression fdo#44385

[Noel Power]

Be good to get this in, afaict this shouldn't cause any problems
see attached patch

Noel
From 778c2ad1225ee3d1e9ac40ab584d8f5f428845fe Mon Sep 17 00:00:00 2001
From: Noel Power noel.po...@novell.com
Date: Thu, 12 Jan 2012 15:46:52 +
Subject: [PATCH] restore special DATE handling code for SbxValue::Compute 
fdo#44385

restore code that seemed to be erroneously moved as part of the currency 
enhancement feature
---
 basic/source/sbx/sbxvalue.cxx |6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/basic/source/sbx/sbxvalue.cxx b/basic/source/sbx/sbxvalue.cxx
index e21234c..39dfadb 100644
--- a/basic/source/sbx/sbxvalue.cxx
+++ b/basic/source/sbx/sbxvalue.cxx
@@ -1311,9 +1311,6 @@ Lbl_OpIsDouble:
 else aL.nDouble /= aR.nDouble; break;
 case SbxPLUS:
 aL.nDouble += aR.nDouble; break;
-// #45465 Date needs with + a special handling: 
forces date type
-if( GetType() == SbxDATE || rOp.GetType() == 
SbxDATE )
-aL.eType = SbxDATE;
 case SbxMINUS:
 aL.nDouble -= aR.nDouble; break;
 case SbxNEG:
@@ -1321,6 +1318,9 @@ Lbl_OpIsDouble:
 default:
 SetError( SbxERR_NOTIMP );
 }
+// #45465 Date needs with + a special handling: forces 
date type
+if( GetType() == SbxDATE || rOp.GetType() == SbxDATE )
+aL.eType = SbxDATE;
 
 }
 }
-- 
1.7.3.4

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Replace getLength() with isEmpty() in vcl/generic/fontmanager

[Olivier Hallot]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Thank you Christina for the patch.

It look like your patch is ok, with respect to the logic inversion. A
build should indicate if the method isEmpty() is valid for the right
object (e.g. it is not valid for OUStringBuffer or Sequence).

Do you mind to
1) update bug fdo43460 with your (pushed) patch?

2) complete module vcl/ with these replacements? I will mark it as yours
in my control file. Attached an exerpt of the files and lines to look at.

Regards

Olivier


Em 12-01-2012 12:29, Chr. Rossmanith escreveu:
 Hi,
 
 while replacing ByteString with OString I came across some getLength()
 calls which might be replaced with isEmpty(). Hope Olivier won't be
 annoyed  :-)
 
 Some reviewing would be nice to be sure the logic didn't get inverted
 accidently.I have git push access - so reviewing would be sufficient.
 
 Christina
 
 
 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice

- -- 
Olivier Hallot
Founder, Board of Directors Member - The Document Foundation
LibreOffice translation leader for Brazilian Portuguese
+55-21-8822-8812
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPDwehAAoJEJp3R7nH3vLxl3cH/0qtyGFDI44WaSWr5XVKgU7n
oGzqcz/DBAuaDRr7NZnHp2rerAXNur1r6M1gVL+yyO/DsLxwnDdUAQsUdwcZspzR
zckK5D8l9q6oD/+o16Ismr5/r+E9Fn5Jz/MH+ER+nqslZe5k138eJZH2L5KrwR7i
J1Uq5ZIZHa+Q9+aWCBeRVpb8RU+VnBx2nVBUQ98ovQ/ShDCE3SNGOwNSQAQtz8si
LzXd4MfTmFZJSk4DwlTXXOAoXcYn6rwRdxr2DsyOa/faOeBwWrBVLrKfGN4Bl1rn
MYEDLvQqZQ7T3FHik4aOHVUmvfYvJKaP1X+oAcHgM5WJpHhYmURf1wAMY8QgrI4=
=tufN
-END PGP SIGNATURE-
/data/lo/core/vcl/generic/app/gensys.cxx:159:9: note: [EmptyLength plugin] 
replace getLength() != 0 with !isEmpty()
/data/lo/core/vcl/generic/fontmanager/fontcache.cxx:179:21: note: [EmptyLength 
plugin] replace getLength() != 0 with !isEmpty()
/data/lo/core/vcl/generic/fontmanager/fontcache.cxx:236:17: note: [EmptyLength 
plugin] replace getLength() != 0 with !isEmpty()
/data/lo/core/vcl/generic/fontmanager/fontconfig.cxx:1003:5: note: [EmptyLength 
plugin] replace getLength() != 0 with !isEmpty()
/data/lo/core/vcl/generic/fontmanager/fontconfig.cxx:767:5: note: [EmptyLength 
plugin] replace getLength() != 0 with !isEmpty()
/data/lo/core/vcl/generic/fontmanager/fontconfig.cxx:778:5: note: [EmptyLength 
plugin] replace getLength() != 0 with !isEmpty()
/data/lo/core/vcl/generic/fontmanager/fontconfig.cxx:856:13: note: [EmptyLength 
plugin] replace getLength()  0 with !isEmpty()
/data/lo/core/vcl/generic/fontmanager/fontconfig.cxx:921:5: note: [EmptyLength 
plugin] replace getLength() != 0 with !isEmpty()
/data/lo/core/vcl/generic/fontmanager/fontconfig.cxx:988:5: note: [EmptyLength 
plugin] replace getLength() != 0 with !isEmpty()
/data/lo/core/vcl/generic/fontmanager/fontconfig.cxx:992:9: note: [EmptyLength 
plugin] replace getLength() != 0 with !isEmpty()
/data/lo/core/vcl/generic/fontmanager/fontconfig.cxx:999:5: note: [EmptyLength 
plugin] replace getLength() != 0 with !isEmpty()
/data/lo/core/vcl/generic/fontmanager/fontmanager.cxx:1697:9: note: 
[EmptyLength plugin] replace getLength() != 0 with !isEmpty()
/data/lo/core/vcl/generic/fontmanager/fontmanager.cxx:1702:9: note: 
[EmptyLength plugin] replace getLength() != 0 with !isEmpty()
/data/lo/core/vcl/generic/fontmanager/fontmanager.cxx:1898:5: note: 
[EmptyLength plugin] replace getLength() != 0 with !isEmpty()
/data/lo/core/vcl/generic/fontmanager/fontmanager.cxx:1949:13: note: 
[EmptyLength plugin] replace getLength() != 0 with !isEmpty()
/data/lo/core/vcl/generic/fontmanager/fontmanager.cxx:2165:5: note: 
[EmptyLength plugin] replace getLength() != 0 with !isEmpty()
/data/lo/core/vcl/generic/fontmanager/fontmanager.cxx:2174:13: note: 
[EmptyLength plugin] replace getLength() == 0 with isEmpty()
/data/lo/core/vcl/generic/fontmanager/fontmanager.cxx:3281:17: note: 
[EmptyLength plugin] replace getLength() != 0 with !isEmpty()
/data/lo/core/vcl/generic/fontmanager/fontmanager.cxx:3447:5: note: 
[EmptyLength plugin] replace getLength() == 0 with isEmpty()
/data/lo/core/vcl/generic/fontmanager/fontmanager.cxx:3497:13: note: 
[EmptyLength plugin] replace getLength() != 0 with !isEmpty()
/data/lo/core/vcl/generic/fontmanager/fontmanager.cxx:3573:17: note: 
[EmptyLength plugin] replace getLength() != 0 with !isEmpty()
/data/lo/core/vcl/generic/fontmanager/fontmanager.cxx:792:9: note: [EmptyLength 
plugin] replace getLength() == 0 with isEmpty()
/data/lo/core/vcl/generic/fontmanager/fontmanager.cxx:806:5: note: [EmptyLength 
plugin] replace getLength() == 0 with isEmpty()
/data/lo/core/vcl/generic/fontmanager/helper.cxx:160:9: note: [EmptyLength 
plugin] replace getLength() == 0 with isEmpty()
/data/lo/core/vcl/generic/fontmanager/helper.cxx:204:5: note: [EmptyLength 
plugin] replace getLength() == 0 with isEmpty()

[Libreoffice] minutes of ESC call ...

[Michael Meeks]

* Present:
+ Lionel, Tor, Michael, Eike, Norbert, Stephan,
  David, Fridrich, Rainer, Christian, Petr, Andras,
  Kohei, Thorsten, Mitch

* Completed Action Items
+ add postgresql to 3.5 feature page (Lionel)
+ make it clear the SAL_INFO etc. macros are internal only for 3.5 
(Stephan)
+ checking pg baseline on windows (Fridrich)
+ FOSDEM: add slot to be filed talk (Stephan)
+ FOSDEM: add Internal structure of calc talk (Eike)
+ FOSDEM: add easy hacks talk (Michael)
+ poke fdo bugzilla hero Tollef wrt. performance (Michael)
+ major hardware upgrade planned soon.
+ cleanup old test build server directories (Thorsten)
+ WONTFIX fdo#... in pleasant way (Thorsten)
+ qa list incomplete, or updating slowly on gmane, poke Florian 
(Thorsten)
+ unknown transient issue apparently gone.
+ qa heros issues (Michael)
+ needs a new bugzilla extension, wait a bit.

* Pending Action Items
+ add tinderbox name to build-id (Norbert)
+ [slow progress] extract 64bit build hardware from firewall (Kendy / 
Admins)
+ get a permanant re-direction link for bug assistent (Thorsten)
+ hack up the Help-File bug menu item (Thorsten)
+ rename VCL API to make it GetBeamerFoo  fix (Michael)
+ include slowchecks into tail_build's Makefile (Markus?)

* Action Items review

* Release Engineering update (Petr)
+ 3.4.5 status
+ bit delayed by Christmas catchup
+ blocker proposed, investigated but not a regression
+ scheduled to be announced shortly, pending marketing input
+ 3.5.0 status
+ pre-release Beta 3 builds up-loaded
+ blocked by getting 3.4.5 out first
+ hope to have it out by Saturday

 Hard English string  UI freeze - in effect now 

+ After Monday/Tuesday's RC1 tag need a 2nd review

 From Monday 16th - one extra pair of eyes needed per commit 

+ the future:
+ 2x extra patch reviewers starts at RC2
+ 3x extra patch reviewers starts at RC3
+ lots of bugs being fixed - please continue !

* Mechanism for asking Translators permission for string freeze breakage ?
+ how many translators to ask (Andras?)
+ previous rule was bug fixes that required them were ok
+ rule: if the bug is more serious than a broken translation ? (Petr)
+ potentially in point-zero releases less serious (Petr?)
+ Decided - ask: l...@global.libreoffice.org for approval in future

* QA update (Rainer)
+ Windows 8 problem
+ running under Virtualbox, can be reproduced
+ Bugzilla updates sorted out with Thorsten
+ status of permanent re-direction link for assistant ?
+ admins need to be told what link they want
+ create link in a couple of minutes,
  ver+os+ as parameters to allow re-direction of
  old versions.
AA: + create http://hub.libreoffice.org/file-a-bug/ (Christian)
+ unreviewed bugs
+ stopped the trend of unchecked bugs increasing
+ lots of bug-fixes coming in
+ very good situation

* ICU size shrink - save 4Mb ... (Eike)
+ great, but prolly not ready for 3.5.0

* Mitch / MSI building update
+ vacation since the last meeting
+ pushed-back by another high-prio project
+ two week delay expected

* FOSDEM dev-room schedule
+ tons of talks, not much time - maximum time slot 30mins
+ program still under discussion, for publication decision soon.

* all bugs created by LibO considered invalid by MS Office
+ we do the right thing: putting 1.2 in the manifest version (Thorsten)
+ recent bug-fix in a 3.4 CWS
+ ODF 1.2 makes the version mandatory, and must have value=1.2
+ if it is seen, MS Office will claim it is invalid.
+ it's not possible for us to write valid ODF 1.2 docs about
  which MS Office doesn't complain
+ MS Office offers to 'repair'  import it
+ that looks scary.
+ it's not our bug
+ Need to release-note this:
+ avoid recommending the legacy 1.1 format due to
  data loss concerns

* 3.5 most annoying bugs ...
+ 23 open (of 71 total)
+ 
https://bugs.freedesktop.org/showdependencytree.cgi?id=37361hide_resolved=1

-- 
michael.me...@suse.com  , Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Replace getLength() with isEmpty() in vcl/generic/fontmanager

[Chr. Rossmanith]

Am 12.01.2012 17:17, schrieb Olivier Hallot:

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Thank you Christina for the patch.

It look like your patch is ok, with respect to the logic inversion. A
build should indicate if the method isEmpty() is valid for the right
object (e.g. it is not valid for OUStringBuffer or Sequence).
I've built it successfully and found out that O(U)StringBuffer has no 
isEmpty() this morning  :-)

Do you mind to
1) update bug fdo43460 with your (pushed) patch?
You mean just add an comment which mentions the directory I've been 
working in? Of course can I do that. When I'm finished with vcl or 
already now with that little bit?

2) complete module vcl/ with these replacements? I will mark it as yours
in my control file. Attached an exerpt of the files and lines to look at.

As time permits. Probably interleaved with the ByteString replacement.

Christina


Regards

Olivier


Em 12-01-2012 12:29, Chr. Rossmanith escreveu:

Hi,

while replacing ByteString with OString I came across some getLength()
calls which might be replaced with isEmpty(). Hope Olivier won't be
annoyed  :-)

Some reviewing would be nice to be sure the logic didn't get inverted
accidently.I have git push access - so reviewing would be sufficient.

Christina


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
- -- 
Olivier Hallot

Founder, Board of Directors Member - The Document Foundation
LibreOffice translation leader for Brazilian Portuguese
+55-21-8822-8812
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPDwehAAoJEJp3R7nH3vLxl3cH/0qtyGFDI44WaSWr5XVKgU7n
oGzqcz/DBAuaDRr7NZnHp2rerAXNur1r6M1gVL+yyO/DsLxwnDdUAQsUdwcZspzR
zckK5D8l9q6oD/+o16Ismr5/r+E9Fn5Jz/MH+ER+nqslZe5k138eJZH2L5KrwR7i
J1Uq5ZIZHa+Q9+aWCBeRVpb8RU+VnBx2nVBUQ98ovQ/ShDCE3SNGOwNSQAQtz8si
LzXd4MfTmFZJSk4DwlTXXOAoXcYn6rwRdxr2DsyOa/faOeBwWrBVLrKfGN4Bl1rn
MYEDLvQqZQ7T3FHik4aOHVUmvfYvJKaP1X+oAcHgM5WJpHhYmURf1wAMY8QgrI4=
=tufN
-END PGP SIGNATURE-


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Dumping to valgrind.log from soffice shell script needed?

[Petr Mladek]

Stephan Bergmann píše v Čt 12. 01. 2012 v 11:37 +0100:
 On 11/11/2011 09:36 AM, Stephan Bergmann wrote:
  On 10/26/2011 09:00 PM, Stephan Bergmann wrote:
  But today I had to find out that even a single invocation of the
  sw/qa_complex test internally starts multiple soffice instances in a
  row, and coming back to a multi-hour valgrind run of that test all I got
  was a most unhelpful valgrind.log for a single soffice invocation.
 
  This feature turns out to be a real productivity problem for me after
  all. Petr, can you please re-consider whether it is really too much to
  ask your clients to type

Ah, I am sorry for the troubles. I have somehow missed this mail. You
probably did not keep me in CC and I overlooked it on the mailing
list :-(


  VALGRIND=memcheck soffice 2valgrind.log
 
  instead of
 
  VALGRIND=memcheck soffice
 
 Removed that feature now, after yet another round of frustrations. 
 http://cgit.freedesktop.org/libreoffice/core/commit/?id=4f00cdfec54a574e25f47dab2f65b299ea64ec73

I think that the main problem is that valgrind is invoked two ways,
either by exporting the variable VALGRIND or using the --valgrind option

The variable was introduced to make debugging easier when running unit-
and subsequent-test. The option was introduced for normal users.

What about the following solution:

+ print log on the standart output when invoking via the variable
+ print to valgrind.log when using the --valgrind option


Would it fit your needs?


Best Regards,
Petr

PS: I wonder why I did not get this idea earlier.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Replace getLength() with isEmpty() in vcl/generic/fontmanager

[Olivier Hallot]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hi Christina

Em 12-01-2012 14:30, Chr. Rossmanith escreveu:
 Am 12.01.2012 17:17, schrieb Olivier Hallot:
 
 1) update bug fdo43460 with your (pushed) patch?
 You mean just add an comment which mentions the directory I've been
 working in? Of course can I do that. When I'm finished with vcl or
 already now with that little bit?

It is up to you, really. It is only for the records.

 2) complete module vcl/ with these replacements? I will mark it as yours
 in my control file. Attached an exerpt of the files and lines to look at.

 As time permits. Probably interleaved with the ByteString replacement.

Please do it at your earliest and comfortable convenience. I leave vcl
to you.

Thank you for helping me.

Kind regards
- -- 
Olivier Hallot
Founder, Board of Directors Member - The Document Foundation
LibreOffice translation leader for Brazilian Portuguese
+55-21-8822-8812
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPDxZKAAoJEJp3R7nH3vLxKYIH/08sEao2BRkRzunDXQWU/alO
nI3AiKOtWXOUjbIEn9fZuJb6EQCOC/C0jsRhBDvBuAXyjZ2aq+t2XVglrxzrYlZ3
iMWT/VatngZn1m+qPUzN735jPivgQiWenyS/3vOY3U0AvW41NSWu5yh9/fq2mePY
fvfNd043kr7O7qhRbvA+Kbo5L0x9n/h9p69RbRh+ahavbtcNHL87WWSDbjP8FUTK
RuuOvum8/DXLbABxq2jgqVeq2x/zl603DrG+xdW22FkbQowakKssd2BGjM2r9ty/
GvdWIjbnkVMI6abC47fU4b5fo00Vgwqhlhz18MgM1dZ6dWIQWgG9WkHtZLY+yNU=
=3ph4
-END PGP SIGNATURE-
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW][3-4] fdo#44078 boxes shown for glyph fallback with DejaVu Sans ExtraLight (he/ar)

[Kohei Yoshida]

On Thu, 2012-01-12 at 11:08 +, Caolán McNamara wrote:
 We probably need a wiki dashboard

Perhaps we could add such info to this wiki page:

http://wiki.documentfoundation.org/Development/Patch_Handling_Guideline

Best,

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] minutes of ESC call ...

[Petr Mladek]

Michael Meeks píše v Čt 12. 01. 2012 v 16:23 +:
  Hard English string  UI freeze - in effect now 
 
   + After Monday/Tuesday's RC1 tag need a 2nd review

It means to ask for one review/approval on the
libreoffice@lists.freedesktop.org mailing list before cherry-pikcing
from master.

This is the usual rule for the libreoffice-A-X branches as described at
http://wiki.documentfoundation.org/Development/Branches


  From Monday 16th - one extra pair of eyes needed per commit 
 
   + the future:
   + 2x extra patch reviewers starts at RC2

We will create the libreoffice-3-5-0 from the tag for 3.5.0-rc2 (about
Jan 24). So, these is the usual rule for libreoffice-A-X-Y branches as
described at http://wiki.documentfoundation.org/Development/Branches


   + 3x extra patch reviewers starts at RC3

rc3 should be final, so there won't be this extra level of review.


I am sorry if I explained it a confusing way on the TSC call. I hope
that the above comments make it more clear :-)


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] How can we use extensions' plugins ?

[Petr Mladek]

Matúš Kukan píše v Čt 12. 01. 2012 v 16:32 +0100:
 Hi there,
 
 I was wondering, mainly because there are still problems to compile 
 extensions:
 
 there are two *plugin* directories:
 extensions/source/plugin/
 extensions/source/nsplugin/
  - Here we also build Executable and Library but how can we use them ?
Because the library npsoplugin has no .component file associated to it.

You might enable it from inside LO by the checkbox
Tools/Options/Internet/Browser Plug-in/Display documents in browser

AFAIK, you might also enable it for all users when you symlink
libnpsoplugin.so into the mozilla plugin directory. I guess that the
standard path is /usr/lib/browser-plugins.

The result is that it will display LO documents inside the browser
window. It even shows a simple menu that allows basic operations with
the document.

I do not have good experiences with it. Sometimes it showed blank
documents instead of the real one. It slowed down the browser. I had
troubles to save the original document on disk.


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=37361

Kohei Yoshida kohei.yosh...@gmail.com changed:

   What|Removed |Added

 Depends on|37860   |

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Dumping to valgrind.log from soffice shell script needed?

[August Sodora]

Does it make sense to do --log-file=valgrind.out.%p ?

August Sodora
aug...@gmail.com
(201) 280-8138



On Thu, Jan 12, 2012 at 11:46 AM, Petr Mladek pmla...@suse.cz wrote:
 Stephan Bergmann píše v Čt 12. 01. 2012 v 11:37 +0100:
 On 11/11/2011 09:36 AM, Stephan Bergmann wrote:
  On 10/26/2011 09:00 PM, Stephan Bergmann wrote:
  But today I had to find out that even a single invocation of the
  sw/qa_complex test internally starts multiple soffice instances in a
  row, and coming back to a multi-hour valgrind run of that test all I got
  was a most unhelpful valgrind.log for a single soffice invocation.
 
  This feature turns out to be a real productivity problem for me after
  all. Petr, can you please re-consider whether it is really too much to
  ask your clients to type

 Ah, I am sorry for the troubles. I have somehow missed this mail. You
 probably did not keep me in CC and I overlooked it on the mailing
 list :-(


  VALGRIND=memcheck soffice 2valgrind.log
 
  instead of
 
  VALGRIND=memcheck soffice

 Removed that feature now, after yet another round of frustrations.
 http://cgit.freedesktop.org/libreoffice/core/commit/?id=4f00cdfec54a574e25f47dab2f65b299ea64ec73

 I think that the main problem is that valgrind is invoked two ways,
 either by exporting the variable VALGRIND or using the --valgrind option

 The variable was introduced to make debugging easier when running unit-
 and subsequent-test. The option was introduced for normal users.

 What about the following solution:

 + print log on the standart output when invoking via the variable
 + print to valgrind.log when using the --valgrind option


 Would it fit your needs?


 Best Regards,
 Petr

 PS: I wonder why I did not get this idea earlier.

 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Libreoffice-qa] 3.5.0 QA ... from BHS 1 to BHS 2

[Cor Nouws]

Hi all,

Cor Nouws wrote (09-01-12 23:10)


Find mentors officially and don't rely on people to show up for the
second one. It did work out on the first session, but esp. for the
follow-up event it should be sure that mentors are around.


I agree with that.


Are there people that can help with this?

--
 - Cor
 - http://nl.libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] FATToVFat_Impl: desktop/source/app/appsys.*: windows

[Caolán McNamara]

These can be removed right ?, I mean, I don't see any use of them
anywhere or anything using appsys.hxx, so appsys.hxx and appsys.cxx
could be completely removed as far as I can see.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW][3-4] date change regression fdo#44385

[Michael Stahl]

On 12/01/12 16:55, Noel Power wrote:
 Be good to get this in, afaict this shouldn't cause any problems
 see attached patch
 
 Noel

looking at the change, i notice that now it is independent of the
operation being performed, while the code that was originally removed in
adcba12537d047f5ad65334b65512615311cf872 checked for addition only (as
the comment says):

 -// #45465 Date needs with + a special handling
 -if( eOp == SbxPLUS  (GetType() == SbxDATE || 
 rOp.GetType() == SbxDATE ) )
 -aL.eType = SbxDATE;

is that intentional?

i'm +1 for putting the original change back, and perhaps also for your
changed variant if you have a good explanation :)

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] prevent the creation of lockfiles during unit tests

[Markus Mohrhard]

Hey,

I finally found a solution to the lockfile problem. The attached patch
prevents lockfiles during unit tests.

I did not push that patch directly because I'm not sure if we really
want to introduce another registry entry for this.

If this is the correct patch i would like to push that to master and
3-5 to prevent test failures because of old lockfiles. This brings us
now one step closer to a read-only source tree.

Regards,
Markus
From 2fe17e493046b9ecb58e3886d1f8cd27250f32b5 Mon Sep 17 00:00:00 2001
From: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Fri, 13 Jan 2012 03:34:28 +0100
Subject: [PATCH] don't create lock files for unit tests

special thanks to Stephan for the configuration part
---
 .../schema/org/openoffice/Office/Common.xcs|7 
 sfx2/source/doc/docfile.cxx|   30 
 test/user-template/registry/modifications.xcd  |   10 ++
 3 files changed, 47 insertions(+), 0 deletions(-)

diff --git a/officecfg/registry/schema/org/openoffice/Office/Common.xcs b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
index 2cee667..c74e508 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Common.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
@@ -6269,6 +6269,13 @@
 /info
 valuetrue/value
   /prop
+  prop oor:name=UseLocking oor:type=xs:boolean
+info
+  descAllows to specify whether locking should be used at all.
+  Use this setting only for debugging purpose./desc
+/info
+valuetrue/value
+  /prop
   prop oor:name=ShowLinkWarningDialog oor:type=xs:boolean
 info
   authorTHB/author
diff --git a/sfx2/source/doc/docfile.cxx b/sfx2/source/doc/docfile.cxx
index 0332493..6d06057 100644
--- a/sfx2/source/doc/docfile.cxx
+++ b/sfx2/source/doc/docfile.cxx
@@ -204,6 +204,31 @@ sal_Bool IsOOoLockFileUsed()
 return bOOoLockFileUsed;
 }
 
+bool IsLockingUsed()
+{
+bool bLocking = true;
+try
+{
+
+uno::Reference uno::XInterface  xCommonConfig = ::comphelper::ConfigurationHelper::openConfig(
+::comphelper::getProcessServiceFactory(),
+::rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( /org.openoffice.Office.Common ) ),
+::comphelper::ConfigurationHelper::E_STANDARD );
+if ( !xCommonConfig.is() )
+throw uno::RuntimeException();
+
+::comphelper::ConfigurationHelper::readRelativeKey(
+xCommonConfig,
+::rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( Misc/ ) ),
+::rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( UseLocking ) ) ) = bLocking;
+}
+catch( const uno::Exception )
+{
+}
+
+return bLocking;
+}
+
 } // anonymous namespace
 //==
 
@@ -998,6 +1023,11 @@ sal_Bool SfxMedium::LockOrigFileOnDemand( sal_Bool bLoading, sal_Bool bNoUI )
 // if user cancel the loading the ERROR_ABORT is set
 sal_Bool bResult = sal_False;
 
+if (!IsLockingUsed())
+{
+return sal_True;
+}
+
 if ( !GetURLObject().HasError() ) try
 {
 if ( pImp-m_bLocked  bLoading  ::utl::LocalFileHelper::IsLocalFile( GetURLObject().GetMainURL( INetURLObject::NO_DECODE ) ) )
diff --git a/test/user-template/registry/modifications.xcd b/test/user-template/registry/modifications.xcd
index d323645..87cacf7 100644
--- a/test/user-template/registry/modifications.xcd
+++ b/test/user-template/registry/modifications.xcd
@@ -27,6 +27,16 @@
  * instead of those above.
 --
 oor:data xmlns:oor=http://openoffice.org/2001/registry;
+ oor:component-data oor:name=Common oor:package=org.openoffice.Office
+  node oor:name=Misc
+prop oor:name=UseDocumentSystemFileLocking
+  valuefalse/value
+/prop
+prop oor:name=UseDocumentOOoLockFile
+  valuefalse/value
+/prop
+  /node
+ /oor:component-data
  oor:component-data oor:name=Paths oor:package=org.openoffice.Office
   node oor:name=Paths
node oor:name=UIConfig oor:op=replace
-- 
1.7.7

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] unit test concept for draw/impress

[Markus Mohrhard]

Hey,

I finally found some time working on a unit test concept for
draw/impress as promised to Thorsten in Paris. (see [1])

The attached patch enables the new test concept in sd. The test is
based on calc's filters-test concept but needs to do some additional
steps.

We take a import file (e.g. an ppt file) and import it into impress,
and in the next step export it to svg. The advantage of the svg file
is that it represents the visual representation extremely good and we
ca easily compare it againts an reference svg file. I hope that this
approach allows us to easily find changes that break features and
change the visual representation of files.

I listed some advantages and disadvantages of this concept in my
commit message. Please feel free to comment my idea.

I have not yet implemented the last step, comparing the exported file
to a reference file but that should be a minor problem. Use the
attached patch to enable the and check my idea. The current test
should take sd/qa/unit/data/a.pptx and export it to
solver/platform/unittest/sd/test2.svg

Regards,
Markus

[1] 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=2b2fbf7350cbc53b878a7faf9ab353146fb598bf
From 7950b170ebedb2e0e64c3f4065577aa0184bcb85 Mon Sep 17 00:00:00 2001
From: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Fri, 13 Jan 2012 05:02:31 +0100
Subject: [PATCH] enable sd's regression test

---
 sd/Module_sd.mk |1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sd/Module_sd.mk b/sd/Module_sd.mk
index 4fd3a95..ba86665 100644
--- a/sd/Module_sd.mk
+++ b/sd/Module_sd.mk
@@ -42,6 +42,7 @@ $(eval $(call gb_Module_add_targets,sd,\
 
 ifneq ($(OS),DRAGONFLY)
 $(eval $(call gb_Module_add_check_targets,sd,\
+CppunitTest_sd_regression_test \
 CppunitTest_sd_uimpress \
 ))
 # disabled for now, seems to have incomplete deps and hangs on a build from scratch
-- 
1.7.7

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-qa] [ANN] LibreOffice 3.5.0 beta3 available

[Thorsten Behrens]

Hi *,

for the upcoming new version 3.5.0, we continue with a beta3 build
that is now feature-complete. For further milestones on the way
towards 3.5.0, please refer to our release plan timings here:

 http://wiki.documentfoundation.org/ReleasePlan#3.5_release

Builds are now being uploaded to a public (but non-mirrored - so don't
spread news too widely!) place, as soon as they're available. Grab
them here:

 http://dev-builds.libreoffice.org/pre-releases/

If you've a bit of time, please give them a try  report *critical*
bugs not yet in bugzilla here, so we can incorporate them into the
release notes. Please note that it takes approximately 24 hours to
populate the mirrors, so that's about the time we have to collect
feedback.

The list of fixed bugs relative to beta2 is here:

 
http://dev-builds.libreoffice.org/pre-releases/src/bugfixes-libreoffice-3-5-release-3.4.99.3.log

So playing with the areas touched there also greatly appreciated - and
validation that those bugs are really fixed.

Thanks a lot for your help,

-- Thorsten


pgppzyXViJ8q2.pgp
Description: PGP signature
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Minutes - QA related - TSC call 2012-01-12

[Pedro]

Hi Rainer, all

Took the liberty of fixing the date and some typos ;)

What do you mean OOo has a 3.4 Beta? Are you referring to the old Beta
released in April 2011?

In any case we can't avoid people from switching projects. What we need to
worry about is why they switched and if there is something TDF can do about
it...

I'm still worried about possible regressions from 3.3.x to 3.4.x... I'm not
sure about this (I use Ubuntu occasionally) but am I mistaken that if Ubuntu
decides to update LO from 3.3.4 to 3.4.5, all machines will be
automagically updated to 3.4.5? And if they decide not to update, Ubuntu
users will be stuck on 3.3.4?

This is the first time I'm not worried about Windows users :) There are no
automatic updates for products that are not from Microsoft :)

--
View this message in context: 
http://nabble.documentfoundation.org/Libreoffice-qa-Minutes-QA-related-TSC-call-2012-01-12-tp3654177p3654310.html
Sent from the QA mailing list archive at Nabble.com.
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Minutes - QA related - TSC call 2012-01-12

[Rainer Bielefeld]

Pedro schrieb:

Hello Pedro,


Took the liberty of fixing the date and some typos ;)


THX!



What do you mean OOo has a 3.4 Beta? Are you referring to the old Beta
released in April 2011?


Yes, of course, I can't imagine why it seemed new to me. Have to wipe my 
glasses again.



... worry about is why they switched and if there is something TDF
can do about it...


Yes, of course! My intention was to check whether there is an upcoming 
problem, and currently I don not see any.




I'm still worried about possible regressions from 3.3.x to 3.4.x...


Me to. My statistics Situation for 3.4 from the Minutes page (TSC call 
2011-12-15 Regressions, I again did the queries and did not see real 
progress) still are not encouraging, although the reaction visible on 
http://wiki.documentfoundation.org/Most_Annoying_Regressions were very 
few. Limitations because of regressions do exist, and I still have to 
use OOo 3.1.1(!) for some printing tasks, and A particular 
masterversions for E-Mail mailmerge, ... . I agree, an automatic update 
might be horrible for some users.


CU

Rainer

___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] 3.5.0 QA ... from BHS 1 to BHS 2

[Nino Novak]

Hi,

please keep in mind that I'm by no means a QA expert, but sometimes I'm good 
in expressing thoughts and fears of ordinary people ;-)

On Tuesday, January 10, 2012 09:58:48 AM Michael Meeks wrote:
 On Mon, 2012-01-09 at 16:20 +0100, Nino Novak wrote:

 ...

   So - I'd love to understand this desire for less frequent releases
 better :-) After all, we have tinderboxes churning out at least daily
 releases (in theory), perhaps several a day if we are lucky.

I think, people simply need enough time as daily spare time window might be 
small: imagine about 2-3x weekly 1-2 hours, but often there's much less. So in 
good times they can install one release per week and test it for one or two 
1-2 hours periods in the same week. That's it. 

As for the frequency: I for my part prefer to have a most-recent build for 
testing, so no - the release frequency should IMHO *not* decrease. But somehow 
I'd also like to have the feeling of having enough time to test in depth. 
Here a clearer prioriritization might be helpful.

I don't know if it's important, but I just wanted to mention that I very 
rarely take the time to test a release according to a fixed testing plan 
(Litmus etc) but most often just try to do my usual office work on copies of 
my original documents in a sandbox (and if nothing suspicious happens, after 
3-4 weeks those sandbox document copies become masters again and replace the 
original documents). And my impression is, that many people do this en 
passant testing and thereby discover problems or bugs. 

 
   What is the concern about having new RC's ? is it that you think
 developers will not care about and/or test any bugs that appear in
 something one release-candidate old ? [ that seems unlikely if it is a
 serious bug ], or ? ...

For /serious/ bugs, well, ok, but what if they are not-so-serious? Where's the 
threshold? 

And, to raise a different issue: People might well feel overwhelmed by the 
release frequency. Lost in release fusillades, so to speak. I personally have 
decided to concentrate on testing the most recent code line whenever possible. 
But many people still do not understand the release plan, and in addition do 
not know, how they can be (or make) sure that their test install will not 
interfere with their productive version. The QA-FAQ does not address this 
issue, you have to search for infos in the wiki...

So in summary, it may be a little bit the Mohammed - mountain problem. Cor's 
activities are a good starting point and most appreciated :-)

In the end, we have the common goal to make the software working as smoothly 
as possible. 

 
  Fourth, which is more an open question, how the success of Release QA
  could be monitored intelligently. My (naive) wish would be to have
  usage numbers, let's say
  - how often a Release has been launched on which OS platform without
  failure
   We have some download statistics of those that can be extracted (I
 suspect), and we have the on-line update statistics too which may give
 some yard-stick for successful launch ;-) usually the app has to stay
 alive for a little while to do that request.

(I'd appreciate if something like that could be implemented, but the effort 
should be kept low)

 
  - how often which module has been started
  - how many documents have been created/edited/viewed successfully
  - which particular functions have been called how often successfully
 
   These other phone-home things are more tricky, needing coding support,
 but it's of course a good idea to ensure good code coverage. Ideally -
 I'd like to reduce the burden on human QA though, so we're investing and
 encouraging (where we can) fast automated test that run during the
 compile: so you should never get a build that has pathaological failures
 [ assuming our test are complete enough ;-]. Hopefully that makes the
 process of QA more difficult  rewarding ;-) but of course there is
 always room for lots of improvement, and some things are hard to test.

All the above written does not relate to machine tests, only to manual tests. 
We should keep these two different approches well separated in discussion as 
they have different needs each one. For automated tests, you need skilled 
people. Manual testing can be done by Joe Average, at least in theory.

 
   One thing that is really nasty to test is the new
 header/footer/page-break stuff. I get intermittent leakage of
 page-breaks in documents (with several rendered on the screen); -but-
 while (after editing a document) I can reproduce them nicely, if I save
  re-load in another instance - I cannot ;-) so - there is a real need
 for some from a clean document reproduction steps for those issues -
 some of which may be races too ;-) help there much appreciated.

(others have to step in here, as I didn't test header/footer much yet - except 
that I wondered that deleting header/footer cannot be undone :-( )

Nino
___
List Name: 

[Libreoffice-qa] ИМПОРТ ЭКСПОРТ 2010 2012 ТНВЭД

[Владимир]

Оповещение: ОБНОВЛЕНИЕ
Обновление по статистике ВЭД ИМПОРТ ЭКСПОРТ 2010- 2011 год.

Справочник ИМПОРТА ЭКСПОРТА 2010- 2011года поможет Вам с поиском
новых партнёров по бизнесу маркетинг, анализ,
обзоры внешней  торговли  по любым группам товаров;
любому коду ТНВЭД.
Любой пример по Вашему товару.

РОССИЯ 2010 год полностью 2500 руб.
Импорт-экспорт

РОССИЯ 2011 год 9 месяцев,
можно только отбор по коду ТНВЭД в формате EXEL.


РОССИЯ 2011 год 4 месяца 2000 руб.
Импорт-экспорт

УКРАИНА 2010 год полностью 2000 руб. Импорт экспорт
УКРАИНА 2011 год 11 месяцев 2000 руб. Импорт экспорт

Поиск можно осуществлять по нескольким критериям
ОБРАТНЫЙ АДРЕС
ДЕМО-ВЕРСИЮ справочника МОЖНО ПОСМОТРЕТЬ
ЗАПРОС по телефону.
По вопросу приобретения
обращаться по телефону

8 926 524-43-34
спросить Владимира
С Уважением.


-
No se encontraron virus en este mensaje.
Comprobado por AVG - www.avg.com
Versión: 10.0.1416 / Base de datos de virus: 2109/4138 - Fecha de publicación: 
01/12/12
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-bugs] [Bug 43150] FILESAVE to doc , docx crashes

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=43150

--- Comment #3 from Marius Cirsta mfor...@gmail.com 2012-01-12 00:49:18 PST 
---
 I installed 3.5 beta2 for Windows, the default install but couldn't find the
doc format in the Save As menu. Maybe it's just me and I needed to install some
additional stuff , I have no idea.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 43066] FILESAVE conversion from *.doc to *.odt

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=43066

--- Comment #8 from Sadi sadiyumu...@gmail.com 2012-01-12 01:26:51 PST ---

Correction: I meant Libre Office 3.5.0 Beta 2...


(In reply to comment #7)
 Created attachment 55468 [details]
 doc file converted to odt by devlo345b2 - screenshot
 
 The problem reported persists in Libre Offive 3.4.5 Beta as can be seen in the
 screenshot of the file opened in OmegaT.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 43066] FILESAVE conversion from *.doc to *.odt

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=43066

Sadi sadiyumu...@gmail.com changed:

   What|Removed |Added

  Attachment #55468|doc file converted to odt   |doc file converted to odt
description|by devlo345b2 - screenshot  |by devlo350b2 - screenshot

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 42975] Opening a word file all the Formula Editor's objects have small size.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=42975

--- Comment #7 from Toussis Manolis kopperm...@yahoo.com 2012-01-12 02:16:09 
PST ---
Created attachment 55481
  -- https://bugs.freedesktop.org/attachment.cgi?id=55481
More complex doc file

I booted in my laptop in Windows 7 32bit, and tested the following versions:
LibreOffice 3.4.2
LibreOffice 3.4.4
LibreOffice 3.5b 
all downloaded from the official site.
The bug appears even in 3.5b. 
I sent you a doc saved in 3.5b (win7 32bit) , that appears bad in my system.
When you press double click on an equation , the equation appears fine in the
pop-up window but not on the document itshelf.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 33152] Using dynamic names for printing areas

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=33152

pierre-yves samyn pierre-yves.sa...@laposte.net changed:

   What|Removed |Added

  Status Whiteboard||VOTE

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 44498] All OpenDocument files created with LibO 3.4 or 3.5 are considered as invalid by Microsoft Office

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=44498

--- Comment #20 from Michael Stahl mst...@redhat.com 2012-01-12 02:46:14 PST 
---
the fact that OOo up to version 3.3 did not write the
manifest:version attribute was a bug:

https://issues.apache.org/ooo/show_bug.cgi?id=115789

the next release (as Apache OpenOffice) will have the fix for this included,
and now that it finally writes valid ODF 1.2, MS Office will claim that the
documents it writes are invalid.  Microsoft's approach to implementing
standards is discouraging to me.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 37361] LibreOffice 3.5 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=37361

Petr Mladek pmla...@suse.cz changed:

   What|Removed |Added

 Depends on||38515

--- Comment #87 from Petr Mladek pmla...@suse.cz 2012-01-12 02:51:48 PST ---
(In reply to comment #82)
 Bug 38515 - LibreOffice crashes in Bibliography dialog when pressing Enter
 – Because it's a crash and has been in LibO at least since 3.4

I crashes even when adding TOC, so let's add it


 Bug 44602 - Modeless Word Count window hides when user clicks into a note
 – Because it's a new feature that doesn't always work as advertised

I think that this one is rather funny than annoying. I think that we do not
need to prioritize it that much.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 43338] LibreOffice calc hangs when opening document with inaccessible URL(s)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=43338

--- Comment #2 from lbai...@pharmanord.com 2012-01-12 03:19:13 PST ---
Hi,

Try this file...


Regards,

Lloyd.

On 11/01/12 21:57, bugzilla-dae...@freedesktop.org wrote:
 https://bugs.freedesktop.org/show_bug.cgi?id=43338

 --- Comment #1 from tester8iamtest...@gmail.com  2012-01-11 13:57:51 PST ---
 NOT reproduced with

 LOdev 3.5.0beta2
 4ca392c-760cc4d-f39cf3d-1b2857e-60db978
 Ubuntu 10.04.3 x86
 Linux 2.6.32-37-generic Russian UI

 Please, attach sample document.


-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 39555] 256px Desktop icons are missing

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=39555

--- Comment #10 from Andras Timar tima...@gmail.com 2012-01-12 03:42:53 PST 
---
(In reply to comment #9)
 
 = FIXED

It does not solve the problem of Windows icons which are in .ico files. But I
have it on my TODO list and will do for 3.5.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 44715] New: FILEOPEN: rtf import fails to set cell borders correctly

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=44715

 Bug #: 44715
   Summary: FILEOPEN: rtf import fails to set cell borders
correctly
Classification: Unclassified
   Product: LibreOffice
   Version: LibO 3.4.4 release
  Platform: x86 (IA32)
OS/Version: All
Status: NEW
  Severity: normal
  Priority: medium
 Component: Writer
AssignedTo: libreoffice-bugs@lists.freedesktop.org
ReportedBy: it...@tnauk.org.uk


This affects boxes within a table.  For the top left corner of the box, if the
left border (clbrdrl) is defined before the top border (clbrdrt), then the left
border loses weight (eg shows as 25pt when it should be 75pt).  If the top
border is defined before the left border, then the top border loses weight in
the same way.  The same is true for all four corner cells in the box.

This is new - the import worked a year ago in Ubuntu (10.04) soffice, and had
for several years before.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 44635] EasyHack: trivial whitespace cleanup in presenter console ...

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=44635

--- Comment #1 from Rich Wareham rj...@cam.ac.uk 2012-01-12 04:15:22 PST ---
Created attachment 55487
  -- https://bugs.freedesktop.org/attachment.cgi?id=55487
sdext/source/presenter/*: remove extraneous vertical whitespace

Patch to collapse multiple vertical lines of whitespace into single lines.

This is my first contribution so I'm not sure of the etiquette. Should I also
get git to email the patch to the dev list?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 44716] New: FORMATTING: Cell contents disappears when 'Clear Direct FORMATTING'

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=44716

 Bug #: 44716
   Summary: FORMATTING: Cell contents disappears when 'Clear
Direct FORMATTING'
Classification: Unclassified
   Product: LibreOffice
   Version: LibO 3.5.0 Beta2
  Platform: Other
OS/Version: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Spreadsheet
AssignedTo: libreoffice-bugs@lists.freedesktop.org
ReportedBy: libreoff...@bielefeldundbuss.de


Created attachment 55488
  -- https://bugs.freedesktop.org/attachment.cgi?id=55488
Sample document

Steps how to reproduce with attached sample doucument and parallel
Dev-Installation of  LibreOffice 3.5.0 Beta3- WIN7 Home Premium (64bit) German
UI [Build-ID : e40af8c-10029e3-615e522-88673a2-727f724] 

0. Download attached sample
1. open sample document from LibO Start Center File menu
2. Click cell F2
3. Menu 'Format - Clear Direct Formatting'
   Expected: simple Number or something else visible
   Actual: No contents visible

Effect does not appear with 3.4.5RC2

Seems to be a rather new problem, not reproducible with Server installation of
MSVC Master LibO-dev 3.5.0 – WIN7 Home Premium (64bit) ENGLISH UI [Build ID:
485138f-e92bf75-4c1bcb5] Win-x86@6 – 2011-12-06_21:37:02)

Might be related to Bug 44687 - Changes in 'Locale Setting' destroys number
FORMATTING persistent (from where I took the sample document)?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 35673] LibreOffice 3.4 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35673

Philipp Gassmann phi...@wmail.ch changed:

   What|Removed |Added

 Depends on||37860

--- Comment #246 from Philipp Gassmann phi...@wmail.ch 2012-01-12 04:31:01 
PST ---
Add Bug 37860 - Formula returns #VALUE in 3.4RC2 but works as expected in 3.3

Although the change is intended, it breaks compatibility to earlier versions
and to Excel import.
There's a common pattern =IF(A1+B1=0;;A1+B1) which is used to hide zeros,
that leads to an error if another formula references this cell when 0/.
Additionally it is already tagged as EasyHack.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 37860] Formula returns #VALUE in 3.4RC2 but works as expected in 3.3

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=37860

Philipp Gassmann phi...@wmail.ch changed:

   What|Removed |Added

 Blocks||35673

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 37361] LibreOffice 3.5 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=37361

Philipp Gassmann phi...@wmail.ch changed:

   What|Removed |Added

 Depends on||37860

--- Comment #88 from Philipp Gassmann phi...@wmail.ch 2012-01-12 04:32:07 PST 
---
Add Bug 37860 - Formula returns #VALUE in 3.4RC2 but works as expected in 3.3

Although the change is intended, it breaks compatibility to earlier versions
and to Excel import.
There's a common pattern =IF(A1+B1=0;;A1+B1) which is used to hide zeros,
that leads to an error if another formula references this cell when 0/.
Additionally it is already tagged as EasyHack.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 37860] Formula returns #VALUE in 3.4RC2 but works as expected in 3.3

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=37860

Philipp Gassmann phi...@wmail.ch changed:

   What|Removed |Added

 Blocks||37361

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 44717] New: Inaccurate 'Please exit' wording in Installation Wizard

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=44717

 Bug #: 44717
   Summary: Inaccurate 'Please exit' wording in Installation
Wizard
Classification: Unclassified
   Product: LibreOffice
   Version: LibO 3.5.0 Beta2
  Platform: x86-64 (AMD64)
OS/Version: Windows (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Installation
AssignedTo: libreoffice-bugs@lists.freedesktop.org
ReportedBy: robert.funn...@mcgill.ca


When installing LibO 3.5.0 Beta 2 I saw the message 'Please exit LOdev 3.5 and
the LOdev 3.5 Quickstarter before you continue ...' although I have never
installed any version of LibO on this computer. Presumably it was really
referring to the fact that OOo was running. It seems that the message should
not refer to a specific version of LibO, and should accommodate the possibility
that it's OOo that needs to be closed.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 43150] FILESAVE to doc , docx crashes

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=43150

--- Comment #4 from tester8 iamtest...@gmail.com 2012-01-12 04:53:31 PST ---
Strange... there is no need in any additional stuff to save into the .doc.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 43066] FILESAVE conversion from *.doc to *.odt

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=43066

--- Comment #9 from tester8 iamtest...@gmail.com 2012-01-12 05:02:58 PST ---
Created attachment 55489
  -- https://bugs.freedesktop.org/attachment.cgi?id=55489
Screenshot of lots of tags in odt converted from doc with 3.5b2

text and /text repeats and repeats.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 43066] FILESAVE conversion from *.doc to *.odt

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=43066

tester8 iamtest...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever Confirmed|0   |1

--- Comment #10 from tester8 iamtest...@gmail.com 2012-01-12 05:04:05 UTC ---
OK, reproduced.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 42975] Opening a word file all the Formula Editor's objects have small size.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=42975

tester8 iamtest...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever Confirmed|0   |1

--- Comment #8 from tester8 iamtest...@gmail.com 2012-01-12 05:09:33 PST ---
With More complex doc file it is reproduced, formulae not small but
distorted.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 44718] New: Addition of double and triple primes to available symbols

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=44718

 Bug #: 44718
   Summary: Addition of double and triple primes to available
symbols
Classification: Unclassified
   Product: LibreOffice
   Version: LibO 3.5.0 Beta2
  Platform: x86-64 (AMD64)
OS/Version: Windows (All)
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Formula Editor
AssignedTo: libreoffice-bugs@lists.freedesktop.org
ReportedBy: robert.funn...@mcgill.ca


It would be useful to have double prime (Unicode 2033) and triple prime (2034)
characters available, as used for degrees/minutes/seconds and for second and
third derivatives. Appropriate names would be %pprime and %ppprime, following
what I think is used in TeX. It might be useful to also have %prime defined,
although a single prime is already available as '.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 44260] Crash after inactivity/switch to other program

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=44260

--- Comment #16 from Petr Mladek pmla...@suse.cz 2012-01-12 05:24:54 PST ---
I am not sure if I understand the diff correctly. I see this diff format for
the first time. Also it does not help that it is in German ;-)

My understanding is that the left 3 columns describe the old (broken)
configuration and the 3 columns on the right describe the new (working)
configuration.

Also, I guess that the word keine means that the file in missing.


So, one big difference is that the new configuration does not include
javasettings_Windows_x86.xml. It might mean that Java is disabled, some
functionality is not used. I wonder if some java stuff might trigger the crash
again if you configure it.

Another difference is that the new configuration includes just en-US config
files. The old configuration included localized config files for de, en-GB,
en-ZA. I am not sure if this could make any difference, though.


One easy test might be if you use the working configuration, copy the missing
files there and try to run LO. It would be great if you could do it in two
steps. Just copy the java configuration in the first stage (or configure it via
Tool/Options/LibreOffice/Java). Then you could copy the missing *.so? files in
the second test round.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs