[Libreoffice-commits] Changes to 'refs/tags/libreoffice-3.5.0.1'
Tag 'libreoffice-3.5.0.1' created by Fridrich Å trba fridrich.st...@bluewin.ch at 2012-01-17 21:55 +0100 Tag 3.5.0.1 (3.5.0-rc1) -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.18 (GNU/Linux) iQIcBAABAgAGBQJPFe5CAAoJEPQ0oe+v7q6jgroQALd3rruLwq/0JCHJSKgRdmFZ jd1UM7Yv43hBjej9ALptDPf0QOJ2qluUKXwcbta0/FKgVy3KIIwZdYdTALHtQwmo G5qXzNO4ZpKgg1OdQFPcaSqZp2XWlH0i/GeE8r9bzzV69tM9dsVOThbvJk3Z8Mt5 nsaFLBfMR4MvUO5ANTC1G1hmSph0NdRLmVkUvINcQPswvUt+CMmNHDD+ApxOdC6O YUbu/8FTTzHkOmI0cz6KHBo4F3D0xqAmpcbBzGnrZb3i6KlFkm4+c00G/qxZe4B0 0DChQtTVISXtbP4LkPSiQUAk6+xHuDkvvL/s4CWQRNZNdVYSwAPvdz8y+QcJGDbl 80vEwRWnmFAUB37ztFn5fw5eq1QsrrlMGeUJxxf9fI54HcVaAU5SMEiItc069oiO M3NlxozXqG2ZeYfWyAliuvA0C5pl6l9Og22yTydbnxLekWGP2cbwaYcq5Xl6l3CC 1u+drV0z6JorQwmiA3KR5tRAyikfOF/IWsGe+TwRJ+YWZ+aeuLqLboogU2CYkjqE ss3YnnZrKG8C0m+dbnY3g44FYijf8xde6wcYF4PjWRpk42Ovxl7IVjNKUkTfxGr0 72RZ8jrCuE6Bpn+g55qiRWtl0JulLXqGM5belUlkekE/Y5F6Y7l5LD/H0PudufB7 UHDNB6QYuBSRw3bCpR/X =IMwQ -END PGP SIGNATURE- Changes since libreoffice-3-5-branch-point-595: --- 0 files changed --- ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] Changes to 'refs/tags/libreoffice-3.5.0.1'
Tag 'libreoffice-3.5.0.1' created by Fridrich Å trba fridrich.st...@bluewin.ch at 2012-01-17 21:55 +0100 Tag 3.5.0.1 (3.5.0-rc1) -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.18 (GNU/Linux) iQIcBAABAgAGBQJPFe5CAAoJEPQ0oe+v7q6jLv0P/jTnFP8pZ9tknA4CX21kIcmF tYCJnhEmQOqZQZG9ryaRiM3o8Lc7FGtBaYl5RLqqZ4MigSiP5ukMTnOoBjIQrCGW uEQLPsPZSc7KpXno2O1SM08NGUH498WviYw2ea1z7efMS1dkQx/Gvv7XKK1WBnyl /rnnL50xjl3ydJL4r7ctYi6XZ43sQR8CsHmDY3RCtZ5UilIoPXXcQmFQwzhQIo2V 20YolI4TN7GjqkxQwqphgfTpqCvvc5M5FDBCKIX+w9umUwiX5u4Z00yH3PLSPAWe mzz+gasecWHlj3hZhhbUmFu2AOsf84LjUX9AqU52XSNLJiwJUOvvIRIrXSo9pe3v 88JqZNQJqXepN0fs/zoeLL2yHigTSiSSMsALDrrB7Vd/6cw8+oZgGrJughRYt+84 sGlxkiXwoTxGfxawL0xogEXWwtxEFrLmyJoD6zkndO1N9FxrtMfExVYvzsPDajmu rSEURN1Otp9Q9G986xH+Cc/ZWmzfzCN5U1vDCq3YSzsoZawQDobqcbqjQOy0Jgpn S0JNxSz8NJc0L08PP5U2yzXoyCG2DnXsi1fy5JKU8EYDKAitQFh41CiwvVIUMsHV K3MO6jGCjM0xKD5ALyWKhMuG6ahvUpb742XAGQpA0kicA+nDo7QVwGNeZPwjgPmk 2luEExA96nYwMiHTPJT0 =7WnG -END PGP SIGNATURE- Changes since libreoffice-3-5-branch-point-24: --- 0 files changed --- ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] Changes to 'refs/tags/libreoffice-3.5.0.1'
Tag 'libreoffice-3.5.0.1' created by Fridrich Å trba fridrich.st...@bluewin.ch at 2012-01-18 08:16 +0100 Tag 3.5.0.1 (3.5.0-rc1) -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.18 (GNU/Linux) iQIcBAABAgAGBQJPFn/zAAoJEPQ0oe+v7q6j4LEP+QG/Mc93lGD6mlsoiKmMVNKc Sn737QmTBDbAHgEJWMFe1+gYOxb8A5WygymedvFT+2iWSj03UF2IbVkfIRVGYxjv uJX8wFTbuh6+5FPqabljzM2kN3hucq/rVOpTfO+0YOHoIpTmLThbeQnxmEUWw/jW /OvcD7FNLeycBhuaBc+oaTiCd8fx6rfY7FM9wLeSiVQgCPWgE3U+Fg4ovGiN98Bh fkjckq4wjL5/0bCJImOTyMHjEjYev3/dll6g8UGnwZEtlngfkAuri8SEWgkVWZ2Q I/eF2srAh4Y03phYognS44qIphcaTcgOkIw6k2BZPOimEraV05AnrjOZvkrPgg3U hLv3sACwSi11kA9+oyGvfm3TE06O6hCH+Ddb99K3oKXdG7eWwDvrXfM5D0SH4+ja GAGU7CH+6gGMkjuDhtJF/lzLt5vPfianCu0s2gf9n0PNAN7f6ZySTF2VbcVJ4gmX CNkNFbwbNl8TM5K73LdIymF34bEHhvT9WVSWm8og4rBrDoHUpzRFMNjQxRQIFX7q GU6L9Yj93UeM60S/+bEO98J1HeNhla2WBEYGSS8F+IAL/mdALndJCzpFbxjQ52aH r8U80c7wyr1TyNg5DhZIE0tan+XSiwh1mTq312BPfNLGHmSMm6pijna2P1BhS8Rg cloqphRfXYDSB+7m47Vl =hfNj -END PGP SIGNATURE- Changes since libreoffice-3-5-branch-point-37: --- 0 files changed --- ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'refs/tags/libreoffice-3.5.0.1' - 3 commits - binfilter/bf_sch binfilter/bf_sw
Rebased ref, commits from common ancestor:
commit 8c0b45513a139657678484b73112dc5eba800dac
Author: Fridrich Å trba fridrich.st...@bluewin.ch
Date: Wed Jan 18 09:24:57 2012 +0100
Version 3.5.0.1, tag libreoffice-3.5.0.1 (3.5.0-rc1)
commit 539d9db35d08904e03366c51105f60385f84
Author: David Tardon dtar...@redhat.com
Date: Tue Jan 10 19:32:51 2012 +0100
fix for gcc 4.7/C++11: these are not string literal operators
Signed-off-by: David Tardon dtar...@redhat.com
diff --git a/binfilter/bf_sch/source/core/sch_globfunc.cxx
b/binfilter/bf_sch/source/core/sch_globfunc.cxx
index 6a81bf1..ac87608 100644
--- a/binfilter/bf_sch/source/core/sch_globfunc.cxx
+++ b/binfilter/bf_sch/source/core/sch_globfunc.cxx
@@ -1193,7 +1193,7 @@ namespace binfilter {
/*N*/ const USHORT* pRanges = rSet.GetRanges();
/*N*/ for( long n = 0; pRanges[ n ] n32; n+=2 )
/*N*/ {
-/*N*/ snprintf( pSmallBuf, sizeof(pSmallBuf), [%SAL_PRIdINT32;
%SAL_PRIdINT32] , (sal_uInt32)pRanges[ n ], (sal_uInt32)pRanges[ n+1 ] );
+/*N*/ snprintf( pSmallBuf, sizeof(pSmallBuf), [% SAL_PRIdINT32 ; %
SAL_PRIdINT32 ] , (sal_uInt32)pRanges[ n ], (sal_uInt32)pRanges[ n+1 ] );
/*N*/ strncat( pBuf, pSmallBuf, sizeof(pBuf) - strlen(pBuf) - 1 );
/*N*/ }
/*N*/
@@ -1219,7 +1219,7 @@ namespace binfilter {
/*N*/ nCns++;
/*N*/ if( nCnt 100 )
/*N*/ {
-/*N*/ snprintf( pSmallBuf, sizeof(pSmallBuf), %SAL_PRIdINT32,
, (sal_uInt32) nWhich );
+/*N*/ snprintf( pSmallBuf, sizeof(pSmallBuf), % SAL_PRIdINT32
, , (sal_uInt32) nWhich );
/*N*/ strncat( pBuf, pSmallBuf, sizeof(pBuf) - strlen(pBuf) - 1
);
/*N*/ }
/*N*/
diff --git a/binfilter/bf_sw/source/core/sw3io/sw_sw3imp.cxx
b/binfilter/bf_sw/source/core/sw3io/sw_sw3imp.cxx
index 6548a85..3da5855 100644
--- a/binfilter/bf_sw/source/core/sw3io/sw_sw3imp.cxx
+++ b/binfilter/bf_sw/source/core/sw3io/sw_sw3imp.cxx
@@ -1646,7 +1646,7 @@ void Sw3StringPool::LoadOld( SvStream r )
/*N*/ if( pCrypter )
/*N*/ {
/*?*/ sal_Char buf[ 17 ];
-/*?*/ snprintf( buf, sizeof(buf),
%08SAL_PRIxUINT32%08SAL_PRIxUINT32, nDate, nTime );
+/*?*/ snprintf( buf, sizeof(buf), %08 SAL_PRIxUINT32 %08
SAL_PRIxUINT32, nDate, nTime );
/*?*/ rtl::OStringBuffer aTest( buf );
/*?*/ pCrypter-Encrypt( aTest );
/*?*/ return sal_Bool( !memcmp( cPasswd, aTest.getStr(), PASSWDLEN ) );
@@ -1664,7 +1664,7 @@ void Sw3StringPool::LoadOld( SvStream r )
/*N*/ {
/*?*/ pCrypter = new Crypter( pRoot-GetKey() );
/*?*/ sal_Char buf[ 17 ];
-/*?*/ snprintf( buf, sizeof(buf),
%08SAL_PRIxUINT32%08SAL_PRIxUINT32, nDate, nTime );
+/*?*/ snprintf( buf, sizeof(buf), %08 SAL_PRIxUINT32 %08
SAL_PRIxUINT32, nDate, nTime );
/*?*/ rtl::OStringBuffer aTest( buf );
/*?*/ pCrypter-Encrypt( aTest );
/*?*/ memcpy( cPasswd, aTest.getStr(), aTest.getLength() );
commit 7f15fcac486ea45c3ca77db7f93506850a022e5e
Author: Petr Mladek pmla...@suse.cz
Date: Tue Dec 6 14:15:08 2011 +0100
Branch libreoffice-3-5
This is 'libreoffice-3-5' - the stable branch for the 3.5.x releases.
The commit rules are different according to the development phase:
+ 3.5.0 beta phase:
+ any bug fixes are allowed without review
+ late features need approval by 2 people with different affiliation
+ 3.5.0 rc phase and later:
+ fixes need approval by one reviewer
+ late features need approval by 2 more people with different
affiliation
IMPORTANT: Every developer is responsible for pushing the fixes into all
appropriate branches. Note that we do not plan any merge
from this branch to master or vice versa.
Please, help use to make stable and usable release. If you want to build
something cool, unstable, and risky, use master.
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-5' - instsetoo_native/util solenv/inc
instsetoo_native/util/openoffice.lst | 30 +++--- solenv/inc/minor.mk |4 ++-- 2 files changed, 17 insertions(+), 17 deletions(-) New commits: commit 2f1fa4abea5035cdf83331dd18b86b6fd6393d88 Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Wed Jan 18 10:28:55 2012 +0100 bump product version to 3.5.0-rc1+, release number to 11 diff --git a/instsetoo_native/util/openoffice.lst b/instsetoo_native/util/openoffice.lst index 18d804d..dba6be7 100644 --- a/instsetoo_native/util/openoffice.lst +++ b/instsetoo_native/util/openoffice.lst @@ -53,13 +53,13 @@ LibreOffice PRODUCTVERSION 3.5 PRODUCTEXTENSION LONG_PRODUCTEXTENSION - SHORT_PRODUCTEXTENSION beta3 + SHORT_PRODUCTEXTENSION rc1 POSTVERSIONEXTENSION POSTVERSIONEXTENSIONUNIX BRANDPACKAGEVERSION 3.5 USERDIRPRODUCTVERSION 3 ABOUTBOXPRODUCTVERSION 3.5.0 - ABOUTBOXPRODUCTVERSIONSUFFIX beta3+ + ABOUTBOXPRODUCTVERSIONSUFFIX rc1+ BASEPRODUCTVERSION 3.5 PCPFILENAME libreoffice.pcp UPDATEURL http://update.libreoffice.org/check.php @@ -112,13 +112,13 @@ LibreOffice_wJRE PRODUCTVERSION 3.5 PRODUCTEXTENSION LONG_PRODUCTEXTENSION - SHORT_PRODUCTEXTENSION beta3 + SHORT_PRODUCTEXTENSION rc1 POSTVERSIONEXTENSION POSTVERSIONEXTENSIONUNIX BRANDPACKAGEVERSION 3.5 USERDIRPRODUCTVERSION 3 ABOUTBOXPRODUCTVERSION 3.5.0 - ABOUTBOXPRODUCTVERSIONSUFFIX beta3+ + ABOUTBOXPRODUCTVERSIONSUFFIX rc1+ BASEPRODUCTVERSION 3.5 UPDATEURL http://update.libreoffice.org/check.php ADD_INCLUDE_FILES cliureversion.mk,clioootypesversion.mk,javaversion2.dat,userland.txt,version.lst @@ -170,14 +170,14 @@ LibreOffice_Dev PRODUCTVERSION 3.5 PRODUCTEXTENSION LONG_PRODUCTEXTENSION - SHORT_PRODUCTEXTENSION beta3 + SHORT_PRODUCTEXTENSION rc1 UNIXBASISROOTNAME lodev3.5 POSTVERSIONEXTENSION POSTVERSIONEXTENSIONUNIX BRANDPACKAGEVERSION 3.5 USERDIRPRODUCTVERSION 3 ABOUTBOXPRODUCTVERSION 3.5.0 - ABOUTBOXPRODUCTVERSIONSUFFIX beta3+ + ABOUTBOXPRODUCTVERSIONSUFFIX rc1+ BASEPRODUCTVERSION 3.5 DEVELOPMENTPRODUCT 1 BASISPACKAGEPREFIX lodevbasis @@ -240,7 +240,7 @@ URE PRODUCTEXTENSION BRANDPACKAGEVERSION 3.5 LONG_PRODUCTEXTENSION -SHORT_PRODUCTEXTENSION beta3 +SHORT_PRODUCTEXTENSION rc1 LICENSENAME LGPL SETSTATICPATH 1 NOVERSIONINDIRNAME 1 @@ -275,7 +275,7 @@ LibreOffice_SDK PRODUCTVERSION 3.5 PRODUCTEXTENSION LONG_PRODUCTEXTENSION -SHORT_PRODUCTEXTENSION beta3 +SHORT_PRODUCTEXTENSION rc1 POSTVERSIONEXTENSION SDK POSTVERSIONEXTENSIONUNIX sdk BRANDPACKAGEVERSION 3.5 @@ -318,7 +318,7 @@ LibreOffice_Dev_SDK PRODUCTVERSION 3.5 PRODUCTEXTENSION LONG_PRODUCTEXTENSION -SHORT_PRODUCTEXTENSION beta3 +SHORT_PRODUCTEXTENSION rc1 UNIXBASISROOTNAME lodev3.5 POSTVERSIONEXTENSION SDK POSTVERSIONEXTENSIONUNIX sdk @@ -367,7 +367,7 @@ LibreOffice_Test PRODUCTVERSION 3.5 PRODUCTEXTENSION LONG_PRODUCTEXTENSION -SHORT_PRODUCTEXTENSION beta3 +SHORT_PRODUCTEXTENSION rc1 POSTVERSIONEXTENSION TEST POSTVERSIONEXTENSIONUNIX test BRANDPACKAGEVERSION 3.5 @@ -410,7 +410,7 @@ LibreOffice_Dev_Test PRODUCTVERSION 3.5 PRODUCTEXTENSION LONG_PRODUCTEXTENSION -SHORT_PRODUCTEXTENSION beta3 +SHORT_PRODUCTEXTENSION rc1 UNIXBASISROOTNAME lodev3.5 POSTVERSIONEXTENSION TEST POSTVERSIONEXTENSIONUNIX test @@ -458,13 +458,13 @@ OxygenOffice PRODUCTVERSION 3.5 PRODUCTEXTENSION LONG_PRODUCTEXTENSION - SHORT_PRODUCTEXTENSION beta3 + SHORT_PRODUCTEXTENSION rc1 POSTVERSIONEXTENSION
[Libreoffice-commits] .: 2 commits - connectivity/inc dbaccess/source
connectivity/inc/connectivity/dbtools.hxx |4 -
dbaccess/source/core/api/KeySet.cxx | 71 +-
dbaccess/source/core/api/KeySet.hxx |5 ++
dbaccess/source/core/api/RowSet.hxx |2
4 files changed, 59 insertions(+), 23 deletions(-)
New commits:
commit c2567a658735423948d76992ca744a4187620928
Author: Lionel Elie Mamane lio...@mamane.lu
Date: Wed Jan 18 12:31:06 2012 +0100
janitorial: typo in comments
diff --git a/connectivity/inc/connectivity/dbtools.hxx
b/connectivity/inc/connectivity/dbtools.hxx
index 3555025..24f39cb 100644
--- a/connectivity/inc/connectivity/dbtools.hxx
+++ b/connectivity/inc/connectivity/dbtools.hxx
@@ -615,7 +615,7 @@ namespace dbtools
const ::com::sun::star::uno::Reference
::com::sun::star::task::XInteractionHandler _rxHandler,
const ::std::vectorbool, std::allocatorbool
_aParametersSet = ::std::vectorbool, std::allocatorbool ());
-/** call the appropiate set method for the specific sql type @see
com::sun::star::sdbc::DataType
+/** call the appropriate set method for the specific sql type @see
com::sun::star::sdbc::DataType
@param _xParamsthe parameters where to set the value
@param parameterIndex the index of the parameter, 1 based
@param x the value to set
@@ -629,7 +629,7 @@ namespace dbtools
sal_Int32 sqlType,
sal_Int32 scale=0)
throw(::com::sun::star::sdbc::SQLException,
::com::sun::star::uno::RuntimeException);
-/** call the appropiate set method for the specific sql type @see
com::sun::star::sdbc::DataType
+/** call the appropriate set method for the specific sql type @see
com::sun::star::sdbc::DataType
@param _xParamsthe parameters where to set the value
@param parameterIndex the index of the parameter, 1 based
@param x the value to set
diff --git a/dbaccess/source/core/api/RowSet.hxx
b/dbaccess/source/core/api/RowSet.hxx
index 40e1920..42ca4b3 100644
--- a/dbaccess/source/core/api/RowSet.hxx
+++ b/dbaccess/source/core/api/RowSet.hxx
@@ -223,7 +223,7 @@ namespace dbaccess
void checkUpdateIterator();
const connectivity::ORowSetValue getInsertValue(sal_Int32
columnIndex);
void setParameter(sal_Int32 parameterIndex, const
connectivity::ORowSetValue x);
-// resizes the parameter vector if nescessary
+// resizes the parameter vector if necessary
::connectivity::ORowSetValue getParameterStorage( sal_Int32
parameterIndex );
void updateValue(sal_Int32 columnIndex,const
connectivity::ORowSetValue x);
commit 3623701d65f92017da905f4debf5514045f502c8
Author: Lionel Elie Mamane lio...@mamane.lu
Date: Wed Jan 18 12:30:36 2012 +0100
fdo#44813: make the refresh query filter NULL-safe
diff --git a/dbaccess/source/core/api/KeySet.cxx
b/dbaccess/source/core/api/KeySet.cxx
index 6024f3f..46444e9 100644
--- a/dbaccess/source/core/api/KeySet.cxx
+++ b/dbaccess/source/core/api/KeySet.cxx
@@ -223,22 +223,56 @@ void OKeySet::findTableColumnsMatching_throw( const
Any i_aTable,
}
SAL_WNODEPRECATED_DECLARATIONS_POP
+namespace
+{
+void appendOneKeyColumnClause( const ::rtl::OUString tblName, const
::rtl::OUString colName, ::rtl::OUStringBuffer o_buf )
+{
+static ::rtl::OUString s_sDot(RTL_CONSTASCII_USTRINGPARAM(.));
+static ::rtl::OUString s_sParam0(RTL_CONSTASCII_USTRINGPARAM( ( TRUE
= ? AND ));
+static ::rtl::OUString s_sParam1(RTL_CONSTASCII_USTRINGPARAM( = ? OR
TRUE = ? AND ));
+static ::rtl::OUString s_sParam2(RTL_CONSTASCII_USTRINGPARAM( IS NULL
) ));
+o_buf.append(s_sParam0);
+o_buf.append(tblName);
+o_buf.append(s_sDot);
+o_buf.append(colName);
+o_buf.append(s_sParam1);
+o_buf.append(tblName);
+o_buf.append(s_sDot);
+o_buf.append(colName);
+o_buf.append(s_sParam2);
+}
+}
+
+void OKeySet::setOneKeyColumnParameter( sal_Int32 nPos, const Reference
XParameters _xParameter, const connectivity::ORowSetValue _rValue,
sal_Int32 _nType, sal_Int32 _nScale ) const
+{
+if ( _rValue.isNull() )
+{
+_xParameter-setBoolean( nPos++, false );
+// We do the full call so that the right sqlType is passed to setNull
+setParameter( nPos++, _xParameter, _rValue, _nType, _nScale );
+_xParameter-setBoolean( nPos++, true );
+}
+else
+{
+_xParameter-setBoolean( nPos++, true );
+setParameter( nPos++, _xParameter, _rValue, _nType, _nScale );
+_xParameter-setBoolean( nPos++, false );
+}
+}
+
::rtl::OUStringBuffer OKeySet::createKeyFilter()
{
static ::rtl::OUString aAnd(RTL_CONSTASCII_USTRINGPARAM( AND ));
const ::rtl::OUString aQuote= getIdentifierQuoteString();
::rtl::OUStringBuffer aFilter;
-static
[Libreoffice-commits] .: dbaccess/source
dbaccess/source/core/api/KeySet.cxx | 80 +++-
dbaccess/source/core/api/KeySet.hxx |1
2 files changed, 26 insertions(+), 55 deletions(-)
New commits:
commit 773668c6ab0963f56f98270b29d595f5df7c4bb2
Author: Lionel Elie Mamane lio...@mamane.lu
Date: Wed Jan 18 13:10:12 2012 +0100
OKeySet: tryRefetch and refreshRow share most of their code
diff --git a/dbaccess/source/core/api/KeySet.cxx
b/dbaccess/source/core/api/KeySet.cxx
index 46444e9..d55f075 100644
--- a/dbaccess/source/core/api/KeySet.cxx
+++ b/dbaccess/source/core/api/KeySet.cxx
@@ -881,45 +881,9 @@ void OKeySet::tryRefetch(const ORowSetRow
_rInsertRow,bool bRefetch)
{
if ( bRefetch )
{
-// we just areassign the base members
try
{
-Reference XParameters xParameter(m_xStatement,UNO_QUERY);
-OSL_ENSURE(xParameter.is(),No Parameter interface!);
-xParameter-clearParameters();
-
-sal_Int32 nPos=1;
-connectivity::ORowVector ORowSetValue ::Vector::const_iterator
aParaIter;
-connectivity::ORowVector ORowSetValue ::Vector::const_iterator
aParaEnd;
-OUpdatedParameter::iterator aUpdateFind =
m_aUpdatedParameter.find(m_aKeyIter-first);
-if ( aUpdateFind == m_aUpdatedParameter.end() )
-{
-aParaIter = m_aParameterValueForCache.get().begin();
-aParaEnd = m_aParameterValueForCache.get().end();
-}
-else
-{
-aParaIter = aUpdateFind-second.get().begin();
-aParaEnd = aUpdateFind-second.get().end();
-}
-
-for(++aParaIter;aParaIter != aParaEnd;++aParaIter,++nPos)
-{
-::dbtools::setObjectWithInfo( xParameter, nPos,
aParaIter-makeAny(), aParaIter-getTypeKind() );
-}
-connectivity::ORowVector ORowSetValue ::Vector::const_iterator
aIter2 = m_aKeyIter-second.first-get().begin();
-SelectColumnsMetaData::const_iterator aPosIter =
(*m_pKeyColumnNames).begin();
-SelectColumnsMetaData::const_iterator aPosEnd =
(*m_pKeyColumnNames).end();
-for(;aPosIter != aPosEnd;++aPosIter,++aIter2)
-
setOneKeyColumnParameter(nPos,xParameter,*aIter2,aPosIter-second.nType,aPosIter-second.nScale);
-aPosIter = (*m_pForeignColumnNames).begin();
-aPosEnd = (*m_pForeignColumnNames).end();
-for(;aPosIter != aPosEnd;++aPosIter,++aIter2)
-
setOneKeyColumnParameter(nPos,xParameter,*aIter2,aPosIter-second.nType,aPosIter-second.nScale);
-
-m_xSet = m_xStatement-executeQuery();
-OSL_ENSURE(m_xSet.is(),No resultset form statement!);
-bRefetch = m_xSet-next();
+bRefetch = doTryRefetch_throw();
}
catch(const Exception)
{
@@ -1327,22 +1291,9 @@ sal_Bool SAL_CALL OKeySet::previous( )
throw(SQLException, RuntimeException)
return previous_checked(sal_True);
}
-//
-
-void SAL_CALL OKeySet::refreshRow() throw(SQLException, RuntimeException)
+bool OKeySet::doTryRefetch_throw() throw(SQLException, RuntimeException)
{
-RTL_LOGFILE_CONTEXT_AUTHOR( aLogger, dbaccess, ocke.jans...@sun.com,
OKeySet::refreshRow );
-if(isBeforeFirst() || isAfterLast() || !m_xStatement.is())
-return;
-
-m_xRow = NULL;
-::comphelper::disposeComponent(m_xSet);
-
-if ( m_aKeyIter-second.second.second.is() )
-{
-m_xRow = m_aKeyIter-second.second.second;
-return;
-}
-// we just areassign the base members
+// we just reassign the base members
Reference XParameters xParameter(m_xStatement,UNO_QUERY);
OSL_ENSURE(xParameter.is(),No Parameter interface!);
xParameter-clearParameters();
@@ -1379,8 +1330,27 @@ void SAL_CALL OKeySet::refreshRow() throw(SQLException,
RuntimeException)
setOneKeyColumnParameter(nPos,xParameter,*aIter,aPosIter-second.nType,aPosIter-second.nScale);
m_xSet = m_xStatement-executeQuery();
-OSL_ENSURE(m_xSet.is(),No resultset form statement!);
-sal_Bool bOK = m_xSet-next();
+OSL_ENSURE(m_xSet.is(),No resultset from statement!);
+return m_xSet-next()
+}
+
+//
-
+void SAL_CALL OKeySet::refreshRow() throw(SQLException, RuntimeException)
+{
+RTL_LOGFILE_CONTEXT_AUTHOR( aLogger, dbaccess, ocke.jans...@sun.com,
OKeySet::refreshRow );
+if(isBeforeFirst() || isAfterLast() || !m_xStatement.is())
+return;
+
+m_xRow = NULL;
+::comphelper::disposeComponent(m_xSet);
+
+if ( m_aKeyIter-second.second.second.is() )
+{
+m_xRow = m_aKeyIter-second.second.second;
+return;
+}
+
+sal_Bool bOK = doTryRefetch_throw();
if ( !bOK )
{
OKeySetMatrix::iterator aTemp
[Libreoffice-commits] .: Branch 'libreoffice-3-5' - 2 commits - dbaccess/source
dbaccess/source/core/api/CacheSet.cxx |2
dbaccess/source/core/api/KeySet.cxx| 85 +++--
dbaccess/source/core/api/KeySet.hxx|5 +
dbaccess/source/core/api/OptimisticSet.cxx |2
4 files changed, 65 insertions(+), 29 deletions(-)
New commits:
commit dfcf55a9de3cc928e5612117d0f9f5f3783de2ff
Author: Lionel Elie Mamane lio...@mamane.lu
Date: Wed Jan 18 12:30:36 2012 +0100
fdo#44813: make the refresh query filter NULL-safe
diff --git a/dbaccess/source/core/api/KeySet.cxx
b/dbaccess/source/core/api/KeySet.cxx
index 17789ff..b41e68b 100644
--- a/dbaccess/source/core/api/KeySet.cxx
+++ b/dbaccess/source/core/api/KeySet.cxx
@@ -223,22 +223,56 @@ void OKeySet::findTableColumnsMatching_throw( const
Any i_aTable,
}
SAL_WNODEPRECATED_DECLARATIONS_POP
+namespace
+{
+void appendOneKeyColumnClause( const ::rtl::OUString tblName, const
::rtl::OUString colName, ::rtl::OUStringBuffer o_buf )
+{
+static ::rtl::OUString s_sDot(RTL_CONSTASCII_USTRINGPARAM(.));
+static ::rtl::OUString s_sParam0(RTL_CONSTASCII_USTRINGPARAM( ( TRUE
= ? AND ));
+static ::rtl::OUString s_sParam1(RTL_CONSTASCII_USTRINGPARAM( = ? OR
TRUE = ? AND ));
+static ::rtl::OUString s_sParam2(RTL_CONSTASCII_USTRINGPARAM( IS NULL
) ));
+o_buf.append(s_sParam0);
+o_buf.append(tblName);
+o_buf.append(s_sDot);
+o_buf.append(colName);
+o_buf.append(s_sParam1);
+o_buf.append(tblName);
+o_buf.append(s_sDot);
+o_buf.append(colName);
+o_buf.append(s_sParam2);
+}
+}
+
+void OKeySet::setOneKeyColumnParameter( sal_Int32 nPos, const Reference
XParameters _xParameter, const connectivity::ORowSetValue _rValue,
sal_Int32 _nType, sal_Int32 _nScale ) const
+{
+if ( _rValue.isNull() )
+{
+_xParameter-setBoolean( nPos++, false );
+// We do the full call so that the right sqlType is passed to setNull
+setParameter( nPos++, _xParameter, _rValue, _nType, _nScale );
+_xParameter-setBoolean( nPos++, true );
+}
+else
+{
+_xParameter-setBoolean( nPos++, true );
+setParameter( nPos++, _xParameter, _rValue, _nType, _nScale );
+_xParameter-setBoolean( nPos++, false );
+}
+}
+
::rtl::OUStringBuffer OKeySet::createKeyFilter()
{
static ::rtl::OUString aAnd(RTL_CONSTASCII_USTRINGPARAM( AND ));
const ::rtl::OUString aQuote= getIdentifierQuoteString();
::rtl::OUStringBuffer aFilter;
-static ::rtl::OUString s_sDot(RTL_CONSTASCII_USTRINGPARAM(.));
-static ::rtl::OUString s_sParam(RTL_CONSTASCII_USTRINGPARAM( = ?));
// create the where clause
ReferenceXDatabaseMetaData xMeta = m_xConnection-getMetaData();
SelectColumnsMetaData::iterator aPosEnd = m_pKeyColumnNames-end();
for(SelectColumnsMetaData::iterator aPosIter =
m_pKeyColumnNames-begin();aPosIter != aPosEnd;)
{
-aFilter.append(::dbtools::quoteTableName(
xMeta,aPosIter-second.sTableName,::dbtools::eInDataManipulation));
-aFilter.append(s_sDot);
-aFilter.append(::dbtools::quoteName(
aQuote,aPosIter-second.sRealName));
-aFilter.append(s_sParam);
+appendOneKeyColumnClause(::dbtools::quoteTableName(
xMeta,aPosIter-second.sTableName,::dbtools::eInDataManipulation),
+ ::dbtools::quoteName(
aQuote,aPosIter-second.sRealName),
+ aFilter);
++aPosIter;
if(aPosIter != aPosEnd)
aFilter.append(aAnd);
@@ -276,8 +310,6 @@ void OKeySet::construct(const Reference XResultSet
_xDriverSet,const ::rtl::O
{
static ::rtl::OUString aAnd(RTL_CONSTASCII_USTRINGPARAM( AND ));
const ::rtl::OUString aQuote= getIdentifierQuoteString();
-static ::rtl::OUString s_sDot(RTL_CONSTASCII_USTRINGPARAM(.));
-static ::rtl::OUString s_sParam(RTL_CONSTASCII_USTRINGPARAM( = ?));
const ::rtl::OUString* pIter = aSeq.getConstArray();
const ::rtl::OUString* pEnd = pIter + aSeq.getLength();
for(;pIter != pEnd;++pIter)
@@ -294,12 +326,11 @@ void OKeySet::construct(const Reference XResultSet
_xDriverSet,const ::rtl::O
for(SelectColumnsMetaData::iterator aPosIter =
(*m_pForeignColumnNames).begin();aPosIter != aPosEnd;++aPosIter)
{
// look for columns not in the source columns to use them
as filter as well
-if ( aFilter.getLength() )
-aFilter.append(aAnd);
-aFilter.append(::dbtools::quoteName(
aQuote,sSelectTableName));
-aFilter.append(s_sDot);
-aFilter.append(::dbtools::quoteName(
aQuote,aPosIter-second.sRealName));
-aFilter.append(s_sParam);
+if ( aFilter.getLength() )
+aFilter.append(aAnd);
+
[Libreoffice-commits] .: dbaccess/source
dbaccess/source/core/api/KeySet.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit ef08c38172f0a19063759a52dd94b70ebd962ed4 Author: Lionel Elie Mamane lio...@mamane.lu Date: Wed Jan 18 13:51:14 2012 +0100 Oups... where is my brown paper bag? diff --git a/dbaccess/source/core/api/KeySet.cxx b/dbaccess/source/core/api/KeySet.cxx index d55f075..a7d9abe 100644 --- a/dbaccess/source/core/api/KeySet.cxx +++ b/dbaccess/source/core/api/KeySet.cxx @@ -1331,7 +1331,7 @@ bool OKeySet::doTryRefetch_throw() throw(SQLException, RuntimeException) m_xSet = m_xStatement-executeQuery(); OSL_ENSURE(m_xSet.is(),No resultset from statement!); -return m_xSet-next() +return m_xSet-next(); } // - ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - unotools/source
unotools/source/i18n/calendarwrapper.cxx | 50 ++---
unotools/source/i18n/charclass.cxx |4 +-
unotools/source/i18n/instance.hxx |2 -
unotools/source/i18n/localedatawrapper.cxx | 28 ++--
4 files changed, 39 insertions(+), 45 deletions(-)
New commits:
commit 1de8ddb72e6a1bc75f3e70b0024c940098948a4f
Author: Eike Rathke er...@redhat.com
Date: Wed Jan 18 14:05:54 2012 +0100
convert one freshly introduced DBG_ERRORFILE to SAL_WARN
diff --git a/unotools/source/i18n/localedatawrapper.cxx
b/unotools/source/i18n/localedatawrapper.cxx
index ed95598..2e8ebf7 100644
--- a/unotools/source/i18n/localedatawrapper.cxx
+++ b/unotools/source/i18n/localedatawrapper.cxx
@@ -1900,15 +1900,9 @@ void LocaleDataWrapper::evaluateLocaleDataChecking()
if ( xLD.is() )
return xLD-getDateAcceptancePatterns( getLocale() );
}
-catch ( Exception e )
+catch (const Exception e)
{
-#ifdef DBG_UTIL
-rtl::OStringBuffer aMsg(getDateAcceptancePatterns: Exception
caught\n);
-aMsg.append(rtl::OUStringToOString(e.Message, RTL_TEXTENCODING_UTF8));
-DBG_ERRORFILE(aMsg.getStr());
-#else
-(void)e;
-#endif
+SAL_WARN( unotools.i18n, getDateAcceptancePatterns: Exception
caught e.Message );
}
return ::com::sun::star::uno::Sequence ::rtl::OUString (0);
}
commit 923934d0f41b5b54c9aa4491958cd1939779902d
Author: Eike Rathke er...@redhat.com
Date: Wed Jan 18 14:02:36 2012 +0100
nitpick, it's i18n, not l18n
diff --git a/unotools/source/i18n/calendarwrapper.cxx
b/unotools/source/i18n/calendarwrapper.cxx
index 2c82da1..23390f9 100644
--- a/unotools/source/i18n/calendarwrapper.cxx
+++ b/unotools/source/i18n/calendarwrapper.cxx
@@ -70,7 +70,7 @@ void CalendarWrapper::loadDefaultCalendar( const
::com::sun::star::lang::Locale
}
catch (const Exception e)
{
-SAL_WARN( unotools.l18n, loadDefaultCalendar: Exception caught
e.Message );
+SAL_WARN( unotools.i18n, loadDefaultCalendar: Exception caught
e.Message );
}
}
@@ -84,7 +84,7 @@ void CalendarWrapper::loadCalendar( const ::rtl::OUString
rUniqueID, const ::co
}
catch (const Exception e)
{
-SAL_WARN( unotools.l18n, loadCalendar: Exception caught requested:
+SAL_WARN( unotools.i18n, loadCalendar: Exception caught requested:
rUniqueID Locale: rLocale.Language _
rLocale.Country e.Message );
}
}
@@ -99,7 +99,7 @@ void CalendarWrapper::loadCalendar( const ::rtl::OUString
rUniqueID, const ::co
}
catch (const Exception e)
{
-SAL_WARN( unotools.l18n, getAllCalendars: Exception caught
e.Message );
+SAL_WARN( unotools.i18n, getAllCalendars: Exception caught
e.Message );
}
return ::com::sun::star::uno::Sequence ::rtl::OUString (0);
@@ -115,7 +115,7 @@ void CalendarWrapper::loadCalendar( const ::rtl::OUString
rUniqueID, const ::co
}
catch (const Exception e)
{
-SAL_WARN( unotools.l18n, getUniqueID: Exception caught
e.Message );
+SAL_WARN( unotools.i18n, getUniqueID: Exception caught
e.Message );
}
return ::rtl::OUString();
}
@@ -130,7 +130,7 @@ void CalendarWrapper::setDateTime( double nTimeInDays )
}
catch (const Exception e)
{
-SAL_WARN( unotools.l18n, setDateTime: Exception caught
e.Message );
+SAL_WARN( unotools.i18n, setDateTime: Exception caught
e.Message );
}
}
@@ -144,7 +144,7 @@ double CalendarWrapper::getDateTime() const
}
catch (const Exception e)
{
-SAL_WARN( unotools.l18n, getDateTime: Exception caught
e.Message );
+SAL_WARN( unotools.i18n, getDateTime: Exception caught
e.Message );
}
return 0.0;
}
@@ -168,7 +168,7 @@ sal_Int32 CalendarWrapper::getCombinedOffsetInMillis(
}
catch (const Exception e)
{
-SAL_WARN( unotools.l18n, setLocalDateTime: Exception caught
e.Message );
+SAL_WARN( unotools.i18n, setLocalDateTime: Exception caught
e.Message );
}
return nOffset;
}
@@ -234,7 +234,7 @@ void CalendarWrapper::setLocalDateTime( double nTimeInDays )
}
catch (const Exception e)
{
-SAL_WARN( unotools.l18n, setLocalDateTime: Exception caught
e.Message );
+SAL_WARN( unotools.i18n, setLocalDateTime: Exception caught
e.Message );
}
}
@@ -254,7 +254,7 @@ double CalendarWrapper::getLocalDateTime() const
}
catch (const Exception e)
{
-SAL_WARN( unotools.l18n, getLocalDateTime: Exception caught
e.Message );
+SAL_WARN( unotools.i18n, getLocalDateTime: Exception caught
e.Message );
}
return 0.0;
}
@@ -269,7 +269,7 @@ void CalendarWrapper::setValue( sal_Int16 nFieldIndex,
sal_Int16 nValue )
}
catch (const Exception e)
{
-SAL_WARN( unotools.l18n, setValue: Exception caught e.Message
);
+
[Libreoffice-commits] .: 2 commits - scp2/source
scp2/source/ooo/ure.scp | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) New commits: commit 7f1d77d9fecdd710d2b2fd17be91a61665baf846 Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Wed Jan 18 15:13:15 2012 +0100 If COM==_MSC, then OS==WNT and also GUI==WNT diff --git a/scp2/source/ooo/ure.scp b/scp2/source/ooo/ure.scp index a7cafa8..d17c0b7 100644 --- a/scp2/source/ooo/ure.scp +++ b/scp2/source/ooo/ure.scp @@ -439,7 +439,7 @@ File gid_File_Dl_LogUnoUno Styles = (PACKED, VERSION_INDEPENDENT_COMP_ID); End -#if defined WNT defined _MSC +#if defined _MSC File gid_File_Dl_Cli_Uno LIB_FILE_BODY; Dir = SCP2_URE_DL_DIR; @@ -449,7 +449,7 @@ File gid_File_Dl_Cli_Uno End #endif -#if defined WNT defined _MSC +#if defined _MSC File gid_File_Dl_Cli_Ure_Assembly TXT_FILE_BODY; @@ -466,7 +466,7 @@ End #endif -#if defined WNT defined _MSC +#if defined _MSC File gid_File_Dl_Policy_Cli_Ure_Assembly TXT_FILE_BODY; @@ -483,7 +483,7 @@ End #endif -#if defined WNT defined _MSC +#if defined _MSC File gid_File_Dl_Policy_Cli_Ure_Config TXT_FILE_BODY; @@ -495,7 +495,7 @@ End #endif -#if defined WNT defined _MSC +#if defined _MSC File gid_File_Dl_Cli_Basetypes_Assembly TXT_FILE_BODY; @@ -512,7 +512,7 @@ End #endif -#if defined WNT defined _MSC +#if defined _MSC File gid_File_Dl_Policy_Cli_Basetypes_Assembly TXT_FILE_BODY; @@ -528,7 +528,7 @@ File gid_File_Dl_Policy_Cli_Basetypes_Assembly End #endif -#if defined WNT defined _MSC +#if defined _MSC File gid_File_Dl_Policy_Cli_Basetypes_Config TXT_FILE_BODY; @@ -541,7 +541,7 @@ End #endif -#if defined WNT defined _MSC +#if defined _MSC File gid_File_Dl_Cli_Uretypes_Assembly TXT_FILE_BODY; @@ -558,7 +558,7 @@ End #endif -#if defined WNT defined _MSC +#if defined _MSC File gid_File_Dl_Policy_Cli_Uretypes_Assembly TXT_FILE_BODY; @@ -575,7 +575,7 @@ End #endif -#if defined WNT defined _MSC +#if defined _MSC File gid_File_Dl_Policy_Cli_Uretypes_Config TXT_FILE_BODY; @@ -587,7 +587,7 @@ End #endif -#if defined WNT defined _MSC +#if defined _MSC File gid_File_Lib_Cli_Cppuhelper_Assembly TXT_FILE_BODY; @@ -604,7 +604,7 @@ End #endif -#if defined WNT defined _MSC +#if defined _MSC File gid_File_Lib_Policy_Cli_Cppuhelper_Assembly TXT_FILE_BODY; @@ -621,7 +621,7 @@ End #endif -#if defined WNT defined _MSC +#if defined _MSC File gid_File_Lib_Policy_Cli_Cppuhelper_Config TXT_FILE_BODY; @@ -868,7 +868,7 @@ File gid_File_Dl_Stlport Name = SCP2_URE_DL_NORMAL(stlport_sunpro); #endif #endif -#elif defined WNT defined _MSC +#elif defined _MSC #if defined _DEBUG_RUNTIME Name = SCP2_URE_DL_NORMAL(stlport_vc71_stldebug45); #else commit aa318df8355334811649055494a03d6336becf66 Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Wed Jan 18 15:08:02 2012 +0100 Package stlport on Windows when requested (fdo#37561) diff --git a/scp2/source/ooo/ure.scp b/scp2/source/ooo/ure.scp index aece726..a7cafa8 100644 --- a/scp2/source/ooo/ure.scp +++ b/scp2/source/ooo/ure.scp @@ -868,7 +868,7 @@ File gid_File_Dl_Stlport Name = SCP2_URE_DL_NORMAL(stlport_sunpro); #endif #endif -#elif defined WNT ((_MSC_VER == 1500) || (_MSC_VER == 1600)) +#elif defined WNT defined _MSC #if defined _DEBUG_RUNTIME Name = SCP2_URE_DL_NORMAL(stlport_vc71_stldebug45); #else ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-5' - scp2/source
scp2/source/ooo/ure.scp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 33d0aec1424fa568c026f5569d18b2aab8815019 Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Wed Jan 18 15:08:02 2012 +0100 Package stlport on Windows when requested (fdo#37561) Signed-off-by: Michael Meeks michael.me...@suse.com diff --git a/scp2/source/ooo/ure.scp b/scp2/source/ooo/ure.scp index aece726..a7cafa8 100644 --- a/scp2/source/ooo/ure.scp +++ b/scp2/source/ooo/ure.scp @@ -868,7 +868,7 @@ File gid_File_Dl_Stlport Name = SCP2_URE_DL_NORMAL(stlport_sunpro); #endif #endif -#elif defined WNT ((_MSC_VER == 1500) || (_MSC_VER == 1600)) +#elif defined WNT defined _MSC #if defined _DEBUG_RUNTIME Name = SCP2_URE_DL_NORMAL(stlport_vc71_stldebug45); #else ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 3 commits - basegfx/inc basegfx/source basegfx/test
basegfx/inc/basegfx/polygon/b2dpolypolygontools.hxx |3
basegfx/source/polygon/b2dsvgpolypolygon.cxx| 10 +++
basegfx/test/boxclipper.cxx | 65 +---
basegfx/test/clipstate.cxx |9 +-
basegfx/test/genericclipper.cxx | 61 +-
5 files changed, 115 insertions(+), 33 deletions(-)
New commits:
commit 152eaa298545821ec842499947236aeb99696427
Author: Thorsten Behrens tbehr...@suse.com
Date: Wed Jan 18 15:25:11 2012 +0100
Add more unit test coverage for generic clipper
With the changes Julien brought in via
66fd9a610cd876c236486a2089d8d58dca866e25, thought it was a good idea
to cover those code paths as well - done now, via the
checkCrossoverSolver() tests.
diff --git a/basegfx/test/genericclipper.cxx b/basegfx/test/genericclipper.cxx
index d3b79ce..496f348 100644
--- a/basegfx/test/genericclipper.cxx
+++ b/basegfx/test/genericclipper.cxx
@@ -143,17 +143,54 @@ public:
validate(validateDiff, pValid, tools::solvePolygonOperationDiff);
}
+void validateCrossover(const char* pName,
+ const char* pInputSvgD,
+ const char* pValidSvgD)
+{
+rtl::OUString aInput=rtl::OUString::createFromAscii(pInputSvgD);
+rtl::OUString aValid=rtl::OUString::createFromAscii(pValidSvgD);
+B2DPolyPolygon aInputPoly, aValidPoly;
+
+tools::importFromSvgD(aInputPoly, aInput);
+tools::importFromSvgD(aValidPoly, aValid);
+
+CPPUNIT_ASSERT_MESSAGE(
+pName,
+basegfx::tools::exportToSvgD(
+tools::solveCrossovers(aInputPoly)) == aValid);
+}
+
void checkCrossoverSolver()
{
-B2DPolyPolygon aPoly;
-tools::importFromSvgD(
-aPoly,
-::rtl::OUString(
-RTL_CONSTASCII_USTRINGPARAM(
-m0 0 v 5 h 3 h 1 h 1 h 1 v -2 v -3 z
-m3 7 v -2 h 1 h 1 h 1 v -2 h 1 v 3 z)));
-
-tools::solveCrossovers(aPoly);
+// partially intersecting polygons, with a common subsection
+validateCrossover(
+partially intersecting,
+m0 0 v 5 h 3 h 1 h 1 h 1 v -2 v -3 z
+ m3 7 v -2 h 1 h 1 h 1 v -2 h 1 v 3 z,
+m0 0v5h3 1 1 1v-2-3zm3 7v-2h1 1 1v-2h1v3z);
+
+// first polygon is identical to subset of second polygon
+validateCrossover(
+full subset,
+m0 0 v 5 h 3 h 1 h 1 v -5 z
+ m3 10 v -5 h 1 h 1 v -5 h -5 v 5 h 3 z,
+m0 0v5h3 1 1v-5zm3 10v-5zm1-5h1v-5h-5v5h3z);
+
+// first polygon is identical to subset of second polygon, but
+// oriented in the opposite direction
+validateCrossover(
+full subset, opposite direction,
+m0 0 v 5 h 3 h 1 h 1 v -5 z
+ m3 10 v -5 h -1 h -1 h -1 v -5 h 5 v 5 h 2 z,
+m0 0v5h1 1 1-1-1-1v-5h5v5-5zm4 5h1 2l-4 5v-5z);
+
+// first polygon is identical to subset of second polygon, and
+// has a curve segment (triggers different code path)
+validateCrossover(
+full subset, plus curves,
+m0 0 v 5 h 3 h 1 h 1 c 2 0 2 0 0 -5 z
+ m3 10 v -5 h 1 h 1 c 2 0 2 0 0 -5 h -5 v 5 h 3 z,
+m0 0v5h3 1 1c2 0 2 0 0-5zm3 10v-5zm1-5h1c2 0 2 0 0-5h-5v5h3z);
}
// Change the following lines only, if you add, remove or rename
commit 13e1fe0561fa80628c031065ad91adfdeade
Author: Thorsten Behrens tbehr...@suse.com
Date: Tue Jan 17 16:32:43 2012 +0100
Fix error in handling 'z' for svg:d string parsing
Previously 'z' did not update the current point to the start
point of the subpath, as required by
http://www.w3.org/TR/SVG/paths.html#PathDataClosePathCommand. Fixed
now, and adapted all the unit tests.
diff --git a/basegfx/inc/basegfx/polygon/b2dpolypolygontools.hxx
b/basegfx/inc/basegfx/polygon/b2dpolypolygontools.hxx
index 0302441..37d2cb5 100644
--- a/basegfx/inc/basegfx/polygon/b2dpolypolygontools.hxx
+++ b/basegfx/inc/basegfx/polygon/b2dpolypolygontools.hxx
@@ -123,8 +123,7 @@ namespace basegfx
/** Read poly-polygon from SVG.
This function imports a poly-polygon from an SVG-D
-attribute. Currently, elliptical arc elements are not yet
-supported (and ignored during parsing).
+attribute.
@param o_rPolyPoly
The output poly-polygon
diff --git a/basegfx/source/polygon/b2dsvgpolypolygon.cxx
b/basegfx/source/polygon/b2dsvgpolypolygon.cxx
index 7a34219..863adf5 100644
--- a/basegfx/source/polygon/b2dsvgpolypolygon.cxx
+++ b/basegfx/source/polygon/b2dsvgpolypolygon.cxx
@@ -239,6 +239,14 @@ namespace basegfx
// remember closed state of current polygon
bIsClosed = true;
+
+// update current point -
[Libreoffice-commits] .: configure.in scp2/inc scp2/source
configure.in |1 + scp2/inc/macros.inc |2 +- scp2/source/ooo/common_brand.scp |2 +- scp2/source/ooo/file_library_ooo.scp |6 +++--- scp2/source/ooo/makefile.mk |4 scp2/source/ooo/ure.scp | 28 ++-- 6 files changed, 20 insertions(+), 23 deletions(-) New commits: commit d3f17ac97d1d90069fd66ccc63caab0f0472dc7d Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Wed Jan 18 16:19:23 2012 +0100 _MSC_VER is compiler define and cpp.lcc needs to be taught about it diff --git a/configure.in b/configure.in index 251cfa8..bb8abe6 100644 --- a/configure.in +++ b/configure.in @@ -2582,6 +2582,7 @@ cygwin*) AC_MSG_ERROR([Unsupported host_cpu $host_cpu for host_os $host_os]) ;; esac + SCPDEFS=$SCPDEFS -D_MSC_VER ;; darwin*) diff --git a/scp2/inc/macros.inc b/scp2/inc/macros.inc index c0f2eff..820a9e2 100755 --- a/scp2/inc/macros.inc +++ b/scp2/inc/macros.inc @@ -516,7 +516,7 @@ End #define SCP2_URE_DL_COMID_NORMAL(n) n STRING(COMID) .dll #define SCP2_URE_DL_UNO_VER(n, v) n v .dll #define SCP2_URE_SHARE_DIR gid_Dir_Common_Ure -#if defined _MSC +#if defined _MSC_VER #define SCP2_URE_DL_UNO_COMID_VER(n, v) n v STRING(COMID) .dll #if defined _DEBUG_RUNTIME #define SCP2_STDLP_DEBUG d diff --git a/scp2/source/ooo/common_brand.scp b/scp2/source/ooo/common_brand.scp index 474d537..6c6fb66 100644 --- a/scp2/source/ooo/common_brand.scp +++ b/scp2/source/ooo/common_brand.scp @@ -554,7 +554,7 @@ End #endif // use this for high detail file open dialog = 5.1 windows -#if defined(WNT) defined( _MSC ) +#if defined( _MSC_VER ) File gid_Brand_File_Bin_Soffice_Bin_Manifest TXT_FILE_BODY; Styles = (PACKED); diff --git a/scp2/source/ooo/file_library_ooo.scp b/scp2/source/ooo/file_library_ooo.scp index 2565973..3d46339 100644 --- a/scp2/source/ooo/file_library_ooo.scp +++ b/scp2/source/ooo/file_library_ooo.scp @@ -97,7 +97,7 @@ STD_LIB_FILE(gid_File_Lib_Charttools, charttools) STD_LIB_FILE(gid_File_Lib_Chartview, chartview) -#if defined WNT defined _MSC +#if defined _MSC_VER File gid_File_Lib_Cli_Oootypes_Assembly TXT_FILE_BODY; @@ -114,7 +114,7 @@ End #endif -#if defined WNT defined _MSC +#if defined _MSC_VER File gid_File_Lib_Policy_Cli_Oootypes_Assembly TXT_FILE_BODY; Styles = (PACKED, ASSEMBLY, DONTRENAMEINPATCH); @@ -130,7 +130,7 @@ End #endif -#if defined WNT defined _MSC +#if defined _MSC_VER File gid_File_Lib_Policy_Cli_Oootypes_Config TXT_FILE_BODY; diff --git a/scp2/source/ooo/makefile.mk b/scp2/source/ooo/makefile.mk index 87cc67c..ccba4f8 100644 --- a/scp2/source/ooo/makefile.mk +++ b/scp2/source/ooo/makefile.mk @@ -35,10 +35,6 @@ TARGETTYPE=CUI .INCLUDE : settings.mk .INCLUDE : i18npool/version.mk -.IF $(COM) == MSC -SCPDEFS+=-D_MSC -.ENDIF - .IF $(ENABLE_ONLINE_UPDATE)!= SCPDEFS+=-DENABLE_ONLINE_UPDATE .ENDIF diff --git a/scp2/source/ooo/ure.scp b/scp2/source/ooo/ure.scp index d17c0b7..be2418f 100644 --- a/scp2/source/ooo/ure.scp +++ b/scp2/source/ooo/ure.scp @@ -439,7 +439,7 @@ File gid_File_Dl_LogUnoUno Styles = (PACKED, VERSION_INDEPENDENT_COMP_ID); End -#if defined _MSC +#if defined _MSC_VER File gid_File_Dl_Cli_Uno LIB_FILE_BODY; Dir = SCP2_URE_DL_DIR; @@ -449,7 +449,7 @@ File gid_File_Dl_Cli_Uno End #endif -#if defined _MSC +#if defined _MSC_VER File gid_File_Dl_Cli_Ure_Assembly TXT_FILE_BODY; @@ -466,7 +466,7 @@ End #endif -#if defined _MSC +#if defined _MSC_VER File gid_File_Dl_Policy_Cli_Ure_Assembly TXT_FILE_BODY; @@ -483,7 +483,7 @@ End #endif -#if defined _MSC +#if defined _MSC_VER File gid_File_Dl_Policy_Cli_Ure_Config TXT_FILE_BODY; @@ -495,7 +495,7 @@ End #endif -#if defined _MSC +#if defined _MSC_VER File gid_File_Dl_Cli_Basetypes_Assembly TXT_FILE_BODY; @@ -512,7 +512,7 @@ End #endif -#if defined _MSC +#if defined _MSC_VER File gid_File_Dl_Policy_Cli_Basetypes_Assembly TXT_FILE_BODY; @@ -528,7 +528,7 @@ File gid_File_Dl_Policy_Cli_Basetypes_Assembly End #endif -#if defined _MSC +#if defined _MSC_VER File gid_File_Dl_Policy_Cli_Basetypes_Config TXT_FILE_BODY; @@ -541,7 +541,7 @@ End #endif -#if defined _MSC +#if defined _MSC_VER File gid_File_Dl_Cli_Uretypes_Assembly TXT_FILE_BODY; @@ -558,7 +558,7 @@ End #endif -#if defined _MSC +#if defined _MSC_VER File gid_File_Dl_Policy_Cli_Uretypes_Assembly TXT_FILE_BODY; @@ -575,7 +575,7 @@ End #endif -#if defined _MSC +#if defined _MSC_VER File gid_File_Dl_Policy_Cli_Uretypes_Config TXT_FILE_BODY; @@ -587,7 +587,7 @@ End #endif -#if defined _MSC +#if defined _MSC_VER File gid_File_Lib_Cli_Cppuhelper_Assembly TXT_FILE_BODY; @@ -604,7 +604,7 @@ End #endif -#if defined _MSC +#if defined _MSC_VER File gid_File_Lib_Policy_Cli_Cppuhelper_Assembly TXT_FILE_BODY; @@ -621,7
[Libreoffice-commits] .: Branch 'libreoffice-3-5' - basegfx/inc basegfx/source basegfx/test
basegfx/inc/basegfx/polygon/b2dpolypolygontools.hxx |3 -
basegfx/source/polygon/b2dsvgpolypolygon.cxx| 10 +++
basegfx/test/boxclipper.cxx | 57 +---
basegfx/test/clipstate.cxx |7 +-
basegfx/test/genericclipper.cxx | 20 +--
5 files changed, 71 insertions(+), 26 deletions(-)
New commits:
commit 85c6fc38dabf227f98e3b5259188e8ccd3521739
Author: Thorsten Behrens tbehr...@suse.com
Date: Tue Jan 17 16:32:43 2012 +0100
Fix error in handling 'z' for svg:d string parsing
Previously 'z' did not update the current point to the start
point of the subpath, as required by
http://www.w3.org/TR/SVG/paths.html#PathDataClosePathCommand. Fixed
now, and adapted all the unit tests.
Signed-off-by: Fridrich Å trba fridrich.st...@bluewin.ch
diff --git a/basegfx/inc/basegfx/polygon/b2dpolypolygontools.hxx
b/basegfx/inc/basegfx/polygon/b2dpolypolygontools.hxx
index 0302441..37d2cb5 100644
--- a/basegfx/inc/basegfx/polygon/b2dpolypolygontools.hxx
+++ b/basegfx/inc/basegfx/polygon/b2dpolypolygontools.hxx
@@ -123,8 +123,7 @@ namespace basegfx
/** Read poly-polygon from SVG.
This function imports a poly-polygon from an SVG-D
-attribute. Currently, elliptical arc elements are not yet
-supported (and ignored during parsing).
+attribute.
@param o_rPolyPoly
The output poly-polygon
diff --git a/basegfx/source/polygon/b2dsvgpolypolygon.cxx
b/basegfx/source/polygon/b2dsvgpolypolygon.cxx
index 7a34219..863adf5 100644
--- a/basegfx/source/polygon/b2dsvgpolypolygon.cxx
+++ b/basegfx/source/polygon/b2dsvgpolypolygon.cxx
@@ -239,6 +239,14 @@ namespace basegfx
// remember closed state of current polygon
bIsClosed = true;
+
+// update current point - we're back at the start
+if( aCurrPoly.count() )
+{
+const B2DPoint aFirst( aCurrPoly.getB2DPoint(0) );
+nLastX = aFirst.getX();
+nLastY = aFirst.getY();
+}
break;
}
@@ -1033,6 +1041,8 @@ namespace basegfx
if(aPolygon.isClosed())
{
aResult.append(lcl_getCommand('Z', 'z',
bUseRelativeCoordinates));
+// return to first point
+aCurrentSVGPosition = aPolygon.getB2DPoint(0);
}
}
}
diff --git a/basegfx/test/boxclipper.cxx b/basegfx/test/boxclipper.cxx
index 05cbb7b..c34b989 100644
--- a/basegfx/test/boxclipper.cxx
+++ b/basegfx/test/boxclipper.cxx
@@ -256,7 +256,6 @@ public:
tools::importFromSvgD(
aTmp2,
aSvg));
-
CPPUNIT_ASSERT_MESSAGE(
sName,
normalizePoly(aTmp2) == normalizePoly(aTmp1));
@@ -264,23 +263,45 @@ public:
void verifyPoly()
{
-const char* disjunct=m100 100v-200h-200v200zm1100 900v-200h-200v200z;
-const char* equal=m100 100v-200h-200v200zm200 0v-200h-200v200h200z;
-const char* intersectionN=m100 0v-100h-200v100zm200
100v-200-100h-200v100 200z;
-const char* intersectionE=m100 100v-200h-100v200zm200
0v-200h-200-100v200h100z;
-const char* intersectionS=m100 100v-200h-200v200 100h200v-100zm0
0v-100h-200v100z;
-const char* intersectionW=m0 100v-200h-100v200zm200
0v-200h-200-100v200h100z;
-const char* intersectionNE=m100 0v-100h-100v100zm200
0v-200h-200v100h-100v200h200v-100z;
-const char* intersectionSE=m200
200v-200h-100v-100h-200v200h100v100zm100-100v-100h-100v100z;
-const char* intersectionSW=m0 100v-100h-100v100zm200
0v-200h-200v100h-100v200h200v-100z;
-const char* intersectionNW=m100
100v-200h-100v-100h-200v200h100v100zm100-100v-100h-100v100z;
-const char* ringIntersection=m150 150v-100h-100v100zm300
0v-300h-200v-200h-300v300h200v100h-200v300h300v-200zm0-200v-100h-100v100z;
-const char* ringIntersection2=m-50-50v-100h-100v100zm100
200v-100h-100v100zm500
0v-300h-200v-200h-300v200h-200v300h200v200h300v-200zm-200-100v-100h100v100zm100-100v-100h-100v100zm100
200v-100h-100v100z;
-const char* ringIntersectExtraStrip=m-50-50v-100h-100v100zm100
200v-100h-100v100zm500
0v-300h-200v-200h-300v200h-200v300h200v200h300v-200zm-200-100v-100h100v25h-50v50h50v25zm150-25v-50h-150v50zm100-75v-100h-100v100zm100
200v-100h-100v100z;
-// TODO: old clipper impl. debug difference
-//const char* complexIntersections=m100 0h-100v-100 100h-100
100v100-100zm0 0zm200 0h-100v-100h-100v-100 100h-100v100h-100
100v100h100v100-100h100v-100zm0 0h-100v-100 100h-100
[Libreoffice-commits] .: sw/source
sw/source/filter/xml/ForbiddenCharactersEnum.hxx | 44 ---
sw/source/filter/xml/xmlexp.cxx |1
sw/source/filter/xml/xmlimp.cxx |1
3 files changed, 46 deletions(-)
New commits:
commit 15e35093e86b49b3e8129108fa358adc0c865fbe
Author: Takeshi Abe t...@fixedpoint.jp
Date: Thu Jan 19 02:25:23 2012 +0900
removed unused header
diff --git a/sw/source/filter/xml/ForbiddenCharactersEnum.hxx
b/sw/source/filter/xml/ForbiddenCharactersEnum.hxx
deleted file mode 100644
index 374d705..000
--- a/sw/source/filter/xml/ForbiddenCharactersEnum.hxx
+++ /dev/null
@@ -1,44 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- *
- * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
- *
- * Copyright 2000, 2010 Oracle and/or its affiliates.
- *
- * OpenOffice.org - a multi-platform office productivity suite
- *
- * This file is part of OpenOffice.org.
- *
- * OpenOffice.org is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Lesser General Public License version 3
- * only, as published by the Free Software Foundation.
- *
- * OpenOffice.org is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU Lesser General Public License version 3 for more details
- * (a copy is included in the LICENSE file that accompanied this code).
- *
- * You should have received a copy of the GNU Lesser General Public License
- * version 3 along with OpenOffice.org. If not, see
- * http://www.openoffice.org/license.html
- * for a copy of the LGPLv3 License.
- *
- /
-
-#ifndef _FORBIDDEN_CHARACTERS_ENUM_HXX
-#define _FORBIDDEN_CHARACTERS_ENUM_HXX
-
-enum ForbiddenCharactersEnum
-{
-SW_FORBIDDEN_CHARACTER_LANGUAGE,
-SW_FORBIDDEN_CHARACTER_COUNTRY,
-SW_FORBIDDEN_CHARACTER_VARIANT,
-SW_FORBIDDEN_CHARACTER_BEGIN_LINE,
-SW_FORBIDDEN_CHARACTER_END_LINE,
-SW_FORBIDDEN_CHARACTER_MAX
-};
-
-#endif
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/filter/xml/xmlexp.cxx b/sw/source/filter/xml/xmlexp.cxx
index 7d6d0e9..9faf522 100644
--- a/sw/source/filter/xml/xmlexp.cxx
+++ b/sw/source/filter/xml/xmlexp.cxx
@@ -63,7 +63,6 @@
#include docary.hxx
#include editeng/unolingu.hxx
#include editeng/forbiddencharacterstable.hxx
-#include ForbiddenCharactersEnum.hxx
#include comphelper/servicehelper.hxx
// for locking SolarMutex: svapp + mutex
diff --git a/sw/source/filter/xml/xmlimp.cxx b/sw/source/filter/xml/xmlimp.cxx
index 36643e4..a59ebf7 100644
--- a/sw/source/filter/xml/xmlimp.cxx
+++ b/sw/source/filter/xml/xmlimp.cxx
@@ -58,7 +58,6 @@
#include svx/xmlgrhlp.hxx
#include svx/xmleohlp.hxx
#include sfx2/printer.hxx
-#include ForbiddenCharactersEnum.hxx
#include xmloff/xmluconv.hxx
#include unotools/saveopt.hxx
#include tools/diagnose_ex.h
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: desktop/Executable_soffice.bin.mk desktop/Module_desktop.mk desktop/util desktop/WinResTarget_sofficebin.mk desktop/WinResTarget_soffice.mk officecfg/registry reportbuilder/re
desktop/Executable_soffice.bin.mk |2 desktop/Module_desktop.mk |1 desktop/WinResTarget_soffice.mk |2 desktop/WinResTarget_sofficebin.mk | 49 ++ desktop/util/officeloader.rc | 36 +-- officecfg/registry/data/org/openoffice/Setup.xcu | 22 ++-- reportbuilder/registry/data/org/openoffice/Setup.xcu |2 scp2/inc/macros.inc |2 scp2/source/base/registryitem_base.scp |2 scp2/source/binfilter/registryitem_binfilter.scp | 16 +-- scp2/source/calc/registryitem_calc.scp | 26 ++--- scp2/source/draw/registryitem_draw.scp | 12 +- scp2/source/impress/registryitem_impress.scp | 28 ++--- scp2/source/math/registryitem_math.scp |8 - scp2/source/ooo/registryitem_ooo.scp |4 scp2/source/writer/registryitem_writer.scp | 32 +++--- setup_native/source/win32/customactions/reg4msdoc/registrationcontextinformation.cxx | 17 +-- setup_native/source/win32/customactions/reg4msdoc/registrationcontextinformation.hxx |1 setup_native/source/win32/customactions/shellextensions/startmenuicon.cxx |4 sfx2/source/appl/shutdowniconunx.cxx |6 - sfx2/source/appl/shutdowniconw32.cxx | 18 +-- vcl/inc/svids.hrc |8 - vcl/inc/vcl/syswin.hxx | 16 +-- vcl/unx/generic/window/salframe.cxx |2 24 files changed, 166 insertions(+), 150 deletions(-) New commits: commit ceb14e0143fb72b34421f6fb81ff1fb1842cb500 Author: Andras Timar ati...@suse.com Date: Wed Jan 18 13:11:11 2012 +0100 fdo#37740 remove duplicate icons from soffice.bin/soffice.exe diff --git a/desktop/Executable_soffice.bin.mk b/desktop/Executable_soffice.bin.mk index 8815432..00fb005 100644 --- a/desktop/Executable_soffice.bin.mk +++ b/desktop/Executable_soffice.bin.mk @@ -103,6 +103,6 @@ $(eval $(call gb_Executable_set_ldflags,\ endif -$(eval $(call gb_Executable_add_nativeres,$(sofficebin),soffice/src)) +$(eval $(call gb_Executable_add_nativeres,$(sofficebin),sofficebin/src)) # vim: set ts=4 sw=4 et: diff --git a/desktop/Module_desktop.mk b/desktop/Module_desktop.mk index 3d0045c..eb83f82 100644 --- a/desktop/Module_desktop.mk +++ b/desktop/Module_desktop.mk @@ -98,6 +98,7 @@ $(eval $(call gb_Module_add_targets,desktop,\ WinResTarget_sdraw \ WinResTarget_simpress \ WinResTarget_soffice \ +WinResTarget_sofficebin \ WinResTarget_smath \ WinResTarget_sweb \ WinResTarget_swriter \ diff --git a/desktop/WinResTarget_soffice.mk b/desktop/WinResTarget_soffice.mk index b15..fe66aa5 100644 --- a/desktop/WinResTarget_soffice.mk +++ b/desktop/WinResTarget_soffice.mk @@ -44,6 +44,6 @@ $(eval $(call gb_WinResTarget_add_dependency,soffice/src,\ sysui/desktop/icons/main_app.ico \ )) -$(eval $(call gb_WinResTarget_add_file,soffice/src,desktop/util/officeloader)) +$(eval $(call gb_WinResTarget_add_file,soffice/src,desktop/win32/source/applauncher/launcher)) # vim: set ts=4 sw=4 et: diff --git a/desktop/WinResTarget_sofficebin.mk b/desktop/WinResTarget_sofficebin.mk new file mode 100644 index 000..334c9b7 --- /dev/null +++ b/desktop/WinResTarget_sofficebin.mk @@ -0,0 +1,49 @@ +# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*- +# Version: MPL 1.1 / GPLv3+ / LGPLv3+ +# +# The contents of this file are subject to the Mozilla Public License Version +# 1.1 (the License); you may not use this file except in compliance with +# the License or as specified alternatively below. You may obtain a copy of +# the License at http://www.mozilla.org/MPL/ +# +# Software distributed under the License is distributed on an AS IS basis, +# WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License +# for the specific language governing rights and limitations under the +# License. +# +# Major Contributor(s): +# Copyright (C) 2011 Red Hat, Inc., David Tardon dtar...@redhat.com +# (initial developer) +# +# All Rights Reserved. +# +# For minor contributions see the git repository.
[Libreoffice-commits] .: extensions/source svx/inc
extensions/source/bibliography/bib.hrc |1
svx/inc/globlmn_tmpl.hrc | 721 -
2 files changed, 722 deletions(-)
New commits:
commit bb921f1df6bb12671777e3f3e4a8caa6f7791c3d
Author: Ivan Timofeev timofeev@gmail.com
Date: Wed Jan 18 23:23:05 2012 +0400
svx: remove unused definitions in globlmn_tmpl.hrc
diff --git a/extensions/source/bibliography/bib.hrc
b/extensions/source/bibliography/bib.hrc
index 480a820..9ca5f3d 100644
--- a/extensions/source/bibliography/bib.hrc
+++ b/extensions/source/bibliography/bib.hrc
@@ -62,7 +62,6 @@
#define RID_MAIN_ME_DBSOURCE(RID_BIB_MENU +10)
#define RID_MAIN_DELETE_RECORD (RID_BIB_MENU +11)
#define RID_MAIN_INSERT_RECORD (RID_BIB_MENU +12)
-#define MN_TEMPLATES(RID_BIB_MENU +13) // to make makro
ITEM_FILE_DOCTEMPLATE happy...
#define RID_POPUP_ME_VIEW (RID_BIB_MENU +50)
diff --git a/svx/inc/globlmn_tmpl.hrc b/svx/inc/globlmn_tmpl.hrc
index 632a4c5..f6b8f73 100755
--- a/svx/inc/globlmn_tmpl.hrc
+++ b/svx/inc/globlmn_tmpl.hrc
@@ -50,21 +50,6 @@
Command = .uno:ChangeControlType ; \
Text [ en-US ] = ~Replace with; \
-#define ITEM_FORMAT_TEMPLATECATALOG \
-Identifier = SID_STYLE_CATALOG ; \
-Command = .uno:StyleCatalog ; \
-Text [ en-US ] = ~Catalog... ; \
-
-#define ITEM_FORMAT_TEMPLATE \
-Identifier = SID_STYLE_DESIGNER ; \
-Command = .uno:DesignerDialog ; \
-Text [ en-US ] = St~ylist ; \
-
-#define ITEM_FORMAT_AUTOFORMAT \
-Identifier = SID_AUTOFORMAT ; \
-Command = .uno:AutoFormat ; \
-Text [ en-US ] = Auto~Format... ;\
-
#define ITEM_FORMAT_CHAR_DLG \
Identifier = SID_CHAR_DLG ; \
Command = .uno:FontDialog ; \
@@ -261,394 +246,22 @@
Command = .uno:ToggleObjectBezierMode ; \
Text [ en-US ] = Edit ~Points ;\
-#define ITEM_FILE_PICKLIST \
-Identifier = SID_PICKLIST ; \
-Command = .uno:PickList ; \
-Text [ en-US ] = ~File ; \
-
-#define ITEM_FILE_NEWDOC \
-Identifier = SID_NEWDOCDIRECT ; \
-Command = .uno:AddDirect ; \
-Text [ en-US ] = ~New ;\
-
-#define ITEM_FILE_OPENDOC \
-Identifier = SID_OPENDOC ; \
-Command = .uno:Open ; \
-Text [ en-US ] = ~Open... ;\
-
-
-#define ITEM_FILE_AUTOPILOT \
-MenuItem\
-{\
-Identifier = SID_AUTOPILOTMENU ; \
-Command = .uno:AutoPilotMenu ; \
-Text [ en-US ] = A~utoPilot ; \
-};
-
-#define ITEM_FILE_CLOSEDOC \
-Identifier = SID_CLOSEDOC ; \
-Command = .uno:CloseDoc ; \
-Text [ en-US ] = ~Close ;\
-
-#define ITEM_FILE_SAVEDOC \
-Identifier = SID_SAVEDOC ; \
-Command = .uno:Save ; \
-Text [ en-US ] = ~Save ; \
-
-#define ITEM_FILE_SAVEDOCS \
-Identifier = SID_SAVEDOCS ; \
-Command = .uno:SaveAll ; \
-Text [ en-US ] = Sa~ve All ; \
-
-#define ITEM_FILE_SAVEASDOC \
-Identifier = SID_SAVEASDOC ; \
-Command = .uno:SaveAs ; \
-Text [ en-US ] = Save ~As... ;\
-
-#define ITEM_FILE_EXPORTDOC \
-Identifier = SID_EXPORTDOC ; \
-Command = .uno:ExportTo ; \
-Text [ en-US ] = Expor~t... ; \
-
-#define ITEM_FILE_EXPORTDOCASPDF \
-Identifier = SID_EXPORTDOCASPDF ; \
-Command = .uno:ExportToPDF ; \
-Text [ en-US ] = Export as P~DF... ; \
-
-#define ITEM_FILE_VERSIONDIALOG \
-Identifier = SID_VERSION ; \
-Command = .uno:VersionDialog ; \
-Text [ en-US ] = Versions... ; \
-
-#define ITEM_FILE_LASTVERSIONDOC \
-Identifier = SID_RELOAD ; \
-Command = .uno:Reload ; \
-Text [ en-US ] = Reload ;\
-
-#define ITEM_FILE_DOCINFO \
-Identifier = SID_DOCINFO ; \
-Command = .uno:SetDocumentProperties ; \
-Text [ en-US ] = Propert~ies... ;\
-
-#define ITEM_FILE_DOCTEMPLATE \
-Identifier = MN_TEMPLATES; \
-Command = .uno:TemplateMenu ; \
-Text [ en-US ] = ~Templates ;\
-SubMenu = Menu \
-{ \
-ItemList = \
-{ \
-MenuItem\
-{ \
-Identifier = SID_ORGANIZER ; \
-Command = .uno:Organizer ; \
-Text [ en-US ] = ~Organize...;\
-}; \
-MenuItem\
-{ \
-Identifier = SID_TEMPLATE_ADDRESSBOKSOURCE; \
-Command = .uno:AddressBookSource ; \
-Text [ en-US ] = ~Address Book Source...; \
-}; \
-MenuItem\
-{ \
-Identifier = SID_DOCTEMPLATE ; \
-Command = .uno:SaveAsTemplate ; \
-Text [ en-US ] = ~Save...;\
-}; \
-MenuItem\
-
[Libreoffice-commits] .: 2 commits - svl/inc svl/source svx/inc svx/source sw/inc sw/source toolkit/inc toolkit/source unusedcode.easy vcl/inc vcl/source
svl/inc/svl/srchitem.hxx|3
svl/source/items/srchitem.cxx | 64 --
svx/inc/svx/ctredlin.hxx|6 -
svx/inc/svx/simptabl.hxx|3
svx/inc/svx/unoshape.hxx|3
svx/source/dialog/_contdlg.cxx | 44
svx/source/dialog/contimp.hxx |3
svx/source/dialog/ctredlin.cxx | 95
svx/source/dialog/simptabl.cxx | 10 --
svx/source/unodraw/unoshape.cxx | 16
sw/inc/pam.hxx |4 -
sw/source/core/crsr/pam.cxx | 10 --
sw/source/core/text/inftxt.cxx | 18 -
sw/source/core/text/inftxt.hxx | 18 -
sw/source/core/text/porlay.hxx |7 --
sw/source/core/text/txtftn.cxx | 10 --
sw/source/core/text/txtio.cxx | 47 -
sw/source/ui/vba/vbacolumn.cxx | 55
sw/source/ui/vba/vbacolumn.hxx |4 -
sw/source/ui/vba/vbastyle.cxx | 27 ---
sw/source/ui/vba/vbastyle.hxx |1
toolkit/inc/toolkit/helper/vclunohelper.hxx |1
toolkit/source/helper/vclunohelper.cxx | 70
unusedcode.easy | 34 --
vcl/inc/vcl/window.hxx |3
vcl/source/window/window.cxx|7 --
26 files changed, 1 insertion(+), 562 deletions(-)
New commits:
commit 105546f7f11ccee50f8066bfb7c753fabb177fc8
Author: Thomas Arnhold tho...@arnhold.org
Date: Wed Jan 18 19:48:19 2012 +0100
remove unused code
diff --git a/svl/inc/svl/srchitem.hxx b/svl/inc/svl/srchitem.hxx
index 7a0be71..c832bac 100644
--- a/svl/inc/svl/srchitem.hxx
+++ b/svl/inc/svl/srchitem.hxx
@@ -171,9 +171,6 @@ public:
inline sal_uInt16 GetLEVLonger() const;
inline voidSetLEVLonger(sal_uInt16 nSet);
-voidGetFromDescriptor( const
::com::sun::star::uno::Reference ::com::sun::star::util::XSearchDescriptor
rDescr );
-voidSetToDescriptor( ::com::sun::star::uno::Reference
::com::sun::star::util::XSearchDescriptor rDescr );
-
inline const com::sun::star::util::SearchOptions
GetSearchOptions() const;
inline void SetSearchOptions( const com::sun::star::util::SearchOptions
rOpt );
diff --git a/svl/source/items/srchitem.cxx b/svl/source/items/srchitem.cxx
index 0e01172..57f1f1d 100644
--- a/svl/source/items/srchitem.cxx
+++ b/svl/source/items/srchitem.cxx
@@ -280,70 +280,6 @@ SfxItemPresentation SvxSearchItem::GetPresentation
return SFX_ITEM_PRESENTATION_NONE;
}
-void SvxSearchItem::GetFromDescriptor( const ::com::sun::star::uno::Reference
::com::sun::star::util::XSearchDescriptor rDescr )
-{
-SetSearchString( rDescr-getSearchString() );
-::com::sun::star::uno::Any aAny = rDescr-getPropertyValue(
::rtl::OUString( RTL_CONSTASCII_USTRINGPARAM(SearchWords) ) );
-sal_Bool bTemp = false;
-aAny = bTemp ;
-SetWordOnly( bTemp );
-aAny = rDescr-getPropertyValue( ::rtl::OUString(
RTL_CONSTASCII_USTRINGPARAM(SearchCaseSensitive) ) );
-aAny = bTemp ;
-SetExact( bTemp );
-aAny = rDescr-getPropertyValue( ::rtl::OUString(
RTL_CONSTASCII_USTRINGPARAM(SearchBackwards) ) );
-aAny = bTemp ;
-SetBackward( bTemp );
-aAny = rDescr-getPropertyValue( ::rtl::OUString(
RTL_CONSTASCII_USTRINGPARAM(SearchInSelection) ) );
-aAny = bTemp ;
-SetSelection( bTemp );
-aAny = rDescr-getPropertyValue( ::rtl::OUString(
RTL_CONSTASCII_USTRINGPARAM(SearchRegularExpression) ) );
-aAny = bTemp ;
-SetRegExp( bTemp );
-aAny = rDescr-getPropertyValue( ::rtl::OUString(
RTL_CONSTASCII_USTRINGPARAM(SearchSimilarity) ) );
-aAny = bTemp ;
-SetLevenshtein( bTemp );
-aAny = rDescr-getPropertyValue( ::rtl::OUString(
RTL_CONSTASCII_USTRINGPARAM(SearchSimilarityRelax) ) );
-aAny = bTemp ;
-SetLEVRelaxed( bTemp );
-aAny = rDescr-getPropertyValue( ::rtl::OUString(
RTL_CONSTASCII_USTRINGPARAM(SearchSimilarityExchange) ) );
-sal_Int16 nTemp = 0;
-aAny = nTemp ;
-SetLEVOther( nTemp );
-aAny = rDescr-getPropertyValue( ::rtl::OUString(
RTL_CONSTASCII_USTRINGPARAM(SearchSimilarityRemove) ) );
-aAny = nTemp ;
-SetLEVShorter( nTemp );
-aAny = rDescr-getPropertyValue( ::rtl::OUString(
RTL_CONSTASCII_USTRINGPARAM(SearchSimilarityAdd) ) );
-aAny = nTemp ;
-SetLEVLonger( nTemp );
-}
-
-void SvxSearchItem::SetToDescriptor( ::com::sun::star::uno::Reference
::com::sun::star::util::XSearchDescriptor rDescr )
-{
-rDescr-setSearchString( GetSearchString() );
-::com::sun::star::uno::Any aAny;
-aAny = GetWordOnly() ;
-rDescr-setPropertyValue( ::rtl::OUString(
RTL_CONSTASCII_USTRINGPARAM(SearchWords) ), aAny );
-aAny =
[Libreoffice-commits] .: Branch 'libreoffice-3-5' - basegfx/source basegfx/test
basegfx/source/matrix/b2dhommatrix.cxx |8
basegfx/test/basegfx2d.cxx | 17 +
2 files changed, 25 insertions(+)
New commits:
commit 9925d8023102d9b1c21da74faca829a61102da6a
Author: Thorsten Behrens tbehr...@suse.com
Date: Wed Jan 18 14:52:20 2012 -0500
decompose() should return the original rotation angle and scales.
decompose() would return incorrect rotation angle and scales when the
angle was exactly 180 degrees, due to FPU rounding error. This commit
fixes it.
This problem would manifest itself when inserting an image into
Calc/Draw, cropping it, and flipping it vertically or rotating it
at exactly 180 degrees. Before the fix the image would simply disappear.
diff --git a/basegfx/source/matrix/b2dhommatrix.cxx
b/basegfx/source/matrix/b2dhommatrix.cxx
index adc9843..4ec49e9 100644
--- a/basegfx/source/matrix/b2dhommatrix.cxx
+++ b/basegfx/source/matrix/b2dhommatrix.cxx
@@ -320,6 +320,14 @@ namespace basegfx
// no rotation and shear, copy scale values
rScale.setX(get(0, 0));
rScale.setY(get(1, 1));
+
+// or is there?
+if( rScale.getX() 0 rScale.getY() 0 )
+{
+// there is - 180 degree rotated
+rScale *= -1;
+rRotate = 180*F_PI180;
+}
}
else
{
diff --git a/basegfx/test/basegfx2d.cxx b/basegfx/test/basegfx2d.cxx
index d0251aa..005a9bb 100644
--- a/basegfx/test/basegfx2d.cxx
+++ b/basegfx/test/basegfx2d.cxx
@@ -36,6 +36,7 @@
#include cppunit/extensions/HelperMacros.h
#include basegfx/matrix/b2dhommatrix.hxx
+#include basegfx/matrix/b2dhommatrixtools.hxx
#include basegfx/polygon/b2dpolygon.hxx
#include basegfx/polygon/b2dpolygontools.hxx
#include basegfx/curve/b2dcubicbezier.hxx
@@ -927,6 +928,22 @@ public:
CPPUNIT_ASSERT_MESSAGE(decompose: error test I2,
impDecomposeComposeTest(-fSX, fSY, tan(-fS), -fR));
CPPUNIT_ASSERT_MESSAGE(decompose: error test I3,
impDecomposeComposeTest(fSX, -fSY, tan(-fS), -fR));
CPPUNIT_ASSERT_MESSAGE(decompose: error test I4,
impDecomposeComposeTest(-fSX, -fSY, tan(-fS), -fR));
+
+// cover special case of 180 degree rotation
+B2DHomMatrix aTest=tools::createScaleShearXRotateTranslateB2DHomMatrix(
+6425,3938,
+0,
+180*F_PI180,
+10482,4921);
+// decompose that matrix
+B2DTuple aDScale;
+B2DTuple aDTrans;
+double fDRot;
+double fDShX;
+aTest.decompose(aDScale, aDTrans, fDRot, fDShX);
+CPPUNIT_ASSERT_MESSAGE(decompose: error test J1, aDScale.getX() ==
6425 aDScale.getY() == 3938);
+CPPUNIT_ASSERT_MESSAGE(decompose: error test J1, aDTrans.getX() ==
10482 aDTrans.getY() == 4921);
+CPPUNIT_ASSERT_MESSAGE(decompose: error test J1, fDRot ==
180*F_PI180);
}
// Change the following lines only, if you add, remove or rename
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: basegfx/source basegfx/test
basegfx/source/matrix/b2dhommatrix.cxx |8
basegfx/test/basegfx2d.cxx | 17 +
2 files changed, 25 insertions(+)
New commits:
commit 800806ba850c7fd03e37acb011fa993e08cb8fc8
Author: Thorsten Behrens tbehr...@suse.com
Date: Wed Jan 18 14:52:20 2012 -0500
decompose() should return the original rotation angle and scales.
decompose() would return incorrect rotation angle and scales when the
angle was exactly 180 degrees, due to FPU rounding error. This commit
fixes it.
This problem would manifest itself when inserting an image into
Calc/Draw, cropping it, and flipping it vertically or rotating it
at exactly 180 degrees. Before the fix the image would simply disappear.
diff --git a/basegfx/source/matrix/b2dhommatrix.cxx
b/basegfx/source/matrix/b2dhommatrix.cxx
index 942f313..8538d22 100644
--- a/basegfx/source/matrix/b2dhommatrix.cxx
+++ b/basegfx/source/matrix/b2dhommatrix.cxx
@@ -289,6 +289,14 @@ namespace basegfx
// no rotation and shear, copy scale values
rScale.setX(get(0, 0));
rScale.setY(get(1, 1));
+
+// or is there?
+if( rScale.getX() 0 rScale.getY() 0 )
+{
+// there is - 180 degree rotated
+rScale *= -1;
+rRotate = 180*F_PI180;
+}
}
else
{
diff --git a/basegfx/test/basegfx2d.cxx b/basegfx/test/basegfx2d.cxx
index 65f778f..0f0c9c7 100644
--- a/basegfx/test/basegfx2d.cxx
+++ b/basegfx/test/basegfx2d.cxx
@@ -36,6 +36,7 @@
#include cppunit/extensions/HelperMacros.h
#include basegfx/matrix/b2dhommatrix.hxx
+#include basegfx/matrix/b2dhommatrixtools.hxx
#include basegfx/polygon/b2dpolygon.hxx
#include basegfx/polygon/b2dpolygontools.hxx
#include basegfx/curve/b2dcubicbezier.hxx
@@ -666,6 +667,22 @@ public:
CPPUNIT_ASSERT_MESSAGE(decompose: error test I2,
impDecomposeComposeTest(-fSX, fSY, tan(-fS), -fR));
CPPUNIT_ASSERT_MESSAGE(decompose: error test I3,
impDecomposeComposeTest(fSX, -fSY, tan(-fS), -fR));
CPPUNIT_ASSERT_MESSAGE(decompose: error test I4,
impDecomposeComposeTest(-fSX, -fSY, tan(-fS), -fR));
+
+// cover special case of 180 degree rotation
+B2DHomMatrix aTest=tools::createScaleShearXRotateTranslateB2DHomMatrix(
+6425,3938,
+0,
+180*F_PI180,
+10482,4921);
+// decompose that matrix
+B2DTuple aDScale;
+B2DTuple aDTrans;
+double fDRot;
+double fDShX;
+aTest.decompose(aDScale, aDTrans, fDRot, fDShX);
+CPPUNIT_ASSERT_MESSAGE(decompose: error test J1, aDScale.getX() ==
6425 aDScale.getY() == 3938);
+CPPUNIT_ASSERT_MESSAGE(decompose: error test J1, aDTrans.getX() ==
10482 aDTrans.getY() == 4921);
+CPPUNIT_ASSERT_MESSAGE(decompose: error test J1, fDRot ==
180*F_PI180);
}
// Change the following lines only, if you add, remove or rename
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 3 commits - android/qa sal/inc sal/osl sal/Package_inc.mk sal/util tools/source
android/qa/sc/Makefile |8 -
sal/Package_inc.mk |1
sal/inc/osl/detail/file.h | 87 +++
sal/osl/unx/file.cxx| 77 +
sal/osl/unx/file_stat.cxx | 23
sal/osl/unx/uunxapi.cxx | 34 --
sal/osl/unx/uunxapi.h |6 +
sal/osl/w32/file.cxx| 16 ++
sal/util/sal.map|8 +
tools/source/stream/strmunx.cxx | 226
10 files changed, 346 insertions(+), 140 deletions(-)
New commits:
commit fa83e46653536821fa70d37d9e4e0ed98538e522
Author: Tor Lillqvist tlillqv...@suse.com
Date: Wed Jan 18 10:48:26 2012 +0200
No need to unpack the .res files any more
diff --git a/android/qa/sc/Makefile b/android/qa/sc/Makefile
index d023791..67fa567 100644
--- a/android/qa/sc/Makefile
+++ b/android/qa/sc/Makefile
@@ -137,11 +137,11 @@ copy-stuff:
sed -e 's!uri=./!uri=$(APP_DATA_PATH)/lib/!g'
$(SRC_ROOT)/testtools/$(INPATH)/lib/$$F.rdb assets/lib/$$F.rdb; \
done
cp -R $(OUTDIR)/xml/registry assets/xml
-# Then assets that are unpacked at run-time into the app's data directory.
- mkdir -p assets/unpack/bin
+# .res files
for F in $(OUTDIR)/bin/*.res; do \
- cp $$F assets/unpack/bin; \
+ cp $$F assets/bin; \
done
+# Then assets that are unpacked at run-time into the app's data directory.
mkdir -p assets/unpack/etc/fonts
cp fonts.conf assets/unpack/etc/fonts
#
@@ -164,7 +164,7 @@ uninstall:
adb uninstall $(APP_PACKAGE)
run:
- echo STAR_RESOURCEPATH=$(APP_DATA_PATH)/bin
FONTCONFIG_FILE=$(APP_DATA_PATH)/etc/fonts/fonts.conf
$(APP_DATA_PATH)/lib/libtest_sc_ucalc.so --headless --protector
libunoexceptionprotector.so unoexceptionprotector
'-env:CONFIGURATION_LAYERS=xcsxcu:file:///assets/xml/registry'
'-env:UNO_TYPES=file:///assets/bin/udkapi.rdb file:///assets/bin/types.rdb'
'-env:UNO_SERVICES=file:///assets/xml/ure/services.rdb
file:///assets/ComponentTarget/framework/util/fwk.component
file:///assets/ComponentTarget/i18npool/util/i18npool.component
file:///assets/ComponentTarget/sfx2/util/sfx.component
file:///assets/ComponentTarget/unoxml/source/service/unoxml.component
file:///assets/ComponentTarget/configmgr/source/configmgr.component
file:///assets/ComponentTarget/ucb/source/core/ucb1.component
file:///assets/ComponentTarget/ucb/source/ucp/file/ucpfile1.component'
-env:URE_INTERNAL_LIB_DIR=file://$(APP_DATA_PATH)/lib
-env:LO_LIB_DIR=file://$(APP_DATA_PATH)/lib cmdline
+ echo STAR_RESOURCEPATH=/assets/bin
FONTCONFIG_FILE=$(APP_DATA_PATH)/etc/fonts/fonts.conf
$(APP_DATA_PATH)/lib/libtest_sc_ucalc.so --headless --protector
libunoexceptionprotector.so unoexceptionprotector
'-env:CONFIGURATION_LAYERS=xcsxcu:file:///assets/xml/registry'
'-env:UNO_TYPES=file:///assets/bin/udkapi.rdb file:///assets/bin/types.rdb'
'-env:UNO_SERVICES=file:///assets/xml/ure/services.rdb
file:///assets/ComponentTarget/framework/util/fwk.component
file:///assets/ComponentTarget/i18npool/util/i18npool.component
file:///assets/ComponentTarget/sfx2/util/sfx.component
file:///assets/ComponentTarget/unoxml/source/service/unoxml.component
file:///assets/ComponentTarget/configmgr/source/configmgr.component
file:///assets/ComponentTarget/ucb/source/core/ucb1.component
file:///assets/ComponentTarget/ucb/source/ucp/file/ucpfile1.component'
-env:URE_INTERNAL_LIB_DIR=file://$(APP_DATA_PATH)/lib
-env:LO_LIB_DIR=file://$(APP_DATA_PATH)/lib cmdline
adb push cmdline $(APP_DATA_PATH)/cmdline
adb shell am start -n $(APP_PACKAGE)/$(BOOTSTRAP) -e lo-main-library
libcppunittester -e lo-main-indirect-cmdline $(APP_DATA_PATH)/cmdline
commit e541105b45d5da8df29688394e3a0297a2e7
Author: Tor Lillqvist tlillqv...@suse.com
Date: Tue Jan 17 21:59:22 2012 +0200
Use osl API to access files in the SvFileStream code
In general it's good to have file opening in just one place. In
particular, this means SvFileStream can now open files located in the
app package (.apk Zip archive) on Android, we don't need to unpack
them into separate files.
diff --git a/tools/source/stream/strmunx.cxx b/tools/source/stream/strmunx.cxx
index ffb75a9..c9d4f07 100644
--- a/tools/source/stream/strmunx.cxx
+++ b/tools/source/stream/strmunx.cxx
@@ -46,6 +46,7 @@
// class FileBase
#include osl/file.hxx
+#include osl/detail/file.h
#include rtl/instance.hxx
#include rtl/strbuf.hxx
@@ -88,7 +89,7 @@ InternalStreamLock::InternalStreamLock(
{
rtl::OString aFileName(rtl::OUStringToOString(m_pStream-GetFileName(),
osl_getThreadTextEncoding()));
-stat( aFileName.getStr(), m_aStat );
+osl_statFilePath( aFileName.getStr(), m_aStat );
LockList::get().push_back( this );
#if OSL_DEBUG_LEVEL 1
fprintf( stderr, locked %s, aFileName.getStr() );
@@ -127,7 +128,7 @@ sal_Bool InternalStreamLock::LockFile(
[Libreoffice-commits] .: svx/inc svx/source
svx/inc/svx/svdograf.hxx |3 --- svx/source/svdraw/svdograf.cxx |1 - 2 files changed, 4 deletions(-) New commits: commit b5a2242ff6fd3136daec04a46d2780d425740398 Author: Kohei Yoshida kohei.yosh...@suse.com Date: Wed Jan 18 16:44:30 2012 -0500 This aCropRect data member is no longer used. diff --git a/svx/inc/svx/svdograf.hxx b/svx/inc/svx/svdograf.hxx index 6aef6bd..28f784d 100644 --- a/svx/inc/svx/svdograf.hxx +++ b/svx/inc/svx/svdograf.hxx @@ -100,8 +100,6 @@ protected: voidImpSetAttrToGrafInfo(); // Werte vom Pool kopieren GraphicAttr aGrafInfo; -Rectangle aCropRect; // Wenn aCropRect nicht Empty ist, dann enthaelt es den sichtbaren -// Ausschnitt der Grafik in logischen Eingeiten der Grafik! Also Bitmap-=Pixel String aFileName; // Wenn es sich um einen Link handelt, steht hier der Dateiname drin. String aFilterName; GraphicObject* pGraphic; // Zur Beschleunigung von Bitmapausgaben, besonders von gedrehten. @@ -125,7 +123,6 @@ protected: DECL_LINK( ImpSwapHdl, GraphicObject* ); public: - TYPEINFO(); SdrGrafObj(); diff --git a/svx/source/svdraw/svdograf.cxx b/svx/source/svdraw/svdograf.cxx index c82b5fe..8686211 100644 --- a/svx/source/svdraw/svdograf.cxx +++ b/svx/source/svdraw/svdograf.cxx @@ -818,7 +818,6 @@ SdrGrafObj SdrGrafObj::operator=( const SdrGrafObj rObj ) SdrRectObj::operator=( rObj ); pGraphic-SetGraphic( rObj.GetGraphic(), rObj.GetGraphicObject() ); -aCropRect = rObj.aCropRect; aFileName = rObj.aFileName; aFilterName = rObj.aFilterName; bMirrored = rObj.bMirrored; ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: svx/inc
svx/inc/svx/svdograf.hxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit a0a04bb926f37d68a127f3a1a88a612eba8a4776 Author: Kohei Yoshida kohei.yosh...@suse.com Date: Wed Jan 18 16:48:22 2012 -0500 Make them private instead of protected. No classes derived from this and they are not virtual methods. diff --git a/svx/inc/svx/svdograf.hxx b/svx/inc/svx/svdograf.hxx index 28f784d..f2d4ad8 100644 --- a/svx/inc/svx/svdograf.hxx +++ b/svx/inc/svx/svdograf.hxx @@ -93,7 +93,7 @@ private: friend class sdr::contact::ViewObjectContactOfGraphic; friend class SdrGraphicLink; -protected: +private: virtual sdr::contact::ViewContact* CreateObjectSpecificViewContact(); virtual sdr::properties::BaseProperties* CreateObjectSpecificProperties(); @@ -114,7 +114,7 @@ protected: unsignedmbInsidePaint : 1; unsignedmbIsPreview : 1; -protected: +private: voidImpLinkAnmeldung(); voidImpLinkAbmeldung(); ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: vcl/source
vcl/source/gdi/outdev2.cxx | 183 +
1 file changed, 89 insertions(+), 94 deletions(-)
New commits:
commit 649457776f11de1f27157c98fd4b05432b425897
Author: Thorsten Behrens tbehr...@suse.com
Date: Wed Jan 18 18:09:39 2012 +0100
Unify blitting in vcl.
vcl's DrawBitmap methods have a very nice optimisation, that reduce
the blit to exactly the area covered (i.e. taking into account clip,
scale etc.). This was hand-coded, now moved out to own AdjustTwoRect
method, and also used from DrawOutDev / CopyArea.
diff --git a/vcl/source/gdi/outdev2.cxx b/vcl/source/gdi/outdev2.cxx
index 329f5f4..2003de8 100644
--- a/vcl/source/gdi/outdev2.cxx
+++ b/vcl/source/gdi/outdev2.cxx
@@ -26,7 +26,6 @@
*
/
-
#include tools/debug.hxx
#include vcl/bitmap.hxx
@@ -152,19 +151,69 @@ sal_uLong ImplAdjustTwoRect( TwoRect rTwoRect, const
Size rSizePix )
// ===
+void ImplAdjustTwoRect( TwoRect rTwoRect, const Rectangle rValidSrcRect )
+{
+if( ( rTwoRect.mnSrcX rValidSrcRect.Left() ) || ( rTwoRect.mnSrcX =
rValidSrcRect.Right() ) ||
+( rTwoRect.mnSrcY rValidSrcRect.Top() ) || ( rTwoRect.mnSrcY =
rValidSrcRect.Bottom() ) ||
+( ( rTwoRect.mnSrcX + rTwoRect.mnSrcWidth ) rValidSrcRect.Right() )
||
+( ( rTwoRect.mnSrcY + rTwoRect.mnSrcHeight ) rValidSrcRect.Bottom()
) )
+{
+const Rectangle aSourceRect( Point( rTwoRect.mnSrcX, rTwoRect.mnSrcY ),
+ Size( rTwoRect.mnSrcWidth,
rTwoRect.mnSrcHeight ) );
+Rectangle aCropRect( aSourceRect );
+
+aCropRect.Intersection( rValidSrcRect );
+
+if( aCropRect.IsEmpty() )
+rTwoRect.mnSrcWidth = rTwoRect.mnSrcHeight = rTwoRect.mnDestWidth
= rTwoRect.mnDestHeight = 0;
+else
+{
+const doublefFactorX = ( rTwoRect.mnSrcWidth 1 ) ? (double)
( rTwoRect.mnDestWidth - 1 ) / ( rTwoRect.mnSrcWidth - 1 ) : 0.0;
+const doublefFactorY = ( rTwoRect.mnSrcHeight 1 ) ? (double)
( rTwoRect.mnDestHeight - 1 ) / ( rTwoRect.mnSrcHeight - 1 ) : 0.0;
+
+const long nDstX1 = rTwoRect.mnDestX + FRound( fFactorX * (
aCropRect.Left() - rTwoRect.mnSrcX ) );
+const long nDstY1 = rTwoRect.mnDestY + FRound( fFactorY * (
aCropRect.Top() - rTwoRect.mnSrcY ) );
+const long nDstX2 = rTwoRect.mnDestX + FRound( fFactorX * (
aCropRect.Right() - rTwoRect.mnSrcX ) );
+const long nDstY2 = rTwoRect.mnDestY + FRound( fFactorY * (
aCropRect.Bottom() - rTwoRect.mnSrcY ) );
+
+rTwoRect.mnSrcX = aCropRect.Left();
+rTwoRect.mnSrcY = aCropRect.Top();
+rTwoRect.mnSrcWidth = aCropRect.GetWidth();
+rTwoRect.mnSrcHeight = aCropRect.GetHeight();
+rTwoRect.mnDestX = nDstX1;
+rTwoRect.mnDestY = nDstY1;
+rTwoRect.mnDestWidth = nDstX2 - nDstX1 + 1;
+rTwoRect.mnDestHeight = nDstY2 - nDstY1 + 1;
+}
+}
+}
+
+// ===
+
void OutputDevice::ImplDrawOutDevDirect( const OutputDevice* pSrcDev, void*
pVoidPosAry )
{
TwoRect*pPosAry = (TwoRect*)pVoidPosAry;
SalGraphics*pGraphics2;
-if ( pPosAry-mnSrcWidth pPosAry-mnSrcHeight pPosAry-mnDestWidth
pPosAry-mnDestHeight )
+if ( this == pSrcDev )
+pGraphics2 = NULL;
+else
{
-if ( this == pSrcDev )
-pGraphics2 = NULL;
+if ( (GetOutDevType() != pSrcDev-GetOutDevType()) ||
+ (GetOutDevType() != OUTDEV_WINDOW) )
+{
+if ( !pSrcDev-mpGraphics )
+{
+if ( !((OutputDevice*)pSrcDev)-ImplGetGraphics() )
+return;
+}
+pGraphics2 = pSrcDev-mpGraphics;
+}
else
{
-if ( (GetOutDevType() != pSrcDev-GetOutDevType()) ||
- (GetOutDevType() != OUTDEV_WINDOW) )
+if ( ((Window*)this)-mpWindowImpl-mpFrameWindow ==
((Window*)pSrcDev)-mpWindowImpl-mpFrameWindow )
+pGraphics2 = NULL;
+else
{
if ( !pSrcDev-mpGraphics )
{
@@ -172,68 +221,38 @@ void OutputDevice::ImplDrawOutDevDirect( const
OutputDevice* pSrcDev, void* pVoi
return;
}
pGraphics2 = pSrcDev-mpGraphics;
-}
-else
-{
-if ( ((Window*)this)-mpWindowImpl-mpFrameWindow ==
((Window*)pSrcDev)-mpWindowImpl-mpFrameWindow )
-pGraphics2 = NULL;
-else
-{
-if ( !pSrcDev-mpGraphics )
-{
-if (
[Libreoffice-commits] .: sc/source
sc/source/ui/optdlg/tpdefaults.cxx | 11 +++
sc/source/ui/src/optdlg.src|4 ++--
2 files changed, 13 insertions(+), 2 deletions(-)
New commits:
commit 225647779959d24cfdaea62968f518cc52533a90
Author: Andras Timar ati...@suse.com
Date: Wed Jan 18 23:48:43 2012 +0100
fdo#44896 accomodate localized text expansion
diff --git a/sc/source/ui/optdlg/tpdefaults.cxx
b/sc/source/ui/optdlg/tpdefaults.cxx
index bd1cc68..afced22 100644
--- a/sc/source/ui/optdlg/tpdefaults.cxx
+++ b/sc/source/ui/optdlg/tpdefaults.cxx
@@ -50,6 +50,17 @@ ScTpDefaultsOptions::ScTpDefaultsOptions(Window *pParent,
const SfxItemSet rCor
rCoreAttrs.Get(GetWhich(SID_SCDOCOPTIONS)));
mpLocalOptions.reset(new ScDocOptions(rItem.GetDocOptions()));
+long nTxtW = aFtNSheets.GetCtrlTextWidth( aFtNSheets.GetText() );
+long nCtrlW = aFtNSheets.GetSizePixel().Width();
+if ( nTxtW = nCtrlW )
+{
+Size aNewSize = aFtNSheets.GetSizePixel();
+aNewSize.Width() += ( nTxtW - nCtrlW );
+aFtNSheets.SetSizePixel( aNewSize );
+Point aNewPoint = aEdNSheets.GetPosPixel();
+aNewPoint.X() += ( nTxtW - nCtrlW );
+aEdNSheets.SetPosPixel( aNewPoint );
+}
aEdNSheets.SetModifyHdl( LINK(this, ScTpDefaultsOptions, NumModifiedHdl) );
}
diff --git a/sc/source/ui/src/optdlg.src b/sc/source/ui/src/optdlg.src
index a8f82a5..8012628 100644
--- a/sc/source/ui/src/optdlg.src
+++ b/sc/source/ui/src/optdlg.src
@@ -926,14 +926,14 @@ TabPage RID_SCPAGE_DEFAULTS
FixedText FT_NSHEETS
{
Pos = MAP_APPFONT ( 12 , 16 ) ;
-Size = MAP_APPFONT ( 120 , 8 ) ;
+Size = MAP_APPFONT ( 110 , 8 ) ;
Text [ en-US ] = Number of worksheets in new document;
};
NumericField ED_NSHEETS
{
HelpID = sc:NumericField:RID_SCPAGE_CALC:ED_NSHEETS;
Border = TRUE ;
-Pos = MAP_APPFONT ( 150 , 14 ) ;
+Pos = MAP_APPFONT ( 130 , 14 ) ;
Size = MAP_APPFONT ( 25 , 12 ) ;
Minimum = 1 ;
Maximum = 32000 ;
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - filter/source tools/inc tools/source unusedcode.easy writerperfect/source
filter/source/svg/svgexport.cxx | 55 ---
filter/source/svg/svgfilter.hxx |8
filter/source/svg/svgwriter.cxx |8
tools/inc/tools/color.hxx|1
tools/source/generic/color.cxx | 15
unusedcode.easy |7 ---
writerperfect/source/filter/PageSpan.cxx | 16 -
writerperfect/source/filter/PageSpan.hxx |2 -
8 files changed, 112 deletions(-)
New commits:
commit 3e04e08d371532960917afbcd59307fbd6c1f313
Author: Kohei Yoshida kohei.yosh...@suse.com
Date: Wed Jan 18 19:59:13 2012 -0500
This method is now unused.
diff --git a/filter/source/svg/svgexport.cxx b/filter/source/svg/svgexport.cxx
index ea63fa1..905bd62 100644
--- a/filter/source/svg/svgexport.cxx
+++ b/filter/source/svg/svgexport.cxx
@@ -392,13 +392,6 @@ sal_Bool SVGExport::IsUseOpacity() const
return bRet;
}
-//
-
-
-const ::basegfx::B2DPolyPolygon* SVGExport::getCurClip() const
-{
-return NULL;
-}
-
//
// - ObjectRepresentation -
//
diff --git a/filter/source/svg/svgfilter.hxx b/filter/source/svg/svgfilter.hxx
index d218e06..68c19d4 100644
--- a/filter/source/svg/svgfilter.hxx
+++ b/filter/source/svg/svgfilter.hxx
@@ -143,8 +143,6 @@ public:
sal_Bool IsUseNativeTextDecoration() const;
sal_Bool IsUseOpacity() const;
-const ::basegfx::B2DPolyPolygon* getCurClip() const;
-
protected:
virtual void_ExportStyles( sal_Bool /* bUsed */ ) {}
commit 05a8ecca55d96b823348fa390482be6cfee64f69
Author: Marc-André Laverdière-Papineau marc-an...@atc.tcs.com
Date: Sun Jan 15 18:24:58 2012 -0500
removed some dead code
diff --git a/filter/source/svg/svgexport.cxx b/filter/source/svg/svgexport.cxx
index 6149ddf..ea63fa1 100644
--- a/filter/source/svg/svgexport.cxx
+++ b/filter/source/svg/svgexport.cxx
@@ -382,20 +382,6 @@ sal_Bool SVGExport::IsUseNativeTextDecoration() const
//
-
-::rtl::OUString SVGExport::GetGlyphPlacement() const
-{
-::rtl::OUString aRet;
-
-if( mrFilterData.getLength() 3 )
-mrFilterData[ 3 ].Value = aRet;
-else
-aRet = B2UCONST( abs );
-
-return aRet;
-}
-
-//
-
-
sal_Bool SVGExport::IsUseOpacity() const
{
sal_Bool bRet = !IsUseTinyProfile();
@@ -408,43 +394,9 @@ sal_Bool SVGExport::IsUseOpacity() const
//
-
-sal_Bool SVGExport::IsUseGradient() const
-{
-sal_Bool bRet = !IsUseTinyProfile();
-
-if( !bRet ( mrFilterData.getLength() 5 ) )
-mrFilterData[ 5 ].Value = bRet;
-
-return bRet;
-}
-
-//
-
-
-void SVGExport::pushClip( const ::basegfx::B2DPolyPolygon rPolyPoly )
-{
-maClipList.push_front( ::basegfx::tools::correctOrientations( rPolyPoly )
);
-}
-
-//
-
-
-void SVGExport::popClip()
-{
-if( !maClipList.empty() )
-maClipList.pop_front();
-}
-
-//
-
-
-sal_Bool SVGExport::hasClip() const
-{
-return( !maClipList.empty() );
-}
-
-//
-
-
const ::basegfx::B2DPolyPolygon* SVGExport::getCurClip() const
{
-return( maClipList.empty() ? NULL : ( *maClipList.begin() ) );
+return NULL;
}
//
diff --git a/filter/source/svg/svgfilter.hxx b/filter/source/svg/svgfilter.hxx
index 21c1238..d218e06 100644
--- a/filter/source/svg/svgfilter.hxx
+++ b/filter/source/svg/svgfilter.hxx
@@ -141,13 +141,8 @@ public:
sal_Bool IsUseTinyProfile() const;
sal_Bool IsEmbedFonts() const;
sal_Bool IsUseNativeTextDecoration() const;
-::rtl::OUString GetGlyphPlacement() const;
sal_Bool IsUseOpacity() const;
-sal_Bool IsUseGradient() const;
-void pushClip( const ::basegfx::B2DPolyPolygon rPolyPoly );
-void popClip();
-sal_Bool hasClip() const;
const ::basegfx::B2DPolyPolygon* getCurClip() const;
protected:
@@ -161,7 +156,6 @@ protected:
private:
const Sequence PropertyValue mrFilterData;
-B2DPolyPolygonList maClipList;
SVGExport();
};
diff --git a/filter/source/svg/svgwriter.cxx b/filter/source/svg/svgwriter.cxx
index 9f70046..0639e5d 100644
--- a/filter/source/svg/svgwriter.cxx
+++ b/filter/source/svg/svgwriter.cxx
@@ -640,14 +640,6 @@ void SVGActionWriter::ImplWritePolyPolygon( const
PolyPolygon rPolyPoly, sal_Bo
else
aPolyPoly = rPolyPoly;
-if( mrExport.hasClip() )
-
[Libreoffice-commits] .: 7 commits - basic/source editeng/source svl/source svtools/source tools/inc tools/source vcl/source
basic/source/sbx/sbxvalue.cxx| 10 ++--
editeng/source/items/bulitem.cxx |7 ++-
editeng/source/items/frmitems.cxx|8 ++-
svl/source/items/cintitem.cxx|8 +--
svl/source/items/slstitm.cxx |6 +-
svtools/source/filter/wmf/enhwmf.cxx |6 ++
svtools/source/filter/wmf/winwmf.cxx |8 ++-
svtools/source/graphic/grfattr.cxx | 14 +-
svtools/source/misc/transfer.cxx | 24 +++---
tools/inc/tools/stream.hxx | 14 +++---
tools/source/generic/fract.cxx | 13 -
tools/source/generic/gen.cxx | 25 +--
tools/source/generic/poly.cxx| 12 +++--
tools/source/stream/stream.cxx | 77 +++
vcl/source/gdi/cvtsvm.cxx| 13 -
vcl/source/gdi/hatch.cxx |8 ++-
vcl/source/gdi/impgraph.cxx | 44 ++--
vcl/source/gdi/lineinfo.cxx | 25 +++
vcl/source/gdi/metaact.cxx | 17 +--
vcl/source/gdi/region.cxx| 20 +
20 files changed, 230 insertions(+), 129 deletions(-)
New commits:
commit db7fb9cdf22d2e36e19baa3e78bca159b3f62735
Author: Keith McRae keithco...@gmail.com
Date: Wed Jan 18 16:21:17 2012 +
fdo#39428 Remove/audit SvStream operator/(long)
Replaced calls to operator(long) with operator(sal_Int32)
Replaced calls to operator(long) with sal::static_int_castsal_Int32
diff --git a/vcl/source/gdi/cvtsvm.cxx b/vcl/source/gdi/cvtsvm.cxx
index 2026ceb..c8ad028 100644
--- a/vcl/source/gdi/cvtsvm.cxx
+++ b/vcl/source/gdi/cvtsvm.cxx
@@ -514,8 +514,12 @@ void SVMConverter::ImplConvertFromSVM1( SvStream rIStm,
GDIMetaFile rMtf )
rIStm.Read( (char*) aCode, sizeof( aCode ) ); // Kennung
rIStm nSize; // Size
rIStm nVersion; // Version
-rIStm aPrefSz.Width(); // PrefSize.Width()
-rIStm aPrefSz.Height(); // PrefSize.Height()
+//#fdo39428 SvStream no longer supports operator(long)
+sal_Int32 nTmp32(0);
+rIStm nTmp32;
+aPrefSz.Width() = nTmp32; // PrefSize.Width()
+rIStm nTmp32;
+aPrefSz.Height() = nTmp32; // PrefSize.Height()
// check header-magic and version
if( rIStm.GetError()
@@ -1290,7 +1294,8 @@ void SVMConverter::ImplConvertFromSVM1( SvStream rIStm,
GDIMetaFile rMtf )
case( GDI_TEXTLINE_COMMENT ):
{
Point aStartPt;
-longnWidth;
+//#fdo39428 SvStream no longer supports operator(long)
+sal_Int32 nWidth;
sal_uInt32 nStrikeout;
sal_uInt32 nUnderline;
sal_Int32 nFollowingActionCount;
@@ -2367,7 +2372,7 @@ sal_uLong SVMConverter::ImplWriteActions( SvStream
rOStm, GDIMetaFile rMtf,
{
const MetaTextLineAction* pA = (MetaTextLineAction*) pAction;
const PointrStartPt = pA-GetStartPoint();
-const long nWidth = pA-GetWidth();
+const sal_Int32 nWidth = (sal_Int32)
pA-GetWidth();
const FontStrikeout eStrikeout = pA-GetStrikeout();
const FontUnderline eUnderline = pA-GetUnderline();
sal_uLong nOldPos, nNewPos;
diff --git a/vcl/source/gdi/hatch.cxx b/vcl/source/gdi/hatch.cxx
index 98d8ce3..7b8b682 100644
--- a/vcl/source/gdi/hatch.cxx
+++ b/vcl/source/gdi/hatch.cxx
@@ -184,9 +184,12 @@ SvStream operator( SvStream rIStm, ImplHatch
rImplHatch )
{
VersionCompat aCompat( rIStm, STREAM_READ );
sal_uInt16 nTmp16;
+sal_Int32 nTmp32(0);
rIStm nTmp16; rImplHatch.meStyle = (HatchStyle) nTmp16;
-rIStm rImplHatch.maColor rImplHatch.mnDistance rImplHatch.mnAngle;
+//#fdo39428 SvStream no longer supports operator(long)
+rIStm rImplHatch.maColor nTmp32 rImplHatch.mnAngle;
+rImplHatch.mnDistance = nTmp32;
return rIStm;
}
@@ -198,7 +201,8 @@ SvStream operator( SvStream rOStm, const ImplHatch
rImplHatch )
VersionCompat aCompat( rOStm, STREAM_WRITE, 1 );
rOStm (sal_uInt16) rImplHatch.meStyle rImplHatch.maColor;
-rOStm rImplHatch.mnDistance rImplHatch.mnAngle;
+//#fdo39428 SvStream no longer supports operator(long)
+rOStm sal::static_int_castsal_Int32(rImplHatch.mnDistance)
rImplHatch.mnAngle;
return rOStm;
}
diff --git a/vcl/source/gdi/impgraph.cxx b/vcl/source/gdi/impgraph.cxx
index e709034..6aaedd6 100644
--- a/vcl/source/gdi/impgraph.cxx
+++ b/vcl/source/gdi/impgraph.cxx
@@ -941,8 +941,9 @@ sal_Bool ImpGraphic::ImplReadEmbedded( SvStream rIStm,
sal_Bool bSwap )
const sal_uLong nStartPos = rIStm.Tell();
sal_uInt32 nId;
sal_uLong
Re: [Libreoffice] [Libreoffice-qa] [ANN] LibreOffice 3.5.0 Beta3 available
Norbert Thiebaud wrote: I think that by default you do not get tag that you don't 'need' ... so if a tag is put, a posteriori, on a commit you already have you won't automatically get it. git fetch --tags is your friend here. :) Cheers, -- Thorsten pgpJGW12w1zj6.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] uno.RuntimeException when convert ODT to HTML
On 18/01/12 02:11, Gabriel Monnerat wrote: __main__.DisposedException: URP_Bridge : disposed (tid=3) Unexpected connection closure a disposed UNO bridge usually means that the office has crashed; can you check that that is indeed what happens, write a simple reproducer, and file a bug? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-qa] [ANN] LibreOffice 3.5.0 Beta3 available
On Wed, Jan 18, 2012 at 09:04:52AM +0100, Thorsten Behrens wrote: Norbert Thiebaud wrote: I think that by default you do not get tag that you don't 'need' ... so if a tag is put, a posteriori, on a commit you already have you won't automatically get it. git fetch --tags is your friend here. :) Ok, thanks all for your answers. I'll create an alias for git and forget about it :) -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [ANNOUNCE] libreoffice-3.5.0.1 tag created (3.5.0-rc1)
Hi, there have been created the libreoffice-3.5.0.1 tag for 3.5.0-rc1 release. The corresponding official builds will be available within 3 days or so. See the attached list of changes against 3.5.0-beta3. See also the schedule at http://wiki.documentfoundation.org/ReleasePlan#3.5_release and release criteria at http://wiki.documentfoundation.org/Release_Criteria Now, if you want to switch your clone to the tag, please do: ./g fetch --tags ./g checkout -b tag-libreoffice-3.5.0.1 libreoffice-3.5.0.1 Thanks again everyone who helped to make this happen. Cheers Fridrich + core + 256x256 Windows icons (fdo#39555) [Andras Timar] + add 256x256 desktop and MIME type icons (fdo#39555, bnc#722644) [Petr Mladek] + contination of 8a17792f2e5 (Handle/invalid column ID cleanup) (fdo#44283) [Lionel Elie Mamane] + copy pivot tables when a sheet is copied. (fdo#43077) [Kohei Yoshida] + defer formula token conversion for defined names (xls import). (fdo#42624) [Kohei Yoshida] + do the same for BIFF5 and earlier. (fdo#42624) [Kohei Yoshida] + drop attributes FRAME and RULES of table for HTML 3.2 (fdo#44616) [Takeshi Abe] + finally, remove data cache when nobody references it. (fdo#43077) [Kohei Yoshida] + fix UpdateCheck clog up server by keeping connection alive (rhbz#544619) [Thorsten Behrens] + fix prefix of command line switches (-- instead of -) (fdo#40991) [Andras Timar] + fix rotation of shapes in imported MS documents (fdo#43193) [Ivan Timofeev] + fix unfortunate name alias mixups with DejaVu fonts (fdo#44078) [Caolán McNamara] + fixed crasher in dialog destructor (fdo#38515) [Cédric Bosdonnat] + have cache instance keep track of who is referencing it. (fdo#43077) [Kohei Yoshida] + implement RTF import progressbar (fdo#38057) [Miklos Vajna] + improve RTF import of table cell spacings (fdo#41034) [Miklos Vajna] + no need to update the source range when it's a named range. (fdo#44661) [Kohei Yoshida] + now, refreshing a table should refresh all linked tables. (fdo#43077) [Kohei Yoshida] + partial revert of ...template names appear... correct word order (fdo#43532) [Stephan Bergmann] + properly update range keys for pivot cache. (fdo#44661) [Kohei Yoshida] + sheet 0 is selected by default. (fdo#44147) [Kohei Yoshida] + text rotation fixes. (bnc#734734) [Muthu Subramanian] + the Open... button's more room problem solved (fdo#33794) [Tomcsik Bence] + vcl: isolate new attempt to count monitors as screens to gtk3 (fdo#43458) [Michael Meeks] + vcl: second part of fix for - get xrandr / y positioning right (fdo#43458) [Michael Meeks] + why not showing horizontal scrollbar when needed? (fdo#30788) [Cédric Bosdonnat] + binfilter + fix for gcc 4.7/C++11: these are not string literal operators [David Tardon] + version 3.5.0.1, tag libreoffice-3.5.0.1 (3.5.0-rc1) [Fridrich Štrba] + core + 256x256 Windows icons (fdo#39555) [Andras Timar] + adapt to the more intuitive libvisio/libwpg API [Fridrich Štrba] + add 256x256 desktop and MIME type icons (fdo#39555, bnc#722644) [Petr Mladek] + add human theme to configure [Bjoern Michaelsen] + add human theme to packaging [Bjoern Michaelsen] + added new custom shape path segment commands - darken/lighten fill color [Radek Doulik] + avoid double deletion during data cache object destruction. [Kohei Yoshida] + avoid iterating beyond the last existing drawing page. [Kohei Yoshida] + bah, i forgot *export* [David Tardon] + bump product version to 3.5.0-beta3+, release number to 3 [Petr Mladek] + bump product version to 3.5.0-rc1, release number to 11 [Fridrich Štrba] + confine JDBC driver to thread-affine apartment for Java 6 performance [Stephan Bergmann] + connectivity: dbase: global variable cleanup [Michael Stahl] + consider the style:mirror property [Fridrich Štrba] + contination of 8a17792f2e5 (Handle/invalid column ID cleanup) (fdo#44283) [Lionel Elie Mamane] + copy pivot tables when a sheet is copied. (fdo#43077) [Kohei Yoshida] + defer formula token conversion for defined names (xls import). (fdo#42624) [Kohei Yoshida] + do the same for BIFF5 and earlier. (fdo#42624) [Kohei Yoshida] + don't create lock files for unit tests [Markus Mohrhard] + drop attributes FRAME and RULES of table for HTML 3.2 (fdo#44616) [Takeshi Abe] + enlarge 'Reset' button for German translation [Andras Timar] + ensure that /usr/include is _appended_ to INCLUDE [Eike Rathke] + finally, remove data cache when nobody references it. (fdo#43077) [Kohei Yoshida] + fix MinGW build. [Jan Holesovsky] + fix UpdateCheck clog up server by keeping connection alive (rhbz#544619) [Thorsten Behrens] + fix configurable branding. [Thorsten Behrens] + fix for gcc 4.7/C++11: this is not string literal operator [David Tardon] + fix ooxml custom shapes with 360 degree arcs [Radek Doulik] +
Re: [Libreoffice] Check for updates uses keep-alive / impacts the server (opengrok, tinderbox..)
On 1/17/12 12:30 PM, Christian Lohmaier wrote: Hi Pedro, *, On Tue, Jan 17, 2012 at 10:54 AM, Pedropedl...@gmail.com wrote: I hope you guys manage to fix this for RC1. Currently only the Beta version has this feature. Considering that only a small proportion of users are brave enough to try Betas and that Updates are only checked manually, my beta3 defaults to having the weekly auto-check enabled. it is worrying that this can have an impact on the server... Yes, because it runs out of open connections, not because it causes high load. It causes the server to roll thumbs.. So the problem here is that the connections dont get closed? If that is the case would'nt that be an easy fix in the sense that after a certain amount of time that the connection is idle the connection gets closed? Is it possible to do something like that with KeepAlive? SNIP ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Check for updates uses keep-alive / impacts the server (opengrok, tinderbox..)
Stefan Knorr (Astron) wrote: sorry for coming late to the discussion... anyway, I don't think it makes much sense to let users decide at what interval to check for updates. I agree, at least to the point that it's one more of those options where the cost does outweigh the benefit. Let's keep it in the xml config, though. For some interesting ideas about spreading update checks equally over time, also see here: http://adblockplus.org/blog/downloading-a-file-regularly-how-hard-can-it-be Could I interest you in having a go at that? ;) Cheers, -- Thorsten pgpBKHNszNFcs.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Check for updates uses keep-alive / impacts the server (opengrok, tinderbox..)
Hi Jonnathan, *, On Wed, Jan 18, 2012 at 11:06 AM, Jonathan Aquilina eagles051...@gmail.com wrote: On 1/17/12 12:30 PM, Christian Lohmaier wrote: On Tue, Jan 17, 2012 at 10:54 AM, Pedropedl...@gmail.com wrote: So the problem here is that the connections dont get closed? Yes, this has been written from the very beginning. And this problem has been fixed in the code already. New releases (i.e. the first that is offically released for end-users) will behave properly. If that is the case would'nt that be an easy fix in the sense that after a certain amount of time that the connection is idle the connection gets closed? Is it possible to do something like that with KeepAlive? This is done. But the order of magnitude for keeping connections open is seconds, whereas handling the actual request is a matter of milliseconds. Also I wrote previously that the keepalive timeout was already adjusted to nullify the impact that the beta-users did have. So all is fine. LO will behave properly, and the server will not collapse because of that. Even if it was not fixed in LO, the server could have been configured to ignore any keepalive requests. But as I wrote all that already: time to move over to other stuff, this topic is solved in my opinion already. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [ANNOUNCE] libreoffice-3.5.0.1 tag created (3.5.0-rc1)
Just to remind you that with this fact, the libreoffice-3-5 branch needs 1 signoff to push stuff. Cheers Fridrich On 18/01/12 10:39, Fridrich Strba wrote: Hi, there have been created the libreoffice-3.5.0.1 tag for 3.5.0-rc1 release. The corresponding official builds will be available within 3 days or so. See the attached list of changes against 3.5.0-beta3. See also the schedule at http://wiki.documentfoundation.org/ReleasePlan#3.5_release and release criteria at http://wiki.documentfoundation.org/Release_Criteria Now, if you want to switch your clone to the tag, please do: ./g fetch --tags ./g checkout -b tag-libreoffice-3.5.0.1 libreoffice-3.5.0.1 Thanks again everyone who helped to make this happen. Cheers Fridrich ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Check for updates uses keep-alive / impacts the server (opengrok, tinderbox..)
On Wed, 2012-01-18 at 10:59 +0100, Thorsten Behrens wrote: I agree, at least to the point that it's one more of those options where the cost does outweigh the benefit. Let's keep it in the xml config, though. Agreed - some sysadmins will no doubt want to tweak / enable / disable this sort of thing. Patches most welcome for the UI change though :-) ATB, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Check for updates uses keep-alive / impacts the server (opengrok, tinderbox..)
Hi Thorsten, *, On Wed, Jan 18, 2012 at 10:59 AM, Thorsten Behrens t...@documentfoundation.org wrote: Stefan Knorr (Astron) wrote: sorry for coming late to the discussion... anyway, I don't think it makes much sense to let users decide at what interval to check for updates. I agree, at least to the point that it's one more of those options where the cost does outweigh the benefit. Let's keep it in the xml config, though. I disagree. You absolutely need the option toggle to disable the check. And whether you have one checkbox or one checkbox and a couple of radio buttons, there's not really any difference in my eyes. It is on its own tabpage. So when you argue with keeping options simple you imply that you would move that enable/disable automatic check for updates control to another tab. And that would not be an improvement in my eyes. and regarding distributing the requests: I don't see any need for it either. Corporate environments where are large number of users will start LO at around the same time will very likely have the update check disabled (or point to their own server), linux distributors will have it disabled, so remains private users and small to tiny business users. Europe and America have the largest userbase, and surely there will be a bias towards business hours in those regions, but I don't see the need for any advanced scheduling logic. At least we should wait after 3.5.0 is released and the access logs can prove me wrong :-) ciao Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #109 from Michael Meeks michael.me...@novell.com 2012-01-18 04:23:22 PST --- Suggest add major PPTX performance regression: bug#44719 that may affect other font related performance issues. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Structural QA activities
Gents, I've been polling inside my work-environment whether I could run Coverity on the LibreOffice code tree. No success so far,it has my attention. From my past I know of similar tools, static code analysis tools, like QAC. Which triggers the question: has a QA-tool been run on the source code, if so which? Thx, -- Luc Castermans mailto:luc.casterm...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Re: [REVIEW][3.5] Writer layout fix for fdo#40438
Hi Michael, On Tue, 2012-01-17 at 22:23 +0100, Michael Stahl wrote: On 13/01/12 18:07, Cedric Bosdonnat wrote: Hi all, Could some of the other Writer gurus have a look at this patch: it should fix the crasher though it may not be perfect. I'ld prefer a peer review before cherry-picking it to 3.5 http://cgit.freedesktop.org/libreoffice/core/commit/?id=d83488 hmmm... i've looked at the problem quite a bit, and my current opinion is that your fix maybe doesn't really address the root cause, but it doesn't seem to cause any obvious problems either, so i've pushed it. Sure, but I couldn't really figure out what proper fix we could do there. the problem is really that we call a listener that wants to paint the document in the middle of a layout, while the layout is in an inconsistent state; but i'm not sure what exactly could be done about that. Yep, same here. Fixing the root cause without having side effects seems complex to me. PS: all those __memcpy_ssse3_back in the bug attached valgrind.log look like positives? No idea... If someone wants to have a look at these, that would be nice. -- Cedric ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Structural QA activities
Coverity will do this themselves for LibreOffice for free: http://scan.coverity.com/ It just needs someone from the project to liaise with them and get it set up. On 2012-01-18 14:30, Luc Castermans wrote: Gents, I've been polling inside my work-environment whether I could run Coverity on the LibreOffice code tree. No success so far,it has my attention. From my past I know of similar tools, static code analysis tools, like QAC. Which triggers the question: has a QA-tool been run on the source code, if so which? Thx, Disclaimer: http://www.peralex.com/disclaimer.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Structural QA activities
Luc Castermans wrote: Which triggers the question: has a QA-tool been run on the source code, if so which? Hi Luc, if by QA tool you mean static analysis, then yes - there's cppcheck http://libreoffice.boldandbusted.com/ and I know that coverity and at least one other proprietary inspection tool had been run over the code base every once in a while. What, in reality, is even more helpful is to have LibreOffice run under valgrind, and have it churn through as many test documents as possible. Cheers, -- Thorsten pgpvCoKcArgLn.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Re: [PATCH] Replaced SAL_INFO with SAL_WARN. Was: [PATCH] Replaced DBG_ERRORFILE with SAL_INFO.
Hi Michael, On Tuesday, 2012-01-17 23:34:22 +0100, Michael Stahl wrote: thanks for the patches, pushed the whole lot. You were faster than me building over night ... just one nitpick, it's i18n not l18n ;-) http://cgit.freedesktop.org/libreoffice/core/commit/?id=923934d0f41b5b54c9aa4491958cd1939779902d Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgprrKpwmRWw7.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Structural QA activities
Hi Noel, On Wed, 2012-01-18 at 14:54 +0200, Noel Grandin wrote: Coverity will do this themselves for LibreOffice for free: http://scan.coverity.com/ In theory :-) the reality is rather different, I've contacted those chaps both directly and indirectly and got no response at all. The sad story is that (in the past) they did the work to get this setup for OpenOffice.org - and then their work was ignored; so ... It just needs someone from the project to liaise with them and get it set up. It'd be great to have someone that could run this for us and share the report (if their license allows that). It'd make some great fruit for easy hacks. Then again - please do reach out to them again - perhaps things will go better this time ? [ asking for a free (evaluation?) license might be good too if someone wanted to set this up ]. All the best, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Structural QA activities
I think the issue is that the guy who was managing the project (David Maxwell) has moved on from Coverity to eSentire. I've dropped him an email to see if he knows who took over from him at Coverity. On 2012-01-18 16:13, Michael Meeks wrote: Hi Noel, On Wed, 2012-01-18 at 14:54 +0200, Noel Grandin wrote: Coverity will do this themselves for LibreOffice for free: http://scan.coverity.com/ In theory :-) the reality is rather different, I've contacted those chaps both directly and indirectly and got no response at all. The sad story is that (in the past) they did the work to get this setup for OpenOffice.org - and then their work was ignored; so ... It just needs someone from the project to liaise with them and get it set up. It'd be great to have someone that could run this for us and share the report (if their license allows that). It'd make some great fruit for easy hacks. Then again - please do reach out to them again - perhaps things will go better this time ? [ asking for a free (evaluation?) license might be good too if someone wanted to set this up ]. All the best, Michael. Disclaimer: http://www.peralex.com/disclaimer.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] CPU eating after opening a password protected macro library
Hi all I submited https://bugs.freedesktop.org/show_bug.cgi?id=44900 The problem is that when openoing a basic library that is password protected, the CPU is then eaten at 43% until i close libreOffice I have this behaviour on master, 3.5.0beta3 but NOT 3.4.3 So it seems a regression to me. Do we have any solution for this ? Feel free to ask for more details Laurent ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Icons in Specialized class ListBox
Hi I'm working on the file picker dialog. I would like to add a list of places as those we can see on most common file pickers (bookmarks on the left of the dialog). In order to display these places, I use specialization of the SvtListBox component. I would like to add icons for each item in the list. Do you know what the best way to display icons in a listbox is ? Should I re-implement (override) the ListBox::draw() method, or is an other way to do that more easily ? Best regards Julien ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 37561, which changed state. Bug 37561 Summary: Failed installing extension: Duden-Korrektor 5.0/6.0 https://bugs.freedesktop.org/show_bug.cgi?id=37561 What|Old Value |New Value Resolution||FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 37561, which changed state. Bug 37561 Summary: Failed installing extension: Duden-Korrektor 5.0/6.0 https://bugs.freedesktop.org/show_bug.cgi?id=37561 What|Old Value |New Value Resolution||FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [LibreOffice] #fdo39428 Remove/audit SvStream operator/(long)
Hello all
Attached are the patch files relating to this issue. I've done make clean,
make check, and make dev-install without errors. Please excuse the bumbling
use of git, I'm on a steep learning curve :)
This code is released under LGPL3+/GPL3+/MPL license.
Kind regards
Keith
From fa4257356472f466673cd88cb2c4331386a30dda Mon Sep 17 00:00:00 2001
From: Keith McRae keithco...@gmail.com
Date: Wed, 18 Jan 2012 14:51:03 +
Subject: [PATCH 1/7] fdo#39428 Remove/audit SvStream operator/(long)
Removed declarations definitions for operator(long),(int)(short)
Removed declarations definitions for operator(long),(int)(short)
Added (where necessary) operator for sal_Int sal_uInt types
Added (where necessary) operator for sal_Int sal_uInt types
Added SwapInt64 function, basically a copy of SwapUInt64
---
tools/inc/tools/stream.hxx | 18 ++---
tools/source/stream/stream.cxx | 82 +++-
2 files changed, 59 insertions(+), 41 deletions(-)
diff --git a/tools/inc/tools/stream.hxx b/tools/inc/tools/stream.hxx
index e96f3e1..0c7e13e 100644
--- a/tools/inc/tools/stream.hxx
+++ b/tools/inc/tools/stream.hxx
@@ -335,12 +335,15 @@ public:
{ eLineDelimiter = eLineEnd; }
LineEnd GetLineDelimiter() const { return eLineDelimiter; }
+//fdo#39428 Remove SvStream operator(long)
+//operator(short) and operator(int) removed also
SvStream operator( sal_uInt16 rUInt16 );
SvStream operator( sal_uInt32 rUInt32 );
SvStream operator( sal_uInt64 rUInt64 );
-SvStream operator( long rLong );
-SvStream operator( short rShort );
-SvStream operator( int rInt );
+SvStream operator( sal_Int16 rInt16 );
+SvStream operator( sal_Int32 rInt32 );
+SvStream operator( sal_Int64 rInt64 );
+
SvStream operator( signed char rChar );
SvStream operator( char rChar );
SvStream operator( unsigned char rChar );
@@ -348,12 +351,15 @@ public:
SvStream operator( double rDouble );
SvStream operator( SvStream rStream );
+//fdo#39428 Remove SvStream operator(long)
+//operator(short) and operator(int) removed also
SvStream operator( sal_uInt16 nUInt16 );
SvStream operator( sal_uInt32 nUInt32 );
SvStream operator( sal_uInt64 nuInt64 );
-SvStream operator( long nLong );
-SvStream operator( short nShort );
-SvStream operator( int nInt );
+SvStream operator( sal_Int16 nInt16 );
+SvStream operator( sal_Int32 nInt32 );
+SvStream operator( sal_Int64 nInt64 );
+
SvStream operator( signed char nChar );
SvStream operator( char nChar );
SvStream operator( unsigned char nChar );
diff --git a/tools/source/stream/stream.cxx b/tools/source/stream/stream.cxx
index 7a9bf0d..57c9172 100644
--- a/tools/source/stream/stream.cxx
+++ b/tools/source/stream/stream.cxx
@@ -91,6 +91,26 @@ inline static void SwapUInt64( sal_uInt64 r )
s.c[1] = SWAPLONG(s.c[1]);
r = s.n;
}
+
+//#fdo39428 Added for operator(sal_Int64)
+inline static void SwapInt64( sal_Int64 r )
+{
+union
+{
+sal_Int64 n;
+sal_Int32 c[2];
+} s;
+
+s.n = r;
+s.c[0] ^= s.c[1]; // swap the 32 bit words
+s.c[1] ^= s.c[0];
+s.c[0] ^= s.c[1];
+// swap the bytes in the words
+s.c[0] = SWAPLONG(s.c[0]);
+s.c[1] = SWAPLONG(s.c[1]);
+r = s.n;
+}
+
#ifdef UNX
inline static void SwapFloat( float r )
{
@@ -1041,6 +1061,8 @@ sal_Size SvStream::SeekRel( sal_sSize nPos )
|*
*/
+//fdo#39428 Remove SvStream operator(long)
+//operator(short) and operator(int) removed also
SvStream SvStream::operator(sal_uInt16 r)
{
sal_uInt16 n = 0;
@@ -1067,7 +1089,6 @@ SvStream SvStream::operator(sal_uInt32 r)
return *this;
}
-
SvStream SvStream::operator(sal_uInt64 r)
{
sal_uInt64 n = 0;
@@ -1081,47 +1102,41 @@ SvStream SvStream::operator(sal_uInt64 r)
return *this;
}
-SvStream SvStream::operator (long r) //puke!, kill this
+
+SvStream SvStream::operator(sal_Int16 r)
{
-#if(SAL_TYPES_SIZEOFLONG != 4)
-int n;
-*this n;
-if (good())
-r = n;
-#else
-long n = 0;
-READNUMBER_WITHOUT_SWAP(long, n)
+sal_Int16 n = 0;
+READNUMBER_WITHOUT_SWAP(sal_Int16, n)
if (good())
{
if (bSwap)
-SwapLong(n);
+SwapShort(n);
r = n;
}
-#endif
return *this;
}
-SvStream SvStream::operator(short r)
+SvStream SvStream::operator(sal_Int32 r)
{
-short n = 0;
-READNUMBER_WITHOUT_SWAP(short, n)
+sal_Int32 n = 0;
+READNUMBER_WITHOUT_SWAP(sal_Int32, n)
if (good())
{
-if(bSwap)
-SwapShort(n);
+if (bSwap)
+
[Libreoffice] Blocker in 3.5.0Beta3?
Hi all While installing LO 3.5.0Beta3 today in my Win XP Home x86 pt-PT netbook I noticed that the installer only starts in Portuguese for a brief second and then switches to English. I had never tried a 3.5.x build in that netbook and after quickly testing with Beta1 and Beta2 I conclude that there is some bug with language selection. Does it work correctly in other languages? If not, should I report this as a blocker? -- Pedro __ If you reply to this email, your message will be added to the discussion below: http://nabble.documentfoundation.org/Blocker-in-3-5-0Beta3-tp3669807p3669807.html This email was sent by Pedro (via Nabble) To receive all replies by email, subscribe to this discussion: http://nabble.documentfoundation.org/template/NamlServlet.jtp?macro=subscribe_by_codenode=3669807code=bGlicmVvZmZpY2VAbGlzdHMuZnJlZWRlc2t0b3Aub3JnfDM2Njk4MDd8LTE1MTIzNjU1NDE=___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Android bitlets ...
Hi there,
Playing with the android stuff some more, I got quite a bit further;
but had a few problems - thought it's prolly better to ask on the
archived list for help:
* size of /data too small: (default seems to be 54Mb or so)
make install:
[echo]
Installing /home/opt/libreoffice/devel/android/qa/sc/bin/sc-debug.apk
onto default emulator or device...
[exec] 3856 KB/s (32230207 bytes in 8.162s)
[exec] pkg: /data/local/tmp/sc-debug.apk
[exec] Failure [INSTALL_FAILED_INSUFFICIENT_STORAGE]
I tried to fiddle with the avd creator at great length to make /data
bigger, only succeeding in making it crash on boot in a loop ;-)
In the end I did:
adb shell
mkdir /mnt/sdcard/tmp
mount -o bind /mnt/sdcard/tmp /data/local/tmp
And it installed: not beautiful, but ... what do you do ? there must be
a better way (surely) :-)
* running it I get logcat to show me:
I/ActivityManager( 77): Start proc org.libreoffice.android.qa.sc for activity
org.libreoffice.android.qa.sc/org.libreoffice.android.Bootstrap: pid=594
uid=10040 gids={}
I/dalvikvm( 594): Turning on JNI app bug workarounds for target SDK version
9...
W/NetworkManagementSocketTagger( 77): setKernelCountSet(10040, 1) failed with
errno -2
V/TabletStatusBar( 130): setLightsOn(true)
W/dalvikvm( 594): Exception Ljava/lang/UnsatisfiedLinkError; thrown while
initializing Lorg/libreoffice/android/Bootstrap;
W/dalvikvm( 594): Class init failed in newInstance call
(Lorg/libreoffice/android/Bootstrap;)
D/AndroidRuntime( 594): Shutting down VM
W/dalvikvm( 594): threadid=1: thread exiting with uncaught exception
(group=0x409961f8)
E/AndroidRuntime( 594): FATAL EXCEPTION: main
E/AndroidRuntime( 594): java.lang.ExceptionInInitializerError
E/AndroidRuntime( 594):at java.lang.Class.newInstanceImpl(Native
Method)
...
E/AndroidRuntime( 594):at
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:784)
E/AndroidRuntime( 594):at
com.android.internal.os.ZygoteInit.main(ZygoteInit.java:551)
E/AndroidRuntime( 594):at dalvik.system.NativeStart.main(Native Method)
E/AndroidRuntime( 594): Caused by: java.lang.UnsatisfiedLinkError: Couldn't
load lo-bootstrap: findLibrary returned null
E/AndroidRuntime( 594):at
java.lang.Runtime.loadLibrary(Runtime.java:365)
E/AndroidRuntime( 594):at java.lang.System.loadLibrary(System.java:535)
E/AndroidRuntime( 594):at
org.libreoffice.android.Bootstrap.clinit(Bootstrap.java:207)
E/AndroidRuntime( 594):... 15 more
I/ARMAssembler( 36): generated scanline__0077:03515104_9002_
[127 ipp] (149 ins) at [0x41c86450:0x41c866a4] in 1748431 ns
W/ActivityManager( 77): Force finishing activity
org.libreoffice.android.qa.sc/org.libreoffice.android.Bootstrap
Which puzzles me a little - could this be related to my previous
problem:
* building fails with missing local.properties errors
+ to fix this I ran:
cd android/qa/sc
/opt/libreoffice/android-sdk-linux/tools/android update project -n sc -t
android-12 -p `pwd`
cd android/Bootstrap
/opt/libreoffice/android-sdk-linux/tools/android update project -n Bootstrap -t
android-12 -p `pwd`
Presumably that's utterly wrong ;-) but ... it got me a bit further.
Do we need to have a --with-android-sdk parameter for configure too,
and add some of that stuff to the Makefile(s) as well ?
* android/qa/simple
I tweaked this to use the new Makefile defines, and tried to adapt it
to some new paths (sal got gnu-make-ised in the meantime eg.). Almost
certainly I broke it in the process.
Hopefully I can get to some more fixing (or breaking depending how you
look at it) tomorrow. I believe I managed to commit my first half-arsed
version of an android VCL backend by accident: which does nothing at all
really except avoid the plugadapt thing - that could be the cause too.
More debugging tips much appreciated etc.
Thanks !
Michael.
--
michael.me...@suse.com , Pseudo Engineer, itinerant idiot
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] CPU eating after opening a password protected macro library
Hi Laurent, On Wed, 2012-01-18 at 15:29 +0100, Laurent Godard wrote: I submited https://bugs.freedesktop.org/show_bug.cgi?id=44900 Great, I've asked for more information in the bug. In general - unless you're discussing the technical details of a patch, or asking for code pointers to solve a bug - just posting it to the developers list is not the right approach :-) there is no shortage of bugs. All the best, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] CPU eating after opening a password protected macro library
On Wed, 2012-01-18 at 18:39 +, Michael Meeks wrote: Hi Laurent, On Wed, 2012-01-18 at 15:29 +0100, Laurent Godard wrote: I submited https://bugs.freedesktop.org/show_bug.cgi?id=44900 Great, I've asked for more information in the bug. In general - unless you're discussing the technical details of a patch, or asking for code pointers to solve a bug - just posting it to the developers list is not the right approach :-) there is no shortage of bugs. Just to give you a background (and be fair to Laurent), I'm the one who suggested him to post to the mailing list, hoping to get a code pointer from someone (since I'm not that familiar with this functionality). I guess he didn't make that clear, or I didn't make it clear to him on IRC. In general, Laurent understands our rule, and is more than willing to dive into the code given some pointers. Just to update, he's already done some profiling to figure it out, but got some roadblocks. Regards, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Icons in Specialized class ListBox
Hi Julien, On Wednesday, 2012-01-18 16:17:32 +0100, Julien Levesy wrote: I'm working on the file picker dialog. I would like to add a list of places as those we can see on most common file pickers (bookmarks on the left of the dialog). In order to display these places, I use specialization of the SvtListBox component. Don't know which SvtListBox you are referring, there is no such class. I would like to add icons for each item in the list. Do you know what the best way to display icons in a listbox is ? There's the vcl ListBox (maybe that's the one you're already using?) that has an InsertEntry() method that takes an Image parameter. You can see it in action under Tools-Options-LanguageSettings-Languages Default languages for documents where it is used to display the ABC check marks for language support. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgpVEaQ1gxEIW.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Android bitlets ...
* size of /data too small: (default seems to be 54Mb or so) I think 54 MB is just enough for the default applications; the LO ucalc unit test app will certainly not fit in that as the LibreOfficeQA-SC-debug.apk file itself is already something like 68 MB... I use -partition-size 500 when I start the emulator. I typically use a command like: emulator-arm -avd avd.vi -no-audio -no-window -partition-size 500 (avd.vi is the name I gave this avd...) adb shell df says for me: Filesystem Size Used Free Blksize /dev 252M32K 252M 4096 /mnt/asec 252M 0K 252M 4096 /mnt/obb 252M 0K 252M 4096 /system484M 151M 333M 4096 /data 490M 287M 202M 4096 /cache 64M 1M62M 4096 after a adb shell stop; adb shell start (which seems to be necessary now and then for files which are removed to actually stop taking disk space, or something). E/AndroidRuntime( 594): Caused by: java.lang.UnsatisfiedLinkError: Couldn't load lo-bootstrap: findLibrary returned null probably there was a lack of space to unpack the .apk... Do a adb shell ls -l /data/data/org.libreoffice.android.qa.sc/lib and see how many of the native libs are missing. * building fails with missing local.properties errors Ah yes. The local.properties that gets automatically set up by I don't remember which command says for me: # This file is automatically generated by Android Tools. # Do not modify this file -- YOUR CHANGES WILL BE ERASED! # # This file must *NOT* be checked in Version Control Systems, # as it contains information specific to your local configuration. # location of the SDK. This is only used by Ant # For customization when using a Version Control System, please read the # header note. sdk.dir=/Users/tml/android-sdk-macosx So I didn't add it to git ;) clearly if we add a --with-android-sdk=/foo switch we should create it automatically. Presumably that's utterly wrong ;-) but ... it got me a bit further. I don't remember. I think the local.properties with its sdk.dir pointer is the only thing missing, otherwise the files in git should be enough as is for ant. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Icons in Specialized class ListBox
Hi Actually, it was ListBox, not SvtListBox ! Thanks for your help, i managed to display icons ! Best regards Julien 2012/1/18 Eike Rathke er...@redhat.com Hi Julien, On Wednesday, 2012-01-18 16:17:32 +0100, Julien Levesy wrote: I'm working on the file picker dialog. I would like to add a list of places as those we can see on most common file pickers (bookmarks on the left of the dialog). In order to display these places, I use specialization of the SvtListBox component. Don't know which SvtListBox you are referring, there is no such class. I would like to add icons for each item in the list. Do you know what the best way to display icons in a listbox is ? There's the vcl ListBox (maybe that's the one you're already using?) that has an InsertEntry() method that takes an Image parameter. You can see it in action under Tools-Options-LanguageSettings-Languages Default languages for documents where it is used to display the ABC check marks for language support. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Removed Window::GetFullscreenSpriteCanvas listed in unusedcode.easy
Code is contributed under the LGPLv3+ / MPL
diff --git a/unusedcode.easy b/unusedcode.easy
index b906bb9..bc78775 100644
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -1,4 +1,4 @@
-AtomDocument::AtomDocument(AtomPubSession*, std::basic_stringchar, std::char_traitschar, std::allocatorchar )
+### AtomDocument::AtomDocument(AtomPubSession*, std::basic_stringchar, std::char_traitschar, std::allocatorchar )
AtomFolder::AtomFolder(AtomPubSession*, std::basic_stringchar, std::char_traitschar, std::allocatorchar )
AtomPubSession::getCollectionUrl(Collection::Type)
ByteString::Assign(char const*, unsigned short)
@@ -15,7 +15,7 @@ CIccMBB::NewCLUT(unsigned char*, unsigned char)
CIccMBB::NewCLUT(unsigned char, unsigned char)
CIccMemIO::Alloc(unsigned int, bool)
CIccMpeCLUT::SetCLUT(CIccCLUT*)
-CIccMpeCreator::DoGetElementSigName(std::basic_stringchar, std::char_traitschar, std::allocatorchar , icElemTypeSignature)
+### CIccMpeCreator::DoGetElementSigName(std::basic_stringchar, std::char_traitschar, std::allocatorchar , icElemTypeSignature)
CIccMpeCurveSet::SetCurve(int, CIccCurveSetCurve*)
CIccProfile::DeleteTag(unsigned int)
CIccProfile::Detach()
diff --git a/vcl/inc/vcl/window.hxx b/vcl/inc/vcl/window.hxx
index 3354499..a2a139a 100644
--- a/vcl/inc/vcl/window.hxx
+++ b/vcl/inc/vcl/window.hxx
@@ -1029,20 +1029,17 @@ public:
/// request XSpriteCanvas render interface for this window
::com::sun::star::uno::Reference
::com::sun::star::rendering::XSpriteCanvas GetSpriteCanvas() const;
-/// request fullscreen XSpriteCanvas render interface for this window
-::com::sun::star::uno::Reference
-::com::sun::star::rendering::XSpriteCanvas GetFullscreenSpriteCanvas( const Size rFullscreenSize ) const;
/* records all DrawText operations within the passed rectangle;
* a synchronous paint is sent to achieve this
*/
voidRecordLayoutData( vcl::ControlLayoutData* pLayout, const Rectangle rRect );
-// Setzen und Abfragen fuer das Toolkit
+// Set and query for the toolkit
VCLXWindow* GetWindowPeer() const;
voidSetWindowPeer( ::com::sun::star::uno::Reference ::com::sun::star::awt::XWindowPeer xPeer, VCLXWindow* pVCLXWindow );
-// Merken, ob vom Toolkit erzeugt
+// Mark and check if created with Toolkit
sal_BoolIsCreatedWithToolkit() const;
voidSetCreatedWithToolkit( sal_Bool b );
diff --git a/vcl/source/window/window.cxx b/vcl/source/window/window.cxx
index 54ac8b2..06f1efc 100644
--- a/vcl/source/window/window.cxx
+++ b/vcl/source/window/window.cxx
@@ -9441,13 +9441,6 @@ uno::Reference rendering::XSpriteCanvas Window::GetSpriteCanvas() const
return xSpriteCanvas;
}
-uno::Reference ::com::sun::star::rendering::XSpriteCanvas Window::GetFullscreenSpriteCanvas( const Size rFullscreenSize ) const
-{
-uno::Reference rendering::XSpriteCanvas xSpriteCanvas(
-ImplGetCanvas( rFullscreenSize, true, true ), uno::UNO_QUERY );
-return xSpriteCanvas;
-}
-
void Window::ImplPaintToDevice( OutputDevice* i_pTargetOutDev, const Point i_rPos )
{
sal_Bool bRVisible = mpWindowImpl-mbReallyVisible;
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW 3-5] fdo#44896 german text cut off
Hi, http://cgit.freedesktop.org/libreoffice/core/commit/?id=225647779959d24cfdaea62968f518cc52533a90 Best regards, Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Removed formula::FormulaCompiler::IsMatrixFunction() const listed in unusedcode.easy
Code is contributed under the LGPLv3+ / MPL
Regards,
Mariusz Dykierek
diff --git a/formula/inc/formula/token.hxx b/formula/inc/formula/token.hxx
index 738caa1..2beed8d 100644
--- a/formula/inc/formula/token.hxx
+++ b/formula/inc/formula/token.hxx
@@ -114,7 +114,6 @@ public:
inline voidDelete(){ delete this; }
inline StackVarGetType() const { return eType; }
boolIsFunction() const; // pure functions, no operators
-boolIsMatrixFunction() const; // if a function _always_ returns a Matrix
boolIsExternalRef() const;
sal_uInt8 GetParamCount() const;
inline voidIncRef() const { nRefCnt++; }
diff --git a/formula/source/core/api/token.cxx b/formula/source/core/api/token.cxx
index d0e8bb8..8052ee4 100644
--- a/formula/source/core/api/token.cxx
+++ b/formula/source/core/api/token.cxx
@@ -125,12 +125,6 @@ sal_uInt8 FormulaToken::GetParamCount() const
// if so then it should be in cByte
}
-
-bool FormulaToken::IsMatrixFunction() const
-{
-return formula::FormulaCompiler::IsMatrixFunction(GetOpCode());
-}
-
bool FormulaToken::IsExternalRef() const
{
bool bRet = false;
diff --git a/unusedcode.easy b/unusedcode.easy
index b906bb9..3ef5bd9 100644
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -1576,7 +1576,6 @@ formula::FormulaDlg_Impl::EditFuncParas(unsigned short)
formula::FormulaDlg_Impl::UpdateFunctionDesc()
formula::FormulaListBox::FormulaListBox(Window*, long)
formula::FormulaSubroutineToken::GetTokenArray() const
-formula::FormulaToken::IsMatrixFunction() const
formula::FormulaTokenArray::AddName(unsigned short)
formula::FormulaTokenArray::GetNextDBArea()
formula::FormulaTokenIterator::First()
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Correction Removed formula::****::IsMatrixFunction() const listed in unusedcode.easy
Was to read: FormulaToken::IsMatrixFunction() const On 2012-01-19 00:15, Mariusz Dykierek wrote: ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Dead code removal
On Sun, 2012-01-15 at 21:52 -0500, Marc-André Laverdière wrote: Hello list, Since I went a bit beyond unusedcode.easy, I prefer to ask review on this one :) I assume you are talking about the change in SVGExport? It all looks reasonable to me. If the push method is not used, then that implies that the clip container is always empty. With that, you can remove a little more code like you did in your patch. BTW, we ask all patch submitters to put [PATCH] in the subject line, or prospective patch reviewers may overlook your patch.[1] Also, I didn't apply your changes in the datetime files in tools. Looks like someone else has got to it first. Thanks, Kohei [1] http://wiki.documentfoundation.org/Development/Patch_Handling_Guideline -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] #fdo39428 Remove/audit SvStream operator/(long)
Hi Keith, On Wed, 2012-01-18 at 17:00 +, Keith McRae wrote: Hello all Attached are the patch files relating to this issue. I've done make clean, make check, and make dev-install without errors. Please excuse the bumbling use of git, I'm on a steep learning curve :) Your patches all look fine. I've made several minor changes here and there, but nothing major. All pushed to master. For future reference, please include [PATCH] in the subject line for all patch submissions. That will help us prospective patch reviewers keep track of all submitted patches on this quite high-volume list. Thanks for your patches. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEWED 3-5] [PUSHED 3-5] fdo#44896 german text cut off
On Wed, 2012-01-18 at 23:52 +0100, Andras Timar wrote: Hi, http://cgit.freedesktop.org/libreoffice/core/commit/?id=225647779959d24cfdaea62968f518cc52533a90 Pushed to -3-5 with my sign-off. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] CPU eating after opening a password protected macro library
Hi Michael Great, I've asked for more information in the bug. i'm in train this morning. will work on it though to give more accurate informations (btw, libreO still responsive) In general - unless you're discussing the technical details of a patch, or asking for code pointers to solve a bug - just posting it to the developers list is not the right approach :-) there is no shortage of bugs. as stated by kohei (thanks to him), i'm aware of it and spent some time on this trying hard to understand (and limited by my poor skills). I'm more than willing to help on this but need some code pointers and advices. Sorry i've not been that clear Best laurent ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Structural QA activities
On Wed, Jan 18, 2012 at 02:13:24PM +, Michael Meeks wrote: It just needs someone from the project to liaise with them and get it set up. It'd be great to have someone that could run this for us and share the report (if their license allows that). It'd make some great fruit for easy hacks. Then again - please do reach out to them again - perhaps things will go better this time ? [ asking for a free (evaluation?) license might be good too if someone wanted to set this up ]. Hi, Red Hat has been running coverity internally on all RHEL/Fedora rpms for ~6 months now and a tool has been developed to simplify that for our developers (i.e., send a source rpm, wait for results :-) The good news is we are allowed to share the results. The not so good news is we only have results for 3.4.3 (because we did not package anything newer at the time of the last run) and the coverity tool seems to have problems with C++11 stuff in libstdc++'s headers, so more recent runs are failing. When time permits (i.e., after 3.5.0 is out :-), I am going to think of a way to do semiautomatic runs for master (let's say once a week) and publish the results somewhere (probably splitted by category, to allow more people to fix things without clashing with each other). Also create an easy hack for it (or, better, one for each category?) Note that the level of false positives is very high: the first run we did found more than 3500 defects and my guesstimate is that more than 80 % of them were false positives (I went through several categories--about 500 defects in total--and fixed what I could, but I did not count :-) D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Structural QA activities
2012/1/19 David Tardon dtar...@redhat.com: Red Hat has been running coverity internally on all RHEL/Fedora rpms for ~6 months now and a tool has been developed to simplify that for our developers (i.e., send a source rpm, wait for results :-) The good news is we are allowed to share the results. The not so good news is we only have results for 3.4.3 (because we did not package anything newer at the time of the last run) and the coverity tool seems to have problems with C++11 stuff in libstdc++'s headers, so more recent runs are failing. When time permits (i.e., after 3.5.0 is out :-), I am going to think of a way to do semiautomatic runs for master (let's say once a week) and publish the results somewhere (probably splitted by category, to allow more people to fix things without clashing with each other). Also create an easy hack for it (or, better, one for each category?) sounds great. Note that the level of false positives is very high: the first run we did found more than 3500 defects and my guesstimate is that more than 80 % of them were false positives (I went through several categories--about 500 defects in total--and fixed what I could, but I did not count :-) How to prevent false positives? could these be turned into easy hacks? They claim they're better then others on this. http://www.verifysoft.com/en_coverity_products_difference.html regards, -- Luc Castermans mailto:luc.casterm...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-qa] [ANNOUNCE] libreoffice-3.5.0.1 tag created (3.5.0-rc1)
Hi, there have been created the libreoffice-3.5.0.1 tag for 3.5.0-rc1 release. The corresponding official builds will be available within 3 days or so. See the attached list of changes against 3.5.0-beta3. See also the schedule at http://wiki.documentfoundation.org/ReleasePlan#3.5_release and release criteria at http://wiki.documentfoundation.org/Release_Criteria Now, if you want to switch your clone to the tag, please do: ./g fetch --tags ./g checkout -b tag-libreoffice-3.5.0.1 libreoffice-3.5.0.1 Thanks again everyone who helped to make this happen. Cheers Fridrich + core + 256x256 Windows icons (fdo#39555) [Andras Timar] + add 256x256 desktop and MIME type icons (fdo#39555, bnc#722644) [Petr Mladek] + contination of 8a17792f2e5 (Handle/invalid column ID cleanup) (fdo#44283) [Lionel Elie Mamane] + copy pivot tables when a sheet is copied. (fdo#43077) [Kohei Yoshida] + defer formula token conversion for defined names (xls import). (fdo#42624) [Kohei Yoshida] + do the same for BIFF5 and earlier. (fdo#42624) [Kohei Yoshida] + drop attributes FRAME and RULES of table for HTML 3.2 (fdo#44616) [Takeshi Abe] + finally, remove data cache when nobody references it. (fdo#43077) [Kohei Yoshida] + fix UpdateCheck clog up server by keeping connection alive (rhbz#544619) [Thorsten Behrens] + fix prefix of command line switches (-- instead of -) (fdo#40991) [Andras Timar] + fix rotation of shapes in imported MS documents (fdo#43193) [Ivan Timofeev] + fix unfortunate name alias mixups with DejaVu fonts (fdo#44078) [Caolán McNamara] + fixed crasher in dialog destructor (fdo#38515) [Cédric Bosdonnat] + have cache instance keep track of who is referencing it. (fdo#43077) [Kohei Yoshida] + implement RTF import progressbar (fdo#38057) [Miklos Vajna] + improve RTF import of table cell spacings (fdo#41034) [Miklos Vajna] + no need to update the source range when it's a named range. (fdo#44661) [Kohei Yoshida] + now, refreshing a table should refresh all linked tables. (fdo#43077) [Kohei Yoshida] + partial revert of ...template names appear... correct word order (fdo#43532) [Stephan Bergmann] + properly update range keys for pivot cache. (fdo#44661) [Kohei Yoshida] + sheet 0 is selected by default. (fdo#44147) [Kohei Yoshida] + text rotation fixes. (bnc#734734) [Muthu Subramanian] + the Open... button's more room problem solved (fdo#33794) [Tomcsik Bence] + vcl: isolate new attempt to count monitors as screens to gtk3 (fdo#43458) [Michael Meeks] + vcl: second part of fix for - get xrandr / y positioning right (fdo#43458) [Michael Meeks] + why not showing horizontal scrollbar when needed? (fdo#30788) [Cédric Bosdonnat] + binfilter + fix for gcc 4.7/C++11: these are not string literal operators [David Tardon] + version 3.5.0.1, tag libreoffice-3.5.0.1 (3.5.0-rc1) [Fridrich Štrba] + core + 256x256 Windows icons (fdo#39555) [Andras Timar] + adapt to the more intuitive libvisio/libwpg API [Fridrich Štrba] + add 256x256 desktop and MIME type icons (fdo#39555, bnc#722644) [Petr Mladek] + add human theme to configure [Bjoern Michaelsen] + add human theme to packaging [Bjoern Michaelsen] + added new custom shape path segment commands - darken/lighten fill color [Radek Doulik] + avoid double deletion during data cache object destruction. [Kohei Yoshida] + avoid iterating beyond the last existing drawing page. [Kohei Yoshida] + bah, i forgot *export* [David Tardon] + bump product version to 3.5.0-beta3+, release number to 3 [Petr Mladek] + bump product version to 3.5.0-rc1, release number to 11 [Fridrich Štrba] + confine JDBC driver to thread-affine apartment for Java 6 performance [Stephan Bergmann] + connectivity: dbase: global variable cleanup [Michael Stahl] + consider the style:mirror property [Fridrich Štrba] + contination of 8a17792f2e5 (Handle/invalid column ID cleanup) (fdo#44283) [Lionel Elie Mamane] + copy pivot tables when a sheet is copied. (fdo#43077) [Kohei Yoshida] + defer formula token conversion for defined names (xls import). (fdo#42624) [Kohei Yoshida] + do the same for BIFF5 and earlier. (fdo#42624) [Kohei Yoshida] + don't create lock files for unit tests [Markus Mohrhard] + drop attributes FRAME and RULES of table for HTML 3.2 (fdo#44616) [Takeshi Abe] + enlarge 'Reset' button for German translation [Andras Timar] + ensure that /usr/include is _appended_ to INCLUDE [Eike Rathke] + finally, remove data cache when nobody references it. (fdo#43077) [Kohei Yoshida] + fix MinGW build. [Jan Holesovsky] + fix UpdateCheck clog up server by keeping connection alive (rhbz#544619) [Thorsten Behrens] + fix configurable branding. [Thorsten Behrens] + fix for gcc 4.7/C++11: this is not string literal operator [David Tardon] + fix ooxml custom shapes with 360 degree arcs [Radek Doulik] +
Re: [Libreoffice-qa] [Libreoffice] [ANNOUNCE] libreoffice-3.5.0.1 tag created (3.5.0-rc1)
Just to remind you that with this fact, the libreoffice-3-5 branch needs 1 signoff to push stuff. Cheers Fridrich On 18/01/12 10:39, Fridrich Strba wrote: Hi, there have been created the libreoffice-3.5.0.1 tag for 3.5.0-rc1 release. The corresponding official builds will be available within 3 days or so. See the attached list of changes against 3.5.0-beta3. See also the schedule at http://wiki.documentfoundation.org/ReleasePlan#3.5_release and release criteria at http://wiki.documentfoundation.org/Release_Criteria Now, if you want to switch your clone to the tag, please do: ./g fetch --tags ./g checkout -b tag-libreoffice-3.5.0.1 libreoffice-3.5.0.1 Thanks again everyone who helped to make this happen. Cheers Fridrich ___ LibreOffice mailing list libreoff...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] Blocker in 3.5.0Beta3?
Hi all While installing LO 3.5.0Beta3 today in my Win XP Home x86 pt-PT netbook I noticed that the installer only starts in Portuguese for a brief second and then switches to English. I had never tried a 3.5.x build in that netbook and after quickly testing with Beta1 and Beta2 I conclude that there is some bug with language selection. Does it work correctly in other languages? If not, should I report this as a blocker? -- Pedro -- View this message in context: http://nabble.documentfoundation.org/Blocker-in-3-5-0Beta3-tp3669807p3669807.html Sent from the QA mailing list archive at Nabble.com. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 44882] New: UI: Nonprinting characters won't show up
https://bugs.freedesktop.org/show_bug.cgi?id=44882 Bug #: 44882 Summary: UI: Nonprinting characters won't show up Classification: Unclassified Product: LibreOffice Version: LibO 3.4.4 release Platform: Other OS/Version: All Status: UNCONFIRMED Status Whiteboard: BSA Severity: normal Priority: medium Component: Writer AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: wince...@gmail.com Created attachment 55713 -- https://bugs.freedesktop.org/attachment.cgi?id=55713 Screen shot Problem description: Steps to reproduce: 1. Turn on the nonprinting characters function. Current behavior: nonprinting characters won't show up after I turn on this feature (see the screenshot added) Expected behavior: nonprinting characters should be shown as usual Platform (if different from the browser): Browser: Mozilla/5.0 (Windows NT 6.0; WOW64; rv:9.0.1) Gecko/20100101 Firefox/9.0.1 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44884] New: circle becomes elliptic
https://bugs.freedesktop.org/show_bug.cgi?id=44884 Bug #: 44884 Summary: circle becomes elliptic Classification: Unclassified Product: LibreOffice Version: LibO 3.4.4 release Platform: x86 (IA32) OS/Version: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Drawing AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: libreoffice_nos...@achner.com I select a circle in LO draw and create it in my sheet. If I now change the circle's size with grabbing the side point with the mouse, I am also able to change the size ratio so that the circle becomes an ellipse. Selecting the checkbox in circle's preferences to keep the size ratio doesn't help. Seems only to take effect for setting the size in the field but not for changing the size with the mouse. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44885] New: Data corruption if editing column chart in calc
https://bugs.freedesktop.org/show_bug.cgi?id=44885 Bug #: 44885 Summary: Data corruption if editing column chart in calc Classification: Unclassified Product: LibreOffice Version: LibO 3.4.5 release Platform: All OS/Version: All Status: UNCONFIRMED Severity: major Priority: medium Component: Spreadsheet AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: br...@ioda-net.ch Created attachment 55717 -- https://bugs.freedesktop.org/attachment.cgi?id=55717 Spreadsheet where you can reproduce the trouble Downstream reference (contain a fix) https://bugzilla.novell.com/show_bug.cgi?id=727504 Reproducible: Always Steps to Reproduce: 1. Try to edit an existing column chart by double click on it 2. The chart is destroyed (loosing it's data ranges sources) 3. right click give only Table data chart in place of data ranges Actual Results: The document contain corrupted charts which are no more valid. The document can't be used anymore, and important definitions are loose. Only a previous backup of the document restore the situation. Expected Results: Work as it should Trying to edit a new column chart reveal a strange behavior during the ranges cells selection ( blanked or loosed ) if data-series tab is selected. My dumb question, why if this is found, and a fix exist, it not backported and fixed, when its a regression Now customers, are going to buy 30 Ms-office Licence, is this what we want for ? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44887] New: Enhancement request: Coretext rendering on Mac OS X
https://bugs.freedesktop.org/show_bug.cgi?id=44887 Bug #: 44887 Summary: Enhancement request: Coretext rendering on Mac OS X Classification: Unclassified Product: LibreOffice Version: unspecified Platform: Other OS/Version: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Libreoffice AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: emir_s...@msn.com Currently text rendering on Mac OS X is very buggy and unreliable. I am sure nearly all Mac OS X LibreOffice users will relate, there are lots of problems. Distorted text, not displayed typefaces, not rendered glyphs... My humble opinion is switching to Coretext would really be a good idea. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43193] Invalid view victor image in DOC
https://bugs.freedesktop.org/show_bug.cgi?id=43193 --- Comment #10 from sasha.libreoff...@gmail.com 2012-01-18 01:32:03 PST --- Thanks for repair! -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 37755] Long number formats doesn't adhere to text alignment format EDITING
https://bugs.freedesktop.org/show_bug.cgi?id=37755 --- Comment #2 from gui guigo...@gmail.com 2012-01-18 01:50:37 PST --- Created attachment 55722 -- https://bugs.freedesktop.org/attachment.cgi?id=55722 Demo document with a clear example Here you will find a demo calc sheet where to check the bug (generated with LOdev 3.5beta3 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 37755] Long number formats doesn't adhere to text alignment format EDITING
https://bugs.freedesktop.org/show_bug.cgi?id=37755 gui guigo...@gmail.com changed: What|Removed |Added Status|NEEDINFO|REOPENED --- Comment #3 from gui guigo...@gmail.com 2012-01-18 01:53:54 PST --- Verified the bug with LOdev3.5beta3, and it still persist. Added a spreadsheet as an attachment to check it (and understand it) generated with same version LOdev3.5beta3 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44888] New: Interaction Go to page or object doesn't work for grouped objects (after save / load)
https://bugs.freedesktop.org/show_bug.cgi?id=44888 Bug #: 44888 Summary: Interaction Go to page or object doesn't work for grouped objects (after save / load) Classification: Unclassified Product: LibreOffice Version: LibO 3.4.3 release Platform: x86 (IA32) OS/Version: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Presentation AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: kl...@bucka-lassen.dk Created attachment 55723 -- https://bugs.freedesktop.org/attachment.cgi?id=55723 Simple example with two pages that demonstrates the bug I have boiled this down to one simple example (attached) where I have created two pages, one with a button to jump to the second page. The first page contains the button which is a group of two objects. To reproduce, open the attached presentation, right click the group on the first page and choose Interaction from the context menu. Then select Go to page or object and the name of the second page (Test) in the list box below. Press OK. Confirm this works by clicking the grouped object (either in Edit or Presentation mode). Now save the presentation and exit LibreOffice. Reopen the just saved presentation and click on the grouped object - it doesn't jump to the second page anymore. A workaround is to set the Go to page or object on one of the individual objects (either Enter group or ungroup/regroup to do this). -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 34531] can not write with Smartboard while presenting
https://bugs.freedesktop.org/show_bug.cgi?id=34531 --- Comment #9 from mal malc...@whsg.info 2012-01-18 02:05:42 PST --- LO Beta 3 works fine on XP Doesn't work with opensuse 11.4, Nvidia and KDE Ink layer can't get above presentation on 2nd screen -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 37752] field value changes not updated till preview, format change EDITING
https://bugs.freedesktop.org/show_bug.cgi?id=37752 gui guigo...@gmail.com changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution||FIXED Version|LibO 3.3.2 release |LibO 3.4.5 release --- Comment #2 from gui guigo...@gmail.com 2012-01-18 02:07:04 PST --- I'm sure it was solved in version 3.4.5 and maybe in eralier version too (but not sure which one)... So, another bug to the bag! :-D Congratulations -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43460] Replace rtl::OUString getLength()==0 with isEmpty() etc.
https://bugs.freedesktop.org/show_bug.cgi?id=43460 --- Comment #44 from Olivier Hallot olivier.hal...@documentfoundation.org 2012-01-18 02:29:36 UTC --- Module sw http://cgit.freedesktop.org/libreoffice/core/commit/?id=964617156260cd157d4f39be01a5d3dec1c29a27 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 32268] Printing when some text is selected (high-lighted): 'Print All' prints nothing!
https://bugs.freedesktop.org/show_bug.cgi?id=32268 --- Comment #7 from sasha.libreoff...@gmail.com 2012-01-18 02:34:36 PST --- please try LibO 3.4.5 from http://www.libreoffice.org/download/ my be there this bug is fixed and if there appears another problems with printer, try this: Goto File - Printer Settings - Properties - Device and change Printer Language Type from PDF to one of the Postscript options. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44890] New: MinGW: LibreOffice crashes often while closing the program on MacOS
https://bugs.freedesktop.org/show_bug.cgi?id=44890 Bug #: 44890 Summary: MinGW: LibreOffice crashes often while closing the program on MacOS Classification: Unclassified Product: LibreOffice Version: LibO 3.4.5 release Platform: Other OS/Version: All Status: UNCONFIRMED Status Whiteboard: BSA Severity: normal Priority: medium Component: Libreoffice AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: adhocroc...@gmail.com Created attachment 55725 -- https://bugs.freedesktop.org/attachment.cgi?id=55725 Crash log Problem description: Steps to reproduce: 1. Start LibreOffice 2. Work on some document 3. Close the document 4. Close LibreOffice Current behavior: LibreOffice crashes often Expected behavior: It should not crash Platform (if different from the browser): Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_2) AppleWebKit/535.7 (KHTML, like Gecko) Chrome/16.0.912.75 Safari/535.7 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44892] New: Icon size does not change
https://bugs.freedesktop.org/show_bug.cgi?id=44892 Bug #: 44892 Summary: Icon size does not change Classification: Unclassified Product: LibreOffice Version: LibO 3.5.0 Beta3 Platform: x86 (IA32) OS/Version: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: soym...@web.de In Extras - Ansicht - Optionen - Symbolgröße On changing Symbolgröße to large nothing happens until I also change the Symbol theme. Also does not work the other way round if I want to change from large to small. Have to change theme again. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44893] New: File Send command crashes the Libreoffice Writer
https://bugs.freedesktop.org/show_bug.cgi?id=44893 Bug #: 44893 Summary: File Send command crashes the Libreoffice Writer Classification: Unclassified Product: LibreOffice Version: LibO 3.4.5 release Platform: x86-64 (AMD64) OS/Version: Windows (All) Status: UNCONFIRMED Severity: critical Priority: medium Component: Writer AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: leonadavi...@gmail.com I have the greek version of libreoffice 3.4.5 in greek Windows Ultimate 32-bit. When I try to use the command Send (Αποστολή in greek) the Writer crashes. The program closes without warning. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44895] New: REGRESSION Autofilter does not work if range contains only one value and empty cells
https://bugs.freedesktop.org/show_bug.cgi?id=44895 Bug #: 44895 Summary: REGRESSION Autofilter does not work if range contains only one value and empty cells Classification: Unclassified Product: LibreOffice Version: LibO 3.5.0 Beta3 Platform: Other OS/Version: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Spreadsheet AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: gdna7...@hotmail.com Created attachment 55728 -- https://bugs.freedesktop.org/attachment.cgi?id=55728 File showing the bug Steps to Reproduce Open the attached file. It is not possible to select in column E only the entry containing 1. In 3.4.X this is possible. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44440] EDITING Crash when copying contents from one CALC OLE object to another OLE object in the document
https://bugs.freedesktop.org/show_bug.cgi?id=0 --- Comment #6 from Nikos gdna7...@hotmail.com 2012-01-18 04:11:11 PST --- 1. Open document from LibO Start Center, 'File - Open' menu 2. double click first OLE object 3. double click on one cell, select its contents, copy 4. click somewhere into the writer document 5. double click second OLE object 6. Click A1 7. control+v for paste --- crash, even on beta3 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44896] New: UI: UI glitch in new option to specify the initial number of sheets; german text cut off
https://bugs.freedesktop.org/show_bug.cgi?id=44896 Bug #: 44896 Summary: UI: UI glitch in new option to specify the initial number of sheets; german text cut off Classification: Unclassified Product: LibreOffice Version: LibO 3.5.0 Beta3 Platform: Other OS/Version: All Status: UNCONFIRMED Status Whiteboard: BSA Severity: normal Priority: medium Component: Spreadsheet AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: s-joyemuseq...@vf.uni-konstanz.de Created attachment 55729 -- https://bugs.freedesktop.org/attachment.cgi?id=55729 german text cut off - marked in red Problem description: In the new option to specify the initial number of sheets in new documents the german text is not entirely visible (the english text is OK) Steps to reproduce: look at the attached picture Current behavior: text cut off Expected behavior: the whole text is visible Platform (if different from the browser): Windows XP, Vindows Vista 64 Browser: Mozilla/5.0 (Windows NT 6.0; WOW64; rv:9.0.1) Gecko/20100101 Firefox/9.0.1 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 40607] EasyHack: call fsync when we can when writing documents to certain linux file-systems
https://bugs.freedesktop.org/show_bug.cgi?id=40607 --- Comment #21 from Michael Meeks michael.me...@novell.com 2012-01-18 04:22:32 PST --- Hi Tristan, FYI, the parse_mounts in your patch won't work for paths containing whitespace. The whitespace characters are translated into octal escape sequences in the file. You'd be better off using setmntent and friends, which handle that for you. Doh - I should have read your code much more carefully; silly me. Any chance of a cleanup / simplify of my patch ? a bit of hunting with gdb to find which bit of code is doing the final close on the output file so we can osl_syncFile it there ? :-) Of course, you'd need a build - but it'd be much appreciated ! :-) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #109 from Michael Meeks michael.me...@novell.com 2012-01-18 04:23:22 PST --- Suggest add major PPTX performance regression: bug#44719 that may affect other font related performance issues. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42665] FILESAVE: I make a file with cells border width but a can save configuration in format .xls
https://bugs.freedesktop.org/show_bug.cgi?id=42665 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution||DUPLICATE --- Comment #4 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-01-18 04:33:07 PST --- Same issue as in Bug 44742 - FORMATTING: FILESAVE as XLS file loses custom border line width information, where we already have much more information @reporter: Please feel free to reopen this Bug if you find evidence that we have an independent issue here. *** This bug has been marked as a duplicate of bug 44742 *** -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 37561] Failed installing extension: Duden-Korrektor 5.0/6.0
https://bugs.freedesktop.org/show_bug.cgi?id=37561 --- Comment #20 from Michael Meeks michael.me...@novell.com 2012-01-18 04:41:49 PST --- My guess is that our old friend uwinapi.dll is the culprit here. The duden_korrektormi.dll imports GetShortPathNameW from uwinapi.dll, and in 3.4 uwinapi.dll does not export such a symbol. Strange indeed; the git log -u of sal/ shows no such symbol being removed (that I could see) uwinapi.dll being built from sal/osl/w32 AFAICS. I imagine this is related to dropping unicows support - seemingly http://prdownloads.sourceforge.net/libunicows/libunicows-1.1.2-src.tar.gz implements that symbol. Which leads me to wonder - what does duden_krrektormi use from unicows, and why is it not linked directly to that ? and so on. If it is only a symbol or two - perhaps we can add them manually to uwinapi.dll - but if it is a whole gamut of unicows functionality, perhaps we'll need to build, compile link that BSD libunicows beasty ... Thoughts ? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 37561] Failed installing extension: Duden-Korrektor 5.0/6.0
https://bugs.freedesktop.org/show_bug.cgi?id=37561 Michael Meeks michael.me...@novell.com changed: What|Removed |Added CC||fridrich.st...@bluewin.ch --- Comment #21 from Michael Meeks michael.me...@novell.com 2012-01-18 04:42:20 PST --- Fridrich - do you have any cycles to look at this ? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43912] MAILMERGE: Server Authentication fails
https://bugs.freedesktop.org/show_bug.cgi?id=43912 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution||WORKSFORME CC||LibreOffice@bielefeldundbus ||s.de --- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-01-18 04:53:55 PST --- Now WORKSFORME with Parallel Dev-Installation of LibreOffice 3.5.0 Beta3- WIN7 Home Premium (64bit) German UI [Build-ID: e40af8c-10029e3-615e522-88673a2-727f724] -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 34184] [Task]: Make E-mail MAILMERGE usable
https://bugs.freedesktop.org/show_bug.cgi?id=34184 Bug 34184 depends on bug 43912, which changed state. Bug 43912 Summary: MAILMERGE: Server Authentication fails https://bugs.freedesktop.org/show_bug.cgi?id=43912 What|Old Value |New Value Resolution||WORKSFORME Status|UNCONFIRMED |RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 33225] nested character styles do not work
https://bugs.freedesktop.org/show_bug.cgi?id=33225 sasha.libreoff...@gmail.com changed: What|Removed |Added CC||sasha.libreoff...@gmail.com --- Comment #3 from sasha.libreoff...@gmail.com 2012-01-18 04:57:00 PST --- not reproduced on LibO 3.3.4 and 3.5.0 beta 2 if problem still exist, please, write how exactly it reproduce -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44379] Table cell optimal sizing
https://bugs.freedesktop.org/show_bug.cgi?id=44379 SURCOUF bunty.surc...@gmail.com changed: What|Removed |Added Version|LibO 3.5.0 Beta2|LibO 3.5.0 Beta3 --- Comment #1 from SURCOUF bunty.surc...@gmail.com 2012-01-18 05:07:08 PST --- Hello, Just installed the beta 3 version. The bug is still there. Cheer -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44899] New: Nasty blinking on appearing of header or footer message
https://bugs.freedesktop.org/show_bug.cgi?id=44899 Bug #: 44899 Summary: Nasty blinking on appearing of header or footer message Classification: Unclassified Product: LibreOffice Version: LibO 3.5.0 Beta3 Platform: Other OS/Version: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: soym...@web.de Please turn of the blinking when the header or footer input message appears, if the mouse pointer is long enough in the area. The feature is great, still the blinking is very distracting. Thanks -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 33743] Add Basic Fonts function in Options of Calc and Impress
https://bugs.freedesktop.org/show_bug.cgi?id=33743 Cheng-Chia Tseng pswo10...@gmail.com changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #2 from Cheng-Chia Tseng pswo10...@gmail.com 2012-01-18 05:20:20 PST --- It still is not implanted yet. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
