[PATCH] source code correction, optimization in for loop
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/1555
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/55/1555/1
source code correction, optimization in for loop
Change-Id: I838c0849454362450f429897224157bc3b5ee2b9
---
M svx/source/table/tablemodel.cxx
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/svx/source/table/tablemodel.cxx b/svx/source/table/tablemodel.cxx
index 46b1c9a..0751b9c 100644
--- a/svx/source/table/tablemodel.cxx
+++ b/svx/source/table/tablemodel.cxx
@@ -1028,10 +1028,11 @@
if( !maRows.empty() !maColumns.empty() )
{
sal_Int32 nCol = getColumnCountImpl() - 1;
+sal_Int32 nRowCountImpl = getRowCountImpl();
while( nCol 0 )
{
bool bEmpty = true;
-for( sal_Int32 nRow = 0; (nRow getRowCountImpl()) bEmpty;
nRow++ )
+for( sal_Int32 nRow = 0; (nRow nRowCountImpl) bEmpty; nRow++ )
{
Reference XMergeableCell xCell( getCellByPosition( nCol,
nRow ), UNO_QUERY );
if( xCell.is() !xCell-isMerged() )
@@ -1065,10 +1066,11 @@
}
sal_Int32 nRow = getRowCountImpl() - 1;
+sal_Int32 nColumnCountImpl = getColumnCountImpl();
while( nRow 0 )
{
bool bEmpty = true;
-for( nCol = 0; (nCol getColumnCountImpl()) bEmpty; nCol++ )
+for( nCol = 0; (nCol nColumnCountImpl) bEmpty; nCol++ )
{
Reference XMergeableCell xCell( getCellByPosition( nCol,
nRow ), UNO_QUERY );
if( xCell.is() !xCell-isMerged() )
@@ -1116,7 +1118,7 @@
const sal_Int32 nLastRow = nRow + nRowSpan;
const sal_Int32 nLastCol = nCol + nColSpan;
-if( (nLastRow getRowCount()) || (nLastCol getRowCount() ) )
+if( (nLastRow getRowCount()) || (nLastCol getColumnCount() ) )
{
OSL_FAIL(TableModel::merge(), merge beyound the table!);
}
--
To view, visit https://gerrit.libreoffice.org/1555
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I838c0849454362450f429897224157bc3b5ee2b9
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Karthikeyan Krishnamurthi karthike...@kacst.edu.sa
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
license statement
Hi All, I confirm all my past and future contributions made to the LibreOffice project are done under MPL1.1+ / GPLv3+ / LGPLv3+. Regards, K. Karthikeyan. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
License Statement
I hereby declare that: All my contributions, past and future, to LibreOffice are licensed under the terms of the MPL / LGPLv3+. thanks, --navin-patidar Warning: This message and its attachment, if any, are confidential and may contain information protected by law. If you are not the intended recipient, please contact the sender immediately and delete the message and its attachment, if any. You should not copy the message and its attachment, if any, or disclose its contents to any other person or use it for any purpose. Statements and opinions expressed in this e-mail and its attachment, if any, are those of the sender, and do not necessarily reflect those of King Abdulaziz city for Science and Technology (KACST) in the Kingdom of Saudi Arabia. KACST accepts no liability for any damage caused by this email. تحذير: هذه الرسالة وما تحويه من مرفقات (إن وجدت) تمثل وثيقة سرية قد تحتوي على معلومات محمية بموجب القانون. إذا لم تكن الشخص المعني بهذه الرسالة فيجب عليك تنبيه المُرسل بخطأ وصولها إليك، وحذف الرسالة ومرفقاتها (إن وجدت)، ولا يجوز لك نسخ أو توزيع هذه الرسالة أو مرفقاتها (إن وجدت) أو أي جزء منها، أو البوح بمحتوياتها للغير أو استعمالها لأي غرض. علماً بأن فحوى هذه الرسالة ومرفقاتها (ان وجدت) تعبر عن رأي المُرسل وليس بالضرورة رأي مدينة الملك عبدالعزيز للعلوم والتقنية بالمملكة العربية السعودية، ولا تتحمل المدينة أي مسئولية عن الأضرار الناتجة عن ما قد يحتويه هذا البريد. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: src/docrecord.py
src/docrecord.py | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
New commits:
commit c37c38e79a0ff142e78111c3ffd4febf1c29
Author: Miklos Vajna vmik...@suse.cz
Date: Sun Jan 6 10:54:47 2013 +0100
Get rid of FcCompressed::getFCTransformedValue
The problem with this static method was that it always assumed
fCompressed to be True, and being static, there was no way to fix this.
Now that Clx is parsed before other FibRgFcLcb97 structures, its usage
can be avoided.
diff --git a/src/docrecord.py b/src/docrecord.py
index ade2ade..4f5c11a 100644
--- a/src/docrecord.py
+++ b/src/docrecord.py
@@ -50,10 +50,6 @@ class FcCompressed(DOCDirStream):
to = end
return
globals.encodeName(self.mainStream.bytes[fro:to].decode('utf-16'), lowOnly =
True)
-@staticmethod
-def getFCTransformedValue(bytes, start, end):
-return globals.encodeName(bytes[start:end])
-
class Pcd(DOCDirStream):
The Pcd structure specifies the location of text in the WordDocument
Stream and additional properties for this text.
def __init__(self, bytes, mainStream, offset, size):
@@ -163,7 +159,7 @@ class PlcfBkl(DOCDirStream, PLC):
end = offset + self.getuInt32(pos = pos)
print 'aCP index=%d bookmarkEnd=%d' % (i, end)
start = self.mainStream.plcfAtnBkf.aCP[i]
-print 'transformed value=%s/' %
FcCompressed.getFCTransformedValue(self.mainStream.bytes, start, end)
+print 'transformed value=%s/' %
self.mainStream.retrieveText(start, end)
pos += 4
print '/aCP'
print '/plcfBkl'
@@ -656,7 +652,7 @@ class PlcfandTxt(DOCDirStream, PLC):
start = self.getuInt32(pos = pos)
end = self.getuInt32(pos = pos + 4)
print 'aCP index=%d start=%d end=%d' % (i, start, end)
-print 'transformed value=%s/' %
FcCompressed.getFCTransformedValue(self.mainStream.bytes, offset+start,
offset+end)
+print 'transformed value=%s/' %
self.mainStream.retrieveText(offset + start, offset + end)
pos += 4
print '/aCP'
print '/plcfandTxt'
@@ -676,7 +672,7 @@ class PlcfandRef(DOCDirStream, PLC):
for i in range(self.getElements()):
start = offset + self.getuInt32(pos = pos)
print 'aCP index=%d commentEndOffset=%d' % (i, start)
-print 'transformed value=%s/' %
FcCompressed.getFCTransformedValue(self.mainStream.bytes, start, start + 1)
+print 'transformed value=%s/' %
self.mainStream.retrieveText(start, start + 1)
pos += 4
# aATRDPre10
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: src/docrecord.py src/docstream.py
src/docrecord.py |7 --- src/docstream.py |2 +- 2 files changed, 5 insertions(+), 4 deletions(-) New commits: commit db7cb080392f8a5a9681909671d63b4888288755 Author: Miklos Vajna vmik...@suse.cz Date: Sun Jan 6 11:06:42 2013 +0100 don't throw on word2000 docs diff --git a/src/docrecord.py b/src/docrecord.py index 4f5c11a..c1e4b2a 100644 --- a/src/docrecord.py +++ b/src/docrecord.py @@ -1452,7 +1452,7 @@ class Dop(DOCDirStream): elif self.fib.nFibNew == 0x0112: Dop2007(self).dump() else: -print todo what=Dop.dump() doesn't know how to handle nFibNew = %s % hex(self.nFibNew) +print todo what=Dop.dump() doesn't know how to handle nFibNew = %s/ % hex(self.fib.nFibNew) print '/dop' class FFID(DOCDirStream): @@ -1741,8 +1741,9 @@ class STSHI(DOCDirStream): self.pos += self.stshif.size if self.pos - posOrig self.size: self.printAndSet(ftcBi, self.readuInt16()) -stshiLsd = StshiLsd(self.bytes, self, self.pos) -stshiLsd.dump() +if self.pos - posOrig self.size: +stshiLsd = StshiLsd(self.bytes, self, self.pos) +stshiLsd.dump() print '/stshi' class LPStshi(DOCDirStream): diff --git a/src/docstream.py b/src/docstream.py index 0eee1d2..a29b9c6 100644 --- a/src/docstream.py +++ b/src/docstream.py @@ -89,7 +89,7 @@ class WordDocumentStream(DOCDirStream): if self.nFibNew == 0x0112: self.dumpFibRgCswNewData2007(fibRgCswNewData2007) else: -print todo what=dumpFibRgCswNew() doesn't know how to handle nFibNew = %s % hex(self.nFibNew) +print todo what=dumpFibRgCswNew() doesn't know how to handle nFibNew = %s/ % hex(self.nFibNew) print '/%s' % name def __dumpFibRgCswNewData2000(self): ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: src/docrecord.py
src/docrecord.py | 63 ++-
1 file changed, 58 insertions(+), 5 deletions(-)
New commits:
commit 562e974b78b2a547bea6a5050a81c1623274c90e
Author: Miklos Vajna vmik...@suse.cz
Date: Sun Jan 6 11:29:37 2013 +0100
dump BRC and BrcOperand
diff --git a/src/docrecord.py b/src/docrecord.py
index c1e4b2a..7e31afe 100644
--- a/src/docrecord.py
+++ b/src/docrecord.py
@@ -345,6 +345,46 @@ class Selsf(DOCDirStream):
assert self.pos == self.mainStream.fcWss + self.size
print '/selsf'
+class BRC(DOCDirStream):
+The Brc structure specifies a border.
+def __init__(self, parent):
+DOCDirStream.__init__(self, parent.bytes)
+self.pos = parent.pos
+self.posOrig = self.pos
+self.cv = self.readuInt32() # TODO parse COLORREF
+self.dptLineWidth = self.readuInt8()
+self.brcType = self.readuInt8() # TODO parse BrcType
+buf = self.readuInt16()
+self.dptSpace = buf 0x1f # 1..5th bits
+self.fShadow = self.getBit(buf, 5)
+self.fFrame = self.getBit(buf, 6)
+self.fReserved = (buf 0xff80) 7 # 8..16th bits
+
+def dump(self):
+print 'brc type=BRC offset=%d' % self.posOrig
+self.printAndSet(cv, self.cv)
+self.printAndSet(dptLineWidth, self.dptLineWidth)
+self.printAndSet(brcType, self.brcType)
+self.printAndSet(dptSpace, self.dptSpace)
+self.printAndSet(fShadow, self.fShadow)
+self.printAndSet(fFrame, self.fFrame)
+self.printAndSet(fReserved, self.fReserved)
+print '/brc'
+
+class BrcOperand(DOCDirStream):
+The BrcOperand structure is the operand to several SPRMs that control
borders.
+def __init__(self, parent):
+DOCDirStream.__init__(self, parent.bytes)
+self.pos = parent.pos
+self.posOrig = self.pos
+self.cb = self.readuInt8()
+self.brc = BRC(self)
+
+def dump(self):
+print 'brcOperand type=BrcOperand offset=%d' % self.posOrig
+self.brc.dump()
+print '/brcOperand'
+
class Sprm(DOCDirStream):
The Sprm structure specifies a modification to a property of a
character, paragraph, table, or section.
def __init__(self, bytes, offset):
@@ -367,6 +407,8 @@ class Sprm(DOCDirStream):
self.sgc = (self.sprm 0x1c00) 10 # 11-13th bits
self.spra = (self.sprm 0xe000) 13 # 14-16th bits
+self.ct = False # If it's a complex type, it can't be dumped as a
simple string.
+self.operand = todo
if self.getOperandSize() == 1:
self.operand = self.getuInt8()
elif self.getOperandSize() == 2:
@@ -378,9 +420,10 @@ class Sprm(DOCDirStream):
elif self.getOperandSize() == 7:
self.operand = self.getuInt64() 0x0fff
elif self.getOperandSize() == 9:
-self.operand = self.getuInt64(pos = self.pos + 1)
-else:
-self.operand = todo
+if self.sprm in (0xd234, 0xd235, 0xd236, 0xd237):
+self.ct = BrcOperand(self)
+else:
+print 'todo what=Sprm::__init__() unhandled sprm of size
9/'
def dump(self):
sgcmap = {
@@ -396,9 +439,19 @@ class Sprm(DOCDirStream):
4: docsprm.secMap,
5: docsprm.tblMap,
}
-print 'sprm value=%s name=%s ispmd=%s fSpec=%s sgc=%s
spra=%s operandSize=%s operand=%s/' % (
-hex(self.sprm), nameMap[self.sgc][self.sprm], hex(self.ispmd),
hex(self.fSpec), sgcmap[self.sgc], hex(self.spra), self.getOperandSize(),
hex(self.operand)
+if self.ct:
+operandstr =
+else:
+if self.operand == todo:
+operandstr = ' operand=/'
+else:
+operandstr = ' operand=%s/' % hex(self.operand)
+print 'sprm value=%s name=%s ispmd=%s fSpec=%s sgc=%s
spra=%s operandSize=%s%s' % (
+hex(self.sprm), nameMap[self.sgc][self.sprm], hex(self.ispmd),
hex(self.fSpec), sgcmap[self.sgc], hex(self.spra), self.getOperandSize(),
operandstr
)
+if self.ct:
+self.ct.dump()
+print '/sprm'
def getOperandSize(self):
if self.spra == 6: # variable
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sw/source
sw/source/core/text/porlay.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 989863d849b1e703e78afc413088c3ae51093139
Author: Julien Nabet serval2...@yahoo.fr
Date: Sat Jan 5 16:21:52 2013 +0100
!= instead of for comparison with end iterator
Change-Id: I6b1d524a7771678758c5cd8d0ef46cb03aba7655
diff --git a/sw/source/core/text/porlay.cxx b/sw/source/core/text/porlay.cxx
index fb346b4..79bde32 100644
--- a/sw/source/core/text/porlay.cxx
+++ b/sw/source/core/text/porlay.cxx
@@ -1238,7 +1238,7 @@ void SwScriptInfo::InitScriptInfo( const SwTxtNode
rNode, sal_Bool bRTL )
// position and that we don't have empty changes.
sal_uInt8 nLastTyp = i18n::ScriptType::WEAK;
xub_StrLen nLastPos = 0;
-for (std::vectorScriptChangeInfo::const_iterator i2 =
aScriptChanges.begin(); i2 aScriptChanges.end(); ++i2)
+for (std::vectorScriptChangeInfo::const_iterator i2 =
aScriptChanges.begin(); i2 != aScriptChanges.end(); ++i2)
{
SAL_WARN_IF( nLastTyp == i2-type ||
nLastPos = i2-position,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - sw/source
sw/source/ui/app/apphdl.cxx |8 +--
sw/source/ui/app/appopt.cxx | 10 ++--
sw/source/ui/app/docsh2.cxx | 17 +++---
sw/source/ui/app/docst.cxx|8 ---
sw/source/ui/app/docstyle.cxx | 103 --
5 files changed, 71 insertions(+), 75 deletions(-)
New commits:
commit f4f23167b6acf2ca7a044cb61dfe347a2ddbe20d
Author: Takeshi Abe t...@fixedpoint.jp
Date: Sun Jan 6 21:43:34 2013 +0900
sal_Bool to bool
Change-Id: I5a29ca056af443643bfef823d0a064c5d834d24f
diff --git a/sw/source/ui/app/apphdl.cxx b/sw/source/ui/app/apphdl.cxx
index 45a0233..19cab01 100644
--- a/sw/source/ui/app/apphdl.cxx
+++ b/sw/source/ui/app/apphdl.cxx
@@ -687,9 +687,9 @@ void SwModule::Notify( SfxBroadcaster /*rBC*/, const
SfxHint rHint )
if( pWrtSh )
{
SFX_ITEMSET_ARG( pDocSh-GetMedium()-GetItemSet(),
pUpdateDocItem, SfxUInt16Item, SID_UPDATEDOCMODE, sal_False);
-sal_Bool bUpdateFields = sal_True;
+bool bUpdateFields = true;
if( pUpdateDocItem pUpdateDocItem-GetValue() ==
document::UpdateDocMode::NO_UPDATE)
-bUpdateFields = sal_False;
+bUpdateFields = false;
if(bUpdateFields)
{
pWrtSh-UpdateInputFlds();
@@ -768,11 +768,11 @@ void SwModule::ConfigurationChanged(
utl::ConfigurationBroadcaster* pBrdCst, sal
}
else if ( pBrdCst == pColorConfig || pBrdCst == pAccessibilityOptions )
{
-sal_Bool bAccessibility = sal_False;
+bool bAccessibility = false;
if( pBrdCst == pColorConfig )
SwViewOption::ApplyColorConfigValues(*pColorConfig);
else
-bAccessibility = sal_True;
+bAccessibility = true;
//invalidate all edit windows
const TypeId aSwViewTypeId = TYPE(SwView);
diff --git a/sw/source/ui/app/appopt.cxx b/sw/source/ui/app/appopt.cxx
index 3ca32fa..edeb058 100644
--- a/sw/source/ui/app/appopt.cxx
+++ b/sw/source/ui/app/appopt.cxx
@@ -74,7 +74,7 @@ using namespace ::com::sun::star::lang;
SfxItemSet* SwModule::CreateItemSet( sal_uInt16 nId )
{
-sal_Bool bTextDialog = (nId == SID_SW_EDITOPTIONS) ? sal_True : sal_False;
+bool bTextDialog = (nId == SID_SW_EDITOPTIONS);
// the options for the Web- and Textdialog are put together here
SwViewOption aViewOpt = *GetUsrPref(!bTextDialog);
@@ -86,7 +86,7 @@ SfxItemSet* SwModule::CreateItemSet( sal_uInt16 nId )
if(pAppView)
{
// if Text then no WebView and vice versa
-sal_Bool bWebView = 0 != PTR_CAST(SwWebView, pAppView);
+bool bWebView = 0 != PTR_CAST(SwWebView, pAppView);
if( (bWebView !bTextDialog) ||(!bWebView bTextDialog))
{
aViewOpt = *pAppView-GetWrtShell().GetViewOptions();
@@ -241,14 +241,14 @@ SfxItemSet* SwModule::CreateItemSet( sal_uInt16 nId )
void SwModule::ApplyItemSet( sal_uInt16 nId, const SfxItemSet rSet )
{
-sal_Bool bTextDialog = nId == SID_SW_EDITOPTIONS;
+bool bTextDialog = nId == SID_SW_EDITOPTIONS;
SwView* pAppView = GetView();
if(pAppView pAppView-GetViewFrame() != SfxViewFrame::Current())
pAppView = 0;
if(pAppView)
{
// the text dialog mustn't apply data to the web view and vice versa
-sal_Bool bWebView = 0 != PTR_CAST(SwWebView, pAppView);
+bool bWebView = 0 != PTR_CAST(SwWebView, pAppView);
if(bWebView == bTextDialog)
pAppView = 0;
}
@@ -499,7 +499,7 @@ SfxTabPage* SwModule::CreateTabPage( sal_uInt16 nId,
Window* pParent, const SfxI
if(pCurrView)
{
// if text then not WebView and vice versa
-sal_Bool bWebView = 0 != PTR_CAST(SwWebView, pCurrView);
+bool bWebView = 0 != PTR_CAST(SwWebView, pCurrView);
if( (bWebView RID_SW_TP_HTML_OPTTABLE_PAGE == nId) ||
(!bWebView RID_SW_TP_HTML_OPTTABLE_PAGE != nId) )
{
diff --git a/sw/source/ui/app/docsh2.cxx b/sw/source/ui/app/docsh2.cxx
index 58bbd6d..f0fa5c3 100644
--- a/sw/source/ui/app/docsh2.cxx
+++ b/sw/source/ui/app/docsh2.cxx
@@ -120,7 +120,7 @@ using namespace ::com::sun::star::uno;
using namespace ::com::sun::star;
using ::rtl::OUString;
using namespace ::sfx2;
-extern sal_Bool FindPhyStyle( SwDoc , const String , SfxStyleFamily );
+extern bool FindPhyStyle( SwDoc , const String , SfxStyleFamily );
/*
Description:create DocInfo (virtual)
@@ -691,7 +691,8 @@ void SwDocShell::Execute(SfxRequest rReq)
case SID_PRINTPREVIEW:
{
-sal_Bool bSet = sal_False, bFound = sal_False, bOnly =
sal_True;
+sal_Bool bSet = sal_False;
+bool
[Libreoffice-commits] .: 3 commits - android/experimental android/qa desktop/source framework/source qadevOOo/runner sal/osl sal/qa unotools/inc unotools/source
android/experimental/DocumentLoader/Makefile |1 -
android/experimental/LibreOffice4Android/Makefile |1 -
android/qa/desktop/Makefile |1 -
desktop/source/app/app.cxx|4 ++--
framework/source/fwe/helper/titlehelper.cxx |2 +-
qadevOOo/runner/graphical/BuildID.java| 11 ---
sal/osl/unx/osxlocale.cxx |3 ---
sal/qa/rtl/doublelock/rtl_doublelocking.cxx |8
unotools/inc/unotools/bootstrap.hxx |3 ---
unotools/source/config/bootstrap.cxx | 14 +-
10 files changed, 8 insertions(+), 40 deletions(-)
New commits:
commit 4427bb0c588382d56d5368e691a29c4c0bbdf944
Author: Tor Lillqvist t...@iki.fi
Date: Sun Jan 6 15:12:12 2013 +0200
The ProductSource (MWS name) makes no sense any more
diff --git a/android/experimental/DocumentLoader/Makefile
b/android/experimental/DocumentLoader/Makefile
index 880a032..6cd8a29 100644
--- a/android/experimental/DocumentLoader/Makefile
+++ b/android/experimental/DocumentLoader/Makefile
@@ -126,7 +126,6 @@ copy-stuff:
echo 'ProductBuildid=3' assets/program/versionrc
echo 'ProductMajor=360' assets/program/versionrc
echo 'ProductMinor=1' assets/program/versionrc
- echo 'ProductSource=OOO350' assets/program/versionrc
echo 'ReferenceOOoMajorMinor=3.6' assets/program/versionrc
#
# .res files
diff --git a/android/experimental/LibreOffice4Android/Makefile
b/android/experimental/LibreOffice4Android/Makefile
index 20627fd..eded9e6 100644
--- a/android/experimental/LibreOffice4Android/Makefile
+++ b/android/experimental/LibreOffice4Android/Makefile
@@ -103,7 +103,6 @@ copy-stuff:
echo 'ProductBuildid=3' assets/program/versionrc
echo 'ProductMajor=360' assets/program/versionrc
echo 'ProductMinor=1' assets/program/versionrc
- echo 'ProductSource=OOO350' assets/program/versionrc
echo 'ReferenceOOoMajorMinor=3.6' assets/program/versionrc
#
# .res files
diff --git a/android/qa/desktop/Makefile b/android/qa/desktop/Makefile
index bb96eef..bec3908 100644
--- a/android/qa/desktop/Makefile
+++ b/android/qa/desktop/Makefile
@@ -70,7 +70,6 @@ buildrcs:
echo ProductBuildid=3 assets/program/versionrc
echo ProductMajor=360 assets/program/versionrc
echo ProductMinor=1 assets/program/versionrc
- echo ProductSource=OOO350 assets/program/versionrc
echo ReferenceOOoMajorMinor=3.6 assets/program/versionrc
echo UpdateID=LibreOffice_3_en-US assets/program/versionrc
echo UpdateURL= assets/program/versionrc
diff --git a/desktop/source/app/app.cxx b/desktop/source/app/app.cxx
index adcf4b7..19f088c 100644
--- a/desktop/source/app/app.cxx
+++ b/desktop/source/app/app.cxx
@@ -1456,10 +1456,10 @@ int Desktop::Main()
delete pLabelResMgr;
#ifdef DBG_UTIL
-//include version ID in non product builds
+//include buildid in non product builds
::rtl::OUString aDefault(development);
aTitle += rtl::OUString( [);
-String aVerId( utl::Bootstrap::getProductSource(aDefault));
+String aVerId( utl::Bootstrap::getProductBuildIdData(aDefault));
aTitle += aVerId;
aTitle += ']';
#endif
diff --git a/framework/source/fwe/helper/titlehelper.cxx
b/framework/source/fwe/helper/titlehelper.cxx
index b54c304..baa8b8c 100644
--- a/framework/source/fwe/helper/titlehelper.cxx
+++ b/framework/source/fwe/helper/titlehelper.cxx
@@ -579,7 +579,7 @@ void TitleHelper::impl_appendModuleName
(::rtl::OUStringBuffer sTitle)
void TitleHelper::impl_appendDebugVersion (::rtl::OUStringBuffer sTitle)
{
::rtl::OUString sDefault(RTL_CONSTASCII_USTRINGPARAM(development));
-::rtl::OUString sVersion = ::utl::Bootstrap::getProductSource(sDefault);
+::rtl::OUString sVersion =
::utl::Bootstrap::getProductBuildIdData(sDefault);
sTitle.appendAscii(RTL_CONSTASCII_STRINGPARAM( [));
sTitle.append(sVersion);
sTitle.appendAscii(RTL_CONSTASCII_STRINGPARAM(]));
diff --git a/qadevOOo/runner/graphical/BuildID.java
b/qadevOOo/runner/graphical/BuildID.java
index f6bc0a6..ce21a0c 100644
--- a/qadevOOo/runner/graphical/BuildID.java
+++ b/qadevOOo/runner/graphical/BuildID.java
@@ -163,13 +163,6 @@ public class BuildID
//System.exit(1);
//}
-public static String getMaster(String _sOfficePath)
-{
-final String sOfficePath = getOfficePath(_sOfficePath);
-final String sMaster = getBuildID(sOfficePath,
ProductSource);
-return sMaster;
-}
-
public static String getMinor(String _sOfficePath)
{
final String sOfficePath = getOfficePath(_sOfficePath);
@@ -199,10 +192,6 @@ public class BuildID
//sBuildID = getBuildID(sApp);
//System.out.println(BuildID is: +
[Libreoffice-commits] .: 6 commits - cppuhelper/source ios/CustomTarget_Viewer_app.mk ios/experimental sal/rtl solenv/gbuild vcl/ios
cppuhelper/source/shlib.cxx | 25 ++-
ios/CustomTarget_Viewer_app.mk | 101 +--
ios/experimental/Viewer/.gitignore |2
ios/experimental/Viewer/Viewer.xcodeproj/project.pbxproj |4
ios/experimental/Viewer/Viewer/Icon-72.png |binary
ios/experimental/Viewer/Viewer/lo-viewer.mm | 92 -
sal/rtl/source/bootstrap.cxx |8 +
solenv/gbuild/platform/IOS_ARM_GCC.mk|2
vcl/ios/source/app/salinst.cxx | 41 --
9 files changed, 153 insertions(+), 122 deletions(-)
New commits:
commit 4a11f5c28a2d7b4d50d67f26cba889169977a0ce
Author: Tor Lillqvist t...@iki.fi
Date: Sat Jan 5 23:13:49 2013 +0200
More hacking on iOS stuff
Get the app bundle directory from Xcode's SCRIPT_OUTPUT_FILE_0.
Copy .rdb, registry, .res files, set up the various rc files.
Don't list a bunch of .component files on the command line, surely
that is not sane.
Change-Id: I6fb8bd4bea8d5afd30900daa1b916defb894e78c
diff --git a/ios/CustomTarget_Viewer_app.mk b/ios/CustomTarget_Viewer_app.mk
index 36cf8c5..9af7a49 100644
--- a/ios/CustomTarget_Viewer_app.mk
+++ b/ios/CustomTarget_Viewer_app.mk
@@ -48,13 +48,85 @@ endif
ifneq ($(SCRIPT_OUTPUT_FILE_0),)
# When run from Xcode, we move the Viewer executable from solver into
-# the Viewer.app directory that Xcode uses.
+# the Viewer.app directory that Xcode uses. We also set up/copy all
+# the run-time configuration etc files that the app needs.
$(call gb_CustomTarget_get_target,ios/Viewer_app) : $(SCRIPT_OUTPUT_FILE_0)
+appdir=$(dir $(SCRIPT_OUTPUT_FILE_0))
+buildid=$(shell git log -1 --format=%H)
+
$(SCRIPT_OUTPUT_FILE_0) : $(call gb_Executable_get_target,Viewer)
$(call gb_Output_announce,$@,fii,APP,2)
- mkdir -p `dirname $(SCRIPT_OUTPUT_FILE_0)`
+ mkdir -p $(appdir)/ure
mv $(call gb_Executable_get_target,Viewer) $(SCRIPT_OUTPUT_FILE_0)
+#
+# Copy rdb files
+#
+ cp $(OUTDIR)/bin/types.rdb $(appdir)
+ cp $(OUTDIR)/bin/ure/types.rdb $(appdir)/ure
+ cp $(OUTDIR)/bin/offapi.rdb $(appdir)
+ cp $(OUTDIR)/xml/services.rdb $(appdir)
+ cp $(OUTDIR)/xml/ure/services.rdb $(appdir)/ure
+#
+# Copy registry files
+#
+ mkdir -p $(appdir)/registry/modules $(appdir)/registry/res
+ cp $(OUTDIR)/xml/*.xcd $(appdir)/registry
+ mv $(appdir)/registry/fcfg_langpack_en-US.xcd $(appdir)/registry/res
+ cp -R $(OUTDIR)/xml/registry/* $(appdir)/registry
+#
+# Copy .res files
+#
+# program/resource is hardcoded in tools/source/rc/resmgr.cxx. Sure,
+# we could set STAR_RESOURCE_PATH instead. sigh...
+#
+ mkdir -p $(appdir)/program/resource
+ cp $(OUTDIR)/bin/*en-US.res $(appdir)/program/resource
+#
+# Set up rc, the inifile. See getIniFileName_Impl().
+#
+ ( \
+ echo '[Bootstrap]' \
+ echo 'URE_BOOTSTRAP=file://$$APP_DATA_DIR/fundamentalrc' \
+ echo 'HOME=$$APP_DATA_DIR/tmp' \
+ : ) $(appdir)/rc
+#
+# Set up fundamentalrc, unorc, bootstraprc and versionrc.
+#
+# Do we really need all these?
+#
+ ( \
+ echo '[Bootstrap]' \
+ echo 'BRAND_BASE_DIR=file://$$APP_DATA_DIR' \
+ echo 'CONFIGURATION_LAYERS=xcsxcu:$${BRAND_BASE_DIR}/registry
module:$${BRAND_BASE_DIR}/registry/modules res:$${BRAND_BASE_DIR}/registry' \
+ : ) $(appdir)/fundamentalrc
+#
+ ( \
+ echo '[Bootstrap]' \
+ : UNO_TYPES and UNO_SERVICES are set up in lo-viewer.mm, is
that sane? \
+ : ) $(appdir)/unorc
+#
+# bootstraprc must be in $BRAND_BASE_DIR/program
+#
+ mkdir -p $(appdir)/program
+ ( \
+ echo '[Bootstrap]' \
+ echo 'InstallMode=installmode' \
+ echo 'ProductKey=LibreOffice Viewer $(PRODUCTVERSION)' \
+ echo 'UserInstallation=file://$$APP_DATA_DIR' \
+ : ) $(appdir)/program/bootstraprc
+#
+# Is this really needed?
+#
+ ( \
+ echo '[Version]' \
+ echo 'AllLanguages=en-US' \
+ echo 'BuildVersion=' \
+ echo 'buildid=$(buildid)' \
+ echo 'ProductBuildid=3' \
+ echo 'ProductMajor=360' \
+ echo 'ProductMinor=1' \
+ : ) $(appdir)/program/versionrc
else
# When run just from the command line, we don't have any app bundle to
diff --git a/ios/experimental/Viewer/Viewer/lo-viewer.mm
b/ios/experimental/Viewer/Viewer/lo-viewer.mm
index a40cb78..616f136 100644
--- a/ios/experimental/Viewer/Viewer/lo-viewer.mm
+++ b/ios/experimental/Viewer/Viewer/lo-viewer.mm
@@ -13,6 +13,7 @@
#import UIKit/UIKit.h
#include postmac.h
+#include comphelper/processfactory.hxx
#include cppuhelper/bootstrap.hxx
#include osl/detail/ios-bootstrap.h
#include osl/process.h
@@
[Libreoffice-commits] .: sal/osl
sal/osl/unx/nlsupport.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
New commits:
commit bf850f6799e505e6d1735540e68e01c6b18ef22f
Author: Tor Lillqvist t...@iki.fi
Date: Sun Jan 6 12:41:07 2013 +0200
Streamline a bit for Android
Change-Id: I8233f6409d75bff23738e121efcdbd340035da9d
diff --git a/sal/osl/unx/nlsupport.c b/sal/osl/unx/nlsupport.c
index fd0e024..b0f231f 100644
--- a/sal/osl/unx/nlsupport.c
+++ b/sal/osl/unx/nlsupport.c
@@ -907,6 +907,12 @@ void _imp_getProcessLocale( rtl_Locale ** ppLocale )
void _imp_getProcessLocale( rtl_Locale ** ppLocale )
{
+#ifdef ANDROID
+/* No locale environment variables on Android, so why even bother
+ * with getenv().
+ */
+ locale = en-US.UTF-8;
+#else
/* simulate behavior off setlocale */
char * locale = getenv( LC_ALL );
@@ -917,13 +923,10 @@ void _imp_getProcessLocale( rtl_Locale ** ppLocale )
locale = getenv( LANG );
if( NULL == locale )
-#ifdef ANDROID
-locale = en-US.UTF-8;
-#else
locale = C;
-#endif
*ppLocale = _parse_locale( locale );
+#endif
}
#endif
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sal/osl
sal/osl/unx/nlsupport.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 3968133721f2d44fa861d369e4d6765c4ffbb6eb Author: Tor Lillqvist t...@iki.fi Date: Sun Jan 6 16:34:37 2013 +0200 Argh, I thought I had compiled this;) Change-Id: I5619e26e5afbe8e6532204feb60b87f6a7875ee0 diff --git a/sal/osl/unx/nlsupport.c b/sal/osl/unx/nlsupport.c index b0f231f..60e21b8 100644 --- a/sal/osl/unx/nlsupport.c +++ b/sal/osl/unx/nlsupport.c @@ -911,7 +911,7 @@ void _imp_getProcessLocale( rtl_Locale ** ppLocale ) /* No locale environment variables on Android, so why even bother * with getenv(). */ - locale = en-US.UTF-8; + char * locale = en-US.UTF-8; #else /* simulate behavior off setlocale */ char * locale = getenv( LC_ALL ); @@ -925,8 +925,8 @@ void _imp_getProcessLocale( rtl_Locale ** ppLocale ) if( NULL == locale ) locale = C; -*ppLocale = _parse_locale( locale ); #endif +*ppLocale = _parse_locale( locale ); } #endif ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - desktop/source framework/source scp2/source
desktop/source/app/app.cxx |2 +-
framework/source/fwe/helper/titlehelper.cxx |2 +-
scp2/source/ooo/common_brand.scp|9 -
3 files changed, 2 insertions(+), 11 deletions(-)
New commits:
commit 9bdaff431bdd71717c64f002f3df0f110c146a08
Author: Tor Lillqvist t...@iki.fi
Date: Sun Jan 6 16:58:39 2013 +0200
Typo
diff --git a/desktop/source/app/app.cxx b/desktop/source/app/app.cxx
index 19f088c..02f6001 100644
--- a/desktop/source/app/app.cxx
+++ b/desktop/source/app/app.cxx
@@ -1459,7 +1459,7 @@ int Desktop::Main()
//include buildid in non product builds
::rtl::OUString aDefault(development);
aTitle += rtl::OUString( [);
-String aVerId( utl::Bootstrap::getProductBuildIdData(aDefault));
+String aVerId( utl::Bootstrap::getBuildIdData(aDefault));
aTitle += aVerId;
aTitle += ']';
#endif
diff --git a/framework/source/fwe/helper/titlehelper.cxx
b/framework/source/fwe/helper/titlehelper.cxx
index baa8b8c..ff64742 100644
--- a/framework/source/fwe/helper/titlehelper.cxx
+++ b/framework/source/fwe/helper/titlehelper.cxx
@@ -579,7 +579,7 @@ void TitleHelper::impl_appendModuleName
(::rtl::OUStringBuffer sTitle)
void TitleHelper::impl_appendDebugVersion (::rtl::OUStringBuffer sTitle)
{
::rtl::OUString sDefault(RTL_CONSTASCII_USTRINGPARAM(development));
-::rtl::OUString sVersion =
::utl::Bootstrap::getProductBuildIdData(sDefault);
+::rtl::OUString sVersion = ::utl::Bootstrap::getBuildIdData(sDefault);
sTitle.appendAscii(RTL_CONSTASCII_STRINGPARAM( [));
sTitle.append(sVersion);
sTitle.appendAscii(RTL_CONSTASCII_STRINGPARAM(]));
commit 1a23b4687aa4fdf0bf1df246cacaba6a3a028f39
Author: Tor Lillqvist t...@iki.fi
Date: Sun Jan 6 16:57:47 2013 +0200
No need to have a ProductSource in versionrc/version.ini any more
diff --git a/scp2/source/ooo/common_brand.scp b/scp2/source/ooo/common_brand.scp
index 7ba7e76..9582f76 100644
--- a/scp2/source/ooo/common_brand.scp
+++ b/scp2/source/ooo/common_brand.scp
@@ -972,15 +972,6 @@ ProfileItem gid_Brand_Profileitem_Version_Buildid
Value = buildid;
End
-ProfileItem gid_Brand_Profileitem_Version_Productsource
-ProfileID = gid_Brand_Profile_Version_Ini;
-ModuleID = gid_Module_Root_Brand;
-Section = Version;
-Order = 7;
-Key = ProductSource;
-Value = sourceid;
-End
-
#ifdef WNT
ProfileItem gid_Brand_Profileitem_Version_Productcode
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: editeng/source sc/source sw/source
editeng/source/editeng/editeng.src |2 +-
sc/source/ui/src/globstr.src |2 +-
sw/source/core/undo/undo.src |2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 93a9e52dccf15b53fc1935145df24306e3a4fc3e
Author: Korrawit Pruegsanusak detective.conan.1...@gmail.com
Date: Sun Dec 23 12:40:09 2012 +0700
fdo#58671: Remove accelerators from Undo action texts
These three texts appear in Undo dropdown list, so they don't need
accelerators
Change-Id: Icec8e199c7cc3990b6316937e49aacb7eb1015fb
Reviewed-on: https://gerrit.libreoffice.org/1473
Reviewed-by: Ivan Timofeev timofeev@gmail.com
Tested-by: Ivan Timofeev timofeev@gmail.com
diff --git a/editeng/source/editeng/editeng.src
b/editeng/source/editeng/editeng.src
index 655861b..ad881e3 100644
--- a/editeng/source/editeng/editeng.src
+++ b/editeng/source/editeng/editeng.src
@@ -61,7 +61,7 @@ String RID_EDITUNDO_SETSTYLE
String RID_EDITUNDO_TRANSLITERATE
{
-Text [ en-US ] = ~Change Case;
+Text [ en-US ] = Change Case;
};
diff --git a/sc/source/ui/src/globstr.src b/sc/source/ui/src/globstr.src
index 79ad06e..a5ac8b2 100644
--- a/sc/source/ui/src/globstr.src
+++ b/sc/source/ui/src/globstr.src
@@ -354,7 +354,7 @@ Resource RID_GLOBSTR
};
String STR_UNDO_TRANSLITERATE
{
-Text [ en-US ] = ~Change Case;
+Text [ en-US ] = Change Case;
};
String STR_DBNAME_IMPORT
{
diff --git a/sw/source/core/undo/undo.src b/sw/source/core/undo/undo.src
index aebd3b8..d5c1ac4 100644
--- a/sw/source/core/undo/undo.src
+++ b/sw/source/core/undo/undo.src
@@ -267,7 +267,7 @@ String STR_MERGE_TABLE
String STR_TRANSLITERATE
{
-Text [ en-US ] = ~Change Case;
+Text [ en-US ] = Change Case;
};
String STR_DELNUM
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PUSHED] fdo#58671: Remove accelerators from Undo action texts
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1473 Approvals: Ivan Timofeev: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1473 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icec8e199c7cc3990b6316937e49aacb7eb1015fb Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Korrawit Pruegsanusak detective.conan.1...@gmail.com Gerrit-Reviewer: Ivan Timofeev timofeev@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sw/source
sw/source/ui/uno/unotxdoc.cxx |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
New commits:
commit 67e1040a7093a872195d0099bf15f5d0b3c2e164
Author: Michael Stahl mst...@redhat.com
Date: Fri Jan 4 22:27:22 2013 +0100
rhbz#890080: crash in SwXTextDocument::getRendererCount
No idea how to reproduce it; pSwView is checked before use except here.
(possibly regression from 2f9f480b22f2fff59d9c48b4b46706c3d5223e66)
Change-Id: Ia7667e879a6944e084a45c06133efc1ac2d8b3c0
(cherry picked from commit 1c52268a5bc6d79c6ee1344e4e341c7e3820d4e0)
Reviewed-on: https://gerrit.libreoffice.org/1546
Reviewed-by: Ivan Timofeev timofeev@gmail.com
Tested-by: Ivan Timofeev timofeev@gmail.com
diff --git a/sw/source/ui/uno/unotxdoc.cxx b/sw/source/ui/uno/unotxdoc.cxx
index 69e524d..e6d25e3 100644
--- a/sw/source/ui/uno/unotxdoc.cxx
+++ b/sw/source/ui/uno/unotxdoc.cxx
@@ -2556,7 +2556,10 @@ sal_Int32 SAL_CALL SwXTextDocument::getRendererCount(
SwViewOption aOpt( *pViewShell-GetViewOptions() );
aOpt.setBrowseMode( false );
pViewShell-ApplyViewOptions( aOpt );
-pSwView-RecheckBrowseMode();
+if (pSwView)
+{
+pSwView-RecheckBrowseMode();
+}
}
// reformating the document for printing will show the changes in
the view
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PUSHED] Change in core[libreoffice-3-6]: rhbz#890080: crash in SwXTextDocument::getRendererCount
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1546 Approvals: Ivan Timofeev: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1546 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7667e879a6944e084a45c06133efc1ac2d8b3c0 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-3-6 Gerrit-Owner: Michael Stahl mst...@redhat.com Gerrit-Reviewer: Ivan Timofeev timofeev@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'libreoffice-4-0' - translations
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 5686cdf6bbc4a2f6ffbc5e7331c51feb27101e83 Author: Andras Timar ati...@suse.com Date: Sun Jan 6 17:18:06 2013 +0100 Updated core Project: translations c3a029cb13eda1c9153a23d62e087301161b6c22 diff --git a/translations b/translations index e8e5534..c3a029c 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit e8e55341aad0521fce7f154a9937a0f3ed162c92 +Subproject commit c3a029cb13eda1c9153a23d62e087301161b6c22 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: translations
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a4298f86f5a6cd4033af541103d0a33a241edeeb Author: Andras Timar ati...@suse.com Date: Sun Jan 6 17:18:06 2013 +0100 Updated core Project: translations e5f69f7b241f21f0b85f7a62ccff9de841875828 diff --git a/translations b/translations index 85f724f..e5f69f7 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit 85f724f5aa1d6a59662a7d1c7ea406a641814bd2 +Subproject commit e5f69f7b241f21f0b85f7a62ccff9de841875828 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: compilerplugins/clang compilerplugins/Makefile-clang.mk config/config_clang.h.in configure.ac
compilerplugins/Makefile-clang.mk |2 +-
compilerplugins/clang/plugin.cxx |2 --
compilerplugins/clang/plugin.hxx |2 ++
compilerplugins/clang/sallogareas.cxx |2 --
config/config_clang.h.in |4
configure.ac |1 +
6 files changed, 8 insertions(+), 5 deletions(-)
New commits:
commit 62532ad485698b70924c54a222890ebcb714dc39
Author: LuboÅ¡ LuÅák l.lu...@suse.cz
Date: Sun Jan 6 18:09:04 2013 +0100
do not set our clang timestamp to the timestamp of the clang binary
If the clang binary comes from a package which had been built before
any of our clang related sources were changed the last time, the timestamp
would be older and so there would be no rebuild. So do the stamp handling
the usual way, clang upgrades will work fine, downgrades will not, but
that's the same problem like with downgrading a library and its headers.
To somewhat mitigate the problem (Clang plugin doesn't get cleaned by
'make clean'), include the full Clang version (which includes SVN revision)
in config_clang.h and make all Clang plugin code include that, so
at least configure re-run will trigger a rebuild if necessary.
Change-Id: I993197f79e92e36105092c92c33b2e1db343e975
diff --git a/compilerplugins/Makefile-clang.mk
b/compilerplugins/Makefile-clang.mk
index e652e44..53c0f2c 100644
--- a/compilerplugins/Makefile-clang.mk
+++ b/compilerplugins/Makefile-clang.mk
@@ -69,6 +69,6 @@ $(CLANGOUTDIR)/plugin.so: $(CLANGOBJS)
# Clang most probably doesn't maintain binary compatibility, so rebuild when
clang changes.
$(CLANGOUTDIR)/clang-timestamp: $(CLANGDIR)/bin/clang
- touch $@ -r $^
+ touch $@
# vim: set noet sw=4 ts=4:
diff --git a/compilerplugins/clang/plugin.cxx b/compilerplugins/clang/plugin.cxx
index 11791b1..7c4256b 100644
--- a/compilerplugins/clang/plugin.cxx
+++ b/compilerplugins/clang/plugin.cxx
@@ -26,8 +26,6 @@
#include sallogareas.hxx
#include unusedvariablecheck.hxx
-#include config_clang.h
-
namespace loplugin
{
diff --git a/compilerplugins/clang/plugin.hxx b/compilerplugins/clang/plugin.hxx
index b9409b2..af1394d 100644
--- a/compilerplugins/clang/plugin.hxx
+++ b/compilerplugins/clang/plugin.hxx
@@ -11,6 +11,8 @@
#ifndef PLUGIN_H
#define PLUGIN_H
+#include config_clang.h
+
#include clang/AST/RecursiveASTVisitor.h
#if __clang_major__ 3 || __clang_major__ == 3 __clang_minor__ 2
diff --git a/compilerplugins/clang/sallogareas.cxx
b/compilerplugins/clang/sallogareas.cxx
index 4462413..7e6c187 100644
--- a/compilerplugins/clang/sallogareas.cxx
+++ b/compilerplugins/clang/sallogareas.cxx
@@ -16,8 +16,6 @@
#include fstream
-#include config_clang.h
-
namespace loplugin
{
diff --git a/config/config_clang.h.in b/config/config_clang.h.in
index 9d87e7a..056d3e8 100644
--- a/config/config_clang.h.in
+++ b/config/config_clang.h.in
@@ -12,4 +12,8 @@ Settings related to Clang compiler plugins.
#undef SRCDIR
#undef WORKDIR
+/* This is actually unused, but it should change whenever Clang changes,
+thus causing update of this .h file and triggerring rebuild of our Clang
plugin. */
+#undef CLANG_FULL_VERSION
+
#endif
diff --git a/configure.ac b/configure.ac
index bd5b074..29cc392 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2906,6 +2906,7 @@ if test $GCC = yes; then
CLANG_FULL_VERSION=`echo __clang_version__ | $CC -E -P -`
CLANGVER=`echo $clang_version | $AWK -F. '{ print
\$1*1+\$2*100+\$3 }'`
AC_MSG_RESULT([Clang $CLANG_FULL_VERSION, $CLANGVER])
+AC_DEFINE_UNQUOTED(CLANG_FULL_VERSION,$CLANG_FULL_VERSION)
fi
fi
AC_SUBST(COM_GCC_IS_CLANG)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: vcl/source
vcl/source/gdi/outdev.cxx |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
New commits:
commit ea9a321d1229914c6342e032da19f47cbeb9de1b
Author: Tor Lillqvist t...@iki.fi
Date: Sun Jan 6 21:54:18 2013 +0200
Avoid duplicates not just for iOS but DISABLE_DYNLOADING in general
Change-Id: Ic449e706f4a8c3c2ed06d8602c6e83755441e0da
diff --git a/vcl/source/gdi/outdev.cxx b/vcl/source/gdi/outdev.cxx
index d34cea9..5d91ba3 100644
--- a/vcl/source/gdi/outdev.cxx
+++ b/vcl/source/gdi/outdev.cxx
@@ -65,14 +65,15 @@
using namespace ::com::sun::star;
DBG_NAME( OutputDevice )
-#ifdef IOS // Static linking, these already exist in the tools
- // library, so put them in the anonymous namespace here to
- // avoid clash...
+#ifdef DISABLE_DYNLOADING
+// Linking all needed LO code into one .so/executable, these already
+// exist in the tools library, so put them in the anonymous namespace
+// here to avoid clash...
namespace {
#endif
DBG_NAME( Polygon )
DBG_NAME( PolyPolygon )
-#ifdef IOS
+#ifdef DISABLE_DYNLOADING
}
#endif
DBG_NAMEEX( Region )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: LO 4.0 build fails in postprocess
On Sat, Jan 05, 2013 at 08:16:51PM +0100, Jean-Baptiste Faure wrote: Extracted error message : Archive: /home/jbf/LibO/master/solver/unxlngx6.pro/pck/driver_calc_qtz.zip packconfig: packing ../unxlngx6.pro/bin/uiconfig_fr.zip finished. packconfig: ERROR: can't find any lang config files in '/home/jbf/LibO/master/solver/unxlngx6.pro/xml/uiconfig' FAILURE: packconfig aborted. dmake: Error code 3, while making '../unxlngx6.pro/bin/uiconfig.zip' So the problem seems to be in one of these commits by D. Tardon which rework UI packaging and seems to be linked to each other: https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit;h=afa240330b51fb3607cfa6390aeb4e085cd1c525 https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit;h=7e1c81e53d436407cae7f8ac915650839ec6d069 https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit;h=d250f6f5626056e94409cc0a6d64f5377bacfe84 https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit;h=90c34cdfa0689167d9dee5df6459ed7449b76301 https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit;h=743e16e71c5b623b3545f19a3ff5640c2ba43cd2 I _think_ Author: Stephan Bergmann sberg...@redhat.com Date: Thu Jan 3 22:20:19 2013 +0100 gb_UITarget_LANGS got removed with b209dec8bbc9be5471438837a4da64adfa350298 create all translations for a .ui file in one uiex call. Change-Id: Idc180b4809b26f45407d3b41b2011edeea886edc was supposed to fix it on master, but -4-0 still has a dmake postprocess and it doesn't fit either way. (no conditional packaging in -4-0) Looks like it was backported without that difference in mind.. I reverted locally these commits starting from https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit;h=235aaeb596c3701373889535f8fd8e29c92d333e and my build was successful. I think this should be done. (Yes, that makes Windows' build slow, but it's better than leaving a localized build broken since Dec, 27 *between the last beta and first rc*...) Regards, Rene ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: solenv/gbuild
solenv/gbuild/platform/android.mk |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) New commits: commit 2ad9d21ac7111f6a3e68f55980f1308a32d3a954 Author: Tor Lillqvist t...@iki.fi Date: Sun Jan 6 22:12:05 2013 +0200 Let's save a bit of disk space Change-Id: I23c9d218792cd3debf30ea59c81e6687a656af31 diff --git a/solenv/gbuild/platform/android.mk b/solenv/gbuild/platform/android.mk index 526c18c..690b886 100644 --- a/solenv/gbuild/platform/android.mk +++ b/solenv/gbuild/platform/android.mk @@ -108,9 +108,13 @@ endef gb_CppunitTest_EXT := .a +# No use for Cppunit targets now for Android (which would be just +# static archives), they are just a waste of disk space. define gb_LinkTarget__command $(call gb_Output_announce,$(2),$(true),LNK,4) -$(call gb_LinkTarget__command_staticlink,$(1)) +$(if $(filter CppunitTest,$(TARGETTYPE)), \ + touch $(1), \ + $(call gb_LinkTarget__command_staticlink,$(1))) endef endif ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PATCH] Cleanup code
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/1556
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/56/1556/1
Cleanup code
This commit is just cleanup in oox
Change-Id: Ic4036c7216c2986d9b237917cb4ae1d829d85003
Signed-off-by: José Guilherme Vanz guilherme@gmail.com
---
M oox/source/ppt/conditioncontext.hxx
M oox/source/ppt/presentationfragmenthandler.cxx
M oox/source/ppt/slidefragmenthandler.cxx
M oox/source/ppt/slidepersist.cxx
M oox/source/ppt/slidetransitioncontext.cxx
M oox/source/ppt/soundactioncontext.cxx
M oox/source/ppt/timenodelistcontext.cxx
7 files changed, 6 insertions(+), 41 deletions(-)
diff --git a/oox/source/ppt/conditioncontext.hxx
b/oox/source/ppt/conditioncontext.hxx
index 47a60c5..12df696 100644
--- a/oox/source/ppt/conditioncontext.hxx
+++ b/oox/source/ppt/conditioncontext.hxx
@@ -44,9 +44,7 @@
virtual ::oox::core::ContextHandlerRef onCreateContext( sal_Int32
aElementToken, const AttributeList rAttribs );
private:
-// ::com::sun::star::uno::Any maCond;
::com::sun::star::animations::Event maEvent;
-// AnimTargetElementPtr mpTarget;
AnimationCondition maCond;
};
diff --git a/oox/source/ppt/presentationfragmenthandler.cxx
b/oox/source/ppt/presentationfragmenthandler.cxx
index 9033372..6d077e7 100644
--- a/oox/source/ppt/presentationfragmenthandler.cxx
+++ b/oox/source/ppt/presentationfragmenthandler.cxx
@@ -114,7 +114,7 @@
xDrawPage = xPresentationPage-getNotesPage();
}
Reference container::XNamed xNamed( xDrawPage,
UNO_QUERY_THROW );
-aURL = OUString( # ).concat( xNamed-getName() );
+aURL = # + xNamed-getName();
xPropSet-setPropertyValue( sURL, Any( aURL ) );
Reference text::XTextContent xContent(
rTextField.xTextField, UNO_QUERY);
Reference text::XTextRange xTextRange(
rTextField.xTextCursor, UNO_QUERY );
@@ -285,8 +285,8 @@
}
catch( uno::Exception )
{
-OSL_FAIL(
OString(OString(oox::ppt::PresentationFragmentHandler::EndDocument(),
-exception caught: ) +
+OSL_FAIL(
OString(oox::ppt::PresentationFragmentHandler::EndDocument(),
+exception caught: +
OUStringToOString(
comphelper::anyToString( cppu::getCaughtException() ),
RTL_TEXTENCODING_UTF8 )).getStr() );
diff --git a/oox/source/ppt/slidefragmenthandler.cxx
b/oox/source/ppt/slidefragmenthandler.cxx
index 643fad2..8caa1a7 100644
--- a/oox/source/ppt/slidefragmenthandler.cxx
+++ b/oox/source/ppt/slidefragmenthandler.cxx
@@ -106,13 +106,10 @@
TextListStylePtr pTextListStyle(new TextListStyle);
SlidePersistPtr pMasterPersistPtr = SlidePersistPtr( new
SlidePersist( rFilter, sal_True, sal_True, mpSlidePersistPtr-getPage(),
ShapePtr( new PPTShape( Master,
com.sun.star.drawing.GroupShape ) ), mpSlidePersistPtr-getNotesTextStyle() )
);
-//pMasterPersistPtr-setLayoutPath( aLayoutFragmentPath );
pMasterPersistPtr-setPath( aNotesFragmentPath );
rFilter.getMasterPages().push_back( pMasterPersistPtr );
FragmentHandlerRef xMasterFragmentHandler( new
SlideFragmentHandler( rFilter, aNotesFragmentPath, pMasterPersistPtr, Master )
);
rFilter.importFragment( xMasterFragmentHandler );
-//pMasterPersistPtr-createBackground( rFilter );
-//pMasterPersistPtr-createXShapes( rFilter );
mpSlidePersistPtr-setMasterPersist( pMasterPersistPtr );
}
return this;
@@ -213,11 +210,11 @@
}
catch( uno::Exception )
{
-OSL_FAIL(
OString(OString(oox::ppt::SlideFragmentHandler::EndElement(),
-exception caught: ) +
+OSL_FAIL( OString(oox::ppt::SlideFragmentHandler::EndElement(),
+exception caught: +
OUStringToOString(
comphelper::anyToString( cppu::getCaughtException() ),
-RTL_TEXTENCODING_UTF8 )).getStr() );
+RTL_TEXTENCODING_UTF8 )).getStr());
}
}
diff --git a/oox/source/ppt/slidepersist.cxx b/oox/source/ppt/slidepersist.cxx
index 72cf294..277096c 100644
--- a/oox/source/ppt/slidepersist.cxx
+++ b/oox/source/ppt/slidepersist.cxx
@@ -56,15 +56,6 @@
, maNotesTextStylePtr( new oox::drawingml::TextListStyle )
, maOtherTextStylePtr( new oox::drawingml::TextListStyle )
{
-if ( pDefaultTextStyle )
-{
-/*
-maTitleTextStylePtr-apply( *pDefaultTextStyle.get() );
-maBodyTextStylePtr-apply( *pDefaultTextStyle.get() );
-maNotesTextStylePtr-apply( *pDefaultTextStyle.get() );
-
[Libreoffice-commits] .: svx/source
svx/source/tbxctrls/tbunosearchcontrollers.cxx |8
1 file changed, 4 insertions(+), 4 deletions(-)
New commits:
commit 6da90944b5134d65bfbd7dcaf024956aa139efc1
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sun Jan 6 22:23:44 2013 +0100
ugly memory leak
Change-Id: I200713987eb1c19f7d795190e7acef02af569cc8
diff --git a/svx/source/tbxctrls/tbunosearchcontrollers.cxx
b/svx/source/tbxctrls/tbunosearchcontrollers.cxx
index c4bfc5c..91efdc3 100644
--- a/svx/source/tbxctrls/tbunosearchcontrollers.cxx
+++ b/svx/source/tbxctrls/tbunosearchcontrollers.cxx
@@ -767,25 +767,25 @@ void SAL_CALL FindbarDispatcher::removeStatusListener(
const css::uno::Reference
css::uno::Reference css::uno::XInterface SAL_CALL
FindTextToolbarController_createInstance(
const css::uno::Reference css::lang::XMultiServiceFactory rSMgr )
{
-return *new FindTextToolbarController( rSMgr );
+return FindTextToolbarController( rSMgr );
}
css::uno::Reference css::uno::XInterface SAL_CALL
DownSearchToolboxController_createInstance(
const css::uno::Reference css::lang::XMultiServiceFactory rSMgr )
{
-return *new UpDownSearchToolboxController( rSMgr,
UpDownSearchToolboxController::DOWN );
+return UpDownSearchToolboxController( rSMgr,
UpDownSearchToolboxController::DOWN );
}
css::uno::Reference css::uno::XInterface SAL_CALL
UpSearchToolboxController_createInstance(
const css::uno::Reference css::lang::XMultiServiceFactory rSMgr )
{
-return *new UpDownSearchToolboxController( rSMgr,
UpDownSearchToolboxController::UP );
+return UpDownSearchToolboxController( rSMgr,
UpDownSearchToolboxController::UP );
}
css::uno::Reference css::uno::XInterface SAL_CALL
FindbarDispatcher_createInstance(
const css::uno::Reference css::lang::XMultiServiceFactory rSMgr )
{
-return *new FindbarDispatcher( rSMgr );
+return FindbarDispatcher( rSMgr );
}
//---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-4-0' - 2 commits - compilerplugins/clang
compilerplugins/clang/bodynotinblock.cxx |1 + compilerplugins/clang/lclstaticfix.cxx|1 + compilerplugins/clang/plugin.cxx |1 - compilerplugins/clang/plugin.hxx |5 + compilerplugins/clang/postfixincrementfix.cxx |1 + compilerplugins/clang/sallogareas.cxx |1 + compilerplugins/clang/unusedvariablecheck.cxx |2 ++ 7 files changed, 11 insertions(+), 1 deletion(-) New commits: commit 038517a51649eb8bbe526303f536987c1207f122 Author: Stephan Bergmann sberg...@redhat.com Date: Wed Dec 5 17:33:47 2012 +0100 Adapt to current Clang trunk Change-Id: I0aadc7019934841d6864258695a17503918b6c20 diff --git a/compilerplugins/clang/unusedvariablecheck.cxx b/compilerplugins/clang/unusedvariablecheck.cxx index fa14b9c..759b9fa 100644 --- a/compilerplugins/clang/unusedvariablecheck.cxx +++ b/compilerplugins/clang/unusedvariablecheck.cxx @@ -11,6 +11,7 @@ #include unusedvariablecheck.hxx #include clang/AST/ASTContext.h +#include clang/AST/Attr.h #include clang/Basic/SourceManager.h namespace loplugin commit 6fbe72e5cd4993992c0a09e796372b804c896feb Author: Stephan Bergmann sberg...@redhat.com Date: Wed Dec 5 15:29:19 2012 +0100 Adapt to Clang 3.2 Change-Id: I9e51867198d7677c26cbd97f5d9c85ac13dc90c5 diff --git a/compilerplugins/clang/bodynotinblock.cxx b/compilerplugins/clang/bodynotinblock.cxx index 90f7933..a2e7968 100644 --- a/compilerplugins/clang/bodynotinblock.cxx +++ b/compilerplugins/clang/bodynotinblock.cxx @@ -10,6 +10,7 @@ #include bodynotinblock.hxx +#include clang/AST/ASTContext.h #include clang/Basic/SourceManager.h namespace loplugin diff --git a/compilerplugins/clang/lclstaticfix.cxx b/compilerplugins/clang/lclstaticfix.cxx index 849fea5..9227af8 100644 --- a/compilerplugins/clang/lclstaticfix.cxx +++ b/compilerplugins/clang/lclstaticfix.cxx @@ -10,6 +10,7 @@ #include lclstaticfix.hxx +#include clang/AST/ASTContext.h #include clang/Basic/SourceManager.h /* diff --git a/compilerplugins/clang/plugin.cxx b/compilerplugins/clang/plugin.cxx index 7ecf599..7138e88 100644 --- a/compilerplugins/clang/plugin.cxx +++ b/compilerplugins/clang/plugin.cxx @@ -16,7 +16,6 @@ #include clang/Frontend/CompilerInstance.h #include clang/Frontend/FrontendAction.h #include clang/Frontend/FrontendPluginRegistry.h -#include clang/Rewrite/Rewriter.h #include bodynotinblock.hxx #include lclstaticfix.hxx diff --git a/compilerplugins/clang/plugin.hxx b/compilerplugins/clang/plugin.hxx index b8a48fa..2a587ad 100644 --- a/compilerplugins/clang/plugin.hxx +++ b/compilerplugins/clang/plugin.hxx @@ -12,7 +12,12 @@ #define PLUGIN_H #include clang/AST/RecursiveASTVisitor.h + +#if __clang_major__ 3 || __clang_major__ == 3 __clang_minor__ 2 #include clang/Rewrite/Rewriter.h +#else +#include clang/Rewrite/Core/Rewriter.h +#endif using namespace clang; using namespace llvm; diff --git a/compilerplugins/clang/postfixincrementfix.cxx b/compilerplugins/clang/postfixincrementfix.cxx index ee63b8e..c5c17fb 100644 --- a/compilerplugins/clang/postfixincrementfix.cxx +++ b/compilerplugins/clang/postfixincrementfix.cxx @@ -10,6 +10,7 @@ #include postfixincrementfix.hxx +#include clang/AST/ASTContext.h #include clang/Basic/SourceManager.h namespace loplugin diff --git a/compilerplugins/clang/sallogareas.cxx b/compilerplugins/clang/sallogareas.cxx index 016e004..10630aa 100644 --- a/compilerplugins/clang/sallogareas.cxx +++ b/compilerplugins/clang/sallogareas.cxx @@ -10,6 +10,7 @@ #include sallogareas.hxx +#include clang/AST/ASTContext.h #include clang/Basic/SourceManager.h #include clang/Lex/Lexer.h diff --git a/compilerplugins/clang/unusedvariablecheck.cxx b/compilerplugins/clang/unusedvariablecheck.cxx index 7e3bb53..fa14b9c 100644 --- a/compilerplugins/clang/unusedvariablecheck.cxx +++ b/compilerplugins/clang/unusedvariablecheck.cxx @@ -10,6 +10,7 @@ #include unusedvariablecheck.hxx +#include clang/AST/ASTContext.h #include clang/Basic/SourceManager.h namespace loplugin ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: solenv/lldb
solenv/lldb/libreoffice/LO.py | 34 --
1 file changed, 28 insertions(+), 6 deletions(-)
New commits:
commit ad887fc3bf6237cfaf08e8f28a4f960b38e83365
Author: Tor Lillqvist t...@iki.fi
Date: Sun Jan 6 23:55:42 2013 +0200
Add lldb pretty-printers for UniStringData and String
Change-Id: I17c7a42d6e401f21f04440ee14616b07bfa0068e
diff --git a/solenv/lldb/libreoffice/LO.py b/solenv/lldb/libreoffice/LO.py
index 594af09..352bb31 100644
--- a/solenv/lldb/libreoffice/LO.py
+++ b/solenv/lldb/libreoffice/LO.py
@@ -29,14 +29,10 @@
# script sys.path[:0] =
[os.path.expanduser('~/lo/ios/solenv/lldb/libreoffice')]
# script import LO
-# type summary add --skip-references --python-function LO.rtl_uString_summary
rtl_uString
-# type summary add --skip-pointers --skip-references --python-function
LO.rtl_OUString_summary rtl::OUString
import lldb
def rtl_uString_summary(valobj, dict):
-e = lldb.SBError()
-
# print valobj = + str(valobj) + , valobj.GetData() = +
str(valobj.GetData()) + , valobj.GetTypeName() = + str(valobj.GetTypeName())
# As we don't use --skip-pointers when doing the type summary add for
this function,
@@ -49,6 +45,28 @@ def rtl_uString_summary(valobj, dict):
buffer_ptr = buffer.AddressOf();
+return sal_unicode_string(buffer_ptr, length)
+
+def rtl_OUString_summary(valobj, dict):
+return rtl_uString_summary(valobj.GetChildMemberWithName('pData'), dict)
+
+def UniStringData_summary(valobj, dict):
+if valobj.TypeIsPointerType():
+return UniStringData_summary(valobj.Dereference(), dict)
+
+length = valobj.GetChildMemberWithName('mnLen').GetValueAsUnsigned(0)
+buffer = valobj.GetChildMemberWithName('maStr')
+
+buffer_ptr = buffer.AddressOf();
+
+return sal_unicode_string(buffer_ptr, length)
+
+def String_summary(valobj, dict):
+return UniStringData_summary(valobj.GetChildMemberWithName('mpData'), dict)
+
+def sal_unicode_string(buffer_ptr, length):
+e = lldb.SBError()
+
s = ''
i = 0
while i length:
@@ -74,7 +92,11 @@ def rtl_uString_summary(valobj, dict):
return s
-def rtl_OUString_summary(valobj, dict):
-return rtl_uString_summary(valobj.GetChildMemberWithName('pData'), dict)
+# Automatically install the above summary functions when this is loaded
+def __lldb_init_module(debugger, dict):
+debugger.HandleCommand(type summary add --skip-references
--python-function LO.rtl_uString_summary rtl_uString)
+debugger.HandleCommand(type summary add --skip-pointers --skip-references
--python-function LO.rtl_OUString_summary rtl::OUString)
+debugger.HandleCommand(type summary add --skip-references
--python-function LO.UniStringData_summary UniStringData)
+debugger.HandleCommand(type summary add --skip-pointers --skip-references
--python-function LO.String_summary String)
# vim:set shiftwidth=4 softtabstop=4 expandtab:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: solenv/lldb
solenv/lldb/libreoffice/LO.py |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
New commits:
commit 129e7572849852eb223f6b13bad48b727955af7e
Author: Tor Lillqvist t...@iki.fi
Date: Mon Jan 7 00:29:22 2013 +0200
Fix usage instructions now that we use __lldb_init_module
Change-Id: I3ba7009f6c44312afda6e3aaa78ca82dd6ece545
diff --git a/solenv/lldb/libreoffice/LO.py b/solenv/lldb/libreoffice/LO.py
index 352bb31..5978c34 100644
--- a/solenv/lldb/libreoffice/LO.py
+++ b/solenv/lldb/libreoffice/LO.py
@@ -26,9 +26,7 @@
# instead of those above.
# To use, add something like this to your ~/.lldbinit:
-
-# script sys.path[:0] =
[os.path.expanduser('~/lo/ios/solenv/lldb/libreoffice')]
-# script import LO
+# command script import '~/lo/sim/solenv/lldb/libreoffice/LO.py'
import lldb
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sc/source
sc/source/filter/xml/xmlwrap.cxx |4 ++--
sc/source/ui/docshell/docsh.cxx |2 +-
sc/source/ui/docshell/docsh8.cxx |4 ++--
sc/source/ui/unoobj/scdetect.cxx |2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
New commits:
commit e48d47469508dee55ae6abcb3988222b5612e1e9
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sun Jan 6 23:34:38 2013 +0100
fix some memory leaks in sc
Change-Id: I1e3b9a55561f941346cb9f553f960dc2bafbb1b6
diff --git a/sc/source/filter/xml/xmlwrap.cxx b/sc/source/filter/xml/xmlwrap.cxx
index 5913788..439e5e6 100644
--- a/sc/source/filter/xml/xmlwrap.cxx
+++ b/sc/source/filter/xml/xmlwrap.cxx
@@ -219,7 +219,7 @@ sal_uInt32
ScXMLImportWrapper::ImportFromComponent(uno::Referencelang::XMultiSe
if( !sDocName.isEmpty() )
{
-nReturn = *new TwoStringErrorInfo(
+nReturn = TwoStringErrorInfo(
(bMustBeSuccessfull ? SCERR_IMPORT_FILE_ROWCOL
:
SCWARN_IMPORT_FILE_ROWCOL),
sDocName, sErr,
@@ -228,7 +228,7 @@ sal_uInt32
ScXMLImportWrapper::ImportFromComponent(uno::Referencelang::XMultiSe
else
{
OSL_ENSURE( bMustBeSuccessfull, Warnings are not supported );
-nReturn = *new StringErrorInfo( SCERR_IMPORT_FORMAT_ROWCOL,
sErr,
+nReturn = StringErrorInfo( SCERR_IMPORT_FORMAT_ROWCOL, sErr,
ERRCODE_BUTTON_OK | ERRCODE_MSG_ERROR );
}
}
diff --git a/sc/source/ui/docshell/docsh.cxx b/sc/source/ui/docshell/docsh.cxx
index f910070..37e5e64 100644
--- a/sc/source/ui/docshell/docsh.cxx
+++ b/sc/source/ui/docshell/docsh.cxx
@@ -2293,7 +2293,7 @@ sal_Bool ScDocShell::ConvertTo( SfxMedium rMed )
aImExport.SetStreamPath( rMed.GetName() );
bRet = aImExport.ExportStream( *pStream, rMed.GetBaseURL( true ),
SOT_FORMATSTR_ID_HTML );
if ( bRet aImExport.GetNonConvertibleChars().Len() )
-SetError( *new StringErrorInfo(
+SetError( StringErrorInfo(
SCWARN_EXPORT_NONCONVERTIBLE_CHARS,
aImExport.GetNonConvertibleChars(),
ERRCODE_BUTTON_OK | ERRCODE_MSG_INFO ), ::rtl::OUString(
RTL_CONSTASCII_USTRINGPARAM( OSL_LOG_PREFIX ) ) );
diff --git a/sc/source/ui/docshell/docsh8.cxx b/sc/source/ui/docshell/docsh8.cxx
index 2bfbcb0..af33ea2 100644
--- a/sc/source/ui/docshell/docsh8.cxx
+++ b/sc/source/ui/docshell/docsh8.cxx
@@ -1156,12 +1156,12 @@ sal_uLong ScDocShell::DBaseExport( const rtl::OUString
rFullFileName, CharSet e
}
String sPosition( ScAddress( nDocCol, nDocRow,
nTab).GetColRowString());
String sEncoding( SvxTextEncodingTable().GetTextString( eCharSet));
-nErr = *new TwoStringErrorInfo( (bEncErr ? SCERR_EXPORT_ENCODING :
+nErr = TwoStringErrorInfo( (bEncErr ? SCERR_EXPORT_ENCODING :
SCERR_EXPORT_FIELDWIDTH), sPosition, sEncoding,
ERRCODE_BUTTON_OK | ERRCODE_MSG_ERROR);
}
else if ( !aException.Message.isEmpty() )
-nErr = *new StringErrorInfo( (SCERR_EXPORT_SQLEXCEPTION),
aException.Message, ERRCODE_BUTTON_OK | ERRCODE_MSG_ERROR);
+nErr = StringErrorInfo( (SCERR_EXPORT_SQLEXCEPTION),
aException.Message, ERRCODE_BUTTON_OK | ERRCODE_MSG_ERROR);
else
nErr = SCERR_EXPORT_DATA;
}
diff --git a/sc/source/ui/unoobj/scdetect.cxx b/sc/source/ui/unoobj/scdetect.cxx
index c9d892f..9ef418e 100644
--- a/sc/source/ui/unoobj/scdetect.cxx
+++ b/sc/source/ui/unoobj/scdetect.cxx
@@ -930,7 +930,7 @@ OUString ScFilterDetect::impl_getStaticImplementationName()
/* Helper for registry */
UNOREFERENCE UNOXINTERFACE SAL_CALL ScFilterDetect::impl_createInstance(
const UNOREFERENCE UNOXMULTISERVICEFACTORY xServiceManager ) throw(
UNOEXCEPTION )
{
-return UNOREFERENCE UNOXINTERFACE ( *new ScFilterDetect( xServiceManager
) );
+return UNOREFERENCE UNOXINTERFACE ( ScFilterDetect( xServiceManager ) );
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 3 commits - ios/CustomTarget_Viewer_app.mk ios/experimental sfx2/source toolkit/source
ios/CustomTarget_Viewer_app.mk |4 ++
ios/experimental/Viewer/Viewer/lo-viewer.mm | 44 ++--
sfx2/source/appl/appdata.cxx|2 +
sfx2/source/appl/appinit.cxx|5 ++-
sfx2/source/appl/appquit.cxx|4 ++
sfx2/source/inc/appdata.hxx |4 ++
toolkit/source/awt/vclxtoolkit.cxx |7
7 files changed, 60 insertions(+), 10 deletions(-)
New commits:
commit 32e927952cff4f715eceb861a3c4c8ab088be405
Author: Tor Lillqvist t...@iki.fi
Date: Mon Jan 7 00:42:06 2013 +0200
Add a sample document to the test app bundle and try to load it
Change-Id: Id0f13351108cbcd748f3c403fe7a6716145f1892
diff --git a/ios/CustomTarget_Viewer_app.mk b/ios/CustomTarget_Viewer_app.mk
index 9af7a49..8c05728 100644
--- a/ios/CustomTarget_Viewer_app.mk
+++ b/ios/CustomTarget_Viewer_app.mk
@@ -127,6 +127,10 @@ $(SCRIPT_OUTPUT_FILE_0) : $(call
gb_Executable_get_target,Viewer)
echo 'ProductMajor=360' \
echo 'ProductMinor=1' \
: ) $(appdir)/program/versionrc
+#
+# Copy a sample document... good old test1.odt...
+#
+ cp $(SRC_ROOT)/odk/examples/java/DocumentHandling/test/test1.odt
$(appdir)
else
# When run just from the command line, we don't have any app bundle to
diff --git a/ios/experimental/Viewer/Viewer/lo-viewer.mm
b/ios/experimental/Viewer/Viewer/lo-viewer.mm
index 616f136..10c3156 100644
--- a/ios/experimental/Viewer/Viewer/lo-viewer.mm
+++ b/ios/experimental/Viewer/Viewer/lo-viewer.mm
@@ -18,12 +18,17 @@
#include osl/detail/ios-bootstrap.h
#include osl/process.h
+#include com/sun/star/awt/XDevice.hpp
+#include com/sun/star/awt/XToolkitExperimental.hpp
+#include com/sun/star/beans/PropertyValue.hpp
#include com/sun/star/beans/XPropertySet.hpp
#include com/sun/star/bridge/XUnoUrlResolver.hpp
#include com/sun/star/frame/XComponentLoader.hpp
#include com/sun/star/lang/XMultiComponentFactory.hpp
#include com/sun/star/lang/XMultiServiceFactory.hpp
#include com/sun/star/registry/XSimpleRegistry.hpp
+#include com/sun/star/uno/XComponentContext.hpp
+#include com/sun/star/view/XRenderable.hpp
#include vcl/svapp.hxx
@@ -32,6 +37,8 @@ using namespace com::sun::star;
using ::rtl::OUString;
using ::rtl::OUStringToOString;
+#define SMALLSIZE 100
+
extern C {
extern void * animcore_component_getFactory( const char * pImplName, void
* pServiceManager, void * pRegistryKey );
extern void * avmedia_component_getFactory( const char * pImplName, void *
pServiceManager, void * pRegistryKey );
@@ -165,6 +172,9 @@ lo_initialize(void)
try {
+// Should start a background thread to do all this UNO
+// initialisation crap
+
uno::Reference uno::XComponentContext
xContext(::cppu::defaultBootstrap_InitialComponentContext());
uno::Reference lang::XMultiComponentFactory xFactory(
xContext-getServiceManager() );
@@ -175,9 +185,37 @@ lo_initialize(void)
InitVCL();
-uno::Reference uno::XInterface xInterface =
-xFactory-createInstanceWithContext( com.sun.star.frame.Desktop,
- xContext );
+// Yes, this code does of course not belong here. Once this
+// turns into something that actually displays something and
+// has a proper app lifecycle etc that willl be fixed. But for
+// now this is just a test, not supposed to work in any sane
+// way from a user POV, and it doesn't matter that we do
+// this here.
+
+uno::Reference uno::XInterface xDesktop =
+xFactory-createInstanceWithContext( com.sun.star.frame.Desktop,
xContext );
+uno::Reference frame::XComponentLoader xComponentLoader( xDesktop,
uno::UNO_QUERY_THROW );
+
+uno::Reference uno::XInterface xToolkitService =
+xFactory-createInstanceWithContext( com.sun.star.awt.Toolkit,
xContext );
+
+uno::Reference awt::XToolkitExperimental xToolkit( xToolkitService,
uno::UNO_QUERY_THROW );
+
+char *smallbb = new char[ SMALLSIZE*SMALLSIZE*4 ];
+
+uno::Reference awt::XDevice xDummyDevice =
xToolkit-createScreenCompatibleDeviceUsingBuffer( SMALLSIZE, SMALLSIZE, 1, 1,
0, 0, (sal_Int64) (intptr_t) smallbb);
+
+uno::Sequence beans::PropertyValue loadProps(3);
+
+loadProps[0].Name = Hidden;
+loadProps[0].Value = sal_True;
+loadProps[1].Name = ReadOnly;
+loadProps[1].Value = sal_True;
+loadProps[2].Name = Preview;
+loadProps[2].Value = sal_True;
+
+OUString test1_odt( OUString( file:// ) + OUString::createFromAscii(
[[app_root_escaped stringByAppendingPathComponent: @test1.odt] UTF8String] ));
+uno::Reference lang::XComponent xDoc =
xComponentLoader-loadComponentFromURL ( test1_odt, _blank, 0, loadProps );
}
catch ( uno::Exception e ) {
SAL_WARN(Viewer,
[Libreoffice-commits] .: sd/source
sd/source/filter/xml/sdxmlwrp.cxx |4 ++--
sd/source/ui/controller/slidelayoutcontroller.cxx |4 ++--
sd/source/ui/toolpanel/ToolPanelFactory.cxx |2 +-
sd/source/ui/unoidl/sddetect.cxx |2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
New commits:
commit 5ea7e74c29f7279b6c31d38185ace576f68f4fb2
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sun Jan 6 23:42:55 2013 +0100
fix some memory leaks in sd
Change-Id: I7c7d0772a3d10601c6d1a9ea22c697abe762036d
diff --git a/sd/source/filter/xml/sdxmlwrp.cxx
b/sd/source/filter/xml/sdxmlwrp.cxx
index 4020a62..285af43 100644
--- a/sd/source/filter/xml/sdxmlwrp.cxx
+++ b/sd/source/filter/xml/sdxmlwrp.cxx
@@ -282,7 +282,7 @@ sal_Int32 ReadThroughComponent(
if( rStreamName.Len() )
{
-return *new TwoStringErrorInfo(
+return TwoStringErrorInfo(
(bMustBeSuccessfull ? ERR_FORMAT_FILE_ROWCOL
: WARN_FORMAT_FILE_ROWCOL),
rStreamName, sErr,
@@ -291,7 +291,7 @@ sal_Int32 ReadThroughComponent(
else
{
DBG_ASSERT( bMustBeSuccessfull, Warnings are not supported );
-return *new StringErrorInfo( ERR_FORMAT_ROWCOL, sErr,
+return StringErrorInfo( ERR_FORMAT_ROWCOL, sErr,
ERRCODE_BUTTON_OK | ERRCODE_MSG_ERROR );
}
}
diff --git a/sd/source/ui/controller/slidelayoutcontroller.cxx
b/sd/source/ui/controller/slidelayoutcontroller.cxx
index bdea29a..5cce3a4 100644
--- a/sd/source/ui/controller/slidelayoutcontroller.cxx
+++ b/sd/source/ui/controller/slidelayoutcontroller.cxx
@@ -331,7 +331,7 @@ Sequence OUString
SlideLayoutController_getSupportedServiceNames() throw( Ru
Reference XInterface SAL_CALL SlideLayoutController_createInstance( const
Reference XMultiServiceFactory rSMgr ) throw( RuntimeException )
{
-return *new SlideLayoutController( rSMgr, .uno:AssignLayout, false );
+return SlideLayoutController( rSMgr, .uno:AssignLayout, false );
}
//
@@ -354,7 +354,7 @@ Sequence OUString
InsertSlideController_getSupportedServiceNames() throw( Ru
Reference XInterface SAL_CALL InsertSlideController_createInstance( const
Reference XMultiServiceFactory rSMgr ) throw( RuntimeException )
{
-return *new SlideLayoutController( rSMgr, .uno:InsertPage , true );
+return SlideLayoutController( rSMgr, .uno:InsertPage , true );
}
//
diff --git a/sd/source/ui/toolpanel/ToolPanelFactory.cxx
b/sd/source/ui/toolpanel/ToolPanelFactory.cxx
index e725293..2fc4d69 100644
--- a/sd/source/ui/toolpanel/ToolPanelFactory.cxx
+++ b/sd/source/ui/toolpanel/ToolPanelFactory.cxx
@@ -101,7 +101,7 @@ namespace sd { namespace toolpanel
//--
Reference XInterface SAL_CALL ToolPanelFactory_createInstance( const
Reference XComponentContext i_rContext )
{
-return Reference XInterface ( *new ToolPanelFactory( i_rContext ) );
+return Reference XInterface ( ToolPanelFactory( i_rContext ) );
}
//--
diff --git a/sd/source/ui/unoidl/sddetect.cxx b/sd/source/ui/unoidl/sddetect.cxx
index 0431e6e..8a8bb94 100644
--- a/sd/source/ui/unoidl/sddetect.cxx
+++ b/sd/source/ui/unoidl/sddetect.cxx
@@ -515,7 +515,7 @@ rtl::OUString
SdFilterDetect::impl_getStaticImplementationName()
/* Helper for registry */
UNOREFERENCE UNOXINTERFACE SAL_CALL SdFilterDetect::impl_createInstance(
const UNOREFERENCE UNOXMULTISERVICEFACTORY xServiceManager ) throw(
UNOEXCEPTION )
{
-return UNOREFERENCE UNOXINTERFACE ( *new SdFilterDetect( xServiceManager
) );
+return UNOREFERENCE UNOXINTERFACE ( SdFilterDetect( xServiceManager ) );
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PATCH] add close option to findbar in Writer
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/1557
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/57/1557/1
add close option to findbar in Writer
Change-Id: Ie42da7ecc7f3cb59bb6f1fb798e72a6862eb1f67
---
M dictionaries
A icon-themes/galaxy/cmd/lc_exitsearch.png
M officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu
M officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
M svx/inc/tbunosearchcontrollers.hxx
M svx/source/tbxctrls/tbunosearchcontrollers.cxx
M svx/source/unodraw/unoctabl.cxx
M svx/util/svx.component
M sw/uiconfig/swriter/toolbar/findbar.xml
9 files changed, 195 insertions(+), 2 deletions(-)
diff --git a/dictionaries b/dictionaries
index a844895..f0c914a 16
--- a/dictionaries
+++ b/dictionaries
-Subproject commit a84489515d2207b1c34646be7d6f532b84a37439
+Subproject commit f0c914a43e7e6540300da25c935a77aebb672094
diff --git a/icon-themes/galaxy/cmd/lc_exitsearch.png
b/icon-themes/galaxy/cmd/lc_exitsearch.png
new file mode 100644
index 000..18958f3
--- /dev/null
+++ b/icon-themes/galaxy/cmd/lc_exitsearch.png
Binary files differ
diff --git a/officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu
b/officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu
index a60dd09..fe27c05 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu
@@ -396,6 +396,17 @@
valuecom.sun.star.svx.DownSearchToolboxController/value
/prop
/node
+ node oor:name=com.sun.star.svx.ExitFindbarToolboxController
oor:op=replace
+prop oor:name=Command
+ value.uno:ExitSearch/value
+/prop
+prop oor:name=Module
+ value/
+/prop
+prop oor:name=Controller
+ valuecom.sun.star.svx.ExitFindbarToolboxController/value
+/prop
+ /node
node oor:name=com.sun.star.svx.UpSearchToolboxController
oor:op=replace
prop oor:name=Command
value.uno:UpSearch/value
diff --git
a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
index 42188b6..bbdf997 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
@@ -1471,6 +1471,14 @@
value1/value
/prop
/node
+node oor:name=.uno:ExitSearch oor:op=replace
+prop oor:name=Label oor:type=xs:string
+value xml:lang=en-USExit Search/value
+/prop
+prop oor:name=Properties oor:type=xs:int
+value1/value
+/prop
+/node
node oor:name=vnd.sun.star.findbar:FocusToFindbar
oor:op=replace
prop oor:name=Label oor:type=xs:string
value xml:lang=en-US~Find.../value
diff --git a/svx/inc/tbunosearchcontrollers.hxx
b/svx/inc/tbunosearchcontrollers.hxx
index 47a1d00..87f9756 100644
--- a/svx/inc/tbunosearchcontrollers.hxx
+++ b/svx/inc/tbunosearchcontrollers.hxx
@@ -135,6 +135,48 @@
};
+class ExitSearchToolboxController : public svt::ToolboxController,
+ public css::lang::XServiceInfo
+{
+public:
+enum Type { EXIT };
+
+ExitSearchToolboxController( const css::uno::Reference
css::lang::XMultiServiceFactory rServiceManager, Type eType );
+~ExitSearchToolboxController();
+
+// XInterface
+virtual ::com::sun::star::uno::Any SAL_CALL queryInterface( const
css::uno::Type aType ) throw ( css::uno::RuntimeException );
+virtual void SAL_CALL acquire() throw ();
+virtual void SAL_CALL release() throw ();
+
+// XServiceInfo
+virtual ::rtl::OUString SAL_CALL getImplementationName() throw(
css::uno::RuntimeException );
+virtual sal_Bool SAL_CALL supportsService( const ::rtl::OUString
ServiceName ) throw( css::uno::RuntimeException );
+virtual css::uno::Sequence ::rtl::OUString SAL_CALL
getSupportedServiceNames() throw( css::uno::RuntimeException );
+
+static ::rtl::OUString getImplementationName_Static( ) throw()
+{
+return ::rtl::OUString(
com.sun.star.svx.ExitFindbarToolboxController );
+}
+
+static css::uno::Sequence ::rtl::OUString
getSupportedServiceNames_Static() throw();
+
+// XComponent
+virtual void SAL_CALL dispose() throw ( css::uno::RuntimeException );
+
+// XInitialization
+virtual void SAL_CALL initialize( const css::uno::Sequence css::uno::Any
aArguments ) throw ( css::uno::Exception, css::uno::RuntimeException);
+
+// XToolbarController
+virtual void SAL_CALL execute( sal_Int16 KeyModifier ) throw (
css::uno::RuntimeException );
+
+// XStatusListener
+virtual void SAL_CALL statusChanged( const
[Libreoffice-commits] .: solenv/gbuild
solenv/gbuild/platform/android.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c441a51fd04a81020529b5f2bdaab72c9b332143 Author: Tor Lillqvist t...@iki.fi Date: Mon Jan 7 01:45:54 2013 +0200 mkdir before touching Change-Id: I262d479e0db7197e9afc7d8e9002862ae4f82a01 diff --git a/solenv/gbuild/platform/android.mk b/solenv/gbuild/platform/android.mk index 690b886..1f4bf81 100644 --- a/solenv/gbuild/platform/android.mk +++ b/solenv/gbuild/platform/android.mk @@ -113,7 +113,7 @@ gb_CppunitTest_EXT := .a define gb_LinkTarget__command $(call gb_Output_announce,$(2),$(true),LNK,4) $(if $(filter CppunitTest,$(TARGETTYPE)), \ - touch $(1), \ + mkdir -p $(dir $(1)) touch $(1), \ $(call gb_LinkTarget__command_staticlink,$(1))) endef ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PATCH] remove some ::rtl:: prefixes
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/1558
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/58/1558/1
remove some ::rtl:: prefixes
Change-Id: Ia31f1b5ae3c940861d72598aff54be85e2ad33dd
---
M accessibility/inc/accessibility/extended/textwindowaccessibility.hxx
M accessibility/source/extended/textwindowaccessibility.cxx
M avmedia/source/quicktime/framegrabber.mm
M avmedia/source/quicktime/manager.mm
M avmedia/source/quicktime/player.mm
M avmedia/source/quicktime/quicktimeuno.mm
M avmedia/source/quicktime/window.mm
M avmedia/source/viewer/mediawindowbase_impl.cxx
M basctl/source/basicide/unomodel.cxx
M basctl/source/basicide/unomodel.hxx
M basegfx/test/basegfx2d.cxx
M bridges/source/jni_uno/jni_base.h
M bridges/source/jni_uno/jni_info.h
M bridges/test/testcomp.cxx
M bridges/test/testcomp.h
M canvas/source/cairo/cairo_canvashelper.cxx
M canvas/source/directx/dx_9rm.cxx
17 files changed, 130 insertions(+), 130 deletions(-)
diff --git
a/accessibility/inc/accessibility/extended/textwindowaccessibility.hxx
b/accessibility/inc/accessibility/extended/textwindowaccessibility.hxx
index 6d8db68..02c5571 100644
--- a/accessibility/inc/accessibility/extended/textwindowaccessibility.hxx
+++ b/accessibility/inc/accessibility/extended/textwindowaccessibility.hxx
@@ -141,7 +141,7 @@
public ParagraphBase, private ::comphelper::OCommonAccessibleText
{
public:
-ParagraphImpl(::rtl::Reference Document const rDocument,
+ParagraphImpl(Reference Document const rDocument,
Paragraphs::size_type nNumber, ::osl::Mutex rMutex);
// Not thread-safe.
@@ -372,7 +372,7 @@
// Throws ::css::lang::DisposedException:
void checkDisposed();
-::rtl::Reference Document m_xDocument;
+Reference Document m_xDocument;
Paragraphs::size_type m_nNumber;
//::cppu::OInterfaceContainerHelper m_aListeners;
@@ -404,21 +404,21 @@
// To make it possible for this method to be (indirectly) called from
// within Paragraph's constructor (i.e., when the Paragraph's ref count is
// still zero), pass a ParagraphImpl const * instead of a
-// ::rtl::Reference ParagraphImpl const .
+// Reference ParagraphImpl const .
::sal_Int32 retrieveParagraphIndex(ParagraphImpl const * pParagraph);
// Must be called only after init has been called.
// To make it possible for this method to be (indirectly) called from
// within Paragraph's constructor (i.e., when the Paragraph's ref count is
// still zero), pass a ParagraphImpl const * instead of a
-// ::rtl::Reference ParagraphImpl const .
+// Reference ParagraphImpl const .
::sal_Int64 retrieveParagraphState(ParagraphImpl const * pParagraph);
// Must be called only after init has been called.
// To make it possible for this method to be (indirectly) called from
// within Paragraph's constructor (i.e., when the Paragraph's ref count is
// still zero), pass a ParagraphImpl const instead of a
-// ::rtl::Reference ParagraphImpl const .
+// Reference ParagraphImpl const .
::css::awt::Rectangle
retrieveParagraphBounds(ParagraphImpl const * pParagraph, bool bAbsolute);
@@ -426,14 +426,14 @@
// To make it possible for this method to be (indirectly) called from
// within Paragraph's constructor (i.e., when the Paragraph's ref count is
// still zero), pass a ParagraphImpl const instead of a
-// ::rtl::Reference ParagraphImpl const .
+// Reference ParagraphImpl const .
OUString retrieveParagraphText(ParagraphImpl const * pParagraph);
// Must be called only after init has been called.
// To make it possible for this method to be (indirectly) called from
// within Paragraph's constructor (i.e., when the Paragraph's ref count is
// still zero), pass a ParagraphImpl const instead of a
-// ::rtl::Reference ParagraphImpl const .
+// Reference ParagraphImpl const .
void retrieveParagraphSelection(ParagraphImpl const * pParagraph,
::sal_Int32 * pBegin, ::sal_Int32 * pEnd);
@@ -441,14 +441,14 @@
// To make it possible for this method to be (indirectly) called from
// within Paragraph's constructor (i.e., when the Paragraph's ref count is
// still zero), pass a ParagraphImpl const * instead of a
-// ::rtl::Reference ParagraphImpl const .
+// Reference ParagraphImpl const .
::sal_Int32 retrieveParagraphCaretPosition(ParagraphImpl const *
pParagraph);
// Must be called only after init has been called.
// To make it possible for this method to be (indirectly) called from
// within Paragraph's constructor (i.e., when the Paragraph's ref count is
// still zero), pass a ParagraphImpl const instead of a
-// ::rtl::Reference ParagraphImpl const .
+// Reference ParagraphImpl const .
// Throws
Re: [PATCH] add close option to findbar in Writer
Well done! But why only in Writer? This is also badly needed in the other modules/programs... In fact it would be great if the hotkey for Find (Ctrl+F) would work as a toggle function (as it does for Find Replace). Should I add a feature request for this? Regards, Pedro -- View this message in context: http://nabble.documentfoundation.org/PATCH-add-close-option-to-findbar-in-Writer-tp4027530p4027535.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] add close option to findbar in Writer
Op 07-01-13 01:47, Pedro schreef: Well done! But why only in Writer? This is also badly needed in the other modules/programs... I would like to review it by an experienced developer first. If my commit passed, I'll integrate it on other components as well. In fact it would be great if the hotkey for Find (Ctrl+F) would work as a toggle function (as it does for Find Replace). Should I add a feature request for this? I'll look at that. To be sure I don't forget it, can you please add new feature request and assign it to me? Kind regards, Joren ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sd/source
sd/source/ui/toolpanel/ToolPanelFactory.cxx |1 -
1 file changed, 1 deletion(-)
New commits:
commit 504b6f0cec5cad01a64e723434d636bfb867ecfa
Author: Tor Lillqvist t...@iki.fi
Date: Mon Jan 7 07:05:57 2013 +0200
Clang doesn't like that ToolPanelFactory::~ToolPanelFactory() is protected
Change-Id: If7ab2dade60f5de62cfbea6d1d021a30e8a60f57
diff --git a/sd/source/ui/toolpanel/ToolPanelFactory.cxx
b/sd/source/ui/toolpanel/ToolPanelFactory.cxx
index 2fc4d69..5989ad0 100644
--- a/sd/source/ui/toolpanel/ToolPanelFactory.cxx
+++ b/sd/source/ui/toolpanel/ToolPanelFactory.cxx
@@ -91,7 +91,6 @@ namespace sd { namespace toolpanel
// XInitialization
virtual void SAL_CALL initialize( const Sequence Any aArguments )
throw (Exception, RuntimeException);
-protected:
virtual ~ToolPanelFactory();
private:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [Libreoffice-qa] French Bug
Hi, Le 06/01/2013 08:39, Rainer Bielefeld a écrit : Rob Snelders schrieb: Maybe it's good to add that to the wiki: Hi Rob, On Rapporter un problème sous LibreOffice https://wiki.documentfoundation.org/BugReport/fr we already have the recommendation to ask for assistance at us...@fr.libreoffice.org. I think requests to q...@fr.libreoffice.org should be reserved to qa team, because subscription is required (?) All FR lists require subscription, even users@fr ML, but in case of a message is sent to a FR list by a not-subscriber, I receive it as moderator and I publish it if it is not spam. and I believe it might cause too much traffic on that list if every users asks for help there. I will do so in future if I can't understand a report written in French language. I agree. Do not hesitate to add me as CC to a bug report in French language if you think I can help. Best regrads. JBF -- Seuls des formats ouverts peuvent assurer la pérennité de vos documents. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 58731] : unable to modify formula
https://bugs.freedesktop.org/show_bug.cgi?id=58731 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID CC||LibreOffice@bielefeldundbus ||s.de --- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- I'm not able? That does not sound like a LibO Bug @reporter: Thank you for your feedback! Unfortunately you are wrong here, this is the Bug tracking system, not a helpdesk! You can get assistance on http://ask.libreoffice.org/questions/ or on the public users mailing list us...@libreoffice.org, a mailing list from http://www.documentfoundation.org/contribution/#lists or http://wiki.documentfoundation.org/Local_Mailing_Lists Please feel free to reopen this Bug if discussion with other users leaded to an assessment that we have a LibO bug and a clear and comprehensible description of the problem due to http://wiki.documentfoundation.org/BugReport. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58728] undefined: browser plugin doesn't work
https://bugs.freedesktop.org/show_bug.cgi?id=58728 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID CC||LibreOffice@bielefeldundbus ||s.de --- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- @reporter: Thank you for your feedback! Unfortunately you are wrong here, this is the Bug tracking system, not a helpdesk! You can get assistance on http://ask.libreoffice.org/questions/ or on the public users mailing list us...@libreoffice.org, a mailing list from http://www.documentfoundation.org/contribution/#lists or http://wiki.documentfoundation.org/Local_Mailing_Lists Please feel free to reopen this Bug if discussion with other users leaded to an assessment that we have a LibO bug and a clear and comprehensible description of the problem due to http://wiki.documentfoundation.org/BugReport. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59064] undefined: how can I choose 'calc' in the components ??
https://bugs.freedesktop.org/show_bug.cgi?id=59064 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID CC||LibreOffice@bielefeldundbus ||s.de --- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- @reporter: Please do not submit any more reports here before you understood how this here works. For your problems please ask for help as I told you in bug 58731 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46440] SIGSEGV in Application::IsInMain()
https://bugs.freedesktop.org/show_bug.cgi?id=46440 --- Comment #6 from Christopher M. Penalver christopher.m.penal...@gmail.com --- Reproducible in: lsb_release -rd Description:Ubuntu 12.10 Release:12.10 apt-cache policy libreoffice libreoffice: Installed: 1:3.6.2~rc2-0ubuntu4 Candidate: 1:3.6.2~rc2-0ubuntu4 Version table: *** 1:3.6.2~rc2-0ubuntu4 0 900 http://archive.ubuntu.com/ubuntu/ quantal-updates/universe i386 Packages 100 /var/lib/dpkg/status 1:3.6.2~rc2-0ubuntu3 0 500 http://archive.ubuntu.com/ubuntu/ quantal/universe i386 Packages apt-cache policy python python: Installed: 2.7.3-0ubuntu7 Candidate: 2.7.3-0ubuntu7 Version table: *** 2.7.3-0ubuntu7 0 500 http://archive.ubuntu.com/ubuntu/ quantal/main i386 Packages 100 /var/lib/dpkg/status -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58717] undefined: formula doesn't allow to write anything
https://bugs.freedesktop.org/show_bug.cgi?id=58717 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID CC||LibreOffice@bielefeldundbus ||s.de --- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- Sounds like a user error. @reporter: Please do not submit any more reports here before you have some more experience with LibO and before you understood how to use Bugzilla! For your problems please ask for help as I told you in bug 58731 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58757] undefined: writer doesn't allow to resize formulas
https://bugs.freedesktop.org/show_bug.cgi?id=58757 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID CC||LibreOffice@bielefeldundbus ||s.de --- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- User error. You have to modify font size! @reporter: Please do not submit any more reports here before you have some more experience with LibO and before you understood how to use Bugzilla! For your problems please ask for help as I told you in bug 58731 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58940] CONFIGURATION: Can not change paths used by LibreOffice
https://bugs.freedesktop.org/show_bug.cgi?id=58940 --- Comment #24 from Adam brucey...@live.com --- That's interesting that someone has the bug that's not on Linux Mint. I have tested the bug on my Ubuntu 12.10 installation and can confirm the bug does exist there. Remember Linux Mint 14 is based on Ubuntu 12.10. Users have said the bug does not exist on Linux Mint 13 (based on Ubuntu 12.04) and I also confirm the bug does not exist in Ubuntu 12.04. So looks like the issue is coming from Ubuntu 12.10 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46440] SIGSEGV in Application::IsInMain()
https://bugs.freedesktop.org/show_bug.cgi?id=46440 --- Comment #7 from Julien Nabet serval2...@yahoo.fr --- Bjoern/Christopher: ok I had missed 3.5 part last time and I see that it's reproduceable in 3.6 too. Sorry for the noise. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58299] VIEWING: Menu crash
https://bugs.freedesktop.org/show_bug.cgi?id=58299 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58807] No sound with statement beep
https://bugs.freedesktop.org/show_bug.cgi?id=58807
Rainer Bielefeld libreoff...@bielefeldundbuss.de changed:
What|Removed |Added
Whiteboard|BSA |bibisectrequest, BSA
CC||LibreOffice@bielefeldundbus
||s.de
Summary|BASIC: macro doesn't beep |No sound with statement
||beep
Version|4.0.0.0.beta1 |4.0.0.0.alpha0+ Master
Keywords||regression
--- Comment #6 from Rainer Bielefeld libreoff...@bielefeldundbuss.de ---
[Reproducible] with parallel installation of LOdev 4.0.0.0.beta2 - GERMAN
UI / German Locale [Build ID: 4104d660979c57e1160b5135634f732918460a0)]
{tinderbox: @6, pull time 2012-12-20} on German WIN7 Home Premium (64bit) with
separate /4 User Profile for Master Branch
Worked fine with 3.6.4, so regression
Already [Reproducible] with Server-installation of Master 3.7.0.alpha0+ –
ENGLISH UI [Build ID: f2e622] {tinderbox: Win-x86@16, pull time 2012-10-06
09:31:39} on German WIN7 Home Premium (64bit)
UserInstallation=$SYSUSERCONFIG/LOdev/3
No idea what tommy27's observation might mean, I agree that that might be
something different.
--
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58807] No sound with statement beep
https://bugs.freedesktop.org/show_bug.cgi?id=58807 --- Comment #7 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- Created attachment 72581 -- https://bugs.freedesktop.org/attachment.cgi?id=72581action=edit Sample Document with macro Simply click the button in the document for a test. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59062] Crash on connexion for e-mailing
https://bugs.freedesktop.org/show_bug.cgi?id=59062 Jean-Baptiste Faure jbf.fa...@sud-ouest.org changed: What|Removed |Added Attachment #72554|text/plain |application/zip mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58768] : cannot save clipart gallery
https://bugs.freedesktop.org/show_bug.cgi?id=58768 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||LibreOffice@bielefeldundbus ||s.de Ever confirmed|0 |1 --- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- I do not understand the problem. How from where what kind of cllipart pictures has been saved? Why does reporter think this problem is related to writer? @reporter: Thank you for your report – unfortunately important information is missing. May be hints on http://wiki.documentfoundation.org/BugReport will help you to find out what information will be useful to reproduce your problem? If you believe that that is really sophisticated please as for Help on a user mailing list Please: - Write a meaningful Summary describing exactly what the problem is - Attach a sample document (gallery picture file) not only screenshot) or refer to an existing sample document in an other Bug with a link; to attach a file to this bug report, just click on Add an attachment right on this page. - Attach screenshots with comments if you believe that that might explain the problem better than a text comment. Best way is to insert your screenshots into a DRAW document and to add comments that explain what you want to show (attachment 68877, attachment 68490) - Contribute a document related step by step instruction containing every key press and every mouse click how to reproduce your problem (similar to example in Bug 43431) – if possible contribute an instruction how to create a sample document from the scratch - add information -- what EXACTLY is unexpected -- and WHY do you believe it's unexpected (cite Help or Documentation!) -- concerning your PC -- concerning your OS (Version, Language) -- concerning your LibO version (with Build ID if it's not a public release) and localization (UI language, Locale setting) –- Libo settings that might be related to your problems -- how you launch LibO and how you opened the sample document / Writer document, / whatever –- Whether your problem persists when you renamed your user profile before you launch LibO (please see https://wiki.documentfoundation.org/UserProfile#User_profile_location) -- everything else crossing your mind after you read linked texts Even if you can not provide all demanded information, every little new information might bring the breakthrough. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59062] Crash on connexion for e-mailing
https://bugs.freedesktop.org/show_bug.cgi?id=59062
Jean-Baptiste Faure jbf.fa...@sud-ouest.org changed:
What|Removed |Added
CC||jbf.fa...@sud-ouest.org
--- Comment #2 from Jean-Baptiste Faure jbf.fa...@sud-ouest.org ---
No crash for me but an error message:
LibreOffice n'a pas pu se connecter au serveur de courrier sortant. Vérifiez
vos paramètres système et les paramètres de LibreOffice. Vérifiez le nom du
serveur, le port et les paramètres des connexions sécurisées
---
class 'AttributeError': 'bytes' object has no attribute 'encode', traceback
follows
/home/jbf/LibO/master/solver/unxlngx6.pro/installation/opt/program/python-core-3.3.0/lib/smtplib.py:623
in function login() [%s %s % (AUTH_LOGIN, encode_base64(user.encode('ascii'),
eol='')))]
/home/jbf/LibO/master/solver/unxlngx6.pro/installation/opt/program/mailmerge.py:107
in function connect() [self.server.login(user, password)]
Tested with Version 4.0.0.0.beta2+ (Build ID:
a31f703366b89abcb8cda1321163c596fc8e556) under Ubuntu 12.04 x86-64
Best regards. JBF
--
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58689] Countifs formula does not count blanks
https://bugs.freedesktop.org/show_bug.cgi?id=58689 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID --- Comment #7 from Cor Nouws c...@nouenoff.nl --- Hi crusader, Thanks for confirming the better way to do that job ;-) Resolving this issue then -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58689] Countifs formula does not count blanks
https://bugs.freedesktop.org/show_bug.cgi?id=58689 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added Status|RESOLVED|CLOSED --- Comment #8 from Cor Nouws c...@nouenoff.nl --- close -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59073] UI: Dialog menu 'Data - Sort - Sort Criteria' tab is empty
https://bugs.freedesktop.org/show_bug.cgi?id=59073
Rainer Bielefeld libreoff...@bielefeldundbuss.de changed:
What|Removed |Added
Status|UNCONFIRMED |NEEDINFO
CC||LibreOffice@bielefeldundbus
||s.de
Summary|FILTER: data sort |UI: Dialog menu 'Data -
|parameters: 1st tab is |Sort - Sort Criteria' tab
|empty |is empty
Ever confirmed|0 |1
--- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de ---
NOT reproducible with parallel installation of LOdev 4.0.0.0.beta2 -
GERMAN UI / German Locale [Build ID:
4104d660979c57e1160b5135634f732918460a0)] {tinderbox: @6, pull time
2012-12-20} on German WIN7 Home Premium (64bit) with separate /4 User Profile
for Master Branch
I do not understand the relation to Filter, in Report no Filter is
mentioned.
There is no Tab Parameters, but Sort Criteria; or do I misunderstand where
reporter has a problem?
@reporter:
Thank you for your report – unfortunately important information is missing.
May be hints on http://wiki.documentfoundation.org/BugReport will help you to
find out what information will be useful to reproduce your problem? If you
believe that that is really sophisticated please as for Help on a user mailing
list
Please:
- Write a meaningful Summary describing exactly what the problem is
- Use English UI for your tests
- Attach a sample document (not only screenshot) or refer to an existing
sample document in an other Bug with a link; to attach a file to this
bug report, just click on Add an attachment right on this page.
- Attach screenshots with comments if you believe that that might explain the
problem better than a text comment. Best way is to insert your screenshots
into a DRAW document and to add comments that explain what you want to show
(attachment 68877, attachment 68490)
- add information
-- what EXACTLY is unexpected (only grey background, no contents at all ...
-- concerning your PC
-- concerning your OS (Version, Language)
-- concerning your LibO localization (UI language, Locale setting)
–- Libo settings that might be related to your problems
(video hardware acceleration, Experimental features enabled, ...)
-- how you launch LibO and how you opened the sample document
–- Whether your problem persists when you renamed your user profile
before you launch LibO (please see
https://wiki.documentfoundation.org/UserProfile#User_profile_location)
-- everything else crossing your mind after you read linked texts
Even if you can not provide all demanded information, every little new
information might bring the breakthrough.
--
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58832] undefined: firefox plugin upper toolbar
https://bugs.freedesktop.org/show_bug.cgi?id=58832 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||LibreOffice@bielefeldundbus ||s.de Ever confirmed|0 |1 --- Comment #2 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- @reporter What world famous browser plugin from what source do you use with what browser in what way? Please contribute information required to make your problem reproducible for ohter users as I told you in other reports. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59028] EDITING: default colours and line for 'rectangle' do not match those for 'basic shapes → rectangle'
https://bugs.freedesktop.org/show_bug.cgi?id=59028 Jean-Baptiste Faure jbf.fa...@sud-ouest.org changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||alexander.wi...@zoho.com, ||jbf.fa...@sud-ouest.org Ever confirmed|0 |1 --- Comment #2 from Jean-Baptiste Faure jbf.fa...@sud-ouest.org --- Indeed; reproducible with Version 4.0.0.0.beta2+ (Build ID: a31f703366b89abcb8cda1321163c596fc8e556) under Ubuntu 12.04 x86-64 It seems that this commit https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit;h=895890563cb0cc5fa872bdfd06918a46cdda172d did not the whole job. @Alexander: something for you ? Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57896] EDITING: duration for copy or deletion of 1 sheet depends on number of sheets with CONDITIONAL FORMATTING in document.
https://bugs.freedesktop.org/show_bug.cgi?id=57896 --- Comment #14 from Cor Nouws c...@nouenoff.nl --- (In reply to comment #13) Is it possible that the patch is use for 3.6.5? Would be great indeed. Should that need much testing on possible side effects, Markus? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58980] Bad font rendering for farsi
https://bugs.freedesktop.org/show_bug.cgi?id=58980 --- Comment #3 from Eman AMini eman.am...@gmail.com --- This is an old bug that apears again! Why? I don't know This bug only apears when the text is in justified mode. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59067] scale
https://bugs.freedesktop.org/show_bug.cgi?id=59067 --- Comment #2 from Frank Dieckmann libreoffice@gmx.info --- (In reply to comment #1) Not a valid bug report, any contents missing! Yes, for shure. It was an accident in using the bug reporting form. I'm so sorry! Kind regards! Frank -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58858] FILESAVE: can't save .xls test file as .ods after deleting cells
https://bugs.freedesktop.org/show_bug.cgi?id=58858 --- Comment #12 from vlb v...@xs4all.nl --- Created attachment 72583 -- https://bugs.freedesktop.org/attachment.cgi?id=72583action=edit New test file ods with 2 sheets I have the first test file bring it to 2 sheets, where i can reproduce the bug in LO Version 4.0.0.0.beta2+ (Build ID: afa240330b51fb3607cfa6390aeb4e085cd1c52): Steps reproduce 1: 1) open test file Issue-save-ligger.ods 2) Go to sheet NEN 3) delete cell F76 and save file 4) error message Steps reproduce 2: 1) open test file Issue-save-ligger.ods 2) Go to sheet NEN 3) save as file to a other name or the same name 4) error message Steps no reproduce 1: 1) open test file Issue-save-ligger.ods 2) stay in the sheet Profielen 3) delete cell A28 and save file 4) save is oke Steps no reproduce 2: 1) open test file Issue-save-ligger.ods 2) stay in the sheet Profielen 3) save as file to a other name or the same name 4) save is oke -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59062] Crash on connexion for e-mailing
https://bugs.freedesktop.org/show_bug.cgi?id=59062 --- Comment #3 from ribotb rib...@gmail.com --- Sorry, crash is not the appropriate term. Bernard Ribot -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59062] Failure on connexion for e-mailing
https://bugs.freedesktop.org/show_bug.cgi?id=59062 Jean-Baptiste Faure jbf.fa...@sud-ouest.org changed: What|Removed |Added Summary|Crash on connexion for |Failure on connexion for |e-mailing |e-mailing --- Comment #4 from Jean-Baptiste Faure jbf.fa...@sud-ouest.org --- (In reply to comment #3) Sorry, crash is not the appropriate term. Ok, changed the summary accordingly. Thank you. JBF -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59068] Scale, Formatting, wish
https://bugs.freedesktop.org/show_bug.cgi?id=59068 --- Comment #2 from Frank Dieckmann libreoffice@gmx.info --- (In reply to comment #1) Not a valid bug report, completely unintelligibly. What might be globally? That all (including comment on us...@de.libreoffice.org) seems th show that reporter did not understand all details of Scaling in Draw @Frank Dieckmann: Thank you for your feedback! Unfortunately you are wrong here, this is the Bug tracking system, not a helpdesk! Regina Henschel explained on us...@de.libreoffice.org how that works. You can have individual scaling for each Draw document, but not for each slide in a Draw document. I'm sorry that I wrote completely unintelligibly. I understood what Regina Henschel wrote. But what I would like to have is that I could have different scales in ONE document. With the expression 'globally' I meant that I could set the scale only for the hole document and not for different drawings or pages. Sorry 'bout my English! Frank -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59028] EDITING: default colours and line for 'rectangle' do not match those for 'basic shapes → rectangle'
https://bugs.freedesktop.org/show_bug.cgi?id=59028 --- Comment #3 from Fabian Alexander Wilms alexander.wi...@zoho.com --- I just tried to find the code where the color for primitive shapes are being defined, but couldn't find anything. Does anyone know where to look? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58994] editing database query in SQL view crashes Base
https://bugs.freedesktop.org/show_bug.cgi?id=58994 rob...@familiegrosskopf.de changed: What|Removed |Added CC||rob...@familiegrosskopf.de --- Comment #2 from rob...@familiegrosskopf.de --- Can't confirm this behavior with any LO-version I have installed under OpenSuSE 11.4 32bit rpm: LO 3.6.4.3, LO 3.3.4, LO 4.0.0.0beta2, LO 3.4.*, LO 3.5.* Must be a special Windows-problem or a special problem with the configuration (corrupted base-file, external database, java, corrupted user-directory). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59078] New: File hash doesn't match with installation file
https://bugs.freedesktop.org/show_bug.cgi?id=59078 Priority: medium Bug ID: 59078 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: File hash doesn't match with installation file Severity: critical Classification: Unclassified OS: Windows (All) Reporter: giumi...@hotmail.com Hardware: Other Status: UNCONFIRMED Version: unspecified Component: Libreoffice Product: LibreOffice The installation file: http://download.documentfoundation.org/libreoffice/stable/3.6.4/win/x86/LibO_3.6.4_Win_x86_install_multi.msi doesn't match with MD5: 94c2808ced90e8113be4153bd54179a8 SHA-1: 60178e13bd1824dce26ff9d1e106e92d545f2d15 SHA-256: 7cb76948f416f939d1b100ddc27e7a33b5506bdae04a167d62ea75d0482ae507 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59054] Form load event not firing (probably same cause as 42796)
https://bugs.freedesktop.org/show_bug.cgi?id=59054 rob...@familiegrosskopf.de changed: What|Removed |Added Status|NEW |NEEDINFO CC||rob...@familiegrosskopf.de --- Comment #2 from rob...@familiegrosskopf.de --- I have tried it with OpenSuSE 11.4, 32 bit rpm and LO 4.0.0.0beta2. Could not confirm this behavior. A pupup appears Change list size when opening the form. Who had confirmed this bug? I have only seen comments of Reto Diener. Set the status to Needinfo -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59079] New: PRINTING - Cannot print the original sheets when new sheets are inserted.
https://bugs.freedesktop.org/show_bug.cgi?id=59079 Priority: medium Bug ID: 59079 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: PRINTING - Cannot print the original sheets when new sheets are inserted. Severity: normal Classification: Unclassified OS: Windows (All) Reporter: 18nicebo...@gmail.com Hardware: x86-64 (AMD64) Status: UNCONFIRMED Version: 3.6.4.3 release Component: Spreadsheet Product: LibreOffice Created attachment 72585 -- https://bugs.freedesktop.org/attachment.cgi?id=72585action=edit 8 sheets spreadsheet with 1 newly added sheet. I have a spreadsheet with 7 sheets and works fine previously. Recently, I want to merge the 3 sheets of another spreadsheet into this spreadsheet. The editing of the new spreadsheet (i.e with totally 10 sheets) is fine. But when I want to preview / print the sheets, only those newly inserted sheets can be previewed/printed. The original sheets only shows blank in preview. When I removed those newly inserted sheets, the original 7 sheets resumed to normal (i.e. can be previewed and printed). The attached BOOKS.ODS is the problem spreadsheet. The last sheet named Testing Sheet is moved from another spreadsheet. Only it can be previewed and printed. When it was removed, all the original sheets can be previewed and printed again. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59075] : OUTLOOK
https://bugs.freedesktop.org/show_bug.cgi?id=59075 --- Comment #2 from Alberto alberto...@hotmail.com --- Thanks -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58587] Installation: setup displays English text with German component names
https://bugs.freedesktop.org/show_bug.cgi?id=58587 cle...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED CC||cle...@gmail.com --- Comment #2 from cle...@gmail.com --- Fixed in 4.0.0.0.beta2 - Setup is in German now Thank you! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59079] PRINTING - Cannot print the original sheets when new sheets are inserted.
https://bugs.freedesktop.org/show_bug.cgi?id=59079 Rob Snelders programm...@ertai.nl changed: What|Removed |Added Attachment #72585|0 |1 is obsolete|| --- Comment #1 from Rob Snelders programm...@ertai.nl --- Created attachment 72586 -- https://bugs.freedesktop.org/attachment.cgi?id=72586action=edit 8 sheets spreadsheet with 1 newly added sheet. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58588] Recovery of document after program crash fails if file was not saved before
https://bugs.freedesktop.org/show_bug.cgi?id=58588 cle...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME CC||cle...@gmail.com --- Comment #1 from cle...@gmail.com --- I can no longer reproduce this on 4.0.0.0.beta2 setting to WORKSFORME since I don't know if this was just me or if it was fixed in code, feel free to correct the status -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59079] PRINTING - Cannot print the original sheets when new sheets are inserted.
https://bugs.freedesktop.org/show_bug.cgi?id=59079 Rob Snelders programm...@ertai.nl changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #2 from Rob Snelders programm...@ertai.nl --- confirmed with 4.0-beta2 on Ubuntu 12.04 x86_64 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59054] Form load event not firing (probably same cause as 42796)
https://bugs.freedesktop.org/show_bug.cgi?id=59054 --- Comment #3 from Reto Diener reto_die...@bluewin.ch --- Precise: The popup must arise! I'm not astonished about the difference (again) between windows and linux. Seems to be some kind of systematic behind of that (see the discussion about the performance problems) best regards reto -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59080] New: Wrong spellingcheck [German]
https://bugs.freedesktop.org/show_bug.cgi?id=59080 Priority: low Bug ID: 59080 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Wrong spellingcheck [German] Severity: normal Classification: Unclassified OS: Linux (All) Reporter: jonas.scho...@dashtec.net Hardware: x86-64 (AMD64) Status: NEW Version: 3.5.4 release Component: Linguistic Product: LibreOffice Problem description: Wrong spellingcheck [German] Steps to reproduce: 1. Write Enthärtung (that's the correct spelling) 2. Writer marks it as wrong and want to correct to Endhärtung, but this is wrong -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59073] UI: Dialog menu 'Data - Sort - Sort Criteria' tab is empty
https://bugs.freedesktop.org/show_bug.cgi?id=59073 Jean-Baptiste Faure jbf.fa...@sud-ouest.org changed: What|Removed |Added Status|NEEDINFO|NEW CC||jbf.fa...@sud-ouest.org --- Comment #2 from Jean-Baptiste Faure jbf.fa...@sud-ouest.org --- Reproducible for me under Ubuntu 12.04 x86-64 with Version 4.0.0.0.beta2+ (Build ID: a31f703366b89abcb8cda1321163c596fc8e556). The Sort Criteria tab is empty until I change for the Options tab and go back to Sort criteria tab. Another way to restaure the view is simply to click outside the dialog in the Calc window. What is weird is that if I try to do a screencopy, the dialog is updated and shows what is expected. So I cannot provide a screencopy. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59081] New: Trying to open a mysql-database table crashes LO database
https://bugs.freedesktop.org/show_bug.cgi?id=59081 Priority: medium Bug ID: 59081 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Trying to open a mysql-database table crashes LO database Severity: critical Classification: Unclassified OS: Linux (All) Reporter: j.reit...@concepts.nl Hardware: x86-64 (AMD64) Status: UNCONFIRMED Version: 4.0.0.0.beta2 Component: Database Product: LibreOffice In LO 4.0.0.0beta2, downloaded yesterday from http://dev-builds.libreoffice.org/daily/libreoffice-4-0/Linux-x86_64_11-Release-Configuration/current/ the following occurs: On opening, in LO Database, an existing mysql database, the database opens. When I try to open the table, I am prompted for a password. When I typ in tje password, and press Enter, LO crashes without further notice. Trying to open it from the command line gives not much more info: /opt/lodev4.0/program ./soffice KCrash: Application 'soffice.bin' crashing... KCrash cannot reach kdeinit, launching directly. OS is OpenSuse 12.2, mysql v. 5.5.25a -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59063] UI Page Pane crash when moved
https://bugs.freedesktop.org/show_bug.cgi?id=59063 Jean-Baptiste Faure jbf.fa...@sud-ouest.org changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||jbf.fa...@sud-ouest.org Ever confirmed|0 |1 --- Comment #1 from Jean-Baptiste Faure jbf.fa...@sud-ouest.org --- Not sure to understand what you describe. Please, could you attach a screencopy of what happens? Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59061] FORMATTING / FORMULA with user defined formatting (prolly imported from Excel) that should result in - now shows -#\
https://bugs.freedesktop.org/show_bug.cgi?id=59061 Jean-Baptiste Faure jbf.fa...@sud-ouest.org changed: What|Removed |Added Attachment #72551|text/plain |application/vnd.oasis.opend mime type||ocument.spreadsheet -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59061] FORMATTING / FORMULA with user defined formatting (prolly imported from Excel) that should result in - now shows -#\
https://bugs.freedesktop.org/show_bug.cgi?id=59061 Jean-Baptiste Faure jbf.fa...@sud-ouest.org changed: What|Removed |Added Status|NEW |NEEDINFO CC||jbf.fa...@sud-ouest.org --- Comment #4 from Jean-Baptiste Faure jbf.fa...@sud-ouest.org --- I do not reproduce with Version 4.0.0.0.beta2+ (Build ID: a31f703366b89abcb8cda1321163c596fc8e556) under Ubuntu 12.04 x86-64. Had same problem in Writer, fixed now. @Cor: could you test again with a recent daily build ? Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59048] Crash when undoing a conversion text to table
https://bugs.freedesktop.org/show_bug.cgi?id=59048 --- Comment #6 from Julien Nabet serval2...@yahoo.fr --- Created attachment 72587 -- https://bugs.freedesktop.org/attachment.cgi?id=72587action=edit bt + console logs on 4.0 On pc Debian x86-64 with 4.0 sources updated today, I reproduced the problem. I attached bt + console logs. I also reproduced this with 3.6 sources but not with master sources updated today. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59042] Option 'Application background' does not work in the main window and Draw
https://bugs.freedesktop.org/show_bug.cgi?id=59042 mariosv mari...@miguelangel.mobi changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE Version|4.1.0.0.alpha0+ Master |unspecified --- Comment #3 from mariosv mari...@miguelangel.mobi --- Hi @api, right, no change in Draw and Main Window, but I have verify this is for all versions from 3.3.4 (As in Aoo 3.4.1). This was reporter in 51535 *** This bug has been marked as a duplicate of bug 51535 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51535] Start Center background doesn't change according to application background setting
https://bugs.freedesktop.org/show_bug.cgi?id=51535 mariosv mari...@miguelangel.mobi changed: What|Removed |Added CC||os...@yandex.ru --- Comment #2 from mariosv mari...@miguelangel.mobi --- *** Bug 59042 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59054] Form load event not firing (probably same cause as 42796)
https://bugs.freedesktop.org/show_bug.cgi?id=59054 Lionel Elie Mamane lio...@mamane.lu changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51081] EDITING: Multiple Select
https://bugs.freedesktop.org/show_bug.cgi?id=51081 bonedri...@gmx.com changed: What|Removed |Added Hardware|x86 (IA32) |x86-64 (AMD64) Priority|medium |highest Version|3.5.4 release |3.6.4.3 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58940] CONFIGURATION: Can not change paths used by LibreOffice
https://bugs.freedesktop.org/show_bug.cgi?id=58940 --- Comment #25 from Rafael DeGennaro rdegenn...@earthlink.net --- Just installed Linux Mint 14 XFCE (the lightweight version of Mint) on a netbook, and have the same bug. So it's not particular to the way I did the install on my desktop computer, or to the main edition of Mint. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59062] Failure on connexion for e-mailing
https://bugs.freedesktop.org/show_bug.cgi?id=59062 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #5 from Julien Nabet serval2...@yahoo.fr --- On pc Debian x86-64 with master sources updated today, I've got this: LibreOffice could not connect to the outgoing mail server. Check your system's settings and the settings in LibreOffice. Check the server name, the port and the secure connections settings -- class 'smtplib.SMTPException': SMTP AUTH extension not supported by server., traceback follows /home/julien/compile-libreoffice/libo/solver/unxlngx6/installation/opt/program/python-core-3.3.0/lib/smtplib.py:594 in function login() [raise SMTPException(SMTP AUTH extension not supported by server.)] /home/julien/compile-libreoffice/libo/solver/unxlngx6/installation/opt/program/mailmerge.py:107 in function connect() [self.server.login(user, password)] On 3.6, it's ok. I use an SMTP without authentification (since I use the box provided by my provider to connect) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59063] UI Page Pane crash when moved
https://bugs.freedesktop.org/show_bug.cgi?id=59063 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #2 from Julien Nabet serval2...@yahoo.fr --- On pc Debian x86-64 with 3.6 sources updated today, I don't reproduce this. Would it be possible you test with a newer version (3.6.4) or use LO package from Libreoffice website? If not, could you try to provide a backtrace by following this link? (see https://wiki.documentfoundation.org/BugReport#How_to_get_a_backtrace_.28on_Linux.29) Jean-Baptiste: page pane (where there are all the slides) is at left by default. Undock it then dock it to the top. Hope I didn't misunderstand what Noble meant :-) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59083] New: Export Chart as SVG produces zero byte files
https://bugs.freedesktop.org/show_bug.cgi?id=59083 Priority: medium Bug ID: 59083 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Export Chart as SVG produces zero byte files Severity: normal Classification: Unclassified OS: Windows (All) Reporter: pedl...@gmail.com Hardware: x86 (IA32) Status: UNCONFIRMED Version: 4.0.0.0.beta2 Component: Spreadsheet Product: LibreOffice Exporting a Chart in Calc works as expected for bitmap formats (PNG, JPG, TIF) and even for WMF. However exporting to SVG produces a zero byte file. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59084] New: EDITING: basic macro with event content change
https://bugs.freedesktop.org/show_bug.cgi?id=59084 Priority: medium Bug ID: 59084 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: EDITING: basic macro with event content change Severity: normal Classification: Unclassified OS: Linux (All) Reporter: koenig...@arcor.de Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 3.6.4.3 release Component: Spreadsheet Product: LibreOffice Created attachment 72590 -- https://bugs.freedesktop.org/attachment.cgi?id=72590action=edit an ods-file with the macro bundled to the event chance content Problem description: Steps to reproduce: 1. select more than one cell in the area A4:E10 2. after delete the ods-file crashes 3. the macro which is bundeled to content change event cann't refresh the datapilot Current behavior: the ods-file crashes Expected behavior: refresh the datapilot Operating System: Ubuntu Version: 3.6.4.3 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59080] Wrong spellingcheck [German]
https://bugs.freedesktop.org/show_bug.cgi?id=59080 manj_k courrier.oou.fr@googlemail.com changed: What|Removed |Added Status|NEW |NEEDINFO CC||courrier.oou.fr.mjk@googlem ||ail.com --- Comment #1 from manj_k courrier.oou.fr@googlemail.com --- [LibO 3.5.7.2 release, on WinXP] Not reproducible with the current dictionaries 'German (Austria, Germany, Switzerland) spelling dictionaries, hyphenation rules, and thesaurus 2012.06.17'. [1] See also the attached screenshot 'enthärtung.png'. [1] ExtensionCenter: http://extensions.libreoffice.org/extension-center/german-de-de-frami-dictionaries http://extensions.libreoffice.org/extension-center/german-de-at-frami-dictionaries http://extensions.libreoffice.org/extension-center/german-de-ch-frami-dictionaries -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59080] Wrong spellingcheck [German]
https://bugs.freedesktop.org/show_bug.cgi?id=59080 --- Comment #2 from manj_k courrier.oou.fr@googlemail.com --- Created attachment 72591 -- https://bugs.freedesktop.org/attachment.cgi?id=72591action=edit Screenshot: 'enthärtung.png' -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58832] undefined: firefox plugin upper toolbar
https://bugs.freedesktop.org/show_bug.cgi?id=58832 --- Comment #3 from paolo_debort...@yahoo.com --- ??? I have a laptop with ubuntu 12.04, mozilla firefox 17.0.1 and libreoffice dev 4.0 last build. If I open the browser and make file open file (anyfile).odt, it opens the file correctlty in the browser window, but doesn't show the upper LO toolbar (the one inside page with LO menu icons: save, modify, send, print, copy, zoom). Calc documents, draw documents and other types show the toolbar, but it is not present by opening text / writer documents. I think it a writer bug. I have no idea about plugin version; however I haven't installed other plugins; I think it is either included in LO or in the html page, so it doesn't come from other parties. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59061] FORMATTING / FORMULA with user defined formatting (prolly imported from Excel) that should result in - now shows -#\
https://bugs.freedesktop.org/show_bug.cgi?id=59061 --- Comment #5 from Cor Nouws c...@nouenoff.nl --- (In reply to comment #4) @Cor: could you test again with a recent daily build ? No daily builds yet for Linux x86 Will come one of the next days, prolly. thanks for reporting! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47464] SLIDESHOW: a pptx kills LO in slideshow mode, slide 3 and so
https://bugs.freedesktop.org/show_bug.cgi?id=47464 --- Comment #6 from Julien Nabet serval2...@yahoo.fr --- I don't have any crash anymore with 3.6 sources updated yesterday. danielcordero: could you give a try to a newer LO version (last one is 3.6.4)? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47383] FILEOPEN: Crashes caused by opening docx and Windows Data Execution Prevention
https://bugs.freedesktop.org/show_bug.cgi?id=47383 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INVALID CC||serval2...@yahoo.fr --- Comment #3 from Julien Nabet serval2...@yahoo.fr --- No Feedback since months, so put it INVALID Sinbad: if you reproduce the crash with last LO version (3.6.4), don't hesitate to reopen this tracker. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58526] UI: Add a close search button to the search bar
https://bugs.freedesktop.org/show_bug.cgi?id=58526 Joren De Cuyper joren.libreoff...@telenet.be changed: What|Removed |Added OS|Windows (All) |All Assignee|libreoffice-b...@lists.free |joren.libreoffice@telenet.b |desktop.org |e CC||joren.libreoffice@telenet.b ||e --- Comment #5 from Joren De Cuyper joren.libreoff...@telenet.be --- I'll try to implement this enhancement -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59081] Trying to open a mysql-database table crashes LO database
https://bugs.freedesktop.org/show_bug.cgi?id=59081 --- Comment #1 from Alex Thurgood ipla...@yahoo.co.uk --- Can not reproduce on my own dev build from master dated 05/01/2013 : Version 4.1.0.0.alpha0+ (Build ID: 1b65d9ed728bff7123d4385248ce6671c4de8bc) on Linux Mint 13 32bit Alex -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59081] Trying to open a mysql-database table crashes LO database
https://bugs.freedesktop.org/show_bug.cgi?id=59081 --- Comment #2 from Alex Thurgood ipla...@yahoo.co.uk --- (In reply to comment #1) Can not reproduce on my own dev build from master dated 05/01/2013 : Version 4.1.0.0.alpha0+ (Build ID: 1b65d9ed728bff7123d4385248ce6671c4de8bc) on Linux Mint 13 32bit Alex Using the mysql native connector extension. Alex -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
