[PATCH] Resolves fdo#61540
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2958
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/58/2958/1
Resolves fdo#61540
On Insert before, the reference column whose size is going to be used for
newly created column(s) is wrong. As the new columns are inserted before the
reference column, the reference column moved to the new position by no., of new
columns i.e (earlier+newcolumns).
Change-Id: Ib52e3633aecb1220cdf709058391361376dc5f00
---
M svx/source/table/tablecontroller.cxx
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/svx/source/table/tablecontroller.cxx
b/svx/source/table/tablecontroller.cxx
index ff6037c..dd3065e 100644
--- a/svx/source/table/tablecontroller.cxx
+++ b/svx/source/table/tablecontroller.cxx
@@ -554,10 +554,17 @@
for( sal_Int32 nOffset = 0; nOffset nNewColumns; nOffset++ )
{
-Reference XPropertySet ( xCols-getByIndex( aEnd.mnCol +
nOffset + 1 ), UNO_QUERY_THROW )-
-setPropertyValue( sSize,
-Reference XPropertySet ( xCols-getByIndex(
aStart.mnCol + nOffset ), UNO_QUERY_THROW )-
-getPropertyValue( sSize ) );
+ /*
+Resolves fdo#61540
+On Insert before, the reference column whose size is going to
be
+used for newly created column(s) is wrong. As the new columns
are
+inserted before the reference column, the reference column
moved
+to the new position by no., of new columns i.e
(earlier+newcolumns).
+ */
+Reference XPropertySet
(xCols-getByIndex(nNewStartColumn+nOffset), UNO_QUERY_THROW )-
+ setPropertyValue( sSize,Reference XPropertySet
+(xCols-getByIndex(
bInsertAfter?nNewStartColumn-1:nNewStartColumn+nNewColumns ), UNO_QUERY_THROW
)-
+ getPropertyValue( sSize ) );
}
if( bUndo )
--
To view, visit https://gerrit.libreoffice.org/2958
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib52e3633aecb1220cdf709058391361376dc5f00
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Karthikeyan Krishnamurthi karthike...@kacst.edu.sa
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 3 commits - chart2/qa offapi/com
chart2/qa/extras/chart2import.cxx| 59 ++-
offapi/com/sun/star/chart/LineDiagram.idl|5 +
offapi/com/sun/star/sheet/XUnnamedDatabaseRanges.idl |1
3 files changed, 62 insertions(+), 3 deletions(-)
New commits:
commit d1bc91ea645f490bd3da205c31fe45711d009f29
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sun Mar 24 07:39:45 2013 +0100
add import test for stepped lines
Change-Id: I5a11bc65ca82719c0e8de94628ae4958afe57aa4
diff --git a/chart2/qa/extras/chart2import.cxx
b/chart2/qa/extras/chart2import.cxx
index e30e1a0..7933001 100644
--- a/chart2/qa/extras/chart2import.cxx
+++ b/chart2/qa/extras/chart2import.cxx
@@ -27,7 +27,9 @@
#include com/sun/star/chart2/XChartTypeContainer.hpp
#include com/sun/star/chart2/XCoordinateSystemContainer.hpp
#include com/sun/star/chart2/XDataSeriesContainer.hpp
+#include com/sun/star/chart2/CurveStyle.hpp
#include com/sun/star/chart/ErrorBarStyle.hpp
+#include com/sun/star/chart/XChartDocument.hpp
#include comphelper/processfactory.hxx
@@ -38,12 +40,14 @@ class Chart2ImportTest : public test::BootstrapFixture,
public unotest::MacrosTe
{
public:
void Fdo60083();
+void testSteppedLines();
virtual void setUp();
virtual void tearDown();
CPPUNIT_TEST_SUITE(Chart2ImportTest);
CPPUNIT_TEST(Fdo60083);
+CPPUNIT_TEST(testSteppedLines);
CPPUNIT_TEST_SUITE_END();
private:
@@ -52,6 +56,8 @@ private:
Reference chart2::XChartDocument getChartDocFromSheet( sal_Int32
nSheet, uno::Reference lang::XComponent xComponent );
Reference chart2::XDataSeries getDataSeriesFromDoc( Reference
chart2::XChartDocument xChartDoc,
sal_Int32 nDataSeries, sal_Int32 nChartType = 0, sal_Int32 nCooSys
= 0 );
+Reference chart2::XChartType getChartTypeFromDoc( Reference
chart2::XChartDocument xChartDoc,
+sal_Int32 nChartType, sal_Int32 nCooSys = 0 );
Reference lang::XComponent mxComponent;
};
@@ -100,6 +106,46 @@ void Chart2ImportTest::Fdo60083()
CPPUNIT_ASSERT(!xErrorBarXProps.is());
}
+
+// stepped line interpolation
+void Chart2ImportTest::testSteppedLines()
+{
+const sal_Int32 MAXSHEET = 14;
+chart2::CurveStyle curveStyle[] = {
+chart2::CurveStyle_LINES,
+chart2::CurveStyle_CUBIC_SPLINES,
+chart2::CurveStyle_B_SPLINES,
+chart2::CurveStyle_STEP_START,
+chart2::CurveStyle_STEP_END,
+chart2::CurveStyle_STEP_CENTER_X,
+chart2::CurveStyle_STEP_CENTER_Y,
+chart2::CurveStyle_LINES,
+chart2::CurveStyle_CUBIC_SPLINES,
+chart2::CurveStyle_B_SPLINES,
+chart2::CurveStyle_STEP_START,
+chart2::CurveStyle_STEP_END,
+chart2::CurveStyle_STEP_CENTER_X,
+chart2::CurveStyle_STEP_CENTER_Y
+};
+
+load(/chart2/qa/extras/data/ods/, stepped_lines.ods);
+for(sal_Int32 nSheet = 0; nSheet MAXSHEET; ++nSheet)
+{
+uno::Reference chart2::XChartDocument xChart2Doc =
getChartDocFromSheet( nSheet, mxComponent );
+CPPUNIT_ASSERT(xChart2Doc.is());
+
+Reference chart2::XChartType xChartType = getChartTypeFromDoc(
xChart2Doc, 0 );
+CPPUNIT_ASSERT(xChartType.is());
+
+Reference beans::XPropertySet xPropSet( xChartType, UNO_QUERY );
+CPPUNIT_ASSERT(xPropSet.is());
+
+chart2::CurveStyle eCurveStyle;
+xPropSet-getPropertyValue(CurveStyle) = eCurveStyle;
+CPPUNIT_ASSERT_EQUAL(eCurveStyle, curveStyle[nSheet]);
+}
+}
+
Reference chart2::XChartDocument Chart2ImportTest::getChartDocFromSheet(
sal_Int32 nSheet, uno::Reference lang::XComponent xComponent )
{
// let us assume that we only have one chart per sheet
@@ -132,8 +178,8 @@ Reference chart2::XChartDocument
Chart2ImportTest::getChartDocFromSheet( sal_
return xChartDoc;
}
-Reference chart2::XDataSeries Chart2ImportTest::getDataSeriesFromDoc(
uno::Reference chart2::XChartDocument xChartDoc,
-sal_Int32
nDataSeries, sal_Int32 nChartType, sal_Int32 nCooSys )
+Reference chart2::XChartType Chart2ImportTest::getChartTypeFromDoc(
Reference chart2::XChartDocument xChartDoc,
+sal_Int32
nChartType, sal_Int32 nCooSys )
{
CPPUNIT_ASSERT( xChartDoc.is() );
@@ -152,7 +198,14 @@ Reference chart2::XDataSeries
Chart2ImportTest::getDataSeriesFromDoc( uno::Re
Sequence Reference chart2::XChartType xChartTypeSequence(
xChartTypeContainer-getChartTypes() );
CPPUNIT_ASSERT( xChartTypeSequence.getLength() nChartType );
-Reference chart2::XDataSeriesContainer xDataSequenceContainer(
xChartTypeSequence[nChartType], UNO_QUERY_THROW );
+return xChartTypeSequence[nChartType];
+}
+
+Reference chart2::XDataSeries Chart2ImportTest::getDataSeriesFromDoc(
uno::Reference chart2::XChartDocument xChartDoc,
+
Re: Leftover dmake makefiles
On Fri Mar 1 02:37:38 PST 2013, Michael Stahl wrote: it doesn't make any sense to just remove dmake files in some directory and leave the code around. maybe it needs special flags to build or whatever. either remove the whole thing or leave the dmake file there as documentation. I have to agree here. For example, there are two examples of how to use vcl via svdemo and vcldemo at vcl/workben but these haven't been built for years I believe and thus the dmake files make for great documentation. Chris ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Use OUString and sal_Int32 in ImplPrepareLayoutArgs() and Ge...
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2959
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/59/2959/1
Use OUString and sal_Int32 in ImplPrepareLayoutArgs() and GetTextIsRTL()
Change-Id: Ib1b659aa56a38efdfc2dddb5e362ac1eb54972f1
---
M vcl/inc/vcl/outdev.hxx
M vcl/source/gdi/outdev3.cxx
2 files changed, 29 insertions(+), 25 deletions(-)
diff --git a/vcl/inc/vcl/outdev.hxx b/vcl/inc/vcl/outdev.hxx
index e51ec2b..5f00757 100644
--- a/vcl/inc/vcl/outdev.hxx
+++ b/vcl/inc/vcl/outdev.hxx
@@ -382,10 +382,8 @@
xub_StrLen nLen, const Point
rLogicPos = Point(0,0),
long nLogicWidth=0, const
sal_Int32* pLogicDXArray=NULL,
bool bFilter = false ) const;
-SAL_DLLPRIVATE ImplLayoutArgs ImplPrepareLayoutArgs( String,
-xub_StrLen nIndex, xub_StrLen nLen,
-long nPixelWidth,
-const sal_Int32* pPixelDXArray )
const;
+SAL_DLLPRIVATE ImplLayoutArgs ImplPrepareLayoutArgs( OUString, const
sal_Int32 nIndex, const sal_Int32 nLen,
+long nPixelWidth, const sal_Int32*
pPixelDXArray ) const;
SAL_DLLPRIVATE SalLayout* ImplGlyphFallbackLayout( SalLayout*,
ImplLayoutArgs ) const;
static
@@ -1060,8 +1058,7 @@
sal_uInt16 GetBitCount() const;
-sal_BoolGetTextIsRTL( const String, xub_StrLen nIndex,
-xub_StrLen nLen ) const;
+sal_BoolGetTextIsRTL( const OUString, sal_Int32 nIndex,
sal_Int32 nLen ) const;
/** Query the existence and depth of the alpha channel
diff --git a/vcl/source/gdi/outdev3.cxx b/vcl/source/gdi/outdev3.cxx
index a2e2e1b..1fedcbd 100644
--- a/vcl/source/gdi/outdev3.cxx
+++ b/vcl/source/gdi/outdev3.cxx
@@ -5665,13 +5665,13 @@
mpAlphaVDev-DrawStretchText( rStartPt, nWidth, rStr, nIndex, nLen );
}
-ImplLayoutArgs OutputDevice::ImplPrepareLayoutArgs( String rStr,
- xub_StrLen nMinIndex, xub_StrLen nLen,
+ImplLayoutArgs OutputDevice::ImplPrepareLayoutArgs( OUString rStr,
+ const sal_Int32 nMinIndex, const
sal_Int32 nLen,
long nPixelWidth, const sal_Int32*
pDXArray ) const
{
// get string length for calculating extents
-xub_StrLen nEndIndex = rStr.Len();
-if( (sal_uLong)nMinIndex + nLen nEndIndex )
+sal_Int32 nEndIndex = rStr.getLength();
+if( nMinIndex + nLen nEndIndex )
nEndIndex = nMinIndex + nLen;
// don't bother if there is nothing to do
@@ -5686,8 +5686,8 @@
else if( 0 == (mnTextLayoutMode TEXT_LAYOUT_BIDI_RTL) )
{
// disable Bidi if no RTL hint and no RTL codes used
-const sal_Unicode* pStr = rStr.GetBuffer() + nMinIndex;
-const sal_Unicode* pEnd = rStr.GetBuffer() + nEndIndex;
+const sal_Unicode* pStr = rStr.getStr() + nMinIndex;
+const sal_Unicode* pEnd = rStr.getStr() + nEndIndex;
for( ; pStr pEnd; ++pStr )
if( ((*pStr = 0x0580) (*pStr 0x0800)) // middle eastern
scripts
|| ((*pStr = 0xFB18) (*pStr 0xFE00)) // hebrew + arabic A
presentation forms
@@ -5711,8 +5711,8 @@
else
{
// disable CTL for non-CTL text
-const sal_Unicode* pStr = rStr.GetBuffer() + nMinIndex;
-const sal_Unicode* pEnd = rStr.GetBuffer() + nEndIndex;
+const sal_Unicode* pStr = rStr.getStr() + nMinIndex;
+const sal_Unicode* pEnd = rStr.getStr() + nEndIndex;
for( ; pStr pEnd; ++pStr )
if( ((*pStr = 0x0300) (*pStr 0x0370)) // diacritical marks
|| ((*pStr = 0x0590) (*pStr 0x10A0)) // many CTL scripts
@@ -5731,9 +5731,10 @@
if( meTextLanguage ) //TODO: (mnTextLayoutMode
TEXT_LAYOUT_SUBSTITUTE_DIGITS)
{
// disable character localization when no digits used
-const sal_Unicode* pBase = rStr.GetBuffer();
+const sal_Unicode* pBase = rStr.getStr();
const sal_Unicode* pStr = pBase + nMinIndex;
const sal_Unicode* pEnd = pBase + nEndIndex;
+OUStringBuffer sTmpStr(rStr);
for( ; pStr pEnd; ++pStr )
{
// TODO: are there non-digit localizations?
@@ -5743,10 +5744,10 @@
sal_UCS4 cChar = GetLocalizedChar( *pStr, meTextLanguage );
if( cChar != *pStr )
// TODO: are the localized digit surrogates?
-rStr.SetChar( static_castsal_uInt16(pStr - pBase),
- static_castsal_Unicode(cChar) );
+sTmpStr[pStr - pBase] = cChar;
}
}
+rStr = sTmpStr.makeStringAndClear();
[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - translations
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 76063620b557de5b296aa6a23000dd4f881c943a Author: Andras Timar ati...@suse.com Date: Sun Mar 24 11:06:20 2013 +0100 Updated core Project: translations 78ffe851c7f86318bd0e21f93caf3ccb7d1b98b9 diff --git a/translations b/translations index d4890ce..78ffe85 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit d4890cefbeb9e8b7249700b3d71a830352ac5857 +Subproject commit 78ffe851c7f86318bd0e21f93caf3ccb7d1b98b9 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-0-2' - translations
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit ba9d87b319fc43d1108ec99bca3a8a0098a56d1a Author: Andras Timar ati...@suse.com Date: Sun Mar 24 11:06:20 2013 +0100 Updated core Project: translations e1e883825a9f5385933031423197cd0e6437f9d1 diff --git a/translations b/translations index c4870e1..e1e8838 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit c4870e103bdfe60109cde78cd6ee3b8b4414a99d +Subproject commit e1e883825a9f5385933031423197cd0e6437f9d1 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PATCH] convert half of optfltr.src to .ui
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2961
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/61/2961/1
convert half of optfltr.src to .ui
Converted the VBA Properties half of optfltr.src to optfltrpage.ui.
Change-Id: Ie200377f2956aa243b1be859eb52972b79e9dc66
---
M cui/UI_cui.mk
M cui/source/options/optfltr.cxx
M cui/source/options/optfltr.hrc
M cui/source/options/optfltr.hxx
M cui/source/options/optfltr.src
A cui/uiconfig/ui/optfltrpage.ui
6 files changed, 308 insertions(+), 161 deletions(-)
diff --git a/cui/UI_cui.mk b/cui/UI_cui.mk
index fff3fda..c3b6fe7 100644
--- a/cui/UI_cui.mk
+++ b/cui/UI_cui.mk
@@ -37,6 +37,7 @@
cui/uiconfig/ui/optaccessibilitypage \
cui/uiconfig/ui/optadvancedpage \
cui/uiconfig/ui/optappearancepage \
+ cui/uiconfig/ui/optfltrpage \
cui/uiconfig/ui/optfontspage \
cui/uiconfig/ui/optgeneralpage \
cui/uiconfig/ui/optmemorypage \
diff --git a/cui/source/options/optfltr.cxx b/cui/source/options/optfltr.cxx
index df2d57e..2271fab 100644
--- a/cui/source/options/optfltr.cxx
+++ b/cui/source/options/optfltr.cxx
@@ -39,23 +39,19 @@
// ---
OfaMSFilterTabPage::OfaMSFilterTabPage(Window* pParent, const SfxItemSet rSet)
-: SfxTabPage( pParent, CUI_RES( RID_OFAPAGE_MSFILTEROPT ), rSet ),
-aMSWordGB ( this, CUI_RES( GB_WORD) ),
-aWBasicCodeCB ( this, CUI_RES( CB_WBAS_CODE ) ),
-aWBasicWbctblCB ( this, CUI_RES( CB_WBAS_WBCTBL ) ),
-aWBasicStgCB( this, CUI_RES( CB_WBAS_STG ) ),
-aMSExcelGB ( this, CUI_RES( GB_EXCEL ) ),
-aEBasicCodeCB ( this, CUI_RES( CB_EBAS_CODE ) ),
-aEBasicExectblCB( this, CUI_RES( CB_EBAS_EXECTBL ) ),
-aEBasicStgCB( this, CUI_RES( CB_EBAS_STG ) ),
-aMSPPointGB ( this, CUI_RES( GB_PPOINT) ),
-aPBasicCodeCB ( this, CUI_RES( CB_PBAS_CODE ) ),
-aPBasicStgCB( this, CUI_RES( CB_PBAS_STG ) )
+: SfxTabPage( pParent, OptFltrPage, cui/ui/optfltrpage.ui, rSet )
{
-FreeResource();
+get( aWBasicCodeCB , wo_basic);
+get( aWBasicWbctblCB, wo_exec );
+get( aWBasicStgCB , wo_saveorig );
+get( aEBasicCodeCB , ex_basic);
+get( aEBasicExectblCB , ex_exec );
+get( aEBasicStgCB , ex_saveorig );
+get( aPBasicCodeCB , pp_basic);
+get( aPBasicStgCB , pp_saveorig );
-aWBasicCodeCB.SetClickHdl( LINK( this, OfaMSFilterTabPage,
LoadWordBasicCheckHdl_Impl ) );
-aEBasicCodeCB.SetClickHdl( LINK( this, OfaMSFilterTabPage,
LoadExcelBasicCheckHdl_Impl ) );
+aWBasicCodeCB-SetClickHdl( LINK( this, OfaMSFilterTabPage,
LoadWordBasicCheckHdl_Impl ) );
+aEBasicCodeCB-SetClickHdl( LINK( this, OfaMSFilterTabPage,
LoadExcelBasicCheckHdl_Impl ) );
}
OfaMSFilterTabPage::~OfaMSFilterTabPage()
@@ -64,13 +60,13 @@
IMPL_LINK_NOARG(OfaMSFilterTabPage, LoadWordBasicCheckHdl_Impl)
{
-aWBasicWbctblCB.Enable( aWBasicCodeCB.IsChecked() );
+aWBasicWbctblCB-Enable( aWBasicCodeCB-IsChecked() );
return 0;
}
IMPL_LINK_NOARG(OfaMSFilterTabPage, LoadExcelBasicCheckHdl_Impl)
{
-aEBasicExectblCB.Enable( aEBasicCodeCB.IsChecked() );
+aEBasicExectblCB-Enable( aEBasicCodeCB-IsChecked() );
return 0;
}
@@ -85,23 +81,23 @@
SvtFilterOptions rOpt = SvtFilterOptions::Get();
sal_Bool bFlag;
-if( aWBasicCodeCB.GetSavedValue() != (bFlag = aWBasicCodeCB.IsChecked()))
+if( aWBasicCodeCB-GetSavedValue() != (bFlag = aWBasicCodeCB-IsChecked()))
rOpt.SetLoadWordBasicCode( bFlag );
-if( aWBasicWbctblCB.GetSavedValue() != (bFlag =
aWBasicWbctblCB.IsChecked()))
+if( aWBasicWbctblCB-GetSavedValue() != (bFlag =
aWBasicWbctblCB-IsChecked()))
rOpt.SetLoadWordBasicExecutable( bFlag );
-if( aWBasicStgCB.GetSavedValue() != (bFlag = aWBasicStgCB.IsChecked()))
+if( aWBasicStgCB-GetSavedValue() != (bFlag = aWBasicStgCB-IsChecked()))
rOpt.SetLoadWordBasicStorage( bFlag );
-if( aEBasicCodeCB.GetSavedValue() != (bFlag = aEBasicCodeCB.IsChecked()))
+if( aEBasicCodeCB-GetSavedValue() != (bFlag = aEBasicCodeCB-IsChecked()))
rOpt.SetLoadExcelBasicCode( bFlag );
-if( aEBasicExectblCB.GetSavedValue() != (bFlag =
aEBasicExectblCB.IsChecked()))
+if( aEBasicExectblCB-GetSavedValue() != (bFlag =
aEBasicExectblCB-IsChecked()))
rOpt.SetLoadExcelBasicExecutable( bFlag );
-if( aEBasicStgCB.GetSavedValue() != (bFlag = aEBasicStgCB.IsChecked()))
+if( aEBasicStgCB-GetSavedValue() != (bFlag = aEBasicStgCB-IsChecked()))
rOpt.SetLoadExcelBasicStorage( bFlag );
-if( aPBasicCodeCB.GetSavedValue() != (bFlag = aPBasicCodeCB.IsChecked()))
+if( aPBasicCodeCB-GetSavedValue() != (bFlag = aPBasicCodeCB-IsChecked()))
rOpt.SetLoadPPointBasicCode( bFlag );
-if( aPBasicStgCB.GetSavedValue() !=
[Libreoffice-commits] core.git: solenv/gcc-wrappers
solenv/gcc-wrappers/wrapper.cxx |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
New commits:
commit c8c19de5c0df85a31ceb5454da351ed13076e048
Author: Peter Foley pefol...@verizon.net
Date: Sat Mar 23 20:09:16 2013 -0400
fix liborcus on windows
Change-Id: I852b4e159f818854fd2ac5bdcd14343b2a628134
diff --git a/solenv/gcc-wrappers/wrapper.cxx b/solenv/gcc-wrappers/wrapper.cxx
index 2b2f233..a768eef 100644
--- a/solenv/gcc-wrappers/wrapper.cxx
+++ b/solenv/gcc-wrappers/wrapper.cxx
@@ -103,7 +103,7 @@ string processccargs(vectorstring rawargs) {
args.append(-link -LIBPATH:+(*i).substr(2));
}
else if(!(*i).compare(0,2,-l)) {
-args.append((*i).substr(2)+lib.lib);
+args.append((*i).substr(2)+.lib);
}
else if(!(*i).compare(0,12,-fvisibility)) {
//TODO: drop other gcc-specific options
@@ -132,7 +132,7 @@ int startprocess(string command, string args) {
sa.bInheritHandle=TRUE;
if(!CreatePipe(childout_read,childout_write,sa,0)) {
-cerr Error: could not create sdtout pipe endl;
+cerr Error: could not create stdout pipe endl;
exit(1);
}
@@ -141,6 +141,7 @@ int startprocess(string command, string args) {
si.hStdOutput=childout_write;
si.hStdError=childout_write;
+// support ccache
size_t pos=command.find(ccache );
if(pos != string::npos) {
args.insert(0,cl.exe);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 5 commits - Library_merged.mk solenv/gbuild xmlsecurity/inc xmlsecurity/source
Library_merged.mk |1 +
solenv/gbuild/extensions/pre_MergedLibsList.mk |8
xmlsecurity/inc/xmlsecurity/macrosecurity.hxx |6 +++---
xmlsecurity/source/dialogs/macrosecurity.cxx | 10 +-
4 files changed, 17 insertions(+), 8 deletions(-)
New commits:
commit 526c32e6909b6955e72f34d86e0aa6a88d74370c
Author: Peter Foley pefol...@verizon.net
Date: Sat Mar 23 20:35:18 2013 -0400
add chartcore to Library_merged
Change-Id: I27c27556e25e2233eea0406e20afe0531ed638e7
diff --git a/solenv/gbuild/extensions/pre_MergedLibsList.mk
b/solenv/gbuild/extensions/pre_MergedLibsList.mk
index 0f17458..117c0df 100644
--- a/solenv/gbuild/extensions/pre_MergedLibsList.mk
+++ b/solenv/gbuild/extensions/pre_MergedLibsList.mk
@@ -31,6 +31,7 @@ ifeq ($(MERGELIBS),TRUE)
gb_MERGEDLIBS := \
avmedia \
canvastools \
+ chartcore \
configmgr \
cppcanvas \
cui \
commit 9e9dc4f4bae26533ebde9ffbcb5ee31a85203194
Author: Peter Foley pefol...@verizon.net
Date: Sat Mar 23 20:29:16 2013 -0400
add localedata to Library_merged
Change-Id: If7896fc49c38f41b370d569a90b02148dcbcbfd6
diff --git a/solenv/gbuild/extensions/pre_MergedLibsList.mk
b/solenv/gbuild/extensions/pre_MergedLibsList.mk
index d5e8f17..0f17458 100644
--- a/solenv/gbuild/extensions/pre_MergedLibsList.mk
+++ b/solenv/gbuild/extensions/pre_MergedLibsList.mk
@@ -52,6 +52,10 @@ gb_MERGEDLIBS := \
i18nutil \
lng \
localebe1 \
+ localedata_en \
+ localedata_es \
+ localedata_euro \
+ localedata_others \
msfilter \
oox \
package2 \
commit 9cac6577496d0aa5ee22720239fcd18fcde85a02
Author: Peter Foley pefol...@verizon.net
Date: Sat Mar 23 20:22:47 2013 -0400
add cui to Library_merged
Change-Id: I485426c0a0792e17bae5ef125d69f52827b469b2
diff --git a/solenv/gbuild/extensions/pre_MergedLibsList.mk
b/solenv/gbuild/extensions/pre_MergedLibsList.mk
index 4c7c229..d5e8f17 100644
--- a/solenv/gbuild/extensions/pre_MergedLibsList.mk
+++ b/solenv/gbuild/extensions/pre_MergedLibsList.mk
@@ -33,6 +33,7 @@ gb_MERGEDLIBS := \
canvastools \
configmgr \
cppcanvas \
+ cui \
$(call gb_Helper_optional,DBCONNECTIVITY,dba) \
$(call gb_Helper_optional,DBCONNECTIVITY,dbtools) \
$(call gb_Helper_optional,DBCONNECTIVITY,dbu) \
diff --git a/xmlsecurity/inc/xmlsecurity/macrosecurity.hxx
b/xmlsecurity/inc/xmlsecurity/macrosecurity.hxx
index 8dc691e..9f79955 100644
--- a/xmlsecurity/inc/xmlsecurity/macrosecurity.hxx
+++ b/xmlsecurity/inc/xmlsecurity/macrosecurity.hxx
@@ -42,11 +42,11 @@ namespace dcss = ::com::sun::star;
class MacroSecurityTP;
-class ReadOnlyImage : public FixedImage
+class XmlReadOnlyImage : public FixedImage
{
public:
-ReadOnlyImage(Window* pParent, const ResId rResId);
-~ReadOnlyImage();
+XmlReadOnlyImage(Window* pParent, const ResId rResId);
+~XmlReadOnlyImage();
virtual voidRequestHelp( const HelpEvent rHEvt );
static const OUString GetHelpTip();
diff --git a/xmlsecurity/source/dialogs/macrosecurity.cxx
b/xmlsecurity/source/dialogs/macrosecurity.cxx
index 3a0a745..0063b0f 100644
--- a/xmlsecurity/source/dialogs/macrosecurity.cxx
+++ b/xmlsecurity/source/dialogs/macrosecurity.cxx
@@ -433,17 +433,17 @@ void MacroSecurityTrustedSourcesTP::ClosePage( void )
mpDlg-maSecOptions.SetTrustedAuthors( maTrustedAuthors );
}
-ReadOnlyImage::ReadOnlyImage(Window* pParent, const ResId rResId) :
+XmlReadOnlyImage::XmlReadOnlyImage(Window* pParent, const ResId rResId) :
FixedImage(pParent, rResId)
{
SetImage( Image(XMLSEC_RES( RID_XMLSECTP_LOCK )));
}
-ReadOnlyImage::~ReadOnlyImage()
+XmlReadOnlyImage::~XmlReadOnlyImage()
{
}
-void ReadOnlyImage::RequestHelp( const HelpEvent rHEvt )
+void XmlReadOnlyImage::RequestHelp( const HelpEvent rHEvt )
{
if( Help::IsBalloonHelpEnabled() || Help::IsQuickHelpEnabled() )
{
@@ -451,7 +451,7 @@ void ReadOnlyImage::RequestHelp( const HelpEvent rHEvt )
Rectangle aScreenRect( OutputToScreenPixel( aLogicPix.TopLeft() ),
OutputToScreenPixel(
aLogicPix.BottomRight() ) );
-OUString aStr(ReadOnlyImage::GetHelpTip());
+OUString aStr(XmlReadOnlyImage::GetHelpTip());
if ( Help::IsBalloonHelpEnabled() )
Help::ShowBalloon( this, rHEvt.GetMousePosPixel(), aScreenRect,
aStr );
@@ -462,7 +462,7 @@ void ReadOnlyImage::RequestHelp( const HelpEvent rHEvt )
Window::RequestHelp( rHEvt );
}
-const OUString ReadOnlyImage::GetHelpTip()
+const OUString XmlReadOnlyImage::GetHelpTip()
{
static OUString aStr(XMLSEC_RES( RID_XMLSECTP_READONLY_CONFIG_TIP));
return aStr;
commit 8726f878574b00fea9a47601e2c341b6f7d7aa37
Author: Peter Foley pefol...@verizon.net
Date: Sat Mar 23 20:12:13 2013 -0400
add writerfilter
[Libreoffice-commits] core.git: chart2/qa
chart2/qa/extras/data/ods/stepped_lines.ods |binary 1 file changed New commits: commit ef61bc2934bb9ae27b366fce6e707533cd73c862 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Sun Mar 24 14:16:14 2013 +0100 add missing test file Change-Id: I87e2bdf944a3fdf374f8b1f14e44ebc0fdd83d46 diff --git a/chart2/qa/extras/data/ods/stepped_lines.ods b/chart2/qa/extras/data/ods/stepped_lines.ods new file mode 100644 index 000..23d443a Binary files /dev/null and b/chart2/qa/extras/data/ods/stepped_lines.ods differ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 5 commits - svx/inc svx/source xmloff/source
svx/inc/svx/sdr/contact/viewobjectcontactofgroup.hxx |3 +
svx/inc/svx/sdr/contact/viewobjectcontactofsdrobj.hxx |9 +++
svx/source/sdr/contact/viewobjectcontactofgroup.cxx |9 +++
svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx |7 ++-
svx/source/svdraw/svdibrow.cxx| 42 +-
svx/source/svdraw/svdobj.cxx |6 --
xmloff/source/style/impastp4.cxx |2
7 files changed, 52 insertions(+), 26 deletions(-)
New commits:
commit 09d4525b11f396a68ca7c5cbb1ae3462db40c77c
Author: David Tardon dtar...@redhat.com
Date: Sun Mar 24 14:08:14 2013 +0100
fdo#62617 display groups on multiple layers correctly
It is possible to group objects from different layers, so it is an error
to rely on layer ID when checking visibility of a group. This problem
was partially obscured by the fact that SdrObjGroup::GetLayer() returns
0 if its subobjects are on different layers and 0 is a valid layer ID.
Change-Id: I0ef75544a26817154642185864cafd4e6734fa38
diff --git a/svx/inc/svx/sdr/contact/viewobjectcontactofgroup.hxx
b/svx/inc/svx/sdr/contact/viewobjectcontactofgroup.hxx
index b925889..fda5610 100644
--- a/svx/inc/svx/sdr/contact/viewobjectcontactofgroup.hxx
+++ b/svx/inc/svx/sdr/contact/viewobjectcontactofgroup.hxx
@@ -40,6 +40,9 @@ namespace sdr
// This method recursively paints the draw hierarchy.
virtual drawinglayer::primitive2d::Primitive2DSequence
getPrimitive2DSequenceHierarchy(DisplayInfo rDisplayInfo) const;
+
+private:
+virtual bool isPrimitiveVisibleOnAnyLayer(const SetOfByte
aLayers) const;
};
} // end of namespace contact
} // end of namespace sdr
diff --git a/svx/inc/svx/sdr/contact/viewobjectcontactofsdrobj.hxx
b/svx/inc/svx/sdr/contact/viewobjectcontactofsdrobj.hxx
index d7609bd..e038442 100644
--- a/svx/inc/svx/sdr/contact/viewobjectcontactofsdrobj.hxx
+++ b/svx/inc/svx/sdr/contact/viewobjectcontactofsdrobj.hxx
@@ -25,6 +25,7 @@
//
// predeclarations
class SdrObject;
+class SetOfByte;
//
@@ -34,6 +35,14 @@ namespace sdr
{
class SVX_DLLPUBLIC ViewObjectContactOfSdrObj : public
ViewObjectContact
{
+/** Test whether the primitive is visible on any layer from @c
aLayers
+
+This should be overriden by ViewObjectContacts of SDR classes
+that have subparts which can be on different layers (that is,
+SdrObjGroup .-)
+ */
+virtual bool isPrimitiveVisibleOnAnyLayer(const SetOfByte
aLayers) const;
+
protected:
const SdrObject getSdrObject() const;
diff --git a/svx/source/sdr/contact/viewobjectcontactofgroup.cxx
b/svx/source/sdr/contact/viewobjectcontactofgroup.cxx
index cdd21db..724b77e 100644
--- a/svx/source/sdr/contact/viewobjectcontactofgroup.cxx
+++ b/svx/source/sdr/contact/viewobjectcontactofgroup.cxx
@@ -25,6 +25,7 @@
#include drawinglayer/primitive2d/groupprimitive2d.hxx
#include basegfx/tools/canvastools.hxx
#include svx/sdr/contact/viewcontact.hxx
+#include svx/svdobj.hxx
//
@@ -98,6 +99,14 @@ namespace sdr
}
return xRetval;
}
+
+bool ViewObjectContactOfGroup::isPrimitiveVisibleOnAnyLayer(const
SetOfByte aLayers) const
+{
+SetOfByte aObjectLayers;
+getSdrObject().getMergedHierarchyLayerSet(aObjectLayers);
+aObjectLayers = aLayers;
+return !aObjectLayers.IsEmpty();
+}
} // end of namespace contact
} // end of namespace sdr
diff --git a/svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx
b/svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx
index e184bde..77c97cd 100644
--- a/svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx
+++ b/svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx
@@ -48,12 +48,17 @@ namespace sdr
{
}
+bool ViewObjectContactOfSdrObj::isPrimitiveVisibleOnAnyLayer(const
SetOfByte aLayers) const
+{
+return aLayers.IsSet(getSdrObject().GetLayer());
+}
+
bool ViewObjectContactOfSdrObj::isPrimitiveVisible(const DisplayInfo
rDisplayInfo) const
{
const SdrObject rObject = getSdrObject();
// Test layer visibility
-if(!rDisplayInfo.GetProcessLayers().IsSet(rObject.GetLayer()))
+if(!isPrimitiveVisibleOnAnyLayer(rDisplayInfo.GetProcessLayers()))
{
return false;
}
commit 9a100bc4f96a8a909b3a2b81cd09079612a9e909
Author: David Tardon dtar...@redhat.com
Date: Sun Mar 24 14:27:15 2013 +0100
avoid possible data inconsistency
[PATCH libreoffice-4-0] fdo#62617 display groups on multiple layers correctly
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2962
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/62/2962/1
fdo#62617 display groups on multiple layers correctly
It is possible to group objects from different layers, so it is an error
to rely on layer ID when checking visibility of a group. This problem
was partially obscured by the fact that SdrObjGroup::GetLayer() returns
0 if its subobjects are on different layers and 0 is a valid layer ID.
Change-Id: I0ef75544a26817154642185864cafd4e6734fa38
(cherry picked from commit 09d4525b11f396a68ca7c5cbb1ae3462db40c77c)
---
M svx/inc/svx/sdr/contact/viewobjectcontactofgroup.hxx
M svx/inc/svx/sdr/contact/viewobjectcontactofsdrobj.hxx
M svx/source/sdr/contact/viewobjectcontactofgroup.cxx
M svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx
4 files changed, 27 insertions(+), 1 deletion(-)
diff --git a/svx/inc/svx/sdr/contact/viewobjectcontactofgroup.hxx
b/svx/inc/svx/sdr/contact/viewobjectcontactofgroup.hxx
index b925889..fda5610 100644
--- a/svx/inc/svx/sdr/contact/viewobjectcontactofgroup.hxx
+++ b/svx/inc/svx/sdr/contact/viewobjectcontactofgroup.hxx
@@ -40,6 +40,9 @@
// This method recursively paints the draw hierarchy.
virtual drawinglayer::primitive2d::Primitive2DSequence
getPrimitive2DSequenceHierarchy(DisplayInfo rDisplayInfo) const;
+
+private:
+virtual bool isPrimitiveVisibleOnAnyLayer(const SetOfByte
aLayers) const;
};
} // end of namespace contact
} // end of namespace sdr
diff --git a/svx/inc/svx/sdr/contact/viewobjectcontactofsdrobj.hxx
b/svx/inc/svx/sdr/contact/viewobjectcontactofsdrobj.hxx
index d7609bd..e038442 100644
--- a/svx/inc/svx/sdr/contact/viewobjectcontactofsdrobj.hxx
+++ b/svx/inc/svx/sdr/contact/viewobjectcontactofsdrobj.hxx
@@ -25,6 +25,7 @@
//
// predeclarations
class SdrObject;
+class SetOfByte;
//
@@ -34,6 +35,14 @@
{
class SVX_DLLPUBLIC ViewObjectContactOfSdrObj : public
ViewObjectContact
{
+/** Test whether the primitive is visible on any layer from @c
aLayers
+
+This should be overriden by ViewObjectContacts of SDR classes
+that have subparts which can be on different layers (that is,
+SdrObjGroup .-)
+ */
+virtual bool isPrimitiveVisibleOnAnyLayer(const SetOfByte
aLayers) const;
+
protected:
const SdrObject getSdrObject() const;
diff --git a/svx/source/sdr/contact/viewobjectcontactofgroup.cxx
b/svx/source/sdr/contact/viewobjectcontactofgroup.cxx
index cdd21db..724b77e 100644
--- a/svx/source/sdr/contact/viewobjectcontactofgroup.cxx
+++ b/svx/source/sdr/contact/viewobjectcontactofgroup.cxx
@@ -25,6 +25,7 @@
#include drawinglayer/primitive2d/groupprimitive2d.hxx
#include basegfx/tools/canvastools.hxx
#include svx/sdr/contact/viewcontact.hxx
+#include svx/svdobj.hxx
//
@@ -98,6 +99,14 @@
}
return xRetval;
}
+
+bool ViewObjectContactOfGroup::isPrimitiveVisibleOnAnyLayer(const
SetOfByte aLayers) const
+{
+SetOfByte aObjectLayers;
+getSdrObject().getMergedHierarchyLayerSet(aObjectLayers);
+aObjectLayers = aLayers;
+return !aObjectLayers.IsEmpty();
+}
} // end of namespace contact
} // end of namespace sdr
diff --git a/svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx
b/svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx
index e184bde..77c97cd 100644
--- a/svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx
+++ b/svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx
@@ -48,12 +48,17 @@
{
}
+bool ViewObjectContactOfSdrObj::isPrimitiveVisibleOnAnyLayer(const
SetOfByte aLayers) const
+{
+return aLayers.IsSet(getSdrObject().GetLayer());
+}
+
bool ViewObjectContactOfSdrObj::isPrimitiveVisible(const DisplayInfo
rDisplayInfo) const
{
const SdrObject rObject = getSdrObject();
// Test layer visibility
-if(!rDisplayInfo.GetProcessLayers().IsSet(rObject.GetLayer()))
+if(!isPrimitiveVisibleOnAnyLayer(rDisplayInfo.GetProcessLayers()))
{
return false;
}
--
To view, visit https://gerrit.libreoffice.org/2962
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ef75544a26817154642185864cafd4e6734fa38
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: David Tardon dtar...@redhat.com
___
LibreOffice mailing
[PATCH libreoffice-4-0-2] fdo#62617 display groups on multiple layers correctly
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2963
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/63/2963/1
fdo#62617 display groups on multiple layers correctly
It is possible to group objects from different layers, so it is an error
to rely on layer ID when checking visibility of a group. This problem
was partially obscured by the fact that SdrObjGroup::GetLayer() returns
0 if its subobjects are on different layers and 0 is a valid layer ID.
Change-Id: I0ef75544a26817154642185864cafd4e6734fa38
(cherry picked from commit 09d4525b11f396a68ca7c5cbb1ae3462db40c77c)
---
M svx/inc/svx/sdr/contact/viewobjectcontactofgroup.hxx
M svx/inc/svx/sdr/contact/viewobjectcontactofsdrobj.hxx
M svx/source/sdr/contact/viewobjectcontactofgroup.cxx
M svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx
4 files changed, 27 insertions(+), 1 deletion(-)
diff --git a/svx/inc/svx/sdr/contact/viewobjectcontactofgroup.hxx
b/svx/inc/svx/sdr/contact/viewobjectcontactofgroup.hxx
index b925889..fda5610 100644
--- a/svx/inc/svx/sdr/contact/viewobjectcontactofgroup.hxx
+++ b/svx/inc/svx/sdr/contact/viewobjectcontactofgroup.hxx
@@ -40,6 +40,9 @@
// This method recursively paints the draw hierarchy.
virtual drawinglayer::primitive2d::Primitive2DSequence
getPrimitive2DSequenceHierarchy(DisplayInfo rDisplayInfo) const;
+
+private:
+virtual bool isPrimitiveVisibleOnAnyLayer(const SetOfByte
aLayers) const;
};
} // end of namespace contact
} // end of namespace sdr
diff --git a/svx/inc/svx/sdr/contact/viewobjectcontactofsdrobj.hxx
b/svx/inc/svx/sdr/contact/viewobjectcontactofsdrobj.hxx
index d7609bd..e038442 100644
--- a/svx/inc/svx/sdr/contact/viewobjectcontactofsdrobj.hxx
+++ b/svx/inc/svx/sdr/contact/viewobjectcontactofsdrobj.hxx
@@ -25,6 +25,7 @@
//
// predeclarations
class SdrObject;
+class SetOfByte;
//
@@ -34,6 +35,14 @@
{
class SVX_DLLPUBLIC ViewObjectContactOfSdrObj : public
ViewObjectContact
{
+/** Test whether the primitive is visible on any layer from @c
aLayers
+
+This should be overriden by ViewObjectContacts of SDR classes
+that have subparts which can be on different layers (that is,
+SdrObjGroup .-)
+ */
+virtual bool isPrimitiveVisibleOnAnyLayer(const SetOfByte
aLayers) const;
+
protected:
const SdrObject getSdrObject() const;
diff --git a/svx/source/sdr/contact/viewobjectcontactofgroup.cxx
b/svx/source/sdr/contact/viewobjectcontactofgroup.cxx
index cdd21db..724b77e 100644
--- a/svx/source/sdr/contact/viewobjectcontactofgroup.cxx
+++ b/svx/source/sdr/contact/viewobjectcontactofgroup.cxx
@@ -25,6 +25,7 @@
#include drawinglayer/primitive2d/groupprimitive2d.hxx
#include basegfx/tools/canvastools.hxx
#include svx/sdr/contact/viewcontact.hxx
+#include svx/svdobj.hxx
//
@@ -98,6 +99,14 @@
}
return xRetval;
}
+
+bool ViewObjectContactOfGroup::isPrimitiveVisibleOnAnyLayer(const
SetOfByte aLayers) const
+{
+SetOfByte aObjectLayers;
+getSdrObject().getMergedHierarchyLayerSet(aObjectLayers);
+aObjectLayers = aLayers;
+return !aObjectLayers.IsEmpty();
+}
} // end of namespace contact
} // end of namespace sdr
diff --git a/svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx
b/svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx
index e184bde..77c97cd 100644
--- a/svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx
+++ b/svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx
@@ -48,12 +48,17 @@
{
}
+bool ViewObjectContactOfSdrObj::isPrimitiveVisibleOnAnyLayer(const
SetOfByte aLayers) const
+{
+return aLayers.IsSet(getSdrObject().GetLayer());
+}
+
bool ViewObjectContactOfSdrObj::isPrimitiveVisible(const DisplayInfo
rDisplayInfo) const
{
const SdrObject rObject = getSdrObject();
// Test layer visibility
-if(!rDisplayInfo.GetProcessLayers().IsSet(rObject.GetLayer()))
+if(!isPrimitiveVisibleOnAnyLayer(rDisplayInfo.GetProcessLayers()))
{
return false;
}
--
To view, visit https://gerrit.libreoffice.org/2963
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ef75544a26817154642185864cafd4e6734fa38
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0-2
Gerrit-Owner: David Tardon dtar...@redhat.com
___
LibreOffice mailing
[PATCH libreoffice-3-6-6] fdo#62617 display groups on multiple layers correctly
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2964
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/64/2964/1
fdo#62617 display groups on multiple layers correctly
It is possible to group objects from different layers, so it is an error
to rely on layer ID when checking visibility of a group. This problem
was partially obscured by the fact that SdrObjGroup::GetLayer() returns
0 if its subobjects are on different layers and 0 is a valid layer ID.
Change-Id: I0ef75544a26817154642185864cafd4e6734fa38
(cherry picked from commit 09d4525b11f396a68ca7c5cbb1ae3462db40c77c)
---
M svx/inc/svx/sdr/contact/viewobjectcontactofgroup.hxx
M svx/inc/svx/sdr/contact/viewobjectcontactofsdrobj.hxx
M svx/source/sdr/contact/viewobjectcontactofgroup.cxx
M svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx
4 files changed, 27 insertions(+), 1 deletion(-)
diff --git a/svx/inc/svx/sdr/contact/viewobjectcontactofgroup.hxx
b/svx/inc/svx/sdr/contact/viewobjectcontactofgroup.hxx
index e189a63..7a0596a 100644
--- a/svx/inc/svx/sdr/contact/viewobjectcontactofgroup.hxx
+++ b/svx/inc/svx/sdr/contact/viewobjectcontactofgroup.hxx
@@ -49,6 +49,9 @@
// This method recursively paints the draw hierarchy.
virtual drawinglayer::primitive2d::Primitive2DSequence
getPrimitive2DSequenceHierarchy(DisplayInfo rDisplayInfo) const;
+
+private:
+virtual bool isPrimitiveVisibleOnAnyLayer(const SetOfByte
aLayers) const;
};
} // end of namespace contact
} // end of namespace sdr
diff --git a/svx/inc/svx/sdr/contact/viewobjectcontactofsdrobj.hxx
b/svx/inc/svx/sdr/contact/viewobjectcontactofsdrobj.hxx
index e366bbd..e5b1f13 100644
--- a/svx/inc/svx/sdr/contact/viewobjectcontactofsdrobj.hxx
+++ b/svx/inc/svx/sdr/contact/viewobjectcontactofsdrobj.hxx
@@ -34,6 +34,7 @@
//
// predeclarations
class SdrObject;
+class SetOfByte;
//
@@ -43,6 +44,14 @@
{
class SVX_DLLPUBLIC ViewObjectContactOfSdrObj : public
ViewObjectContact
{
+/** Test whether the primitive is visible on any layer from @c
aLayers
+
+This should be overriden by ViewObjectContacts of SDR classes
+that have subparts which can be on different layers (that is,
+SdrObjGroup .-)
+ */
+virtual bool isPrimitiveVisibleOnAnyLayer(const SetOfByte
aLayers) const;
+
protected:
const SdrObject getSdrObject() const;
diff --git a/svx/source/sdr/contact/viewobjectcontactofgroup.cxx
b/svx/source/sdr/contact/viewobjectcontactofgroup.cxx
index 3f47bb4..ee2c630 100644
--- a/svx/source/sdr/contact/viewobjectcontactofgroup.cxx
+++ b/svx/source/sdr/contact/viewobjectcontactofgroup.cxx
@@ -34,6 +34,7 @@
#include drawinglayer/primitive2d/groupprimitive2d.hxx
#include basegfx/tools/canvastools.hxx
#include svx/sdr/contact/viewcontact.hxx
+#include svx/svdobj.hxx
//
@@ -107,6 +108,14 @@
}
return xRetval;
}
+
+bool ViewObjectContactOfGroup::isPrimitiveVisibleOnAnyLayer(const
SetOfByte aLayers) const
+{
+SetOfByte aObjectLayers;
+getSdrObject().getMergedHierarchyLayerSet(aObjectLayers);
+aObjectLayers = aLayers;
+return !aObjectLayers.IsEmpty();
+}
} // end of namespace contact
} // end of namespace sdr
diff --git a/svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx
b/svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx
index d9a285f..b1e9fa9 100644
--- a/svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx
+++ b/svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx
@@ -57,12 +57,17 @@
{
}
+bool ViewObjectContactOfSdrObj::isPrimitiveVisibleOnAnyLayer(const
SetOfByte aLayers) const
+{
+return aLayers.IsSet(getSdrObject().GetLayer());
+}
+
bool ViewObjectContactOfSdrObj::isPrimitiveVisible(const DisplayInfo
rDisplayInfo) const
{
const SdrObject rObject = getSdrObject();
// Test layer visibility
-if(!rDisplayInfo.GetProcessLayers().IsSet(rObject.GetLayer()))
+if(!isPrimitiveVisibleOnAnyLayer(rDisplayInfo.GetProcessLayers()))
{
return false;
}
--
To view, visit https://gerrit.libreoffice.org/2964
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ef75544a26817154642185864cafd4e6734fa38
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6-6
Gerrit-Owner: David Tardon dtar...@redhat.com
___
LibreOffice
[PATCH] remove unused member maHelpFile and its getter/setter
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2965
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/65/2965/1
remove unused member maHelpFile and its getter/setter
Change-Id: I97b53be0a6110c6ca736de657cba48baa0445a12
---
M vcl/inc/vcl/help.hxx
1 file changed, 0 insertions(+), 6 deletions(-)
diff --git a/vcl/inc/vcl/help.hxx b/vcl/inc/vcl/help.hxx
index 2ee33c5..b74d802 100644
--- a/vcl/inc/vcl/help.hxx
+++ b/vcl/inc/vcl/help.hxx
@@ -59,15 +59,9 @@
class VCL_DLLPUBLIC Help
{
-private:
-OUStringmaHelpFile;
-
public:
Help();
virtual ~Help();
-
-voidSetHelpFile( const OUString rFileName ) { maHelpFile
= rFileName; }
-const OUString GetHelpFile() const { return maHelpFile; }
virtual sal_BoolStart( const OUString rHelpId, const Window* pWindow
);
virtual sal_BoolSearchKeyword( const OUString rKeyWord );
--
To view, visit https://gerrit.libreoffice.org/2965
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I97b53be0a6110c6ca736de657cba48baa0445a12
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: mhofmann bor...@web.de
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 2 commits - bridges/Library_cpp_uno.mk Makefile.in solenv/gbuild
Makefile.in |6 -- bridges/Library_cpp_uno.mk |3 ++- solenv/gbuild/platform/com_GCC_class.mk |1 + 3 files changed, 7 insertions(+), 3 deletions(-) New commits: commit d72b4106e2b1525f76ea4d91458204aeec8b408e Author: Peter Foley pefol...@verizon.net Date: Sun Mar 24 10:20:09 2013 -0400 make bridges work with clang on x64 linux Change-Id: Idf5c7586e375f0321c765d165f9698403b7a7daf diff --git a/bridges/Library_cpp_uno.mk b/bridges/Library_cpp_uno.mk index 12275f5..987517d 100644 --- a/bridges/Library_cpp_uno.mk +++ b/bridges/Library_cpp_uno.mk @@ -130,7 +130,8 @@ else ifeq ($(CPU),X) ifneq ($(filter DRAGONFLY FREEBSD LINUX NETBSD OPENBSD,$(OS)),) bridges_SELECTED_BRIDGE := gcc3_linux_x86-64 bridge_asm_objects := call -bridge_exception_objects := abi callvirtualmethod cpp2uno except uno2cpp +bridge_noopt_objects := callvirtualmethod +bridge_exception_objects := abi cpp2uno except uno2cpp else ifeq ($(OS),MACOSX) bridges_SELECTED_BRIDGE := gcc3_macosx_x86-64 bridge_exception_objects := abi call callvirtualmethod cpp2uno except uno2cpp diff --git a/solenv/gbuild/platform/com_GCC_class.mk b/solenv/gbuild/platform/com_GCC_class.mk index 6d068d7..c8a8d33 100644 --- a/solenv/gbuild/platform/com_GCC_class.mk +++ b/solenv/gbuild/platform/com_GCC_class.mk @@ -44,6 +44,7 @@ $(call gb_Output_announce,$(2),$(true),ASM,3) $(call gb_Helper_abbreviate_dirs,\ mkdir -p $(dir $(1)) $(dir $(4)) cd $(SRCDIR) \ $(gb_CC) \ + -x assembler-with-cpp \ $(gb_LTOFLAGS) \ $(gb_AFLAGS) \ -c $(3) \ commit 96f943045af9068d1e6b5453836eccdbc140e677 Author: Peter Foley pefol...@verizon.net Date: Sun Mar 24 09:34:55 2013 -0400 match gbuild rules that contain a slash Change-Id: Id50d89114a7569a9c7429204ce73217cf7a4c131 diff --git a/Makefile.in b/Makefile.in index 0ae475a..626c726 100644 --- a/Makefile.in +++ b/Makefile.in @@ -88,7 +88,9 @@ define gbuild_modules_rules $(foreach m,$(1),$(call gbuild_module_rules,$(m))) endef -$(eval $(call gbuild_modules_rules,$(filter-out Module%,$(subst /, ,$(subst $(SRCDIR)/,,$(wildcard $(SRCDIR)/*/Module_*.mk)) +gbuild_modules := $(filter-out Module%,$(subst /, ,$(subst $(SRCDIR)/,,$(wildcard $(SRCDIR)/*/Module_*.mk + +$(eval $(call gbuild_modules_rules,$(gbuild_modules))) gbuild_TARGETS := AllLangHelp \ AllLangResTarget \ @@ -124,7 +126,7 @@ gbuild_TARGETS := AllLangHelp \ WinResTarget \ Zip # build a generic gbuild target -$(foreach target,$(gbuild_TARGETS),$(target)_%): +$(foreach target,$(gbuild_TARGETS),$(target)_% $(foreach module,$(gbuild_modules),$(target)_$(module)/%)): $(GNUMAKE) -j $(PARALLELISM) $(GMAKE_OPTIONS) -f $(SRCDIR)/Makefile.gbuild $@ # ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PATCH] upgrade icu to 51.1
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2953 to look at the new patch set (#5). Change subject: upgrade icu to 51.1 .. upgrade icu to 51.1 Change-Id: I1c0d5ca4b2f88ca48225fcdbeb978f27fa91f7a6 --- M RepositoryExternal.mk M config_host.mk.in M configure.ac M download.lst M icu/ExternalPackage_icu.mk M icu/UnpackedTarball_icu.mk D icu/icu4c-CVE-2013-0900_umutex.patch D icu/icu4c-bsd.patch D icu/icu4c-solarisgcc.patch D icu/icu4c.9313.cygwin.patch D icu/icu4c.9737.CVE-2013-0900_changesets_32865_32908.patch R icu/icu5c-aix.patch R icu/icu5c-android.patch R icu/icu5c-buffer-overflow.patch R icu/icu5c-build.patch R icu/icu5c-macosx.patch R icu/icu5c-mkdir.patch R icu/icu5c-rpath.patch A icu/icu5c-solarisgcc.patch R icu/icu5c-warnings.patch R icu/icu5c-wchar_t.patch R icu/icu5c.7601.Indic-ccmp.patch R icu/icu5c.8198.revert.icu5431.patch R icu/icu5c.9948.mlym-crash.patch M libcdr/ExternalProject_libcdr.mk M libmspub/ExternalProject_libmspub.mk M scp2/InstallModule_ooo.mk M scp2/source/ooo/file_library_ooo.scp M vcl/generic/glyphs/gcach_layout.cxx M writerfilter/Library_writerfilter.mk 30 files changed, 61 insertions(+), 630 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/53/2953/5 -- To view, visit https://gerrit.libreoffice.org/2953 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1c0d5ca4b2f88ca48225fcdbeb978f27fa91f7a6 Gerrit-PatchSet: 5 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Peter Foley pefol...@verizon.net Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org Gerrit-Reviewer: Mathias M m...@gmx.fr Gerrit-Reviewer: Peter Foley pefol...@verizon.net Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] fdo#39468 Translate German comments - vcl/source/control/
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2966
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/66/2966/1
fdo#39468 Translate German comments - vcl/source/control/
Change-Id: I736cf155e252293ed571cd44a6a395b15c4bf576
FYI: there is some code duplication noticeable between slider and scrbar
---
M vcl/source/control/longcurr.cxx
M vcl/source/control/lstbox.cxx
M vcl/source/control/menubtn.cxx
M vcl/source/control/morebtn.cxx
M vcl/source/control/prgsbar.cxx
M vcl/source/control/scrbar.cxx
M vcl/source/control/slider.cxx
M vcl/source/control/spinfld.cxx
M vcl/source/control/tabctrl.cxx
9 files changed, 100 insertions(+), 111 deletions(-)
diff --git a/vcl/source/control/longcurr.cxx b/vcl/source/control/longcurr.cxx
index d84b404..f7c4c90 100644
--- a/vcl/source/control/longcurr.cxx
+++ b/vcl/source/control/longcurr.cxx
@@ -137,11 +137,11 @@
sal_uInt16 nDecPos;
sal_BoolbNegative = sal_False;
-// Reaktion auf leeren String
+// empty string
if ( !rStr.Len() )
return sal_False;
-// Fuehrende und nachfolgende Leerzeichen entfernen
+// trim leading or trailing spaces
aStr = string::strip(aStr, ' ');
// Position des Dezimalpunktes suchen
@@ -155,7 +155,7 @@
else
aStr1 = aStr;
-// Negativ ?
+// negativ ?
if ( bCurrency )
{
if ( (aStr.GetChar( 0 ) == '(') (aStr.GetChar( aStr.Len()-1 ) ==
')') )
@@ -198,7 +198,7 @@
bNegative = sal_True;
}
-// Alle unerwuenschten Zeichen rauswerfen
+// delete unwanted characters
for (xub_StrLen i=0; i aStr1.Len(); )
{
if ( (aStr1.GetChar( i ) = '0') (aStr1.GetChar( i ) = '9') )
@@ -222,7 +222,7 @@
if ( bNegative )
aStr1.Insert( '-', 0 );
-// Nachkommateil zurechtstutzen und dabei runden
+// trim round digits
bool bRound = false;
if (aStr2.getLength() nDecDigits)
{
@@ -236,7 +236,7 @@
aStr = aStr1;
aStr += aStr2.makeStringAndClear();
-// Bereichsueberpruefung
+// check range
BigInt nValue( aStr );
if ( bRound )
{
@@ -256,8 +256,7 @@
static sal_Bool ImplLongCurrencyProcessKeyInput( Edit* pEdit, const KeyEvent
rKEvt,
sal_Bool, sal_Bool
bUseThousandSep, const LocaleDataWrapper rLocaleDataWrapper )
{
-// Es gibt hier kein sinnvolles StrictFormat, also alle
-// Zeichen erlauben
+// there is no suitable StrictFormat, thus allow all characters
return ImplNumericProcessKeyInput( pEdit, rKEvt, sal_False,
bUseThousandSep, rLocaleDataWrapper );
}
@@ -266,7 +265,7 @@
inline sal_Bool ImplLongCurrencyGetValue( const XubString rStr, BigInt
rValue,
sal_uInt16 nDecDigits, const
LocaleDataWrapper rLocaleDataWrapper )
{
-// Zahlenwert holen
+// get value
return ImplNumericGetValue( rStr, rValue, nDecDigits, rLocaleDataWrapper,
sal_True );
}
@@ -468,7 +467,7 @@
void LongCurrencyFormatter::SetDecimalDigits( sal_uInt16 nDigits )
{
-// DBG_ASSERT( nDigits 10, LongCurrency duerfen nur maximal 9
Nachkommastellen haben );
+// DBG_ASSERT( nDigits 10, LongCurrency may have no more than 9 decimal
places );
if ( nDigits 9 )
nDigits = 9;
diff --git a/vcl/source/control/lstbox.cxx b/vcl/source/control/lstbox.cxx
index cb15f0a..6822bcd 100644
--- a/vcl/source/control/lstbox.cxx
+++ b/vcl/source/control/lstbox.cxx
@@ -75,8 +75,8 @@
//#109201#
ImplCallEventListeners( VCLEVENT_OBJECT_DYING );
-// Beim zerstoeren des FloatWins macht TH ein GrabFocus auf den Parent,
-// also diese ListBox = PreNotify()...
+// When destroying the FloatWin, TH does a GrabFocus of the parent,
+// thus this ListBox = PreNotify()...
ImplListBox *pImplLB = mpImplLB;
mpImplLB = NULL;
delete pImplLB;
@@ -208,7 +208,7 @@
long nId = ReadLongRes();
if( nId )
-SetEntryData( nPos, (void *)nId ); // ID als UserData
+SetEntryData( nPos, (void *)nId ); // ID as UserData
}
if( nSelPos nNumber )
@@ -272,7 +272,7 @@
const ImplEntryList* pEntryList = mpImplLB-GetEntryList();
if ( pEntryList-IsEntryPosSelected( nChanged ) )
{
-// Sollte mal ein ImplPaintEntry werden...
+// was supposed to become a ImplPaintEntry...
if ( nChanged pEntryList-GetMRUCount() )
nChanged = pEntryList-FindEntry( pEntryList-GetEntryText(
nChanged ) );
mpImplWin-SetItemPos( nChanged );
@@ -414,7 +414,7 @@
}
}
-// Inhalt
+// contents
if ( ( nFlags WINDOW_DRAW_MONO ) || ( eOutDevType == OUTDEV_PRINTER ) )
{
pDev-SetTextColor( Color( COL_BLACK ) );
@@ -461,7 +461,8 @@
{
Rectangle aClip( aPos, aSize );
if ( nTextHeight aSize.Height() )
-
[Libreoffice-commits] core.git: dbaccess/source extras/source
dbaccess/source/ui/control/opendoccontrols.cxx | 27 +
dbaccess/source/ui/dlg/adminpages.cxx | 13
dbaccess/source/ui/dlg/adminpages.hxx |1
dbaccess/source/ui/inc/opendoccontrols.hxx |2 +
extras/source/glade/libreoffice-catalog.xml.in |8 +++
5 files changed, 51 insertions(+)
New commits:
commit 379988085239fdd93dd87870bcc4966aeaa9b396
Author: Mathias Hasselmann math...@openismus.com
Date: Thu Mar 21 07:58:31 2013 +0100
Add builder support for a few dbaui controls
This adds the needed methods and catalog definitions for
dbaui::OGenericAdministrationPage, dbaui::OpenDocumentButton
and dbaui::OpenDocumentListBox.
Change-Id: I5b883c39f1cb9623c357e5ebec1632816547ff03
Reviewed-on: https://gerrit.libreoffice.org/2886
Reviewed-by: Lionel Elie Mamane lio...@mamane.lu
Reviewed-by: Fridrich Strba fridr...@documentfoundation.org
Tested-by: Fridrich Strba fridr...@documentfoundation.org
diff --git a/dbaccess/source/ui/control/opendoccontrols.cxx
b/dbaccess/source/ui/control/opendoccontrols.cxx
index 1ae7fe7..907840e 100644
--- a/dbaccess/source/ui/control/opendoccontrols.cxx
+++ b/dbaccess/source/ui/control/opendoccontrols.cxx
@@ -38,6 +38,7 @@
#include tools/urlobj.hxx
#include svl/filenotation.hxx
#include osl/diagnose.h
+#include vcl/builder.hxx
//
namespace dbaui
@@ -168,6 +169,19 @@ namespace dbaui
}
//
+OpenDocumentButton::OpenDocumentButton( Window* _pParent, const sal_Char*
_pAsciiModuleName )
+:PushButton( _pParent )
+{
+impl_init( _pAsciiModuleName );
+}
+
+//
+extern C SAL_DLLPUBLIC_EXPORT Window* SAL_CALL makeOpenDocumentButton(
Window *pParent, VclBuilder::stringmap )
+{
+return new OpenDocumentButton( pParent,
com.sun.star.sdb.OfficeDatabaseDocument );
+}
+
+//
void OpenDocumentButton::impl_init( const sal_Char* _pAsciiModuleName )
{
OSL_ENSURE( _pAsciiModuleName, OpenDocumentButton::impl_init: invalid
module name! );
@@ -198,6 +212,19 @@ namespace dbaui
}
//
+OpenDocumentListBox::OpenDocumentListBox( Window* _pParent, const
sal_Char* _pAsciiModuleName )
+:ListBox( _pParent, WB_BORDER | WB_DROPDOWN )
+{
+impl_init( _pAsciiModuleName );
+}
+
+//
+extern C SAL_DLLPUBLIC_EXPORT Window* SAL_CALL makeOpenDocumentListBox(
Window *pParent, VclBuilder::stringmap )
+{
+return new OpenDocumentListBox( pParent,
com.sun.star.sdb.OfficeDatabaseDocument );
+}
+
+//
void OpenDocumentListBox::impl_init( const sal_Char* _pAsciiModuleName )
{
OSL_ENSURE( _pAsciiModuleName, OpenDocumentListBox::impl_init:
invalid module name! );
diff --git a/dbaccess/source/ui/dlg/adminpages.cxx
b/dbaccess/source/ui/dlg/adminpages.cxx
index 46840d8..27ce056 100644
--- a/dbaccess/source/ui/dlg/adminpages.cxx
+++ b/dbaccess/source/ui/dlg/adminpages.cxx
@@ -78,6 +78,19 @@ namespace dbaui
}
//-
+OGenericAdministrationPage::OGenericAdministrationPage(Window* _pParent,
const rtl::OString _rId, const rtl::OUString _rUIXMLDescription, const
SfxItemSet _rAttrSet)
+:SfxTabPage(_pParent, _rId, _rUIXMLDescription, _rAttrSet)
+,m_abEnableRoadmap(sal_False)
+,m_pAdminDialog(NULL)
+,m_pItemSetHelper(NULL)
+,m_pFT_HeaderText(NULL)
+{
+DBG_CTOR(OGenericAdministrationPage,NULL);
+
+SetExchangeSupport(sal_True);
+}
+
+//-
OGenericAdministrationPage::~OGenericAdministrationPage()
{
DELETEZ(m_pFT_HeaderText);
diff --git a/dbaccess/source/ui/dlg/adminpages.hxx
b/dbaccess/source/ui/dlg/adminpages.hxx
index 7e5dcdc..e9e11c8 100644
--- a/dbaccess/source/ui/dlg/adminpages.hxx
+++ b/dbaccess/source/ui/dlg/adminpages.hxx
@@ -109,6 +109,7 @@ namespace dbaui
m_xORB;
public:
OGenericAdministrationPage(Window* _pParent, const ResId _rId, const
SfxItemSet _rAttrSet);
+OGenericAdministrationPage(Window* _pParent, const rtl::OString _rId,
const rtl::OUString _rUIXMLDescription, const SfxItemSet _rAttrSet);
~OGenericAdministrationPage();
/// set a handler which gets called every time something on the page
has been modified
diff --git
[PUSHED] Add builder support for a few dbaui controls
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2886 Approvals: Lionel Elie Mamane: Looks good to me, but someone else must approve Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2886 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b883c39f1cb9623c357e5ebec1632816547ff03 Gerrit-PatchSet: 4 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Mathias Hasselmann math...@openismus.com Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org Gerrit-Reviewer: Lionel Elie Mamane lio...@mamane.lu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - svx/inc svx/source
svx/inc/svx/sdr/contact/viewobjectcontactofgroup.hxx |3 +++
svx/inc/svx/sdr/contact/viewobjectcontactofsdrobj.hxx |9 +
svx/source/sdr/contact/viewobjectcontactofgroup.cxx |9 +
svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx |7 ++-
4 files changed, 27 insertions(+), 1 deletion(-)
New commits:
commit 7016708ef411a7112c2acc504441ef7c10f570cc
Author: David Tardon dtar...@redhat.com
Date: Sun Mar 24 14:08:14 2013 +0100
fdo#62617 display groups on multiple layers correctly
It is possible to group objects from different layers, so it is an error
to rely on layer ID when checking visibility of a group. This problem
was partially obscured by the fact that SdrObjGroup::GetLayer() returns
0 if its subobjects are on different layers and 0 is a valid layer ID.
Change-Id: I0ef75544a26817154642185864cafd4e6734fa38
(cherry picked from commit 09d4525b11f396a68ca7c5cbb1ae3462db40c77c)
Reviewed-on: https://gerrit.libreoffice.org/2962
Reviewed-by: Fridrich Strba fridr...@documentfoundation.org
Tested-by: Fridrich Strba fridr...@documentfoundation.org
diff --git a/svx/inc/svx/sdr/contact/viewobjectcontactofgroup.hxx
b/svx/inc/svx/sdr/contact/viewobjectcontactofgroup.hxx
index b925889..fda5610 100644
--- a/svx/inc/svx/sdr/contact/viewobjectcontactofgroup.hxx
+++ b/svx/inc/svx/sdr/contact/viewobjectcontactofgroup.hxx
@@ -40,6 +40,9 @@ namespace sdr
// This method recursively paints the draw hierarchy.
virtual drawinglayer::primitive2d::Primitive2DSequence
getPrimitive2DSequenceHierarchy(DisplayInfo rDisplayInfo) const;
+
+private:
+virtual bool isPrimitiveVisibleOnAnyLayer(const SetOfByte
aLayers) const;
};
} // end of namespace contact
} // end of namespace sdr
diff --git a/svx/inc/svx/sdr/contact/viewobjectcontactofsdrobj.hxx
b/svx/inc/svx/sdr/contact/viewobjectcontactofsdrobj.hxx
index d7609bd..e038442 100644
--- a/svx/inc/svx/sdr/contact/viewobjectcontactofsdrobj.hxx
+++ b/svx/inc/svx/sdr/contact/viewobjectcontactofsdrobj.hxx
@@ -25,6 +25,7 @@
//
// predeclarations
class SdrObject;
+class SetOfByte;
//
@@ -34,6 +35,14 @@ namespace sdr
{
class SVX_DLLPUBLIC ViewObjectContactOfSdrObj : public
ViewObjectContact
{
+/** Test whether the primitive is visible on any layer from @c
aLayers
+
+This should be overriden by ViewObjectContacts of SDR classes
+that have subparts which can be on different layers (that is,
+SdrObjGroup .-)
+ */
+virtual bool isPrimitiveVisibleOnAnyLayer(const SetOfByte
aLayers) const;
+
protected:
const SdrObject getSdrObject() const;
diff --git a/svx/source/sdr/contact/viewobjectcontactofgroup.cxx
b/svx/source/sdr/contact/viewobjectcontactofgroup.cxx
index cdd21db..724b77e 100644
--- a/svx/source/sdr/contact/viewobjectcontactofgroup.cxx
+++ b/svx/source/sdr/contact/viewobjectcontactofgroup.cxx
@@ -25,6 +25,7 @@
#include drawinglayer/primitive2d/groupprimitive2d.hxx
#include basegfx/tools/canvastools.hxx
#include svx/sdr/contact/viewcontact.hxx
+#include svx/svdobj.hxx
//
@@ -98,6 +99,14 @@ namespace sdr
}
return xRetval;
}
+
+bool ViewObjectContactOfGroup::isPrimitiveVisibleOnAnyLayer(const
SetOfByte aLayers) const
+{
+SetOfByte aObjectLayers;
+getSdrObject().getMergedHierarchyLayerSet(aObjectLayers);
+aObjectLayers = aLayers;
+return !aObjectLayers.IsEmpty();
+}
} // end of namespace contact
} // end of namespace sdr
diff --git a/svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx
b/svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx
index e184bde..77c97cd 100644
--- a/svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx
+++ b/svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx
@@ -48,12 +48,17 @@ namespace sdr
{
}
+bool ViewObjectContactOfSdrObj::isPrimitiveVisibleOnAnyLayer(const
SetOfByte aLayers) const
+{
+return aLayers.IsSet(getSdrObject().GetLayer());
+}
+
bool ViewObjectContactOfSdrObj::isPrimitiveVisible(const DisplayInfo
rDisplayInfo) const
{
const SdrObject rObject = getSdrObject();
// Test layer visibility
-if(!rDisplayInfo.GetProcessLayers().IsSet(rObject.GetLayer()))
+if(!isPrimitiveVisibleOnAnyLayer(rDisplayInfo.GetProcessLayers()))
{
return false;
}
___
Libreoffice-commits mailing list
[PUSHED libreoffice-4-0] fdo#62617 display groups on multiple layers correctly
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2962 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2962 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ef75544a26817154642185864cafd4e6734fa38 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: David Tardon dtar...@redhat.com Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: basic/source
basic/source/runtime/methods.cxx |7 ---
basic/source/runtime/rtlproto.hxx |1 -
basic/source/runtime/stdobj.cxx |2 --
3 files changed, 10 deletions(-)
New commits:
commit 7f4a34e3145673681c0ff3aee8de8c440e790ece
Author: Thomas Arnhold tho...@arnhold.org
Date: Thu Mar 21 19:06:44 2013 +0100
basic: Remove non working AboutStarBasic
The content of this function was commented out since the first import. So
as it does nothing remove it.
Change-Id: Ia46674f7bdc12e80d61a8142697e875f5c58f482
Reviewed-on: https://gerrit.libreoffice.org/2899
Reviewed-by: Chris Sherlock chris.sherloc...@gmail.com
Reviewed-by: Fridrich Strba fridr...@documentfoundation.org
Tested-by: Fridrich Strba fridr...@documentfoundation.org
diff --git a/basic/source/runtime/methods.cxx b/basic/source/runtime/methods.cxx
index fefb9d9..a7ad6d5 100644
--- a/basic/source/runtime/methods.cxx
+++ b/basic/source/runtime/methods.cxx
@@ -4341,13 +4341,6 @@ RTLFUNC(SavePicture)
//-
-RTLFUNC(AboutStarBasic)
-{
-(void)pBasic;
-(void)bWrite;
-(void)rPar;
-}
-
RTLFUNC(MsgBox)
{
(void)pBasic;
diff --git a/basic/source/runtime/rtlproto.hxx
b/basic/source/runtime/rtlproto.hxx
index b13d664..ccf0a3b 100644
--- a/basic/source/runtime/rtlproto.hxx
+++ b/basic/source/runtime/rtlproto.hxx
@@ -275,7 +275,6 @@ extern RTLFUNC(Beep);
extern RTLFUNC(Load);
extern RTLFUNC(Unload);
-extern RTLFUNC(AboutStarBasic);
extern RTLFUNC(LoadPicture);
extern RTLFUNC(SavePicture);
diff --git a/basic/source/runtime/stdobj.cxx b/basic/source/runtime/stdobj.cxx
index 2a69f44..1e882c2 100644
--- a/basic/source/runtime/stdobj.cxx
+++ b/basic/source/runtime/stdobj.cxx
@@ -80,8 +80,6 @@ struct StringHashCode
static Methods aMethods[] = {
-{ AboutStarBasic, SbxNULL, 1 | _FUNCTION, RTLNAME(AboutStarBasic),0 },
- { Name, SbxSTRING, 0,NULL,0 },
{ Abs,SbxDOUBLE,1 | _FUNCTION, RTLNAME(Abs),0 },
{ number, SbxDOUBLE, 0,NULL,0 },
{ Array, SbxOBJECT,_FUNCTION, RTLNAME(Array),0 },
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PUSHED] basic: Remove non working AboutStarBasic
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2899 Approvals: Chris Sherlock: Looks good to me, but someone else must approve Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2899 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia46674f7bdc12e80d61a8142697e875f5c58f482 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold tho...@arnhold.org Gerrit-Reviewer: Chris Sherlock chris.sherloc...@gmail.com Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Build error - testFdo60915
Same content as Rodolfo: export SYSTEM_ICU=NO 2013/3/22 Rodolfo rodolf...@gmail.com I have the same issue here. Yes, timezone is America/Sao Paulo. But, aside the bug report, I'm a Debian-Wheezy user. About ./config_host.mk contains: export SYSTEM_ICU=NO =/ Att, Rodolfo 2013/3/22 Eike Rathke er...@redhat.com: Hi Marcos, On Friday, 2013-03-22 17:01:12 -0300, Marcos Souza wrote: AHuahUAHauhAUAHU Brazil makes me laught in LO too T.T Glad you had a good laugh ;-) Yes this is my timezone Ok, could you please tell me which ICU library version you use * the internally provided 49.1.1, ./config_host.mk contains SYSTEM_ICU=NO in this case * a system one, which version? ./config_host.mk contains SYSTEM_ICU=YES in this case The version numbers are in ./config_host.mk variables ICU_MAJOR, ICU_MINOR and ICU_MICRO Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. New GnuPG key 0x65632D3A : 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A Old GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD Support the FSFE, care about Free Software! https://fsfe.org/support/?erack ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Att, Marcos Paulo de Souza Acadêmico de Ciencia da Computação - FURB - SC Github: https://github.com/marcosps/ Uma vida sem desafios é uma vida sem razão A life without challenges, is a non reason life ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Use OUString and sal_Int32 in GetTextArray() and ImplLayout(...
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2967
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/2967/1
Use OUString and sal_Int32 in GetTextArray() and ImplLayout()
Change-Id: I2c1e5b7d53c0d78f2ccf9ac317a7ff40298cd68d
---
M vcl/inc/vcl/outdev.hxx
M vcl/source/gdi/outdev3.cxx
2 files changed, 26 insertions(+), 41 deletions(-)
diff --git a/vcl/inc/vcl/outdev.hxx b/vcl/inc/vcl/outdev.hxx
index 5f00757..44a5979 100644
--- a/vcl/inc/vcl/outdev.hxx
+++ b/vcl/inc/vcl/outdev.hxx
@@ -378,10 +378,9 @@
SAL_DLLPRIVATE bool ImplSelectClipRegion( const Region,
SalGraphics* pGraphics = NULL );
SAL_DLLPRIVATE void ImplSetClipRegion( const Region* pRegion );
-SAL_DLLPRIVATE SalLayout* ImplLayout( const String, xub_StrLen nIndex,
-xub_StrLen nLen, const Point
rLogicPos = Point(0,0),
-long nLogicWidth=0, const
sal_Int32* pLogicDXArray=NULL,
-bool bFilter = false ) const;
+SAL_DLLPRIVATE SalLayout* ImplLayout( const OUString, sal_Int32 nIndex,
sal_Int32 nLen,
+const Point rLogicPos =
Point(0,0), long nLogicWidth=0,
+const sal_Int32*
pLogicDXArray=NULL, bool bFilter = false ) const;
SAL_DLLPRIVATE ImplLayoutArgs ImplPrepareLayoutArgs( OUString, const
sal_Int32 nIndex, const sal_Int32 nLen,
long nPixelWidth, const sal_Int32*
pPixelDXArray ) const;
SAL_DLLPRIVATE SalLayout* ImplGlyphFallbackLayout( SalLayout*,
ImplLayoutArgs ) const;
@@ -583,9 +582,8 @@
const sal_Int32* pDXAry = NULL,
xub_StrLen nIndex = 0,
xub_StrLen nLen = STRING_LEN );
-longGetTextArray( const XubString rStr, sal_Int32* pDXAry
= NULL,
- xub_StrLen nIndex = 0,
- xub_StrLen nLen = STRING_LEN ) const;
+longGetTextArray( const OUString rStr, sal_Int32* pDXAry
= NULL,
+ sal_Int32 nIndex = 0, sal_Int32 nLen =
-1 ) const;
boolGetCaretPositions( const XubString, sal_Int32*
pCaretXArray,
xub_StrLen nIndex, xub_StrLen nLen,
sal_Int32* pDXAry = NULL, long nWidth =
0,
diff --git a/vcl/source/gdi/outdev3.cxx b/vcl/source/gdi/outdev3.cxx
index 1fedcbd..56d1d4a 100644
--- a/vcl/source/gdi/outdev3.cxx
+++ b/vcl/source/gdi/outdev3.cxx
@@ -5475,7 +5475,11 @@
{
DBG_CHKTHIS( OutputDevice, ImplDbgCheckOutputDevice );
-long nWidth = GetTextArray( rStr, NULL, nIndex, nLen );
+sal_Int32 nLen2 = (nLen == STRING_LEN) ? -1 : nLen; // only needed until
nLen is sal_Int32
+sal_Int32 nIndex2 = nIndex;// ditto
+OUString aTmpStr(rStr);
+long nWidth = GetTextArray( aTmpStr, NULL, nIndex2, nLen2 );
+
return nWidth;
}
@@ -5532,15 +5536,17 @@
mpAlphaVDev-DrawTextArray( rStartPt, rStr, pDXAry, nIndex, nLen );
}
-long OutputDevice::GetTextArray( const String rStr, sal_Int32* pDXAry,
- xub_StrLen nIndex, xub_StrLen nLen ) const
+long OutputDevice::GetTextArray( const OUString rStr, sal_Int32* pDXAry,
+ sal_Int32 nIndex, sal_Int32 nLen ) const
{
+// MEM: default nLen = STRING_LENGTH
DBG_CHKTHIS( OutputDevice, ImplDbgCheckOutputDevice );
-if( nIndex = rStr.Len() )
+if( nIndex = rStr.getLength() )
return 0;
-if( (sal_uLong)nIndex+nLen = rStr.Len() )
-nLen = rStr.Len() - nIndex;
+
+if( nLen 0 || nIndex+nLen = rStr.getLength() )
+nLen = rStr.getLength() - nIndex;
// do layout
SalLayout* pSalLayout = ImplLayout( rStr, nIndex, nLen );
@@ -5776,12 +5782,8 @@
return aLayoutArgs;
}
-SalLayout* OutputDevice::ImplLayout( const String rOrigStr,
- xub_StrLen nMinIndex,
- xub_StrLen nLen,
- const Point rLogicalPos,
- long nLogicalWidth,
- const sal_Int32* pDXArray,
+SalLayout* OutputDevice::ImplLayout( const OUString rOrigStr, sal_Int32
nMinIndex, sal_Int32 nLen,
+ const Point rLogicalPos, long
nLogicalWidth, const sal_Int32* pDXArray,
bool bFilter ) const
{
// we need a graphics
@@ -5797,28 +5799,21 @@
ImplInitFont();
// check string index and length
-if( (unsigned)nMinIndex + nLen rOrigStr.Len() )
+if( nMinIndex + nLen rOrigStr.getLength() )
[ABANDONED] [draft] use pragma once
Thomas Arnhold has abandoned this change. Change subject: [draft] use pragma once .. Patch Set 3: Abandoned Not as easy as it seems. Clashes with Windows headers at least. Why ever... -- To view, visit https://gerrit.libreoffice.org/2875 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I81e28f0241d35e13381c85cef0327d45c7f9b2c1 Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold tho...@arnhold.org Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sd/source
sd/source/core/sdpage.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f9d0bfe98d631fb0a27f2827188ce4af6b755d3c Author: Julien Nabet serval2...@yahoo.fr Date: Sun Mar 24 17:53:17 2013 +0100 coverity#704289 Logically dead code Change-Id: I84491fc5947364191c14efa57fd106c9a57bd0be diff --git a/sd/source/core/sdpage.cxx b/sd/source/core/sdpage.cxx index 5c4337f..688d093 100644 --- a/sd/source/core/sdpage.cxx +++ b/sd/source/core/sdpage.cxx @@ -2033,7 +2033,7 @@ SdrObject* convertPresentationObjectImpl( SdPage rPage, SdrObject* pSourceObj, if( !pModel || !pSourceObj ) return pSourceObj; -::svl::IUndoManager* pUndoManager = pModel ? static_castSdDrawDocument*(pModel)-GetUndoManager() : 0; +::svl::IUndoManager* pUndoManager = static_castSdDrawDocument*(pModel)-GetUndoManager(); const bool bUndo = pUndoManager pUndoManager-IsInListAction() rPage.IsInserted(); SdrObject* pNewObj = pSourceObj; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sd/source
sd/source/ui/dlg/tpoption.cxx |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
New commits:
commit 8b08aceb3d254909f2ee38f8c3c72162e3717717
Author: Julien Nabet serval2...@yahoo.fr
Date: Sun Mar 24 18:44:07 2013 +0100
coverity#704293 Logically dead code
Change-Id: I1e2ad99d19b647607805c7447f5f81f853d411a5
diff --git a/sd/source/ui/dlg/tpoption.cxx b/sd/source/ui/dlg/tpoption.cxx
index e777320..aee8b26 100644
--- a/sd/source/ui/dlg/tpoption.cxx
+++ b/sd/source/ui/dlg/tpoption.cxx
@@ -77,7 +77,6 @@ SdTpOptionsSnap::~SdTpOptionsSnap()
sal_Bool SdTpOptionsSnap::FillItemSet( SfxItemSet rAttrs )
{
SvxGridTabPage::FillItemSet(rAttrs);
-SdOptionsSnapItem* pOptsItem = NULL;
SdOptionsSnapItem aOptsItem( ATTR_OPTIONS_SNAP );
aOptsItem.GetOptionsSnap().SetSnapHelplines( aCbxSnapHelplines.IsChecked()
);
@@ -91,8 +90,7 @@ sal_Bool SdTpOptionsSnap::FillItemSet( SfxItemSet rAttrs )
aOptsItem.GetOptionsSnap().SetAngle( (sal_Int16) aMtrFldAngle.GetValue() );
aOptsItem.GetOptionsSnap().SetEliminatePolyPointLimitAngle( (sal_Int16)
aMtrFldBezAngle.GetValue() );
-if( pOptsItem == NULL || !(aOptsItem == *pOptsItem) )
-rAttrs.Put( aOptsItem );
+rAttrs.Put( aOptsItem );
// we get a possible existing GridItem, this ensures that we do net set
// some default values by accident
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PATCH] Clean obsolete tools/filesystem abstraction
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2968 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/68/2968/1 Clean obsolete tools/filesystem abstraction Change-Id: I74f99c48b822644b26486a66d2f15386991154d6 --- M tools/source/fsys/unx.hxx M tools/source/fsys/wntmsc.hxx 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/tools/source/fsys/unx.hxx b/tools/source/fsys/unx.hxx index 8a3ee3b..bcc86ec 100644 --- a/tools/source/fsys/unx.hxx +++ b/tools/source/fsys/unx.hxx @@ -26,8 +26,6 @@ #include dirent.h #include unistd.h -#define DRIVE_EXISTS(c) ( TRUE ) - #define _mkdir(p) mkdir(p, 0777) #define _rmdir rmdir #define _chdir chdir diff --git a/tools/source/fsys/wntmsc.hxx b/tools/source/fsys/wntmsc.hxx index bf83941..dcc0654 100644 --- a/tools/source/fsys/wntmsc.hxx +++ b/tools/source/fsys/wntmsc.hxx @@ -50,7 +50,7 @@ const char *p; } DIR; -#define PATHDELIMITER ; +#define PATHSEPARATOR SAL_PATHSEPARATOR #define DEFSTYLEFSYS_STYLE_NTFS #define MKDIR( p ) mkdir( p ) #define CMP_LOWER(s)( s.toAsciiLowerCase() ) -- To view, visit https://gerrit.libreoffice.org/2968 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I74f99c48b822644b26486a66d2f15386991154d6 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Tomáš Turek osm...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] The tooltips of the slide sorter in impress should behave li...
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2969
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/2969/1
The tooltips of the slide sorter in impress should behave like the toolbar.
When hovering the mouse over a slide its name is displayed in a tooltip.
If you jump with the mouse from slide to slide the new tooltip is displayed
immediately.
Also remove unused member variables and make tooltip delay configurable.
Change-Id: Ia2347d81620f0ced437beaaeb49d8ad7f41e9333
---
M sd/source/ui/slidesorter/inc/view/SlsTheme.hxx
M sd/source/ui/slidesorter/inc/view/SlsToolTip.hxx
M sd/source/ui/slidesorter/view/SlsToolTip.cxx
3 files changed, 22 insertions(+), 17 deletions(-)
diff --git a/sd/source/ui/slidesorter/inc/view/SlsTheme.hxx
b/sd/source/ui/slidesorter/inc/view/SlsTheme.hxx
index 99b089d..a4e03da 100644
--- a/sd/source/ui/slidesorter/inc/view/SlsTheme.hxx
+++ b/sd/source/ui/slidesorter/inc/view/SlsTheme.hxx
@@ -37,7 +37,6 @@
namespace sd { namespace slidesorter { namespace view {
-const int Theme_ToolTipDelay = 1000;
const int Theme_FocusIndicatorWidth = 3;
/** Collection of colors and styles that are used to paint the slide sorter
diff --git a/sd/source/ui/slidesorter/inc/view/SlsToolTip.hxx
b/sd/source/ui/slidesorter/inc/view/SlsToolTip.hxx
index 01bc50e..bc26e73 100644
--- a/sd/source/ui/slidesorter/inc/view/SlsToolTip.hxx
+++ b/sd/source/ui/slidesorter/inc/view/SlsToolTip.hxx
@@ -55,10 +55,10 @@
private:
SlideSorter mrSlideSorter;
model::SharedPageDescriptor mpDescriptor;
-::rtl::OUString msDefaultHelpText;
::rtl::OUString msCurrentHelpText;
sal_uLong mnHelpWindowHandle;
-Timer maTimer;
+Timer maShowTimer;
+Timer maHiddenTimer;
/** Request to show the tool tip.
@param bForce
diff --git a/sd/source/ui/slidesorter/view/SlsToolTip.cxx
b/sd/source/ui/slidesorter/view/SlsToolTip.cxx
index f28aa53..c0babd7 100644
--- a/sd/source/ui/slidesorter/view/SlsToolTip.cxx
+++ b/sd/source/ui/slidesorter/view/SlsToolTip.cxx
@@ -33,13 +33,16 @@
ToolTip::ToolTip (SlideSorter rSlideSorter)
: mrSlideSorter(rSlideSorter),
- msDefaultHelpText(),
msCurrentHelpText(),
mnHelpWindowHandle(0),
- maTimer()
+ maShowTimer(),
+ maHiddenTimer()
{
-maTimer.SetTimeout(Theme_ToolTipDelay);
-maTimer.SetTimeoutHdl(LINK(this, ToolTip, DelayTrigger));
+SharedSdWindow window = rSlideSorter.GetContentWindow();
+const HelpSettings rHelpSettings =
window-GetSettings().GetHelpSettings();
+maShowTimer.SetTimeout(rHelpSettings.GetTipDelay());
+maShowTimer.SetTimeoutHdl(LINK(this, ToolTip, DelayTrigger));
+maHiddenTimer.SetTimeout(rHelpSettings.GetTipDelay());
}
@@ -47,19 +50,23 @@
ToolTip::~ToolTip (void)
{
-maTimer.Stop();
+maShowTimer.Stop();
+maHiddenTimer.Stop();
Hide();
}
-
-
void ToolTip::SetPage (const model::SharedPageDescriptor rpDescriptor)
{
if (mpDescriptor != rpDescriptor)
{
-maTimer.Stop();
-Hide();
+maShowTimer.Stop();
+bool bWasVisible = Hide();
+
+if (bWasVisible)
+{
+maHiddenTimer.Start();
+}
mpDescriptor = rpDescriptor;
@@ -79,13 +86,12 @@
sHelpText += OUString::number(mpDescriptor-GetPageIndex()+1);
}
-msDefaultHelpText = sHelpText;
msCurrentHelpText = sHelpText;
-Show(false);
+// show new tooltip immediately, if last one was recently hidden
+Show(maHiddenTimer.IsActive());
}
else
{
-msDefaultHelpText = OUString();
msCurrentHelpText = OUString();
}
}
@@ -98,7 +104,7 @@
if (bNoDelay)
DoShow();
else
-maTimer.Start();
+maShowTimer.Start();
}
@@ -106,7 +112,7 @@
void ToolTip::DoShow (void)
{
-if (maTimer.IsActive())
+if (maShowTimer.IsActive())
{
// The delay timer is active. Wait for it to trigger the showing of
// the tool tip.
--
To view, visit https://gerrit.libreoffice.org/2969
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia2347d81620f0ced437beaaeb49d8ad7f41e9333
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: mhofmann bor...@web.de
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: tools/source
tools/source/fsys/unx.hxx|2 -- tools/source/fsys/wntmsc.hxx |1 - 2 files changed, 3 deletions(-) New commits: commit d31bf8bf5524af62b48e59179ef7c2afc5096682 Author: Tomas Turek osm...@gmail.com Date: Sun Mar 24 20:14:49 2013 +0100 Clean obsolete tools/filesystem abstraction Change-Id: I74f99c48b822644b26486a66d2f15386991154d6 Reviewed-on: https://gerrit.libreoffice.org/2968 Reviewed-by: Thomas Arnhold tho...@arnhold.org Reviewed-by: Andras Timar ati...@suse.com Tested-by: Andras Timar ati...@suse.com diff --git a/tools/source/fsys/unx.hxx b/tools/source/fsys/unx.hxx index 8a3ee3b..bcc86ec 100644 --- a/tools/source/fsys/unx.hxx +++ b/tools/source/fsys/unx.hxx @@ -26,8 +26,6 @@ #include dirent.h #include unistd.h -#define DRIVE_EXISTS(c) ( TRUE ) - #define _mkdir(p) mkdir(p, 0777) #define _rmdir rmdir #define _chdir chdir diff --git a/tools/source/fsys/wntmsc.hxx b/tools/source/fsys/wntmsc.hxx index bf83941..734a68f 100644 --- a/tools/source/fsys/wntmsc.hxx +++ b/tools/source/fsys/wntmsc.hxx @@ -50,7 +50,6 @@ typedef struct const char *p; } DIR; -#define PATHDELIMITER ; #define DEFSTYLEFSYS_STYLE_NTFS #define MKDIR( p ) mkdir( p ) #define CMP_LOWER(s)( s.toAsciiLowerCase() ) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PUSHED] Clean obsolete tools/filesystem abstraction
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2968 Approvals: Andras Timar: Verified; Looks good to me, approved Thomas Arnhold: Looks good to me, but someone else must approve -- To view, visit https://gerrit.libreoffice.org/2968 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74f99c48b822644b26486a66d2f15386991154d6 Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Tomáš Turek osm...@gmail.com Gerrit-Reviewer: Andras Timar ati...@suse.com Gerrit-Reviewer: Thomas Arnhold tho...@arnhold.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Licence
All of my past future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license. Tomáš Turek ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] fdo#60462 - Small errors in the layout margins of the text b...
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2970
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/70/2970/1
fdo#60462 - Small errors in the layout margins of the text boxes
As you can see on this screenshot
https://bugs.freedesktop.org/attachment.cgi?id=74399 there was a margin
problem. The X-position of the text box is at 0.05, but the
width was only 0.88 so we had 0.02 _extra_ on the right side. This is the
width of that little margin error. Fixing it by setting Layoutsize width
to 0.90, so we have on both side a nice 0.05 margin.
Change-Id: Id712ce3695a760c8f955413c9392c008733d7fb9
---
M sd/source/core/sdpage.cxx
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sd/source/core/sdpage.cxx b/sd/source/core/sdpage.cxx
index 5c4337f..e943e89 100644
--- a/sd/source/core/sdpage.cxx
+++ b/sd/source/core/sdpage.cxx
@@ -1052,7 +1052,7 @@
{
aLayoutPos.X() += long( aLayoutSize.Width() * 0.05 );
aLayoutPos.Y() += long( aLayoutSize.Height() * 0.234 );
-aLayoutSize.Width() = long( aLayoutSize.Width() * 0.88 );
+aLayoutSize.Width() = long( aLayoutSize.Width() * 0.9 );
aLayoutSize.Height() = long( aLayoutSize.Height() * 0.58 );
aLayoutRect.SetPos(aLayoutPos);
aLayoutRect.SetSize(aLayoutSize);
--
To view, visit https://gerrit.libreoffice.org/2970
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id712ce3695a760c8f955413c9392c008733d7fb9
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Joren De Cuyper joren.libreoff...@telenet.be
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH libreoffice-4-0-2] fdo#60462 - Small errors in the layout margins of the text b...
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2971
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/71/2971/1
fdo#60462 - Small errors in the layout margins of the text boxes
As you can see on this screenshot
https://bugs.freedesktop.org/attachment.cgi?id=74399 there was a margin
problem. The X-position of the text box is at 0.05, but the
width was only 0.88 so we had 0.02 _extra_ on the right side. This is the
width of that little margin error. Fixing it by setting Layoutsize width
to 0.90, so we have on both side a nice 0.05 margin.
Change-Id: Id712ce3695a760c8f955413c9392c008733d7fb9
---
M sd/source/core/sdpage.cxx
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sd/source/core/sdpage.cxx b/sd/source/core/sdpage.cxx
index 5c4337f..e943e89 100644
--- a/sd/source/core/sdpage.cxx
+++ b/sd/source/core/sdpage.cxx
@@ -1052,7 +1052,7 @@
{
aLayoutPos.X() += long( aLayoutSize.Width() * 0.05 );
aLayoutPos.Y() += long( aLayoutSize.Height() * 0.234 );
-aLayoutSize.Width() = long( aLayoutSize.Width() * 0.88 );
+aLayoutSize.Width() = long( aLayoutSize.Width() * 0.9 );
aLayoutSize.Height() = long( aLayoutSize.Height() * 0.58 );
aLayoutRect.SetPos(aLayoutPos);
aLayoutRect.SetSize(aLayoutSize);
--
To view, visit https://gerrit.libreoffice.org/2971
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id712ce3695a760c8f955413c9392c008733d7fb9
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0-2
Gerrit-Owner: Joren De Cuyper joren.libreoff...@telenet.be
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH libreoffice-4-0] fdo#60462 - Small errors in the layout margins of the text b...
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2972
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/72/2972/1
fdo#60462 - Small errors in the layout margins of the text boxes
As you can see on this screenshot
https://bugs.freedesktop.org/attachment.cgi?id=74399 there was a margin
problem. The X-position of the text box is at 0.05, but the
width was only 0.88 so we had 0.02 _extra_ on the right side. This is the
width of that little margin error. Fixing it by setting Layoutsize width
to 0.90, so we have on both side a nice 0.05 margin.
Change-Id: Id712ce3695a760c8f955413c9392c008733d7fb9
---
M sd/source/core/sdpage.cxx
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sd/source/core/sdpage.cxx b/sd/source/core/sdpage.cxx
index 5c4337f..e943e89 100644
--- a/sd/source/core/sdpage.cxx
+++ b/sd/source/core/sdpage.cxx
@@ -1052,7 +1052,7 @@
{
aLayoutPos.X() += long( aLayoutSize.Width() * 0.05 );
aLayoutPos.Y() += long( aLayoutSize.Height() * 0.234 );
-aLayoutSize.Width() = long( aLayoutSize.Width() * 0.88 );
+aLayoutSize.Width() = long( aLayoutSize.Width() * 0.9 );
aLayoutSize.Height() = long( aLayoutSize.Height() * 0.58 );
aLayoutRect.SetPos(aLayoutPos);
aLayoutRect.SetSize(aLayoutSize);
--
To view, visit https://gerrit.libreoffice.org/2972
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id712ce3695a760c8f955413c9392c008733d7fb9
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Joren De Cuyper joren.libreoff...@telenet.be
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH libreoffice-3-6-6] fdo#60462 - Small errors in the layout margins of the text b...
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2973
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/73/2973/1
fdo#60462 - Small errors in the layout margins of the text boxes
As you can see on this screenshot
https://bugs.freedesktop.org/attachment.cgi?id=74399 there was a margin
problem. The X-position of the text box is at 0.05, but the
width was only 0.88 so we had 0.02 _extra_ on the right side. This is the
width of that little margin error. Fixing it by setting Layoutsize width
to 0.90, so we have on both side a nice 0.05 margin.
Change-Id: Id712ce3695a760c8f955413c9392c008733d7fb9
---
M sd/source/core/sdpage.cxx
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sd/source/core/sdpage.cxx b/sd/source/core/sdpage.cxx
index 5c4337f..e943e89 100644
--- a/sd/source/core/sdpage.cxx
+++ b/sd/source/core/sdpage.cxx
@@ -1052,7 +1052,7 @@
{
aLayoutPos.X() += long( aLayoutSize.Width() * 0.05 );
aLayoutPos.Y() += long( aLayoutSize.Height() * 0.234 );
-aLayoutSize.Width() = long( aLayoutSize.Width() * 0.88 );
+aLayoutSize.Width() = long( aLayoutSize.Width() * 0.9 );
aLayoutSize.Height() = long( aLayoutSize.Height() * 0.58 );
aLayoutRect.SetPos(aLayoutPos);
aLayoutRect.SetSize(aLayoutSize);
--
To view, visit https://gerrit.libreoffice.org/2973
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id712ce3695a760c8f955413c9392c008733d7fb9
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6-6
Gerrit-Owner: Joren De Cuyper joren.libreoff...@telenet.be
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH libreoffice-3-6] fdo#60462 - Small errors in the layout margins of the text b...
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2974
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/74/2974/1
fdo#60462 - Small errors in the layout margins of the text boxes
As you can see on this screenshot
https://bugs.freedesktop.org/attachment.cgi?id=74399 there was a margin
problem. The X-position of the text box is at 0.05, but the
width was only 0.88 so we had 0.02 _extra_ on the right side. This is the
width of that little margin error. Fixing it by setting Layoutsize width
to 0.90, so we have on both side a nice 0.05 margin.
Change-Id: Id712ce3695a760c8f955413c9392c008733d7fb9
---
M sd/source/core/sdpage.cxx
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sd/source/core/sdpage.cxx b/sd/source/core/sdpage.cxx
index 5c4337f..e943e89 100644
--- a/sd/source/core/sdpage.cxx
+++ b/sd/source/core/sdpage.cxx
@@ -1052,7 +1052,7 @@
{
aLayoutPos.X() += long( aLayoutSize.Width() * 0.05 );
aLayoutPos.Y() += long( aLayoutSize.Height() * 0.234 );
-aLayoutSize.Width() = long( aLayoutSize.Width() * 0.88 );
+aLayoutSize.Width() = long( aLayoutSize.Width() * 0.9 );
aLayoutSize.Height() = long( aLayoutSize.Height() * 0.58 );
aLayoutRect.SetPos(aLayoutPos);
aLayoutRect.SetSize(aLayoutSize);
--
To view, visit https://gerrit.libreoffice.org/2974
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id712ce3695a760c8f955413c9392c008733d7fb9
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Joren De Cuyper joren.libreoff...@telenet.be
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] fdo#39445 writing out tools/fsys.hxx (idl)
Hello LibreOffice gerrit bot, I'd like you to reexamine a rebased change. Please visit https://gerrit.libreoffice.org/2935 to look at the new rebased patch set (#3). Change subject: fdo#39445 writing out tools/fsys.hxx (idl) .. fdo#39445 writing out tools/fsys.hxx (idl) Removed uses of fsys from database.cxx, command.cxx, module.cxx, svidl.cxx. Also removed a lot of cruft from svidl.cxx and command.hxx; unused variables and code relating to them, eg. variables aCxxFile, aHxxFile, aSrcFile, aODLFile. Changed some Strings to OUStrings in svidl.cxx and command.hxx. Someone please test this patch under Windows. Change-Id: I708284f70435c8f65cdcfc954af43976e28b8c9d --- M idl/inc/command.hxx M idl/source/objects/module.cxx M idl/source/prj/command.cxx M idl/source/prj/database.cxx M idl/source/prj/svidl.cxx 5 files changed, 138 insertions(+), 159 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/35/2935/3 -- To view, visit https://gerrit.libreoffice.org/2935 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I708284f70435c8f65cdcfc954af43976e28b8c9d Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Krisztian Pinter pin.termina...@gmail.com Gerrit-Reviewer: Andras Timar ati...@suse.com Gerrit-Reviewer: Krisztian Pinter pin.termina...@gmail.com Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: ucb/source
ucb/source/ucp/file/bc.cxx |4 -
ucb/source/ucp/file/filcmd.cxx |4 -
ucb/source/ucp/file/filinpstr.cxx | 14 ++--
ucb/source/ucp/file/filprp.cxx |2
ucb/source/ucp/file/filtask.cxx|2
ucb/source/ucp/gio/gio_content.cxx | 14 ++--
ucb/source/ucp/gvfs/gvfs_content.cxx | 15 ++---
ucb/source/ucp/tdoc/tdoc_docmgr.cxx|2
ucb/source/ucp/tdoc/tdoc_provider.cxx |6 --
ucb/source/ucp/tdoc/tdoc_storage.cxx |7 +-
ucb/source/ucp/webdav-neon/NeonPropFindRequest.cxx |3 -
ucb/source/ucp/webdav/ContentProperties.cxx| 61 ++---
12 files changed, 54 insertions(+), 80 deletions(-)
New commits:
commit 8da928423add3fdb94baee2a3f3fa053390f828e
Author: Chr. Rossmanith chrrossman...@gmx.de
Date: Sun Mar 24 21:31:32 2013 +0100
Remove RTL_CONSTASCII_(U)STRINGPARAM in ucb(ucp)
Change-Id: Iae4ea99e6eff6de8db3d40a6b86e5fd28ff857d0
diff --git a/ucb/source/ucp/file/bc.cxx b/ucb/source/ucp/file/bc.cxx
index 2c551af..18fa9f3 100644
--- a/ucb/source/ucp/file/bc.cxx
+++ b/ucb/source/ucp/file/bc.cxx
@@ -338,11 +338,11 @@ BaseContent::execute( const Command aCommand,
Any aAny;
-if
(aCommand.Name.equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(getPropertySetInfo)))
// No exceptions
+if (aCommand.Name == getPropertySetInfo) // No exceptions
{
aAny = getPropertySetInfo( CommandId );
}
-else if
(aCommand.Name.equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(getCommandInfo))) //
no exceptions
+else if (aCommand.Name == getCommandInfo) // no exceptions
{
aAny = getCommandInfo();
}
diff --git a/ucb/source/ucp/file/filcmd.cxx b/ucb/source/ucp/file/filcmd.cxx
index 2a57070..c001717 100644
--- a/ucb/source/ucp/file/filcmd.cxx
+++ b/ucb/source/ucp/file/filcmd.cxx
@@ -87,7 +87,7 @@ XCommandInfo_impl::getCommandInfoByName(
if( m_pMyShell-m_sCommandInfo[i].Name == aName )
return m_pMyShell-m_sCommandInfo[i];
-throw UnsupportedCommandException( ::rtl::OUString(
RTL_CONSTASCII_USTRINGPARAM( OSL_LOG_PREFIX ) ), uno::Reference
uno::XInterface () );
+throw UnsupportedCommandException( OUString( OSL_LOG_PREFIX ),
uno::Reference uno::XInterface () );
}
@@ -101,7 +101,7 @@ XCommandInfo_impl::getCommandInfoByHandle(
if( m_pMyShell-m_sCommandInfo[i].Handle == Handle )
return m_pMyShell-m_sCommandInfo[i];
-throw UnsupportedCommandException( ::rtl::OUString(
RTL_CONSTASCII_USTRINGPARAM( OSL_LOG_PREFIX ) ), uno::Reference
uno::XInterface () );
+throw UnsupportedCommandException( OUString( OSL_LOG_PREFIX ),
uno::Reference uno::XInterface () );
}
diff --git a/ucb/source/ucp/file/filinpstr.cxx
b/ucb/source/ucp/file/filinpstr.cxx
index bc9afd0..94172d7 100644
--- a/ucb/source/ucp/file/filinpstr.cxx
+++ b/ucb/source/ucp/file/filinpstr.cxx
@@ -136,7 +136,7 @@ XInputStream_impl::readBytes(
io::IOException,
uno::RuntimeException)
{
-if( ! m_nIsOpen ) throw io::IOException( ::rtl::OUString(
RTL_CONSTASCII_USTRINGPARAM( OSL_LOG_PREFIX ) ), uno::Reference
uno::XInterface () );
+if( ! m_nIsOpen ) throw io::IOException( OUString( OSL_LOG_PREFIX ),
uno::Reference uno::XInterface () );
aData.realloc(nBytesToRead);
//TODO! translate memory exhaustion (if it were detectable...) into
@@ -145,7 +145,7 @@ XInputStream_impl::readBytes(
sal_uInt64 nrc(0);
if(m_aFile.read( aData.getArray(),sal_uInt64(nBytesToRead),nrc )
!= osl::FileBase::E_None)
-throw io::IOException( ::rtl::OUString( RTL_CONSTASCII_USTRINGPARAM(
OSL_LOG_PREFIX ) ), uno::Reference uno::XInterface () );
+throw io::IOException( OUString( OSL_LOG_PREFIX ), uno::Reference
uno::XInterface () );
// Shrink aData in case we read less than nBytesToRead (XInputStream
// documentation does not tell whether this is required, and I do not know
@@ -202,7 +202,7 @@ XInputStream_impl::closeInput(
{
osl::FileBase::RC err = m_aFile.close();
if( err != osl::FileBase::E_None )
-throw io::IOException( ::rtl::OUString(
RTL_CONSTASCII_USTRINGPARAM( OSL_LOG_PREFIX ) ), uno::Reference
uno::XInterface () );
+throw io::IOException( OUString( OSL_LOG_PREFIX ), uno::Reference
uno::XInterface () );
m_nIsOpen = false;
}
}
@@ -216,9 +216,9 @@ XInputStream_impl::seek(
uno::RuntimeException )
{
if( location 0 )
-throw lang::IllegalArgumentException( ::rtl::OUString(
RTL_CONSTASCII_USTRINGPARAM( OSL_LOG_PREFIX ) ), uno::Reference
uno::XInterface (), 0 );
+throw lang::IllegalArgumentException( OUString( OSL_LOG_PREFIX ),
uno::Reference uno::XInterface (), 0 );
if( osl::FileBase::E_None != m_aFile.setPos( osl_Pos_Absolut, sal_uInt64(
location ) ) )
-throw
[PATCH] coverity#704300 Logically dead code
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2976
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/76/2976/1
coverity#704300 Logically dead code
Change-Id: I05bf1fc737896d99419597850b70a5ca156e1b8a
---
M sfx2/source/appl/appuno.cxx
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/sfx2/source/appl/appuno.cxx b/sfx2/source/appl/appuno.cxx
index 62b2dfe..39b2bf1 100644
--- a/sfx2/source/appl/appuno.cxx
+++ b/sfx2/source/appl/appuno.cxx
@@ -1885,16 +1885,17 @@
if ( !pDoc-AdjustMacroMode( String() ) )
// check forbids execution
return ERRCODE_IO_ACCESSDENIED;
-}
-else if ( pDoc pDoc-GetMedium() )
-{
-pDoc-AdjustMacroMode( String() );
-SFX_ITEMSET_ARG( pDoc-GetMedium()-GetItemSet(),
pUpdateDocItem, SfxUInt16Item, SID_UPDATEDOCMODE, sal_False);
-SFX_ITEMSET_ARG( pDoc-GetMedium()-GetItemSet(),
pMacroExecModeItem, SfxUInt16Item, SID_MACROEXECMODE, sal_False);
-if ( pUpdateDocItem pMacroExecModeItem
- pUpdateDocItem-GetValue() ==
document::UpdateDocMode::NO_UPDATE
- pMacroExecModeItem-GetValue() ==
document::MacroExecMode::NEVER_EXECUTE )
-return ERRCODE_IO_ACCESSDENIED;
+
+if ( pDoc-GetMedium() )
+{
+pDoc-AdjustMacroMode( String() );
+SFX_ITEMSET_ARG( pDoc-GetMedium()-GetItemSet(),
pUpdateDocItem, SfxUInt16Item, SID_UPDATEDOCMODE, sal_False);
+SFX_ITEMSET_ARG( pDoc-GetMedium()-GetItemSet(),
pMacroExecModeItem, SfxUInt16Item, SID_MACROEXECMODE, sal_False);
+if ( pUpdateDocItem pMacroExecModeItem
+ pUpdateDocItem-GetValue() ==
document::UpdateDocMode::NO_UPDATE
+ pMacroExecModeItem-GetValue() ==
document::MacroExecMode::NEVER_EXECUTE )
+return ERRCODE_IO_ACCESSDENIED;
+}
}
// find BASIC method
--
To view, visit https://gerrit.libreoffice.org/2976
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I05bf1fc737896d99419597850b70a5ca156e1b8a
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Julien Nabet serval2...@yahoo.fr
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove RTL_CONSTASCII_STRINGPARAM in NeonUri.cxx
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2975
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/75/2975/1
Remove RTL_CONSTASCII_STRINGPARAM in NeonUri.cxx
Change-Id: Ibfce9af9bec2e1bac435514ad6d3d27eac5f1a17
---
M ucb/source/ucp/webdav-neon/NeonUri.cxx
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/ucb/source/ucp/webdav-neon/NeonUri.cxx
b/ucb/source/ucp/webdav-neon/NeonUri.cxx
index 5886429..463048b 100644
--- a/ucb/source/ucp/webdav-neon/NeonUri.cxx
+++ b/ucb/source/ucp/webdav-neon/NeonUri.cxx
@@ -149,11 +149,9 @@
{
// Complete URI.
const ne_uri * pUriDefs
-= matchIgnoreAsciiCase( rUri,
-RTL_CONSTASCII_STRINGPARAM( ftp: ) ) ?
+= rUri.matchIgnoreAsciiCase( ftp: ) ?
g_sUriDefaultsFTP :
- matchIgnoreAsciiCase( rUri,
-RTL_CONSTASCII_STRINGPARAM( https: ) ) ?
+ rUri.matchIgnoreAsciiCase( https: ) ?
g_sUriDefaultsHTTPS :
g_sUriDefaultsHTTP;
--
To view, visit https://gerrit.libreoffice.org/2975
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibfce9af9bec2e1bac435514ad6d3d27eac5f1a17
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Christina Roßmanith chrrossman...@web.de
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] coverity#704302 Logically dead code
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2977
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/77/2977/1
coverity#704302 Logically dead code
Change-Id: Ibdea2ca5225ac13e80b0a76cd0fd79e463c32e37
---
M sfx2/source/dialog/filedlghelper.cxx
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sfx2/source/dialog/filedlghelper.cxx
b/sfx2/source/dialog/filedlghelper.cxx
index 164bc7e..6108a62 100644
--- a/sfx2/source/dialog/filedlghelper.cxx
+++ b/sfx2/source/dialog/filedlghelper.cxx
@@ -529,7 +529,7 @@
for ( sal_uInt32 nCtrl = 0; nCtrl nCount; ++nCtrl )
if ( aCtrlList[ nCtrl ] == SelectionBox )
{
-bSelectionBoxFound = sal_False;
+bSelectionBoxFound = sal_True;
break;
}
}
--
To view, visit https://gerrit.libreoffice.org/2977
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibdea2ca5225ac13e80b0a76cd0fd79e463c32e37
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Julien Nabet serval2...@yahoo.fr
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: ucb/source
ucb/source/ucp/gio/gio_content.cxx | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
New commits:
commit c17eaa63273a7544ea812990d7e0e5644385a220
Author: Stephan Bergmann sberg...@redhat.com
Date: Sun Mar 24 22:30:48 2013 +0100
Does not compile
Change-Id: If7d24a6378a6645baf9d0c40e3c3cf0ae7d4f317
diff --git a/ucb/source/ucp/gio/gio_content.cxx
b/ucb/source/ucp/gio/gio_content.cxx
index 68e693c..4b7c304 100644
--- a/ucb/source/ucp/gio/gio_content.cxx
+++ b/ucb/source/ucp/gio/gio_content.cxx
@@ -645,12 +645,12 @@ uno::Sequence uno::Any Content::setPropertyValues(
#if OSL_DEBUG_LEVEL 1
g_warning(Set prop '%s', rtl::OUStringToOString(rValue.Name,
RTL_TEXTENCODING_UTF8).getStr());
#endif
-if ( rValue.Name == ContentType ) ||
- rValue.Name == MediaType ) ||
- rValue.Name == IsDocument ) ||
- rValue.Name == IsFolder ) ||
- rValue.Name == Size ) ||
- rValue.Name == CreatableContentsInfo ) )
+if ( rValue.Name == ContentType ||
+ rValue.Name == MediaType ||
+ rValue.Name == IsDocument ||
+ rValue.Name == IsFolder ||
+ rValue.Name == Size ||
+ rValue.Name == CreatableContentsInfo )
{
aRet[ n ] = getReadOnlyException( static_cast cppu::OWeakObject
* (this) );
}
@@ -931,7 +931,7 @@ uno::Any SAL_CALL Content::execute(
ucbhelper::cancelCommandExecution ( getBadArgExcept (), xEnv );
aRet = setPropertyValues( aProperties, xEnv );
}
-else if (aCommand.Name.equals == createNewContent )
+else if (aCommand.Name == createNewContent
isFolder( xEnv ) )
{
ucb::ContentInfo arg;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Mac buildbot broken
The mac buildbot seems to be broken (see https://ci.libreoffice.org/job/buildbot/413). It is producing this error: make[1]: execvp: touch: Bad file descriptor make[1]: *** [/Users/n_th/lo/core_gerrit/workdir/unxmacxi.pro/UnoApiPartTarget/offapi/com/sun/star/frame/XRecordableDispatch.urd] Error 127 Could someone take a look? Thanks, Peter ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: About coverity 440107 (keyimpl.cxx in registry)
On 03/23/2013 01:00 PM, julien2412 wrote: If I remove these cases in the switch, I've got this: /home/julien/compile-libreoffice/libo/registry/source/keyimpl.cxx: In member function ‘RegError ORegKey::getValue(const rtl::OUString, RegValue) const’: /home/julien/compile-libreoffice/libo/registry/source/keyimpl.cxx:622:12: error: enumeration value ‘RG_VALUETYPE_LONGLIST’ not handled in switch [-Werror=switch] /home/julien/compile-libreoffice/libo/registry/source/keyimpl.cxx:622:12: error: enumeration value ‘RG_VALUETYPE_STRINGLIST’ not handled in switch [-Werror=switch] /home/julien/compile-libreoffice/libo/registry/source/keyimpl.cxx:622:12: error: enumeration value ‘RG_VALUETYPE_UNICODELIST’ not handled in switch [-Werror=switch] In which case, case RG_VALUETYPE_LONGLIST: case RG_VALUETYPE_STRINGLIST: case RG_VALUETYPE_UNICODELIST: assert(false); // this cannot happen is the canonic solution. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 2 commits - configure.ac i18npool/source
configure.ac | 66 +++---
i18npool/source/localedata/localedata.cxx | 11 -
2 files changed, 44 insertions(+), 33 deletions(-)
New commits:
commit 02ed2608199f2adc466849d0f4864213ad07c445
Author: Peter Foley pefol...@verizon.net
Date: Sun Mar 24 17:48:48 2013 -0400
add configure option to use clang
Change-Id: Ide63ef8bde7ed739b9bf29e936c01e156e8e3de4
diff --git a/configure.ac b/configure.ac
index 6a31c89..898dedb 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1158,6 +1158,11 @@ AC_ARG_ENABLE(winegcc,
needed for MinGW cross-compilation.]),
)
+AC_ARG_ENABLE(clang,
+AS_HELP_STRING([--enable-clang],
+[Build using the clang compiler.]),
+)
+
AC_ARG_ENABLE(liblangtag,
AS_HELP_STRING([--disable-liblangtag],
[Disable use of liblangtag, and insted use an own simple
@@ -2274,43 +2279,36 @@ if test $CCACHE != ; then
fi
dnl ===
+dnl Checks for Icecream
+dnl ===
+if test $enable_icecream = yes; then
+if test -d /usr/lib/icecc/bin; then
+ ICECREAM_HOME=/usr/lib/icecc/
+else
+ ICECREAM_HOME=/opt/icecream/
+fi
+if test -z $CC; then
+ CC=$GCC_HOME/bin/gcc
+fi
+if test -z $CXX; then
+ CXX=$GCC_HOME/bin/g++
+fi
+fi
+
+dnl ===
dnl Checks for C compiler,
+dnl AC_PROG_CC checks for gcc, cc and then cl (if it weren't guarded for
win32)
dnl The check for the C++ compiler is later on.
dnl ===
-if test $_os != WINNT -a $WITH_MINGW != yes; then
- GCC_HOME_SET=true
- AC_MSG_CHECKING([gcc home])
- if test -z $with_gcc_home; then
- if test $enable_icecream = yes; then
- if test -d /usr/lib/icecc/bin; then
- GCC_HOME=/usr/lib/icecc/
- else
- GCC_HOME=/opt/icecream/
- fi
- else
- GCC_HOME=`which gcc | $SED -e s,/bin/gcc,,`
- GCC_HOME_SET=false
- fi
- else
- GCC_HOME=$with_gcc_home
- fi
- AC_MSG_RESULT($GCC_HOME)
- AC_SUBST(GCC_HOME)
-
- if test $GCC_HOME_SET = true; then
- if test -z $CC; then
- CC=$GCC_HOME/bin/gcc
- fi
- if test -z $CXX; then
- CXX=$GCC_HOME/bin/g++
- fi
- fi
-fi
-
-dnl The following checks for gcc, cc and then cl (if it weren't guarded for
win32)
if test $_os != WINNT -o $WITH_MINGW = yes; then
# AC_PROG_CC sets CFLAGS to -g -O2 if not set, avoid that
save_CFLAGS=$CFLAGS
+if test $enable_clang = yes; then
+AC_PATH_PROG(CC,clang)
+if test -z $CC; then
+AC_MSG_ERROR([Clang not found in path. Is it installed?])
+fi
+fi
AC_PROG_CC
CFLAGS=$save_CFLAGS
fi
@@ -5002,6 +5000,12 @@ dnl
===
if test $_os != WINNT -o $WITH_MINGW = yes; then
# AC_PROG_CXX sets CXXFLAGS to -g -O2 if not set, avoid that
save_CXXFLAGS=$CXXFLAGS
+if test $enable_clang = yes; then
+AC_PATH_PROG(CXX,clang++)
+if test -z $CXX; then
+AC_MSG_ERROR([clang++ not found in path. Is it installed?])
+fi
+fi
AC_PROG_CXX
CXXFLAGS=$save_CXXFLAGS
else
commit db754e891e35a2832645fce676a5f6f0bf162976
Author: Peter Foley pefol...@verizon.net
Date: Sun Mar 24 17:36:31 2013 -0400
fix breakiterator with Library_merged
Change-Id: I78327067b977b522d34cc734c83c252e22d208b6
diff --git a/i18npool/source/localedata/localedata.cxx
b/i18npool/source/localedata/localedata.cxx
index 5880d11..ae20335 100644
--- a/i18npool/source/localedata/localedata.cxx
+++ b/i18npool/source/localedata/localedata.cxx
@@ -43,6 +43,15 @@ typedef sal_Unicode const * const * (SAL_CALL *
MyFunc_FormatCode)( sal_Int16,
#ifndef DISABLE_DYNLOADING
+#ifdef LIBO_MERGELIBS
+
+static const char *lcl_DATA_EN = mergedlo;
+static const char *lcl_DATA_ES = mergedlo;
+static const char *lcl_DATA_EURO = mergedlo;
+static const char *lcl_DATA_OTHERS = mergedlo;
+
+#else
+
static const char *lcl_DATA_EN = localedata_en;
static const char *lcl_DATA_ES = localedata_es;
static const char *lcl_DATA_EURO = localedata_euro;
@@ -50,8 +59,6 @@ static const char *lcl_DATA_OTHERS = localedata_others;
#endif
-#ifndef DISABLE_DYNLOADING
-
static const struct {
const char* pLocale;
const char* pLib;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: need help with shell / configure
On 03/23/2013 09:25 PM, Mat M wrote:
When working on it, I found that:
AC_PATH_PROG(BASH, bash)
if test -z $BASH; then
AC_MSG_ERROR([bash not found in \$PATH])
fi
AC_SUBST(BASH)
and then,
$ git grep BASH
bin/bash-completion.in:@BASH_COMPLETION_SUFFIXES_CHECKS@
bin/bash-completion.in:@BASH_COMPLETION_OOO_APPS@
bin/generate-bash-completion:if ($line =~
m/\@BASH_COMPLETION_SUFFIXES_CHECKS\@/) {
bin/generate-bash-completion:} elsif ($line =~
m/\@BASH_COMPLETION_OOO_APPS\@/) {
config_host.mk.in:export OOO_SHELL=@BASH@
configure.ac:AC_PATH_PROG(BASH, bash)
configure.ac:if test -z $BASH; then
configure.ac:AC_SUBST(BASH)
and
$ git grep OOO_SHELL
config_host.mk.in:export OOO_SHELL=@BASH@
So, is it still useful or could we remove BASH check and OOO_SHELL as
well ?
I'm not sure I understand your question. The LO build system requires
Bash in places, esp. as the shell used to execute makefile recipe lines.
But that is unrelated to the fact that Autotools translates LO's
configure.ac into a #! /bin/sh configure script, so that it should not
use Bashisms.
(That said, it looks like OOO_SHELL is actually unused since we got rid
of the old dmake-based build system, and could be dropped. The use of
Bash in gbuild is enforced via SHELL=/usr/bin/env bash in Makefile.mk,
which should arguably be replaced with SHELL=@BASH@.)
Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 96/3ae3e6bf2f20f7deb48ee80ce12d840ea35e07
96/3ae3e6bf2f20f7deb48ee80ce12d840ea35e07 |1 + 1 file changed, 1 insertion(+) New commits: commit 5437b7ce25eb56fd07a95e0d77434a7f7c9fe836 Author: Xisco Fauli aniste...@gmail.com Date: Mon Mar 25 00:10:31 2013 +0100 Notes added by 'git notes add' diff --git a/96/3ae3e6bf2f20f7deb48ee80ce12d840ea35e07 b/96/3ae3e6bf2f20f7deb48ee80ce12d840ea35e07 new file mode 100644 index 000..b9d699b --- /dev/null +++ b/96/3ae3e6bf2f20f7deb48ee80ce12d840ea35e07 @@ -0,0 +1 @@ +merged as: 6fd9ad9f3a61a3c489140100cad269c9edfee479 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 3 commits - sd/source writerfilter/source
sd/source/filter/eppt/epptso.cxx|3 +++
sd/source/ui/unoidl/unomodel.cxx|3 ++-
writerfilter/source/dmapper/PropertyMap.cxx |2 +-
3 files changed, 6 insertions(+), 2 deletions(-)
New commits:
commit 2a4161f7098b9bcb76eadbc82212038bbaebed2b
Author: Andre Fischer a...@apache.org
Date: Thu Aug 30 07:28:53 2012 +
#i119592# Fixed column widths.
Reported by: xiao ting xiao
Patch by: wujinlong@...
Reviewed by: Andre Fischer
diff --git a/writerfilter/source/dmapper/PropertyMap.cxx
b/writerfilter/source/dmapper/PropertyMap.cxx
index 8f19057..9e22551 100644
--- a/writerfilter/source/dmapper/PropertyMap.cxx
+++ b/writerfilter/source/dmapper/PropertyMap.cxx
@@ -543,7 +543,7 @@ uno::Reference text::XTextColumns
SectionPropertyMap::ApplyColumnProperties(
uno::Reference beans::XPropertySet xColumnPropSet( xColumns,
uno::UNO_QUERY_THROW );
if( !m_bEvenlySpaced
(sal_Int32(m_aColWidth.size()) == (m_nColumnCount + 1 ))
-(sal_Int32(m_aColDistance.size()) == m_nColumnCount))
+((sal_Int32(m_aColDistance.size()) == m_nColumnCount) ||
(sal_Int32(m_aColDistance.size()) == m_nColumnCount + 1)) )
{
//the column width in word is an absolute value, in OOo it's
relative
//the distances are both absolute
commit 40ca6b3a9f805e4a1c12a9ed2c487282fff1c08b
Author: Armin Le Grand a...@apache.org
Date: Wed Jun 20 12:52:26 2012 +
#119459# Corrected export of connectors to PPT format, Patch by: Sun Ying,
Review by: alg
diff --git a/sd/source/filter/eppt/epptso.cxx b/sd/source/filter/eppt/epptso.cxx
index 106bb74..f543cde 100644
--- a/sd/source/filter/eppt/epptso.cxx
+++ b/sd/source/filter/eppt/epptso.cxx
@@ -2664,6 +2664,9 @@ void PPTWriter::ImplWritePage( const PHLayout rLayout,
EscherSolverContainer a
mpPptEscherEx-OpenContainer( ESCHER_SpContainer );
ImplCreateShape( nSpType, nSpFlags, aSolverContainer );
+
+// #119459# for connector shape, the start point and end point
is fixed, and should not be rotated.
+mnAngle = 0;
}
else if ( mType == drawing.Measure )
{
commit 69b0688589fe611d873d2c8d2556dd1279c764a0
Author: Zhe Wang wangz...@apache.org
Date: Fri Sep 7 02:11:47 2012 +
Fix issue #i119524#: [From Symphony]Can not open the sample ppt file which
contain vb controls in the slide master.
* subversion/main/sd/source/ui/unoidl/unomodel.cxx
[]Before initializeDocument,should check whether it is in loading process
Patch by: Yin Bing steve.yin@gmail.com
Suggested by:Wang Zhe kingwise...@gmail.com
Found by: Du Jing jbjduj...@gmail.com
Review by: Wang Zhe kingwise...@gmail.com
diff --git a/sd/source/ui/unoidl/unomodel.cxx b/sd/source/ui/unoidl/unomodel.cxx
index 037a2cd..32249c1 100644
--- a/sd/source/ui/unoidl/unomodel.cxx
+++ b/sd/source/ui/unoidl/unomodel.cxx
@@ -736,7 +736,8 @@ uno::Reference drawing::XDrawPages SAL_CALL
SdXImpressDocument::getMasterPage
if( !xMasterPages.is() )
{
-initializeDocument();
+if ( !hasControllersLocked() )
+initializeDocument();
mxMasterPagesAccess = xMasterPages = new SdMasterPagesAccess(*this);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - f3/c156fd4e1d847606433b72cd4d198d90674603
f3/c156fd4e1d847606433b72cd4d198d90674603 |1 + 1 file changed, 1 insertion(+) New commits: commit c7574fdcf29965f933ca68d4e7853434cb0ac6a5 Author: Xisco Fauli aniste...@gmail.com Date: Mon Mar 25 00:48:14 2013 +0100 Notes added by 'git notes add' diff --git a/f3/c156fd4e1d847606433b72cd4d198d90674603 b/f3/c156fd4e1d847606433b72cd4d198d90674603 new file mode 100644 index 000..a5a7941 --- /dev/null +++ b/f3/c156fd4e1d847606433b72cd4d198d90674603 @@ -0,0 +1 @@ +merged as: 40ca6b3a9f805e4a1c12a9ed2c487282fff1c08b ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - b0/e67d12cb84c0b5272905cb8aee37bfce794fb1
b0/e67d12cb84c0b5272905cb8aee37bfce794fb1 |1 + 1 file changed, 1 insertion(+) New commits: commit 5cab7a6fcb97af93a1d68d71a3112867ae47ebe2 Author: Xisco Fauli aniste...@gmail.com Date: Mon Mar 25 00:50:52 2013 +0100 Notes added by 'git notes add' diff --git a/b0/e67d12cb84c0b5272905cb8aee37bfce794fb1 b/b0/e67d12cb84c0b5272905cb8aee37bfce794fb1 new file mode 100644 index 000..aab404b --- /dev/null +++ b/b0/e67d12cb84c0b5272905cb8aee37bfce794fb1 @@ -0,0 +1 @@ +merged as: 69b0688589fe611d873d2c8d2556dd1279c764a0 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 6 commits - filter/source
filter/source/svg/presentation_engine.js | 738 ---
1 file changed, 98 insertions(+), 640 deletions(-)
New commits:
commit 88042d437df72c9c36a39ca668c2f8f459a0d04a
Author: Thorsten Behrens tbehr...@suse.com
Date: Mon Mar 25 00:47:12 2013 +0100
Replace stdlib priority queue with own version.
This is enough for our needs, and avoids the third license in one
file.
Change-Id: I5312ac9904406f013964a34d9167a32403fcb941
diff --git a/filter/source/svg/presentation_engine.js
b/filter/source/svg/presentation_engine.js
index 634033b..c77ff1d 100644
--- a/filter/source/svg/presentation_engine.js
+++ b/filter/source/svg/presentation_engine.js
@@ -679,202 +679,6 @@ function configureDetectionTools()
/*
* @licstart
*
- * The following is the license notice for the part of JavaScript code of this
- * page included between the '@stdlibstart' and the '@stdlibend' notes.
- */
-
-/* **
- *
- * Copyright (C) 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009
- * Free Software Foundation, Inc.
- *
- * The code included between the start note '@stdlibstart' and the end
- * note '@stdlibend' is a derivative work of the GNU ISO C++ Library.
- * This library is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 3, or (at your option)
- * any later version.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * Under Section 7 of GPL version 3, you are granted additional
- * permissions described in the GCC Runtime Library Exception, version
- * 3.1, as published by the Free Software Foundation.
- *
- * You should have received a copy of the GNU General Public License and
- * a copy of the GCC Runtime Library Exception along with this program;
- * see the files COPYING3 and COPYING.RUNTIME respectively. If not, see
- * http://www.gnu.org/licenses/.
- *
- */
-
-/*
- *
- * Copyright (c) 1994
- * Hewlett-Packard Company
- *
- * Permission to use, copy, modify, distribute and sell this software
- * and its documentation for any purpose is hereby granted without fee,
- * provided that the above copyright notice appear in all copies and
- * that both that copyright notice and this permission notice appear
- * in supporting documentation. Hewlett-Packard Company makes no
- * representations about the suitability of this software for any
- * purpose. It is provided 'as is' without express or implied warranty.
- *
- *
- * Copyright (c) 1996,1997
- * Silicon Graphics Computer Systems, Inc.
- *
- * Permission to use, copy, modify, distribute and sell this software
- * and its documentation for any purpose is hereby granted without fee,
- * provided that the above copyright notice appear in all copies and
- * that both that copyright notice and this permission notice appear
- * in supporting documentation. Silicon Graphics makes no
- * representations about the suitability of this software for any
- * purpose. It is provided 'as is' without express or implied warranty.
- *
- /
-
-/*
- * @licend
- *
- * The above is the license notice for the part of JavaScript code of this
- * page included between the '@stdlibstart' and the '@stdlibend' notes.
- */
-
-
-
-/*
- * @stdlibstart
- *
- * The following code is a porting, performed on August 2011, of a part of
- * the C++ code included into the source file stl_queue.h that is part of
- * the GNU ISO C++ Library.
- */
-
-
-function PriorityQueue( aCompareFunc )
-{
-this.aSequence = new Array();
-this.aCompareFunc = aCompareFunc;
-}
-
-PriorityQueue.prototype.clone = function()
-{
-var aCopy = new PriorityQueue( this.aCompareFunc );
-var src = this.aSequence;
-var dest = [];
-var i, l;
-for( i = 0, l = src.length; i l; ++i )
-{
-if( i in src )
-{
-dest.push( src[i] );
-}
-}
-aCopy.aSequence = dest;
-
-return aCopy;
-};
-
-PriorityQueue.prototype.top = function()
-{
-return this.aSequence[0];
-};
-
-PriorityQueue.prototype.isEmpty = function()
-{
-return ( this.size() === 0 );
-};
-
-PriorityQueue.prototype.size = function()
-{
-return this.aSequence.length;
-};
-
-PriorityQueue.prototype.push = function( aValue )
-{
-this.implPushHeap( 0, this.aSequence.length, 0, aValue );
-};
-
-PriorityQueue.prototype.clear = function()
-{
-return this.aSequence = new Array();
-};
-
-
-PriorityQueue.prototype.pop = function()
-{
-if( this.isEmpty() )
-return;
-
-
[PATCH] Fix bashism in configure.ac
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2978
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/78/2978/1
Fix bashism in configure.ac
Change-Id: I574e873fede3343b2384715162dcecce86563db3
---
M configure.ac
1 file changed, 27 insertions(+), 19 deletions(-)
diff --git a/configure.ac b/configure.ac
index 6a31c89..4caa919 100644
--- a/configure.ac
+++ b/configure.ac
@@ -11356,36 +11356,44 @@
dnl ===
AC_MSG_CHECKING([for alternative branding images directory])
# initialize mapped arrays
-brand_vars=(INTRO_BITMAP ABOUT_BACKGROUND_SVG FLAT_LOGO_SVG \
+brand_vars=INTRO_BITMAP ABOUT_BACKGROUND_SVG FLAT_LOGO_SVG \
STARTCENTER_LEFT_BITMAP STARTCENTER_RIGHT_BITMAP \
STARTCENTER_RTL_LEFT_BITMAP STARTCENTER_RTL_RIGHT_BITMAP \
-STARTCENTER_SPACE_BITMAP)
-brand_files=(intro.png about.svg flat_logo.svg \
+STARTCENTER_SPACE_BITMAP
+brand_files=intro.png about.svg flat_logo.svg \
backing_left.png backing_right.png \
backing_rtl_left.png backing_rtl_right.png \
-backing_space.png)
+backing_space.png
+brandmaxidx=0
-for i in $(echo ${brand_vars[[@]]})
+for i in $brand_vars
do
- declare $i=
+declare $i=
+let brandmaxidx=$brandmaxidx + 1
done
if test -z $with_branding -o $with_branding = no; then
AC_MSG_RESULT([none])
else
-idx=0
-while test $idx -lt ${#brand_vars[@]}
-do
-if ! test -f $with_branding/${brand_files[[$idx]]}
-then
-AC_MSG_WARN([Branded file $i does not exist, using the default
one])
-else
-declare
${brand_vars[[$idx]]}=$with_branding/${brand_files[[$idx]]}
-fi
-let idx=$idx + 1
-done
-check_for_progress=yes
-AC_MSG_RESULT([$with_branding])
+if ! test -d $with_branding ; then
+AC_MSG_ERROR([No directory $with_branding, falling back to default
branding])
+else
+AC_MSG_RESULT([$with_branding])
+idx=1
+while test $idx -le $brandmaxidx
+do
+lvar=$(echo $brand_vars | cut -f$idx -d )
+lfile=$(echo $brand_files | cut -f$idx -d )
+
+if ! test -f $with_branding/$lfile ; then
+AC_MSG_WARN([Branded file $lfile does not exist, using the
default one])
+else
+declare lvar=$with_branding/$lfile
+fi
+let idx=$idx + 1
+done
+check_for_progress=yes
+fi
fi
AC_SUBST(INTRO_BITMAP)
AC_SUBST(ABOUT_BACKGROUND_SVG)
--
To view, visit https://gerrit.libreoffice.org/2978
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I574e873fede3343b2384715162dcecce86563db3
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Mathias M m...@gmx.fr
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: filter/source
filter/source/svg/svgexport.cxx | 30 +-
1 file changed, 25 insertions(+), 5 deletions(-)
New commits:
commit c724ad3de3c053cd482cd107a4ade4065980acb9
Author: Moritz Kuett moritz.ku...@web.de
Date: Sat Mar 23 23:30:34 2013 +0100
fdo#47576: Hyperlinks work for SVG Exports
For different objects (images, shapes...) hyperlinks are exported by
Draw/Impress.
An a Tag is wrapped around the object, if the object has a Property
Bookmark which is not empty.
Change-Id: I3e034effe6c4a5025c27bd6408fd162bf5cf4859
Reviewed-on: https://gerrit.libreoffice.org/2957
Reviewed-by: Thorsten Behrens tbehr...@suse.com
Tested-by: Thorsten Behrens tbehr...@suse.com
diff --git a/filter/source/svg/svgexport.cxx b/filter/source/svg/svgexport.cxx
index fdf12a7..4b952c4 100644
--- a/filter/source/svg/svgexport.cxx
+++ b/filter/source/svg/svgexport.cxx
@@ -1785,12 +1785,32 @@ sal_Bool SVGFilter::implExportShape( const Reference
XShape rxShape )
}
{
+OUString aBookmark;
+ReferenceXPropertySetInfo xShapePropSetInfo =
xShapePropSet-getPropertySetInfo();
+if(xShapePropSetInfo-hasPropertyByName(Bookmark))
+{
+xShapePropSet-getPropertyValue( Bookmark ) =
aBookmark;
+}
+
SvXMLElementExport aExp2( *mpSVGExport,
XML_NAMESPACE_NONE, g, sal_True, sal_True );
-mpSVGWriter-WriteMetaFile( aTopLeft, aSize, rMtf,
-0x,
-pElementId,
-rxShape,
-pEmbeddedBitmapsMtf );
+if( !aBookmark.isEmpty() )
+{
+mpSVGExport-AddAttribute( XML_NAMESPACE_NONE,
xlink:href, aBookmark);
+SvXMLElementExport alinkA( *mpSVGExport,
XML_NAMESPACE_NONE, a, sal_True, sal_True );
+mpSVGWriter-WriteMetaFile( aTopLeft, aSize, rMtf,
+0x,
+pElementId,
+rxShape,
+pEmbeddedBitmapsMtf );
+}
+else
+{
+mpSVGWriter-WriteMetaFile( aTopLeft, aSize, rMtf,
+0x,
+pElementId,
+rxShape,
+pEmbeddedBitmapsMtf );
+}
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PUSHED] fdo#47576: Hyperlinks work for SVG Exports
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2957 Approvals: Thorsten Behrens: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2957 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e034effe6c4a5025c27bd6408fd162bf5cf4859 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Moritz Kütt moritz.ku...@web.de Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: vcl/inc
vcl/inc/vcl/help.hxx |6 --
1 file changed, 6 deletions(-)
New commits:
commit 4d05ee2411e4baf13eb9639ffdfd9ce896665396
Author: mhofmann bor...@web.de
Date: Sun Mar 24 15:12:27 2013 +0100
remove unused member maHelpFile and its getter/setter
Change-Id: I97b53be0a6110c6ca736de657cba48baa0445a12
Reviewed-on: https://gerrit.libreoffice.org/2965
Reviewed-by: Thomas Arnhold tho...@arnhold.org
Reviewed-by: Thorsten Behrens tbehr...@suse.com
Tested-by: Thorsten Behrens tbehr...@suse.com
diff --git a/vcl/inc/vcl/help.hxx b/vcl/inc/vcl/help.hxx
index 2ee33c5..b74d802 100644
--- a/vcl/inc/vcl/help.hxx
+++ b/vcl/inc/vcl/help.hxx
@@ -59,16 +59,10 @@ class Window;
class VCL_DLLPUBLIC Help
{
-private:
-OUStringmaHelpFile;
-
public:
Help();
virtual ~Help();
-voidSetHelpFile( const OUString rFileName ) { maHelpFile
= rFileName; }
-const OUString GetHelpFile() const { return maHelpFile; }
-
virtual sal_BoolStart( const OUString rHelpId, const Window* pWindow
);
virtual sal_BoolSearchKeyword( const OUString rKeyWord );
virtual voidOpenHelpAgent( const OString rHelpId );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PUSHED] remove unused member maHelpFile and its getter/setter
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2965 Approvals: Thomas Arnhold: Looks good to me, but someone else must approve Thorsten Behrens: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2965 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97b53be0a6110c6ca736de657cba48baa0445a12 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: mhofmann bor...@web.de Gerrit-Reviewer: Thomas Arnhold tho...@arnhold.org Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sd/source
sd/source/ui/slidesorter/inc/view/SlsTheme.hxx |1
sd/source/ui/slidesorter/inc/view/SlsToolTip.hxx |4 +-
sd/source/ui/slidesorter/view/SlsToolTip.cxx | 34 +--
3 files changed, 22 insertions(+), 17 deletions(-)
New commits:
commit 97107b997a456fc2e471ac64679e1c8a2a12ab09
Author: mhofmann bor...@web.de
Date: Sun Mar 24 15:10:51 2013 +0100
The tooltips of the slide sorter in impress should behave like the toolbar.
When hovering the mouse over a slide its name is displayed in a tooltip.
If you jump with the mouse from slide to slide the new tooltip is displayed
immediately.
Also remove unused member variables and make tooltip delay configurable.
Change-Id: Ia2347d81620f0ced437beaaeb49d8ad7f41e9333
Reviewed-on: https://gerrit.libreoffice.org/2969
Reviewed-by: Thorsten Behrens tbehr...@suse.com
Tested-by: Thorsten Behrens tbehr...@suse.com
diff --git a/sd/source/ui/slidesorter/inc/view/SlsTheme.hxx
b/sd/source/ui/slidesorter/inc/view/SlsTheme.hxx
index 99b089d..a4e03da 100644
--- a/sd/source/ui/slidesorter/inc/view/SlsTheme.hxx
+++ b/sd/source/ui/slidesorter/inc/view/SlsTheme.hxx
@@ -37,7 +37,6 @@ class Properties;
namespace sd { namespace slidesorter { namespace view {
-const int Theme_ToolTipDelay = 1000;
const int Theme_FocusIndicatorWidth = 3;
/** Collection of colors and styles that are used to paint the slide sorter
diff --git a/sd/source/ui/slidesorter/inc/view/SlsToolTip.hxx
b/sd/source/ui/slidesorter/inc/view/SlsToolTip.hxx
index 01bc50e..bc26e73 100644
--- a/sd/source/ui/slidesorter/inc/view/SlsToolTip.hxx
+++ b/sd/source/ui/slidesorter/inc/view/SlsToolTip.hxx
@@ -55,10 +55,10 @@ public:
private:
SlideSorter mrSlideSorter;
model::SharedPageDescriptor mpDescriptor;
-::rtl::OUString msDefaultHelpText;
::rtl::OUString msCurrentHelpText;
sal_uLong mnHelpWindowHandle;
-Timer maTimer;
+Timer maShowTimer;
+Timer maHiddenTimer;
/** Request to show the tool tip.
@param bForce
diff --git a/sd/source/ui/slidesorter/view/SlsToolTip.cxx
b/sd/source/ui/slidesorter/view/SlsToolTip.cxx
index f28aa53..c0babd7 100644
--- a/sd/source/ui/slidesorter/view/SlsToolTip.cxx
+++ b/sd/source/ui/slidesorter/view/SlsToolTip.cxx
@@ -33,13 +33,16 @@ namespace sd { namespace slidesorter { namespace view {
ToolTip::ToolTip (SlideSorter rSlideSorter)
: mrSlideSorter(rSlideSorter),
- msDefaultHelpText(),
msCurrentHelpText(),
mnHelpWindowHandle(0),
- maTimer()
+ maShowTimer(),
+ maHiddenTimer()
{
-maTimer.SetTimeout(Theme_ToolTipDelay);
-maTimer.SetTimeoutHdl(LINK(this, ToolTip, DelayTrigger));
+SharedSdWindow window = rSlideSorter.GetContentWindow();
+const HelpSettings rHelpSettings =
window-GetSettings().GetHelpSettings();
+maShowTimer.SetTimeout(rHelpSettings.GetTipDelay());
+maShowTimer.SetTimeoutHdl(LINK(this, ToolTip, DelayTrigger));
+maHiddenTimer.SetTimeout(rHelpSettings.GetTipDelay());
}
@@ -47,19 +50,23 @@ ToolTip::ToolTip (SlideSorter rSlideSorter)
ToolTip::~ToolTip (void)
{
-maTimer.Stop();
+maShowTimer.Stop();
+maHiddenTimer.Stop();
Hide();
}
-
-
void ToolTip::SetPage (const model::SharedPageDescriptor rpDescriptor)
{
if (mpDescriptor != rpDescriptor)
{
-maTimer.Stop();
-Hide();
+maShowTimer.Stop();
+bool bWasVisible = Hide();
+
+if (bWasVisible)
+{
+maHiddenTimer.Start();
+}
mpDescriptor = rpDescriptor;
@@ -79,13 +86,12 @@ void ToolTip::SetPage (const model::SharedPageDescriptor
rpDescriptor)
sHelpText += OUString::number(mpDescriptor-GetPageIndex()+1);
}
-msDefaultHelpText = sHelpText;
msCurrentHelpText = sHelpText;
-Show(false);
+// show new tooltip immediately, if last one was recently hidden
+Show(maHiddenTimer.IsActive());
}
else
{
-msDefaultHelpText = OUString();
msCurrentHelpText = OUString();
}
}
@@ -98,7 +104,7 @@ void ToolTip::Show (const bool bNoDelay)
if (bNoDelay)
DoShow();
else
-maTimer.Start();
+maShowTimer.Start();
}
@@ -106,7 +112,7 @@ void ToolTip::Show (const bool bNoDelay)
void ToolTip::DoShow (void)
{
-if (maTimer.IsActive())
+if (maShowTimer.IsActive())
{
// The delay timer is active. Wait for it to trigger the showing of
// the tool tip.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/dialog/filedlghelper.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 1b6b836411c67ad53c17d6dc5ebceaf62d9d9a5a
Author: Julien Nabet serval2...@yahoo.fr
Date: Sun Mar 24 22:11:45 2013 +0100
coverity#704302 Logically dead code
Change-Id: Ibdea2ca5225ac13e80b0a76cd0fd79e463c32e37
Reviewed-on: https://gerrit.libreoffice.org/2977
Reviewed-by: Thorsten Behrens tbehr...@suse.com
Tested-by: Thorsten Behrens tbehr...@suse.com
diff --git a/sfx2/source/dialog/filedlghelper.cxx
b/sfx2/source/dialog/filedlghelper.cxx
index 164bc7e..6108a62 100644
--- a/sfx2/source/dialog/filedlghelper.cxx
+++ b/sfx2/source/dialog/filedlghelper.cxx
@@ -529,7 +529,7 @@ void FileDialogHelper_Impl::updateSelectionBox()
for ( sal_uInt32 nCtrl = 0; nCtrl nCount; ++nCtrl )
if ( aCtrlList[ nCtrl ] == SelectionBox )
{
-bSelectionBoxFound = sal_False;
+bSelectionBoxFound = sal_True;
break;
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PUSHED] The tooltips of the slide sorter in impress should behave li...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2969 Approvals: Thorsten Behrens: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2969 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2347d81620f0ced437beaaeb49d8ad7f41e9333 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: mhofmann bor...@web.de Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] coverity#704302 Logically dead code
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2977 Approvals: Thorsten Behrens: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2977 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibdea2ca5225ac13e80b0a76cd0fd79e463c32e37 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Julien Nabet serval2...@yahoo.fr Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 3 commits - basic/source idlc/source sd/source svx/inc svx/source vcl/generic
basic/source/basmgr/basmgr.cxx |6 +--
idlc/source/astunion.cxx |6 +--
sd/source/ui/inc/SdUnoSlideView.hxx | 17
sd/source/ui/view/drviews6.cxx |2 -
sd/source/ui/view/drviewsc.cxx |2 -
svx/inc/svx/sdr/event/eventhandler.hxx |2 -
svx/inc/svx/view3d.hxx | 12 +++---
svx/source/engine3d/view3d.cxx | 28 +++---
svx/source/items/algitem.cxx |4 +-
svx/source/items/grfitem.cxx |4 +-
svx/source/items/hlnkitem.cxx|2 -
svx/source/items/numinf.cxx |3 -
svx/source/sdr/event/eventhandler.cxx|2 -
svx/source/sdr/properties/e3dsceneproperties.cxx |8 ++--
svx/source/sdr/properties/textproperties.cxx | 10 ++---
svx/source/stbctrls/pszctrl.cxx | 46 +++
vcl/generic/fontmanager/fontmanager.cxx |9 +---
17 files changed, 70 insertions(+), 93 deletions(-)
New commits:
commit 1e50f7892705c64db0ffec06b651cd280e9a7f8f
Author: Takeshi Abe t...@fixedpoint.jp
Date: Mon Mar 25 10:51:15 2013 +0900
sal_Bool to bool
Change-Id: Ibc63340b3ae431c7cdac78893dbdd1989ebe5ff9
diff --git a/basic/source/basmgr/basmgr.cxx b/basic/source/basmgr/basmgr.cxx
index 70775ae..8f52b1f 100644
--- a/basic/source/basmgr/basmgr.cxx
+++ b/basic/source/basmgr/basmgr.cxx
@@ -256,7 +256,7 @@ void SAL_CALL BasMgrContainerListenerImpl::disposing( const
lang::EventObject S
void SAL_CALL BasMgrContainerListenerImpl::elementInserted( const
container::ContainerEvent Event )
throw( uno::RuntimeException )
{
-sal_Bool bLibContainer = maLibName.isEmpty();
+bool bLibContainer = maLibName.isEmpty();
OUString aName;
Event.Accessor = aName;
@@ -308,7 +308,7 @@ void SAL_CALL BasMgrContainerListenerImpl::elementReplaced(
const container::Con
// Replace not possible for library container
#ifdef DBG_UTIL
-sal_Bool bLibContainer = maLibName.isEmpty();
+bool bLibContainer = maLibName.isEmpty();
#endif
DBG_ASSERT( !bLibContainer, library container fired elementReplaced());
@@ -336,7 +336,7 @@ void SAL_CALL BasMgrContainerListenerImpl::elementRemoved(
const container::Cont
OUString aName;
Event.Accessor = aName;
-sal_Bool bLibContainer = maLibName.isEmpty();
+bool bLibContainer = maLibName.isEmpty();
if( bLibContainer )
{
StarBASIC* pLib = mpMgr-GetLib( aName );
diff --git a/sd/source/ui/view/drviews6.cxx b/sd/source/ui/view/drviews6.cxx
index 573190b..8a136d7 100644
--- a/sd/source/ui/view/drviews6.cxx
+++ b/sd/source/ui/view/drviews6.cxx
@@ -583,7 +583,7 @@ void DrawViewShell::FuTemp04(SfxRequest rReq)
mpDrawView-SdrEndTextEdit();
if(GetActiveWindow())
GetActiveWindow()-EnterWait();
-mpDrawView-End3DCreation(sal_True);
+mpDrawView-End3DCreation(true);
Cancel();
rReq.Ignore();
if(GetActiveWindow())
diff --git a/sd/source/ui/view/drviewsc.cxx b/sd/source/ui/view/drviewsc.cxx
index 6694393..bcdd2b9 100644
--- a/sd/source/ui/view/drviewsc.cxx
+++ b/sd/source/ui/view/drviewsc.cxx
@@ -406,7 +406,7 @@ void DrawViewShell::FuTemp03(SfxRequest rReq)
}
WaitObject aWait( (Window*)GetActiveWindow() );
-mpDrawView-ConvertMarkedObjTo3D(sal_True);
+mpDrawView-ConvertMarkedObjTo3D(true);
}
}
diff --git a/svx/inc/svx/sdr/event/eventhandler.hxx
b/svx/inc/svx/sdr/event/eventhandler.hxx
index b5ac78b..91ac549 100644
--- a/svx/inc/svx/sdr/event/eventhandler.hxx
+++ b/svx/inc/svx/sdr/event/eventhandler.hxx
@@ -96,7 +96,7 @@ namespace sdr
virtual void ExecuteEvents();
// for control
-sal_Bool IsEmpty() const;
+bool IsEmpty() const;
};
} // end of namespace event
} // end of namespace sdr
diff --git a/svx/inc/svx/view3d.hxx b/svx/inc/svx/view3d.hxx
index 72420f2..7f4d523 100644
--- a/svx/inc/svx/view3d.hxx
+++ b/svx/inc/svx/view3d.hxx
@@ -69,13 +69,13 @@ protected:
void InitView();
-void ImpCreate3DObject(E3dScene* pScene, SdrObject* pObj, sal_Bool
bExtrude, double fDepth, basegfx::B2DHomMatrix rLatheMat);
-void ImpCreateSingle3DObjectFlat(E3dScene* pScene, SdrObject* pObj,
sal_Bool bExtrude, double fDepth, basegfx::B2DHomMatrix rLatheMat);
+void ImpCreate3DObject(E3dScene* pScene, SdrObject* pObj, bool bExtrude,
double fDepth, basegfx::B2DHomMatrix rLatheMat);
+void ImpCreateSingle3DObjectFlat(E3dScene* pScene, SdrObject* pObj, bool
bExtrude, double fDepth, basegfx::B2DHomMatrix rLatheMat);
void ImpChangeSomeAttributesFor3DConversion(SdrObject* pObj);
void
Epson Printer
To : Sales Manager, I have an Tender order ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] about moztrap attachment missing :(
Hi Thomas, On Mon, Mar 25, 2013 at 05:10:51AM +0100, Thomas Hackert wrote: Is there a possibility to set my rights in Moztrap so, that I can translate the Germanophone Test Cases? I was the guy, who started the discussion on the Germanophone discuss ML about manual testing (Moztrap vs. Litmus) to contribute (again) more to the QA of LO ... Though due to my job I am only able to contribute on weekends a little bit ... :( But I would like to translate some of the test cases to relieve N00bs without (or too less) English knowledge their contribution to QA ... ;) Of course, I saw your previous discussion as well. Thanks and your account has been upgraded to test manager, who's able to edit and create new cases. Please be aware to let the mailing list know if you want to revise more than test cases (test suite, version etc.). Ideally we do not frequently adjust other settings except for runs and test cases. Please take a bit time to look through this wiki page, which could be helpful for a quick start: https://wiki.documentfoundation.org/QA/Testing/Test_Case#Add_a_new_test_case For thorough understanding of Moztrap management, please consult: https://moztrap.readthedocs.org/en/1.3/userguide/index.html To summarize what is *very* *important* to add a test cases in LO Moztrap: 1. The test case is categorized into proper test suite (Priority 1/2/3/4) 2. The test cases are needed to tag with priority and component. i.e for each test case, we need at least *2* tags like writer, p1, calc, p2. Visist the tags management view to see how many tags are available. http://manual-test.libreoffice.org/manage/tags/ Though Your permission is allow to add extra tags, the component and priority tags are very important for our test cases filter from practice. 3. A new test case has to add to a Version 0 and checked as later versions, so that all the versions of the test case would have the new test case included. Any questions please do not hesitate to ask :) And I miss a function to skip tests in Moztrap ... :( Is it possible to implement it? Sorry I did not notice features like that. How does that work as? Would you specify a little bit more. Best wishes, Yifan -- Yifan Jiang Libreoffice / SUSE Contact: yifan - irc.freenode.net/libreoffice = http://www.libreoffice.org/ http://www.documentfoundation.org/ ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 55189] TDF Site [de] (German): 2 pages reference to each other
https://bugs.freedesktop.org/show_bug.cgi?id=55189 Kü kuehl.christ...@googlemail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Kü kuehl.christ...@googlemail.com --- This bug has been resolved since k-j changed the link in 2012-09-24. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45999] FILESAVE: Hebrew comments/notes appear as squares in MS Word when saving in doc (work on docx)
https://bugs.freedesktop.org/show_bug.cgi?id=45999 --- Comment #18 from Boaz Dodin boaz.do...@gmail.com --- (In reply to comment #15) NO, It isn't resolved. I install new LO: 4.0.1.2 create document with Hebrew comments and save it in both doc and docx: results: doc: letters appear in wrong order. docx: words appear in wrong order. attach test of now @Nadav - Windows version? M. Office version? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62685] New: Changing space for Illustration X to non-breaking space
https://bugs.freedesktop.org/show_bug.cgi?id=62685 Priority: medium Bug ID: 62685 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Changing space for Illustration X to non-breaking space Severity: normal Classification: Unclassified OS: All Reporter: kuehl.christ...@googlemail.com Hardware: All Status: UNCONFIRMED Version: unspecified Component: Writer Product: LibreOffice When you insert a cross-reference for an illustration with Category and Number this reference is be splitted when it is at the line end. existing behavior: For an example see the graphic at Illustration 1 below expected behavior: For an example see the graphic at Illustration 1 below As solution the space between category an number should be a non-braking space. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62645] VIEWING - Libmariadb connector fails to display data in mysql server registered VIEW
https://bugs.freedesktop.org/show_bug.cgi?id=62645 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Severity|major |normal Priority|high|medium --- Comment #17 from Alex Thurgood ipla...@yahoo.co.uk --- Damn, I could've sworn that this used to work, BUT... I just tested this against MySQL 5.5, LO 334 and Oracle 101 Mysql connector on OSX and I see exactly the same problem. Reducing severity, and apologizing profusely for the noise. Just another run of the mill Base bug - sorry peeps. Alex -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 61752] [Export to PDF] Add option to export document type in Impress (Slides, Handouts, Notes and Outline)
https://bugs.freedesktop.org/show_bug.cgi?id=61752 A stgohi-lob...@yahoo.de changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Severity|normal |enhancement CC||stgohi-lob...@yahoo.de Ever confirmed|0 |1 --- Comment #1 from A stgohi-lob...@yahoo.de --- Could you please give more information to reproduce it. What do you mean with the second paragraph. In the menu item FILE you can find a function EXPORT AS PDF where you can also change the options of this PDF export or do you mean something else? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62679] FILESAVE: Deleted Outline text line exceeding rectangle shape rises from the dead
https://bugs.freedesktop.org/show_bug.cgi?id=62679
Rainer Bielefeld libreoff...@bielefeldundbuss.de changed:
What|Removed |Added
Status|NEEDINFO|NEW
Priority|high|medium
Summary|Custom Animation still does |FILESAVE: Deleted Outline
|not work properly |text line exceeding
||rectangle shape rises from
||the dead
--- Comment #9 from Rainer Bielefeld libreoff...@bielefeldundbuss.de ---
I think I am some closer to the root. Based on reporters sample 2013-03-23
20:38 UTC, Dave Nadler I did several tests and now found the roots of the
problem. With the attachment you will find a description how to create your
own sample document from the scratch. You will find my sample attached with
next comment.
Steps how to reproduce NewSample.odp with server installation of LibO 4.0.1.2
release - German UI / German Locale [Build ID:
84102822e3d61eb989ddd325abf1ac077904985)] {tinderbox: @6, pull time
2013-02-28 08:53(?)} on German WIN7 Home Premium (64bit) with newly created
user profile ….\LibreOffice\4012\
1. Open Sample Document
2. Double Click blue rectangle
Edit mode
3. control+end for caret position behind Line 10
4. Backspace, hold and / or pressuntil Lines 10 is deleted
and caret flashes behind Line 9
5. Save with new name - close - reopen
Expected: Line 10 deleted
Actual: Line 10 has reappeared
For a new test you can increase rectangle hight after step 1 by dragging bottom
border of rectangle down far below Line 10, what will make the problem
disappear.
Already [Reproducible] with
* server installation of LOdev 4.0.0.1+ - ENGLISH UI / German Locale
[Build ID: 072fc07107e9849ed7050d18575b42049db9657)] {tinderbox: Win-x86@6,
pull time 2013-01-16 09:31:57} on German WIN7 Home Premium (64bit) with own
separate User Profile
* 4.0.0.3
Was Still OK with
* Server installation of Version 4.1.0.0.alpha0+ (Build ID:
6a393297ce6d99bbc4edefbf01ab9c5c6f0eff8)
TinderBox: Win-x86@6, Branch:master, Time: 2013-01-04_01:06:01
* unzipped installation of LOdev 4.0.0.0.alpha1+ - ENGLISH UI / German
Locale [Build ID: af60316514f3ae3d4c475819bf86f2af837171e)] {tinderbox:
Win-x86@6, pull time 2012-11-23 22:10:31} on German WIN7 Home Premium (64bit)
with own separate User Profile
@David:
Please also never touch Status dropdown!
The only thing we need is a clear, detailed and sound description how to
reproduce that what you consider to be a bug, nothing else.
This one does not need any more input by you.
--
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62645] VIEWING - internally shipped mysqlcppconn can't handle MYSQL_TYPE_NEWDATE
https://bugs.freedesktop.org/show_bug.cgi?id=62645 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Summary|VIEWING - Libmariadb|VIEWING - internally |connector fails to display |shipped mysqlcppconn can't |data in mysql server|handle MYSQL_TYPE_NEWDATE |registered VIEW | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62645] VIEWING - internally shipped mysqlcppconn can't handle MYSQL_TYPE_NEWDATE
https://bugs.freedesktop.org/show_bug.cgi?id=62645 --- Comment #18 from Alex Thurgood ipla...@yahoo.co.uk --- Changed title to reflect (I hope) the real situation as I understand it. If it is wrong, please correct. Alex -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 61720] SLIDESHOW: Wrong animation on slide show
https://bugs.freedesktop.org/show_bug.cgi?id=61720 A stgohi-lob...@yahoo.de changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #2 from A stgohi-lob...@yahoo.de --- reproducible with LO 4.0.1.2 (Win7 Home, 64bit) The picture animation is buggy. In MSO 2007 it is shown correctly. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62645] VIEWING - internally shipped mysqlcppconn can't handle MYSQL_TYPE_NEWDATE
https://bugs.freedesktop.org/show_bug.cgi?id=62645 --- Comment #19 from Alex Thurgood ipla...@yahoo.co.uk --- (In reply to comment #16) Alex, are you *sure* this view works with previous versions of LibreOffice, connecting to the *same* MySQL server (MYSQL_TYPE_NEWDATE is used only by versions 5.0 and later)? Well I was sure, but as I have just reported against LO334, I must have done something to either the query or the view or the server version in the past instead... :-/ Sorry once again (kicks self). Alex -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57310] SLIDESHOW: slide show shows only a black screen
https://bugs.freedesktop.org/show_bug.cgi?id=57310 A stgohi-lob...@yahoo.de changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #2 from A stgohi-lob...@yahoo.de --- Does this issue still persist for you with the latest release of LO? Could you now reproduce this bug with 3.6.5.2 and do you now have more information to reproduce it? Or could ask a friend to reproduce this on his/her computer or attach a sample file to reproduce it? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50466] PRINTING: Unwanted white grid inside heart and two fire squares outside
https://bugs.freedesktop.org/show_bug.cgi?id=50466 --- Comment #17 from Alex Thurgood ipla...@yahoo.co.uk --- Tested on : Version 4.1.0.0.alpha0+ (Build ID: edf57013463eff6d3b40d8d5d933577f0e6cf8e) Downloaded ODG file. Opened in Draw. Cmd-P to print to networked colour laser printer Print result : fine, no overlap, nothing outside the heart shape, heart shape itself completely filled with bitmap. Can not reproduce on OSX 10.8.2. Alex -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62645] VIEWING - internally shipped mysqlcppconn can't handle MYSQL_TYPE_NEWDATE
https://bugs.freedesktop.org/show_bug.cgi?id=62645 Lionel Elie Mamane lio...@mamane.lu changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |NOTOURBUG --- Comment #20 from Lionel Elie Mamane lio...@mamane.lu --- This is a bug in MySQL Connector/C++. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57001] EDITING: Characters get overwritten - no text entry possible
https://bugs.freedesktop.org/show_bug.cgi?id=57001 A stgohi-lob...@yahoo.de changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||stgohi-lob...@yahoo.de Ever confirmed|0 |1 --- Comment #3 from A stgohi-lob...@yahoo.de --- This seems to be really strange. But, I have currently no idea to reproduce it. Does this issue only occur with this specific presentation file or also with any other new presentation file? Does this issue still persist for you with the latest release of LO? Could you ask a friend to reproduce this on his/her computer or attach a sample file to reproduce it? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 61872] SLIDESHOW: Scanned images are displayed distorted with hardware acceleration enabled
https://bugs.freedesktop.org/show_bug.cgi?id=61872 --- Comment #3 from A stgohi-lob...@yahoo.de --- not reproducible with LO 4.0.1.2 (Win7 Home, 64bit), looks fine in presentation view and edit mode with and without hardware acceleration Does this issue still persist for you with the latest release of LO? Can anybody else confirm this behavior? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50466] PRINTING: Unwanted white grid inside heart and two fire squares outside
https://bugs.freedesktop.org/show_bug.cgi?id=50466 --- Comment #18 from Alex Thurgood ipla...@yahoo.co.uk --- Confirming on LO 3.6.5.2 on Windows XP SP3 On screen within LO the heart is displayed correctly filled. When sending to printer, Print Preview displays ragged, almost square shaped heart boundary. Printed result is a square filled with the fire motif bitmap. Alex -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62196] EDITING: copy-paste from non-LibO-text-source pastes previous clipboard contents
https://bugs.freedesktop.org/show_bug.cgi?id=62196 --- Comment #3 from grofaty grof...@hotmail.com --- I have been using LibreOffice on Windows XP for years and never experiance this problem. Currently I am using LibreOffice 4.0.1.2 on Windows XP, no problem at all. It looks to me that user may have somekind of clipboard manager installed that does not work fine with LibreOffice. I suggest to do the following: 1. Close as many programs as possible. 2. Open Notepad and LibreOffice. 3. Try to copy/paste text between them and make sure the problem appears. 4. Then open cmd window and execute command: tasklist Note: This program lists the processes that are currently running. I hope we can spot some process that is interfering with LibreOffice copy/paste. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50466] PRINTING: Unwanted white grid inside heart and two fire squares outside
https://bugs.freedesktop.org/show_bug.cgi?id=50466 --- Comment #19 from Alex Thurgood ipla...@yahoo.co.uk --- The white line grid seems to result from the placement of the tiled bitmaps (on Windows). Tested on 2 different printers : Samsung CLX 3175 FN Colour Network Laser Kyocera FS C5150DN Colour Network Laser Alex -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49251] Impress FILEOPEN, FORMATTING: pptx opens with wrong animation
https://bugs.freedesktop.org/show_bug.cgi?id=49251 A stgohi-lob...@yahoo.de changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #5 from A stgohi-lob...@yahoo.de --- reproducible with LO 4.0.1.2 (Win7 Home, 64bit) no crash, but an extra click is necessary, while in MSO 2007 it is shown correctly without additional click -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48918] FORMATTING: grow / shrink custom animation effect mstill missing
https://bugs.freedesktop.org/show_bug.cgi?id=48918 A stgohi-lob...@yahoo.de changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62659] CRASH - Template Manager dumps core on closing after browsing templates
https://bugs.freedesktop.org/show_bug.cgi?id=62659 --- Comment #7 from Alex Thurgood ipla...@yahoo.co.uk --- (In reply to comment #6) Reproducible for me under Ubuntu 12.04 x86-64 with master (Build ID: 97edb75d08e35eb014037fa6a4f93eeb16e1127) and LibreOffice 4.0.3.0+ (Build ID: 9296cf4088a0637f0326803fe220816ebc8daf2). Even if I launch the Template Manager from the StartCenter, when I close it LibreOffice exit. It is not clear for me if it is a crash because I do not get any error message in the terminal as for a normal exit. Best regards. JBF Hi Jean-Baptiste, I see the same as you on Linux Mint 13 KDE edition. The whole app just shuts down, no error messages in konsole (perhaps in my case, that has something to do with KDE integration of LO, or rather, the lack of it). I get no core output or hs_err_pid.log either on Linux Mint 13 KDE. Alex -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62686] New: FILEOPEN: Delay
https://bugs.freedesktop.org/show_bug.cgi?id=62686 Priority: medium Bug ID: 62686 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: FILEOPEN: Delay Severity: normal Classification: Unclassified OS: Windows (All) Reporter: muratylm...@gmail.com Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 4.0.1.2 release Component: UI Product: LibreOffice Problem description: There is a delay when the program (excel word whatever) starts. Version 3.6.5 was quicker! Steps to reproduce: 1. 2. 3. Current behavior: Expected behavior: Operating System: Windows 7 Version: 4.0.1.2 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57543] VIEWING: Slide icons in outline view not correctly displayed
https://bugs.freedesktop.org/show_bug.cgi?id=57543 A stgohi-lob...@yahoo.de changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from A stgohi-lob...@yahoo.de --- Do you have a sample file which you could attach? Unfortunately, I can not yet reproduce it with LO 4.0.1.2 (Win7 Home, 64bit). Could anybody else confirm this issue? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57001] EDITING: Characters get overwritten - no text entry possible
https://bugs.freedesktop.org/show_bug.cgi?id=57001 --- Comment #4 from bugquestcon...@online.de --- @A thanks for working on this topic. I understand that you need to reproduce it. Just in the last days it happened again and I have no clue on what was the trigger. I could possibly observe and note - which applications are running - what template was used - was the file once save in a format different than odp and opened from there Please comment on above and feel free to add more parameters. I will try to collect information as much as possible. Please understand that I have periods where I work every day with Impress and then there are periods without Impress work. Let's get this bug -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57580] Impress' custom animations raised with click don't work fine when mouse button is pressed quickly
https://bugs.freedesktop.org/show_bug.cgi?id=57580 --- Comment #1 from A stgohi-lob...@yahoo.de --- not reproducible with LO 4.0.1.2 (Win7 Home, 64bit) Does this issue still persist for you with the latest release of LO? Can anybody else confirm this behavior? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62679] FILESAVE: Deleted Outline text line exceeding rectangle shape rises from the dead
https://bugs.freedesktop.org/show_bug.cgi?id=62679 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Attachment #76949|0 |1 is obsolete|| Attachment #76952|0 |1 is obsolete|| --- Comment #10 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- Created attachment 76957 -- https://bugs.freedesktop.org/attachment.cgi?id=76957action=edit Simple Sample Steps how to create: a) Launch LibO b) from LibO Start Center created new Presentation without using wizard c) Below title text field insert Rectangle wirh 1/2 Size of Text field d) Click Rectangle, - Rightclick - Text - Test Anchtot top left ok e) f2 for edit mode, Click 'Align Left' icon in Formatting Toolbar f) Click 'Outline' icon in Formatting Toolbar Bullet appears g) Type Line 1 Enter and repeat as often (with new line Number) as necessary until 2 Lines exceed rectangle at the bottom h) click outside rectangle i) click Rectangle j) 'Rightclick - Text - activate Word Wrap in Text Shape' k) Save, Close, Reopen and do tests as per comment above I obsolete reporter's sample because more simple reduced sample document is available. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57580] Impress' custom animations raised with click don't work fine when mouse button is pressed quickly
https://bugs.freedesktop.org/show_bug.cgi?id=57580 A stgohi-lob...@yahoo.de changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #2 from A stgohi-lob...@yahoo.de --- Really strange, I tried it once more a little bit faster and now I could reproduce it with LO 4.0.1.2 (Win7 Home, 64bit), but you have to click very fast, otherwise you can't see it -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57581] [EDITING] Animations sets for a text box with several paragraphs don't affect new paragraphs
https://bugs.freedesktop.org/show_bug.cgi?id=57581 A stgohi-lob...@yahoo.de changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from A stgohi-lob...@yahoo.de --- reproducible with LO 4.0.1.2 (Win7 Home, 64bit) I would suppose that this is a bug, because if the text box has as a whole an animation, then added lines should also have this animation. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57586] Rehearsing timings doesn't work with slides with animations
https://bugs.freedesktop.org/show_bug.cgi?id=57586 A stgohi-lob...@yahoo.de changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from A stgohi-lob...@yahoo.de --- reproducible with LO 4.0.1.2 (Win7 Home, 64bit) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57587] Rehearsed timmings are stored nowhere
https://bugs.freedesktop.org/show_bug.cgi?id=57587 A stgohi-lob...@yahoo.de changed: What|Removed |Added Status|UNCONFIRMED |NEW Severity|normal |enhancement Ever confirmed|0 |1 --- Comment #1 from A stgohi-lob...@yahoo.de --- marked as enhancement -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57268] : Cannot save new file on webdav
https://bugs.freedesktop.org/show_bug.cgi?id=57268 --- Comment #3 from l...@pontsystems.eu --- I can also confirm this bug. I've tried with OwnCloud (and Ubuntu 12.10 + LibreOffice 4.0.1), https, and get the same errors (Error while saving... does not exists) when tried to save into a sub folder. When I try to save into the OwnCloud main folder, LibreOffice crashes. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 55353] Styles and formatting icon and field next to fonts list
https://bugs.freedesktop.org/show_bug.cgi?id=55353 A stgohi-lob...@yahoo.de changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47309] EDITING: Scrollbars let move the slide almost out of view space
https://bugs.freedesktop.org/show_bug.cgi?id=47309 A stgohi-lob...@yahoo.de changed: What|Removed |Added Status|UNCONFIRMED |NEW Severity|normal |enhancement Ever confirmed|0 |1 --- Comment #9 from A stgohi-lob...@yahoo.de --- marked as enhancement request -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62687] New: EDITING: Deleted Outline what of text exceeding shape reappears after save - close - reopen
https://bugs.freedesktop.org/show_bug.cgi?id=62687 Priority: medium Bug ID: 62687 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: EDITING: Deleted Outline what of text exceeding shape reappears after save - close - reopen Severity: normal Classification: Unclassified OS: Windows (All) Reporter: libreoff...@bielefeldundbuss.de Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 4.1.0.0.alpha0+ Master Component: Presentation Product: LibreOffice found that during my research for Bug 62679 - FILESAVE: Deleted Outline text line exceeding rectangle shape rises from the dead: Steps to reproduce with Version 4.1.0.0.alpha0+ (Build ID: 094bab7f9097fba62800d3dd578bd42640d8c6e) TinderBox: Win-x86@6, Branch:master, Time: 2013-03-18_01:35:56: 1. Open Attachment 76957 for Bug 62679 2. Click Rectangle, f2 for edit mode 3. control+a to activate edit mode 4. Click 'Outline icon' in formatting toolbar to remove outline bullets outline bullets disappear 5. 'Save - Close - Reopen' Expected behavior: no outline Current behavior: Outline bullets are back That will not happen if the rectangle is big enough so that all outline text is in the rectangle I did not test with what version that started, but I am pretty sure that this one has the same roots like Bug 62679 Operating System: Windows 7 Version: 4.1.0.0.alpha0+ Master -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
