[Libreoffice-commits] core.git: extensions/source filter/source include/svx m4/libgcrypt.m4 qadevOOo/tests sal/osl sal/textenc sc/source svtools/source sw/source sw/uiconfig xmloff/source
extensions/source/ole/unoconversionutilities.hxx|2 +- filter/source/xslt/odf2xhtml/export/xhtml/opendoc2xhtml.xsl |4 ++-- include/svx/msdffdef.hxx|2 +- m4/libgcrypt.m4 |4 ++-- qadevOOo/tests/java/ifc/xml/sax/_XDocumentHandler.java |2 +- sal/osl/unx/file_path_helper.hxx|2 +- sal/textenc/tcvtlat1.tab|4 ++-- sc/source/core/data/column4.cxx |2 +- svtools/source/config/colorcfg.cxx |2 +- sw/source/uibase/docvw/PostItMgr.cxx|2 +- sw/uiconfig/swriter/ui/inputwinmenu.ui |2 +- xmloff/source/chart/SchXMLExport.cxx|2 +- 12 files changed, 15 insertions(+), 15 deletions(-) New commits: commit 0501869949b65b27303a41fd235a6ec32a4c90a7 Author: Andrea GelminiDate: Wed Aug 16 22:21:16 2017 +0200 Fix typos Change-Id: I795059109e23800987cda6f04c58ab18c488ad07 Reviewed-on: https://gerrit.libreoffice.org/41242 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/extensions/source/ole/unoconversionutilities.hxx b/extensions/source/ole/unoconversionutilities.hxx index 58a2d9dcfb27..194bdf6942ff 100644 --- a/extensions/source/ole/unoconversionutilities.hxx +++ b/extensions/source/ole/unoconversionutilities.hxx @@ -1952,7 +1952,7 @@ void UnoConversionUtilities::dispatchExObject2Sequence( const VARIANTARG* pva OLECHAR const * sLength= L"length"; -// Get the length of the array. Can also be obtained throu GetNextDispID. The +// Get the length of the array. Can also be obtained through GetNextDispID. The // method only returns DISPIDs of the array data. Their names are like "0", "1" etc. if( FAILED( hr= pdispEx->GetIDsOfNames(IID_NULL, const_cast(), 1, LOCALE_USER_DEFAULT, ))) throw BridgeRuntimeError("[automation bridge] UnoConversionUtilities::dispatchExObject2Sequence \n" diff --git a/filter/source/xslt/odf2xhtml/export/xhtml/opendoc2xhtml.xsl b/filter/source/xslt/odf2xhtml/export/xhtml/opendoc2xhtml.xsl index 4397bdc610d1..2fa20efbf7cf 100644 --- a/filter/source/xslt/odf2xhtml/export/xhtml/opendoc2xhtml.xsl +++ b/filter/source/xslt/odf2xhtml/export/xhtml/opendoc2xhtml.xsl @@ -130,7 +130,7 @@ - + @@ -159,7 +159,7 @@ - + Parameter dpi: Parameter metaFileURL: Parameter stylesFileURL: diff --git a/include/svx/msdffdef.hxx b/include/svx/msdffdef.hxx index afabc5ca7c31..0c62f5e6d0d2 100644 --- a/include/svx/msdffdef.hxx +++ b/include/svx/msdffdef.hxx @@ -613,7 +613,7 @@ enum MSO_BlipFlags { /* Or the following flags with any of the above. */ mso_blipflagDontSave = 4, // A "dont" is the depression in the metal // body work of an automobile caused when a - // cyclist violently thrusts his or her nose + // cyclist violently trusts his or her nose // at it, thus a DontSave is another name for // a cycle lane. mso_blipflagDoNotSave = 4, // For those who prefer English diff --git a/m4/libgcrypt.m4 b/m4/libgcrypt.m4 index 831dc0c6f439..2c79027c7894 100644 --- a/m4/libgcrypt.m4 +++ b/m4/libgcrypt.m4 @@ -13,9 +13,9 @@ dnl implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. dnl AM_PATH_LIBGCRYPT([MINIMUM-VERSION, dnl [ACTION-IF-FOUND [, ACTION-IF-NOT-FOUND ]]]) dnl Test for libgcrypt and define LIBGCRYPT_CFLAGS and LIBGCRYPT_LIBS. -dnl MINIMUN-VERSION is a string with the version number optionalliy prefixed +dnl MINIMUM-VERSION is a string with the version number optionalliy prefixed dnl with the API version to also check the API compatibility. Example: -dnl a MINIMUN-VERSION of 1:1.2.5 won't pass the test unless the installed +dnl a MINIMUM-VERSION of 1:1.2.5 won't pass the test unless the installed dnl version of libgcrypt is at least 1.2.5 *and* the API number is 1. Using dnl this features allows to prevent build against newer versions of libgcrypt dnl with a changed API. diff --git a/qadevOOo/tests/java/ifc/xml/sax/_XDocumentHandler.java b/qadevOOo/tests/java/ifc/xml/sax/_XDocumentHandler.java index 8767e15f07d1..27daceaa80ce 100644 --- a/qadevOOo/tests/java/ifc/xml/sax/_XDocumentHandler.java +++ b/qadevOOo/tests/java/ifc/xml/sax/_XDocumentHandler.java @@ -150,7 +150,7 @@ public class _XDocumentHandler extends MultiMethodTest { if (targetDocSet == null){ log.println("object relation
[Libreoffice-bugs] [Bug 109534] fileopen docx unable to open document
https://bugs.documentfoundation.org/show_bug.cgi?id=109534 raalchanged: What|Removed |Added Version|unspecified |5.3.0.0.alpha1+ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109534] fileopen docx unable to open document
https://bugs.documentfoundation.org/show_bug.cgi?id=109534 --- Comment #6 from raal--- No crash in Version: 6.0.0.0.alpha0+ Build ID: 791f93e ( build from 17.8.2017) android 5.0.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/source framework/source sdext/source vcl/unx writerfilter/source
cui/source/options/optaboutconfig.cxx |2 +- framework/source/services/desktop.cxx |2 +- framework/source/services/frame.cxx |2 +- sdext/source/presenter/PresenterHelpView.cxx|2 +- vcl/unx/generic/gdi/gdiimpl.cxx |2 +- writerfilter/source/ooxml/OOXMLDocumentImpl.cxx |2 +- 6 files changed, 6 insertions(+), 6 deletions(-) New commits: commit 713c80b46053567977b53651ee057ce7d6f84bd3 Author: Andrea GelminiDate: Thu Aug 17 23:42:19 2017 +0200 Fix typos Change-Id: If13c1408a3e597c6f9b21d209722ef6bc87c0c94 Reviewed-on: https://gerrit.libreoffice.org/41270 Reviewed-by: Julien Nabet Tested-by: Julien Nabet diff --git a/cui/source/options/optaboutconfig.cxx b/cui/source/options/optaboutconfig.cxx index 2514d8a40622..0fe009240837 100644 --- a/cui/source/options/optaboutconfig.cxx +++ b/cui/source/options/optaboutconfig.cxx @@ -229,7 +229,7 @@ void CuiAboutConfigTabPage::Reset() m_pPrefBox->SetUpdateMode(false); Reference< XNameAccess > xConfigAccess = getConfigAccess( "/", false ); -//Load all XNameAcces to m_prefBoxEntries +//Load all XNameAccess to m_prefBoxEntries FillItems( xConfigAccess, nullptr, 0, true ); //Load xConfigAccess' children to m_prefBox FillItems( xConfigAccess ); diff --git a/framework/source/services/desktop.cxx b/framework/source/services/desktop.cxx index f727fbe3f576..d9427c0f5529 100644 --- a/framework/source/services/desktop.cxx +++ b/framework/source/services/desktop.cxx @@ -125,7 +125,7 @@ void Desktop::constructorInit() // Safe impossible cases // We can't work without this helper! -SAL_WARN_IF( !m_xFramesHelper.is(), "fwk.desktop", "Desktop::Desktop(): Frames helper is not valid. XFrames, XIndexAccess and XElementAcces are not supported!"); +SAL_WARN_IF( !m_xFramesHelper.is(), "fwk.desktop", "Desktop::Desktop(): Frames helper is not valid. XFrames, XIndexAccess and XElementAccess are not supported!"); SAL_WARN_IF( !m_xDispatchHelper.is(), "fwk.desktop", "Desktop::Desktop(): Dispatch helper is not valid. XDispatch will not work correctly!" ); // Enable object for real working! diff --git a/framework/source/services/frame.cxx b/framework/source/services/frame.cxx index 76dddcafd4f8..ef0b48fef1bf 100644 --- a/framework/source/services/frame.cxx +++ b/framework/source/services/frame.cxx @@ -514,7 +514,7 @@ void Frame::initListeners() SAL_WARN_IF( !m_xDispatchHelper.is(), "fwk.frame", "Frame::Frame(): Interception helper is not valid. XDispatchProvider, " "XDispatch, XDispatchProviderInterception are not full supported!" ); SAL_WARN_IF( !m_xFramesHelper.is(), "fwk.frame", "Frame::Frame(): Frames helper is not valid. XFrames, " -"XIndexAccess and XElementAcces are not supported!" ); +"XIndexAccess and XElementAccess are not supported!" ); SAL_WARN_IF( !m_xDropTargetListener.is(), "fwk.frame", "Frame::Frame(): DropTarget helper is not valid. " "Drag and drop without functionality!" ); diff --git a/sdext/source/presenter/PresenterHelpView.cxx b/sdext/source/presenter/PresenterHelpView.cxx index c7a04138b6e0..03f68efd8e03 100644 --- a/sdext/source/presenter/PresenterHelpView.cxx +++ b/sdext/source/presenter/PresenterHelpView.cxx @@ -499,7 +499,7 @@ void PresenterHelpView::ThrowIfDisposed() } } -//= LineDescritor = +//= LineDescriptor = namespace { diff --git a/vcl/unx/generic/gdi/gdiimpl.cxx b/vcl/unx/generic/gdi/gdiimpl.cxx index 20abe91a8b07..649315473132 100644 --- a/vcl/unx/generic/gdi/gdiimpl.cxx +++ b/vcl/unx/generic/gdi/gdiimpl.cxx @@ -1476,7 +1476,7 @@ bool X11SalGraphicsImpl::drawPolyPolygon( const basegfx::B2DPolyPolygon& rOrigPo if( !aPolyPoly.count() ) return true; -// tesselate the polypolygon into trapezoids +// tessellate the polypolygon into trapezoids basegfx::B2DTrapezoidVector aB2DTrapVector; basegfx::tools::trapezoidSubdivide( aB2DTrapVector, aPolyPoly ); const int nTrapCount = aB2DTrapVector.size(); diff --git a/writerfilter/source/ooxml/OOXMLDocumentImpl.cxx b/writerfilter/source/ooxml/OOXMLDocumentImpl.cxx index d884248e7908..b48bca5b40b4 100644 --- a/writerfilter/source/ooxml/OOXMLDocumentImpl.cxx +++ b/writerfilter/source/ooxml/OOXMLDocumentImpl.cxx @@ -198,7 +198,7 @@ void OOXMLDocumentImpl::importSubStreamRelations(const OOXMLStream::Pointer_t& p if (xcpInputStream.is()) { -// imporing itemprops files for item.xml from customXml. +// importing itemprops files for item.xml from customXml. if(OOXMLStream::CUSTOMXMLPROPS == nType) { try ___ Libreoffice-commits mailing list
[Libreoffice-bugs] [Bug 92190] PRINTs landscape despite configured as portrait (Mac OS)
https://bugs.documentfoundation.org/show_bug.cgi?id=92190 --- Comment #22 from T.L.--- This issue seems to have spontaneously arisen for us with LO 5.3.5.2 (TDF download) on MacOS X 10.11.6. I don't think it occurred in conjunction with an app update. Trashing the /Library/Application Support/LibreOffice had no improvement. Using the workaround of: Format -> Page -> Page: Paper Format, Width: 8.52" The issue seems to affect printing of most (but not all) existing Writer documents. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111887] Nested functions return wrong values
https://bugs.documentfoundation.org/show_bug.cgi?id=111887 raalchanged: What|Removed |Added Status|UNCONFIRMED |NEW CC||er...@redhat.com, ||r...@post.cz, ||winfrieddonkers@libreoffice ||.org Ever confirmed|0 |1 OS|Linux (All) |All --- Comment #1 from raal --- I saved the file as .xlsx and opened in excel. The result from excel is B3= False B4 = false C4 = false -> no error. Setting as new. In LO Version: 6.0.0.0.alpha0+ are results B3, B4, C4 = Error. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111890] fileopen .odg colour fill missing
https://bugs.documentfoundation.org/show_bug.cgi?id=111890 raalchanged: What|Removed |Added Status|UNCONFIRMED |NEW CC||r...@post.cz Ever confirmed|0 |1 --- Comment #4 from raal --- I can confirm crash. Version: 6.0.0.0.alpha0+ Build ID: 791f93e Android 5.0.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111890] fileopen .odg colour fill missing
https://bugs.documentfoundation.org/show_bug.cgi?id=111890 --- Comment #3 from krishna [:kr1shna]--- Created attachment 135637 --> https://bugs.documentfoundation.org/attachment.cgi?id=135637=edit display on 6.0.0.0.alpha0+ [ aa084cc ] -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111890] fileopen .odg colour fill missing
https://bugs.documentfoundation.org/show_bug.cgi?id=111890 --- Comment #2 from krishna [:kr1shna]--- Created attachment 135636 --> https://bugs.documentfoundation.org/attachment.cgi?id=135636=edit display on 5.1, 5.2, 5.3, 5.4, 6.0 [ b115c1cd99b1 ] -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111890] fileopen .odg colour fill missing
https://bugs.documentfoundation.org/show_bug.cgi?id=111890 --- Comment #1 from krishna [:kr1shna]--- Created attachment 135635 --> https://bugs.documentfoundation.org/attachment.cgi?id=135635=edit display on 5.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111890] New: fileopen .odg colour fill missing
https://bugs.documentfoundation.org/show_bug.cgi?id=111890 Bug ID: 111890 Summary: fileopen .odg colour fill missing Product: LibreOffice Version: 5.1.0.3 release Hardware: ARM OS: Android Status: UNCONFIRMED Severity: normal Priority: medium Component: Android Viewer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kris...@grrlz.net Description: colour fill is displayed on 5.0; w/o colour fill is displayed on 5.1, 5.2, 5.3, 5.4; 6.0 [ aa084cc ] crashes Steps to Reproduce: open Humanité et faits divers_test-bug-ext-fodg_7.odg attachment 110576 Actual Results: colour fill is missing Expected Results: display similar to version 5.0, please find attachments colour fill 5.0.0.0.alpha1+ [ build id: ab465b9 ] w/o colour fill 5.1.0.0.alpha1+ [ build id: 1a6ec13 ] 5.1.0.0.alpha1+ [ build id: 5b791ec ] 5.2.0.0.alpha0+ [ build id: f6a74ce ] 5.3.0.0.alpha1+ [ build id: 4136757 ] 5.4.0.0.alpha0+ [ build id: 3902bb7 ] 6.0.0.0.alpha0+ [ build id: b115c1cd99b1 ] crash 6.0.0.0.alpha0+ [ aa084cc ] blank document os: android 5.1 device: lyf flame 3 [ ls-4001 ] Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Opera/9.80 (Android; Opera Mini/29.0.2254/66.318; U; en) Presto/2.12.423 Version/12.16 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92786] FILESAVE: wrong table of content page numbers alignment after .docx export
https://bugs.documentfoundation.org/show_bug.cgi?id=92786 Bastián Díazchanged: What|Removed |Added CC||diazbast...@openmailbox.org --- Comment #10 from Bastián Díaz --- Created attachment 135634 --> https://bugs.documentfoundation.org/attachment.cgi?id=135634=edit screenshot This problem is still present using LibreOffice 5.4.0.3 (7556cbc6811c9d992f4064ab9287069087d7f62c) in fedora 25 XFCE 64 bit. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 33304] Header / Footer should be inserted into margin, not into text body
https://bugs.documentfoundation.org/show_bug.cgi?id=33304 --- Comment #48 from Bastián Díaz--- A problem related to what is discussed here is that mentioned in Bug 111325. Because a header is added when inserting a watermark, the space of the text body decreases slightly, but it can have consequences in the design layout. I think that by default LO should insert headers/footers in the margins, however, allowing the user to choose to insert the headers/footers in the margins or as part of the text body would give more control of the document layout. Cheers -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65100] Table of Content' s field is changed when saving as *.doc and *.docx file formats
https://bugs.documentfoundation.org/show_bug.cgi?id=65100 Bastián Díazchanged: What|Removed |Added CC||diazbast...@openmailbox.org --- Comment #19 from Bastián Díaz --- Created attachment 135633 --> https://bugs.documentfoundation.org/attachment.cgi?id=135633=edit screenshot of new testcase I can't replicate the problem in version 5.4.0.3 (7556cbc6811c9d992f4064ab9287069087d7f62c) on fedora xfce 64 bit. When exporting a document in *.doc file format looks the same as original *.odt and in the case of exporting to OOXML or Word 2007-2013 XML, only the page numbers are not well aligned, something that is best described in Bug 92786. For the test I used the original file presented here as other new ones created by me. The same screenshot results occur when opening documents exported by LibreOffice using MS Office 2013 - MS 2016 (Windows 10), WPS Office Writer 10.1.0.5707 (gnu/linux) and OnlyOffice desktop editors 4.4.1.338 (gnu/linux). I think it's better to close this ticket and contribute to other more delimited reports. Cheers -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 97314] a11y libreoffice is very slow in version 5.1 even with disabling open gl by default.
https://bugs.documentfoundation.org/show_bug.cgi?id=97314 V Stuart Footechanged: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME --- Comment #8 from V Stuart Foote --- OK we'll set this resolved works for me then... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 97314] a11y libreoffice is very slow in version 5.1 even with disabling open gl by default.
https://bugs.documentfoundation.org/show_bug.cgi?id=97314 --- Comment #7 from zahra--- hello. i appologize for the delay for the response. i reported many bugs and i forgot the numbers for some of them to return and comment. this problem fixed for me in many versions ago, specially version 5.2 the only problem is for reporting headers of some options that they are not related to accessibility and they are relates to some delay in showing them in libreoffice which causes delay for reading in nvda or any screen reader. i confirm that this bug is fixed completely for me. you can set it to resolved. thanks so much for your great program, i dont forget your kindness, sincerely pray for you in my every day praying, and request divine infinite mercy and blessings for you. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: wsd/DocumentBroker.cpp wsd/Storage.cpp wsd/Storage.hpp
wsd/DocumentBroker.cpp |2 +- wsd/Storage.cpp|5 +++-- wsd/Storage.hpp|2 +- 3 files changed, 5 insertions(+), 4 deletions(-) New commits: commit 769e41dfb21a17a50cb0d768451d0838bc30f2f3 Author: Pranav KantDate: Fri Aug 18 07:14:33 2017 +0530 Fix build Mismerge. There is no session->getAccessToken now Change-Id: I4d8f2cc612cbd39b3163bcdbba5df8ea5d732774 diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp index 016d251d..77035837 100644 --- a/wsd/DocumentBroker.cpp +++ b/wsd/DocumentBroker.cpp @@ -729,7 +729,7 @@ void DocumentBroker::saveFileAs(const std::string& sessionId, const std::string& WopiStorage* wopiStorage = dynamic_cast (_storage.get()); if (wopiStorage != nullptr) { -const std::string newUrl = wopiStorage->createCopyFile(it->second->getAccessToken(), newFileName, path); +const std::string newUrl = wopiStorage->createCopyFile(it->second->getAuthorization(), newFileName, path); if (!newUrl.empty()) { it->second->sendTextFrame("saveas: " + newUrl + " " + newFileName); diff --git a/wsd/Storage.cpp b/wsd/Storage.cpp index 1472faa6..db047aba 100644 --- a/wsd/Storage.cpp +++ b/wsd/Storage.cpp @@ -585,12 +585,12 @@ std::unique_ptr WopiStorage::getWOPIFileInfo(const Au } /// PutRelativeFile - uri format: http://server/<...>/wopi*/files// -std::string WopiStorage::createCopyFile(const std::string& accessToken, const std::string& newFileName, const std::string& path) +std::string WopiStorage::createCopyFile(const Authorization& auth, const std::string& newFileName, const std::string& path) { const auto size = getFileSize(_jailedFilePath); std::ostringstream oss; Poco::URI uriObject(_uri); -setQueryParameter(uriObject, "access_token", accessToken); +auth.authorizeURI(uriObject); LOG_DBG("Wopi PutRelativeFile(save as) request for : " << uriObject.toString()); @@ -600,6 +600,7 @@ std::string WopiStorage::createCopyFile(const std::string& accessToken, const st Poco::Net::HTTPRequest request(Poco::Net::HTTPRequest::HTTP_POST, uriObject.getPathAndQuery(), Poco::Net::HTTPMessage::HTTP_1_1); request.set("User-Agent", WOPI_AGENT_STRING); +auth.authorizeRequest(request); request.set("X-WOPI-Override", "PUT_RELATIVE"); request.set("X-WOPI-RelativeTarget", newFileName + "." + getFileExtension()); request.set("X-WOPI-Size", std::to_string(size)); diff --git a/wsd/Storage.hpp b/wsd/Storage.hpp index da30b1b9..827a8fa7 100644 --- a/wsd/Storage.hpp +++ b/wsd/Storage.hpp @@ -259,7 +259,7 @@ public: std::unique_ptr getWOPIFileInfo(const Authorization& auth); /// returns -std::string createCopyFile(const std::string& accessToken, const std::string& newFileName, const std::string& path); +std::string createCopyFile(const Authorization& auth, const std::string& newFileName, const std::string& path); /// uri format: http://server/<...>/wopi*/files//content std::string loadStorageFileToLocal(const Authorization& auth) override; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/lok_dialog' - 654 commits - accessibility/inc accessibility/source android/source apple_remote/source autogen.sh avmedia/source basctl/inc basctl/source
Rebased ref, commits from common ancestor: commit 67d0cf3bf7ac1dd2da56335fe3974dfe13c0a1cf Author: Pranav KantDate: Wed Aug 16 08:46:40 2017 +0530 CD_DIALOG_INVALIDATE -> DIALOG Change-Id: Ifdda1c868e19700013a0742a0a547c0a4e040fba diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index 561c1e8886c2..1b2a0832559f 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -779,7 +779,7 @@ void CallbackFlushHandler::queue(const int type, const char* data) case LOK_CALLBACK_SET_PART: case LOK_CALLBACK_TEXT_VIEW_SELECTION: case LOK_CALLBACK_INVALIDATE_HEADER: -case LOK_CALLBACK_DIALOG_INVALIDATE: +case LOK_CALLBACK_DIALOG: { const auto& pos = std::find_if(m_queue.rbegin(), m_queue.rend(), [type] (const queue_type::value_type& elem) { return (elem.first == type); }); commit 37e36de24c0fa9207fe552ae3b3065e7ce4fd932 Author: Pranav Kant Date: Tue Aug 15 18:54:02 2017 +0530 lokdialog: Smoother mouse move on floating windows Do away with an early hack to create the floating window with every invalidate. This gets rid of persistent blinking when moving the mouse over a listbox, for example. Change-Id: Ida9367156605edc9835529f83529363ad97beaee diff --git a/libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.cxx b/libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.cxx index ec734a011a88..43c14712646a 100644 --- a/libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.cxx +++ b/libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.cxx @@ -598,34 +598,34 @@ void gtv_lok_dialog_child_invalidate(GtvLokDialog* dialog, int nX, int nY) GtvLokDialogPrivate* priv = getPrivate(dialog); // remove any existing floating windows, for now -if (priv->pFloatingWin) -gtk_widget_destroy(priv->pFloatingWin); - -priv->pFloatingWin = gtk_window_new(GTK_WINDOW_POPUP); -GtkWidget* pDrawingArea = gtk_drawing_area_new(); -gtk_container_add(GTK_CONTAINER(priv->pFloatingWin), pDrawingArea); - -gtk_window_set_transient_for(GTK_WINDOW(priv->pFloatingWin), GTK_WINDOW(dialog)); -gtk_window_set_destroy_with_parent(GTK_WINDOW(priv->pFloatingWin), true); - -gtk_widget_add_events(pDrawingArea, - GDK_BUTTON_PRESS_MASK - |GDK_POINTER_MOTION_MASK - |GDK_BUTTON_RELEASE_MASK - |GDK_BUTTON_MOTION_MASK); - -g_signal_connect(G_OBJECT(pDrawingArea), "draw", G_CALLBACK(gtv_lok_dialog_floating_win_draw), dialog); -g_signal_connect(G_OBJECT(pDrawingArea), "button-press-event", G_CALLBACK(gtv_lok_dialog_floating_win_signal_button), dialog); -g_signal_connect(G_OBJECT(pDrawingArea), "button-release-event", G_CALLBACK(gtv_lok_dialog_floating_win_signal_button), dialog); -g_signal_connect(G_OBJECT(pDrawingArea), "motion-notify-event", G_CALLBACK(gtv_lok_dialog_floating_win_signal_motion), dialog); - -gtk_widget_set_size_request(priv->pFloatingWin, 1, 1); -gtk_window_set_type_hint(GTK_WINDOW(priv->pFloatingWin), GDK_WINDOW_TYPE_HINT_POPUP_MENU); -gtk_window_set_screen(GTK_WINDOW(priv->pFloatingWin), gtk_window_get_screen(GTK_WINDOW(dialog))); - -gtk_widget_show_all(priv->pFloatingWin); -gtk_window_present(GTK_WINDOW(priv->pFloatingWin)); -gtk_widget_grab_focus(pDrawingArea); +if (!priv->pFloatingWin) +{ +priv->pFloatingWin = gtk_window_new(GTK_WINDOW_POPUP); +GtkWidget* pDrawingArea = gtk_drawing_area_new(); +gtk_container_add(GTK_CONTAINER(priv->pFloatingWin), pDrawingArea); + +gtk_window_set_transient_for(GTK_WINDOW(priv->pFloatingWin), GTK_WINDOW(dialog)); +gtk_window_set_destroy_with_parent(GTK_WINDOW(priv->pFloatingWin), true); + +gtk_widget_add_events(pDrawingArea, + GDK_BUTTON_PRESS_MASK + |GDK_POINTER_MOTION_MASK + |GDK_BUTTON_RELEASE_MASK + |GDK_BUTTON_MOTION_MASK); + +g_signal_connect(G_OBJECT(pDrawingArea), "draw", G_CALLBACK(gtv_lok_dialog_floating_win_draw), dialog); +g_signal_connect(G_OBJECT(pDrawingArea), "button-press-event", G_CALLBACK(gtv_lok_dialog_floating_win_signal_button), dialog); +g_signal_connect(G_OBJECT(pDrawingArea), "button-release-event", G_CALLBACK(gtv_lok_dialog_floating_win_signal_button), dialog); +g_signal_connect(G_OBJECT(pDrawingArea), "motion-notify-event", G_CALLBACK(gtv_lok_dialog_floating_win_signal_motion), dialog); + +gtk_widget_set_size_request(priv->pFloatingWin, 1, 1); +gtk_window_set_type_hint(GTK_WINDOW(priv->pFloatingWin), GDK_WINDOW_TYPE_HINT_POPUP_MENU); +gtk_window_set_screen(GTK_WINDOW(priv->pFloatingWin), gtk_window_get_screen(GTK_WINDOW(dialog))); + +
[Libreoffice-bugs] [Bug 86905] EDITING outline level on non-heading paragraphs does not respect setting in Paragraph > Outline and Numbering > Outline level..
https://bugs.documentfoundation.org/show_bug.cgi?id=86905 --- Comment #12 from Justin L--- (In reply to Justin L from comment #11) > Basically, styles and list numbering are completely separate. Just to clarify - in a paragraph style, you CAN assign the LIST-STYLE that will be used by default so in that way there is a connection, but nothing in the style affects the LEVEL that the list will be at. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86905] EDITING outline level on non-heading paragraphs does not respect setting in Paragraph > Outline and Numbering > Outline level..
https://bugs.documentfoundation.org/show_bug.cgi?id=86905 Justin Lchanged: What|Removed |Added Blocks|75748 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=75748 [Bug 75748] FILEOPEN: incorrect display of some numbering styles in .DOC and .DOCX -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75748] FILEOPEN: incorrect display of some numbering styles in .DOC and .DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=75748 Justin Lchanged: What|Removed |Added Depends on|86905 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=86905 [Bug 86905] EDITING outline level on non-heading paragraphs does not respect setting in Paragraph > Outline and Numbering > Outline level.. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86905] EDITING outline level on non-heading paragraphs does not respect setting in Paragraph > Outline and Numbering > Outline level..
https://bugs.documentfoundation.org/show_bug.cgi?id=86905 Justin Lchanged: What|Removed |Added Status|NEW |RESOLVED CC||jl...@mail.com Resolution|--- |NOTABUG --- Comment #11 from Justin L --- NOTABUG: As Regina notes in comment 10, outline levels and list levels are not the same thing. The user's example is trying to equate the two. To make the document work as intended by design: 1.) apply "Heading 4" paragraph style to paragraph 4. 2.) apply "Custom" list style to paragraph 4. In terms of being able to use a style OTHER than Heading 4 for the 4th level, that is possible under "Tools - Chapter numbering". So in keeping with this example, you could re-assign level 4 to be paragraph style 'Text body'. Basically, styles and list numbering are completely separate. Chapter numbering is a special feature designed to handle a specific use case. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103370] [META] Outline/Chapter numbering bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103370 Bug 103370 depends on bug 86905, which changed state. Bug 86905 Summary: EDITING outline level on non-heading paragraphs does not respect setting in Paragraph > Outline and Numbering > Outline level.. https://bugs.documentfoundation.org/show_bug.cgi?id=86905 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |NOTABUG -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75748] FILEOPEN: incorrect display of some numbering styles in .DOC and .DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=75748 Bug 75748 depends on bug 86905, which changed state. Bug 86905 Summary: EDITING outline level on non-heading paragraphs does not respect setting in Paragraph > Outline and Numbering > Outline level.. https://bugs.documentfoundation.org/show_bug.cgi?id=86905 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |NOTABUG -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104787] [META] FILESAVE: PPTX: Corrupted file in MSO PP after RT
https://bugs.documentfoundation.org/show_bug.cgi?id=104787 Aron Budeachanged: What|Removed |Added Depends on||106867 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=106867 [Bug 106867] Videos do not get saved when saving in PPTX, and invalid file produced -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106867] Videos do not get saved when saving in PPTX, and invalid file produced
https://bugs.documentfoundation.org/show_bug.cgi?id=106867 Aron Budeachanged: What|Removed |Added Keywords|dataLoss| CC||ba...@caesar.elte.hu Hardware|x86-64 (AMD64) |All Blocks||104787 Summary|Videos do not get saved |Videos do not get saved |when saving in pptx format |when saving in PPTX, and ||invalid file produced Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104787 [Bug 104787] [META] FILESAVE: PPTX: Corrupted file in MSO PP after RT -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106867] Videos do not get saved when saving in pptx format
https://bugs.documentfoundation.org/show_bug.cgi?id=106867 --- Comment #6 from Aron Budea--- Created attachment 135632 --> https://bugs.documentfoundation.org/attachment.cgi?id=135632=edit Test PPTX (created in PowerPoint) Not only the video is not saved into PPTX, the file produced by LO is not a valid PPTX. Attaching a valid PPTX created in PP for testing. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 34355] Use margins to track changes
https://bugs.documentfoundation.org/show_bug.cgi?id=34355 --- Comment #34 from Edmund Laugasson--- (In reply to Christoph from comment #3) > There have been some ideation iterations within the OOo Notes2 > implementation, see "Change Tracking Integration" at: > http://wiki.services.openoffice.org/wiki/Notes2_OtherIdeas > > The mockup I've created that time: > http://wiki.services.openoffice.org/wiki/File: > Notes2_GeneralMockups_RoughIdeas_ReviewTools_ForIdeasList.png This mockup looks actually very nice. I guess this could be an option to turn such feature on but leave also an option to use current version of track changes. I guess there could be different modes of track changes and then users can decide which one to use. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 34355] Use margins to track changes
https://bugs.documentfoundation.org/show_bug.cgi?id=34355 --- Comment #34 from Edmund Laugasson--- (In reply to Christoph from comment #3) > There have been some ideation iterations within the OOo Notes2 > implementation, see "Change Tracking Integration" at: > http://wiki.services.openoffice.org/wiki/Notes2_OtherIdeas > > The mockup I've created that time: > http://wiki.services.openoffice.org/wiki/File: > Notes2_GeneralMockups_RoughIdeas_ReviewTools_ForIdeasList.png This mockup looks actually very nice. I guess this could be an option to turn such feature on but leave also an option to use current version of track changes. I guess there could be different modes of track changes and then users can decide which one to use. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 105168] mpg-video not displayed in impress anymore
https://bugs.documentfoundation.org/show_bug.cgi?id=105168 --- Comment #12 from Aron Budea--- Possible duplicate of bug 62408? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 34355] Use margins to track changes
https://bugs.documentfoundation.org/show_bug.cgi?id=34355 --- Comment #33 from Edmund Laugasson--- Basically as there is already a button to show/hide track changes, there would be nice to have a button "Show track changes on edge" (optionally allow also choose either right or left edge) or "Switch to MSO track changes mode". Then it would be easy to switch between two track changes mode. The only missing feature seems to be to show these different color bubbles with changes on edge. Hiding changes already exist which makes the result actually comparable with MSO. Instead of these colorful bubbles there is a track changes management dialog where all changes with names, date/time and comments are shown and can be actually managed in a very compact and fast way. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 34355] Use margins to track changes
https://bugs.documentfoundation.org/show_bug.cgi?id=34355 --- Comment #33 from Edmund Laugasson--- Basically as there is already a button to show/hide track changes, there would be nice to have a button "Show track changes on edge" (optionally allow also choose either right or left edge) or "Switch to MSO track changes mode". Then it would be easy to switch between two track changes mode. The only missing feature seems to be to show these different color bubbles with changes on edge. Hiding changes already exist which makes the result actually comparable with MSO. Instead of these colorful bubbles there is a track changes management dialog where all changes with names, date/time and comments are shown and can be actually managed in a very compact and fast way. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 62408] Cannot insert MP4 video files on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=62408 Aron Budeachanged: What|Removed |Added Blocks||107322 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107322 [Bug 107322] [META] Media (audio / video) bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107322] [META] Media (audio / video) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107322 Aron Budeachanged: What|Removed |Added Depends on||62408 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=62408 [Bug 62408] Cannot insert MP4 video files on Windows -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80128] FILESAVE: MP4 is broken in PPTX
https://bugs.documentfoundation.org/show_bug.cgi?id=80128 Aron Budeachanged: What|Removed |Added Status|NEW |RESOLVED CC||ba...@caesar.elte.hu Resolution|--- |DUPLICATE --- Comment #11 from Aron Budea --- Basically this and bug 106867 is the same. As that one has a sample, let's close this one. *** This bug has been marked as a duplicate of bug 106867 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106867] Videos do not get saved when saving in pptx format
https://bugs.documentfoundation.org/show_bug.cgi?id=106867 Aron Budeachanged: What|Removed |Added CC||danielyunu...@gmail.com --- Comment #5 from Aron Budea --- *** Bug 80128 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108943] FILEOPEN: RTF: left margin on first paragraph' s line is ignored
https://bugs.documentfoundation.org/show_bug.cgi?id=108943 Miklos Vajnachanged: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |vmik...@collabora.co.uk |desktop.org | --- Comment #5 from Miklos Vajna --- I see the problem now, thanks for the additional info. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103570] Java not selected automatically when a database is opened for the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=103570 --- Comment #5 from Aron Budea--- Hi Xisco, yes, I just reproduced with daily build 2017-08-15_01:59:49 / bebaac5eb6ebd2db3e1ea22b1630111343a9c25c. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/oox oox/source sw/source
include/oox/export/vmlexport.hxx |5 + oox/source/export/vmlexport.cxx |4 +--- sw/source/filter/ww8/docxattributeoutput.cxx | 24 sw/source/filter/ww8/docxattributeoutput.hxx |5 ++--- sw/source/filter/ww8/docxsdrexport.cxx | 10 +- sw/source/filter/ww8/docxsdrexport.hxx |4 ++-- 6 files changed, 23 insertions(+), 29 deletions(-) New commits: commit 79611a44fac472dfa5f0a01c051c314078f798b9 Author: Tamás ZolnaiDate: Wed Aug 16 22:02:53 2017 +0200 NdTopLeft is unused now. Change-Id: I39184b8fdf76c21560d39911f6204b0afd52 Reviewed-on: https://gerrit.libreoffice.org/41257 Tested-by: Jenkins Reviewed-by: Tamás Zolnai diff --git a/include/oox/export/vmlexport.hxx b/include/oox/export/vmlexport.hxx index c259db30cf06..c098ace13cb7 100644 --- a/include/oox/export/vmlexport.hxx +++ b/include/oox/export/vmlexport.hxx @@ -84,9 +84,6 @@ class OOX_DLLPUBLIC VMLExport : public EscherEx sal_Int16 m_eHOri, m_eVOri, m_eHRel, m_eVRel; bool m_bInline; // css::text::TextContentAnchorType_AS_CHARACTER -/// Parent position. -const Point* m_pNdTopLeft; - /// The object we're exporting. const SdrObject* m_pSdrObject; @@ -128,7 +125,7 @@ public: /// Call this when you need to export the object as VML. OString AddSdrObject( const SdrObject& rObj, sal_Int16 eHOri = -1, sal_Int16 eVOri = -1, sal_Int16 eHRel = -1, -sal_Int16 eVRel = -1, const Point* pNdTopLeft = nullptr, const bool bOOxmlExport = false ); +sal_Int16 eVRel = -1, const bool bOOxmlExport = false ); OString AddInlineSdrObject( const SdrObject& rObj, const bool bOOxmlExport = false ); virtual void AddSdrObjectVMLObject( const SdrObject& rObj) override; static bool IsWaterMarkShape(const OUString& rStr); diff --git a/oox/source/export/vmlexport.cxx b/oox/source/export/vmlexport.cxx index 3ee2711f8e5f..a401c3c44465 100644 --- a/oox/source/export/vmlexport.cxx +++ b/oox/source/export/vmlexport.cxx @@ -60,7 +60,6 @@ VMLExport::VMLExport( ::sax_fastparser::FSHelperPtr const & pSerializer, VMLText , m_eHRel( 0 ) , m_eVRel( 0 ) , m_bInline( false ) -, m_pNdTopLeft( nullptr ) , m_pSdrObject( nullptr ) , m_pShapeAttrList( nullptr ) , m_nShapeType( ESCHER_ShpInst_Nil ) @@ -1280,14 +1279,13 @@ void VMLExport::EndShape( sal_Int32 nShapeElement ) } } -OString VMLExport::AddSdrObject( const SdrObject& rObj, sal_Int16 eHOri, sal_Int16 eVOri, sal_Int16 eHRel, sal_Int16 eVRel, const Point* pNdTopLeft, const bool bOOxmlExport ) +OString VMLExport::AddSdrObject( const SdrObject& rObj, sal_Int16 eHOri, sal_Int16 eVOri, sal_Int16 eHRel, sal_Int16 eVRel, const bool bOOxmlExport ) { m_pSdrObject = m_eHOri = eHOri; m_eVOri = eVOri; m_eHRel = eHRel; m_eVRel = eVRel; -m_pNdTopLeft = pNdTopLeft; EscherEx::AddSdrObject(rObj, bOOxmlExport); return m_sShapeId; } diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx b/sw/source/filter/ww8/docxattributeoutput.cxx index 3c8bddef0cbf..87fefdc7783b 100644 --- a/sw/source/filter/ww8/docxattributeoutput.cxx +++ b/sw/source/filter/ww8/docxattributeoutput.cxx @@ -4790,13 +4790,13 @@ void DocxAttributeOutput::WritePostponedActiveXControl() for( std::vector::const_iterator it = m_aPostponedActiveXControls.begin(); it != m_aPostponedActiveXControls.end(); ++it ) { -WriteActiveXControl(it->object, *(it->frame), *(it->point)); +WriteActiveXControl(it->object, *(it->frame)); } m_aPostponedActiveXControls.clear(); } -void DocxAttributeOutput::WriteActiveXControl(const SdrObject* pObject, const SwFrameFormat& rFrameFormat,const Point& rNdTopLeft) +void DocxAttributeOutput::WriteActiveXControl(const SdrObject* pObject, const SwFrameFormat& rFrameFormat) { SdrUnoObj *pFormObj = const_cast (dynamic_cast< const SdrUnoObj*>(pObject)); if (!pFormObj) @@ -4833,7 +4833,7 @@ void DocxAttributeOutput::WriteActiveXControl(const SdrObject* pObject, const Sw sShapeId = m_rExport.VMLExporter().AddSdrObject(*pObject, rHoriOri.GetHoriOrient(), rVertOri.GetVertOrient(), rHoriOri.GetRelationOrient(), -rVertOri.GetRelationOrient(), , true); +rVertOri.GetRelationOrient(), true); } // control @@ -5013,7 +5013,7 @@ void DocxAttributeOutput::WritePostponedCustomShape() if ( IsAlternateContentChoiceOpen() ) m_rExport.SdrExporter().writeDMLDrawing(it->object, (it->frame), m_anchorId++); else -m_rExport.SdrExporter().writeDMLAndVMLDrawing(it->object, *(it->frame), *(it->point), m_anchorId++); +m_rExport.SdrExporter().writeDMLAndVMLDrawing(it->object, *(it->frame), m_anchorId++); }
[Libreoffice-bugs] [Bug 34355] Use margins to track changes
https://bugs.documentfoundation.org/show_bug.cgi?id=34355 --- Comment #32 from Edmund Laugasson--- Would propose to keep current version and possibly add a configuration option to switch onto MS Office version of track changes and support also importing while opening MSO document in LO with track changes made in MSO. At least by my humble opinion I am satisfied with current track changes logic and design in LO and would like to use it also in future like now. Certainly this is fundamental difference how the track changes is solved in MSO and LO - therefore it would be nice to have similar or same behaviour in LO like in MSO. There could be different options how to enable such behaviour like in MSO. One option would be to add an effect that changes will not shown in text. Then there could be an option while accepting/denying changes, allow to show them. Another option would be to just switch completely to MSO way to track changes. Currently there is a button to show/hide changes (on appropriate toolbar without turning on experimental features) - so if showing track changes disturbs anybody - these can be just switched off and you will always see the latest text with all changes as in MSO. At the same time there remains ability to accept/deny changes whenever there would be needed to decide it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 34355] Use margins to track changes
https://bugs.documentfoundation.org/show_bug.cgi?id=34355 --- Comment #32 from Edmund Laugasson--- Would propose to keep current version and possibly add a configuration option to switch onto MS Office version of track changes and support also importing while opening MSO document in LO with track changes made in MSO. At least by my humble opinion I am satisfied with current track changes logic and design in LO and would like to use it also in future like now. Certainly this is fundamental difference how the track changes is solved in MSO and LO - therefore it would be nice to have similar or same behaviour in LO like in MSO. There could be different options how to enable such behaviour like in MSO. One option would be to add an effect that changes will not shown in text. Then there could be an option while accepting/denying changes, allow to show them. Another option would be to just switch completely to MSO way to track changes. Currently there is a button to show/hide changes (on appropriate toolbar without turning on experimental features) - so if showing track changes disturbs anybody - these can be just switched off and you will always see the latest text with all changes as in MSO. At the same time there remains ability to accept/deny changes whenever there would be needed to decide it. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 107322] [META] Media (audio / video) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107322 Aron Budeachanged: What|Removed |Added Depends on||105168 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105168 [Bug 105168] mpg-video not displayed in impress anymore -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105168] mpg-video not displayed in impress anymore
https://bugs.documentfoundation.org/show_bug.cgi?id=105168 Aron Budeachanged: What|Removed |Added CC||ba...@caesar.elte.hu Blocks||107322 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107322 [Bug 107322] [META] Media (audio / video) bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111889] Assert when testing tdf#104312 (enable-dbgutil only)
https://bugs.documentfoundation.org/show_bug.cgi?id=111889 Aron Budeachanged: What|Removed |Added Blocks||105537 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105537 [Bug 105537] [META] Assertion failed crashes -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105537] [META] Assertion failed crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=105537 Aron Budeachanged: What|Removed |Added Depends on||111889 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=111889 [Bug 111889] Assert when testing tdf#104312 (enable-dbgutil only) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: connectivity/source
connectivity/source/drivers/macab/MacabRecord.cxx |1 + connectivity/source/drivers/macab/MacabRecords.cxx |2 ++ 2 files changed, 3 insertions(+) New commits: commit 27b1e21913d8119ea27be05954156d15ca069e66 Author: Julien NabetDate: Thu Aug 17 23:07:35 2017 +0200 Related tdf#111634: Multiple memory leaks in libmacabdrv1 (part3) Hope it'll fix leak from https://bugs.documentfoundation.org/show_bug.cgi?id=111634#c13 Change-Id: I61a51faf291145c8cafd03339b7bcc7b23072fba Reviewed-on: https://gerrit.libreoffice.org/41268 Reviewed-by: Julien Nabet Tested-by: Julien Nabet diff --git a/connectivity/source/drivers/macab/MacabRecord.cxx b/connectivity/source/drivers/macab/MacabRecord.cxx index 5cb71beff854..f4e9a8c65341 100644 --- a/connectivity/source/drivers/macab/MacabRecord.cxx +++ b/connectivity/source/drivers/macab/MacabRecord.cxx @@ -55,6 +55,7 @@ MacabRecord::~MacabRecord() { if(size > 0) { +releaseFields(); int i; for(i = 0; i < size; i++) { diff --git a/connectivity/source/drivers/macab/MacabRecords.cxx b/connectivity/source/drivers/macab/MacabRecords.cxx index ccc4dc3e8f6e..958fdd87c901 100644 --- a/connectivity/source/drivers/macab/MacabRecords.cxx +++ b/connectivity/source/drivers/macab/MacabRecords.cxx @@ -188,6 +188,8 @@ void MacabRecords::initialize() MacabRecords::~MacabRecords() { +delete [] lcl_CFTypes; +delete [] requiredProperties; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 111634] Multiple memory leaks in libmacabdrv1
https://bugs.documentfoundation.org/show_bug.cgi?id=111634 --- Comment #16 from Commit Notification--- Julien Nabet committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=27b1e21913d8119ea27be05954156d15ca069e66 Related tdf#111634: Multiple memory leaks in libmacabdrv1 (part3) It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50097] FILESAVE: FORMCONTROLS: Form controls not saved in .docx
https://bugs.documentfoundation.org/show_bug.cgi?id=50097 Tamás Zolnaichanged: What|Removed |Added Assignee|libreoffice-b...@lists.free |zolnaitamas2...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: filter/source include/oox oox/source sd/Module_sd.mk sd/qa sw/qa sw/source writerfilter/inc writerfilter/source
dev/null |binary filter/source/msfilter/eschesdo.cxx| 20 ++ include/oox/export/vmlexport.hxx | 18 +- include/oox/ole/olehelper.hxx | 35 +++ oox/source/export/preset-definitions-to-shape-types.pl |2 oox/source/export/vmlexport.cxx| 93 +- oox/source/ole/olehelper.cxx | 45 + oox/source/token/tokens.txt|2 sd/Module_sd.mk|2 sd/qa/unit/import-tests.cxx|1 sw/qa/extras/ooxmlexport/ooxmlexport2.cxx |1 sw/qa/extras/ooxmlexport/ooxmlexport3.cxx | 57 -- sw/qa/extras/ooxmlexport/ooxmlexport5.cxx |1 sw/qa/extras/ooxmlexport/ooxmlexport6.cxx |8 sw/qa/extras/ooxmlexport/ooxmlexport7.cxx |8 sw/qa/extras/ooxmlexport/ooxmlexport9.cxx | 29 +++ sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx |1 sw/qa/extras/ooxmlimport/ooxmlimport.cxx | 28 --- sw/source/filter/ww8/docxattributeoutput.cxx | 104 +++ sw/source/filter/ww8/docxattributeoutput.hxx |5 sw/source/filter/ww8/docxexport.cxx| 149 ++--- sw/source/filter/ww8/docxexport.hxx|6 writerfilter/inc/ooxml/OOXMLDocument.hxx |4 writerfilter/source/filter/WriterFilter.cxx|4 writerfilter/source/ooxml/OOXMLDocumentImpl.cxx| 78 writerfilter/source/ooxml/OOXMLDocumentImpl.hxx|6 writerfilter/source/ooxml/OOXMLStreamImpl.cxx | 15 - 27 files changed, 377 insertions(+), 345 deletions(-) New commits: commit c0cc02e2934aeb12dda44818955e5964496c186a Author: Tamás ZolnaiDate: Thu Aug 17 21:47:22 2017 +0200 tdf#50097: DOCX: export form controls as MSO ActiveX controls * Use the same structure for export what MSO uses ** Position and size information are exported as VML shape properties ** Different handling of inline and floating controls (pict or object) ** Do some changes on VML shape export to match how MSO exports these controls ** Write out activeX.xml and activeX.bin to store control properties ** Use persistStorage storage type defined in activeX.xml * Drop grabbaging of activex.XML and activeX.bin * Cleanup control related test code Change-Id: I38bb2b2ffd2676c5459b61ec2549c31348bab41c Signed-off-by: Tamás Zolnai Reviewed-on: https://gerrit.libreoffice.org/41256 Tested-by: Jenkins diff --git a/filter/source/msfilter/eschesdo.cxx b/filter/source/msfilter/eschesdo.cxx index c89469405c68..1348c38bfe7e 100644 --- a/filter/source/msfilter/eschesdo.cxx +++ b/filter/source/msfilter/eschesdo.cxx @@ -40,6 +40,7 @@ #include #include #include +#include #include #include #include @@ -419,7 +420,24 @@ sal_uInt32 ImplEESdrWriter::ImplWriteShape( ImplEESdrObject& rObj, } else if ( rObj.GetType() == "drawing.Control" ) { -break; +mpEscherEx->OpenContainer( ESCHER_SpContainer ); +bool bInline = false; +const Reference< XPropertySet > xPropSet(rObj.mXPropSet, UNO_QUERY); +if(xPropSet.is()) +{ +text::TextContentAnchorType eAnchorType; +xPropSet->getPropertyValue("AnchorType") >>= eAnchorType; +bInline = eAnchorType == text::TextContentAnchorType_AS_CHARACTER; +} + +if(bInline) +{ +ADD_SHAPE( ESCHER_ShpInst_PictureFrame, SHAPEFLAG_HAVESPT | SHAPEFLAG_HAVEANCHOR ); +} +else +{ +ADD_SHAPE( ESCHER_ShpInst_HostControl, SHAPEFLAG_HAVESPT | SHAPEFLAG_HAVEANCHOR ); +} } else if ( rObj.GetType() == "drawing.Connector" ) { diff --git a/include/oox/export/vmlexport.hxx b/include/oox/export/vmlexport.hxx index aac1811a4f17..c259db30cf06 100644 --- a/include/oox/export/vmlexport.hxx +++ b/include/oox/export/vmlexport.hxx @@ -82,6 +82,7 @@ class OOX_DLLPUBLIC VMLExport : public EscherEx /// Anchoring. sal_Int16 m_eHOri, m_eVOri, m_eHRel, m_eVRel; +bool m_bInline; // css::text::TextContentAnchorType_AS_CHARACTER /// Parent position. const Point* m_pNdTopLeft; @@ -101,11 +102,20 @@ class OOX_DLLPUBLIC VMLExport : public EscherEx /// Remember style, the most important shape attribute ;-) OStringBuffer m_ShapeStyle; +/// Remember the generated shape id. +OString m_sShapeId; + /// Remember which shape types we had already written. std::vector m_aShapeTypeWritten; +/// It seems useless to
[Libreoffice-bugs] [Bug 50097] FILESAVE: FORMCONTROLS: Form controls not saved in .docx
https://bugs.documentfoundation.org/show_bug.cgi?id=50097 --- Comment #33 from Commit Notification--- Tamás Zolnai committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c0cc02e2934aeb12dda44818955e5964496c186a tdf#50097: DOCX: export form controls as MSO ActiveX controls It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50097] FILESAVE: FORMCONTROLS: Form controls not saved in .docx
https://bugs.documentfoundation.org/show_bug.cgi?id=50097 Commit Notificationchanged: What|Removed |Added Whiteboard||target:6.0.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54922] PostgreSQL SDBC connector does not allow write access PostgreSQL version 8.3 and older
https://bugs.documentfoundation.org/show_bug.cgi?id=54922 Michael Stahlchanged: What|Removed |Added Status|NEW |RESOLVED CC||mst...@redhat.com Resolution|--- |WONTFIX --- Comment #5 from Michael Stahl --- i think now we can safely conclude this isn't going to happen. postgresql.org says the oldest supported release is 9.2, so probably everybody on versions < 8.4 has upgraded anyway. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Branch 'refs/tags/2.1.3-4' - loolwsd.spec.in
Rebased ref, commits from common ancestor: commit a6fa4cb8661317a29594726bdc81787af95dd24a Author: Jan HolesovskyDate: Thu Aug 17 22:48:30 2017 +0200 No libpcap on CentOS6. Change-Id: I2a430e97b49818772a9459d0326f1326fabc9823 diff --git a/loolwsd.spec.in b/loolwsd.spec.in index 1a8c45cf..81e743f6 100644 --- a/loolwsd.spec.in +++ b/loolwsd.spec.in @@ -24,7 +24,7 @@ Source0:loolwsd-@package_vers...@.tar.gz BuildRequires: libcap-devel libpng-devel poco-devel >= 1.7.5 # Red Hat and CentOS -%if 0%{?fedora} || 0%{?rhel} >= 6 +%if 0%{?fedora} || 0%{?rhel} >= 7 BuildRequires: libpcap %endif ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-2-1' - loolwsd.spec.in
loolwsd.spec.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a6fa4cb8661317a29594726bdc81787af95dd24a Author: Jan HolesovskyDate: Thu Aug 17 22:48:30 2017 +0200 No libpcap on CentOS6. Change-Id: I2a430e97b49818772a9459d0326f1326fabc9823 diff --git a/loolwsd.spec.in b/loolwsd.spec.in index 1a8c45cf..81e743f6 100644 --- a/loolwsd.spec.in +++ b/loolwsd.spec.in @@ -24,7 +24,7 @@ Source0:loolwsd-@package_vers...@.tar.gz BuildRequires: libcap-devel libpng-devel poco-devel >= 1.7.5 # Red Hat and CentOS -%if 0%{?fedora} || 0%{?rhel} >= 6 +%if 0%{?fedora} || 0%{?rhel} >= 7 BuildRequires: libpcap %endif ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Suggestion: Finding missing words in dictionaries via web scraping and natural language processing
On 08/17/2017 11:20 AM, Michael Stahl wrote: > by "missing words in dictionaries", do you mean that if "teh" was used > as an archaic spelling of "tea" in a work of Shakespeare (completely In Pinyin, the transliteration is "de". In Wade-Giles, the transliteration is "teh". For people who quote Daoist material written prior to circa 1980, autocorrect of "teh to the" becomes extremely annoying. This is the type of specialized usage that belongs only in a dictionary that can easily turned on/off, as needed. jonathon ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 111889] Assert when testing tdf#104312 (enable-dbgutil only)
https://bugs.documentfoundation.org/show_bug.cgi?id=111889 --- Comment #3 from Julien Nabet--- Created attachment 135631 --> https://bugs.documentfoundation.org/attachment.cgi?id=135631=edit bt 2 with debug symbols Since I don't know how to display info from SAL_INFO (whereas I use enable-dbgutil), I replaced on local with SAL_WARN. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111889] Assert when testing tdf#104312 (enable-dbgutil only)
https://bugs.documentfoundation.org/show_bug.cgi?id=111889 --- Comment #2 from Julien Nabet--- Created attachment 135630 --> https://bugs.documentfoundation.org/attachment.cgi?id=135630=edit bt with debug symbols -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Suggestion: Finding missing words in dictionaries via web scraping and natural language processing
On 08/17/2017 10:08 AM, Andrej Warkentin wrote: > So I thought this could be used to find (or at least help finding) most > missing words in dictionaries for all languages. Back when the OOo dictionary for Afrikaans was created, a program was run through the dictionary corpus, excluding words that were also found in the English dictionary. Which is why the three of the most common words in Afrikaans were not found in that dictionary, for at least the first five revisions of it. Die man. Two words, which as a phrase, have completely different meanings, when read in Afrikaans, and in English. «I'll grant that "man" is bad Afrikaans, but it is the only example I can think of, offhand, that isn't also off-colour in either, or both languages.» > My question is if this would be something helpful at all or if missing words > in dictionaries is not a problem anymore. Once a dictionary has reached a certain size, it starts to include words that are rarely used, whose spelling is a common misspelling for another word. Earlier in this thread somebody mentioned "teh" as one example. For dictionaries that are under initial construction, this type of tool can be extremely useful. > don't have much spare time at the moment to work on this so if anyone My impression is that a Python Library Module that includes this functionality exists. What would need to be done, would be to either hook that library up with a bot that scrapes Wikipedia, etc, or an extension that reads ODF documents. Your question might be more appropriate for the upstream project that provides the dictionaries used by LibreOffice. Also might be appropriate on the Language Tool (grammar checking) list. jonathon ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 66744] slow selection of Libreoffice entries in gnome-panel
https://bugs.documentfoundation.org/show_bug.cgi?id=66744 Jean-Baptiste Faurechanged: What|Removed |Added Status|NEW |RESOLVED CC||jbfa...@libreoffice.org Resolution|--- |INSUFFICIENTDATA --- Comment #5 from Jean-Baptiste Faure --- Nobody confirmed this bug report. As it has not been touched by its reporter since 3 years, I close it as insufficientdata. Please feel free to reopen if you disagree. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: svx/source
svx/source/tbxctrls/PaletteManager.cxx |1 + svx/source/tbxctrls/tbcontrl.cxx |1 + 2 files changed, 2 insertions(+) New commits: commit 8c0cc5cd7befffc6e8e6361ba67807a799cc997f Author: Julien NabetDate: Thu Aug 17 21:42:32 2017 +0200 Related tdf#105500: leaks in PaletteManager and SvxColorToolBoxControl See comments of the bugtracker for more details Again thank you Alex for very useful information about leaks! Change-Id: I96743e8b167224f1bec73db5f2ba82536c7f23fa Reviewed-on: https://gerrit.libreoffice.org/41265 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/svx/source/tbxctrls/PaletteManager.cxx b/svx/source/tbxctrls/PaletteManager.cxx index 6e77ff700521..57cd8f0ee2d0 100644 --- a/svx/source/tbxctrls/PaletteManager.cxx +++ b/svx/source/tbxctrls/PaletteManager.cxx @@ -62,6 +62,7 @@ PaletteManager::PaletteManager() : PaletteManager::~PaletteManager() { +m_Palettes.clear(); } void PaletteManager::LoadPalettes() diff --git a/svx/source/tbxctrls/tbcontrl.cxx b/svx/source/tbxctrls/tbcontrl.cxx index 02ab35acd106..66bedff5fc85 100644 --- a/svx/source/tbxctrls/tbcontrl.cxx +++ b/svx/source/tbxctrls/tbcontrl.cxx @@ -2807,6 +2807,7 @@ void SvxColorToolBoxControl::EnsurePaletteManager() SvxColorToolBoxControl::~SvxColorToolBoxControl() { +m_xPaletteManager.reset(nullptr); } void SvxColorToolBoxControl::setColorSelectFunction(const ColorSelectFunction& aColorSelectFunction) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=105500 --- Comment #13 from Commit Notification--- Julien Nabet committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=8c0cc5cd7befffc6e8e6361ba67807a799cc997f Related tdf#105500: leaks in PaletteManager and SvxColorToolBoxControl It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=105500 Commit Notificationchanged: What|Removed |Added Whiteboard||target:6.0.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111889] Assert when testing tdf#104312 (enable-dbgutil only)
https://bugs.documentfoundation.org/show_bug.cgi?id=111889 Julien Nabetchanged: What|Removed |Added CC||noelgran...@gmail.com --- Comment #1 from Julien Nabet --- Noel: thought you might be interested since the assert is triggered from https://cgit.freedesktop.org/libreoffice/core/commit/?id=bc9a2ba677ce3fcd46c2bbef6e8faeacb14292c1 Of course, the pb isn't the assert but we must find the root cause. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111889] New: Assert when testing tdf#104312 (enable-dbgutil only)
https://bugs.documentfoundation.org/show_bug.cgi?id=111889 Bug ID: 111889 Summary: Assert when testing tdf#104312 (enable-dbgutil only) Product: LibreOffice Version: 6.0.0.0.alpha0+ Master Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: serval2...@yahoo.fr Description: On pc Debian x86-64 with master sources updated today + enable-dbgutil, I've got an assert. Steps to Reproduce: 1. Open attachment https://bugs.documentfoundation.org/attachment.cgi?id=129188 2. Close LO Actual Results: Assert Expected Results: No assert Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111888] change method of creating of variable in Writer's dialogue " Fields"
https://bugs.documentfoundation.org/show_bug.cgi?id=111888 --- Comment #1 from kompilainenn <79045_79...@mail.ru> --- Created attachment 135629 --> https://bugs.documentfoundation.org/attachment.cgi?id=135629=edit mockup change method of creating a new variable -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111888] New: change method of creating of variable in Writer' s dialogue "Fields"
https://bugs.documentfoundation.org/show_bug.cgi?id=111888 Bug ID: 111888 Summary: change method of creating of variable in Writer's dialogue "Fields" Product: LibreOffice Version: 6.0.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: 79045_79...@mail.ru Description: change method of creating of variable in Writer's dialogue "Fields". Today you must follow steps: 1. Open dialogue Fields (Ctrl+F2) 2. Go to tab Variables 3. Select type - Set variable 4. Enter Name of variable and enter Value of variable 5. Push button Insert (it insert new field in your document, that you don't need) 6. Repeat step 3-5 7. Delete all new fields with new variable from document! (I know, that there is checkbox "Invisible") I offer change method of creating a new variable (see mockup from attach) 1. Delete text box "Value" 2. Assign a default value to the variable or/and make entering value of variable optional 3. For create a new variable don't need to insert new field in the document. Need just select existing green checkbox "Apply". It create a new variable and clean text box Name for create next variable. Actual Results: too much steps for create a new variable in dialogue "Fields". It insert new fields in the document, then user should delete them Expected Results: simple process of creating a new variable in dialogue "Fields" Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:56.0) Gecko/20100101 Firefox/56.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 97706] CLEAN is neither ODF nor OOXML conform
https://bugs.documentfoundation.org/show_bug.cgi?id=97706 Taylorchanged: What|Removed |Added Status|NEW |ASSIGNED CC||taylorlee...@gmail.com Assignee|libreoffice-b...@lists.free |taylorlee...@gmail.com |desktop.org | --- Comment #3 from Taylor --- Using http://www.unicode.org/Public/UNIDATA/UnicodeData.txt as reference, we can grep for ';(Cc|Cn);'. We find that Cc and Cn chars are: 0x00 to 0x1F (inclusive) 0x7F to 0x9F (inclusive) Using the above info, we can update the CLEAN isPrintable() function. I also added CLEAN.OOXML using a new isPrintable_OOXML() function that returns true only if c > 0x1f. Using the following fods to verify, I found that the CHAR function is not appropriate to use with CLEAN since CHAR returns 0xfffd for the range of 0x80 to 0xFF inclusive. 0x100 and above returns Err:502. core/sc/qa/unit/data/functions/text/fods/clean.fods Changing CHAR to UNICHAR, we can then successfully test the range 0x80 to 0x9F. I'll attempt to use gerrit to start the patch process. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: autogen.sh avmedia/source basic/qa bin/lo-commit-stat bin/lo-pack-sources chart2/source cli_ure/qa configure.ac desktop/source editeng/source extensions/source filter/s
README.cross |4 - autogen.sh |2 avmedia/source/macavf/player.mm |2 basic/qa/vba_tests/replace.vb |2 bin/lo-commit-stat |2 bin/lo-pack-sources |2 chart2/source/view/charttypes/VSeriesPlotter.cxx |2 cli_ure/qa/climaker/climaker.cs |2 configure.ac |4 - desktop/source/pkgchk/unopkg/unopkg_app.cxx |2 editeng/source/accessibility/AccessibleContextBase.cxx |2 extensions/source/inc/componentmodule.hxx |2 filter/source/graphicfilter/ipict/ipict.cxx |2 filter/source/xslt/export/wordml/ooo2wordml_table.xsl |4 - filter/source/xslt/import/spreadsheetml/spreadsheetml2ooo.xsl |2 filter/source/xslt/import/wordml/wordml2ooo_draw.xsl |2 filter/source/xslt/odf2xhtml/export/xhtml/body.xsl |4 - fpicker/source/office/iodlg.cxx |2 include/osl/security_decl.hxx |2 include/svtools/brwbox.hxx |2 include/svx/AccessibleShapeTreeInfo.hxx |2 include/svx/SmartTagMgr.hxx |2 odk/docs/install.html |4 - odk/examples/DevelopersGuide/OfficeDev/FilterDevelopment/FlatXmlFilter_cpp/FlatXmlFilter_cpp.xcu |2 odk/examples/DevelopersGuide/examples.html |6 +- odk/examples/examples.html |6 +- offapi/com/sun/star/chart2/Axis.idl |2 offapi/com/sun/star/chart2/XScaling.idl |2 offapi/com/sun/star/document/ExtendedTypeDetection.idl |2 offapi/com/sun/star/document/ExtendedTypeDetectionFactory.idl |2 offapi/com/sun/star/document/XUndoManagerListener.idl |4 - offapi/com/sun/star/drawing/DrawingDocumentFactory.idl |2 offapi/com/sun/star/embed/XEmbeddedClient.idl |2 offapi/com/sun/star/frame/XDispatch.idl |2 offapi/com/sun/star/script/provider/XScript.idl |2 offapi/com/sun/star/text/TextMarkupType.idl |2 offapi/com/sun/star/ucb/XInteractionAuthFallback.idl |2 offapi/com/sun/star/xml/crypto/sax/ElementMarkPriority.idl |2 officecfg/registry/schema/org/openoffice/Office/Labels.xcs |2 officecfg/registry/schema/org/openoffice/TypeDetection/Types.xcs |2 oovbaapi/ooo/vba/excel/XRange.idl |2 qadevOOo/tests/java/ifc/lang/_XServiceInfo.java |2 qadevOOo/tests/java/ifc/sdb/_RowSet.java |2 sal/osl/unx/thread.cxx |2 sal/test/bootstrap.pl |2 sal/textenc/tcvtest1.tab | 16 +++--- sal/textenc/tcvtlat1.tab
[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - oox/source sd/qa
oox/source/core/fragmenthandler2.cxx |1 oox/source/ole/axcontrolfragment.cxx | 19 ++ oox/source/vml/vmlshapecontext.cxx |4 ++- sd/qa/unit/data/pptx/activex_checkbox.pptx |binary sd/qa/unit/import-tests.cxx| 37 + 5 files changed, 60 insertions(+), 1 deletion(-) New commits: commit ceb23063726a938caa691aa73a9dd9c773e35134 Author: Tamás ZolnaiDate: Sun Aug 13 18:39:32 2017 +0200 tdf#111548: PPTX: ActiveX checkbox control appear as picture Make ActiveX controls import working again (PPTX / XLSX) It used to work earlier, but there were an issue with the shape id and so controls were not find. Also in PPTX import the persistStorage attribute was handled only for parent controls and not for other kind of controls. Reviewed-on: https://gerrit.libreoffice.org/40751 Reviewed-by: Tamás Zolnai Tested-by: Tamás Zolnai (cherry picked from commit c8e3633a352c2fda3aebb9781288a926e7a88c42) tdf#111548: Better fix for PPTX / XLSX import of ActiveX controls Follow up fix for: c8e3633a352c2fda3aebb9781288a926e7a88c42 Revert part of it and fix the real issue: shapid was messed up. Reviewed-on: https://gerrit.libreoffice.org/40929 Tested-by: Jenkins Reviewed-by: Tamás Zolnai (cherry picked from commit 286c27e805c4501451857abff19c23b3719146a3) Change-Id: I9784166b65407b79b6dfed8a38087b55b1b69835 Reviewed-on: https://gerrit.libreoffice.org/41117 Tested-by: Jenkins Reviewed-by: Michael Stahl diff --git a/oox/source/core/fragmenthandler2.cxx b/oox/source/core/fragmenthandler2.cxx index 4bd32f4e7a77..76ef5ec1e32c 100644 --- a/oox/source/core/fragmenthandler2.cxx +++ b/oox/source/core/fragmenthandler2.cxx @@ -77,6 +77,7 @@ bool FragmentHandler2::prepareMceContext( sal_Int32 nElement, const AttributeLis "p14", "p15", "x12ac", +"v", }; if (std::find(aSupportedNS.begin(), aSupportedNS.end(), aRequires) != aSupportedNS.end()) diff --git a/oox/source/ole/axcontrolfragment.cxx b/oox/source/ole/axcontrolfragment.cxx index 4a76adc9e2f6..b6503a7b0651 100644 --- a/oox/source/ole/axcontrolfragment.cxx +++ b/oox/source/ole/axcontrolfragment.cxx @@ -130,11 +130,30 @@ ContextHandlerRef AxControlFragment::onCreateContext( sal_Int32 nElement, const Reference< XInputStream > xStrgStrm = getFilter().openInputStream( aFragmentPath ); if( xStrgStrm.is() ) { +// Try to import as a parent control +bool bImportedAsParent = false; OleStorage aStorage( getFilter().getComponentContext(), xStrgStrm, false ); BinaryXInputStream aInStrm( aStorage.openInputStream( "f" ), true ); if( !aInStrm.isEof() ) +{ if( AxContainerModelBase* pModel = dynamic_cast< AxContainerModelBase* >( mrControl.createModelFromGuid( aClassId ) ) ) +{ pModel->importBinaryModel( aInStrm ); +bImportedAsParent = true; +} +} +// Import it as a non-parent control +if(!bImportedAsParent) +{ +BinaryXInputStream aInStrm2(aStorage.openInputStream("contents"), true); +if (!aInStrm2.isEof()) +{ +if (ControlModelBase* pModel = mrControl.createModelFromGuid(aClassId)) +{ +pModel->importBinaryModel(aInStrm2); +} +} +} } } } diff --git a/oox/source/vml/vmlshapecontext.cxx b/oox/source/vml/vmlshapecontext.cxx index 02cf06e51429..9311351601d5 100644 --- a/oox/source/vml/vmlshapecontext.cxx +++ b/oox/source/vml/vmlshapecontext.cxx @@ -282,10 +282,12 @@ ShapeTypeContext::ShapeTypeContext( ContextHandler2Helper& rParent, ShapeType& r { mrTypeModel.maShapeName = rAttribs.getXString( XML_id, OUString() ); // get ShapeType and ShapeId from name for compatibility -mrTypeModel.maShapeId = mrTypeModel.maShapeName; static const OUString sShapeTypePrefix = "shapetype_"; if( mrTypeModel.maShapeName.startsWith( sShapeTypePrefix ) ) +{ +
[Libreoffice-commits] core.git: include/svx svx/source sw/source
include/svx/sdasitm.hxx |9 - include/svx/svddef.hxx |3 +-- svx/source/items/customshapeitem.cxx|4 svx/source/svdraw/svdattr.cxx |8 svx/source/unodraw/unoprov.cxx |1 - sw/source/uibase/uiview/formatclipboard.cxx |1 - 6 files changed, 1 insertion(+), 25 deletions(-) New commits: commit fc443f3b50e33a1adab03bbf7fb9f9351eb07868 Author: Jochen NitschkeDate: Thu Aug 17 09:59:33 2017 +0200 drop unused SdrCustomShapeReplacementURLItem no user found at least since 2004 last traceable commit 50a73f5963c4d0ca34629f36cc04e8b45f61bd62 Date: Fri Apr 2 13:07:39 2004 + INTEGRATION: CWS sj05 (1.1.2); FILE ADDED Change-Id: Iaaf80e93ed60611f5e03688f4d95ab0a7d024e79 Reviewed-on: https://gerrit.libreoffice.org/41262 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/include/svx/sdasitm.hxx b/include/svx/sdasitm.hxx index 8ad95dd9ed71..8bf5eab3e8b9 100644 --- a/include/svx/sdasitm.hxx +++ b/include/svx/sdasitm.hxx @@ -22,7 +22,6 @@ #include #include -#include #include #include #include @@ -77,14 +76,6 @@ private: void ClearPropertyValue( const OUString& rPropertyName ); }; -class SVX_DLLPUBLIC SdrCustomShapeReplacementURLItem : public SfxStringItem -{ -public: -SdrCustomShapeReplacementURLItem(); -virtual ~SdrCustomShapeReplacementURLItem() override; -virtual SfxPoolItem*Clone( SfxItemPool* pPool = nullptr ) const override; -}; - inline SdrOnOffItem makeSdrTextWordWrapItem( bool bAuto ) { return SdrOnOffItem( SDRATTR_TEXT_WORDWRAP, bAuto ); } diff --git a/include/svx/svddef.hxx b/include/svx/svddef.hxx index 30d50d2254f9..eed623e04149 100644 --- a/include/svx/svddef.hxx +++ b/include/svx/svddef.hxx @@ -287,8 +287,7 @@ #define SDRATTR_CUSTOMSHAPE_ENGINE (SDRATTR_CUSTOMSHAPE_FIRST + 0) /* 1334 V4+++*/ #define SDRATTR_CUSTOMSHAPE_DATA(SDRATTR_CUSTOMSHAPE_FIRST + 1) /* 1335 V4+++*/ #define SDRATTR_CUSTOMSHAPE_GEOMETRY(SDRATTR_CUSTOMSHAPE_FIRST + 2) /* 1336 V4+++*/ -#define SDRATTR_CUSTOMSHAPE_REPLACEMENT_URL (SDRATTR_CUSTOMSHAPE_FIRST + 3) /* 1337 V4+++*/ -#define SDRATTR_CUSTOMSHAPE_LAST (SDRATTR_CUSTOMSHAPE_REPLACEMENT_URL) /* 1357 V4+++*/ +#define SDRATTR_CUSTOMSHAPE_LAST (SDRATTR_CUSTOMSHAPE_GEOMETRY) /* 1357 V4+++*/ #define SDRATTR_TABLE_FIRST (SDRATTR_CUSTOMSHAPE_LAST+1) #define SDRATTR_TABLE_BORDER(SDRATTR_TABLE_FIRST+0) diff --git a/svx/source/items/customshapeitem.cxx b/svx/source/items/customshapeitem.cxx index 507a7694bab7..ffd6c514c64f 100644 --- a/svx/source/items/customshapeitem.cxx +++ b/svx/source/items/customshapeitem.cxx @@ -304,8 +304,4 @@ bool SdrCustomShapeGeometryItem::PutValue( const uno::Any& rVal, sal_uInt8 /*nMe } } -SdrCustomShapeReplacementURLItem::SdrCustomShapeReplacementURLItem() -: SfxStringItem( SDRATTR_CUSTOMSHAPE_REPLACEMENT_URL, "" ) -{} - /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/svx/source/svdraw/svdattr.cxx b/svx/source/svdraw/svdattr.cxx index e4fb92b3e0ee..d38a8e6bf5be 100644 --- a/svx/source/svdraw/svdattr.cxx +++ b/svx/source/svdraw/svdattr.cxx @@ -305,7 +305,6 @@ SdrItemPool::SdrItemPool( rPoolDefaults[ SDRATTR_CUSTOMSHAPE_ENGINE - SDRATTR_START ] = new SfxStringItem(SDRATTR_CUSTOMSHAPE_ENGINE, ""); rPoolDefaults[ SDRATTR_CUSTOMSHAPE_DATA - SDRATTR_START ] = new SfxStringItem(SDRATTR_CUSTOMSHAPE_DATA, ""); rPoolDefaults[ SDRATTR_CUSTOMSHAPE_GEOMETRY - SDRATTR_START ] = new SdrCustomShapeGeometryItem; -rPoolDefaults[ SDRATTR_CUSTOMSHAPE_REPLACEMENT_URL - SDRATTR_START ] = new SdrCustomShapeReplacementURLItem; SvxBoxItem* pboxItem = new SvxBoxItem( SDRATTR_TABLE_BORDER ); pboxItem->SetAllDistances( 100 ); @@ -1933,13 +1932,6 @@ SfxPoolItem* SdrMeasureTextUpsideDownItem::Clone(SfxItemPool* ) const { return new SdrMeasureTextUpsideDownItem(*this); } -SdrCustomShapeReplacementURLItem::~SdrCustomShapeReplacementURLItem() -{ -} -SfxPoolItem* SdrCustomShapeReplacementURLItem::Clone( SfxItemPool*) const -{ -return new SdrCustomShapeReplacementURLItem(*this); -} SfxPoolItem* SdrLayerIdItem::Clone(SfxItemPool* /*pPool*/) const { diff --git a/svx/source/unodraw/unoprov.cxx b/svx/source/unodraw/unoprov.cxx index 48caa04e1683..c03ede3c1ad3 100644 --- a/svx/source/unodraw/unoprov.cxx +++ b/svx/source/unodraw/unoprov.cxx @@ -687,7 +687,6 @@ SfxItemPropertyMapEntry const * ImplGetSvxCustomShapePropertyMap() { OUString("CustomShapeData"), SDRATTR_CUSTOMSHAPE_DATA, cppu::UnoType::get(), 0, 0 }, { OUString("CustomShapeGeometry"), SDRATTR_CUSTOMSHAPE_GEOMETRY,
[Libreoffice-commits] online.git: Changes to 'refs/tags/2.1.3-4'
Tag '2.1.3-4' created by Jan Holesovskyat 2017-08-17 19:12 + 2.1.3-4 Changes since 2.1.3-mf-11: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - sw/qa writerfilter/source
sw/qa/extras/rtfexport/data/tdf107480.rtf | 16 sw/qa/extras/rtfexport/rtfexport.cxx |7 +++ writerfilter/source/rtftok/rtfsprm.cxx|4 3 files changed, 27 insertions(+) New commits: commit 6e8c6f08cfc34ab59ef359152725aeae940f2654 Author: Miklos VajnaDate: Tue Aug 15 22:34:13 2017 +0200 tdf#107480 RTF import: fix HTML automatic spacing in styles \htmautsp changes the meaning of \sbauto and \saauto, but the auto keywords may appear early in style definitions before \htmautsp arrives. This wasn't a problem before commit 1be0a3fa9ebb22b607c54b47739d4467acfed259 (n#825305: writerfilter RTF import: override style properties like Word, 2014-06-17), as there the right auto keyword interpretation was repeated as direct formatting. So fix the regression by not deduplicating these keywords, which brings back the correct layout. A larger rework is necessary in the future to delay the parsing of the stylesheet table, that would be a cleaner approach. (cherry picked from commit 9dd82d0d68065ab95e20a1a489f4130299a8669e) Change-Id: I783d2175483bc80ead0a511ad15c4b75e4ab663c Reviewed-on: https://gerrit.libreoffice.org/41203 Tested-by: Jenkins Reviewed-by: Michael Stahl diff --git a/sw/qa/extras/rtfexport/data/tdf107480.rtf b/sw/qa/extras/rtfexport/data/tdf107480.rtf new file mode 100644 index ..2edd895e02ab --- /dev/null +++ b/sw/qa/extras/rtfexport/data/tdf107480.rtf @@ -0,0 +1,16 @@ +{\rtf1 +{\fonttbl +{\f0 Times New Roman;} +} +{\stylesheet +{\snext0 Normal;} +{\s3 \sbauto1\saauto1 heading 3;} +} +\paperw11906\paperh16838\margl1701\margr850\margt1134\margb1134 +\jexpand\viewkind1\viewscale100\pgbrdrhead\pgbrdrfoot\splytwnine\ftnlytwnine +\nolnhtadjtbl\useltbaln\alntblind\lytcalctblwd\lyttblrtgr\lnbrkrule\nobrkwrptbl\snaptogridincell\allowfieldendsel\wrppunct +\asianbrkrule\newtblstyruls\nogrowautofit \fet0\sectd \linex0\headery708\footery708\colsx708\endnhere\sectlinegrid360\sectdefaultcl\sftnbj +\htmautsp +\pard\plain \s3 \sbauto1\saauto1 +1.\par +} diff --git a/sw/qa/extras/rtfexport/rtfexport.cxx b/sw/qa/extras/rtfexport/rtfexport.cxx index bfa59514ff59..b31a66a30f6e 100644 --- a/sw/qa/extras/rtfexport/rtfexport.cxx +++ b/sw/qa/extras/rtfexport/rtfexport.cxx @@ -1211,6 +1211,13 @@ DECLARE_RTFEXPORT_TEST(testTdf107620, "tdf107620.docx") CPPUNIT_ASSERT(!bAddParaTableSpacing); } +DECLARE_RTFEXPORT_TEST(testTdf107480, "tdf107480.rtf") +{ +// These were 176 (100 twips), as \htmautsp was parsed too late. +CPPUNIT_ASSERT_EQUAL(sal_Int32(convertTwipToMm100(280)), getProperty(getParagraph(1), "ParaTopMargin")); +CPPUNIT_ASSERT_EQUAL(sal_Int32(convertTwipToMm100(280)), getProperty(getParagraph(1), "ParaBottomMargin")); +} + DECLARE_RTFEXPORT_TEST(testWatermark, "watermark.rtf") { uno::Reference xShape(getShape(1), uno::UNO_QUERY); diff --git a/writerfilter/source/rtftok/rtfsprm.cxx b/writerfilter/source/rtftok/rtfsprm.cxx index a1d0605a248b..7d0129cf2b5f 100644 --- a/writerfilter/source/rtftok/rtfsprm.cxx +++ b/writerfilter/source/rtftok/rtfsprm.cxx @@ -168,6 +168,10 @@ static bool isSPRMDeduplicateBlacklist(Id nId) // possibly from the numbering. case NS_ooxml::LN_CT_Ind_left: case NS_ooxml::LN_CT_Ind_right: +// \htmautsp arrives after the style table, so only the non-style value is +// correct, keep these. +case NS_ooxml::LN_CT_Spacing_beforeAutospacing: +case NS_ooxml::LN_CT_Spacing_afterAutospacing: return true; default: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 33041] Allow page background to cover the whole page, not only within page borders/margins
https://bugs.documentfoundation.org/show_bug.cgi?id=33041 --- Comment #43 from Yan Pas--- Created attachment 135628 --> https://bugs.documentfoundation.org/attachment.cgi?id=135628=edit abiword files I've created both files in abiword. Libreoffice cannot open ODT with picture bg. But it opens odt with color bg. Margins are still white, seems like abiword displays them differently. Despite ODT I guess we should display DOCX (and maybe other exotic formats too) correctly too. In other words LO should support drawing background on the whole paper. Seems like it's hard programming task if it is inherited from OpenOffice. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111876] Links to Windows shares become corrupted in XLSX after save
https://bugs.documentfoundation.org/show_bug.cgi?id=111876 Jan Holesovskychanged: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Jan Holesovsky --- I touched this in the deep past, but don't remember details unfortunately; but overall, we should treat the samba shares (\\server\path\to\file.ods) like URLs, and never relativize that. Having said that, LibreOffice internally works with absolute URLs, so when the 'relativization' is on, it has to do heuristic to reconstruct the relative paths; but that should be omitted for samba shares. The commits I came up with in the past were these: https://cgit.freedesktop.org/libreoffice/core/commit/?id=6423f447db9130673089b5057fd174d321b5de5a https://cgit.freedesktop.org/libreoffice/core/commit/?id=7fe1706d431d8a4e366a2999726d75fc641d05b0 Either they regressed, or we have another corner case here I think... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111869] Doesn't change the default language when doing so in KDE
https://bugs.documentfoundation.org/show_bug.cgi?id=111869 Alberto Salvia Novellachanged: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #2 from Alberto Salvia Novella --- The setting is "Default - [language]". -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-2-1' - debian/changelog loolwsd.spec.in
debian/changelog |6 ++ loolwsd.spec.in |2 +- 2 files changed, 7 insertions(+), 1 deletion(-) New commits: commit 277d2b89a92ccb9fabe06defcfbcb29fb1c3e61b Author: Jan HolesovskyDate: Thu Aug 17 20:34:56 2017 +0200 Bump version for packages 2.1.3-4 Change-Id: I7f7f8f25683a95e9237580c8d6fe77f4a24f3b92 diff --git a/debian/changelog b/debian/changelog index cba7f0b3..2b4b880e 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +loolwsd (2.1.3-4) unstable; urgency=medium + + * see the git log: http://col.la/cool21 + + -- Jan Holesovsky Thu, 17 Aug 2017 20:00:00 +0200 + loolwsd (2.1.3-3) unstable; urgency=medium * see the git log: http://col.la/cool21 diff --git a/loolwsd.spec.in b/loolwsd.spec.in index 3ad0f851..1a8c45cf 100644 --- a/loolwsd.spec.in +++ b/loolwsd.spec.in @@ -12,7 +12,7 @@ Name: loolwsd%{name_suffix} Name: loolwsd %endif Version:@PACKAGE_VERSION@ -Release:3%{?dist} +Release:4%{?dist} %if 0%{?suse_version} == 1110 Group: Productivity/Office/Suite BuildRoot: %{_tmppath}/%{name}-%{version}-build ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: writerperfect/Library_wpftwriter.mk writerperfect/source
writerperfect/Library_wpftwriter.mk|2 writerperfect/source/writer/EPUBPackage.cxx| 21 ++ writerperfect/source/writer/exp/XMLBase64ImportContext.cxx | 46 ++ writerperfect/source/writer/exp/XMLBase64ImportContext.hxx | 43 + writerperfect/source/writer/exp/XMLTextFrameContext.cxx| 99 + writerperfect/source/writer/exp/XMLTextFrameContext.hxx| 41 + writerperfect/source/writer/exp/txtparai.cxx | 10 + 7 files changed, 258 insertions(+), 4 deletions(-) New commits: commit 28102e471d3cb6b6976380ca84b1094078ac1af1 Author: Miklos VajnaDate: Thu Aug 17 18:03:53 2017 +0200 EPUB export: handle inline images Just the bare minimum, so that the binary file-related member functions of the package interface are triggered, so I can implement them. Change-Id: I996659126667423fded1f89f8097ac726418fa00 Reviewed-on: https://gerrit.libreoffice.org/41261 Tested-by: Jenkins Reviewed-by: Miklos Vajna diff --git a/writerperfect/Library_wpftwriter.mk b/writerperfect/Library_wpftwriter.mk index ba2172100f00..1f28b440b05b 100644 --- a/writerperfect/Library_wpftwriter.mk +++ b/writerperfect/Library_wpftwriter.mk @@ -75,6 +75,8 @@ $(eval $(call gb_Library_add_exception_objects,wpftwriter,\ writerperfect/source/writer/PagesImportFilter \ writerperfect/source/writer/StarOfficeWriterImportFilter \ writerperfect/source/writer/WordPerfectImportFilter \ + writerperfect/source/writer/exp/XMLBase64ImportContext \ + writerperfect/source/writer/exp/XMLTextFrameContext \ writerperfect/source/writer/exp/txtparai \ writerperfect/source/writer/exp/xmlictxt \ writerperfect/source/writer/exp/xmlimp \ diff --git a/writerperfect/source/writer/EPUBPackage.cxx b/writerperfect/source/writer/EPUBPackage.cxx index 7818f584b76f..3a33dedac3eb 100644 --- a/writerperfect/source/writer/EPUBPackage.cxx +++ b/writerperfect/source/writer/EPUBPackage.cxx @@ -140,17 +140,30 @@ void EPUBPackage::closeCSSFile() void EPUBPackage::openBinaryFile(const char *pName) { -SAL_WARN("writerperfect", "EPUBPackage::openBinaryFile, " << pName << ": implement me"); +assert(pName); +assert(!mxOutputStream.is()); + + mxOutputStream.set(mxStorage->openStreamElementByHierarchicalName(OUString::fromUtf8(pName), embed::ElementModes::READWRITE), uno::UNO_QUERY); } -void EPUBPackage::insertBinaryData(const librevenge::RVNGBinaryData &/*rData*/) +void EPUBPackage::insertBinaryData(const librevenge::RVNGBinaryData ) { -SAL_WARN("writerperfect", "EPUBPackage::insertBinaryData: implement me"); +assert(mxOutputStream.is()); + +if (rData.empty()) +return; + +uno::Sequence aData(reinterpret_cast(rData.getDataBuffer()), rData.size()); +mxOutputStream->writeBytes(aData); } void EPUBPackage::closeBinaryFile() { -SAL_WARN("writerperfect", "EPUBPackage::closeBinaryFile: implement me"); +assert(mxOutputStream.is()); + +uno::Reference xTransactedObject(mxOutputStream, uno::UNO_QUERY); +xTransactedObject->commit(); +mxOutputStream.clear(); } void EPUBPackage::openTextFile(const char *pName) diff --git a/writerperfect/source/writer/exp/XMLBase64ImportContext.cxx b/writerperfect/source/writer/exp/XMLBase64ImportContext.cxx new file mode 100644 index ..c073d8fc19bd --- /dev/null +++ b/writerperfect/source/writer/exp/XMLBase64ImportContext.cxx @@ -0,0 +1,46 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#include "XMLBase64ImportContext.hxx" + +using namespace com::sun::star; + +namespace writerperfect +{ +namespace exp +{ + +XMLBase64ImportContext::XMLBase64ImportContext(XMLImport ) +: XMLImportContext(rImport) +{ +} + +void XMLBase64ImportContext::startElement(const OUString &/*rName*/, const css::uno::Reference &/*xAttribs*/) +{ +} + +void XMLBase64ImportContext::endElement(const OUString &/*rName*/) +{ +} + +void XMLBase64ImportContext::characters(const OUString ) +{ +OString sCharU8 = OUStringToOString(rChars, RTL_TEXTENCODING_UTF8); +m_aBinaryData.appendBase64Data(librevenge::RVNGString(sCharU8.getStr())); +} + +const librevenge::RVNGBinaryData ::getBinaryData() const +{ +return m_aBinaryData; +} + +} // namespace exp +} // namespace writerperfect + +/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/writerperfect/source/writer/exp/XMLBase64ImportContext.hxx b/writerperfect/source/writer/exp/XMLBase64ImportContext.hxx new file mode 100644 index ..f60122b61382 --- /dev/null +++
[Libreoffice-commits] core.git: Branch 'feature/borderline3' - include/svx svx/source
include/svx/framelink.hxx| 107 +-- include/svx/framelinkarray.hxx | 10 --- svx/source/dialog/framelink.cxx | 34 ++- svx/source/dialog/framelinkarray.cxx | 89 + svx/source/dialog/frmsel.cxx |9 +- 5 files changed, 34 insertions(+), 215 deletions(-) New commits: commit 3e36255a53db5264eaa212edbc81015f465dbaee Author: Armin Le GrandDate: Thu Aug 17 20:19:46 2017 +0200 borderline: Cleanup of DiagStyle and others DiagStyle is not needed anymore due to no longer using angles calculated, but being based on vectors defining the geometry. Also cleaned up quite a bit of no longer needed calculation stuff for the control Change-Id: I10f2702416eea68b9e1541c6ae153d1f6094970b diff --git a/include/svx/framelink.hxx b/include/svx/framelink.hxx index f79b5ed84301..ce4ff50e8524 100644 --- a/include/svx/framelink.hxx +++ b/include/svx/framelink.hxx @@ -187,107 +187,8 @@ SVX_DLLPUBLIC bool operator<( const Style& rL, const Style& rR ); inline bool operator>( const Style& rL, const Style& rR ) { return rR < rL; } inline bool operator<=( const Style& rL, const Style& rR ) { return !(rR < rL); } - -/** Extends the Style struct with an angle for diagonal frame borders. - -The angle is specified in radian (a full circle is equivalent to 2*PI). -It is dependent on the context, how the value is interpreted, i.e. it may -specify the angle to a horizontal or vertical frame border. - */ -class SAL_WARN_UNUSED DiagStyle : public Style -{ -public: -/** Constructs an invisible diagonal frame style. */ -explicit DiagStyle() : mfAngle( 0.0 ) {} -/** Constructs a diagonal frame style passed style and angle. */ -explicit DiagStyle( const Style& rStyle, double fAngle ) : -Style( rStyle ), mfAngle( fAngle ) {} - -double GetAngle() const { return mfAngle; } - -/** Returns this style mirrored, if it is a double frame style, otherwise a simple copy. */ -DiagStyleMirror() const { return DiagStyle( Style::Mirror(), mfAngle ); } - -private: -double mfAngle;/// Angle between this and hor. or vert. border. -}; - - // Various helper functions - -/** Returns the angle between horizontal border of a rectangle and its diagonal. - -The returned values represents the inner angle between the diagonals and -horizontal borders, and is therefore in the range [0,PI/2] (inclusive). The -passed sizes may be negative, calculation is done with absolute values. - */ -SVX_DLLPUBLIC double GetHorDiagAngle( long nWidth, long nHeight ); - -/** Returns the angle between horizontal border of a rectangle and its diagonal. - -The returned values represents the inner angle between the diagonals and -horizontal borders, and is therefore in the range [0,PI/2] (inclusive). - */ -inline double GetHorDiagAngle( const tools::Rectangle& rRect ) -{ return GetHorDiagAngle( rRect.GetWidth(), rRect.GetHeight() ); } - - -/** Returns the angle between vertical border of a rectangle and its diagonal. - -The returned values represents the inner angle between the diagonals and -vertical borders, and is therefore in the range [0,PI/2] (inclusive). The -passed sizes may be negative, calculation is done with absolute values. - */ -inline double GetVerDiagAngle( long nWidth, long nHeight ) -{ return GetHorDiagAngle( nHeight, nWidth ); } - -/** Returns the angle between vertical border of a rectangle and its diagonal. - -The returned values represents the inner angle between the diagonals and -vertical borders, and is therefore in the range [0,PI/2] (inclusive). - */ -inline double GetVerDiagAngle( const tools::Rectangle& rRect ) -{ return GetVerDiagAngle( rRect.GetWidth(), rRect.GetHeight() ); } - - -/** Returns an X coordinate for a diagonal frame border in the specified height. - -This function is for usage with the top-left end of a top-left to -bottom-right diagonal frame border, connected to the left end of a -horizontal frame border. - -The function returns the relative X position (i.e. for a polygon) of the -diagonal frame border according to the specified relative Y position. The -mentioned positions are relative to the reference point of both frame -borders. - -+-- -| The horizontal frame border. -|| -- - - - - - | --+-- < Reference point for horizontal and diagonal frame borders. - ^ | \ | \ - nVerOffs | \ \ <--- The diagonal frame border. - v +---\ \ -- - - - - - - - -\- - -X <- The function calculates the X position of i.e. - \ \ this point (relative from X of
[Libreoffice-bugs] [Bug 109253] FONT NAME list: Scrolling through the list causes a crash. " Bad allocation" error message
https://bugs.documentfoundation.org/show_bug.cgi?id=109253 --- Comment #12 from Telesto--- *** Bug 111885 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111885] FORMATTING. Fatal error when changing fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=111885 Telestochanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Telesto --- *** This bug has been marked as a duplicate of bug 109253 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109253] FONT NAME list: Scrolling through the list causes a crash. " Bad allocation" error message
https://bugs.documentfoundation.org/show_bug.cgi?id=109253 Telestochanged: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109253] FONT NAME list: Scrolling through the list causes a crash. " Bad allocation" error message
https://bugs.documentfoundation.org/show_bug.cgi?id=109253 Bryan Leechchanged: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Version|5.4.0.1 rc |5.4.0.3 release Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109253] FONT NAME list: Scrolling through the list causes a crash. " Bad allocation" error message
https://bugs.documentfoundation.org/show_bug.cgi?id=109253 Bryan Leechchanged: What|Removed |Added Status|NEW |NEEDINFO CC||brya...@westnet.com.au --- Comment #11 from Bryan Leech --- I am having exactly the same problem. Reading through the comments, I can find no solution and this issue is making Libreoffice unusable. I note that the crash has never caused a problem with Windows (7 Home Premium 64-bit). I really hope this can be resolved. Thank you. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86905] EDITING outline level on non-heading paragraphs does not respect setting in Paragraph > Outline and Numbering > Outline level..
https://bugs.documentfoundation.org/show_bug.cgi?id=86905 Justin Lchanged: What|Removed |Added Blocks||75748 See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=75 ||748 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=75748 [Bug 75748] FILEOPEN: incorrect display of some numbering styles in .DOC and .DOCX -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75748] FILEOPEN: incorrect display of some numbering styles in .DOC and .DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=75748 Justin Lchanged: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=86 ||905 Depends on||86905 --- Comment #19 from Justin L --- Probably a duplicate of 86905, but marking as depends on... The numbering is based on the style name (Styl Nagłówek 3 + 10 pt Nie Pogrubienie Wyjustowany Przed: 0 p...). If the style is changed to header3 (which this one is based on) then it works, but styles "based on" header3 don't. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=86905 [Bug 86905] EDITING outline level on non-heading paragraphs does not respect setting in Paragraph > Outline and Numbering > Outline level.. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111887] New: Nested functions return wrong values
https://bugs.documentfoundation.org/show_bug.cgi?id=111887 Bug ID: 111887 Summary: Nested functions return wrong values Product: LibreOffice Version: 5.3.1.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: nemtudokolva...@gmail.com Created attachment 135627 --> https://bugs.documentfoundation.org/attachment.cgi?id=135627=edit Example test case Nested ISNUMBER(), LEN(), TRUNC() functions are evaluated improperly. According to function wizard, it's possible to get: * Err:502 or Err:504, * #VALUE!, * wrong type (e.g. ISNUMBER(12.16) = 5), * wrong value (e.g. TRUNC(12.16) = 5). Functions can mistakenly return the result of another functions. Breaking apart such a formula is the only solution. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111885] FORMATTING. Fatal error when changing fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=111885 --- Comment #1 from Telesto--- Sounds like bug 109253 (fatal error: bad alloc) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: [Libreoffice-commits] core.git: sw/inc sw/source
Ashod Nakashian wrote: > The code currently in master was a temporary first step. The logic I > currently have locally ready to push soon is to only use Text portions. > Hi Ashod, right, that should ~solve the definedness problem (modulo some questions around tabs/line breaks/whitespace collapsing, but there in theory ODF has algorithmic definitions already). > For now at least we are leaving all formatting/styles out of > document signing and only considering the plain text. > Ok. Just not sure if perhaps some common attributes shouldn't be included in the hashing, like e.g. xlink:href? Cheers, -- Thorsten signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] online.git: loleaflet/reference.html loleaflet/src tools/KitClient.cpp wsd/ClientSession.cpp wsd/DocumentBroker.cpp wsd/DocumentBroker.hpp wsd/protocol.txt wsd/Storage.cpp wsd/St
loleaflet/reference.html | 22 loleaflet/src/control/Control.Menubar.js |3 + loleaflet/src/control/Toolbar.js |9 ++- loleaflet/src/core/Socket.js |9 +++ loleaflet/src/map/handler/Map.WOPI.js| 11 +++- tools/KitClient.cpp |1 wsd/ClientSession.cpp|7 ++ wsd/DocumentBroker.cpp | 23 + wsd/DocumentBroker.hpp |3 + wsd/Storage.cpp | 79 +++ wsd/Storage.hpp |3 + wsd/protocol.txt | 16 +- 12 files changed, 177 insertions(+), 9 deletions(-) New commits: commit c3711a4375ec15a25b47cd62c8137f57145dbef5 Author: Aditya DewanDate: Thu Aug 10 04:32:03 2017 +0530 Extending WOPI implementaion to introduce 'Save As' feature Change-Id: Ic4c80f4c4b54944143682c25a5878c1336787b27 Reviewed-on: https://gerrit.libreoffice.org/40946 Reviewed-by: pranavk Tested-by: pranavk diff --git a/loleaflet/reference.html b/loleaflet/reference.html index dcd0a977..8f1ea583 100644 --- a/loleaflet/reference.html +++ b/loleaflet/reference.html @@ -2849,7 +2849,6 @@ Editor to WOPI host export of the document. - Session Management @@ -2914,6 +2913,18 @@ WOPI host to editor + Action_SaveAs + + Name: String + Path: String + + Creates copy of the document with given Name. + Name is the requested name for the new file. + Path is the relative path in the WOPI host file system where the + user wants the new file to be saved. + + + Action_Print @@ -3036,6 +3047,15 @@ Editor to WOPI host via Insert_Button API above is clicked. + + UI_SaveAs + + + Requests WOPI host to create appropriate UI, so that the user can choose + path and File name for creating a copy of the current file. + Response to this query is sent via Action_SaveAs message. + + Marker diff --git a/loleaflet/src/control/Control.Menubar.js b/loleaflet/src/control/Control.Menubar.js index af87725d..031bbb52 100644 --- a/loleaflet/src/control/Control.Menubar.js +++ b/loleaflet/src/control/Control.Menubar.js @@ -9,6 +9,7 @@ L.Control.Menubar = L.Control.extend({ text: [ {name: _('File'), id: 'file', type: 'menu', menu: [ {name: _('Save'), id: 'save', type: 'action'}, + {name: _('Save As'), id: 'saveas', type: 'action'}, {name: _('Print'), id: 'print', type: 'action'}, {name: _('See revision history'), id: 'rev-history', type: 'action'}, {name: _('Download as'), id: 'downloadas', type: 'menu', menu: [ @@ -566,6 +567,8 @@ L.Control.Menubar = L.Control.extend({ var id = $(item).data('id'); if (id === 'save') { map.save(true, true); + } else if (id === 'saveas') { + map.fire('postMessage', {msgId: 'UI_SaveAs'}); } else if (id === 'print') { map.print(); } else if (id.startsWith('downloadas-')) { diff --git a/loleaflet/src/control/Toolbar.js b/loleaflet/src/control/Toolbar.js index 832abdb0..25693170 100644 --- a/loleaflet/src/control/Toolbar.js +++ b/loleaflet/src/control/Toolbar.js @@ -84,20 +84,23 @@ L.Map.include({ this.downloadAs('print.pdf', 'pdf', null, 'print'); }, - saveAs: function (url, format, options) { + saveAs: function (newName, path, format, options) { if (format === undefined || format === null) { format = ''; } if (options === undefined || options === null) { options = ''; } + if (path === undefined || path === null) { + path = ''; + } - this.showBusy(_('Saving...'), false); // TakeOwnership: we are performing a 'real' save-as, the document // is just getting a new place, ie. it will get the // '.uno:ModifiedStatus' upon completion. this._socket.sendMessage('saveas ' + - 'url=' + url + ' ' + + 'fileName=' + newName + ' ' + + 'path=' + path + ' ' +
[Libreoffice-bugs] [Bug 103587] [HELP] Missing description for some options in Find & Replace dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=103587 Timurchanged: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||1886 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111886] New: DIALOG: Make Paragraph Styles and Comments more visible in compact Find & Replace dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=111886 Bug ID: 111886 Summary: DIALOG: Make Paragraph Styles and Comments more visible in compact Find & Replace dialog Product: LibreOffice Version: 5.2.0.0.beta1 Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: gti...@gmail.com I asked this in Bug 98539 - DIALOG: Improvements to the Find & Replace dialog, but since no response, I open a new bug. For Writer, I'd like to see "Paragraph Styles" and "Comments" more visible in Find & Replace dialog, i.e. in compact UI, as suggested in attachment 124657. Reason for "Paragraph Styles": I open expanded UI for Paragraph Styles rather often. Reason for "Comments": that's somewhat basic option, one could expect to find text in comments since they are visible. Please comment on this with you preferences and opinion. Calc option "Cell Styles" (related to "Paragraph Styles" in Writer) is now in expanded part, but if that's the price because of space, it's better to have "Cell Styles" up in compact and "Formatted display" down in expanded. I don't know what (new from 5.1) "Formatted display" is used for. Also no tooltips. I guess it should be obvious, but it's not, sorry. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 38328] Find & replace dialogue doesn't open through Ctrl+H ( former Ctrl+Alt+F) if cursor is in Find bar
https://bugs.documentfoundation.org/show_bug.cgi?id=38328 Timurchanged: What|Removed |Added Priority|medium |low Summary|Find & replace dialogue do |Find & replace dialogue |not open through Ctrl+Alt+F |doesn't open through Ctrl+H |/ Ctrl+H if cursor is in|(former Ctrl+Alt+F) if |find bar|cursor is in Find bar Severity|normal |trivial -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99393] Display Interface buttons icons LO
https://bugs.documentfoundation.org/show_bug.cgi?id=99393 --- Comment #10 from V Stuart Foote--- (In reply to Xisco Faulí from comment #9) > Could it be related to bug 107166 ? > Don't think so, other than that it is a hardware/driver issue. tdf#107166 is DirectWrite D2Write font rendering--here fonts are rendered but other graphics elements are dropped--we saw that with some of the early OpenGL glitches. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111885] New: FORMATTING. Fatal error when changing fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=111885 Bug ID: 111885 Summary: FORMATTING. Fatal error when changing fonts Product: LibreOffice Version: 5.4.0.3 release Hardware: Other OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: brya...@westnet.com.au Problem has only appeared with latest release of Libreoffice. This makes product unusable. [Intel Core i7 processor, 64-bit] -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108874] percent formatting lost when saving document and reopening
https://bugs.documentfoundation.org/show_bug.cgi?id=108874 Xavier Van Wijmeerschchanged: What|Removed |Added CC||xv3...@gmail.com --- Comment #4 from Xavier Van Wijmeersch --- no repro with Version: 6.0.0.0.alpha0+ Build ID: ec2abbca3d9befc4192452555a9433d267a47d58 CPU threads: 8; OS: Linux 4.9; UI render: default; VCL: gtk3; Locale: nl-BE (en_US.UTF-8); Calc: group and Version: 5.3.4.2 Build ID: SlackBuild for 5.3.4 by Eric Hameleers CPU Threads: 8; OS Version: Linux 4.9; UI Render: default; VCL: kde4; Layout Engine: new; Locale: nl-BE (en_US.UTF-8); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111884] PPTX with animation on grouped shapes opens with repair in PowerPoint after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=111884 Aron Budeachanged: What|Removed |Added Status|UNCONFIRMED |NEW Version|6.0.0.0.alpha0+ Master |4.0.0.3 release Ever confirmed|0 |1 --- Comment #1 from Aron Budea --- Also observed with LO 4.0.0.3. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104787] [META] FILESAVE: PPTX: Corrupted file in MSO PP after RT
https://bugs.documentfoundation.org/show_bug.cgi?id=104787 Aron Budeachanged: What|Removed |Added Depends on||111884 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=111884 [Bug 111884] PPTX with animation on grouped shapes opens with repair in PowerPoint after roundtrip -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111884] New: PPTX with animation on grouped shapes opens with repair in PowerPoint after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=111884 Bug ID: 111884 Summary: PPTX with animation on grouped shapes opens with repair in PowerPoint after roundtrip Product: LibreOffice Version: 6.0.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Keywords: filter:pptx Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ba...@caesar.elte.hu Blocks: 104787 Created attachment 135626 --> https://bugs.documentfoundation.org/attachment.cgi?id=135626=edit Sample PPTX The attached presentation contains a group of shapes with a simple animation. Save it as a new PPTX in Impress. The resulting file opens with repair in PowerPoint. Observed using LO 6.0 daily build (2017-08-15_01:59:49 / bebaac5eb6ebd2db3e1ea22b1630111343a9c25c) / Windows 7. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104787 [Bug 104787] [META] FILESAVE: PPTX: Corrupted file in MSO PP after RT -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Re: Suggestion: Finding missing words in dictionaries via web scraping and nlp
by "missing words in dictionaries", do you mean that if "teh" was used as an archaic spelling of "tea" in a work of Shakespeare (completely made up and hypothetical example), that we should add "teh" to the dictionary and no longer flag it as a wrongly spelled word? Of course not. The result of this would only be a candidate list. One would probably have to go through such a list manually and see if there really are missing words. Maybe this is not needed for the most common languages but for others it might be useful. I don't know it and that's why I'm asking if this would be something helpful. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 99393] Display Interface buttons icons LO
https://bugs.documentfoundation.org/show_bug.cgi?id=99393 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #9 from Xisco Faulí --- Could it be related to bug 107166 ? Could you please try to reproduce it with the latest version of LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ ? I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the latest version. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs