[Libreoffice-bugs] [Bug 119949] Filter broken by blank line
https://bugs.documentfoundation.org/show_bug.cgi?id=119949 raal changed: What|Removed |Added Status|REOPENED|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115566] Custom bullet (-) in presentation not exported into SVG
https://bugs.documentfoundation.org/show_bug.cgi?id=115566 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Keywords||filter:svg -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115566] Custom bullet (-) in presentation not exported into SVG
https://bugs.documentfoundation.org/show_bug.cgi?id=115566 --- Comment #3 from Roman Kuznetsov <79045_79...@mail.ru> --- still repro in Version: 6.3.0.0.alpha0+ Build ID: c57dc7d41bd62f933cffab6131edb7252606382d CPU threads: 4; OS: Windows 6.1; UI render: default; VCL: win; Locale: ru-RU (ru_RU); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122619] Remove AppMenu export via DBus
https://bugs.documentfoundation.org/show_bug.cgi?id=122619
--- Comment #1 from Arkadiy Illarionov ---
Please, don't remove it. It is used by global menu plugin for
{mate,vala,xfce4}-panel:
https://gitlab.com/vala-panel-project/vala-panel-appmenu
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123565] I Want an Acoustic plus an Optical Signal when Wrap Around happens when Searching or Searching and Replacing
https://bugs.documentfoundation.org/show_bug.cgi?id=123565 --- Comment #5 from Heiko Tietze --- (In reply to Jim Raykowski from comment #4) > I like how Kate and Qt Creator display a toast on search wrapping. We should avoid another bunch of options likely with non-familiar signals and trigger the inbuilt sound theme - crossplatform. Don't see any option in Kate (and don't get a beep, just the overlay in the middle of the canvas). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83247] VIEWING / SLIDESHOW: Pause duration in "Auto" mode defaults to 10s when presentation is opened in PowerPoint
https://bugs.documentfoundation.org/show_bug.cgi?id=83247 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=61 ||679 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 61679] SLIDESHOW: Enhancement request: control over the timing of presentation delay in kiosk mode
https://bugs.documentfoundation.org/show_bug.cgi?id=61679 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=83 ||247 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83247] VIEWING / SLIDESHOW: Pause duration in "Auto" mode defaults to 10s when presentation is opened in PowerPoint
https://bugs.documentfoundation.org/show_bug.cgi?id=83247 --- Comment #9 from Mike Kaganski --- See also bug 47365 comment 5. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83247] VIEWING / SLIDESHOW: Pause duration in "Auto" mode defaults to 10s when presentation is opened in PowerPoint
https://bugs.documentfoundation.org/show_bug.cgi?id=83247 --- Comment #8 from Mike Kaganski --- This is definitely a bug - or maybe several bugs: 1. In ODF: since PowerPoint seems to not support the pause option in presentations, it simply ignores any value set in presentation:pause attribute [1], and doesn't write it back to ODF. But LibreOffice treats the missing attribute as its "default" 10 s, which is incompliant to the standard which requires that missing attribute be treated as if 0 s pause duration was set. 2. In external formats (namely, PPT), it introduces the (default) delay of 10 s absent in the PPT. The problem is likely remedied simply by replacing the default of 10 s by 0 s in PresentationSettings::PresentationSettings() [2]. [1] http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.html#__RefHeading__1417722_253892949 [2] https://opengrok.libreoffice.org/xref/core/sd/source/core/drawdoc.cxx?r=e2d2a338#97 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122591] Added the function of "Set as preset pattern"
https://bugs.documentfoundation.org/show_bug.cgi?id=122591 --- Comment #12 from 和尚蟹 --- (In reply to Cor Nouws from comment #6) > is it for drawings? Not drawings. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/toolkit toolkit/source
include/toolkit/awt/vclxtopwindow.hxx |3 ---
toolkit/source/awt/vclxtopwindow.cxx |1 -
toolkit/source/awt/vclxwindow.cxx | 10 ++
3 files changed, 2 insertions(+), 12 deletions(-)
New commits:
commit 4c349c7b2fa422f17354b1db7231ffe4d15d3b44
Author: Noel Grandin
AuthorDate: Thu Feb 21 16:05:23 2019 +0200
Commit: Noel Grandin
CommitDate: Fri Feb 22 08:23:47 2019 +0100
loplugin:unusedfields in toolkit
Change-Id: Ida146892e786aa05cd9b94cd647a1c5849ecc2ce
Reviewed-on: https://gerrit.libreoffice.org/68162
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/toolkit/awt/vclxtopwindow.hxx
b/include/toolkit/awt/vclxtopwindow.hxx
index b018b20335f9..08777e280cee 100644
--- a/include/toolkit/awt/vclxtopwindow.hxx
+++ b/include/toolkit/awt/vclxtopwindow.hxx
@@ -39,9 +39,6 @@ class TOOLKIT_DLLPUBLIC VCLXTopWindow_Base :public
VCLXTopWindow_XBase
,public VCLXTopWindow_SBase
{
protected:
-css::uno::Reference< css::awt::XMenuBar> mxMenuBar;
-
-
virtual vcl::Window* GetWindowImpl() = 0;
virtual ::comphelper::OInterfaceContainerHelper2&
GetTopWindowListenersImpl() = 0;
diff --git a/toolkit/source/awt/vclxtopwindow.cxx
b/toolkit/source/awt/vclxtopwindow.cxx
index 69330da50fa6..fd78b543768f 100644
--- a/toolkit/source/awt/vclxtopwindow.cxx
+++ b/toolkit/source/awt/vclxtopwindow.cxx
@@ -159,7 +159,6 @@ void VCLXTopWindow_Base::setMenuBar( const
css::uno::Reference< css::awt::XMenuB
pSystemWindow->SetMenuBar( static_cast(
pMenu->GetMenu() ));
}
}
-mxMenuBar = rxMenu;
}
diff --git a/toolkit/source/awt/vclxwindow.cxx
b/toolkit/source/awt/vclxwindow.cxx
index f956569d0079..55a61ac36307 100644
--- a/toolkit/source/awt/vclxwindow.cxx
+++ b/toolkit/source/awt/vclxwindow.cxx
@@ -132,8 +132,6 @@ public:
std::unique_ptr
mpPropHelper;
-css::uno::Reference< css::awt::XPointer >
-mxPointer;
css::uno::Reference< css::accessibility::XAccessibleContext >
mxAccessibleContext;
css::uno::Reference< css::awt::XGraphics >
@@ -1147,12 +1145,8 @@ void VCLXWindow::setPointer( const css::uno::Reference<
css::awt::XPointer >& rx
SolarMutexGuard aGuard;
VCLXPointer* pPointer = VCLXPointer::GetImplementation( rxPointer );
-if ( pPointer )
-{
-mpImpl->mxPointer = rxPointer;
-if ( GetWindow() )
-GetWindow()->SetPointer( pPointer->GetPointer() );
-}
+if ( pPointer && GetWindow() )
+GetWindow()->SetPointer( pPointer->GetPointer() );
}
void VCLXWindow::setBackground( sal_Int32 nColor )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 121137] Numbering instruction integration program
https://bugs.documentfoundation.org/show_bug.cgi?id=121137 和尚蟹 changed: What|Removed |Added Resolution|FIXED |INVALID -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121137] Numbering instruction integration program
https://bugs.documentfoundation.org/show_bug.cgi?id=121137 和尚蟹 changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #8 from 和尚蟹 --- Because deleting the "command" causes the "tool column command" to display an error, the user deletes the "tool column command" and can achieve the same function, so the article is closed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/core/graphic/ndgrf.cxx |5 +
1 file changed, 1 insertion(+), 4 deletions(-)
New commits:
commit d5ae190a6fd483f3d0346ce4abbc4089f5092234
Author: Matteo Casalin
AuthorDate: Sun Feb 17 16:40:57 2019 +0100
Commit: Matteo Casalin
CommitDate: Fri Feb 22 07:53:16 2019 +0100
Remove confusing comment
Change-Id: I0e19228b50a19085c9eee70372b34a07e7255091
Reviewed-on: https://gerrit.libreoffice.org/68115
Tested-by: Jenkins
Reviewed-by: Matteo Casalin
diff --git a/sw/source/core/graphic/ndgrf.cxx b/sw/source/core/graphic/ndgrf.cxx
index 8045a4158135..1b32c727734b 100644
--- a/sw/source/core/graphic/ndgrf.cxx
+++ b/sw/source/core/graphic/ndgrf.cxx
@@ -569,13 +569,10 @@ void SwGrfNode::InsertLink( const OUString& rGrfName,
const OUString& rFltName )
if( rFltName == "DDE" )
{
sal_Int32 nTmp = 0;
-// Cannot use getToken as argument in function call:
-// evaluation order is undefined!
const OUString sApp{ rGrfName.getToken( 0, sfx2::cTokenSeparator,
nTmp ) };
const OUString sTopic{ rGrfName.getToken( 0,
sfx2::cTokenSeparator, nTmp ) };
const OUString sItem{ rGrfName.copy( nTmp ) };
-rIDLA.GetLinkManager().InsertDDELink( refLink.get(),
-sApp, sTopic, sItem );
+rIDLA.GetLinkManager().InsertDDELink( refLink.get(), sApp, sTopic,
sItem );
}
else
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 123225] Pivot table format lost in window machine when I save as ods calc file (LibreOffice calc 6.1) to 'Excel 2007-2019(.xlsx)' in linux machine
https://bugs.documentfoundation.org/show_bug.cgi?id=123225 --- Comment #11 from Aron Budea --- Please attach a sample ODS created in LibreOffice, an already buggy file is not useful in itself. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sd/source
sd/source/ui/framework/factories/FullScreenPane.cxx |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
New commits:
commit f5a7821d694b98e020fe57efdb0bc22470e9e022
Author: Matteo Casalin
AuthorDate: Thu Feb 21 18:23:37 2019 +0100
Commit: Matteo Casalin
CommitDate: Fri Feb 22 07:46:52 2019 +0100
Reduce scope
Change-Id: I66ccb752f67b19e5dfb5d77fece3d0e9828f5a5c
Reviewed-on: https://gerrit.libreoffice.org/68177
Tested-by: Jenkins
Reviewed-by: Matteo Casalin
diff --git a/sd/source/ui/framework/factories/FullScreenPane.cxx
b/sd/source/ui/framework/factories/FullScreenPane.cxx
index e092d6fc9319..b9d227c00dfe 100644
--- a/sd/source/ui/framework/factories/FullScreenPane.cxx
+++ b/sd/source/ui/framework/factories/FullScreenPane.cxx
@@ -216,11 +216,10 @@ void FullScreenPane::ExtractArguments (
{
// Extract arguments from the resource URL.
const util::URL aURL = rxPaneId->getFullResourceURL();
-sal_Int32 nIndex = 0;
-OUString sValue;
-while (nIndex >= 0)
+for (sal_Int32 nIndex{ 0 }; nIndex >= 0; )
{
const OUString aToken = aURL.Arguments.getToken(0, '&', nIndex);
+OUString sValue;
if (aToken.startsWith("ScreenNumber=", ))
{
rnScreenNumberReturnValue = sValue.toInt32();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/ui/unoobj/docuno.cxx | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
New commits:
commit 193d4c3741753ae19481c849864f55267889e47e
Author: Matteo Casalin
AuthorDate: Thu Feb 21 18:31:35 2019 +0100
Commit: Matteo Casalin
CommitDate: Fri Feb 22 07:46:21 2019 +0100
Revert "getToken+comparison ==> startsWith, reuse available information"
Not equivalent to original code, may cause problems in the future.
This reverts commit 0ae876595e9d9af44fc4d4bc948f8a42d8a27e8d.
Change-Id: Ifbec90620168903d8d3e807f2ca6751b3a82b85f
Reviewed-on: https://gerrit.libreoffice.org/68176
Tested-by: Jenkins
Reviewed-by: Matteo Casalin
diff --git a/sc/source/ui/unoobj/docuno.cxx b/sc/source/ui/unoobj/docuno.cxx
index ae8bd965f0b2..baf72864eff4 100644
--- a/sc/source/ui/unoobj/docuno.cxx
+++ b/sc/source/ui/unoobj/docuno.cxx
@@ -833,13 +833,20 @@ OString ScModelObj::getTextSelection(const char*
pMimeType, OString& rUsedMimeTy
// Take care of UTF-8 text here.
OString aMimeType(pMimeType);
-bool bConvert{ aMimeType.startsWith("text/plain;charset=utf-8") };
-if (bConvert)
-aMimeType = "text/plain;charset=utf-16";
+bool bConvert = false;
+sal_Int32 nIndex = 0;
+if (aMimeType.getToken(0, ';', nIndex) == "text/plain")
+{
+if (aMimeType.getToken(0, ';', nIndex) == "charset=utf-8")
+{
+aMimeType = "text/plain;charset=utf-16";
+bConvert = true;
+}
+}
datatransfer::DataFlavor aFlavor;
aFlavor.MimeType = OUString::fromUtf8(aMimeType.getStr());
-if (bConvert || aMimeType == "text/plain;charset=utf-16")
+if (aMimeType == "text/plain;charset=utf-16")
aFlavor.DataType = cppu::UnoType::get();
else
aFlavor.DataType = cppu::UnoType< uno::Sequence >::get();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/tox.hxx |8 --
sw/source/core/edit/edfcol.cxx |2 -
sw/source/core/unocore/unoidx.cxx |6
sw/source/filter/xml/xmltbli.cxx | 44 +
sw/source/filter/xml/xmltbli.hxx |4 ---
sw/source/ui/dbui/dbinsdlg.cxx |4 ---
sw/source/ui/dbui/mmlayoutpage.cxx |2 -
sw/source/ui/frmdlg/wrap.cxx |1
sw/source/ui/vba/vbacolumn.cxx |1
sw/source/ui/vba/vbacolumn.hxx |1
sw/source/uibase/dbui/mmconfigitem.cxx |1
sw/source/uibase/inc/conpoly.hxx |3 --
sw/source/uibase/inc/mmconfigitem.hxx |4 ---
sw/source/uibase/inc/wrap.hxx |1
sw/source/uibase/ribbar/conpoly.cxx|9 --
15 files changed, 16 insertions(+), 75 deletions(-)
New commits:
commit c50357ff625972464d1a591afe4198d3f6f42a39
Author: Noel Grandin
AuthorDate: Thu Feb 21 16:47:24 2019 +0200
Commit: Noel Grandin
CommitDate: Fri Feb 22 07:40:33 2019 +0100
loplugin:unusedfields in sw
Change-Id: Id68a01042f8398d7d4803a9ce7eb03620732f1ce
Reviewed-on: https://gerrit.libreoffice.org/68163
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/inc/tox.hxx b/sw/inc/tox.hxx
index ae5a75df26d6..75bf9d6e189c 100644
--- a/sw/inc/tox.hxx
+++ b/sw/inc/tox.hxx
@@ -61,7 +61,6 @@ class SW_DLLPUBLIC SwTOXMark
OUString m_aAltText;// Text of caption is different.
OUString m_aPrimaryKey;
OUString m_aSecondaryKey;
-OUString m_aCitationKeyReading;
// three more strings for phonetic sorting
OUString m_aTextReading;
@@ -120,7 +119,6 @@ public:
inline void SetTextReading(const OUString& rStr);
inline void SetPrimaryKeyReading(const OUString& rStr );
inline void SetSecondaryKeyReading(const OUString& rStr);
-inline void SetCitationKeyReading(const OUString& rStr);
inline OUString const & GetPrimaryKey() const;
inline OUString const & GetSecondaryKey() const;
@@ -591,12 +589,6 @@ inline void SwTOXMark::SetPrimaryKeyReading( const
OUString& rKey )
m_aPrimaryKeyReading = rKey;
}
-inline void SwTOXMark::SetCitationKeyReading( const OUString& rKey )
-{
-SAL_WARN_IF(GetTOXType()->GetType() != TOX_CITATION, "sw", "Wrong type");
-m_aCitationKeyReading = rKey;
-}
-
inline void SwTOXMark::SetSecondaryKeyReading( const OUString& rKey )
{
SAL_WARN_IF(GetTOXType()->GetType() != TOX_INDEX, "sw", "Wrong type");
diff --git a/sw/source/core/edit/edfcol.cxx b/sw/source/core/edit/edfcol.cxx
index ab0b35bf18fa..f3d4fe945c27 100644
--- a/sw/source/core/edit/edfcol.cxx
+++ b/sw/source/core/edit/edfcol.cxx
@@ -349,7 +349,6 @@ struct SignatureDescr
OUString msSignature;
OUString msUsage;
OUString msDate;
-OUString msId;
bool isValid() const { return !msSignature.isEmpty(); }
};
@@ -359,7 +358,6 @@ SignatureDescr lcl_getSignatureDescr(const
uno::Reference& xModel
const OUString& sFieldId)
{
SignatureDescr aDescr;
-aDescr.msId = sFieldId;
const OUString prefix = ParagraphSignatureRDFNamespace + sFieldId;
const std::map aStatements =
lcl_getRDFStatements(xModel, xParagraph);
diff --git a/sw/source/core/unocore/unoidx.cxx
b/sw/source/core/unocore/unoidx.cxx
index c7f3397b62b0..de2b67a7da37 100644
--- a/sw/source/core/unocore/unoidx.cxx
+++ b/sw/source/core/unocore/unoidx.cxx
@@ -1877,11 +1877,7 @@ SwXDocumentIndexMark::attach(
aMark.SetMainEntry(m_pImpl->m_bMainEntry);
break;
case TOX_CITATION:
-if (!m_pImpl->m_sCitaitonText.isEmpty())
-{
-aMark.SetCitationKeyReading(m_pImpl->m_sCitaitonText);
-}
-aMark.SetMainEntry(m_pImpl->m_bMainEntry);
+aMark.SetMainEntry(m_pImpl->m_bMainEntry);
break;
case TOX_USER:
case TOX_CONTENT:
diff --git a/sw/source/filter/xml/xmltbli.cxx b/sw/source/filter/xml/xmltbli.cxx
index 10bdae565e64..885abd80a5e5 100644
--- a/sw/source/filter/xml/xmltbli.cxx
+++ b/sw/source/filter/xml/xmltbli.cxx
@@ -169,7 +169,6 @@ class SwXMLTableCell_Impl
{
OUString aStyleName;
-OUString mXmlId;
OUString m_StringValue;
OUString sFormula; // cell formula; valid if length > 0
@@ -207,8 +206,7 @@ public:
bool bHasValue,
bool bCovered,
double dVal,
- OUString const*const pStringValue,
- OUString const& i_rXmlId);
+ OUString const*const pStringValue);
bool IsUsed() const { return pStartNode!=nullptr ||
xSubTable.is() || bProtected;}
@@ -244,8 +242,7 @@ inline void SwXMLTableCell_Impl::Set( const OUString&
rStyleName,
bool bHasVal,
bool bCov,
[Libreoffice-commits] core.git: include/ucbhelper ucbhelper/source ucb/source
include/ucbhelper/interactionrequest.hxx |1 -
ucb/source/cacher/cachedcontentresultsetstub.cxx |8 +++-
ucb/source/cacher/cachedcontentresultsetstub.hxx |5 +
ucb/source/ucp/hierarchy/hierarchyuri.cxx|2 --
ucb/source/ucp/hierarchy/hierarchyuri.hxx|1 -
ucb/source/ucp/tdoc/tdoc_uri.cxx |9 -
ucb/source/ucp/tdoc/tdoc_uri.hxx |2 --
ucbhelper/source/provider/interactionrequest.cxx |5 +
8 files changed, 5 insertions(+), 28 deletions(-)
New commits:
commit 131cc96a890b8988703532d09773bb0bde20ee8a
Author: Noel Grandin
AuthorDate: Thu Feb 21 16:03:13 2019 +0200
Commit: Noel Grandin
CommitDate: Fri Feb 22 07:39:44 2019 +0100
loplugin:unusedfields in ucb,ucbhelper
Change-Id: Id15c92e54669bd5f26adfe0d0b9dda0e8894ccf3
Reviewed-on: https://gerrit.libreoffice.org/68161
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/ucbhelper/interactionrequest.hxx
b/include/ucbhelper/interactionrequest.hxx
index 74df7f1f6c87..fca1a63c2cdd 100644
--- a/include/ucbhelper/interactionrequest.hxx
+++ b/include/ucbhelper/interactionrequest.hxx
@@ -314,7 +314,6 @@ class UCBHELPER_DLLPUBLIC InteractionSupplyAuthentication :
OUString m_aRealm;
OUString m_aUserName;
OUString m_aPassword;
-OUString m_aAccount;
css::ucb::RememberAuthentication m_eRememberPasswordMode;
css::ucb::RememberAuthentication const m_eDefaultRememberPasswordMode;
css::ucb::RememberAuthentication const m_eDefaultRememberAccountMode;
diff --git a/ucb/source/cacher/cachedcontentresultsetstub.cxx
b/ucb/source/cacher/cachedcontentresultsetstub.cxx
index b9085f7ac323..a648beac5e76 100644
--- a/ucb/source/cacher/cachedcontentresultsetstub.cxx
+++ b/ucb/source/cacher/cachedcontentresultsetstub.cxx
@@ -497,10 +497,8 @@ FetchResult SAL_CALL CachedContentResultSetStub
// class CachedContentResultSetStubFactory
-CachedContentResultSetStubFactory::CachedContentResultSetStubFactory(
-const Reference< XMultiServiceFactory > & rSMgr )
+CachedContentResultSetStubFactory::CachedContentResultSetStubFactory()
{
-m_xSMgr = rSMgr;
}
CachedContentResultSetStubFactory::~CachedContentResultSetStubFactory()
@@ -546,10 +544,10 @@ XSERVICEINFO_COMMOM_IMPL(
CachedContentResultSetStubFactory,
OUString(
"com.sun.star.comp.ucb.CachedContentResultSetStubFactory" ) )
/// @throws css::uno::Exception
static css::uno::Reference< css::uno::XInterface >
-CachedContentResultSetStubFactory_CreateInstance( const css::uno::Reference<
css::lang::XMultiServiceFactory> & rSMgr )
+CachedContentResultSetStubFactory_CreateInstance( const css::uno::Reference<
css::lang::XMultiServiceFactory> & )
{
css::lang::XServiceInfo* pX =
-static_cast(new
CachedContentResultSetStubFactory( rSMgr ));
+static_cast(new
CachedContentResultSetStubFactory);
return css::uno::Reference< css::uno::XInterface >::query( pX );
}
css::uno::Sequence< OUString >
diff --git a/ucb/source/cacher/cachedcontentresultsetstub.hxx
b/ucb/source/cacher/cachedcontentresultsetstub.hxx
index c4ba74410680..5a4182a63efd 100644
--- a/ucb/source/cacher/cachedcontentresultsetstub.hxx
+++ b/ucb/source/cacher/cachedcontentresultsetstub.hxx
@@ -146,12 +146,9 @@ class CachedContentResultSetStubFactory final
, public css::lang::XServiceInfo
, public css::ucb::XCachedContentResultSetStubFactory
{
-css::uno::Reference< css::lang::XMultiServiceFactory >m_xSMgr;
-
public:
-CachedContentResultSetStubFactory(
-const css::uno::Reference< css::lang::XMultiServiceFactory > & rSMgr);
+CachedContentResultSetStubFactory();
virtual ~CachedContentResultSetStubFactory() override;
diff --git a/ucb/source/ucp/hierarchy/hierarchyuri.cxx
b/ucb/source/ucp/hierarchy/hierarchyuri.cxx
index 8b7402d22dac..6bd2fc5952f1 100644
--- a/ucb/source/ucp/hierarchy/hierarchyuri.cxx
+++ b/ucb/source/ucp/hierarchy/hierarchyuri.cxx
@@ -46,7 +46,6 @@ void HierarchyUri::init() const
// Note: Maybe it's a re-init, setUri only resets m_aPath!
m_aService.clear();
m_aParentUri.clear();
-m_aName.clear();
// URI must match at least: :
if ( m_aUri.getLength() < HIERARCHY_URL_SCHEME_LENGTH + 1 )
@@ -165,7 +164,6 @@ void HierarchyUri::init() const
( nLastSlash != m_aUri.getLength() - 1 ) ) // root
{
m_aParentUri = m_aUri.copy( 0, nLastSlash );
-m_aName = m_aUri.copy( nLastSlash + 1 );
}
// success
diff --git a/ucb/source/ucp/hierarchy/hierarchyuri.hxx
b/ucb/source/ucp/hierarchy/hierarchyuri.hxx
index 4e67db7751ed..12973a9c3326 100644
--- a/ucb/source/ucp/hierarchy/hierarchyuri.hxx
+++ b/ucb/source/ucp/hierarchy/hierarchyuri.hxx
@@ -35,7 +35,6 @@ class HierarchyUri
mutable OUString m_aParentUri;
[Libreoffice-commits] core.git: 2 commits - include/vcl starmath/source vcl/inc vcl/source vcl/unx writerfilter/source writerperfect/inc
include/vcl/calendar.hxx |4 +--- include/vcl/dockwin.hxx|2 -- include/vcl/field.hxx |1 - include/vcl/font.hxx |1 - include/vcl/help.hxx |8 +--- include/vcl/longcurr.hxx |2 -- include/vcl/menu.hxx |1 - include/vcl/ppdparser.hxx |1 - include/vcl/print.hxx |1 - include/vcl/salnativewidgets.hxx |4 +--- include/vcl/vclmedit.hxx |3 --- starmath/source/ElementsDockingWindow.cxx |2 +- vcl/inc/helpwin.hxx|4 +--- vcl/inc/impfont.hxx|2 -- vcl/inc/listbox.hxx|2 -- vcl/inc/printerinfomanager.hxx |4 vcl/inc/salwtype.hxx |1 - vcl/inc/svdata.hxx |2 -- vcl/source/app/help.cxx|8 +++- vcl/source/app/svmain.cxx |2 -- vcl/source/control/calendar.cxx| 13 - vcl/source/control/field2.cxx |1 - vcl/source/control/listbox.cxx |1 - vcl/source/control/longcurr.cxx|3 --- vcl/source/control/scrbar.cxx |6 -- vcl/source/font/font.cxx |3 --- vcl/source/gdi/print.cxx |5 - vcl/source/gdi/print3.cxx |4 vcl/source/gdi/virdev.cxx |4 vcl/source/outdev/font.cxx |2 -- vcl/source/window/dockmgr.cxx |1 - vcl/source/window/dockwin.cxx |1 - vcl/source/window/menubarwindow.cxx|3 --- vcl/source/window/toolbox.cxx |4 ++-- vcl/source/window/window.cxx |6 +- vcl/unx/generic/printer/ppdparser.cxx |1 - vcl/unx/generic/printer/printerinfomanager.cxx |3 --- writerfilter/source/dmapper/FontTable.cxx |1 - writerfilter/source/dmapper/FontTable.hxx |1 - writerfilter/source/dmapper/OLEHandler.cxx |5 - writerfilter/source/dmapper/OLEHandler.hxx |5 - writerfilter/source/dmapper/SettingsTable.cxx |9 + writerperfect/inc/ImportFilter.hxx | 19 ++- 43 files changed, 18 insertions(+), 138 deletions(-) New commits: commit de9acc1dd0b72d1af92ac4de97840d98d4977820 Author: Noel Grandin AuthorDate: Thu Feb 21 15:30:44 2019 +0200 Commit: Noel Grandin CommitDate: Fri Feb 22 07:38:35 2019 +0100 loplugin:unusedfields in vcl maStatusText in HelpTextWindow is dead since commit bd3ea40ed49074c4fa4439de7b5dea4fc3161880 Date: Fri Jan 21 14:48:58 2011 +0200 Remove ShowHelpStatusText and HideHelpStatusText and associated cruft Change-Id: I7a74e2a1b909a479f9338bd4da5fad06ccc25283 Reviewed-on: https://gerrit.libreoffice.org/68153 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/include/vcl/calendar.hxx b/include/vcl/calendar.hxx index fe4f7ea7c0eb..338392453aec 100644 --- a/include/vcl/calendar.hxx +++ b/include/vcl/calendar.hxx @@ -138,7 +138,6 @@ class VCL_DLLPUBLIC Calendar final : public Control DatemaOldFirstDate; DatemaCurDate; DatemaOldCurDate; -DatemaAnchorDate; Color maSelColor; Color maOtherColor; sal_Int32 mnDayCount; @@ -184,8 +183,7 @@ class VCL_DLLPUBLIC Calendar final : public Control VCL_DLLPRIVATE void ImplDraw(vcl::RenderContext& rRenderContext); VCL_DLLPRIVATE void ImplUpdateDate( const Date& rDate ); VCL_DLLPRIVATE void ImplUpdateSelection( IntDateSet* pOld ); -VCL_DLLPRIVATE void ImplMouseSelect( const Date& rDate, sal_uInt16 nHitTest, - bool bMove ); +VCL_DLLPRIVATE void ImplMouseSelect( const Date& rDate, sal_uInt16 nHitTest ); VCL_DLLPRIVATE void ImplUpdate( bool bCalcNew = false ); using Window::ImplScroll; VCL_DLLPRIVATE void ImplScroll( bool bPrev ); diff --git a/include/vcl/dockwin.hxx b/include/vcl/dockwin.hxx index 5d88e9de65f1..2cf7ea7324ed 100644 --- a/include/vcl/dockwin.hxx +++ b/include/vcl/dockwin.hxx @@ -85,7 +85,6 @@ private: Point maFloatPos; Point maDockPos; Point maMouseOff; -Point maMouseStart; SizemaRollUpOutSize; SizemaMinOutSize; SizemaMaxOutSize; @@ -217,7 +216,6 @@ private: Point maFloatPos; Point maDockPos; Point
[Libreoffice-commits] core.git: unotools/source
unotools/source/config/defaultoptions.cxx |3 -
unotools/source/config/moduleoptions.cxx | 15 -
unotools/source/ucbhelper/ucblockbytes.cxx | 45 +
unotools/source/ucbhelper/ucblockbytes.hxx |7
4 files changed, 3 insertions(+), 67 deletions(-)
New commits:
commit 10134a2f8b604c934676e9e622d8123862a0b941
Author: Noel Grandin
AuthorDate: Thu Feb 21 16:00:28 2019 +0200
Commit: Noel Grandin
CommitDate: Fri Feb 22 07:39:19 2019 +0100
loplugin:unusedfields in unotools
Change-Id: Icbf95150f7f7e5cf73e7709487f0543f9c01c2ce
Reviewed-on: https://gerrit.libreoffice.org/68160
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/unotools/source/config/defaultoptions.cxx
b/unotools/source/config/defaultoptions.cxx
index a530e06eb628..7c9b4a38c0e4 100644
--- a/unotools/source/config/defaultoptions.cxx
+++ b/unotools/source/config/defaultoptions.cxx
@@ -91,7 +91,6 @@ public:
OUString m_aUserConfigPath;
OUString m_aWorkPath;
OUString m_aClassificationPath;
-OUString m_aUserDictionaryPath;
SvtDefaultOptions_Impl();
virtual ~SvtDefaultOptions_Impl() override;
@@ -309,7 +308,7 @@ SvtDefaultOptions_Impl::SvtDefaultOptions_Impl() :
ConfigItem( "Office.Common/Pa
case DEFAULTPATH_USERCONFIG: m_aUserConfigPath =
aFullPath;break;
case DEFAULTPATH_WORK: m_aWorkPath =
aFullPath; break;
case DEFAULTPATH_CLASSIFICATION: m_aClassificationPath =
aFullPath;break;
-case DEFAULTPATH_USERDICTIONARY: m_aUserDictionaryPath =
aFullPath;break;
+case DEFAULTPATH_USERDICTIONARY: break;
default:
SAL_WARN( "unotools.config", "invalid index to load a
default path" );
diff --git a/unotools/source/config/moduleoptions.cxx
b/unotools/source/config/moduleoptions.cxx
index 7bfcede60714..85cea00c93aa 100644
--- a/unotools/source/config/moduleoptions.cxx
+++ b/unotools/source/config/moduleoptions.cxx
@@ -105,10 +105,7 @@ struct FactoryInfo
{
bInstalled = false;
sFactory.clear();
-sShortName.clear();
sTemplateFile.clear();
-sWindowAttributes.clear();
-sEmptyDocumentURL.clear();
sDefaultFilter.clear();
nIcon = 0;
bChangedTemplateFile= false;
@@ -173,9 +170,6 @@ struct FactoryInfo
// But if you wish to set it without that... you must initialize it!
void initInstalled() {
bInstalled= true; }
void initFactory ( const OUString& sNewFactory ) {
sFactory = sNewFactory; }
-void initShortName( const OUString& sNewShortName) {
sShortName= sNewShortName; }
-void initWindowAttributes ( const OUString& sNewWindowAttributes ) {
sWindowAttributes = sNewWindowAttributes; }
-void initEmptyDocumentURL ( const OUString& sNewEmptyDocumentURL ) {
sEmptyDocumentURL = sNewEmptyDocumentURL; }
void initDefaultFilter( const OUString& sNewDefaultFilter) {
sDefaultFilter= sNewDefaultFilter; }
void setDefaultFilterReadonly( const bool bVal){bDefaultFilterReadonly
= bVal;}
void initIcon ( sal_Int32 nNewIcon
) { nIcon = nNewIcon; }
@@ -222,10 +216,7 @@ struct FactoryInfo
bool bInstalled;
OUString sFactory;
-OUString sShortName;
OUString sTemplateFile;
-OUString sWindowAttributes;
-OUString sEmptyDocumentURL;
OUString sDefaultFilter;
sal_Int32nIcon;
@@ -727,14 +718,8 @@ void SvtModuleOptions_Impl::impl_Read( const
css::uno::Sequence< OUString >& lFa
pInfo->initInstalled();
pInfo->initFactory ( sFactoryName );
-if (lValues[nPropertyStart+PROPERTYHANDLE_SHORTNAME] >>= sTemp)
-pInfo->initShortName( sTemp );
if (lValues[nPropertyStart+PROPERTYHANDLE_TEMPLATEFILE] >>= sTemp)
pInfo->initTemplateFile( sTemp );
-if (lValues[nPropertyStart+PROPERTYHANDLE_WINDOWATTRIBUTES] >>=
sTemp)
-pInfo->initWindowAttributes( sTemp );
-if (lValues[nPropertyStart+PROPERTYHANDLE_EMPTYDOCUMENTURL] >>=
sTemp)
-pInfo->initEmptyDocumentURL( sTemp );
if (lValues[nPropertyStart+PROPERTYHANDLE_DEFAULTFILTER ] >>=
sTemp)
pInfo->initDefaultFilter( sTemp );
if (lValues[nPropertyStart+PROPERTYHANDLE_ICON] >>= nTemp)
diff --git a/unotools/source/ucbhelper/ucblockbytes.cxx
b/unotools/source/ucbhelper/ucblockbytes.cxx
index
[Libreoffice-commits] core.git: 2 commits - unoxml/inc unoxml/source uui/source
unoxml/inc/node.hxx |1 -
unoxml/source/dom/node.cxx |1 -
unoxml/source/dom/saxbuilder.cxx |6 +-
unoxml/source/dom/saxbuilder.hxx |1 -
uui/source/iahndl-authentication.cxx |1 -
uui/source/loginerr.hxx |3 ---
6 files changed, 1 insertion(+), 12 deletions(-)
New commits:
commit 09394116502c54c8c6bbb9ec18e9ad991b7db83b
Author: Noel Grandin
AuthorDate: Thu Feb 21 15:50:15 2019 +0200
Commit: Noel Grandin
CommitDate: Fri Feb 22 07:39:04 2019 +0100
loplugin:unusedfields in unoxml
Change-Id: I03655d967dc165885bb51e4a931930590632c32d
Reviewed-on: https://gerrit.libreoffice.org/68159
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/unoxml/inc/node.hxx b/unoxml/inc/node.hxx
index ebfcd9bf15d4..216f80eda3d5 100644
--- a/unoxml/inc/node.hxx
+++ b/unoxml/inc/node.hxx
@@ -64,7 +64,6 @@ namespace DOM
{
OString maPrefix;
sal_Int32 mnToken;
-OUStringmaNamespaceURL;
const OString& getPrefix() const { return maPrefix; }
};
diff --git a/unoxml/source/dom/node.cxx b/unoxml/source/dom/node.cxx
index 73e2b5985f48..f486182eca83 100644
--- a/unoxml/source/dom/node.cxx
+++ b/unoxml/source/dom/node.cxx
@@ -90,7 +90,6 @@ namespace DOM
Context::Namespace aNS;
aNS.maPrefix = prefix;
aNS.mnToken = aIter->second;
-aNS.maNamespaceURL = val;
io_rContext.maNamespaces.back().push_back(aNS);
diff --git a/unoxml/source/dom/saxbuilder.cxx b/unoxml/source/dom/saxbuilder.cxx
index a8d1210c9c83..994a6c0392f6 100644
--- a/unoxml/source/dom/saxbuilder.cxx
+++ b/unoxml/source/dom/saxbuilder.cxx
@@ -191,12 +191,8 @@ namespace DOM
m_aNodeStack.top()->appendChild(aInstruction);
}
-void SAL_CALL CSAXDocumentBuilder::setDocumentLocator( const Reference<
XLocator >& xLocator )
+void SAL_CALL CSAXDocumentBuilder::setDocumentLocator( const Reference<
XLocator >& )
{
-::osl::MutexGuard g(m_Mutex);
-
-// set the document locator...
-m_aLocator = xLocator;
}
void SAL_CALL CSAXDocumentBuilder::startFastElement( sal_Int32 nElement ,
const Reference< XFastAttributeList >& xAttribs )
diff --git a/unoxml/source/dom/saxbuilder.hxx b/unoxml/source/dom/saxbuilder.hxx
index e2279a0c24bb..e20b5ccb95a5 100644
--- a/unoxml/source/dom/saxbuilder.hxx
+++ b/unoxml/source/dom/saxbuilder.hxx
@@ -56,7 +56,6 @@ namespace DOM
css::uno::Reference< css::xml::dom::XDocument > m_aDocument;
css::uno::Reference< css::xml::dom::XDocumentFragment > m_aFragment;
-css::uno::Reference< css::xml::sax::XLocator > m_aLocator;
public:
commit e0c9956a76514279a6df27f9752763e1ea20abbd
Author: Noel Grandin
AuthorDate: Thu Feb 21 15:50:06 2019 +0200
Commit: Noel Grandin
CommitDate: Fri Feb 22 07:38:51 2019 +0100
loplugin:unusedfields in uui
Change-Id: I4b5f359dd7af170bcdee5343078e4e36eeebdc85
Reviewed-on: https://gerrit.libreoffice.org/68158
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/uui/source/iahndl-authentication.cxx
b/uui/source/iahndl-authentication.cxx
index 6103f876e209..114cf8b87563 100644
--- a/uui/source/iahndl-authentication.cxx
+++ b/uui/source/iahndl-authentication.cxx
@@ -236,7 +236,6 @@ handleAuthenticationRequest_(
}
LoginErrorInfo aInfo;
-aInfo.SetTitle(rRequest.ServerName);
aInfo.SetServer(rRequest.ServerName);
if (rRequest.HasAccount)
aInfo.SetAccount(rRequest.Account);
diff --git a/uui/source/loginerr.hxx b/uui/source/loginerr.hxx
index bdfb7f06c19a..76973684c855 100644
--- a/uui/source/loginerr.hxx
+++ b/uui/source/loginerr.hxx
@@ -34,7 +34,6 @@
class LoginErrorInfo
{
private:
-OUString m_aTitle;
OUString m_aServer;
OUString m_aAccount;
OUString m_aUserName;
@@ -72,8 +71,6 @@ public:
sal_uInt8 GetFlags() const{ return m_nFlags; }
DialogMask GetResult() const { return m_nRet; }
-voidSetTitle( const OUString& aTitle )
-{ m_aTitle = aTitle; }
voidSetServer( const OUString& aServer )
{ m_aServer = aServer; }
voidSetAccount( const OUString& aAccount )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 123225] Pivot table format lost in window machine when I save as ods calc file (LibreOffice calc 6.1) to 'Excel 2007-2019(.xlsx)' in linux machine
https://bugs.documentfoundation.org/show_bug.cgi?id=123225 --- Comment #10 from Pradip_0382 --- Hi, I tried with 6.3 libreoffice. Created pivot report and save as .xlsx in Linux machine.Tried to open the same file in windows machine with Ms office. Issue:Missing some functionalities of pivot report. but after click refresh button i can get all pivot functionalities there. Is there any fix for to overcome the refresh button click? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123508] "Fit print range(s) to width/height" value falls back to default when window closes
https://bugs.documentfoundation.org/show_bug.cgi?id=123508 --- Comment #8 from Commit Notification --- Zdeněk Crhonek committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/3114e187e5abd34207f220b6d9f42b63b4fe0bd8%5E%21 uitest for bug tdf#123508 It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/Module_sc.mk sc/qa sc/UITest_pageFormat.mk
sc/Module_sc.mk|1
sc/UITest_pageFormat.mk| 20 +
sc/qa/uitest/calc_tests/data/tdf123508.ods |binary
sc/qa/uitest/pageFormat/tdf123508.py | 64 +
4 files changed, 85 insertions(+)
New commits:
commit 3114e187e5abd34207f220b6d9f42b63b4fe0bd8
Author: Zdeněk Crhonek
AuthorDate: Thu Feb 21 16:34:51 2019 +0100
Commit: Zdenek Crhonek
CommitDate: Fri Feb 22 06:39:28 2019 +0100
uitest for bug tdf#123508
Change-Id: Iab59789ce57295d204ad475cd5405bcdd1f5b9ef
Reviewed-on: https://gerrit.libreoffice.org/68164
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek
diff --git a/sc/Module_sc.mk b/sc/Module_sc.mk
index 15455b6fe7da..8104af4cd6c1 100644
--- a/sc/Module_sc.mk
+++ b/sc/Module_sc.mk
@@ -239,6 +239,7 @@ $(eval $(call gb_Module_add_uicheck_targets,sc,\
UITest_calc_tests7 \
UITest_sort \
UITest_chart \
+ UITest_pageFormat \
))
endif
diff --git a/sc/UITest_pageFormat.mk b/sc/UITest_pageFormat.mk
new file mode 100644
index ..1cb0e0f9174f
--- /dev/null
+++ b/sc/UITest_pageFormat.mk
@@ -0,0 +1,20 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call gb_UITest_UITest,pageFormat))
+
+$(eval $(call gb_UITest_add_modules,pageFormat,$(SRCDIR)/sc/qa/uitest,\
+ pageFormat/ \
+))
+
+$(eval $(call gb_UITest_set_defs,pageFormat, \
+TDOC="$(SRCDIR)/sc/qa/uitest/calc_tests/data" \
+))
+
+# vim: set noet sw=4 ts=4:
diff --git a/sc/qa/uitest/calc_tests/data/tdf123508.ods
b/sc/qa/uitest/calc_tests/data/tdf123508.ods
new file mode 100644
index ..a91951b08c97
Binary files /dev/null and b/sc/qa/uitest/calc_tests/data/tdf123508.ods differ
diff --git a/sc/qa/uitest/pageFormat/tdf123508.py
b/sc/qa/uitest/pageFormat/tdf123508.py
new file mode 100644
index ..c99ec01eaa2a
--- /dev/null
+++ b/sc/qa/uitest/pageFormat/tdf123508.py
@@ -0,0 +1,64 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+from uitest.framework import UITestCase
+from uitest.uihelper.common import get_state_as_dict
+from uitest.uihelper.common import select_pos
+from uitest.uihelper.calc import enter_text_to_cell
+from libreoffice.calc.document import get_cell_by_position
+from libreoffice.uno.propertyvalue import mkPropertyValues
+from uitest.uihelper.common import get_state_as_dict, type_text
+import org.libreoffice.unotest
+import pathlib
+
+def get_url_for_data_file(file_name):
+return
pathlib.Path(org.libreoffice.unotest.makeCopyFromTDOC(file_name)).as_uri()
+
+#Bug 123508 - "Fit print range(s) to width/height" value falls back to default
when window closes
+
+class tdf123508(UITestCase):
+ def test_tdf123508_format_page_scale(self):
+calc_doc = self.ui_test.load_file(get_url_for_data_file("tdf123508.ods"))
+xCalcDoc = self.xUITest.getTopFocusWindow()
+gridwin = xCalcDoc.getChild("grid_window")
+document = self.ui_test.get_component()
+#open "Format > Page - Sheet > Scale
+self.ui_test.execute_dialog_through_command(".uno:PageFormatDialog")
+xDialog = self.xUITest.getTopFocusWindow()
+xTabs = xDialog.getChild("tabcontrol")
+select_pos(xTabs, "6") #tab Scale
+scalingMode = xDialog.getChild("comboLB_SCALEMODE")
+spinEDSCALEPAGEWIDTH = xDialog.getChild("spinED_SCALEPAGEWIDTH")
+spinEDSCALEPAGEHEIGHT = xDialog.getChild("spinED_SCALEPAGEHEIGHT")
+#select "Fit print range(s) to width/height" from the scale mode
drop-down list
+props = {"TEXT": "Fit print range(s) to width/height"}
+actionProps = mkPropertyValues(props)
+scalingMode.executeAction("SELECT", actionProps)
+#define a value for the page, e.g.: width 2; height 2
+spinEDSCALEPAGEWIDTH.executeAction("UP", tuple())
+spinEDSCALEPAGEHEIGHT.executeAction("UP", tuple())
+
+xOKBtn = xDialog.getChild("ok")
+self.ui_test.close_dialog_through_button(xOKBtn)
+
+#verify
+self.ui_test.execute_dialog_through_command(".uno:PageFormatDialog")
+xDialog = self.xUITest.getTopFocusWindow()
+xTabs = xDialog.getChild("tabcontrol")
+select_pos(xTabs, "6") #tab Scale
+scalingMode = xDialog.getChild("comboLB_SCALEMODE")
+spinEDSCALEPAGEWIDTH = xDialog.getChild("spinED_SCALEPAGEWIDTH")
+spinEDSCALEPAGEHEIGHT = xDialog.getChild("spinED_SCALEPAGEHEIGHT")
+
+self.assertEqual(get_state_as_dict(scalingMode)["SelectEntryText"], "Fit
print range(s) to width/height")
+
[Libreoffice-bugs] [Bug 123508] "Fit print range(s) to width/height" value falls back to default when window closes
https://bugs.documentfoundation.org/show_bug.cgi?id=123508 Commit Notification changed: What|Removed |Added Whiteboard||target:6.3.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104309] Scrollbar form element is lost entirely when saving as xlsx
https://bugs.documentfoundation.org/show_bug.cgi?id=104309 --- Comment #5 from stragu --- I confirm the behaviour exactly as described in original report, tested with: Version: 6.1.5.2 Build ID: 1:6.1.5~rc2-0ubuntu0.18.04.1~lo3 CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: en-AU (en_AU.UTF-8); Calc: group threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123638] New: Pivot Refresh to be included in the Recalculate Hard(CTRL+SHIFT+F9)
https://bugs.documentfoundation.org/show_bug.cgi?id=123638 Bug ID: 123638 Summary: Pivot Refresh to be included in the Recalculate Hard(CTRL+SHIFT+F9) Product: LibreOffice Version: 6.2.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: perie_...@hotmail.com Created attachment 149502 --> https://bugs.documentfoundation.org/attachment.cgi?id=149502=edit sample I have a Base connected in my Calc via Multiple Pivot Tables and it is too taxing updating each pivot tables. Is it possible to include the "Refresh" of all pivot tables on the Recalculated Hard process. Version: 6.2.0.3 (x64) Build ID: 98c6a8a1c6c7b144ce3cc729e34964b47ce25d62 CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; Locale: en-PH (en_PH); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123638] Pivot Refresh to be included in the Recalculate Hard(CTRL+SHIFT+F9)
https://bugs.documentfoundation.org/show_bug.cgi?id=123638 perie_...@hotmail.com changed: What|Removed |Added Keywords||perf, regression -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123631] Closing a document and going back to LibreOffice-main then causes multiple menu-bars to appear
https://bugs.documentfoundation.org/show_bug.cgi?id=123631 --- Comment #2 from Alfredo --- After some experimentation I have found that this is not a LibreOffice bug. It only happens when the LanguageTool 4.4.1 extension is installed and enabled. If the extension is disabled or LibreOffice restored to the default settings everything works as expected. I will try to let the extension author know. Thank you very much for your time and effort. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit b1ede813da23ab54ab7df0fa92cb5bbfcc524aae Author: Andrea Gelmini AuthorDate: Thu Feb 21 21:05:12 2019 +0100 Commit: Gerrit Code Review CommitDate: Fri Feb 22 05:35:42 2019 +0100 Update git submodules * Update helpcontent2 from branch 'master' - Fix typo Change-Id: I3946d4ed9f9c38d0d30f89427b44bb6696b85f8a Reviewed-on: https://gerrit.libreoffice.org/68182 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/helpcontent2 b/helpcontent2 index 5489ccad66f7..49d8f790a781 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 5489ccad66f7bb892c09c68baa9d38b351c01b59 +Subproject commit 49d8f790a781c027b19772daf72820e6c9572f6b ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/sbasic/python/python_dialogs.xhp |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 49d8f790a781c027b19772daf72820e6c9572f6b Author: Andrea Gelmini AuthorDate: Thu Feb 21 21:05:12 2019 +0100 Commit: Adolfo Jayme Barrientos CommitDate: Fri Feb 22 05:35:42 2019 +0100 Fix typo Change-Id: I3946d4ed9f9c38d0d30f89427b44bb6696b85f8a Reviewed-on: https://gerrit.libreoffice.org/68182 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/source/text/sbasic/python/python_dialogs.xhp b/source/text/sbasic/python/python_dialogs.xhp index 2ba1ad81f..7bcb34ebd 100644 --- a/source/text/sbasic/python/python_dialogs.xhp +++ b/source/text/sbasic/python/python_dialogs.xhp @@ -10,7 +10,7 @@ --> -Python : Opening a Dialog +Python: Opening a Dialog /text/sbasic/python/python_dialogs.xhp @@ -23,7 +23,7 @@ Opening a Dialog in Python -%PRODUCTNAME static dialogs are created with the Dialog editor and are stored in varying places according to their personal (My Macros), shared (%PRODUCTNAME Macros) or document-embedded nature. In reverse, dynamic dialogs are constructed at runtime, from on Basic or Python scripts, or using any other %PRODUCTNAME supported language for that matter. Opening static dialogs with Python is illustrated herewith. Exception handling and internationalization are omitted for clarity. +%PRODUCTNAME static dialogs are created with the Dialog editor and are stored in varying places according to their personal (My Macros), shared (%PRODUCTNAME Macros) or document-embedded nature. In reverse, dynamic dialogs are constructed at runtime, from on Basic or Python scripts, or using any other %PRODUCTNAME supported language for that matter. Opening static dialogs with Python is illustrated herewith. Exception handling and internationalization are omitted for clarity. My Macros or %PRODUCTNAME Macros dialogs The examples below open Access2Base Trace console or the imported TutorialsDialog dialog with Tools – Macros – Run Macro... menu: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 107348] Pasting transpose of filtered data pastes unfiltered data
https://bugs.documentfoundation.org/show_bug.cgi?id=107348 --- Comment #4 from Mohith Manoj --- Issue persists... Tested in, Version: 6.1.4.2 (x64) Build ID: 9d0f32d1f0b509096fd65e0d4bec26ddd1938fd3 CPU threads: 4; OS: Windows 6.3; UI render: default; Locale: en-US (en_US); Calc: group threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107348] Pasting transpose of filtered data pastes unfiltered data
https://bugs.documentfoundation.org/show_bug.cgi?id=107348 --- Comment #3 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115896] FILEOPEN Shape in table in a DOC appears on wrong side of the page
https://bugs.documentfoundation.org/show_bug.cgi?id=115896 --- Comment #3 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115566] Custom bullet (-) in presentation not exported into SVG
https://bugs.documentfoundation.org/show_bug.cgi?id=115566 --- Comment #2 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115894] Default formatting on selected text reset the size of the textbox unexpectedly.
https://bugs.documentfoundation.org/show_bug.cgi?id=115894 --- Comment #3 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47490] CONFIGURATION: "Show overwrite warning when pasting data" setting is not honored when "Enter" is used to paste
https://bugs.documentfoundation.org/show_bug.cgi?id=47490 --- Comment #5 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83762] FORMATTING: Cursor can be Positioned beyond Paper Margins by Using Negative Indentation Values
https://bugs.documentfoundation.org/show_bug.cgi?id=83762 --- Comment #8 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123565] I Want an Acoustic plus an Optical Signal when Wrap Around happens when Searching or Searching and Replacing
https://bugs.documentfoundation.org/show_bug.cgi?id=123565 --- Comment #4 from Jim Raykowski --- An acoustic signal would of course be an opt in setting. Impress can play audio media so it might be possible to use in Writer. I like how Kate and Qt Creator display a toast on search wrapping. IMHO what we have now is adequate but these seem like they would be nice enhancements. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102005] START CENTER: Pressing F6 stops at thumbnail list view
https://bugs.documentfoundation.org/show_bug.cgi?id=102005 --- Comment #8 from Jim Raykowski --- Hi All, Here is a patch for this: https://gerrit.libreoffice.org/#/c/68185/ I don't know what the Template Manager part of the patch that caused this regression is so I couldn't test if this patch fixes F6 navigation in it although I suspect it does. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123158] isNumeric returns false if number is passed as String
https://bugs.documentfoundation.org/show_bug.cgi?id=123158
--- Comment #8 from Leos Pohl ---
To complement my full results:
Version: 6.1.5.2
Build ID: 90f8dcf33c87b3705e78202e3df5142b201bd805
CPU threads: 8; OS: Mac OS X 10.14.3; UI render: default;
Locale: cs-CZ (cs_CZ.UTF-8); Calc: group threaded
(locale decimal separator is ",")
IsNumeric(1,2) = True
IsNumeric(1.2) = True
IsNumeric("1.2") = False
IsNumeric("1,2") = True
So maybe if the input is a String, it does depend on the Locale but regardless
of the input type, it needs to provide consistent results which it does not.
Whether it is correct to take into account the locale or not is a good question
because, if a the table has numbers stored as text (e.g. '1.2) then when such a
workbook is transported onto a system with such locale that the decimal
separator is "," these numbers are not automatically transformed to have the
correct decimal separator but it is still a number (at least it was supposed as
such on the other system), regardless of the fact that it is stored as text and
since the point of isNumeric is to determine whether a Variant type (i.e. even
a string) is a correct number, from this point of view both isNumber should be
insensitive to the locale.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123158] isNumeric returns false if number is passed as String
https://bugs.documentfoundation.org/show_bug.cgi?id=123158
--- Comment #9 from Leos Pohl ---
To complement my full results:
Version: 6.1.5.2
Build ID: 90f8dcf33c87b3705e78202e3df5142b201bd805
CPU threads: 8; OS: Mac OS X 10.14.3; UI render: default;
Locale: cs-CZ (cs_CZ.UTF-8); Calc: group threaded
(locale decimal separator is ",")
IsNumeric(1,2) = True
IsNumeric(1.2) = True
IsNumeric("1.2") = False
IsNumeric("1,2") = True
So maybe if the input is a String, it does depend on the Locale but regardless
of the input type, it needs to provide consistent results which it does not.
Whether it is correct to take into account the locale or not is a good question
because, if a the table has numbers stored as text (e.g. '1.2) then when such a
workbook is transported onto a system with such locale that the decimal
separator is "," these numbers are not automatically transformed to have the
correct decimal separator but it is still a number (at least it was supposed as
such on the other system), regardless of the fact that it is stored as text and
since the point of isNumeric is to determine whether a Variant type (i.e. even
a string) is a correct number, from this point of view both isNumber should be
insensitive to the locale.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123637] Crash when Navigate By Headings search wraps from end to beginning of file
https://bugs.documentfoundation.org/show_bug.cgi?id=123637 Julien Nabet changed: What|Removed |Added Keywords||haveBacktrace Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123637] Crash when Navigate By Headings search wraps from end to beginning of file
https://bugs.documentfoundation.org/show_bug.cgi?id=123637 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #1 from Julien Nabet --- Created attachment 149501 --> https://bugs.documentfoundation.org/attachment.cgi?id=149501=edit bt with debug symbols On pc Debian x86-64 with master sources updated some days ago, I could reproduce this. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123637] New: Crash when Navigate By Headings search wraps from end to beginning of file
https://bugs.documentfoundation.org/show_bug.cgi?id=123637 Bug ID: 123637 Summary: Crash when Navigate By Headings search wraps from end to beginning of file Product: LibreOffice Version: 6.2.0.0.beta1+ Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rayk...@gmail.com Created attachment 149500 --> https://bugs.documentfoundation.org/attachment.cgi?id=149500=edit Headings search crash test file Steps to repro: 1) Open writer with the attached file 2) Menu > View > Toolbars > Find 3) Select Headings in the Navigate By list box 4) Press the Next Heading control until crash occurs (4 presses) I have traced the bug to the following commit: commit d0e9cc832d19b622532f01580d9cf78ee0b215db Author: Michael Stahl , Thu Oct 25 11:06:38 2018 +0200 (4 months ago) Committer: Michael Stahl , Thu Nov 15 15:10:02 2018 +0100 (3 months ago) Follows: libreoffice-6-2-branch-point Precedes: libreoffice-6.2.0.0.beta1 sw_redlinehide_3: adapt GotoOutline for SwCursrShell Adapt SwDoc::GotoOutline(), SwCursorShell::GotoNextOutline(), SwCursorShell::GotoPrevOutline() to skip over outline nodes that are merged away in the layout. Change-Id: Id6f6bb93177753ed21a438c89dc6d90098e11455 It seems to be an issue with accessing an array out of bounds. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Cygwin 3.0.0-1 Released
Am 17.02.19 um 00:28 schrieb Luke Benes via LibreOffice: > Info on this major release can be found here: > https://cygwin.com/ml/cygwin/2019-02/msg00229.html > > Do any of these improvements look beneficial to LibreOffice? I'm not aware LO depends on any Cygwin version. Actually updating Cygwin broke the build for me a few times. Did you try to build LO with current Cygwin 3? If it breaks for you we need to fix configure, as there is no way to install older Cygwin for new contributors. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sd/source
sd/source/ui/view/viewshel.cxx | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
New commits:
commit a9de98d3b874de12d2533dbb5a4db30c6e3e81b6
Author: Matteo Casalin
AuthorDate: Thu Feb 21 18:30:32 2019 +0100
Commit: Stephan Bergmann
CommitDate: Thu Feb 21 22:55:37 2019 +0100
Revert "Simplify: getToken+comparison ==> startsWith"
Not equivalent to original code, may cause problems in the future.
This reverts commit 4d341228fc9988fbf22695494197ace5a342426c.
Change-Id: Ie91e43496c3ff67d31a0fc363638dde41fffa550
Reviewed-on: https://gerrit.libreoffice.org/68175
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/sd/source/ui/view/viewshel.cxx b/sd/source/ui/view/viewshel.cxx
index 9163d2142dd2..4f321bd7134b 100644
--- a/sd/source/ui/view/viewshel.cxx
+++ b/sd/source/ui/view/viewshel.cxx
@@ -534,10 +534,17 @@ OString ViewShell::GetTextSelection(const OString&
_aMimeType, OString& rUsedMim
uno::Reference xTransferable =
rEditView.GetEditEngine()->CreateTransferable(rEditView.GetSelection());
// Take care of UTF-8 text here.
+bool bConvert = false;
+sal_Int32 nIndex = 0;
OString aMimeType = _aMimeType;
-const bool bConvert{ aMimeType.startsWith("text/plain;charset=utf-8") };
-if (bConvert)
-aMimeType = "text/plain;charset=utf-16";
+if (aMimeType.getToken(0, ';', nIndex) == "text/plain")
+{
+if (aMimeType.getToken(0, ';', nIndex) == "charset=utf-8")
+{
+aMimeType = "text/plain;charset=utf-16";
+bConvert = true;
+}
+}
datatransfer::DataFlavor aFlavor;
aFlavor.MimeType = OUString::fromUtf8(aMimeType.getStr());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: distro-configs/Jenkins
distro-configs/Jenkins/linux_clang_dbgutil_64 |1 + distro-configs/Jenkins/linux_gcc_release_64 |2 +- 2 files changed, 2 insertions(+), 1 deletion(-) New commits: commit 7d2afd1c205d324447e42a8281f646b086882cd5 Author: Michael Weghorn AuthorDate: Thu Feb 21 16:39:23 2019 +0100 Commit: Michael Weghorn CommitDate: Thu Feb 21 22:42:56 2019 +0100 '--enable-kde5' for Jenkins CI builds As discussed in ESC call of 2019-02-21, enable kde5 for the Jenkins CI builds to detect build issues *before* the changes get merged. Change-Id: I44b0e611348a22b390b6ec89d3ed1d7eb7bddd63 Reviewed-on: https://gerrit.libreoffice.org/68165 Tested-by: Jenkins Reviewed-by: Michael Weghorn diff --git a/distro-configs/Jenkins/linux_clang_dbgutil_64 b/distro-configs/Jenkins/linux_clang_dbgutil_64 index 004f02afaba9..2feee4326da6 100644 --- a/distro-configs/Jenkins/linux_clang_dbgutil_64 +++ b/distro-configs/Jenkins/linux_clang_dbgutil_64 @@ -1,3 +1,4 @@ --enable-dbgutil --enable-compiler-plugins COMPILER_PLUGINS_CXX=ccache g++ -std=c++11 +--enable-kde5 diff --git a/distro-configs/Jenkins/linux_gcc_release_64 b/distro-configs/Jenkins/linux_gcc_release_64 index ffdfe19bc18b..e2e56dc802eb 100644 --- a/distro-configs/Jenkins/linux_gcc_release_64 +++ b/distro-configs/Jenkins/linux_gcc_release_64 @@ -1,3 +1,3 @@ CC=/opt/rh/devtoolset-7/root/usr/bin/gcc CXX=/opt/rh/devtoolset-7/root/usr/bin/g++ - +--enable-kde5 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 118991] EDITING. 100% CPU usage after a few minutes with certain documents.
https://bugs.documentfoundation.org/show_bug.cgi?id=118991 rar...@pm.me changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #18 from rar...@pm.me --- Cross post with Bug 120727, as this look similar: Hello, i had the same problem as laurens with older version of Libreoffice, i uninstalled and reinstall last version and same problem again: even only scrolling a simple document with text (and with the example of laurens as well in Bug 120727) is a nightmare: so slow. Version: 6.2.0.3 Build ID: 98c6a8a1c6c7b144ce3cc729e34964b47ce25d62 CPU threads: 4; OS: Mac OS X 10.14.3; UI render: default; VCL: osx; Locale: fr-FR (en_FR.UTF-8); UI-Language: en-US Calc: threaded Computer: Model Name: MacBook Pro Model Identifier: MacBookPro13,1 Processor Name: Intel Core i5 Processor Speed: 2 GHz Number of Processors: 1 Total Number of Cores:2 L2 Cache (per Core): 256 KB L3 Cache: 4 MB Memory: 8 GB Boot ROM Version: 228.0.0.0.0 SMC Version (system): 2.36f97 When scrolling, MAC OS activity monitor shows at least 60% use of CPU, up to more than 100% in a few seconds of scrolling. Degrading to right click in libreoffice.app and"get info, low resolution" is better but still slow; and ugly. Thanks for help! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117761] Snake Algorithm unable to display accurate layout.
https://bugs.documentfoundation.org/show_bug.cgi?id=117761 Commit Notification changed: What|Removed |Added Whiteboard|target:6.2.0 target:6.1.4 |target:6.2.0 target:6.1.4 |target:6.1.5 target:6.2.1 |target:6.1.5 target:6.2.1 |target:6.1.6|target:6.1.6 target:6.2.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117761] Snake Algorithm unable to display accurate layout.
https://bugs.documentfoundation.org/show_bug.cgi?id=117761 --- Comment #9 from Commit Notification --- Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-6-1": https://git.libreoffice.org/core/+/abab6e096839838e60222c635cf51629d7ce48d5%5E%21 Related: tdf#117761 oox smartart: backport fixes related to cycle matrix It will be available in 6.1.6. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - oox/source sd/qa
oox/source/drawingml/diagram/diagram.cxx| 11 +- oox/source/drawingml/diagram/diagram.hxx|8 + oox/source/drawingml/diagram/diagramlayoutatoms.cxx | 71 --- oox/source/drawingml/diagram/diagramlayoutatoms.hxx |4 oox/source/drawingml/diagram/layoutnodecontext.cxx | 16 ++- sd/qa/unit/data/pptx/smartart-cycle-matrix.pptx |binary sd/qa/unit/import-tests-smartart.cxx| 93 7 files changed, 181 insertions(+), 22 deletions(-) New commits: commit abab6e096839838e60222c635cf51629d7ce48d5 Author: Miklos Vajna AuthorDate: Thu Feb 7 16:26:31 2019 +0100 Commit: Andras Timar CommitDate: Thu Feb 21 22:32:23 2019 +0100 Related: tdf#117761 oox smartart: backport fixes related to cycle matrix This is a combination of 6 commits. This is the 1st commit: oox smartart, cycle matrix: fix counting presentation children The markup is: Where PowerPoint evaluated the condition to true, but Impress evaluated to false. This means that the undocumented relation between the child lists is "OR" (not "AND"). Also, our code assumed that "node" has to be a data node (not presentation node), but it seems the only way this condition can be true if presentation children is also counted. (The presentation node in question is not a presentation of anything.) (cherry picked from commit e3c6f249c10f7f1bcc528e643f5723288c514b29) This is the commit #2: oox smartart, cycle matrix: handle left/bottom constraint in composite algo The bugdoc has 3 shapes in the "outer" circle which have a position where either x or y is not 0. But these are defined using constraints talking about the right or bottom edge of the shape. Map that to top/left, given that we already know the shape size. (cherry picked from commit b9b4e9223b6c0d6e0b48b694c9aabbe54a250660) This is the commit #3: oox smartart, cycle matrix: fix too large height in composite algo The user-level problem was that the height of the entire smartart was too large. The reason for this was that: - composite algorithm gets the constraint height should be 77% of width, this means 6096000 -> 4693920 EMUs - at the same time the parent container is already smaller, 4064000 EMUs - a few lines later we already limit the max height with std::min(), but in the meantime an incorrect y position is calculated, exactly due to the lack of early limited height Solve the problem by making sure composite algorithm never works with a height (even when using it to calculate vertical center) that exceeds the height of the parent. (cherry picked from commit 5b2e38e0cfc7006d6982f741cf158a8a98dc8630) This is the commit #4: oox smartart, cycle matrix: handle aspect ratio in composite algo This way the 4 quadrant shapes in the center of the SmartArt form a circle, as width is shrinking. It's not height growing, as OOXML spec clearly says "ar" always just shrinks one axis. (>1 and <1 "ar" is to be handled when they are seen in action in an actual document.) (cherry picked from commit 34383064ac061497b0c46c449313877c6b6a2087) This is the commit #5: oox smartart, cycle matrix: handle destination order in connections It is possible to have connections from multiple data nodes to the same presentation node with a presOf type. We use to order these based on as they appear in the data XML, but we need to order them according to the destOrd attribute. Introduce an std::map for that, so get ordering automatically as we iterate. Turn the std::pair into a struct to make the code a bit more readable. (cherry picked from commit ecb733da58b74714eb66d2063a2835ce5c471870) Conflicts: oox/source/drawingml/diagram/diagramlayoutatoms.cxx This is the commit #6: oox smartart, cycle matrix: fix fill and line props of shape The topmost shape may not have 0 depth, but something larger. In that case at least it's safe to still use fill & line properties. The B1 quadrant of the test file now has the proper orange background, and B2's border is also properly orange. (cherry picked from commit 8193e697d286595aa62859011761adeb002244e3) Conflicts: oox/source/drawingml/diagram/diagramlayoutatoms.cxx Change-Id: Iccc5f6993693a0f1cf8f50d163003c24d3ad690e Reviewed-on: https://gerrit.libreoffice.org/68149 Tested-by: Jenkins Reviewed-by: Andras Timar diff --git a/oox/source/drawingml/diagram/diagram.cxx b/oox/source/drawingml/diagram/diagram.cxx index 4664a55e594c..daddf1fa6991 100644 --- a/oox/source/drawingml/diagram/diagram.cxx +++
[Libreoffice-bugs] [Bug 120727] Excessive CPU usage under normal use (typing)
https://bugs.documentfoundation.org/show_bug.cgi?id=120727 rar...@pm.me changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117761] Snake Algorithm unable to display accurate layout.
https://bugs.documentfoundation.org/show_bug.cgi?id=117761 --- Comment #8 from Commit Notification --- Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/a6d9ccf26910e35f22ccec8a75472e2fa947abe1%5E%21 Related: tdf#117761 oox smartart: backport fixes related to cycle matrix It will be available in 6.2.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - oox/source sd/qa
oox/source/drawingml/diagram/diagram.cxx| 11 +- oox/source/drawingml/diagram/diagram.hxx|8 + oox/source/drawingml/diagram/diagramlayoutatoms.cxx | 71 --- oox/source/drawingml/diagram/diagramlayoutatoms.hxx |4 oox/source/drawingml/diagram/layoutnodecontext.cxx | 16 ++- sd/qa/unit/data/pptx/smartart-cycle-matrix.pptx |binary sd/qa/unit/import-tests-smartart.cxx| 93 7 files changed, 181 insertions(+), 22 deletions(-) New commits: commit a6d9ccf26910e35f22ccec8a75472e2fa947abe1 Author: Miklos Vajna AuthorDate: Thu Feb 7 16:26:31 2019 +0100 Commit: Andras Timar CommitDate: Thu Feb 21 22:32:44 2019 +0100 Related: tdf#117761 oox smartart: backport fixes related to cycle matrix This is a combination of 6 commits. This is the 1st commit: oox smartart, cycle matrix: fix counting presentation children The markup is: Where PowerPoint evaluated the condition to true, but Impress evaluated to false. This means that the undocumented relation between the child lists is "OR" (not "AND"). Also, our code assumed that "node" has to be a data node (not presentation node), but it seems the only way this condition can be true if presentation children is also counted. (The presentation node in question is not a presentation of anything.) (cherry picked from commit e3c6f249c10f7f1bcc528e643f5723288c514b29) This is the commit #2: oox smartart, cycle matrix: handle left/bottom constraint in composite algo The bugdoc has 3 shapes in the "outer" circle which have a position where either x or y is not 0. But these are defined using constraints talking about the right or bottom edge of the shape. Map that to top/left, given that we already know the shape size. (cherry picked from commit b9b4e9223b6c0d6e0b48b694c9aabbe54a250660) This is the commit #3: oox smartart, cycle matrix: fix too large height in composite algo The user-level problem was that the height of the entire smartart was too large. The reason for this was that: - composite algorithm gets the constraint height should be 77% of width, this means 6096000 -> 4693920 EMUs - at the same time the parent container is already smaller, 4064000 EMUs - a few lines later we already limit the max height with std::min(), but in the meantime an incorrect y position is calculated, exactly due to the lack of early limited height Solve the problem by making sure composite algorithm never works with a height (even when using it to calculate vertical center) that exceeds the height of the parent. (cherry picked from commit 5b2e38e0cfc7006d6982f741cf158a8a98dc8630) This is the commit #4: oox smartart, cycle matrix: handle aspect ratio in composite algo This way the 4 quadrant shapes in the center of the SmartArt form a circle, as width is shrinking. It's not height growing, as OOXML spec clearly says "ar" always just shrinks one axis. (>1 and <1 "ar" is to be handled when they are seen in action in an actual document.) (cherry picked from commit 34383064ac061497b0c46c449313877c6b6a2087) This is the commit #5: oox smartart, cycle matrix: handle destination order in connections It is possible to have connections from multiple data nodes to the same presentation node with a presOf type. We use to order these based on as they appear in the data XML, but we need to order them according to the destOrd attribute. Introduce an std::map for that, so get ordering automatically as we iterate. Turn the std::pair into a struct to make the code a bit more readable. (cherry picked from commit ecb733da58b74714eb66d2063a2835ce5c471870) Conflicts: oox/source/drawingml/diagram/diagramlayoutatoms.cxx This is the commit #6: oox smartart, cycle matrix: fix fill and line props of shape The topmost shape may not have 0 depth, but something larger. In that case at least it's safe to still use fill & line properties. The B1 quadrant of the test file now has the proper orange background, and B2's border is also properly orange. (cherry picked from commit 8193e697d286595aa62859011761adeb002244e3) Conflicts: oox/source/drawingml/diagram/diagramlayoutatoms.cxx Change-Id: Iccc5f6993693a0f1cf8f50d163003c24d3ad690e Reviewed-on: https://gerrit.libreoffice.org/68144 Tested-by: Jenkins Reviewed-by: Andras Timar diff --git a/oox/source/drawingml/diagram/diagram.cxx b/oox/source/drawingml/diagram/diagram.cxx index 64dc5dde6d91..d1de1c72f94d 100644 --- a/oox/source/drawingml/diagram/diagram.cxx +++
[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - oox/source sd/qa svx/source
oox/source/drawingml/table/tableproperties.cxx | 77 +++--
sd/qa/unit/data/pptx/tdf123090.pptx|binary
sd/qa/unit/import-tests.cxx| 31 +-
svx/source/table/cellcursor.cxx|1
svx/source/table/tablecontroller.cxx |1
5 files changed, 91 insertions(+), 19 deletions(-)
New commits:
commit 6676952d319e032a631bfe9d8ce23ebcb4c92f5b
Author: Gülşah Köse
AuthorDate: Wed Feb 20 19:06:33 2019 +0300
Commit: Andras Timar
CommitDate: Thu Feb 21 22:31:55 2019 +0100
tdf#123090 Handle removed column with gridSpan.
This is a combination of 3 commits.
(cherry picked from commit 48ef20f2039d1a300a4324072e9b712c9994b406)
(cherry picked from commit 00e89430a2f8cd1f9ec702a7583a1e4c886a2b46)
(cherry picked from commit 1f0206d940cd8f7fb627a59cfe4165c0bfebaf46)
Change-Id: Ic6fa6f335623e2114fc8bea76dc54833284d2a02
Reviewed-on: https://gerrit.libreoffice.org/68154
Tested-by: Jenkins
Reviewed-by: Andras Timar
diff --git a/oox/source/drawingml/table/tableproperties.cxx
b/oox/source/drawingml/table/tableproperties.cxx
index 5f1495166b39..128668f012c4 100644
--- a/oox/source/drawingml/table/tableproperties.cxx
+++ b/oox/source/drawingml/table/tableproperties.cxx
@@ -273,33 +273,76 @@ const TableStyle& TableProperties::getUsedTableStyle(
const ::oox::core::XmlFilt
return *pTableStyle;
}
-void TableProperties::pushToPropSet( const ::oox::core::XmlFilterBase&
rFilterBase,
-const Reference < XPropertySet >& xPropSet, const TextListStylePtr&
pMasterTextListStyle )
+void TableProperties::pushToPropSet(const ::oox::core::XmlFilterBase&
rFilterBase,
+const Reference& xPropSet,
+const TextListStylePtr&
pMasterTextListStyle)
{
-uno::Reference< XColumnRowRange > xColumnRowRange(
- xPropSet->getPropertyValue("Model"), uno::UNO_QUERY_THROW );
+uno::Reference
xColumnRowRange(xPropSet->getPropertyValue("Model"),
+uno::UNO_QUERY_THROW);
-CreateTableColumns( xColumnRowRange->getColumns(), mvTableGrid );
-CreateTableRows( xColumnRowRange->getRows(), mvTableRows );
+CreateTableColumns(xColumnRowRange->getColumns(), mvTableGrid);
+CreateTableRows(xColumnRowRange->getRows(), mvTableRows);
TableStyle* pTableStyleToDelete = nullptr;
-const TableStyle& rTableStyle( getUsedTableStyle( rFilterBase,
pTableStyleToDelete ) );
+const TableStyle& rTableStyle(getUsedTableStyle(rFilterBase,
pTableStyleToDelete));
sal_Int32 nRow = 0;
-for (auto & tableRow : mvTableRows)
+
+for (auto& tableRow : mvTableRows)
{
sal_Int32 nColumn = 0;
-for (auto & tableCell : tableRow.getTableCells())
+sal_Int32 nColumnSize = tableRow.getTableCells().size();
+sal_Int32 nRemovedColumn = 0; //
+
+for (sal_Int32 nColIndex = 0; nColIndex < nColumnSize; nColIndex++)
{
-TableCell& rTableCell(tableCell);
-if ( !rTableCell.getvMerge() && !rTableCell.gethMerge() )
+TableCell& rTableCell(tableRow.getTableCells().at(nColIndex));
+
+if (!rTableCell.getvMerge() && !rTableCell.gethMerge())
{
-uno::Reference< XTable > xTable( xColumnRowRange,
uno::UNO_QUERY_THROW );
-if ( ( rTableCell.getRowSpan() > 1 ) || (
rTableCell.getGridSpan() > 1 ) )
-MergeCells( xTable, nColumn, nRow,
rTableCell.getGridSpan(), rTableCell.getRowSpan() );
+uno::Reference xTable(xColumnRowRange,
uno::UNO_QUERY_THROW);
+bool bMerged = false;
-Reference< XCellRange > xCellRange( xTable, UNO_QUERY_THROW );
-rTableCell.pushToXCell( rFilterBase, pMasterTextListStyle,
xCellRange->getCellByPosition( nColumn, nRow ), *this, rTableStyle,
-nColumn, tableRow.getTableCells().size()-1, nRow,
mvTableRows.size()-1 );
+if ((rTableCell.getRowSpan() > 1) || (rTableCell.getGridSpan()
> 1))
+{
+MergeCells(xTable, nColumn, nRow, rTableCell.getGridSpan(),
+ rTableCell.getRowSpan());
+
+if (rTableCell.getGridSpan() > 1)
+{
+nRemovedColumn = (rTableCell.getGridSpan() - 1);
+// MergeCells removes columns. Our loop does not know
about those
+// removed columns and we skip handling those removed
columns.
+nColIndex += nRemovedColumn;
+// It will adjust new column number after push current
column's
+// props with pushToXCell.
+bMerged = true;
+}
+}
+
+Reference xCellRange(xTable, UNO_QUERY_THROW);
+
[Libreoffice-bugs] [Bug 120727] Excessive CPU usage under normal use (typing)
https://bugs.documentfoundation.org/show_bug.cgi?id=120727 --- Comment #22 from rar...@pm.me --- Hello, i had the same problem as laurens with older version of Libreoffice, i uninstalled and reinstall last version and same problem again: even only scrolling a simple document with text (and with the example of laurens as well) is a nightmare: so slow. Version: 6.2.0.3 Build ID: 98c6a8a1c6c7b144ce3cc729e34964b47ce25d62 CPU threads: 4; OS: Mac OS X 10.14.3; UI render: default; VCL: osx; Locale: fr-FR (en_FR.UTF-8); UI-Language: en-US Calc: threaded Computer: Model Name: MacBook Pro Model Identifier: MacBookPro13,1 Processor Name: Intel Core i5 Processor Speed: 2 GHz Number of Processors: 1 Total Number of Cores:2 L2 Cache (per Core): 256 KB L3 Cache: 4 MB Memory: 8 GB Boot ROM Version: 228.0.0.0.0 SMC Version (system): 2.36f97 When scrolling, MAC OS activity monitor shows at least 60% use of CPU, up to more than 100% in a few seconds of scrolling. Degrading to right click in libreoffice.app and"get info, low resolution" is better but still slow; and ugly. Thanks for help! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123564] Dialogs are not at the right position with Execute method
https://bugs.documentfoundation.org/show_bug.cgi?id=123564 raal changed: What|Removed |Added CC||r...@post.cz Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from raal --- Hello, Thank you for filing the bug. Please send us a sample document, as this makes it easier for us to verify the bug. I have set the bug's status to 'NEEDINFO', so please do change it back to 'UNCONFIRMED' once you have attached a document. (Please note that the attachment will be public, remove any sensitive information before attaching it.) How can I eliminate confidential data from a sample document? https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F Thank you -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123564] Dialogs are not at the right position with Execute method
https://bugs.documentfoundation.org/show_bug.cgi?id=123564 raal changed: What|Removed |Added Keywords||regression -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123622] FILEOPEN | DOCX, Text frame in header moves when opened in LO.
https://bugs.documentfoundation.org/show_bug.cgi?id=123622 raal changed: What|Removed |Added CC||r...@post.cz Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Version|6.2.0.0.beta1+ |4.1.0.4 release Keywords||filter:docx --- Comment #3 from raal --- Confirm with Version: 6.3.0.0.alpha0+ Build ID: 465939feb0e9c382e5581b53b72008979ece4807 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; and Version: 4.1.0.0.alpha1+ Build ID: 863d38fbfa4fb4861e476828c46410602100919 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119949] Filter broken by blank line
https://bugs.documentfoundation.org/show_bug.cgi?id=119949 Dan Dascalescu changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME |--- --- Comment #9 from Dan Dascalescu --- I've just run into this bug again. I don't know what to do. Unfortunately, raal's comments weren't helpful. Xisco, you mentioned changing the bug status to UNCONFIRMED, but I see it as "WORKSFORME". Since einsachtzehn confirmed reproduction, I hope it's OK that I reopen the bug. If not, please try to reproduce based on my original post. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123633] Web view and hide whitespace causes view position to jitter until entire document is reformatted
https://bugs.documentfoundation.org/show_bug.cgi?id=123633 --- Comment #4 from Dieter Praas --- (In reply to matt from comment #3) > Created attachment 149499 [details] > Doc that causes jitter > > The attached file causes the problem on my PC I also couldn't reproduce the bug with your document -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123633] Web view and hide whitespace causes view position to jitter until entire document is reformatted
https://bugs.documentfoundation.org/show_bug.cgi?id=123633 --- Comment #3 from m...@frosti.us --- Created attachment 149499 --> https://bugs.documentfoundation.org/attachment.cgi?id=149499=edit Doc that causes jitter The attached file causes the problem on my PC -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120748] Sidebar: Focus lost using mouse wheel in sidebar tab bar
https://bugs.documentfoundation.org/show_bug.cgi?id=120748 --- Comment #4 from Jim Raykowski --- One way to fix this would be to revert the patch that introduced scroll wheel functionality to the sidebar tab bar. commit 8c5e922d66d154405029380374f088cee6578056 Author: Bjoern Michaelsen , Wed Oct 28 01:58:43 2015 +0100 (3 years, 4 months ago) Committer: Bjoern Michaelsen , Wed Oct 28 02:11:58 2015 +0100 (3 years, 4 months ago) Follows: libreoffice-5-0-branch-point Precedes: libreoffice-5-1-branch-point Branches: handle scrollwheel events in TabBar of Sidebar - using the scrollwheel in the TabBar used to scroll the document: - even though the deck next to it handles scroll event on its own - thus there are two areas that arent even touching (separated by the deck) scrolling the same area - instead, now we capture mousewheel scrolls and switch through the decks of the sidebar. This should also severely simplify navigating them. Change-Id: Ie2136f4ec67dedf72ff6b56d16356f6a12de74ea -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123633] Web view and hide whitespace causes view position to jitter until entire document is reformatted
https://bugs.documentfoundation.org/show_bug.cgi?id=123633 --- Comment #2 from m...@frosti.us --- (In reply to Dieter Praas from comment #1) > I can't confirm this with a document of 93 pages and > > Version: 6.1.5.2 (x64) > Build-ID: 90f8dcf33c87b3705e78202e3df5142b201bd805 > CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; > Gebietsschema: de-DE (de_DE); Calc: group threaded Running on windows 10.0.17763 Document has a large number of small tables in case that is causing the problem -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123626] FILEOPEN | DOCX, Hyperlink missing from Shape in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=123626 Dieter Praas changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107733] [META] Hyperlink bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107733 Dieter Praas changed: What|Removed |Added Depends on||123626 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=123626 [Bug 123626] FILEOPEN | DOCX, Hyperlink missing from Shape in LO -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123626] FILEOPEN | DOCX, Hyperlink missing from Shape in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=123626 Dieter Praas changed: What|Removed |Added Blocks||107733 CC||dgp-m...@gmx.de --- Comment #2 from Dieter Praas --- I confirm it with Version: 6.3.0.0.alpha0+ (x64) Build ID: f42554a1886ebe49170c25096dc3281b2c7bb1f4 CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2019-02-08_22:37:30 Locale: en-US (de_DE); UI-Language: en-US Calc: threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107733 [Bug 107733] [META] Hyperlink bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123633] Web view and hide whitespace causes view position to jitter until entire document is reformatted
https://bugs.documentfoundation.org/show_bug.cgi?id=123633 Dieter Praas changed: What|Removed |Added CC||dgp-m...@gmx.de --- Comment #1 from Dieter Praas --- I can't confirm this with a document of 93 pages and Version: 6.1.5.2 (x64) Build-ID: 90f8dcf33c87b3705e78202e3df5142b201bd805 CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; Gebietsschema: de-DE (de_DE); Calc: group threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123621] FILEOPEN | DOCX, Rectangle with text moves in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=123621 raal changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||r...@post.cz Keywords||filter:docx Ever confirmed|0 |1 --- Comment #3 from raal --- Confirm with Version: 6.3.0.0.alpha0+ Build ID: 465939feb0e9c382e5581b53b72008979ece4807 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; In older versions are another problems. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123611] FILEOPEN | XLSX, Text in shape flips when opened in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=123611 raal changed: What|Removed |Added Status|UNCONFIRMED |NEW Version|6.2.0.0.beta1+ |4.1.0.4 release Ever confirmed|0 |1 Keywords||filter:xlsx CC||r...@post.cz --- Comment #3 from raal --- Confirm with Version: 6.3.0.0.alpha0+ Build ID: 465939feb0e9c382e5581b53b72008979ece4807 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; and Version: 4.1.0.0.alpha1+ Build ID: 863d38fbfa4fb4861e476828c46410602100919 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123608] FILEOPEN | XLSX, Arrows change direction when opened in Calc.
https://bugs.documentfoundation.org/show_bug.cgi?id=123608 raal changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||r...@post.cz Version|6.2.0.0.beta1+ |4.1.0.4 release Ever confirmed|0 |1 --- Comment #3 from raal --- I can confirm with Version: 4.1.0.0.alpha1+ Build ID: 863d38fbfa4fb4861e476828c46410602100919 and Version: 6.3.0.0.alpha0+ Build ID: 465939feb0e9c382e5581b53b72008979ece4807 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123609] FILEOPEN | XLSX, Arrows get vertically mirorred when opening in Calc.
https://bugs.documentfoundation.org/show_bug.cgi?id=123609 raal changed: What|Removed |Added Version|6.2.0.0.beta1+ |4.1.0.4 release CC||r...@post.cz Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from raal --- Confirm with Version: 6.3.0.0.alpha0+ Build ID: 465939feb0e9c382e5581b53b72008979ece4807 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; and Version: 4.1.0.0.alpha1+ Build ID: 863d38fbfa4fb4861e476828c46410602100919 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123596] Can't copy selection as plain text
https://bugs.documentfoundation.org/show_bug.cgi?id=123596 raal changed: What|Removed |Added CC||r...@post.cz --- Comment #2 from raal --- I cannot confirm with Version: 6.3.0.0.alpha0+ Build ID: 465939feb0e9c382e5581b53b72008979ece4807 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; and gedit. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3/gtk3gtkinst.cxx | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
New commits:
commit 35701e731728bc010b19e5ebb154c3fe6682647e
Author: Caolán McNamara
AuthorDate: Thu Feb 21 17:19:18 2019 +
Commit: Caolán McNamara
CommitDate: Thu Feb 21 21:14:45 2019 +0100
wrong "to-page" reported in split notebooks
and when switching decks we need that notification to occur too
Change-Id: Ica3c83ad34e072faf044c6d4667f34756688de09
Reviewed-on: https://gerrit.libreoffice.org/68171
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index b0c0e13b5e7e..7910ae85948c 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -3183,6 +3183,13 @@ private:
void signal_switch_page(int nNewPage)
{
+if (m_bOverFlowBoxIsStart)
+{
+auto nOverFlowLen = m_bOverFlowBoxActive ?
gtk_notebook_get_n_pages(m_pOverFlowNotebook) - 1 : 0;
+// add count of overflow pages, minus the extra tab
+nNewPage += nOverFlowLen;
+}
+
bool bAllow = !m_aLeavePageHdl.IsSet() ||
m_aLeavePageHdl.Call(get_current_page_ident());
if (!bAllow)
{
@@ -3246,9 +3253,11 @@ private:
std::swap(m_nStartTabCount, m_nEndTabCount);
split_notebooks();
-gtk_notebook_set_current_page(m_pNotebook, nNewPage);
-
enable_notify_events();
+
+// we want to call this outside enable_notify_events so that the main
+// notebook switch-page callback is triggered
+gtk_notebook_set_current_page(m_pNotebook, nNewPage);
}
static OString get_page_ident(GtkNotebook *pNotebook, guint nPage)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 123636] FILEOPEN DOCX with frame content on multiple pages is condensed to single page
https://bugs.documentfoundation.org/show_bug.cgi?id=123636 raal changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 CC||r...@post.cz --- Comment #3 from raal --- Confirm with Version: 6.3.0.0.alpha0+ Build ID: 465939feb0e9c382e5581b53b72008979ece4807 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/source vcl/unx
cui/source/tabpages/numfmt.cxx |2 +-
vcl/unx/gtk3/gtk3gtkinst.cxx | 23 +--
2 files changed, 18 insertions(+), 7 deletions(-)
New commits:
commit 7bc3ac14a88206ed3cafa123e92877e0a47cfb15
Author: Caolán McNamara
AuthorDate: Thu Feb 21 15:57:22 2019 +
Commit: Caolán McNamara
CommitDate: Thu Feb 21 20:48:50 2019 +0100
menu of currency combobox in format-cells is too narrow
we want the combobox to be narrower than it wants to be. To make that
happen
we have only the option of shrinking the cell renderer of the combobox area.
And that is also used by the menu.
Setting a small value of e.g. 1 works to let the combobox not request more
width than that, and the combobox will correctly render within the wider
size
it actually gets. But then the menu is a min width menu, which is
undesirable,
we want the menu to be as wide as it can be.
So calculate what part of the combobox belongs to the cell area and set
the widest cell area we can within the overall combobox width, resulting
in the widest menu we can get.
Change-Id: Ie3e9960a320a70471ac21d2a88f32632cafa951f
Reviewed-on: https://gerrit.libreoffice.org/68167
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/cui/source/tabpages/numfmt.cxx b/cui/source/tabpages/numfmt.cxx
index c0e66b6ceb05..e51de20a02cb 100644
--- a/cui/source/tabpages/numfmt.cxx
+++ b/cui/source/tabpages/numfmt.cxx
@@ -234,7 +234,7 @@
SvxNumberFormatTabPage::SvxNumberFormatTabPage(TabPageParent pParent,
auto nWidth = approximate_char_width() * 26;
m_xLbCategory->set_size_request(nWidth, m_xLbCategory->get_height_rows(7));
m_xLbFormat->set_size_request(nWidth, m_xLbFormat->get_height_rows(5));
-m_xLbCurrency->set_size_request(1, -1); // width of 1, so real width will
be that of its LbFormat sibling
+m_xLbCurrency->set_size_request(nWidth, -1); // width of 1, so real width
will be that of its LbFormat sibling
// Initially remove the "Automatically" entry.
m_xLbCurrency->set_active(-1); // First ensure that nothing is selected.
diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index cd00ff5a9e8c..b0c0e13b5e7e 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -7531,20 +7531,31 @@ public:
// tweak the cell render to get a narrower size to stick
GList* cells = gtk_cell_layout_get_cells(GTK_CELL_LAYOUT(m_pComboBox));
GtkCellRenderer* cell = static_cast(cells->data);
-GtkRequisition size;
-gtk_cell_renderer_get_preferred_size(cell, m_pWidget, , nullptr);
-if (nWidth < size.width)
+
+if (nWidth != -1)
{
// this bit isn't great, I really want to be able to ellipse the
text in the comboboxtext itself and let
-// the popup menu render them in full, in the interim ellipse both
+// the popup menu render them in full, in the interim ellipse both
of them
g_object_set(G_OBJECT(m_pTextRenderer), "ellipsize",
PANGO_ELLIPSIZE_MIDDLE, nullptr);
-gtk_cell_renderer_set_fixed_size(cell, nWidth, size.height);
+
+// to find out how much of the width of the combobox belongs to
the cell, set
+// the cell and widget to the min cell width and see what the
difference is
+int min;
+gtk_cell_renderer_get_preferred_width(cell, m_pWidget, ,
nullptr);
+gtk_cell_renderer_set_fixed_size(cell, min, -1);
+gtk_widget_set_size_request(m_pWidget, min, -1);
+int nNonCellWidth = get_preferred_size().Width() - min;
+
+// now set the cell to the max width which it can be within the
+// requested widget width
+gtk_cell_renderer_set_fixed_size(cell, nWidth - nNonCellWidth, -1);
}
else
{
g_object_set(G_OBJECT(m_pTextRenderer), "ellipsize",
PANGO_ELLIPSIZE_NONE, nullptr);
-gtk_cell_renderer_set_fixed_size(cell, -1, size.height);
+gtk_cell_renderer_set_fixed_size(cell, -1, -1);
}
+
g_list_free(cells);
gtk_widget_set_size_request(m_pWidget, nWidth, nHeight);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: cui/uiconfig
cui/uiconfig/ui/eventassignpage.ui |1 + 1 file changed, 1 insertion(+) New commits: commit e0a8803fa3b053eeccb226fc69d5005e63d00c99 Author: Caolán McNamara AuthorDate: Thu Feb 21 16:31:49 2019 + Commit: Caolán McNamara CommitDate: Thu Feb 21 20:47:42 2019 +0100 missing standard border-width Change-Id: I4aa1fd132e3d6e153bdc03a51bf81469301eb1fb Reviewed-on: https://gerrit.libreoffice.org/68169 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/cui/uiconfig/ui/eventassignpage.ui b/cui/uiconfig/ui/eventassignpage.ui index d8d2034261db..f61020d121e2 100644 --- a/cui/uiconfig/ui/eventassignpage.ui +++ b/cui/uiconfig/ui/eventassignpage.ui @@ -37,6 +37,7 @@ False True True +6 12 12 True ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 123636] FILEOPEN DOCX with frame content on multiple pages is condensed to single page
https://bugs.documentfoundation.org/show_bug.cgi?id=123636 --- Comment #2 from Aron Budea --- Created attachment 149498 --> https://bugs.documentfoundation.org/attachment.cgi?id=149498=edit Sample DOC (opens fine) The DOC saved from the DOCX in Word opens fine in Writer. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123636] FILEOPEN DOCX with frame content on multiple pages is condensed to single page
https://bugs.documentfoundation.org/show_bug.cgi?id=123636 --- Comment #1 from Aron Budea --- Created attachment 149497 --> https://bugs.documentfoundation.org/attachment.cgi?id=149497=edit Comparison screenshot -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: tdf#121845 rework custom shape path command U and T
Hi Miklos, hi Thorsten,
Miklos Vajna schrieb am 21-Feb-19 um 13:46:
Hi Regina,
On Tue, Feb 19, 2019 at 08:58:56PM +0100, Regina Henschel
wrote:
(1) My opinion, how the commands U and T should work, see comments in
https://bugs.documentfoundation.org/show_bug.cgi?id=121845.
The description in the ODF 1.2 spec seems to be a copy of the VML spec
proposal and is not clear.
Seeing that noone replied so far, just some thoughts...
Another source of information might be the drawingML spec, which is
supposed to be able to describe all features VML has. But the first is
part of OOXML strict, so possibly it has a bit better description.
OOXML has the command arcTo. It is not compatible to ODF commands U and
T. That is the reason, why we have introduced a new ODF command G
(=ARCANGLETO), which is currently in drawooo namespace, but will
hopefully be in ODF 1.4.
The implementation in MS Office is surely wrong,
because it sets 0 degree in up-direction.
You mean the ODF filter of MS Office?
Yes, I mean MS Office import filter for ODF.
MS Office avoids command U and T on export to ODF, but use cubic Bézier
curves. It avoids the OOXML command 'arcTo' too, when converting from
"Word 2003 XML". In compatible docx format, it writes only VML, and in
strict docx format, it uses alternative content with one case VML and
the other case OOXML command 'cubicBezTo'.
(2) I have made the case distinction on the draw:type attribute.
I'm not sure, that this is the correct way to go. A different way would be
to add an internal property to shapes, which filter was used on opening.
However that would touch much more parts and might be beyond my skills.
Storing the filter name is not great -- I think loading from MSO formats
and saving as ODF is a frequent use-case. If saving as ODF and reloading
changes how the commands are interpreted, that's problematic.
I see no way to write that, what is possible in VML, with the commands,
that are available in ODF 1.2. The problem is, that the swing angle can
produce several turns.
And handles, equations and modifiers need to be converted too for a true
conversion. Path and equations do not change for static shapes. Export
to ODF will keep the MS-kind values and the draw:type, so that reloading
from ODF goes to the same case as reading the original doc-format.
I have no solution for dynamic shapes, those can be changed by handles.
The handle problem would still exist, if we switched to the new ARCANGLETO.
The original comment in the source was:
// SJ: if the angle was imported from our escher import, then the
// value is shifted by 16. TODO: already change the fixed float to a
// double in the import filter.
The real challenge, however, is not converting the angles in the path,
but adjusting the equations and modifiers and handles.
The current implementation for shapes in OOXML also avoids doing a full
conversions during import. The angle conversion is in
EnhancedCustomShape2d.cxx. I have not yet tested user defined shapes
with handles for that file format. I only have seen, that the problem of
large swing angles is not solved.
From Thorsten from Gerrit:
Line 1595:
That seems a tad brittle? If indeed there's no way to fix that on import, I'd
much prefer a separate, explicit marker property on the SvxShape, that the
import sets.
Thorsten, I have no idea, where to set it.
Are you afraid that the test 'startsWith("mso") will catch wrong shapes?
BTW, I have only doc-documents with non-preset shapes. Does someone else
has ppt or xls documents, which have non-preset shapes, that lead to
ANGLEELLIPSE on import?
Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 104461] [META] DOCX (OOXML) frame-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104461 Aron Budea changed: What|Removed |Added Depends on||123636 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=123636 [Bug 123636] FILEOPEN DOCX with frame content on multiple pages is condensed to single page -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123636] New: FILEOPEN DOCX with frame content on multiple pages is condensed to single page
https://bugs.documentfoundation.org/show_bug.cgi?id=123636 Bug ID: 123636 Summary: FILEOPEN DOCX with frame content on multiple pages is condensed to single page Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Keywords: filter:docx Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ba...@caesar.elte.hu Blocks: 104461 Created attachment 149496 --> https://bugs.documentfoundation.org/attachment.cgi?id=149496=edit Sample DOCX The attached document was created in an external document producer, and minimized in Word. When opened in Word, the document appears as two pages, interestingly text can only be added to the text frames. When opened in Writer, the frames are all on the same page. Observed using LO 6.3.0.0.alpha0+ (e0745a11597e5d57eb8001a295314e86810a6027), 3.3.0 / Windows 7. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104461 [Bug 104461] [META] DOCX (OOXML) frame-related issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42082] [META] Make LibreOffice shine and glow on OS X
https://bugs.documentfoundation.org/show_bug.cgi?id=42082 Sierk Bornemann changed: What|Removed |Added Depends on||67465 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=67465 [Bug 67465] EPS rendering: locating pstoedit on Mac a problem -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67465] EPS rendering: locating pstoedit on Mac a problem
https://bugs.documentfoundation.org/show_bug.cgi?id=67465 Sierk Bornemann changed: What|Removed |Added Blocks||42082 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=42082 [Bug 42082] [META] Make LibreOffice shine and glow on OS X -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103674] Libreoffice fails to export or print an embedded EPS Image
https://bugs.documentfoundation.org/show_bug.cgi?id=103674 Sierk Bornemann changed: What|Removed |Added Blocks||42082 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=42082 [Bug 42082] [META] Make LibreOffice shine and glow on OS X -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42082] [META] Make LibreOffice shine and glow on OS X
https://bugs.documentfoundation.org/show_bug.cgi?id=42082 Sierk Bornemann changed: What|Removed |Added Depends on||103674 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103674 [Bug 103674] Libreoffice fails to export or print an embedded EPS Image -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sd/source
sd/source/ui/animations/CustomAnimationList.cxx | 67
sd/source/ui/animations/CustomAnimationList.hxx |3 +
2 files changed, 70 insertions(+)
New commits:
commit d3fdd9f12ba698008515bfdc47c5f96318406d7f
Author: Brian Fraser
AuthorDate: Sun Feb 17 22:55:57 2019 -0800
Commit: Jim Raykowski
CommitDate: Thu Feb 21 19:59:46 2019 +0100
tdf#123534 Impress collapse/expand animation maintains selection
- Expandened a selected bulleted list's animations now
selects children (maintaining the selection behaviour).
- Collapsing a bulleted list's animation no longer
clears the current selections
- Deselecting animations now refreshed the UI correctly
Change-Id: I3a3ca0eb0efe841784d96d5dc8e1b760dea4f777
Reviewed-on: https://gerrit.libreoffice.org/67947
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
diff --git a/sd/source/ui/animations/CustomAnimationList.cxx
b/sd/source/ui/animations/CustomAnimationList.cxx
index 7e3107b80baa..d3f88d483f1d 100644
--- a/sd/source/ui/animations/CustomAnimationList.cxx
+++ b/sd/source/ui/animations/CustomAnimationList.cxx
@@ -1108,6 +1108,7 @@ void CustomAnimationList::onSelectionChanged(const Any&
rSelection)
}
}
+// Notify controller to refresh UI when we are notified of selection change
from base class
void CustomAnimationList::SelectHdl()
{
if( mbIgnorePaint )
@@ -1116,6 +1117,72 @@ void CustomAnimationList::SelectHdl()
mpController->onSelect();
}
+// Notify controller to refresh UI when we are notified of selection change
from base class
+void CustomAnimationList::DeselectHdl()
+{
+if( mbIgnorePaint )
+return;
+SvTreeListBox::DeselectHdl();
+mpController->onSelect();
+}
+
+
+bool CustomAnimationList::Expand( SvTreeListEntry* pParent )
+{
+bool result = SvTreeListBox::Expand( pParent );
+
+// If expanded entry is selected, then select its children too.
+if( IsSelected( pParent )) {
+for( auto pChild = FirstChild( pParent ); pChild; pChild =
pChild->NextSibling() )
+{
+if( !IsSelected( pChild ) )
+{
+SelectListEntry( pChild, true );
+}
+}
+}
+
+// Notify controller that selection has changed (it should update the UI)
+mpController->onSelect();
+
+return result;
+}
+
+bool CustomAnimationList::Collapse( SvTreeListEntry* pParent )
+{
+// SvTreeListBox::Collapse(..) discards multi-selection state
+// of list entries, so first save current selection state
+std::vector< SvTreeListEntry* > selectedEntries;
+for( auto pEntry = FirstSelected(); pEntry; pEntry = NextSelected( pEntry
))
+{
+selectedEntries.push_back( pEntry );
+}
+
+// Execute collapse on base class
+bool result = SvTreeListBox::Collapse( pParent );
+
+// Deselect all entries as SvTreeListBox::Collapse selects the last
+// entry to have focus (or its parent), which is not desired
+for( auto pEntry = FirstSelected(); pEntry; pEntry = NextSelected( pEntry
))
+{
+SelectListEntry( pEntry, false );
+}
+
+// Restore selection state for entries which are still visible
+for( auto : selectedEntries )
+{
+if( IsEntryVisible( pEntry ))
+{
+SelectListEntry( pEntry, true );
+}
+}
+
+// Notify controller that selection has changed (it should update the UI)
+mpController->onSelect();
+
+return result;
+}
+
bool CustomAnimationList::isExpanded( const CustomAnimationEffectPtr& pEffect
) const
{
CustomAnimationListEntry* pEntry =
static_cast(First());
diff --git a/sd/source/ui/animations/CustomAnimationList.hxx
b/sd/source/ui/animations/CustomAnimationList.hxx
index 8e322f885db1..25976bc0e437 100644
--- a/sd/source/ui/animations/CustomAnimationList.hxx
+++ b/sd/source/ui/animations/CustomAnimationList.hxx
@@ -72,6 +72,7 @@ public:
// overrides
virtual voidSelectHdl() override;
+virtual voidDeselectHdl() override;
virtual boolDoubleClickHdl() override;
virtual voidPaint( vcl::RenderContext& rRenderContext, const
::tools::Rectangle& rRect ) override;
@@ -83,6 +84,8 @@ public:
virtual void notify_change() override;
+virtual bool Expand( SvTreeListEntry* pParent ) override;
+virtual bool Collapse( SvTreeListEntry* pParent ) override;
bool isExpanded( const CustomAnimationEffectPtr& pEffect ) const;
bool isVisible( const CustomAnimationEffectPtr& pEffect ) const;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: solenv/bin xmloff/inc xmloff/source xmloff/util
solenv/bin/native-code.py |1 +
xmloff/inc/facreg.hxx |5 -
xmloff/source/core/facreg.cxx |1 -
xmloff/source/draw/sdxmlexp.cxx | 11 ++-
xmloff/util/xo.component|3 ++-
5 files changed, 13 insertions(+), 8 deletions(-)
New commits:
commit 50a73ae6ea3dca335df98b217982d8fe4d0d7a6c
Author: Miklos Vajna
AuthorDate: Thu Feb 21 16:41:33 2019 +0100
Commit: Miklos Vajna
CommitDate: Thu Feb 21 19:42:04 2019 +0100
xmloff: create XMLImpressContentExportOasis instances with an uno
constructor
Change-Id: I75301ca29794dd42a966faa36add3078c8c55211
Reviewed-on: https://gerrit.libreoffice.org/68166
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/solenv/bin/native-code.py b/solenv/bin/native-code.py
index 2b887fd20976..5887c0b3a5ce 100755
--- a/solenv/bin/native-code.py
+++ b/solenv/bin/native-code.py
@@ -255,6 +255,7 @@ core_constructor_list = [
"com_sun_star_comp_Impress_XMLOasisImporter_get_implementation",
"com_sun_star_comp_Impress_XMLOasisExporter_get_implementation",
"com_sun_star_comp_Impress_XMLOasisStylesExporter_get_implementation",
+"com_sun_star_comp_Impress_XMLOasisContentExporter_get_implementation",
# xmlscript/util/xmlscript.component
"com_sun_star_comp_xmlscript_XMLBasicExporter",
"com_sun_star_comp_xmlscript_XMLBasicImporter",
diff --git a/xmloff/inc/facreg.hxx b/xmloff/inc/facreg.hxx
index 07655681c146..60c49bfb3c75 100644
--- a/xmloff/inc/facreg.hxx
+++ b/xmloff/inc/facreg.hxx
@@ -56,11 +56,6 @@ css::uno::Reference
XMLImpressSettingsImportOasis_createIn
css::uno::Reference const & rSMgr);
// impress oasis export
-OUString XMLImpressContentExportOasis_getImplementationName() throw();
-css::uno::Sequence
XMLImpressContentExportOasis_getSupportedServiceNames() throw();
-/// @throws css::uno::Exception
-css::uno::Reference
XMLImpressContentExportOasis_createInstance(
-css::uno::Reference const & rSMgr);
OUString XMLImpressMetaExportOasis_getImplementationName() throw();
css::uno::Sequence
XMLImpressMetaExportOasis_getSupportedServiceNames() throw();
/// @throws css::uno::Exception
diff --git a/xmloff/source/core/facreg.cxx b/xmloff/source/core/facreg.cxx
index 6488cd7f456e..1a8e929e835b 100644
--- a/xmloff/source/core/facreg.cxx
+++ b/xmloff/source/core/facreg.cxx
@@ -63,7 +63,6 @@ XMLOFF_DLLPUBLIC void * xo_component_getFactory( const
sal_Char * pImplName, voi
else SINGLEFACTORY( XMLImpressSettingsImportOasis )
// impress oasis export
-else SINGLEFACTORY( XMLImpressContentExportOasis )
else SINGLEFACTORY( XMLImpressMetaExportOasis )
else SINGLEFACTORY( XMLImpressSettingsExportOasis )
diff --git a/xmloff/source/draw/sdxmlexp.cxx b/xmloff/source/draw/sdxmlexp.cxx
index f6f6640ae166..afd398a0eda5 100644
--- a/xmloff/source/draw/sdxmlexp.cxx
+++ b/xmloff/source/draw/sdxmlexp.cxx
@@ -2672,7 +2672,16 @@
com_sun_star_comp_Impress_XMLOasisStylesExporter_get_implementation(
| SvXMLExportFlags::AUTOSTYLES | SvXMLExportFlags::FONTDECLS));
}
-SERVICE( XMLImpressContentExportOasis,
"com.sun.star.comp.Impress.XMLOasisContentExporter",
"XMLImpressContentExportOasis", false,
SvXMLExportFlags::OASIS|SvXMLExportFlags::AUTOSTYLES|SvXMLExportFlags::CONTENT|SvXMLExportFlags::SCRIPTS|SvXMLExportFlags::FONTDECLS
);
+extern "C" SAL_DLLPUBLIC_EXPORT uno::XInterface*
+com_sun_star_comp_Impress_XMLOasisContentExporter_get_implementation(
+uno::XComponentContext* pCtx, uno::Sequence const& /*rSeq*/)
+{
+return cppu::acquire(new SdXMLExport(pCtx, "XMLImpressContentExportOasis",
false,
+ SvXMLExportFlags::OASIS |
SvXMLExportFlags::AUTOSTYLES
+ | SvXMLExportFlags::CONTENT |
SvXMLExportFlags::SCRIPTS
+ | SvXMLExportFlags::FONTDECLS));
+}
+
SERVICE( XMLImpressMetaExportOasis,
"com.sun.star.comp.Impress.XMLOasisMetaExporter", "XMLImpressMetaExportOasis",
false, SvXMLExportFlags::OASIS|SvXMLExportFlags::META );
SERVICE( XMLImpressSettingsExportOasis,
"com.sun.star.comp.Impress.XMLOasisSettingsExporter",
"XMLImpressSettingsExportOasis", false,
SvXMLExportFlags::OASIS|SvXMLExportFlags::SETTINGS );
diff --git a/xmloff/util/xo.component b/xmloff/util/xo.component
index db037edd20a7..ec69df766a2d 100644
--- a/xmloff/util/xo.component
+++ b/xmloff/util/xo.component
@@ -94,7 +94,8 @@
-
+
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 123625] getattr fails with \..
https://bugs.documentfoundation.org/show_bug.cgi?id=123625 Oliver Brinzing changed: What|Removed |Added Version|6.1.3.2 release |Inherited From OOo Status|UNCONFIRMED |NEW Ever confirmed|0 |1 CC||oliver.brinz...@gmx.de --- Comment #1 from Oliver Brinzing --- attached macro will fail with AOO 4.1.5 too, so it never worked at all. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123604] How to fix QuickBooks error 6000?
https://bugs.documentfoundation.org/show_bug.cgi?id=123604 Oliver Brinzing changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID URL|https://www.customercarenum | |ber-usa.com/quickbooks-supp | |ort-number/ | CC||oliver.brinz...@gmx.de -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] help.git: Branch 'libreoffice-6-2' - help3xsl/index2.html source/text
help3xsl/index2.html|4
source/text/shared/main0108.xhp |3 +--
2 files changed, 5 insertions(+), 2 deletions(-)
New commits:
commit 7f8f2aefb437aa6c08c597cb2ea99cd1b67696e9
Author: Olivier Hallot
AuthorDate: Wed Feb 20 11:52:46 2019 -0300
Commit: Adolfo Jayme Barrientos
CommitDate: Thu Feb 21 18:57:56 2019 +0100
Fix call of main Help page from app Help menu
The Application Help menu sends //.uno:HelpIndex in the Help
URL.
This translates to '.uno:HelpIndex' and module name is lost, opening the
New Help default page instead of the module Help entry page.
The patch picks the right module Help entry page in this particular
case.
Change-Id: Ifbb5ba4f817b195210fbb19bcb5c2011d2cb416d
Reviewed-on: https://gerrit.libreoffice.org/68103
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/help3xsl/index2.html b/help3xsl/index2.html
index 01bfb442f..0321b7a39 100644
--- a/help3xsl/index2.html
+++ b/help3xsl/index2.html
@@ -37,6 +37,10 @@
case "sbasic":
{defaultFile='text/sbasic/shared/main0601.html';module="BASIC";break;}
default:
{defaultFile='text/shared/05/new_help.html';module="WRITER";break;}
}
+//Special case of application F1 or menu Help -> LibreOffice Help
+if (target.indexOf('.uno:HelpIndex') != -1) {
+window.location.href = lang + '/' + defaultFile + '?System=' + system
+ '=' + module;
+}
var bookmark = target.slice(target.indexOf('/') + 1, target.length);
var file = hid2fileMap[bookmark];
// check first if a root bookmark @@nowidget@@ can be used
diff --git a/source/text/shared/main0108.xhp b/source/text/shared/main0108.xhp
index 9f0932ff6..e8f8d4d60 100644
--- a/source/text/shared/main0108.xhp
+++ b/source/text/shared/main0108.xhp
@@ -39,7 +39,6 @@
-
$[officename] Help
Opens the main page of the $[officename] Help for the
current application. You can scroll through the Help pages and you can
search for index terms or any text.
@@ -105,4 +104,4 @@
-
\ No newline at end of file
+
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 90069045f4bab7b4dc8701533fdbf5d53c71d4ae Author: Olivier Hallot AuthorDate: Wed Feb 20 11:52:46 2019 -0300 Commit: Gerrit Code Review CommitDate: Thu Feb 21 18:57:56 2019 +0100 Update git submodules * Update helpcontent2 from branch 'libreoffice-6-2' - Fix call of main Help page from app Help menu The Application Help menu sends //.uno:HelpIndex in the Help URL. This translates to '.uno:HelpIndex' and module name is lost, opening the New Help default page instead of the module Help entry page. The patch picks the right module Help entry page in this particular case. Change-Id: Ifbb5ba4f817b195210fbb19bcb5c2011d2cb416d Reviewed-on: https://gerrit.libreoffice.org/68103 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/helpcontent2 b/helpcontent2 index 9af370151723..7f8f2aefb437 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 9af370151723302e5df5e413604351ade70a40a9 +Subproject commit 7f8f2aefb437aa6c08c597cb2ea99cd1b67696e9 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 123598] Autofilter removed from output range after save & reload
https://bugs.documentfoundation.org/show_bug.cgi?id=123598 --- Comment #5 from Oliver Brinzing --- checked with Version: 6.2.1.1 (x64) Build-ID: 757c58e8cb70b2982843211a54750fb3cd79acd5 CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; VCL: win; Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE Calc: same result: autofilter icons are lost on save & reload from sheet "Result" -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123598] Autofilter removed from output range after save & reload
https://bugs.documentfoundation.org/show_bug.cgi?id=123598 Oliver Brinzing changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 CC||oliver.brinz...@gmx.de --- Comment #3 from Oliver Brinzing --- (In reply to Roman Kuznetsov from comment #2) > Olivier, what varsion of LO and what OS do you use? lo version is: Version: 6.1.5.2 (x64) Build ID: 90f8dcf33c87b3705e78202e3df5142b201bd805 CPU threads: 4; OS: Windows 10.0; UI render: default; Locale: de-DE (de_DE); Calc: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123598] Autofilter removed from output range after save & reload
https://bugs.documentfoundation.org/show_bug.cgi?id=123598 --- Comment #4 from Oliver Brinzing --- Created attachment 149495 --> https://bugs.documentfoundation.org/attachment.cgi?id=149495=edit filter result after save and reload attached pdf shows, the autofilter icons are lost on save and reload from sheet "Result" -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123635] New: Changing the default font size only affects certain symbols/expressions
https://bugs.documentfoundation.org/show_bug.cgi?id=123635
Bug ID: 123635
Summary: Changing the default font size only affects certain
symbols/expressions
Product: LibreOffice
Version: 6.1.5.2 release
Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
Severity: minor
Priority: medium
Component: Formula Editor
Assignee: libreoffice-bugs@lists.freedesktop.org
Reporter: k-ri...@comcast.net
Description:
If you change the default font size for the Formula editor, certain
mathematical symbols and expressions are not initially affected by the change.
Steps to Reproduce:
1. Open Writer
2. On the menu bar, click Insert, Object, Formula...
3. On the Formula Editor menu bar, click Format, Font Size...
4. Change the font base size to a non-default value (not 12). Setting it to a
very large value, such as 80, demonstrates this bug more clearly.
5. Click the "default" button and click "yes".
6. Click "Ok"
7. Exit Writer, do not save the document.
8. Open Writer again
9. On the menu bar, click Insert, Object, Formula...
10. Type "sum a" without the quotes. If you had set the font base size to a
relatively large value, you should clearly see that the summation symbol is
much smaller than it should be. It appears to be the original default size of
12. The "a" character is the correct size, though.
11. Click on the white page in the Formula editor to exit back into Writer.
12. Save the document as an .odt file.
13. Exit Writer.
14. Open Writer again and open the saved document.
15. Double click on the "sum a" Formula object, thereby entering into the
Formula editor.
16. Observe that the size of the summation symbol has been automatically
corrected.
Try repeating the above steps, but instead of typing "sum a" in step 10, type
in the following: left[ matrix{ a#b ## c#d } right]
The vertical size of the matrix appears to be correct, but the horizontal size
is wrong. The matrix is too narrow. If you go all the way through to step 16,
you will see that the matrix's size will widen to the correct amount.
Actual Results:
Expected Results:
Reproducible: Always
User Profile Reset: Yes
OpenGL enabled: Yes
Additional Info:
Version: 6.1.5.2 (x64)
Build ID: 90f8dcf33c87b3705e78202e3df5142b201bd805
CPU threads: 2; OS: Windows 10.0; UI render: GL;
Locale: en-US (en_US); Calc: group threaded
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123634] New: Calc does not adjust columns correctly when they are frozen
https://bugs.documentfoundation.org/show_bug.cgi?id=123634 Bug ID: 123634 Summary: Calc does not adjust columns correctly when they are frozen Product: LibreOffice Version: 6.2.0.3 release Hardware: x86-64 (AMD64) OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: hunta...@gmail.com Description: When inserting a new column within a frozen area, an originally frozen column is pushed out of the range and is no longer frozen. Steps to Reproduce: 1. Create a new spreadsheet in Calc. 2. Add text to at least 5 or 6 columns in row 1. 3. Right click on column D and freeze the columns (This has frozen columns: A, B, C.) 4. Now right click on column C and select "Insert columns before" Actual Results: This will push the columns over, and columns A,B,C are still frozen but the old column C that is now D, is outside of the frozen area. Expected Results: The expectation is that the frozen column would be moved over so that A,B,C,D would be frozen. Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'aoo/trunk' - Repository.mk solenv/gbuild
Repository.mk|1 + solenv/gbuild/TargetLocations.mk |2 ++ solenv/gbuild/platform/macosx.mk |2 +- 3 files changed, 4 insertions(+), 1 deletion(-) New commits: commit dd9b9e930a7d58bc4a472fb683edbf938772f110 Author: Jim Jagielski AuthorDate: Thu Feb 21 16:34:19 2019 + Commit: Jim Jagielski CommitDate: Thu Feb 21 16:34:19 2019 + Get ObjC files to build and link diff --git a/Repository.mk b/Repository.mk index 3a33d0f9f112..f379061a6b43 100644 --- a/Repository.mk +++ b/Repository.mk @@ -80,6 +80,7 @@ $(eval $(call gb_Helper_register_libraries,OOOLIBS, \ agg \ analysis \ animcore \ +apple_remote \ avmedia \ avmediagst \ avmediaMacAVF \ diff --git a/solenv/gbuild/TargetLocations.mk b/solenv/gbuild/TargetLocations.mk index 8e9fef96e70e..34ef104229d9 100644 --- a/solenv/gbuild/TargetLocations.mk +++ b/solenv/gbuild/TargetLocations.mk @@ -83,6 +83,7 @@ gb_Module_get_subsequentcheck_target = $(WORKDIR)/Module/subsequentcheck/$(1) gb_Module_get_target = $(WORKDIR)/Module/$(1) gb_NoexPrecompiledHeader_get_dep_target = $(WORKDIR)/Dep/NoexPrecompiledHeader/$(gb_NoexPrecompiledHeader_DEBUGDIR)/$(1).hxx.pch.d gb_NoexPrecompiledHeader_get_target = $(WORKDIR)/NoexPrecompiledHeader/$(gb_NoexPrecompiledHeader_DEBUGDIR)/$(1).hxx.pch +gb_ObjCObject_get_target = $(WORKDIR)/ObjCObject/$(1).o gb_ObjCxxObject_get_target = $(WORKDIR)/ObjCxxObject/$(1).o gb_Package_get_preparation_target = $(WORKDIR)/Package/prepared/$(1) gb_Package_get_target = $(WORKDIR)/Package/$(1) @@ -147,6 +148,7 @@ $(eval $(call gb_Helper_make_outdir_clean_targets,\ $(eval $(call gb_Helper_make_dep_targets,\ CObject \ CxxObject \ + ObjCObject \ ObjCxxObject \ GenCObject \ GenCxxObject \ diff --git a/solenv/gbuild/platform/macosx.mk b/solenv/gbuild/platform/macosx.mk index d859e3a78f58..7ea8c7a7f1b6 100644 --- a/solenv/gbuild/platform/macosx.mk +++ b/solenv/gbuild/platform/macosx.mk @@ -235,7 +235,7 @@ endef # ObjCObject class define gb_ObjCObject__command -$(call gb_Output_announce,$(2),$(true),OC ,3) +$(call gb_Output_announce,$(2),$(true),OC,3) $(call gb_Helper_abbreviate_dirs,\ mkdir -p $(dir $(1)) $(dir $(4)) && \ $(gb_CC) \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
