[Libreoffice-bugs] [Bug 125307] PyUno wrongly converts Tuples of Strings

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125307

--- Comment #3 from Thomas Viehmann  ---
Thanks Oliver! Those are great resources! (And I do sometimes look at the
grammalecte plugin for inspiration of how PyUNO works, too)

So slide 18 (Elimination of explicit Any) is very close to my case. The
implicit conversion to any here would be not to "string[]" as I would expect
from the example, but to any[].

Maybe you or Matthew have an opinion on whether that's intentional or maybe
less so?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125348] autocorrect replacement table default width is increased by long autocorrect entries and you can't resize it

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125348

tommy27  changed:

   What|Removed |Added

   Keywords||regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103341

tommy27  changed:

   What|Removed |Added

 Depends on||125348


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=125348
[Bug 125348] autocorrect replacement table default width is increased by long
autocorrect entries and you can't resize it
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125348] autocorrect replacement table default width is increased by long autocorrect entries and you can't resize it

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125348

tommy27  changed:

   What|Removed |Added

 Blocks||103341
 CC||ba...@quipo.it,
   ||caol...@redhat.com


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103341
[Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125348] New: autocorrect replacement table default width is increased by long autocorrect entries and you can't resize it

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125348

Bug ID: 125348
   Summary: autocorrect replacement table default width is
increased by long autocorrect entries and you can't
resize it
   Product: LibreOffice
   Version: 6.2.4.1 rc
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ba...@quipo.it

Created attachment 151493
  --> https://bugs.documentfoundation.org/attachment.cgi?id=151493=edit
screenshot of an extremely enlarged replacement table width

this is a regression I've noticed in latest LibO 6.2.5.0.0+ (x64) but I suspect
it affect the whole 6.2.x branch.

apparently the default width of the autocorrect replacement table
(Tools/Autocorrect/Autocorrect options...) is permanently increased by the
presence of long autocorrect entries.

try to load the table with default entries and see it's width.
now enter and save a very long entry (you may use dummy text like
qwertyuiopèasdfghjklzxcvbnmqwertyuiopasdfghjklzxcvbnm) and the reload it.

you will see that the default width of the table is dramatically enlarged (see
my screenshot as well) and you cannot shrink it...

resize only works for the table's height but not for width.

the table keeps it's regular width in LibO 6.1.x despite the lenght of the
longest autocorrect entry.

please fix it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103341
Bug 103341 depends on bug 125241, which changed state.

Bug 125241 Summary: Loading a large autocorrect replacement table causes 
freezing in 6.2.x
https://bugs.documentfoundation.org/show_bug.cgi?id=125241

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=109158

tommy27  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||5241

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125093] Windows: Honor "Zone.Identifier" stream, and open files from restricted zones in read-only mode

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125093

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125089] Add menu Separator to View -> User Interface menu between legacy toolbars and MUFFIN notebookbars

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125089

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117382] DATUMVERSCHIL is not working, instead must use DATUMALS (DATEDIFF)

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117382

--- Comment #8 from QA Administrators  ---
Dear Cor,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122691] Export full tooltip for footnote number to PDF

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122691

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|QA:needsComment |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124086] copy of the contents of the cell where it finds the cursor

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124086

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125023] Impress videos start with sound, but with out picture. Starting Presentation again with that foil runs correctly.

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125023

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125023] Impress videos start with sound, but with out picture. Starting Presentation again with that foil runs correctly.

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125023

--- Comment #8 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122771] Navigator's vertical scroll-bar is no longer exhibited once Navigator's area has been reduced according to the horizontal axis.

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122771

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|QA:needsComment |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124086] copy of the contents of the cell where it finds the cursor

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124086

--- Comment #6 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105481] Formula disappears after file save and re-open for specific ODT with figure frame

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105481

--- Comment #15 from QA Administrators  ---
Dear john,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91237] CALC hangs on web table paste (intermittent)

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=91237

--- Comment #21 from QA Administrators  ---
Dear Timur,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/qa sw/source

2019-05-17 Thread Mark Hung (via logerrit)
 sw/qa/core/data/doc/tdf124937.doc |binary
 sw/source/core/text/itrform2.cxx  |1 +
 2 files changed, 1 insertion(+)

New commits:
commit 96acebb72211b4718eb3038c427df37b55b17b0b
Author: Mark Hung 
AuthorDate: Tue May 14 01:49:03 2019 +0800
Commit: Mark Hung 
CommitDate: Sat May 18 04:33:35 2019 +0200

tdf#124937 reset m_pFirstOfBorderMerge before truncate.

SwLinePortion::Truncate() called in
SwTextFormatter::FormatReset() delete the portion referred
by m_pFirstOfBorderMerge.

Change-Id: I68e134c86db617d37ea2efa09dad4409772146b5
Reviewed-on: https://gerrit.libreoffice.org/72300
Tested-by: Jenkins
Reviewed-by: Mark Hung 

diff --git a/sw/qa/core/data/doc/tdf124937.doc 
b/sw/qa/core/data/doc/tdf124937.doc
new file mode 100644
index ..4a3f91f7c020
Binary files /dev/null and b/sw/qa/core/data/doc/tdf124937.doc differ
diff --git a/sw/source/core/text/itrform2.cxx b/sw/source/core/text/itrform2.cxx
index fa56ada86eba..da17ddeff5da 100644
--- a/sw/source/core/text/itrform2.cxx
+++ b/sw/source/core/text/itrform2.cxx
@@ -1859,6 +1859,7 @@ void SwTextFormatter::FeedInf( SwTextFormatInfo  ) 
const
 
 void SwTextFormatter::FormatReset( SwTextFormatInfo  )
 {
+m_pFirstOfBorderMerge = nullptr;
 m_pCurr->Truncate();
 m_pCurr->Init();
 if( pBlink && m_pCurr->IsBlinking() )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 122329] When inputting Chinese in CODE, it would show double words instead of one with each input

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122329

--- Comment #12 from Franklin Weng  ---

Fixed in CODE confirmed.  Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 119571] When tracking changes, paragraph joining does not update the style of the text after the deleted paragraph break until show changes is toggled (also it doesn't update t

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119571

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||5310

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125310] DOCX Change tracking: deleting paragraph end mark inserts a page break

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125310

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||9571
   Keywords||bisected

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125341] Crash upon exporting a document to PDF

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125341

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #1 from Aron Budea  ---
Does it happen with any file, eg. an empty document, or only with specific
ones? If the latter, can you attach it? Does LO attempt to submit a crash
report after the crash?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108392] [META] Master slide bugs and enhancements

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108392

Aron Budea  changed:

   What|Removed |Added

 Depends on||125346


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=125346
[Bug 125346] PPTX export: Shape has wrong fill color comming from theme
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108226] [META] PPTX (OOXML) bug tracker

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108226

Aron Budea  changed:

   What|Removed |Added

 Depends on||125346


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=125346
[Bug 125346] PPTX export: Shape has wrong fill color comming from theme
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108230] [META] OOXML document theme issues

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108230

Aron Budea  changed:

   What|Removed |Added

 Depends on||125346


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=125346
[Bug 125346] PPTX export: Shape has wrong fill color comming from theme
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125342] Excel 5.0/95 XLS File shows messy code in Calc

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125342

--- Comment #4 from Kevin Suo  ---
Created attachment 151492
  --> https://bugs.documentfoundation.org/attachment.cgi?id=151492=edit
Bug xls resaved as xlsx in Excel

> It may already help to save the file in Excel as .xlsx instead of .xls
See attached. The resaved xlsx file can be open in Calc without any problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/svx sc/inc sc/source svx/source sw/inc sw/source

2019-05-17 Thread Armin Le Grand (via logerrit)
 include/svx/autoformathelper.hxx  |   72 ++--
 sc/inc/autoform.hxx   |3 
 sc/source/core/tool/autoform.cxx  |   60 
 svx/source/items/autoformathelper.cxx |   43 +++
 sw/inc/tblafmt.hxx|8 +-
 sw/source/core/doc/tblafmt.cxx|  122 ++
 6 files changed, 171 insertions(+), 137 deletions(-)

New commits:
commit 10d8682e4cf77361e0ebf68a4ea1b565f05e91a9
Author: Armin Le Grand 
AuthorDate: Thu May 16 11:33:38 2019 +0200
Commit: Armin Le Grand 
CommitDate: Sat May 18 01:29:25 2019 +0200

Adapt AutoFormatHelper to std::unique_ptr

Change-Id: I3087a7e95e73dbcda798ca62705f7941a6466ccb
Reviewed-on: https://gerrit.libreoffice.org/72401
Tested-by: Jenkins
Reviewed-by: Armin Le Grand 

diff --git a/include/svx/autoformathelper.hxx b/include/svx/autoformathelper.hxx
index a2d72646cbce..c731ff70b5e0 100644
--- a/include/svx/autoformathelper.hxx
+++ b/include/svx/autoformathelper.hxx
@@ -93,47 +93,50 @@ class SVX_DLLPUBLIC AutoFormatBase
 protected:
 // common attributes of Calc and Writer
 // --- from 641 on: CJK and CTL font settings
-std::shared_ptrm_aFont;
-std::shared_ptr  m_aHeight;
-std::shared_ptr  m_aWeight;
-std::shared_ptr m_aPosture;
-
-std::shared_ptrm_aCJKFont;
-std::shared_ptr  m_aCJKHeight;
-std::shared_ptr  m_aCJKWeight;
-std::shared_ptr m_aCJKPosture;
-
-std::shared_ptrm_aCTLFont;
-std::shared_ptr  m_aCTLHeight;
-std::shared_ptr  m_aCTLWeight;
-std::shared_ptr m_aCTLPosture;
-
-std::shared_ptr   m_aUnderline;
-std::shared_ptrm_aOverline;
-std::shared_ptr  m_aCrossedOut;
-std::shared_ptr m_aContour;
-std::shared_ptrm_aShadowed;
-std::shared_ptr   m_aColor;
-std::shared_ptr m_aBox;
-std::shared_ptrm_aTLBR;
-std::shared_ptrm_aBLTR;
-std::shared_ptr   m_aBackground;
+std::unique_ptrm_aFont;
+std::unique_ptr  m_aHeight;
+std::unique_ptr  m_aWeight;
+std::unique_ptr m_aPosture;
+
+std::unique_ptrm_aCJKFont;
+std::unique_ptr  m_aCJKHeight;
+std::unique_ptr  m_aCJKWeight;
+std::unique_ptr m_aCJKPosture;
+
+std::unique_ptrm_aCTLFont;
+std::unique_ptr  m_aCTLHeight;
+std::unique_ptr  m_aCTLWeight;
+std::unique_ptr m_aCTLPosture;
+
+std::unique_ptr   m_aUnderline;
+std::unique_ptrm_aOverline;
+std::unique_ptr  m_aCrossedOut;
+std::unique_ptr m_aContour;
+std::unique_ptrm_aShadowed;
+std::unique_ptr   m_aColor;
+std::unique_ptr m_aBox;
+std::unique_ptrm_aTLBR;
+std::unique_ptrm_aBLTR;
+std::unique_ptr   m_aBackground;
 
 // Writer specific
-std::shared_ptr  m_aAdjust;
+std::unique_ptr  m_aAdjust;
 
 // Calc specific
-std::shared_ptr  m_aHorJustify;
-std::shared_ptr  m_aVerJustify;
-std::shared_ptrm_aStacked;
-std::shared_ptr  m_aMargin;
-std::shared_ptrm_aLinebreak;
+std::unique_ptr  m_aHorJustify;
+std::unique_ptr  m_aVerJustify;
+std::unique_ptrm_aStacked;
+std::unique_ptr  m_aMargin;
+std::unique_ptrm_aLinebreak;
 
 // from SO5, 504k on, rotated text
-std::shared_ptr   m_aRotateAngle;
-std::shared_ptr  m_aRotateMode;
+std::unique_ptr   m_aRotateAngle;
+std::unique_ptr  m_aRotateMode;
+
+// assignment-op is protected due to this being a tooling
+// class, so callers need to be aware of what they do
+AutoFormatBase& operator=(const AutoFormatBase&);
 
-public:
 AutoFormatBase();
 AutoFormatBase( const AutoFormatBase& rNew );
 ~AutoFormatBase();
@@ -141,6 +144,7 @@ public:
 /// Comparing based of boxes backgrounds.
 bool operator==(const AutoFormatBase& rRight);
 
+public:
 // The get-methods.
 const SvxFontItem   () const{ return *m_aFont; }
 const SvxFontHeightItem () const  { return *m_aHeight; }
diff --git a/sc/inc/autoform.hxx b/sc/inc/autoform.hxx
index 5a6676f15500..8fad143b8400 100644
--- a/sc/inc/autoform.hxx
+++ b/sc/inc/autoform.hxx
@@ -112,6 +112,9 @@ public:
 ScAutoFormatDataField( const ScAutoFormatDataField& rCopy );
 ~ScAutoFormatDataField();
 
+// block assignment operator
+ScAutoFormatDataField& operator=(const ScAutoFormatDataField& rRef) = 
delete;
+
 // number format
 const ScNumFormatAbbrev&GetNumFormat() const{ return aNumFormat; }
 
diff --git a/sc/source/core/tool/autoform.cxx b/sc/source/core/tool/autoform.cxx
index 

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - dbaccess/source

2019-05-17 Thread Katarina Behrens (via logerrit)
 dbaccess/source/ui/dlg/generalpage.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 21e1aa9d6b13b39b87435f8998c7ea6123a069fd
Author: Katarina Behrens 
AuthorDate: Wed May 15 20:12:23 2019 +0200
Commit: Thorsten Behrens 
CommitDate: Sat May 18 00:25:51 2019 +0200

tdf#125267: relax the requirement of fixed value of current filter

In a filepicker, user can select any file filter ('All files' for
example) and still choose to open .odb file. Specific UIName of
the current filter ('ODF Database' in this case) shouldn't therefore
be a hard requirement, the correct file extension is enough.

Change-Id: I641a267c545c66aa4d34954922783cc5ff7efd24
Reviewed-on: https://gerrit.libreoffice.org/72377
Tested-by: Jenkins
Reviewed-by: Katarina Behrens 
(cherry picked from commit dc17f247daeb281dda531ff335873d563db5b653)
Reviewed-on: https://gerrit.libreoffice.org/72453
Reviewed-by: Michael Stahl 

diff --git a/dbaccess/source/ui/dlg/generalpage.cxx 
b/dbaccess/source/ui/dlg/generalpage.cxx
index 9f1c2c6f58a6..06a6e7d8b720 100644
--- a/dbaccess/source/ui/dlg/generalpage.cxx
+++ b/dbaccess/source/ui/dlg/generalpage.cxx
@@ -701,7 +701,10 @@ namespace dbaui
 if ( aFileDlg.Execute() == ERRCODE_NONE )
 {
 OUString sPath = aFileDlg.GetPath();
-if ( aFileDlg.GetCurrentFilter() != pFilter->GetUIName() || 
!pFilter->GetWildcard().Matches(sPath) )
+// check for aFileDlg.GetCurrentFilter used to be here but current 
fpicker filter
+// can be set to anything, see tdf#125267 how this breaks if other 
value
+// than 'ODF Database' is selected. Let's therefore check only if 
wildcard matches
+if ( !pFilter->GetWildcard().Matches(sPath) )
 {
 OUString sMessage(DBA_RES(STR_ERR_USE_CONNECT_TO));
 std::unique_ptr 
xInfoBox(Application::CreateMessageDialog(GetFrameWeld(),
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 125298] FILESAVE DOCX Bookmark names and field references shortened in case they are 40 characters long and contain non ASCII characters

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125298

László Németh  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125298] FILESAVE DOCX Bookmark names and field references shortened in case they are 40 characters long and contain non ASCII characters

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125298

--- Comment #6 from Commit Notification 
 ---
Adam Kovacs committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/1cbf0ee54519bf81d934609352e8a1a641d8a534%5E%21

tdf#125298 DOCX export: fix bookmark name truncation

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/qa sw/source

2019-05-17 Thread Adam Kovacs (via logerrit)
 sw/qa/extras/ooxmlexport/data/tdf125298_crossreflink_nonascii_charlimit.docx 
|binary
 sw/qa/extras/ooxmlexport/ooxmlexport13.cxx   | 
  25 ++
 sw/source/filter/ww8/docxattributeoutput.cxx | 
   8 ---
 sw/source/filter/ww8/wrtw8nds.cxx| 
   2 
 4 files changed, 28 insertions(+), 7 deletions(-)

New commits:
commit 1cbf0ee54519bf81d934609352e8a1a641d8a534
Author: Adam Kovacs 
AuthorDate: Fri May 17 11:30:26 2019 +0200
Commit: László Németh 
CommitDate: Sat May 18 00:07:55 2019 +0200

tdf#125298 DOCX export: fix bookmark name truncation

The 40-character bookmark name truncation for MSO was
applied on percent encoded Unicode letters, resulting
shorter bookmark names, than needed (for example,
only 6 letters instead of 40).

This is a clean-up of the commit b9afb9959c31c3c57d0f2fe91107a92abfd82cdb
"tdf#113483: DOCX: fix encoding of bookmarks with non-ASCII letters".

Change-Id: I6fbcdc47c57ef228abcf29e0a68d3d8bb66c5661
Reviewed-on: https://gerrit.libreoffice.org/72456
Tested-by: László Németh 
Tested-by: Jenkins
Reviewed-by: László Németh 

diff --git 
a/sw/qa/extras/ooxmlexport/data/tdf125298_crossreflink_nonascii_charlimit.docx 
b/sw/qa/extras/ooxmlexport/data/tdf125298_crossreflink_nonascii_charlimit.docx
new file mode 100644
index ..d15739971c23
Binary files /dev/null and 
b/sw/qa/extras/ooxmlexport/data/tdf125298_crossreflink_nonascii_charlimit.docx 
differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
index ff2030df8b5f..b056ad16071d 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
@@ -277,10 +277,35 @@ DECLARE_OOXMLEXPORT_TEST(testTdf113483, 
"tdf113483_crossreflink_nonascii_bookmar
 xmlDocPtr pXmlDoc = parseExport("word/document.xml");
 if (!pXmlDoc)
 return;
+// check whether test file keeps non-ascii values or not
 assertXPath(pXmlDoc, "/w:document/w:body/w:p[1]/w:bookmarkStart[1]", 
"name", OUString::fromUtf8("Els\u0151"));
 assertXPathContent(pXmlDoc, 
"/w:document/w:body/w:p[5]/w:r[2]/w:instrText[1]", OUString::fromUtf8(" REF 
Els\u0151 \\h "));
 }
 
+//tdf#125298: fix charlimit restrictions in bookmarknames and field references 
if they contain non-ascii characters
+DECLARE_OOXMLEXPORT_TEST(testTdf125298, 
"tdf125298_crossreflink_nonascii_charlimit.docx")
+{
+xmlDocPtr pXmlDoc = parseExport("word/document.xml");
+if (!pXmlDoc)
+return;
+// check whether test file keeps non-ascii values or not
+OUString bookmarkName1 = getXPath(pXmlDoc, 
"/w:document/w:body/w:p[1]/w:bookmarkStart[1]", "name");
+
CPPUNIT_ASSERT_EQUAL(OUString::fromUtf8("\u00e1rv\u00edzt\u0171r\u0151_t\u00fck\u00f6rf\u00far\u00f3g\u00e9p"),
 bookmarkName1);
+
+OUString bookmarkName2 = getXPath(pXmlDoc, 
"/w:document/w:body/w:p[3]/w:bookmarkStart[1]", "name");
+
CPPUNIT_ASSERT_EQUAL(OUString::fromUtf8("\u00e91\u00e12\u01713\u01514\u00fa5\u00f66\u00fc7\u00f38\u00ed9"),
 bookmarkName2);
+OUString fieldName1 = getXPathContent(pXmlDoc, 
"/w:document/w:body/w:p[5]/w:r[2]/w:instrText[1]");
+OUString expectedFieldName1(" REF ");
+expectedFieldName1 += bookmarkName1;
+expectedFieldName1 += " \\h ";
+CPPUNIT_ASSERT_EQUAL(expectedFieldName1, fieldName1);
+OUString fieldName2 = getXPathContent(pXmlDoc, 
"/w:document/w:body/w:p[7]/w:r[2]/w:instrText[1]");
+OUString expectedFieldName2(" REF ");
+expectedFieldName2 += bookmarkName2;
+expectedFieldName2 += " \\h ";
+CPPUNIT_ASSERT_EQUAL(expectedFieldName2, fieldName2);
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx 
b/sw/source/filter/ww8/docxattributeoutput.cxx
index d351101cf4a7..f47d539ddfb5 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -1612,7 +1612,7 @@ void DocxAttributeOutput::DoWriteBookmarkTagStart(const 
OUString & bookmarkName)
 {
 m_pSerializer->singleElementNS(XML_w, XML_bookmarkStart,
 FSNS(XML_w, XML_id), OString::number(m_nNextBookmarkId),
-FSNS(XML_w, XML_name), 
INetURLObject::decode(BookmarkToWord(bookmarkName), 
INetURLObject::DecodeMechanism::Unambiguous, RTL_TEXTENCODING_UTF8).toUtf8());
+FSNS(XML_w, XML_name), BookmarkToWord(bookmarkName).toUtf8());
 }
 
 void DocxAttributeOutput::DoWriteBookmarkTagEnd(const OUString & bookmarkName)
@@ -1981,12 +1981,6 @@ void DocxAttributeOutput::CmdField_Impl( const 
SwTextNode* pNode, sal_Int32 nPos
sToken = sToken.replaceAll("", "");
sToken = sToken.replaceAll("NN", "ddd");
 }
-//tdf#113483: fix non-ascii characters inside instrText xml tags
-else if ( rInfos.eType 

[Libreoffice-bugs] [Bug 125298] FILESAVE DOCX Bookmark names and field references shortened in case they are 40 characters long and contain non ASCII characters

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125298

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: chart2/source sw/qa

2019-05-17 Thread Balazs Varga (via logerrit)
 chart2/source/view/axes/VCartesianAxis.cxx |   25 ++---
 chart2/source/view/axes/VCartesianAxis.hxx |2 +-
 sw/qa/extras/layout/data/tdf125334.odt |binary
 sw/qa/extras/layout/layout.cxx |   20 +++-
 4 files changed, 38 insertions(+), 9 deletions(-)

New commits:
commit 75ef0e41ea8a9096ac619356d2b837c5333b47e6
Author: Balazs Varga 
AuthorDate: Fri May 17 11:40:27 2019 +0200
Commit: László Németh 
CommitDate: Sat May 18 00:06:28 2019 +0200

tdf#125334 Chart: allow text break in bar chart axis labels

Now vertical category axis labels support text breaking.

Change-Id: I8b1c6eff921ea999bc4f745aa5f85bae278e735b
Reviewed-on: https://gerrit.libreoffice.org/72457
Tested-by: Jenkins
Reviewed-by: László Németh 

diff --git a/chart2/source/view/axes/VCartesianAxis.cxx 
b/chart2/source/view/axes/VCartesianAxis.cxx
index 234e1000140a..4fac1f83b72e 100644
--- a/chart2/source/view/axes/VCartesianAxis.cxx
+++ b/chart2/source/view/axes/VCartesianAxis.cxx
@@ -510,7 +510,7 @@ TickInfo* MaxLabelTickIter::nextInfo()
 }
 
 bool VCartesianAxis::isBreakOfLabelsAllowed(
-const AxisLabelProperties& rAxisLabelProperties, bool bIsHorizontalAxis ) 
const
+const AxisLabelProperties& rAxisLabelProperties, bool bIsHorizontalAxis, 
bool bIsVerticalAxis) const
 {
 if( m_aTextLabels.getLength() > 100 )
 return false;
@@ -525,8 +525,10 @@ bool VCartesianAxis::isBreakOfLabelsAllowed(
rAxisLabelProperties.fRotationAngleDegree == 90.0 ||
rAxisLabelProperties.fRotationAngleDegree == 270.0 ) )
 return false;
-//break only for horizontal axis
-return bIsHorizontalAxis;
+if ( !m_aAxisProperties.m_bSwapXAndY )
+return bIsHorizontalAxis;
+else
+return bIsVerticalAxis;
 }
 namespace{
 
@@ -702,7 +704,7 @@ bool VCartesianAxis::createTextShapes(
 const bool bIsHorizontalAxis = pTickFactory->isHorizontalAxis();
 const bool bIsVerticalAxis = pTickFactory->isVerticalAxis();
 
-if (!isBreakOfLabelsAllowed(rAxisLabelProperties, bIsHorizontalAxis) &&
+if (!isBreakOfLabelsAllowed(rAxisLabelProperties, bIsHorizontalAxis, 
bIsVerticalAxis) &&
 !isAutoStaggeringOfLabelsAllowed(rAxisLabelProperties, 
bIsHorizontalAxis, bIsVerticalAxis) &&
 !rAxisLabelProperties.isStaggered())
 return createTextShapesSimple(xTarget, rTickIter, 
rAxisLabelProperties, pTickFactory);
@@ -714,7 +716,7 @@ bool VCartesianAxis::createTextShapes(
 B2DVector aTextToTickDistance = 
pTickFactory->getDistanceAxisTickToText(m_aAxisProperties, true);
 sal_Int32 nLimitedSpaceForText = -1;
 
-if( isBreakOfLabelsAllowed( rAxisLabelProperties, bIsHorizontalAxis ) )
+if( isBreakOfLabelsAllowed( rAxisLabelProperties, bIsHorizontalAxis, 
bIsVerticalAxis ) )
 {
 nLimitedSpaceForText = nScreenDistanceBetweenTicks;
 if( bIsStaggered )
@@ -742,6 +744,12 @@ bool VCartesianAxis::createTextShapes(
 nLimitedSpaceForText = -1;
 }
 }
+
+// recalculate the nLimitedSpaceForText in case of vertical category 
axis if the text break is true
+if ( m_aAxisProperties.m_bSwapXAndY && bIsVerticalAxis && 
rAxisLabelProperties.fRotationAngleDegree == 0.0 )
+{
+nLimitedSpaceForText = 
rAxisLabelProperties.m_aMaximumSpaceForLabels.X;
+}
 }
 
  // Stores an array of text label strings in case of a normal
@@ -750,8 +758,11 @@ bool VCartesianAxis::createTextShapes(
 if( m_bUseTextLabels && !m_aAxisProperties.m_bComplexCategories )
 pCategories = _aTextLabels;
 
-bool bLimitedHeight = fabs(aTextToTickDistance.getX()) > 
fabs(aTextToTickDistance.getY());
-
+bool bLimitedHeight;
+if( !m_aAxisProperties.m_bSwapXAndY )
+bLimitedHeight = fabs(aTextToTickDistance.getX()) > 
fabs(aTextToTickDistance.getY());
+else
+bLimitedHeight = fabs(aTextToTickDistance.getX()) < 
fabs(aTextToTickDistance.getY());
 //prepare properties for multipropertyset-interface of shape
 tNameSequence aPropNames;
 tAnySequence aPropValues;
diff --git a/chart2/source/view/axes/VCartesianAxis.hxx 
b/chart2/source/view/axes/VCartesianAxis.hxx
index df15e4896198..1c020bc4174c 100644
--- a/chart2/source/view/axes/VCartesianAxis.hxx
+++ b/chart2/source/view/axes/VCartesianAxis.hxx
@@ -150,7 +150,7 @@ private: //methods
  * @return true if we can break a single line label text into multiple
  * lines for better fitting, otherwise false.
  */
-bool isBreakOfLabelsAllowed( const AxisLabelProperties& 
rAxisLabelProperties, bool bIsHorizontalAxis ) const;
+bool isBreakOfLabelsAllowed( const AxisLabelProperties& 
rAxisLabelProperties, bool bIsHorizontalAxis, bool bIsVerticalAxis ) const;
 
 ::basegfx::B2DVector getScreenPosition( double fLogicX, double fLogicY, 
double fLogicZ ) const;
 ScreenPosAndLogicPos getScreenPosAndLogicPos( double 

[Libreoffice-bugs] [Bug 125307] PyUno wrongly converts Tuples of Strings

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125307

Olivier R.  changed:

   What|Removed |Added

 CC||olivier...@grammalecte.net

--- Comment #2 from Olivier R.  ---
Have a look here. Could be useful.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=af8143bc40cf2cfbc12e77c9bb7de01b655f7b30

https://conference.libreoffice.org/assets/Conference/Aarhus/Slides/MatthewFrancisPyUNO.pdf


I don’t know if there is more doc on this topic.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/qa

2019-05-17 Thread Stephan Bergmann (via logerrit)
 sw/qa/uitest/writer_tests5/xwindow.py |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit 9976aa7b8420daa9f7a5290ae433e2ab338ca146
Author: Stephan Bergmann 
AuthorDate: Fri May 17 15:23:04 2019 +0200
Commit: Stephan Bergmann 
CommitDate: Fri May 17 23:38:10 2019 +0200

Fix expected mouseEntered/Exited values in xwindow.py test

(see  "Temporarily disable broken
part of xwindow.py test")

Change-Id: I1c19e24d87971bb3a91f5ccea2f35ecf42f65028
Reviewed-on: https://gerrit.libreoffice.org/72477
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/sw/qa/uitest/writer_tests5/xwindow.py 
b/sw/qa/uitest/writer_tests5/xwindow.py
index 51bee376968a..c1b86323d629 100644
--- a/sw/qa/uitest/writer_tests5/xwindow.py
+++ b/sw/qa/uitest/writer_tests5/xwindow.py
@@ -167,11 +167,12 @@ class XWindow(UITestCase):
 global mouseReleasedEventsIntercepted
 self.assertEqual(2, mouseReleasedEventsIntercepted)
 
+# Upon xMouseEvent, enter the vcl::Window with GetText() being 
"Standard", then upon
+# xMouseEvent2, exit that vcl::Window and enter the one with get_id() 
being "writer_edit":
 global mouseEnteredEventsIntercepted
-#TODO: self.assertEqual(1, mouseEnteredEventsIntercepted)
-
+self.assertEqual(2, mouseEnteredEventsIntercepted)
 global mouseExitedEventsIntercepted
-#TODO: self.assertEqual(0, mouseExitedEventsIntercepted)
+self.assertEqual(1, mouseExitedEventsIntercepted)
 
 # close document
 self.ui_test.close_doc()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 125347] New: Setting text color doesn't work

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125347

Bug ID: 125347
   Summary: Setting text color doesn't work
   Product: LibreOffice
   Version: 6.2.3.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: stalliondr...@gmail.com

When I write any text and try to color it, that function doesn't work. At first
I thought the reason it wouldn't work was because the file had an inserted
table but now I tried with a new file and text coloring still won't work - the
text remains with the default text color which is black.
I even made a video of the bug:
https://www.youtube.com/watch?v=e6_UQvROTds

OS is Arch Linux. LO version is 6.2.3.2 - latest available in Arch repo.

Expected result: clicking the text color button should apply the chosen color.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/svx svx/qa svx/source

2019-05-17 Thread Regina Henschel (via logerrit)
 include/svx/svdoashp.hxx|6 
 svx/qa/unit/customshapes.cxx|   75 
++
 svx/qa/unit/data/tdf115813_HandleMovementOOXMLPresetShapes.pptx |binary
 svx/source/customshapes/EnhancedCustomShape2d.cxx   |   51 +-
 4 files changed, 120 insertions(+), 12 deletions(-)

New commits:
commit 4ca556d041b3e27c4aeebf7434814eb8a4350203
Author: Regina Henschel 
AuthorDate: Mon May 13 14:21:05 2019 +0200
Commit: Regina Henschel 
CommitDate: Fri May 17 21:16:24 2019 +0200

tdf#115813 unit test for handle position of OOXML shapes

The patch contains some additions to tdf#115813 and a unit test.
The test covers nearly all OOXML preset shapes with handles. Only
some shapes do not fit to the test pattern: swooshArrow and polar
handle shapes arc, blockArc, chord, circularArror, mathNotEqual,
pie, leftCircularArrow, leftRightCicularArrow.
The shapes star24 and star32 are excluded because of tdf#125181.
The shapes gear6 and gear9 are excluded because a correct handle
movement is not yet implemented.
Connector shapes are inserted as ordinary shapes to prevent
converting.
The error string is designed to identify the affected shape.

Change-Id: Icd3358f3701ac2db2cc61eb045ae10bc4b72b9ca
Reviewed-on: https://gerrit.libreoffice.org/72229
Tested-by: Jenkins
Reviewed-by: Regina Henschel 

diff --git a/include/svx/svdoashp.hxx b/include/svx/svdoashp.hxx
index e7f915992eae..662ddb5d446b 100644
--- a/include/svx/svdoashp.hxx
+++ b/include/svx/svdoashp.hxx
@@ -98,11 +98,11 @@ public:
 
 css::uno::Reference< css::drawing::XCustomShapeEngine > const & 
GetCustomShapeEngine() const;
 
-SVX_DLLPRIVATE std::vector< SdrCustomShapeInteraction > 
GetInteractionHandles() const;
+std::vector< SdrCustomShapeInteraction > GetInteractionHandles() const; // 
needed in unit test
 SVX_DLLPRIVATE void DragCreateObject( SdrDragStat& rDrag );
 SVX_DLLPRIVATE void DragResizeCustomShape( const tools::Rectangle& 
rNewRect );
-SVX_DLLPRIVATE void DragMoveCustomShapeHdl( const Point& rDestination,
-const sal_uInt16 nCustomShapeHdlNum, bool bMoveCalloutRectangle );
+void DragMoveCustomShapeHdl( const Point& rDestination,
+const sal_uInt16 nCustomShapeHdlNum, bool bMoveCalloutRectangle ); 
// needed in unit test
 
 // #i37011# centralize throw-away of render geometry
 void InvalidateRenderGeometry();
diff --git a/svx/qa/unit/customshapes.cxx b/svx/qa/unit/customshapes.cxx
index 526721d1a6c3..470d838cda3b 100644
--- a/svx/qa/unit/customshapes.cxx
+++ b/svx/qa/unit/customshapes.cxx
@@ -38,6 +38,7 @@ protected:
 uno::Reference mxComponent;
 // get shape nShapeIndex from page 0
 uno::Reference getShape(sal_uInt8 nShapeIndex);
+sal_uInt8 countShapes();
 
 public:
 virtual void setUp() override
@@ -69,6 +70,17 @@ uno::Reference 
CustomshapesTest::getShape(sal_uInt8 nShapeIndex
 return xShape;
 }
 
+sal_uInt8 CustomshapesTest::countShapes()
+{
+uno::Reference xDrawPagesSupplier(mxComponent,
+   
uno::UNO_QUERY_THROW);
+CPPUNIT_ASSERT_MESSAGE("Could not get XDrawPagesSupplier", 
xDrawPagesSupplier.is());
+uno::Reference 
xDrawPages(xDrawPagesSupplier->getDrawPages());
+uno::Reference xDrawPage(xDrawPages->getByIndex(0), 
uno::UNO_QUERY_THROW);
+CPPUNIT_ASSERT_MESSAGE("Could not get xDrawPage", xDrawPage.is());
+return xDrawPage->getCount();
+}
+
 CPPUNIT_TEST_FIXTURE(CustomshapesTest, testViewBoxLeftTop)
 {
 // tdf#121890 formula values "left" and "top" are wrongly calculated
@@ -318,6 +330,69 @@ CPPUNIT_TEST_FIXTURE(CustomshapesTest, 
testTdf124740_handle_path_coordsystem)
 // tolerance for rounding to integer
 CPPUNIT_ASSERT_DOUBLES_EQUAL_MESSAGE("handle X coordinate", 8000.0, fX, 
2.0);
 }
+
+CPPUNIT_TEST_FIXTURE(CustomshapesTest, testTdf115813_OOXML_XY_handle)
+{
+// The test covers all preset shapes with handles. Only these ones are
+// excluded: arc, blockArc, chord, circularArrow, gear6, gear9, 
mathNotEqual, pie,
+// leftCircularArrow, leftRightCircularArrow, star24, star32, swooshArrow.
+// Connectors are included as ordinary shapes to prevent converting.
+// Error was, that the handle movement and the changes to the shape did 
not follow
+// the mouse movement.
+const OUString sFileName("tdf115813_HandleMovementOOXMLPresetShapes.pptx");
+OUString sURL = m_directories.getURLFromSrc(sDataDirectory) + sFileName;
+mxComponent = loadFromDesktop(sURL, 
"com.sun.star.comp.drawing.DrawingDocument");
+CPPUNIT_ASSERT_MESSAGE("Could not load document", mxComponent.is());
+
+OUString sErrors;
+// values in vector InteractionsHandles are in 1/100 mm and refer to page
+for (sal_uInt8 i = 0; i < countShapes(); i++)
+{
+uno::Reference xShape(getShape(i));
+

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2-4' - cui/source include/vcl sc/source vcl/source

2019-05-17 Thread Caolán McNamara (via logerrit)
 cui/source/inc/paragrph.hxx   |   28 +---
 cui/source/tabpages/paragrph.cxx  |   20 --
 include/vcl/weld.hxx  |   12 
 sc/source/ui/attrdlg/tabpages.cxx |   51 --
 sc/source/ui/inc/tabpages.hxx |   13 -
 vcl/source/app/salvtables.cxx |   20 ++
 6 files changed, 89 insertions(+), 55 deletions(-)

New commits:
commit 64576639c4f2d42268692dde8edb53d6791354cd
Author: Caolán McNamara 
AuthorDate: Tue May 7 12:06:30 2019 +0100
Commit: Caolán McNamara 
CommitDate: Fri May 17 21:13:49 2019 +0200

Resolves: tdf#125106 fix cell protect TriState toggles

and merge duplicated TriStateEnabled class

Reviewed-on: https://gerrit.libreoffice.org/71905
Tested-by: Xisco Faulí 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 
(cherry picked from commit 2376db068d8194d3455681a559369e50743e29f3)

Change-Id: I1f145558fe9d86682e03481fb2800386d04d2b1d
Reviewed-on: https://gerrit.libreoffice.org/71994
Reviewed-by: Michael Stahl 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/cui/source/inc/paragrph.hxx b/cui/source/inc/paragrph.hxx
index 183dbba699dc..b741934754ef 100644
--- a/cui/source/inc/paragrph.hxx
+++ b/cui/source/inc/paragrph.hxx
@@ -184,18 +184,6 @@ public:
 virtual voidPageCreated(const SfxAllItemSet& aSet) override;
 };
 
-struct TriStateEnabled
-{
-TriState eState;
-bool bTriStateEnabled;
-TriStateEnabled()
-: eState(TRISTATE_INDET)
-, bTriStateEnabled(true)
-{
-}
-void ButtonToggled(weld::ToggleButton& rToggle);
-};
-
 // class SvxExtParagraphTabPage --
 /*
 [Description]
@@ -235,14 +223,14 @@ protected:
 private:
 SvxExtParagraphTabPage(TabPageParent pParent, const SfxItemSet& rSet);
 
-TriStateEnabled aHyphenState;
-TriStateEnabled aPageBreakState;
-TriStateEnabled aApplyCollState;
-TriStateEnabled aPageNumState;
-TriStateEnabled aKeepTogetherState;
-TriStateEnabled aKeepParaState;
-TriStateEnabled aOrphanState;
-TriStateEnabled aWidowState;
+weld::TriStateEnabled aHyphenState;
+weld::TriStateEnabled aPageBreakState;
+weld::TriStateEnabled aApplyCollState;
+weld::TriStateEnabled aPageNumState;
+weld::TriStateEnabled aKeepTogetherState;
+weld::TriStateEnabled aKeepParaState;
+weld::TriStateEnabled aOrphanState;
+weld::TriStateEnabled aWidowState;
 
 boolbPageBreak;
 boolbHtmlMode;
diff --git a/cui/source/tabpages/paragrph.cxx b/cui/source/tabpages/paragrph.cxx
index a8d9d8ab6003..35515175c760 100644
--- a/cui/source/tabpages/paragrph.cxx
+++ b/cui/source/tabpages/paragrph.cxx
@@ -2063,26 +2063,6 @@ IMPL_LINK(SvxExtParagraphTabPage, WidowHdl_Impl, 
weld::ToggleButton&, rToggle, v
 WidowHdl();
 }
 
-void TriStateEnabled::ButtonToggled(weld::ToggleButton& rToggle)
-{
-if (bTriStateEnabled)
-{
-switch (eState)
-{
-case TRISTATE_INDET:
-rToggle.set_state(TRISTATE_FALSE);
-break;
-case TRISTATE_TRUE:
-rToggle.set_state(TRISTATE_INDET);
-break;
-case TRISTATE_FALSE:
-rToggle.set_state(TRISTATE_TRUE);
-break;
-}
-}
-eState = rToggle.get_state();
-}
-
 IMPL_LINK(SvxExtParagraphTabPage, OrphanHdl_Impl, weld::ToggleButton&, 
rToggle, void)
 {
 aOrphanState.ButtonToggled(rToggle);
diff --git a/include/vcl/weld.hxx b/include/vcl/weld.hxx
index 449829015054..a124cd09786d 100644
--- a/include/vcl/weld.hxx
+++ b/include/vcl/weld.hxx
@@ -627,6 +627,18 @@ public:
 virtual void connect_toggled(const Link& rLink) { 
m_aToggleHdl = rLink; }
 };
 
+struct VCL_DLLPUBLIC TriStateEnabled
+{
+TriState eState;
+bool bTriStateEnabled;
+TriStateEnabled()
+: eState(TRISTATE_INDET)
+, bTriStateEnabled(true)
+{
+}
+void ButtonToggled(ToggleButton& rToggle);
+};
+
 class VCL_DLLPUBLIC MenuButton : virtual public ToggleButton
 {
 protected:
diff --git a/sc/source/ui/attrdlg/tabpages.cxx 
b/sc/source/ui/attrdlg/tabpages.cxx
index 4e82125791dc..8795514813aa 100644
--- a/sc/source/ui/attrdlg/tabpages.cxx
+++ b/sc/source/ui/attrdlg/tabpages.cxx
@@ -49,10 +49,10 @@ ScTabPageProtection::ScTabPageProtection(TabPageParent 
pParent, const SfxItemSet
 //  States will be set in Reset
 bTriEnabled = bDontCare = bProtect = bHideForm = bHideCell = bHidePrint = 
false;
 
-m_xBtnProtect->connect_toggled(LINK(this, ScTabPageProtection, 
ButtonClickHdl));
-m_xBtnHideCell->connect_toggled(LINK(this, ScTabPageProtection, 
ButtonClickHdl));
-m_xBtnHideFormula->connect_toggled(LINK(this, ScTabPageProtection, 
ButtonClickHdl));
-m_xBtnHidePrint->connect_toggled(LINK(this, ScTabPageProtection, 

[Libreoffice-bugs] [Bug 107038] online: Poco::Time* replacement with std::chrono

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107038

Shivansh  changed:

   What|Removed |Added

 CC||avihs...@gmail.com

--- Comment #3 from Shivansh  ---
Created attachment 151491
  --> https://bugs.documentfoundation.org/attachment.cgi?id=151491=edit
changed Poco::Timestamp().epochTime()

Here is a small patch I have attached. Can you tell me if this is the right
way?

Thank you.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/sfx2

2019-05-17 Thread Caolán McNamara (via logerrit)
 include/sfx2/childwin.hxx |8 
 1 file changed, 8 deletions(-)

New commits:
commit 2719821c21761926db46f836cd4190b10fa9d4ff
Author: Caolán McNamara 
AuthorDate: Mon May 13 21:33:31 2019 +0100
Commit: Caolán McNamara 
CommitDate: Fri May 17 20:25:34 2019 +0200

drop now unused SFX_IMPL_MODELESSDIALOG_WITHID

Change-Id: I5c764847218d95289b64ee51e39665dfca8cde69
Reviewed-on: https://gerrit.libreoffice.org/72273
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/include/sfx2/childwin.hxx b/include/sfx2/childwin.hxx
index a01881c7698a..ce6dcb47b5fe 100644
--- a/include/sfx2/childwin.hxx
+++ b/include/sfx2/childwin.hxx
@@ -290,14 +290,6 @@ public:
 static_cast(GetWindow())->FillInfo( aInfo );  \
 return aInfo; }
 
-#define SFX_IMPL_MODELESSDIALOG_WITHID(Class, MyID)\
-SFX_IMPL_CHILDWINDOW_WITHID(Class, MyID)   \
-SfxChildWinInfo Class::GetInfo() const \
-{   \
-SfxChildWinInfo aInfo = SfxChildWindow::GetInfo(); \
-static_cast(GetWindow())->FillInfo( aInfo );  \
-return aInfo; }
-
 #define SFX_IMPL_MODELESSDIALOGCONTOLLER_WITHID(Class, MyID)\
 SFX_IMPL_CHILDWINDOW_WITHID(Class, MyID)   \
 SfxChildWinInfo Class::GetInfo() const \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 125346] PPTX export: Shape has wrong fill color comming from theme

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125346

Tamás Zolnai  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |zolnaitamas2...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125346] New: PPTX export: Shape has wrong fill color comming from theme

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125346

Bug ID: 125346
   Summary: PPTX export: Shape has wrong fill color comming from
theme
   Product: LibreOffice
   Version: 6.3.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: zolnaitamas2...@gmail.com

Description:
The attached document contains one shape on the first slide. After a round trip
in LO, the shape's fill color changes from green to blue. The document contains
two master slides using two different color themes. The root of the issue is
that the export code finds the incorrect theme for the specific slide.

Steps to Reproduce:
1. Open the attached PPTX -> the shape has green fil color
2. Save it back to a different PPTX file
3. Open the saved file again -> the shape has blue fill color

Actual Results:
After an RT shape has blue fill color.

Expected Results:
After an RT shape should have green fill color.


Reproducible: Always


User Profile Reset: No



Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-5-2+backports' - sc/source

2019-05-17 Thread Serge Krot (via logerrit)
 sc/source/core/data/table1.cxx |7 ---
 1 file changed, 7 deletions(-)

New commits:
commit 91bb6196ab7b174fa02acbc1852739cf76439d3e
Author: Serge Krot 
AuthorDate: Tue May 7 10:10:33 2019 +0200
Commit: Thorsten Behrens 
CommitDate: Fri May 17 20:09:53 2019 +0200

tdf#124829 sc: fix crash during progress update

Call reschedule() during update of the cells height is not
thread safe.

Reviewed-on: https://gerrit.libreoffice.org/71892
Reviewed-by: Noel Grandin 
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 
Reviewed-on: https://gerrit.libreoffice.org/72236
Tested-by: Thorsten Behrens 
(cherry picked from commit 5f410088767e05ef5b5a7a7d5bebdce899cfe86a)

Conflicts:
sc/source/core/data/table1.cxx

Change-Id: Ia938aead79a048f12a53aa55c034e84ce3bf433b
Reviewed-on: https://gerrit.libreoffice.org/72498
Reviewed-by: Serge Krot (CIB) 
Tested-by: Serge Krot (CIB) 
Reviewed-by: Thorsten Behrens 

diff --git a/sc/source/core/data/table1.cxx b/sc/source/core/data/table1.cxx
index bd4e779d0984..409968693df5 100644
--- a/sc/source/core/data/table1.cxx
+++ b/sc/source/core/data/table1.cxx
@@ -107,7 +107,6 @@ void GetOptimalHeightsInColumn(
 const SCROW nMinStart = nStartRow + nPos;
 
 sal_uLong nWeightedCount = nProgressStart + 
rCol[MAXCOL].GetWeightedCount(nStartRow, nEndRow);
-const SCCOL progressUpdateStep = MAXCOL / 10;
 for (SCCOL nCol=0; nColSetState( nWeightedCount );
-
-if ((nCol % progressUpdateStep) == 0)
-{
-// try to make sure the progress dialog is painted before 
continuing
-Application::Reschedule(true);
-}
 }
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 119343] EDITING: copied and pasted cells containing formulas are not recalcuated (2)

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119343

Dennis Francis  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|dennisfrancis...@gmail.com  |libreoffice-b...@lists.free
   ||desktop.org

--- Comment #21 from Dennis Francis  ---
I believe the original bug reported here is already fixed in master and release
branches. Need someone else to confirm my findings in comments 17 & 20 and
change the status accordingly. For now I will leave it to NEW.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125023] Impress videos start with sound, but with out picture. Starting Presentation again with that foil runs correctly.

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125023

--- Comment #7 from Kim Mongan  ---
Created attachment 151489
  --> https://bugs.documentfoundation.org/attachment.cgi?id=151489=edit
Simple small 2 slide presentation where video problem occurs

The file size limit is hard to fulfill when you have a video in the
presentation.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125023] Impress videos start with sound, but with out picture. Starting Presentation again with that foil runs correctly.

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125023

--- Comment #6 from Kim Mongan  ---
Hallo.

Did you start the presentation from the first slide ?  If you start from slide
5 it will probably work, but not if you start the presentation from the first
slide and klick slide after slide up to 5.
This problem occurs on my desktop and on my laptop, no difference.

I tried starting Libre Office in Safe Mode and the result is the same, even the
first slide is not shown properly. The second slide does not show correctly but
the music starts. 

Posting my simple test ODP.

Version: 6.2.3.2 (x64)
Build-ID: aecc05fe267cc68dde00352a451aa867b3b546ac
CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; VCL: win; 
Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: shell/CustomTarget_x64.mk shell/Library_spsupp_x64.mk shell/source solenv/gbuild

2019-05-17 Thread Mike Kaganski (via logerrit)
 shell/CustomTarget_x64.mk|8 +---
 shell/Library_spsupp_x64.mk  |   11 +--
 shell/source/win32/spsupp/COMOpenDocuments_x64.cxx   |   13 +
 shell/source/win32/spsupp/registrar_x64.cxx  |   13 +
 shell/source/win32/spsupp/spsuppClassFactory_x64.cxx |   13 +
 shell/source/win32/spsupp/spsuppServ_x64.cxx |   13 +
 solenv/gbuild/LinkTarget.mk  |1 -
 solenv/gbuild/platform/com_MSC_class.mk  |4 ++--
 8 files changed, 60 insertions(+), 16 deletions(-)

New commits:
commit 3259ec8fb318f484ca2bcd798df95fd28dea74f6
Author: Mike Kaganski 
AuthorDate: Fri May 17 14:30:51 2019 +0200
Commit: Mike Kaganski 
CommitDate: Fri May 17 19:34:32 2019 +0200

Make spsupp_x64 independent of shell/CustomTarget_x64

... in preparation for further changes.
Thanks to Noel Grandin for the hint!

Change-Id: I2b223322d1d42099b56a74a92e3c39631d6b581c
Reviewed-on: https://gerrit.libreoffice.org/72470
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/shell/CustomTarget_x64.mk b/shell/CustomTarget_x64.mk
index 42dd36c03edb..79dcde80d0e3 100644
--- a/shell/CustomTarget_x64.mk
+++ b/shell/CustomTarget_x64.mk
@@ -44,12 +44,6 @@ SHELL_PROPERTYHDL_FILES := \
 SHELL_XMLPARSER_FILES := \
all/xml_parser
 
-SHELL_SPSUPP_FILES := \
-win32/spsupp/COMOpenDocuments \
-win32/spsupp/registrar \
-win32/spsupp/spsuppClassFactory \
-win32/spsupp/spsuppServ
-
 SHELL_HEADERS := \
win32/ooofilereader/autostyletag \
win32/ooofilereader/dummytag \
@@ -64,7 +58,7 @@ SHELL_HEADERS := \
win32/zipfile/zipexcptn
 
 $(call gb_CustomTarget_get_target,shell/source) : \
-   $(foreach source,$(SHELL_SHLXTHANDLER_COMMON_FILES) 
$(SHELL_SHLXTHDL_FILES) $(SHELL_OOOFILT_FILES) $(SHELL_PROPERTYHDL_FILES) 
$(SHELL_XMLPARSER_FILES) $(SHELL_SPSUPP_FILES),\
+   $(foreach source,$(SHELL_SHLXTHANDLER_COMMON_FILES) 
$(SHELL_SHLXTHDL_FILES) $(SHELL_OOOFILT_FILES) $(SHELL_PROPERTYHDL_FILES) 
$(SHELL_XMLPARSER_FILES),\
$(call gb_CustomTarget_get_workdir,shell/source)/$(source).cxx) 
\
$(foreach header,$(SHELL_HEADERS),\
$(call gb_CustomTarget_get_workdir,shell/source)/$(header).hxx)
diff --git a/shell/Library_spsupp_x64.mk b/shell/Library_spsupp_x64.mk
index cbb69df7d352..1988b2745539 100644
--- a/shell/Library_spsupp_x64.mk
+++ b/shell/Library_spsupp_x64.mk
@@ -12,7 +12,6 @@ $(eval $(call gb_Library_Library,spsupp_x64))
 $(eval $(call gb_Library_set_x64,spsupp_x64,YES))
 
 $(eval $(call gb_Library_use_custom_headers,spsupp_x64,\
-   shell/source \
shell/source/win32/spsupp/idl \
 ))
 
@@ -35,11 +34,11 @@ $(eval $(call gb_Library_add_ldflags,spsupp_x64,\
/DEF:$(SRCDIR)/shell/source/win32/spsupp/spsupp.def \
 ))
 
-$(eval $(call gb_Library_add_x64_generated_exception_objects,spsupp_x64,\
-CustomTarget/shell/source/win32/spsupp/COMOpenDocuments \
-CustomTarget/shell/source/win32/spsupp/registrar \
-CustomTarget/shell/source/win32/spsupp/spsuppClassFactory \
-CustomTarget/shell/source/win32/spsupp/spsuppServ \
+$(eval $(call gb_Library_add_exception_objects,spsupp_x64,\
+shell/source/win32/spsupp/COMOpenDocuments_x64 \
+shell/source/win32/spsupp/registrar_x64 \
+shell/source/win32/spsupp/spsuppClassFactory_x64 \
+shell/source/win32/spsupp/spsuppServ_x64 \
 ))
 
 # vim: set shiftwidth=4 tabstop=4 noexpandtab:
diff --git a/shell/source/win32/spsupp/COMOpenDocuments_x64.cxx 
b/shell/source/win32/spsupp/COMOpenDocuments_x64.cxx
new file mode 100644
index ..2a155fefa303
--- /dev/null
+++ b/shell/source/win32/spsupp/COMOpenDocuments_x64.cxx
@@ -0,0 +1,13 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+* This file is part of the LibreOffice project.
+*
+* This Source Code Form is subject to the terms of the Mozilla Public
+* License, v. 2.0. If a copy of the MPL was not distributed with this
+* file, You can obtain one at http://mozilla.org/MPL/2.0/.
+*/
+
+// A stub for generating x64 DLL without the need to copy source files to a 
temporary directory
+#include "COMOpenDocuments.cxx"
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/shell/source/win32/spsupp/registrar_x64.cxx 
b/shell/source/win32/spsupp/registrar_x64.cxx
new file mode 100644
index ..18372bb27cf3
--- /dev/null
+++ b/shell/source/win32/spsupp/registrar_x64.cxx
@@ -0,0 +1,13 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+* This file is part of the LibreOffice project.
+*
+* This Source Code Form is subject to the terms of the Mozilla Public
+* License, v. 2.0. If a copy of the MPL was not distributed with this
+* file, You can obtain one at http://mozilla.org/MPL/2.0/.
+*/
+
+// A stub for generating x64 DLL without the need to copy 

[Libreoffice-bugs] [Bug 125345] LibreOffice Impress Slideshow failure

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125345

prasol...@bk.ru changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125345] New: LibreOffice Impress Slideshow failure

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125345

Bug ID: 125345
   Summary: LibreOffice Impress Slideshow failure
   Product: LibreOffice
   Version: 6.2.3.1 rc
  Hardware: x86 (IA32)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: prasol...@bk.ru

Description:
I have simple presentation in .odp format and .ppt format. when starting
Slideshow (press Slide Show, then Start from First Slide or Start from Current
Slide) only white screen pops up with partial text lines at top and bottom of a
screen. 
Opened same presentations in PowerPoint (after saving all as .pptx) -
everything is ok. 
Problem started yesterday, May 16th 2019. 
Checked for updates. Uninstalled and reinstalled the program - problem is still
there. 

Steps to Reproduce:
1.Open presentation in Libre Office Impress
2. Press Slide Show, then Start from First Slide
3. Watch and enjoy

Actual Results:
Blank white screen

Expected Results:
Full screen slide show


Reproducible: Always


User Profile Reset: Yes



Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Repository.mk shell/AllLangMoTarget_shell.mk shell/Executable_spsupp_helper.mk shell/inc shell/Module_shell.mk shell/source shell/WinResTarget_spsupp_dlg.mk

2019-05-17 Thread Mike Kaganski (via logerrit)
 Repository.mk  |2 
 shell/AllLangMoTarget_shell.mk |   11 +
 shell/Executable_spsupp_helper.mk  |   37 
 shell/Module_shell.mk  |6 
 shell/WinResTarget_spsupp_dlg.mk   |   14 +
 shell/inc/spsupp/spsuppServ.hpp|2 
 shell/inc/spsupp/spsuppStrings.hrc |   23 ++
 shell/source/win32/spsupp/COMOpenDocuments.cxx |  113 ++--
 shell/source/win32/spsupp/res/spsuppDlg.h  |   27 ++
 shell/source/win32/spsupp/res/spsuppDlg.rc |   29 +++
 shell/source/win32/spsupp/spsuppHelper.cxx |  231 +
 shell/source/win32/spsupp/spsuppServ.cxx   |   17 -
 12 files changed, 453 insertions(+), 59 deletions(-)

New commits:
commit f60cc89ec35f8b1bf56e9f69ef15143fd002c409
Author: Mike Kaganski 
AuthorDate: Tue May 7 21:22:08 2019 +0300
Commit: Mike Kaganski 
CommitDate: Fri May 17 19:15:02 2019 +0200

SharePoint: Add dialog to choose opening in read-only or edit mode.

ViewDocument3 method takes OpenType parameter, which allows to decide
if user can choose opening the document read-only or to edit.

Since we need to show localizable strings, we need to bootstrap part
of LO (l10n), which is impossible when e.g. 64-bit ActiveX DLL tries
to load installed 32-bit sal DLLs. Thus, we need a separate helper
.exe, which architecture matches the rest of installed LO, and which
handles user interaction.

Change-Id: I0ad53ba64272fb84728d2221e3dc85d3eefdda68
Reviewed-on: https://gerrit.libreoffice.org/72355
Reviewed-by: Mike Kaganski 
Tested-by: Mike Kaganski 

diff --git a/Repository.mk b/Repository.mk
index d9654e717025..a88b0f282897 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -208,6 +208,7 @@ $(eval $(call 
gb_Helper_register_executables_for_install,OOO,ooo, \
) \
$(if $(filter WNT,$(OS)), \
senddoc \
+   spsupp_helper \
) \
$(if $(filter OPENCL,$(BUILD_TYPE)),opencltest) \
 ))
@@ -1120,6 +1121,7 @@ $(eval $(call gb_Helper_register_mos,\
scc \
sd \
sfx \
+   shell \
sm \
svl \
svt \
diff --git a/shell/AllLangMoTarget_shell.mk b/shell/AllLangMoTarget_shell.mk
new file mode 100644
index ..41285974e3b7
--- /dev/null
+++ b/shell/AllLangMoTarget_shell.mk
@@ -0,0 +1,11 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+
+$(eval $(call gb_AllLangMoTarget_AllLangMoTarget,shell))
+
+# vim: set noet sw=4 ts=4:
diff --git a/shell/Executable_spsupp_helper.mk 
b/shell/Executable_spsupp_helper.mk
new file mode 100644
index ..5daeff28da56
--- /dev/null
+++ b/shell/Executable_spsupp_helper.mk
@@ -0,0 +1,37 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call gb_Executable_Executable,spsupp_helper))
+
+$(eval $(call gb_Executable_set_targettype_gui,spsupp_helper,YES))
+
+$(eval $(call gb_Executable_set_include,spsupp_helper,\
+-I$(SRCDIR)/shell/inc/spsupp \
+$$(INCLUDE) \
+))
+
+$(eval $(call gb_Executable_use_sdk_api,spsupp_helper))
+
+$(eval $(call gb_Executable_use_libraries,spsupp_helper,\
+   i18nlangtag \
+   sal \
+   utl \
+))
+
+$(eval $(call gb_Executable_add_exception_objects,spsupp_helper,\
+shell/source/win32/spsupp/spsuppHelper \
+))
+
+$(eval $(call gb_Executable_add_nativeres,spsupp_helper,spsupp_dlg))
+
+$(eval $(call gb_Executable_use_system_win32_libs,spsupp_helper,\
+shell32 \
+))
+
+# vim:set noet sw=4 ts=4:
diff --git a/shell/Module_shell.mk b/shell/Module_shell.mk
index 2aeb69177a13..c0c42cc5bea5 100644
--- a/shell/Module_shell.mk
+++ b/shell/Module_shell.mk
@@ -43,6 +43,7 @@ $(eval $(call gb_Module_add_targets,shell,\
Executable_senddoc \
Library_smplmail \
Library_wininetbe \
+   Executable_spsupp_helper \
 ))
 
 ifeq ($(COM),MSC)
@@ -57,6 +58,7 @@ $(eval $(call gb_Module_add_targets,shell,\
CustomTarget_spsupp_idl \
Library_spsupp \
WinResTarget_spsupp \
+   WinResTarget_spsupp_dlg \
 ))
 
 $(eval $(call gb_Module_add_check_targets,shell,\
@@ -104,4 +106,8 @@ endif
 
 endif
 
+$(eval $(call gb_Module_add_l10n_targets,shell,\
+AllLangMoTarget_shell \
+))
+
 # vim: set shiftwidth=4 tabstop=4 noexpandtab:
diff --git a/shell/WinResTarget_spsupp_dlg.mk b/shell/WinResTarget_spsupp_dlg.mk
new file mode 

[Libreoffice-bugs] [Bug 124906] iPad Hardware-Keyboard in iOS App: Characters appear twice

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124906

--- Comment #7 from Nicolas Christener  ---
I may be wrong, but as far as I remember I also encountered this issue in
"online", I think it is not related to iOS.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125212] Installation doesn't work on "Windows To Go" Windows 8.1

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125212

Mike Kaganski  changed:

   What|Removed |Added

 Resolution|--- |NOTOURBUG
 Status|UNCONFIRMED |RESOLVED

--- Comment #12 from Mike Kaganski  ---
(In reply to jlucschoon from comment #11)

Thank you for the notice!
Based on your information, I assume that that was a problem with a system
component (Windows Update), and problem was resolved after fixing that
component state. Thus, I close this as NOTOURBUG.

Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113117] [META] Windows installer/uninstaller bugs and enhancements

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113117
Bug 113117 depends on bug 125212, which changed state.

Bug 125212 Summary: Installation doesn't work on "Windows To Go" Windows 8.1
https://bugs.documentfoundation.org/show_bug.cgi?id=125212

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTOURBUG

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125344] Calc crashes when changing number format in .csv file

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125344

--- Comment #1 from Eike Rathke  ---
Please attach the file and give details what exactly to do to provoke the
crash.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125342] Excel 5.0/95 XLS File shows messy code in Calc

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125342

Eike Rathke  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #3 from Eike Rathke  ---
Looks like a wrong text encoding was used during import. It may already help to
save the file in Excel as .xlsx instead of .xls, the binary .xls file format is
notoriously known for not properly indicating which encoding is used for stored
strings, especially if written by 3rd party software and not Excel, but even
then..

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 119745] Scrolling with a laptop touchpad in Libreoffice way too fast

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119745

--- Comment #13 from honorine.br...@yahoo.com ---
(In reply to Buovjaga from comment #1)
> Please tell us the laptop model.
> Have you seen this in versions older than 6.0.6?
> 
> Set to NEEDINFO.
> Change back to UNCONFIRMED after you have provided the information.

Hi, 
I have a ASUS ZenBook UX430UA
I have the Libre Office version 6.2.3.2
I have this bug of the track pad way too sensitive that make the scrolling way
too fast

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125212] Installation doesn't work on "Windows To Go" Windows 8.1

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125212

--- Comment #11 from jlucsch...@aol.com ---
(In reply to Mike Kaganski from comment #10)
> Things to try:
> 
> 1. Stop Windows Update service (*do not disable!*) and start installation of
> the update package - so that the update would start the service itself. It
> is reported that in some cases, that helps.
> 2. Stop Windows Update service, and *remove*
> C:\Windows\SoftwareDistribution. Then start Windows Update service to
> re-create the directory anew.


Hello!

Unfortunately, what you suggested didn't worked... 

But, I have manage to make 'Windows update' work again on my win 8.1 pc, with
kb3138615.

After that, LibreOffice 6.1.6 installation worked perfectly.

Thank you very much for your help!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125329] Automatic font color becomes invisible in Calc charts

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125329

--- Comment #3 from BogdanB  ---
With the mention that text is first black, but after going outside of the chart
and resize it the font color change...To automatic which in this case became
WHITE.

Reproduce also on

Version: 6.3.0.0.alpha0+
Build ID: 96ab20756316b25b7f2343a15596bc5114ea5a68
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2019-05-02_14:29:16
Locale: ro-RO (ro_RO.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/svx sd/source svx/source

2019-05-17 Thread Caolán McNamara (via logerrit)
 include/svx/graphctl.hxx |3 ++-
 include/svx/svdpntv.hxx  |5 ++---
 sd/source/ui/inc/ClientView.hxx  |4 ++--
 sd/source/ui/view/clview.cxx |4 ++--
 svx/source/dialog/graphctl.cxx   |   15 +--
 svx/source/svdraw/sdrpagewindow.cxx  |2 +-
 svx/source/svdraw/sdrpaintwindow.cxx |6 --
 svx/source/svdraw/svdpagv.cxx|2 +-
 svx/source/svdraw/svdpntv.cxx|   10 ++
 9 files changed, 29 insertions(+), 22 deletions(-)

New commits:
commit 810e1a86b0f87086f972f0b1190130ce3ec088b2
Author: Caolán McNamara 
AuthorDate: Thu May 16 13:57:07 2019 +0100
Commit: Caolán McNamara 
CommitDate: Fri May 17 18:10:30 2019 +0200

there's already a way to customize the invalidation

Change-Id: I486494de730b8665e56cfc664b62830fb0b8b8ee
Reviewed-on: https://gerrit.libreoffice.org/72415
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/include/svx/graphctl.hxx b/include/svx/graphctl.hxx
index b4044d2b072b..d4fe23b3abca 100644
--- a/include/svx/graphctl.hxx
+++ b/include/svx/graphctl.hxx
@@ -264,7 +264,8 @@ public:
 // override these so we can get the occasions SdrPaintView would call 
Window::Invalidate on its vcl::Window
 // if it had one, and route to WidgetController::Invalidate instead
 virtual rtl::Reference 
CreateOverlayManager(OutputDevice& rDevice) const override;
-virtual void InvalidateWindow(const tools::Rectangle& rArea, OutputDevice& 
rDevice) const override;
+virtual void InvalidateOneWin(OutputDevice& rWin) override;
+virtual void InvalidateOneWin(OutputDevice& rWin, const tools::Rectangle& 
rRect) override;
 };
 
 #endif // INCLUDED_SVX_GRAPHCTL_HXX
diff --git a/include/svx/svdpntv.hxx b/include/svx/svdpntv.hxx
index 7fe1a838b8d3..ce62413bc7c5 100644
--- a/include/svx/svdpntv.hxx
+++ b/include/svx/svdpntv.hxx
@@ -238,7 +238,6 @@ public:
 SdrPaintWindow* GetPaintWindow(sal_uInt32 nIndex) const;
 // Replacement for GetWin(0), may return 0L (!)
 OutputDevice* GetFirstOutputDevice() const;
-virtual void InvalidateWindow(const tools::Rectangle& rArea, OutputDevice& 
rDevice) const;
 
 private:
 SVX_DLLPRIVATE void ImpClearVars();
@@ -432,8 +431,8 @@ public:
 
 /// If the View should not call Invalidate() on the windows, override
 /// the following 2 methods and do something else.
-virtual void InvalidateOneWin(vcl::Window& rWin);
-virtual void InvalidateOneWin(vcl::Window& rWin, const tools::Rectangle& 
rRect);
+virtual void InvalidateOneWin(OutputDevice& rWin);
+virtual void InvalidateOneWin(OutputDevice& rWin, const tools::Rectangle& 
rRect);
 
 void SetActiveLayer(const OUString& rName) { maActualLayer=rName; }
 const OUString&  GetActiveLayer() const { return maActualLayer; }
diff --git a/sd/source/ui/inc/ClientView.hxx b/sd/source/ui/inc/ClientView.hxx
index a7bb20b51bf2..a616a6252bce 100644
--- a/sd/source/ui/inc/ClientView.hxx
+++ b/sd/source/ui/inc/ClientView.hxx
@@ -38,8 +38,8 @@ public:
 
 /* if the view should not do a Invalidate() on the windows, you have to
override the following two methods and do something different */
-virtual void InvalidateOneWin(vcl::Window& rWin) override;
-virtual void InvalidateOneWin(vcl::Window& rWin, const ::tools::Rectangle& 
rRect) override;
+virtual void InvalidateOneWin(OutputDevice& rWin) override;
+virtual void InvalidateOneWin(OutputDevice& rWin, const 
::tools::Rectangle& rRect) override;
 };
 
 } // end of namespace sd
diff --git a/sd/source/ui/view/clview.cxx b/sd/source/ui/view/clview.cxx
index 29905c83909f..a73bd292314f 100644
--- a/sd/source/ui/view/clview.cxx
+++ b/sd/source/ui/view/clview.cxx
@@ -48,7 +48,7 @@ ClientView::~ClientView()
  * to be overridden and properly handled.
  */
 
-void ClientView::InvalidateOneWin(vcl::Window& rWin)
+void ClientView::InvalidateOneWin(OutputDevice& rWin)
 {
 vcl::Region aRegion;
 CompleteRedraw(, aRegion);
@@ -59,7 +59,7 @@ void ClientView::InvalidateOneWin(vcl::Window& rWin)
  * to be overridden and properly handled.
  */
 
-void ClientView::InvalidateOneWin(vcl::Window& rWin, const ::tools::Rectangle& 
rRect)
+void ClientView::InvalidateOneWin(OutputDevice& rWin, const 
::tools::Rectangle& rRect)
 {
 CompleteRedraw(, vcl::Region(rRect));
 }
diff --git a/svx/source/dialog/graphctl.cxx b/svx/source/dialog/graphctl.cxx
index d77a7c6e6069..470912a649c5 100644
--- a/svx/source/dialog/graphctl.cxx
+++ b/svx/source/dialog/graphctl.cxx
@@ -1494,7 +1494,18 @@ rtl::Reference 
SvxGraphCtrlView::CreateOverlayMana
 return SdrView::CreateOverlayManager(rDevice);
 }
 
-void SvxGraphCtrlView::InvalidateWindow(const tools::Rectangle& rArea, 
OutputDevice& rDevice) const
+void SvxGraphCtrlView::InvalidateOneWin(OutputDevice& rDevice)
+{
+assert( == ()->get_ref_device());
+if (rDevice.GetOutDevType() == OUTDEV_VIRDEV)
+{
+

[Libreoffice-bugs] [Bug 125329] Automatic font color becomes invisible in Calc charts

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125329

BogdanB  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||buzea.bog...@libreoffice.or
   ||g
 Status|UNCONFIRMED |NEW

--- Comment #2 from BogdanB  ---
I could reproduce this on Linux 6.2

Version: 6.2.3.2
Build ID: aecc05fe267cc68dde00352a451aa867b3b546ac
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ro-RO (ro_RO.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124906] iPad Hardware-Keyboard in iOS App: Characters appear twice

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124906

--- Comment #6 from Tor Lillqvist  ---
For reference, here is a log from adding console.log calls to the original
code. From this can be seen that when I type the keys a ¨ e b , for some reason
the keydown, keypress, and keyup events for the b and c keys arrived in
duplicate, nested. That caused the b and c characters to be entered twice into
the document. What caused this duplication is unknown. Possibly some bug in
iOS, possibly some bug in the app (loleaflet) code.

> [Log] ==> onKeyEvents: keydown:a keyCode=65 charCode=0 unoKeyCode=512 
> _keyHandled=true _isComposing=undefined (Control.MobileInput.js, line 125)
> [Log] _keyHandled := false (Control.MobileInput.js, line 144)
> [Log] ==> onKeyEvents: keypress:a keyCode=97 charCode=97 unoKeyCode=257 
> _keyHandled=false _isComposing=undefined (Control.MobileInput.js, line 125)
> [Log] ==> _postKeyboardEvent type=input charcode=97 keycode=0 (TileLayer.js, 
> line 1573)
> [Log] _keyHandled := true (Control.MobileInput.js, line 172)
> [Log] ==> onTextInput: _keyHandled=true (Control.MobileInput.js, line 205)
> [Log] ==> onInput: inputType=insertText (Control.MobileInput.js, line 215)
> [Log] ==> onKeyEvents: keyup:a keyCode=0 charCode=0 unoKeyCode=0 
> _keyHandled=true _isComposing=undefined (Control.MobileInput.js, line 125)
> [Log] ==> _postKeyboardEvent type=up charcode=0 keycode=0 (TileLayer.js, line 
> 1573)
> [Log] _keyHandled := true (Control.MobileInput.js, line 182)
> [Log] ==> onCompEvents: compositionstart (Control.MobileInput.js, line 188)
> [Log] ==> onCompEvents: compositionupdate (Control.MobileInput.js, line 188)
> [Log] ==> onInput: inputType=insertCompositionText (Control.MobileInput.js, 
> line 215)
> [Log] ==> _postCompositionEvent type=input text="¨" (TileLayer.js, line 1599)
> [Log] ==> onKeyEvents: keydown:ë keyCode=69 charCode=0 unoKeyCode=516 
> _keyHandled=true _isComposing=true (Control.MobileInput.js, line 125)
> [Log] _keyHandled := false (Control.MobileInput.js, line 144)
> [Log] ==> onKeyEvents: keypress:ë keyCode=235 charCode=235 unoKeyCode=235 
> _keyHandled=false _isComposing=false (Control.MobileInput.js, line 125)
> [Log] ==> _postKeyboardEvent type=input charcode=235 keycode=0 (TileLayer.js, 
> line 1573)
> [Log] _keyHandled := true (Control.MobileInput.js, line 172)
> [Log] ==> onTextInput: _keyHandled=true (Control.MobileInput.js, line 205)
> [Log] ==> onInput: inputType=insertFromComposition (Control.MobileInput.js, 
> line 215)
> [Log] ==> onCompEvents: compositionend (Control.MobileInput.js, line 188)
> [Log] ==> _postCompositionEvent type=end text="" (TileLayer.js, line 1599)
> [Log] ==> onKeyEvents: keyup:Dead keyCode=69 charCode=0 unoKeyCode=516 
> _keyHandled=true _isComposing=false (Control.MobileInput.js, line 125)
> [Log] ==> _postKeyboardEvent type=up charcode=0 keycode=516 (TileLayer.js, 
> line 1573)
> [Log] _keyHandled := true (Control.MobileInput.js, line 182)
> [Log] ==> onKeyEvents: keyup:ë keyCode=0 charCode=0 unoKeyCode=0 
> _keyHandled=true _isComposing=false (Control.MobileInput.js, line 125)
> [Log] ==> _postKeyboardEvent type=up charcode=0 keycode=0 (TileLayer.js, line 
> 1573)
> [Log] _keyHandled := true (Control.MobileInput.js, line 182)
> 
> 
> [Log] ==> onKeyEvents: keydown:b keyCode=66 charCode=0 unoKeyCode=513 
> _keyHandled=true _isComposing=false (Control.MobileInput.js, line 125)
> [Log] _keyHandled := false (Control.MobileInput.js, line 144)
> [Log] ==> onKeyEvents: keypress:b keyCode=98 charCode=98 unoKeyCode=258 
> _keyHandled=false _isComposing=false (Control.MobileInput.js, line 125)
> [Log] ==> _postKeyboardEvent type=input charcode=98 keycode=0 (TileLayer.js, 
> line 1573)
> [Log] _keyHandled := true (Control.MobileInput.js, line 172)
> [Log] ==> onKeyEvents: keydown:b keyCode=66 charCode=0 unoKeyCode=513 
> _keyHandled=true _isComposing=false (Control.MobileInput.js, line 125)
> [Log] _keyHandled := false (Control.MobileInput.js, line 144)
> [Log] ==> onKeyEvents: keypress:b keyCode=98 charCode=98 unoKeyCode=258 
> _keyHandled=false _isComposing=false (Control.MobileInput.js, line 125)
> [Log] ==> _postKeyboardEvent type=input charcode=98 keycode=0 (TileLayer.js, 
> line 1573)
> [Log] _keyHandled := true (Control.MobileInput.js, line 172)
> [Log] ==> onKeyEvents: keyup:Dead keyCode=66 charCode=0 unoKeyCode=513 
> _keyHandled=true _isComposing=false (Control.MobileInput.js, line 125)
> [Log] ==> _postKeyboardEvent type=up charcode=0 keycode=513 (TileLayer.js, 
> line 1573)
> [Log] _keyHandled := true (Control.MobileInput.js, line 182)
> [Log] ==> onKeyEvents: keyup:b keyCode=0 charCode=0 unoKeyCode=0 
> _keyHandled=true _isComposing=false (Control.MobileInput.js, line 125)
> [Log] ==> _postKeyboardEvent type=up charcode=0 keycode=0 (TileLayer.js, line 
> 1573)
> [Log] _keyHandled := true (Control.MobileInput.js, line 182)
> [Log] ==> onKeyEvents: keydown:c keyCode=67 

Re: Update of file oox-drawingml-cs-presets

2019-05-17 Thread Miklos Vajna
Hi Regina,

On Fri, May 17, 2019 at 05:00:02PM +0200, Regina Henschel 
 wrote:
> to fix https://bugs.documentfoundation.org/show_bug.cgi?id=125181 it is
> needed to correct the file
> oox/source/drawingml/customshapes/presetShapeDefinitions.xml.

IIRC that file is from the OOXML spec, so please double-check that you
indeed have to change it.

> Do I need to include all changed files into the patch? Or is the change to
> presetShapeDefinitions.xml sufficient and there is a way to run the script
> afterwards?

It's perfectly fine to do this in two commits if you prefer that. If you
just change presetShapeDefinitions.xml, then I think nothing will change
in practice; but separating your real change and the generated changes
make sense.

Tracking the generated file in git is needed because of the circular
dependency here: to generate the file, you need a working installation
set, but to create the installation set, first you need to generate the
file. :-)

Regards,

Miklos


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 124467] cannot disable wrap text

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124467

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125344] New: Calc crashes when changing number format in .csv file

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125344

Bug ID: 125344
   Summary: Calc crashes when changing number format in .csv file
   Product: LibreOffice
   Version: 6.2.3.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ravenkw...@gmail.com

This bug was filed from the crash reporting server and is
br-0f941bc8-9114-47b4-a5ad-6762f9b07e21.


When I open a .csv file and make it editable, calc crashes if I attempt to
change the number formating (specifically, making the numbers currency).

If I open the file, make it editable, and save it as a .ods file, it still
crashes.

I have to open, save it, close it and open the saved file before I can change
number formats.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: [Libreoffice-commits] core.git: The -fvisibility-ms-compat hack is no longer needed for UBSan on Linux...

2019-05-17 Thread Stephan Bergmann

On 03/05/2019 13:58, Stephan Bergmann wrote:

This is a heads up for anybody using Clang ASan/UBSan on Linux:

(1)  If you are using Clang trunk (towards Clang 9), make sure you have 
 
"Adapt -fsanitize=function to SANITIZER_NON_UNIQUE_TYPEINFO".  Configure 
now assumes that "Clang >= 9" implies that fix, and otherwise building 
or running LO could fail.


(2)  I want to eventually get rid of the legacy 
NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY code, so if you are using an 
older Clang, it would be great if you could upgrade as soon as 
convenient for you (and once Clang 9 is even out).


*  is now using an appropriate 
Clang trunk (see 
 
"Bump ASan/UBSan bot to Clang trunk towards Clang 9").


* The fuzzer machinery was already using Clang trunk and appears to not 
be negatively affected by the below 
9a7aa3326d087c79879e435179e359dd76aa5e0a "The -fvisibility-ms-compat 
hack is no longer needed for UBSan on Linux..." (Caolán, correct me if 
I'm wrong).


*  "Remove legacy 
solenv/sanitizers/asan-suppressions support" will drop the legacy 
NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY code (and the no longer needed 
solenv/sanitizers/asan-suppressions, which people might still reference 
from their ASAN_OPTIONS), I plan on submitting it in a week, say.  Speak 
up now if you still need non-trunk Clang supported for sanitizer builds!



On 03/05/2019 13:47, Stephan Bergmann (via logerrit) wrote:

New commits:
commit 9a7aa3326d087c79879e435179e359dd76aa5e0a
Author: Stephan Bergmann 
AuthorDate: Tue Apr 16 16:11:39 2019 +0200
Commit: Stephan Bergmann 
CommitDate: Fri May 3 13:46:25 2019 +0200

 The -fvisibility-ms-compat hack is no longer needed for UBSan on 
Linux...
 ...with latest Clang trunk towards Clang 9.  All the no-longer 
necessary hacks
 are made conditional on new 
NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY, which is
 still set for UBSan builds with older Clang on Linux (but which 
should

 eventually be purged).
 Various classes needed additional SAL_DLLPUBLIC_RTTI annotations, 
as building
 with UBSan instrumentation can generate references to RTTI 
symbols from
 additional places like outside a dynamic library that used to 
hide those symbols
 by default (but used to not hide them for old UBSan builds thanks 
to the

 -fvisibility-ms-compat hack).
 The odr-violation suppressions in 
solenv/sanitizers/asan-suppressions (which is
 not referenced from anywhere in the code base, but meant to be 
included in an
 ASan/UBSan build's ASAN_OPTIONS env var) are also no longer 
needed when

 NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY is false.
 Change-Id: I24ec3e388b0cbab50dbe2bf008d9569bff7bf25a
 Reviewed-on: https://gerrit.libreoffice.org/70829
 Tested-by: Jenkins
 Reviewed-by: Stephan Bergmann 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] translations.git: Changes to 'refs/tags/libreoffice-6.2.4.2'

2019-05-17 Thread Libreoffice Gerrit user
Tag 'libreoffice-6.2.4.2' created by Christian Lohmaier 
 at 2019-05-17 15:35 +

Tag libreoffice-6.2.4.2
-BEGIN PGP SIGNATURE-

iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAlze1LcACgkQ9DSh76/u
rqOmcw//Q/NYVQPm+sEBA1XEkRD7XyGzQiPyEnkoSgEX3BTqPH2HxVk6IJkGIlFI
L5y/4JTKTdVWtXYgZhHzbYDZwxUwi0ijGk2MMpJiWPpCv7GCQIHBzvWw5Occxb/T
/3kXARt7+qhnF/do7D5s6icRGcGNJAfUKrqTN36UcxkYuNmt81emRx2hb66E0YwX
jv5SaabGuhfRLr3vi+g2GDqqib2QoPlV/CvLVS9vvnngOyhKRh13UG2tgs3j7a4l
rwq+yCw/FmDYpI0BBN8wGnhN752Vme5FIjxVBNrumeofr2XcW0Gs4n1ijJB9yeRN
quEcHlcOqjCT3sG1ycEfiQ9HMZ9w3J9k0Ae1q/hrE3kfa2WFIQICovPj5f71p1r1
6qrmlwraLxSC6SIuYtjonJeDJJcEHYwKQzSr3DqydDeitZQr1sMyJM9RtqgpJq5+
nCNQubNRSpHPBZaR0gCSVYXB8JNqyt5vexd2ipQihxyNK/KLlJThmZpHv0qf6192
fnYVRseWDkOuGUa1V5ANhwkdmoKsDJpPdpdkJGlv+y+vKDg5sGNHemnr3FOqAe0n
wEsItqIrh8vd6L3IVguOGXbC9awahypDxp5PViNajvTF4hjolIIHxBSu2gV+8QYa
/5Vv442nbDL7rvivBN4Am7Ii3/8hnMdlJ4fyw8RxecJYkxW43Oo=
=Il9T
-END PGP SIGNATURE-

Changes since libreoffice-6-2-branch-point-26:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/libreoffice-6.2.4.2'

2019-05-17 Thread Libreoffice Gerrit user
Tag 'libreoffice-6.2.4.2' created by Christian Lohmaier 
 at 2019-05-17 15:35 +

Tag libreoffice-6.2.4.2
-BEGIN PGP SIGNATURE-

iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAlze1LEACgkQ9DSh76/u
rqO/LhAAm2aeyxt3rEjFM6baM4fJE3+mCh6rsDXgq3K71afvKQ+IEwb4mz4b93hv
6tkHmTlGkzREcXfmJ+qCnhjSZmXfgZfaTljCfmfxn3Nez3W+ZCkOxR3kJRmOnshS
4nj8RqlaNu6n+CaYkM7tMFb3831RI8O0Xwz0YmeURcgO+0KnV8ZnwmWYFM8CaClT
ZY6EOlzeRbiekuLKy/iA1juYVSEIibQQ/v/o051EDmlznCBP2d408yLKwmijd8HQ
FfZ3mRSiliWhWm9mp2S0BETJBzzxGNqmPiLOaU4UEUh+ws7Alp1RkddW2AgNcVlr
ihOB+FAyNYk073Xp2pqMxe6h+Y+MQsArnMaxdiR3nF8qYeBnOxSoXZUmsuq7wsOW
7Kr/3cErQ68jiWRVMNhIqE3hxY7tLRGP2397q3UpkKWmaYWlCHWzVcupeQYJgnZs
PqOqEzg3S9nleiTczW3Kk1fd+g5Fy41hHNl873WyiHY+0kNqOpb048H0w2CuKisJ
IogK3WRvwDn3FIQ+ZVW1d7mnSjC/OpER40P0BTCr1eeNG5rwFpqkEYd38q5PNdKj
WEOMYLPGTr4Sui/hKh1h0KbB/WiepgJ/EQXTTAcGNx9AwJ2gp987tb1unVIxHIxH
psjhLaFXmh+AUFSZ1z6IOxVUYeg3lpOgvpXPsvtZtbhOGQtLxXA=
=xQH/
-END PGP SIGNATURE-

Changes since libreoffice-6-2-branch-point-6:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: Changes to 'refs/tags/libreoffice-6.2.4.2'

2019-05-17 Thread Libreoffice Gerrit user
Tag 'libreoffice-6.2.4.2' created by Christian Lohmaier 
 at 2019-05-17 15:35 +

Tag libreoffice-6.2.4.2
-BEGIN PGP SIGNATURE-

iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAlze1LcACgkQ9DSh76/u
rqPM4g//Rh9lX5xqnNTYirqf2vc8IxDuf/lyfT1/tdSAkULSVbxS7MrlS96RsCW1
4+50PFseQpcHNW+PqJb/A/kMzvhQbkPBb8ipr5EvL5/oah43kKCyg/zknpEBZ/1c
f/5MgaDMQ/zuY5sGp0RUBrsKexcDHIPN0rJRypVMMjjPo1xoAgYwOkpcVlbkYth5
1T1yvExQPB5SLcvydmWARuJt20n0snkokIzaBgaR7vq4DPgBmuqo3yrNtCSIHfZB
A27cd1Ofp/0mZhbSBRS6y83Q8AwEwj8ASP/u+w5DX6TPXRvFBOf+/p0OdrTHk99P
urgH5dn0w6ILu5AqfLfbQti8X1AGBTCjPzG6Ga0Ky+Qhv3QS+MUu2XFlMek2/R8X
8+u506XTBq6U4OVq1w94IGAoyNHuswu3UtaTrBMUgQwCodVohDZy9Z9HejMsfRaV
+uujLEavKIdCvAL8UAOp2LxyltVEPYZ8ze/00QwBoJ+xHXqw8c6UhoYMB6jFRHxh
olS2aCmmUwD/lUzyX0m3CUZ1pBfjvgQoxrUrvMRCzzLsszVjrhOHYybGlo9e7UVE
JI/raJTbg3zNCpcm++Fr1pN4uoacrVgyuMBVcJDKF3xm1vm5q2ebWLxWLlZQSMSY
gcUhSKCZda+VPTSh43OABtPp1Y9CNdVHrL87LWyHkd7ZGFQpN7s=
=m8NA
-END PGP SIGNATURE-

Changes since libreoffice-6-2-branch-point-48:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2-4' - configure.ac

2019-05-17 Thread Christian Lohmaier (via logerrit)
 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d541b9080e117539cc97d1f48d5df488cff7353f
Author: Christian Lohmaier 
AuthorDate: Fri May 17 17:35:40 2019 +0200
Commit: Christian Lohmaier 
CommitDate: Fri May 17 17:35:40 2019 +0200

bump product version to 6.2.4.2.0+

Change-Id: Ib55310bd8aad8872d70ce2bb83d2918f702da6a2

diff --git a/configure.ac b/configure.ac
index 6834e6336fab..fc5216dd9143 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([LibreOffice],[6.2.4.1.0+],[],[],[http://documentfoundation.org/])
+AC_INIT([LibreOffice],[6.2.4.2.0+],[],[],[http://documentfoundation.org/])
 
 AC_PREREQ([2.59])
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/tags/libreoffice-6.2.4.2'

2019-05-17 Thread Christian Lohmaier (via logerrit)
Tag 'libreoffice-6.2.4.2' created by Christian Lohmaier 
 at 2019-05-17 15:35 +

Tag libreoffice-6.2.4.2
-BEGIN PGP SIGNATURE-

iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAlze1LcACgkQ9DSh76/u
rqM9tA//Vz9o2BGcKeQtL5mnSWDkh0pLQASGOoW7PXvbFf1KBYeZ/24P5ki+Kyxn
9o14tXroeXOZxdiRV41oc6XSWpfiNVZQQu1fvKzPzo/WsKcD535vG8kbr6w1zUH4
Tw2SE+4T1susGXxD1JRMeUk58ELJ3JzeBCIQMj9pMtjo3OAkrPnAni99+fYety3H
iDR8WvXcJ62wDjo63xNd1H19Ofw0LwbREZ+LpRlaaCBMZDoApKTNy3QYUEFnqomo
QIicVTRSohz9T2nXhdSOL+gJgccHgG+UL03bWu9vBmiel1A2lJQ2Ke+/YnGJV/zO
ToHu7VPkiEdMbImc0CXM5jOB25edJtg8XeeIV0Gpetyo2AeK3LPOryyJ/jGQMmyW
YxupPC8W1JnK9kIsx3CrBqVHX+V83YDQOiC7zbp2US3G0POD34Gnlxvpgz2q5rjU
qumQR73hW8O+dF7rjKL53b+jblvLfkeeGA+3bOmBdU8VEsrJ0rTiRUwdry5Q9DMP
nRX+sAdxqojqG1BTd7fXRHvTBfOqmU5EXZ2G5HFv0PfS2sEfMBLoRhwY5j0gvZNe
gfdG8gBMeRHhJrstdb/GBK7LY57LdjSuWFaAEUCtdPpie3ZKD3qjLC9V/HGFs4TO
HCr2iN+DB5cqUJ1v3kyc609L9UiDTNqWfu2BHnGT++7YpvBzUcA=
=+3pE
-END PGP SIGNATURE-

Changes since libreoffice-6-2-branch-point-1431:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - readlicense_oo/license

2019-05-17 Thread Christian Lohmaier (via logerrit)
 readlicense_oo/license/CREDITS.fodt | 8329 +---
 1 file changed, 4162 insertions(+), 4167 deletions(-)

New commits:
commit 90cf72f8a4988b4978c40d19ec7a4db314b97480
Author: Christian Lohmaier 
AuthorDate: Fri May 17 17:30:38 2019 +0200
Commit: Christian Lohmaier 
CommitDate: Fri May 17 17:31:51 2019 +0200

update credits

Change-Id: I7d712426ff82242fd1a53779ad1e7df6d6fa86d9
(cherry picked from commit b5bc0d40ce55ced3c5019bdce27395e2a4f74454)

diff --git a/readlicense_oo/license/CREDITS.fodt 
b/readlicense_oo/license/CREDITS.fodt
index ad5c69379a8f..dbb04b1ff79e 100644
--- a/readlicense_oo/license/CREDITS.fodt
+++ b/readlicense_oo/license/CREDITS.fodt
@@ -1,10 +1,10 @@
 
 
 http://www.w3.org/1999/xlink; 
xmlns:dc="http://purl.org/dc/elements/1.1/; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" 
xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oas
 is:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:rpt="http://openoffice.org/2005/report; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 
xmlns:officeooo="http://openoffice.org/2009/office; 
xmlns:tableooo="http://openoffice.org/2009/table; 
xmlns:drawooo="http://openoffice.org/2010/draw; 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:formx="urn:openoffice:names:
 experimental:ooxml-odf-interop:xmlns:form:1.0" 
xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" 
office:mimetype="application/vnd.oasis.opendocument.text">
- Credits » 
LibreOfficeCreditscontributorscodersdevelopersCredits
 for the LibreOffice 
development/coding.LibreOffice/6.2.3.2$Linux_X86_64
 
LibreOffice_project/aecc05fe267cc68dde00352a451aa867b3b546ac2012-02-20T22:17:18.06000PT14M12S3JUebjoxEpqXoQcpltWRTwzBZEEHtch3wApdhgiQPFiA
+ Credits » 
LibreOfficeCreditscontributorscodersdevelopersCredits
 for the LibreOffice 
development/coding.LibreOffice/6.2.3.2$Linux_X86_64
 
LibreOffice_project/aecc05fe267cc68dde00352a451aa867b3b546ac2012-02-20T22:17:18.06000PT14M12S3JUebjoxEpqXoQcpltWRTwzBZEEHtch3wApdhgiQPFiA
  
   
-   584
+   552
501
32440
18152
@@ -16,9 +16,9 @@
  3649
  3471
  501
- 584
+ 552
  32939
- 18734
+ 18703
  0
  0
  false
@@ -114,7 +114,7 @@
true
false
true
-   8509381
+   8636398
false
false
false
@@ -325,105 +325,87 @@
  
  
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   

   
-  
+  
+   
+  
+  

   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   

   
-  
+  

   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
-  
-  
-   
+   
   
   

   
-  
+  

   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
-  
-  
-   
-  
-  
-   
-  
-  
-   
-  
-  
-   
-  
-  
-   
+   
   
-  
-   
+  
+   
   
-  
-   
-  
-  
+  

   
-  
+  

   
   
@@ -1059,7 +1041,7 @@

   
  Credits
-1427 individuals contributed to 
OpenOffice.org (and whose contributions were imported into LibreOffice) or 
LibreOffice until 2019-04-25 14:12:30.
+1433 individuals contributed to 
OpenOffice.org (and whose contributions were imported into LibreOffice) or 
LibreOffice until 2019-05-17 11:02:01.
 * marks developers whose first contributions 
happened after 2010-09-28.
 Developers 
committing code since 2010-09-28
 
@@ -1083,16 +1065,16 @@
  
  
   
-   Caolán 
McNamaraCommits: 25940Joined: 
2000-10-10
+   Caolán 
McNamaraCommits: 26036Joined: 
2000-10-10
   
   
Vladimir 
GlazunovCommits: 25434Joined: 
2000-12-04
   
   
-   Stephan 
BergmannCommits: 16926Joined: 
2000-10-04
+   Stephan 
BergmannCommits: 16967Joined: 
2000-10-04
   
   
-   *Noel GrandinCommits: 
11234Joined: 2011-12-12
+   *Noel GrandinCommits: 
11289Joined: 2011-12-12
   
  

[Libreoffice-commits] core.git: readlicense_oo/license

2019-05-17 Thread Christian Lohmaier (via logerrit)
 readlicense_oo/license/CREDITS.fodt | 8329 +---
 1 file changed, 4162 insertions(+), 4167 deletions(-)

New commits:
commit b5bc0d40ce55ced3c5019bdce27395e2a4f74454
Author: Christian Lohmaier 
AuthorDate: Fri May 17 17:30:38 2019 +0200
Commit: Christian Lohmaier 
CommitDate: Fri May 17 17:30:38 2019 +0200

update credits

Change-Id: I7d712426ff82242fd1a53779ad1e7df6d6fa86d9

diff --git a/readlicense_oo/license/CREDITS.fodt 
b/readlicense_oo/license/CREDITS.fodt
index ad5c69379a8f..dbb04b1ff79e 100644
--- a/readlicense_oo/license/CREDITS.fodt
+++ b/readlicense_oo/license/CREDITS.fodt
@@ -1,10 +1,10 @@
 
 
 http://www.w3.org/1999/xlink; 
xmlns:dc="http://purl.org/dc/elements/1.1/; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" 
xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oas
 is:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:rpt="http://openoffice.org/2005/report; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 
xmlns:officeooo="http://openoffice.org/2009/office; 
xmlns:tableooo="http://openoffice.org/2009/table; 
xmlns:drawooo="http://openoffice.org/2010/draw; 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:formx="urn:openoffice:names:
 experimental:ooxml-odf-interop:xmlns:form:1.0" 
xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" 
office:mimetype="application/vnd.oasis.opendocument.text">
- Credits » 
LibreOfficeCreditscontributorscodersdevelopersCredits
 for the LibreOffice 
development/coding.LibreOffice/6.2.3.2$Linux_X86_64
 
LibreOffice_project/aecc05fe267cc68dde00352a451aa867b3b546ac2012-02-20T22:17:18.06000PT14M12S3JUebjoxEpqXoQcpltWRTwzBZEEHtch3wApdhgiQPFiA
+ Credits » 
LibreOfficeCreditscontributorscodersdevelopersCredits
 for the LibreOffice 
development/coding.LibreOffice/6.2.3.2$Linux_X86_64
 
LibreOffice_project/aecc05fe267cc68dde00352a451aa867b3b546ac2012-02-20T22:17:18.06000PT14M12S3JUebjoxEpqXoQcpltWRTwzBZEEHtch3wApdhgiQPFiA
  
   
-   584
+   552
501
32440
18152
@@ -16,9 +16,9 @@
  3649
  3471
  501
- 584
+ 552
  32939
- 18734
+ 18703
  0
  0
  false
@@ -114,7 +114,7 @@
true
false
true
-   8509381
+   8636398
false
false
false
@@ -325,105 +325,87 @@
  
  
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   

   
-  
+  
+   
+  
+  

   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   

   
-  
+  

   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
-  
-  
-   
+   
   
   

   
-  
+  

   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
-  
-  
-   
-  
-  
-   
-  
-  
-   
-  
-  
-   
-  
-  
-   
+   
   
-  
-   
+  
+   
   
-  
-   
-  
-  
+  

   
-  
+  

   
   
@@ -1059,7 +1041,7 @@

   
  Credits
-1427 individuals contributed to 
OpenOffice.org (and whose contributions were imported into LibreOffice) or 
LibreOffice until 2019-04-25 14:12:30.
+1433 individuals contributed to 
OpenOffice.org (and whose contributions were imported into LibreOffice) or 
LibreOffice until 2019-05-17 11:02:01.
 * marks developers whose first contributions 
happened after 2010-09-28.
 Developers 
committing code since 2010-09-28
 
@@ -1083,16 +1065,16 @@
  
  
   
-   Caolán 
McNamaraCommits: 25940Joined: 
2000-10-10
+   Caolán 
McNamaraCommits: 26036Joined: 
2000-10-10
   
   
Vladimir 
GlazunovCommits: 25434Joined: 
2000-12-04
   
   
-   Stephan 
BergmannCommits: 16926Joined: 
2000-10-04
+   Stephan 
BergmannCommits: 16967Joined: 
2000-10-04
   
   
-   *Noel GrandinCommits: 
11234Joined: 2011-12-12
+   *Noel GrandinCommits: 
11289Joined: 2011-12-12
   
  
  
@@ -1100,10 +1082,10 @@
Ivo 
HinkelmannCommits: 

Re: Converting Python Tuples / Lists into Any in PyUNO

2019-05-17 Thread Thorsten Behrens
Stephan Bergmann wrote:
> On 16/05/2019 14:41, Thomas Viehmann wrote:
> > 2. If 1. is yes, would investigating github projects featuring "import
> > uno" and checking whether and how they use "Any" interfaces be an OKish
> > assessment method?
> 
> Lets hope that somebody else with an actual interest in PyUNO steps in for
> the above.
> 
Well mostly a user for that one - that said, perhaps this github
research could inform further discussions (e.g. if we find many
instances, it's probably a non-starter. if we don't, could tip the
balance to do a low-impact cleanup)?

Alternatively, we could consider collecting breaking changes in an
experimental mode, and at some stage pull a 'python2 -> python3' alike
move.

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 122771] Navigator's vertical scroll-bar is no longer exhibited once Navigator's area has been reduced according to the horizontal axis.

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122771

Usama  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||uahe...@gmail.com
 Status|UNCONFIRMED |NEEDINFO
   Severity|normal  |minor

--- Comment #2 from Usama  ---
Hello,
Thank you for reporting this issue. I wasn't able to reproduce it on master
version. Similar issue is present for horizontal scroll-bar in "styles" where
text is cut and no scroll-bar is available but it seems fine for the
"navigator" 
I've created a lot of headers and I could see the scroll-bar. 

Is it possible for you to check the issue using the latest version from master?

For Linux you can find an Appimage version here:
https://www.libreoffice.org/download/appimage/
For Windows:
https://dev-builds.libreoffice.org/daily/master/Win-x86@42/current/
If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

I'm setting the bug status to NEEDINFO, Please set it to UNCONFIRMED again
after providing the requested data.

You can always visit our QA channel #libreoffice-qa@freenode if you need help
with bugs
https://irc.documentfoundation.org/?settings=#libreoffice-qa


Version: 6.3.0.0.alpha0+
Build ID: 98630a0bd49bd80652145a21e4e0d0ded792b36b
CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2019-05-04_04:44:35
Locale: tr-TR (tr_TR.UTF-8); UI-Language: en-US
Calc: threaded


Version: 6.3.0.0.alpha1+
Build ID: 31cc28ca7c02f28b64e9d757c9fc17e2a81ba352
CPU threads: 1; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-05-15_04:21:42
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 119810] Base Reports: Ruler-Margin Landscape Mode Wrong

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119810

teckn...@cts.com changed:

   What|Removed |Added

Version|6.1.0.0.alpha0+ |6.2.3.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: minutes of ESC call ...

2019-05-17 Thread Thorsten Behrens
Stephan Bergmann wrote:
> Whenever I recently happened to look at Gerrit/Jenkins builds that
> hadn't finished yet, it was the Mac build that was still
> outstanding, so I think we do have a bottleneck there after all.
>
Yeah, same anecdotal evidence here. Is the assumption we don't need
more Mac build power based on hard data?

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 122691] Export full tooltip for footnote number to PDF

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122691

Usama  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1
 CC||uahe...@gmail.com

--- Comment #1 from Usama  ---
Thank you for reporting this issue. I had the same experience you had but only
with Evnice the default PDF viewer for Ubuntu.
I've tried using Acrobat reader, Sumatra PDF and Firefox internal PDF viewer
none of them showed any tooltip when hovering above the footnote reference. Are
you using Windows? What is your PDF viewer.

That is for the first part, However I personally believe that Libreoffice
should support tooltip.

For now I'm setting the bug status to NEEDINFO, Please set it to UNCONFIRMED
again after providing the requested info.

If you have time, please check the latest version from master, you can find an
Appimage version here for Linux: https://www.libreoffice.org/download/appimage/
For Windows:
https://dev-builds.libreoffice.org/daily/master/Win-x86@42/current/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

You can always visit our QA channel #libreoffice-qa@freenode if you need help
with bugs
https://irc.documentfoundation.org/?settings=#libreoffice-qa


Version: 6.3.0.0.alpha0+
Build ID: 98630a0bd49bd80652145a21e4e0d0ded792b36b
CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2019-05-04_04:44:35
Locale: en-US (tr_TR.UTF-8); UI-Language: en-US
Calc: threaded

And Windows:

Version: 6.3.0.0.alpha1+
Build ID: 31cc28ca7c02f28b64e9d757c9fc17e2a81ba352
CPU threads: 1; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-05-15_04:21:42
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Update of file oox-drawingml-cs-presets

2019-05-17 Thread Regina Henschel

Hi all,

to fix https://bugs.documentfoundation.org/show_bug.cgi?id=125181 it is 
needed to correct the file 
oox/source/drawingml/customshapes/presetShapeDefinitions.xml. But in 
addition the script oox/source/drawingml/customshapes/README needs to 
run for to generate an updated version of oox-drawingml-cs-presets. This 
script re-generates a lot of other files in addition.


Do I need to include all changed files into the patch? Or is the change 
to presetShapeDefinitions.xml sufficient and there is a way to run the 
script afterwards?


Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - vcl/source

2019-05-17 Thread Caolán McNamara (via logerrit)
 vcl/source/app/salvtables.cxx |   12 
 1 file changed, 12 insertions(+)

New commits:
commit e4576e3da166b97c5c5b2d72903d51bddc04780f
Author: Caolán McNamara 
AuthorDate: Fri May 17 09:38:06 2019 +0100
Commit: Caolán McNamara 
CommitDate: Fri May 17 16:46:36 2019 +0200

tdf#125241 SvTreeListBox has a separate SetUpdateMode

so just Window:SetUpdateMode was called, not also
SvTreeListBox::SetUpdateMode

Change-Id: I37a91f8aff6e8a2399cb7cacfcdc6b3f8b1f44ab
Reviewed-on: https://gerrit.libreoffice.org/72451
Reviewed-by: Michael Stahl 
Tested-by: Jenkins

diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index 0f925613ac8e..afb51ee80791 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -1898,6 +1898,18 @@ public:
 m_aRadioButtonData.SetLink(LINK(this, SalInstanceTreeView, ToggleHdl));
 }
 
+virtual void freeze() override
+{
+SalInstanceWidget::freeze();
+m_xTreeView->SetUpdateMode(false);
+}
+
+virtual void thaw() override
+{
+m_xTreeView->SetUpdateMode(true);
+SalInstanceWidget::thaw();
+}
+
 virtual void set_column_fixed_widths(const std::vector& rWidths) 
override
 {
 std::vector aTabPositions;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 125104] Changing page numbering to "1st, 2nd, 3rd, ..." causes crashes when trying to change Page settings later ( see comment 26 )

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125104

Caolán McNamara  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124906] iPad Hardware-Keyboard in iOS App: Characters appear twice

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124906

--- Comment #5 from Tor Lillqvist  ---
First attempt at fix at https://gerrit.libreoffice.org/#/c/72486/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125342] Excel 5.0/95 XLS File shows messy code in Calc

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125342

--- Comment #2 from Kevin Suo  ---
Created attachment 151488
  --> https://bugs.documentfoundation.org/attachment.cgi?id=151488=edit
Bug result in Calc

The cell values are in messy code. However, I noticed that the name of the tab
is showing correct Chinese chars.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 120950] kde4, kde5, gtk3_kde5: Filter "Office Open XML" in fpicker sometimes not applied instantly

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120950

Jan-Marek Glogowski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||5267

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125342] Excel 5.0/95 XLS File shows messy code in Calc

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125342

--- Comment #1 from Kevin Suo  ---
Created attachment 151487
  --> https://bugs.documentfoundation.org/attachment.cgi?id=151487=edit
Expected result screenshot (in MS Excel)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 120950] kde4, kde5, gtk3_kde5: Filter "Office Open XML" in fpicker sometimes not applied instantly

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120950

--- Comment #3 from Jan-Marek Glogowski  ---
I've created https://bugs.kde.org/show_bug.cgi?id=407642 to fix it upstream.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125343] New: Presentation restarts after reconnecting external display

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125343

Bug ID: 125343
   Summary: Presentation restarts after reconnecting external
display
   Product: LibreOffice
   Version: 6.2.3.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kont...@kuba-orlik.name

While presenting, every time I disconnect and then re-connect the external
display/projector, the presentation resets to the first slide. I'd expect it to
not do that and just let me continue with my presentation

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125342] New: Excel 5.0/95 XLS File shows messy code in Calc

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125342

Bug ID: 125342
   Summary: Excel 5.0/95 XLS File shows messy code in Calc
   Product: LibreOffice
   Version: 6.3.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: suokunl...@126.com

Created attachment 151486
  --> https://bugs.documentfoundation.org/attachment.cgi?id=151486=edit
Test XLS file

Calc shows messy code when open the attached xls file.

This file was from an Financial Accounting ERP system, with confidential
information removed in MS Excel.

The expected cell values are in Simplified Chinese chars, so you need to
install at least one Chinese fonts (e.g., Source Han Sans CJK SC or Noto Sans
CJK SC).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 125280] Footer can not be made to appear only on the first page after it has been filled with content

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125280

--- Comment #12 from Regina Henschel  ---
(In reply to Adalbert Hanßen from comment #11)

> Then I followed your second link to the draft 1.3, i.e. to
> https://www.oasis-open.org/committees/documents.php?wg_abbrev=office. This
> one shows me a table of 10 documents. They contain links to some
> OpenDocument-v1.3-*part*.odt, but the part numbers go beyond the range 1...3

The numbering will change from ODF 1.2 to ODF 1.3.

> and the low numbers are missing. Is there something similar to the ZIP-file
> OpenDocument-v1.2-os.zip (of course, the version 1.3 and perhaps draft and
> the date or a subversion number in it)?

No zip. They are working drafts of the committee.
For header/footer topic you need 'part 3'. 'part 4' contains the formula
language for Calc. "production" in the file name means, that it is a version
without change tracking. Take that with highest wd-number in the filename.

Sent me a mail, in case you need help getting it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 123992] [l10n] Use separate strings for menu items and icon tooltips

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123992

--- Comment #5 from Ming Hua  ---
So I tried the keyID feature in 6.3.0 alpha1, and both the "File -> Open..."
menu item and the open icon tooltip has the keyID EKctU.  I assume this
confirms that they are using the same translation.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: officecfg/registry

2019-05-17 Thread Stephan Bergmann (via logerrit)
 officecfg/registry/schema/org/openoffice/Setup.xcs |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 7fcbb0a9115c3e125578dcd3c88c410a9c4aff08
Author: Stephan Bergmann 
AuthorDate: Fri May 17 11:02:01 2019 +0200
Commit: Stephan Bergmann 
CommitDate: Fri May 17 16:30:25 2019 +0200

Remove spurious trailing whitespace

...introduced with 5187d3ae495a07373a12fd5980c9269bc8ce3f8f "Resolves: 
tdf#69042
- Add a 'What's New' infobar"

Change-Id: I7ffa28e996838e681d1ecc317b9c3af56f74bc5a
Reviewed-on: https://gerrit.libreoffice.org/72454
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/officecfg/registry/schema/org/openoffice/Setup.xcs 
b/officecfg/registry/schema/org/openoffice/Setup.xcs
index 34bca3e15c5e..9d93e7eb6a64 100644
--- a/officecfg/registry/schema/org/openoffice/Setup.xcs
+++ b/officecfg/registry/schema/org/openoffice/Setup.xcs
@@ -262,7 +262,7 @@
   
   
 
-  Specifies the version number of the previously used product 
for 
+  Specifies the version number of the previously used product for
   whats-new comparison.
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 125280] Footer can not be made to appear only on the first page after it has been filled with content

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125280

--- Comment #12 from Regina Henschel  ---
(In reply to Adalbert Hanßen from comment #11)

> Then I followed your second link to the draft 1.3, i.e. to
> https://www.oasis-open.org/committees/documents.php?wg_abbrev=office. This
> one shows me a table of 10 documents. They contain links to some
> OpenDocument-v1.3-*part*.odt, but the part numbers go beyond the range 1...3

The numbering will change from ODF 1.2 to ODF 1.3.

> and the low numbers are missing. Is there something similar to the ZIP-file
> OpenDocument-v1.2-os.zip (of course, the version 1.3 and perhaps draft and
> the date or a subversion number in it)?

No zip. They are working drafts of the committee.
For header/footer topic you need 'part 3'. 'part 4' contains the formula
language for Calc. "production" in the file name means, that it is a version
without change tracking. Take that with highest wd-number in the filename.

Sent me a mail, in case you need help getting it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - shell/source

2019-05-17 Thread Mike Kaganski (via logerrit)
 shell/source/win32/spsupp/res/spsupp.rc |   13 -
 1 file changed, 12 insertions(+), 1 deletion(-)

New commits:
commit 59c4940c4f1eff1cec3e58e0fe3b926b6547256e
Author: Mike Kaganski 
AuthorDate: Fri May 17 14:39:04 2019 +0200
Commit: Mike Kaganski 
CommitDate: Fri May 17 16:25:52 2019 +0200

Add license statement

Change-Id: Ib7ed7b3d94c04c09debe910a76cd720802f1a6f6
Reviewed-on: https://gerrit.libreoffice.org/72475
Reviewed-by: Mike Kaganski 
Tested-by: Mike Kaganski 
(cherry picked from commit fa7412039f7d89a9b15aeabb99b0f5380b690cfa)
Reviewed-on: https://gerrit.libreoffice.org/72484

diff --git a/shell/source/win32/spsupp/res/spsupp.rc 
b/shell/source/win32/spsupp/res/spsupp.rc
index c7f62aeb24e3..20e323e16a7b 100644
--- a/shell/source/win32/spsupp/res/spsupp.rc
+++ b/shell/source/win32/spsupp/res/spsupp.rc
@@ -1 +1,12 @@
-1 TYPELIB TLB_FILE
\ No newline at end of file
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+* This file is part of the LibreOffice project.
+*
+* This Source Code Form is subject to the terms of the Mozilla Public
+* License, v. 2.0. If a copy of the MPL was not distributed with this
+* file, You can obtain one at http://mozilla.org/MPL/2.0/.
+*/
+
+// Type library
+
+1 TYPELIB TLB_FILE
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: shell/source

2019-05-17 Thread Mike Kaganski (via logerrit)
 shell/source/win32/spsupp/res/spsupp.rc |   13 -
 1 file changed, 12 insertions(+), 1 deletion(-)

New commits:
commit fa7412039f7d89a9b15aeabb99b0f5380b690cfa
Author: Mike Kaganski 
AuthorDate: Fri May 17 14:39:04 2019 +0200
Commit: Mike Kaganski 
CommitDate: Fri May 17 16:25:12 2019 +0200

Add license statement

Change-Id: Ib7ed7b3d94c04c09debe910a76cd720802f1a6f6
Reviewed-on: https://gerrit.libreoffice.org/72475
Reviewed-by: Mike Kaganski 
Tested-by: Mike Kaganski 

diff --git a/shell/source/win32/spsupp/res/spsupp.rc 
b/shell/source/win32/spsupp/res/spsupp.rc
index c7f62aeb24e3..20e323e16a7b 100644
--- a/shell/source/win32/spsupp/res/spsupp.rc
+++ b/shell/source/win32/spsupp/res/spsupp.rc
@@ -1 +1,12 @@
-1 TYPELIB TLB_FILE
\ No newline at end of file
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+* This file is part of the LibreOffice project.
+*
+* This Source Code Form is subject to the terms of the Mozilla Public
+* License, v. 2.0. If a copy of the MPL was not distributed with this
+* file, You can obtain one at http://mozilla.org/MPL/2.0/.
+*/
+
+// Type library
+
+1 TYPELIB TLB_FILE
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2-4' - translations

2019-05-17 Thread Christian Lohmaier (via logerrit)
 translations |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a0a8351ab8582ec891df51ecee6bba3d591873dd
Author: Christian Lohmaier 
AuthorDate: Fri May 17 15:46:44 2019 +0200
Commit: Gerrit Code Review 
CommitDate: Fri May 17 16:09:04 2019 +0200

Update git submodules

* Update translations from branch 'libreoffice-6-2-4'
  - update translations for 6.2.4 rc2

and force-fix errors using pocheck

Change-Id: Ic143bd8070d7f8ef2c46265a88cfc215717c807c
(cherry picked from commit b4ac8d65832ab402e449f0e294bb3f09c4095fef)

diff --git a/translations b/translations
index 4e36c4799930..9214024f80f5 16
--- a/translations
+++ b/translations
@@ -1 +1 @@
-Subproject commit 4e36c4799930dc79470dd5d69a351d08fda298eb
+Subproject commit 9214024f80f56375207f34282b51c595166d72c2
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - translations

2019-05-17 Thread Christian Lohmaier (via logerrit)
 translations |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a894e2307a277e05cc9631e5871a3e86b96fd5ea
Author: Christian Lohmaier 
AuthorDate: Fri May 17 15:46:44 2019 +0200
Commit: Gerrit Code Review 
CommitDate: Fri May 17 16:07:59 2019 +0200

Update git submodules

* Update translations from branch 'libreoffice-6-2'
  - update translations for 6.2.4 rc2

and force-fix errors using pocheck

Change-Id: Ic143bd8070d7f8ef2c46265a88cfc215717c807c

diff --git a/translations b/translations
index a53a97b84749..b4ac8d65832a 16
--- a/translations
+++ b/translations
@@ -1 +1 @@
-Subproject commit a53a97b84749dda48d6796989fdaf21ad16afd4d
+Subproject commit b4ac8d65832ab402e449f0e294bb3f09c4095fef
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 108551] mis-positioned laser dot on external screen (?)

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108551

--- Comment #9 from ira nikjonas  ---
Thanks for this information. It really helpful for me.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-4-0' - loleaflet/src

2019-05-17 Thread Libreoffice Gerrit user
 loleaflet/src/layer/tile/TileLayer.js |   10 ++
 1 file changed, 10 insertions(+)

New commits:
commit 5a160ba0c0504f65bdfb3b0def9f39637b8b7e4b
Author: Jan Holesovsky 
AuthorDate: Fri May 17 13:42:00 2019 +0200
Commit: Michael Meeks 
CommitDate: Fri May 17 15:50:07 2019 +0200

Prefer HTML over RTF for pasting on the Mac.

Safari provides RTF clipboard content which doesn't contain the images.
We do not know where the content comes from, so let's always prefer HTML
over RTF on Mac.

Change-Id: I2f449ff4cf025e5f51dbe6e0683667f2d319ac21
Reviewed-on: https://gerrit.libreoffice.org/72461
Reviewed-by: Michael Meeks 
Tested-by: Michael Meeks 
(cherry picked from commit 2998ab914e057d5c9bae3e3b03c0cf5f13e531b9)
Reviewed-on: https://gerrit.libreoffice.org/72480

diff --git a/loleaflet/src/layer/tile/TileLayer.js 
b/loleaflet/src/layer/tile/TileLayer.js
index f39102829..00759ca65 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -2384,6 +2384,16 @@ L.TileLayer = L.GridLayer.extend({
['text/plain', 'text/plain;charset=utf-8'],
['Text', 'text/plain;charset=utf-8']
];
+   } else if (navigator.platform.startsWith('Mac')) {
+   // Safari provides RTF clipboard content which doesn't 
contain the
+   // images.  We do not know where the content comes 
from, so let's
+   // always prefer HTML over RTF on Mac.
+   mimeTypes = [
+   ['text/html', 'text/html'],
+   ['text/rtf', 'text/rtf'],
+   ['text/plain', 'text/plain;charset=utf-8'],
+   ['Text', 'text/plain;charset=utf-8']
+   ];
} else {
mimeTypes = [
['text/rtf', 'text/rtf'],
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103182

Xisco Faulí  changed:

   What|Removed |Added

 Depends on||125340


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=125340
[Bug 125340] CRASH: closing LibreOffice while migration dialog is open ( GTK3 )
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122615] Envelope address does not go down enough

2019-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122615

--- Comment #10 from Usama  ---
I wish you could solve your issue and get a happy experience using LibreOffice
but bug triaging and fix release for accepted bugs may take sometime. 

I suggest you ask your question in https://ask.libreoffice.org/
There you could get a solution for your issue or a workaround. 

You may also want to check LibreOffice Telegram channel to get help from the
community https://telegram.me/libreoffice

As I told you if you could export the PDF correctly then IMHO the issue could
be limited to printer configuration. Hope someone could step in and investigate
it further.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

  1   2   3   >