[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - external/cairo
external/cairo/UnpackedTarball_cairo.mk |1
external/cairo/cairo/cairo.oldfreetype.patch | 78 +++
2 files changed, 79 insertions(+)
New commits:
commit 124379909d9aedc8bbf1b5f4e9e9c13f7302ef1d
Author: Andras Timar
AuthorDate: Fri Jul 5 23:31:29 2019 +0200
Commit: Andras Timar
CommitDate: Sat Jul 6 07:56:26 2019 +0200
fix build of internal cairo with old freetype (CentOS 6)
Change-Id: I7e816a5325e00e49d4c467d3a5d65f379cd9b372
Reviewed-on: https://gerrit.libreoffice.org/75148
Reviewed-by: Andras Timar
Tested-by: Andras Timar
diff --git a/external/cairo/UnpackedTarball_cairo.mk
b/external/cairo/UnpackedTarball_cairo.mk
index 895950a58301..b260446edf8f 100644
--- a/external/cairo/UnpackedTarball_cairo.mk
+++ b/external/cairo/UnpackedTarball_cairo.mk
@@ -13,6 +13,7 @@ $(eval $(call
gb_UnpackedTarball_set_tarball,cairo,$(CAIRO_TARBALL),,cairo))
$(eval $(call gb_UnpackedTarball_add_patches,cairo,\
external/cairo/cairo/cairo-1.10.2.patch \
+ external/cairo/cairo/cairo.oldfreetype.patch \
))
ifeq ($(OS),iOS)
diff --git a/external/cairo/cairo/cairo.oldfreetype.patch
b/external/cairo/cairo/cairo.oldfreetype.patch
new file mode 100644
index ..d994dd5f4b1b
--- /dev/null
+++ b/external/cairo/cairo/cairo.oldfreetype.patch
@@ -0,0 +1,78 @@
+From c0ed8ce1a111cb9472aef080ac3aa31526443f7c Mon Sep 17 00:00:00 2001
+From: suzuki toshiya
+Date: Thu, 13 Dec 2018 14:36:56 +0900
+Subject: [PATCH] [cairo-ft-font.c] conditionalize the changes by 3ec4aa24 on
2018-07-16 for legacy FreeType2 without color font feature
+
+---
+ src/cairo-ft-font.c | 10 ++
+ 1 files changed, 10 insertions(+), 0 deletions(-)
+
+diff --git a/src/cairo-ft-font.c b/src/cairo-ft-font.c
+index 325dd61..1841adb 100644
+--- misc/a/src/cairo-ft-font.c
misc/b/src/cairo-ft-font.c
+@@ -976,10 +976,12 @@ _compute_xrender_bitmap_size(FT_Bitmap *target,
+ pitch = width * 4;
+ break;
+
++#ifdef FT_PIXEL_MODE_BGRA
+ case FT_PIXEL_MODE_BGRA:
+ /* each pixel is replicated into a 32-bit ARGB value */
+ pitch = width * 4;
+ break;
++#endif
+
+ default: /* unsupported source format */
+ return -1;
+@@ -1177,10 +1179,12 @@ _fill_xrender_bitmap(FT_Bitmap *target,
+ }
+ break;
+
++#ifdef FT_PIXEL_MODE_BGRA
+ case FT_PIXEL_MODE_BGRA:
+ for (h = height; h > 0; h--, srcLine += src_pitch, dstLine += pitch)
+ memcpy (dstLine, srcLine, width * 4);
+ break;
++#endif
+
+ default:
+ assert (0);
+@@ -1289,6 +1293,7 @@ _get_bitmap_surface (FT_Bitmap*bitmap,
+ component_alpha = TRUE;
+ }
+ break;
++#ifdef FT_PIXEL_MODE_BGRA
+ case FT_PIXEL_MODE_BGRA:
+ stride = width * 4;
+ if (own_buffer) {
+@@ -1311,6 +1316,7 @@ _get_bitmap_surface (FT_Bitmap*bitmap,
+ }
+ format = CAIRO_FORMAT_ARGB32;
+ break;
++#endif
+ case FT_PIXEL_MODE_GRAY2:
+ case FT_PIXEL_MODE_GRAY4:
+ convert:
+@@ -2487,7 +2493,9 @@ _cairo_ft_scaled_glyph_init (void
*abstract_font,
+ vertical_layout = TRUE;
+ }
+
++#ifdef FT_LOAD_COLOR
+ load_flags |= FT_LOAD_COLOR;
++#endif
+
+
+ if (info & CAIRO_SCALED_GLYPH_INFO_METRICS) {
+@@ -2656,7 +2664,9 @@ LOAD:
+ */
+ scaled_glyph_loaded = FALSE;
+ info &= ~CAIRO_SCALED_GLYPH_INFO_METRICS;
++#ifdef FT_LOAD_COLOR
+ load_flags &= ~FT_LOAD_COLOR;
++#endif
+ goto LOAD;
+ }
+
+--
+1.7.1
+
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 126147] Inserting graphics with type TIFF *.tif
https://bugs.documentfoundation.org/show_bug.cgi?id=126147 Aron Budea changed: What|Removed |Added Keywords|bibisectRequest |bibisected, bisected CC||caol...@redhat.com Version|6.1.0.3 release |5.1.0.3 release --- Comment #3 from Aron Budea --- Bibisected to the following commit using repo bibisect-win32-5.1. Adding Cc: to Caolán McNamara. However, I'd say there's something wrong with the file, the size is 1700x2800, which corresponds to the byte size, however there's a header, which results in a 192-byte offset, and those 192 bytes are missing at the end. Windows shows a preview of the file, but XnView fails to open it. https://cgit.freedesktop.org/libreoffice/core/commit/?id=97a0e7558b24792827d77217fb2d8b1106056963 author Caolán McNamara 2015-07-20 12:28:03 +0100 committer Caolán McNamara 2015-07-20 12:30:28 +0100 bail if offsets are past eof -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108010] Remote Files dialog is not showing files/directories containing non-latin characters when browsing WebDAV server
https://bugs.documentfoundation.org/show_bug.cgi?id=108010 Aron Budea changed: What|Removed |Added Summary|Remote Files dialog is not |Remote Files dialog is not |showing files/directories |showing files/directories |containing non-latin|containing non-latin |characters when browsing|characters when browsing |WebDAV servers |WebDAV server -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108010] Remote Files dialog is not showing files/directories containing non-latin characters when browsing WebDAV servers
https://bugs.documentfoundation.org/show_bug.cgi?id=108010 Aron Budea changed: What|Removed |Added Summary|WebDAV browser is not |Remote Files dialog is not |showing files/directories |showing files/directories |containing non-latin|containing non-latin |characters |characters when browsing ||WebDAV servers -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108010] WebDAV browser is not showing files/directories containing non-latin characters
https://bugs.documentfoundation.org/show_bug.cgi?id=108010 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||8009 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108009] Can't save new file to WebDAV server via Save Remote
https://bugs.documentfoundation.org/show_bug.cgi?id=108009 Aron Budea changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Summary|Can't save new file to |Can't save new file to |WebDAV server |WebDAV server via Save ||Remote See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||8010 CC||ba...@caesar.elte.hu --- Comment #8 from Aron Budea --- Confirmed in LO 6.3 beta2 / Windows 7. Similarly to bug 108010 this only occurs in the Remote Files dialog. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'private/EL-SHREIF/ui_logger' - uitest/ui_logger_dsl vcl/source
uitest/ui_logger_dsl/UI_Object_commands.tx |6 -
uitest/ui_logger_dsl/dsl_core.py | 161 -
vcl/source/uitest/uiobject.cxx |3
3 files changed, 165 insertions(+), 5 deletions(-)
New commits:
commit 58eabef2d605984d2e13c1d7faeb6ea9faaf7466
Author: Ahmed ElShreif
AuthorDate: Sat Jul 6 05:23:08 2019 +0200
Commit: Ahmed ElShreif
CommitDate: Sat Jul 6 05:23:08 2019 +0200
This Commit is implementation of the Compiler of these items:
1) ButtonUIObject
2) CheckBoxUIObject
3) TabControlUIObject
4) ComboBoxUIObject
5) RadioButtonUIObject
6) ListBoxUIObject
7) SpinFieldUIObject
8) EditUIObject
Change-Id: Ic81c2a0511351cf91f4514316b9c5854a64a4b05
diff --git a/uitest/ui_logger_dsl/UI_Object_commands.tx
b/uitest/ui_logger_dsl/UI_Object_commands.tx
index 58339e6c752f..03bb0f78ded1 100644
--- a/uitest/ui_logger_dsl/UI_Object_commands.tx
+++ b/uitest/ui_logger_dsl/UI_Object_commands.tx
@@ -31,7 +31,7 @@ ComboBoxUIObject:
'Select in' Combo_box_id=STRING 'ComboBox' 'item number' item_num=INT
'from' parent_id=ID
;
TabControlUIObject:
- 'Choose Tab number' tab_page_number=INT 'from' parent_id=ID
+ 'Choose Tab number' tab_page_number=INT 'in' tab_id=STRING 'from'
parent_id=ID
;
EditUIObject:
@@ -41,7 +41,7 @@ SpinFieldUIObject:
change=increase_or_ecrease Spin_id=STRING 'from' parent_id=ID
;
ListBoxUIObject:
- 'Select element with position ' POS=INT 'in' list=STRING 'from'
parent_id=ID
+ 'Select element with position ' POS=INT 'in' list_id=STRING 'from'
parent_id=ID
;
//==
SpinUIObject:
@@ -59,7 +59,7 @@ Type_action:
;
SELECT:
'Select in ' edit_button=STRING
- '{"FROM": "' from=INT '", "' To=INT '": "0"}'
+ '{"FROM": "' from_pos=INT '" , "TO" : "'to_pos=INT '"}'
;
Clear:
'Clear' edit_button=STRING
diff --git a/uitest/ui_logger_dsl/dsl_core.py b/uitest/ui_logger_dsl/dsl_core.py
index 94dc4c8b716e..6f04762cc96e 100644
--- a/uitest/ui_logger_dsl/dsl_core.py
+++ b/uitest/ui_logger_dsl/dsl_core.py
@@ -24,6 +24,7 @@ def parse_args():
class ul_Compiler:
variables=[]
+objects = dict()
def __init__(self , input_address , output_address):
self.ui_dsl_mm = metamodel_from_file('ui_logger_dsl_grammar.tx')
self.output_stream=self.initiate_test_generation(output_address)
@@ -65,6 +66,14 @@ class ul_Compiler:
'CloseDialog': self.handle_Dialog,
'OpenModelessDialog': self.handle_Dialog,
'OpenModalDialog':self.handle_Dialog,
+'ButtonUIObject':self.handle_button,
+'CheckBoxUIObject':self.handle_check_box,
+'TabControlUIObject':self.handle_tab,
+'ComboBoxUIObject':self.handle_Combo_box,
+'RadioButtonUIObject':self.handle_Radio_button,
+'ListBoxUIObject':self.handle_List_box,
+'SpinFieldUIObject':self.handle_spin_field,
+'EditUIObject':self.handle_Edit_uiObject,
})
self.log_lines=self.get_log_file(self.input_address)
@@ -119,6 +128,156 @@ class ul_Compiler:
self.variables.append(line)
+def handle_button(self, ButtonUIObject):
+
+if ButtonUIObject.ui_button in self.objects:
+self.objects[ButtonUIObject.ui_button]+=1
+else:
+self.objects[ButtonUIObject.ui_button]=1
+line="\t\t"+ButtonUIObject.ui_button+" =
"+ButtonUIObject.parent_id+\
+".getChild(\""+ButtonUIObject.ui_button+"\")\n"
+self.variables.append(line)
+
+
line="\t\t"+ButtonUIObject.ui_button+".executeAction(\"CLICK\",tuple())\n"
+self.variables.append(line)
+
+def handle_check_box(self, CheckBoxUIObject):
+
+if CheckBoxUIObject.Check_box_id in self.objects:
+self.objects[CheckBoxUIObject.Check_box_id]+=1
+else:
+self.objects[CheckBoxUIObject.Check_box_id]=1
+line="\t\t"+CheckBoxUIObject.Check_box_id+" =
"+CheckBoxUIObject.parent_id+\
+".getChild(\""+CheckBoxUIObject.Check_box_id+"\")\n"
+self.variables.append(line)
+
+
line="\t\t"+CheckBoxUIObject.Check_box_id+".executeAction(\"CLICK\",tuple())\n"
+self.variables.append(line)
+
+def handle_tab(self, TabControlUIObject):
+
+if TabControlUIObject.tab_id in self.objects:
+self.objects[TabControlUIObject.tab_id]+=1
+else:
+self.objects[TabControlUIObject.tab_id]=1
+line="\t\t"+TabControlUIObject.tab_id+" =
"+TabControlUIObject.parent_id+\
+".getChild(\""+TabControlUIObject.tab_id+"\")\n"
+self.variables.append(line)
+
+line="\t\t"+TabControlUIObject.tab_id+\
+".executeAction(\"SELECT\",
[Libreoffice-bugs] [Bug 126246] Silent crash without the document recovery dialog notice
https://bugs.documentfoundation.org/show_bug.cgi?id=126246 --- Comment #6 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126045] Media player drawing glitch at progress bar after pressing play
https://bugs.documentfoundation.org/show_bug.cgi?id=126045 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126037] Last modified time is not reset on Action_Save request
https://bugs.documentfoundation.org/show_bug.cgi?id=126037 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126046] Media player doesn't respect aspect ratio of video; it's fit to mediaplayer window
https://bugs.documentfoundation.org/show_bug.cgi?id=126046 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125390] Gtk3 theme settings with small sizes for scrollbars make them unusable
https://bugs.documentfoundation.org/show_bug.cgi?id=125390 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126246] Silent crash without the document recovery dialog notice
https://bugs.documentfoundation.org/show_bug.cgi?id=126246 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117201] MediaWiki fails to login
https://bugs.documentfoundation.org/show_bug.cgi?id=117201 --- Comment #6 from QA Administrators --- Dear lukiluki123, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125390] Gtk3 theme settings with small sizes for scrollbars make them unusable
https://bugs.documentfoundation.org/show_bug.cgi?id=125390 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90933] EDITING Moving a image with key board, changes positions relative to settings
https://bugs.documentfoundation.org/show_bug.cgi?id=90933 --- Comment #5 from QA Administrators --- Dear Cor Nouws, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107304] FILEOPEN OTT: Slow file-opening
https://bugs.documentfoundation.org/show_bug.cgi?id=107304 --- Comment #7 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107376] Displaying false preview when using pptx files.
https://bugs.documentfoundation.org/show_bug.cgi?id=107376 --- Comment #8 from QA Administrators --- Dear Philipp Petschner, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103533] Fileopen dump with specific XLSX, no recovery window (svxcorelo.dll)
https://bugs.documentfoundation.org/show_bug.cgi?id=103533 --- Comment #10 from QA Administrators --- Dear Timur, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/qa vcl/qa
sc/qa/unit/helper/qahelper.cxx |8
sc/qa/unit/helper/qahelper.hxx |4
sc/qa/unit/subsequent_export-test.cxx | 17 ++---
vcl/qa/cppunit/pdfexport/pdfexport.cxx |3 +++
4 files changed, 21 insertions(+), 11 deletions(-)
New commits:
commit a2c665e4dd73007fe7f0eda2de31db8b768f1df9
Author: Jan-Marek Glogowski
AuthorDate: Sat Jul 6 01:36:57 2019 +0200
Commit: Jan-Marek Glogowski
CommitDate: Sat Jul 6 04:30:25 2019 +0200
WIN fix some unit tests more generally
Fixes regressed unit test failures from commit 3f7e8ddea89f ("Enable
many more unit tests on all archs").
Change-Id: I76a8f7560675b9be3765237f8368d05cff22591d
Reviewed-on: https://gerrit.libreoffice.org/75155
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
diff --git a/sc/qa/unit/helper/qahelper.cxx b/sc/qa/unit/helper/qahelper.cxx
index b38dcdfac161..c5f183161a78 100644
--- a/sc/qa/unit/helper/qahelper.cxx
+++ b/sc/qa/unit/helper/qahelper.cxx
@@ -405,8 +405,6 @@ ScRangeList getChartRanges(ScDocument& rDoc, const
SdrOle2Obj& rChartObj)
return aRanges;
}
-namespace {
-
ScTokenArray* getTokens(ScDocument& rDoc, const ScAddress& rPos)
{
ScFormulaCell* pCell = rDoc.GetFormulaCell(rPos);
@@ -420,8 +418,6 @@ ScTokenArray* getTokens(ScDocument& rDoc, const ScAddress&
rPos)
return pCell->GetCode();
}
-}
-
bool checkFormula(ScDocument& rDoc, const ScAddress& rPos, const char*
pExpected)
{
ScTokenArray* pCode = getTokens(rDoc, rPos);
@@ -778,15 +774,11 @@ void ScBootstrapFixture::miscRowHeightsTest( TestParam
const * aTestValues, unsi
}
}
-namespace {
-
std::string to_std_string(const OUString& rStr)
{
return std::string(rStr.toUtf8().getStr());
}
-}
-
void checkFormula(ScDocument& rDoc, const ScAddress& rPos, const char*
expected, const char* msg, CppUnit::SourceLine const & sourceLine)
{
ScTokenArray* pCode = getTokens(rDoc, rPos);
diff --git a/sc/qa/unit/helper/qahelper.hxx b/sc/qa/unit/helper/qahelper.hxx
index 671b3bdcad1b..d0ad00b258d7 100644
--- a/sc/qa/unit/helper/qahelper.hxx
+++ b/sc/qa/unit/helper/qahelper.hxx
@@ -219,6 +219,10 @@ SCQAHELPER_DLLPUBLIC void checkFormula(ScDocument& rDoc,
const ScAddress& rPos,
SCQAHELPER_DLLPUBLIC void testFormats(ScBootstrapFixture* pTest, ScDocument*
pDoc, sal_Int32 nFormat);
+SCQAHELPER_DLLPUBLIC ScTokenArray* getTokens(ScDocument& rDoc, const
ScAddress& rPos);
+
+SCQAHELPER_DLLPUBLIC std::string to_std_string(const OUString& rStr);
+
#endif
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/qa/unit/subsequent_export-test.cxx
b/sc/qa/unit/subsequent_export-test.cxx
index 462320794754..473be4c8593b 100644
--- a/sc/qa/unit/subsequent_export-test.cxx
+++ b/sc/qa/unit/subsequent_export-test.cxx
@@ -3223,11 +3223,22 @@ void ScExportTest::testSupBookVirtualPathXLS()
ScDocument& rDoc = xDocSh->GetDocument();
+ScAddress aPos(0,0,0);
+ScTokenArray* pCode = getTokens(rDoc, aPos);
+if (!pCode)
+CppUnit::Asserter::fail("empty token array", CPPUNIT_SOURCELINE());
+
+OUString aFormula = toString(rDoc, aPos, *pCode, rDoc.GetGrammar());
#ifdef _WIN32
-ASSERT_FORMULA_EQUAL(rDoc, ScAddress(0,0,0),
"'file:///C:/home/timar/Documents/external.xls'#$Sheet1.A1", "Wrong SupBook
VirtualPath URL");
-#else
-ASSERT_FORMULA_EQUAL(rDoc, ScAddress(0,0,0),
"'file:///home/timar/Documents/external.xls'#$Sheet1.A1", "Wrong SupBook
VirtualPath URL");
+aFormula = aFormula.copy(0, 9) + aFormula.copy(12); // strip drive letter,
e.g. 'C:/'
#endif
+OUString aExpectedFormula =
OUStringLiteral("'file:///home/timar/Documents/external.xls'#$Sheet1.A1");
+if (aFormula != aExpectedFormula)
+{
+CppUnit::Asserter::failNotEqual(to_std_string(aExpectedFormula),
+to_std_string(aFormula), CPPUNIT_SOURCELINE(),
CppUnit::AdditionalMessage("Wrong SupBook VirtualPath URL"));
+}
+
xDocSh->DoClose();
}
diff --git a/vcl/qa/cppunit/pdfexport/pdfexport.cxx
b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
index 89c9745ccb3c..8f82c8c3528b 100644
--- a/vcl/qa/cppunit/pdfexport/pdfexport.cxx
+++ b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
@@ -882,6 +882,8 @@ void PdfExportTest::testTdf108963()
PageHolder pPdfPage(FPDF_LoadPage(pPdfDocument.get(), /*page_index=*/0));
CPPUNIT_ASSERT(pPdfPage.get());
+// FIXME: strangely this fails on some Win systems after a pdfium update,
expected: 793.7; actual: 793
+#if !defined _WIN32
// Test page size (28x15.75 cm, was 1/100th mm off, tdf#112690)
// bad: MediaBox[0 0 793.672440944882 446.428346456693]
// good: MediaBox[0 0 793.700787401575 446.456692913386]
@@ -947,6 +949,7 @@ void PdfExportTest::testTdf108963()
}
CPPUNIT_ASSERT_EQUAL(1, nYellowPathCount);
+#endif
}
void PdfExportTest::testTdf118244_radioButtonGroup()
___
Libreoffice-commits mailing list
[Libreoffice-commits] core.git: include/vcl vcl/inc vcl/qt5 vcl/quartz vcl/source vcl/unx vcl/win
include/vcl/vcllayout.hxx |2
vcl/inc/impglyphitem.hxx| 77 +---
vcl/qt5/Qt5Graphics_Text.cxx|2
vcl/quartz/salgdi.cxx |2
vcl/source/gdi/CommonSalLayout.cxx | 38 +++
vcl/source/gdi/pdfwriter_impl.cxx | 22 -
vcl/source/gdi/sallayout.cxx| 69 ++--
vcl/source/outdev/text.cxx |2
vcl/unx/generic/gdi/cairotextrender.cxx |2
vcl/unx/generic/print/text_gfx.cxx |4 -
vcl/win/gdi/DWriteTextRenderer.cxx |2
vcl/win/gdi/winlayout.cxx |8 +--
12 files changed, 127 insertions(+), 103 deletions(-)
New commits:
commit af8f249ad6368fb957b98ea70bfdf6778709d2eb
Author: Jan-Marek Glogowski
AuthorDate: Fri Jul 5 22:12:39 2019 +0200
Commit: Jan-Marek Glogowski
CommitDate: Sat Jul 6 03:15:58 2019 +0200
Constify GlyphItem
This hides all the data, which shouldn't change after init. Real
const makes a lot of problems for copying, so this is the 2nd
option to just add getters for private data. While at it use
typed_flags for the GlyphItemFlags.
Change-Id: Ic1eeabe2398f6c30080fdd516285b72c620b11be
Reviewed-on: https://gerrit.libreoffice.org/75147
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
diff --git a/include/vcl/vcllayout.hxx b/include/vcl/vcllayout.hxx
index c1d2db0bf152..99884011e928 100644
--- a/include/vcl/vcllayout.hxx
+++ b/include/vcl/vcllayout.hxx
@@ -28,7 +28,7 @@
class ImplLayoutArgs;
class PhysicalFontFace;
class SalGraphics;
-struct GlyphItem;
+class GlyphItem;
class SalLayoutGlyphs;
// all positions/widths are in font units
diff --git a/vcl/inc/impglyphitem.hxx b/vcl/inc/impglyphitem.hxx
index 987df438894c..a04113a1fbae 100644
--- a/vcl/inc/impglyphitem.hxx
+++ b/vcl/inc/impglyphitem.hxx
@@ -20,6 +20,7 @@
#ifndef INCLUDED_VCL_IMPGLYPHITEM_HXX
#define INCLUDED_VCL_IMPGLYPHITEM_HXX
+#include
#include
#include
#include
@@ -28,57 +29,75 @@
#include "fontinstance.hxx"
-struct VCL_DLLPUBLIC GlyphItem
+enum class GlyphItemFlags
+{
+NONE = 0,
+IS_IN_CLUSTER = 0x001,
+IS_RTL_GLYPH = 0x002,
+IS_DIACRITIC = 0x004,
+IS_VERTICAL = 0x008,
+IS_SPACING = 0x010,
+ALLOW_KASHIDA = 0x020,
+IS_DROPPED = 0x040,
+IS_CLUSTER_START = 0x080
+};
+namespace o3tl
+{
+template <> struct typed_flags :
is_typed_flags
+{
+};
+};
+
+class VCL_DLLPUBLIC GlyphItem
{
sal_GlyphId m_aGlyphId;
int m_nCharCount; // number of characters making up this glyph
int m_nOrigWidth; // original glyph width
LogicalFontInstance* m_pFontInstance;
-
int m_nCharPos; // index in string
-int m_nFlags;
-int m_nNewWidth; // width after adjustments
+GlyphItemFlags m_nFlags;
int m_nXOffset;
+
+public:
+int m_nNewWidth; // width after adjustments
Point m_aLinearPos; // absolute position of non rotated string
GlyphItem(int nCharPos, int nCharCount, sal_GlyphId aGlyphId, const Point&
rLinearPos,
- long nFlags, int nOrigWidth, int nXOffset, LogicalFontInstance*
pFontInstance)
+ GlyphItemFlags nFlags, int nOrigWidth, int nXOffset,
+ LogicalFontInstance* pFontInstance)
: m_aGlyphId(aGlyphId)
, m_nCharCount(nCharCount)
, m_nOrigWidth(nOrigWidth)
, m_pFontInstance(pFontInstance)
, m_nCharPos(nCharPos)
, m_nFlags(nFlags)
-, m_nNewWidth(nOrigWidth)
, m_nXOffset(nXOffset)
+, m_nNewWidth(nOrigWidth)
, m_aLinearPos(rLinearPos)
{
assert(m_pFontInstance);
}
-enum
-{
-IS_IN_CLUSTER = 0x001,
-IS_RTL_GLYPH = 0x002,
-IS_DIACRITIC = 0x004,
-IS_VERTICAL = 0x008,
-IS_SPACING = 0x010,
-ALLOW_KASHIDA = 0x020,
-IS_DROPPED = 0x040,
-IS_CLUSTER_START = 0x080
-};
-
-bool IsInCluster() const { return ((m_nFlags & IS_IN_CLUSTER) != 0); }
-bool IsRTLGlyph() const { return ((m_nFlags & IS_RTL_GLYPH) != 0); }
-bool IsDiacritic() const { return ((m_nFlags & IS_DIACRITIC) != 0); }
-bool IsVertical() const { return ((m_nFlags & IS_VERTICAL) != 0); }
-bool IsSpacing() const { return ((m_nFlags & IS_SPACING) != 0); }
-bool AllowKashida() const { return ((m_nFlags & ALLOW_KASHIDA) != 0); }
-bool IsDropped() const { return ((m_nFlags & IS_DROPPED) != 0); }
-bool IsClusterStart() const { return ((m_nFlags & IS_CLUSTER_START) != 0);
}
+bool IsInCluster() const { return bool(m_nFlags &
GlyphItemFlags::IS_IN_CLUSTER); }
+bool IsRTLGlyph() const { return bool(m_nFlags &
GlyphItemFlags::IS_RTL_GLYPH); }
+bool IsDiacritic() const { return bool(m_nFlags &
GlyphItemFlags::IS_DIACRITIC); }
+bool IsVertical() const { return bool(m_nFlags &
GlyphItemFlags::IS_VERTICAL); }
+bool IsSpacing() const { return bool(m_nFlags &
Re: Reveal code, old macros convert them to LO
On 05/07/19 13:14, Uwe Brauer wrote: > >> On 05/07/19 09:16, Uwe Brauer wrote: >> Sorry but that completely misses the point. If it's read-only I won't >> even bother to learn how to use it ... > > The point is: > > Since almost 10 years people are demanding such a feature and nothing > happened. > > All I am saying is: if a read only feature can be _easily implemented_, > then maybe more people will start even to consider such a feature as > being useful and the pressure to have it as «a power tool» will grow. And all I am saying is that the feature you describe sounds to me NOTHING LIKE reveal codes, and personally I can't see any use for it. The Word equivalent is "show formatting" which - like I said - was ignored by lusers and power users alike because they couldn't see any use for it. Do you know lilypond and frescobaldi? That can be set up so that you work in a text editor, and the output is constantly updated in a pdf. THAT is what I want in "reveal codes" - not something that tells me what the formatting is, but something that *lets me work in a text window* but shows me what the result will look like. Your macros mean I'm still stuck in the wysiwyg windows where I *D*O*N*T* want to be, so why would I be interested in your code? Sorry but everybody who tries to implement a reveal-codes-alike always seems to focus on the fact that it shows you what the formatting is. They always miss the fact that it ALSO allows you to EDIT said formatting, and *this* is what power users value (and as I say lusers don't value the fact that you can see the formatting, which means that nobody values that). > > The alternative would be «shut up and how me your code», but I can't > provide you the feature you desire, because I know almost nothing about > LO internals. > Well, all I know about LO internals is that Michael Meeks said it would be a very big job to refactor everything so that a real "reveal codes" was even possible :-( Cheers, Wol ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Reveal code, old macros convert them to LO
On 05/07/19 13:15, Uwe Brauer wrote: "Wl" == Wol's lists writes: > >> On 04/07/2019 11:08, Uwe Brauer wrote: > >> And yes, I would dearly love to have reveal codes back - so much so >> that I am seriously considering shelling out for an up-to-date copy of >> WordPerfect, but sadly I suspect Corel have butchered it. WP8 was >> ported to linux, but that requires libc5, and I'm not aware of any >> newer linux compatible version (WP9, aka WP2000, was implemented on >> top of Wine, but I've never managed to get Wine to run WordPerfect 8 >> or earlier, which are the "real" versions. WP9 was the Corel Windows >> re-write - yeuch!!!) > > Did you try this? > https://ubuntuforums.org/archive/index.php/t-998675.html > THANK YOU VERY MUCH! I've never seen that, but I've got the linux WP8 somewhere, plus licence keys, so I'll have to try. I run gentoo, so it'll be a bit different, but ... :-) Cheers, Wol ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 108010] WebDAV browser is not showing files/directories containing non-latin characters
https://bugs.documentfoundation.org/show_bug.cgi?id=108010 Aron Budea changed: What|Removed |Added Status|RESOLVED|NEW Resolution|INSUFFICIENTDATA|--- CC||ba...@caesar.elte.hu --- Comment #10 from Aron Budea --- Confirmed in LO 6.3 beta2 / Windows 7. I tested with Chinese file name on a SharePoint library accessed via WebDAV, and in the Remote Files dialog the file wasn't shown (other files with latin characters were there). If I used the regular Open File dialog, the file was there. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117073] [META] WebDAV bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=117073 Bug 117073 depends on bug 108010, which changed state. Bug 108010 Summary: WebDAV browser is not showing files/directories containing non-latin characters https://bugs.documentfoundation.org/show_bug.cgi?id=108010 What|Removed |Added Status|RESOLVED|NEW Resolution|INSUFFICIENTDATA|--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
MacUpdate - your app listing has been updated
Title: Untitled Document App Listing Updated Hi The Document Foundation, We have updated your application listing for LibreOffice 6.2.5.2 on MacUpdate.com. Please take a moment to review your application's information to make sure that everything is correct. View your updated app listing You can login to your Developer Account to reply to comments and view stats, or submit new updates and changes to your app listing. Desktop Install Compatibility MacUpdate Desktop 6 is helping developers make it easier for users to fully install and use their apps. Download Desktop 6 and to ensure your app works with the “Install” link on our download pages. Advertise With MacUpdate The best Mac devs advertise their apps on MacUpdate.com because it’s the most targeted, highly performing Mac app advertising you can find on the web. Contact a...@macupdate.com to guarantee your annual ad campaigns get booked and expand your app’s audience. Learn more Questions? Contact our Content Update Team upda...@macupdate.com. You are receiving this offer because you have an app listed on MacUpdate.com. Add us to your address book or white list to ensure reliable delivery. © 2018 MacUpdate - All Rights Reserved 526 W. 14th St. #100 • Traverse City, MI 49684 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
NullPointerException in org.odftoolkit.odfvalidator.ODFValidator.getValidatorForSchema
Hello, I compile libreoffice 6.2.4.2 with ./configure --enable-evolution2 --enable-avahi --enable-python=system --enable-eot --enable-online-update --without- doxygen --with-jdk-home=/opt/jdk --with-ant-home=/opt/ant --without-junit --enable-formula-logger --enable-introspection --with-system-bzip2 --with-system-cairo --with-system-epoxy --with-system-zlib --with-system-jpeg --with-system-expat -- with-system-libxml --with-system-icu --with-system-openldap --without-system-poppler --with-system-curl --with-system- boost --with-webdav --with-krb5 --with-gssapi --with-system-lcms2 --with-system-nss --with-system-graphite --with- system-harfbuzz --with-system-cppunit --with-system-openssl --with-system-libpng --disable-gtk Having java and javac 11.0.2, make fails with NullPointerExceptions: mkdir -p /src/libreoffice-6.2.4.2/build/instdir /src/libreoffice-6.2.4.2/solenv/bin/install-gdb-printers -a /src/libreoffice-6.2.4.2/build/instdir -c make -j 4 -rs -f /src/libreoffice-6.2.4.2/Makefile.gbuild all [build PRL] CustomTarget/postprocess/images/sorted.lst [build PRL] CustomTarget/postprocess/images/commandimagelist.ilst [build DEP] LNK:Library/libswuilo.so [build LNK] Library/libswuilo.so [build DEP] LNK:Library/libvbaswobjlo.so [build LNK] Library/libvbaswobjlo.so [build ECH] CustomTarget/instsetoo_native/setup/versionrc fatal: not a git repository (or any of the parent directories): .git … [build CUT] sd_import_tests [build CUT] sd_import_tests_smartart [build CUT] sd_filters_test [build CUT] sd_misc_tests [build CUT] sd_html_export_tests [build CUT] sd_activex_controls_tests [build CUT] sw_uwriter [build DEP] LNK:CppunitTest/libtest_sw_docbookexport.so [build LNK] CppunitTest/libtest_sw_docbookexport.so SdMiscTest::testTdf96206 finished in: 1824ms SdMiscTest::testTdf96708 finished in: 1279ms SdMiscTest::testTdf99396 finished in: 619ms SdMiscTest::testTdf99396TextEdit finished in: 566ms SdMiscTest::testFillGradient finished in: 81ms Exception in thread "main" java.lang.NullPointerException at org.odftoolkit.odfvalidator.ODFValidator.getValidatorForSchema(ODFValidator.java:286) at org.odftoolkit.odfvalidator.ODFValidator.getManifestValidator(ODFValidator.java:186) at org.odftoolkit.odfvalidator.ODFRootPackageValidator.validateManifest(ODFRootPackageValidator.java:170) at org.odftoolkit.odfvalidator.ODFRootPackageValidator.validatePre(ODFRootPackageValidator.java:93) at org.odftoolkit.odfvalidator.ODFPackageValidator._validate(ODFPackageValidator.java:111) at org.odftoolkit.odfvalidator.ODFPackageValidator.validate(ODFPackageValidator.java:81) at org.odftoolkit.odfvalidator.ODFValidator.validateFile(ODFValidator.java:163) at org.odftoolkit.odfvalidator.ODFValidator.validate(ODFValidator.java:125) at org.odftoolkit.odfvalidator.Main.main(Main.java:314) /src/libreoffice-6.2.4.2/test/source/bootstrapfixture.cxx:199:SdMiscTest::testTdf44774 equality assertion failed - Expected: 0 - Actual : 256 - failed to execute: sh /src/libreoffice-6.2.4.2/build/bin/odfvalidator.sh -M /src/libreoffice- 6.2.4.2/schema/libreoffice/OpenDocument-manifest-schema-v1.3+libreoffice.rng -D /src/libreoffice- 6.2.4.2/schema/libreoffice/OpenDocument-dsig-schema-v1.3+libreoffice.rng -O /src/libreoffice- 6.2.4.2/schema/libreoffice/OpenDocument-schema-v1.3+libreoffice.rng -m /src/libreoffice- 6.2.4.2/schema/mathml2/mathml2.xsd /tmp/lu11615n8eqk4.tmp > /tmp/lu11615n8eqk8.tmp SdMiscTest::testTdf44774 finished in: 1995ms Exception in thread "main" java.lang.NullPointerException at org.odftoolkit.odfvalidator.ODFValidator.getValidatorForSchema(ODFValidator.java:286) at org.odftoolkit.odfvalidator.ODFValidator.getManifestValidator(ODFValidator.java:186) at org.odftoolkit.odfvalidator.ODFRootPackageValidator.validateManifest(ODFRootPackageValidator.java:170) at org.odftoolkit.odfvalidator.ODFRootPackageValidator.validatePre(ODFRootPackageValidator.java:93) at org.odftoolkit.odfvalidator.ODFPackageValidator._validate(ODFPackageValidator.java:111) at org.odftoolkit.odfvalidator.ODFPackageValidator.validate(ODFPackageValidator.java:81) at org.odftoolkit.odfvalidator.ODFValidator.validateFile(ODFValidator.java:163) at org.odftoolkit.odfvalidator.ODFValidator.validate(ODFValidator.java:125) at org.odftoolkit.odfvalidator.Main.main(Main.java:314) /src/libreoffice-6.2.4.2/test/source/bootstrapfixture.cxx:199:SdMiscTest::testTdf38225 equality assertion failed - Expected: 0 - Actual : 256 - failed to execute: sh /src/libreoffice-6.2.4.2/build/bin/odfvalidator.sh -M /src/libreoffice- 6.2.4.2/schema/libreoffice/OpenDocument-manifest-schema-v1.3+libreoffice.rng -D /src/libreoffice- 6.2.4.2/schema/libreoffice/OpenDocument-dsig-schema-v1.3+libreoffice.rng -O /src/libreoffice- 6.2.4.2/schema/libreoffice/OpenDocument-schema-v1.3+libreoffice.rng -m /src/libreoffice-
[Libreoffice-bugs] [Bug 126164] EDITING Error at Paste: Instead to overwrite selected text by text from clipboard selected text iis copied to clipbpoard
https://bugs.documentfoundation.org/show_bug.cgi?id=126164 --- Comment #3 from stefan_lange...@t-online.de --- I have also checked when the bug was introduced in LO 6.4 alpha0+: - I cannot reproduce the behavior with Version: 6.4.0.0.alpha0+ (x64) Build ID: b59a691d2f6b0d1b94ec68fa01768325e4a34dc9 CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2019-06-17_23:52:41 Locale: de-DE (de_DE); UI-Language: en-US Calc: threaded - The bug is present in Version: 6.4.0.0.alpha0+ (x64) Build ID: 11a1bdc5fa0312111ddf9c1b7779a114b97e361c CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2019-06-19_00:00:04 Locale: de-DE (de_DE); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53023] AutoText (text only) embeds extra carriage return
https://bugs.documentfoundation.org/show_bug.cgi?id=53023 --- Comment #15 from Justus --- Still annoying and reproducible on Arch-Linux with LO: - Version: 6.2.4.2.0+ - Build-ID: 6.2.4-1 Best regards Justus -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/drawinglayer
include/drawinglayer/primitive2d/baseprimitive2d.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a36e0f34f2d1baa95f3fe1c9afe6882abcf554dc Author: Andrea Gelmini AuthorDate: Sun Jun 30 22:26:05 2019 + Commit: Julien Nabet CommitDate: Fri Jul 5 23:05:37 2019 +0200 Fix typo Change-Id: I7e22d7e56e0816f446d9d37ca85c7fddee79bd66 Reviewed-on: https://gerrit.libreoffice.org/75115 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/include/drawinglayer/primitive2d/baseprimitive2d.hxx b/include/drawinglayer/primitive2d/baseprimitive2d.hxx index c06065117b75..67a40d77e4c6 100644 --- a/include/drawinglayer/primitive2d/baseprimitive2d.hxx +++ b/include/drawinglayer/primitive2d/baseprimitive2d.hxx @@ -32,7 +32,7 @@ /** defines for DeclPrimitive2DIDBlock and ImplPrimitive2DIDBlock Added to be able to simply change identification stuff later, e.g. add -a identification string and/or ID to the interface and to the implementation +an identification string and/or ID to the interface and to the implementation ATM used to delclare implement getPrimitive2DID() */ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/dbaccess
include/dbaccess/genericcontroller.hxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit a2f4076316ab9b6ded98da304ea980e49219e5ca
Author: Andrea Gelmini
AuthorDate: Sun Jun 30 22:26:07 2019 +
Commit: Julien Nabet
CommitDate: Fri Jul 5 23:04:25 2019 +0200
Fix typo
Change-Id: Iac082acf6940cef62463d505697243b27387334b
Reviewed-on: https://gerrit.libreoffice.org/75112
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/include/dbaccess/genericcontroller.hxx
b/include/dbaccess/genericcontroller.hxx
index 139d6fdd6838..f9aa378b0d99 100644
--- a/include/dbaccess/genericcontroller.hxx
+++ b/include/dbaccess/genericcontroller.hxx
@@ -388,10 +388,10 @@ namespace dbaui
weld::Window* getFrameWeld() const;
voidsetView( const VclPtr& i_rView );
voidclearView();
-// shows a error box if the SQLExceptionInfo is valid
+// shows an error box if the SQLExceptionInfo is valid
void showError(const ::dbtools::SQLExceptionInfo& _rInfo);
-// if there is an css::util::URL translation for the id
+// if there is a css::util::URL translation for the id
// ('handle') then if xListener is NULL the change will be forwarded
// to all listeners to the given css::util::URL
// if there is a toolbar slot with the given id it is updated (the new
state is determined via GetState)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/drawinglayer
include/drawinglayer/primitive2d/cropprimitive2d.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 02edd6b97e15239220594de69fa93e0f875bb4cf Author: Andrea Gelmini AuthorDate: Sun Jun 30 22:26:03 2019 + Commit: Julien Nabet CommitDate: Fri Jul 5 23:03:54 2019 +0200 Fix typo Change-Id: I6b761a20bfe06936aa6872320caff42b044c84e3 Reviewed-on: https://gerrit.libreoffice.org/75125 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/include/drawinglayer/primitive2d/cropprimitive2d.hxx b/include/drawinglayer/primitive2d/cropprimitive2d.hxx index cf1dcaca04a9..ee5871e8a52c 100644 --- a/include/drawinglayer/primitive2d/cropprimitive2d.hxx +++ b/include/drawinglayer/primitive2d/cropprimitive2d.hxx @@ -41,7 +41,7 @@ namespace drawinglayer to get to the uncropped original content. Thus a transformation has to be calculated which will be applied -to the already exsisting content to get it to the uncropped state +to the already existing content to get it to the uncropped state and then this is masked with the current state (mask polygon created from unit polygon and maTransformation). ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 121431] Set language for multiple paragraphs only sets it for the last selected one
https://bugs.documentfoundation.org/show_bug.cgi?id=121431 --- Comment #4 from Adalbert Hanßen --- Today I tested the bug again in LibreOfficeDev Version: 6.4.0.0.alpha0+ Build ID: 0328e0af9532d5ab26840cf58b9dcbb69bb8c33d CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk3; TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-06-28_14:36:08 Locale: de-DE (de_DE.UTF-8); UI-Language: en-US Calc: threaded I marked a text portion spanning several paragraphs. I used Tools>Language>for Paragraph. No language carried a checkmark at that state of my testing. Then I continued such that finally I checked Tools>Language>for Paragraph>English (USA). But this did not change the language: Everything was still underlined with red curly lines indicating typing errors. I checked, if the checkmark for the paragraphs being English (USA) was set: No, it was not, no checkmark on any language in Tools>Language>for Paragraph. Then I repeated my trial with the selection only spanning one paragraph or less and that worked such that the content of the whole paragraph was turned to English (USA). After this, I checked if the checkmark for English (USA) was set fpr that paragraph: No, it was not set. No checkmark at any language in Tools>Language>for Paragraph. Trying to find more about this glitch, I checked several parts of the paragraph to which I had applied Tools>Language>for Paragraph>English (USA), but I checked the properties of the marked test portions with Tools>Language>for Selection. This showed me that the whole content of the paragraph had been turned to English (USA), but as characters, not as a paragraph. Preliminary Conclusion: a) EITHER the language flag is a property of characters rather than a property of paragraphs. b) OR there is a language flag which can be associated to paragraphs, but it is handled by setting this flag to the characters in the selection and the whole surrounding paragraph in which it is located. I don't know enough about the underlying data structures. At least, the function is not properly implemented in the case for a selection spanning more than one paragraph if a) is true and the option to apply a language to a paragraph is meant as "extending the selection to the involved paragraphs first, if necessary". My proposal aa) for case a): In this case the option to assign a language for a paragraph should EITHER be removed, since there is nothing to associate a language to a paragraph OR ab) (still for for case a): it should be implemented to also work, if the selection spans more than one paragraph: extending to all associated paragraphs. bb) for case b): If the data structures are such that they apply a language to characters and to paragraphs, the hierarchy of those settings should be explained in the help function and the function should be applied accordingly. The current user interface at this point is just anti-logical (since it works for less than one paragraph extending but does not work at all, if the selection extends across paragraph bounds). It just surprises the user. Sometimes he is happy, sometimes he is unhappy. But the user does not know about it ahead (unless he has spent as much time as I did to find out when it works and when it doesn't). Probably removing the option to set the selection for paragraphs is the quickest one to implement. It has the advantage to make the program more logical to use and less "mystic exceptions" to learn for a beginner. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: reportdesign/source
reportdesign/source/ui/dlg/Formula.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit e011bf1c751833fa4702ee90dee77b6473ebdaf6 Author: Julien Nabet AuthorDate: Fri Jul 5 19:25:02 2019 +0200 Commit: Julien Nabet CommitDate: Fri Jul 5 22:08:09 2019 +0200 Revert "cid#1448383: Resource leak in object (reportdesign/formula)" I should have use delete or unique_ptr This reverts commit 99ec957948ce3af0c40e9cb1560e2de59fbc8912. Change-Id: I746c2307ca0d4d6cdbe8dbb1c6fd6de624666726 Reviewed-on: https://gerrit.libreoffice.org/75144 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/reportdesign/source/ui/dlg/Formula.cxx b/reportdesign/source/ui/dlg/Formula.cxx index 08794435871e..919deaeec869 100644 --- a/reportdesign/source/ui/dlg/Formula.cxx +++ b/reportdesign/source/ui/dlg/Formula.cxx @@ -97,7 +97,6 @@ FormulaDialog::~FormulaDialog() StoreFormEditData( m_pFormulaData ); m_pEdit = nullptr; m_pAddField.clear(); -free(m_pFormulaData); } // functions for right side ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/ui/vba/vbafiledialogitems.cxx |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
New commits:
commit bf4b2e9f1ef51731299714119361f6e5f73d9072
Author: Noel Grandin
AuthorDate: Fri Jul 5 15:53:55 2019 +0200
Commit: Noel Grandin
CommitDate: Fri Jul 5 21:58:08 2019 +0200
cid#1448260 Argument cannot be negative
Change-Id: I147f68c04c8905aac9e790766c260a30cc061d92
Reviewed-on: https://gerrit.libreoffice.org/75141
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sc/source/ui/vba/vbafiledialogitems.cxx
b/sc/source/ui/vba/vbafiledialogitems.cxx
index 8c0210c70fdc..551da71fda3e 100644
--- a/sc/source/ui/vba/vbafiledialogitems.cxx
+++ b/sc/source/ui/vba/vbafiledialogitems.cxx
@@ -67,7 +67,10 @@ uno::Any
ScVbaFileDialogSelectedItems::createCollectionObject( const uno::Any& aSource )
{
sal_Int32 nPosition = -1;
-aSource >>= nPosition;
+if (!(aSource >>= nPosition))
+throw uno::RuntimeException("not an sal_Int32");
+if (nPosition < 0 || nPosition >= static_cast(m_sItems.size()))
+throw uno::RuntimeException("out of range");
OUString sPath = m_sItems[nPosition];
return uno::makeAny( sPath );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/doc/docfile.cxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit 3f009ab4e767000da299fe222184efea29942173
Author: Jan-Marek Glogowski
AuthorDate: Fri Jul 5 20:13:22 2019 +0200
Commit: Jan-Marek Glogowski
CommitDate: Fri Jul 5 21:03:57 2019 +0200
Fix !HAVE_FEATURE_MULTIUSER_ENVIRONMENT build
The Android-ARM_24-Bytemark-Hosting build currentl< fails with:
error: unused parameter ´pLockData´ [-Werror,-Wunused-parameter]
Regression from commit 0f9599b687c1 ("Show who has locked the
document when reopening a read-only document").
Change-Id: I6d8f900957d79a9c5bf70645e2021995e8a28d43
Reviewed-on: https://gerrit.libreoffice.org/75145
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
diff --git a/sfx2/source/doc/docfile.cxx b/sfx2/source/doc/docfile.cxx
index efb874b67f2a..8570d9921d56 100644
--- a/sfx2/source/doc/docfile.cxx
+++ b/sfx2/source/doc/docfile.cxx
@@ -1136,6 +1136,7 @@ SfxMedium::LockFileResult
SfxMedium::LockOrigFileOnDemand(bool bLoading, bool bN
(void) bLoading;
(void) bNoUI;
(void) bTryIgnoreLockFile;
+(void) pLockData;
return LockFileResult::Succeeded;
#else
LockFileResult eResult = LockFileResult::Failed;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 123587] Beanshell editor: Show current file name as window title
https://bugs.documentfoundation.org/show_bug.cgi?id=123587 Andreas Heinisch changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |andreas.heini...@yahoo.de |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/filter/html/htmlforw.cxx| 20 -
sw/source/filter/ww8/docxattributeoutput.cxx | 352 +++-
sw/source/filter/ww8/docxexport.cxx | 139 +++--
sw/source/filter/ww8/docxsdrexport.cxx| 66 +---
sw/source/filter/ww8/docxtablestyleexport.cxx | 370 --
sw/source/filter/ww8/rtfattributeoutput.cxx |6
sw/source/filter/ww8/ww8par.cxx |9
sw/source/filter/xml/wrtxml.cxx |3
sw/source/filter/xml/xmlimp.cxx | 125 +++-
sw/source/filter/xml/xmlmeta.cxx |6
10 files changed, 498 insertions(+), 598 deletions(-)
New commits:
commit 310cbbd5866f19d2a82bef35da66f56af90c2d08
Author: Arkadiy Illarionov
AuthorDate: Thu Jul 4 22:34:01 2019 +0300
Commit: Arkadiy Illarionov
CommitDate: Fri Jul 5 20:20:34 2019 +0200
Simplify Sequence iterations in sw/source/filter/*
Use range-based loops, STL and comphelper functions
Change-Id: I8ec58bdd38061936f621cdfdbfde59a38ac86705
Reviewed-on: https://gerrit.libreoffice.org/75103
Tested-by: Jenkins
Reviewed-by: Arkadiy Illarionov
diff --git a/sw/source/filter/html/htmlforw.cxx
b/sw/source/filter/html/htmlforw.cxx
index 3b0715581352..eb8697d99291 100644
--- a/sw/source/filter/html/htmlforw.cxx
+++ b/sw/source/filter/html/htmlforw.cxx
@@ -127,15 +127,13 @@ static void lcl_html_outEvents( SvStream& rStrm,
uno::Sequence< script::ScriptEventDescriptor > aDescs =
xEventManager->getScriptEvents( nPos );
-nCount = aDescs.getLength();
-if( !nCount )
+if( !aDescs.hasElements() )
return;
-const script::ScriptEventDescriptor *pDescs = aDescs.getConstArray();
-for( sal_Int32 i = 0; i < nCount; i++ )
+for( const script::ScriptEventDescriptor& rDesc : aDescs )
{
ScriptType eScriptType = EXTENDED_STYPE;
-OUString aScriptType( pDescs[i].ScriptType );
+OUString aScriptType( rDesc.ScriptType );
if( aScriptType.equalsIgnoreAsciiCase(SVX_MACRO_LANGUAGE_JAVASCRIPT) )
eScriptType = JAVASCRIPT;
else if(
aScriptType.equalsIgnoreAsciiCase(SVX_MACRO_LANGUAGE_STARBASIC ) )
@@ -143,7 +141,7 @@ static void lcl_html_outEvents( SvStream& rStrm,
if( JAVASCRIPT != eScriptType && !bCfgStarBasic )
continue;
-OUString sListener( pDescs[i].ListenerType );
+OUString sListener( rDesc.ListenerType );
if (!sListener.isEmpty())
{
const sal_Int32 nIdx { sListener.lastIndexOf('.')+1 };
@@ -159,7 +157,7 @@ static void lcl_html_outEvents( SvStream& rStrm,
}
}
}
-OUString sMethod( pDescs[i].EventMethod );
+OUString sMethod( rDesc.EventMethod );
const sal_Char *pOpt = nullptr;
for( int j=0; aEventListenerTable[j]; j++ )
@@ -175,7 +173,7 @@ static void lcl_html_outEvents( SvStream& rStrm,
OString sOut = " ";
if( pOpt && (EXTENDED_STYPE != eScriptType ||
- pDescs[i].AddListenerParam.isEmpty()) )
+ rDesc.AddListenerParam.isEmpty()) )
sOut += OString(pOpt);
else
{
@@ -185,16 +183,16 @@ static void lcl_html_outEvents( SvStream& rStrm,
}
sOut += "=\"";
rStrm.WriteOString( sOut );
-HTMLOutFuncs::Out_String( rStrm, pDescs[i].ScriptCode, eDestEnc,
pNonConvertableChars );
+HTMLOutFuncs::Out_String( rStrm, rDesc.ScriptCode, eDestEnc,
pNonConvertableChars );
rStrm.WriteChar( '\"' );
if( EXTENDED_STYPE == eScriptType &&
-!pDescs[i].AddListenerParam.isEmpty() )
+!rDesc.AddListenerParam.isEmpty() )
{
sOut = " " OOO_STRING_SVTOOLS_HTML_O_sdaddparam +
OUStringToOString(sListener, RTL_TEXTENCODING_ASCII_US) + "-" +
OUStringToOString(sMethod, RTL_TEXTENCODING_ASCII_US) + "=\"";
rStrm.WriteOString( sOut );
-HTMLOutFuncs::Out_String( rStrm, pDescs[i].AddListenerParam,
+HTMLOutFuncs::Out_String( rStrm, rDesc.AddListenerParam,
eDestEnc, pNonConvertableChars );
rStrm.WriteChar( '\"' );
}
diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx
b/sw/source/filter/ww8/docxattributeoutput.cxx
index 2414c7efcb75..ac88e97d32eb 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -616,15 +616,10 @@ bool DocxAttributeOutput::TextBoxIsFramePr(const
SwFrameFormat& rFrameFormat)
{
uno::Sequence< beans::PropertyValue > propList;
xPropertySet->getPropertyValue("FrameInteropGrabBag") >>= propList;
-for (sal_Int32 nProp=0; nProp < propList.getLength(); ++nProp)
-{
-OUString propName = propList[nProp].Name;
-if (propName == "ParaFrameProperties")
-
[Libreoffice-commits] core.git: solenv/gbuild
solenv/gbuild/UITest.mk |1 + 1 file changed, 1 insertion(+) New commits: commit 2c147cd9ded81b66927435782e0f3d39a1fa44ba Author: Jan-Marek Glogowski AuthorDate: Mon Jul 1 20:59:21 2019 +0200 Commit: Jan-Marek Glogowski CommitDate: Fri Jul 5 20:06:28 2019 +0200 Make UITests depend on MORE_FONTS Change-Id: Ie81a1d0bfc430ec3a5ca03a5ac76f1c82fee6218 Reviewed-on: https://gerrit.libreoffice.org/74969 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski diff --git a/solenv/gbuild/UITest.mk b/solenv/gbuild/UITest.mk index f7444a361728..5ae6774b7d8d 100644 --- a/solenv/gbuild/UITest.mk +++ b/solenv/gbuild/UITest.mk @@ -95,6 +95,7 @@ define gb_UITest_UITest $(call gb_UITest_get_target,$(1)) : PYPATH := $(SRCDIR)/uitest$$(gb_CLASSPATHSEP)$(SRCDIR)/unotest/source/python$$(gb_CLASSPATHSEP)$(INSTROOT)/$(LIBO_LIB_PYUNO_FOLDER)$(if $(filter-out $(LIBO_LIB_PYUNO_FOLDER),$(LIBO_LIB_FOLDER)),$(gb_CLASSPATHSEP)$(INSTROOT)/$(LIBO_LIB_FOLDER)) $(call gb_UITest_get_target,$(1)) : MODULES := +$(eval $(call gb_TestHelpers_use_more_fonts,$(call gb_UITest_get_target,$(1 $(eval $(call gb_Module_register_target,UITest_$(1),$(call gb_UITest_get_target,$(1)),$(call gb_UITest_get_clean_target,$(1 $(call gb_Helper_make_userfriendly_targets,$(1),UITest) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: emfio/qa sc/qa sw/qa vcl/qa
emfio/qa/cppunit/emf/EmfImportTest.cxx|5 +
sc/qa/extras/macros-test.cxx | 11 ---
sc/qa/unit/subsequent_export-test.cxx | 17 +---
sw/qa/core/macros-test.cxx| 90 --
sw/qa/extras/layout/layout.cxx|2
sw/qa/extras/odfexport/odfexport.cxx |4 -
sw/qa/extras/odfimport/odfimport.cxx |5 -
sw/qa/extras/ooxmlexport/ooxmlexport12.cxx|3
sw/qa/extras/ooxmlexport/ooxmlexport2.cxx |4 -
sw/qa/extras/ooxmlexport/ooxmlexport3.cxx | 10 --
sw/qa/extras/ooxmlexport/ooxmlexport7.cxx |2
sw/qa/extras/rtfexport/rtfexport2.cxx |4 -
sw/qa/extras/uiwriter/uiwriter.cxx| 62 ++---
sw/qa/extras/ww8export/ww8export.cxx |2
vcl/qa/cppunit/FontFeatureTest.cxx|8 --
vcl/qa/cppunit/app/test_IconThemeSelector.cxx | 45 +++--
vcl/qa/cppunit/complextext.cxx| 37 +++---
vcl/qa/cppunit/pdfexport/pdfexport.cxx| 45 +
vcl/qa/cppunit/timer.cxx |7 --
19 files changed, 118 insertions(+), 245 deletions(-)
New commits:
commit 3f7e8ddea89f6340cd18b5b34f5a7c5f503962be
Author: Jan-Marek Glogowski
AuthorDate: Tue Jun 25 19:56:13 2019 +
Commit: Jan-Marek Glogowski
CommitDate: Fri Jul 5 20:05:59 2019 +0200
Enable many more unit tests on all archs
This depends on commit "Make font-based unit test depend on instdir
fonts, not that it's sure that this really fixes the problem, as its
origin is really unknown.
It especially enables all the font-based tests I could find on all
archs. Same for many more test where I couldn't see any reason they
don't work generally. To get rid of even more ifdefs, it moves these
from the class to the functions, so there is actually just one needed
for any test. As a result some few tests run but do nothing.
There is still some problem with embedded fonts on MacOS and with
delayed graphics loading on Windows, so these ifdefs are kept.
Change-Id: I63f8424e9debda6cbf3e5777c93245e09f8eb0f2
Reviewed-on: https://gerrit.libreoffice.org/74719
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
diff --git a/emfio/qa/cppunit/emf/EmfImportTest.cxx
b/emfio/qa/cppunit/emf/EmfImportTest.cxx
index 30add1aec73f..94b4f6acd11f 100644
--- a/emfio/qa/cppunit/emf/EmfImportTest.cxx
+++ b/emfio/qa/cppunit/emf/EmfImportTest.cxx
@@ -8,6 +8,7 @@
*/
#include
+#include
#include
#include
@@ -95,6 +96,7 @@ void Test::testWorking()
void Test::TestDrawString()
{
+#if HAVE_MORE_FONTS
// This unit checks for a correct import of an EMF+ file with only one
DrawString Record
// Since the text is undecorated the optimal choice is a simpletextportion
primitive
@@ -112,10 +114,12 @@ void Test::TestDrawString()
assertXPath(pDocument,
"/primitive2D/metafile/transform/transform/textsimpleportion", "text", "TEST");
assertXPath(pDocument,
"/primitive2D/metafile/transform/transform/textsimpleportion", "fontcolor",
"#00");
assertXPath(pDocument,
"/primitive2D/metafile/transform/transform/textsimpleportion", "familyname",
"CALIBRI");
+#endif
}
void Test::TestDrawStringTransparent()
{
+#if HAVE_MORE_FONTS
// This unit checks for a correct import of an EMF+ file with one
DrawString Record with transparency
// first, get the sequence of primitives and dump it
@@ -133,6 +137,7 @@ void Test::TestDrawStringTransparent()
assertXPath(pDocument,
"/primitive2D/metafile/transform/mask/transform/unifiedtransparence/textsimpleportion",
"text", "Transparent Text");
assertXPath(pDocument,
"/primitive2D/metafile/transform/mask/transform/unifiedtransparence/textsimpleportion",
"fontcolor", "#ff");
assertXPath(pDocument,
"/primitive2D/metafile/transform/mask/transform/unifiedtransparence/textsimpleportion",
"familyname", "ARIAL");
+#endif
}
void Test::TestDrawLine()
diff --git a/sc/qa/extras/macros-test.cxx b/sc/qa/extras/macros-test.cxx
index de71456f1b79..475320d470f9 100644
--- a/sc/qa/extras/macros-test.cxx
+++ b/sc/qa/extras/macros-test.cxx
@@ -38,29 +38,22 @@ class ScMacrosTest : public UnoApiTest
public:
ScMacrosTest();
-#if !defined MACOSX
void testStarBasic();
void testVba();
void testMSP();
void testPasswordProtectedStarBasic();
void testRowColumn();
-#endif
+
CPPUNIT_TEST_SUITE(ScMacrosTest);
-#if !defined(MACOSX)
-//enable this test if you want to play with star basic macros in unit tests
-//works but does nothing useful yet
CPPUNIT_TEST(testStarBasic);
CPPUNIT_TEST(testMSP);
CPPUNIT_TEST(testVba);
CPPUNIT_TEST(testPasswordProtectedStarBasic);
CPPUNIT_TEST(testRowColumn);
-#endif
CPPUNIT_TEST_SUITE_END();
};
-#if !defined MACOSX
-
// I suppose you could say this test doesn't really
[Libreoffice-bugs] [Bug 126249] New: SaveAs [Text - Choose Encoding (.txt)] : don't let you chose encoding
https://bugs.documentfoundation.org/show_bug.cgi?id=126249 Bug ID: 126249 Summary: SaveAs [Text - Choose Encoding (.txt)] : don't let you chose encoding Product: LibreOffice Version: 6.2.4.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rumc...@wolke7.net Description: Saving a file as .txt (Text - Choose Encoding (.txt)) don't let you chose encoding. Steps to Reproduce: Save File as .txt (Text - Choose Encoding (.txt) Actual Results: It's save the file as Text but without let you select the encoding Expected Results: - Reproducible: Always User Profile Reset: No Additional Info: - -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: extras/CustomTarget_fontconfig.mk extras/Module_extras.mk extras/Package_fontconfig.mk postprocess/CustomTarget_fontconfig.mk postprocess/Module_postprocess.mk postproc
Repository.mk |2 - RepositoryModule_host.mk |8 +- extras/CustomTarget_fontconfig.mk | 12 - extras/Module_extras.mk| 13 ++ extras/Package_fontconfig.mk |6 ++-- postprocess/Module_postprocess.mk | 13 -- solenv/PythonTest_solenv_python.mk |2 + solenv/gbuild/AllLangHelp.mk |2 - solenv/gbuild/AllLangMoTarget.mk |2 - solenv/gbuild/AllLangPackage.mk|2 - solenv/gbuild/AutoInstall.mk |2 - solenv/gbuild/CliLibrary.mk|2 - solenv/gbuild/CliNativeLibrary.mk |2 - solenv/gbuild/CliUnoApi.mk |2 - solenv/gbuild/CompilerTest.mk |2 - solenv/gbuild/Configuration.mk |2 - solenv/gbuild/CppunitTest.mk | 10 +--- solenv/gbuild/CustomTarget.mk |2 - solenv/gbuild/Dictionary.mk|2 - solenv/gbuild/Executable.mk|2 - solenv/gbuild/Extension.mk |2 - solenv/gbuild/ExtensionPackage.mk |4 +-- solenv/gbuild/ExternalPackage.mk |2 - solenv/gbuild/ExternalProject.mk |2 - solenv/gbuild/Gallery.mk |2 - solenv/gbuild/GeneratedPackage.mk |2 - solenv/gbuild/InstallModule.mk |2 - solenv/gbuild/InstallScript.mk |2 - solenv/gbuild/InternalUnoApi.mk|2 - solenv/gbuild/Jar.mk |2 - solenv/gbuild/JunitTest.mk |4 +-- solenv/gbuild/Library.mk |2 - solenv/gbuild/Module.mk| 14 +-- solenv/gbuild/Package.mk | 15 +++- solenv/gbuild/PackageSet.mk|2 - solenv/gbuild/Pagein.mk|2 - solenv/gbuild/PythonTest.mk|5 ++-- solenv/gbuild/Pyuno.mk |2 - solenv/gbuild/Rdb.mk |2 - solenv/gbuild/StaticLibrary.mk |2 - solenv/gbuild/TestHelpers.mk | 45 + solenv/gbuild/UIConfig.mk |2 - solenv/gbuild/UITest.mk|4 +-- solenv/gbuild/UnoApi.mk|2 - solenv/gbuild/UnpackedTarball.mk |2 - solenv/gbuild/WinResTarget.mk |2 - solenv/gbuild/Zip.mk |2 - solenv/gbuild/gbuild.mk|1 solenv/qa/python/gbuildtojson.py |1 49 files changed, 142 insertions(+), 81 deletions(-) New commits: commit 368c996b24e09c427a30972b3405493328db6779 Author: Jan-Marek Glogowski AuthorDate: Mon Jun 24 08:47:57 2019 +0200 Commit: Jan-Marek Glogowski CommitDate: Fri Jul 5 20:03:40 2019 +0200 Make font-based unit test depend on instdir fonts The current dependency is already a hack, because there is no way I know of to depend on delivered top-level modules like more_fonts. The original patch parses the gb_Package_MODULE_ooo_fonts list of registered packages to add them as build dependencies. But this is not sufficient, as it just adds the dependencies on the installed / unpacked fonts in the workdir (actually it's just the installer filelist), where they can't be found by the unit test running in the instdir environment. So this converts the depndency into a make error, if either the filelist is missing or the included font files. But if we are in a full run and know the more_fonts module, we simply depend on its delivered files. This needs some minimal changes to gbuild, as neither the delivered file list nor the modules class names are yet available. And this moves the fontconfig handling to extras, where the opensymbol font is already handled. Change-Id: I1b70a4c45ff189266ce56c57e534ddc45e7c5c19 Reviewed-on: https://gerrit.libreoffice.org/74624 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski diff --git a/Repository.mk b/Repository.mk index 33cc24fd6881..2febae16202f 100644 --- a/Repository.mk +++ b/Repository.mk @@ -983,7 +983,7 @@ $(eval $(call gb_Helper_register_packages_for_install,ooo,\ $(eval $(call gb_Helper_register_packages_for_install,ooo_fonts,\ extras_fonts \ $(if $(USING_X11)$(DISABLE_GUI)$(filter ANDROID,$(OS)), \ - postprocess_fontconfig) \ + extras_fontconfig) \ $(call gb_Helper_optional,MORE_FONTS,\ fonts_alef \ fonts_amiri \ diff --git a/RepositoryModule_host.mk b/RepositoryModule_host.mk index e6f93c869ccd..e3ea0d994b3b 100644 --- a/RepositoryModule_host.mk +++ b/RepositoryModule_host.mk @@ -11,6 +11,13 @@ $(eval $(call gb_Module_Module,libreoffice)) +# These have to be included before the others for more_fonts dependencies +$(eval $(call gb_Module_add_moduledirs,libreoffice,\ + $(call gb_Helper_optional,MORE_FONTS,external/more_fonts) \ + extras \ +)) + + # This makefile needs to be read first because some variables like T_LIBS # for libmerged are cleared there and then later we append stuff to it # through e.g.
[Libreoffice-bugs] [Bug 126224] main Menu has same accelerator letter for two items in Italian
https://bugs.documentfoundation.org/show_bug.cgi?id=126224 --- Comment #4 from Massimo Medolla --- It's not possible to access to Stile with keyboard shortcuts because with ALT+I is catched from other voices in the menu Inserisci. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/win
vcl/win/gdi/salfont.cxx | 167 ++--
1 file changed, 64 insertions(+), 103 deletions(-)
New commits:
commit 5111baa39117f6e16909566e28a8663a32e25269
Author: Jan-Marek Glogowski
AuthorDate: Thu Jul 4 19:27:31 2019 +0200
Commit: Jan-Marek Glogowski
CommitDate: Fri Jul 5 19:39:55 2019 +0200
WIN get embedded font info from EnumFontFamiliesEx
Instead of some manual decoding of the .fot file, this extracts
all the relevant information of the registered font using the
default routines already used when enumerating the system fonts.
We still have to extract the font family from the .fot file to
know the registered family name of the embedded font.
And it uses the OSL functions to create the temporary font resource
file name and generally adds more SAL_WARNs when some part of the
private font registration fails.
Change-Id: I5e118bf1f3bc1fb7bbf4c68a383a45892dffaf98
Reviewed-on: https://gerrit.libreoffice.org/75102
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
diff --git a/vcl/win/gdi/salfont.cxx b/vcl/win/gdi/salfont.cxx
index 0dfd4fdc62a1..56685cda8eb9 100644
--- a/vcl/win/gdi/salfont.cxx
+++ b/vcl/win/gdi/salfont.cxx
@@ -40,6 +40,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -1105,111 +1106,71 @@ void ImplReleaseTempFonts(SalData& rSalData, bool bAll)
}
}
-static bool ImplGetFontAttrFromFile( const OUString& rFontFileURL,
-FontAttributes& rDFA )
+static OUString lcl_GetFontFamilyName(const OUString& rFontFileURL)
{
-OUString aUSytemPath;
-OSL_VERIFY( !osl::FileBase::getSystemPathFromFileURL( rFontFileURL,
aUSytemPath ) );
-
-// get FontAttributes from a *fot file
-// TODO: use GetTTGlobalFontInfo() to access the font directly
-rDFA.SetQuality( 1000 );
-rDFA.SetFamilyType(FAMILY_DONTKNOW);
-rDFA.SetWidthType(WIDTH_DONTKNOW);
-rDFA.SetWeight(WEIGHT_DONTKNOW);
-rDFA.SetItalic(ITALIC_DONTKNOW);
-rDFA.SetPitch(PITCH_DONTKNOW);
-
// Create temporary file name
-wchar_t aResourceName[512];
-int nMaxLen = SAL_N_ELEMENTS(aResourceName) - 16;
-int nLen = GetTempPathW( nMaxLen, aResourceName );
-wcsncpy( aResourceName + nLen, L"soAAT.fot", std::max( 0, nMaxLen - nLen
));
-DeleteFileW( aResourceName );
-
-// Create font resource file (typically with a .fot file name extension).
-CreateScalableFontResourceW( 0, aResourceName,
o3tl::toW(aUSytemPath.getStr()), nullptr );
+OUString aTempFileURL;
+if (osl::File::E_None != osl::File::createTempFile(nullptr, nullptr,
))
+return OUString();
+osl::File::remove(aTempFileURL);
+OUString aResSystemPath;
+osl::FileBase::getSystemPathFromFileURL(aTempFileURL, aResSystemPath);
+
+// Create font resource file (.fot)
+// There is a limit of 127 characters for the full path passed via
lpszFile, so we have to
+// split the font URL and pass it as two parameters. As a result we can't
use
+// CreateScalableFontResource for renaming, as it now expects the font in
the system path.
+// But it's still good to use it for family name extraction, we're
currently after.
+// BTW: it doesn't help to prefix the lpszFile with \\?\ to support larger
paths.
+// TODO: use TTLoadEmbeddedFont (needs an EOT as input, so we have to add
a header to the TTF)
+// TODO: forward the EOT from the AddTempDevFont call side, if VCL
supports it
+INetURLObject aTTFUrl(rFontFileURL);
+// GetBase() stripts the extension
+OUString aFilename =
aTTFUrl.GetLastName(INetURLObject::DecodeMechanism::WithCharset);
+if (!CreateScalableFontResourceW(0, o3tl::toW(aResSystemPath.getStr()),
+o3tl::toW(aFilename.getStr()),
o3tl::toW(aTTFUrl.GetPath().getStr(
+{
+sal_uInt32 nError = GetLastError();
+SAL_WARN("vcl.fonts", "CreateScalableFontResource failed for " <<
aResSystemPath << " "
+ << aFilename << " " << aTTFUrl.GetPath() << " "
<< nError);
+return OUString();
+}
// Open and read the font resource file
-OUString aFotFileName = o3tl::toU( aResourceName );
-osl::FileBase::getFileURLFromSystemPath( aFotFileName, aFotFileName );
-osl::File aFotFile( aFotFileName );
-osl::FileBase::RC aError = aFotFile.open( osl_File_OpenFlag_Read );
-if( aError != osl::FileBase::E_None )
-return false;
+osl::File aFotFile(aTempFileURL);
+if (osl::FileBase::E_None != aFotFile.open(osl_File_OpenFlag_Read))
+return OUString();
sal_uInt64 nBytesRead = 0;
charaBuffer[4096];
aFotFile.read( aBuffer, sizeof( aBuffer ), nBytesRead );
// clean up temporary resource file
aFotFile.close();
-DeleteFileW( aResourceName );
+osl::File::remove(aTempFileURL);
// retrieve font family name from byte offset 0x4F6
-sal_uInt64 i = 0x4F6;
-sal_uInt64
[Libreoffice-bugs] [Bug 126224] main Menu has same accelerator letter for two items in Italian
https://bugs.documentfoundation.org/show_bug.cgi?id=126224 --- Comment #3 from Massimo Medolla --- Created attachment 152595 --> https://bugs.documentfoundation.org/attachment.cgi?id=152595=edit Access to Stile with shortcuts -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/inc vcl/win
vcl/inc/win/saldata.hxx |5 +++--
vcl/win/app/salinst.cxx |3 ++-
vcl/win/gdi/salfont.cxx | 39 ---
vcl/win/gdi/salgdi.cxx |7 ---
4 files changed, 37 insertions(+), 17 deletions(-)
New commits:
commit 8e63934c398dd5065f3589c8a7d1b3008f5514d1
Author: Jan-Marek Glogowski
AuthorDate: Thu Jul 4 19:24:06 2019 +0200
Commit: Jan-Marek Glogowski
CommitDate: Fri Jul 5 19:38:31 2019 +0200
WIN separate LO shared and embedded fonts
This way we can get rid of the embedded fonts without the reqirement
to re-process all of LO's shared fonts.
Change-Id: I25661a611d43ae05052e5cb9cc21e74ccd06b172
Reviewed-on: https://gerrit.libreoffice.org/75101
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
diff --git a/vcl/inc/win/saldata.hxx b/vcl/inc/win/saldata.hxx
index 00f7c787bbea..dd08b7553734 100644
--- a/vcl/inc/win/saldata.hxx
+++ b/vcl/inc/win/saldata.hxx
@@ -108,7 +108,8 @@ public:
DWORD mnAppThreadId; // Id from
Application-Thread
BOOLmbScrSvrEnabled;// ScreenSaver enabled
SalIcon*mpFirstIcon;// icon cache, points to
first icon, NULL if none
-TempFontItem* mpTempFontItem;
+TempFontItem* mpSharedTempFontItem; // LibreOffice shared fonts
+TempFontItem* mpOtherTempFontItem;// other temporary fonts
(embedded?)
boolmbThemeChanged; // true if visual theme
was changed: throw away theme handles
boolmbThemeMenuSupport;
@@ -156,7 +157,7 @@ void ImplClearHDCCache( SalData* pData );
HDC ImplGetCachedDC( sal_uLong nID, HBITMAP hBmp = nullptr );
void ImplReleaseCachedDC( sal_uLong nID );
-void ImplReleaseTempFonts( SalData& );
+void ImplReleaseTempFonts(SalData&, bool bAll);
HCURSOR ImplLoadSalCursor( int nId );
HBITMAP ImplLoadSalBitmap( int nId );
diff --git a/vcl/win/app/salinst.cxx b/vcl/win/app/salinst.cxx
index c4a290adb092..3a5fd78f743b 100644
--- a/vcl/win/app/salinst.cxx
+++ b/vcl/win/app/salinst.cxx
@@ -289,7 +289,8 @@ SalData::SalData()
mnAppThreadId = 0; // Id from Application-Thread
mbScrSvrEnabled = FALSE;// ScreenSaver enabled
mpFirstIcon = nullptr; // icon cache, points to first icon, NULL if
none
-mpTempFontItem = nullptr;
+mpSharedTempFontItem = nullptr;
+mpOtherTempFontItem = nullptr;
mbThemeChanged = false; // true if visual theme was changed: throw
away theme handles
mbThemeMenuSupport = false;
diff --git a/vcl/win/gdi/salfont.cxx b/vcl/win/gdi/salfont.cxx
index 4ea93e96ce33..0dfd4fdc62a1 100644
--- a/vcl/win/gdi/salfont.cxx
+++ b/vcl/win/gdi/salfont.cxx
@@ -1060,7 +1060,7 @@ struct TempFontItem
TempFontItem* mpNextItem;
};
-static int lcl_AddFontResource(SalData& rSalData, const OUString& rFontFileURL)
+static int lcl_AddFontResource(SalData& rSalData, const OUString&
rFontFileURL, bool bShared)
{
OUString aFontSystemPath;
OSL_VERIFY(!osl::FileBase::getSystemPathFromFileURL(rFontFileURL,
aFontSystemPath));
@@ -1071,19 +1071,36 @@ static int lcl_AddFontResource(SalData& rSalData, const
OUString& rFontFileURL)
{
TempFontItem* pNewItem = new TempFontItem;
pNewItem->maFontResourcePath = aFontSystemPath;
-pNewItem->mpNextItem = rSalData.mpTempFontItem;
-rSalData.mpTempFontItem = pNewItem;
+if (bShared)
+{
+pNewItem->mpNextItem = rSalData.mpSharedTempFontItem;
+rSalData.mpSharedTempFontItem = pNewItem;
+}
+else
+{
+pNewItem->mpNextItem = rSalData.mpOtherTempFontItem;
+rSalData.mpOtherTempFontItem = pNewItem;
+}
}
return nRet;
}
-void ImplReleaseTempFonts( SalData& rSalData )
+void ImplReleaseTempFonts(SalData& rSalData, bool bAll)
{
-while (TempFontItem* p = rSalData.mpTempFontItem)
+while (TempFontItem* p = rSalData.mpOtherTempFontItem)
+{
+RemoveFontResourceExW(o3tl::toW(p->maFontResourcePath.getStr()),
FR_PRIVATE, nullptr);
+rSalData.mpOtherTempFontItem = p->mpNextItem;
+delete p;
+}
+
+if (!bAll)
+return;
+
+while (TempFontItem* p = rSalData.mpSharedTempFontItem)
{
-RemoveFontResourceExW(o3tl::toW(p->maFontResourcePath.getStr()),
- FR_PRIVATE, nullptr);
-rSalData.mpTempFontItem = p->mpNextItem;
+RemoveFontResourceExW(o3tl::toW(p->maFontResourcePath.getStr()),
FR_PRIVATE, nullptr);
+rSalData.mpSharedTempFontItem = p->mpNextItem;
delete p;
}
}
@@ -1196,7 +1213,7 @@ bool
WinSalGraphics::AddTempDevFont(PhysicalFontCollection* pFontCollection,
return false;
}
-int nFonts = lcl_AddFontResource(*GetSalData(), rFontFileURL);
+int nFonts = lcl_AddFontResource(*GetSalData(), rFontFileURL, false);
if (nFonts
[Libreoffice-commits] core.git: vcl/inc vcl/win
vcl/inc/win/saldata.hxx |1 -
vcl/win/gdi/salfont.cxx | 39 ---
2 files changed, 20 insertions(+), 20 deletions(-)
New commits:
commit 7dd44125a9c184c21374a47005e303579179805f
Author: Jan-Marek Glogowski
AuthorDate: Thu Jul 4 01:45:11 2019 +0200
Commit: Jan-Marek Glogowski
CommitDate: Fri Jul 5 19:38:01 2019 +0200
WIN don't register LO's shared fonts twice
This separates the system registration (AddFontResourceEx) of
LO's shared fonts from the later PhysicalFontCollection
population using EnumFontFamiliesEx.
Calling AddTempDevFont from GetDevFontList creates a new
WinFontFaces, but the later EnumFontFamiliesEx also creates
WinFontFaces for all registered fonts, resulting in duplicate
WinFontFace entries in the PhysicalFontCollection.
Also currently the provided WinFontFace from AddTempDevFont is
much less accurate, compated to the EnumFontFamiliesEx one.
Change-Id: I2cd8af77197429508d0a7112ff98706d7f449659
Reviewed-on: https://gerrit.libreoffice.org/75067
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
diff --git a/vcl/inc/win/saldata.hxx b/vcl/inc/win/saldata.hxx
index 74be79774db5..00f7c787bbea 100644
--- a/vcl/inc/win/saldata.hxx
+++ b/vcl/inc/win/saldata.hxx
@@ -156,7 +156,6 @@ void ImplClearHDCCache( SalData* pData );
HDC ImplGetCachedDC( sal_uLong nID, HBITMAP hBmp = nullptr );
void ImplReleaseCachedDC( sal_uLong nID );
-bool ImplAddTempFont( SalData&, const OUString& rFontFileURL );
void ImplReleaseTempFonts( SalData& );
HCURSOR ImplLoadSalCursor( int nId );
diff --git a/vcl/win/gdi/salfont.cxx b/vcl/win/gdi/salfont.cxx
index fcdbb6484dda..4ea93e96ce33 100644
--- a/vcl/win/gdi/salfont.cxx
+++ b/vcl/win/gdi/salfont.cxx
@@ -1060,22 +1060,21 @@ struct TempFontItem
TempFontItem* mpNextItem;
};
-bool ImplAddTempFont( SalData& rSalData, const OUString& rFontFileURL )
+static int lcl_AddFontResource(SalData& rSalData, const OUString& rFontFileURL)
{
-int nRet = 0;
-OUString aUSytemPath;
-OSL_VERIFY( !osl::FileBase::getSystemPathFromFileURL( rFontFileURL,
aUSytemPath ) );
+OUString aFontSystemPath;
+OSL_VERIFY(!osl::FileBase::getSystemPathFromFileURL(rFontFileURL,
aFontSystemPath));
-nRet = AddFontResourceExW( o3tl::toW(aUSytemPath.getStr()), FR_PRIVATE,
nullptr );
-SAL_WARN_IF(!nRet, "vcl.fonts", "Adding private font failed: " <<
rFontFileURL);
+int nRet = AddFontResourceExW(o3tl::toW(aFontSystemPath.getStr()),
FR_PRIVATE, nullptr);
+SAL_WARN_IF(nRet <= 0, "vcl.fonts", "AddFontResourceExW failed for " <<
rFontFileURL);
if (nRet > 0)
{
TempFontItem* pNewItem = new TempFontItem;
-pNewItem->maFontResourcePath = aUSytemPath;
+pNewItem->maFontResourcePath = aFontSystemPath;
pNewItem->mpNextItem = rSalData.mpTempFontItem;
rSalData.mpTempFontItem = pNewItem;
}
-return (nRet > 0);
+return nRet;
}
void ImplReleaseTempFonts( SalData& rSalData )
@@ -1177,10 +1176,9 @@ static bool ImplGetFontAttrFromFile( const OUString&
rFontFileURL,
return true;
}
-bool WinSalGraphics::AddTempDevFont( PhysicalFontCollection* pFontCollection,
-const OUString& rFontFileURL, const OUString& rFontName )
+bool WinSalGraphics::AddTempDevFont(PhysicalFontCollection* pFontCollection,
+const OUString& rFontFileURL, const
OUString& rFontName)
{
-SAL_INFO("vcl.fonts", "WinSalGraphics::AddTempDevFont(): " <<
rFontFileURL);
FontAttributes aDFA;
aDFA.SetFamilyName(rFontName);
@@ -1193,10 +1191,13 @@ bool WinSalGraphics::AddTempDevFont(
PhysicalFontCollection* pFontCollection,
}
if ( aDFA.GetFamilyName().isEmpty() )
+{
+SAL_WARN("vcl.fonts", "error extracting font family from " <<
rFontFileURL);
return false;
+}
-// remember temp font for cleanup later
-if( !ImplAddTempFont( *GetSalData(), rFontFileURL ) )
+int nFonts = lcl_AddFontResource(*GetSalData(), rFontFileURL);
+if (nFonts <= 0)
return false;
// create matching FontData struct
@@ -1224,9 +1225,7 @@ bool WinSalGraphics::AddTempDevFont(
PhysicalFontCollection* pFontCollection,
void WinSalGraphics::GetDevFontList( PhysicalFontCollection* pFontCollection )
{
-SAL_INFO("vcl.fonts", "WinSalGraphics::GetDevFontList(): enter");
-
-// make sure all fonts are registered at least temporarily
+// make sure all LO shared fonts are registered temporarily
static bool bOnce = true;
if( bOnce )
{
@@ -1245,13 +1244,15 @@ void WinSalGraphics::GetDevFontList(
PhysicalFontCollection* pFontCollection )
if( rcOSL == osl::FileBase::E_None )
{
osl::DirectoryItem aDirItem;
+SalData* pSalData = GetSalData();
+assert(pSalData);
while( aFontDir.getNextItem( aDirItem, 10 ) ==
osl::FileBase::E_None )
{
[Libreoffice-bugs] [Bug 126224] main Menu has same accelerator letter for two items in Italian
https://bugs.documentfoundation.org/show_bug.cgi?id=126224 V Stuart Foote changed: What|Removed |Added Summary|main Menu has same |main Menu has same |accelerators letter for two |accelerator letter for two |items in Italian|items in Italian -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=98259 V Stuart Foote changed: What|Removed |Added Depends on||126238 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=126238 [Bug 126238] Some accelerators are double mapped on the main Menu bar with the FR version (calc) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126238] Some accelerators are double mapped on the main Menu bar with the FR version (calc)
https://bugs.documentfoundation.org/show_bug.cgi?id=126238 V Stuart Foote changed: What|Removed |Added Blocks||98259 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=98259 [Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126224] main Menu has same accelerators letter for two items in Italian
https://bugs.documentfoundation.org/show_bug.cgi?id=126224 V Stuart Foote changed: What|Removed |Added Blocks||98259 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=98259 [Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=98259 V Stuart Foote changed: What|Removed |Added Depends on||126224 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=126224 [Bug 126224] main Menu has same accelerators letter for two items in Italian -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126224] main Menu has same accelerators letter for two items in Italian
https://bugs.documentfoundation.org/show_bug.cgi?id=126224 V Stuart Foote changed: What|Removed |Added Summary|Menu keyboard shortcut has |main Menu has same |same letter for two items |accelerators letter for two |in Italian |items in Italian -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126238] Some accelerators are double mapped on the main Menu bar with the FR version (calc)
https://bugs.documentfoundation.org/show_bug.cgi?id=126238 V Stuart Foote changed: What|Removed |Added Summary|Some shortcuts are double |Some accelerators are |mapped to access the Menu |double mapped on the main |with the FR version (calc) |Menu bar with the FR ||version (calc) Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126224] Menu keyboard shortcut has same letter for two items in Italian
https://bugs.documentfoundation.org/show_bug.cgi?id=126224 V Stuart Foote changed: What|Removed |Added Status|NEEDINFO|NEW See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||6238 CC||so...@libreoffice.org --- Comment #2 from V Stuart Foote --- It is annoying to reuse the main menu bar accelerator mappings more than one mnemonic. Shortcut assignment is handled in the localization/translation process. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126238] Some shortcuts are double mapped to access the Menu with the FR version (calc)
https://bugs.documentfoundation.org/show_bug.cgi?id=126238 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||6224 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126218] Build fails: No target for Drivers-mysqlc.xcu
https://bugs.documentfoundation.org/show_bug.cgi?id=126218 --- Comment #2 from antifagmbh...@gmail.com --- Please forgive my this issue, I didn't knew the rules. I've deliberately added --disable-database-connectivity because I hoped it would me around the Drivers-mysqlc.xcu error. Where is this LO dev forum located? Do you mean https://ask.libreoffice.org/de/questions/ ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126172] Tools-Options cannot be opened if GPG4win is installed and many PGP keys set (Windows 10?)
https://bugs.documentfoundation.org/show_bug.cgi?id=126172 --- Comment #16 from Patrick Schönbach --- I posted this: https://dev.gnupg.org/T4615 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126246] Silent crash without the document recovery dialog notice
https://bugs.documentfoundation.org/show_bug.cgi?id=126246 --- Comment #5 from Telesto --- I get the attached dialog with the same build when following: 1. Open attachment 134755 [details] 2. CTRL+A & CTRL+C in header 3. CTRL+N 4. CTRL+V 2x 5. CTRL+A 6. CTRL+X 7. CTRL+V 8. CTRL+Z CTRL+Z -> Crash but not with 1. Open attachment 134755 [details] 2. CTRL+A & CTRL+C in header 3. CTRL+N 4. CTRL+V 3x And I have seen attachment 152594 more often.. But there where instances where lacked (as in the current case). For the record attachment 152594 is not the recovery dialog AFTER restarting LibO. It opens after a crash occurs (it somehow 'holds' the crash). Not sure this can be fixed at all -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126219] LibreOffice Basic exports number with decimal as comma
https://bugs.documentfoundation.org/show_bug.cgi?id=126219 --- Comment #3 from Oliver Brinzing --- correction: and with: Version: 6.2.5.1 (x64) Build-ID: 9a940173fab1747f02322bc89779759d52b3a086 CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; VCL: win; Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE output is 1,2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126219] LibreOffice Basic exports number with decimal as comma
https://bugs.documentfoundation.org/show_bug.cgi?id=126219 --- Comment #2 from Oliver Brinzing --- (In reply to Roy Coleman from comment #0) > Description: > LO BASIC Numbers eg 1.2 export/print as 1,2. No issue in LO 6.1.63, new in > LO 6.2.4.2 x64. please check your Locale Settings: Menu Tools/Options/Language Settings/Languages -> Locale Setting with: Version: 6.2.5.1 (x64) Build-ID: 9a940173fab1747f02322bc89779759d52b3a086 CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; VCL: win; Gebietsschema: en-US (de_DE); UI-Sprache: de-DE output is 1.2 and with: Version: 6.2.5.1 (x64) Build-ID: 9a940173fab1747f02322bc89779759d52b3a086 CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; VCL: win; Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE output is 1.2 so i think, it is a feature and not a bug. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126248] New: Display of English text doesn't honor style setting in Chinese environment
https://bugs.documentfoundation.org/show_bug.cgi?id=126248 Bug ID: 126248 Summary: Display of English text doesn't honor style setting in Chinese environment Product: LibreOffice Version: 6.3.0.0.beta2+ Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ming.v@qq.com Description: On my Chinese version of Windows, when the style assigns western and Asian texts with different fonts, the newly inputed English text doesn't use the western text font, but use the Asian text font instead. This is only a problem of displaying the text, as saving the file, closing it, and opening it again shows the English text with the correctly assigned font. Steps to Reproduce: 1. Create a new spreadsheet file. Change the "Default" style, set the western text font to something distinctly different from the system's default Asian font, say "Segoe UI". Keep the Asian text font as the default "Microsoft YaHei" (微软雅黑). 2. Type some English text in a cell, notice it shows as Segoe UI font when typing, but after enter key to confirm, the text in the cell is shown as MS YaHei font. 3. Save the file. Close it and open it again, now the English text is correcly shown as Segoe UI font. Actual Results: The English text is displayed in the Asian text font, instead of the western text font specified in the style. Expected Results: English text is displayed in the western text font. Reproducible: Always User Profile Reset: Yes Additional Info: Version: 6.3.0.0.beta2 (x64) Build ID: 6c6edded7133daf2d8d0b2ea7ae25b8109c5c064 CPU threads: 2; OS: Windows 10.0; UI render: default; VCL: win; Locale: zh-CN (zh_CN); UI-Language: en-US Calc: threaded It shouldn't be related to user profile, as it's reproducible in safe mode. This is also a regression from 6.1.6 and 6.2.4. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125443] Implement different border colors depending on the LibreOffice app launched on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=125443 --- Comment #6 from Jan-Marek Glogowski --- Windows in LO are represented by the SalFrame class. There is a 2nd type of "window" for native client areas (used for stuff like video overlay in Impress). That code for the Windows OS is is in vcl/win/window/salframe.cxx and vcl/win/window/salobj.cxx. But reading the stackoverflow link, it doesn't look that easy, because now you would have to paint the whole decorations yourself, which probably would require the implementation of bug 113388. OTOH I don't understand why bug 113388 is closed as WONTFIX. If someone manages to implement this, I don't see a reason to not merge that into VCL. Or is there some compelling design reasons not to support this? But getting this to work consistently on all platforms might be quite hard. Looking into Firefox code might be a good starting point there. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124187] Font display issues with BlackForestSans font
https://bugs.documentfoundation.org/show_bug.cgi?id=124187 --- Comment #14 from Adolfo Jayme --- It doesn’t have to do with bug 69254, though… The UI shouldn’t randomly use non-UI typefaces based on what you install. The same problem is described at bug 91607 (I even provided a code pointer there), and will ultimately solved when bug 91400 is addressed. *** This bug has been marked as a duplicate of bug 91607 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91607] DIN Regular used as fallback font for UI (see comment 6)
https://bugs.documentfoundation.org/show_bug.cgi?id=91607 Adolfo Jayme changed: What|Removed |Added CC||estelond...@gmail.com --- Comment #14 from Adolfo Jayme --- *** Bug 124187 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117932] Tooltip's letters are not displayed correctly in Japanese Environment (Mac)
https://bugs.documentfoundation.org/show_bug.cgi?id=117932 Adolfo Jayme changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=91 | |400 | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108042] Tooltips display for toolbar icons suffer from broken font fallback on OSX in CJK UIs
https://bugs.documentfoundation.org/show_bug.cgi?id=108042 Adolfo Jayme changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=91 ||400 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91400] LibreOffice doesn’t use system font since OS X 10.10+
https://bugs.documentfoundation.org/show_bug.cgi?id=91400 Adolfo Jayme changed: What|Removed |Added See Also|https://bugs.documentfounda |https://bugs.documentfounda |tion.org/show_bug.cgi?id=11 |tion.org/show_bug.cgi?id=10 |7932|8042 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126246] Silent crash without the document recovery dialog notice
https://bugs.documentfoundation.org/show_bug.cgi?id=126246 --- Comment #4 from Xisco Faulí --- (In reply to Telesto from comment #3) > Sorry I should rephrase.. I mean the document recovery dialog which opens > after the crash is missing.. Not the actual crash reporter dialog.. My question still stands, do you get the recovery dialog with other crashes ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126246] Silent crash without the document recovery dialog notice
https://bugs.documentfoundation.org/show_bug.cgi?id=126246 Telesto changed: What|Removed |Added Summary|Silent crash without|Silent crash without the |triggering crash reporter |document recovery dialog |(it's about the lack of |notice |crash dialog, not the crash | |as such)| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126246] Silent crash without triggering crash reporter (it's about the lack of crash dialog, not the crash as such)
https://bugs.documentfoundation.org/show_bug.cgi?id=126246 --- Comment #3 from Telesto --- Sorry I should rephrase.. I mean the document recovery dialog which opens after the crash is missing.. Not the actual crash reporter dialog.. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126202] Writer: Insert Hyperlink dialogue: can't enter or edit the URL (GTK3)
https://bugs.documentfoundation.org/show_bug.cgi?id=126202 --- Comment #11 from David Gerard --- obviously this isn't a *good* workaround, as you note. But it allowed me to continue progress with the complex, link-filled Writer document I was working on :-) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126246] Silent crash without triggering crash reporter (it's about the lack of crash dialog, not the crash as such)
https://bugs.documentfoundation.org/show_bug.cgi?id=126246 --- Comment #2 from Telesto --- Created attachment 152594 --> https://bugs.documentfoundation.org/attachment.cgi?id=152594=edit Screenshot -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126217] in lubuntu window has no icon
https://bugs.documentfoundation.org/show_bug.cgi?id=126217 C changed: What|Removed |Added OS|All |Linux (All) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126202] Writer: Insert Hyperlink dialogue: can't enter or edit the URL (GTK3)
https://bugs.documentfoundation.org/show_bug.cgi?id=126202 --- Comment #10 from David Gerard --- I compile it myself. On this box, my --prefix=/home/fun/bin/libreoffice so I start it from the command line with this command to get gtk2: SAL_USE_VCLPLUGIN=gtk /home/fun/bin/libreoffice/lib/libreoffice/program/soffice -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/tiledrendering/tiledrendering.cxx | 20
sw/source/ui/frmdlg/frmpage.cxx|8
sw/source/uibase/inc/basesh.hxx|2 +-
sw/source/uibase/shells/basesh.cxx | 10 ++
4 files changed, 39 insertions(+), 1 deletion(-)
New commits:
commit 4154d281fbecaadf6cd118c00cc6cff929e339a4
Author: Miklos Vajna
AuthorDate: Fri Jul 5 12:48:07 2019 +0200
Commit: Miklos Vajna
CommitDate: Fri Jul 5 16:11:20 2019 +0200
sw lok: hide UI to set Word-incompatible anchor types
Let's make it a bit harder for users to hurt themselves, at least in
Online. Affects the context/popup menu and the dialog of frames.
This is similar to how certain border types are hidden on the UI,
depending on if MSO supports them. Though that goes a bit further and
disables those types even on the desktop.
Change-Id: I6b9205ef3df8a7bc15fbcf787d134743c09e98da
Reviewed-on: https://gerrit.libreoffice.org/75129
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/sw/qa/extras/tiledrendering/tiledrendering.cxx
b/sw/qa/extras/tiledrendering/tiledrendering.cxx
index 965a64fa5191..c06f150ccf32 100644
--- a/sw/qa/extras/tiledrendering/tiledrendering.cxx
+++ b/sw/qa/extras/tiledrendering/tiledrendering.cxx
@@ -45,6 +45,7 @@
#include
#include
#include
+#include
static char const DATA_DIRECTORY[] = "/sw/qa/extras/tiledrendering/data/";
@@ -116,6 +117,7 @@ public:
void testVisCursorInvalidation();
void testDeselectCustomShape();
void testSemiTransparent();
+void testAnchorTypes();
CPPUNIT_TEST_SUITE(SwTiledRenderingTest);
CPPUNIT_TEST(testRegisterCallback);
@@ -174,6 +176,7 @@ public:
CPPUNIT_TEST(testVisCursorInvalidation);
CPPUNIT_TEST(testDeselectCustomShape);
CPPUNIT_TEST(testSemiTransparent);
+CPPUNIT_TEST(testAnchorTypes);
CPPUNIT_TEST_SUITE_END();
private:
@@ -2484,6 +2487,23 @@ void SwTiledRenderingTest::testSemiTransparent()
CPPUNIT_ASSERT_GREATEREQUAL(190, static_cast(aColor.B));
}
+void SwTiledRenderingTest::testAnchorTypes()
+{
+comphelper::LibreOfficeKit::setActive();
+SwXTextDocument* pXTextDocument = createDoc("shape.fodt");
+SwDoc* pDoc = pXTextDocument->GetDocShell()->GetDoc();
+SwView* pView = pXTextDocument->GetDocShell()->GetView();
+pView->GetViewFrame()->GetDispatcher()->Execute(FN_CNTNT_TO_NEXT_FRAME,
SfxCallMode::SYNCHRON);
+SfxItemSet aSet(pDoc->GetAttrPool(), svl::Items{});
+SfxBoolItem aItem(FN_TOOL_ANCHOR_PAGE);
+aSet.Put(aItem);
+auto pShell = dynamic_cast(pView->GetCurShell());
+pShell->GetState(aSet);
+// Without the accompanying fix in place, this test would have failed,
setting the anchor type
+// to other than as/at-char was possible.
+CPPUNIT_ASSERT(!aSet.HasItem(FN_TOOL_ANCHOR_PAGE));
+}
+
CPPUNIT_TEST_SUITE_REGISTRATION(SwTiledRenderingTest);
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sw/source/ui/frmdlg/frmpage.cxx b/sw/source/ui/frmdlg/frmpage.cxx
index 7d99d3b0fcf9..d904ff0ec964 100644
--- a/sw/source/ui/frmdlg/frmpage.cxx
+++ b/sw/source/ui/frmdlg/frmpage.cxx
@@ -72,6 +72,7 @@
#include
#include
#include
+#include
#include
using namespace ::com::sun::star;
@@ -703,6 +704,13 @@ SwFramePage::SwFramePage(TabPageParent pParent, const
SfxItemSet )
m_xAutoWidthCB->connect_toggled(LINK(this, SwFramePage,
AutoWidthClickHdl));
m_xAutoHeightCB->connect_toggled(LINK(this, SwFramePage,
AutoHeightClickHdl));
+
+if (comphelper::LibreOfficeKit::isActive())
+{
+m_xAnchorAtPageRB->hide();
+m_xAnchorAtParaRB->hide();
+m_xAnchorAtFrameRB->hide();
+}
}
SwFramePage::~SwFramePage()
diff --git a/sw/source/uibase/inc/basesh.hxx b/sw/source/uibase/inc/basesh.hxx
index 17d0a8336601..41efce245c32 100644
--- a/sw/source/uibase/inc/basesh.hxx
+++ b/sw/source/uibase/inc/basesh.hxx
@@ -36,7 +36,7 @@ class SfxItemSet;
class SwCursorShell;
struct DBTextStruct_Impl;
-class SAL_DLLPUBLIC_RTTI SwBaseShell: public SfxShell
+class SW_DLLPUBLIC SwBaseShell: public SfxShell
{
SwView
diff --git a/sw/source/uibase/shells/basesh.cxx
b/sw/source/uibase/shells/basesh.cxx
index 58593a92ff69..0e95f814d29b 100644
--- a/sw/source/uibase/shells/basesh.cxx
+++ b/sw/source/uibase/shells/basesh.cxx
@@ -110,6 +110,7 @@
#include
#include
+#include
#include
#include
@@ -1656,6 +1657,15 @@ void SwBaseShell::GetState( SfxItemSet )
rSet.DisableItem(nWhich);
else if(nWhich != SID_ANCHOR_MENU)
rSet.Put(SfxBoolItem(nWhich, bSet));
+
+if (comphelper::LibreOfficeKit::isActive())
+{
+if (nWhich == FN_TOOL_ANCHOR_PAGE || nWhich ==
FN_TOOL_ANCHOR_PARAGRAPH
+|| nWhich == FN_TOOL_ANCHOR_FRAME)
+{
+
Re: Reveal code, old macros convert them to LO
On 7/4/19 8:06 AM, Thorsten Behrens wrote: Hi Uwe, Uwe Brauer wrote: Is there somebody with enough knownledge in macros to translate those macros to LO 6.2? Perhaps - I'd suggest you upload them somewhere (provided they are available under an open source license) & post a link here. Preferably as a bug report at bugs.documentfoundation.org; you can include a description on how to run them / what is expected to work there. All the best, -- Thorsten ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice I see in the two threads on this topic that there is a much discussion without looking at what is the basics of the ODT layout. I this is a mistake, and here is why. I have some .sxw files from which I had earlier an .odt copy. From them I obtained the following information: This is the ODT layout: Which types of data source can OpenOffice.org use? • A database server using Java Database Connectivity (JDBC). • A database server using Open Database Connectivity (ODBC). • The built-in dbase source. • The built-in Adabas source. • ActiveX data objects (ADO) -only available on Windows. • Text files. • Spreadsheets. • Address Books. The help manual that comes with OpenOffice.org does a good job of describing these data sources and how to connect to them. Use Help>Contents>Database Functionality>Data Sources. This is the styles markup of it: Which types of data source can OpenOffice.org use? A database server using Java Database Connectivity (JDBC). A database server using Open Database Connectivity (ODBC). The built-in dbase source. The built-in Adabas source. ActiveX data objects (ADO) -only available on Windows. Text files. Spreadsheets. Which types of data source can OpenOffice.org use? A database server using Java Database Connectivity (JDBC). A database server using Open Database Connectivity (ODBC). The built-in dbase source. The built-in Adabas source. ActiveX data objects (ADO) -only available on Windows. Text files. Spreadsheets. Address Books. The help manual that comes with OpenOffice.org does a good job of describing these data sources and how to connect to them. Use HelpContentsDatabase FunctionalityData Sources. Address Books. The help manual that comes with OpenOffice.org does a good job of describing these data sources and how to connect to them. Use HelpContentsDatabase FunctionalityData Sources. The markup comes directly from the Content.xml file of either the .sxw or .odt file. I should mention for those who wondered but did not know: the mark up for both files (.sxw, its .odt copy) is identical. To open the Content.xml, rename the .odt or .sxw file to .zip. Then unzip it. When opening Content.xml, use a browser or similar program which will give you an outline layout. Each of these styles (L1, P3, P4, P5) are defined in the beginning lines of Content.xml. For example, L1 contains the styles for "List 1"; P3 contains the styles for "Heading 3". P4 and P5 both use the paragraph style "text body"; P4 also contains the list-item style "L1". Search for P4 in the Content.xml beginning from the top to see this. Looking at the markup above, I do not see any way to get "reveal codes". I do think a macro is possible which would reveal the styles used for a given part of a document in outline form as above. It would have to gather that information from the Content.xml file. Could it then expand the name of given style such as L1, P3, P4, p5 so that it would appear in place of the style name? For example, becomes style:parent-style-name="Text body" style:list-style-name="L1"> (This would replace the tag used in the text with the tag used in the list of definitions at the beginning of Content.xml. Comments: Perhaps this could be called "reveal styles"? Also one personal point that I learned back when OOo 1.14 was the latest version: Do not use direct formatting for any reason. That is what styles are for. In the long run, direct formatting does not save any time even when you make no errors with them. But needing to change some of the direct formatting can be very time consuming! A few years ago, someone needed a "pamphlet" formatted which I did for her using styles. Later she wanted to change some of the characteristics of a heading. All I had to do was to change the settings for that heading style. This took seconds, and all of that particular heading now had
[Libreoffice-bugs] [Bug 126202] Writer: Insert Hyperlink dialogue: can't enter or edit the URL (GTK3)
https://bugs.documentfoundation.org/show_bug.cgi?id=126202 --- Comment #9 from Adalbert Hanßen --- (In reply to David Gerard from comment #6) > Just tried starting LO with: > > * SAL_USE_VCLPLUGIN=gen - gives VCL: x11 > * SAL_USE_VCLPLUGIN=gtk - gives VCL: gtk2 > > with either of these, the URL field is editable. > > So there's a workaround, at least. Please explain exactly how what the command line has to be to start LO with your solution. Would it be possible to set such an option to some preference file such that it becomes default for every start which does not explicitly ask for something else with respect to VCLPLUGIN? I tired to modify the starter for LibreOfficeWriter in menulibre to this: libreofficedev6.4 --writer SAL_USE_VCLPLUGIN=gtk %U but this did not work for me. I think, such a workaround (if it works) is only a temporary solution. Being able to produce documents which contain hyperlinks is a very basic thing and I use it very frequently and the same applies to all users who use LibreOfficeWriter for purposes beyond composing "a few pages letters" only. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126133] Calc does not import xlsx-file correctly.
https://bugs.documentfoundation.org/show_bug.cgi?id=126133 --- Comment #3 from Timur --- Created attachment 152593 --> https://bugs.documentfoundation.org/attachment.cgi?id=152593=edit The xlsx-file compared MSO 2016 LO 6.4+.png "File not imported correctly" is always a wrong title. Bugzilla is not "document based", like "this document doesn't display nice". Bugzilla is "issue based", so a single issue must be pointed at, after a search for not being a duplicate. We need to precise what is a single issue here. FWIS and what needs to be checked in the existing bugs: - chart title is missing (from before) - axis title rotated (change in 5.0 but for both) - values are missing (regression from 5.0) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126133] Calc does not import xlsx-file correctly.
https://bugs.documentfoundation.org/show_bug.cgi?id=126133 Timur changed: What|Removed |Added OS|Linux (All) |All Hardware|x86-64 (AMD64) |All -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125390] Gtk3 theme settings with small sizes for scrollbars make them unusable
https://bugs.documentfoundation.org/show_bug.cgi?id=125390 --- Comment #2 from Ilhan Yesil --- Created attachment 152592 --> https://bugs.documentfoundation.org/attachment.cgi?id=152592=edit Sample gtk file This is my installation file /usr/share/themes/Breeze/gtk-3.20/gtk.css where at line 3133 and 3134, I've changed the values from 14px to 5px. min-width: 14px; min-height: 14px; to min-width: 5px; min-height: 5px; -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57147] EDITING: Paste stops working after several copy-paste
https://bugs.documentfoundation.org/show_bug.cgi?id=57147 --- Comment #29 from bugzil...@cb-computerservice.at --- Bug still exists in 6.2.5 :( I wonder that no one cares for this bug, given the huge negativ impact it has on workflow. I always have to copy things from browser to notepad to LibreOffice because I cannot paste without formatting directly :( -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126246] Silent crash without triggering crash reporter (it's about the lack of crash dialog, not the crash as such)
https://bugs.documentfoundation.org/show_bug.cgi?id=126246 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from Xisco Faulí --- Do you get the crash report with the same build with other crashes? I'm wondering if the crash report is disable in that build... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: officecfg/registry sd/uiconfig
officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu | 3 +++ sd/uiconfig/simpress/popupmenu/drawtext.xml | 1 + 2 files changed, 4 insertions(+) New commits: commit e553b3698f6d8f4f606ebe21ed9857ee09f0c057 Author: Samuel Mehrbrodt AuthorDate: Thu Jul 4 15:41:15 2019 +0200 Commit: Samuel Mehrbrodt CommitDate: Fri Jul 5 15:25:49 2019 +0200 Related tdf#98575 Add "Edit Hyperlink" to context menu in sd Change-Id: I121373fae5122e779614a53ac73b4b9d058908d2 Reviewed-on: https://gerrit.libreoffice.org/75126 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt diff --git a/officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu b/officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu index 7c3c4217b803..8199dc07e72e 100644 --- a/officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu +++ b/officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu @@ -703,6 +703,9 @@ ~Hyperlink... + + Edit Hyperlink... + 1 diff --git a/sd/uiconfig/simpress/popupmenu/drawtext.xml b/sd/uiconfig/simpress/popupmenu/drawtext.xml index 23281741dd87..70e153b14afa 100644 --- a/sd/uiconfig/simpress/popupmenu/drawtext.xml +++ b/sd/uiconfig/simpress/popupmenu/drawtext.xml @@ -19,6 +19,7 @@ + ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: oox/source sd/qa
oox/source/drawingml/diagram/diagramlayoutatoms.cxx | 55
sd/qa/unit/import-tests-smartart.cxx|5 +
2 files changed, 5 insertions(+), 55 deletions(-)
New commits:
commit 329c814d28c7773e64e5902ffb1aa4877e4131f1
Author: Grzegorz Araminowicz
AuthorDate: Thu Jul 4 16:16:47 2019 +0200
Commit: Grzegorz Araminowicz
CommitDate: Fri Jul 5 15:23:40 2019 +0200
SmartArt: remove calculateHierChildOffsetScale() from org chart algorithm
Its purpose was to center subtree if sibling parent has no children.
It was not working correctly for complex charts causing shapes to overlap.
Without it chart is still readable (just sometimes not centered).
Remove it for now until more universal solution is found.
Change-Id: I397bd4264d6ce0fadf5c5fa1352f22e72d5d163a
Reviewed-on: https://gerrit.libreoffice.org/75092
Tested-by: Jenkins
Reviewed-by: Grzegorz Araminowicz
diff --git a/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
b/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
index 6a8ffd2c4b3e..a981dd99138c 100644
--- a/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
+++ b/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
@@ -105,51 +105,6 @@ bool containsDataNodeType(const oox::drawingml::ShapePtr&
pShape, sal_Int32 nTyp
return false;
}
-/**
- * Calculates the offset and scaling for pShape (laid out with the hierChild
- * algorithm) based on the siblings of pParent.
- */
-void calculateHierChildOffsetScale(const oox::drawingml::ShapePtr& pShape,
- const oox::drawingml::LayoutNode* pParent,
sal_Int32& rXOffset,
- double& rWidthScale, sal_Int32 nLevel)
-{
-if (!pParent)
-return;
-
-auto pShapes = pParent->getNodeShapes().find(nLevel - 1);
-if (pShapes == pParent->getNodeShapes().end())
-return;
-
-const std::vector& rParents = pShapes->second;
-for (size_t nParent = 0; nParent < rParents.size(); ++nParent)
-{
-const oox::drawingml::ShapePtr& pParentShape = rParents[nParent];
-const std::vector& rChildren =
pParentShape->getChildren();
-if (std::none_of(rChildren.begin(), rChildren.end(),
- [pShape](const oox::drawingml::ShapePtr& pChild) {
return pChild == pShape; }))
-// This is not our parent.
-continue;
-
-if (nParent > 0)
-{
-if (rParents[nParent - 1]->getChildren().size() == 1)
-{
-// Previous sibling of our parent has no children: can use that
-// space, so shift to the left and scale up.
-rWidthScale += 1.0;
-rXOffset -= pShape->getSize().Width;
-}
-}
-if (nParent < rParents.size() - 1)
-{
-if (rParents[nParent + 1]->getChildren().size() == 1)
-// Next sibling of our parent has no children: can use that
-// space, so scale up.
-rWidthScale += 1.0;
-}
-}
-}
-
/// Sets the position and size of a connector inside a hierChild algorithm.
void setHierChildConnPosSize(const oox::drawingml::ShapePtr& pShape)
{
@@ -465,7 +420,7 @@ sal_Int32 AlgAtom::getConnectorType()
void AlgAtom::layoutShape( const ShapePtr& rShape,
const std::vector& rConstraints,
- sal_Int32 nShapeLevel )
+ sal_Int32 /*nShapeLevel*/ )
{
switch(mnType)
{
@@ -750,11 +705,6 @@ void AlgAtom::layoutShape( const ShapePtr& rShape,
std::swap(rChildren[1], rChildren[2]);
}
-sal_Int32 nXOffset = 0;
-double fWidthScale = 1.0;
-if (mnType == XML_hierChild)
-calculateHierChildOffsetScale(rShape,
getLayoutNode().getParentLayoutNode(), nXOffset, fWidthScale, nShapeLevel);
-
awt::Size aChildSize = rShape->getSize();
if (nDir == XML_fromT)
{
@@ -763,11 +713,10 @@ void AlgAtom::layoutShape( const ShapePtr& rShape,
else
aChildSize.Width /= nCount;
aChildSize.Height *= fHeightScale;
-aChildSize.Width *= fWidthScale;
awt::Size aConnectorSize = aChildSize;
aConnectorSize.Width = 1;
-awt::Point aChildPos(nXOffset, 0);
+awt::Point aChildPos(0, 0);
for (auto& pChild : rShape->getChildren())
{
pChild->setPosition(aChildPos);
diff --git a/sd/qa/unit/import-tests-smartart.cxx
b/sd/qa/unit/import-tests-smartart.cxx
index fde35bd0a48d..e40b364d6b58 100644
--- a/sd/qa/unit/import-tests-smartart.cxx
+++ b/sd/qa/unit/import-tests-smartart.cxx
@@ -832,7 +832,7 @@ void SdImportTestSmartArt::testOrgChart()
CPPUNIT_ASSERT(xEmployee2Shape.is());
awt::Point aEmployee2Pos = xEmployee2Shape->getPosition();
-
[Libreoffice-bugs] [Bug 118418] Should implemented scrollto, scrolltopoint, scrollsubstringto, scrollsubstringtopoint
https://bugs.documentfoundation.org/show_bug.cgi?id=118418 --- Comment #1 from Samuel Thibault --- The methods are documented on https://gitlab.gnome.org/GNOME/atk/blob/master/atk/atkcomponent.h#L204 and https://gitlab.gnome.org/GNOME/atk/blob/master/atk/atktext.h#L337 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/vcl vcl/inc vcl/source
include/vcl/metric.hxx | 46 -
vcl/inc/impfontmetric.hxx | 70 -
vcl/source/font/fontmetric.cxx | 135 +++--
vcl/source/outdev/font.cxx |2
4 files changed, 41 insertions(+), 212 deletions(-)
New commits:
commit 4b557c96597a9bbb51677fd83bac98a2edbb9db1
Author: Noel Grandin
AuthorDate: Fri Jul 5 13:09:35 2019 +0200
Commit: Noel Grandin
CommitDate: Fri Jul 5 15:11:12 2019 +0200
flatten and simplify FontMetric
Change-Id: I9cce47c132345e40d3500ba69178e871d68bf764
Reviewed-on: https://gerrit.libreoffice.org/75130
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/vcl/metric.hxx b/include/vcl/metric.hxx
index 55d26cede8fd..0eb584960c16 100644
--- a/include/vcl/metric.hxx
+++ b/include/vcl/metric.hxx
@@ -25,7 +25,6 @@
#include
#include
-class ImplFontMetric;
class FontCharMap;
typedef sal_uInt32 sal_UCS4;
@@ -36,35 +35,44 @@ class VCL_DLLPUBLIC FontMetric : public vcl::Font
public:
explicitFontMetric();
FontMetric( const FontMetric& ); // TODO make this
explicit
-virtual ~FontMetric() override;
+~FontMetric() override;
-longGetAscent() const;
-longGetDescent() const;
-longGetInternalLeading() const;
-longGetExternalLeading() const;
-longGetLineHeight() const;
-longGetSlant() const;
-longGetBulletOffset() const;
+longGetAscent() const { return
mnAscent; }
+longGetDescent() const { return
mnDescent; }
+longGetInternalLeading() const { return
mnIntLeading; }
+longGetExternalLeading() const { return
mnExtLeading; }
+longGetLineHeight() const { return
mnLineHeight; } // TODO this is ascent + descnt
+longGetSlant() const{ return
mnSlant; }
+longGetBulletOffset() const { return
mnBulletOffset; }
-voidSetAscent(long);
-voidSetDescent(long);
-voidSetExternalLeading(long);
-voidSetInternalLeading(long);
-voidSetLineHeight(long);
-voidSetSlant(long);
-voidSetBulletOffset(long);
+voidSetAscent( long nAscent ) { mnAscent
= nAscent; }
+voidSetDescent( long nDescent ) {
mnDescent = nDescent; }
+voidSetExternalLeading( long nExtLeading ) {
mnExtLeading = nExtLeading; }
+voidSetInternalLeading( long nIntLeading ) {
mnIntLeading = nIntLeading; }
+voidSetLineHeight( long nHeight ) {
mnLineHeight = nHeight; } // TODO this is ascent + descent
+voidSetSlant( long nSlant ) { mnSlant
= nSlant; }
+voidSetBulletOffset( long nOffset ) {
mnBulletOffset = nOffset; }
-boolIsFullstopCentered() const;
+boolIsFullstopCentered() const { return
mbFullstopCentered; }
-voidSetFullstopCenteredFlag(bool);
+voidSetFullstopCenteredFlag( bool bCentered ) {
mbFullstopCentered = bCentered; }
+using Font::operator=;
FontMetric& operator=( const FontMetric& rMetric );
FontMetric& operator=( FontMetric&& rMetric );
booloperator==( const FontMetric& rMetric ) const;
booloperator!=( const FontMetric& rMetric ) const
{ return !operator==( rMetric ); }
private:
-tools::SvRef mxImplMetric;// Implementation
+longmnAscent; // Ascent
+longmnDescent; // Descent
+longmnIntLeading; // Internal Leading
+longmnExtLeading; // External Leading
+longmnLineHeight; //
Ascent+Descent+EmphasisMark
+longmnSlant; // Slant
+longmnBulletOffset;// Offset for
non-printing character
+
+boolmbFullstopCentered;
};
template< typename charT, typename traits >
diff --git a/vcl/inc/impfontmetric.hxx b/vcl/inc/impfontmetric.hxx
deleted file mode 100644
index 6267a30fddfd..
--- a/vcl/inc/impfontmetric.hxx
+++ /dev/null
@@ -1,70 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This
[Libreoffice-bugs] [Bug 124983] EDITING Calc: After hiding a column, column breaks and row breaks are inserted
https://bugs.documentfoundation.org/show_bug.cgi?id=124983 --- Comment #4 from Ilhan Yesil --- Created attachment 152591 --> https://bugs.documentfoundation.org/attachment.cgi?id=152591=edit Picture shows two column breaks after hiding first column -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70813] Bad alphabet sort of list of macros
https://bugs.documentfoundation.org/show_bug.cgi?id=70813 Andreas Heinisch changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |andreas.heini...@yahoo.de |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126247] The position of an image ( anchor to as-char ) can't be changed while being selected (alignment is disabled)
https://bugs.documentfoundation.org/show_bug.cgi?id=126247 --- Comment #1 from Telesto --- Created attachment 152590 --> https://bugs.documentfoundation.org/attachment.cgi?id=152590=edit Example file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126247] New: The position of an image ( anchor to as-char ) can't be changed while being selected (alignment is disabled)
https://bugs.documentfoundation.org/show_bug.cgi?id=126247 Bug ID: 126247 Summary: The position of an image ( anchor to as-char ) can't be changed while being selected (alignment is disabled) Product: LibreOffice Version: 6.4.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: The position of an image ( anchor to as-char ) can't be changed while being selected (alignment is disabled) Steps to Reproduce: 1. Open the attached file 2. Click the image -> Not possible to align 3. Place the cursor right or left from the image and change the alignment -> Image position will change.. This slightly different compared to Word Actual Results: It's impossible to change alignment with the image selected. The issue will be more prominent with https://gerrit.libreoffice.org/#/c/75091/ Expected Results: It feels more natural to be able too. Reproducible: Always User Profile Reset: No Additional Info: Version: 6.4.0.0.alpha0+ (x86) Build ID: c2cb467a1e5194c56bb65706b7965fb2c9241b8f CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2019-06-29_00:11:35 Locale: nl-NL (nl_NL); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Change shape from text box mode to ordinary shape in Writer
Hi all, Regina Henschel schrieb am 01-Jul-19 um 20:26: My questions: Is it possible at all? If yes, what do I have overlooked? I have found my mistake. The structure of the custom shape geometry was not correct. But the result doesn't convince me. I consider to import "shape with transformed text" as group, one object for the shape and one object for the transformed text. (Although I yet do not know how to do it.) Such Word object is surely a decorative object in a text document. Therefore it is not good, to have either the shape or the transformed text. You need both. Another advantage of a group is, that text wrap is preserved without large conversions. If only one Fontwork shape is used, without conversions, text layout changes because the bounding rectangle is used for text wrap in LibreOffice. Kind regards Regina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 126246] New: Silent crash without triggering crash reporter (it's about the lack of crash dialog, not the crash as such)
https://bugs.documentfoundation.org/show_bug.cgi?id=126246 Bug ID: 126246 Summary: Silent crash without triggering crash reporter (it's about the lack of crash dialog, not the crash as such) Product: LibreOffice Version: 6.4.0.0.alpha0+ Master Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Silent crash without triggering crash reporter (it's about the lack of crash dialog, not the crash as such) Steps to Reproduce: 1. Open attachment 134755 [details] 2. CTRL+A & CTRL+C in header 3. CTRL+N 4. CTRL+V 3x 5. Hold CTRL+Z -> Silent crash Actual Results: Silent crash Expected Results: A LibreOffice crashed dialog similar to doing these steps 1. Open attachment 134755 [details] 2. CTRL+A & CTRL+C in header 3. CTRL+N 4. CTRL+V 2x 5. CTRL+A 6. CTRL+X 7. CTRL+V 8. CTRL+Z CTRL+Z -> Crash Reproducible: Always User Profile Reset: No Additional Info: Version: 6.4.0.0.alpha0+ (x86) Build ID: c2cb467a1e5194c56bb65706b7965fb2c9241b8f CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2019-06-29_00:11:35 Locale: nl-NL (nl_NL); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111338] LibO will update the registrymodifications.xcu for every color chosen in the color picker (since LibO 5.3)
https://bugs.documentfoundation.org/show_bug.cgi?id=111338 --- Comment #9 from Telesto --- Not sure if there is much to gain from it.. It's more a global design problem I guess.. The xcu is immediately updated on every change (floating dialogs, colors, window position etc). As such acceptable (but not ideal) if the xcu isn't to large. However this isn't the case. A xcu size of 2-4 MB isn't to exceptional causing a crazy amount of disk activity storing mostly trivial things Lazy writing of xcu would be a solution. So storing a some intervals. Release build only of course as I might be problematic for debugging. Another solution would be splitting settings to different xcu's but half-house solution; probably not desired anyway (backward compatibility ) It needs a Dev Evaluation IMHO -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126230] 2 un-nice icons since 6.3.0.0 Beta 2
https://bugs.documentfoundation.org/show_bug.cgi?id=126230 --- Comment #3 from V Stuart Foote --- That looks like the corrupted scaled icon cache issue of bug 119020 using OpenGL Could you please clear you icon cache and retest. Cache of icons is located in: %appdata%\LibreOffice\4\cache\\ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Reveal code, old macros convert them to LO
Hi! On 04.07.2019 20:08, Uwe Brauer wrote: > > > From time to time the question pops up whether LO could support > Wordperfects reveal code. Sometimes it is stated that this feature could > be implemented by a macro/extension. > > Now I remember that long time ago such macros existed and using the > wayback machine I found them. They were written around 2005 for OO 1.2, > using the sxw format. Great that you have interest for bringing the power features to LO. I'm curious what the "reveal code" feature looks like in WP, and what it looked like in OOo with the said macros? Personally I would love to see a greatly reworked style manager, with ability to show the settings applied to any piece of text in layers - from most basic (paragraph style, with its inheritance) through possibly several character styles, to the top manual formatting, where one could easily see the structure - with all intermediate properties - of what we see as the result. Possibly something like modern browsers' object inspectors. But I'm afraid that there's no "codes" in LO (if I understand it right - my understanding is that it shows something like "xml tags" or some such) - and if I'm right, then trying to fake the actual "property set"-based architecture into "codes" would result in much effort with small output. -- Best regards, Mike Kaganski ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Reveal code, old macros convert them to LO
>>> "Wl" == Wol's lists writes: > On 04/07/2019 11:08, Uwe Brauer wrote: > And yes, I would dearly love to have reveal codes back - so much so > that I am seriously considering shelling out for an up-to-date copy of > WordPerfect, but sadly I suspect Corel have butchered it. WP8 was > ported to linux, but that requires libc5, and I'm not aware of any > newer linux compatible version (WP9, aka WP2000, was implemented on > top of Wine, but I've never managed to get Wine to run WordPerfect 8 > or earlier, which are the "real" versions. WP9 was the Corel Windows > re-write - yeuch!!!) Did you try this? https://ubuntuforums.org/archive/index.php/t-998675.html smime.p7s Description: S/MIME cryptographic signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Reveal code, old macros convert them to LO
> On 05/07/19 09:16, Uwe Brauer wrote: > Sorry but that completely misses the point. If it's read-only I won't > even bother to learn how to use it ... The point is: Since almost 10 years people are demanding such a feature and nothing happened. All I am saying is: if a read only feature can be _easily implemented_, then maybe more people will start even to consider such a feature as being useful and the pressure to have it as «a power tool» will grow. The alternative would be «shut up and how me your code», but I can't provide you the feature you desire, because I know almost nothing about LO internals. smime.p7s Description: S/MIME cryptographic signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 125993] CHAPTER NUMBERING DIALOG: Give option to seperate different chapter levels with a dash
https://bugs.documentfoundation.org/show_bug.cgi?id=125993 --- Comment #5 from hoo...@gmail.com --- (In reply to Heiko Tietze from comment #2) > Created attachment 152371 [details] > Mockup for the modification > > We have "Before" and "After" allowing to enter static text. The > customization could provide means to modify the delimiter "Between" > similarly, defaulting to the dot. In case of levels >2 it makes sense to > only change the last delimiter, e.g. A-1+I defines the - at level 2 and the > I at level 3 (but not A-1 vs A+1+I). > Provided ODF allows this flexibility. > > All these changes needs to fit into the new dialog, adding some developers. > The mockup does not work on all aspects; in particular the mix between > characters and numbers is not possible with this kind of top bar selection. > So please just consider the Before/After > Delimiter part. (For consistency > it needs a dot at After to have 1., 2. etc. - we provide this customization > today only per selection from the predefined types). Excuse me, which version of Writer is this? Or Still need to install other programs? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 125993] CHAPTER NUMBERING DIALOG: Give option to seperate different chapter levels with a dash
https://bugs.documentfoundation.org/show_bug.cgi?id=125993 --- Comment #5 from hoo...@gmail.com --- (In reply to Heiko Tietze from comment #2) > Created attachment 152371 [details] > Mockup for the modification > > We have "Before" and "After" allowing to enter static text. The > customization could provide means to modify the delimiter "Between" > similarly, defaulting to the dot. In case of levels >2 it makes sense to > only change the last delimiter, e.g. A-1+I defines the - at level 2 and the > I at level 3 (but not A-1 vs A+1+I). > Provided ODF allows this flexibility. > > All these changes needs to fit into the new dialog, adding some developers. > The mockup does not work on all aspects; in particular the mix between > characters and numbers is not possible with this kind of top bar selection. > So please just consider the Before/After > Delimiter part. (For consistency > it needs a dot at After to have 1., 2. etc. - we provide this customization > today only per selection from the predefined types). Excuse me, which version of Writer is this? Or Still need to install other programs? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
