[Libreoffice-bugs] [Bug 149369] EDITING Form Controls: Default anchor should be set "To Page", not "To Paragraph"

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149369

--- Comment #6 from Robert Großkopf  ---
(In reply to Julien Nabet from comment #5)
> 
> After some test, related code seems to be in
> wizards/com/sun/star/wizards/form but I tried:
> git grep -in anchor
> and
> git grep -in parag
> it returns nothing.
> 
> Are you sure it's about anchor type?

Think it has nothing to do with the wizard.
Open a form for editing.
Add a control.
Have a look for the anchor.
Anchor is set to paragraph automatically.

This is the same behavior in Writer, because default anchor could only be set
for images, not for form controls.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149400] Provide more detailed info about versions in release notes

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149400

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu,
   ||xiscofa...@libreoffice.org
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID

--- Comment #1 from V Stuart Foote  ---
Requested details are provided for incremental releases on project Wiki

Here:

https://wiki.documentfoundation.org/Category:Release

you'll need to review both the RC1 and RC2 final build for applicable fixes,
and the release specific notes for any new "features" being delivered.

IMHO the Wiki format is sufficient for those who want to dig into the
differences of the release builds.  => Invalid

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149152] I cannot insert and display a pdf into a Calc spreadsheet.

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149152

--- Comment #4 from Hud Quistorff  ---
With version 7.2.6.2, I could not insert a pdf into a Calc spreadsheet.

With version 7.3.3.2, mission accomplished!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149137] When launching Libreoffice on MacOS 12.3.1 it gives an error mentioning that soffice cannot launch.

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149137

--- Comment #2 from paulflaher...@hotmail.com ---
the issue is still occurring

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133619] [META] Regressions from increasing column limit in Calc (mainly bug 50916)

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133619

Aron Budea  changed:

   What|Removed |Added

 Depends on||139782


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=139782
[Bug 139782] Calc crashes opening file containing "MATCH" formula referencing
not yet allocated column
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148484] Conditional FORMATTING works in one range, but not in another

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148484

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149138] i am looking for an enhancement to insert multiple images in a Libre Office document

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149138

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149137] When launching Libreoffice on MacOS 12.3.1 it gives an error mentioning that soffice cannot launch.

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149137

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149134] Black boxes present on document when scrolling through text in writer document

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149134

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149121] Hang when resizing a frame/table? within (complex document)

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149121

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149111] Crash when attempting to add MP4 file to Impress

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149111

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149108] Edit conditional formatting prompt/confirmation dialog's "No/Yes" actions don't work as intended

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149108

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149386] formatting brackets randomly created

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149386

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149386] formatting brackets randomly created

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149386

--- Comment #7 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149359] Assertion failed: (index >= 0 && static_cast(index) < static_cast(getLength())), function operator[], file ustring.hxx, line 842.

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149359

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149359] Assertion failed: (index >= 0 && static_cast(index) < static_cast(getLength())), function operator[], file ustring.hxx, line 842.

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149359

--- Comment #8 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145466] Application crashes when running multiple writer instances

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145466

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145466] Application crashes when running multiple writer instances

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145466

--- Comment #4 from QA Administrators  ---
Dear seven,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107733] [META] Hyperlink bugs and enhancements

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107733
Bug 107733 depends on bug 145172, which changed state.

Bug 145172 Summary: URL not recognised when "autocorrection > detect url" is ON 
(both modes) and autocorrection is on
https://bugs.documentfoundation.org/show_bug.cgi?id=145172

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145172] URL not recognised when "autocorrection > detect url" is ON (both modes) and autocorrection is on

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145172

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145172] URL not recognised when "autocorrection > detect url" is ON (both modes) and autocorrection is on

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145172

--- Comment #3 from QA Administrators  ---
Dear nicolas.micaux,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 134788] Inserting a table with 4000-6000 takes a long time to process since 5.1

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134788

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 134788] Inserting a table with 4000-6000 takes a long time to process since 5.1

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134788

--- Comment #10 from QA Administrators  ---
Dear Telesto,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145993] Data Pasted into a cell in Calc goes into the cell below

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145993

--- Comment #2 from QA Administrators  ---
Dear john.davieslg5,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139978] Forced autocorrections of formulas to fractions as text, on paste into Calc

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139978

--- Comment #5 from QA Administrators  ---
Dear davidpbrown,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139818] REQUEST :: Need for BETTERING - Handling of graphics / photographs / objects AND THEIR ANCHORS

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139818

--- Comment #4 from QA Administrators  ---
Dear Karl,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139584] \p should be added to the possible regular expressions for search and replace

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139584

--- Comment #4 from QA Administrators  ---
Dear Adalbert Hanßen,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139578] Extension do not work after updating 6.4.7 to 7.0.3

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139578

--- Comment #2 from QA Administrators  ---
Dear Jürgen,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139564] Loading Styles From Another File Does Not Import Custom Page Styles

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139564

--- Comment #4 from QA Administrators  ---
Dear larrybradley,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139454] Base: Open Insert table design causes memory usage bump of 600 MB with empty database

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139454

--- Comment #8 from QA Administrators  ---
Dear Telesto,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139428] Libreoffice Calc freezes when copying a cell - poll([{fd=6, events=POLLIN} loop

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139428

--- Comment #8 from QA Administrators  ---
Dear mariobaldini,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138215] LibreOffice struggles with dark themes.

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138215

--- Comment #3 from QA Administrators  ---
Dear bas_gommans,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 95949] Changing Display Mode using View menu does not update Display Mode

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=95949

--- Comment #8 from QA Administrators  ---
Dear Óvári,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 94584] FILEOPEN: ODT - Pentagon shape not imported

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94584

--- Comment #9 from QA Administrators  ---
Dear Yousuf Philips (jay) (retired),

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112470] EDITING: Exiting edit mode via clicking on header skewes column selection

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112470

--- Comment #4 from QA Administrators  ---
Dear Emil Tanev,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149388] deleting 'the' tracks the change as 'moved (deletion)'

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149388

--- Comment #3 from Justin  ---
Created attachment 180511
  --> https://bugs.documentfoundation.org/attachment.cgi?id=180511=edit
another example except with 'of'

This time the word "of" is being accused of moving.  I added "of a" at one and
the same time.  I didn't move anything.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 120550] Draw - Changes to table size "Optimal" features need documentation

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120550

--- Comment #15 from Commit Notification 
 ---
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f2d2334b032780d97f7a95aacb8283008e91c529

tdf#121367 (related: tdf#120550) consistent labeling between modules

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 120550] Draw - Changes to table size "Optimal" features need documentation

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120550

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 121367] Writer - Changes to table size "Optimal" features need documentation

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121367

--- Comment #3 from Commit Notification 
 ---
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f2d2334b032780d97f7a95aacb8283008e91c529

tdf#121367 (related: tdf#120550) consistent labeling between modules

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 121367] Writer - Changes to table size "Optimal" features need documentation

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121367

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: officecfg/registry

2022-05-31 Thread Seth Chaiklin (via logerrit)
 officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu |   10 
--
 1 file changed, 8 insertions(+), 2 deletions(-)

New commits:
commit f2d2334b032780d97f7a95aacb8283008e91c529
Author: Seth Chaiklin 
AuthorDate: Fri May 27 00:08:33 2022 +0200
Commit: Seth Chaiklin 
CommitDate: Wed Jun 1 02:50:23 2022 +0200

tdf#121367 (related: tdf#120550) consistent labeling between modules

  There is a slight difference in the label used by Writer
  and the label used by Draw/Impress to refer to:
  .uno:SetMinimalRowHeight and  uno:SetMinimalColumnWidth.
  This patch changes the label in Writer so that it uses the
  same label as Draw/Impress.

Change-Id: I0469b32350bf9a57903b03929675d3b7e8abe287
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135005
Reviewed-by: Seth Chaiklin 
Reviewed-by: Heiko Tietze 
Tested-by: Jenkins

diff --git 
a/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
index 7c7dede5e219..a79fef9d8b5e 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
@@ -2536,7 +2536,10 @@
   
   
 
-  Minimize Column Width
+  Minimal Column Width
+
+
+  Minimal Column Width: Adjust width of 
selected columns to fit content
 
 
   1
@@ -2557,7 +2560,10 @@
   
   
 
-  Minimize Row Height
+  Minimal Row Height
+
+
+  Minimal Row Height: Adjust height of 
selected rows to fit content
 
 
   1


[Libreoffice-ux-advise] [Bug 149414] Change submenu label for formatting textboxes and shapes in Calc and Impress

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149414

sdc.bla...@youmail.dk changed:

   What|Removed |Added

   Keywords||needsUXEval
 Blocks||85811
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=85811
[Bug 85811] [META] Main menu bar bugs and enhancements
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 85811] [META] Main menu bar bugs and enhancements

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=85811

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 Depends on||149414


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=149414
[Bug 149414] Change submenu label for formatting textboxes and shapes in Calc
and Impress
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149414] Change submenu label for formatting textboxes and shapes in Calc and Impress

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149414

sdc.bla...@youmail.dk changed:

   What|Removed |Added

   Keywords||needsUXEval
 Blocks||85811
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=85811
[Bug 85811] [META] Main menu bar bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149414] New: Change submenu label for formatting textboxes and shapes in Calc and Impress

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149414

Bug ID: 149414
   Summary: Change submenu label for formatting textboxes and
shapes in Calc and Impress
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sdc.bla...@youmail.dk

In Calc: Format > OLE Object (using.uno:ObjectMenu), 
In Impress: Format > "Object and Shape" (using .uno:FormatObjectMenu).

Proposal: 
  1. Change Label of .uno:FormatObjectMenu
  from "Object and Shape" -> "Text Box and Shape"
   (a) to be consistent with Writer,
   (b) because the contents of its submenu are applied
   only to Text Boxes and Shapes.

  2. Change in Calc, .uno:ObjectMenu to .uno:FormatObjectMenu 
 for its Format menu.
   (a) will make its label consistent with Writer and Impress
   (b) the contents of its submenu is for editing properties of text boxes
   and shapes, not OLE Objects, so the label will be more appropriate.

https://gerrit.libreoffice.org/c/core/+/135162

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 90796] [META] HiDPI / Retina bugs

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90796
Bug 90796 depends on bug 126530, which changed state.

Bug 126530 Summary: Tabbed Notebook Bar Usability Issues on Windows 10
https://bugs.documentfoundation.org/show_bug.cgi?id=126530

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107237] [META] Notebookbar Tabbed

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107237
Bug 107237 depends on bug 126530, which changed state.

Bug 126530 Summary: Tabbed Notebook Bar Usability Issues on Windows 10
https://bugs.documentfoundation.org/show_bug.cgi?id=126530

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 126530] Tabbed Notebook Bar Usability Issues on Windows 10

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126530

ema1...@gmail.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |---

--- Comment #7 from ema1...@gmail.com ---
(In reply to Heiko Tietze from comment #5)
> Sorry for the late reply, sometimes reports just slip through. Since some
> time has past by and the report consists of five different issues I'm going
> to resolve it as WFM with the hope some/many/all issues have been fixed
> meanwhile. If not, other reports are referenced with the meta ticket. Feel
> free to reopen, of course.

Hey there, I currently still have all the listed issues on my 4k PC, I've
attached a screenshot.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 126530] Tabbed Notebook Bar Usability Issues on Windows 10

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126530

ema1...@gmail.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |---

--- Comment #7 from ema1...@gmail.com ---
(In reply to Heiko Tietze from comment #5)
> Sorry for the late reply, sometimes reports just slip through. Since some
> time has past by and the report consists of five different issues I'm going
> to resolve it as WFM with the hope some/many/all issues have been fixed
> meanwhile. If not, other reports are referenced with the meta ticket. Feel
> free to reopen, of course.

Hey there, I currently still have all the listed issues on my 4k PC, I've
attached a screenshot.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 126530] Tabbed Notebook Bar Usability Issues on Windows 10

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126530

--- Comment #6 from ema1...@gmail.com ---
Created attachment 180510
  --> https://bugs.documentfoundation.org/attachment.cgi?id=180510=edit
Squised Tabbed UI View

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 126530] Tabbed Notebook Bar Usability Issues on Windows 10

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126530

--- Comment #6 from ema1...@gmail.com ---
Created attachment 180510
  --> https://bugs.documentfoundation.org/attachment.cgi?id=180510=edit
Squised Tabbed UI View

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 95958] enhancement: tune the comment box (width/padding) for visual comfort

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=95958

Rafael Lima  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=97
   ||341

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 97341] Width for document comments cannot be changed manually

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=97341

Rafael Lima  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=95
   ||958

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148534] [META] Arrow Style

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148534
Bug 148534 depends on bug 148737, which changed state.

Bug 148737 Summary: Improve label and tooltip for Arrow Styles icon in Drawing 
Objects Properties bar
https://bugs.documentfoundation.org/show_bug.cgi?id=148737

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148737] Improve label and tooltip for Arrow Styles icon in Drawing Objects Properties bar

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148737

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #13 from sdc.bla...@youmail.dk ---
Closing this ticket as FIXED, because OP was achieved.

And a short status report.

This ticket and bug 148736 grew out of an attempt to make UI consistency
between the Arrow Styles tab in the Line dialog.  And that attempt grew out of
bug 126658, which tried to improve the labelling in the Arrow Styles tab.

Along the way, dissatisfaction arose with the use of "Styles" throughout the
"Line" dialog.  That discussion was held in this ticket, perhaps with the
conclusion that the Line dialog should be reworked to not use "style" (in
relation to "Line", "Cap", "Corner" and "Arrow".

comment 11 summarizes the situation -- pointing out that it would be better to
revise all the "styles" in the Line dialog at one time -- to avoid
retranslating sentences in help.  That is where the story stops.

There is now UI consistency (more or less) between the arrow styles tab and its
popup dialogs, while the tooltip that was added for this ticket has used
"arrowheads" as a first small step toward the "overhaul" of the Line dialog.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149386] formatting brackets randomly created

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149386

--- Comment #6 from Justin  ---
I'm confused, Rafael.  I did upload part of the DOCX.  Do you mean a part of
the file that has not been saved in Writer?
Also, I confirmed with the author of the file that he had only one known
bookmark.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148534] [META] Arrow Style

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148534
Bug 148534 depends on bug 148736, which changed state.

Bug 148736 Summary: Popup dialog boxes for Arrow Style tab should use 
consistent terminology with the main Arrow style tab
https://bugs.documentfoundation.org/show_bug.cgi?id=148736

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148736] Popup dialog boxes for Arrow Style tab should use consistent terminology with the main Arrow style tab

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148736

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED
   Assignee|libreoffice-b...@lists.free |sdc.bla...@youmail.dk
   |desktop.org |

--- Comment #8 from sdc.bla...@youmail.dk ---
(In reply to Heiko Tietze from comment #6)
> At least no one volunteered to do the work. So yes, push your patch for now.
Ok. Will close this ticket as FIXED, because it provides consistent terminology
between the Arrow Styles tab and its popup dialog boxes. 

Meanwhile comment 4 gives a detailed account of the situation, if and when a
more systematic overhaul of the "Line" dialog is made, and the word "Styles" is
expunged.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: cui/inc cui/uiconfig sd/inc

2022-05-31 Thread Seth Chaiklin (via logerrit)
 cui/inc/strings.hrc |2 +-
 cui/uiconfig/ui/querychangelineenddialog.ui |6 +++---
 cui/uiconfig/ui/querydeletelineenddialog.ui |4 ++--
 sd/inc/strings.hrc  |2 +-
 4 files changed, 7 insertions(+), 7 deletions(-)

New commits:
commit 5423dfb8549743bd5045b6e3b1ebad7980e62965
Author: Seth Chaiklin 
AuthorDate: Fri Apr 22 21:51:33 2022 +0100
Commit: Seth Chaiklin 
CommitDate: Wed Jun 1 01:16:28 2022 +0200

tdf#148736 improve labels for Arrow style popup dialogs

Change-Id: Ifc43650a3008cbd96cac8f994675e680368a215b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133287
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin 

diff --git a/cui/inc/strings.hrc b/cui/inc/strings.hrc
index b0dccedc413f..cea0b183e33a 100644
--- a/cui/inc/strings.hrc
+++ b/cui/inc/strings.hrc
@@ -319,7 +319,7 @@
 #define RID_CUISTR_ADD  NC_("RID_SVXSTR_ADD", 
"Add")
 #define RID_CUISTR_DESC_COLOR   
NC_("RID_SVXSTR_DESC_COLOR", "Please enter a name for the new color:")
 #define RID_CUISTR_TABLENC_("RID_SVXSTR_TABLE", 
"Table")
-#define RID_CUISTR_DESC_LINEEND 
NC_("RID_SVXSTR_DESC_LINEEND", "Please enter a name for the new arrowhead:")
+#define RID_CUISTR_DESC_LINEEND 
NC_("RID_SVXSTR_DESC_LINEEND", "Please enter a name for the new arrow style:")
 #define RID_CUISTR_CHARNAME_NOSTYLE 
NC_("RID_SVXSTR_CHARNAME_NOSTYLE", "No %1")
 #define RID_CUISTR_CHARNAME_FAMILY  
NC_("RID_SVXSTR_CHARNAME_FAMILY", "Family:")
 #define RID_CUISTR_CHARNAME_FONT
NC_("RID_SVXSTR_CHARNAME_FONT", "Font:")
diff --git a/cui/uiconfig/ui/querychangelineenddialog.ui 
b/cui/uiconfig/ui/querychangelineenddialog.ui
index 6057416728a1..5ec1567001b0 100644
--- a/cui/uiconfig/ui/querychangelineenddialog.ui
+++ b/cui/uiconfig/ui/querychangelineenddialog.ui
@@ -4,15 +4,15 @@
   
   
 False
-Save 
Arrowhead?
+Save Arrow 
Style?
 False
 True
 dialog
 True
 warning
 yes-no
-The arrowhead was 
modified without saving.
-Would you like to 
save the arrowhead now?
+The arrow style was 
modified without saving.
+Would you like to 
save the arrow style now?
 
   
 False
diff --git a/cui/uiconfig/ui/querydeletelineenddialog.ui 
b/cui/uiconfig/ui/querydeletelineenddialog.ui
index eb1e771a246f..6917fc62422a 100644
--- a/cui/uiconfig/ui/querydeletelineenddialog.ui
+++ b/cui/uiconfig/ui/querydeletelineenddialog.ui
@@ -4,14 +4,14 @@
   
   
 False
-Delete 
Arrowhead?
+Delete Arrow 
Style?
 False
 True
 dialog
 True
 question
 yes-no
-Do you really want to 
delete the arrowhead?
+Do you really want to 
delete the arrow style?
 This action cannot be 
undone.
 
   
diff --git a/sd/inc/strings.hrc b/sd/inc/strings.hrc
index c67d1c9d1579..05326f9e461a 100644
--- a/sd/inc/strings.hrc
+++ b/sd/inc/strings.hrc
@@ -64,7 +64,7 @@
 #define STR_AUTOLAYOUT_NOTES
NC_("STR_AUTOLAYOUT_NOTES", "Notes")
 #define STR_TRANSFORM   NC_("STR_TRANSFORM", 
"Transform")
 #define STR_LINEEND NC_("STR_LINEEND", 
"Line Ends")
-#define STR_DESC_LINEEND
NC_("STR_DESC_LINEEND", "Please enter a name for the new arrowhead:")
+#define STR_DESC_LINEEND
NC_("STR_DESC_LINEEND", "Please enter a name for the new arrow style:")
 #define STR_WARN_NAME_DUPLICATE 
NC_("STR_WARN_NAME_DUPLICATE", "The name chosen already exists. \nPlease enter 
another name.")
 #define STR_UNDO_ANIMATION  
NC_("STR_UNDO_ANIMATION", "Animation parameters")
 #define STR_UNDO_COPYOBJECTS
NC_("STR_UNDO_COPYOBJECTS", "Duplicate")


[Libreoffice-bugs] [Bug 148736] Popup dialog boxes for Arrow Style tab should use consistent terminology with the main Arrow style tab

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148736

--- Comment #7 from Commit Notification 
 ---
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5423dfb8549743bd5045b6e3b1ebad7980e62965

tdf#148736 improve labels for Arrow style popup dialogs

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148736] Popup dialog boxes for Arrow Style tab should use consistent terminology with the main Arrow style tab

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148736

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 97341] Width for document comments cannot be changed manually

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=97341

Rafael Lima  changed:

   What|Removed |Added

 CC||evisa.vietn...@gmail.com

--- Comment #44 from Rafael Lima  ---
*** Bug 149405 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149405] LibreOffice Writer comment boxes are too small and should be resizable

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149405

Rafael Lima  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Rafael Lima  ---


*** This bug has been marked as a duplicate of bug 97341 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149413] New: record macro is gone

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149413

Bug ID: 149413
   Summary: record macro is gone
   Product: LibreOffice
   Version: 7.2.7.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mul...@gmail.com

after the update the macro recording is gone

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: helpcontent2

2022-05-31 Thread Seth Chaiklin (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c2670f45252aa3642ea4fbb70a48e03e284eb60c
Author: Seth Chaiklin 
AuthorDate: Wed Jun 1 00:29:49 2022 +0200
Commit: Gerrit Code Review 
CommitDate: Wed Jun 1 00:29:49 2022 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to b30109758ad6b6bcb8b82d6a646fc055cd3a2402
  - refactor some embedvars that give a translation problem for some

Change-Id: Ibb67c7dd61fe55892232bebc2280fb3faed0db37
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135168
Reviewed-by: Seth Chaiklin 
Tested-by: Jenkins

diff --git a/helpcontent2 b/helpcontent2
index 4bbaecd77c87..b30109758ad6 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 4bbaecd77c87afee5453dc89a9e033d4048c909e
+Subproject commit b30109758ad6b6bcb8b82d6a646fc055cd3a2402


[Libreoffice-commits] help.git: source/text

2022-05-31 Thread Seth Chaiklin (via logerrit)
 source/text/shared/00/0005.xhp  |3 ++-
 source/text/swriter/guide/anchor_object.xhp |2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

New commits:
commit b30109758ad6b6bcb8b82d6a646fc055cd3a2402
Author: Seth Chaiklin 
AuthorDate: Tue May 31 23:23:23 2022 +0200
Commit: Seth Chaiklin 
CommitDate: Wed Jun 1 00:29:48 2022 +0200

refactor some embedvars that give a translation problem for some

Change-Id: Ibb67c7dd61fe55892232bebc2280fb3faed0db37
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135168
Reviewed-by: Seth Chaiklin 
Tested-by: Jenkins

diff --git a/source/text/shared/00/0005.xhp 
b/source/text/shared/00/0005.xhp
index 4866ec144..bb23d6002 100644
--- a/source/text/shared/00/0005.xhp
+++ b/source/text/shared/00/0005.xhp
@@ -199,7 +199,8 @@
 
OLE
Object 
Linking and Embedding (OLE) objects can be linked to a target document or may 
also be embedded. Embedding inserts a copy of the object and details of the 
source program in the target document. If you want to edit the object, simply 
activate the source program by double-clicking on the object.
-   If an OLE object is 
linked to a target document, then the target document must be available in the 
location specified in the link. Deleting or moving the target document will 
make it impossible to open the linked OLE object. You can use the  option 
in the General section of Load/Save Options to 
configure your system to save links relative to your filesystem.
+   If an OLE object is 
linked to a target document, then the target document must be available in the 
location specified in the link. Deleting or moving the target document will 
make it impossible to open the linked OLE object. You can use the Save URLs relative to file system 
option in the General section of Load/Save 
Options to configure your system to save links relative to your filesystem.
+  
   
   
 
diff --git a/source/text/swriter/guide/anchor_object.xhp 
b/source/text/swriter/guide/anchor_object.xhp
index 5cca8c8cf..11e43ee29 100644
--- a/source/text/swriter/guide/anchor_object.xhp
+++ b/source/text/swriter/guide/anchor_object.xhp
@@ -104,7 +104,7 @@
 
 
 Changing an Anchor
-To change the anchoring 
options of an object, right-click the object, and then choose an option from 
the  submenu.
+To change the anchoring 
options of an object, right-click the object, and then choose an option from 
the Anchor submenu.
 
 
 


[Libreoffice-bugs] [Bug 149406] What is expected behavior of padding for characters, with and without borders?

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149406

--- Comment #3 from sdc.bla...@youmail.dk ---
(In reply to LeroyG from comment #2)
Thanks Leroy.  The first question in the OP is about the "Character" option in
the "to" control in the Position and Size dialog for shape. The issue is not to
align the shapes across the big letters, but to explain, for each letter, the
size of the "Character" area used in the Position and Size dialog for
positioning the shape, and how that area interacts with padding and borders
applied to the different letters (as described above each letter). The
different big letters in the attachment are provided to show examples of that
interaction. (I should have made these points more explicit from the start.)  

Your example is interesting, but uses another positioning feature in a
different dialog than the OP.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 149406] What is expected behavior of padding for characters, with and without borders?

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149406

--- Comment #3 from sdc.bla...@youmail.dk ---
(In reply to LeroyG from comment #2)
Thanks Leroy.  The first question in the OP is about the "Character" option in
the "to" control in the Position and Size dialog for shape. The issue is not to
align the shapes across the big letters, but to explain, for each letter, the
size of the "Character" area used in the Position and Size dialog for
positioning the shape, and how that area interacts with padding and borders
applied to the different letters (as described above each letter). The
different big letters in the attachment are provided to show examples of that
interaction. (I should have made these points more explicit from the start.)  

Your example is interesting, but uses another positioning feature in a
different dialog than the OP.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-commits] core.git: vcl/qt5

2022-05-31 Thread Jan-Marek Glogowski (via logerrit)
 vcl/qt5/QtWidget.cxx |   47 ++-
 1 file changed, 22 insertions(+), 25 deletions(-)

New commits:
commit cd2ea94969b9c63b24e35e9b8e546cea0f62340e
Author: Jan-Marek Glogowski 
AuthorDate: Tue May 31 21:03:39 2022 +0200
Commit: Jan-Marek Glogowski 
CommitDate: Wed Jun 1 00:16:32 2022 +0200

Qt just resize the backing store on size change

... and if there is no need to create a Cairo surface if it
doesn't exists, there is no need for a fresh QImage either.

Change-Id: If607e03d246f3c31d66953b1e07a7af55659e64b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135209
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 

diff --git a/vcl/qt5/QtWidget.cxx b/vcl/qt5/QtWidget.cxx
index 74adcc4e974c..b2451123e7e6 100644
--- a/vcl/qt5/QtWidget.cxx
+++ b/vcl/qt5/QtWidget.cxx
@@ -98,38 +98,35 @@ void QtWidget::resizeEvent(QResizeEvent* pEvent)
 
 if (m_rFrame.m_bUseCairo)
 {
-if (m_rFrame.m_pSvpGraphics)
+if (m_rFrame.m_pSurface)
 {
-cairo_surface_t* pSurface
-= cairo_image_surface_create(CAIRO_FORMAT_ARGB32, nWidth, 
nHeight);
-cairo_surface_set_user_data(pSurface, 
SvpSalGraphics::getDamageKey(),
-_rFrame.m_aDamageHandler, nullptr);
-m_rFrame.m_pSvpGraphics->setSurface(pSurface, 
basegfx::B2IVector(nWidth, nHeight));
-UniqueCairoSurface old_surface(m_rFrame.m_pSurface.release());
-m_rFrame.m_pSurface.reset(pSurface);
-
-int min_width = 
qMin(cairo_image_surface_get_width(old_surface.get()), nWidth);
-int min_height = 
qMin(cairo_image_surface_get_height(old_surface.get()), nHeight);
-
-SalTwoRect rect(0, 0, min_width, min_height, 0, 0, min_width, 
min_height);
-
-m_rFrame.m_pSvpGraphics->copySource(rect, old_surface.get());
+const int nOldWidth = 
cairo_image_surface_get_width(m_rFrame.m_pSurface.get());
+const int nOldHeight = 
cairo_image_surface_get_height(m_rFrame.m_pSurface.get());
+if (nOldWidth != nWidth || nOldHeight != nHeight)
+{
+cairo_surface_t* pSurface
+= cairo_image_surface_create(CAIRO_FORMAT_ARGB32, nWidth, 
nHeight);
+cairo_surface_set_user_data(pSurface, 
SvpSalGraphics::getDamageKey(),
+_rFrame.m_aDamageHandler, 
nullptr);
+m_rFrame.m_pSvpGraphics->setSurface(pSurface, 
basegfx::B2IVector(nWidth, nHeight));
+UniqueCairoSurface old_surface(m_rFrame.m_pSurface.release());
+m_rFrame.m_pSurface.reset(pSurface);
+
+const int nMinWidth = qMin(nOldWidth, nWidth);
+const int nMinHeight = qMin(nOldHeight, nHeight);
+SalTwoRect rect(0, 0, nMinWidth, nMinHeight, 0, 0, nMinWidth, 
nMinHeight);
+m_rFrame.m_pSvpGraphics->copySource(rect, old_surface.get());
+}
 }
 }
 else
 {
-QImage* pImage = nullptr;
-
-if (m_rFrame.m_pQImage)
-pImage = new QImage(m_rFrame.m_pQImage->copy(0, 0, nWidth, 
nHeight));
-else
+if (m_rFrame.m_pQImage && m_rFrame.m_pQImage->size() != QSize(nWidth, 
nHeight))
 {
-pImage = new QImage(nWidth, nHeight, Qt_DefaultFormat32);
-pImage->fill(Qt::transparent);
+QImage* pImage = new QImage(m_rFrame.m_pQImage->copy(0, 0, nWidth, 
nHeight));
+m_rFrame.m_pQtGraphics->ChangeQImage(pImage);
+m_rFrame.m_pQImage.reset(pImage);
 }
-
-m_rFrame.m_pQtGraphics->ChangeQImage(pImage);
-m_rFrame.m_pQImage.reset(pImage);
 }
 
 m_rFrame.CallCallback(SalEvent::Resize, nullptr);


[Libreoffice-commits] core.git: sc/source

2022-05-31 Thread Eike Rathke (via logerrit)
 sc/source/ui/view/tabview3.cxx |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit c30306ad19f7ba022628f4f88ba5b92b8a1af402
Author: Eike Rathke 
AuthorDate: Tue May 31 22:48:28 2022 +0200
Commit: Eike Rathke 
CommitDate: Wed Jun 1 00:08:25 2022 +0200

MoveCursorAbs: it is cheaper to check for marks first and then formula mode

... so repeated travelling with cell cursor will be less affected.

Change-Id: I3f42356e66b2ec8acf60c0e0c777f8c34b9a952a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135211
Reviewed-by: Eike Rathke 
Tested-by: Jenkins

diff --git a/sc/source/ui/view/tabview3.cxx b/sc/source/ui/view/tabview3.cxx
index b261f04e0119..ae960b0a8c1f 100644
--- a/sc/source/ui/view/tabview3.cxx
+++ b/sc/source/ui/view/tabview3.cxx
@@ -1236,13 +1236,14 @@ void ScTabView::MoveCursorAbs( SCCOL nCurX, SCROW 
nCurY, ScFollowMode eMode,
 }
 else
 {
-if (!bShift && !SC_MOD()->IsFormulaMode())
+if (!bShift)
 {
 // Remove all marked data on cursor movement unless the Shift is
-// locked or while editing a formula.
+// locked or while editing a formula. It is cheaper to check for
+// marks first and then formula mode.
 ScMarkData& rMark = aViewData.GetMarkData();
 bool bMarked = rMark.IsMarked() || rMark.IsMultiMarked();
-if (bMarked)
+if (bMarked && !SC_MOD()->IsFormulaMode())
 {
 rMark.ResetMark();
 DoneBlockMode();


[Libreoffice-bugs] [Bug 103437] [META] Animation deck/tab of the sidebar

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103437

Eyal Rozenberg  changed:

   What|Removed |Added

 Depends on||149412


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=149412
[Bug 149412] Incorrect/unexpected click+drag behavior in animations list
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149412] Incorrect/unexpected click+drag behavior in animations list

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149412

Eyal Rozenberg  changed:

   What|Removed |Added

 Blocks||103437
 Whiteboard||NeedsUXEval


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103437
[Bug 103437] [META] Animation deck/tab of the sidebar
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149412] New: Incorrect/unexpected click+drag behavior in animations list

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149412

Bug ID: 149412
   Summary: Incorrect/unexpected click+drag behavior in animations
list
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: eyalr...@gmx.com

If I select several (consecutive) animation effects in the animations sidebar
pane, then click+drag them in some direction - instead of them all being
dragged, the click selects just one of them, and it alone gets dragged.

Build info: 
Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: d9b33ed6644203141fdb0776c291425c2bc9f5ac
CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-IL (en_IL); UI: en-US

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149409] Small Caps toolbar button invalidly grayed out

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149409

LeroyG  changed:

   What|Removed |Added

Version|7.4.0.0 alpha0+ Master  |7.2.3.2 release

--- Comment #2 from LeroyG  ---
Reproducible with:

Version: 7.2.3.2 / LibreOffice Community
Build ID: 20(Build:2)
CPU threads: 1; OS: Linux 5.3; UI render: default; VCL: gtk3
Locale: es-MX (es_ES.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 149406] What is expected behavior of padding for characters, with and without borders?

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149406

--- Comment #2 from LeroyG  ---
Try choosing menu Format - Paragraph - Alignment tab - Text-to-text, Alignment:

If set to Bottom, all blue rectangles will be aligned vertically.

Tested with version 7.2.3.2 on Linux.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 149406] What is expected behavior of padding for characters, with and without borders?

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149406

--- Comment #2 from LeroyG  ---
Try choosing menu Format - Paragraph - Alignment tab - Text-to-text, Alignment:

If set to Bottom, all blue rectangles will be aligned vertically.

Tested with version 7.2.3.2 on Linux.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149411] It's difficult to reach text area properties

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149411

Eyal Rozenberg  changed:

   What|Removed |Added

Summary|Often difficult to reach|It's difficult to reach
   |text area properties|text area properties

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 100373] [META] Style issues in Draw/Impress

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=100373

Eyal Rozenberg  changed:

   What|Removed |Added

 Depends on||149411


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=149411
[Bug 149411] Often difficult to reach text area properties
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149411] Often difficult to reach text area properties

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149411

Eyal Rozenberg  changed:

   What|Removed |Added

 CC||heiko.tietze@documentfounda
   ||tion.org
 Whiteboard||NeedsUXEval
 Blocks||100373


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=100373
[Bug 100373] [META] Style issues in Draw/Impress
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149411] New: Often difficult to reach text area properties

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149411

Bug ID: 149411
   Summary: Often difficult to reach text area properties
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: eyalr...@gmx.com

Suppose you have a box in Impress, and you want to modify the spacing between
its borders and its internal text area (a.k.a. its "padding").

You can do this via the content menu > Text Attributes > Text. This is already
not so great, as it's not really an "attribute of the text", but of the box.
That's the minor issue.

The major issue is that it's very difficult, or impossible, to get to these
settings from anywhere else:

* It's not on the main toolbar
* It's not on the text formatting toolbar (and even if it were, the infernal
app closes that on you as soon as you exist text editing mode)
* It's not in the Format menu
* Specifically, it's not in Format > Text, if you were somehow optimistic about
menu hierarchy consistency...
* It's not in any section of the properties sidebar - and you'll waste quite a
bit of time looking for it in "Area" and "Position and Size" maybe.

WTF?! That makes no sense at all.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149369] EDITING Form Controls: Default anchor should be set "To Page", not "To Paragraph"

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149369

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #5 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated today, I could reproduce this.

After some test, related code seems to be in wizards/com/sun/star/wizards/form
but I tried:
git grep -in anchor
and
git grep -in parag
it returns nothing.

Are you sure it's about anchor type?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149242] "Left paragraph border" -> "Left of paragraph text area" and "Right paragraph border" -> "Right of paragraph text area"

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149242

--- Comment #15 from sdc.bla...@youmail.dk ---
(In reply to Heiko Tietze from comment #14)
> Using "Left of paragraph text area" makes me wonder how
> this is different from just "Paragraph text area". 
A good thing imo. 

> we put a lot of thinking into the terminology expecting users to
> understand it from a single word change. 
Comment 9 argued against the idea that individual labels will be sufficient for
understanding positioning options and for the idea that understanding will come
contextually (as elaborated in comment 12) from comparing similar options,
which helps to build up a more general model of the positioning options.  That
you "wonder" about the relation between "left of para text area" and "para text
area" is already a step in the right direction.

> In the end feel free to change the label. No strong opinion and no better
> idea.
In any case, "border" is misleading and unhelpful. Also open to better ideas.

Meanwhile, here is the patch, but will wait a little for possible further
comment.

https://gerrit.libreoffice.org/c/core/+/135161

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149410] New: When set Conditional Format in a cell (color) it changes the colour of all of the cells

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149410

Bug ID: 149410
   Summary: When set Conditional Format in a cell (color) it
changes the colour of all of the cells
   Product: LibreOffice
   Version: 7.3.3.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: feder...@installer.com.ar

Description:
When using LibreOffice Calc and set a new Conditional Format for a particular
cell (background color) it changes the colour of all of the cells in the
complete sheet. Version 7.3.3.2 (x64) Windows 10. Language of application:
Spanish (español).

Steps to Reproduce:
1. Formato condicional -> Condicion -> El valor de la celda es igual a ... (Any
valid conditional argument)
2. Aplicar estilo: -> Estilo nuevo... -> Fondo -> Color (Choose any color)
3. Aceptar (at this step all the cells without a format become colored)

Actual Results:
A lot of cells has the cell color changed.

Expected Results:
Just the cell you have selected should be in a new color (when the condition
comes true).


Reproducible: Always


User Profile Reset: No



Additional Info:
No other information.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104428] exploded donut uses too small radius

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104428

kurt.nordb...@protonmail.com  changed:

   What|Removed |Added

 CC||kurt.nordb...@protonmail.co
   ||m

--- Comment #8 from kurt.nordb...@protonmail.com  
---
Created attachment 180509
  --> https://bugs.documentfoundation.org/attachment.cgi?id=180509=edit
MS Office rendering of the test case

It's not clear exactly what behavior is being requested here. This image shows
the MS Office rendering the analogous test case. The basic behavior is the same
as that of LO (other than a difference in angular convention, which is distinct
from the issue at hand).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/win

2022-05-31 Thread Jan-Marek Glogowski (via logerrit)
 vcl/win/window/salmenu.cxx |   30 ++
 1 file changed, 2 insertions(+), 28 deletions(-)

New commits:
commit 483f3125ecd4744cbcc2f8fd3cdf243d81a601ff
Author: Jan-Marek Glogowski 
AuthorDate: Tue May 31 21:14:00 2022 +0200
Commit: Jan-Marek Glogowski 
CommitDate: Tue May 31 22:45:40 2022 +0200

WIN drop effectively empty ImplDrawMenuBar

.. as VisibleMenuBar() just always returns false.

Change-Id: Ie793d84d57970cbf08b81b6ec0350b9b5fd4192c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135210
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 

diff --git a/vcl/win/window/salmenu.cxx b/vcl/win/window/salmenu.cxx
index 6f8dc8bff283..91a15284aeb5 100644
--- a/vcl/win/window/salmenu.cxx
+++ b/vcl/win/window/salmenu.cxx
@@ -96,19 +96,6 @@ std::unique_ptr WinSalInstance::CreateMenuItem( 
const SalItemParams
 return std::unique_ptr(pSalMenuItem);
 }
 
-static void ImplDrawMenuBar( SalMenu *pMenu )
-{
-if( pMenu->VisibleMenuBar() )
-{
-// redrawing the menubar all the time actually seems to be unnecessary 
(it just flickers)
-/*
-WinSalMenu *pMenuBar = ImplFindMenuBar( pMenu );
-if( pMenuBar && pMenuBar->mhWnd )
-::DrawMenuBar( pMenuBar->mhWnd );
-*/
-}
-}
-
 /*
  * WinSalMenu
  */
@@ -166,10 +153,7 @@ void WinSalMenu::InsertItem( SalMenuItem* pSalMenuItem, 
unsigned nPos )
 if(!::InsertMenuItemW( mhMenu, nPos, TRUE, >mInfo ))
 myerr = GetLastError();
 else
-{
 pWItem->mpSalMenu = this;
-ImplDrawMenuBar( this );
-}
 }
 }
 
@@ -194,7 +178,6 @@ void WinSalMenu::RemoveItem( unsigned nPos )
 {
 if( pSalMenuItem )
 pSalMenuItem->mpSalMenu = nullptr;
-ImplDrawMenuBar( this );
 }
 }
 }
@@ -220,7 +203,6 @@ static void ImplRemoveItemById( WinSalMenu *pSalMenu, 
unsigned nItemId )
 {
 if( pSalMenuItem )
 pSalMenuItem->mpSalMenu = nullptr;
-ImplDrawMenuBar( pSalMenu );
 }
 }
 
@@ -247,21 +229,17 @@ void WinSalMenu::SetSubMenu( SalMenuItem* pSalMenuItem, 
SalMenu* pSubMenu, unsig
 
 if(!::SetMenuItemInfoW( mhMenu, nPos, TRUE, >mInfo ) )
 myerr = GetLastError();
-else
-ImplDrawMenuBar( this );
 }
 }
 
 void WinSalMenu::CheckItem( unsigned nPos, bool bCheck )
 {
-if( static_cast( -1 ) != ::CheckMenuItem( mhMenu, nPos, 
MF_BYPOSITION|(bCheck ? MF_CHECKED : MF_UNCHECKED) ) )
-ImplDrawMenuBar( this );
+::CheckMenuItem(mhMenu, nPos, MF_BYPOSITION|(bCheck ? MF_CHECKED : 
MF_UNCHECKED));
 }
 
 void WinSalMenu::EnableItem( unsigned nPos, bool bEnable )
 {
-if( -1 != ::EnableMenuItem( mhMenu, nPos, MF_BYPOSITION|(bEnable ? 
MF_ENABLED : (MF_DISABLED|MF_GRAYED) ) ) )
-ImplDrawMenuBar( this );
+::EnableMenuItem(mhMenu, nPos, MF_BYPOSITION|(bEnable ? MF_ENABLED : 
(MF_DISABLED|MF_GRAYED)));
 }
 
 void WinSalMenu::SetItemImage( unsigned /*nPos*/, SalMenuItem* pSalMenuItem, 
const Image& rImage )
@@ -298,8 +276,6 @@ void WinSalMenu::SetItemText( unsigned nPos, SalMenuItem* 
pSalMenuItem, const OU
 
 if(!::SetMenuItemInfoW( mhMenu, nPos, TRUE, >mInfo ))
 myerr = GetLastError();
-else
-ImplDrawMenuBar( this );
 }
 }
 
@@ -323,8 +299,6 @@ void WinSalMenu::SetAccelerator( unsigned nPos, 
SalMenuItem* pSalMenuItem, const
 
 if(!::SetMenuItemInfoW( mhMenu, nPos, TRUE, >mInfo ))
 myerr = GetLastError();
-else
-ImplDrawMenuBar( this );
 }
 }
 


[Libreoffice-commits] core.git: basic/source

2022-05-31 Thread Stephan Bergmann (via logerrit)
 basic/source/sbx/sbxarray.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit bd279d30025e13125e9c5736f7baa9b00484156d
Author: Stephan Bergmann 
AuthorDate: Tue May 31 20:40:55 2022 +0200
Commit: Stephan Bergmann 
CommitDate: Tue May 31 22:42:34 2022 +0200

Use more appropriate index variable type

Change-Id: I0a6de93876d316a1aa094cf98dc2ee5c7eddebbf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135205
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/basic/source/sbx/sbxarray.cxx b/basic/source/sbx/sbxarray.cxx
index 4bd933b126ad..ec95e5e10602 100644
--- a/basic/source/sbx/sbxarray.cxx
+++ b/basic/source/sbx/sbxarray.cxx
@@ -24,6 +24,7 @@
 #include 
 #include 
 
+#include 
 #include 
 
 struct SbxVarEntry
@@ -562,7 +563,7 @@ bool SbxDimArray::StoreData( SvStream& rStrm ) const
 {
 assert(m_vDimensions.size() <= 
sal::static_int_cast(std::numeric_limits::max()));
 rStrm.WriteInt16( m_vDimensions.size() );
-for( sal_Int32 i = 1; i <= static_cast(m_vDimensions.size()); 
i++ )
+for( std::size_t i = 1; i <= m_vDimensions.size(); i++ )
 {
 sal_Int32 lb32, ub32;
 GetDim(i, lb32, ub32);


[Libreoffice-commits] core.git: animations/source

2022-05-31 Thread Stephan Bergmann (via logerrit)
 animations/source/animcore/animcore.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit d1cdf9a24de0d87f22e283f5cb2ed93ff6e83ee6
Author: Stephan Bergmann 
AuthorDate: Tue May 31 20:35:26 2022 +0200
Commit: Stephan Bergmann 
CommitDate: Tue May 31 22:42:14 2022 +0200

Also assert that nNodeType is non-negative

...given that nNodeType aka AnimationNode::mnNodeType is later used as an 
index
into the AnimationNode::mpTypes array

Change-Id: Ic208fbdfaa8dcca44ff2a99cf3b169904b14a4bf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135203
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/animations/source/animcore/animcore.cxx 
b/animations/source/animcore/animcore.cxx
index c02ba3ca2878..737da604a594 100644
--- a/animations/source/animcore/animcore.cxx
+++ b/animations/source/animcore/animcore.cxx
@@ -55,6 +55,7 @@
 
 #include 
 
+#include 
 #include 
 #include 
 #include 
@@ -446,7 +447,7 @@ AnimationNode::AnimationNode( sal_Int16 nNodeType )
 mnIterateType( css::presentation::ShapeAnimationSubType::AS_WHOLE ),
 mfIterateInterval(0.0)
 {
-assert(nNodeType < int(mpTypes.size()));
+assert(nNodeType >= 0 && o3tl::make_unsigned(nNodeType) < mpTypes.size());
 }
 
 AnimationNode::AnimationNode( const AnimationNode& rNode )


[Libreoffice-commits] core.git: sc/source

2022-05-31 Thread Eike Rathke (via logerrit)
 sc/source/ui/view/tabview3.cxx |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 93a3f142bf46eb7b4309cd168354fe2a971e196d
Author: Eike Rathke 
AuthorDate: Tue May 31 20:25:37 2022 +0200
Commit: Eike Rathke 
CommitDate: Tue May 31 22:40:23 2022 +0200

MoveCursorAbs: do not reset selection marks while editing a formula

i.e. when moving the cursor for reference selection, so an
existing mark is preserved for Alt+Enter or Shift+Ctrl+Enter.

Change-Id: I3a73145b4e3e299fa9eb28e2198338e76ffe5093
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135202
Reviewed-by: Eike Rathke 
Tested-by: Jenkins

diff --git a/sc/source/ui/view/tabview3.cxx b/sc/source/ui/view/tabview3.cxx
index 5c706bab5f11..b261f04e0119 100644
--- a/sc/source/ui/view/tabview3.cxx
+++ b/sc/source/ui/view/tabview3.cxx
@@ -1236,9 +1236,10 @@ void ScTabView::MoveCursorAbs( SCCOL nCurX, SCROW nCurY, 
ScFollowMode eMode,
 }
 else
 {
-if (!bShift)
+if (!bShift && !SC_MOD()->IsFormulaMode())
 {
-// Remove all marked data on cursor movement unless the Shift is 
locked.
+// Remove all marked data on cursor movement unless the Shift is
+// locked or while editing a formula.
 ScMarkData& rMark = aViewData.GetMarkData();
 bool bMarked = rMark.IsMarked() || rMark.IsMultiMarked();
 if (bMarked)


[Libreoffice-bugs] [Bug 101756] [META] Table styles bugs and enhancements

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=101756

Eyal Rozenberg  changed:

   What|Removed |Added

 Depends on||149360


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=149360
[Bug 149360] No UI for setting alternating table row backgrounds
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 100366] [META] Impress/Draw table bugs and enhancements

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=100366

Eyal Rozenberg  changed:

   What|Removed |Added

 Depends on||149360


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=149360
[Bug 149360] No UI for setting alternating table row backgrounds
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149360] No UI for setting alternating table row backgrounds

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149360

Eyal Rozenberg  changed:

   What|Removed |Added

 Blocks||100366, 101756


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=100366
[Bug 100366] [META] Impress/Draw table bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=101756
[Bug 101756] [META] Table styles bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: compilerplugins/clang vcl/inc vcl/jsdialog

2022-05-31 Thread Szymon Kłos (via logerrit)
 compilerplugins/clang/badstatics.cxx |1 
 vcl/inc/jsdialog/jsdialogbuilder.hxx |9 +
 vcl/jsdialog/jsdialogbuilder.cxx |   56 +--
 3 files changed, 64 insertions(+), 2 deletions(-)

New commits:
commit 09847cdbd435c1f6ac8c0ac0256f8be488edd194
Author: Szymon Kłos 
AuthorDate: Wed May 18 23:28:30 2022 +0200
Commit: Szymon Kłos 
CommitDate: Tue May 31 22:09:42 2022 +0200

jsdialog: introduce popup management

Popup windows are managed by vcl (some moving between parents
happens on show/hide popup).

We need to access correct popup window to correctly close
popup in LOK. So remember popup instances.

Change-Id: I9e1ba18ded5a1bf675f95bd7178043eebd9bbd5a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134576
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Mert Tumer 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134675
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135197
Tested-by: Jenkins
Reviewed-by: Szymon Kłos 

diff --git a/compilerplugins/clang/badstatics.cxx 
b/compilerplugins/clang/badstatics.cxx
index 9539559f699e..3b80278a2f4f 100644
--- a/compilerplugins/clang/badstatics.cxx
+++ b/compilerplugins/clang/badstatics.cxx
@@ -208,6 +208,7 @@ public:
 .Class("ScDocument").GlobalNamespace()) // not owning
 || name == "s_aLOKWindowsMap" // LOK only, guarded by assert, 
and LOK never tries to perform a VCL cleanup
 || name == "s_aLOKWeldBuildersMap" // LOK only, similar case 
as above
+|| name == "s_aLOKPopupsMap" // LOK only, similar case as above
 || name == "m_pNotebookBarWeldedWrapper" // LOK only, warning 
about map's key, no VCL cleanup performed
 || name == "gStaticManager" // vcl/source/graphic/Manager.cxx 
- stores non-owning pointers
 || name == "aThreadedInterpreterPool"// 
ScInterpreterContext(Pool), not owning
diff --git a/vcl/inc/jsdialog/jsdialogbuilder.hxx 
b/vcl/inc/jsdialog/jsdialogbuilder.hxx
index 0b0289240bf6..a25aeac55c10 100644
--- a/vcl/inc/jsdialog/jsdialogbuilder.hxx
+++ b/vcl/inc/jsdialog/jsdialogbuilder.hxx
@@ -304,6 +304,11 @@ public:
weld::Widget* pWidget);
 static void RemoveWindowWidget(const std::string& nWindowId);
 
+// we need to remember original popup window to close it properly (its 
handled by vcl)
+static void RememberPopup(const std::string& nWindowId, 
VclPtr pWidget);
+static void ForgetPopup(const std::string& nWindowId);
+static vcl::Window* FindPopup(const std::string& nWindowId);
+
 private:
 const std::string& GetTypeOfJSON() const;
 VclPtr& GetContentWindow();
@@ -700,6 +705,8 @@ public:
 
 class JSPopover : public JSWidget
 {
+vcl::LOKWindowId mnWindowId;
+
 public:
 JSPopover(JSDialogSender* pSender, DockingWindow* pPopover, 
SalInstanceBuilder* pBuilder,
   bool bTakeOwnership);
@@ -707,6 +714,8 @@ public:
 virtual void popup_at_rect(weld::Widget* pParent, const tools::Rectangle& 
rRect,
weld::Placement ePlace = 
weld::Placement::Under) override;
 virtual void popdown() override;
+
+void set_window_id(vcl::LOKWindowId nWindowId) { mnWindowId = nWindowId; }
 };
 
 class JSBox : public JSWidget
diff --git a/vcl/jsdialog/jsdialogbuilder.cxx b/vcl/jsdialog/jsdialogbuilder.cxx
index b1ca111a07f7..3648d33b3ebc 100644
--- a/vcl/jsdialog/jsdialogbuilder.cxx
+++ b/vcl/jsdialog/jsdialogbuilder.cxx
@@ -27,6 +27,14 @@
 #include 
 #include 
 
+static std::map& GetLOKPopupsMap()
+{
+// Map to remember the LOKWindowId <-> vcl popup binding.
+static std::map s_aLOKPopupsMap;
+
+return s_aLOKPopupsMap;
+}
+
 namespace
 {
 void response_help(vcl::Window* pWindow)
@@ -670,6 +678,8 @@ JSInstanceBuilder::~JSInstanceBuilder()
   [it](std::string& sId) { 
it->second.erase(sId.c_str()); });
 }
 }
+
+GetLOKPopupsMap().erase(std::to_string(m_nWindowId));
 }
 
 std::map& JSInstanceBuilder::GetLOKWeldWidgetsMap()
@@ -762,6 +772,28 @@ void JSInstanceBuilder::RemoveWindowWidget(const 
std::string& nWindowId)
 }
 }
 
+void JSInstanceBuilder::RememberPopup(const std::string& nWindowId, 
VclPtr pWidget)
+{
+GetLOKPopupsMap()[nWindowId] = pWidget;
+}
+
+void JSInstanceBuilder::ForgetPopup(const std::string& nWindowId)
+{
+auto it = GetLOKPopupsMap().find(nWindowId);
+if (it != GetLOKPopupsMap().end())
+GetLOKPopupsMap().erase(it);
+}
+
+vcl::Window* JSInstanceBuilder::FindPopup(const std::string& nWindowId)
+{
+const auto it = GetLOKPopupsMap().find(nWindowId);
+
+if (it != GetLOKPopupsMap().end())
+return it->second;
+
+return nullptr;
+}
+
 const std::string& JSInstanceBuilder::GetTypeOfJSON() const { return 
m_sTypeOfJSON; }
 
 VclPtr& JSInstanceBuilder::GetContentWindow()
@@ -1048,8 +1080,9 @@ std::unique_ptr 

[Libreoffice-bugs] [Bug 149360] No UI for setting alternating table row backgrounds

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149360

Eyal Rozenberg  changed:

   What|Removed |Added

 Resolution|DUPLICATE   |---
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=92
   ||234
 Status|RESOLVED|UNCONFIRMED

--- Comment #3 from Eyal Rozenberg  ---
(In reply to Timur from comment #2)
> This would be a dupe of bug 92234, which is Writer

So, not a dupe of that yet, since it's not the same UI (and that bug is not for
all of LO)

> but there's bug 101802 so it should be the same.

That one is:

1. About the sidebar and
2. Not resolved yet

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 92234] Table style needs UI to alter first/odd/even/last/header row background colours

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=92234

Eyal Rozenberg  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||9360

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 101802] Consolidate Writer and Draw/Impress sidebar table design content panel

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=101802

--- Comment #6 from Eyal Rozenberg  ---
Is this only about the sidebar, or about the table properties dialog(s) as
well?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: basic/source

2022-05-31 Thread Stephan Bergmann (via logerrit)
 basic/source/classes/image.cxx |4 ++--
 basic/source/inc/image.hxx |3 ++-
 2 files changed, 4 insertions(+), 3 deletions(-)

New commits:
commit b19a2dfafa366f5fea1b70a1bae2d39a76a54a8e
Author: Stephan Bergmann 
AuthorDate: Tue May 31 20:39:43 2022 +0200
Commit: Stephan Bergmann 
CommitDate: Tue May 31 22:03:42 2022 +0200

Use more appropriate type for SbiImage::nStringIdx

Change-Id: I1448739b373c6f7b9f5e6ee5a725fa0a129a4fb4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135204
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/basic/source/classes/image.cxx b/basic/source/classes/image.cxx
index 229dc8058518..677e0a68c8f1 100644
--- a/basic/source/classes/image.cxx
+++ b/basic/source/classes/image.cxx
@@ -578,7 +578,7 @@ void SbiImage::MakeStrings( short nSize )
 // growing in 1K-Steps
 void SbiImage::AddString( const OUString& r )
 {
-if( nStringIdx >= short(mvStringOffsets.size()) )
+if( nStringIdx >= mvStringOffsets.size() )
 {
 bError = true;
 }
@@ -606,7 +606,7 @@ void SbiImage::AddString( const OUString& r )
 memcpy( pStrings.get() + nStringOff, r.getStr(), len * sizeof( 
sal_Unicode ) );
 nStringOff = nStringOff + len;
 // Last String? The update the size of the buffer
-if( nStringIdx >= short(mvStringOffsets.size()) )
+if( nStringIdx >= mvStringOffsets.size() )
 {
 nStringSize = nStringOff;
 }
diff --git a/basic/source/inc/image.hxx b/basic/source/inc/image.hxx
index b33009c1e029..4bd4201a46f9 100644
--- a/basic/source/inc/image.hxx
+++ b/basic/source/inc/image.hxx
@@ -23,6 +23,7 @@
 #include 
 #include "filefmt.hxx"
 #include 
+#include 
 #include 
 
 // This class reads in the image that's been produced by the compiler
@@ -56,7 +57,7 @@ class SbiImage {
 sal_uInt16 nDimBase;// OPTION BASE value
 rtl_TextEncoding eCharSet;
 // temporary management-variable:
-short  nStringIdx;
+std::size_tnStringIdx;
 sal_uInt32 nStringOff;  // current Pos in the stringbuffer
 // routines for the compiler:
 void MakeStrings( short );  // establish StringPool


[Libreoffice-commits] core.git: slideshow/source

2022-05-31 Thread Stephan Bergmann (via logerrit)
 slideshow/source/engine/animationnodes/basecontainernode.cxx |7 ---
 slideshow/source/engine/shapes/appletshape.cxx   |7 ---
 slideshow/source/engine/shapes/backgroundshape.cxx   |7 ---
 slideshow/source/engine/shapes/drawshape.cxx |7 ---
 slideshow/source/engine/shapes/mediashape.cxx|7 ---
 5 files changed, 20 insertions(+), 15 deletions(-)

New commits:
commit 4c60697daaecc8be0a00e900ba1b4b62713e43df
Author: Stephan Bergmann 
AuthorDate: Tue May 31 20:47:59 2022 +0200
Commit: Stephan Bergmann 
CommitDate: Tue May 31 22:03:22 2022 +0200

The return value of std::count_if is guaranteed to be non-negative

...so use o3tl::make_unsigned when comparing it against an expression of
unsigned integer type, instead of casting that expression to a signed type

Change-Id: I487fd04eafbf8c56b8b6bfce579b477d8f34a052
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135206
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/slideshow/source/engine/animationnodes/basecontainernode.cxx 
b/slideshow/source/engine/animationnodes/basecontainernode.cxx
index cde434f3d7bd..709f5392ac8a 100644
--- a/slideshow/source/engine/animationnodes/basecontainernode.cxx
+++ b/slideshow/source/engine/animationnodes/basecontainernode.cxx
@@ -24,6 +24,7 @@
 #include 
 #include "nodetools.hxx"
 #include 
+#include 
 #include 
 
 #include 
@@ -80,10 +81,10 @@ bool BaseContainerNode::init_children()
 mnFinishedChildren = 0;
 
 // initialize all children
-return (std::count_if(
+return (o3tl::make_unsigned(std::count_if(
 maChildren.begin(), maChildren.end(),
-std::mem_fn(::init) ) ==
-static_cast(maChildren.size()));
+std::mem_fn(::init) )) ==
+maChildren.size());
 }
 
 void BaseContainerNode::deactivate_st( NodeState eDestState )
diff --git a/slideshow/source/engine/shapes/appletshape.cxx 
b/slideshow/source/engine/shapes/appletshape.cxx
index 102dc6aaf3f4..ba7c6243b30b 100644
--- a/slideshow/source/engine/shapes/appletshape.cxx
+++ b/slideshow/source/engine/shapes/appletshape.cxx
@@ -23,6 +23,7 @@
 #include "viewappletshape.hxx"
 #include 
 
+#include 
 #include 
 
 #include 
@@ -210,12 +211,12 @@ namespace slideshow::internal
 bool AppletShape::implRender( const ::basegfx::B2DRange& rCurrBounds ) 
const
 {
 // redraw all view shapes, by calling their update() method
-if( ::std::count_if( maViewAppletShapes.begin(),
+if( o3tl::make_unsigned(::std::count_if( 
maViewAppletShapes.begin(),
  maViewAppletShapes.end(),
  []
  ( const ViewAppletShapeSharedPtr& pShape )
- { return pShape->render( rCurrBounds ); } )
-!= 
static_cast(maViewAppletShapes.size()) )
+ { return pShape->render( rCurrBounds ); } ))
+!= maViewAppletShapes.size() )
 {
 // at least one of the ViewShape::update() calls did return
 // false - update failed on at least one ViewLayer
diff --git a/slideshow/source/engine/shapes/backgroundshape.cxx 
b/slideshow/source/engine/shapes/backgroundshape.cxx
index b107fe4af038..d304b9f901e6 100644
--- a/slideshow/source/engine/shapes/backgroundshape.cxx
+++ b/slideshow/source/engine/shapes/backgroundshape.cxx
@@ -21,6 +21,7 @@
 #include 
 
 #include 
+#include 
 #include 
 
 #include 
@@ -258,11 +259,11 @@ namespace slideshow::internal
 }
 
 // redraw all view shapes, by calling their render() method
-if( ::std::count_if( maViewShapes.begin(),
+if( o3tl::make_unsigned(::std::count_if( maViewShapes.begin(),
  maViewShapes.end(),
  [this]( const ViewBackgroundShapeSharedPtr& 
pBgShape )
- { return pBgShape->render( this->mpMtf ); } )
-!= 
static_cast(maViewShapes.size()) )
+ { return pBgShape->render( this->mpMtf ); } ))
+!= maViewShapes.size() )
 {
 // at least one of the ViewBackgroundShape::render() calls did 
return
 // false - update failed on at least one ViewLayer
diff --git a/slideshow/source/engine/shapes/drawshape.cxx 
b/slideshow/source/engine/shapes/drawshape.cxx
index f8e03ebff36f..22b65bf28e21 100644
--- a/slideshow/source/engine/shapes/drawshape.cxx
+++ b/slideshow/source/engine/shapes/drawshape.cxx
@@ -21,6 +21,7 @@
 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -146,15 +147,15 @@ namespace slideshow::internal
 // redraw all view shapes, by calling their update() method
 ViewShape::RenderArgs renderArgs( getViewRenderArgs() 

[Libreoffice-bugs] [Bug 149409] Small Caps toolbar button invalidly grayed out

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149409

--- Comment #1 from Eyal Rozenberg  ---
I should mention that, in LO Writer, the toolbar button is not grayed out and
works fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147732] font effect "small caps" does not work in Impress

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147732

Eyal Rozenberg  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||9409

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149409] Small Caps toolbar button invalidly grayed out

2022-05-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149409

Eyal Rozenberg  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||7732

-- 
You are receiving this mail because:
You are the assignee for the bug.

  1   2   3   4   >