[Libreoffice-bugs] [Bug 91063] [META] SIDEBAR: Properties tab for Charts
https://bugs.documentfoundation.org/show_bug.cgi?id=91063 Aron Budea changed: What|Removed |Added Depends on|116838 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=116838 [Bug 116838] EDITING Not possible to edit chart from sidebar (steps on comment 4) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 116838] EDITING Not possible to edit chart from sidebar (steps on comment 4)
https://bugs.documentfoundation.org/show_bug.cgi?id=116838 Aron Budea changed: What|Removed |Added Blocks|91063 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=91063 [Bug 91063] [META] SIDEBAR: Properties tab for Charts -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113688] Cannot set data series filling to pattern
https://bugs.documentfoundation.org/show_bug.cgi?id=113688 Aron Budea changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=11 | |6838| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 91063] [META] SIDEBAR: Properties tab for Charts
https://bugs.documentfoundation.org/show_bug.cgi?id=91063 Bug 91063 depends on bug 116838, which changed state. Bug 116838 Summary: EDITING Not possible to edit chart from sidebar (steps on comment 4) https://bugs.documentfoundation.org/show_bug.cgi?id=116838 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 94322] Unable to properly resize or hide the sidebar in chart edit mode
https://bugs.documentfoundation.org/show_bug.cgi?id=94322 Aron Budea changed: What|Removed |Added CC||emo_asse...@yahoo.com --- Comment #13 from Aron Budea --- *** Bug 116838 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 116838] EDITING Not possible to edit chart from sidebar (steps on comment 4)
https://bugs.documentfoundation.org/show_bug.cgi?id=116838 Aron Budea changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=10 | |0180, | |https://bugs.documentfounda | |tion.org/show_bug.cgi?id=11 | |3688| --- Comment #11 from Aron Budea --- Let's consolidate these into bug 94322, as they have the same root cause. *** This bug has been marked as a duplicate of bug 94322 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 116838] EDITING Not possible to edit chart from sidebar (steps on comment 4)
https://bugs.documentfoundation.org/show_bug.cgi?id=116838 Aron Budea changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=13 | |5890| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 91063] [META] SIDEBAR: Properties tab for Charts
https://bugs.documentfoundation.org/show_bug.cgi?id=91063 Aron Budea changed: What|Removed |Added Depends on|135890 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=135890 [Bug 135890] Chart Properties Sidebar broken when chart is double-clicked before opening the sidebar -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135890] Chart Properties Sidebar broken when chart is double-clicked before opening the sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=135890 Aron Budea changed: What|Removed |Added Blocks|91063 | Keywords|regression | See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=11 | |6838| Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=91063 [Bug 91063] [META] SIDEBAR: Properties tab for Charts -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 94322] Unable to properly resize or hide the sidebar in chart edit mode
https://bugs.documentfoundation.org/show_bug.cgi?id=94322 Aron Budea changed: What|Removed |Added CC||rafael.palma.l...@gmail.com --- Comment #12 from Aron Budea --- *** Bug 135890 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 91063] [META] SIDEBAR: Properties tab for Charts
https://bugs.documentfoundation.org/show_bug.cgi?id=91063 Bug 91063 depends on bug 135890, which changed state. Bug 135890 Summary: Chart Properties Sidebar broken when chart is double-clicked before opening the sidebar https://bugs.documentfoundation.org/show_bug.cgi?id=135890 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135890] Chart Properties Sidebar broken when chart is double-clicked before opening the sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=135890 Aron Budea changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #15 from Aron Budea --- Let's consolidate these into bug 94322, as they have the same root cause. *** This bug has been marked as a duplicate of bug 94322 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sw/source
sw/source/core/access/accpara.cxx |3 --- 1 file changed, 3 deletions(-) New commits: commit 2603a7d51d5c6a283831ba8b92af561eb5931692 Author: Michael Weghorn AuthorDate: Wed Jun 15 09:55:10 2022 +0200 Commit: Michael Weghorn CommitDate: Thu Jun 16 07:55:01 2022 +0200 tdf#147084 sw a11y: Ensure focus event gets sent when moving to table The code responsible for sending an a11y focus event when the cursor moves from elsewhere into e.g. a table cell depends on the fact that the cursor was previously not in that object, i.e. the previous/old cursor/caret position is -1, s. e.g. `SwAccessibleParagraph::InvalidateCursorPos_`. Already setting `m_nOldCaretPos` to the the actual cursor position instead of -1 in the `SwAccessibleParagraph` ctor resulted in that assumption no longer holding when initially moving the cursor into a table (cell), so no focus event would get sent and the NVDA screen reader on Windows would therefore also not refer to the correct a11y object when handling the subsequent CARET_CHANGED event and fail to retrieve the caret position in the previously focused object (because focus/cursor have moved on). Make focus announcement work by only setting `m_nOldCaretPos` to the actual cursor position when processing the corresponding events related to change of cursor position, not in the ctor. Setting the cursor pos already in the ctor had been added to fix an issue with IM handling in commit 817da76529aa39f641d76805d429b09681348811 Date: Sat Nov 8 19:37:22 2014 +0300 fdo#85912 Delete surrounding text failing for input method calls regression. When Apache OpenOffice code was merged in, a few lines were removed for no apparent reason. This just adds the code back in, and resolves the bug. See the comments in fdo#85912 for details about this bug. It is hard for majority language users to reproduce since they don't use ibus/kmfl to type their language's letters. The issue mentioned in the referenced tdf#85912 (== fdo#85912) is not reproducible for me with this change here in place either, neither with the gtk3 VCL plugin nor with kf5 (for which the relevant IM handling has been added in the context of tdf#149255, which has some more information on the ibus/kmfl setup needed to reproduce the original bug). The bug report already mentioned that the issue was reproducible with Linux 13 Mint and LibreOffice 4.3.3.2, but not Linux 17 Mint with exactly the same LO version, so without being able to analyze this any further, the best explanation I can come up with is that the root cause for tdf#85912 was somewhere else and has been fixed in the meanwhile. In hindsight, comment 5 in tdf#85912 already has further information on why adding the assignment back to the ctor was problematic: > Reviewed OpenOffice code as well. The missing lines exist (but are > commented out) in the current AOO code. The commenting out > occurred when Steven Ying implemented his huge "AOO IA2 enabled draft > version 1" change on 27 Sep 2013. > https://github.com/apache/openoffice/commit/0deba7fbda3d9908785c25a443701a293b6f4e71#diff-50d752f41bb880abd1094d09d9e1a7fc > > The current AOO comment is > // If this object has the focus, then it is remembered by the map itself. > // not necessary to remember this pos here. Generally, the pos will be updated in invalidateXXX method, which may fire the > //Focus event based on the difference of new & old caret pos. > //nOldCaretPos = GetCaretPos(); Change-Id: If8cd4e92bc1f6233775ccc2834230f3a388ccadb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135868 Reviewed-by: Justin Luth Tested-by: Jenkins Reviewed-by: Michael Weghorn (cherry picked from commit 38b14d4b61cdcf894d42e159bcf7aa8edab44de8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135941 diff --git a/sw/source/core/access/accpara.cxx b/sw/source/core/access/accpara.cxx index 1447b97a6dbd..94a1df603c4a 100644 --- a/sw/source/core/access/accpara.cxx +++ b/sw/source/core/access/accpara.cxx @@ -412,9 +412,6 @@ SwAccessibleParagraph::SwAccessibleParagraph( //Get the real heading level, Heading1 ~ Heading10 m_nHeadingLevel = GetRealHeadingLevel(); SetName( OUString() ); // set an empty accessibility name for paragraphs - -// If this object has the focus, then it is remembered by the map itself. -m_nOldCaretPos = GetCaretPos(); } SwAccessibleParagraph::~SwAccessibleParagraph()
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - framework/source
framework/source/dispatch/closedispatcher.cxx | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
New commits:
commit 2154945c4b1ed6dfe365f50e318c47b9fafbf4ee
Author: Samuel Mehrbrodt
AuthorDate: Wed Jun 15 14:25:36 2022 +0200
Commit: Samuel Mehrbrodt
CommitDate: Thu Jun 16 07:49:53 2022 +0200
Show start center when closing last document
also when there are active UNO connections.
(Behavior was different when there were active UNO connections)
Change-Id: Ief37b0f362b7e2a47eccbec985ee3017c475046c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135905
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt
(cherry picked from commit 539374caa5deac788f394a54a75b6e167ab04864)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135939
diff --git a/framework/source/dispatch/closedispatcher.cxx
b/framework/source/dispatch/closedispatcher.cxx
index 19fe9ffaa69d..a6ff39d459c3 100644
--- a/framework/source/dispatch/closedispatcher.cxx
+++ b/framework/source/dispatch/closedispatcher.cxx
@@ -353,12 +353,17 @@ IMPL_LINK_NOARG(CloseDispatcher, impl_asyncCallback,
LinkParamNone*, void)
// application or establish the backing mode now.
// And that depends from the dispatched URL ...
{
-if (bHasActiveConnections)
-bCloseFrame = true;
-else if (eOperation == E_CLOSE_FRAME)
-bTerminateApp = true;
+if (eOperation == E_CLOSE_FRAME)
+{
+if (bHasActiveConnections)
+bCloseFrame = true;
+else
+bTerminateApp = true;
+}
else if(
SvtModuleOptions().IsModuleInstalled(SvtModuleOptions::EModule::STARTMODULE) )
bEstablishBackingMode = true;
+else if (bHasActiveConnections)
+bCloseFrame = true;
else
bTerminateApp = true;
}
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - vcl/source
vcl/source/treelist/treelist.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 8d2523f824e377c886621432b208ac420b6bcd14
Author: Samuel Mehrbrodt
AuthorDate: Wed Jun 15 16:54:55 2022 +0200
Commit: Samuel Mehrbrodt
CommitDate: Thu Jun 16 07:49:29 2022 +0200
Make sure pEntry is not null
Crash seen:
> mergedlo.dll!SvTreeList::GetDepth(const SvTreeListEntry * pEntry)
line 106
mergedlo.dll!SalInstanceTreeView::get_iter_depth(const
weld::TreeIter & rIter) line 4230
basctllo.dll!basctl::SbTreeListBox::FindVariable(const
weld::TreeIter * pEntry) line 271
basctllo.dll!basctl::SbTreeListBox::FindModule(const weld::TreeIter
* pEntry) line 695
basctllo.dll!basctl::MacroChooser::BasicSelectHdl(weld::TreeView &
__formal) line 473
basctllo.dll!basctl::MacroChooser::RestoreMacroDescription() line
158
basctllo.dll!basctl::MacroChooser::run() line 178
Change-Id: Ic85758c0bbee952d0a23b1d52e8bbdd231e8de26
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135914
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt
(cherry picked from commit 79f820b6822f8d3578975a4757b4293728c8c717)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135937
diff --git a/vcl/source/treelist/treelist.cxx b/vcl/source/treelist/treelist.cxx
index 07db41b54266..f118e5e35637 100644
--- a/vcl/source/treelist/treelist.cxx
+++ b/vcl/source/treelist/treelist.cxx
@@ -103,7 +103,7 @@ sal_uInt16 SvTreeList::GetDepth( const SvTreeListEntry*
pEntry ) const
{
DBG_ASSERT(pEntry && pEntry!=pRootItem.get(),"GetDepth:Bad Entry");
sal_uInt16 nDepth = 0;
-while( pEntry->pParent != pRootItem.get() )
+while( pEntry && pEntry->pParent != pRootItem.get() )
{
nDepth++;
pEntry = pEntry->pParent;
[Libreoffice-bugs] [Bug 147201] Progress in Wayland scaling on KF5 but still not there
https://bugs.documentfoundation.org/show_bug.cgi?id=147201 --- Comment #21 from pieter kristensen --- Created attachment 180791 --> https://bugs.documentfoundation.org/attachment.cgi?id=180791=edit Styles box in LO Writer 7.4 beta 1 still not properly scaled in Wayland The styles box of LO Writer 7.4 beta 1 also still isn't properly scaled on my Neon user edition plasma 5.25 machine. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 90486] [META] Chart bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=90486 Aron Budea changed: What|Removed |Added Depends on|107748 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107748 [Bug 107748] When resizing window after inserting chart and remaining in the chart mode, there are UI glitches -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 94322] Unable to properly resize or hide the sidebar in chart edit mode
https://bugs.documentfoundation.org/show_bug.cgi?id=94322 Aron Budea changed: What|Removed |Added CC||ccshel...@gmail.com --- Comment #11 from Aron Budea --- *** Bug 107748 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107748] When resizing window after inserting chart and remaining in the chart mode, there are UI glitches
https://bugs.documentfoundation.org/show_bug.cgi?id=107748 Aron Budea changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED Blocks|90486 | --- Comment #10 from Aron Budea --- Let's mark this as dupe of bug 94322. *** This bug has been marked as a duplicate of bug 94322 *** Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=90486 [Bug 90486] [META] Chart bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147201] Progress in Wayland scaling on KF5 but still not there
https://bugs.documentfoundation.org/show_bug.cgi?id=147201 --- Comment #20 from pieter kristensen --- Created attachment 180790 --> https://bugs.documentfoundation.org/attachment.cgi?id=180790=edit "avatars" of recently used files are still not properly scaled (too small) I just tried LO 7.4 beta 1 and the "avatars" of the recently used files in the start-center are imho still not properly scaled in wayland. They are too small. I use plasma 5.25 and Neon user edition. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: oox/source
oox/source/drawingml/drawingmltypes.cxx | 21 +
1 file changed, 17 insertions(+), 4 deletions(-)
New commits:
commit cbbb67e05709e89bca60ae241342d6647ea64f79
Author: Mike Kaganski
AuthorDate: Wed Jun 15 15:04:07 2022 +0200
Commit: Mike Kaganski
CommitDate: Thu Jun 16 06:45:16 2022 +0200
Correct parsing of ST_Percentage
Change-Id: I227b2abd493d3a4ce6f4e4dcd256aa29653fdce0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135886
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/oox/source/drawingml/drawingmltypes.cxx
b/oox/source/drawingml/drawingmltypes.cxx
index 6ce901ab1ef9..fc2f28d902b7 100644
--- a/oox/source/drawingml/drawingmltypes.cxx
+++ b/oox/source/drawingml/drawingmltypes.cxx
@@ -23,6 +23,8 @@
#include
#include
#include
+
+#include
#include
#include
#include
@@ -374,15 +376,26 @@ const char* GetHatchPattern( const drawing::Hatch& rHatch
)
return sPattern;
}
+namespace
+{
+// ISO/IEC-29500 Part 1 ST_Percentage, and [MS-OI29500] 2.1.1324
+sal_Int32 GetST_Percentage(std::u16string_view s)
+{
+if (o3tl::ends_with(s, u"%"))
+return std::round(o3tl::toDouble(s) * 1000);
+return o3tl::toInt32(s);
+}
+}
+
/** converts the attributes from a CT_RelativeRect to an IntegerRectangle2D */
IntegerRectangle2D GetRelativeRect( const Reference< XFastAttributeList >&
xAttribs )
{
IntegerRectangle2D r;
-r.X1 = xAttribs->getOptionalValue( XML_l ).toInt32();
-r.Y1 = xAttribs->getOptionalValue( XML_t ).toInt32();
-r.X2 = xAttribs->getOptionalValue( XML_r ).toInt32();
-r.Y2 = xAttribs->getOptionalValue( XML_b ).toInt32();
+r.X1 = GetST_Percentage(xAttribs->getOptionalValue( XML_l ));
+r.Y1 = GetST_Percentage(xAttribs->getOptionalValue( XML_t ));
+r.X2 = GetST_Percentage(xAttribs->getOptionalValue( XML_r ));
+r.Y2 = GetST_Percentage(xAttribs->getOptionalValue( XML_b ));
return r;
}
[Libreoffice-bugs] [Bug 32357] Autocomplete is not language sensitive
https://bugs.documentfoundation.org/show_bug.cgi?id=32357 Dieter changed: What|Removed |Added CC||giuli...@people.it --- Comment #18 from Dieter --- *** Bug 149443 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149443] [enhancement] select language for word completion
https://bugs.documentfoundation.org/show_bug.cgi?id=149443 Dieter changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE CC||dgp-m...@gmx.de --- Comment #3 from Dieter --- If there are different word completions you can select one with ctrl+tab, see https://help.libreoffice.org/7.3/en-GB/text/swriter/guide/word_completion.html?=WRITER=WIN I think, this would solve your problem. But I think, there should be something that indicates different words for word completion. Your idea of a language sensitive word completion is bug 32357. So I mark it as duplicate. Feel free to change it back to UNCONFIRMED, if you disagree. *** This bug has been marked as a duplicate of bug 32357 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 119745] Scrolling with a laptop touchpad in Libreoffice way too fast
https://bugs.documentfoundation.org/show_bug.cgi?id=119745 --- Comment #43 from George Theodoridis --- I just installed 7.3.4. Scrolling is fast, but usable on my Lenovo Legion 5. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149419] Footnote numbers aren't reset between letters in mail merge
https://bugs.documentfoundation.org/show_bug.cgi?id=149419 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO Whiteboard| QA:needsComment| --- Comment #1 from Dieter --- Thank you for reporting the bug. It seems you're using an old version of LibreOffice. Could you please try to reproduce it with the latest version of LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ ? I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the latest version and paste informations from Help -> About LibreOffice. Change to RESOLVED WORKSFORME, if the problem went away. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102495 Dieter changed: What|Removed |Added Depends on||149505 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149505 [Bug 149505] [CRASH] Writer hangs opening a DOCX file -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149505] [CRASH] Writer hangs opening a DOCX file
https://bugs.documentfoundation.org/show_bug.cgi?id=149505 Dieter changed: What|Removed |Added Blocks||102495 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102495 [Bug 102495] [META] KDE VCL backend bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140005] Draw import of PDF squishes text together
https://bugs.documentfoundation.org/show_bug.cgi?id=140005 --- Comment #12 from wafflek...@gmail.com --- Thank you for bringing this to our attention. Could you possibly try reproducing it using the most recent version of LibreOffice from https://waffle-game.com? I've changed the bug's status to 'NEEDINFO.' If the problem is still present in the current version, please change it back to 'UNCONFIRMED.' -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147508] LibreOffice (Calc?): random occasional freezes when idle or clicking (macOS)
https://bugs.documentfoundation.org/show_bug.cgi?id=147508 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147130] CRASH - Collabora Office SIGABRT - seemingly random crashes on startup
https://bugs.documentfoundation.org/show_bug.cgi?id=147130 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149419] Footnote numbers aren't reset between letters in mail merge
https://bugs.documentfoundation.org/show_bug.cgi?id=149419 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145485] (WRITER) page header content in document gets erased after template update
https://bugs.documentfoundation.org/show_bug.cgi?id=145485 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145485] (WRITER) page header content in document gets erased after template update
https://bugs.documentfoundation.org/show_bug.cgi?id=145485 --- Comment #4 from QA Administrators --- Dear peter josvai, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145742] Impossible to write an accent mark the second time i write in a cell
https://bugs.documentfoundation.org/show_bug.cgi?id=145742 --- Comment #3 from QA Administrators --- Dear rober, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133667] Memory usage increases with 20 MB style setting font change and closing the document doesn't free the memory
https://bugs.documentfoundation.org/show_bug.cgi?id=133667 --- Comment #7 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 130247] Excel workbook with multiple worksheets changes sheet reference in form control when importing to LibreOffice Calc.
https://bugs.documentfoundation.org/show_bug.cgi?id=130247 --- Comment #6 from QA Administrators --- Dear Willis, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149577] LO Calc closed without warning
https://bugs.documentfoundation.org/show_bug.cgi?id=149577 Tracy changed: What|Removed |Added Version|7.3.3.2 release |7.3.4.2 release -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149577] LO Calc closed without warning
https://bugs.documentfoundation.org/show_bug.cgi?id=149577 Tracy changed: What|Removed |Added Ever confirmed|0 |1 Status|RESOLVED|REOPENED Resolution|DUPLICATE |--- --- Comment #3 from Tracy --- (In reply to Timur from comment #2) > Report bug to Antivirus vendor. > > *** This bug has been marked as a duplicate of bug 149262 *** Have been in contact with my antivirus provider. After uninstalling antivirus software I am still unable to open LibreOffice from shortcut or in safe-mode from start menu. As LO still won't open without antivirus running or installed my provider concludes there is no issue from their side. What now?? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149505] [CRASH] Writer hangs opening a DOCX file
https://bugs.documentfoundation.org/show_bug.cgi?id=149505 Rafael Lima changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #4 from Rafael Lima --- (In reply to Timur from comment #3) > Please try with GEN and GTK3 (profile reset is unlikely but also try). I tried with the latest nightly build with a clean profile. The file initially hangs for 15 seconds before LibreOffice starts responding. It's no longer a crash, but a hanging problem... it's taking longer than it should to open this file. Also, it's not happening in "gen" and "gtk3", but only in "kf5". System info Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: cb83063cc0eb4e93bd44bc0cb9b7c4841230cdef CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149554] CRASH: using empty transpose
https://bugs.documentfoundation.org/show_bug.cgi?id=149554 --- Comment #7 from Rafael Lima --- (In reply to Xisco Faulí from comment #6) > Could you please try again with a daily build and a clean profile ? I tried with today's build and the problem is no longer happening. System info Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: cb83063cc0eb4e93bd44bc0cb9b7c4841230cdef CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149576] Dashed bounding box/border for text not shown, when not selected or multiple selected (Draw, Impress, ...)
https://bugs.documentfoundation.org/show_bug.cgi?id=149576 Rafael Lima changed: What|Removed |Added CC||rafael.palma.l...@gmail.com Keywords||needsUXEval --- Comment #4 from Rafael Lima --- This sounds useful. I'm not sure if they should be the default, but we could have an option in the View menu to enable/disable them. This could be similar to what we have in Writer for viewing Table / Text Boundaries. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: bin/get-forum-attachments.py
bin/get-forum-attachments.py |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit bbae8d3708691d10f18cac158e2ce8f2ee556d86
Author: Adolfo Jayme Barrientos
AuthorDate: Thu Jun 16 02:39:22 2022 +0200
Commit: Adolfo Jayme Barrientos
CommitDate: Thu Jun 16 02:39:56 2022 +0200
Revert "Fix typo"
This reverts commit 157d58605acc714a5756525b567d6b59a1322d35.
Reason for revert: IT IS NOT A TYPO
Change-Id: I06ccc29f4a093068b0ba211682e1624476b8a6c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135946
Tested-by: Adolfo Jayme Barrientos
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/bin/get-forum-attachments.py b/bin/get-forum-attachments.py
index 2861718edebe..4e46befefa9a 100755
--- a/bin/get-forum-attachments.py
+++ b/bin/get-forum-attachments.py
@@ -94,7 +94,7 @@ def get_attachments_from_url(lang, url, pathes):
if lang.startswith("mso"):
if not do_login(session, url, pathes.config):
-print("Can't login into " + url)
+print("Can't log in to " + url)
return
invalidCount = 0
EPUB 3 compliance of ebooks exported from LibreOffice
hello,when exporting to EPUB from LibreOffice, the resulting file is not compliant with the EPUB 3 standard. it includes a direction key in the css, which is invalid in version 3. i've created a patch for libepubgen that fixes this issue, but since the library isn't actively being developed anymore, i'm not sure how to continue from here on. does anyone happen to know if the developer is still around? if not, what would be a good way to implement this into LibreOffice?PS: i've posted about this on the IRC before, but i'm not very familiar with that platform and the service disconnected after a while, so i didn't see any of the responses (if there were any), hence why i'm posting here. regards,max
[Libreoffice-commits] core.git: xmloff/qa xmloff/source
xmloff/qa/unit/data/tdf149551_verticalText.pptx |binary
xmloff/qa/unit/draw.cxx | 32
xmloff/source/draw/shapeexport.cxx | 18 +++--
3 files changed, 42 insertions(+), 8 deletions(-)
New commits:
commit aca189d118d4351b293c089cb26584eb898e1849
Author: Regina Henschel
AuthorDate: Wed Jun 15 13:15:15 2022 +0200
Commit: Regina Henschel
CommitDate: Thu Jun 16 00:57:51 2022 +0200
tdf#149551 write draw:text-rotate-angle only once
The attributes 'vert' and 'vert270' set property TextPreRotateAngle on
import from OOXML. The property TextRotateAngle can be set by macro.
Both were written to file as 'draw:text-rotate-angle' attribute. So we
got a file format error 'duplicate attribute'.
The values are now added and the sum is written. That gives the same
rendering as after applying a macro. Using the sum is a workaround. We
have currently no way to save the direction specified by 'vert' and
'vert270' as style:writing-mode to ODF.
Change-Id: I93fd8ca42b82c1ed7f1bf6e33d932e5510615b2f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135901
Tested-by: Jenkins
Reviewed-by: Regina Henschel
diff --git a/xmloff/qa/unit/data/tdf149551_verticalText.pptx
b/xmloff/qa/unit/data/tdf149551_verticalText.pptx
new file mode 100644
index ..b142a2e83420
Binary files /dev/null and b/xmloff/qa/unit/data/tdf149551_verticalText.pptx
differ
diff --git a/xmloff/qa/unit/draw.cxx b/xmloff/qa/unit/draw.cxx
index fdfc6e98aa02..e8462ccc6181 100644
--- a/xmloff/qa/unit/draw.cxx
+++ b/xmloff/qa/unit/draw.cxx
@@ -25,6 +25,8 @@
#include
#include
+#include
+#include
#include
#include
#include
@@ -501,6 +503,36 @@ CPPUNIT_TEST_FIXTURE(XmloffDrawTest,
testTdf148714_CurvedArrowsOld)
}
}
}
+
+CPPUNIT_TEST_FIXTURE(XmloffDrawTest, testTextRotationPlusPre)
+{
+// import
+getComponent() =
loadFromDesktop(m_directories.getURLFromSrc(DATA_DIRECTORY)
+ + "tdf149551_verticalText.pptx",
+
"com.sun.star.presentation.PresentationDocument");
+// The file has a shape with attribute vert="vert" in element.
That generates a
+// TextPreRotateAngle attribute in CustomShapeGeometry.
+
+// Add a TextRotateAngle attribute.
+uno::Reference xShape(getShape(0));
+uno::Reference xShapeProps(xShape, uno::UNO_QUERY);
+uno::Sequence aGeomSeq;
+xShapeProps->getPropertyValue("CustomShapeGeometry") >>= aGeomSeq;
+auto
aGeomVec(comphelper::sequenceToContainer>(aGeomSeq));
+aGeomVec.push_back(comphelper::makePropertyValue("TextRotateAngle",
sal_Int32(45)));
+aGeomSeq = comphelper::containerToSequence(aGeomVec);
+xShapeProps->setPropertyValue("CustomShapeGeometry", uno::Any(aGeomSeq));
+
+// Save to ODF. Without the fix, a file format error was produced, because
attribute
+// draw:text-rotate-angle was written twice, one from TextPreRotateAngle
and the other from
+// TextRotateAngle.
+utl::TempFile aTempFile;
+// This should already catch the format error, but does not, see tdf#149567
+save("impress8", aTempFile);
+// But reload catches it.
+getComponent()->dispose();
+getComponent() = loadFromDesktop(aTempFile.GetURL());
+}
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/xmloff/source/draw/shapeexport.cxx
b/xmloff/source/draw/shapeexport.cxx
index 89eceb95982c..ebe9f7b4a71d 100644
--- a/xmloff/source/draw/shapeexport.cxx
+++ b/xmloff/source/draw/shapeexport.cxx
@@ -4226,6 +4226,7 @@ static void ImpExportEnhancedGeometry( SvXMLExport&
rExport, const uno::Referenc
OUString aStr;
OUStringBuffer aStrBuffer;
+double fTextRotateAngle(0.0); // sum TextRotateAngle and TextPreRotateAngle
SvXMLUnitConverter& rUnitConverter = rExport.GetMM100UnitConverter();
uno::Reference< beans::XPropertySetInfo > xPropSetInfo(
xPropSet->getPropertySetInfo() );
@@ -4280,14 +4281,9 @@ static void ImpExportEnhancedGeometry( SvXMLExport&
rExport, const uno::Referenc
case EAS_TextPreRotateAngle :
case EAS_TextRotateAngle :
{
-double fTextRotateAngle = 0;
-if ( ( rGeoProp.Value >>= fTextRotateAngle ) &&
fTextRotateAngle != 0 )
-{
-::sax::Converter::convertDouble(
-aStrBuffer, fTextRotateAngle );
-aStr = aStrBuffer.makeStringAndClear();
-rExport.AddAttribute( XML_NAMESPACE_DRAW,
XML_TEXT_ROTATE_ANGLE, aStr );
-}
+double fAngle = 0.0;
+rGeoProp.Value >>= fAngle;
+fTextRotateAngle += fAngle;
}
[Libreoffice-commits] core.git: sw/uiconfig
sw/uiconfig/swriter/ui/labeloptionspage.ui |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 513ae848b668647093ae4161718b2585d80fdb7a Author: Olivier Hallot AuthorDate: Mon Jun 13 07:51:59 2022 -0300 Commit: Olivier Hallot CommitDate: Thu Jun 16 00:44:18 2022 +0200 Fix extended tips in labeloptionspage.ui Change-Id: Ib82fd7a19a837521afbe0d0a6c154d4c5c5f2824 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135755 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/sw/uiconfig/swriter/ui/labeloptionspage.ui b/sw/uiconfig/swriter/ui/labeloptionspage.ui index c726208c65b5..86132b56d160 100644 --- a/sw/uiconfig/swriter/ui/labeloptionspage.ui +++ b/sw/uiconfig/swriter/ui/labeloptionspage.ui @@ -116,7 +116,7 @@ adjustment1 -Enter the number of labels or business cards that you want to have in a row on your page. +Select the column in which you want to place your single label or business card. @@ -160,7 +160,7 @@ adjustment2 -Enter the number of rows of labels or business cards that you want to have on your page. +Select the row in which you want to place your single label or business card.
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-4+backports' - solenv/gdb
solenv/gdb/libreoffice/sw.py |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
New commits:
commit 76a545fc9b67b654471b98075f9d6aaeb038f0b0
Author: Michael Stahl
AuthorDate: Thu Dec 2 11:57:40 2021 +0100
Commit: Thorsten Behrens
CommitDate: Thu Jun 16 00:10:11 2022 +0200
gdb: BigPtrArrayPrinter gets confused by libstdc++ std::unique_ptr
It looks like this in libstdc++:
= {
m_ppInf = {
_M_t = {
>> = {
_M_t = {
>> = {
>> = {
,
true>> = {
_M_head_impl = {}
}, },
> = {
_M_head_impl = 0x567fd20
}, }, }
}, }
},
Note there are 2 _M_head_impl members, and somehow gdb 11.1-2.fc34 picks
the wrong one.
A manual cast to std::_Head_base<0, BlockInfo**, false> seems to help.
Change-Id: I1332c2fc6eb2661d417fd92a73aed977bbb1dcea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126220
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit c9267ca4fa7fa94a1bf79320bec54428a6ad4804)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135486
Tested-by: Michael Stahl
diff --git a/solenv/gdb/libreoffice/sw.py b/solenv/gdb/libreoffice/sw.py
index e170709fb79c..7a5ce193684b 100644
--- a/solenv/gdb/libreoffice/sw.py
+++ b/solenv/gdb/libreoffice/sw.py
@@ -8,6 +8,7 @@
#
import six
+import gdb
from libreoffice.util import printing
class SwPositionPrinter(object):
@@ -194,7 +195,10 @@ class BigPtrArrayPrinter(object):
class _iterator(six.Iterator):
def __init__(self, array):
-self.blocks = array['m_ppInf']['_M_t']['_M_t']['_M_head_impl']
+# libstdc++ unique_ptr is a std::tuple which contains multiple
+# _M_head_impl members and gdb may pick the wrong one by default
+# so have to manually cast it to the one that contains the array
+self.blocks =
array['m_ppInf']['_M_t']['_M_t'].cast(gdb.lookup_type("std::_Head_base<0,
BlockInfo**, false>"))['_M_head_impl']
self.count = array['m_nSize']
self.pos = 0
self.block_count = array['m_nBlock']
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-4+backports' - filter/source forms/source fpicker/source include/svtools include/svx include/vcl io/source sot/source svx/source sw/sou
filter/source/xsltdialog/xmlfilterjar.hxx |
1 +
forms/source/component/EventThread.hxx |
1 +
fpicker/source/office/contentenumeration.hxx |
2 ++
include/svtools/imageresourceaccess.hxx|
2 ++
include/svx/hexcolorcontrol.hxx|
2 ++
include/vcl/BitmapBuffer.hxx |
2 ++
io/source/acceptor/acc_pipe.cxx|
2 ++
io/source/acceptor/acc_socket.cxx |
1 +
io/source/connector/connector.cxx |
2 ++
sot/source/unoolestorage/xolesimplestorage.hxx |
2 ++
svx/source/unodialogs/textconversiondlgs/chinese_translation_unodialog.hxx |
1 +
sw/source/uibase/docvw/OverlayRanges.hxx |
1 +
sw/source/uibase/docvw/ShadowOverlayObject.hxx |
2 ++
xmlsecurity/source/gpg/SEInitializer.cxx |
2 ++
xmlsecurity/source/gpg/SecurityEnvironment.hxx |
2 ++
xmlsecurity/source/helper/ooxmlsecparser.hxx |
1 +
xmlsecurity/source/helper/xsecparser.hxx |
1 +
17 files changed, 27 insertions(+)
New commits:
commit 60e7c5b92388b543a351af866eeeb767df13ff1b
Author: Michael Stahl
AuthorDate: Tue May 31 18:01:46 2022 +0200
Commit: Thorsten Behrens
CommitDate: Thu Jun 16 00:09:40 2022 +0200
include memory for GCC12
Change-Id: Idd92510b66f63b68faa8a8d4fef01a18874e9905
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135487
Tested-by: Michael Stahl
Reviewed-by: Michael Stahl
diff --git a/filter/source/xsltdialog/xmlfilterjar.hxx
b/filter/source/xsltdialog/xmlfilterjar.hxx
index d9e20cd05847..d4a760366626 100644
--- a/filter/source/xsltdialog/xmlfilterjar.hxx
+++ b/filter/source/xsltdialog/xmlfilterjar.hxx
@@ -23,6 +23,7 @@
#include
#include
+#include
#include
class filter_info_impl;
diff --git a/forms/source/component/EventThread.hxx
b/forms/source/component/EventThread.hxx
index eb3062080d73..bb8d01c48a0b 100644
--- a/forms/source/component/EventThread.hxx
+++ b/forms/source/component/EventThread.hxx
@@ -22,6 +22,7 @@
#include
+#include
#include
#include
diff --git a/fpicker/source/office/contentenumeration.hxx
b/fpicker/source/office/contentenumeration.hxx
index 920a6d8f2b08..0f6e37277376 100644
--- a/fpicker/source/office/contentenumeration.hxx
+++ b/fpicker/source/office/contentenumeration.hxx
@@ -26,6 +26,8 @@
#include
#include
+#include
+
namespace svt
{
diff --git a/include/svtools/imageresourceaccess.hxx
b/include/svtools/imageresourceaccess.hxx
index 6adff39ae4aa..b9135f2ccf6d 100644
--- a/include/svtools/imageresourceaccess.hxx
+++ b/include/svtools/imageresourceaccess.hxx
@@ -24,6 +24,8 @@
#include
+#include
+
namespace com :: sun :: star :: io { class XInputStream; }
namespace com :: sun :: star :: uno { class XComponentContext; }
diff --git a/include/svx/hexcolorcontrol.hxx b/include/svx/hexcolorcontrol.hxx
index 63b44992d370..fc72f493a61d 100644
--- a/include/svx/hexcolorcontrol.hxx
+++ b/include/svx/hexcolorcontrol.hxx
@@ -24,6 +24,8 @@
#include
#include
+#include
+
namespace weld { class Entry; }
struct ImplSVEvent;
diff --git a/include/vcl/BitmapBuffer.hxx b/include/vcl/BitmapBuffer.hxx
index 2a064951c447..3686e5fcb508 100644
--- a/include/vcl/BitmapBuffer.hxx
+++ b/include/vcl/BitmapBuffer.hxx
@@ -25,6 +25,8 @@
#include
#include
+#include
+
struct SalTwoRect;
struct VCL_DLLPUBLIC BitmapBuffer
diff --git a/io/source/acceptor/acc_pipe.cxx b/io/source/acceptor/acc_pipe.cxx
index ad9ce09a20cb..0af2ae14a32c 100644
--- a/io/source/acceptor/acc_pipe.cxx
+++ b/io/source/acceptor/acc_pipe.cxx
@@ -27,6 +27,8 @@
#include
#include
+#include
+
using namespace ::osl;
using namespace ::cppu;
using namespace ::com::sun::star::uno;
diff --git a/io/source/acceptor/acc_socket.cxx
b/io/source/acceptor/acc_socket.cxx
index a72179ecb356..66a70a7c2d0e 100644
--- a/io/source/acceptor/acc_socket.cxx
+++ b/io/source/acceptor/acc_socket.cxx
@@ -20,6 +20,7 @@
#include "acceptor.hxx"
#include
+#include
#include
#include
diff --git a/io/source/connector/connector.cxx
b/io/source/connector/connector.cxx
index c21a34d17eac..ba9ec42ce436 100644
--- a/io/source/connector/connector.cxx
+++ b/io/source/connector/connector.cxx
@@ -34,6 +34,8 @@
#include
#include "connector.hxx"
+#include
+
#define IMPLEMENTATION_NAME "com.sun.star.comp.io.Connector"
#define SERVICE_NAME "com.sun.star.connection.Connector"
diff --git a/sot/source/unoolestorage/xolesimplestorage.hxx
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sw/qa sw/source
sw/qa/extras/uiwriter/uiwriter2.cxx | 50
sw/source/core/doc/DocumentContentOperationsManager.cxx |9 ++
sw/source/core/doc/docedt.cxx |4 -
sw/source/core/inc/mvsave.hxx |2
4 files changed, 62 insertions(+), 3 deletions(-)
New commits:
commit b7ab83bd96c70932c2223c8d0b3bc0f24327cef2
Author: Michael Stahl
AuthorDate: Fri Jun 10 16:26:40 2022 +0200
Commit: Thorsten Behrens
CommitDate: Thu Jun 16 00:09:02 2022 +0200
tdf#139982 sw: preserve flys in Replace with redlining enabled
The problem is that there isn't a redline type "Replace" so it's
represented as Delete+Insert.
To prevent the flys anchored in the text from being deleted, move the
anchors to the point between the old (deleted) and new (inserted) text.
(regression from commit 28b77c89dfcafae82cf2a6d85731b643ff9290e5)
Change-Id: Ib600c9dbfb9421917e4b8d61195c48cf0b364f06
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135604
Tested-by: Michael Stahl
Reviewed-by: Michael Stahl
(cherry picked from commit 646c6ddd91a98afddf914e3889cb269fc814c060)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135737
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
diff --git a/sw/qa/extras/uiwriter/uiwriter2.cxx
b/sw/qa/extras/uiwriter/uiwriter2.cxx
index 32bc25ef6386..645ef94d762a 100644
--- a/sw/qa/extras/uiwriter/uiwriter2.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter2.cxx
@@ -1067,6 +1067,56 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testTdf140007)
pDoc->GetNodes()[SwNodeOffset(11)]->GetTextNode()->GetText());
}
+CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testTdf139982)
+{
+SwDoc* const pDoc = createSwDoc();
+SwWrtShell* const pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+
+// turn on redlining and show changes
+pDoc->getIDocumentRedlineAccess().SetRedlineFlags(RedlineFlags::On |
RedlineFlags::ShowDelete
+ |
RedlineFlags::ShowInsert);
+CPPUNIT_ASSERT_MESSAGE("redlining should be on",
+ pDoc->getIDocumentRedlineAccess().IsRedlineOn());
+CPPUNIT_ASSERT_MESSAGE(
+"redlines should be visible",
+
IDocumentRedlineAccess::IsShowChanges(pDoc->getIDocumentRedlineAccess().GetRedlineFlags()));
+
+pWrtShell->Insert("helloo");
+
+pWrtShell->Left(CRSR_SKIP_CHARS, /*bSelect=*/false, 1,
/*bBasicCall=*/false);
+{
+SwFormatAnchor anchor(RndStdIds::FLY_AT_CHAR);
+anchor.SetAnchor(pWrtShell->GetCursor()->GetPoint());
+SfxItemSet flySet(pDoc->GetAttrPool(), svl::Items);
+flySet.Put(anchor);
+SwFrameFormat const* pFly = pWrtShell->NewFlyFrame(flySet,
/*bAnchValid=*/true);
+CPPUNIT_ASSERT(pFly != nullptr);
+}
+
+pWrtShell->SttEndDoc(true);
+pWrtShell->EndPara(/*bSelect=*/true);
+
+CPPUNIT_ASSERT_EQUAL(size_t(1), pWrtShell->GetFlyCount(FLYCNTTYPE_FRM));
+
+pWrtShell->Replace("hello", true);
+
+// the problem was that a redline delete with the same author as redline
+// insert has its text deleted immediately, including anchored flys.
+CPPUNIT_ASSERT_EQUAL(size_t(1), pWrtShell->GetFlyCount(FLYCNTTYPE_FRM));
+
+pWrtShell->Undo();
+
+CPPUNIT_ASSERT_EQUAL(size_t(1), pWrtShell->GetFlyCount(FLYCNTTYPE_FRM));
+
+pWrtShell->Redo();
+
+CPPUNIT_ASSERT_EQUAL(size_t(1), pWrtShell->GetFlyCount(FLYCNTTYPE_FRM));
+
+pWrtShell->Undo();
+
+CPPUNIT_ASSERT_EQUAL(size_t(1), pWrtShell->GetFlyCount(FLYCNTTYPE_FRM));
+}
+
CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testTdf39721)
{
// FIXME: disabled on Windows because of a not reproducible problem (not
related to the patch)
diff --git a/sw/source/core/doc/DocumentContentOperationsManager.cxx
b/sw/source/core/doc/DocumentContentOperationsManager.cxx
index a52884f8c43a..2a5ec2918db4 100644
--- a/sw/source/core/doc/DocumentContentOperationsManager.cxx
+++ b/sw/source/core/doc/DocumentContentOperationsManager.cxx
@@ -4596,6 +4596,14 @@ bool DocumentContentOperationsManager::ReplaceRangeImpl(
SwPaM& rPam, const OUSt
InsertItemSet( aTmpRange, aSet );
}
+// tdf#139982: Appending the redline may immediately delete flys
+// anchored in the previous text if it's inside an insert redline.
+// Also flys will be deleted if the redline is accepted. Move them
+// to the position between the previous text and the new text,
+// there the chance of surviving both accept and reject is best.
+SaveFlyArr flys;
+SaveFlyInRange(aDelPam, *aDelPam.End(), flys, false);
+
if (m_rDoc.GetIDocumentUndoRedo().DoesUndo())
{
m_rDoc.GetIDocumentUndoRedo().AppendUndo(
@@ -4606,6 +4614,7 @@ bool DocumentContentOperationsManager::ReplaceRangeImpl(
SwPaM& rPam, const OUSt
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-4+backports' - vcl/unx
vcl/unx/generic/printer/cpdmgr.cxx |2 +-
vcl/unx/generic/printer/cupsmgr.cxx |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit c8088a1691144925ec05f01d6f107afe6ae3a9be
Author: Michael Stahl
AuthorDate: Sun May 22 12:55:36 2022 +0200
Commit: Thorsten Behrens
CommitDate: Thu Jun 16 00:09:16 2022 +0200
vcl: GCC12 says fclose() causes -Werror=use-after-free on any use of FILE*
In file included from vcl/inc/unx/cpdmgr.hxx:34,
from vcl/unx/generic/printer/cpdmgr.cxx:25:
In member function ‘size_t psp::FPtrHash::operator()(const FILE*) const’,
inlined from ‘std::__detail::_Hash_code_base<_Key, _Value, _ExtractKey,
_Hash, _RangeHash, _Unused, __cache_hash_code>::__hash_code
std::__detail::_Hash_code_base<_Key, _Value, _ExtractKey, _Hash, _RangeHash,
_Unused, __cache_hash_code>::_M_hash_code(const _Key&) const [with _Key =
_IO_FILE*; _Value = std::pair<_IO_FILE* const, rtl::OString>; _ExtractKey =
std::__detail::_Select1st; _Hash = psp::FPtrHash; _RangeHash =
std::__detail::_Mod_range_hashing; _Unused =
std::__detail::_Default_ranged_hash; bool __cache_hash_code = true]’ at
/usr/include/c++/12/bits/hashtable_policy.h:1268:18,
inlined from ‘std::_Hashtable<_Key, _Value, _Alloc, _ExtractKey,
_Equal, _Hash, _RangeHash, _Unused, _RehashPolicy, _Traits>::size_type
std::_Hashtable<_Key, _Value, _Alloc, _ExtractKey, _Equal, _Hash, _RangeHash,
_Unused, _RehashPolicy, _Traits>::_M_erase(std::true_type, const key_type&)
[with _Key = _IO_FILE*; _Value = std::pair<_IO_FILE* const, rtl::OString>;
_Alloc = std::allocator >; _ExtractKey
= std::__detail::_Select1st; _Equal = std::equal_to<_IO_FILE*>; _Hash =
psp::FPtrHash; _RangeHash = std::__detail::_Mod_range_hashing; _Unused =
std::__detail::_Default_ranged_hash; _RehashPolicy =
std::__detail::_Prime_rehash_policy; _Traits =
std::__detail::_Hashtable_traits]’ at
/usr/include/c++/12/bits/hashtable.h:2358:43,
inlined from ‘std::_Hashtable<_Key, _Value, _Alloc, _ExtractKey,
_Equal, _Hash, _RangeHash, _Unused, _RehashPolicy, _Traits>::size_type
std::_Hashtable<_Key, _Value, _Alloc, _ExtractKey, _Equal, _Hash, _RangeHash,
_Unused, _RehashPolicy, _Traits>::erase(const key_type&) [with _Key =
_IO_FILE*; _Value = std::pair<_IO_FILE* const, rtl::OString>; _Alloc =
std::allocator >; _ExtractKey =
std::__detail::_Select1st; _Equal = std::equal_to<_IO_FILE*>; _Hash =
psp::FPtrHash; _RangeHash = std::__detail::_Mod_range_hashing; _Unused =
std::__detail::_Default_ranged_hash; _RehashPolicy =
std::__detail::_Prime_rehash_policy; _Traits =
std::__detail::_Hashtable_traits]’ at
/usr/include/c++/12/bits/hashtable.h:971:24,
inlined from ‘std::unordered_map<_Key, _Tp, _Hash, _Pred,
_Alloc>::size_type std::unordered_map<_Key, _Tp, _Hash, _Pred,
_Alloc>::erase(const key_type&) [with _Key = _IO_FILE*; _Tp = rtl::OString;
_Hash = psp::FPtrHash; _Pred = std::equal_to<_IO_FILE*>; _Alloc =
std::allocator >]’ at
/usr/include/c++/12/bits/unordered_map.h:763:26,
inlined from ‘virtual bool psp::CPDManager::endSpool(const
rtl::OUString&, const rtl::OUString&, FILE*, const psp::JobData&, bool, const
rtl::OUString&)’ at vcl/unx/generic/printer/cpdmgr.cxx:725:28:
vcl/inc/unx/cupsmgr.hxx:35:43: error: pointer may be used after ‘int
fclose(FILE*)’ [-Werror=use-after-free]
35 | { return reinterpret_cast(pPtr); }
| ^
vcl/unx/generic/printer/cpdmgr.cxx: In member function ‘virtual bool
psp::CPDManager::endSpool(const rtl::OUString&, const rtl::OUString&, FILE*,
const psp::JobData&, bool, const rtl::OUString&)’:
vcl/unx/generic/printer/cpdmgr.cxx:695:15: note: call to ‘int
fclose(FILE*)’ here
695 | fclose( pFile );
| ~~^
Change-Id: Ib035f2287649dcf9a2d37bda85ebcf52c6c51aaa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134739
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 02ebfb8ed6175934a1985786e6816ecef1bd59f8)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134632
Reviewed-by: Caolán McNamara
(cherry picked from commit aedb674394960a294535f35d19f7ae532ee5d35a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135488
Tested-by: Michael Stahl
diff --git a/vcl/unx/generic/printer/cpdmgr.cxx
b/vcl/unx/generic/printer/cpdmgr.cxx
index d114dd71accd..a4c55b83365d 100644
--- a/vcl/unx/generic/printer/cpdmgr.cxx
+++ b/vcl/unx/generic/printer/cpdmgr.cxx
@@ -717,7 +717,7 @@ bool CPDManager::endSpool( const OUString& rPrintername,
const OUString& rJobTit
}
g_variant_unref(ret);
unlink( it->second.getStr() );
-m_aSpoolFiles.erase( pFile );
+m_aSpoolFiles.erase(it);
}
#else
(void)rPrintername;
diff --git a/vcl/unx/generic/printer/cupsmgr.cxx
b/vcl/unx/generic/printer/cupsmgr.cxx
index
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - officecfg/registry sdext/source sd/source
officecfg/registry/data/org/openoffice/Office/PresenterScreen.xcu |8
+++
sd/source/ui/slideshow/slideshowimpl.cxx |9
sdext/source/presenter/PresenterController.cxx| 11
++
3 files changed, 28 insertions(+)
New commits:
commit 27ddda4356f18f464a41cc828cf42bf9d5e053b8
Author: Gabor Kelemen
AuthorDate: Fri Jun 10 10:28:36 2022 +0200
Commit: Thorsten Behrens
CommitDate: Thu Jun 16 00:08:20 2022 +0200
tdf#149351 Add a 'Turn off mouse as pen' shortcut
for UX compatibility with PP: Ctrl-A turns off 'mouse as pen' mode
Change-Id: I0379580f4034f07f044dc1079c14898f3014face
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135579
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
Reviewed-by: Gabor Kelemen
(cherry picked from commit 76f7f0c167a5148c01cdb1e0d8ea56b905f5a875)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135849
Reviewed-by: Thorsten Behrens
diff --git a/officecfg/registry/data/org/openoffice/Office/PresenterScreen.xcu
b/officecfg/registry/data/org/openoffice/Office/PresenterScreen.xcu
index 4f99dae763a8..b21e67fd9e47 100644
--- a/officecfg/registry/data/org/openoffice/Office/PresenterScreen.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/PresenterScreen.xcu
@@ -1163,6 +1163,14 @@
Switches monitors
+
+
+Ctrl-'A'
+
+
+Turn off pointer as pen mode
+
+
diff --git a/sd/source/ui/slideshow/slideshowimpl.cxx
b/sd/source/ui/slideshow/slideshowimpl.cxx
index 3215a550b7c1..89a8ac95f033 100644
--- a/sd/source/ui/slideshow/slideshowimpl.cxx
+++ b/sd/source/ui/slideshow/slideshowimpl.cxx
@@ -1816,6 +1816,15 @@ bool SlideshowImpl::keyInput(const KeyEvent& rKEvt)
setUsePen( !mbUsePen );
break;
+// tdf#149351 Ctrl+A disables pointer as pen mode
+case KEY_A:
+if(rKEvt.GetKeyCode().IsMod1())
+{
+setUsePen( false );
+break;
+}
+break;
+
case KEY_E:
setEraseAllInk( true );
updateSlideShow();
diff --git a/sdext/source/presenter/PresenterController.cxx
b/sdext/source/presenter/PresenterController.cxx
index 5b501dbfa7cd..1062d892d336 100644
--- a/sdext/source/presenter/PresenterController.cxx
+++ b/sdext/source/presenter/PresenterController.cxx
@@ -878,6 +878,17 @@ void SAL_CALL PresenterController::keyReleased (const
awt::KeyEvent& rEvent)
}
break;
+// tdf#149351 Ctrl+A disables pointer as pen mode
+case awt::Key::A:
+if (mxSlideShowController.is())
+{
+if (rEvent.Modifiers == awt::KeyModifier::MOD1)
+{
+mxSlideShowController->setUsePen( false );
+}
+}
+break;
+
case awt::Key::E:
if (mxSlideShowController.is())
{
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sw/source
sw/source/core/doc/DocumentRedlineManager.cxx |6 ++
1 file changed, 6 insertions(+)
New commits:
commit 918f435d48de3f29814f187c8621c1a564c5b835
Author: Michael Stahl
AuthorDate: Tue Jun 14 17:19:23 2022 +0200
Commit: Thorsten Behrens
CommitDate: Thu Jun 16 00:07:47 2022 +0200
sw_redlinehide: skip unnecessary updates when undoing redlined delete
When reproducing tdf#135976 and then Undo, an UAF crash happens here:
assert(!pFrame->GetDrawObjs() || !pObjs->Contains(*pObj));
The pObjs was actually deleted and then re-created, because the pObj was
removed from the frame and added again to the same frame.
This is a bit unexpected, so prevent it by taking a shortcut in the
caller UpdateFramesForRemoveDeleteRedline() to insert a check that had
been removed in commit 14e87a4b15d31a34e6053f6194688f3aa23af991.
If the rPam is inside a single node, the sw::RedlineUnDelText hint that
was sent to the SwTextFrame should be sufficient to update it and the
rest of the code in the loop that deals with newly split paragraph can
be skipped.
Change-Id: I5f36eb91bc20003887ee0bad03ea4a6e67135de9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135907
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit cf9a16caf5012d65b2a45a5525e36e40585dd35c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135892
Reviewed-by: Thorsten Behrens
diff --git a/sw/source/core/doc/DocumentRedlineManager.cxx
b/sw/source/core/doc/DocumentRedlineManager.cxx
index c2ddb046ef8b..8a9a70ae2bb9 100644
--- a/sw/source/core/doc/DocumentRedlineManager.cxx
+++ b/sw/source/core/doc/DocumentRedlineManager.cxx
@@ -309,6 +309,12 @@ void UpdateFramesForRemoveDeleteRedline(SwDoc & rDoc,
SwPaM const& rPam)
break;
}
+// no nodes can be unmerged by this - skip MakeFrames() etc.
+if (rPam.GetPoint()->nNode == rPam.GetMark()->nNode)
+{
+break; // continue with AppendAllObjs()
+}
+
// first, call CheckParaRedlineMerge on the first paragraph,
// to init flag on new merge range (if any) + 1st node post the
merge
auto eMode(sw::FrameMode::Existing);
[Libreoffice-bugs] [Bug 149316] Clarify what a master slide is a master _for_
https://bugs.documentfoundation.org/show_bug.cgi?id=149316 --- Comment #5 from Eyal Rozenberg --- (In reply to Heiko Tietze from comment #4) > I don't think we should link a master slide somehow with the presentation. That's not what I mean, exactly. The master slide, in the template, should obviously not be linked to the specific presentation. But it should be made clear what _kind_ of slides a master is intended for. Also, a slide always has a master slide as which it began. It is useful to be able to browse that mapping, rather than going slide by slide through the link to this-slide's-master. > It's up to the designer whether a slide is called yellow, subtitle, 42 and > to the user where exactly this is inserted. Not quite sure how this contradicts what I said... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149341] When clicking an Insert-shape button, focus is wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=149341 Eyal Rozenberg changed: What|Removed |Added Keywords||needsUXEval -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149580] New: Text boundaries stop applying when saving as DOCX and opening both files
https://bugs.documentfoundation.org/show_bug.cgi?id=149580 Bug ID: 149580 Summary: Text boundaries stop applying when saving as DOCX and opening both files Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: eyalr...@gmx.com Created attachment 180789 --> https://bugs.documentfoundation.org/attachment.cgi?id=180789=edit The two documents opened side-by-side This is closely related to bug 112285, which I've just marked as WFM. So, if we: 0. Check Show Text boundaries, uncheck Show Table Boundaries (e.g. on the View menu) 1. Open the ODT file in that bug (attachment 136111) 2. Save it as a DOCX file 3. Close the DOCX file 4. Open both files (ODT and DOCX) We'll see how the ODT table exhibits thin gray boundaries, while the DOCX table does not. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102950] Format All Comments is not persistent for new comments
https://bugs.documentfoundation.org/show_bug.cgi?id=102950 --- Comment #12 from Celia Palacios --- Still persisit in 7.3.4.2 in Manajaro Version: 7.3.4.2 / LibreOffice Community Build ID: 30(Build:2) CPU threads: 16; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: es-MX (en_US.UTF-8); UI: en-US 7.3.4-1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112285] FILESAVE DOCX "Merge adjacent line styles" for table borders gets reactivated after deactivating
https://bugs.documentfoundation.org/show_bug.cgi?id=112285 Eyal Rozenberg changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #11 from Eyal Rozenberg --- Can no longer reproduce the bug. If I: * Open the ODT document * Save as DOCX * Open both files * (Uncheck Show Table Boundaries and Show Text Boundaries, just to clarify things) I see the borders on the center column are missing in both documents. So, marking WFM (although perhaps this was fixed somehow?) Build: Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: d9b33ed6644203141fdb0776c291425c2bc9f5ac CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: en-IL (en_IL); UI: en-US -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104444] [META] DOCX (OOXML) table-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=10 Bug 10 depends on bug 112285, which changed state. Bug 112285 Summary: FILESAVE DOCX "Merge adjacent line styles" for table borders gets reactivated after deactivating https://bugs.documentfoundation.org/show_bug.cgi?id=112285 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: translations
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c6c732e640ae0221e059e7b179edbf78ef7ca30e Author: Martin Srebotnjak AuthorDate: Wed Jun 15 23:41:13 2022 +0200 Commit: Gerrit Code Review CommitDate: Wed Jun 15 23:41:13 2022 +0200 Update git submodules * Update translations from branch 'master' to 140d3bcbbdf20e83d772d419515e49846ae7e105 - Updated Slovenian translation Change-Id: Ic93876c783b228af11b625e1a2e7370567798a84 diff --git a/translations b/translations index ef3257698791..140d3bcbbdf2 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit ef3257698791a7e3312d5d859ac8229ee48a0e69 +Subproject commit 140d3bcbbdf20e83d772d419515e49846ae7e105
[Libreoffice-commits] translations.git: source/sl
source/sl/cui/messages.po | 385 +++--- source/sl/editeng/messages.po | 10 source/sl/filter/messages.po |8 source/sl/fpicker/messages.po | 20 source/sl/helpcontent2/source/text/sbasic/shared.po |4 source/sl/helpcontent2/source/text/sbasic/shared/03.po| 282 source/sl/helpcontent2/source/text/scalc/01.po| 20 source/sl/helpcontent2/source/text/scalc/guide.po | 10 source/sl/helpcontent2/source/text/sdraw.po | 20 source/sl/helpcontent2/source/text/shared/00.po | 48 source/sl/helpcontent2/source/text/shared/01.po | 66 - source/sl/helpcontent2/source/text/shared/guide.po| 46 source/sl/helpcontent2/source/text/swriter/00.po |4 source/sl/helpcontent2/source/text/swriter/guide.po | 34 source/sl/officecfg/registry/data/org/openoffice/Office/UI.po | 21 source/sl/sc/messages.po | 582 +- source/sl/sd/messages.po |6 source/sl/sfx2/messages.po|4 source/sl/svtools/messages.po |9 source/sl/svx/messages.po | 204 +-- source/sl/sw/messages.po | 187 +-- 21 files changed, 1176 insertions(+), 794 deletions(-) New commits: commit 140d3bcbbdf20e83d772d419515e49846ae7e105 Author: Martin Srebotnjak AuthorDate: Wed Jun 15 23:41:02 2022 +0200 Commit: Andras Timar CommitDate: Wed Jun 15 23:41:02 2022 +0200 Updated Slovenian translation Change-Id: Ic93876c783b228af11b625e1a2e7370567798a84 diff --git a/source/sl/cui/messages.po b/source/sl/cui/messages.po index 4cc7eb8665e..a8c5a7cffd1 100644 --- a/source/sl/cui/messages.po +++ b/source/sl/cui/messages.po @@ -3,8 +3,8 @@ msgid "" msgstr "" "Project-Id-Version: LibreOffice 7.4\n" "Report-Msgid-Bugs-To: https://bugs.libreoffice.org/enter_bug.cgi?product=LibreOffice_status=UNCONFIRMED=UI\n; -"POT-Creation-Date: 2022-06-07 09:29+0200\n" -"PO-Revision-Date: 2022-06-07 10:36+0200\n" +"POT-Creation-Date: 2022-06-13 09:50+0200\n" +"PO-Revision-Date: 2022-06-15 17:18+0200\n" "Last-Translator: Martin Srebotnjak \n" "Language-Team: sl.libreoffice.org\n" "Language: sl\n" @@ -3171,292 +3171,297 @@ msgctxt "SID_LANGUAGE_OPTIONS_RES" msgid "Complex Text Layout" msgstr "Kompleksna postavitev besedila" -#: cui/inc/treeopt.hrc:63 +#: cui/inc/treeopt.hrc:59 +msgctxt "SID_LANGUAGE_OPTIONS_RES" +msgid "LanguageTool Server Settings" +msgstr "Nastavitve strežnika LanguageTool" + +#: cui/inc/treeopt.hrc:64 msgctxt "SID_INET_DLG_RES" msgid "Internet" msgstr "Internet" -#: cui/inc/treeopt.hrc:64 +#: cui/inc/treeopt.hrc:65 msgctxt "SID_INET_DLG_RES" msgid "Proxy" msgstr "Posredovalni strežniki" -#: cui/inc/treeopt.hrc:65 +#: cui/inc/treeopt.hrc:66 msgctxt "SID_INET_DLG_RES" msgid "Email" msgstr "E-pošta" -#: cui/inc/treeopt.hrc:70 +#: cui/inc/treeopt.hrc:71 msgctxt "SID_SW_EDITOPTIONS_RES" msgid "%PRODUCTNAME Writer" msgstr "%PRODUCTNAME Writer" -#: cui/inc/treeopt.hrc:71 +#: cui/inc/treeopt.hrc:72 msgctxt "SID_SW_EDITOPTIONS_RES" msgid "General" msgstr "Splošno" -#: cui/inc/treeopt.hrc:72 +#: cui/inc/treeopt.hrc:73 msgctxt "SID_SW_EDITOPTIONS_RES" msgid "View" msgstr "Pogled" -#: cui/inc/treeopt.hrc:73 +#: cui/inc/treeopt.hrc:74 msgctxt "SID_SW_EDITOPTIONS_RES" msgid "Formatting Aids" msgstr "Pripomočki za oblikovanje" -#: cui/inc/treeopt.hrc:74 +#: cui/inc/treeopt.hrc:75 msgctxt "SID_SW_EDITOPTIONS_RES" msgid "Grid" msgstr "Mreža" -#: cui/inc/treeopt.hrc:75 +#: cui/inc/treeopt.hrc:76 msgctxt "SID_SW_EDITOPTIONS_RES" msgid "Basic Fonts (Western)" msgstr "Osnovne pisave (zahodne)" -#: cui/inc/treeopt.hrc:76 +#: cui/inc/treeopt.hrc:77 msgctxt "SID_SW_EDITOPTIONS_RES" msgid "Basic Fonts (Asian)" msgstr "Osnovne pisave (azijske)" -#: cui/inc/treeopt.hrc:77 +#: cui/inc/treeopt.hrc:78 msgctxt "SID_SW_EDITOPTIONS_RES" msgid "Basic Fonts (CTL)" msgstr "Osnovne pisave (CTL)" -#: cui/inc/treeopt.hrc:78 +#: cui/inc/treeopt.hrc:79 msgctxt "SID_SW_EDITOPTIONS_RES" msgid "Print" msgstr "Tiskanje" -#: cui/inc/treeopt.hrc:79 +#: cui/inc/treeopt.hrc:80 msgctxt "SID_SW_EDITOPTIONS_RES" msgid "Table" msgstr "Tabela" -#: cui/inc/treeopt.hrc:80 +#: cui/inc/treeopt.hrc:81 msgctxt "SID_SW_EDITOPTIONS_RES" msgid "Changes" msgstr "Spremembe" -#: cui/inc/treeopt.hrc:81 +#: cui/inc/treeopt.hrc:82 msgctxt "SID_SW_EDITOPTIONS_RES" msgid "Comparison" msgstr "Primerjava" -#: cui/inc/treeopt.hrc:82 +#: cui/inc/treeopt.hrc:83 msgctxt "SID_SW_EDITOPTIONS_RES" msgid "Compatibility" msgstr "Združljivost" -#: cui/inc/treeopt.hrc:83 +#: cui/inc/treeopt.hrc:84 msgctxt
[Libreoffice-commits] core.git: translations
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 7aadae242747bc09b316cfec9ff23b0d2690794b Author: Christian Lohmaier AuthorDate: Wed Jun 15 23:28:09 2022 +0200 Commit: Gerrit Code Review CommitDate: Wed Jun 15 23:28:09 2022 +0200 Update git submodules * Update translations from branch 'master' to ef3257698791a7e3312d5d859ac8229ee48a0e69 - update translations for master/7.4 and force-fix errors using pocheck Change-Id: I748d74278038427100e6927f374e17d69a2eaee9 diff --git a/translations b/translations index d876aa338f5b..ef3257698791 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit d876aa338f5bc378bec4500d8e4d13654d7f8cea +Subproject commit ef3257698791a7e3312d5d859ac8229ee48a0e69
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - translations
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit bae9d1d5e1e5d7e962b8f22d2c8b5ce8e9e8f61e Author: Christian Lohmaier AuthorDate: Wed Jun 15 23:32:50 2022 +0200 Commit: Gerrit Code Review CommitDate: Wed Jun 15 23:32:50 2022 +0200 Update git submodules * Update translations from branch 'libreoffice-7-4' to 52563f0f56dd203c093adc3a19fcd64334b42b16 - update translations for master/7.4 and force-fix errors using pocheck Change-Id: I748d74278038427100e6927f374e17d69a2eaee9 (cherry picked from commit ef3257698791a7e3312d5d859ac8229ee48a0e69) diff --git a/translations b/translations index 650d58f9d450..52563f0f56dd 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit 650d58f9d45043c552b2806024db19b812263173 +Subproject commit 52563f0f56dd203c093adc3a19fcd64334b42b16
[Libreoffice-bugs] [Bug 74142] FORMATTING: Impress default table design options are not 'Impressive'
https://bugs.documentfoundation.org/show_bug.cgi?id=74142 Rafael Lima changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=38 ||213 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 38213] Allow to specify the color pattern for tables
https://bugs.documentfoundation.org/show_bug.cgi?id=38213 Rafael Lima changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=74 ||142 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103100 Rafael Lima changed: What|Removed |Added Blocks|148376 | Depends on||148376 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148376 [Bug 148376] Insert Table toolbar: text with table size does not respect dark mode -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103100 Rafael Lima changed: What|Removed |Added Blocks||148376 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148376 [Bug 148376] Insert Table toolbar: text with table size does not respect dark mode -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148376] Insert Table toolbar: text with table size does not respect dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=148376 Rafael Lima changed: What|Removed |Added Depends on|103100 | Blocks||103100 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103100 [Bug 103100] [META] Writer table bugs -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148376] Insert Table toolbar: text with table size does not respect dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=148376 Rafael Lima changed: What|Removed |Added Depends on||103100 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103100 [Bug 103100] [META] Writer table bugs -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149570] Undo doesn't work with operations on tables
https://bugs.documentfoundation.org/show_bug.cgi?id=149570 --- Comment #3 from Eyal Rozenberg --- (In reply to Rafael Lima from comment #2) > Impress tables have too many bugs =( > > I use them all the time and it's impossible to finish preparing a > presentation without running across a table bug in Impress. Yeah, I don't understand why Impress tables aren't one of the annual foci for a tender, or allocated some serious developer time. They're quite the embarrassment IMHO. This and a zillion formatting gaffes... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142540] Unable to Undo border formatting in Impress Tables
https://bugs.documentfoundation.org/show_bug.cgi?id=142540 Rafael Lima changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||9570 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149570] Undo doesn't work with operations on tables
https://bugs.documentfoundation.org/show_bug.cgi?id=149570 Rafael Lima changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||2540 CC||rafael.palma.l...@gmail.com --- Comment #2 from Rafael Lima --- Impress tables have too many bugs =( I use them all the time and it's impossible to finish preparing a presentation without running across a table bug in Impress. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149571] Automatic color doesn't change when object background is dark
https://bugs.documentfoundation.org/show_bug.cgi?id=149571 Rafael Lima changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||2799 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142799] 'Automatic' font color ignores table background color being black
https://bugs.documentfoundation.org/show_bug.cgi?id=142799 Rafael Lima changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||9571 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 100366] [META] Impress/Draw table bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=100366 Rafael Lima changed: What|Removed |Added Depends on||149571 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149571 [Bug 149571] Automatic color doesn't change when object background is dark -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149571] Automatic color doesn't change when object background is dark
https://bugs.documentfoundation.org/show_bug.cgi?id=149571 Rafael Lima changed: What|Removed |Added Blocks||100366 CC||rafael.palma.l...@gmail.com Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=100366 [Bug 100366] [META] Impress/Draw table bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149571] Automatic color doesn't change when object background is dark
https://bugs.documentfoundation.org/show_bug.cgi?id=149571 --- Comment #3 from Rafael Lima --- When you click the black-cell in the table to edit the text, the text gets a white color. But when you exit the cell, then text becomes black again. This does not seem to be the correct behavior - BUG. As for the text in the transparent box saying "Automatic for the people", I believe the result is expected, since the box itself is transparent, so it can't know what's beneath it to determine text color - NAB. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 60251] [META] ACCESSIBILITY: Tracking Windows OS accessibility and AT issues
https://bugs.documentfoundation.org/show_bug.cgi?id=60251 Bug 60251 depends on bug 147084, which changed state. Bug 147084 Summary: I can’t read tables with NVDA screen reader in Writer, Windows builds https://bugs.documentfoundation.org/show_bug.cgi?id=147084 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149561] Chart type is not saved when an empty XY Scatter chart is created
https://bugs.documentfoundation.org/show_bug.cgi?id=149561 Julien Nabet changed: What|Removed |Added CC||qui...@gmail.com, ||serval2...@yahoo.fr --- Comment #2 from Julien Nabet --- I suppose that when chart is empty, ScatterChartTypeTemplate::matchesTemplate (https://opengrok.libreoffice.org/xref/core/chart2/source/model/template/ScatterChartTypeTemplate.cxx?r=fef939d8#198) doesn't "guess" the right subtype. Tomaž: any idea how to save the subtype so it can be retrieved easily instead of guessing it in ChartTypeTabPage::initializePage() ? (see https://opengrok.libreoffice.org/xref/core/chart2/source/controller/dialogs/tp_ChartType.cxx?r=b7c260ae#302) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: svx/source
svx/source/diagram/IDiagramHelper.cxx |4
1 file changed, 4 insertions(+)
New commits:
commit 1089c1baa887a7120d17707d8b54925fa5c2feee
Author: Xisco Fauli
AuthorDate: Wed Jun 15 16:37:13 2022 +0200
Commit: Xisco Fauli
CommitDate: Wed Jun 15 22:45:21 2022 +0200
Advanced Diagram support: make UI visualization experimental only
In 391cb44d415e2126f668ecf62387d5e98ffa6f5c
"Advanced Diagram support: UI visualization & simple interactions"
added a UI visualization to advanced diagrams.
However, the feature is incomplete at the moment, specially towards
LibreOffice 7.4, thus, make it experimental for now.
This can be reverted later on
Change-Id: Ibf21d11899460ab9ef1ddf91cffb851171119618
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135912
Reviewed-by: Thorsten Behrens
Tested-by: Jenkins
diff --git a/svx/source/diagram/IDiagramHelper.cxx
b/svx/source/diagram/IDiagramHelper.cxx
index b701a5930917..1803a3d2beed 100644
--- a/svx/source/diagram/IDiagramHelper.cxx
+++ b/svx/source/diagram/IDiagramHelper.cxx
@@ -34,6 +34,7 @@
#include
#include
#include
+#include
#include
#include
@@ -322,6 +323,9 @@ drawinglayer::primitive2d::Primitive2DContainer
OverlayDiagramFrame::createOverl
{
drawinglayer::primitive2d::Primitive2DContainer aReturnContainer;
+if ( !officecfg::Office::Common::Misc::ExperimentalMode::get() )
+return aReturnContainer;
+
if (getOverlayManager())
{
aReturnContainer = drawinglayer::primitive2d::Primitive2DContainer {
[Libreoffice-commits] core.git: sc/qa
sc/qa/extras/testdocuments/tdf52602.xls |binary
sc/qa/extras/vba-macro-test.cxx | 41
2 files changed, 41 insertions(+)
New commits:
commit fc5357935cc160fd19b61db7cbf7f098962d42a3
Author: Xisco Fauli
AuthorDate: Wed Jun 15 12:30:24 2022 +0200
Commit: Xisco Fauli
CommitDate: Wed Jun 15 22:44:16 2022 +0200
tdf#52602: sc_vba_macro_test: Add unittest
Change-Id: I3e6ab3d8f3e9dddfec90f1a9762e7bf2007c10db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135899
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sc/qa/extras/testdocuments/tdf52602.xls
b/sc/qa/extras/testdocuments/tdf52602.xls
new file mode 100644
index ..1770b15fb45d
Binary files /dev/null and b/sc/qa/extras/testdocuments/tdf52602.xls differ
diff --git a/sc/qa/extras/vba-macro-test.cxx b/sc/qa/extras/vba-macro-test.cxx
index 1f93a6247975..456b57822566 100644
--- a/sc/qa/extras/vba-macro-test.cxx
+++ b/sc/qa/extras/vba-macro-test.cxx
@@ -66,6 +66,7 @@ public:
void testVbaRangeSort();
void testTdf107885();
void testTdf131562();
+void testTdf52602();
void testTdf107902();
void testTdf90278();
void testTdf149531();
@@ -85,6 +86,7 @@ public:
CPPUNIT_TEST(testVbaRangeSort);
CPPUNIT_TEST(testTdf107885);
CPPUNIT_TEST(testTdf131562);
+CPPUNIT_TEST(testTdf52602);
CPPUNIT_TEST(testTdf107902);
CPPUNIT_TEST(testTdf90278);
CPPUNIT_TEST(testTdf149531);
@@ -736,6 +738,45 @@ void VBAMacroTest::testTdf131562()
pDocSh->DoClose();
}
+void VBAMacroTest::testTdf52602()
+{
+OUString aFileName;
+createFileURL(u"tdf52602.xls", aFileName);
+uno::Reference xComponent
+= loadFromDesktop(aFileName, "com.sun.star.sheet.SpreadsheetDocument");
+
+uno::Any aRet;
+uno::Sequence aOutParamIndex;
+uno::Sequence aOutParam;
+uno::Sequence aParams;
+
+SfxObjectShell* pFoundShell =
SfxObjectShell::GetShellFromComponent(xComponent);
+
+CPPUNIT_ASSERT_MESSAGE("Failed to access document shell", pFoundShell);
+ScDocShell* pDocSh = static_cast(pFoundShell);
+ScDocument& rDoc = pDocSh->GetDocument();
+
+//Without the fix in place, it would have failed with 'Unexpected dialog:
Error: BASIC runtime error.'
+SfxObjectShell::CallXScript(xComponent,
+
"vnd.sun.Star.script:VBAProject.Modul1.Test_NumberFormat_DateTime?"
+"language=Basic=document",
+aParams, aRet, aOutParamIndex, aOutParam);
+
+CPPUNIT_ASSERT_EQUAL(OUString("15:20"), rDoc.GetString(ScAddress(0, 0,
0)));
+CPPUNIT_ASSERT_EQUAL(OUString("15:20"), rDoc.GetString(ScAddress(0, 1,
0)));
+CPPUNIT_ASSERT_EQUAL(OUString("03/01/2012 15:20"),
rDoc.GetString(ScAddress(1, 0, 0)));
+CPPUNIT_ASSERT_EQUAL(OUString("03/01/2012 15:20"),
rDoc.GetString(ScAddress(1, 1, 0)));
+CPPUNIT_ASSERT_EQUAL(OUString("03/01/2012 15:20:00"),
rDoc.GetString(ScAddress(2, 0, 0)));
+CPPUNIT_ASSERT_EQUAL(OUString("03/01/2012 15:20:00"),
rDoc.GetString(ScAddress(2, 1, 0)));
+CPPUNIT_ASSERT_EQUAL(OUString("1/3/12 15:20"), rDoc.GetString(ScAddress(3,
0, 0)));
+CPPUNIT_ASSERT_EQUAL(OUString("1/3/12 15:20"), rDoc.GetString(ScAddress(3,
1, 0)));
+CPPUNIT_ASSERT_EQUAL(OUString("1/ March 2012"),
rDoc.GetString(ScAddress(4, 0, 0)));
+CPPUNIT_ASSERT_EQUAL(OUString("1/ March 2012"),
rDoc.GetString(ScAddress(4, 1, 0)));
+CPPUNIT_ASSERT_EQUAL(OUString("1/ Mar 2012"), rDoc.GetString(ScAddress(5,
0, 0)));
+CPPUNIT_ASSERT_EQUAL(OUString("1/ Mar 2012"), rDoc.GetString(ScAddress(5,
1, 0)));
+
+pDocSh->DoClose();
+}
void VBAMacroTest::testTdf107902()
{
OUString aFileName;
[Libreoffice-commits] core.git: bin/get-forum-attachments.py
bin/get-forum-attachments.py |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 157d58605acc714a5756525b567d6b59a1322d35
Author: Andrea Gelmini
AuthorDate: Thu Jun 9 17:23:07 2022 +0200
Commit: Xisco Fauli
CommitDate: Wed Jun 15 22:43:48 2022 +0200
Fix typo
Change-Id: I9769e01a95b10a798769104e16e6b0c37585a2d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135559
Tested-by: Jenkins
Reviewed-by: Julien Nabet
Reviewed-by: Xisco Fauli
diff --git a/bin/get-forum-attachments.py b/bin/get-forum-attachments.py
index 4e46befefa9a..2861718edebe 100755
--- a/bin/get-forum-attachments.py
+++ b/bin/get-forum-attachments.py
@@ -94,7 +94,7 @@ def get_attachments_from_url(lang, url, pathes):
if lang.startswith("mso"):
if not do_login(session, url, pathes.config):
-print("Can't log in to " + url)
+print("Can't login into " + url)
return
invalidCount = 0
[Libreoffice-commits] core.git: sw/source
sw/source/core/access/accpara.cxx |3 --- 1 file changed, 3 deletions(-) New commits: commit 8bb6190dd406390b404f0c1855894e8a48d0fda2 Author: Michael Weghorn AuthorDate: Wed Jun 15 09:55:10 2022 +0200 Commit: Michael Weghorn CommitDate: Wed Jun 15 22:42:52 2022 +0200 tdf#147084 sw a11y: Ensure focus event gets sent when moving to table The code responsible for sending an a11y focus event when the cursor moves from elsewhere into e.g. a table cell depends on the fact that the cursor was previously not in that object, i.e. the previous/old cursor/caret position is -1, s. e.g. `SwAccessibleParagraph::InvalidateCursorPos_`. Already setting `m_nOldCaretPos` to the the actual cursor position instead of -1 in the `SwAccessibleParagraph` ctor resulted in that assumption no longer holding when initially moving the cursor into a table (cell), so no focus event would get sent and the NVDA screen reader on Windows would therefore also not refer to the correct a11y object when handling the subsequent CARET_CHANGED event and fail to retrieve the caret position in the previously focused object (because focus/cursor have moved on). Make focus announcement work by only setting `m_nOldCaretPos` to the actual cursor position when processing the corresponding events related to change of cursor position, not in the ctor. Setting the cursor pos already in the ctor had been added to fix an issue with IM handling in commit 817da76529aa39f641d76805d429b09681348811 Date: Sat Nov 8 19:37:22 2014 +0300 fdo#85912 Delete surrounding text failing for input method calls regression. When Apache OpenOffice code was merged in, a few lines were removed for no apparent reason. This just adds the code back in, and resolves the bug. See the comments in fdo#85912 for details about this bug. It is hard for majority language users to reproduce since they don't use ibus/kmfl to type their language's letters. The issue mentioned in the referenced tdf#85912 (== fdo#85912) is not reproducible for me with this change here in place either, neither with the gtk3 VCL plugin nor with kf5 (for which the relevant IM handling has been added in the context of tdf#149255, which has some more information on the ibus/kmfl setup needed to reproduce the original bug). The bug report already mentioned that the issue was reproducible with Linux 13 Mint and LibreOffice 4.3.3.2, but not Linux 17 Mint with exactly the same LO version, so without being able to analyze this any further, the best explanation I can come up with is that the root cause for tdf#85912 was somewhere else and has been fixed in the meanwhile. In hindsight, comment 5 in tdf#85912 already has further information on why adding the assignment back to the ctor was problematic: > Reviewed OpenOffice code as well. The missing lines exist (but are > commented out) in the current AOO code. The commenting out > occurred when Steven Ying implemented his huge "AOO IA2 enabled draft > version 1" change on 27 Sep 2013. > https://github.com/apache/openoffice/commit/0deba7fbda3d9908785c25a443701a293b6f4e71#diff-50d752f41bb880abd1094d09d9e1a7fc > > The current AOO comment is > // If this object has the focus, then it is remembered by the map itself. > // not necessary to remember this pos here. Generally, the pos will be updated in invalidateXXX method, which may fire the > //Focus event based on the difference of new & old caret pos. > //nOldCaretPos = GetCaretPos(); Change-Id: If8cd4e92bc1f6233775ccc2834230f3a388ccadb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135868 Reviewed-by: Justin Luth Tested-by: Jenkins Reviewed-by: Michael Weghorn diff --git a/sw/source/core/access/accpara.cxx b/sw/source/core/access/accpara.cxx index 1447b97a6dbd..94a1df603c4a 100644 --- a/sw/source/core/access/accpara.cxx +++ b/sw/source/core/access/accpara.cxx @@ -412,9 +412,6 @@ SwAccessibleParagraph::SwAccessibleParagraph( //Get the real heading level, Heading1 ~ Heading10 m_nHeadingLevel = GetRealHeadingLevel(); SetName( OUString() ); // set an empty accessibility name for paragraphs - -// If this object has the focus, then it is remembered by the map itself. -m_nOldCaretPos = GetCaretPos(); } SwAccessibleParagraph::~SwAccessibleParagraph()
[Libreoffice-bugs] [Bug 149432] system font in Hebrew is not a standard font
https://bugs.documentfoundation.org/show_bug.cgi?id=149432 --- Comment #3 from Shlomo belleli --- well? is anyone is working on this bug report? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149474] Check for updates
https://bugs.documentfoundation.org/show_bug.cgi?id=149474 --- Comment #4 from Shlomo belleli --- well? is this a bug? in my computer, it is a bug. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/source
vcl/source/treelist/treelist.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 21747f8ef471080817db464a91ef203813e84677
Author: Samuel Mehrbrodt
AuthorDate: Wed Jun 15 16:54:55 2022 +0200
Commit: Samuel Mehrbrodt
CommitDate: Wed Jun 15 22:25:35 2022 +0200
Make sure pEntry is not null
Crash seen:
> mergedlo.dll!SvTreeList::GetDepth(const SvTreeListEntry * pEntry)
line 106
mergedlo.dll!SalInstanceTreeView::get_iter_depth(const
weld::TreeIter & rIter) line 4230
basctllo.dll!basctl::SbTreeListBox::FindVariable(const
weld::TreeIter * pEntry) line 271
basctllo.dll!basctl::SbTreeListBox::FindModule(const weld::TreeIter
* pEntry) line 695
basctllo.dll!basctl::MacroChooser::BasicSelectHdl(weld::TreeView &
__formal) line 473
basctllo.dll!basctl::MacroChooser::RestoreMacroDescription() line
158
basctllo.dll!basctl::MacroChooser::run() line 178
Change-Id: Ic85758c0bbee952d0a23b1d52e8bbdd231e8de26
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135914
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt
diff --git a/vcl/source/treelist/treelist.cxx b/vcl/source/treelist/treelist.cxx
index 07db41b54266..f118e5e35637 100644
--- a/vcl/source/treelist/treelist.cxx
+++ b/vcl/source/treelist/treelist.cxx
@@ -103,7 +103,7 @@ sal_uInt16 SvTreeList::GetDepth( const SvTreeListEntry*
pEntry ) const
{
DBG_ASSERT(pEntry && pEntry!=pRootItem.get(),"GetDepth:Bad Entry");
sal_uInt16 nDepth = 0;
-while( pEntry->pParent != pRootItem.get() )
+while( pEntry && pEntry->pParent != pRootItem.get() )
{
nDepth++;
pEntry = pEntry->pParent;
[Libreoffice-bugs] [Bug 126530] Tabbed Notebook Bar Usability Issues on Windows 10
https://bugs.documentfoundation.org/show_bug.cgi?id=126530 --- Comment #11 from Damian Hofmann --- > 2. with "visual noise" The underlining of the MNEMONIC key makes the already cluttered UI even busier. It should normally be hidden and only shown, when the ALT key is pressed. > 5. with "poorly aligned" needs specification. What specification do you need? There's a clear example pointed out in the screenshot (see nr. 5), where the "Seitenleiste" button simply doesn't line up with it's neighboring buttons "Lineale" und "Gitter". This is one of many examples, where the buttons or groups have "strange" horizontal or vertical offsets to their neighbors for no apparent reason. > does not mean implementing a couple of patches for this broad topic is > impossible. And some issues might have also been reported. I remember > discussions on a11y, the tab size, and white space. Feel free to split into separate issues, if it helps fixing. But it's really not one individual thing for me. The poor use of margins, padding, bad alignments, etc. make the entire Tabbed Notebook Bar look unfinished and messy. It's the combination of all those things. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149571] Automatic color doesn't change when object background is dark
https://bugs.documentfoundation.org/show_bug.cgi?id=149571 --- Comment #2 from Eyal Rozenberg --- (In reply to LeroyG from comment #1) > Reproducible from scratch You mean, not with my file? If so, can you give reproduction instructions? Also, this is actually two-issues-in-one: Dark area, and transparent area over a dark background object. Which did you reproduce? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 115634] in special characters dialog buttons for recent and favorite characters are too small on high resolution screens
https://bugs.documentfoundation.org/show_bug.cgi?id=115634 --- Comment #8 from Damian Hofmann --- Retested with LO 7.3.3.2. Still doesn't scale correctly. Version: 7.3.3.2 (x64) / LibreOffice Community Build ID: d1d0ea68f081ee2800a922cac8f79445e4603348 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-CH (de_CH); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135976] Anchor to character deleted with backspace at anchor position in bulleted list
https://bugs.documentfoundation.org/show_bug.cgi?id=135976 --- Comment #7 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/932a8efce878547bfd81521d0cf1ddfe8dc33ec6 tdf#135976 sw: preserve flys on backspace/delete with redlining enabled It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/uiwriter/uiwriter2.cxx | 95
sw/source/core/doc/DocumentContentOperationsManager.cxx |4
sw/source/core/doc/docedt.cxx |7 +
sw/source/core/inc/UndoRedline.hxx |8 +
sw/source/core/inc/mvsave.hxx |2
sw/source/core/undo/unredln.cxx | 32 +
6 files changed, 142 insertions(+), 6 deletions(-)
New commits:
commit 932a8efce878547bfd81521d0cf1ddfe8dc33ec6
Author: Michael Stahl
AuthorDate: Wed Jun 15 15:08:16 2022 +0200
Commit: Michael Stahl
CommitDate: Wed Jun 15 21:28:05 2022 +0200
tdf#135976 sw: preserve flys on backspace/delete with redlining enabled
This is a continuation of commit 85376a02348810812d515ee72140dbf56f2b6040
for the case when redlining is turned on.
Also try to restore the anchors in SwUndoRedlineDelete.
(regression from commit 3345feb67f2c49a1b76639965b56968e1c5f03ee)
Change-Id: I4199f5755398d469a606618c037ad9756cb7aeba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135909
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/sw/qa/extras/uiwriter/uiwriter2.cxx
b/sw/qa/extras/uiwriter/uiwriter2.cxx
index e62532c0a20d..0ff16f74e59d 100644
--- a/sw/qa/extras/uiwriter/uiwriter2.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter2.cxx
@@ -22,6 +22,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -1081,6 +1082,100 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testTdf139982)
CPPUNIT_ASSERT_EQUAL(size_t(1), pWrtShell->GetFlyCount(FLYCNTTYPE_FRM));
}
+CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testTdf135976)
+{
+SwDoc* const pDoc = createSwDoc();
+SwWrtShell* const pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+
+pWrtShell->Insert("foobar");
+
+pWrtShell->Left(CRSR_SKIP_CHARS, /*bSelect=*/false, 2,
/*bBasicCall=*/false);
+SwFormatAnchor anchor(RndStdIds::FLY_AT_CHAR);
+anchor.SetAnchor(pWrtShell->GetCursor()->GetPoint());
+SfxItemSet flySet(pDoc->GetAttrPool(), svl::Items);
+flySet.Put(anchor);
+SwFrameFormat const* pFly = pWrtShell->NewFlyFrame(flySet,
/*bAnchValid=*/true);
+CPPUNIT_ASSERT(pFly != nullptr);
+
+// turn on redlining and show changes
+pDoc->getIDocumentRedlineAccess().SetRedlineFlags(RedlineFlags::On |
RedlineFlags::ShowDelete
+ |
RedlineFlags::ShowInsert);
+dispatchCommand(mxComponent, ".uno:ShowTrackedChanges", {});
+CPPUNIT_ASSERT_MESSAGE("redlining should be on",
+ pDoc->getIDocumentRedlineAccess().IsRedlineOn());
+CPPUNIT_ASSERT_MESSAGE(
+"redlines should be visible",
+
IDocumentRedlineAccess::IsShowChanges(pDoc->getIDocumentRedlineAccess().GetRedlineFlags()));
+CPPUNIT_ASSERT(pWrtShell->GetLayout()->IsHideRedlines());
+
+CPPUNIT_ASSERT_EQUAL(size_t(1), pWrtShell->GetFlyCount(FLYCNTTYPE_FRM));
+CPPUNIT_ASSERT_EQUAL(size_t(1),
pWrtShell->GetLayout()->GetLastPage()->GetSortedObjs()->size());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(4),
pFly->GetAnchor().GetContentAnchor()->nContent.GetIndex());
+
+pWrtShell->UnSelectFrame();
+pWrtShell->SttEndDoc(/*bStart=*/false);
+pWrtShell->Left(CRSR_SKIP_CHARS, /*bSelect=*/false, 1,
/*bBasicCall=*/false);
+
+pWrtShell->DelLeft();
+pWrtShell->DelLeft();
+
+CPPUNIT_ASSERT_EQUAL(size_t(1), pWrtShell->GetFlyCount(FLYCNTTYPE_FRM));
+// the problem was that the fly was deleted from the layout
+CPPUNIT_ASSERT_EQUAL(size_t(1),
pWrtShell->GetLayout()->GetLastPage()->GetSortedObjs()->size());
+// check that the anchor was moved outside the redline
+CPPUNIT_ASSERT_EQUAL(sal_Int32(3),
pFly->GetAnchor().GetContentAnchor()->nContent.GetIndex());
+
+pWrtShell->Undo(2);
+
+CPPUNIT_ASSERT_EQUAL(size_t(1), pWrtShell->GetFlyCount(FLYCNTTYPE_FRM));
+CPPUNIT_ASSERT_EQUAL(size_t(1),
pWrtShell->GetLayout()->GetLastPage()->GetSortedObjs()->size());
+// check that the anchor was restored
+CPPUNIT_ASSERT_EQUAL(sal_Int32(4),
pFly->GetAnchor().GetContentAnchor()->nContent.GetIndex());
+
+pWrtShell->Redo(2);
+
+CPPUNIT_ASSERT_EQUAL(size_t(1), pWrtShell->GetFlyCount(FLYCNTTYPE_FRM));
+CPPUNIT_ASSERT_EQUAL(size_t(1),
pWrtShell->GetLayout()->GetLastPage()->GetSortedObjs()->size());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(3),
pFly->GetAnchor().GetContentAnchor()->nContent.GetIndex());
+
+pWrtShell->Undo(2);
+
+CPPUNIT_ASSERT_EQUAL(size_t(1), pWrtShell->GetFlyCount(FLYCNTTYPE_FRM));
+CPPUNIT_ASSERT_EQUAL(size_t(1),
pWrtShell->GetLayout()->GetLastPage()->GetSortedObjs()->size());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(4),
pFly->GetAnchor().GetContentAnchor()->nContent.GetIndex());
+
+// now again in the other direction:
+
+pWrtShell->SttEndDoc(/*bStart=*/false);
+pWrtShell->Left(CRSR_SKIP_CHARS, /*bSelect=*/false, 3,
/*bBasicCall=*/false);
+
[Libreoffice-bugs] [Bug 135976] Anchor to character deleted with backspace at anchor position in bulleted list
https://bugs.documentfoundation.org/show_bug.cgi?id=135976 Commit Notification changed: What|Removed |Added Whiteboard||target:7.5.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/core/undo/unredln.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit f31f11f3222933dbc96dc672e6fa52233cda12be
Author: Michael Stahl
AuthorDate: Wed Jun 15 15:06:59 2022 +0200
Commit: Michael Stahl
CommitDate: Wed Jun 15 21:26:29 2022 +0200
sw: fix odd m_bCanGroup check in SwUndoRedlineDelete
This looks like copypasta, presumably both flags must be true to allow
grouping.
Change-Id: I96afeac98f94b122a3b1a155940776a3aa44b0a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135908
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/sw/source/core/undo/unredln.cxx b/sw/source/core/undo/unredln.cxx
index eae6577d52ff..e48255c3ab5b 100644
--- a/sw/source/core/undo/unredln.cxx
+++ b/sw/source/core/undo/unredln.cxx
@@ -256,7 +256,7 @@ bool SwUndoRedlineDelete::CanGrouping( const
SwUndoRedlineDelete& rNext )
{
bool bRet = false;
if( SwUndoId::DELETE == mnUserId && mnUserId == rNext.mnUserId &&
-m_bCanGroup == rNext.m_bCanGroup &&
+m_bCanGroup && rNext.m_bCanGroup &&
m_bIsDelim == rNext.m_bIsDelim &&
m_bIsBackspace == rNext.m_bIsBackspace &&
m_nSttNode == m_nEndNode &&
[Libreoffice-commits] core.git: sw/source
sw/source/core/doc/DocumentRedlineManager.cxx |6 ++
1 file changed, 6 insertions(+)
New commits:
commit cf9a16caf5012d65b2a45a5525e36e40585dd35c
Author: Michael Stahl
AuthorDate: Tue Jun 14 17:19:23 2022 +0200
Commit: Michael Stahl
CommitDate: Wed Jun 15 21:25:22 2022 +0200
sw_redlinehide: skip unnecessary updates when undoing redlined delete
When reproducing tdf#135976 and then Undo, an UAF crash happens here:
assert(!pFrame->GetDrawObjs() || !pObjs->Contains(*pObj));
The pObjs was actually deleted and then re-created, because the pObj was
removed from the frame and added again to the same frame.
This is a bit unexpected, so prevent it by taking a shortcut in the
caller UpdateFramesForRemoveDeleteRedline() to insert a check that had
been removed in commit 14e87a4b15d31a34e6053f6194688f3aa23af991.
If the rPam is inside a single node, the sw::RedlineUnDelText hint that
was sent to the SwTextFrame should be sufficient to update it and the
rest of the code in the loop that deals with newly split paragraph can
be skipped.
Change-Id: I5f36eb91bc20003887ee0bad03ea4a6e67135de9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135907
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/sw/source/core/doc/DocumentRedlineManager.cxx
b/sw/source/core/doc/DocumentRedlineManager.cxx
index c2ddb046ef8b..8a9a70ae2bb9 100644
--- a/sw/source/core/doc/DocumentRedlineManager.cxx
+++ b/sw/source/core/doc/DocumentRedlineManager.cxx
@@ -309,6 +309,12 @@ void UpdateFramesForRemoveDeleteRedline(SwDoc & rDoc,
SwPaM const& rPam)
break;
}
+// no nodes can be unmerged by this - skip MakeFrames() etc.
+if (rPam.GetPoint()->nNode == rPam.GetMark()->nNode)
+{
+break; // continue with AppendAllObjs()
+}
+
// first, call CheckParaRedlineMerge on the first paragraph,
// to init flag on new merge range (if any) + 1st node post the
merge
auto eMode(sw::FrameMode::Existing);
[Libreoffice-bugs] [Bug 146628] Outline-Folding Button Is Too Small [HiDPI]
https://bugs.documentfoundation.org/show_bug.cgi?id=146628 --- Comment #4 from Damian Hofmann --- Retested. Issue still exists with LO 7.3.3.2 Version: 7.3.3.2 (x64) / LibreOffice Community Build ID: d1d0ea68f081ee2800a922cac8f79445e4603348 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-CH (de_CH); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: winaccessibility/source
winaccessibility/source/UAccCOM/MAccessible.cxx | 33 ++--
1 file changed, 4 insertions(+), 29 deletions(-)
New commits:
commit d8e827890f9ff3fca642b3af9475704fc376f845
Author: Michael Weghorn
AuthorDate: Wed Jun 15 12:47:50 2022 +0100
Commit: Michael Weghorn
CommitDate: Wed Jun 15 20:59:45 2022 +0200
wina11y: Drop implemenation for obsolete IAccessible::put_accName
Just return `E_NOTIMPL`, as the
`IAccessible::put_accName` doc now says [1]:
> The IAccessible::put_accName method is no longer supported. Client
> applications should use a control-specific workaround, such as the
> SetWindowText function. Servers should return E_NOTIMPL.
[1]
https://docs.microsoft.com/en-us/windows/win32/api/oleacc/nf-oleacc-iaccessible-put_accname
Change-Id: I4b36b6a4c4215f237ba7e7583d2f130e8d80f200
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135903
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/winaccessibility/source/UAccCOM/MAccessible.cxx
b/winaccessibility/source/UAccCOM/MAccessible.cxx
index f2f616980157..69353484d522 100644
--- a/winaccessibility/source/UAccCOM/MAccessible.cxx
+++ b/winaccessibility/source/UAccCOM/MAccessible.cxx
@@ -1049,37 +1049,12 @@ COM_DECLSPEC_NOTHROW STDMETHODIMP
CMAccessible::QueryService(REFGUID guidService
}
/**
-* Set the accessible name of the current COM object self or its one child from
UNO.
-* @paramvarChild, vt member of varChild must be VT_I4,and lVal member
stores the child ID,
-* the child ID specify child index from 0 to children count, 0 stands for
object self.
-* @paramszName, the name used to set the name of the proper object.
-* @return S_OK if successful and E_FAIL if failure.
+* No longer supported according to IAccessible doc.
+* Servers should return E_NOTIMPL
*/
-COM_DECLSPEC_NOTHROW STDMETHODIMP CMAccessible::put_accName(VARIANT varChild,
BSTR szName)
+COM_DECLSPEC_NOTHROW STDMETHODIMP CMAccessible::put_accName(VARIANT, BSTR)
{
-SolarMutexGuard g;
-
-try {
-if (m_isDestroy) return S_FALSE;
-if(varChild.vt==VT_I4)
-{
-if(varChild.lVal==CHILDID_SELF)
-{
-SysFreeString(m_pszName);
-m_pszName=SysAllocString(szName);
-return S_OK;
-}
-
-long lVal = varChild.lVal;
-varChild.lVal = CHILDID_SELF;
-IMAccessible *pChild = this->GetChildInterface(lVal);
-if(!pChild)
-return E_FAIL;
-return pChild->put_accName(varChild,szName);
-}
-return E_FAIL;
-
-} catch(...) { return E_FAIL; }
+return E_NOTIMPL;
}
/**
[Libreoffice-commits] core.git: framework/source
framework/source/dispatch/closedispatcher.cxx | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
New commits:
commit 539374caa5deac788f394a54a75b6e167ab04864
Author: Samuel Mehrbrodt
AuthorDate: Wed Jun 15 14:25:36 2022 +0200
Commit: Samuel Mehrbrodt
CommitDate: Wed Jun 15 20:53:45 2022 +0200
Show start center when closing last document
also when there are active UNO connections.
(Behavior was different when there were active UNO connections)
Change-Id: Ief37b0f362b7e2a47eccbec985ee3017c475046c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135905
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt
diff --git a/framework/source/dispatch/closedispatcher.cxx
b/framework/source/dispatch/closedispatcher.cxx
index 19fe9ffaa69d..a6ff39d459c3 100644
--- a/framework/source/dispatch/closedispatcher.cxx
+++ b/framework/source/dispatch/closedispatcher.cxx
@@ -353,12 +353,17 @@ IMPL_LINK_NOARG(CloseDispatcher, impl_asyncCallback,
LinkParamNone*, void)
// application or establish the backing mode now.
// And that depends from the dispatched URL ...
{
-if (bHasActiveConnections)
-bCloseFrame = true;
-else if (eOperation == E_CLOSE_FRAME)
-bTerminateApp = true;
+if (eOperation == E_CLOSE_FRAME)
+{
+if (bHasActiveConnections)
+bCloseFrame = true;
+else
+bTerminateApp = true;
+}
else if(
SvtModuleOptions().IsModuleInstalled(SvtModuleOptions::EModule::STARTMODULE) )
bEstablishBackingMode = true;
+else if (bHasActiveConnections)
+bCloseFrame = true;
else
bTerminateApp = true;
}
[Libreoffice-bugs] [Bug 149571] Automatic color doesn't change when object background is dark
https://bugs.documentfoundation.org/show_bug.cgi?id=149571 LeroyG changed: What|Removed |Added Version|unspecified |7.2.7.2 release --- Comment #1 from LeroyG --- Reproducible from scratch with: Version: 7.2.7.2 (x86) / LibreOffice Community Build ID: 8d71d29d553c0f7dcbfa38fbfda25ee34cce99a2 CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win Locale: es-MX (es_MX); UI: en-US Calc: threaded Text is shown in black, until you edit the text in the table cell. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149579] VBA Range.Sort should expand a single cell range to Range.CurrentRegion
https://bugs.documentfoundation.org/show_bug.cgi?id=149579 Eike Rathke changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149579] New: VBA Range.Sort should expand a single cell range to Range.CurrentRegion
https://bugs.documentfoundation.org/show_bug.cgi?id=149579
Bug ID: 149579
Summary: VBA Range.Sort should expand a single cell range to
Range.CurrentRegion
Product: LibreOffice
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: enhancement
Priority: medium
Component: Calc
Assignee: libreoffice-bugs@lists.freedesktop.org
Reporter: er...@redhat.com
If
Worksheets(1).Range("A1").Sort
is given, the single cell range A1 should be expanded to the
Range.CurrentRegion contiguous data area, same as if Sort was invoked by UI and
Excel does in VBA.
RFE created from
https://ask.libreoffice.org/t/microsoft-excel-vba-sort-function-which-works-with-libreoffice-calc-without-modification/78606
See also
https://docs.microsoft.com/en-us/office/vba/api/excel.range.sort
https://docs.microsoft.com/en-us/office/vba/api/excel.range.currentregion
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/source
sc/source/filter/excel/xepivotxml.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 2f30596347b12a7d0b9b78a1e4e2bc50eca9223a
Author: Caolán McNamara
AuthorDate: Tue Jun 14 10:35:38 2022 +0100
Commit: Caolán McNamara
CommitDate: Wed Jun 15 20:44:35 2022 +0200
don't assert on exporting forum-mso-de-104384.xlsx to xlsx
a case of this -2 is also mentioned in
commit 97af58093978d8e6b9d90eedcc59141304e7200e
Date: Fri Apr 5 22:04:13 2019 +0530
tdf#123421 : xlsx export : Don't write data field entry...
Change-Id: Ieded6035539df9d3896f2f08cf03c195082d4987
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135817
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sc/source/filter/excel/xepivotxml.cxx
b/sc/source/filter/excel/xepivotxml.cxx
index 4bd34041328a..ecc39caae37f 100644
--- a/sc/source/filter/excel/xepivotxml.cxx
+++ b/sc/source/filter/excel/xepivotxml.cxx
@@ -1118,7 +1118,7 @@ void XclExpXmlPivotTables::SavePivotTableXml(
XclExpXmlStream& rStrm, const ScDP
for (const auto& rDataField : aDataFields)
{
tools::Long nDimIdx = rDataField.mnPos;
-assert(aCachedDims[nDimIdx]); // the loop above should have
screened for NULL's.
+assert(nDimIdx == -2 || aCachedDims[nDimIdx]); // the loop above
should have screened for NULL's, skip check for -2 "data field"
const ScDPSaveDimension& rDim = *rDataField.mpDim;
std::optional pName = rDim.GetLayoutName();
// tdf#124651: despite being optional in CT_DataField according to
ECMA-376 Part 1,
[Libreoffice-bugs] [Bug 149569] Spreadsheet refuses to use the correct number of decimal places
https://bugs.documentfoundation.org/show_bug.cgi?id=149569 --- Comment #4 from LeroyG --- Maybe you must check [x] Precision as shown (https://help.libreoffice.org/latest/en-US/text/shared/optionen/01060500.html#hd_id3145150). -- You are receiving this mail because: You are the assignee for the bug.
