[Libreoffice-commits] core.git: vcl/win
vcl/win/gdi/DWriteTextRenderer.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit c9974818bdf9ab8ccf2f8db140ff6b2b3eb1c461
Author: Michael Weghorn
AuthorDate: Fri Sep 9 11:56:17 2022 +0100
Commit: خالد حسني
CommitDate: Sat Sep 10 07:55:11 2022 +0200
win: Explicitly cast glyph ID to 16 bit
After
commit ba02639c9c17d75e73fc2eff83e64c116fcdaeb2
Date: Wed Sep 7 11:00:26 2022 +0200
vcl: Make glyph IDs 32bit
, my clang-cl Windows build would otherwise fail as follows:
[build CXX] vcl/win/gdi/DWriteTextRenderer.cxx
[build CUS] postprocess/images
C:/tools/cygwin/home/michael/development/git/libreoffice/vcl/win/gdi/DWriteTextRenderer.cxx(264,39):
error: non-constant-expression cannot be narrowed from type 'sal_GlyphId' (aka
'unsigned int') to 'UINT16'
(aka 'unsigned short') in initializer list [-Wc++11-narrowing]
UINT16 glyphIndices[] = { pGlyph->glyphId() };
^
C:/tools/cygwin/home/michael/development/git/libreoffice/vcl/win/gdi/DWriteTextRenderer.cxx(264,39):
note: insert an explicit cast to silence this issue
UINT16 glyphIndices[] = { pGlyph->glyphId() };
^
static_cast( )
1 error generated.
Change-Id: Ifa4fcdd98331378b5d9340f961e0bc4d7e842fe2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139721
Tested-by: Jenkins
Reviewed-by: خالد حسني
diff --git a/vcl/win/gdi/DWriteTextRenderer.cxx
b/vcl/win/gdi/DWriteTextRenderer.cxx
index 835e09e7eed9..c160166a541e 100644
--- a/vcl/win/gdi/DWriteTextRenderer.cxx
+++ b/vcl/win/gdi/DWriteTextRenderer.cxx
@@ -261,7 +261,7 @@ bool
D2DWriteTextOutRenderer::performRender(GenericSalLayout const & rLayout, Sa
const GlyphItem* pGlyph;
while (rLayout.GetNextGlyph(, aPos, nStart))
{
-UINT16 glyphIndices[] = { pGlyph->glyphId() };
+UINT16 glyphIndices[] = { static_cast(pGlyph->glyphId()) };
FLOAT glyphAdvances[] = { static_cast(pGlyph->newWidth()) /
fHScale };
DWRITE_GLYPH_OFFSET glyphOffsets[] = { { 0.0f, 0.0f }, };
D2D1_POINT_2F baseline = { static_cast(aPos.getX() -
bounds.Left()) / fHScale,
[Libreoffice-commits] core.git: include/vcl vcl/inc vcl/source
include/vcl/fontcharmap.hxx |3 -
vcl/inc/impfontcharmap.hxx |7 +-
vcl/source/font/PhysicalFontFace.cxx | 14 +
vcl/source/font/fontcharmap.cxx | 82 ++-
4 files changed, 44 insertions(+), 62 deletions(-)
New commits:
commit f4bd06f9928fc01762f9e52c5bebcb3137b39665
Author: Khaled Hosny
AuthorDate: Thu Sep 8 17:13:25 2022 +0200
Commit: خالد حسني
CommitDate: Sat Sep 10 07:54:29 2022 +0200
vcl: Use vector instead of array for FontCharMap ranges
Change-Id: I8846c89d51cc33022f90c3a9c03bc1560497e651
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139701
Tested-by: Jenkins
Reviewed-by: خالد حسني
diff --git a/include/vcl/fontcharmap.hxx b/include/vcl/fontcharmap.hxx
index f7bea49f0f7a..de41b4925683 100644
--- a/include/vcl/fontcharmap.hxx
+++ b/include/vcl/fontcharmap.hxx
@@ -23,6 +23,7 @@
#include
#include
#include
+#include
class ImplFontCharMap;
class FontCharMap;
@@ -41,7 +42,7 @@ public:
/** A new FontCharMap is created based on passed arguments.
*/
-FontCharMap(bool bSymbolic, const sal_UCS4* pRangeCodes, int nRangeCount);
+FontCharMap(bool bSymbolic, std::vector aRangeCodes);
virtual ~FontCharMap() override;
diff --git a/vcl/inc/impfontcharmap.hxx b/vcl/inc/impfontcharmap.hxx
index 1334dc76b262..552cb736020f 100644
--- a/vcl/inc/impfontcharmap.hxx
+++ b/vcl/inc/impfontcharmap.hxx
@@ -22,6 +22,7 @@
#include
#include
+#include
class ImplFontCharMap;
typedef tools::SvRef ImplFontCharMapRef;
@@ -30,8 +31,7 @@ class ImplFontCharMap final : public SvRefBase
{
public:
explicitImplFontCharMap( bool bSymbolic,
- const sal_uInt32* pRangeCodes,
- int nRangeCount);
+ std::vector aRangeCodes);
virtual ~ImplFontCharMap() override;
private:
@@ -44,8 +44,7 @@ private:
boolisDefaultMap() const;
private:
-const sal_uInt32* mpRangeCodes; // pairs of StartCode/(EndCode+1)
-int mnRangeCount;
+std::vector maRangeCodes; // pairs of StartCode/(EndCode+1)
int mnCharCount; // covered codepoints
const bool m_bSymbolic;
};
diff --git a/vcl/source/font/PhysicalFontFace.cxx
b/vcl/source/font/PhysicalFontFace.cxx
index e3a4638b3139..88670f6e0ff6 100644
--- a/vcl/source/font/PhysicalFontFace.cxx
+++ b/vcl/source/font/PhysicalFontFace.cxx
@@ -249,21 +249,15 @@ FontCharMapRef PhysicalFontFace::GetFontCharMap() const
if (hb_set_get_population(pUnicodes))
{
// Convert HarfBuzz set to code ranges.
-int nRangeCount = 0;
+std::vector aRangeCodes;
hb_codepoint_t nFirst, nLast = HB_SET_VALUE_INVALID;
-while (hb_set_next_range(pUnicodes, , ))
-nRangeCount++;
-
-nLast = HB_SET_VALUE_INVALID;
-auto* pRangeCodes(new sal_UCS4[nRangeCount * 2]);
-auto* pCP = pRangeCodes;
while (hb_set_next_range(pUnicodes, , ))
{
-*(pCP++) = nFirst;
-*(pCP++) = nLast + 1;
+aRangeCodes.push_back(nFirst);
+aRangeCodes.push_back(nLast + 1);
}
-mxCharMap = new FontCharMap(bSymbol, pRangeCodes, nRangeCount);
+mxCharMap = new FontCharMap(bSymbol, std::move(aRangeCodes));
}
hb_set_destroy(pUnicodes);
diff --git a/vcl/source/font/fontcharmap.cxx b/vcl/source/font/fontcharmap.cxx
index 70fb51375580..0a7148a663c0 100644
--- a/vcl/source/font/fontcharmap.cxx
+++ b/vcl/source/font/fontcharmap.cxx
@@ -24,50 +24,36 @@
#include
static ImplFontCharMapRef g_pDefaultImplFontCharMap;
-const sal_UCS4 aDefaultUnicodeRanges[] = {0x0020,0xD800, 0xE000,0xFFF0};
-const sal_UCS4 aDefaultSymbolRanges[] = {0x0020,0x0100, 0xF020,0xF100};
+const std::vector aDefaultUnicodeRanges = { 0x0020, 0xD800,
0xE000, 0xFFF0 };
+const std::vector aDefaultSymbolRanges = { 0x0020, 0x0100, 0xF020,
0xF100 };
ImplFontCharMap::~ImplFontCharMap()
{
-if( !isDefaultMap() )
-{
-delete[] mpRangeCodes;
-}
}
-ImplFontCharMap::ImplFontCharMap(bool bSymbolic, const sal_UCS4* pRangeCodes,
int nRangeCount)
-: mpRangeCodes(pRangeCodes)
-, mnRangeCount(nRangeCount)
+ImplFontCharMap::ImplFontCharMap(bool bSymbolic, std::vector
aRangeCodes)
+: maRangeCodes(std::move(aRangeCodes))
, mnCharCount( 0 )
, m_bSymbolic(bSymbolic)
{
-const sal_UCS4* pRangePtr = mpRangeCodes;
-for( int i = mnRangeCount; --i >= 0; pRangePtr += 2 )
+for (size_t i = 0; i < maRangeCodes.size(); i += 2)
{
-sal_UCS4 cFirst = pRangePtr[0];
-sal_UCS4 cLast = pRangePtr[1];
+sal_UCS4 cFirst = maRangeCodes[i];
+sal_UCS4 cLast = maRangeCodes[i + 1];
mnCharCount += cLast - cFirst;
}
}
ImplFontCharMapRef const & ImplFontCharMap::getDefaultMap( bool
[Libreoffice-bugs] [Bug 103859] [META] EMF/WMF (Enhanced/Windows Metafile) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103859 Aron Budea changed: What|Removed |Added Depends on||150888 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=150888 [Bug 150888] Blurry icon in OLE link -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150888] Blurry icon in OLE link
https://bugs.documentfoundation.org/show_bug.cgi?id=150888 Aron Budea changed: What|Removed |Added Regression By||Hossein See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=88 ||163 Status|UNCONFIRMED |NEW CC||aron.bu...@gmail.com, ||hoss...@libreoffice.org Keywords||bibisected, bisected, ||regression Ever confirmed|0 |1 Version|7.3.5.2 release |7.3.0.3 release Blocks||103859 --- Comment #5 from Aron Budea --- Confirmed using LO 7.5.0.0.alpha0+ (ee003ca99f94c9a5517ebba67ed02abb2a60dae8) / Ubuntu. This is a regression, and could be bibisected to the following commit using repo bibisect-linux-64-7.3. Adding CC: to Hossein. https://cgit.freedesktop.org/libreoffice/core/commit/?id=5e4e1cdb1e14354b42838e1dfcf82873b3071896 author Hossein2021-09-27 06:53:47 +0200 committer Hossein2021-09-27 22:08:15 +0200 tdf#88163 Fix font size for placeable wmf files Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103859 [Bug 103859] [META] EMF/WMF (Enhanced/Windows Metafile) bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: winaccessibility/Library_uacccom.mk winaccessibility/source
winaccessibility/Library_uacccom.mk |1 +
winaccessibility/source/UAccCOM/MAccessible.cxx | 19 +++
2 files changed, 8 insertions(+), 12 deletions(-)
New commits:
commit 235b30bdfa76b5c0514c7dfe2a0d13ab8ecf5be2
Author: Michael Weghorn
AuthorDate: Fri Sep 9 23:04:19 2022 +0100
Commit: Michael Weghorn
CommitDate: Sat Sep 10 07:21:17 2022 +0200
wina11y: Report actual app/toolkit name/version
The previous way of reporting "Hannover" as app name, "3.0" as
version and no toolkit name and version looks rather arbitrary.
Can be queried e.g. from NVDA's Python console as follows after
pressing Keypad_Insert+Ctrl+Z with any LibreOffice UI element focused:
>>>
focus.IAccessibleObject.QueryInterface(IA2.IAccessibleApplication).appName
'Hannover'
>>>
focus.IAccessibleObject.QueryInterface(IA2.IAccessibleApplication).appVersion
'3.0'
>>>
focus.IAccessibleObject.QueryInterface(IA2.IAccessibleApplication).toolkitName
' '
>>>
focus.IAccessibleObject.QueryInterface(IA2.IAccessibleApplication).toolkitVersion
' '
Report the actual app name and version. For the toolkit use "VCL"
as name and the same version that LibreOffice has:
>>>
focus.IAccessibleObject.QueryInterface(IA2.IAccessibleApplication).appName
'LibreOfficeDev'
>>>
focus.IAccessibleObject.QueryInterface(IA2.IAccessibleApplication).appVersion
'7.5'
>>>
focus.IAccessibleObject.QueryInterface(IA2.IAccessibleApplication).toolkitName
'VCL'
>>>
focus.IAccessibleObject.QueryInterface(IA2.IAccessibleApplication).toolkitVersion
'7.5'
Change-Id: I3c6bdb79e6b945c0f9707bfa7bada0fb456d6e05
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139743
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/winaccessibility/Library_uacccom.mk
b/winaccessibility/Library_uacccom.mk
index 8c3d3c1596e5..0fb07814b2f9 100644
--- a/winaccessibility/Library_uacccom.mk
+++ b/winaccessibility/Library_uacccom.mk
@@ -58,6 +58,7 @@ $(eval $(call gb_Library_use_libraries,UAccCOM,\
comphelper \
cppu \
sal \
+ utl \
))
$(eval $(call gb_Library_use_externals,UAccCOM,\
diff --git a/winaccessibility/source/UAccCOM/MAccessible.cxx
b/winaccessibility/source/UAccCOM/MAccessible.cxx
index 2b11d2ed7d12..3cb544f3ba80 100644
--- a/winaccessibility/source/UAccCOM/MAccessible.cxx
+++ b/winaccessibility/source/UAccCOM/MAccessible.cxx
@@ -45,6 +45,7 @@
#include
#include
+#include
#include
#include
#include
@@ -3033,7 +3034,8 @@ COM_DECLSPEC_NOTHROW STDMETHODIMP
CMAccessible::get_appName(BSTR __RPC_FAR *name
if(name == nullptr)
return E_INVALIDARG;
-*name = SysAllocString(OLESTR("Hannover"));
+static const OUString sAppName = utl::ConfigManager::getProductName();
+*name = SysAllocString(o3tl::toW(sAppName.getStr()));
return S_OK;
} catch(...) { return E_FAIL; }
}
@@ -3045,7 +3047,8 @@ COM_DECLSPEC_NOTHROW STDMETHODIMP
CMAccessible::get_appVersion(BSTR __RPC_FAR *v
if (m_isDestroy) return S_FALSE;
if(version == nullptr)
return E_INVALIDARG;
-*version=SysAllocString(OLESTR("3.0"));
+static const OUString sVersion =
utl::ConfigManager::getProductVersion();
+*version=SysAllocString(o3tl::toW(sVersion.getStr()));
return S_OK;
} catch(...) { return E_FAIL; }
}
@@ -3057,21 +3060,13 @@ COM_DECLSPEC_NOTHROW STDMETHODIMP
CMAccessible::get_toolkitName(BSTR __RPC_FAR *
if (m_isDestroy) return S_FALSE;
if(name == nullptr)
return E_INVALIDARG;
-*name = SysAllocString(OLESTR(" "));
+*name = SysAllocString(OLESTR("VCL"));
return S_OK;
} catch(...) { return E_FAIL; }
}
COM_DECLSPEC_NOTHROW STDMETHODIMP CMAccessible::get_toolkitVersion(BSTR
__RPC_FAR *version)
{
-SolarMutexGuard g;
-
-try {
-if (m_isDestroy) return S_FALSE;
-if(version == nullptr)
-return E_INVALIDARG;
-*version = SysAllocString(OLESTR(" "));
-return S_OK;
-} catch(...) { return E_FAIL; }
+return get_appVersion(version);
}
[Libreoffice-bugs] [Bug 136524] [META] Performance/hang/lag/high CPU issues
https://bugs.documentfoundation.org/show_bug.cgi?id=136524 Bug 136524 depends on bug 131781, which changed state. Bug 131781 Summary: Calculating optimal width relatively slow CPU/consuming (Win-only) https://bugs.documentfoundation.org/show_bug.cgi?id=131781 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131781] Calculating optimal width relatively slow CPU/consuming (Win-only)
https://bugs.documentfoundation.org/show_bug.cgi?id=131781 Buovjaga changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #9 from Buovjaga --- Yeah, let's close. Many Calc optimisations have been made in the two years since this was reported and more will surely follow. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150861] Autofilter result is wrong when I deselect one item, click OK, then click on the dropdown again
https://bugs.documentfoundation.org/show_bug.cgi?id=150861 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148178] SVG Export from macro in old version of SVG
https://bugs.documentfoundation.org/show_bug.cgi?id=148178 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150590] 文件列印顏色錯誤
https://bugs.documentfoundation.org/show_bug.cgi?id=150590 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150622] High Contrast theme is broken with GTK3.
https://bugs.documentfoundation.org/show_bug.cgi?id=150622 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147340] Libreoffice 7.3 Print bug
https://bugs.documentfoundation.org/show_bug.cgi?id=147340 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150616] FILESAVE PDF Table row disappears from complex table after CLI PDF export
https://bugs.documentfoundation.org/show_bug.cgi?id=150616 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147340] Libreoffice 7.3 Print bug
https://bugs.documentfoundation.org/show_bug.cgi?id=147340 --- Comment #3 from QA Administrators --- Dear thelupe, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147945] software crashes when formatting cell underline
https://bugs.documentfoundation.org/show_bug.cgi?id=147945 --- Comment #2 from QA Administrators --- Dear clydeh7, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147940] LibreOfficeWriterCrashing on one text file
https://bugs.documentfoundation.org/show_bug.cgi?id=147940 --- Comment #3 from QA Administrators --- Dear Simon, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136757] White triangles throughout UI after updating to 7.x.
https://bugs.documentfoundation.org/show_bug.cgi?id=136757 --- Comment #10 from QA Administrators --- Dear Thomas Leigh, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 76131] Existing pinned icon on Win7/8/10/11 is taskbar invalid after re-installation/update
https://bugs.documentfoundation.org/show_bug.cgi?id=76131 --- Comment #71 from V Stuart Foote --- (In reply to John Page from comment #70) > As I see it, this is not merely a "bug", but simply bad programming. I am > frequently up-dating software, but very few apps need the existing version > to be uninstalled before installing the updated version. Most merely update > the relevant DLL files into the existing software. This particular issue is > limited to the part of the software dealing with the formation of the > taskbar listings. Therefore, it seems to me that only that portion of the > code needs to be replaced, leaving everything else untouched. > > Dealing with updates in that fashion would not only leave everything else as > it was, but the updating process would take much less time to complete, with > minimal impact on the registry, which cannot be a bad thing. That is generically know as incremental updating. See bug 68274, or the general tracking meta bug 113339. And, retaining Windows JumpLists inside user os profiles is native code. Specific Windows packaging might address situation for os/DE registered JumpLists -- but project cross-platform already retains our MRU history in our per-user profile. The Windows specific bug has received attention, and while we've been able to retain between minor incremental builds the rub comes with major version updates. There might be a solution, but it remains a minor issue (though affecting all Windows users at version update). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150896] New: Print and File dialogs showing wrong language
https://bugs.documentfoundation.org/show_bug.cgi?id=150896 Bug ID: 150896 Summary: Print and File dialogs showing wrong language Product: LibreOffice Version: 7.4.0.3 release Hardware: ARM OS: macOS (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: libreoff...@chaosallen.org Description: When installing v7.4.0 on macOS/M1(ARM) which has the OS locale set to en_US, multiple dialog boxes have a non-English language displayed. This can be recovered from by creating the directory /Applications/LibreOffice.app/Contents/Resources/en.lproj and restarting LibreOffice. Steps to Reproduce: 1. Install 7.4.0.3 on M1 Mac 2. Set OS language to US English 3. Open LibreOffice 4. Create a new empty document 5. Print the document Actual Results: Print dialog box shows German-looking labels on the buttons. Expected Results: Print dialog box shows labels in English. Reproducible: Always User Profile Reset: No Additional Info: When installing 7.4.0.3 on macOS/Intel, /Applications/LibreOffice.app/Contents/Resources/en.lproj exists as an empty directory, and the application behaves as expected. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150894] Added Gradients Not Saved in documents (ODT, ODG)
https://bugs.documentfoundation.org/show_bug.cgi?id=150894 --- Comment #4 from saved2se...@gmail.com --- Yes, that basically describes the issue, though my version is more descriptive, so I do not know how such complementary duplication is handled. Note that Comment 2 by Regina Henschel 2016-11-24 11:46:18 UTC that "the gradient which has been defined in the situation of page background and which is applied as background, is no longer available, if you save and reopen the document" needs clarification, as the gradient which had been defined and applied as background still is the page or frame background after closing and reopening the saved document, and can be altered. However, it is not listed in the group of available gradients, though it could be added, named and saved as available in that (and only that) open document - as long as it remains open. Hope this helps. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 126535] 'Find' doesn't show number of matches
https://bugs.documentfoundation.org/show_bug.cgi?id=126535 Jim Raykowski changed: What|Removed |Added CC||rayk...@gmail.com Assignee|libreoffice-b...@lists.free |rayk...@gmail.com |desktop.org | --- Comment #11 from Jim Raykowski --- Hi All, Here is an enhancement patch to show number of matches in Find and Replace dialog and Findbar: https://gerrit.libreoffice.org/c/core/+/139745 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148178] SVG Export from macro in old version of SVG
https://bugs.documentfoundation.org/show_bug.cgi?id=148178 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #1 from Regina Henschel --- Are you sure about the used version? The bug 105636. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150894] Added Gradients Not Saved in documents (ODT, ODG)
https://bugs.documentfoundation.org/show_bug.cgi?id=150894 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #3 from Regina Henschel --- I think, your problem is already covered by bug 103916. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/source
vcl/source/app/salvtables.cxx |5 +
1 file changed, 5 insertions(+)
New commits:
commit 37d778b601966434ff6042373c1a82d4687fd034
Author: Miklos Vajna
AuthorDate: Thu Sep 8 13:48:01 2022 +0200
Commit: Miklos Vajna
CommitDate: Sat Sep 10 00:33:03 2022 +0200
vcl: fix crash in SalInstanceWidget::set_busy_cursor()
Crashreport signature:
Fatal signal received: SIGSEGV code: 128 for address: 0x0
program/libmergedlo.so
vcl::Window::LeaveWait()
vcl/source/window/mouse.cxx:640
program/libsclo.so
ScSpellingEngine::ShowTableWrapDialog()
sc/source/ui/view/spelleng.cxx:315
program/libsclo.so
ScConversionEngineBase::FindNextConversionCell()
sc/source/ui/view/spelleng.cxx:168
program/libsclo.so
ScSpellDialogChildWindow::GetNextWrongSentence(bool)
/opt/rh/devtoolset-10/root/usr/include/c++/10/bits/unique_ptr.h:173
Change-Id: I298789211d6ee038bd5a9a7bff7cf9ae4f132a91
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139731
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index 74327b0bf72e..d4f9b41e329c 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -552,6 +552,11 @@ void SalInstanceWidget::thaw()
void SalInstanceWidget::set_busy_cursor(bool bBusy)
{
+if (!m_xWidget)
+{
+return;
+}
+
if (bBusy)
m_xWidget->EnterWait();
else
[Libreoffice-bugs] [Bug 119039] Writer crash when I try to open 4-pages DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=119039 --- Comment #12 from Julien Nabet --- Just for the record because I'm suppose it's wrong, if I delete this: delete m_pNativeImpl; (see https://opengrok.libreoffice.org/xref/core/embeddedobj/source/msole/olecomponent.cxx?r=7b8f630d#373) File can be opened on Windows. It seems there's something wrong with m_pNativeImpl->m_pIStorage m_pNativeImpl is ok but if I try something like: m_pNativeImpl->m_pIStorage = nullptr; it segfaults. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131781] Calculating optimal width relatively slow CPU/consuming (Win-only)
https://bugs.documentfoundation.org/show_bug.cgi?id=131781 --- Comment #8 from Telesto --- seems resolved based on comment 3 + comment 6 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150895] Libre Office Draw Position and Size Base Point not working
https://bugs.documentfoundation.org/show_bug.cgi?id=150895 --- Comment #1 from cos...@tutanota.com --- Just found a temp workaround. 1. Know where you want the center of your object for X and Y 2. Select object and right click Position and Size 3. Select the new base point (such as center) 4 Enter the x and y you want the base point center to be on 5. Hit OK and it will snap to that location. The desire is to have this work as you chance and update inside the Position and Size dialog box and believe that was the intent for how it should work. This workaround will get me by for now. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150895] New: Libre Office Draw Position and Size Base Point not working
https://bugs.documentfoundation.org/show_bug.cgi?id=150895 Bug ID: 150895 Summary: Libre Office Draw Position and Size Base Point not working Product: LibreOffice Version: 7.3.5.2 release Hardware: x86 (IA32) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: cos...@tutanota.com Description: The position and base point are not working at all. When trying to set the base point to center or other locations on a circle (or other object) it will not work. This is in addition to the Base Point not remembering (also an issue). Please fix this, really need! Steps to Reproduce: 1.Place any object in the drawing 2. Select it 3. Go to Format, Position and Size 4. Select a new base point other than upper left corner 5. Hit OK Actual Results: Object is still using the upper left corner as base point Expected Results: Base point reference updates for selected object Reproducible: Always User Profile Reset: No Additional Info: On first trying this Draw Crashed and closed. After retrying it would not crash but would not work. Removed and reinstalled Draw, still no joy. Using Ubuntu Studio 64 (KDE) most up to date as of 09/09/22 Using Ubuntu Discover to install and uninstall. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149013] Description of images, OLE objects and shapes is not exported to HTML
https://bugs.documentfoundation.org/show_bug.cgi?id=149013 stragu changed: What|Removed |Added Component|Writer Web |Writer CC||stephane.guil...@member.fsf ||.org Version|7.4.0.0 alpha0+ |6.3.6.2 release --- Comment #20 from stragu --- Thanks for a very informative discussion, this is a bug report to keep handy for a long list of useful accessibility references. LO 6.3 didn't keep the description either, when either saving as HTML or exporting as XHTML: Version: 6.3.6.2 Build ID: 2196df99b074d8a661f4036fca8fa0cbfa33a497 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3; Locale: en-AU (en_AU.UTF-8); UI-Language: en-US Calc: threaded Also changing the component to "Writer" as "Writer Web" is about the alternative view. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140302] Image repeats itself a number of times in an RTF (import issue)
https://bugs.documentfoundation.org/show_bug.cgi?id=140302 Miklos Vajna changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |vmik...@collabora.com |desktop.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148636] Layout of large Web documents makes some (large) parts of text stay "between" pages
https://bugs.documentfoundation.org/show_bug.cgi?id=148636 stragu changed: What|Removed |Added Whiteboard| QA:needsComment| Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from stragu --- I can't reproduce in: Version: 7.2.7.2 / LibreOffice Community Build ID: 8d71d29d553c0f7dcbfa38fbfda25ee34cce99a2 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded nor with: Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: 24087697d5cf78aac346d4dcea0596373e15a95c CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Mike, could you test again? Or maybe it's Windows-specific? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: dbaccess/source
dbaccess/source/core/api/RowSet.cxx | 10 +-
dbaccess/source/core/api/RowSetBase.cxx | 30 +++---
dbaccess/source/core/api/RowSetBase.hxx | 10 +-
3 files changed, 25 insertions(+), 25 deletions(-)
New commits:
commit 270df129a428a7346f87ebd760cfd51780750592
Author: Noel Grandin
AuthorDate: Wed Sep 7 08:46:02 2022 +0200
Commit: Noel Grandin
CommitDate: Fri Sep 9 22:15:51 2022 +0200
convert CursorMoveDirection to scoped enum
Change-Id: I9ad59207fab6d3988b8c8106aec6c4fac21dc9d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139734
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/dbaccess/source/core/api/RowSet.cxx
b/dbaccess/source/core/api/RowSet.cxx
index bd826fcf5797..69f61044f0a9 100644
--- a/dbaccess/source/core/api/RowSet.cxx
+++ b/dbaccess/source/core/api/RowSet.cxx
@@ -974,7 +974,7 @@ void SAL_CALL ORowSet::deleteRow( )
// this call position the cache indirect
Any aBookmarkToDelete( m_aBookmark );
-positionCache( MOVE_NONE );
+positionCache( CursorMoveDirection::Current );
sal_Int32 nDeletePosition = m_pCache->getRow();
notifyRowSetAndClonesRowDelete( aBookmarkToDelete );
@@ -1021,7 +1021,7 @@ void ORowSet::implCancelRowUpdates( bool _bNotifyModified
)
if ( m_bNew || m_nResultSetConcurrency == ResultSetConcurrency::READ_ONLY )
throwFunctionSequenceException(*this);
-positionCache( MOVE_NONE );
+positionCache( CursorMoveDirection::Current );
ORowSetRow aOldValues;
if ( !m_bModified && _bNotifyModified && !m_aCurrentRow.isNull() )
@@ -1171,12 +1171,12 @@ void SAL_CALL ORowSet::moveToInsertRow( )
ORowSetRow aOldValues;
if ( rowDeleted() )
{
-positionCache( MOVE_FORWARD );
+positionCache( CursorMoveDirection::Forward );
m_pCache->next();
setCurrentRow( true, false, aOldValues, aGuard);
}
else
-positionCache( MOVE_NONE );
+positionCache( CursorMoveDirection::Current );
// check before because the resultset could be empty
if ( !m_bBeforeFirst
@@ -1265,7 +1265,7 @@ void SAL_CALL ORowSet::moveToCurrentRow( )
if ( !notifyAllListenersCursorBeforeMove( aGuard ) )
return;
-positionCache( MOVE_NONE_REFRESH );
+positionCache( CursorMoveDirection::CurrentRefresh );
ORowSetNotifier aNotifier( this );
diff --git a/dbaccess/source/core/api/RowSetBase.cxx
b/dbaccess/source/core/api/RowSetBase.cxx
index e6eddc57eef5..753c857eecc0 100644
--- a/dbaccess/source/core/api/RowSetBase.cxx
+++ b/dbaccess/source/core/api/RowSetBase.cxx
@@ -207,7 +207,7 @@ const ORowSetValue& ORowSetBase::impl_getValue(sal_Int32
columnIndex)
if ( !bValidCurrentRow )
{
// currentrow is null when the clone moves the window
-positionCache( MOVE_NONE );
+positionCache( CursorMoveDirection::Current );
m_aCurrentRow = m_pCache->m_aMatrixIter;
m_bIsInsertRow = false;
OSL_ENSURE(!m_aCurrentRow.isNull(),"ORowSetBase::getValue: we don't
stand on a valid row! Row is null.");
@@ -338,7 +338,7 @@ Reference< css::io::XInputStream > SAL_CALL
ORowSetBase::getBinaryStream( sal_In
bool bValidCurrentRow = ( !m_aCurrentRow.isNull() && m_aCurrentRow !=
m_pCache->getEnd() && m_aCurrentRow->is() );
if ( !bValidCurrentRow )
{
-positionCache( MOVE_NONE );
+positionCache( CursorMoveDirection::Current );
m_aCurrentRow = m_pCache->m_aMatrixIter;
m_bIsInsertRow = false;
OSL_ENSURE(!m_aCurrentRow.isNull(),"ORowSetBase::getBinaryStream: we
don't stand on a valid row! Row is null.");
@@ -579,7 +579,7 @@ sal_Bool SAL_CALL ORowSetBase::next( )
ORowSetRow aOldValues = getOldRow(bWasNew);
-positionCache( MOVE_FORWARD );
+positionCache( CursorMoveDirection::Forward );
bool bAfterLast = m_pCache->isAfterLast();
bRet = m_pCache->next();
doCancelModification( );
@@ -662,7 +662,7 @@ sal_Bool SAL_CALL ORowSetBase::isFirst( )
if ( impl_rowDeleted() )
return ( m_nDeletedPosition == 1 );
-positionCache( MOVE_NONE );
+positionCache( CursorMoveDirection::Current );
bool bIsFirst = m_pCache->isFirst();
SAL_INFO("dbaccess", "ORowSetBase::isFirst() = " << bIsFirst << " Clone =
" << m_bClone);
@@ -692,7 +692,7 @@ sal_Bool SAL_CALL ORowSetBase::isLast( )
return ( m_nDeletedPosition == impl_getRowCount() );
}
-positionCache( MOVE_NONE );
+positionCache( CursorMoveDirection::Current );
bool bIsLast = m_pCache->isLast();
SAL_INFO("dbaccess", "ORowSetBase::isLast() = " << bIsLast << " Clone = "
<< m_bClone);
@@ -864,7 +864,7 @@ sal_Int32 ORowSetBase::impl_getRow()
nPos = 0;
else
{
-positionCache( MOVE_NONE );
+positionCache( CursorMoveDirection::Current );
nPos = m_pCache->getRow();
}
[Libreoffice-bugs] [Bug 123838] Issue on CAST() (FirebirdSQL)
https://bugs.documentfoundation.org/show_bug.cgi?id=123838 --- Comment #10 from priya singh --- > escorts super-sexy Bangalore Call Girls, but they’re also really friendly, > fun and easy to get along with – which makes them the perfect date for > anyone who wants to spend some quality time with an exciting partner in > their city. Whether you want a naughty night in or are looking to book an > adventurous weekend away, we’ve got all kinds of hot female partners who can > fulfill your fantasies and provide you with the adult entertainment that you > crave! https://www.bangalorecallgirls.net/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 123838] Issue on CAST() (FirebirdSQL)
https://bugs.documentfoundation.org/show_bug.cgi?id=123838 --- Comment #9 from riya singh --- Call girls chennai is a leading provider of premium call girls chennai We are known for our excellent service and quality. We offer services such as outcall call girl, incall call girl, call girl in chennai, call girl in chennai, Independent girl call girl Chennai. Website: https://www.callgirlschennai.net/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 119039] Writer crash when I try to open 4-pages DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=119039 Julien Nabet changed: What|Removed |Added Attachment #148735|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 119039] Writer crash when I try to open 4-pages DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=119039
--- Comment #11 from Julien Nabet ---
Created attachment 182346
--> https://bugs.documentfoundation.org/attachment.cgi?id=182346=edit
bt
On Windows 10 with master sources updated today, I could still reproduce this.
This time instead of using:
!analyze -v
I tried:
kp
this one gives:
file name + associated line
parameters provided to the function.
If it can help, here's what I got on Cygwin console:
warn:legacy.osl:4740:19232:sal/osl/w32/file_url.cxx:849: osl_getAbsoluteFileURL
called with empty base URL and/or invalid relative URL
warn:extensions.olebridge:4740:19232:extensions/source/ole/olethread.cxx:39:
CoInitializeEx failed (expectedly): Impossible de modifier le mode thread une
fois qu’il a été fixé.
warn:extensions.olebridge:4740:19232:extensions/source/ole/olethread.cxx:59:
Thread is in a main single-threaded apartment.
warn:vcl:4740:19232:vcl/source/image/ImplImage.cxx:82: Failed to load scaled
image from cmd/sc_signaturesmenu.png at 1
warn:vcl:4740:19232:vcl/source/image/ImplImage.cxx:105: Failed to load stock
icon cmd/sc_signaturesmenu.png
warn:vcl:4740:19232:vcl/source/window/menu.cxx:2917: Available height
misdetected as 652px. Setting to 768px instead.
warn:sfx.dialog:4740:19232:sfx2/source/dialog/filtergrouping.cxx:359: already
have an element for WordPerfect
warn:sfx.dialog:4740:19232:sfx2/source/dialog/filtergrouping.cxx:359: already
have an element for writerweb8_writer_template
warn:sfx.dialog:4740:19232:sfx2/source/dialog/filtergrouping.cxx:359: already
have an element for writerglobal8
warn:xmloff:4740:19232:sax/source/fastparser/fastparser.cxx:1324: unknown
element xsi:type http://www.w3.org/2001/XMLSchema-instance
warn:xmloff:4740:19232:sax/source/fastparser/fastparser.cxx:1324: unknown
element xsi:type http://www.w3.org/2001/XMLSchema-instance
warn:xmloff:4740:19232:sax/source/fastparser/fastparser.cxx:1248: unknown
attribute vid={4A3C46E8-61CC-4603-A589-7422A47A8E4A}
warn:legacy.osl:4740:19232:svx/source/unodraw/unoshape.cxx:1870:
SvxShape::GetAnyForItem() Returnvalue has wrong Type!
warn:svx:4740:19232:svx/source/unodraw/unoshap2.cxx:1461: Getting Graphic by
URL is not supported, getting it by value
warn:drawinglayer.emf:4740:19232:drawinglayer/source/tools/emfphelperdata.cxx:1791:
EMF+ TODO SetPixelOffsetMode
warn:drawinglayer.emf:4740:19232:drawinglayer/source/tools/emfphelperdata.cxx:1778:
EMF+ TODO SetAntiAliasMode
warn:drawinglayer.emf:4740:19232:drawinglayer/source/tools/emfphelperdata.cxx:1785:
EMF+ TODO InterpolationMode
warn:writerfilter:4740:19232:writerfilter/source/dmapper/OLEHandler.cxx:260:
OLEHandler::getCLSID: unhandled m_sProgId: StaticMetafile
warn:writerfilter:4740:19232:writerfilter/source/dmapper/DomainMapper_Impl.cxx:7616:
PopFieldContext() com.sun.star.lang.IllegalArgumentException ArgumentPosition:
0
warn:writerfilter:4740:19232:writerfilter/source/dmapper/DomainMapper_Impl.cxx:7616:
PopFieldContext() com.sun.star.lang.IllegalArgumentException ArgumentPosition:
0
warn:legacy.osl:4740:19232:svx/source/unodraw/unoshape.cxx:1870:
SvxShape::GetAnyForItem() Returnvalue has wrong Type!
warn:svx:4740:19232:svx/source/unodraw/unoshap2.cxx:1461: Getting Graphic by
URL is not supported, getting it by value
warn:drawinglayer.emf:4740:19232:drawinglayer/source/tools/emfphelperdata.cxx:1791:
EMF+ TODO SetPixelOffsetMode
warn:drawinglayer.emf:4740:19232:drawinglayer/source/tools/emfphelperdata.cxx:1778:
EMF+ TODO SetAntiAliasMode
warn:drawinglayer.emf:4740:19232:drawinglayer/source/tools/emfphelperdata.cxx:1785:
EMF+ TODO InterpolationMode
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 82984] FILEOPEN: Error opening XLSX file in zip64 format
https://bugs.documentfoundation.org/show_bug.cgi?id=82984 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=94 ||915 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 128244] OD* files can't be opened if Zip64 was used in their creation
https://bugs.documentfoundation.org/show_bug.cgi?id=128244 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=94 ||915 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104450] [META] DOCX (OOXML) file opening issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104450 Justin L changed: What|Removed |Added Depends on||94915 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=94915 [Bug 94915] FILEOPEN: unable to open particular document apparently compressed with zip64 format - comment 8 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 94915] FILEOPEN: unable to open particular document apparently compressed with zip64 format - comment 8
https://bugs.documentfoundation.org/show_bug.cgi?id=94915 Justin L changed: What|Removed |Added Blocks||104450 See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=82 ||984, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||8244 Keywords||filter:docx Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104450 [Bug 104450] [META] DOCX (OOXML) file opening issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: reportdesign/source
reportdesign/source/core/sdr/RptObject.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 08051644adeed4d0ee137f3111f225b378e436aa
Author: Andrea Gelmini
AuthorDate: Fri Sep 9 17:20:40 2022 +0200
Commit: Julien Nabet
CommitDate: Fri Sep 9 21:17:56 2022 +0200
Fix typo
Change-Id: I764af470a6bff3ec82182d32fd971e94fa2f725a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139732
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/reportdesign/source/core/sdr/RptObject.cxx
b/reportdesign/source/core/sdr/RptObject.cxx
index e54db1ee3fe1..1e4285162531 100644
--- a/reportdesign/source/core/sdr/RptObject.cxx
+++ b/reportdesign/source/core/sdr/RptObject.cxx
@@ -568,7 +568,7 @@ OUnoObject::OUnoObject(
// tdf#119067
,m_bSetDefaultLabel(rSource.m_bSetDefaultLabel)
{
-osl_atomic_increment(_refCount); // getUnoShape will ref-count thiss
+osl_atomic_increment(_refCount); // getUnoShape will ref-count this
{
if ( !rSource.getUnoControlModelTypeName().isEmpty() )
impl_initializeModel_nothrow();
[Libreoffice-commits] core.git: sc/inc sc/source
sc/inc/dociter.hxx |2 +-
sc/source/core/data/dociter.cxx |6 +++---
sc/source/core/tool/interpr1.cxx |4 ++--
sc/source/core/tool/interpr6.cxx |2 +-
4 files changed, 7 insertions(+), 7 deletions(-)
New commits:
commit e00a86699b89913a80b15eeea33dd0fac64299d0
Author: Caolán McNamara
AuthorDate: Thu Sep 8 10:32:42 2022 +0100
Commit: Caolán McNamara
CommitDate: Fri Sep 9 20:56:07 2022 +0200
GetCurNumFmtInfo is always called with the same context as given in ctor
Change-Id: Ic3aefaa5ddd26b5cb44bfc299f7ae7188f205d17
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139638
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sc/inc/dociter.hxx b/sc/inc/dociter.hxx
index 55a2040f1d1b..c8b51b9e24ff 100644
--- a/sc/inc/dociter.hxx
+++ b/sc/inc/dociter.hxx
@@ -87,7 +87,7 @@ public:
ScDocument& rDocument, const ScRange& rRange, SubtotalFlags
nSubTotalFlags = SubtotalFlags::NONE,
bool bTextAsZero = false );
-void GetCurNumFmtInfo( const ScInterpreterContext& rContext,
SvNumFormatType& nType, sal_uInt32& nIndex );
+void GetCurNumFmtInfo( SvNumFormatType& nType, sal_uInt32& nIndex );
/// Does NOT reset rValue if no value found!
bool GetFirst( double& rValue, FormulaError& rErr );
diff --git a/sc/source/core/data/dociter.cxx b/sc/source/core/data/dociter.cxx
index 97d40d82fd98..0fb2fec32673 100644
--- a/sc/source/core/data/dociter.cxx
+++ b/sc/source/core/data/dociter.cxx
@@ -252,14 +252,14 @@ bool ScValueIterator::GetThis(double& rValue,
FormulaError& rErr)
}
}
-void ScValueIterator::GetCurNumFmtInfo( const ScInterpreterContext& rContext,
SvNumFormatType& nType, sal_uInt32& nIndex )
+void ScValueIterator::GetCurNumFmtInfo( SvNumFormatType& nType, sal_uInt32&
nIndex )
{
if (!bNumValid && mnTab < mrDoc.GetTableCount())
{
SCROW nCurRow = GetRow();
const ScColumn* pCol = &(mrDoc.maTabs[mnTab])->aCol[mnCol];
-nNumFmtIndex = pCol->GetNumberFormat(rContext, nCurRow);
-nNumFmtType = rContext.GetNumberFormatType( nNumFmtIndex );
+nNumFmtIndex = pCol->GetNumberFormat(mrContext, nCurRow);
+nNumFmtType = mrContext.GetNumberFormatType( nNumFmtIndex );
bNumValid = true;
}
diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx
index 8a7a0ac0093b..279d33f29cae 100644
--- a/sc/source/core/tool/interpr1.cxx
+++ b/sc/source/core/tool/interpr1.cxx
@@ -3697,7 +3697,7 @@ void ScInterpreter::ScMin( bool bTextAsZero )
{
if (nMin > nVal)
nMin = nVal;
-aValIter.GetCurNumFmtInfo( mrContext, nFuncFmtType,
nFuncFmtIndex );
+aValIter.GetCurNumFmtInfo( nFuncFmtType, nFuncFmtIndex );
while ((nErr == FormulaError::NONE) &&
aValIter.GetNext(nVal, nErr))
{
if (nMin > nVal)
@@ -3854,7 +3854,7 @@ void ScInterpreter::ScMax( bool bTextAsZero )
{
if (nMax < nVal)
nMax = nVal;
-aValIter.GetCurNumFmtInfo( mrContext, nFuncFmtType,
nFuncFmtIndex );
+aValIter.GetCurNumFmtInfo( nFuncFmtType, nFuncFmtIndex );
while ((nErr == FormulaError::NONE) &&
aValIter.GetNext(nVal, nErr))
{
if (nMax < nVal)
diff --git a/sc/source/core/tool/interpr6.cxx b/sc/source/core/tool/interpr6.cxx
index 9f8fcb6a9661..13f19895e00a 100644
--- a/sc/source/core/tool/interpr6.cxx
+++ b/sc/source/core/tool/interpr6.cxx
@@ -788,7 +788,7 @@ void ScInterpreter::IterateParameters( ScIterFunc eFunc,
bool bTextAsZero )
if (aValIter.GetFirst(fVal, nErr))
{
// placed the loop on the inside for performance
reasons:
-aValIter.GetCurNumFmtInfo( mrContext, nFuncFmtType,
nFuncFmtIndex );
+aValIter.GetCurNumFmtInfo( nFuncFmtType, nFuncFmtIndex
);
switch( eFunc )
{
case ifAVERAGE:
[Libreoffice-commits] core.git: sc/inc sc/qa sc/source
sc/inc/dociter.hxx |6 ++
sc/qa/unit/ucalc.cxx |4 +++-
sc/source/core/data/dociter.cxx |8
sc/source/core/tool/interpr1.cxx | 16 +++-
sc/source/core/tool/interpr2.cxx |4 ++--
sc/source/core/tool/interpr3.cxx | 17 -
sc/source/core/tool/interpr5.cxx |4 ++--
sc/source/core/tool/interpr6.cxx |3 +--
8 files changed, 29 insertions(+), 33 deletions(-)
New commits:
commit 3be1cdce9d92cbadca1b276b3193c727032ea717
Author: Caolán McNamara
AuthorDate: Thu Sep 8 10:26:01 2022 +0100
Commit: Caolán McNamara
CommitDate: Fri Sep 9 20:55:43 2022 +0200
always pass ScInterpreterContext to ScValueIterator
its available at every call site
Change-Id: I764962d1d2330c414e02ed215b4a0c5be2979145
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139637
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/sc/inc/dociter.hxx b/sc/inc/dociter.hxx
index ff58a4181e12..55a2040f1d1b 100644
--- a/sc/inc/dociter.hxx
+++ b/sc/inc/dociter.hxx
@@ -53,7 +53,7 @@ class ScValueIterator// walk through all values
in an area
typedef sc::CellStoreType::const_position_type PositionType;
ScDocument& mrDoc;
-ScInterpreterContext* pContext;
+ScInterpreterContext& mrContext;
const ScAttrArray* pAttrArray;
sal_uInt32 nNumFormat; // for CalcAsShown
sal_uInt32 nNumFmtIndex;
@@ -83,7 +83,7 @@ class ScValueIterator// walk through all values
in an area
public:
-ScValueIterator(
+ScValueIterator(ScInterpreterContext& rContext,
ScDocument& rDocument, const ScRange& rRange, SubtotalFlags
nSubTotalFlags = SubtotalFlags::NONE,
bool bTextAsZero = false );
@@ -94,8 +94,6 @@ public:
/// Does NOT reset rValue if no value found!
bool GetNext( double& rValue, FormulaError& rErr );
-
-void SetInterpreterContext( ScInterpreterContext* context ) { pContext =
context; }
};
class ScDBQueryDataIterator
diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 03cd8adfdbc8..0b21003a56c8 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -1336,6 +1336,8 @@ void Test::testValueIterator()
aOpt.SetCalcAsShown(true);
m_pDoc->SetDocOptions(aOpt);
+ScInterpreterContext aContext(*m_pDoc, m_pDoc->GetFormatTable());
+
// Purely horizontal data layout with numeric data.
for (SCCOL i = 1; i <= 3; ++i)
m_pDoc->SetValue(ScAddress(i,2,0), i);
@@ -1343,7 +1345,7 @@ void Test::testValueIterator()
{
const double aChecks[] = { 1.0, 2.0, 3.0 };
size_t const nCheckLen = SAL_N_ELEMENTS(aChecks);
-ScValueIterator aIter(*m_pDoc, ScRange(1,2,0,3,2,0));
+ScValueIterator aIter(aContext, *m_pDoc, ScRange(1,2,0,3,2,0));
bool bHas = false;
size_t nCheckPos = 0;
double fVal;
diff --git a/sc/source/core/data/dociter.cxx b/sc/source/core/data/dociter.cxx
index 2c64a22e9011..97d40d82fd98 100644
--- a/sc/source/core/data/dociter.cxx
+++ b/sc/source/core/data/dociter.cxx
@@ -82,10 +82,10 @@ static void ScAttrArray_IterGetNumberFormat( sal_uInt32&
nFormat, const ScAttrAr
nAttrEndRow = nRowEnd;
}
-ScValueIterator::ScValueIterator( ScDocument& rDocument, const ScRange& rRange,
+ScValueIterator::ScValueIterator(ScInterpreterContext& rContext, ScDocument&
rDocument, const ScRange& rRange,
SubtotalFlags nSubTotalFlags, bool bTextZero )
: mrDoc(rDocument)
-, pContext(nullptr)
+, mrContext(rContext)
, pAttrArray(nullptr)
, nNumFormat(0) // Initialized in GetNumberFormat
, nNumFmtIndex(0)
@@ -194,8 +194,8 @@ bool ScValueIterator::GetThis(double& rValue, FormulaError&
rErr)
if (bCalcAsShown)
{
ScAttrArray_IterGetNumberFormat(nNumFormat, pAttrArray,
-nAttrEndRow, pCol->pAttrArray.get(), nCurRow, mrDoc,
pContext);
-rValue = mrDoc.RoundValueAsShown(rValue, nNumFormat,
pContext);
+nAttrEndRow, pCol->pAttrArray.get(), nCurRow, mrDoc,
);
+rValue = mrDoc.RoundValueAsShown(rValue, nNumFormat,
);
}
return true; // Found it!
}
diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx
index 9eb660386e97..8a7a0ac0093b 100644
--- a/sc/source/core/tool/interpr1.cxx
+++ b/sc/source/core/tool/interpr1.cxx
@@ -1314,7 +1314,7 @@ void ScInterpreter::ScAnd()
{
double fVal;
FormulaError nErr = FormulaError::NONE;
-ScValueIterator aValIter( mrDoc, aRange );
+ScValueIterator aValIter( mrContext, mrDoc, aRange );
if ( aValIter.GetFirst( fVal, nErr ) && nErr ==
FormulaError::NONE )
{
[Libreoffice-commits] core.git: sc/source
sc/source/core/tool/interpr3.cxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit 2f4c49fa96db7d6134fb28b20ea9ad4c51183f28
Author: Caolán McNamara
AuthorDate: Thu Sep 8 10:10:10 2022 +0100
Commit: Caolán McNamara
CommitDate: Fri Sep 9 20:55:16 2022 +0200
crashtesting: threaded assert on loading forum-de3-3100.ods
use SetInterpreterContext like I see in similar places to avoid the need
to call ScDocument::GetFormatTable
#9 0x7fd35b1af283 in ScDocument::GetFormatTable() const
(this=this@entry=0x5573153bf1d0) at sc/source/core/data/documen2.cxx:463
__PRETTY_FUNCTION__ = "SvNumberFormatter*
ScDocument::GetFormatTable() const"
#10 0x7fd35b196f57 in ScAttrArray_IterGetNumberFormat(sal_uInt32&,
ScAttrArray const*&, SCROW&, ScAttrArray const*, SCROW, ScDocument const&,
ScInterpreterContext const*) (nFormat=@0x7fd354458b38: 0,
rpArr=@0x7fd354458b30: 0x0, nAttrEndRow=@0x7fd354458b54: 0,
pNewArr=0x557315063910, nRow=nRow@entry=30, rDoc=..., pContext=0x0) at
sc/source/core/data/dociter.cxx:80
nRowStart = 30
nRowEnd = 30
pPattern = 0x557316c093f0
#11 0x7fd35b19e5b7 in ScValueIterator::GetThis(double&, FormulaError&)
(this=this@entry=0x7fd354458b20, rValue=@0x7fd354458b00: 0,
rErr=@0x7fd354458af8: FormulaError::NONE) at sc/source/core/data/dociter.cxx:196
bNextColumn =
pCol = 0x557316aca050
nCurRow = 30
nLastRow = 32723
#12 0x7fd35b19e8c4 in ScValueIterator::GetNext(double&, FormulaError&)
(this=, this@entry=0x7fd354458b20, rValue=@0x7fd354458b00: 0,
rErr=@0x7fd354458af8: FormulaError::NONE) at sc/source/core/data/dociter.cxx:297
#13 0x7fd35b6a5307 in ScInterpreter::GetNumberSequenceArray(unsigned
char, std::__debug::vector >&, bool)
(this=this@entry=0x5573169d9900, nParamCount=nParamCount@entry=1 '\001',
rArray=std::__debug::vector of length 2, capacity 200 = {...},
bConvertTextInArray=bConvertTextInArray@entry=false) at
sc/source/core/tool/interpr3.cxx:3986
nCellCount =
nErr = FormulaError::NONE
fCellVal = 0
aValIter = {mrDoc = @0x5573153bf1d0, pContext = 0x0, pAttrArray =
0x0, nNumFormat = 0, nNumFmtIndex = 0, maStartPos = {nRow = 0, nCol = 0, nTab =
4, static detailsOOOa1 = {eConv = formula::FormulaGrammar::CONV_OOO, nRow = 0,
nCol = 0}}, maEndPos = {nRow = 199, nCol = 0, nTab = 4, static detailsOOOa1 =
{eConv = formula::FormulaGrammar::CONV_OOO, nRow = 0, nCol = 0}}, mnCol = 0,
mnTab = 4, nAttrEndRow = 0, mnSubTotalFlags = SubtotalFlags::NONE, nNumFmtType
= SvNumFormatType::UNDEFINED, bNumValid = false, bCalcAsShown = true,
bTextAsZero = false, mpCells = 0x557316aca280, maCurPos = {first =
{, mdds::mtv::noncopyable_managed_element_block<53,
EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54,
ScFormulaCell> >, sc::CellStoreTrait>::const_iterator_trait>> = {m_cur_node =
{type = 10, position = 30, size
= 1, data = 0x557316d734d0, __private_data = {parent = 0x557316aca280,
block_index = 1}}, m_pos = {position_iterator = 30, size_iterator = 1,
element_block_iterator = 0x557316d734d0}, m_end = {position_iterator =
7378697629483820646, size_iterator = 7378697629483820646,
element_block_iterator = 0x}}, }, second = 0}}
eStackType =
aAdr = {nRow = 0, nCol = 0, nTab = 0, static detailsOOOa1 = {eConv
= formula::FormulaGrammar::CONV_OOO, nRow = 0, nCol = 0}}
aRange = {aStart = {nRow = 0, nCol = 0, nTab = 4, static
detailsOOOa1 = {eConv = formula::FormulaGrammar::CONV_OOO, nRow = 0, nCol =
0}}, aEnd = {nRow = 199, nCol = 0, nTab = 4, static detailsOOOa1 = {eConv =
formula::FormulaGrammar::CONV_OOO, nRow = 0, nCol = 0}}}
bIgnoreErrVal = false
nParam = 0
nRefInList = 0
#14 0x7fd35b6aa9ed in ScInterpreter::CalculateSmallLarge(bool)
(this=this@entry=0x5573169d9900, bSmall=bSmall@entry=true) at
sc/source/core/tool/interpr3.cxx:3657
nCol = 1
nRow = 1
aArray = std::__debug::vector of length 1, capacity 1 = {1}
nRankArraySize = 1
__PRETTY_FUNCTION__ = "void
ScInterpreter::CalculateSmallLarge(bool)"
aRankArray = std::__debug::vector of length 1, capacity 1 = {1}
aSortArray = std::__debug::vector of length 2, capacity 200 = {1,
21}
nSize =
#15 0x7fd35b6abac8 in ScInterpreter::ScSmall()
(this=this@entry=0x5573169d9900) at sc/source/core/tool/interpr3.cxx:3717
#16 0x7fd35b6cd929 in ScInterpreter::Interpret()
(this=this@entry=0x5573169d9900) at sc/source/core/tool/interpr4.cxx:4373
bGotResult =
nRetTypeExpr = SvNumFormatType::NUMBER
nRetIndexExpr = 0
nErrorFunction = 0
nErrorFunctionCount = 0
aErrorFunctionStack = std::__debug::vector of
[Libreoffice-commits] core.git: Changes to 'refs/tags/libreoffice-7.4.1.2'
Tag 'libreoffice-7.4.1.2' created by Christian Lohmaier at 2022-09-09 18:46 + Tag libreoffice-7.4.1.2 -BEGIN PGP SIGNATURE- iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmMbiekACgkQ9DSh76/u rqP4gBAAqXrvVDkkNj9HoDoOTML7acqZlCU50XkXzwrtyuJCESutP/QqLaGIyxsa b25+Pw7oqyQTA8tRjIXYYZTJfGdCMDQJkG7hn7vAyx5GublIfncyH1dAyKbCtXGp GuLEEJbY+P6mChzL2MDkjLg+/x2QNysOJTeQSntJObKLjoSA3MIRDz45MyrhEp6r 6K4iRBp7aCROzN8rftCiTk1hiua5jPWCPHRoq8tMHV/BIqJqj8iR1Hw/iUZcC/v2 rvvpU02t4WM1o7GqM3AiQNTuAD0FHbVXdPPTHbQ1Y2YMF8fuQIfr9bUJqIm1+B7s br+UGkXIOPIr+QVWZzuccSSBn+ZMaV5O4rX4suELLGUmsAPf1mnY3v8jn6gp7NIo FTwRRzQdtKwp7TLMSgrBavgvkaRAA7S3YT+R+BPpvKRtV+zsRmBe0rnCR5cJOtTD MHatNrKmdrpyXPCwTeFjiEhnbTnxnxo5v8Qlye7iYbUEzG4DdVONkG+dQTAfUopD 2CZUZkgXzN+3iL5tixmy8KQc7PJCKo0xQFqd5WYpgo5BWOCkBGgBtQ+AnROQNBAD fm1UtxcwMKduWFkOziMY07ese3UD1WbLwHkc7VRVHBtZ0apAGSZN418Xm0/86OWO 3mvEHVaOFRsKp4IymqskYBwBSYP36dKHlVn2WVuZccKwtbRNuNo= =auhR -END PGP SIGNATURE- Changes since libreoffice-7-4-branch-point-526: --- 0 files changed ---
[Libreoffice-commits] translations.git: Changes to 'refs/tags/libreoffice-7.4.1.2'
Tag 'libreoffice-7.4.1.2' created by Christian Lohmaier at 2022-09-09 18:46 + Tag libreoffice-7.4.1.2 -BEGIN PGP SIGNATURE- iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmMbiekACgkQ9DSh76/u rqODMxAAuH22lKkxG8DdVZE1pDp93CWaUdRkKqNl4QfWp+2y4r+vruk0KR1T6NsH 0r0nif5Rvk1ZZboSqK5AQ46QLftcSGVfwqXEZpA/ZnP195RGSt8PJh+hu1QZycHo oZMAPEQ6RvF6fdg6va4xuWg6QIOjbV+UEXdCTNcTOcqG6DF9NmyMgTw2FM4DJxI9 mdhf5RZ/hc4dgEyFrbaJIgVX/ua7wIyAC+3TXtUky35vTS5L2fJXHVmQjhmg qdJHWJK3Gqbpw0UQeHo1SXP/4jrivgM0LCFYSKb9L/VDjydJx5XzdxsSDSXJ0T2c g1OkVLJTCVqiZIhpTLWwn3yEGp2wUWmomHCYe1T3o/hX3U4Aukn/O/aPBaVQYIR9 FqVRxlDCf4tizfkl9EV3WNnr0/LvQNE3EiSt3TQHKMypJe3+KwxZWD+0DQB8RTB/ 1y6U9GNEz0bZYh09d66sVmIvUnLWN+Vg2IXEKz+/A6dregdzYVDAfWmc6bYZBLIf D3vQaiVG1W89Ao8LRObSLKymsJwf8sU6d402HqWhjbl0EIiApMylbIxgZL64iSGq 0NtjHeT/Lsmy0wz8wQOs9jRc4jn9p4Njmd/wOypRzZCMZCsvijFEnab8bbZKCtKt 6zfBE8jR9mExBsMXYpJOyrxUN9YGFM+umdBOVUX9Egv7S/jCISw= =TCfW -END PGP SIGNATURE- Changes since libreoffice-7-4-branch-point-17: --- 0 files changed ---
[Libreoffice-commits] help.git: Changes to 'refs/tags/libreoffice-7.4.1.2'
Tag 'libreoffice-7.4.1.2' created by Christian Lohmaier at 2022-09-09 18:46 + Tag libreoffice-7.4.1.2 -BEGIN PGP SIGNATURE- iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmMbiekACgkQ9DSh76/u rqNqsBAAjMeOr8FhEoI/HqjMamXaEBQ64FRhqpOX/qSyL3QJXaSGOv9jlGvU9rN+ 2XIpbvP7bg4PjOK2SmTX2EtPi9ijWR3x4rqBT8Id3Tgxfe6ZGvANoZGmX9i6MdEP Sfr24Ptvz7PlRU3bHVy1mXXHUOJBneUYOvEy/V/JtTdNEHPyJjv63/qbTtxvqUix PQNTWqrve12vOA0773JucvZB46i5oCfNiwNwTQQd+Qq3UUBtyfqomOOMxwccXhpJ 35TQnvSSFGKJg1yOy9wmNAS6Xd06Z2BfMviWXjF9k+LKgQZnbW/0QkvdheZmi9hq ertTWsU4isjDmoezSWW6rZSua4NpZHDkOOB/zX7G9eqhqKJ6llKxUarRkymBgVsC BYSXeXFnaVT6KBMx48gPVhXADuDksShRB653urjDSWEA+bkzk/iFdabkpf+guzI5 rYL1zxnEOzqps40CmgKNx3zRhMkAdPYJIIKgoNgXbxxDATdi9oC4waiybZKTw+Om ySBOYTA7l1eKk1kvMNKx6AAHPx11TeijTlg2QSGRmpqaTiggZ9B/NJsov4vsEVGb CLIF854bD272YzQLRl1udHBBUA1FXNRPfJaQLAl4ArN5uJGq3o+4c2cdrmY+oeoY 9kOJAnPZ+4ullWiJygC+ZIoPBS3ELq1MUrPXpORk1IDOgxNeTFs= =dxmn -END PGP SIGNATURE- Changes since libreoffice-7-4-branch-point-54: --- 0 files changed ---
[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/libreoffice-7.4.1.2'
Tag 'libreoffice-7.4.1.2' created by Christian Lohmaier at 2022-09-09 18:45 + Tag libreoffice-7.4.1.2 -BEGIN PGP SIGNATURE- iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmMbieYACgkQ9DSh76/u rqP0Pg/8CJI1IYRfy1QWm1b0f5qVwDf0UspkbcxV0Y29XFL0oipN3dckg4bYwdgt YBEFw5TqASZ18fcdE2PJH3tiWbG1p++6IwTjUxKCUikkWLYDK+u+hHXS67FxMAmu ZphFJIvKC5M7wVlJrH61heyKltTIeO7KBlNvXSvWWQKScNiGhAvXoLmOIRtUzJXX y9fIzE7y6QdgFHKauFqLTCQn1LV3Blpp7iA3LnY9gcnUBWWWTX/7OKPOjPgqCUav PW+nabjhUO2COfebmyvHsBNhZaX8Fdo+7katQwI4Gztfr2UasJdvzN05Tq80pJHb dJsKcQH/zk2Xf9RG/YBigZ0Yl26Vw9THPYa4vNDtKPh3NW4VYRW++vSOvV8ZlHra Bq0SSGkxZOXfj+ne6A+ReNs2TU8kQYfwbRDf/S0mfNsL8GrSrT7XD5vIcUKMKCui X+AMpbTY11y4rb/Eqsq8WDxrEnaQO2qgBbO+KZhfPyxaGIO6E/VHgbEaZUPRa8PU p72yNOBQkKNS9ukQ2XcGFlcvEasPHSoAsjpCT9v48OyXpZNG9FkWlqkvamMO4Ibj iaTI+bbtu0yYcAz4887PFVKH2G3Gy/VXesfplby49NQJr0fn8nV+pjYcFWeY/uUP KTlu9RQasd/BkvLZZEqkjtJoSVp1jOtKGS9d9TXyUdDR2HeqsUY= =DlDP -END PGP SIGNATURE- Changes since libreoffice-7-4-branch-point-3: --- 0 files changed ---
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4-1' - configure.ac
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit cb591c1932b2ba8c008fc449737f5f26a292fe00 Author: Christian Lohmaier AuthorDate: Fri Sep 9 20:48:09 2022 +0200 Commit: Christian Lohmaier CommitDate: Fri Sep 9 20:48:09 2022 +0200 bump product version to 7.4.1.2.0+ Change-Id: Ib1f7faf775666e23ebf8db789965f329fb8a31dd diff --git a/configure.ac b/configure.ac index beb7d3a9eaaa..91220fb6ade6 100644 --- a/configure.ac +++ b/configure.ac @@ -9,7 +9,7 @@ dnl in order to create a configure script. # several non-alphanumeric characters, those are split off and used only for the # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no idea. -AC_INIT([LibreOffice],[7.4.1.1.0+],[],[],[http://documentfoundation.org/]) +AC_INIT([LibreOffice],[7.4.1.2.0+],[],[],[http://documentfoundation.org/]) dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just fine if it is installed dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails hard
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4-1' - readlicense_oo/license
readlicense_oo/license/CREDITS.fodt | 4109 ++-- 1 file changed, 2061 insertions(+), 2048 deletions(-) New commits: commit 65005db2377ff7384d6ac623232b635f039de421 Author: Christian Lohmaier AuthorDate: Fri Sep 9 20:36:22 2022 +0200 Commit: Christian Lohmaier CommitDate: Fri Sep 9 20:41:57 2022 +0200 update credits Change-Id: I2b1e2e53b0688369e9ebc480ab296ace4cdb804b (cherry picked from commit 69b0c17f1e5d2fd8c7ca0548fb5c5ed8def26ce2) (cherry picked from commit f3e2a0e2e353a278afdd85a79614ff0b6e2a2128) diff --git a/readlicense_oo/license/CREDITS.fodt b/readlicense_oo/license/CREDITS.fodt index 3edb3ed7e5e0..dee82e9cb7bf 100644 --- a/readlicense_oo/license/CREDITS.fodt +++ b/readlicense_oo/license/CREDITS.fodt @@ -1,24 +1,24 @@ http://www.w3.org/TR/css3-text/; xmlns:grddl="http://www.w3.org/2003/g/data-view#; xmlns:xhtml="http://www.w3.org/1999/xhtml; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xmlns:xsd="http://www.w3.org/2001/XMLSchema; xmlns:xforms="http://www.w3.org/2002/xforms; xmlns:dom="http://www.w3.org/2001/xml-events; xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0" xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:math="http://www.w3.org/1998/Math/MathML; xmlns:office="urn:oasis:names:tc:opendocument:xmlns:office:1.0" xmlns:ooo="http://openoffice.org/2004/office; xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0" xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" xmlns:ooow="http://openoffice.org/2004/writer; xmlns:xlink="http://www.w3.org/1999/xlink; xmlns:drawooo="http://openoffice.org/2010/draw; xmlns:oooc="http://openoffice.org/2004/calc; xmlns:dc="http://purl.org/dc/elements/1.1/; xmlns:c alcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0" xmlns:style="urn:oasis:names:tc:opendocument:xmlns:style:1.0" xmlns:text="urn:oasis:names:tc:opendocument:xmlns:text:1.0" xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" xmlns:tableooo="http://openoffice.org/2009/table; xmlns:draw="urn:oasis:names:tc:opendocument:xmlns:drawing:1.0" xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" xmlns:rpt="http://openoffice.org/2005/report; xmlns:formx="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0" xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" xmlns:officeooo="http://openoffice.org/2009/office; xmlns:table="urn:oasis:names:tc:opendocument:xmlns:table:1.0" xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" xmlns:meta="urn:oasis:names:tc:opendocument:xmlns: meta:1.0" xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0" office:version="1.3" office:mimetype="application/vnd.oasis.opendocument.text"> - Credits » LibreOfficeCreditscontributorscodersdevelopersCredits for the LibreOffice development/coding.LibreOffice/7.4.0.3$Linux_X86_64 LibreOffice_project/f85e47c08ddd19c015c0114a68350214f7066f5a2012-02-20T22:17:18.06000PT14M12S3JUebjoxEpqXoQcpltWRTwzBZEEHtch3wApdhgiQPFiA + Credits » LibreOfficeCreditscontributorscodersdevelopersCredits for the LibreOffice development/coding.LibreOffice/7.4.0.3$Linux_X86_64 LibreOffice_project/f85e47c08ddd19c015c0114a68350214f7066f5a2012-02-20T22:17:18.06000PT14M12S3JUebjoxEpqXoQcpltWRTwzBZEEHtch3wApdhgiQPFiA - 660 + 1949 501 - 32175 - 28180 + 32202 + 28206 true true view2 - 14233 - 5835 + 3649 + 3434 501 - 660 - 32674 - 28838 + 1949 + 32701 + 30154 0 0 false @@ -100,7 +100,7 @@ true - 11200710 + 11425201 true false @@ -351,21 +351,21 @@ - + - + - + - + - + @@ -426,26 +426,23 @@ - + - + - + - + - + - - - @@ -1085,7 +1082,7 @@ Credits -1784 individuals contributed to OpenOffice.org (and whose contributions were imported into LibreOffice) or LibreOffice until 2022-08-31 13:01:51. +1788 individuals contributed to OpenOffice.org (and whose contributions were imported into LibreOffice) or LibreOffice until 2022-09-09 19:59:37. * marks developers whose first contributions happened after 2010-09-28. Developers committing code since 2010-09-28 @@ -1098,7 +1095,7 @@ Ruediger TimmCommits: 82464Joined: 2000-10-10 - Caolán McNamaraCommits: 33445Joined: 2000-10-10 + Caolán McNamaraCommits: 33507Joined: 2000-10-10 Kurt ZenkerCommits: 31752Joined: 2000-09-25 @@ -1115,10 +1112,10 @@
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - readlicense_oo/license
readlicense_oo/license/CREDITS.fodt | 4109 ++-- 1 file changed, 2061 insertions(+), 2048 deletions(-) New commits: commit f3e2a0e2e353a278afdd85a79614ff0b6e2a2128 Author: Christian Lohmaier AuthorDate: Fri Sep 9 20:36:22 2022 +0200 Commit: Christian Lohmaier CommitDate: Fri Sep 9 20:39:05 2022 +0200 update credits Change-Id: I2b1e2e53b0688369e9ebc480ab296ace4cdb804b (cherry picked from commit 69b0c17f1e5d2fd8c7ca0548fb5c5ed8def26ce2) diff --git a/readlicense_oo/license/CREDITS.fodt b/readlicense_oo/license/CREDITS.fodt index 3edb3ed7e5e0..dee82e9cb7bf 100644 --- a/readlicense_oo/license/CREDITS.fodt +++ b/readlicense_oo/license/CREDITS.fodt @@ -1,24 +1,24 @@ http://www.w3.org/TR/css3-text/; xmlns:grddl="http://www.w3.org/2003/g/data-view#; xmlns:xhtml="http://www.w3.org/1999/xhtml; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xmlns:xsd="http://www.w3.org/2001/XMLSchema; xmlns:xforms="http://www.w3.org/2002/xforms; xmlns:dom="http://www.w3.org/2001/xml-events; xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0" xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:math="http://www.w3.org/1998/Math/MathML; xmlns:office="urn:oasis:names:tc:opendocument:xmlns:office:1.0" xmlns:ooo="http://openoffice.org/2004/office; xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0" xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" xmlns:ooow="http://openoffice.org/2004/writer; xmlns:xlink="http://www.w3.org/1999/xlink; xmlns:drawooo="http://openoffice.org/2010/draw; xmlns:oooc="http://openoffice.org/2004/calc; xmlns:dc="http://purl.org/dc/elements/1.1/; xmlns:c alcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0" xmlns:style="urn:oasis:names:tc:opendocument:xmlns:style:1.0" xmlns:text="urn:oasis:names:tc:opendocument:xmlns:text:1.0" xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" xmlns:tableooo="http://openoffice.org/2009/table; xmlns:draw="urn:oasis:names:tc:opendocument:xmlns:drawing:1.0" xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" xmlns:rpt="http://openoffice.org/2005/report; xmlns:formx="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0" xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" xmlns:officeooo="http://openoffice.org/2009/office; xmlns:table="urn:oasis:names:tc:opendocument:xmlns:table:1.0" xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" xmlns:meta="urn:oasis:names:tc:opendocument:xmlns: meta:1.0" xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0" office:version="1.3" office:mimetype="application/vnd.oasis.opendocument.text"> - Credits » LibreOfficeCreditscontributorscodersdevelopersCredits for the LibreOffice development/coding.LibreOffice/7.4.0.3$Linux_X86_64 LibreOffice_project/f85e47c08ddd19c015c0114a68350214f7066f5a2012-02-20T22:17:18.06000PT14M12S3JUebjoxEpqXoQcpltWRTwzBZEEHtch3wApdhgiQPFiA + Credits » LibreOfficeCreditscontributorscodersdevelopersCredits for the LibreOffice development/coding.LibreOffice/7.4.0.3$Linux_X86_64 LibreOffice_project/f85e47c08ddd19c015c0114a68350214f7066f5a2012-02-20T22:17:18.06000PT14M12S3JUebjoxEpqXoQcpltWRTwzBZEEHtch3wApdhgiQPFiA - 660 + 1949 501 - 32175 - 28180 + 32202 + 28206 true true view2 - 14233 - 5835 + 3649 + 3434 501 - 660 - 32674 - 28838 + 1949 + 32701 + 30154 0 0 false @@ -100,7 +100,7 @@ true - 11200710 + 11425201 true false @@ -351,21 +351,21 @@ - + - + - + - + - + @@ -426,26 +426,23 @@ - + - + - + - + - + - - - @@ -1085,7 +1082,7 @@ Credits -1784 individuals contributed to OpenOffice.org (and whose contributions were imported into LibreOffice) or LibreOffice until 2022-08-31 13:01:51. +1788 individuals contributed to OpenOffice.org (and whose contributions were imported into LibreOffice) or LibreOffice until 2022-09-09 19:59:37. * marks developers whose first contributions happened after 2010-09-28. Developers committing code since 2010-09-28 @@ -1098,7 +1095,7 @@ Ruediger TimmCommits: 82464Joined: 2000-10-10 - Caolán McNamaraCommits: 33445Joined: 2000-10-10 + Caolán McNamaraCommits: 33507Joined: 2000-10-10 Kurt ZenkerCommits: 31752Joined: 2000-09-25 @@ -1115,10 +1112,10 @@ Vladimir GlazunovCommits: 25434Joined: 2000-12-04
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - readlicense_oo/license
readlicense_oo/license/CREDITS.fodt | 4109 ++-- 1 file changed, 2061 insertions(+), 2048 deletions(-) New commits: commit d51c1274af20d67be085c3d3ffdcbb0354c1985b Author: Christian Lohmaier AuthorDate: Fri Sep 9 20:36:22 2022 +0200 Commit: Christian Lohmaier CommitDate: Fri Sep 9 20:37:53 2022 +0200 update credits Change-Id: I2b1e2e53b0688369e9ebc480ab296ace4cdb804b (cherry picked from commit 69b0c17f1e5d2fd8c7ca0548fb5c5ed8def26ce2) diff --git a/readlicense_oo/license/CREDITS.fodt b/readlicense_oo/license/CREDITS.fodt index 3edb3ed7e5e0..dee82e9cb7bf 100644 --- a/readlicense_oo/license/CREDITS.fodt +++ b/readlicense_oo/license/CREDITS.fodt @@ -1,24 +1,24 @@ http://www.w3.org/TR/css3-text/; xmlns:grddl="http://www.w3.org/2003/g/data-view#; xmlns:xhtml="http://www.w3.org/1999/xhtml; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xmlns:xsd="http://www.w3.org/2001/XMLSchema; xmlns:xforms="http://www.w3.org/2002/xforms; xmlns:dom="http://www.w3.org/2001/xml-events; xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0" xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:math="http://www.w3.org/1998/Math/MathML; xmlns:office="urn:oasis:names:tc:opendocument:xmlns:office:1.0" xmlns:ooo="http://openoffice.org/2004/office; xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0" xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" xmlns:ooow="http://openoffice.org/2004/writer; xmlns:xlink="http://www.w3.org/1999/xlink; xmlns:drawooo="http://openoffice.org/2010/draw; xmlns:oooc="http://openoffice.org/2004/calc; xmlns:dc="http://purl.org/dc/elements/1.1/; xmlns:c alcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0" xmlns:style="urn:oasis:names:tc:opendocument:xmlns:style:1.0" xmlns:text="urn:oasis:names:tc:opendocument:xmlns:text:1.0" xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" xmlns:tableooo="http://openoffice.org/2009/table; xmlns:draw="urn:oasis:names:tc:opendocument:xmlns:drawing:1.0" xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" xmlns:rpt="http://openoffice.org/2005/report; xmlns:formx="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0" xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" xmlns:officeooo="http://openoffice.org/2009/office; xmlns:table="urn:oasis:names:tc:opendocument:xmlns:table:1.0" xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" xmlns:meta="urn:oasis:names:tc:opendocument:xmlns: meta:1.0" xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0" office:version="1.3" office:mimetype="application/vnd.oasis.opendocument.text"> - Credits » LibreOfficeCreditscontributorscodersdevelopersCredits for the LibreOffice development/coding.LibreOffice/7.4.0.3$Linux_X86_64 LibreOffice_project/f85e47c08ddd19c015c0114a68350214f7066f5a2012-02-20T22:17:18.06000PT14M12S3JUebjoxEpqXoQcpltWRTwzBZEEHtch3wApdhgiQPFiA + Credits » LibreOfficeCreditscontributorscodersdevelopersCredits for the LibreOffice development/coding.LibreOffice/7.4.0.3$Linux_X86_64 LibreOffice_project/f85e47c08ddd19c015c0114a68350214f7066f5a2012-02-20T22:17:18.06000PT14M12S3JUebjoxEpqXoQcpltWRTwzBZEEHtch3wApdhgiQPFiA - 660 + 1949 501 - 32175 - 28180 + 32202 + 28206 true true view2 - 14233 - 5835 + 3649 + 3434 501 - 660 - 32674 - 28838 + 1949 + 32701 + 30154 0 0 false @@ -100,7 +100,7 @@ true - 11200710 + 11425201 true false @@ -351,21 +351,21 @@ - + - + - + - + - + @@ -426,26 +426,23 @@ - + - + - + - + - + - - - @@ -1085,7 +1082,7 @@ Credits -1784 individuals contributed to OpenOffice.org (and whose contributions were imported into LibreOffice) or LibreOffice until 2022-08-31 13:01:51. +1788 individuals contributed to OpenOffice.org (and whose contributions were imported into LibreOffice) or LibreOffice until 2022-09-09 19:59:37. * marks developers whose first contributions happened after 2010-09-28. Developers committing code since 2010-09-28 @@ -1098,7 +1095,7 @@ Ruediger TimmCommits: 82464Joined: 2000-10-10 - Caolán McNamaraCommits: 33445Joined: 2000-10-10 + Caolán McNamaraCommits: 33507Joined: 2000-10-10 Kurt ZenkerCommits: 31752Joined: 2000-09-25 @@ -1115,10 +1112,10 @@ Vladimir GlazunovCommits: 25434Joined: 2000-12-04
[Libreoffice-commits] core.git: readlicense_oo/license
readlicense_oo/license/CREDITS.fodt | 4109 ++-- 1 file changed, 2061 insertions(+), 2048 deletions(-) New commits: commit 69b0c17f1e5d2fd8c7ca0548fb5c5ed8def26ce2 Author: Christian Lohmaier AuthorDate: Fri Sep 9 20:36:22 2022 +0200 Commit: Christian Lohmaier CommitDate: Fri Sep 9 20:36:22 2022 +0200 update credits Change-Id: I2b1e2e53b0688369e9ebc480ab296ace4cdb804b diff --git a/readlicense_oo/license/CREDITS.fodt b/readlicense_oo/license/CREDITS.fodt index 3edb3ed7e5e0..dee82e9cb7bf 100644 --- a/readlicense_oo/license/CREDITS.fodt +++ b/readlicense_oo/license/CREDITS.fodt @@ -1,24 +1,24 @@ http://www.w3.org/TR/css3-text/; xmlns:grddl="http://www.w3.org/2003/g/data-view#; xmlns:xhtml="http://www.w3.org/1999/xhtml; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xmlns:xsd="http://www.w3.org/2001/XMLSchema; xmlns:xforms="http://www.w3.org/2002/xforms; xmlns:dom="http://www.w3.org/2001/xml-events; xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0" xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:math="http://www.w3.org/1998/Math/MathML; xmlns:office="urn:oasis:names:tc:opendocument:xmlns:office:1.0" xmlns:ooo="http://openoffice.org/2004/office; xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0" xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" xmlns:ooow="http://openoffice.org/2004/writer; xmlns:xlink="http://www.w3.org/1999/xlink; xmlns:drawooo="http://openoffice.org/2010/draw; xmlns:oooc="http://openoffice.org/2004/calc; xmlns:dc="http://purl.org/dc/elements/1.1/; xmlns:c alcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0" xmlns:style="urn:oasis:names:tc:opendocument:xmlns:style:1.0" xmlns:text="urn:oasis:names:tc:opendocument:xmlns:text:1.0" xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" xmlns:tableooo="http://openoffice.org/2009/table; xmlns:draw="urn:oasis:names:tc:opendocument:xmlns:drawing:1.0" xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" xmlns:rpt="http://openoffice.org/2005/report; xmlns:formx="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0" xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" xmlns:officeooo="http://openoffice.org/2009/office; xmlns:table="urn:oasis:names:tc:opendocument:xmlns:table:1.0" xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" xmlns:meta="urn:oasis:names:tc:opendocument:xmlns: meta:1.0" xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0" office:version="1.3" office:mimetype="application/vnd.oasis.opendocument.text"> - Credits » LibreOfficeCreditscontributorscodersdevelopersCredits for the LibreOffice development/coding.LibreOffice/7.4.0.3$Linux_X86_64 LibreOffice_project/f85e47c08ddd19c015c0114a68350214f7066f5a2012-02-20T22:17:18.06000PT14M12S3JUebjoxEpqXoQcpltWRTwzBZEEHtch3wApdhgiQPFiA + Credits » LibreOfficeCreditscontributorscodersdevelopersCredits for the LibreOffice development/coding.LibreOffice/7.4.0.3$Linux_X86_64 LibreOffice_project/f85e47c08ddd19c015c0114a68350214f7066f5a2012-02-20T22:17:18.06000PT14M12S3JUebjoxEpqXoQcpltWRTwzBZEEHtch3wApdhgiQPFiA - 660 + 1949 501 - 32175 - 28180 + 32202 + 28206 true true view2 - 14233 - 5835 + 3649 + 3434 501 - 660 - 32674 - 28838 + 1949 + 32701 + 30154 0 0 false @@ -100,7 +100,7 @@ true - 11200710 + 11425201 true false @@ -351,21 +351,21 @@ - + - + - + - + - + @@ -426,26 +426,23 @@ - + - + - + - + - + - - - @@ -1085,7 +1082,7 @@ Credits -1784 individuals contributed to OpenOffice.org (and whose contributions were imported into LibreOffice) or LibreOffice until 2022-08-31 13:01:51. +1788 individuals contributed to OpenOffice.org (and whose contributions were imported into LibreOffice) or LibreOffice until 2022-09-09 19:59:37. * marks developers whose first contributions happened after 2010-09-28. Developers committing code since 2010-09-28 @@ -1098,7 +1095,7 @@ Ruediger TimmCommits: 82464Joined: 2000-10-10 - Caolán McNamaraCommits: 33445Joined: 2000-10-10 + Caolán McNamaraCommits: 33507Joined: 2000-10-10 Kurt ZenkerCommits: 31752Joined: 2000-09-25 @@ -1115,10 +1112,10 @@ Vladimir GlazunovCommits: 25434Joined: 2000-12-04 - Stephan BergmannCommits: 19983Joined: 2000-10-04 +
[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL
https://bugs.documentfoundation.org/show_bug.cgi?id=103322 mj.Jernigan changed: What|Removed |Added CC||mj_jerni...@yahoo.com --- Comment #41 from mj.Jernigan --- Created attachment 182345 --> https://bugs.documentfoundation.org/attachment.cgi?id=182345=edit Tahoma example text in LO 5.1, 7.1, and 7.4 I hope the attached image helps. To me, at least, the kerning issue appears resolved in LO 7.4. Previously, I had _mostly_ noticed kerning issues around punctuation in the Tahoma font, as you can see in the attached image of text taken from the same document as rendered in PDF (which pretty well shows something more than just a sub-pixel issue). You can also see that 7.4 is nearly the same as 5.1 with some minor sub-pixel differences. Kerning between letters (such as "fa") also appears better. I looked at the previous mention of "California" in Liberation Sans, 12pt, 120% zoom, and it appears better as well in 7.4--although, that "rn" will likely always be a bit hard to discern. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4-1' - translations
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 23199599b48a0bb7af2487b88f20a89e2912f0cd Author: Christian Lohmaier AuthorDate: Fri Sep 9 20:04:53 2022 +0200 Commit: Gerrit Code Review CommitDate: Fri Sep 9 20:04:53 2022 +0200 Update git submodules * Update translations from branch 'libreoffice-7-4-1' to e8cc69c4ac6bd1fb0d94ddac9f5d3afa0e39d85f - update translations for 7.4.1 rc2 and force-fix errors using pocheck Change-Id: Iead6e205e7824b0e4c5f7001661275410fe33360 (cherry picked from commit d2af5ccdc269827d9738b6ed08c8166bfd5c91cf) (cherry picked from commit ceb35d1d848b7ba6795c703a3bec6c5549844bfc) diff --git a/translations b/translations index fef0ef275c1a..e8cc69c4ac6b 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit fef0ef275c1ae9f65b983496c025ba3cd1e26d71 +Subproject commit e8cc69c4ac6bd1fb0d94ddac9f5d3afa0e39d85f
[Libreoffice-commits] translations.git: Branch 'libreoffice-7-4-1' - source/am source/an source/ast source/ca source/cy source/de source/dsb source/es source/eu source/fi source/fr source/gl source/gu
source/am/officecfg/registry/data/org/openoffice/Office/UI.po | 18 source/an/cui/messages.po | 9 source/ast/cui/messages.po | 6 source/ast/filter/messages.po | 4 source/ast/helpcontent2/source/text/sbasic/guide.po | 6 source/ast/helpcontent2/source/text/sbasic/shared.po| 6 source/ast/helpcontent2/source/text/sbasic/shared/03.po | 36 source/ast/helpcontent2/source/text/scalc/01.po | 8 source/ast/helpcontent2/source/text/shared/01.po| 10 source/ast/helpcontent2/source/text/shared/02.po| 10 source/ast/helpcontent2/source/text/shared/guide.po | 4 source/ast/helpcontent2/source/text/shared/optionen.po | 16 source/ast/helpcontent2/source/text/smath/01.po | 12 source/ast/helpcontent2/source/text/swriter/01.po | 6 source/ast/helpcontent2/source/text/swriter/guide.po| 6 source/ast/officecfg/registry/data/org/openoffice/Office/UI.po | 22 source/ast/sc/messages.po | 8 source/ast/sd/messages.po | 9 source/ast/sfx2/messages.po | 21 source/ast/starmath/messages.po | 8 source/ast/sw/messages.po | 10 source/ca/cui/messages.po | 6 source/ca/helpcontent2/source/text/sbasic/guide.po | 4 source/ca/helpcontent2/source/text/sbasic/python.po | 8 source/ca/helpcontent2/source/text/sbasic/shared.po | 4 source/ca/helpcontent2/source/text/sbasic/shared/03.po | 58 source/ca/helpcontent2/source/text/scalc/01.po | 12 source/ca/helpcontent2/source/text/shared/00.po | 6 source/ca/helpcontent2/source/text/shared/02.po | 6 source/ca/helpcontent2/source/text/shared/optionen.po | 4 source/ca/helpcontent2/source/text/simpress/guide.po| 8 source/ca/helpcontent2/source/text/smath/01.po | 16 source/ca/sfx2/messages.po | 8 source/cy/uui/messages.po | 8 source/de/helpcontent2/source/text/sbasic/guide.po | 52 source/de/helpcontent2/source/text/sbasic/shared/02.po | 8 source/de/helpcontent2/source/text/sbasic/shared/03.po | 8 source/de/helpcontent2/source/text/scalc/01.po | 6 source/de/helpcontent2/source/text/scalc/02.po | 8 source/de/helpcontent2/source/text/sdatabase.po | 76 source/de/helpcontent2/source/text/shared/guide.po | 6 source/de/helpcontent2/source/text/shared/optionen.po | 6 source/de/helpcontent2/source/text/swriter/guide.po | 4 source/dsb/chart2/messages.po | 6 source/dsb/cui/messages.po | 6 source/dsb/formula/messages.po | 6 source/dsb/officecfg/registry/data/org/openoffice/Office/UI.po | 26 source/dsb/sc/messages.po | 8 source/dsb/sd/messages.po | 14 source/dsb/svx/messages.po | 20 source/dsb/wizards/source/resources.po | 10 source/es/basctl/messages.po| 6 source/es/basic/messages.po | 8 source/es/cui/messages.po | 50 source/es/extensions/messages.po| 18 source/es/formula/messages.po | 4 source/es/helpcontent2/source/text/sbasic/guide.po | 6 source/es/helpcontent2/source/text/sbasic/python.po | 52
[Libreoffice-commits] translations.git: Branch 'libreoffice-7-4' - source/am source/an source/ast source/ca source/cy source/de source/dsb source/es source/eu source/fi source/fr source/gl source/gug
source/am/officecfg/registry/data/org/openoffice/Office/UI.po | 18 source/an/cui/messages.po | 9 source/ast/cui/messages.po | 6 source/ast/filter/messages.po | 4 source/ast/helpcontent2/source/text/sbasic/guide.po | 6 source/ast/helpcontent2/source/text/sbasic/shared.po| 6 source/ast/helpcontent2/source/text/sbasic/shared/03.po | 36 source/ast/helpcontent2/source/text/scalc/01.po | 8 source/ast/helpcontent2/source/text/shared/01.po| 10 source/ast/helpcontent2/source/text/shared/02.po| 10 source/ast/helpcontent2/source/text/shared/guide.po | 4 source/ast/helpcontent2/source/text/shared/optionen.po | 16 source/ast/helpcontent2/source/text/smath/01.po | 12 source/ast/helpcontent2/source/text/swriter/01.po | 6 source/ast/helpcontent2/source/text/swriter/guide.po| 6 source/ast/officecfg/registry/data/org/openoffice/Office/UI.po | 22 source/ast/sc/messages.po | 8 source/ast/sd/messages.po | 9 source/ast/sfx2/messages.po | 21 source/ast/starmath/messages.po | 8 source/ast/sw/messages.po | 10 source/ca/cui/messages.po | 6 source/ca/helpcontent2/source/text/sbasic/guide.po | 4 source/ca/helpcontent2/source/text/sbasic/python.po | 8 source/ca/helpcontent2/source/text/sbasic/shared.po | 4 source/ca/helpcontent2/source/text/sbasic/shared/03.po | 58 source/ca/helpcontent2/source/text/scalc/01.po | 12 source/ca/helpcontent2/source/text/shared/00.po | 6 source/ca/helpcontent2/source/text/shared/02.po | 6 source/ca/helpcontent2/source/text/shared/optionen.po | 4 source/ca/helpcontent2/source/text/simpress/guide.po| 8 source/ca/helpcontent2/source/text/smath/01.po | 16 source/ca/sfx2/messages.po | 8 source/cy/uui/messages.po | 8 source/de/helpcontent2/source/text/sbasic/guide.po | 52 source/de/helpcontent2/source/text/sbasic/shared/02.po | 8 source/de/helpcontent2/source/text/sbasic/shared/03.po | 8 source/de/helpcontent2/source/text/scalc/01.po | 6 source/de/helpcontent2/source/text/scalc/02.po | 8 source/de/helpcontent2/source/text/sdatabase.po | 76 source/de/helpcontent2/source/text/shared/guide.po | 6 source/de/helpcontent2/source/text/shared/optionen.po | 6 source/de/helpcontent2/source/text/swriter/guide.po | 4 source/dsb/chart2/messages.po | 6 source/dsb/cui/messages.po | 6 source/dsb/formula/messages.po | 6 source/dsb/officecfg/registry/data/org/openoffice/Office/UI.po | 26 source/dsb/sc/messages.po | 8 source/dsb/sd/messages.po | 14 source/dsb/svx/messages.po | 20 source/dsb/wizards/source/resources.po | 10 source/es/basctl/messages.po| 6 source/es/basic/messages.po | 8 source/es/cui/messages.po | 50 source/es/extensions/messages.po| 18 source/es/formula/messages.po | 4 source/es/helpcontent2/source/text/sbasic/guide.po | 6 source/es/helpcontent2/source/text/sbasic/python.po | 52
[Libreoffice-commits] core.git: translations
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 6e34b6072fb602b3094f19e1e80c1e05d4d91eb1 Author: Christian Lohmaier AuthorDate: Fri Sep 9 19:59:37 2022 +0200 Commit: Gerrit Code Review CommitDate: Fri Sep 9 19:59:37 2022 +0200 Update git submodules * Update translations from branch 'master' to d2af5ccdc269827d9738b6ed08c8166bfd5c91cf - update translations for 7.4.1 rc2 and force-fix errors using pocheck Change-Id: Iead6e205e7824b0e4c5f7001661275410fe33360 diff --git a/translations b/translations index eb38107f17db..d2af5ccdc269 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit eb38107f17dbae1029eca4e4449128fbc2b9adf4 +Subproject commit d2af5ccdc269827d9738b6ed08c8166bfd5c91cf
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - translations
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 12551520e84a152b6ade32c45ff6c1fbdf285a2b Author: Christian Lohmaier AuthorDate: Fri Sep 9 20:00:39 2022 +0200 Commit: Gerrit Code Review CommitDate: Fri Sep 9 20:00:39 2022 +0200 Update git submodules * Update translations from branch 'libreoffice-7-4' to ceb35d1d848b7ba6795c703a3bec6c5549844bfc - update translations for 7.4.1 rc2 and force-fix errors using pocheck Change-Id: Iead6e205e7824b0e4c5f7001661275410fe33360 (cherry picked from commit d2af5ccdc269827d9738b6ed08c8166bfd5c91cf) diff --git a/translations b/translations index dd84244a0ff3..ceb35d1d848b 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit dd84244a0ff314c710e71f609bd32f2afa483d95 +Subproject commit ceb35d1d848b7ba6795c703a3bec6c5549844bfc
[Libreoffice-commits] translations.git: source/am source/an source/ast source/ca source/cy source/de source/dsb source/es source/eu source/fi source/fr source/gl source/gug source/hsb source/hu source
source/am/officecfg/registry/data/org/openoffice/Office/UI.po | 18 source/an/cui/messages.po | 9 source/ast/cui/messages.po | 6 source/ast/filter/messages.po | 4 source/ast/helpcontent2/source/text/sbasic/guide.po | 6 source/ast/helpcontent2/source/text/sbasic/shared.po| 6 source/ast/helpcontent2/source/text/sbasic/shared/03.po | 36 source/ast/helpcontent2/source/text/scalc/01.po | 8 source/ast/helpcontent2/source/text/shared/01.po| 10 source/ast/helpcontent2/source/text/shared/02.po| 10 source/ast/helpcontent2/source/text/shared/guide.po | 4 source/ast/helpcontent2/source/text/shared/optionen.po | 16 source/ast/helpcontent2/source/text/smath/01.po | 12 source/ast/helpcontent2/source/text/swriter/01.po | 6 source/ast/helpcontent2/source/text/swriter/guide.po| 6 source/ast/officecfg/registry/data/org/openoffice/Office/UI.po | 22 source/ast/sc/messages.po | 8 source/ast/sd/messages.po | 9 source/ast/sfx2/messages.po | 21 source/ast/starmath/messages.po | 8 source/ast/sw/messages.po | 10 source/ca/cui/messages.po | 6 source/ca/helpcontent2/source/text/sbasic/guide.po | 4 source/ca/helpcontent2/source/text/sbasic/python.po | 8 source/ca/helpcontent2/source/text/sbasic/shared.po | 4 source/ca/helpcontent2/source/text/sbasic/shared/03.po | 58 source/ca/helpcontent2/source/text/scalc/01.po | 12 source/ca/helpcontent2/source/text/shared/00.po | 6 source/ca/helpcontent2/source/text/shared/02.po | 6 source/ca/helpcontent2/source/text/shared/optionen.po | 4 source/ca/helpcontent2/source/text/simpress/guide.po| 8 source/ca/helpcontent2/source/text/smath/01.po | 16 source/ca/sfx2/messages.po | 8 source/cy/uui/messages.po | 8 source/de/helpcontent2/source/text/sbasic/guide.po | 52 source/de/helpcontent2/source/text/sbasic/shared/02.po | 8 source/de/helpcontent2/source/text/sbasic/shared/03.po | 8 source/de/helpcontent2/source/text/scalc/01.po | 6 source/de/helpcontent2/source/text/scalc/02.po | 8 source/de/helpcontent2/source/text/sdatabase.po | 76 source/de/helpcontent2/source/text/shared/guide.po | 6 source/de/helpcontent2/source/text/shared/optionen.po | 6 source/de/helpcontent2/source/text/swriter/guide.po | 4 source/dsb/chart2/messages.po | 6 source/dsb/cui/messages.po | 6 source/dsb/formula/messages.po | 6 source/dsb/officecfg/registry/data/org/openoffice/Office/UI.po | 26 source/dsb/sc/messages.po | 8 source/dsb/sd/messages.po | 14 source/dsb/svx/messages.po | 20 source/dsb/wizards/source/resources.po | 10 source/es/basctl/messages.po| 6 source/es/basic/messages.po | 8 source/es/cui/messages.po | 50 source/es/extensions/messages.po| 18 source/es/formula/messages.po | 4 source/es/helpcontent2/source/text/sbasic/guide.po | 6 source/es/helpcontent2/source/text/sbasic/python.po | 52
[Libreoffice-bugs] [Bug 144423] UI: Text frame/shape doesn't show a contour border line when selected
https://bugs.documentfoundation.org/show_bug.cgi?id=144423 --- Comment #4 from Nithila --- I can see a contour border line for both shape and textbox when selected in the version LibreOffice 7.5. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150518] Sparkline dialogs have Close button instead of Cancel button
https://bugs.documentfoundation.org/show_bug.cgi?id=150518 stragu changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||stephane.guil...@member.fsf ||.org Ever confirmed|0 |1 Whiteboard| QA:needsComment| --- Comment #3 from stragu --- I can see the Close button in: Version: 7.4.0.3 / LibreOffice Community Build ID: f85e47c08ddd19c015c0114a68350214f7066f5a CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded It looks like most insertion and formatting dialogs have a "Cancel" button but there are also a few dialogs with a "Close" button. I'm not sure what the logic is behind picking one over the other. grofaty, can you point to a dialog that applies the changes when the "Close" button is pressed? For example, the Insert > Hyperlink dialog doesn't apply the changes if the Close button is pressed. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135482] EDITING: Data validity fails after copying sheet and deleting original sheet
https://bugs.documentfoundation.org/show_bug.cgi?id=135482 --- Comment #8 from Richard Kelly --- The "Menu/Data/Validity [Ok]" thing is a decent workaround; thank you. Might it also be a clue to the root cause? After the error is introduced, the behavior seems consistent with the spreadsheet holding two versions of the Data Validity attributes, i.e. the human-readable version we see in the dialog and an encoded version cached internally. Does selecting the dialog's [Ok] button cause the software to re-interpret the human-readable version and store the result internally? If so, would re-interpreting it earlier (e.g. when deleting Sheet1) fix the bug? The above is just speculation. I haven't seen the relevant code. I'm just basing my speculation on the behavior I've observed. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sw/source
sw/source/core/docnode/ndtbl1.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 4a7b856c2b6b97b9538a6945cf2afa95e59a3031 Author: Xisco Fauli AuthorDate: Fri Sep 9 13:33:09 2022 +0200 Commit: Xisco Fauli CommitDate: Fri Sep 9 19:17:52 2022 +0200 sw: avoid divide by zero in SwDoc::AdjustCellWidth See https://crashreport.libreoffice.org/stats/signature/SwDoc::AdjustCellWidth(SwCursor%20const%20&,bool,bool) Change-Id: I98b90dcbed6b6f3ea0a7d1668a5c248f39e7a2a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139658 Reviewed-by: Miklos Vajna Tested-by: Jenkins diff --git a/sw/source/core/docnode/ndtbl1.cxx b/sw/source/core/docnode/ndtbl1.cxx index 59c9154f74ca..678861ca08e1 100644 --- a/sw/source/core/docnode/ndtbl1.cxx +++ b/sw/source/core/docnode/ndtbl1.cxx @@ -1670,7 +1670,8 @@ void SwDoc::AdjustCellWidth( const SwCursor& rCursor, } fTotalWish += aWish[i]; } -const sal_uInt16 nEqualWidth = nSelectedWidth / nCols; +assert(nCols); +const sal_uInt16 nEqualWidth = nCols ? nSelectedWidth / nCols : 0; // bBalance: Distribute the width evenly for (sal_uInt16 & rn : aWish) if ( rn && bBalance )
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4-1' - sc/source
sc/source/core/data/dpsave.cxx | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
New commits:
commit 538f86a1a512b67b7abbe7edbc62acf341eb6606
Author: Eike Rathke
AuthorDate: Wed Sep 7 18:34:05 2022 +0200
Commit: Xisco Fauli
CommitDate: Fri Sep 9 19:17:02 2022 +0200
crashtesting: prevent nullptr access
There's a xlsx export crash on *2nd* export with data pilot data
of forum-en-38962.ods. We export without crash this .ods to xlsx
*once*, but on saving again to xlsx it crashes. It also crashes with an
export to .xls and then an export to .xlsx. Repeated exports to xls are
crash free.
Already on the first export there are loads of warning messages of
ScDPMember::GetItemData: what data? nDim 0, mnDataId #
ScNameToIndexAccess getByIndex failed
com.sun.star.container.NoSuchElementException message: "at
sc/source/core/data/dptabsrc.cxx:2267
The pivot tables are broken on both exports.
This smells like some sort of data pilot cache
corruption/insufficiency during .xlsx export but the root cause is
yet unknown. This only fixes the crash symptom.
Change-Id: Ie479f7f0abc4af284e61f6aa5a69943ccdd72eab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139611
Reviewed-by: Eike Rathke
Tested-by: Jenkins
(cherry picked from commit 5aa3f046f934092fbfd7cc92b93d79b4f548cc13)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139565
Reviewed-by: Xisco Fauli
(cherry picked from commit 0f434e0b91e240ff60418da4ae9c6415554e4d0f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139572
Reviewed-by: Christian Lohmaier
Tested-by: Xisco Fauli
diff --git a/sc/source/core/data/dpsave.cxx b/sc/source/core/data/dpsave.cxx
index 0f8bfbf11712..16de535bd85d 100644
--- a/sc/source/core/data/dpsave.cxx
+++ b/sc/source/core/data/dpsave.cxx
@@ -1285,8 +1285,20 @@ void
ScDPSaveData::SyncAllDimensionMembers(ScDPTableData* pData)
for (size_t j = 0; j < nMemberCount; ++j)
{
const ScDPItemData* pMemberData = pData->GetMemberById(nDimIndex,
rMembers[j]);
-OUString aMemName = pData->GetFormattedString(nDimIndex,
*pMemberData, false);
-aMemNames.insert(aMemName);
+// ScDPCache::GetItemDataById() (via
+// ScDPTableData::GetMemberById(),
+// ScDPGroupTableData::GetMemberById() through
+// GetCacheTable().getCache()) may return nullptr.
+if (pMemberData)
+{
+OUString aMemName = pData->GetFormattedString(nDimIndex,
*pMemberData, false);
+aMemNames.insert(aMemName);
+}
+else
+{
+SAL_WARN("sc.core", "No pMemberData for nDimIndex " <<
nDimIndex << ", rMembers[j] " << rMembers[j]
+<< ", j " << j);
+}
}
it->RemoveObsoleteMembers(aMemNames);
[Libreoffice-bugs] [Bug 150499] CRASH: deleting sheet
https://bugs.documentfoundation.org/show_bug.cgi?id=150499 --- Comment #6 from Commit Notification --- Luboš Luňák committed a patch related to this issue. It has been pushed to "libreoffice-7-4-1": https://git.libreoffice.org/core/commit/fc6cd5b1e214f6688dbfb5ffa70332b6bece8763 try harder to ensure InterpretCellsIfNeeded() interprets (tdf#150499) It will be available in 7.4.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150499] CRASH: deleting sheet
https://bugs.documentfoundation.org/show_bug.cgi?id=150499 Commit Notification changed: What|Removed |Added Whiteboard|target:7.5.0 target:7.4.2 |target:7.5.0 target:7.4.2 ||target:7.4.1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4-1' - sc/inc sc/source
sc/inc/column.hxx |2 -
sc/inc/document.hxx|4 ++-
sc/inc/formulacell.hxx |2 +
sc/inc/rangecache.hxx |2 -
sc/inc/table.hxx |2 -
sc/source/core/data/column3.cxx| 44 +
sc/source/core/data/documen2.cxx | 11 ++---
sc/source/core/data/document.cxx | 13 +++---
sc/source/core/data/table1.cxx |7 -
sc/source/core/tool/rangecache.cxx |6 -
10 files changed, 65 insertions(+), 28 deletions(-)
New commits:
commit fc6cd5b1e214f6688dbfb5ffa70332b6bece8763
Author: Luboš Luňák
AuthorDate: Tue Aug 23 19:47:50 2022 +0200
Commit: Xisco Fauli
CommitDate: Fri Sep 9 19:16:28 2022 +0200
try harder to ensure InterpretCellsIfNeeded() interprets (tdf#150499)
ScFormulaCell::Interpret() tries to interpret the whole formula group
(or the given range of it), but it's not guaranteed, and possibly
just the called cell will be interpreted. So if a specific range
really needs to be interpreted, handle that case.
Change-Id: I7fb563ae471eefd49e5bb6c92b6aff98c42a440e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138741
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
(cherry picked from commit e1f02b8d00272be9cbf17cb8c351445a08a4c5f4)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138814
Reviewed-by: Xisco Fauli
(cherry picked from commit 92ad0da73f23376d65b5367b44dd0ac9f7c59a12)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138820
Reviewed-by: Christian Lohmaier
Tested-by: Xisco Fauli
diff --git a/sc/inc/column.hxx b/sc/inc/column.hxx
index e4b7eb148d9a..aa5a5c689c01 100644
--- a/sc/inc/column.hxx
+++ b/sc/inc/column.hxx
@@ -721,7 +721,7 @@ public:
bool IsDrawObjectsEmptyBlock(SCROW nStartRow, SCROW nEndRow) const;
void InterpretDirtyCells( SCROW nRow1, SCROW nRow2 );
-void InterpretCellsIfNeeded( SCROW nRow1, SCROW nRow2 );
+bool InterpretCellsIfNeeded( SCROW nRow1, SCROW nRow2 );
static void JoinNewFormulaCell( const sc::CellStoreType::position_type&
aPos, ScFormulaCell& rCell );
diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index 959960e15e03..b4552e792000 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -1363,7 +1363,9 @@ public:
void SetTableOpDirty( const ScRange& ); // for Interpreter
TableOp
void InterpretDirtyCells( const ScRangeList& rRanges );
// Interprets cells that have NeedsInterpret(), i.e. the same like calling
MaybeInterpret() on them.
-void InterpretCellsIfNeeded( const ScRangeList& rRanges );
+// Returns false if some couldn't be interpreted (i.e. they still have
NeedsInterpret()).
+// Useful to ensure that the given cells will not need interpreting.
+bool InterpretCellsIfNeeded( const ScRangeList& rRanges );
SC_DLLPUBLIC void CalcAll();
SC_DLLPUBLIC void CalcAfterLoad( bool bStartListening = true );
void CompileAll();
diff --git a/sc/inc/formulacell.hxx b/sc/inc/formulacell.hxx
index 013a0058ba5d..789353efce9f 100644
--- a/sc/inc/formulacell.hxx
+++ b/sc/inc/formulacell.hxx
@@ -261,6 +261,8 @@ public:
void CompileXML( sc::CompileFormulaContext& rCxt, ScProgress& rProgress );
// compile temporary string tokens
void CalcAfterLoad( sc::CompileFormulaContext& rCxt, bool bStartListening
);
boolMarkUsedExternalReferences();
+// Returns true if the cell was interpreted as part of the formula group.
+// The parameters may limit which subset of the formula group should be
interepreted, if possible.
bool Interpret(SCROW nStartOffset = -1, SCROW nEndOffset = -1);
bool IsIterCell() const { return bIsIterCell; }
sal_uInt16 GetSeenInIteration() const { return nSeenInIteration; }
diff --git a/sc/inc/rangecache.hxx b/sc/inc/rangecache.hxx
index 7490a570f20a..c65e8653a458 100644
--- a/sc/inc/rangecache.hxx
+++ b/sc/inc/rangecache.hxx
@@ -46,7 +46,7 @@ class ScSortedRangeCache final : public SvtListener
public:
/// MUST be new'd because Notify() deletes.
ScSortedRangeCache(ScDocument* pDoc, const ScRange& rRange, const
ScQueryParam& param,
- ScInterpreterContext* context);
+ ScInterpreterContext* context, bool invalid = false);
/// Returns if the cache is usable.
bool isValid() const { return mValid; }
diff --git a/sc/inc/table.hxx b/sc/inc/table.hxx
index 0a3bc6c67956..35388b54ea1f 100644
--- a/sc/inc/table.hxx
+++ b/sc/inc/table.hxx
@@ -1057,7 +1057,7 @@ public:
void FillMatrix( ScMatrix& rMat, SCCOL nCol1, SCROW nRow1, SCCOL nCol2,
SCROW nRow2, svl::SharedStringPool* pPool ) const;
void InterpretDirtyCells( SCCOL nCol1, SCROW nRow1, SCCOL nCol2, SCROW
nRow2 );
-void InterpretCellsIfNeeded( SCCOL nCol1, SCROW nRow1, SCCOL nCol2, SCROW
nRow2 );
+
[Libreoffice-bugs] [Bug 150770] FILEOPEN: PPtX: Read error - Error reading file
https://bugs.documentfoundation.org/show_bug.cgi?id=150770 --- Comment #19 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-4-1": https://git.libreoffice.org/core/commit/6167a3ca9c2a88814933b83f6ced75444983ae4a tdf#150770: crashtesting: assert seen on loading forum-mso-en-2633.pptx It will be available in 7.4.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150770] FILEOPEN: PPtX: Read error - Error reading file
https://bugs.documentfoundation.org/show_bug.cgi?id=150770 Commit Notification changed: What|Removed |Added Whiteboard|target:7.4.2 target:7.5.0 |target:7.4.2 target:7.5.0 ||target:7.4.1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4-1' - oox/source
oox/source/ppt/presentationfragmenthandler.cxx | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
New commits:
commit 6167a3ca9c2a88814933b83f6ced75444983ae4a
Author: Caolán McNamara
AuthorDate: Sun Jun 12 17:21:12 2022 +0100
Commit: Xisco Fauli
CommitDate: Fri Sep 9 19:15:34 2022 +0200
tdf#150770: crashtesting: assert seen on loading forum-mso-en-2633.pptx
probably since:
commit 855a56fea4561135a63cb729d7a625a950b210e7
Date: Fri May 13 08:12:17 2022 +0200
tdf#148965 PPTX import: fix internal hyperlinks on shapes
Change-Id: I920cbbb5544cbe9d76f37b3d524c9ccebd426132
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135682
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
(cherry picked from commit 48de2ac37366d5671aabc64364660311431d3235)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139570
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
(cherry picked from commit 80551374ae7b5c010dac6bbdf36b3cf1897f952f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139573
Reviewed-by: Christian Lohmaier
Tested-by: Xisco Fauli
diff --git a/oox/source/ppt/presentationfragmenthandler.cxx
b/oox/source/ppt/presentationfragmenthandler.cxx
index b0a7b7ec0fd3..ac1e32e533ec 100644
--- a/oox/source/ppt/presentationfragmenthandler.cxx
+++ b/oox/source/ppt/presentationfragmenthandler.cxx
@@ -112,15 +112,17 @@ static void
lcl_setBookmark(uno::Reference& rShape,
std::vector& rSlidePersist)
{
OUString aBookmark;
-sal_Int32 nPageNumber;
static const OUStringLiteral sSlideName = u"#page";
uno::Reference xPropSet(rShape, uno::UNO_QUERY);
xPropSet->getPropertyValue("Bookmark") >>= aBookmark;
-nPageNumber = o3tl::toInt32(aBookmark.subView(sSlideName.getLength()));
-Reference xDrawPage(rSlidePersist[nPageNumber - 1]->getPage());
-Reference xNamed(xDrawPage, UNO_QUERY_THROW);
-aBookmark = xNamed->getName();
-xPropSet->setPropertyValue("Bookmark", Any(aBookmark));
+if (aBookmark.startsWith(sSlideName))
+{
+sal_Int32 nPageNumber =
o3tl::toInt32(aBookmark.subView(sSlideName.getLength()));
+Reference xDrawPage(rSlidePersist[nPageNumber -
1]->getPage());
+Reference xNamed(xDrawPage, UNO_QUERY_THROW);
+aBookmark = xNamed->getName();
+xPropSet->setPropertyValue("Bookmark", Any(aBookmark));
+}
}
static void ResolveShapeBookmark(std::vector& rSlidePersist)
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4-1' - filter/source
filter/source/pdf/pdffilter.cxx | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
New commits:
commit 6e5b05302081b3cd5d046671ce5b1d340c880b30
Author: Mike Kaganski
AuthorDate: Wed Sep 7 21:50:24 2022 +0300
Commit: Xisco Fauli
CommitDate: Fri Sep 9 19:14:45 2022 +0200
tdf#150846: FilterOptions in descriptor could come from import filter
Tolerate failure parsing json here. Unfortunately this means that
we can't provide a diagnostics to user when they provide bad json
in the command line parameters.
Change-Id: Ia3fa18e709a4c0b891faf4365453b79e6c58a9c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139613
Tested-by: Jenkins
Reviewed-by: Miklos Vajna
(cherry picked from commit 467308d679a3f2b4bbdd117fcc73636d57d66c09)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139568
Reviewed-by: Xisco Fauli
(cherry picked from commit 7a9b45de539fc69c6a99e0f1cdf5e0554cc83cbc)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139654
Reviewed-by: Christian Lohmaier
Tested-by: Xisco Fauli
diff --git a/filter/source/pdf/pdffilter.cxx b/filter/source/pdf/pdffilter.cxx
index d7fc558d198e..f12559bfe3df 100644
--- a/filter/source/pdf/pdffilter.cxx
+++ b/filter/source/pdf/pdffilter.cxx
@@ -33,6 +33,8 @@
#include
#include
+#include
+
using namespace ::com::sun::star::io;
PDFFilter::PDFFilter( const Reference< XComponentContext > ) :
@@ -78,11 +80,19 @@ bool PDFFilter::implExport( const Sequence< PropertyValue
>& rDescriptor )
pValue[i].Value >>= bIsRedactMode;
}
-if (!aFilterData.hasElements() && !aFilterOptions.isEmpty())
+if (!aFilterData.hasElements() && aFilterOptions.startsWith("{"))
{
-// Allow setting filter data keys from the cmdline.
-std::vector aData =
comphelper::JsonToPropertyValues(aFilterOptions.toUtf8());
-aFilterData = comphelper::containerToSequence(aData);
+try
+{
+// Allow setting filter data keys from the cmdline.
+std::vector aData
+= comphelper::JsonToPropertyValues(aFilterOptions.toUtf8());
+aFilterData = comphelper::containerToSequence(aData);
+}
+catch (const boost::property_tree::json_parser::json_parser_error&)
+{
+// This wasn't a valid json; maybe came from import filter
(tdf#150846)
+}
}
/* we don't get FilterData if we are exporting directly
[Libreoffice-bugs] [Bug 150766] Incomplete recalculate
https://bugs.documentfoundation.org/show_bug.cgi?id=150766 Eike Rathke changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |er...@redhat.com |desktop.org | Status|NEW |ASSIGNED --- Comment #8 from Eike Rathke --- Taking. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/source
sc/source/filter/xml/xmlexprt.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit d2c500fb40be23aa7bd1d2b7cc02e47ea109d25c Author: Eike Rathke AuthorDate: Thu Sep 8 21:52:19 2022 +0200 Commit: Eike Rathke CommitDate: Fri Sep 9 18:43:44 2022 +0200 Related: tdf#150312 Assert a defined name's non-empty table:base-cell-address Change-Id: Iaf377ae51c20e30e0362f5dc6f66172c544483d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139728 Reviewed-by: Eike Rathke Tested-by: Jenkins diff --git a/sc/source/filter/xml/xmlexprt.cxx b/sc/source/filter/xml/xmlexprt.cxx index ca7ff1cca804..77a45ab9b284 100644 --- a/sc/source/filter/xml/xmlexprt.cxx +++ b/sc/source/filter/xml/xmlexprt.cxx @@ -4484,6 +4484,7 @@ void ScXMLExport::WriteNamedRange(ScRangeName* pRangeName) rxEntry.second->ValidateTabRefs(); ScRangeStringConverter::GetStringFromAddress( sBaseCellAddress, rxEntry.second->GetPos(), pDoc, FormulaGrammar::CONV_OOO, ' ', false, ScRefFlags::ADDR_ABS_3D); +assert(!sBaseCellAddress.isEmpty()); AddAttribute(XML_NAMESPACE_TABLE, XML_BASE_CELL_ADDRESS, sBaseCellAddress); OUString sSymbol = rxEntry.second->GetSymbol(pDoc->GetStorageGrammar());
[Libreoffice-bugs] [Bug 34519] Cell comments should be above a split in freeze
https://bugs.documentfoundation.org/show_bug.cgi?id=34519 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=55 ||131 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 55133] COMMENT - added comment text gets invisible when fist row is set as header (MENU WINDOW FREEZE)
https://bugs.documentfoundation.org/show_bug.cgi?id=55133 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=55 ||131 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 55131] Comments: "freeze cells" indicator line visible in comment
https://bugs.documentfoundation.org/show_bug.cgi?id=55131 Justin L changed: What|Removed |Added OS|Windows (All) |All Hardware|x86-64 (AMD64) |All See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=55 ||133, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=34 ||519 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 123838] Issue on CAST() (FirebirdSQL)
https://bugs.documentfoundation.org/show_bug.cgi?id=123838 priya singh changed: What|Removed |Added URL||https://www.bangalorecallgi ||rls.net/ --- Comment #8 from priya singh --- escorts super-sexy Bangalore Call Girls, but they’re also really friendly, fun and easy to get along with – which makes them the perfect date for anyone who wants to spend some quality time with an exciting partner in their city. Whether you want a naughty night in or are looking to book an adventurous weekend away, we’ve got all kinds of hot female partners who can fulfill your fantasies and provide you with the adult entertainment that you crave! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 121877] Tabbed UIs do not use theme color - keeps the default application color
https://bugs.documentfoundation.org/show_bug.cgi?id=121877 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||8145 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108145] Notebookbar background color should be defaulting to toolbar color
https://bugs.documentfoundation.org/show_bug.cgi?id=108145 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||1877 --- Comment #15 from Justin L --- How is this different from bug 121877? Should it be a duplicate? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150894] Added Gradients Not Saved in documents (ODT, ODG)
https://bugs.documentfoundation.org/show_bug.cgi?id=150894 --- Comment #2 from Harald Berger --- I can confirm this. It seems that for page background and frame the gradient is not saved. Drawing shapes incl. Text Box are saved. But what is not saved is a transparency value. This could be intentional. See also: https://ask.libreoffice.org/t/custom-gradient-colors-missing-after-saving-where-are-they/63175 --- With me: Version: 7.4.0.3 (x64) / LibreOffice Community Build ID: f85e47c08ddd19c015c0114a68350214f7066f5a CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150894] Added Gradients Not Saved in documents (ODT, ODG)
https://bugs.documentfoundation.org/show_bug.cgi?id=150894 Harald Berger changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147147] Display of UI is very large on Mac
https://bugs.documentfoundation.org/show_bug.cgi?id=147147 --- Comment #3 from Alex Thurgood --- @Tony,@David : I can't reproduce this on my Arm MacBook Pro (13 inch, M1, 2020), either when using the built-in laptop display, or when connected to either an external 1080 dpi moniteur or a HiDPI Apple 27 inch monitor. Under LibreOffices Preferences > LibreOffice > Display - which, if any, of the tick boxes are active (even if they are greyed out) ? - which icon set, and which icon size are you using ? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131781] Calculating optimal width relatively slow CPU/consuming (Win-only)
https://bugs.documentfoundation.org/show_bug.cgi?id=131781 --- Comment #7 from Buovjaga --- I get these on Windows 10 7.0 bibisect repo, oldest: 22.7 secs (same result with 7.1 repo newest) 7.5: 3.8 secs so it seems like quite an improvement. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 115449] Add Tooltips to the Horizontal Ruler in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=115449 --- Comment #8 from Stephen Leibowitz --- The tabs are small and at the bottom of the ruler. Even on a laptop or desktop monitor, the small size is a visual problem. Using color for the manually set tabs would make it practical to increase their size and locate them at the same height as the length markings, without increasing the width of the ruler. Apple and Google (Docs) color the tabs (and other items) on the ruler. It may not be a coincidence that these two companies are major players in the small device market, where screen real estate is at a premium. Also, Collabra colors the indents on the ruler for tablets. It does not have a ruler on phones. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150894] Added Gradients Not Saved in documents (ODT, ODG)
https://bugs.documentfoundation.org/show_bug.cgi?id=150894 --- Comment #1 from saved2se...@gmail.com --- Created attachment 182344 --> https://bugs.documentfoundation.org/attachment.cgi?id=182344=edit saved gradient test See thread https://ask.libreoffice.org/t/custom-gradient-colors-missing-after-saving-where-are-they/63175 I thank God for those who even make such customization possible and their abilities and and those who help! And thank you all here for the interest and help in this perplexing if not major issue. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150894] New: Added Gradients Not Saved in documents (ODT, ODG)
https://bugs.documentfoundation.org/show_bug.cgi?id=150894 Bug ID: 150894 Summary: Added Gradients Not Saved in documents (ODT, ODG) Product: LibreOffice Version: 7.3.5.2 release Hardware: x86-64 (AMD64) OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: saved2se...@gmail.com Description: Adding custom gradients under Page styles (or under Properties in Frames)>Area>Gradient>Add>Name>OK>Apply, only results in added, named, saved gradient color schemes being presently available for that ODT document while still open, not for any others, nor available to choose (in that document or any others) after saving, closing and reopening document, nor after closing and reopening LO. Steps to Reproduce: 1.Open new writer or drawing document. 2. R. click to Page Styles or Properties, and hit Area>Gradient (or Area) 3.Hit Add or customize colors, etc. first, provide name, and OK and OK or Apply and OK. Likewise add more gradients if wanted for additional testing. 4. Open a new document and follow step 2 to see if you can find any of the gradients you added are listed. Save first (or any) document in which you added, named and saved a gradient in. Next, close and reopen document and follow step 2 and see if you can find any of the gradients you added, named and saved. Note that if you had chosen Apply in step 3 then gradient should be seen applied to the page or frame saved as so formatted, but look for any added, named, saved gradients being listed and thus available under 2. 5. Close LO and reopen the saved document and check for availability of added, named and saved gradients as per step 4. Actual Results: While after closing and reopening, the last applied gradient will be applied to the document saved with it, but none any of the gradients you added, named and saved are listed and thus available to be applied. Expected Results: As with adding custom colors under Page Styles or Properties, then added, named and saved gradients should henceforth be available to choose from in any document. Reproducible: Always User Profile Reset: Yes Additional Info: This operation was tested with LO 7.3.2.2. in Safe Mode in a PC with a Ryzen 3200G CPU. 64 GB RAM, running Windows 10 and up to date Windows 11, as well as LO 7.3.5.2 Portable in the same PC. Also in 32 bit Linux and corresponding LO in an older PC. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 41645] Pivot table formatting/sorting disappears on refresh (with no undo)
https://bugs.documentfoundation.org/show_bug.cgi?id=41645 Justin L changed: What|Removed |Added Summary|Pivot table formatting |Pivot table |disappears on refresh |formatting/sorting ||disappears on refresh (with ||no undo) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150590] 文件列印顏色錯誤
https://bugs.documentfoundation.org/show_bug.cgi?id=150590 Michael Warner changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #2 from Michael Warner --- 1. Please attach a sample document 2. Please check your printer and toner levels 3. Please provide more details as to your printer settings 4. Please post the info in the About LibreOffice window -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150590] 文件列印顏色錯誤
https://bugs.documentfoundation.org/show_bug.cgi?id=150590 --- Comment #1 from Michael Warner --- English translation === The text is black and red, and it turns pink when printed The edited color of the document is very different from the printed color === -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 115817] Correct implementation or remove the Navigation toolbar (a GSOC 2009 contribution see bug 32869) (comment 3 for history and functional intent)
https://bugs.documentfoundation.org/show_bug.cgi?id=115817 --- Comment #50 from Justin L --- Is this bug fixed? If some aspects are still TODO, it would be nice to document that if this bug is left open. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150433] Add Thai thesaurus
https://bugs.documentfoundation.org/show_bug.cgi?id=150433 --- Comment #3 from Eike Rathke --- Apparently we don't have your license statement on file, could you please send us a blanket statement that you contribute all your past and future patches under the MPLv2 and LGPLv3+ licenses? Best on the dev mailing list libreoff...@lists.freedesktop.org so we can link to it from https://wiki.documentfoundation.org/Development/Developers Something like this does nicely: All of my past & future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license. Best use Subject: license statement Sorry for the inconvenience and thank you for cooperating :-) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148876] Add Thai hyphenation patterns
https://bugs.documentfoundation.org/show_bug.cgi?id=148876 --- Comment #3 from Eike Rathke --- Apparently we don't have your license statement on file, could you please send us a blanket statement that you contribute all your past and future patches under the MPLv2 and LGPLv3+ licenses? Best on the dev mailing list libreoff...@lists.freedesktop.org so we can link to it from https://wiki.documentfoundation.org/Development/Developers Something like this does nicely: All of my past & future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license. Best use Subject: license statement Sorry for the inconvenience and thank you for cooperating :-) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104770] Fileopen of OCR'ed PDF also shows otherwise hidden text so looks duplicated
https://bugs.documentfoundation.org/show_bug.cgi?id=104770 Timur changed: What|Removed |Added CC||fcoda...@gmail.com --- Comment #16 from Timur --- *** Bug 146495 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 99746] [META] PDF import filter in Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=99746 Bug 99746 depends on bug 146495, which changed state. Bug 146495 Summary: FORMATTING: Text gets duplicated when importing pdf https://bugs.documentfoundation.org/show_bug.cgi?id=146495 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146495] FORMATTING: Text gets duplicated when importing pdf
https://bugs.documentfoundation.org/show_bug.cgi?id=146495 Timur changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #6 from Timur --- *** This bug has been marked as a duplicate of bug 104770 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150810] Make the Search Commands dialog easier to understand
https://bugs.documentfoundation.org/show_bug.cgi?id=150810 --- Comment #14 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/1cba31a159fb1ed4795adeea968dc915b95d64a5 tdf#150810 get visible placeholder text in GtkEntry with focus It will be available in 7.4.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150810] Make the Search Commands dialog easier to understand
https://bugs.documentfoundation.org/show_bug.cgi?id=150810 Commit Notification changed: What|Removed |Added Whiteboard|target:7.5.0|target:7.5.0 target:7.4.2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - vcl/unx
vcl/unx/gtk3/gtkinst.cxx | 145 +++
1 file changed, 145 insertions(+)
New commits:
commit 1cba31a159fb1ed4795adeea968dc915b95d64a5
Author: Caolán McNamara
AuthorDate: Wed Sep 7 12:24:44 2022 +0100
Commit: Miklos Vajna
CommitDate: Fri Sep 9 16:41:12 2022 +0200
tdf#150810 get visible placeholder text in GtkEntry with focus
in gtk3 focus causes placeholders to be not rendered
https://gitlab.gnome.org/GNOME/gtk/-/issues/378
https://bugzilla.gnome.org/show_bug.cgi?id=657613
FWIW, currently in gtk4 they are shown when focused
Change-Id: I623c81dd71f651d8b24a717a63fe428bc9d6a505
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139592
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
(cherry picked from commit 7ef1de66eb974fdb7638582e80b1cdab46f4e81d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139561
Reviewed-by: Miklos Vajna
diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index 8c46146b00f6..ec706e524455 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -13092,16 +13092,161 @@ public:
class GtkInstanceEntry : public GtkInstanceEditable
{
+private:
+#if !GTK_CHECK_VERSION(4, 0, 0)
+GtkEntry* m_pEntry;
+GtkOverlay* m_pPlaceHolderReplacement;
+GtkLabel* m_pPlaceHolderLabel;
+gulong m_nEntryFocusInSignalId;
+gulong m_nEntryFocusOutSignalId;
+gulong m_nEntryTextLengthSignalId;
+gulong m_nEntryScrollOffsetSignalId;
+guint m_nUpdatePlaceholderReplacementIdle;
+
+static gboolean do_update_placeholder_replacement(gpointer widget)
+{
+GtkInstanceEntry* pThis = static_cast(widget);
+pThis->update_placeholder_replacement();
+return false;
+}
+
+void update_placeholder_replacement()
+{
+m_nUpdatePlaceholderReplacementIdle = 0;
+
+const char* placeholder_text =
gtk_entry_get_placeholder_text(m_pEntry);
+const bool bShow = placeholder_text &&
!gtk_entry_get_text_length(m_pEntry) &&
+ gtk_widget_has_focus(GTK_WIDGET(m_pEntry));
+if (bShow)
+{
+GdkRectangle text_area;
+gtk_entry_get_text_area(m_pEntry, _area);
+gint x;
+gtk_entry_get_layout_offsets(m_pEntry, , nullptr);
+gtk_widget_set_margin_start(GTK_WIDGET(m_pPlaceHolderLabel), x);
+gtk_widget_set_margin_end(GTK_WIDGET(m_pPlaceHolderLabel), x);
+gtk_label_set_text(m_pPlaceHolderLabel, placeholder_text);
+gtk_widget_show(GTK_WIDGET(m_pPlaceHolderLabel));
+}
+else
+gtk_widget_hide(GTK_WIDGET(m_pPlaceHolderLabel));
+}
+
+void launch_update_placeholder_replacement()
+{
+// do it in the next event cycle so the GtkEntry has done its layout
+// and gtk_entry_get_layout_offsets returns the right results
+if (m_nUpdatePlaceholderReplacementIdle)
+return;
+// G_PRIORITY_LOW so gtk's idles are run before this
+m_nUpdatePlaceholderReplacementIdle = g_idle_add_full(G_PRIORITY_LOW,
do_update_placeholder_replacement, this, nullptr);
+}
+
+static gboolean signalEntryFocusIn(GtkWidget*, GdkEvent*, gpointer widget)
+{
+GtkInstanceEntry* pThis = static_cast(widget);
+pThis->launch_update_placeholder_replacement();
+return false;
+}
+
+static gboolean signalEntryFocusOut(GtkWidget*, GdkEvent*, gpointer widget)
+{
+GtkInstanceEntry* pThis = static_cast(widget);
+pThis->launch_update_placeholder_replacement();
+return false;
+}
+
+static void signalEntryTextLength(void*, GParamSpec*, gpointer widget)
+{
+GtkInstanceEntry* pThis = static_cast(widget);
+pThis->launch_update_placeholder_replacement();
+}
+
+static void signalEntryScrollOffset(void*, GParamSpec*, gpointer widget)
+{
+// this property affects the x-position of the text area
+GtkInstanceEntry* pThis = static_cast(widget);
+pThis->launch_update_placeholder_replacement();
+}
+
+#endif
+
public:
GtkInstanceEntry(GtkEntry* pEntry, GtkInstanceBuilder* pBuilder, bool
bTakeOwnership)
: GtkInstanceEditable(GTK_WIDGET(pEntry), pBuilder, bTakeOwnership)
+#if !GTK_CHECK_VERSION(4, 0, 0)
+, m_pEntry(pEntry)
+, m_pPlaceHolderReplacement(nullptr)
+, m_pPlaceHolderLabel(nullptr)
+, m_nEntryFocusInSignalId(0)
+, m_nEntryFocusOutSignalId(0)
+, m_nEntryTextLengthSignalId(0)
+, m_nEntryScrollOffsetSignalId(0)
+, m_nUpdatePlaceholderReplacementIdle(0)
+#endif
{
+#if !GTK_CHECK_VERSION(4, 0, 0)
+// tdf#150810 fake getting placeholders visible even when GtkEntry has
focus in gtk3.
+// In gtk4 this works out of the box, for gtk3 fake it by having a
GtkLabel in an
+// overlay and show that label if the
[Libreoffice-bugs] [Bug 34519] Cell comments should be above a split in freeze
https://bugs.documentfoundation.org/show_bug.cgi?id=34519 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=55 ||133 -- You are receiving this mail because: You are the assignee for the bug.
