[Libreoffice-bugs] [Bug 138528] When I type ö using the ASCII code, instead of appearing where I typed it, it appears before the previous character.
https://bugs.documentfoundation.org/show_bug.cgi?id=138528 dm changed: What|Removed |Added Severity|minor |normal Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #10 from dm --- The issue persists with version 7.5 and was also noted with the 7.3 and 7.4 versions. Version: 7.5.0.0.alpha1 (X86_64) / LibreOffice Community Build ID: 2b4d136b65bc79a1248876160e85fab79d52d5d6 CPU threads: 2; OS: Linux 5.19; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded The problem started with the office program(s) wanting to display a pending accent before the complete keyboard/character code was sent, which apparently created a race condition, readily observable in older/slower systems and/or 'difficult' documents like the one described above (long, multi-column, tables with several lines of text in each cell). As long as a specific commit addressing this issue is not in reference, I don't expect it to go away. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149240] DOCX SDT: support for
https://bugs.documentfoundation.org/show_bug.cgi?id=149240 --- Comment #4 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/78b5195d8add0679263a5e08ba34be9b27637a65 tdf#149240 docx content controls: round-trip showingPlcHdr better It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149240] DOCX SDT: support for
https://bugs.documentfoundation.org/show_bug.cgi?id=149240 Commit Notification changed: What|Removed |Added Whiteboard||target:7.5.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa sw/source writerfilter/source
sw/qa/extras/ooxmlexport/ooxmlexport17.cxx |6 ++
sw/qa/extras/ooxmlexport/ooxmlexport3.cxx|4
sw/source/filter/ww8/docxattributeoutput.cxx | 10 ++
sw/source/filter/ww8/docxattributeoutput.hxx |2 ++
writerfilter/source/dmapper/DomainMapper.cxx | 20 +++-
5 files changed, 37 insertions(+), 5 deletions(-)
New commits:
commit 78b5195d8add0679263a5e08ba34be9b27637a65
Author: Justin Luth
AuthorDate: Wed Dec 7 13:44:01 2022 -0500
Commit: Miklos Vajna
CommitDate: Fri Dec 9 07:14:38 2022 +
tdf#149240 docx content controls: round-trip showingPlcHdr better
ShowingPlaceHolder causes all the text in the control to be
selected when the control gains the focus. Otherwise, just a
cursor is placed at the click point.
While round-tripping this attribute worked for inline SDTs,
it was lost for block SDTs. But BlockSDTs are very easy
to create. The MS templates are full of them.
Also, these are boolean, but it could have a val=0 specified,
in which case it is off, but we were importing it as on.
Change-Id: I167afa935311a63bba408ecd489ae819485a5cb7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143818
Tested-by: Jenkins
Reviewed-by: Justin Luth
Reviewed-by: Miklos Vajna
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
index 87e7d0c68b21..d9d5802e0606 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
@@ -830,6 +830,12 @@ DECLARE_OOXMLEXPORT_TEST(testTdf148111, "tdf148111.docx")
// No more fields
CPPUNIT_ASSERT(!xFields->hasMoreElements());
+
+if (!isExported())
+return;
+xmlDocUniquePtr pXmlDoc = parseExport("word/document.xml");
+// ShowingPlaceholder should be off for 0, false and "on". (This was 21
before the fix)
+assertXPath(pXmlDoc,"//w:p/w:sdt/w:sdtPr/w:showingPlcHdr", 12);
}
DECLARE_OOXMLEXPORT_TEST(TestTdf73499, "tdf73499.docx")
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx
index 9930fa27b768..db2abe3513a7 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx
@@ -1000,6 +1000,10 @@ CPPUNIT_TEST_FIXTURE(Test, testGlossaryWithEmail)
"and
@Type='http://schemas.openxmlformats.org/officeDocument/2006/relationships/hyperlink'
"
"and @Target='mailto:emailgoesh...@example.com' "
"and @TargetMode='External']");
+
+// preserve the ShowingPlaceholder setting on both block SDTs.
+pXmlDoc = parseExport("word/document.xml");
+
assertXPath(pXmlDoc,"/w:document/w:body/w:p/w:sdt/w:sdtPr/w:showingPlcHdr", 2);
}
DECLARE_OOXMLEXPORT_TEST(testFdo71785, "fdo71785.docx")
diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx
b/sw/source/filter/ww8/docxattributeoutput.cxx
index 92b13f34823c..dcafe422a0e8 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -619,6 +619,7 @@ void SdtBlockHelper::DeleteAndResetTheLists()
m_aPlaceHolderDocPart.clear();
if (!m_aColor.isEmpty())
m_aColor.clear();
+m_bShowingPlaceHolder = false;
m_bHasId = false;
}
@@ -707,6 +708,10 @@ void SdtBlockHelper::WriteExtraParams(const
::sax_fastparser::FSHelperPtr& pSeri
pSerializer->singleElementNS(XML_w, XML_docPart, FSNS(XML_w, XML_val),
m_aPlaceHolderDocPart);
pSerializer->endElementNS(XML_w, XML_placeholder);
}
+
+if (m_bShowingPlaceHolder)
+pSerializer->singleElementNS(XML_w, XML_showingPlcHdr);
+
if (!m_aColor.isEmpty())
{
pSerializer->singleElementNS(XML_w15, XML_color, FSNS(XML_w, XML_val),
m_aColor);
@@ -813,6 +818,11 @@ void SdtBlockHelper::GetSdtParamsFromGrabBag(const
uno::Sequence>= m_bShowingPlaceHolder))
+SAL_WARN("sw.ww8", "DocxAttributeOutput::GrabBag: unexpected
sdt ShowingPlcHdr");
+}
else if (aPropertyValue.Name == "ooxml:CT_SdtPr_alias" &&
m_aAlias.isEmpty())
{
if (!(aPropertyValue.Value >>= m_aAlias))
diff --git a/sw/source/filter/ww8/docxattributeoutput.hxx
b/sw/source/filter/ww8/docxattributeoutput.hxx
index fd14524f6e77..6e029cc9dfc4 100644
--- a/sw/source/filter/ww8/docxattributeoutput.hxx
+++ b/sw/source/filter/ww8/docxattributeoutput.hxx
@@ -130,6 +130,7 @@ public:
SdtBlockHelper()
: m_bHasId(false)
, m_bStartedSdt(false)
+, m_bShowingPlaceHolder(false)
, m_nSdtPrToken(0)
{}
@@ -141,6 +142,7 @@ public:
rtl::Reference m_pDataBindingAttrs;
OUString m_aColor;
OUString m_aPlaceHolderDocPart;
+bool m_bShowingPlaceHolder;
OUString m_aAlias;
sal_Int32 m_nSdtPrToken;
diff --git a/writerfilter/source/dmapper/DomainMapper.cxx
b/writerfilter/source/dmapper/DomainMapper.cxx
index 93cb36cb8e55..4683ff445458 100644
[Libreoffice-commits] core.git: sw/inc sw/qa sw/source
sw/inc/IDocumentContentOperations.hxx |5 - sw/qa/core/layout/layout.cxx|5 +++-- sw/qa/extras/uiwriter/uiwriter7.cxx | 13 - sw/qa/extras/unowriter/unowriter.cxx|5 +++-- sw/qa/uibase/shells/shells.cxx |5 +++-- sw/source/core/doc/DocumentContentOperationsManager.cxx | 14 -- sw/source/core/inc/DocumentContentOperationsManager.hxx |3 --- 7 files changed, 17 insertions(+), 33 deletions(-) New commits: commit 2d9a3f8137e82af4a419441b58f80c027eee51b1 Author: Miklos Vajna AuthorDate: Thu Dec 8 20:06:15 2022 +0100 Commit: Miklos Vajna CommitDate: Fri Dec 9 07:10:50 2022 + sw: remove unused DocumentContentOperationsManager::InsertGraphicObject() Only tests called it, migrate those to DocumentContentOperationsManager::InsertGraphic() instead, which is what SwFEShell::Insert() and SwXFrame::attachToRange() use. Change-Id: Ie05b501507f8722bc0a312c2e729ecd76154ce98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143836 Tested-by: Jenkins Reviewed-by: Miklos Vajna diff --git a/sw/inc/IDocumentContentOperations.hxx b/sw/inc/IDocumentContentOperations.hxx index 5a95d0ba95b8..3294e9869b4c 100644 --- a/sw/inc/IDocumentContentOperations.hxx +++ b/sw/inc/IDocumentContentOperations.hxx @@ -186,11 +186,6 @@ public: const SfxItemSet* pFlyAttrSet, const SfxItemSet* pGrfAttrSet, SwFrameFormat*) = 0; -virtual SwFlyFrameFormat* InsertGraphicObject( -const SwPaM& rRg, const GraphicObject& rGrfObj, -const SfxItemSet* pFlyAttrSet, -const SfxItemSet* pGrfAttrSet) = 0; - /** Transpose graphic (with undo) */ virtual void ReRead(SwPaM&, const OUString& rGrfName, const OUString& rFltName, const Graphic* pGraphic) = 0; diff --git a/sw/qa/core/layout/layout.cxx b/sw/qa/core/layout/layout.cxx index 8479a3a075aa..f95cfcf09bc9 100644 --- a/sw/qa/core/layout/layout.cxx +++ b/sw/qa/core/layout/layout.cxx @@ -865,8 +865,9 @@ CPPUNIT_TEST_FIXTURE(SwCoreLayoutTest, testFollowTextFlowWrapInBackground) aFrameSet.Put(aSize); SwFormatFollowTextFlow aFlow(true); aFrameSet.Put(aFlow); -GraphicObject aGrf; -rIDCO.InsertGraphicObject(*pWrtShell->GetCursor(), aGrf, , ); +Graphic aGrf; +rIDCO.InsertGraphic(*pWrtShell->GetCursor(), OUString(), OUString(), , , +, nullptr); // When laying out that document: calcLayout(); diff --git a/sw/qa/extras/uiwriter/uiwriter7.cxx b/sw/qa/extras/uiwriter/uiwriter7.cxx index 8c14e7184f44..f04c802ea3b0 100644 --- a/sw/qa/extras/uiwriter/uiwriter7.cxx +++ b/sw/qa/extras/uiwriter/uiwriter7.cxx @@ -1830,11 +1830,13 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest7, testUndoDelAsCharTdf107512) pShell->ClearMark(); SwFormatAnchor anchor(RndStdIds::FLY_AS_CHAR); frameSet.Put(anchor); -GraphicObject grf; +Graphic grf; pShell->SttEndDoc(true); -CPPUNIT_ASSERT(rIDCO.InsertGraphicObject(*pShell->GetCursor(), grf, , )); +CPPUNIT_ASSERT(rIDCO.InsertGraphic(*pShell->GetCursor(), OUString(), OUString(), , + , , nullptr)); pShell->SttEndDoc(false); -CPPUNIT_ASSERT(rIDCO.InsertGraphicObject(*pShell->GetCursor(), grf, , )); +CPPUNIT_ASSERT(rIDCO.InsertGraphic(*pShell->GetCursor(), OUString(), OUString(), , + , , nullptr)); CPPUNIT_ASSERT_EQUAL(size_t(2), pDoc->GetFlyCount(FLYCNTTYPE_GRF)); SvxCharHiddenItem hidden(true, RES_CHRATR_HIDDEN); pShell->SelectTextModel(1, 4); @@ -2017,8 +2019,9 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest7, testUndoDelAsChar) SfxItemSet grfSet(pDoc->GetAttrPool(), svl::Items); SwFormatAnchor anchor(RndStdIds::FLY_AS_CHAR); frameSet.Put(anchor); -GraphicObject grf; -CPPUNIT_ASSERT(rIDCO.InsertGraphicObject(*pShell->GetCursor(), grf, , )); +Graphic grf; +CPPUNIT_ASSERT(rIDCO.InsertGraphic(*pShell->GetCursor(), OUString(), OUString(), , + , , nullptr)); CPPUNIT_ASSERT_EQUAL(size_t(1), pDoc->GetFlyCount(FLYCNTTYPE_GRF)); pShell->SetMark(); pShell->Left(1, SwCursorSkipMode::Chars); diff --git a/sw/qa/extras/unowriter/unowriter.cxx b/sw/qa/extras/unowriter/unowriter.cxx index 14ffc152d921..61b9b524b399 100644 --- a/sw/qa/extras/unowriter/unowriter.cxx +++ b/sw/qa/extras/unowriter/unowriter.cxx @@ -695,8 +695,9 @@ CPPUNIT_TEST_FIXTURE(SwUnoWriter, testDeleteFlyAtCharAtStart) SfxItemSet grfSet(pDoc->GetAttrPool(), svl::Items); SwFormatAnchor anchor(RndStdIds::FLY_AT_CHAR); frameSet.Put(anchor); -GraphicObject grf; -CPPUNIT_ASSERT(rIDCO.InsertGraphicObject(*pWrtShell->GetCursor(), grf, , )); +Graphic grf; +CPPUNIT_ASSERT(rIDCO.InsertGraphic(*pWrtShell->GetCursor(), OUString(), OUString(), , +
[Libreoffice-commits] core.git: vcl/osx
vcl/osx/salframeview.mm |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 24eabdbebcbc3b9189bbb9809205ead9f903a0cb Author: Andrea Gelmini AuthorDate: Thu Dec 8 22:50:57 2022 +0100 Commit: Julien Nabet CommitDate: Fri Dec 9 07:00:06 2022 + Fix typo Change-Id: Iaa550d83da5823fe52c25afb8e403c998ce68b3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143842 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/vcl/osx/salframeview.mm b/vcl/osx/salframeview.mm index 289f74aad3c6..e6fda362f927 100644 --- a/vcl/osx/salframeview.mm +++ b/vcl/osx/salframeview.mm @@ -1614,7 +1614,7 @@ static AquaSalFrame* getMouseContainerFrame() else mSelectedRange = NSMakeRange( selRange.location, selRange.location + selRange.length > mMarkedRange.length ? mMarkedRange.length - selRange.location : selRange.length ); -// If we are going to post uncommitted text, cache the string paramater +// If we are going to post uncommitted text, cache the string parameter // as is needed in both [self endExtTextInput] and // [self attributedSubstringForProposedRange:actualRange:] mpLastMarkedText = [aString retain];
[Libreoffice-bugs] [Bug 152429] Enhancement: Allow BASE to access multiple external data sources
https://bugs.documentfoundation.org/show_bug.cgi?id=152429 Robert Großkopf changed: What|Removed |Added CC||rob...@familiegrosskopf.de --- Comment #1 from Robert Großkopf --- Do you know you could connect to *.csv-tables directly with internal HSQLDB? https://books.libreoffice.org/en/BG73/BG7302-CreatingADatabase.html#toc72 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152029] Visually draw attention to in-view bookmark or hyperlink when selecting/hovering it in the Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=152029 --- Comment #30 from Commit Notification --- Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/11b87e7601fd24eb290854e9642bf01d0b4592ff tdf#152029 Bring drawing objects to attention in the document view It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/inc/conttree.hxx |1
sw/source/uibase/utlui/content.cxx | 97 ++---
2 files changed, 71 insertions(+), 27 deletions(-)
New commits:
commit 11b87e7601fd24eb290854e9642bf01d0b4592ff
Author: Jim Raykowski
AuthorDate: Thu Dec 8 18:58:59 2022 -0900
Commit: Jim Raykowski
CommitDate: Fri Dec 9 06:40:30 2022 +
tdf#152029 Bring drawing objects to attention in the document view
when mouse pointer is over drawing object entry in the Navigator
content tree
Change-Id: Idfeeb3854ffe76745f2f30a6ffac8528b2dda725
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143844
Reviewed-by: Noel Grandin
Tested-by: Jenkins
diff --git a/sw/source/uibase/inc/conttree.hxx
b/sw/source/uibase/inc/conttree.hxx
index 03f331c2584f..5a9ef1a9322e 100644
--- a/sw/source/uibase/inc/conttree.hxx
+++ b/sw/source/uibase/inc/conttree.hxx
@@ -141,6 +141,7 @@ class SwContentTree final : public SfxListener
void BringBookmarksToAttention(const std::vector& rNames);
void BringURLFieldsToAttention(const SwGetINetAttrs& rINetAttrsArr);
void BringReferencesToAttention(std::vector&
rTextAttrsArr);
+void BringDrawingObjectsToAttention(std::vector&
rDrawingObjectsArr);
void BringTextFieldsToAttention(std::vector&
rTextAttrsArr);
/**
diff --git a/sw/source/uibase/utlui/content.cxx
b/sw/source/uibase/utlui/content.cxx
index 1033c63c84e3..dbed1715e32d 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -1152,26 +1152,35 @@ IMPL_LINK(SwContentTree, MouseMoveHdl, const
MouseEvent&, rMEvt, bool)
// initialize the compare entry iterator with the first tree entry iterator
if (!m_xOverlayCompareEntry &&
!m_xTreeView->get_iter_first(*m_xOverlayCompareEntry))
return false;
-bool bRemoveOverlayObject = false;
if (rMEvt.IsLeaveWindow())
{
-bRemoveOverlayObject = true;
+m_aOverlayObjectDelayTimer.Stop();
+if (m_xOverlayObject && m_xOverlayObject->getOverlayManager())
+{
+m_xOverlayObject->getOverlayManager()->remove(*m_xOverlayObject);
+m_xOverlayObject.reset();
+}
}
else if (std::unique_ptr
xEntry(m_xTreeView->make_iterator());
m_xTreeView->get_dest_row_at_pos(rMEvt.GetPosPixel(),
xEntry.get(), false, false))
{
+// Remove the overlay object if the pointer is over a different entry
than the last time
+// it was here.
+if (m_xTreeView->iter_compare(*xEntry, *m_xOverlayCompareEntry) != 0)
+{
+m_aOverlayObjectDelayTimer.Stop();
+if (m_xOverlayObject && m_xOverlayObject->getOverlayManager())
+{
+
m_xOverlayObject->getOverlayManager()->remove(*m_xOverlayObject);
+m_xOverlayObject.reset();
+}
+}
if (lcl_IsContent(*xEntry, *m_xTreeView)) // content entry
{
SwContent* pCnt =
weld::fromId(m_xTreeView->get_id(*xEntry));
const ContentTypeId nType = pCnt->GetParent()->GetType();
-bRemoveOverlayObject =
-nType != ContentTypeId::OUTLINE && nType !=
ContentTypeId::TABLE &&
-nType != ContentTypeId::FRAME && nType !=
ContentTypeId::GRAPHIC &&
-nType != ContentTypeId::OLE && nType !=
ContentTypeId::BOOKMARK &&
-nType != ContentTypeId::URLFIELD && nType !=
ContentTypeId::REFERENCE &&
-nType != ContentTypeId::TEXTFIELD;
-if (!bRemoveOverlayObject && (rMEvt.IsEnterWindow() ||
-m_xTreeView->iter_compare(*xEntry,
*m_xOverlayCompareEntry) != 0))
+if (rMEvt.IsEnterWindow() ||
+m_xTreeView->iter_compare(*xEntry,
*m_xOverlayCompareEntry) != 0)
{
if (nType == ContentTypeId::OUTLINE)
{
@@ -1218,6 +1227,14 @@ IMPL_LINK(SwContentTree, MouseMoveHdl, const
MouseEvent&, rMEvt, bool)
BringReferencesToAttention(aTextAttrArr);
}
}
+else if (nType == ContentTypeId::DRAWOBJECT)
+{
+if (!pCnt->IsInvisible())
+{
+std::vector aSdrObjectArr
{GetDrawingObjectsByContent(pCnt)};
+BringDrawingObjectsToAttention(aSdrObjectArr);
+}
+}
else if (nType == ContentTypeId::TEXTFIELD)
{
if (const SwTextAttr* pTextAttr =
@@ -1233,14 +1250,8 @@ IMPL_LINK(SwContentTree, MouseMoveHdl, const
MouseEvent&, rMEvt, bool)
{
const ContentTypeId nType =
weld::fromId(m_xTreeView->get_id(*xEntry))->GetType();
-bRemoveOverlayObject =
-nType != ContentTypeId::OUTLINE && nType !=
[Libreoffice-bugs] [Bug 152433] New: wrong cross-reference
https://bugs.documentfoundation.org/show_bug.cgi?id=152433 Bug ID: 152433 Summary: wrong cross-reference Product: LibreOffice Version: 7.1.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: geleti...@yandex.ru Description: When I try to use cross-reference using list with numbers (bulleted list), I want to receive from program only number. But program gives me long word: "_RefNumPara_428-2744482666" Actual Results: - Expected Results: - Reproducible: Always User Profile Reset: No Additional Info: Please help me to solve this problem -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - basic/CppunitTest_basic_macros.mk basic/qa basic/source
basic/CppunitTest_basic_macros.mk |1
basic/qa/cppunit/test_global_as_new.cxx | 86
basic/source/comp/dim.cxx | 27 ++
basic/source/inc/runtime.hxx|1
basic/source/runtime/runtime.cxx| 34 ++--
5 files changed, 143 insertions(+), 6 deletions(-)
New commits:
commit e3d413f46c4b4c8a044ef487711be961fbcdbc6f
Author: John
AuthorDate: Thu Mar 4 01:50:25 2021 -0500
Commit: Mike Kaganski
CommitDate: Fri Dec 9 05:35:32 2022 +
tdf#88442 SBasic: Don't double-initialize a Global ... As New ...
"As New" variables use lazy instantiation, but that should not re-apply each
time one re-enters the module. If the object is still there, don't replace
it.
Change-Id: Ic568a56b93db9bc9139d434d97a4a4deb05840df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112018
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
(cherry picked from commit b80069e133d30e80e50a792b2bc1d0c2f9a31bfa)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143843
Tested-by: Jenkins CollaboraOffice
diff --git a/basic/CppunitTest_basic_macros.mk
b/basic/CppunitTest_basic_macros.mk
index 6cce94737113..c2c1eb5b7a04 100644
--- a/basic/CppunitTest_basic_macros.mk
+++ b/basic/CppunitTest_basic_macros.mk
@@ -19,6 +19,7 @@ $(eval $(call
gb_CppunitTest_add_exception_objects,basic_macros, \
basic/qa/cppunit/test_language_conditionals \
basic/qa/cppunit/test_nested_struct \
basic/qa/cppunit/test_vba \
+ basic/qa/cppunit/test_global_as_new \
))
$(eval $(call gb_CppunitTest_use_libraries,basic_macros, \
diff --git a/basic/qa/cppunit/test_global_as_new.cxx
b/basic/qa/cppunit/test_global_as_new.cxx
new file mode 100644
index ..db64a974cb0f
--- /dev/null
+++ b/basic/qa/cppunit/test_global_as_new.cxx
@@ -0,0 +1,86 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4;
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+namespace
+{
+class GlobalAsNewTest : public CppUnit::TestFixture
+{
+void testMaintainsValueAcrossCalls();
+
+CPPUNIT_TEST_SUITE(GlobalAsNewTest);
+CPPUNIT_TEST(testMaintainsValueAcrossCalls);
+CPPUNIT_TEST_SUITE_END();
+
+BasicDLL lib;
+StarBASICRef interpreter;
+
+SbModuleRef Module()
+{
+interpreter = new StarBASIC();
+auto mod = interpreter->MakeModule("GlobalAsNew", R"BAS(
+Global aDate As New "com.sun.star.util.Date"
+
+Function GetDateAsString As String
+DIM local_Date As New "com.sun.star.util.Date"
+GetDateAsString = TRIM(STR(aDate.Year)) + "-" + TRIM(STR(local_Date.Year))
+ TRIM(STR(aDate.Month)) + "-" + TRIM(STR(aDate.Day))
+End Function
+
+Function SetDate
+ aDate.Month = 6
+ aDate.Day = 30
+ aDate.Year = 2019
+ SetDate = GetDateAsString()
+End Function
+
+)BAS");
+CPPUNIT_ASSERT(mod->Compile());
+CPPUNIT_ASSERT_EQUAL(StarBASIC::GetErrBasic(), ERRCODE_NONE);
+CPPUNIT_ASSERT_EQUAL(SbxBase::GetError(), ERRCODE_NONE);
+CPPUNIT_ASSERT(mod->IsCompiled());
+return mod;
+}
+};
+
+void GlobalAsNewTest::testMaintainsValueAcrossCalls()
+{
+auto m = Module();
+auto GetDateAsString = m->FindMethod("GetDateAsString",
SbxClassType::Method);
+CPPUNIT_ASSERT_MESSAGE("Could not Find GetDateAsString in module",
GetDateAsString != nullptr);
+
+// There is no SbxMethod::call(), the basic code is exercised here in the
copy ctor
+SbxVariableRef returned = new SbxMethod{ *GetDateAsString };
+CPPUNIT_ASSERT(returned->IsString());
+//0-00-0 is the result of reading the default-initialized date
+CPPUNIT_ASSERT_EQUAL(OUString{ "0-00-0" }, returned->GetOUString());
+
+auto SetDate = m->FindMethod("SetDate", SbxClassType::Method);
+CPPUNIT_ASSERT_MESSAGE("Could not Find SetDate in module", SetDate !=
nullptr);
+returned = new SbxMethod{ *SetDate };
+CPPUNIT_ASSERT(returned->IsString());
+OUString set_val("2019-06-30");
+CPPUNIT_ASSERT_EQUAL(set_val, returned->GetOUString());
+
+returned = new SbxMethod{ *GetDateAsString };
+CPPUNIT_ASSERT(returned->IsString());
+//tdf#88442 The global should have maintained its state!
+CPPUNIT_ASSERT_EQUAL(set_val, returned->GetOUString());
+}
+
+// Put the test suite in the registry
+CPPUNIT_TEST_SUITE_REGISTRATION(GlobalAsNewTest);
+
+} // namespace
diff --git a/basic/source/comp/dim.cxx b/basic/source/comp/dim.cxx
index 17eef0a263a5..aea0f8a3901e 100644
--- a/basic/source/comp/dim.cxx
+++ b/basic/source/comp/dim.cxx
@@ -441,12 +441,39 @@ void SbiParser::DefVar( SbiOpcode eOp, bool
[Libreoffice-bugs] [Bug 152431] Line count resets to zero after 65535
https://bugs.documentfoundation.org/show_bug.cgi?id=152431 BogdanB changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |buzea.bog...@libreoffice.or |desktop.org |g -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152431] Line count resets to zero after 65535
https://bugs.documentfoundation.org/show_bug.cgi?id=152431 BogdanB changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from BogdanB --- Confirm with Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 95a3d7733c5b48c99b2b74b06c7718fdcd03 CPU threads: 4; OS: Linux 5.19; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded It's reseting to zero after the 65535 line. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 127232] [META] QR/barcode generator's problems and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=127232 Bug 127232 depends on bug 145358, which changed state. Bug 145358 Summary: Dynamic QR / Barcode creation using spreadsheet cell reference https://bugs.documentfoundation.org/show_bug.cgi?id=145358 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138856] Allow for input to QR-Code Generator by reference to another object
https://bugs.documentfoundation.org/show_bug.cgi?id=138856 Heiko Tietze changed: What|Removed |Added CC||pharman...@gmail.com --- Comment #5 from Heiko Tietze --- *** Bug 145358 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145358] Dynamic QR / Barcode creation using spreadsheet cell reference
https://bugs.documentfoundation.org/show_bug.cgi?id=145358 Heiko Tietze changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #8 from Heiko Tietze --- Thanks for reporting, pharmankur. Please add important aspects to the duplicate bug and follow the progress there. *** This bug has been marked as a duplicate of bug 138856 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138856] Allow for input to QR-Code Generator by reference to another object
https://bugs.documentfoundation.org/show_bug.cgi?id=138856 Heiko Tietze changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138856] Allow for input to QR-Code Generator by reference to another object
https://bugs.documentfoundation.org/show_bug.cgi?id=138856 Heiko Tietze changed: What|Removed |Added CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org, ||samuel.mehrbrodt@allotropia ||.de Keywords|needsUXEval | --- Comment #4 from Heiko Tietze --- Commented on bug 145358 that adding a formula might not work on round-trip operations and is not (yet) defined by OASIS. Nevertheless such a feature is desirable and I'd go with =barcode(reference, type = <>). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 138856] Allow for input to QR-Code Generator by reference to another object
https://bugs.documentfoundation.org/show_bug.cgi?id=138856 Heiko Tietze changed: What|Removed |Added CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org, ||samuel.mehrbrodt@allotropia ||.de Keywords|needsUXEval | --- Comment #4 from Heiko Tietze --- Commented on bug 145358 that adding a formula might not work on round-trip operations and is not (yet) defined by OASIS. Nevertheless such a feature is desirable and I'd go with =barcode(reference, type = <>). -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 149035] Falla de filtro hoja de calculo
https://bugs.documentfoundation.org/show_bug.cgi?id=149035 --- Comment #3 from QA Administrators --- Dear Sergio Bautista, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142491] sometimes quotes are attached to an URL in a cell
https://bugs.documentfoundation.org/show_bug.cgi?id=142491 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142379] Incorrect shape scaling silhouette
https://bugs.documentfoundation.org/show_bug.cgi?id=142379 --- Comment #5 from QA Administrators --- Dear Jonatán Perren, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142379] Incorrect shape scaling silhouette
https://bugs.documentfoundation.org/show_bug.cgi?id=142379 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142491] sometimes quotes are attached to an URL in a cell
https://bugs.documentfoundation.org/show_bug.cgi?id=142491 --- Comment #5 from QA Administrators --- Dear Thilo Pfennig, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141899] Fail selection on the text
https://bugs.documentfoundation.org/show_bug.cgi?id=141899 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141899] Fail selection on the text
https://bugs.documentfoundation.org/show_bug.cgi?id=141899 --- Comment #5 from QA Administrators --- Dear rmbeer, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139402] FORMATTING: Default font color for form controls is set to black but displays as gray
https://bugs.documentfoundation.org/show_bug.cgi?id=139402 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139402] FORMATTING: Default font color for form controls is set to black but displays as gray
https://bugs.documentfoundation.org/show_bug.cgi?id=139402 --- Comment #5 from QA Administrators --- Dear Mark Jones, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 95647] Cropping of TIFFs in Draw/Impress are being scaled
https://bugs.documentfoundation.org/show_bug.cgi?id=95647 --- Comment #8 from QA Administrators --- Dear Larry, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149377] VBA Calc does not paste, pastes only empty cells
https://bugs.documentfoundation.org/show_bug.cgi?id=149377 --- Comment #4 from QA Administrators --- Dear ofthecentury, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149520] Reload of current LibreOffice failed to download.
https://bugs.documentfoundation.org/show_bug.cgi?id=149520 --- Comment #2 from QA Administrators --- Dear Marc Vessells, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149111] Crash when attempting to add MP4 file to Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=149111 --- Comment #5 from QA Administrators --- Dear Applejack01, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149515] In calc, figures on secondary y-axis cannot be formatted in style and size
https://bugs.documentfoundation.org/show_bug.cgi?id=149515 --- Comment #2 from QA Administrators --- Dear phermes, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149326] Libra Office Writer Hangs When I Click On File Then Scroll Past "Open Remote"
https://bugs.documentfoundation.org/show_bug.cgi?id=149326 --- Comment #2 from QA Administrators --- Dear Jeff, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112250] empty values in y-axis of empty chart
https://bugs.documentfoundation.org/show_bug.cgi?id=112250 --- Comment #18 from QA Administrators --- Dear Marc Oggier, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138553] When I write formula, I can't see the selected cells
https://bugs.documentfoundation.org/show_bug.cgi?id=138553 --- Comment #2 from QA Administrators --- Dear Martin Srdoš, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137633] Drag handle not shown for textbox in DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=137633 --- Comment #6 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131309] Validity>Custom>Formula does not have the expected effect without additional measures - evaluation of entered formula only happens after additional trigger
https://bugs.documentfoundation.org/show_bug.cgi?id=131309 --- Comment #7 from QA Administrators --- Dear Wolfgang Jäger, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133300] Please add the ability to search for Page Styles
https://bugs.documentfoundation.org/show_bug.cgi?id=133300 --- Comment #23 from QA Administrators --- Dear Luke Kendall, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 121130] markers.png generated from markers.svg is 118x93 instead of 117x92 and therefore markers don't fit
https://bugs.documentfoundation.org/show_bug.cgi?id=121130 --- Comment #9 from QA Administrators --- Dear Regina Henschel, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152432] File > Recent Recordings displays empty list when saving document
https://bugs.documentfoundation.org/show_bug.cgi?id=152432 --- Comment #2 from Mark C --- Created attachment 184060 --> https://bugs.documentfoundation.org/attachment.cgi?id=184060=edit screen snapshot showing the "recent documents" list is NOT empty (step 5) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152432] File > Recent Recordings displays empty list when saving document
https://bugs.documentfoundation.org/show_bug.cgi?id=152432 --- Comment #1 from Mark C --- Created attachment 184059 --> https://bugs.documentfoundation.org/attachment.cgi?id=184059=edit screen snapshot showing the "recent documents" list is empty -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152432] New: File > Recent Recordings displays empty list when saving document
https://bugs.documentfoundation.org/show_bug.cgi?id=152432 Bug ID: 152432 Summary: File > Recent Recordings displays empty list when saving document Product: LibreOffice Version: 7.4.3.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: minor Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: anicest...@gmail.com Description: This is 100% reproducible. It is more an annoyance than a major problem. I use Calc all the time so this is done with calc. How to reproduce: 1. Save your document. 2. While the saving is in progress, select File > Recent Documents. 3. You will see an empty list. 4. Wait for the save to complete. 5. Now go to File > Recent Documents -- you will see the expected list! screenshots are attached. Version: 7.4.3.2 / LibreOffice Community Build ID: 8d7af0b9f05ca3f6bf3593323f061d3291e2ce28 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-CA (en_CA.UTF-8); UI: en-US Calc: threaded Steps to Reproduce: 1. Save your document. 2. While the saving is in progress, select File > Recent Documents. 3. You will see an empty list. 4. Wait for the save to complete. 5. Now go to File > Recent Documents -- you will see the expected list! Actual Results: you see a Recent Documents list that is empty Expected Results: if you wait, you see a populated list... Reproducible: Always User Profile Reset: No Additional Info: I see I have to add attachment after I submit the bug report, so I will do that. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 126949] Data labels loses format unexpectedly
https://bugs.documentfoundation.org/show_bug.cgi?id=126949 --- Comment #6 from Mark C --- Confirmed that this is now WORKING as expected on this version: Version: 7.4.3.2 / LibreOffice Community Build ID: 8d7af0b9f05ca3f6bf3593323f061d3291e2ce28 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-CA (en_CA.UTF-8); UI: en-US Calc: threaded Thank you for fixing this bug. It was a real pain to me. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152431] New: Line count resets to zero after 65535
https://bugs.documentfoundation.org/show_bug.cgi?id=152431
Bug ID: 152431
Summary: Line count resets to zero after 65535
Product: LibreOffice
Version: 7.5.0.0 alpha0+ Master
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: Writer
Assignee: libreoffice-bugs@lists.freedesktop.org
Reporter: hoss...@libreoffice.org
Created attachment 184058
--> https://bugs.documentfoundation.org/attachment.cgi?id=184058=edit
Text file with 65535 non-blank lines
Description:
In LibreOffice Writer document statistics, the line number can not exceed 65535
and it resets to zero after that. This shows the usage of 16 bit unsigned
integer for the line count.
Steps to Reproduce:
1. Create a file containing 65535 non-blank lines. For example:
for i in {1..65535}; do echo .; done > lines.txt
Alternatively, you can download and use the attachment (lines.txt) from this
issue.
2. Open the file
3. Go to File > Properties > Statistics and click Update. See 65535 in the
lines.
4. Add a new non-blank line.
3. Count the statistics again, just like step 3.
Actual Results:
The line count is shown as 0.
Expected Results:
The line count should be 65536. Using a 32 bit unsigend integer can increase
the limit to 2^32-1=4,294,967,295 (~4.3 billion) which is much better, and is a
good practical limit.
Reproducible: Always
User Profile Reset: No
Additional Info:
Reproducible with the latst LO 7.5 dev master:
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 95a3d7733c5b48c99b2b74b06c7718fdcd03
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-commits] core.git: 2 commits - include/xmloff sd/qa sw/source xmloff/source
include/xmloff/table/XMLTableImport.hxx |3 -
sd/qa/unit/misc-tests.cxx | 52 ++
sw/source/filter/xml/xmlfmt.cxx |2
xmloff/source/table/XMLTableExport.cxx |4 -
xmloff/source/table/XMLTableImport.cxx | 92
5 files changed, 70 insertions(+), 83 deletions(-)
New commits:
commit 95a3d7733c5b48c99b2b74b06c7718fdcd03
Author: Maxim Monastirsky
AuthorDate: Thu Dec 8 14:07:36 2022 +0200
Commit: Maxim Monastirsky
CommitDate: Fri Dec 9 00:13:42 2022 +
Deduplicate table styles insertion
(Not adding a test here, as this should already be covered
by several tests in sw/qa/extras/odfexport/odfexport.cxx.)
Change-Id: Ic3cae9f38efc55d3d9055a45bc642d7b15fa382a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143840
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky
diff --git a/include/xmloff/table/XMLTableImport.hxx
b/include/xmloff/table/XMLTableImport.hxx
index 0889637f2e23..3577ed8adedf 100644
--- a/include/xmloff/table/XMLTableImport.hxx
+++ b/include/xmloff/table/XMLTableImport.hxx
@@ -58,13 +58,12 @@ public:
const rtl::Reference< SvXMLImportPropertyMapper >&
GetColumnImportPropertySetMapper() const { return
mxColumnImportPropertySetMapper; }
void addTableTemplate( const OUString& rsStyleName, XMLTableTemplate&
xTableTemplate );
-/// Inserts to the doc template with given name.
-void insertTabletemplate( const OUString& rsStyleName, bool bOverwrite);
/// Inserts all table templates.
void finishStyles();
private:
SvXMLImport& mrImport;
+boolmbWriter;
rtl::Reference< SvXMLImportPropertyMapper > mxCellImportPropertySetMapper;
rtl::Reference< SvXMLImportPropertyMapper > mxRowImportPropertySetMapper;
rtl::Reference< SvXMLImportPropertyMapper >
mxColumnImportPropertySetMapper;
diff --git a/sw/source/filter/xml/xmlfmt.cxx b/sw/source/filter/xml/xmlfmt.cxx
index 8d21591e12b9..9bd4d2a5f41b 100644
--- a/sw/source/filter/xml/xmlfmt.cxx
+++ b/sw/source/filter/xml/xmlfmt.cxx
@@ -919,6 +919,8 @@ OUString SwXMLStylesContext_Impl::GetServiceName(
XmlStyleFamily nFamily ) const
void SwXMLStylesContext_Impl::endFastElement(sal_Int32 )
{
GetSwImport().InsertStyles( IsAutomaticStyle() );
+if (!IsAutomaticStyle())
+GetImport().GetShapeImport()->GetShapeTableImport()->finishStyles();
}
namespace {
diff --git a/xmloff/source/table/XMLTableImport.cxx
b/xmloff/source/table/XMLTableImport.cxx
index 65b6be09d2ff..40899a4fda84 100644
--- a/xmloff/source/table/XMLTableImport.cxx
+++ b/xmloff/source/table/XMLTableImport.cxx
@@ -206,7 +206,6 @@ public:
virtual void SAL_CALL endFastElement(sal_Int32 nElement) override;
-virtual void CreateAndInsert( bool bOverwrite ) override;
protected:
virtual void SetAttribute( sal_Int32 nElement,
const OUString& rValue ) override;
@@ -234,21 +233,21 @@ css::uno::Reference< css::xml::sax::XFastContextHandler >
XMLProxyContext::creat
XMLTableImport::XMLTableImport( SvXMLImport& rImport, const rtl::Reference<
XMLPropertySetMapper >& xCellPropertySetMapper, const rtl::Reference<
XMLPropertyHandlerFactory >& xFactoryRef )
: mrImport( rImport )
+, mbWriter( false )
{
-bool bWriter = false;
// check if called by Writer
Reference xFac(rImport.GetModel(), UNO_QUERY);
if (xFac.is()) try
{
Sequence sSNS = xFac->getAvailableServiceNames();
-bWriter = comphelper::findValue(sSNS, "com.sun.star.style.TableStyle")
!= -1;
+mbWriter = comphelper::findValue(sSNS,
"com.sun.star.style.TableStyle") != -1;
}
catch(const Exception&)
{
SAL_WARN("xmloff.table", "Error while checking available service
names");
}
-if (bWriter)
+if (mbWriter)
{
mxCellImportPropertySetMapper =
XMLTextImportHelper::CreateTableCellExtPropMapper(rImport);
}
@@ -288,69 +287,6 @@ void XMLTableImport::addTableTemplate( const OUString&
rsStyleName, XMLTableTemp
maTableTemplates.emplace_back(rsStyleName, xPtr);
}
-void XMLTableImport::insertTabletemplate(const OUString& rsStyleName, bool
bOverwrite)
-{
-// FIXME: All templates will be inserted eventually, but
-// instead of simply iterating them, like in finishStyles(),
-// we search here by name again and again.
-auto it = std::find_if(maTableTemplates.begin(), maTableTemplates.end(),
-[](const auto& item) { return rsStyleName == item.first;
});
-if (it == maTableTemplates.end())
-return;
-
-try
-{
-Reference xFamiliesSupp(mrImport.GetModel(),
UNO_QUERY_THROW);
-Reference xFamilies(xFamiliesSupp->getStyleFamilies());
-
-Reference
xTableFamily(xFamilies->getByName("TableStyles"), UNO_QUERY_THROW);
-Reference
[Libreoffice-bugs] [Bug 151700] "Print to file" doesn't work on OSX 12.6
https://bugs.documentfoundation.org/show_bug.cgi?id=151700 Patrick Luby changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |plub...@neooffice.org |desktop.org | Ever confirmed|0 |1 Status|UNCONFIRMED |ASSIGNED --- Comment #17 from Patrick Luby --- There is a workaround: install a printer driver that prints to PDF. One that I have used is a free, open source print driver called RWTS-PDFwriter. A fake printer is really useful when you want to save PDFs in Adobe Acrobat Reader to PDFs that are viewable in the Preview application through Adobe's non-native print dialog. You can download the installer (download the "RWTS-PDFwriter.pkg" file) from the following link: https://github.com/rodyager/RWTS-PDFwriter/releases/tag/v2.0 As for fixing the problem: I have posted the following patch that forces LibreOffice to display the macOS native print dialog even if there are no printers setup on your machine. The patch still needs some tweaking and then review but there is a fix in the works: https://gerrit.libreoffice.org/c/core/+/143794 -- You are receiving this mail because: You are the assignee for the bug.
What's the license of external library？
What license is applied to *.patch* files in the external/[library name] directory? 1. the MPLv2 2. the license of each library (including MPLv2)
[Libreoffice-bugs] [Bug 151748] Bad Horizontal lines (kashida) in Arabic/Persian text inside a text box
https://bugs.documentfoundation.org/show_bug.cgi?id=151748 --- Comment #12 from Hossein --- (In reply to خالد حسني from comment #11) > If some one is looking for code pointers, look for GetMinKashida() use under > sw/, and try to locate the corresponding code under editeng/ and make it do > something similar with GetMinKashida(). I am certainly interested in fix this issue. :-) It seems to be this part of the code: https://opengrok.libreoffice.org/xref/core/editeng/source/editeng/impedit3.cxx?r=f9395a12#2270 Commenting 10 lines from 2272 to 2281 out removes the kashida completely. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 132293] Run pyflakes on python uitest files to find unused imports
https://bugs.documentfoundation.org/show_bug.cgi?id=132293 --- Comment #25 from Commit Notification --- Bogdan B committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/15e94efb87118b0ceb4aa926181a8906259f369b tdf#132293 remove unused imports from uitest It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sd/qa
sd/qa/uitest/findReplace/findReplace.py |5 + 1 file changed, 1 insertion(+), 4 deletions(-) New commits: commit 15e94efb87118b0ceb4aa926181a8906259f369b Author: Bogdan B AuthorDate: Fri Nov 11 20:08:01 2022 +0200 Commit: Hossein CommitDate: Thu Dec 8 22:55:49 2022 + tdf#132293 remove unused imports from uitest Change-Id: I6f5b5d97dab27986a6b0046c42c20ec4d0527980 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142531 Tested-by: Jenkins Reviewed-by: Hossein diff --git a/sd/qa/uitest/findReplace/findReplace.py b/sd/qa/uitest/findReplace/findReplace.py index 0e4bd4c12f73..130765a865bb 100644 --- a/sd/qa/uitest/findReplace/findReplace.py +++ b/sd/qa/uitest/findReplace/findReplace.py @@ -7,11 +7,8 @@ # file, You can obtain one at http://mozilla.org/MPL/2.0/. # from uitest.framework import UITestCase -from uitest.uihelper.common import select_pos -from uitest.uihelper.calc import enter_text_to_cell -from libreoffice.calc.document import get_cell_by_position from libreoffice.uno.propertyvalue import mkPropertyValues -from uitest.uihelper.common import get_state_as_dict, get_url_for_data_file, type_text +from uitest.uihelper.common import get_state_as_dict, get_url_for_data_file class findReplace(UITestCase): def test_find_impress(self):
[Libreoffice-bugs] [Bug 114441] Convert use of sal_uLong to better integer types
https://bugs.documentfoundation.org/show_bug.cgi?id=114441 --- Comment #52 from Commit Notification --- Nalini Prasad Dash committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/855bf4d68865ef046c8f527bf19e3ec78c7b033a tdf#114441 - Convert use of sal_uLong to better integer types It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: cui/source forms/source
cui/source/tabpages/swpossizetabpage.cxx |3 ++-
forms/source/richtext/rtattributehandler.cxx |4 ++--
2 files changed, 4 insertions(+), 3 deletions(-)
New commits:
commit 855bf4d68865ef046c8f527bf19e3ec78c7b033a
Author: Nalini Prasad Dash
AuthorDate: Wed Nov 23 17:09:55 2022 +0530
Commit: Stephan Bergmann
CommitDate: Thu Dec 8 22:44:38 2022 +
tdf#114441 - Convert use of sal_uLong to better integer types
The variable type of nHeight was changed as the return type of
pFontHeightItem->GetHeight() is sal_uInt32.Also nBit was assigned
the underlying datatype of LB(int) as it was checked against
LB::LAST(Value converted to underlying datatype of LB) in the for loop .
Change-Id: I657d545ac7af1786edd61569ba43b42e55d1f47b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143145
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/cui/source/tabpages/swpossizetabpage.cxx
b/cui/source/tabpages/swpossizetabpage.cxx
index e8a1e4eb9df4..060f7b44ce9f 100644
--- a/cui/source/tabpages/swpossizetabpage.cxx
+++ b/cui/source/tabpages/swpossizetabpage.cxx
@@ -19,6 +19,7 @@
#include
#include
+#include
#include
#include
#include
@@ -1696,7 +1697,7 @@ void SvxSwPosSizeTabPage::FillRelLB(FrmMap const *pMap,
sal_uInt16 nMapPos, sal_
nLBRelations = pMap[nMapPos].nLBRelations;
}
-for (sal_uLong nBit = 1; nBit < sal_uLong(LB::LAST); nBit <<= 1)
+for (std::underlying_type_t nBit = 1; nBit <
o3tl::to_underlying(LB::LAST) ; nBit <<= 1)
{
if (nLBRelations & static_cast(nBit))
{
diff --git a/forms/source/richtext/rtattributehandler.cxx
b/forms/source/richtext/rtattributehandler.cxx
index 582b451a8423..b5cfb55b7820 100644
--- a/forms/source/richtext/rtattributehandler.cxx
+++ b/forms/source/richtext/rtattributehandler.cxx
@@ -320,7 +320,7 @@ namespace frm
if ( pFontHeightItem )
{
// by definition, the item should have the unit twip
-sal_uLong nHeight = pFontHeightItem->GetHeight();
+sal_uInt32 nHeight = pFontHeightItem->GetHeight();
if ( _rAttribs.GetPool()->GetMetric( getWhich() ) !=
MapUnit::MapTwip )
{
nHeight = OutputDevice::LogicToLogic(
@@ -347,7 +347,7 @@ namespace frm
if ( !pFontHeightItem )
return;
-sal_uLong nHeight = pFontHeightItem->GetHeight();
+sal_uInt32 nHeight = pFontHeightItem->GetHeight();
if ( _rNewAttribs.GetPool()->GetMetric( getWhich() ) !=
MapUnit::MapTwip )
{
nHeight = OutputDevice::LogicToLogic(
[Libreoffice-bugs] [Bug 152299] Remove unused define(s) from C/C++ files
https://bugs.documentfoundation.org/show_bug.cgi?id=152299 Commit Notification changed: What|Removed |Added Whiteboard||target:7.5.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: dbaccess/source
dbaccess/source/ui/browser/dbtreemodel.hxx |3 ---
1 file changed, 3 deletions(-)
New commits:
commit 0569a84c16e6ee6ed6f4fb52c23ed6dfe4225cdf
Author: Bogdan B
AuthorDate: Mon Nov 28 21:00:11 2022 +0100
Commit: Hossein
CommitDate: Thu Dec 8 22:38:23 2022 +
tdf#152299 - Remove unused define(s) from C/C++ files
Change-Id: I22185ee21af426974cf57bda288320413bd119a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143434
Tested-by: Jenkins
Reviewed-by: Hossein
diff --git a/dbaccess/source/ui/browser/dbtreemodel.hxx
b/dbaccess/source/ui/browser/dbtreemodel.hxx
index 2ea11b900975..53a34a8e4247 100644
--- a/dbaccess/source/ui/browser/dbtreemodel.hxx
+++ b/dbaccess/source/ui/browser/dbtreemodel.hxx
@@ -29,9 +29,6 @@
// tables holds the nameaccess for the tables
// tableholds the table
-#define CONTAINER_QUERIES sal_uLong( 0 )
-#define CONTAINER_TABLESsal_uLong( 1 )
-
namespace com::sun::star::lang { class XMultiServiceFactory; }
namespace dbaui
[Libreoffice-commits] core.git: external/zxing
external/zxing/UnpackedTarball_zxing.mk |1 +
external/zxing/msvc-lambdacapture.patch.0 | 11 +++
2 files changed, 12 insertions(+)
New commits:
commit 3f564769446032825b20ca6414caa1c196076ddc
Author: Stephan Bergmann
AuthorDate: Thu Dec 8 16:50:32 2022 +0100
Commit: Stephan Bergmann
CommitDate: Thu Dec 8 22:29:46 2022 +
external/zxing: Avoid MSVC 2022 error C2326
> workdir/UnpackedTarball/zxing/core/src/qrcode/QRDetector.cpp(431): error
C2326: 'auto ZXing::QRCode::SampleMQRoperator ()(int,bool)
const': function cannot access 'FORMAT_INFO_COORDS'
seen at least with VS 2022 17.4.2 and VS 2022 17.5.0 Preview 1.0, but not
with
VS 2019 16.11.21. It looks to me like a bug in MSVC, but then again it
doesn't
hurt to make that variable static, anyway.
Change-Id: I48fa22f9495791e60953f9f717ffc814de1c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143826
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/external/zxing/UnpackedTarball_zxing.mk
b/external/zxing/UnpackedTarball_zxing.mk
index 0d81d13f6411..ac0aff061d72 100644
--- a/external/zxing/UnpackedTarball_zxing.mk
+++ b/external/zxing/UnpackedTarball_zxing.mk
@@ -17,6 +17,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,zxing, \
external/zxing/assume.__cpp_lib_string_view.patch.0 \
external/zxing/android_include.patch.0 \
external/zxing/missing-include.patch.0 \
+ external/zxing/msvc-lambdacapture.patch.0 \
))
# vim: set noet sw=4 ts=4:
diff --git a/external/zxing/msvc-lambdacapture.patch.0
b/external/zxing/msvc-lambdacapture.patch.0
new file mode 100644
index ..390d1cc65502
--- /dev/null
+++ b/external/zxing/msvc-lambdacapture.patch.0
@@ -0,0 +1,11 @@
+--- core/src/qrcode/QRDetector.cpp
core/src/qrcode/QRDetector.cpp
+@@ -418,7 +418,7 @@
+
+ auto srcQuad = Rectangle(7, 7, 0.5);
+
+- constexpr PointI FORMAT_INFO_COORDS[] = {{0, 8}, {1, 8}, {2, 8}, {3,
8}, {4, 8}, {5, 8}, {6, 8}, {7, 8}, {8, 8},
++ static constexpr PointI FORMAT_INFO_COORDS[] = {{0, 8}, {1, 8}, {2, 8},
{3, 8}, {4, 8}, {5, 8}, {6, 8}, {7, 8}, {8, 8},
+
{8, 7}, {8, 6}, {8, 5}, {8, 4}, {8, 3}, {8, 2}, {8, 1}, {8, 0}};
+
+ FormatInformation bestFI;
[Libreoffice-bugs] [Bug 152345] Pivot table - visual FORMATTING mistake after sorting by descending order
https://bugs.documentfoundation.org/show_bug.cgi?id=152345 m.a.riosv changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |NOTABUG --- Comment #9 from m.a.riosv --- Then please do a new report as enhancement, explain in it how do you expect it can work. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152422] Inter-glyph jitter when underlining text with Skia rendering
https://bugs.documentfoundation.org/show_bug.cgi?id=152422 --- Comment #6 from m.a.riosv --- Created attachment 184057 --> https://bugs.documentfoundation.org/attachment.cgi?id=184057=edit Screencast 2 Thanks, @Caolan for detailed explanation, My vision is not very good, with glasses I can see a little bit of the issue when a quick change between [Ctrl+U] and [Ctrl+Z] is done, and with a so high zoom. Attached is a video capture. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152345] Pivot table - visual FORMATTING mistake after sorting by descending order
https://bugs.documentfoundation.org/show_bug.cgi?id=152345 --- Comment #8 from devilfe...@hotmail.com --- Got it, this is indeed the answer to the problem HOWEVER...its too complex, too many steps, go inside this, that, clic, etc. it should be more agile, simpler. hope you can incorporate the feedback into the dev discussions. many thanks for all the support. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152430] New: Libreoffice hangs when cycling through open documents
https://bugs.documentfoundation.org/show_bug.cgi?id=152430 Bug ID: 152430 Summary: Libreoffice hangs when cycling through open documents Product: LibreOffice Version: 7.3.3.2 release Hardware: Other OS: macOS (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: dar...@oneillaw.com Libreoffice hangs when I cycle through open documents using the command and tilde keys. This started recently and I cannot associate it with any change in my set up. I did upgrade to Ventura recently, but I cannot say that it started with that. I am using a Macbook Air with the M1 chip, running Ventura. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: extras/source
extras/source/templates/wizard/letter/pri-bottle_l/content.xml | 27 -- extras/source/templates/wizard/letter/pri-mail_l/content.xml| 27 -- extras/source/templates/wizard/letter/pri-marine_l/content.xml | 27 -- extras/source/templates/wizard/letter/pri-redline_l/content.xml | 27 -- 4 files changed, 108 deletions(-) New commits: commit 20d3af853d327ab66cf55ccdfc5991a13993c47d Author: Caolán McNamara AuthorDate: Thu Dec 8 13:01:06 2022 + Commit: Caolán McNamara CommitDate: Thu Dec 8 19:46:11 2022 + Related: tdf#152266 remove office:scripts from wizard letter templates all the assignments are blank anyway, but its not desirable to have these. Change-Id: I5d7bd7bbdc65b286daad37cd6c368f86e0bb2785 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143821 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/extras/source/templates/wizard/letter/pri-bottle_l/content.xml b/extras/source/templates/wizard/letter/pri-bottle_l/content.xml index 83b418319d51..cbd8be3be7e5 100644 --- a/extras/source/templates/wizard/letter/pri-bottle_l/content.xml +++ b/extras/source/templates/wizard/letter/pri-bottle_l/content.xml @@ -1,32 +1,5 @@ http://www.w3.org/1999/xlink; xmlns:dc="http://purl.org/dc/elements/1.1/; xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" xmlns:math="http://www.w3.org/1998/Math/MathML; xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0" xmlns:ooo="ht tp://openoffice.org/2004/office" xmlns:ooow="http://openoffice.org/2004/writer; xmlns:oooc="http://openoffice.org/2004/calc; xmlns:dom="http://www.w3.org/2001/xml-events; xmlns:xforms="http://www.w3.org/2002/xforms; xmlns:xsd="http://www.w3.org/2001/XMLSchema; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; office:version="1.0"> - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/extras/source/templates/wizard/letter/pri-mail_l/content.xml b/extras/source/templates/wizard/letter/pri-mail_l/content.xml index 345d92c9c9ab..184cc1a680ab 100644 --- a/extras/source/templates/wizard/letter/pri-mail_l/content.xml +++ b/extras/source/templates/wizard/letter/pri-mail_l/content.xml @@ -1,32 +1,5 @@ http://www.w3.org/1999/xlink; xmlns:dc="http://purl.org/dc/elements/1.1/; xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" xmlns:math="http://www.w3.org/1998/Math/MathML; xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0" xmlns:ooo="ht tp://openoffice.org/2004/office" xmlns:ooow="http://openoffice.org/2004/writer; xmlns:oooc="http://openoffice.org/2004/calc; xmlns:dom="http://www.w3.org/2001/xml-events; xmlns:xforms="http://www.w3.org/2002/xforms; xmlns:xsd="http://www.w3.org/2001/XMLSchema; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; office:version="1.0"> - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/extras/source/templates/wizard/letter/pri-marine_l/content.xml b/extras/source/templates/wizard/letter/pri-marine_l/content.xml index 6f991ab3aff0..2174758c277b 100644 --- a/extras/source/templates/wizard/letter/pri-marine_l/content.xml +++ b/extras/source/templates/wizard/letter/pri-marine_l/content.xml @@ -1,32 +1,5 @@ http://www.w3.org/1999/xlink; xmlns:dc="http://purl.org/dc/elements/1.1/; xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" xmlns:math="http://www.w3.org/1998/Math/MathML; xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0" xmlns:ooo="ht tp://openoffice.org/2004/office" xmlns:ooow="http://openoffice.org/2004/writer; xmlns:oooc="http://openoffice.org/2004/calc; xmlns:dom="http://www.w3.org/2001/xml-events;
[Libreoffice-commits] core.git: xmloff/source
xmloff/source/script/XMLEventImportHelper.cxx |2 --
xmloff/source/script/XMLScriptContextFactory.cxx|3 +++
xmloff/source/script/XMLStarBasicContextFactory.cxx |3 +++
3 files changed, 6 insertions(+), 2 deletions(-)
New commits:
commit 8a33bde5288a4a652de35846aa34354044b872c3
Author: Caolán McNamara
AuthorDate: Thu Dec 8 16:25:24 2022 +
Commit: Caolán McNamara
CommitDate: Thu Dec 8 19:45:00 2022 +
tdf#152266 only warn about script:event-listener with non-empty targets
Change-Id: I19518c4872b522686b3df1881ccee02d840c3db4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143829
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/xmloff/source/script/XMLEventImportHelper.cxx
b/xmloff/source/script/XMLEventImportHelper.cxx
index aa409e77765d..aebfd13dc7ee 100644
--- a/xmloff/source/script/XMLEventImportHelper.cxx
+++ b/xmloff/source/script/XMLEventImportHelper.cxx
@@ -102,8 +102,6 @@ SvXMLImportContext* XMLEventImportHelper::CreateContext(
const OUString& rXmlEventName,
const OUString& rLanguage)
{
-rImport.NotifyMacroEventRead();
-
SvXMLImportContext* pContext = nullptr;
// translate event name from xml to api
diff --git a/xmloff/source/script/XMLScriptContextFactory.cxx
b/xmloff/source/script/XMLScriptContextFactory.cxx
index c5d7cb2d0d05..3ebc45c1c98a 100644
--- a/xmloff/source/script/XMLScriptContextFactory.cxx
+++ b/xmloff/source/script/XMLScriptContextFactory.cxx
@@ -53,6 +53,9 @@ SvXMLImportContext* XMLScriptContextFactory::CreateContext(
// else: ignore
}
+if (!sURLVal.isEmpty())
+rImport.NotifyMacroEventRead();
+
Sequence aValues{
comphelper::makePropertyValue(gsEventType, OUString(gsScript)),
comphelper::makePropertyValue(gsURL,
sURLVal) };
diff --git a/xmloff/source/script/XMLStarBasicContextFactory.cxx
b/xmloff/source/script/XMLStarBasicContextFactory.cxx
index e26198978596..bab59a0d7505 100644
--- a/xmloff/source/script/XMLStarBasicContextFactory.cxx
+++ b/xmloff/source/script/XMLStarBasicContextFactory.cxx
@@ -81,6 +81,9 @@ SvXMLImportContext* XMLStarBasicContextFactory::CreateContext(
sMacroNameVal = sMacroNameVal.copy( rDoc.getLength()+1 );
}
+if (!sMacroNameVal.isEmpty())
+rImport.NotifyMacroEventRead();
+
Sequence aValues
{
comphelper::makePropertyValue(gsEventType, OUString(gsStarBasic)),
[Libreoffice-commits] core.git: 2 commits - cui/source cui/uiconfig
cui/source/tabpages/macroass.cxx|3
cui/uiconfig/ui/eventassignpage.ui | 136 ++--
cui/uiconfig/ui/eventsconfigpage.ui | 94
3 files changed, 118 insertions(+), 115 deletions(-)
New commits:
commit c2c7c378ff8c1e3ba12420aa75189b9b1fe8515b
Author: Caolán McNamara
AuthorDate: Thu Dec 8 16:53:47 2022 +
Commit: Caolán McNamara
CommitDate: Thu Dec 8 19:44:28 2022 +
update assign/delete state after positioning cursor in treeview
Change-Id: I9fe2d9d4a3575e0b67c8421d215f65f46c2ac1f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143832
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/cui/source/tabpages/macroass.cxx b/cui/source/tabpages/macroass.cxx
index e80e471ff228..baff7c87b0ae 100644
--- a/cui/source/tabpages/macroass.cxx
+++ b/cui/source/tabpages/macroass.cxx
@@ -221,7 +221,10 @@ void SfxMacroTabPage::Reset( const SfxItemSet* rSet )
weld::TreeView& rListBox = mpImpl->m_xEventLB->GetListBox();
std::unique_ptr xIter(rListBox.make_iterator());
if (rListBox.get_iter_first(*xIter))
+{
rListBox.set_cursor(*xIter);
+EnableButtons();
+}
}
bool SfxMacroTabPage::IsReadOnly() const
commit 9fc0e4fa50e22c464dde702fcaa25420fa5ce5a4
Author: Caolán McNamara
AuthorDate: Thu Dec 8 16:33:57 2022 +
Commit: Caolán McNamara
CommitDate: Thu Dec 8 19:44:18 2022 +
resave with latest glade
Change-Id: I089e6c872b52ef530d0e6279fa8fd10576ccc6dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143831
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/cui/uiconfig/ui/eventassignpage.ui
b/cui/uiconfig/ui/eventassignpage.ui
index 78bf01cc4d92..86f0a7044ef0 100644
--- a/cui/uiconfig/ui/eventassignpage.ui
+++ b/cui/uiconfig/ui/eventassignpage.ui
@@ -1,5 +1,5 @@
-
+
@@ -32,43 +32,43 @@
-
+
True
-False
+False
True
True
-6
-12
-12
-True
+6
+12
+12
+True
True
-False
+False
True
True
-0
-none
+0
+none
True
-True
-True
-True
-in
+True
12
6
+True
+True
+in
True
-True
-True
+True
+True
True
True
liststore3
-0
-False
+0
+False
@@ -110,7 +110,7 @@
True
-False
+False
Assignments
@@ -119,25 +119,25 @@
-0
-0
+0
+0
True
-False
+False
vertical
6
-start
+start
Assign
True
False
-True
-True
-True
+True
+True
+True
Assigns the
selected macro to the selected event.
@@ -154,9 +154,9 @@
Remove
True
-True
-True
-True
+True
+True
+True
Removes the
macro assignment from the selected entry.
@@ -171,47 +171,47 @@
-1
-0
+1
+0
2
-
+
True
-False
-6
-True
+False
+6
+True
True
-False
+False
True
True
-0
-none
+0
+none
True
-True
-True
-True
-in
+True
12
6
+True
+True
+in
--1
+-1
True
-True
-True
+True
+True
True
True
liststore1
-False
-1
-True
+False
+1
+True
@@ -244,7 +244,7 @@
True
-
[Libreoffice-bugs] [Bug 152429] New: Enhancement: Allow BASE to access multiple external data sources
https://bugs.documentfoundation.org/show_bug.cgi?id=152429 Bug ID: 152429 Summary: Enhancement: Allow BASE to access multiple external data sources Product: LibreOffice Version: 7.3.6.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: bra...@branchco.com Description: I'm looking into building a stock portfolio management application. I want the account data to be in a local database, but there are several tables that need to be updated daily with new data. For example the price_master table looks like the following: SYMBOL PRICE DIVIDEND YIELD PAY_DATE PE_RATIO FCX 39.525 0.15 1.56% 11/01/2022 14.60 ADM 92.435 0.40 1.72% 12/07/2022 12.86 This data is available from a CSV download file and it only takes a half minute to copy/past the appropriate columns into a CALC workbook that I've setup for this. Although the data in these tables change, there is never any reason for the application to make the changes. A read only table is all that is needed. Data that is managed by the application should be in the embedded HSQLDB database. The security_master table is a good example of this: SYMBOL DESCRIPTION FCX Freeport-McMoran Inc Class B ADM Archer Daniels Midland Co Common My use case is in finance, but I can readily think of many use cases in other fields where this capability would be very useful. This enhancement would allow BASE to function as a reporting engine bringing together multiple data sources. Steps to Reproduce: 1. N/A Enhancement request 2. 3. Actual Results: N/A Enhancement request Expected Results: N/A Enhancement request Reproducible: Always User Profile Reset: No Additional Info: N/A Enhancement request -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Changes to 'refs/tags/libreoffice-7-5-branch-point'
Tag 'libreoffice-7-5-branch-point' created by Christian Lohmaier at 2022-12-08 19:31 + Tag libreoffice-7-5-branch-point -BEGIN PGP SIGNATURE- iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmOSO6IACgkQ9DSh76/u rqNf7BAAkGNVM0XDFSxlP0NxIzntXXJvtt20qFGW4uDyt3j7LKlgmZcAWnp2ycUO DHceCNvUvbhlXJ6jjpqdGEjDJTLZUD/3WFhmSYKWCYksuwYbz1LQPW/HbnS4SXmP eeG4M6zh8m2YOvkq024uhkROXZc6cCrBehi+F3w/1c3ENR4yHAud4FDyCa6rVt2j gQD/1DYm5QunHFPxhTNtSgkDIoXaR7tiYk0S/kfzgbCMmPR765c6hswE86mhnCxf VQJVJuVha2h27C/PLcsnjooo2n8Ad+2O37OXpP8c+T0lWFwCxeHao17/tGCPSdnN /W/Rl8mesbohLVk/X6muNT6VOglk58NmLG8gsABb+/yY0UUOBOSYOR5xXCFVZmEn LBPmWznBY/z5u2ciQGs2mHiRC7r7bQ/cEdhcp6kxt1u1Tf11oH5VEM17neF7oY1L 2lzb+Jr8btTh1DNbhUPn76Oc9EbnmhoVgngTD8batqbE1Z8o3uhbr1G8+mFlkiCr mx2/BQi1UVVLuWjZQUoeqwfsjnW0jWi2TbzdGQgQa41CJDXXcGtmKiJVl9MYicqp ZiHoEKrJrKFwVkrZfLdc+MmtbWbUxI1ixK0IRaFEXHeM60SFePdZrB3/4D8yzFIj 1dZWJcr5IGCwFlBK/wNQ3C001CrVrpBG2ejHhZinVy8AH7OyS/Q= =DJNT -END PGP SIGNATURE- Changes since libreoffice-7-4-branch-point-5222: --- 0 files changed ---
[Libreoffice-commits] translations.git: Changes to 'refs/tags/libreoffice-7-5-branch-point'
Tag 'libreoffice-7-5-branch-point' created by Christian Lohmaier at 2022-12-08 19:31 + Tag libreoffice-7-5-branch-point -BEGIN PGP SIGNATURE- iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmOSO6IACgkQ9DSh76/u rqN05hAAi3XFcGDyO6Tt+K9KIKR8bfvJE55bUEuSIXVj/xWNn036hu1iFGNTA4I0 NGhVRPCYwtR3oVq6bf61ktqPJotKl2/APIz6zpBO4oS7w9AbPJFhb5M0/RHCjLCH ffIfRHXye5i7NbAaA2XePyTCu8g9HY8dvB7M9qPWxZ9YzwdWBpEtEbUjuJvBndn/ Mv8H03CJqOlsfCIJPCSprbDw866KC6fRuTG/4dT/fdlA9953CC17sSfTj2KVzSbR PrMKgjGU/zP9r/a3aa6ak1iKb02SrJ5o0yC/2CcBLGEFu3sM/JvPrYjqwladn1Ew bLzya4/awc8H8gVOk9E4W1N0GjN+m22Sw7nBDisITM7WfXkZUrbAyzIYbWYVnxsM lCzYhi485uh4WG93NeNnF6bc9j9ipz9vCYcV7Jn+McsBUGAr3oO2f5LuFv1DJcgP XM3sGzTmiAGHa0QUEW1Kjv5BhE00AaghL5tiN4IFc1pkX9ARZs0Hhzi9EV4oglws 4cPme89RafGk6sT41aLHipCq+AfpeEjqT1+X4uuJ4YFyH18V/76GK5+RymIa4lhR bZ9DY8TKBAAv+Fu7FMeoEhbJNm5IVDIe5spX+8mOCZHIqOihoMjqjDcjjp5+9wQc Avi2LD+Kvfy1jlWZE9V1Q+UyKLZ7yLk1KnXZezl7296hdveevk8= =kHJn -END PGP SIGNATURE- Changes since libreoffice-7-4-branch-point-28: --- 0 files changed ---
[Libreoffice-commits] help.git: Changes to 'refs/tags/libreoffice-7-5-branch-point'
Tag 'libreoffice-7-5-branch-point' created by Christian Lohmaier at 2022-12-08 19:31 + Tag libreoffice-7-5-branch-point -BEGIN PGP SIGNATURE- iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmOSO6IACgkQ9DSh76/u rqNZHg//dsZBhBgFlBERSyMktoB71K5R8L/6qpHV5ygxyCn2PAgpTXefZ7G+7vas wXqFASRpsLOc0W1HpR1mwx0K6OeNPd4nCI0UWkF6l/3H0jdlK/JBurgSY1gXv9NC 4MgJFbwDJ4UeCJj8/twR1yHANNcI7Sx0MfInDHQvztbsNFClkHu5UFWlvEuWt+QS Bi7Ar8c2i03u/fGJUpk88dAQSGmMinaQeRVn3FKFRXYN67s2vPxfsofhLJbRO++a WCTLpN1LPYnDgY0Ec8ctitUWdfPDKR01H8uKVl4NkEzQ0igIcCKAOOdBVSS7TiJz bLVKFQ9uDTBywClefMcfhZy4//zHWzpBV32zANq7RT8CqpaV5V81N7FkElMo5GV/ Z3iu86eAY07AGvK6UIAA+qFRzhb+S7aLyV8XuigGrh/l3HmG7l+Ie1yfIdtvEQOF Tz0GpoTu/om1mkvQM/5/y9pQi8ccpCVOAfiLE1SKS7mgXjMc7aaGo+6Te+w9V8zU Fezpt/MBvuI2eTCPIxGho4cKs3hf4vCtuqh6DT1pp8hWkFqpyRqkU8Zm2nfIZI5P 9mXsYbt9zOsuljwLfpHVQM7WMDXOC+zVSfzcM0rIIZnanEnQo9pPUNxHwyeDbKGu zYdAf9bZIKX0+DQlOyeY7z45bUs/I6NDmp5EqHK0BDDb6bBUmJ0= =JNKI -END PGP SIGNATURE- Changes since libreoffice-7-4-branch-point-226: --- 0 files changed ---
[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/libreoffice-7-5-branch-point'
Tag 'libreoffice-7-5-branch-point' created by Christian Lohmaier at 2022-12-08 19:31 + Tag libreoffice-7-5-branch-point -BEGIN PGP SIGNATURE- iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmOSO6IACgkQ9DSh76/u rqNgJQ//S9L85KgeoPHDMjQJHBluKyWDL827Dw74b69GKxkvpgy7QStxWHkjJeVB N8/nPU9ELf+YWQvELIkQ2B3XmXbn6jFURWw+BtGoG9Wv3Y4runXzMSVqtaAzMe8B EcYtbAI7EDKz95xx3h+CQCEbIRub1TAXDLaaHwngkmOX6at4v61xqM3o714OODan sQJhYxvCna88tKQbBL6pOyxkFHQhXcw+0k5g6+DIMGXjqdq0uOCtH/8OMF1xDvUX FkjjEJiRuAPvgWPeWpfyglNkKpxBEpEy8mw9kxNavZyd8fpkcbG1EqqDpdGPbMeE QikVeK5KgGLz1lUOtvb33jUhjx+RZvj/peCVKqWhDP8zBpB9Ce3xXGavNxhLelKN RUsmsM8/XSm+j/szQQmKJ1a9rWvPswWdwaEZQ+VRr35Apt37vM9bWwTJbC8Agi65 pt4g05w5+O+zQLWzHPeUz6xF/bggz/Bo4uMpAmIdnmckcuT/UoaW0bC64bTJ/KmP iu8LPOdc5JUc3EsS/5A8mtJ7dmYLccj4Ky9dBwTGSF+cv+QXnHKlE7mDdK67/cwi u+1kXfdWfIf+NIaqVV+TIupVk04QPZqRI/dRKjwc5C6KigpZlQlOlLcz2kkbfxzR DHMF2cFSwwjFJ/POtamk+ohQJa9JDti37oHx2wvWchr7sXdJKEE= =6YOa -END PGP SIGNATURE- Changes since libreoffice-7-4-branch-point-12: --- 0 files changed ---
[Libreoffice-commits] translations.git: Changes to 'refs/tags/libreoffice-7.5.0.0.beta1'
Tag 'libreoffice-7.5.0.0.beta1' created by Christian Lohmaier at 2022-12-08 19:29 + Tag libreoffice-7.5.0.0.beta1 -BEGIN PGP SIGNATURE- iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmOSOxMACgkQ9DSh76/u rqNBSw//fGgg0+ksJtrbrs+WC9AFr/OBm/JrmFdwkxbAdomPSHR2xmT4f5x6jTPM T9m1wmep7pPnMryGXNzq1Bxo34dR5fOmsJF4ChAO5eeE3XqguKxwsEPe/1VwPICp ibvWjSRlD1SWnOteMo4GPBNgtZsRmSZj5TAH+2L6wUUFE5kXAPf1SjswzRXW7LLo jsCmBHOIFhYBvJN2dVzFC18DOrSyypvzpVgyKK+QbjGiPX4bfms2KVVt8Mn6abS/ 8Oe0RhKYhugUFqo/AI7306kfKXMEckzhrrXnnM6vPZC03qm5jVHmDrywfyTB9kck cehNrDqlJ0S3FQio51mYIQxOhV3t5JQElanaCZkDL76kLgnJoOAsxIocRiLXFKPc DGI/FsKlsKN/XIasAnUp+g2FtqsHXj04xEUcToiRL/UJ8YQWXVjRRg6bk3dutdoO jEEAXZrXF0DfnsO3DbswvgQN8yOOLL5/qOAaIqL174AWfPbOkiTqLfPg+aTxJzL7 XxJV9r3K3btprp5zOshcztWCgujg/J2fmjzJurpmg+jSIE+SST35+rks7a/7vr5t d09mxLSpWT5YBDueD05HahlUkSojW7BO+qxg9ciPaC/xY3F7HX7MTL/mWJ3aN3CT LlskL7LDaeG5F8sSN/SAF+XeynjhTmhDmS2GroEsAGFzttGDusM= =LmyG -END PGP SIGNATURE- Changes since libreoffice-7-4-branch-point-30: --- 0 files changed ---
[Libreoffice-commits] help.git: Changes to 'refs/tags/libreoffice-7.5.0.0.beta1'
Tag 'libreoffice-7.5.0.0.beta1' created by Christian Lohmaier at 2022-12-08 19:29 + Tag libreoffice-7.5.0.0.beta1 -BEGIN PGP SIGNATURE- iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmOSOxMACgkQ9DSh76/u rqPYFhAAgD/WdLgLzodmtyMbv7I75S8BcATgHCwvt5EKx+KGYGc8Piic3AHffq0N 5Ny9Ydr9Us6LTOcGwk3Hbd2hZyQmnIFTKJJsQ0joUX18fFy8hkJULLEhxREIjwvn kLOomPSsTHUGJNis94I2GA3T+llvh7F6APmWceH7aeQkWzC6OsGSNOaIktmNETF+ KQqyjyKuFqG6jgD5rfr6Bwmginh4QXpYarFTvTWycZIV/R2QzxhLfGwIZMfCgADu XdU/bZID6bxUBuohjwUx1QIqOv9hceEfs86QCxU6SEQG52JGCcMGGUF73kAYI07d nA0thrJo2tmMOUFkQVkmidq5OKc/1I9kPprnUEO65Wp0JfrqbntM/pY+oJ8UXMpq T5zgGi1dv4/4h6RoU4VhGBDYWtxgeOM7+GPHph5+kbvEmr+gz4NweY1S2MNKoVx4 RWl9qn0NRWePYvt3QpMsOJslf779FBMOdrK0+7akdiu6Kjl+MZogjgWKboW4LBl0 WJ5jD7lFl11tjjZhvMsnhb7pRIlPgR277iZcxxV6dgJ3eEaBkdx6Ud/snTRseoP9 vvJwkuuwLYFyQ8n+lWybqZB4a2glS5a1zXmdOaIKHjZwg2EIZIQKGe5K5hBnaeIK /e/WMTzw68pQWWPXcevOlADvoh511Vq8q38Bu8jDlMGgDGOtVqc= =CSmL -END PGP SIGNATURE- Changes since libreoffice-7-4-branch-point-228: --- 0 files changed ---
[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/libreoffice-7.5.0.0.beta1'
Tag 'libreoffice-7.5.0.0.beta1' created by Christian Lohmaier at 2022-12-08 19:29 + Tag libreoffice-7.5.0.0.beta1 -BEGIN PGP SIGNATURE- iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmOSOw4ACgkQ9DSh76/u rqPjWRAAj0eRzlwJEqUvQmWfFwrNJxcglLfSOhVa00HdAfubKprh934+aBiIq/7Z pvwsbF1BMgkdzdTdkZjT26YloZGPVD/XSivYlecqgvE7EYYk3o1xD5KYkANSZ3Sn F/CnAzaHIJFP7qNWS7iAJACydVhPwndAXdonPaxH3E7i5Ta7OcdKIQDtcsdllT1t y4KJ6D8eLNVetf8LHeS8jDAfZ4RuXNLRerSlSB1dAp9q++CjAkwb/KYp1vRu3LKT iQjsEDJ4+n3HoQngHFTo+yxH2Ab9wXS/3dAtla7waOk2De6gFePIKCMs8O6r8cNG Ck0nJC5M3+mBdFArE2p/d/F+58RChXLE9DaYTmLx3sX7VUJL7Pl1FvzlxIbPVS0q /IHwQMD9DZwbwwhj+5DBUrSo04uzznhP5dDtOZHdT5/VMnveCHXvgn+B4s3XbfDb IOEheBUFXUIZyM+8qagnmdTSXQTAyp8iTisTXLQPs4rnRsujd7NRzL5y6WIZB8hr vwjkBauHI9/FvJ+UdJ1q5EhUawfQkKfl13Wq07BLg+x0xv1OXIsc/1bGuahfsvYm 2aYWzJQKATwTQnw+SzqzqaqnYmOIy9jAL+3ZcV2Kd1HjxCi2FkJXL14L7/WTI+Ug XKI2SZPgY6w3oDQ4izxYEDwFPI5DXaGB1k+N64zTwg8N0HcbCdw= =J3rS -END PGP SIGNATURE- Changes since libreoffice-7-4-branch-point-14: --- 0 files changed ---
[Libreoffice-commits] core.git: Changes to 'refs/tags/libreoffice-7.5.0.0.beta1'
Tag 'libreoffice-7.5.0.0.beta1' created by Christian Lohmaier at 2022-12-08 19:29 + Tag libreoffice-7.5.0.0.beta1 -BEGIN PGP SIGNATURE- iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmOSOxMACgkQ9DSh76/u rqOFfRAAzkE+fn8nAEYdmepRA/rj3uBHvtQZD2YdHsNOlvOtWiBSutrNxXIZLFVn Pk8n9dT0ZI0Ap8a02czfEN6UT8iMkTZ89AF16RJnE+Q2LT1MpVdJmPLfZCNuTm2N 47H+w4GgUV6Rxhq8HivRL8Dz6DzHyOb3OY39yCp12CBoYk1vEOxODuWWMsBywMMt kcW8MhcvVBe1ZtSUdrBEDbOXkPIqszuT5OL8eJ1V3Q5PTcYXWg5T4eHQHyO6Sm8h XkScyg0CNlL60xGKkr3RiBHHBrGv0DBkLoU5DKJ3/F8y6DjxefhlatHr1N1Xi4si NFpRWWrm77M5ryVGPtMhiafTeR/I0gqLUQmeKOs78LyulQ94E9+bBOBGUUnH+LuL 7d9Z66oD/lys8YkUBU4Bj1OFBsyabO33WTwPwibC7pekNkSK6XP6gLbD5DSgc8zg qwY2+2+2piXftUbw782X1fdNj7xGFHc4+VF0fLJp0Xr0eLW4vieZ6TOorGMEC3mF V5g2dC2ouH4ZYReMfy5H+zEmdx0IWtyvUqO6JOYah8zeN68OxQuZRoWxtOjHIAve d/E6m3T7C9lC19mAF0bSDeYLoycoijjnGy2Uk/cfAVGMW9pQ0f/uxMIhFAVNCddh jgslxHRXAJEzUANjxA3QvCvnmXgu7FpD9WdkDmA4ZkqnpH535UA= =eHTA -END PGP SIGNATURE- Changes since libreoffice-7-4-branch-point-5225: --- 0 files changed ---
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - configure.ac
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f561cf425cda33fa1c688dac14be052e116ce0f6 Author: Christian Lohmaier AuthorDate: Thu Dec 8 20:29:51 2022 +0100 Commit: Christian Lohmaier CommitDate: Thu Dec 8 20:29:51 2022 +0100 bump product version to 7.5.0.0.beta1+ Change-Id: I0140e0863311008955eef76ce9c1c616a74bb373 diff --git a/configure.ac b/configure.ac index 1e850637f55e..3695d2528c88 100644 --- a/configure.ac +++ b/configure.ac @@ -9,7 +9,7 @@ dnl in order to create a configure script. # several non-alphanumeric characters, those are split off and used only for the # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no idea. -AC_INIT([LibreOffice],[7.5.0.0.alpha1+],[],[],[http://documentfoundation.org/]) +AC_INIT([LibreOffice],[7.5.0.0.beta1+],[],[],[http://documentfoundation.org/]) dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just fine if it is installed dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails hard
[Libreoffice-commits] core.git: configure.ac
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit af6f87e66bc7f6257524df68ca9d90e6072558f6 Author: Christian Lohmaier AuthorDate: Thu Dec 8 20:26:44 2022 +0100 Commit: Christian Lohmaier CommitDate: Thu Dec 8 20:26:44 2022 +0100 bump product version to 7.6.0.0.alpha0+ Change-Id: I4cc88c54d42dd141f03c46377cd5c2f2fa56ad7b diff --git a/configure.ac b/configure.ac index 1e850637f55e..5fc489a7e8c0 100644 --- a/configure.ac +++ b/configure.ac @@ -9,7 +9,7 @@ dnl in order to create a configure script. # several non-alphanumeric characters, those are split off and used only for the # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no idea. -AC_INIT([LibreOffice],[7.5.0.0.alpha1+],[],[],[http://documentfoundation.org/]) +AC_INIT([LibreOffice],[7.6.0.0.alpha0+],[],[],[http://documentfoundation.org/]) dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just fine if it is installed dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails hard
[Libreoffice-commits] core.git: Changes to 'libreoffice-7-5'
New branch 'libreoffice-7-5' available with the following commits: commit 694fc64d53f594a039294162420b9f8fe451ee13 Author: Christian Lohmaier Date: Thu Dec 8 20:25:29 2022 +0100 Branch libreoffice-7-5 This is 'libreoffice-7-5' - the stable branch for the 7.5.x releases. The commit rules are different according to the development phase: A. 7.5.0 beta phase: A. any bug fixes are allowed without review B. late features need approval by 3 people with different affiliation B. 7.5.0 rc phase and later: A. fixes need approval by one reviewer B. late features need approval by 3 more people with different affiliation IMPORTANT: Every developer is responsible for pushing the fixes into all appropriate branches. Note that we do not plan any merge from this branch to master or vice versa. Please, help use to make stable and usable release. If you want to build something cool, unstable, and risky, use master.
[Libreoffice-commits] translations.git: Changes to 'libreoffice-7-5'
New branch 'libreoffice-7-5' available with the following commits: commit 53ac2ecc116572789505a5fe304b1c962d01ed26 Author: Christian Lohmaier Date: Thu Dec 8 20:25:01 2022 +0100 Branch libreoffice-7-5 This is 'libreoffice-7-5' - the stable branch for the 7.5.x releases. The commit rules are different according to the development phase: A. 7.5.0 beta phase: A. any bug fixes are allowed without review B. late features need approval by 3 people with different affiliation B. 7.5.0 rc phase and later: A. fixes need approval by one reviewer B. late features need approval by 3 more people with different affiliation IMPORTANT: Every developer is responsible for pushing the fixes into all appropriate branches. Note that we do not plan any merge from this branch to master or vice versa. Please, help use to make stable and usable release. If you want to build something cool, unstable, and risky, use master. Change-Id: Ie59eedb980482d785531219b2d1ef187395246f3
[Libreoffice-commits] help.git: Changes to 'libreoffice-7-5'
New branch 'libreoffice-7-5' available with the following commits: commit 79a1aad15a9024a25e83b9ceb47455f63434e4bd Author: Christian Lohmaier Date: Thu Dec 8 20:25:01 2022 +0100 Branch libreoffice-7-5 This is 'libreoffice-7-5' - the stable branch for the 7.5.x releases. The commit rules are different according to the development phase: A. 7.5.0 beta phase: A. any bug fixes are allowed without review B. late features need approval by 3 people with different affiliation B. 7.5.0 rc phase and later: A. fixes need approval by one reviewer B. late features need approval by 3 more people with different affiliation IMPORTANT: Every developer is responsible for pushing the fixes into all appropriate branches. Note that we do not plan any merge from this branch to master or vice versa. Please, help use to make stable and usable release. If you want to build something cool, unstable, and risky, use master. Change-Id: I821b6c9bb1a9c8ade313d38c0ea97583495ece60
[Libreoffice-commits] dictionaries.git: Changes to 'libreoffice-7-5'
New branch 'libreoffice-7-5' available with the following commits: commit 908f704b798338332ddd79dd8c2d53dd6fd1 Author: Christian Lohmaier Date: Thu Dec 8 20:25:01 2022 +0100 Branch libreoffice-7-5 This is 'libreoffice-7-5' - the stable branch for the 7.5.x releases. The commit rules are different according to the development phase: A. 7.5.0 beta phase: A. any bug fixes are allowed without review B. late features need approval by 3 people with different affiliation B. 7.5.0 rc phase and later: A. fixes need approval by one reviewer B. late features need approval by 3 more people with different affiliation IMPORTANT: Every developer is responsible for pushing the fixes into all appropriate branches. Note that we do not plan any merge from this branch to master or vice versa. Please, help use to make stable and usable release. If you want to build something cool, unstable, and risky, use master. Change-Id: I2b56c99acbf6d71d03f3a1f0e4553fb7040d47d2
[Libreoffice-commits] core.git: translations
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 1c629ca0048670db4bed5e7d8d76bcf8e81f2158 Author: Christian Lohmaier AuthorDate: Thu Dec 8 20:20:03 2022 +0100 Commit: Gerrit Code Review CommitDate: Thu Dec 8 19:20:03 2022 + Update git submodules * Update translations from branch 'master' to f201069fb109d5c24dd18d03f393de1169056956 - remove name attribute from links for sl from last update Change-Id: Iddcea1018599043d5db47afd7fc7207c1a388a96 - update translations for 7.5.0 beta1 and force-fix errors using pocheck Change-Id: Id9f87177a20fe0832571d86c1802926b960ec1e8 diff --git a/translations b/translations index ced285e64bd6..f201069fb109 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit ced285e64bd6856c29ff97baeedf638999617b6d +Subproject commit f201069fb109d5c24dd18d03f393de1169056956
[Libreoffice-bugs] [Bug 152428] inserting an image into a writer file prevents further editing of the document
https://bugs.documentfoundation.org/show_bug.cgi?id=152428 --- Comment #3 from Steve Garry --- the received document is after being edited, I can provide the original document as received if needed, -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152428] inserting an image into a writer file prevents further editing of the document
https://bugs.documentfoundation.org/show_bug.cgi?id=152428 --- Comment #2 from Steve Garry --- Created attachment 184056 --> https://bugs.documentfoundation.org/attachment.cgi?id=184056=edit signature JPG file signature file to insert -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 125040] Replace single toolbar with contextual single
https://bugs.documentfoundation.org/show_bug.cgi?id=125040 Stéphane Guillou (stragu) changed: What|Removed |Added Whiteboard|target:7.5.0|target:7.5.0 ||inReleaseNotes:7.5 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152428] inserting an image into a writer file prevents further editing of the document
https://bugs.documentfoundation.org/show_bug.cgi?id=152428 --- Comment #1 from Steve Garry --- Created attachment 184055 --> https://bugs.documentfoundation.org/attachment.cgi?id=184055=edit received document -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152428] New: inserting an image into a writer file prevents further editing of the document
https://bugs.documentfoundation.org/show_bug.cgi?id=152428 Bug ID: 152428 Summary: inserting an image into a writer file prevents further editing of the document Product: LibreOffice Version: 7.4.2.3 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: i...@huntsgrove.ie Description: Received a docx file via E-mail, and saved a copy of that file to local storage. Opened it for edit, and made changes, but after inserting an image (17Kb JPG file), it is no longer possible to make further changes to the document, the cursor cannot be found. The document can be saved, but this is not an issue I have seen with previous versions, I was adding a signature image to a file, which I have been doing for many years with no issues. Steps to Reproduce: 1.open .odt file 2.insert image jpg file on page 3 at signature position 3. Actual Results: on changing format of JPG to allow correct placement, and changing format to allow text to surround image, no further editing of document can be performed, the cursor is lost. Other tool bar functions still operate. Expected Results: image is inserted, then set to have correct formatting and then editing continues. Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: en-GB Module: TextDocument [Information guessed from browser] OS: Windows (All) OS is 64bit: no Version: 7.4.2.3 (x64) / LibreOffice Community Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf CPU threads: 2; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: en-GB (en_GB); UI: en-GB Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152427] LibreOffice Calc "formula bar" is sunken and the formula is only half displayed.
https://bugs.documentfoundation.org/show_bug.cgi?id=152427 Stéphane Guillou (stragu) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Stéphane Guillou (stragu) --- *** This bug has been marked as a duplicate of bug 150664 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source xmloff/source
sw/source/core/doc/list.cxx| 12 +
xmloff/source/text/XMLTextListBlockContext.cxx | 172 +
2 files changed, 101 insertions(+), 83 deletions(-)
New commits:
commit da798460e370a97597ecc9a06634f400c4b2e0cc
Author: Noel Grandin
AuthorDate: Thu Dec 8 14:50:54 2022 +0200
Commit: Noel Grandin
CommitDate: Thu Dec 8 18:24:22 2022 +
crashtesting ooo84576-1.odt
prevent the OOM by detecting cycles in SwList::SwList and throwing an
exception.
(1) However, that means we need to catch the exception in
XMLTextListBlockContext::XMLTextListBlockContext
and undo some registration, otherwise we will get a use-after-free.
The need to catch it is why I'm using an UNO exception here,
it seemed like a bad idea to throw and then catch and std::foo
exception.
(2) this is still not the end of the story, a further exception
is thrown during SwDoc destruction, for which I don't have a
solution.
Change-Id: I48be3d8acbdc0f9ca948a958f1124b158ba77ac0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143820
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/source/core/doc/list.cxx b/sw/source/core/doc/list.cxx
index aa4c06f473aa..5095d4e6c9a9 100644
--- a/sw/source/core/doc/list.cxx
+++ b/sw/source/core/doc/list.cxx
@@ -33,8 +33,18 @@ SwList::SwList( OUString sListId,
{
// create empty list trees for the document ranges
const SwNode* pNode = rNodes[SwNodeOffset(0)];
+std::vector aVisited(static_cast(rNodes.Count()), false);
do
{
+SwNodeOffset nIndex = pNode->GetIndex();
+if (aVisited[static_cast(nIndex)])
+{
+// crashtesting ooo84576-1.odt, which manages to trigger a broken
document structure
+// in our code. This is just a workaround to prevent an infinite
loop leading to OOM.
+SAL_WARN("sw.core", "corrupt document structure, bailing out of
infinite loop");
+throw css::uno::RuntimeException("corrupt document structure,
bailing out of infinite loop");
+}
+aVisited[static_cast(nIndex)] = true;
SwPaM aPam( *pNode, *pNode->EndOfSectionNode() );
maListTrees.emplace_back(
@@ -46,7 +56,7 @@ SwList::SwList( OUString sListId,
pNode = pNode->EndOfSectionNode();
if (pNode != ())
{
-SwNodeOffset nIndex = pNode->GetIndex();
+nIndex = pNode->GetIndex();
nIndex++;
pNode = rNodes[nIndex];
}
diff --git a/xmloff/source/text/XMLTextListBlockContext.cxx
b/xmloff/source/text/XMLTextListBlockContext.cxx
index 7c688f4c5e6c..c22eb2e221f2 100644
--- a/xmloff/source/text/XMLTextListBlockContext.cxx
+++ b/xmloff/source/text/XMLTextListBlockContext.cxx
@@ -110,113 +110,121 @@ XMLTextListBlockContext::XMLTextListBlockContext(
// Remember this list block.
mrTxtImport.GetTextListHelper().PushListContext( this );
+try
+{
+mxNumRules = XMLTextListsHelper::MakeNumRule(GetImport(), mxNumRules,
+sParentListStyleName, msListStyleName,
+mnLevel, , );
+if( !mxNumRules.is() )
+return;
-mxNumRules = XMLTextListsHelper::MakeNumRule(GetImport(), mxNumRules,
-sParentListStyleName, msListStyleName,
-mnLevel, , );
-if( !mxNumRules.is() )
-return;
-
-if ( mnLevel != 0 ) // root element
-return;
+if ( mnLevel != 0 ) // root element
+return;
-XMLTextListsHelper& rTextListsHelper( mrTxtImport.GetTextListHelper() );
-// Inconsistent behavior regarding lists (#i92811#)
-OUString sListStyleDefaultListId;
-{
-uno::Reference< beans::XPropertySet > xNumRuleProps( mxNumRules,
UNO_QUERY );
-if ( xNumRuleProps.is() )
+XMLTextListsHelper& rTextListsHelper( mrTxtImport.GetTextListHelper()
);
+// Inconsistent behavior regarding lists (#i92811#)
+OUString sListStyleDefaultListId;
{
-uno::Reference< beans::XPropertySetInfo > xNumRulePropSetInfo(
-xNumRuleProps->getPropertySetInfo());
-if (xNumRulePropSetInfo.is() &&
-xNumRulePropSetInfo->hasPropertyByName(
- s_PropNameDefaultListId))
+uno::Reference< beans::XPropertySet > xNumRuleProps( mxNumRules,
UNO_QUERY );
+if ( xNumRuleProps.is() )
{
-xNumRuleProps->getPropertyValue(s_PropNameDefaultListId)
->>= sListStyleDefaultListId;
-SAL_WARN_IF( sListStyleDefaultListId.isEmpty(), "xmloff",
-"no default list id found at numbering rules
instance. Serious defect." );
+uno::Reference< beans::XPropertySetInfo > xNumRulePropSetInfo(
+
xNumRuleProps->getPropertySetInfo());
+if
[Libreoffice-bugs] [Bug 107328] [META] Style preview bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107328 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||87535 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=87535 [Bug 87535] Styles-dropdown preview always uses “Western” font -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152427] New: LibreOffice Calc "formula bar" is sunken and the formula is only half displayed.
https://bugs.documentfoundation.org/show_bug.cgi?id=152427 Bug ID: 152427 Summary: LibreOffice Calc "formula bar" is sunken and the formula is only half displayed. Product: LibreOffice Version: 7.4.2.3 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: oreocn...@gmail.com Description: LibreOffice Calc "formula bar" is sunken and the formula is only half displayed. Actual Results: When you open the first glance you can see the problem. Expected Results: The formula bar is aligned with the icon in front of it, and the formula does not appear to show only half of it. Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: zh-CN Module: SpreadsheetDocument [Information guessed from browser] OS: Windows (All) OS is 64bit: no -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152426] Labels printing to a Zebra LP-2844 printer are not formatted correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=152426 --- Comment #2 from Kevin Madzia --- Created attachment 184053 --> https://bugs.documentfoundation.org/attachment.cgi?id=184053=edit Screen shots of print dialog boxes and printer preferences dialog boxes from a working and non-working PC -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152426] Labels printing to a Zebra LP-2844 printer are not formatted correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=152426 --- Comment #1 from Kevin Madzia --- Created attachment 184052 --> https://bugs.documentfoundation.org/attachment.cgi?id=184052=edit Sample document with a label -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152426] New: Labels printing to a Zebra LP-2844 printer are not formatted correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=152426 Bug ID: 152426 Summary: Labels printing to a Zebra LP-2844 printer are not formatted correctly Product: LibreOffice Version: 7.4.3.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ke...@centurycycles.com Description: I have a Zebra LP-2844 label printer. I am NOT using mailmerge; just a few basic labels that I have created as LibreOffice Writer documents (see attachment for a sample). The labels are 2.25 inches wide by 1.25 inches tall. I have a PC with LibreOffice 7.2.5.2 and the formatting when printed works fine. Another PC has the latest LibreOffice version 7.4.3.2, and when I try to print from this PC, the labels are not formatting correctly. It appears to be an issue with the orientation, but if I change the orientation, that does not help. Steps to Reproduce: 1. Open the label in LibreOffice Writer. 2. Print the document. 3. Choose the label printer as the destination. 4. Choose Portrait orientation under Page Layout. 5. Print. 4. Actual Results: The label prints across two physical labels with about one-half inch of blank space on the left and right, and the contents of the label are cut off within that blank space. Expected Results: The label should print completely on a single physical label. Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.4.3.2 (x64) / LibreOffice Community Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890 CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152029] Visually draw attention to in-view bookmark or hyperlink when selecting/hovering it in the Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=152029 --- Comment #29 from V Stuart Foote --- @Jim, * Got a chance to test drive with Bookmark in view attention feature 3cb654972ba204efb5dd35a44f95c7d509414400 Works well, was testing against the GettingStarted 7.4 guide ODT, where it helped to first focus to the page or two (if in multi-page view mode), but the mouse-over visual toggle of the bookmarks in the view-port nicely exposes them--even the "no text" bookmarks. I like it, looking forward to the additional "attention" views. =-testing-= Windows 10 in both Dark and Light color themes Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 52c75986adc2b370eb55ce918ab1db0a95831c83 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/inc sw/qa sw/sdi sw/source
sw/inc/cmdid.h |1 +
sw/qa/uibase/shells/shells.cxx | 27 +++
sw/sdi/_textsh.sdi |5 +
sw/sdi/swriter.sdi | 14 ++
sw/source/uibase/shells/textfld.cxx |9 +
5 files changed, 56 insertions(+)
New commits:
commit 243131397a5b626c2d8442dc716193e27b13ef9f
Author: Miklos Vajna
AuthorDate: Thu Dec 8 16:43:28 2022 +0100
Commit: Miklos Vajna
CommitDate: Thu Dec 8 16:46:54 2022 +
sw: introduce a .uno:GotoMark command
This is meant to be used from macros, it does the same as manually
opening the navigator, selecting a given bookmark and pressing enter.
It also helps debugging when you want to jump somewhere, but the
surrounding document content changes, so jumping to a certain page won't
work due to the changing page number.
Change-Id: I3bc08ae8023997bab89cf4732fb67233a6a1e134
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143825
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/sw/inc/cmdid.h b/sw/inc/cmdid.h
index 838ccde78c83..cb21ddb5b441 100644
--- a/sw/inc/cmdid.h
+++ b/sw/inc/cmdid.h
@@ -106,6 +106,7 @@ class SwUINumRuleItem;
#define FN_GOTO_NEXT_INPUTFLD (FN_EDIT + 47) /* go to next inputfield */
#define FN_GOTO_PREV_INPUTFLD (FN_EDIT + 48) /* go to previous inputfield
*/
+#define FN_GOTO_MARK(FN_EDIT + 49) /* go to bookmark by name */
#define FN_REPEAT_SEARCH(FN_EDIT + 50) /* Search again */
diff --git a/sw/qa/uibase/shells/shells.cxx b/sw/qa/uibase/shells/shells.cxx
index 1f89211e52e8..a9625ad9a59f 100644
--- a/sw/qa/uibase/shells/shells.cxx
+++ b/sw/qa/uibase/shells/shells.cxx
@@ -408,6 +408,33 @@ CPPUNIT_TEST_FIXTURE(SwUibaseShellsTest,
testInsertBookmark)
}
}
+CPPUNIT_TEST_FIXTURE(SwUibaseShellsTest, testGotoMark)
+{
+// Given a document with 2 paragraphs, a bookmark on the second one:
+createSwDoc();
+SwDoc* pDoc = getSwDoc();
+SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+pWrtShell->SplitNode();
+pWrtShell->SttEndDoc(/*bStt=*/false);
+pWrtShell->SetBookmark(vcl::KeyCode(), "mybookmark");
+SwNodeOffset nExpected = pWrtShell->GetCursor()->GetPointNode().GetIndex();
+
+// When jumping to that mark from the doc start:
+pWrtShell->SttEndDoc(/*bStt=*/true);
+uno::Sequence aArgs = {
+comphelper::makePropertyValue("GotoMark",
uno::Any(OUString("mybookmark"))),
+};
+dispatchCommand(mxComponent, ".uno:GotoMark", aArgs);
+
+// Then make sure that the final cursor position is at the bookmark:
+SwNodeOffset nActual = pWrtShell->GetCursor()->GetPointNode().GetIndex();
+// Without the accompanying fix in place, this test would have failed with:
+// - Expected: 10 (bookmark)
+// - Actual : 9 (doc start)
+// i.e. the actual jump didn't happen.
+CPPUNIT_ASSERT_EQUAL(nExpected, nActual);
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/sdi/_textsh.sdi b/sw/sdi/_textsh.sdi
index 312462f5b474..98e32d3d58dc 100644
--- a/sw/sdi/_textsh.sdi
+++ b/sw/sdi/_textsh.sdi
@@ -971,6 +971,11 @@ interface BaseText
ExecMethod = ExecField ;
StateMethod = NoState ;
]
+FN_GOTO_MARK // status(final|play)
+[
+ExecMethod = ExecField ;
+StateMethod = NoState ;
+]
FN_EXECUTE_MACROFIELD // status()
[
ExecMethod = ExecField ;
diff --git a/sw/sdi/swriter.sdi b/sw/sdi/swriter.sdi
index 84ca0997f982..2471dfcd9fb6 100644
--- a/sw/sdi/swriter.sdi
+++ b/sw/sdi/swriter.sdi
@@ -1730,6 +1730,20 @@ SfxVoidItem GotoNextInputField FN_GOTO_NEXT_INPUTFLD
GroupId = SfxGroupId::Navigator;
]
+SfxVoidItem GotoMark FN_GOTO_MARK
+(SfxStringItem GotoMark FN_GOTO_MARK)
+[
+AutoUpdate = FALSE,
+FastCall = TRUE,
+ReadOnlyDoc = TRUE,
+Toggle = FALSE,
+Container = FALSE,
+RecordAbsolute = FALSE,
+RecordPerSet;
+
+GroupId = SfxGroupId::Navigator;
+]
+
SfxVoidItem GotoNextObject FN_GOTO_NEXT_OBJ
()
[
diff --git a/sw/source/uibase/shells/textfld.cxx
b/sw/source/uibase/shells/textfld.cxx
index 80a955d2da16..1efdf57abed0 100644
--- a/sw/source/uibase/shells/textfld.cxx
+++ b/sw/source/uibase/shells/textfld.cxx
@@ -198,6 +198,15 @@ void SwTextShell::ExecField(SfxRequest )
}
break;
+case FN_GOTO_MARK:
+{
+const SfxStringItem* pName =
rReq.GetArg(FN_GOTO_MARK);
+if (pName)
+{
+rSh.GotoMark(pName->GetValue());
+}
+}
+break;
default:
bMore = true;
}
[Libreoffice-bugs] [Bug 152422] Inter-glyph jitter when underlining text with Skia rendering
https://bugs.documentfoundation.org/show_bug.cgi?id=152422 --- Comment #5 from Caolán McNamara --- you have to look closely at the i in the word sit or the l in elit on the same line as the word that is getting its underline toggled, they appear to wiggle/jitter a little wrt their neighbours -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sc/uiconfig
sc/uiconfig/scalc/ui/tpviewpage.ui |1 + 1 file changed, 1 insertion(+) New commits: commit b4d491808b65188f342a5ab25b893156b285deab Author: Caolán McNamara AuthorDate: Thu Dec 8 14:24:28 2022 + Commit: Eike Rathke CommitDate: Thu Dec 8 16:38:11 2022 + Resolves: tdf#152421 'GTK_IS_LABEL (label)' assertion failure Change-Id: I33d76f4a84d7ef1cd14cb5f2597f38385eff2e2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143725 Tested-by: Jenkins Reviewed-by: Eike Rathke diff --git a/sc/uiconfig/scalc/ui/tpviewpage.ui b/sc/uiconfig/scalc/ui/tpviewpage.ui index 18acb5e2fadb..6bbbe4aa756e 100644 --- a/sc/uiconfig/scalc/ui/tpviewpage.ui +++ b/sc/uiconfig/scalc/ui/tpviewpage.ui @@ -460,6 +460,7 @@ False 0 True +
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sc/source
sc/source/ui/cctrl/checklistmenu.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a52335fd454ca23db5969f661dc7cf8b22bbbfeb Author: Caolán McNamara AuthorDate: Thu Dec 8 12:02:32 2022 + Commit: Eike Rathke CommitDate: Thu Dec 8 16:36:09 2022 + Resolves: tdf#152325 initial "select" may not set the cursor to that pos but setting the cursor will 'select' for the default "single" selection mode. Change-Id: Ib7c3dfcce72bad69741b5bc3eb159a6ed3bc8142 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143723 Tested-by: Jenkins Reviewed-by: Eike Rathke diff --git a/sc/source/ui/cctrl/checklistmenu.cxx b/sc/source/ui/cctrl/checklistmenu.cxx index 833857614e72..82e7488c9804 100644 --- a/sc/source/ui/cctrl/checklistmenu.cxx +++ b/sc/source/ui/cctrl/checklistmenu.cxx @@ -1345,7 +1345,7 @@ size_t ScCheckListMenuControl::initMembers(int nMaxMemberWidth) } if (nVisMemCount) -mpChecks->select(0); +mpChecks->set_cursor(0); return nVisMemCount; }
[Libreoffice-bugs] [Bug 152422] Inter-glyph jitter when underlining text with Skia rendering
https://bugs.documentfoundation.org/show_bug.cgi?id=152422 --- Comment #4 from m.a.riosv --- Sorry, but I don't appreciate anything in the video. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/ooxmlexport/ooxmlexport12.cxx |5 ++---
sw/source/filter/ww8/docxattributeoutput.cxx |6 +-
sw/source/filter/ww8/writerhelper.cxx| 12
sw/source/filter/ww8/writerhelper.hxx|2 ++
sw/source/filter/ww8/wrtw8nds.cxx|1 +
5 files changed, 22 insertions(+), 4 deletions(-)
New commits:
commit 515df96a85878f10dae3c9d1274ef4575d2e3215
Author: Michael Stahl
AuthorDate: Tue Dec 6 12:03:07 2022 +0100
Commit: Michael Stahl
CommitDate: Thu Dec 8 16:30:45 2022 +
sw: DOCX export: avoid writing duplicate w:b to w:pPr
This prevents validation of documents in unit tests, only one w:b is
allowed.
The problem is that Writer has 3 different bold attributes, but Word
apparently has only 2 of them, so Western and CJK are now both mapped to
w:b.
But RTF export oddly maps CJK and CTL to \ab, in contrast to DOC/DOCX.
Change-Id: Icb9ece988de29e54dc320c483c74a4d4b8b70141
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143814
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport12.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport12.cxx
index eaddd1d6f48c..444fbf51a39c 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport12.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport12.cxx
@@ -1859,9 +1859,8 @@ CPPUNIT_TEST_FIXTURE(Test, testTdf135187)
loadAndSave("tdf135187.docx");
xmlDocUniquePtr pXmlDoc = parseExport("word/document.xml");
assertXPath(pXmlDoc,
"/w:document/w:body/w:tbl/w:tr[2]/w:tc[1]/w:p/w:pPr/w:rPr/w:b", 0);
-// FIXME: remove duplicate
-assertXPath(pXmlDoc,
"/w:document/w:body/w:tbl/w:tr[3]/w:tc[1]/w:p/w:pPr/w:rPr/w:b", 2);
-assertXPath(pXmlDoc,
"/w:document/w:body/w:tbl/w:tr[4]/w:tc[1]/w:p/w:pPr/w:rPr/w:b", 2);
+assertXPath(pXmlDoc,
"/w:document/w:body/w:tbl/w:tr[3]/w:tc[1]/w:p/w:pPr/w:rPr/w:b", 1);
+assertXPath(pXmlDoc,
"/w:document/w:body/w:tbl/w:tr[4]/w:tc[1]/w:p/w:pPr/w:rPr/w:b", 1);
assertXPath(pXmlDoc,
"/w:document/w:body/w:tbl/w:tr[2]/w:tc[1]/w:p/w:r[1]/w:rPr/w:b", 1);
assertXPathNoAttribute(pXmlDoc,
"/w:document/w:body/w:tbl/w:tr[2]/w:tc[1]/w:p/w:r[1]/w:rPr/w:b",
diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx
b/sw/source/filter/ww8/docxattributeoutput.cxx
index 9084b9b6171a..92b13f34823c 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -1362,6 +1362,7 @@ void
lcl_writeParagraphMarkerProperties(DocxAttributeOutput& rAttributeOutput, c
const SfxPoolItem* pItem = nullptr;
// Did we already produce a element?
bool bFontSizeWritten = false;
+bool bBoldWritten = false;
while (nWhichId)
{
if (aIter.GetItemState(true, ) == SfxItemState::SET && nWhichId
!= RES_CHRATR_GRABBAG)
@@ -1370,10 +1371,13 @@ void
lcl_writeParagraphMarkerProperties(DocxAttributeOutput& rAttributeOutput, c
{
// Will this item produce a element?
bool bFontSizeItem = nWhichId == RES_CHRATR_FONTSIZE ||
nWhichId == RES_CHRATR_CJK_FONTSIZE;
-if (!bFontSizeWritten || !bFontSizeItem)
+bool bBoldItem = nWhichId == RES_CHRATR_WEIGHT || nWhichId ==
RES_CHRATR_CJK_WEIGHT;
+if (!(bFontSizeWritten && bFontSizeItem) && !(bBoldWritten &&
bBoldItem))
rAttributeOutput.OutputItem(*pItem);
if (bFontSizeItem)
bFontSizeWritten = true;
+if (bBoldItem)
+bBoldWritten = true;
}
else if (nWhichId == RES_TXTATR_AUTOFMT)
{
diff --git a/sw/source/filter/ww8/writerhelper.cxx
b/sw/source/filter/ww8/writerhelper.cxx
index 61be965848e6..5a45a6dbb04b 100644
--- a/sw/source/filter/ww8/writerhelper.cxx
+++ b/sw/source/filter/ww8/writerhelper.cxx
@@ -401,6 +401,18 @@ namespace sw
while ((pItem = aIter.NextItem()));
}
}
+//DeduplicateItems(rItems);
+}
+
+void DeduplicateItems(ww8::PoolItems & rItems)
+{
+if (rItems.find(RES_CHRATR_WEIGHT) != rItems.end()
+&& rItems.find(RES_CHRATR_CJK_WEIGHT) != rItems.end())
+{
+// avoid duplicate w:b element (DOC and DOCX map Western and
+// CJK the same - inconsistently RTF maps CJK and CTL the
same?)
+rItems.erase(rItems.find(RES_CHRATR_CJK_WEIGHT));
+}
}
const SfxPoolItem *SearchPoolItems(const ww8::PoolItems ,
diff --git a/sw/source/filter/ww8/writerhelper.hxx
b/sw/source/filter/ww8/writerhelper.hxx
index 632d1cb3a639..27442fceb0b9 100644
--- a/sw/source/filter/ww8/writerhelper.hxx
+++ b/sw/source/filter/ww8/writerhelper.hxx
@@ -317,6 +317,8 @@ namespace sw
*/
void GetPoolItems(const SfxItemSet , ww8::PoolItems , bool
bExportParentItemSet
[Libreoffice-bugs] [Bug 152266] A macro warning shows because of stale events assignment, but no indication in UI for that
https://bugs.documentfoundation.org/show_bug.cgi?id=152266 Caolán McNamara changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | Status|NEW |ASSIGNED --- Comment #1 from Caolán McNamara --- We can at least not warn if there is not macro/target associated with the event, which is the case in these examples: https://gerrit.libreoffice.org/c/core/+/143829 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152266] A macro warning shows because of stale events assignment, but no indication in UI for that
https://bugs.documentfoundation.org/show_bug.cgi?id=152266 Caolán McNamara changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.
