[Libreoffice-bugs] [Bug 152506] Footnote order error, first footnote replaced.
https://bugs.documentfoundation.org/show_bug.cgi?id=152506 NISZ LibreOffice Team changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #3 from NISZ LibreOffice Team --- Verified in: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: ad387d5b984c906505d25685065f710ed55d CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: hu-HU (hu_HU); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: compilerplugins/clang
compilerplugins/clang/includeform.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 8fe55893af1f62219f9ebb1da9527ce8aa0fbd81 Author: Noel Grandin AuthorDate: Tue Dec 20 09:08:29 2022 +0200 Commit: Noel Grandin CommitDate: Tue Dec 20 07:52:20 2022 + Adapt to PPCallbacks::InclusionDirective change in Clang 16 trunk Attempt to follow the unfolding debate here, it was std::optional briefly, but then that was reverted with commit 205c0589f918f95d2f2c586a01bea2716d73d603 Revert "[clang] Convert OptionalFileEntryRefDegradesToFileEntryPtr to std::optional" and then a different changed landed with commit 854c10f8d185286d941307e1033eb492e085c203 Date: Tue Dec 20 00:15:11 2022 +0100 [Clang] Prepare for llvm::Optional becoming std::optional. Change-Id: I0068960a45695014405437206d8d4565562b0af9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144575 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/compilerplugins/clang/includeform.cxx b/compilerplugins/clang/includeform.cxx index 558c9b423345..583cb059bc40 100644 --- a/compilerplugins/clang/includeform.cxx +++ b/compilerplugins/clang/includeform.cxx @@ -31,7 +31,7 @@ private: SourceLocation HashLoc, Token const & IncludeTok, StringRef, bool IsAngled, CharSourceRange FilenameRange, #if CLANG_VERSION >= 16 -std::optional File, +OptionalFileEntryRef File, #elif CLANG_VERSION >= 15 Optional File, #else
[Libreoffice-bugs] [Bug 151062] The UI flickering and lagging in GTK3. The Page following scroll from style format when it scrolling
https://bugs.documentfoundation.org/show_bug.cgi?id=151062 Buovjaga changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||ilmari.lauhakangas@libreoff ||ice.org --- Comment #3 from Buovjaga --- See bug 144813 comment 8. Do you have GTK_IM_MODULE=xim environment variable set in your .xinputrc file? https://askubuntu.com/questions/1388589/libreoffice-7-2-5-2-ubuntu-20-04-1-lts-flickering-menus-and-right-panel/1434282#1434282 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151686] rapid flickering and alternating see through layers
https://bugs.documentfoundation.org/show_bug.cgi?id=151686 Buovjaga changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 Whiteboard| QA:needsComment| CC||ilmari.lauhakangas@libreoff ||ice.org --- Comment #2 from Buovjaga --- See bug 144813 comment 8. Do you have GTK_IM_MODULE=xim environment variable set in your .xinputrc file? https://askubuntu.com/questions/1388589/libreoffice-7-2-5-2-ubuntu-20-04-1-lts-flickering-menus-and-right-panel/1434282#1434282 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sc/qa sc/source
sc/qa/uitest/autofilter/autofilterBugs.py | 18 ++
sc/qa/uitest/data/autofilter/tdf152082.ods |binary
sc/source/filter/xml/xmlfilti.cxx |2 ++
3 files changed, 20 insertions(+)
New commits:
commit f6728e75f814bfc4df533469ff7d90601de490e6
Author: Tünde Tóth
AuthorDate: Wed Dec 7 12:44:18 2022 +0100
Commit: László Németh
CommitDate: Tue Dec 20 07:51:29 2022 +
tdf#152082 ODS: fix import of Empty filter operator
Bad import of the Empty filter operator resulted shifted
filter settings, e.g. selected "A" and "B" instead of
"empty" and "A" from the range "empty", "A" and "B".
Regression from commit f6b143a57d9bd8f5d7b29febcb4e01ee1eb2ff1d
"tdf#142910 sc filter: fix "greater than" or "smaller than" etc".
Change-Id: I33082d77fb9e707aa474fb22753a001960341d66
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143776
Tested-by: László Németh
Reviewed-by: László Németh
(cherry picked from commit 1f30f9cf012cee6823029ef5a96a1d91a0e16cdc)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144481
Tested-by: Jenkins
diff --git a/sc/qa/uitest/autofilter/autofilterBugs.py
b/sc/qa/uitest/autofilter/autofilterBugs.py
index a295c6307793..864cde7d83a0 100644
--- a/sc/qa/uitest/autofilter/autofilterBugs.py
+++ b/sc/qa/uitest/autofilter/autofilterBugs.py
@@ -252,4 +252,22 @@ class autofilter(UITestCase):
xCancel = xFloatWindow.getChild("cancel")
xCancel.executeAction("CLICK", tuple())
+#tdf152082
+ def test_tdf152082(self):
+with self.ui_test.load_file(get_url_for_data_file("tdf152082.ods")):
+xCalcDoc = self.xUITest.getTopFocusWindow()
+gridwin = xCalcDoc.getChild("grid_window")
+
+gridwin.executeAction("LAUNCH", mkPropertyValues({"AUTOFILTER":
"", "COL": "0", "ROW": "0"}))
+xFloatWindow = self.xUITest.getFloatWindow()
+xCheckListMenu = xFloatWindow.getChild("FilterDropDown")
+xTreeList = xCheckListMenu.getChild("check_list_box")
+self.assertEqual(4, len(xTreeList.getChildren()))
+self.assertEqual('true',
get_state_as_dict(xTreeList.getChild('0'))['IsChecked'])
+self.assertEqual('true',
get_state_as_dict(xTreeList.getChild('1'))['IsChecked'])
+self.assertEqual('true',
get_state_as_dict(xTreeList.getChild('2'))['IsChecked'])
+self.assertEqual('false',
get_state_as_dict(xTreeList.getChild('3'))['IsChecked'])
+xCancelBtn = xFloatWindow.getChild("cancel")
+xCancelBtn.executeAction("CLICK", tuple())
+
# vim: set shiftwidth=4 softtabstop=4 expandtab:
diff --git a/sc/qa/uitest/data/autofilter/tdf152082.ods
b/sc/qa/uitest/data/autofilter/tdf152082.ods
new file mode 100644
index ..6a0e1cac6751
Binary files /dev/null and b/sc/qa/uitest/data/autofilter/tdf152082.ods differ
diff --git a/sc/source/filter/xml/xmlfilti.cxx
b/sc/source/filter/xml/xmlfilti.cxx
index e549a3438d78..7585ce0c50fa 100644
--- a/sc/source/filter/xml/xmlfilti.cxx
+++ b/sc/source/filter/xml/xmlfilti.cxx
@@ -422,6 +422,8 @@ void SAL_CALL ScXMLConditionContext::endFastElement(
sal_Int32 /*nElement*/ )
if (maQueryItems.empty())
{
ScQueryEntry::Item& rItem = rEntry.GetQueryItem();
+if (IsXMLToken(sOperator, XML_EMPTY))
+return;
if (IsXMLToken(sDataType, XML_NUMBER))
{
rItem.mfVal = sConditionValue.toDouble();
[Libreoffice-bugs] [Bug 148388] LibreOffice (either Writer, or Calc, etc.) side panel flicker behaviour on Linux AMD64 (GFX stack or OpenGL issue)
https://bugs.documentfoundation.org/show_bug.cgi?id=148388 Buovjaga changed: What|Removed |Added CC||ilmari.lauhakangas@libreoff ||ice.org Whiteboard| QA:needsComment| Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #2 from Buovjaga --- See bug 144813 comment 8. Do you have GTK_IM_MODULE=xim environment variable set in your .xinputrc file? https://askubuntu.com/questions/1388589/libreoffice-7-2-5-2-ubuntu-20-04-1-lts-flickering-menus-and-right-panel/1434282#1434282 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 65535] Correcting a misspelled word with a comment in the middle erases the comment (see comment 38)
https://bugs.documentfoundation.org/show_bug.cgi?id=65535 --- Comment #50 from Commit Notification --- László Németh committed a patch related to this issue. It has been pushed to "libreoffice-7-5": https://git.libreoffice.org/core/commit/97a3c604d3a05c0011827eef761056c5198e44dc tdf#65535 sw: fix lost comment at fixing spelling with context menu It will be available in 7.5.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - sw/qa sw/source
sw/qa/extras/uiwriter/data/tdf65535.fodt | 14 +
sw/qa/extras/uiwriter/uiwriter6.cxx | 80 +++
sw/source/uibase/shells/textsh1.cxx | 23
3 files changed, 116 insertions(+), 1 deletion(-)
New commits:
commit 97a3c604d3a05c0011827eef761056c5198e44dc
Author: László Németh
AuthorDate: Sun Dec 18 10:03:18 2022 +0100
Commit: László Németh
CommitDate: Tue Dec 20 07:50:40 2022 +
tdf#65535 sw: fix lost comment at fixing spelling with context menu
Also fix the bad Undo label, where the invisible IAA character
became visible.
Choosing one of the spelling suggestions of the context menu
of a bad word fixed the spelling of the original word, but
also deleted its inword comment. Keep the comment at the end
of the fixed word.
Fix also the bad Undo label, which contained the original
word with the Interlinear Annotation Anchor (IAA) character.
Now it shows only the word, but not the Unicode replacement
glyph of IAA.
Regression from commit b0f170d7df9cff12535d2ecfd146b32b745a8ef8
"0xFFF9 is a better choice for CH_TXTATR_INWORD than 0x0002".
Change-Id: I5bfa214a060c446e9897e806832bedfe54241e1e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144397
Tested-by: László Németh
Reviewed-by: László Németh
(cherry picked from commit 1e4709f47dec87d5d2b66f3de222588c3babaf18)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144489
Tested-by: Jenkins
diff --git a/sw/qa/extras/uiwriter/data/tdf65535.fodt
b/sw/qa/extras/uiwriter/data/tdf65535.fodt
new file mode 100644
index ..b3a738bc8ac8
--- /dev/null
+++ b/sw/qa/extras/uiwriter/data/tdf65535.fodt
@@ -0,0 +1,14 @@
+
+
+http://www.w3.org/TR/css3-text/;
xmlns:grddl="http://www.w3.org/2003/g/data-view#;
xmlns:xhtml="http://www.w3.org/1999/xhtml;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xmlns:xsd="http://www.w3.org/2001/XMLSchema;
xmlns:xforms="http://www.w3.org/2002/xforms;
xmlns:dom="http://www.w3.org/2001/xml-events;
xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0"
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0"
xmlns:math="http://www.w3.org/1998/Math/MathML;
xmlns:office="urn:oasis:names:tc:opendocument:xmlns:office:1.0"
xmlns:ooo="http://openoffice.org/2004/office;
xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0"
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0"
xmlns:ooow="http://openoffice.org/2004/writer;
xmlns:xlink="http://www.w3.org/1999/xlink;
xmlns:drawooo="http://openoffice.org/2010/draw;
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
xmlns:meta="u
rn:oasis:names:tc:opendocument:xmlns:meta:1.0"
xmlns:oooc="http://openoffice.org/2004/calc;
xmlns:dc="http://purl.org/dc/elements/1.1/;
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
xmlns:style="urn:oasis:names:tc:opendocument:xmlns:style:1.0"
xmlns:text="urn:oasis:names:tc:opendocument:xmlns:text:1.0"
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2"
xmlns:tableooo="http://openoffice.org/2009/table;
xmlns:draw="urn:oasis:names:tc:opendocument:xmlns:drawing:1.0"
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0"
xmlns:rpt="http://openoffice.org/2005/report;
xmlns:formx="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0"
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0"
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0"
xmlns:officeooo="http://openoffice.org/2009/office;
xmlns:table="urn:oasis:names:tc:opendocument:xmlns:table:1.0"
xmlns:field="urn:openoffice:names:experimental:ooo-ms
-interop:xmlns:field:1.0"
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0"
office:version="1.3" office:mimetype="application/vnd.oasis.opendocument.text">
+
2022-12-17T23:29:19.7819935302022-12-17T23:30:52.855431377PT1M34S1LibreOfficeDev/7.5.0.0.alpha0$Linux_X86_64
LibreOffice_project/be538308dd5dee33436ae0e247c315df63a8b958
+
+
+ Ba
+ x
+ 2022-12-17T23:29:53.289798307
+ with
comment
+ad
+
+
+
diff --git a/sw/qa/extras/uiwriter/uiwriter6.cxx
b/sw/qa/extras/uiwriter/uiwriter6.cxx
index 305e4fa18732..a3cda9eca08f 100644
--- a/sw/qa/extras/uiwriter/uiwriter6.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter6.cxx
@@ -29,6 +29,14 @@
#include
#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
#include
#include
#include
@@ -1430,6 +1438,78 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest6, testTdf124603)
}
}
+CPPUNIT_TEST_FIXTURE(SwUiWriterTest6, testTdf65535)
+{
+#if !defined(MACOSX)
+createSwDoc("tdf65535.fodt");
+SwXTextDocument* pTextDoc =
dynamic_cast(mxComponent.get());
+SwWrtShell* pWrtShell = pTextDoc->GetDocShell()->GetWrtShell();
+const SwViewOption* pOpt = pWrtShell->GetViewOptions();
+
[Libreoffice-bugs] [Bug 65535] Correcting a misspelled word with a comment in the middle erases the comment (see comment 38)
https://bugs.documentfoundation.org/show_bug.cgi?id=65535 Commit Notification changed: What|Removed |Added Whiteboard|BSA target:7.3.0|BSA target:7.3.0 |target:7.2.1 target:7.6.0 |target:7.2.1 target:7.6.0 ||target:7.5.0.0.beta2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - 2 commits - oox/source sc/qa sc/source sd/qa
oox/source/export/shapes.cxx | 10 ++
sc/qa/uitest/autofilter2/tdf151152.py | 52 ++
sc/source/ui/view/gridwin.cxx | 14 +++--
sd/qa/unit/data/pptx/ole-emf_min.pptx |binary
sd/qa/unit/export-tests-ooxml3.cxx| 11 +++
5 files changed, 84 insertions(+), 3 deletions(-)
New commits:
commit b3ed83265c1ba0c6d15be0bafd6d16b9a87cc64a
Author: Tünde Tóth
AuthorDate: Tue Dec 13 11:08:52 2022 +0100
Commit: László Németh
CommitDate: Tue Dec 20 07:50:25 2022 +
tdf#152436 PPTX export regression: fix lost shape at missing object
If the object is missing, it's still possible to keep its shape
by exporting its preview graphic, as before the regression.
Regression from commit adc042f95d3dbd65b778260025d59283146916e5
"tdf#124333 PPTX import: fix Z-order of embedded OLE objects".
Change-Id: Ib2fd00f53a80572cfc9acaefea55015780c57da8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144040
Tested-by: László Németh
Reviewed-by: László Németh
(cherry picked from commit 907da02bf8b33c080538731864225b3c44251328)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144486
Tested-by: Jenkins
diff --git a/oox/source/export/shapes.cxx b/oox/source/export/shapes.cxx
index 70466d17fdb1..4b41f56d79cd 100644
--- a/oox/source/export/shapes.cxx
+++ b/oox/source/export/shapes.cxx
@@ -2537,6 +2537,16 @@ ShapeExport& ShapeExport::WriteOLE2Shape( const
Reference< XShape >& xShape )
if (!xObj.is())
{
SAL_WARN("oox.shape", "ShapeExport::WriteOLE2Shape: no object");
+
+// tdf#152436 Export the preview graphic of the object if the object
is missing.
+SdrObject* pSdrOLE2(SdrObject::getSdrObjectFromXShape(xShape));
+if (auto pOle2Obj = dynamic_cast(pSdrOLE2))
+{
+const Graphic* pGraphic = pOle2Obj->GetGraphic();
+if (pGraphic)
+WriteGraphicObjectShapePart(xShape, pGraphic);
+}
+
return *this;
}
diff --git a/sd/qa/unit/data/pptx/ole-emf_min.pptx
b/sd/qa/unit/data/pptx/ole-emf_min.pptx
new file mode 100644
index ..0f97208fbebc
Binary files /dev/null and b/sd/qa/unit/data/pptx/ole-emf_min.pptx differ
diff --git a/sd/qa/unit/export-tests-ooxml3.cxx
b/sd/qa/unit/export-tests-ooxml3.cxx
index 2e6a600ec686..309709317821 100644
--- a/sd/qa/unit/export-tests-ooxml3.cxx
+++ b/sd/qa/unit/export-tests-ooxml3.cxx
@@ -130,6 +130,7 @@ public:
void testTdf124333();
void testAutofittedTextboxIndent();
void testTdf151622_oleIcon();
+void testTdf152436();
CPPUNIT_TEST_SUITE(SdOOXMLExportTest3);
@@ -221,6 +222,7 @@ public:
CPPUNIT_TEST(testTdf124333);
CPPUNIT_TEST(testAutofittedTextboxIndent);
CPPUNIT_TEST(testTdf151622_oleIcon);
+CPPUNIT_TEST(testTdf152436);
CPPUNIT_TEST_SUITE_END();
virtual void registerNamespaces(xmlXPathContextPtr& pXmlXPathCtx) override
@@ -2105,6 +2107,15 @@ void SdOOXMLExportTest3::testTdf151622_oleIcon()
assertXPath(pXml, "//p:oleObj", "showAsIcon", "1");
}
+void SdOOXMLExportTest3::testTdf152436()
+{
+createSdImpressDoc("pptx/ole-emf_min.pptx");
+saveAndReload("Impress Office Open XML");
+
+// Check number of shapes after export.
+CPPUNIT_ASSERT_EQUAL(sal_Int32(1), getPage(0)->getCount());
+}
+
CPPUNIT_TEST_SUITE_REGISTRATION(SdOOXMLExportTest3);
CPPUNIT_PLUGIN_IMPLEMENT();
commit 438192f4947669e6c514bc25ce95d9eba38ce39c
Author: Tünde Tóth
AuthorDate: Wed Dec 7 13:34:37 2022 +0100
Commit: László Németh
CommitDate: Tue Dec 20 07:50:12 2022 +
tdf#151152 sc filter: fix string entry checking
When a column was filtered for values that included 0,
the all string entries were always checked in the Autofilter
dropdown (because their conversion to number, i.e. value 0
was used to check their existence in the filtered values
instead of their string value).
Regression from commit f6b143a57d9bd8f5d7b29febcb4e01ee1eb2ff1d
"tdf#142910 sc filter: fix "greater than" or "smaller than" etc".
Change-Id: Ib659aba9d6f3d6bc3557547b1a27963f51e3eca3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143777
Tested-by: László Németh
Reviewed-by: László Németh
(cherry picked from commit 2298087db28ee1b4251cac6e12c1d4806b395a1e)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144479
Tested-by: Jenkins
diff --git a/sc/qa/uitest/autofilter2/tdf151152.py
b/sc/qa/uitest/autofilter2/tdf151152.py
new file mode 100644
index ..6971096e9844
--- /dev/null
+++ b/sc/qa/uitest/autofilter2/tdf151152.py
@@ -0,0 +1,52 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - sw/qa sw/source
sw/qa/uitest/data/tdf65535.fodt | 14 ++
sw/qa/uitest/writer_tests4/spellDialog.py | 41 ++
sw/source/core/edit/edlingu.cxx | 16 +++
3 files changed, 71 insertions(+)
New commits:
commit 0d2f45934327c199ac6651f149d9a9b39393cc96
Author: László Németh
AuthorDate: Mon Dec 19 10:12:45 2022 +0100
Commit: László Németh
CommitDate: Tue Dec 20 07:49:48 2022 +
tdf#65535 sw: fix lost comments using spelling dialog
Choosing one of the spelling suggestions in the spelling
dialog, or rewriting the bad word removed also its
inword comment. Keep the comment at the end of the fixed word.
Regression from commit b0f170d7df9cff12535d2ecfd146b32b745a8ef8
"0xFFF9 is a better choice for CH_TXTATR_INWORD than 0x0002".
Change-Id: Iaf083453fad4e0ca99e254f53b20ead86b3ba15e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144458
Tested-by: Jenkins
Tested-by: László Németh
Reviewed-by: László Németh
(cherry picked from commit 5ecb61c81238b5bc802dd5afcab18e8331ed3d9d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144483
diff --git a/sw/qa/uitest/data/tdf65535.fodt b/sw/qa/uitest/data/tdf65535.fodt
new file mode 100644
index ..b3a738bc8ac8
--- /dev/null
+++ b/sw/qa/uitest/data/tdf65535.fodt
@@ -0,0 +1,14 @@
+
+
+http://www.w3.org/TR/css3-text/;
xmlns:grddl="http://www.w3.org/2003/g/data-view#;
xmlns:xhtml="http://www.w3.org/1999/xhtml;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xmlns:xsd="http://www.w3.org/2001/XMLSchema;
xmlns:xforms="http://www.w3.org/2002/xforms;
xmlns:dom="http://www.w3.org/2001/xml-events;
xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0"
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0"
xmlns:math="http://www.w3.org/1998/Math/MathML;
xmlns:office="urn:oasis:names:tc:opendocument:xmlns:office:1.0"
xmlns:ooo="http://openoffice.org/2004/office;
xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0"
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0"
xmlns:ooow="http://openoffice.org/2004/writer;
xmlns:xlink="http://www.w3.org/1999/xlink;
xmlns:drawooo="http://openoffice.org/2010/draw;
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
xmlns:meta="u
rn:oasis:names:tc:opendocument:xmlns:meta:1.0"
xmlns:oooc="http://openoffice.org/2004/calc;
xmlns:dc="http://purl.org/dc/elements/1.1/;
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
xmlns:style="urn:oasis:names:tc:opendocument:xmlns:style:1.0"
xmlns:text="urn:oasis:names:tc:opendocument:xmlns:text:1.0"
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2"
xmlns:tableooo="http://openoffice.org/2009/table;
xmlns:draw="urn:oasis:names:tc:opendocument:xmlns:drawing:1.0"
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0"
xmlns:rpt="http://openoffice.org/2005/report;
xmlns:formx="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0"
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0"
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0"
xmlns:officeooo="http://openoffice.org/2009/office;
xmlns:table="urn:oasis:names:tc:opendocument:xmlns:table:1.0"
xmlns:field="urn:openoffice:names:experimental:ooo-ms
-interop:xmlns:field:1.0"
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0"
office:version="1.3" office:mimetype="application/vnd.oasis.opendocument.text">
+
2022-12-17T23:29:19.7819935302022-12-17T23:30:52.855431377PT1M34S1LibreOfficeDev/7.5.0.0.alpha0$Linux_X86_64
LibreOffice_project/be538308dd5dee33436ae0e247c315df63a8b958
+
+
+ Ba
+ x
+ 2022-12-17T23:29:53.289798307
+ with
comment
+ad
+
+
+
diff --git a/sw/qa/uitest/writer_tests4/spellDialog.py
b/sw/qa/uitest/writer_tests4/spellDialog.py
index 183a85843ab9..d7990cdf494e 100644
--- a/sw/qa/uitest/writer_tests4/spellDialog.py
+++ b/sw/qa/uitest/writer_tests4/spellDialog.py
@@ -205,4 +205,45 @@ frog, dogg, catt"""
# This was "Baaed HTTP://www. baaad .org baaed" (skipped non-URL
words of hypertext)
self.assertEqual("Baaed http://www. baaed .org baaad", output_text)
+def test_tdf65535(self):
+supported_locale = self.is_supported_locale("en", "US")
+if not supported_locale:
+self.skipTest("no dictionary support for en_US available")
+
+with self.ui_test.load_file(get_url_for_data_file("tdf65535.fodt")) as
document:
+cursor = document.getCurrentController().getViewCursor()
+# Inserted text must be en_US, so make sure to set language in
current location
+cursor.CharLocale = Locale("en", "US", "")
+
+xMainWindow = self.xUITest.getTopFocusWindow()
+xEdit = xMainWindow.getChild("writer_edit")
+
+# type a bad word after the word with comment
+
[Libreoffice-bugs] [Bug 144813] Tabbed UI (drop down box) and sidebar options - rapid blinking/flashing.
https://bugs.documentfoundation.org/show_bug.cgi?id=144813 Buovjaga changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #10 from Buovjaga --- Nice work, Roland! Let's put this to needinfo pending Chris checking the same. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/inc
sw/inc/fmtcol.hxx |2 ++
1 file changed, 2 insertions(+)
New commits:
commit 6d5262209a89127880c888c2ef0dc4e0da7f6ea1
Author: Miklos Vajna
AuthorDate: Mon Dec 19 20:25:17 2022 +0100
Commit: Miklos Vajna
CommitDate: Tue Dec 20 07:48:20 2022 +
sw: document SwFormatColl
I.e. first what's confusing is that SwCharFormat doesn't derive from
SwFormatColl, and the answer is that in practice it doesn't matter too
much, as long as in practice user-visible char styles are SwCharFormats
where SetAuto(false) is called in some other way.
Change-Id: Ie85f9bf947348b5ef7051f055c5b931a8a2b932a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144544
Tested-by: Jenkins
Reviewed-by: Miklos Vajna
diff --git a/sw/inc/fmtcol.hxx b/sw/inc/fmtcol.hxx
index 00e5208b73f4..6a477e1f5ca3 100644
--- a/sw/inc/fmtcol.hxx
+++ b/sw/inc/fmtcol.hxx
@@ -32,6 +32,8 @@
class SwAttrPool;
namespace sw{ class DocumentStylePoolManager; }
+/// SwFormatColl is just an SwFormat subclass that defaults to
m_bAutoFormat=false, expressing that
+/// this set of formatting is a style, not direct formatting.
class SAL_DLLPUBLIC_RTTI SwFormatColl: public SwFormat
{
protected:
[Libreoffice-commits] core.git: basic/qa
basic/qa/basic_coverage/test_transliteration.bas | 52 +++
1 file changed, 52 insertions(+)
New commits:
commit c6dc676306d2e507bf57369d02dcaf2408d43eb0
Author: Xisco Fauli
AuthorDate: Mon Dec 19 17:42:36 2022 +0100
Commit: Xisco Fauli
CommitDate: Tue Dec 20 07:47:34 2022 +
tdf#152520: basic_macros: Add unittest
Change-Id: I30f6badc620f3932cacff07bd37ef4da96f1bafd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144539
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/basic/qa/basic_coverage/test_transliteration.bas
b/basic/qa/basic_coverage/test_transliteration.bas
new file mode 100644
index ..01a5705d0a0d
--- /dev/null
+++ b/basic/qa/basic_coverage/test_transliteration.bas
@@ -0,0 +1,52 @@
+' This file is part of the LibreOffice project.
+'
+' This Source Code Form is subject to the terms of the Mozilla Public
+' License, v. 2.0. If a copy of the MPL was not distributed with this
+' file, You can obtain one at http://mozilla.org/MPL/2.0/.
+'
+
+Option Explicit
+
+Function doUnitTest() As String
+TestUtil.TestInit
+verify_testTransliteration
+doUnitTest = TestUtil.GetResult()
+End Function
+
+Sub verify_testTransliteration
+On Error GoTo errorHandler
+
+ Dim oTr As Object, s$, oLoc as new com.sun.star.lang.Locale
+
+ With oLoc
+ .Country="US"
+ .Language="en"
+ .Variant=""
+ End With
+
+s="AB cd. eF. "
+ oTr = CreateUnoService("com.sun.star.i18n.Transliteration")
+
+ oTr.LoadModuleByImplName("LOWERCASE_UPPERCASE", oLoc)
+ TestUtil.AssertEqual(oTr.transliterateString2String(s, 0, Len(s)), "AB
CD. EF. ", "LOWERCASE_UPPERCASE")
+
+ oTr.LoadModuleByImplName("UPPERCASE_LOWERCASE", oLoc)
+ TestUtil.AssertEqual(oTr.transliterateString2String(s, 0, Len(s)), "ab
cd. ef. ", "UPPERCASE_LOWERCASE")
+
+ oTr.LoadModuleByImplName("TOGGLE_CASE", oLoc)
+ TestUtil.AssertEqual(oTr.transliterateString2String(s, 0, Len(s)), "ab
CD. Ef. ", "TOGGLE_CASE")
+
+ oTr.LoadModuleByImplName("IGNORE_CASE", oLoc)
+ TestUtil.AssertEqual(oTr.transliterateString2String(s, 0, Len(s)), "ab
cd. ef. ", "IGNORE_CASE")
+
+' tdf#152520: Without the fix in place, this test would have crashed here
+ oTr.LoadModuleByImplName("TITLE_CASE", oLoc)
+ TestUtil.AssertEqual(oTr.transliterateString2String(s, 0, Len(s)), "Ab
cd. ef. ", "TITLE_CASE")
+
+ oTr.LoadModuleByImplName("SENTENCE_CASE", oLoc)
+ TestUtil.AssertEqual(oTr.transliterateString2String(s, 0, Len(s)), "Ab
cd. ef. ", "SENTENCE_CASE")
+
+Exit Sub
+errorHandler:
+TestUtil.ReportErrorHandler("verify_testTransliteration", Err, Error$, Erl)
+End Sub
[Libreoffice-bugs] [Bug 152285] CLONE FORMATTING DOCX: Clone formatting of font is no longer applied after saving and reloading
https://bugs.documentfoundation.org/show_bug.cgi?id=152285 --- Comment #8 from Mike Kaganski --- Created attachment 184254 --> https://bugs.documentfoundation.org/attachment.cgi?id=184254=edit Minimal reproducer with a parahraph having a character style applied Reproduce from scratch: 1. Create a new text document; 2. Add a couple of paragraph; 3. Assign a *character style* with a distinct font name (e.g., "Source Text" that defines use of Liberation Mono) to the whole entirety of one of them; 4. Save as DOCX, and *reload*; 5. Using Clone Formatting tool (in normal mode, without any modifier keys), copy the formatting from the paragraph *without* character style, and select the whole entirety of the paragraph with the character style as the target; 6. Save and reload. After step 5, the paragraph having the character style will look identically to the look of the other paragraph: the character style formatting will get overwritten by character-level formatting applied atop. After step 6, the paragraph will have the font name defined by the character style (and the character-level direct formatting will not specify the font name, as seen in Style Inspector). The attachment has a file after steps 1-4. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - translations
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 0a7a6bba43f06e9e8d71b77c8dca2c4cfd692605 Author: Martin Srebotnjak AuthorDate: Tue Dec 20 08:27:22 2022 +0100 Commit: Gerrit Code Review CommitDate: Tue Dec 20 07:27:22 2022 + Update git submodules * Update translations from branch 'libreoffice-7-5' to b2dbdb1a0775668579b45c3cdac65b67c31bcb65 - Updated Slovenian translation Change-Id: Ib6c9e874bc1407a134930774568b2812bcb1a9c3 diff --git a/translations b/translations index bb16a8bd8397..b2dbdb1a0775 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit bb16a8bd8397622a783fc874c1eebb4148d74711 +Subproject commit b2dbdb1a0775668579b45c3cdac65b67c31bcb65
[Libreoffice-commits] translations.git: Branch 'libreoffice-7-5' - source/sl
source/sl/cui/messages.po | 87 source/sl/helpcontent2/source/text/sbasic/shared.po| 28 source/sl/helpcontent2/source/text/sbasic/shared/03.po | 1488 - source/sl/helpcontent2/source/text/scalc/01.po | 14 source/sl/helpcontent2/source/text/sdatabase.po|4 source/sl/helpcontent2/source/text/shared/00.po|2 source/sl/helpcontent2/source/text/shared/01.po| 18 source/sl/helpcontent2/source/text/shared/02.po| 10 source/sl/helpcontent2/source/text/swriter.po |8 source/sl/officecfg/registry/data/org/openoffice/Office.po | 10 source/sl/sc/messages.po | 54 source/sl/sd/messages.po |4 source/sl/sfx2/messages.po | 135 - source/sl/svtools/messages.po |4 source/sl/svx/messages.po | 26 source/sl/sw/messages.po | 82 source/sl/wizards/messages.po | 26 source/sl/wizards/source/resources.po | 26 18 files changed, 1724 insertions(+), 302 deletions(-) New commits: commit b2dbdb1a0775668579b45c3cdac65b67c31bcb65 Author: Martin Srebotnjak AuthorDate: Tue Dec 20 08:27:17 2022 +0100 Commit: Andras Timar CommitDate: Tue Dec 20 08:27:17 2022 +0100 Updated Slovenian translation Change-Id: Ib6c9e874bc1407a134930774568b2812bcb1a9c3 diff --git a/source/sl/cui/messages.po b/source/sl/cui/messages.po index 708839ac3e6..f808a725d9c 100644 --- a/source/sl/cui/messages.po +++ b/source/sl/cui/messages.po @@ -3,14 +3,14 @@ msgid "" msgstr "" "Project-Id-Version: LibreOffice 7.5\n" "Report-Msgid-Bugs-To: https://bugs.libreoffice.org/enter_bug.cgi?product=LibreOffice_status=UNCONFIRMED=UI\n; -"POT-Creation-Date: 2022-12-07 21:45+0100\n" -"PO-Revision-Date: 2022-12-04 11:56+0200\n" +"POT-Creation-Date: 2022-12-18 20:11+0100\n" +"PO-Revision-Date: 2022-12-18 22:38+0200\n" "Last-Translator: Martin Srebotnjak \n" "Language-Team: sl.libreoffice.org\n" +"Language: sl\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" "Content-Transfer-Encoding: 8bit\n" -"Language: sl\n" "Plural-Forms: nplurals=4; plural=(n%100==1 ? 0 : n%100==2 ? 1 : n%100==3 || n%100==4 ? 2 : 3);\n" "X-Generator: Virtaal 0.7.1\n" "X-Accelerator-Marker: ~\n" @@ -7614,32 +7614,37 @@ msgctxt "eventsconfigpage|extended_tip|delete" msgid "Deletes the macro or component assignment for the selected event." msgstr "Izbriše dodelitve makra ali komponente za izbrani dogodek." -#: cui/uiconfig/ui/eventsconfigpage.ui:130 +#: cui/uiconfig/ui/eventsconfigpage.ui:100 +msgctxt "eventsconfigpage|deleteall" +msgid "Remove _All" +msgstr "Odstrani _vse" + +#: cui/uiconfig/ui/eventsconfigpage.ui:144 msgctxt "eventsconfigpage|label2" msgid "Save in:" msgstr "Shrani v:" -#: cui/uiconfig/ui/eventsconfigpage.ui:147 +#: cui/uiconfig/ui/eventsconfigpage.ui:161 msgctxt "eventsconfigpage|extended_tip|savein" msgid "Select first where to save the event binding, in the current document or in the office suite." msgstr "Najprej izberite, kje želite shraniti dogodkovno vezavo; v trenutnem dokumentu ali v pisarniškem paketu." -#: cui/uiconfig/ui/eventsconfigpage.ui:186 +#: cui/uiconfig/ui/eventsconfigpage.ui:200 msgctxt "eventsconfigpage|eventft" msgid "Event" msgstr "Dogodek" -#: cui/uiconfig/ui/eventsconfigpage.ui:210 +#: cui/uiconfig/ui/eventsconfigpage.ui:224 msgctxt "eventsconfigpage|actionft" msgid "Assigned Action" msgstr "Dodeljeno dejanje" -#: cui/uiconfig/ui/eventsconfigpage.ui:221 +#: cui/uiconfig/ui/eventsconfigpage.ui:235 msgctxt "eventsconfigpage|extended_tip|events" msgid "The big list box lists the events and the assigned macros. After you selected the location in the Save In list box, select an event in the big list box. Then click Assign Macro." msgstr "Veliko seznamsko polje naredi seznam dogodkov in dodeljenih makrov. Potem ko ste v seznamskem polju Shrani v izbrali mesto, v velikem seznamskem polju izberite dogodek. Nato kliknite Dodeli makro." -#: cui/uiconfig/ui/eventsconfigpage.ui:246 +#: cui/uiconfig/ui/eventsconfigpage.ui:260 msgctxt "eventsconfigpage|extended_tip|EventsConfigPage" msgid "Assigns macros to program events. The assigned macro runs automatically every time the selected event occurs." msgstr "Programskim dogodkom se dodelijo makri. Vsakokrat, ko se pojavi izbrani dogodek, se dodeljeni makro samodejno zažene." @@ -10422,12 +10427,17 @@ msgctxt "macroassignpage|extended_tip|delete" msgid "Deletes the macro or component assignment for the selected event." msgstr "Izbriše dodelitve makra ali komponente za izbrani dogodek." -#: cui/uiconfig/ui/macroassignpage.ui:190 +#: cui/uiconfig/ui/macroassignpage.ui:186 +msgctxt
[Libreoffice-commits] core.git: compilerplugins/clang
compilerplugins/clang/includeform.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 99b5e216f107259d6e402896800282948997c4fa Author: Noel Grandin AuthorDate: Tue Dec 20 08:18:41 2022 +0200 Commit: Noel Grandin CommitDate: Tue Dec 20 07:25:27 2022 + fix compile error in compilerplugins home/noel/libo2/compilerplugins/clang/includeform.cxx:33:9: error: no template named 'optional' in namespace 'std'; did you mean 'Optional'? std::optional File, after commit b5023fa9abea248831271df99df0810351bd8c21 Date: Mon Dec 19 13:16:29 2022 +0100 Adapt to clang::PPCallbacks::InclusionDirective change in Clang 16 trunk Change-Id: I7acbfeac4fd138a1f6ae89f8b4b8cf918da04e30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144574 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/compilerplugins/clang/includeform.cxx b/compilerplugins/clang/includeform.cxx index e640e14b6859..558c9b423345 100644 --- a/compilerplugins/clang/includeform.cxx +++ b/compilerplugins/clang/includeform.cxx @@ -8,6 +8,7 @@ */ #include +#include #include "config_clang.h"
[Libreoffice-commits] core.git: xmlsecurity/source
xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit 5c7accf3e1d7bd550611af42d2eea07e590fde2f
Author: Stephan Bergmann
AuthorDate: Tue Dec 13 09:15:33 2022 +0100
Commit: Stephan Bergmann
CommitDate: Tue Dec 20 06:49:46 2022 +
Use XUnoTunnel instead of dynamic_cast here too
...like in other code accessing X509Certificate_NssImpl. (See the upcoming
commit introducing loplugin:unocast on why such dynamic_casts from UNO
types are
dangerous.
Change-Id: I65c8380ef0c3ab34a41142639e0e6fbfb4154b27
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144510
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx
b/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx
index 8872dd96b05a..d130c03723e9 100644
--- a/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx
+++ b/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx
@@ -813,7 +813,8 @@ xmlSecKeysMngrPtr
SecurityEnvironment_NssImpl::createKeysManager() {
throw RuntimeException();
// Adopt the private key of the signing certificate, if it has any.
-if (auto pCertificate =
dynamic_cast(m_xSigningCertificate.get()))
+if (auto pCertificate
+=
comphelper::getFromUnoTunnel(m_xSigningCertificate))
{
SECKEYPrivateKey* pPrivateKey =
SECKEY_CopyPrivateKey(pCertificate->getPrivateKey());
if (pPrivateKey)
[Libreoffice-commits] core.git: filter/source
filter/source/pdf/impdialog.cxx | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
New commits:
commit 241cd824fdd4bf02f393633c1e19d24f2f35f1c0
Author: Andras Timar
AuthorDate: Wed Dec 14 20:33:18 2022 +0100
Commit: Andras Timar
CommitDate: Tue Dec 20 06:40:49 2022 +
lok: hide 'View PDF after export' checkbox in PDF export dialog
Change-Id: I866e4765ba88ca6c93375c9fecd51f22b79ce72e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144535
Tested-by: Jenkins
Reviewed-by: Andras Timar
diff --git a/filter/source/pdf/impdialog.cxx b/filter/source/pdf/impdialog.cxx
index 2d8a366ae868..4a03de89fdef 100644
--- a/filter/source/pdf/impdialog.cxx
+++ b/filter/source/pdf/impdialog.cxx
@@ -632,7 +632,15 @@ void
ImpPDFTabGeneralPage::SetFilterConfigItem(ImpPDFTabDialog* pParent)
mxCbExportNotes->set_active( pParent->mbExportNotes );
mxCbExportNotesInMargin->set_active( pParent->mbExportNotesInMargin );
-mxCbViewPDF->set_active( pParent->mbViewPDF);
+if (comphelper::LibreOfficeKit::isActive())
+{
+mxCbViewPDF->hide();
+mxCbViewPDF->set_active(false);
+}
+else
+{
+ mxCbViewPDF->set_active(pParent->mbViewPDF);
+}
if ( mbIsPresentation )
{
[Libreoffice-commits] core.git: writerperfect/source
writerperfect/source/writer/EPUBExportDialog.cxx |5 +
writerperfect/source/writer/EPUBExportDialog.hxx |1 +
2 files changed, 6 insertions(+)
New commits:
commit 35d8b4c36299df39de36f2c7ade5727fc525eaab
Author: Szymon Kłos
AuthorDate: Wed Dec 14 09:29:22 2022 +0100
Commit: Andras Timar
CommitDate: Tue Dec 20 06:40:31 2022 +
lok: hide customization in EPUB export dialog
Change-Id: I531aba2eb52e74904b6cba82add769d35a8a28c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144150
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Andras Timar
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144534
Tested-by: Jenkins
diff --git a/writerperfect/source/writer/EPUBExportDialog.cxx
b/writerperfect/source/writer/EPUBExportDialog.cxx
index 0bba77a1898b..ecea590ac831 100644
--- a/writerperfect/source/writer/EPUBExportDialog.cxx
+++ b/writerperfect/source/writer/EPUBExportDialog.cxx
@@ -14,6 +14,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -92,6 +93,7 @@ EPUBExportDialog::EPUBExportDialog(weld::Window* pParent,
, m_xInitialCreator(m_xBuilder->weld_entry("author"))
, m_xLanguage(m_xBuilder->weld_entry("language"))
, m_xDate(m_xBuilder->weld_entry("date"))
+, m_xCustomizeFrame(m_xBuilder->weld_frame("customize"))
{
assert(PositionToVersion(m_xVersion->get_active()) ==
EPUBExportFilter::GetDefaultVersion());
@@ -154,6 +156,9 @@ EPUBExportDialog::EPUBExportDialog(weld::Window* pParent,
}
m_xOKButton->connect_clicked(LINK(this, EPUBExportDialog, OKClickHdl));
+
+if (comphelper::LibreOfficeKit::isActive())
+m_xCustomizeFrame->hide();
}
IMPL_LINK_NOARG(EPUBExportDialog, VersionSelectHdl, weld::ComboBox&, void)
diff --git a/writerperfect/source/writer/EPUBExportDialog.hxx
b/writerperfect/source/writer/EPUBExportDialog.hxx
index 9e11d5351559..440c74d1176e 100644
--- a/writerperfect/source/writer/EPUBExportDialog.hxx
+++ b/writerperfect/source/writer/EPUBExportDialog.hxx
@@ -54,6 +54,7 @@ private:
std::unique_ptr m_xInitialCreator;
std::unique_ptr m_xLanguage;
std::unique_ptr m_xDate;
+std::unique_ptr m_xCustomizeFrame;
};
} // namespace writerperfect
[Libreoffice-commits] core.git: filter/source
filter/source/pdf/impdialog.cxx |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
New commits:
commit 63eed8ff31311fc266791df48cc03a644f665b11
Author: Szymon Kłos
AuthorDate: Wed Dec 14 09:18:11 2022 +0100
Commit: Andras Timar
CommitDate: Tue Dec 20 06:40:11 2022 +
lok: hide signatures in PDF export dialog
Change-Id: Idd67e7ffe4dffc89555d75773501908165cbdd7b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144149
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Andras Timar
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144513
Tested-by: Jenkins
diff --git a/filter/source/pdf/impdialog.cxx b/filter/source/pdf/impdialog.cxx
index a02412ac6caa..2d8a366ae868 100644
--- a/filter/source/pdf/impdialog.cxx
+++ b/filter/source/pdf/impdialog.cxx
@@ -28,6 +28,7 @@
#include
#include
+#include
#include
#include
#include
@@ -250,7 +251,10 @@ ImpPDFTabDialog::ImpPDFTabDialog(weld::Window* pParent,
const Sequence< Property
// queue the tab pages for later creation (created when first shown)
AddTabPage("general", ImpPDFTabGeneralPage::Create, nullptr );
-AddTabPage("digitalsignatures", ImpPDFTabSigningPage::Create, nullptr);
+if (comphelper::LibreOfficeKit::isActive())
+m_xTabCtrl->remove_page("digitalsignatures");
+else
+AddTabPage("digitalsignatures", ImpPDFTabSigningPage::Create, nullptr);
AddTabPage("security", ImpPDFTabSecurityPage::Create, nullptr);
AddTabPage("links", ImpPDFTabLinksPage::Create, nullptr);
AddTabPage("userinterface", ImpPDFTabViewerPage::Create, nullptr);
[Libreoffice-bugs] [Bug 152285] CLONE FORMATTING DOCX: Clone formatting of font is no longer applied after saving and reloading
https://bugs.documentfoundation.org/show_bug.cgi?id=152285 Mike Kaganski changed: What|Removed |Added Attachment #184076|libreoffice-bugzilla-test.d |libreoffice-bugzilla-test.d filename|ocx.txt |ocx Attachment #184076|text/plain |application/vnd.openxmlform mime type||ats-officedocument.wordproc ||essingml.document -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152029] Visually draw attention to in-view bookmark or hyperlink when selecting/hovering it in the Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=152029 --- Comment #46 from Commit Notification --- Jim Raykowski committed a patch related to this issue. It has been pushed to "libreoffice-7-5": https://git.libreoffice.org/core/commit/a89972b681cf041b47b3e059c16f1e1080972a7f tdf#152029 Bring tox sections to attention in the document view It will be available in 7.5.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152517] Navigator: Ctrl+Minus collapses the whole Headings tree, not the selected node
https://bugs.documentfoundation.org/show_bug.cgi?id=152517 --- Comment #9 from Commit Notification --- Jim Raykowski committed a patch related to this issue. It has been pushed to "libreoffice-7-5": https://git.libreoffice.org/core/commit/ffd8d368b3a780c7b687512540821ad52f2db457 tdf#152517 Fix gen backend treeview ctrl+minus behavior It will be available in 7.5.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152029] Visually draw attention to in-view bookmark or hyperlink when selecting/hovering it in the Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=152029 --- Comment #45 from Commit Notification --- Jim Raykowski committed a patch related to this issue. It has been pushed to "libreoffice-7-5": https://git.libreoffice.org/core/commit/18ce4278c37f58887ee830d4f8b2746ed14f20e6 tdf#152029 cleanup: Bring content to attention in document view It will be available in 7.5.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152517] Navigator: Ctrl+Minus collapses the whole Headings tree, not the selected node
https://bugs.documentfoundation.org/show_bug.cgi?id=152517 Commit Notification changed: What|Removed |Added Whiteboard|target:7.6.0|target:7.6.0 ||target:7.5.0.0.beta2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152029] Visually draw attention to in-view bookmark or hyperlink when selecting/hovering it in the Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=152029 --- Comment #44 from Commit Notification --- Jim Raykowski committed a patch related to this issue. It has been pushed to "libreoffice-7-5": https://git.libreoffice.org/core/commit/2ef1800e03890609b24883fa7fd970540280905e tdf#152029 Bring comment fields to attention in the document view It will be available in 7.5.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - sw/source
sw/source/uibase/utlui/content.cxx | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
New commits:
commit a89972b681cf041b47b3e059c16f1e1080972a7f
Author: Jim Raykowski
AuthorDate: Sat Dec 17 10:09:05 2022 -0900
Commit: Noel Grandin
CommitDate: Tue Dec 20 06:10:14 2022 +
tdf#152029 Bring tox sections to attention in the document view
when the mouse pointer is over index content type and content entries
in the Navigator content tree
Change-Id: Ia9ec89ed55da7b62b00b016a6e1dbda5fab54a7a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144390
Tested-by: Jenkins
Reviewed-by: Noel Grandin
Signed-off-by: Xisco Fauli
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144455
diff --git a/sw/source/uibase/utlui/content.cxx
b/sw/source/uibase/utlui/content.cxx
index 3ab2041e1898..e45e6f9e9938 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -1216,7 +1216,7 @@ IMPL_LINK(SwContentTree, MouseMoveHdl, const MouseEvent&,
rMEvt, bool)
{
BringBookmarksToAttention(std::vector
{pCnt->GetName()});
}
-else if (nType == ContentTypeId::REGION)
+else if (nType == ContentTypeId::REGION|| nType ==
ContentTypeId::INDEX)
{
const SwSectionFormats& rFormats =
m_pActiveShell->GetDoc()->GetSections();
const SwSectionFormat* pFormat =
rFormats.FindFormatByName(pCnt->GetName());
@@ -1320,7 +1320,7 @@ IMPL_LINK(SwContentTree, MouseMoveHdl, const MouseEvent&,
rMEvt, bool)
}
BringBookmarksToAttention(aNames);
}
-else if (nType == ContentTypeId::REGION)
+else if (nType == ContentTypeId::REGION || nType ==
ContentTypeId::INDEX)
{
const SwSectionFormats& rFormats =
m_pActiveShell->GetDoc()->GetSections();
if (const size_t nSize = rFormats.size())
@@ -1334,9 +1334,13 @@ IMPL_LINK(SwContentTree, MouseMoveHdl, const
MouseEvent&, rMEvt, bool)
const SwSection* pSection =
pFormat->GetSection();
if (pSection && !pSection->IsHiddenFlag())
{
-if (SectionType eSectionType =
pSection->GetType();
-eSectionType ==
SectionType::ToxContent ||
-eSectionType ==
SectionType::ToxHeader)
+const SectionType eSectionType =
pSection->GetType();
+if (nType == ContentTypeId::REGION &&
+(eSectionType ==
SectionType::ToxContent ||
+eSectionType ==
SectionType::ToxHeader))
+continue;
+if (nType == ContentTypeId::INDEX &&
+eSectionType !=
SectionType::ToxContent)
continue;
aSectionsFormatsArr.push_back(pFormat);
}
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - 2 commits - sw/source
sw/source/uibase/inc/conttree.hxx |2
sw/source/uibase/utlui/content.cxx | 555 ++---
2 files changed, 213 insertions(+), 344 deletions(-)
New commits:
commit 24ead7e8a237fca3cc7bc9078a0b7378fa63a4a5
Author: Jim Raykowski
AuthorDate: Wed Dec 14 06:24:08 2022 -0900
Commit: Noel Grandin
CommitDate: Tue Dec 20 06:10:05 2022 +
SwNavigator: Fix delete field content deletes one character extra
PostIt fields are no longer included in the fields content
type since commit bf28e1df0a04cf6a06d9c4cf591e238a45a34ec1 so there is
no need to check to delete them from the field content type, if ever
this was needed, and fall through to the PostIt content handling which
is where the extra character delete happens that is the cause of this
bug.
Change-Id: I61ded30fd89d87c536f0c050117d5b61fe3a9aef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144201
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
Signed-off-by: Xisco Fauli
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144454
Reviewed-by: Noel Grandin
diff --git a/sw/source/uibase/utlui/content.cxx
b/sw/source/uibase/utlui/content.cxx
index 3011c0828765..3ab2041e1898 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -5386,22 +5386,17 @@ void SwContentTree::EditEntry(const weld::TreeIter&
rEntry, EditEntryMode nMode)
break;
case ContentTypeId::TEXTFIELD:
{
-const SwTextFieldContent* pTextFieldCnt = static_cast(pCnt);
if (nMode == EditEntryMode::DELETE)
{
+const SwTextFieldContent* pTextFieldCnt =
+static_cast(pCnt);
const SwTextField* pTextField =
pTextFieldCnt->GetFormatField()->GetTextField();
SwTextField::DeleteTextField(*pTextField);
}
else
-{
-if (pTextFieldCnt->GetFormatField()->GetField()->GetTypeId()
!= SwFieldTypesEnum::Postit)
-{
-nSlot = FN_EDIT_FIELD;
-break;
-}
-}
-[[fallthrough]]; // execute FN_POSTIT assuring standard mode first
+nSlot = FN_EDIT_FIELD;
}
+break;
case ContentTypeId::POSTIT:
{
auto& rView = m_pActiveShell->GetView();
commit 18ce4278c37f58887ee830d4f8b2746ed14f20e6
Author: Jim Raykowski
AuthorDate: Fri Dec 9 13:36:30 2022 -0900
Commit: Noel Grandin
CommitDate: Tue Dec 20 06:09:58 2022 +
tdf#152029 cleanup: Bring content to attention in document view
when the mouse pointer is over content type and content entries in the
Navigator content tree
Changes made:
* check for content visibility
* use m_aActiveContentArray for content types where possible
* consolidate repeated code
* check pointers before use
* stop and clear overlay when hidden shell is shown
Change-Id: I2ec41b2508e3f37ea11bfbeb695fc95e0dcca0ec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143904
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
Signed-off-by: Xisco Fauli
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144453
Reviewed-by: Noel Grandin
diff --git a/sw/source/uibase/inc/conttree.hxx
b/sw/source/uibase/inc/conttree.hxx
index af39a41cb1ae..1764377f0312 100644
--- a/sw/source/uibase/inc/conttree.hxx
+++ b/sw/source/uibase/inc/conttree.hxx
@@ -136,6 +136,8 @@ class SwContentTree final : public SfxListener
std::unique_ptr m_xOverlayCompareEntry;
std::unique_ptr m_xOverlayObject;
+void OverlayObject(std::vector&& aRanges);
+
void BringHeadingsToAttention(const SwOutlineNodes& rOutlineNodesArr);
void BringFramesToAttention(const std::vector&
rFrameFormats);
void BringBookmarksToAttention(const std::vector& rNames);
diff --git a/sw/source/uibase/utlui/content.cxx
b/sw/source/uibase/utlui/content.cxx
index 7dd41c39b5e0..3011c0828765 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -1150,6 +1150,8 @@ SwContentTree::~SwContentTree()
IMPL_LINK(SwContentTree, MouseMoveHdl, const MouseEvent&, rMEvt, bool)
{
+if (m_eState == State::HIDDEN)
+return false;
if (rMEvt.IsLeaveWindow())
{
m_aOverlayObjectDelayTimer.Stop();
@@ -1180,8 +1182,8 @@ IMPL_LINK(SwContentTree, MouseMoveHdl, const MouseEvent&,
rMEvt, bool)
{
SwContent* pCnt =
weld::fromId(m_xTreeView->get_id(*xEntry));
const ContentTypeId nType = pCnt->GetParent()->GetType();
-if (rMEvt.IsEnterWindow() ||
-m_xTreeView->iter_compare(*xEntry,
*m_xOverlayCompareEntry) != 0)
+if (!pCnt->IsInvisible() && (rMEvt.IsEnterWindow() ||
+m_xTreeView->iter_compare(*xEntry,
*m_xOverlayCompareEntry)
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - 2 commits - sw/source vcl/source
sw/source/uibase/inc/conttree.hxx |1
sw/source/uibase/utlui/content.cxx | 85 -
vcl/source/treelist/svimpbox.cxx |9 ++-
3 files changed, 91 insertions(+), 4 deletions(-)
New commits:
commit ffd8d368b3a780c7b687512540821ad52f2db457
Author: Jim Raykowski
AuthorDate: Thu Dec 15 21:23:49 2022 -0900
Commit: Noel Grandin
CommitDate: Tue Dec 20 06:09:49 2022 +
tdf#152517 Fix gen backend treeview ctrl+minus behavior
For gen type backends, makes the cursor node and all sub nodes
collapsed on ctrl+minus key input.
Change-Id: I53730aca29dd47766cfe8b4cdc81539633ebd8c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144286
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
Signed-off-by: Xisco Fauli
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144452
Reviewed-by: Noel Grandin
diff --git a/vcl/source/treelist/svimpbox.cxx b/vcl/source/treelist/svimpbox.cxx
index 63b4d928bfd5..b5efa69aa19d 100644
--- a/vcl/source/treelist/svimpbox.cxx
+++ b/vcl/source/treelist/svimpbox.cxx
@@ -2392,9 +2392,12 @@ bool SvImpLBox::KeyInput( const KeyEvent& rKEvt)
case KEY_SUBTRACT:
if (m_pView->IsExpanded(m_pCursor))
-m_pView->Collapse(m_pCursor);
-if (bMod1)
-CollapseTo(m_pTree->GetRootLevelParent(m_pCursor));
+{
+if (bMod1)
+CollapseTo(m_pCursor);
+else
+m_pView->Collapse(m_pCursor);
+}
break;
case KEY_MULTIPLY:
commit 2ef1800e03890609b24883fa7fd970540280905e
Author: Jim Raykowski
AuthorDate: Mon Dec 12 00:06:48 2022 -0900
Commit: Noel Grandin
CommitDate: Tue Dec 20 06:09:40 2022 +
tdf#152029 Bring comment fields to attention in the document view
when the mouse pointer is over comment content type and content entries
in the Navigator content tree
Change-Id: I81f8667231fe0e94f0b81c4c2d4955ba17aaa3da
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143979
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
Signed-off-by: Xisco Fauli
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144451
Reviewed-by: Noel Grandin
diff --git a/sw/source/uibase/inc/conttree.hxx
b/sw/source/uibase/inc/conttree.hxx
index 3cf671ac1bd9..af39a41cb1ae 100644
--- a/sw/source/uibase/inc/conttree.hxx
+++ b/sw/source/uibase/inc/conttree.hxx
@@ -141,6 +141,7 @@ class SwContentTree final : public SfxListener
void BringBookmarksToAttention(const std::vector& rNames);
void BringURLFieldsToAttention(const SwGetINetAttrs& rINetAttrsArr);
void BringReferencesToAttention(std::vector&
rTextAttrsArr);
+void BringPostItFieldsToAttention(std::vector&
rTextAttrsArr);
void BringDrawingObjectsToAttention(std::vector&
rDrawingObjectsArr);
void BringTextFieldsToAttention(std::vector&
rTextAttrsArr);
void BringFootnotesToAttention(std::vector&
rTextAttrsArr);
diff --git a/sw/source/uibase/utlui/content.cxx
b/sw/source/uibase/utlui/content.cxx
index 37983514e647..7dd41c39b5e0 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -102,6 +102,7 @@
#include
#include
+#include
#include
#include
#include
@@ -1248,6 +1249,15 @@ IMPL_LINK(SwContentTree, MouseMoveHdl, const
MouseEvent&, rMEvt, bool)
BringReferencesToAttention(aTextAttrArr);
}
}
+else if (nType == ContentTypeId::POSTIT)
+{
+if (const SwTextAttr* pTextAttr =
+
static_cast(pCnt)->GetPostIt()->GetTextField())
+{
+std::vector aTextAttrArr
{pTextAttr};
+BringPostItFieldsToAttention(aTextAttrArr);
+}
+}
else if (nType == ContentTypeId::DRAWOBJECT)
{
if (!pCnt->IsInvisible())
@@ -1372,6 +1382,20 @@ IMPL_LINK(SwContentTree, MouseMoveHdl, const
MouseEvent&, rMEvt, bool)
}
BringReferencesToAttention(aTextAttrArr);
}
+else if (nType == ContentTypeId::POSTIT)
+{
+std::vector aTextAttrArr;
+for (size_t i = 0; i <
m_aActiveContentArr[nType]->GetMemberCount(); i++)
+{
+const SwPostItContent* pPostItContent =
static_cast(
+m_aActiveContentArr[nType]->GetMember(i));
+if (pPostItContent && !pPostItContent->IsInvisible())
+if (const SwFormatField* pFormatField =
pPostItContent->GetPostIt())
+if (const SwTextAttr* pTextAttr =
pFormatField->GetTextField())
+
[Libreoffice-commits] core.git: 2 commits - compilerplugins/clang solenv/CompilerTest_compilerplugins_clang.mk xmlhelp/source
compilerplugins/clang/implinheritancehelper.cxx | 120 +++
compilerplugins/clang/test/implinheritancehelper.cxx | 26
solenv/CompilerTest_compilerplugins_clang.mk |1
xmlhelp/source/cxxhelp/provider/provider.cxx | 49 ---
xmlhelp/source/cxxhelp/provider/provider.hxx | 17 --
5 files changed, 150 insertions(+), 63 deletions(-)
New commits:
commit 0a5d85e76f12d1819b0ed1d5b531e731e57c201c
Author: Noel Grandin
AuthorDate: Mon Dec 19 08:48:21 2022 +0200
Commit: Noel Grandin
CommitDate: Tue Dec 20 06:05:13 2022 +
new loplugin:implinheritancehelper
Look for places we should be using ImplInheritanceHelper, which handles
various boilerplate for us
Change-Id: Icff6babf682c95b60aca86e6d6c2e2181eefc2f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/14
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/compilerplugins/clang/implinheritancehelper.cxx
b/compilerplugins/clang/implinheritancehelper.cxx
new file mode 100644
index ..fb24ed96f2dd
--- /dev/null
+++ b/compilerplugins/clang/implinheritancehelper.cxx
@@ -0,0 +1,120 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include
+#include
+
+#include "check.hxx"
+#include "plugin.hxx"
+#include "config_clang.h"
+#include "clang/AST/CXXInheritance.h"
+
+/**
+
+Look for places where we should be using ImplInheritanceHelper
+
+*/
+
+namespace
+{
+class ImplInheritanceHelper : public
loplugin::FilteringPlugin
+{
+public:
+explicit ImplInheritanceHelper(loplugin::InstantiationData const& data)
+: FilteringPlugin(data)
+{
+}
+
+virtual bool preRun() override { return true; }
+
+virtual void run() override
+{
+if (preRun())
+TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
+}
+
+bool VisitCXXRecordDecl(const CXXRecordDecl*);
+};
+
+bool ImplInheritanceHelper::VisitCXXRecordDecl(const CXXRecordDecl*
cxxRecordDecl)
+{
+if (ignoreLocation(cxxRecordDecl))
+return true;
+if (!cxxRecordDecl->isThisDeclarationADefinition())
+return true;
+if (cxxRecordDecl->isDependentContext())
+return true;
+
+// ignore the utility template classes
+SourceLocation spellingLocation
+=
compiler.getSourceManager().getSpellingLoc(cxxRecordDecl->getBeginLoc());
+StringRef fileName = getFilenameOfLocation(spellingLocation);
+if (loplugin::hasPathnamePrefix(fileName, SRCDIR "/include/cppu"))
+return true;
+if (loplugin::isSamePathname(fileName, SRCDIR
"/include/comphelper/compbase.hxx"))
+return true;
+
+// not sure why this extends XPropertyState but does not support it in
queryInterface.
+if (loplugin::DeclCheck(cxxRecordDecl)
+.Class("ChainablePropertySet")
+.Namespace("comphelper")
+.GlobalNamespace())
+return true;
+// in these cases the UNO interface is optional
+if
(loplugin::DeclCheck(cxxRecordDecl).Class("OFSInputStreamContainer").GlobalNamespace())
+return true;
+if (loplugin::DeclCheck(cxxRecordDecl)
+.Class("OPropertyBrowserController")
+.Namespace("pcr")
+.GlobalNamespace())
+return true;
+
+// check if this class extends cppu::WeakImplHelper
+if (!loplugin::isDerivedFrom(cxxRecordDecl, [](Decl const* decl) -> bool {
+return bool(loplugin::DeclCheck(decl)
+.Class("WeakImplHelper")
+.Namespace("cppu")
+.GlobalNamespace());
+}))
+return true;
+// check if this class directly inherits from a UNO interface class
+bool foundOne = false;
+for (auto const& i : cxxRecordDecl->bases())
+{
+auto rt = i.getType()->getAs();
+if (!rt)
+continue;
+auto const bd = cast(rt->getDecl())->getDefinition();
+auto ctx = bd->getDeclContext();
+if (!ctx->isNamespace())
+break;
+auto ns = dyn_cast(ctx);
+while (ns)
+{
+if (ns->getIdentifier() && ns->getName() == "star")
+{
+foundOne = true;
+break;
+}
+ns = dyn_cast_or_null(ns->getParent());
+}
+}
+if (!foundOne)
+return true;
+report(DiagnosticsEngine::Warning, "can probably use ImplInheritanceHelper
here",
+ cxxRecordDecl->getLocation())
+<< cxxRecordDecl->getSourceRange();
+return true;
+}
+
+loplugin::Plugin::Registration
+implinheritancehelper("implinheritancehelper");
+}
+
+/*
[Libreoffice-bugs] [Bug 77999] [META] Autosave/Autorecovery/Backup copy issues
https://bugs.documentfoundation.org/show_bug.cgi?id=77999 Bug 77999 depends on bug 152463, which changed state. Bug 152463 Summary: AutoRecovery should be turned on by default https://bugs.documentfoundation.org/show_bug.cgi?id=152463 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: officecfg/registry
officecfg/registry/schema/org/openoffice/Office/Common.xcs |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 5cb7fed2a5a02ff1cb4551752a0bd8d3001a1f22 Author: Bogdan B AuthorDate: Mon Dec 12 20:31:20 2022 + Commit: Heiko Tietze CommitDate: Tue Dec 20 05:58:19 2022 + tdf#152463 Turn on AutoSave and Backup by default Change-Id: Icc29bfa8a752be75c4ffa9eb8b939008297105bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144020 Tested-by: Jenkins Reviewed-by: Heiko Tietze diff --git a/officecfg/registry/schema/org/openoffice/Office/Common.xcs b/officecfg/registry/schema/org/openoffice/Office/Common.xcs index ea175aabf532..023ed391bfe1 100644 --- a/officecfg/registry/schema/org/openoffice/Office/Common.xcs +++ b/officecfg/registry/schema/org/openoffice/Office/Common.xcs @@ -2308,7 +2308,7 @@ saved in a time interval. AutoSave every - false + true @@ -2326,7 +2326,7 @@ document is saved. Always create backup copy - false + true
[Libreoffice-bugs] [Bug 152319] Writer crash and damaged file using Undo/Redo viewing Track Changes
https://bugs.documentfoundation.org/show_bug.cgi?id=152319 Dieter changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152319] Writer crash and damaged file using Undo/Redo viewing Track Changes
https://bugs.documentfoundation.org/show_bug.cgi?id=152319 Dieter changed: What|Removed |Added Whiteboard| QA:needsComment| CC||dgp-m...@gmx.de --- Comment #1 from Dieter --- BigTonyD, thank you for your bug report. Could you please retest with a clean user profile? Thank you. => NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152607] New: Sometime in 2022, someone created an "quick/shortcut key" error in the Calc "Sheets" menu.
https://bugs.documentfoundation.org/show_bug.cgi?id=152607 Bug ID: 152607 Summary: Sometime in 2022, someone created an "quick/shortcut key" error in the Calc "Sheets" menu. Product: LibreOffice Version: 7.4.3.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rjsm...@smu.edu Description: Two commands in the same menu cannot have the same quick/shortcut key. In the Calc "Sheet" menu, "Insert Rows" uses R as the quick key. The error is that someone changed the "Delete Key" quick key from "W" to "R" which duplicates the hot key for Insert Rows. This cancelled the short cut key for Delete Rows. Please correct Delete Key hot back to "w". Thank you. I use both Writer and Calc and am becoming comfortable with both. Steps to Reproduce: 1. create a couple of data lines in Calc. 2. try to delete a data line by using the Sheet menu "Delete Rows" HOT KEY: r. 3. it does not work because the "r" is already in use by the Insert Rows command. 4. please return the Delete Rows hot key to the original "w" key. Actual Results: "R" is already in use by the "Insert Rows" command. Expected Results: With the "w" key in previous versions of Libre Office, the "w" key worked flawlessly when deleting rows. Whoever made the change in the menu was not paying attention to the hot keys already in use in the "Sheet" menu. Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: SpreadsheetDocument [Information guessed from browser] OS: Windows (All) OS is 64bit: no -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 128622] Impress: Increase/decrease indent has different effect on list items than in Writer -> cannot demote/promote
https://bugs.documentfoundation.org/show_bug.cgi?id=128622 --- Comment #11 from Mike Kaganski --- Unless there is a strong reason, inconsistency is bad. Having same actions doing same things in both apps produces much less surprise, makes learning easier. The underlying markup (ODF) allows the same features in text boxes as in Writer's text body, so the limitation is only in implementation. There is a wish to merge the two layout implementations (EditEngine used in text boxes / Impress / Calc, and Writer's layout, so that the same feature set is available universally). So - I haven't seen a compelling reason not to implement this request yet. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - vcl/source
vcl/source/gdi/pdfobjectcopier.cxx |9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
New commits:
commit 9aaf70675c0fc80641f6da6f821c2180be1ca608
Author: Aron Budea
AuthorDate: Mon Dec 19 08:49:57 2022 +0100
Commit: Dennis Francis
CommitDate: Tue Dec 20 04:39:59 2022 +
vcl: avoid unused variable warning
vcl/source/gdi/pdfobjectcopier.cxx: In member function ‘rtl::OString
vcl::PDFObjectCopier::copyExternalResources(vcl::filter::PDFObjectElement&,
const rtl::OString&, std::__debug::map&)’:
vcl/source/gdi/pdfobjectcopier.cxx:240:27: error: unused variable ‘pDict’
[-Werror=unused-variable]
240 | if (auto* pDict =
dynamic_cast(rItem.second))
| ^
Change-Id: I864210144e6154eb79a42e6cd5ceb3d5dbd39a76
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/19
Reviewed-by: Dennis Francis
Tested-by: Jenkins CollaboraOffice
diff --git a/vcl/source/gdi/pdfobjectcopier.cxx
b/vcl/source/gdi/pdfobjectcopier.cxx
index cbf3dc308c3b..fddacc2a65fd 100644
--- a/vcl/source/gdi/pdfobjectcopier.cxx
+++ b/vcl/source/gdi/pdfobjectcopier.cxx
@@ -235,13 +235,10 @@ OString
PDFObjectCopier::copyExternalResources(filter::PDFObjectElement& rPage,
auto pReference =
dynamic_cast(rItem.second);
if (!pReference)
{
-if (pKindObject)
+if (pKindObject &&
dynamic_cast(rItem.second) != nullptr)
{
-if (auto* pDict =
dynamic_cast(rItem.second))
-{
-bHasDictValue = true;
-break;
-}
+bHasDictValue = true;
+break;
}
continue;
[Libreoffice-bugs] [Bug 152606] New: Crash if I open the specified pptx file
https://bugs.documentfoundation.org/show_bug.cgi?id=152606 Bug ID: 152606 Summary: Crash if I open the specified pptx file Product: LibreOffice Version: 7.3.7.2 release Hardware: ARM OS: macOS (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Printing and PDF export Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: pet-...@foxmail.com Description: I can't open the specified file with Libreoffice(Windows 11, WSL,Mac OS(Apple M1)).And I got a crash report under the Mac OS(Apple M1) platform. Steps to Reproduce: I'm trying to convert the specified pptx file to pdf with soffice. 1. Try to convert the file with soffice in Windows Subsystem of Linux, but the process of soffice can't be finished(CPU 90%+). 2. Try to use Libreoffice with Windows 11 to open the file, but it seems to be stuck while loading the file.(CPU 90%+) 3. While I tried to use Libreoffice (Apple M1) to open the file, It crashed. And I got the report as below. Actual Results: - Translated Report (Full Report Below) - Process: soffice [3893] Path: /Applications/LibreOffice.app/Contents/MacOS/soffice Identifier:org.libreoffice.script Version: 7.3.7.2 (7.3.7.2) Code Type: ARM-64 (Native) Parent Process:launchd [1] User ID: 501 Date/Time: 2022-12-20 10:55:03.7630 +0800 OS Version:macOS 12.1 (21C52) Report Version:12 Anonymous UUID:D647E694-B4C9-C918-9226-1B985616FBA5 Time Awake Since Boot: 6100 seconds System Integrity Protection: enabled Crashed Thread:0 Dispatch queue: com.apple.main-thread Exception Type:EXC_BAD_ACCESS (SIGABRT) Exception Codes: KERN_INVALID_ADDRESS at 0x0038 Exception Codes: 0x0001, 0x0038 Exception Note:EXC_CORPSE_NOTIFY VM Region Info: 0x38 is not in any region. Bytes before following region: 4370628552 REGION TYPESTART - END [ VSIZE] PRT/MAX SHRMOD REGION DETAIL UNUSED SPACE AT START ---> __TEXT 104828000-10482c000[ 16K] r-x/r-x SM=COW ...MacOS/soffice Application Specific Information: abort() called terminating with uncaught exception of type com::sun::star::uno::RuntimeException Kernel Triage: VM - pmap_enter failed with resource shortage VM - pmap_enter failed with resource shortage VM - pmap_enter failed with resource shortage VM - pmap_enter failed with resource shortage VM - pmap_enter failed with resource shortage Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 libsystem_kernel.dylib 0x1998b59b8 __pthread_kill + 8 1 libsystem_pthread.dylib0x1998e8eb0 pthread_kill + 288 2 libsystem_c.dylib 0x199826314 abort + 164 3 libuno_sal.dylib.3 0x104b13300 (anonymous namespace)::signalHandlerFunction(int, __siginfo*, void*) (.cold.1) + 32 4 libuno_sal.dylib.3 0x104b06e80 (anonymous namespace)::signalHandlerFunction(int, __siginfo*, void*) + 1060 5 libsystem_platform.dylib 0x1999004e4 _sigtramp + 56 6 libsystem_pthread.dylib0x1998e8eb0 pthread_kill + 288 7 libsystem_c.dylib 0x199826314 abort + 164 8 libc++abi.dylib0x1998a5b50 abort_message + 132 9 libc++abi.dylib0x199896f64 demangling_terminate_handler() + 332 10 libobjc.A.dylib0x19978e150 _objc_terminate() + 160 11 libc++abi.dylib0x1998a4ee4 std::__terminate(void (*)()) + 20 12 libc++abi.dylib0x1998a4e80 std::terminate() + 64 13 libooxlo.dylib 0x2e1f6f918 oox::ppt::PPTShapeContext::onCreateContext(int, oox::AttributeList const&) + 248 14 libooxlo.dylib 0x2e1db1d64 oox::core::ContextHandler2Helper::implCreateChildContext(int, com::sun::star::uno::Reference const&) + 96 15 libexpwraplo.dylib 0x2da92d77c (anonymous namespace)::Entity::startElement((anonymous namespace)::Event const*) + 624 16 libexpwraplo.dylib 0x2da92c508 sax_fastparser::FastSaxParserImpl::callbackStartElement(unsigned char const*, unsigned char const*, unsigned char const*, int, unsigned char const**, int, unsigned char const**) + 2776 17 libxml2.2.dylib0x1a0e3f428 xmlParseStartTag2 + 4108 18 libxml2.2.dylib0x1a0e3b0a4 xmlParseTryOrFinish + 3100 19 libxml2.2.dylib0x1a0e39bf8 xmlParseChunk + 676 20 libexpwraplo.dylib 0x2da92a960
[Libreoffice-bugs] [Bug 152264] Installing the Windows 32-bit version in parallel by SI-GUI, No starting if the ExperimentalMode is enabled.
https://bugs.documentfoundation.org/show_bug.cgi?id=152264 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152389] Layers created on 'OLN_MGE_PGC_REE_Rev2.10.odg' file, (once exported the .odg file to .pdf file) are not visible on the .pdf file.
https://bugs.documentfoundation.org/show_bug.cgi?id=152389 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152319] Writer crash and damaged file using Undo/Redo viewing Track Changes
https://bugs.documentfoundation.org/show_bug.cgi?id=152319 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143941] LibreCalc freezes machine when shutting down [1]
https://bugs.documentfoundation.org/show_bug.cgi?id=143941 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152373] Spell check on cell in CALC Sheet Corrects and fails to update cell but works on other cells
https://bugs.documentfoundation.org/show_bug.cgi?id=152373 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149038] Adding support for RD Field Codes in .docx format
https://bugs.documentfoundation.org/show_bug.cgi?id=149038 --- Comment #3 from QA Administrators --- Dear Muhammad Hasan Firdaus, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149676] Can not switch off Auto Correction replace of 3 dots ("...") with the typographical single character "…" Ellipsis
https://bugs.documentfoundation.org/show_bug.cgi?id=149676 --- Comment #2 from QA Administrators --- Dear ATI, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143941] LibreCalc freezes machine when shutting down [1]
https://bugs.documentfoundation.org/show_bug.cgi?id=143941 --- Comment #4 from QA Administrators --- Dear dpkesling, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 129357] Soft hyphen shows no hyphen at line break
https://bugs.documentfoundation.org/show_bug.cgi?id=129357 --- Comment #5 from QA Administrators --- Dear Gerhard Weydt, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134175] LibreOffice does not show the option to remove hyperlinks on typos
https://bugs.documentfoundation.org/show_bug.cgi?id=134175 --- Comment #4 from QA Administrators --- Dear BDF, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 129704] hyphenation with big string and wrap picture bad on first line
https://bugs.documentfoundation.org/show_bug.cgi?id=129704 --- Comment #4 from QA Administrators --- Dear noscollections, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 126096] Hyperlink to in-document target adds path when exported to PDF from Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=126096 --- Comment #5 from QA Administrators --- Dear lrollins, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 125032] uno:Hyphenate toggle in calc, draw, impress but not in writer menubar
https://bugs.documentfoundation.org/show_bug.cgi?id=125032 --- Comment #4 from QA Administrators --- Dear andreas_k, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 115542] Disabling Master background still shows it in the slideshow
https://bugs.documentfoundation.org/show_bug.cgi?id=115542 --- Comment #6 from QA Administrators --- Dear Ahmed GHANMI, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: include/svtools
include/svtools/genericasyncunodialog.hxx |8
1 file changed, 8 deletions(-)
New commits:
commit fd839a7f7a0480df0c4bef3029dea0f97c0dd406
Author: Szymon Kłos
AuthorDate: Wed Dec 14 17:36:10 2022 +0100
Commit: Andras Timar
CommitDate: Tue Dec 20 03:13:20 2022 +
lok: remove undefined behaviour warning
Change-Id: I74d015bdf2c30b85c8e9eb8271780cea1f15
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144169
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Andras Timar
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144536
Tested-by: Jenkins
diff --git a/include/svtools/genericasyncunodialog.hxx
b/include/svtools/genericasyncunodialog.hxx
index 7168d08f4301..937f9778030d 100644
--- a/include/svtools/genericasyncunodialog.hxx
+++ b/include/svtools/genericasyncunodialog.hxx
@@ -57,14 +57,6 @@ protected:
{
}
-virtual ~OGenericUnoAsyncDialog() override
-{
-SolarMutexGuard aSolarGuard;
-::osl::MutexGuard aGuard(m_aMutex);
-if (m_xAsyncDialog)
-destroyAsyncDialog();
-}
-
public:
// XAsynchronousExecutableDialog
void SAL_CALL setDialogTitle(const OUString& aTitle) override
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/doc/guisaveas.cxx | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
New commits:
commit d3d76fe4138f0a27306480e4e71394cda6078ee5
Author: Szymon Kłos
AuthorDate: Mon Dec 12 15:27:26 2022 +0100
Commit: Andras Timar
CommitDate: Tue Dec 20 03:11:33 2022 +
lok: export PDF/EPUB with extension
Change-Id: Ib266814d88a4f121959cb21f40293d671f242448
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143989
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Andras Timar
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144512
Tested-by: Jenkins
diff --git a/sfx2/source/doc/guisaveas.cxx b/sfx2/source/doc/guisaveas.cxx
index d95d2bb2c289..c0f951d62206 100644
--- a/sfx2/source/doc/guisaveas.cxx
+++ b/sfx2/source/doc/guisaveas.cxx
@@ -1089,8 +1089,21 @@ bool ModelData_Impl::OutputFileDialog( sal_Int16
nStoreMode,
// get the path from the dialog
INetURLObject aURL( pFileDlg->GetPath() );
-// the path should be provided outside since it might be used for further
calls to the dialog
-aSuggestedName =
aURL.GetLastName(INetURLObject::DecodeMechanism::WithCharset);
+
+if (comphelper::LibreOfficeKit::isActive())
+{
+// keep name with extension
+aSuggestedName = aRecommendedName;
+OUString aExtension;
+if (size_t nPos = aSuggestedName.lastIndexOf('.') + 1)
+aExtension = aSuggestedName.copy(nPos, aSuggestedName.getLength()
- nPos);
+aURL.SetExtension(aExtension);
+}
+else
+{
+// the path should be provided outside since it might be used for
further calls to the dialog
+aSuggestedName =
aURL.GetLastName(INetURLObject::DecodeMechanism::WithCharset);
+}
aSuggestedDir = pFileDlg->GetDisplayDirectory();
// old filter options should be cleared in case different filter is used
[Libreoffice-commits] core.git: filter/source include/LibreOfficeKit include/sfx2 include/svtools libreofficekit/source offapi/com sfx2/inc sfx2/source vcl/jsdialog
filter/source/pdf/impdialog.cxx |7
filter/source/pdf/impdialog.hxx |2
filter/source/pdf/pdfdialog.cxx | 24 ++
filter/source/pdf/pdfdialog.hxx | 13 +
include/LibreOfficeKit/LibreOfficeKitEnums.h | 10 +
include/sfx2/viewsh.hxx |6
include/svtools/genericasyncunodialog.hxx| 132 ++
libreofficekit/source/gtk/lokdocview.cxx |1
offapi/com/sun/star/document/PDFDialog.idl |1
sfx2/inc/guisaveas.hxx | 32 +++
sfx2/source/doc/guisaveas.cxx| 246 +++
sfx2/source/doc/objserv.cxx | 15 +
sfx2/source/view/ipclient.cxx|3
vcl/jsdialog/enabled.cxx |9
14 files changed, 419 insertions(+), 82 deletions(-)
New commits:
commit 89f5912ad2eee786508414791653a017206a7c04
Author: NickWingate
AuthorDate: Thu Sep 22 09:02:42 2022 +0100
Commit: Andras Timar
CommitDate: Tue Dec 20 03:11:16 2022 +
Async PDFExport dialog and parent methods
Filter dialogs are all called generically from
guisaveas.cxx in GUIStoreModel()
Signed-off-by: NickWingate
Change-Id: Idfbe85c09f84d4a7cf3f00b9704d5af94868a051
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140403
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Andras Timar
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144511
Tested-by: Jenkins
diff --git a/filter/source/pdf/impdialog.cxx b/filter/source/pdf/impdialog.cxx
index fd68322f1a23..a02412ac6caa 100644
--- a/filter/source/pdf/impdialog.cxx
+++ b/filter/source/pdf/impdialog.cxx
@@ -541,6 +541,8 @@ ImpPDFTabGeneralPage::ImpPDFTabGeneralPage(weld::Container*
pPage, weld::DialogC
ImpPDFTabGeneralPage::~ImpPDFTabGeneralPage()
{
+if (mxPasswordUnusedWarnDialog)
+mxPasswordUnusedWarnDialog->response(RET_CANCEL);
}
void ImpPDFTabGeneralPage::SetFilterConfigItem(ImpPDFTabDialog* pParent)
@@ -871,10 +873,11 @@ IMPL_LINK_NOARG(ImpPDFTabGeneralPage,
TogglePDFVersionOrUniversalAccessibilityHa
// if a password was set, inform the user that this will not be used
if (pSecPage && pSecPage->hasPassword())
{
-std::unique_ptr
xBox(Application::CreateMessageDialog(m_xContainer.get(),
+mxPasswordUnusedWarnDialog =
+
std::shared_ptr(Application::CreateMessageDialog(m_xContainer.get(),
VclMessageType::Warning,
VclButtonsType::Ok,
FilterResId(STR_WARN_PASSWORD_PDFA)));
-xBox->run();
+mxPasswordUnusedWarnDialog->runAsync(mxPasswordUnusedWarnDialog,
[] (sal_uInt32){ });
}
}
else
diff --git a/filter/source/pdf/impdialog.hxx b/filter/source/pdf/impdialog.hxx
index 828422bdc63e..d0d63bccc86b 100644
--- a/filter/source/pdf/impdialog.hxx
+++ b/filter/source/pdf/impdialog.hxx
@@ -232,6 +232,8 @@ class ImpPDFTabGeneralPage : public SfxTabPage
DECL_LINK(TogglePDFVersionOrUniversalAccessibilityHandle,
weld::Toggleable&, void);
+std::shared_ptr mxPasswordUnusedWarnDialog;
+
public:
ImpPDFTabGeneralPage(weld::Container* pPage, weld::DialogController*
pController, const SfxItemSet& rSet);
diff --git a/filter/source/pdf/pdfdialog.cxx b/filter/source/pdf/pdfdialog.cxx
index 7c3e5dda1956..c036fc747b2a 100644
--- a/filter/source/pdf/pdfdialog.cxx
+++ b/filter/source/pdf/pdfdialog.cxx
@@ -62,6 +62,13 @@ std::unique_ptr
PDFDialog::createDialog(const css::uno::
return nullptr;
}
+std::shared_ptr PDFDialog::createAsyncDialog(const
css::uno::Reference& rParent)
+{
+if( mxSrcDoc.is() )
+return
std::make_shared(Application::GetFrameWeld(rParent),
maFilterData, mxSrcDoc);
+return nullptr;
+}
+
void PDFDialog::executedDialog( sal_Int16 nExecutionResult )
{
if (nExecutionResult && m_xDialog)
@@ -69,6 +76,23 @@ void PDFDialog::executedDialog( sal_Int16 nExecutionResult )
destroyDialog();
}
+void PDFDialog::runAsync(const css::uno::Reference<
css::ui::dialogs::XDialogClosedListener >& xListener)
+{
+SfxTabDialogController::runAsync(m_xAsyncDialog, [this,
xListener](sal_Int32 nResponse) {
+executedAsyncDialog( m_xAsyncDialog, nResponse );
+css::ui::dialogs::DialogClosedEvent aEvent;
+aEvent.DialogResult = nResponse;
+xListener->dialogClosed( aEvent );
+destroyAsyncDialog();
+});
+}
+
+void PDFDialog::executedAsyncDialog( std::shared_ptr
xAsyncDialog, sal_Int32 nExecutionResult )
+{
+if (nExecutionResult && xAsyncDialog)
+maFilterData =
static_cast(xAsyncDialog.get())->GetFilterData();
+}
+
Reference< XPropertySetInfo > SAL_CALL PDFDialog::getPropertySetInfo()
{
Reference< XPropertySetInfo > xInfo( createPropertySetInfo(
getInfoHelper() ) );
diff --git
[Libreoffice-commits] core.git: writerperfect/source
writerperfect/source/writer/EPUBExportUIComponent.cxx | 25 ++
writerperfect/source/writer/EPUBExportUIComponent.hxx | 14 ++
2 files changed, 39 insertions(+)
New commits:
commit 34709aa3f4f166879004670e60ff3b37ad3eacd5
Author: Szymon Kłos
AuthorDate: Fri Dec 9 13:53:47 2022 +0100
Commit: Andras Timar
CommitDate: Tue Dec 20 03:10:59 2022 +
Make EPUB Export dialog async
(cherry picked from commit 9461b0e1385b87d2490bf9402729fb9e912395e9)
Change-Id: Iead5b4ff6064395fd5abbcdea73db38415dbb37c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144514
Tested-by: Jenkins
Reviewed-by: Andras Timar
diff --git a/writerperfect/source/writer/EPUBExportUIComponent.cxx
b/writerperfect/source/writer/EPUBExportUIComponent.cxx
index e8d618b99cf6..0e392ffe00ec 100644
--- a/writerperfect/source/writer/EPUBExportUIComponent.cxx
+++ b/writerperfect/source/writer/EPUBExportUIComponent.cxx
@@ -90,6 +90,31 @@ void SAL_CALL EPUBExportUIComponent::setSourceDocument(
mxSourceDocument = xDocument;
}
+void SAL_CALL EPUBExportUIComponent::setDialogTitle(const OUString& aTitle) {
setTitle(aTitle); }
+
+void SAL_CALL EPUBExportUIComponent::startExecuteModal(
+const css::uno::Reference&
xListener)
+{
+SolarMutexGuard aSolarGuard;
+
+if (!mxAsyncDialog)
+{
+if (mxSourceDocument.is())
+mxAsyncDialog
+=
std::make_shared(Application::GetFrameWeld(mxDialogParent),
+ maFilterData, mxContext,
mxSourceDocument);
+
+if (!mxAsyncDialog)
+return;
+}
+
+weld::DialogController::runAsync(mxAsyncDialog, [xListener](sal_Int32
nResponse) {
+css::ui::dialogs::DialogClosedEvent aEvent;
+aEvent.DialogResult = nResponse;
+xListener->dialogClosed(aEvent);
+});
+}
+
extern "C" SAL_DLLPUBLIC_EXPORT uno::XInterface*
com_sun_star_comp_Writer_EPUBExportUIComponent_get_implementation(
uno::XComponentContext* pCtx, uno::Sequence const& /*rSeq*/)
diff --git a/writerperfect/source/writer/EPUBExportUIComponent.hxx
b/writerperfect/source/writer/EPUBExportUIComponent.hxx
index 71fcc0ace168..b453a4e88096 100644
--- a/writerperfect/source/writer/EPUBExportUIComponent.hxx
+++ b/writerperfect/source/writer/EPUBExportUIComponent.hxx
@@ -12,6 +12,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -19,6 +20,11 @@
#include
#include
+namespace weld
+{
+class DialogController;
+}
+
namespace com::sun::star::uno
{
class XComponentContext;
@@ -30,6 +36,7 @@ namespace writerperfect
class EPUBExportUIComponent
: public cppu::WeakImplHelper
{
public:
@@ -49,6 +56,12 @@ public:
void SAL_CALL setTitle(const OUString& rTitle) override;
sal_Int16 SAL_CALL execute() override;
+// XAsynchronousExecutableDialog
+void SAL_CALL setDialogTitle(const OUString& aTitle) override;
+
+void SAL_CALL startExecuteModal(
+const css::uno::Reference&
xListener) override;
+
// XExporter
void SAL_CALL
setSourceDocument(const css::uno::Reference&
xDocument) override;
@@ -65,6 +78,7 @@ private:
css::uno::Reference mxContext;
css::uno::Reference mxSourceDocument;
css::uno::Reference mxDialogParent;
+std::shared_ptr mxAsyncDialog;
};
} // namespace writerperfect
[Libreoffice-bugs] [Bug 152596] A page style tab is missing. Unable to landscape , adjust margins, change page size
https://bugs.documentfoundation.org/show_bug.cgi?id=152596 --- Comment #5 from Rizal Muttaqin --- (In reply to Rizal Muttaqin from comment #4) s/principle in principle/principle in UX/g -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152596] A page style tab is missing. Unable to landscape , adjust margins, change page size
https://bugs.documentfoundation.org/show_bug.cgi?id=152596 Rizal Muttaqin changed: What|Removed |Added CC||riz...@libreoffice.org --- Comment #4 from Rizal Muttaqin --- Created attachment 184253 --> https://bugs.documentfoundation.org/attachment.cgi?id=184253=edit Tab in LibreOffice with KF5 backend I see this as more of a UX issue, and happens on the Windows platform when a window or dialog is minimized it always results in a tab state with text almost filling the area inside. This is against principle in principle because there should always be enough space between the text and the right and left edges of the tabs. Supposedly over-dialog tabs can be shifted down so that they become two or more lines like the example shown in the screenshot. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 152605] Change "outline level" to "heading level" in UI and help pages for Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=152605 sdc.bla...@youmail.dk changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org Blocks||103370 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103370 [Bug 103370] [META] Outline/Chapter numbering bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 103370] [META] Outline/Chapter numbering bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103370 sdc.bla...@youmail.dk changed: What|Removed |Added Depends on||152605 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=152605 [Bug 152605] Change "outline level" to "heading level" in UI and help pages for Writer -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152605] Change "outline level" to "heading level" in UI and help pages for Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=152605 sdc.bla...@youmail.dk changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org Blocks||103370 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103370 [Bug 103370] [META] Outline/Chapter numbering bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152605] New: Change "outline level" to "heading level" in UI and help pages for Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=152605 Bug ID: 152605 Summary: Change "outline level" to "heading level" in UI and help pages for Writer Product: LibreOffice Version: 7.6.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sdc.bla...@youmail.dk Summary: Change "outline level" to "heading level" in UI and help pages. Some reasons: 1. More meaningful in relation to numbering in Tools > Chapter Numbering For example, see [1] where "heading level" should replace "outline level" 2. Better consistency in help pages, which often refer to chapter heading, where "heading level" for a chapter heading, fits better than the (current) "outline level". See for example [2] (which is already using "heading level" somewhat) 3. Makes more sense that (default) "Heading n" is assigned to "heading level" n, rather than the (current) "outline level". 4. Avoids confusion with lists, which also use "outline" See [3] and [4] for relevant comments. In sum: Main idea (hypothesis) is that using the label "heading level" to refer to Tools > Chapter Number > Numbering tab > Level will (a) make the meaning/significance of "level" more transparent, including its relation to numbering of headers, and (b) allow improvements in the help pages to better communicate the connection between heading and heading level, while (c) reducing confusion with the use of "outline" in connection with lists. [1] https://help.libreoffice.org/7.6/en-US/text/swriter/01/06060100.html [2] https://help.libreoffice.org/7.6/en-US/text/swriter/guide/chapter_numbering.html [3] https://bugs.documentfoundation.org/show_bug.cgi?id=107573#c15 [4] https://bugs.documentfoundation.org/show_bug.cgi?id=83071#c21 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152604] ActiveSheet.ChartObjects.Count reports false numbers
https://bugs.documentfoundation.org/show_bug.cgi?id=152604 Stéphane Aulery changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #2 from Stéphane Aulery --- *** This bug has been marked as a duplicate of bug 111303 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 111303] BASIC error '91' on iCount = ActiveChart.SeriesCollection.Count
https://bugs.documentfoundation.org/show_bug.cgi?id=111303 --- Comment #10 from Stéphane Aulery --- *** Bug 152604 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152604] ActiveSheet.ChartObjects.Count reports false numbers
https://bugs.documentfoundation.org/show_bug.cgi?id=152604 Stéphane Aulery changed: What|Removed |Added See Also||http://bugs.debian.org/6423 ||29 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152604] ActiveSheet.ChartObjects.Count reports false numbers
https://bugs.documentfoundation.org/show_bug.cgi?id=152604 --- Comment #1 from Stéphane Aulery --- Created attachment 184252 --> https://bugs.documentfoundation.org/attachment.cgi?id=184252=edit debug_document_2.xlsm -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152604] New: ActiveSheet.ChartObjects.Count reports false numbers
https://bugs.documentfoundation.org/show_bug.cgi?id=152604 Bug ID: 152604 Summary: ActiveSheet.ChartObjects.Count reports false numbers Product: LibreOffice Version: 7.4.3.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: lk...@free.fr Description: ActiveSheet.ChartObjects.Count reports false numbers Steps to Reproduce: Hello, I can reproduce this bug on Windows 7 with LO 6.0.6.2 and 7.4.3.2 (x64), but it was found on Debian with LO 5.4.0-1 and 3.4.3. In fact there are 2 bugs in this example: To reproduce execute sub ComputeTableSolaire() in Module1 of the VBAProject. a) In sheet "Graphics Solaire" the graph is an object but in sheet "Cumul Solaire" the graph is really a graph. You can see it in the object navigator. If I insert a graph in the sheet "Graphics Solaire" with the menu Insert > Graph..., an object is inserted, not a graph. ChartObjects.Count return 0 on sheet "Graphics Solaire" and 1 on sheet "Cumul Solaire". b) The name property on a Chart object return an empty string. Regards, -- Stéphane Aulery Actual Results: a) ActiveSheet.ChartObjects.Count always return 0. b) The name property on a Chart object return an empty string. Expected Results: a) ActiveSheet.ChartObjects.Count should report 1 in both cases. b) The name property on a Chart object should return the cart name. Reproducible: Always User Profile Reset: No Additional Info: See the file attached which reproduces the behavior. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152519] SurroundingText is not working in kf5 VCL
https://bugs.documentfoundation.org/show_bug.cgi?id=152519 --- Comment #9 from Xuetian Weng --- While it is possible to implement a polling like logic. Retrieving surrounding text is an expensive query, so I'd prefer libreoffice to notify the change instead of letting input method poll it. Also, the implementation itself seems not working properly. Even if I tried to hack fcitx5-qt to poll the surrounding text by explicitly query the object, it return value for inputMethodQuery(Qt::ImSurroundingText) is still QVariant(Invalid). So despite of adding qApp->inputMethod()->update(Qt::ImSurroundingText | Qt::ImCursorPosition | Qt::ImAnchorPosition) to a proper place maybe also check if this lcl_retrieveSurrounding actually works. https://github.com/LibreOffice/core/blob/d57836db76fcf3133e6eb54d264c774911015e08/vcl/qt5/QtWidget.cxx#L897 Gtk counterpart seems to use a different approach for retrieving surrounding https://github.com/LibreOffice/core/blob/83485052e6cac574754191c59371dbc41383b810/vcl/unx/gtk3/gtkframe.cxx#L5824 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145397] Navigator does not select/highlight names of images, objects, tables etc that get focus (Impress/Draw)
https://bugs.documentfoundation.org/show_bug.cgi?id=145397 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #2 from Stéphane Guillou (stragu) --- Reproduced in: Version: 7.4.3.2 / LibreOffice Community Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: de-DE (en_AU.UTF-8); UI: en-US Calc: threaded But works for me in: Version: 7.5.0.0.beta1 (X86_64) / LibreOffice Community Build ID: 3aca23eec42e9d6fbe57071d7633ae1fc4bc5fcc CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103030] [META] Navigator sidebar deck and floating window
https://bugs.documentfoundation.org/show_bug.cgi?id=103030 Bug 103030 depends on bug 145397, which changed state. Bug 145397 Summary: Navigator does not select/highlight names of images, objects, tables etc that get focus (Impress/Draw) https://bugs.documentfoundation.org/show_bug.cgi?id=145397 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103030] [META] Navigator sidebar deck and floating window
https://bugs.documentfoundation.org/show_bug.cgi?id=103030 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||152603 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=152603 [Bug 152603] drag-and-drop objects in navigator doesn't work below last item -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152603] New: drag-and-drop objects in navigator doesn't work below last item
https://bugs.documentfoundation.org/show_bug.cgi?id=152603 Bug ID: 152603 Summary: drag-and-drop objects in navigator doesn't work below last item Product: LibreOffice Version: 7.5.0.0 beta1+ Hardware: All OS: All Status: UNCONFIRMED Severity: minor Priority: low Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: stephane.guil...@libreoffice.org CC: rayk...@gmail.com Blocks: 103030, 145359 Created attachment 184251 --> https://bugs.documentfoundation.org/attachment.cgi?id=184251=edit test slide In Impress / Draw, since the fix for bug 145359, we can drag and drop objects in and out of groups. However, dropping into the empty area under the last element in the tree doesn't do anything. Steps: 1. Open attachment 2. Open navigator sidebar 3. Drag and drop Shape 2 in the empty area below Shape 4 Result: A green line appears under the last item, but nothing happens when Shape 2 is dropped. Expected: Object is placed last, at the same level as the item below which it is placed (in this case, ungrouped. If Shape 4 was part of a group, Shape 2 would enter the group.) Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103030 [Bug 103030] [META] Navigator sidebar deck and floating window https://bugs.documentfoundation.org/show_bug.cgi?id=145359 [Bug 145359] Enter group: functionality to add an existing shape to a group is missing -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152519] SurroundingText is not working in kf5 VCL
https://bugs.documentfoundation.org/show_bug.cgi?id=152519
Xuetian Weng changed:
What|Removed |Added
Resolution|NOTOURBUG |---
Status|RESOLVED|REOPENED
--- Comment #8 from Xuetian Weng ---
The issue for libreoffice is that, although it implements the surrounding
support.
Like:
https://github.com/LibreOffice/core/blob/d57836db76fcf3133e6eb54d264c774911015e08/vcl/qt5/QtWidget.cxx#L893
It doesn't seem to notify input method about surrounding changes, which is
usually done with QWidget::updateMicroFocus(), or call
QGuiApplication::inputMethod()->update(FLAGS).
```
void QWidget::updateMicroFocus()
{
// updating everything since this is currently called for any kind of state
change
if (this == QGuiApplication::focusObject())
QGuiApplication::inputMethod()->update(Qt::ImQueryAll);
}
```
I can only find libreoffice's qt implementation notifies about cursor rectangle
change at
https://github.com/LibreOffice/core/blob/d57836db76fcf3133e6eb54d264c774911015e08/vcl/qt5/QtWidget.cxx#L628
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102495 Bug 102495 depends on bug 152519, which changed state. Bug 152519 Summary: SurroundingText is not working in kf5 VCL https://bugs.documentfoundation.org/show_bug.cgi?id=152519 What|Removed |Added Status|RESOLVED|REOPENED Resolution|NOTOURBUG |--- -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152602] copy of string fails if in a hyperlinked cell (XLSX)
https://bugs.documentfoundation.org/show_bug.cgi?id=152602 m.a.riosv changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m.a.riosv --- Looks like the same issue reported on bug#149483 *** This bug has been marked as a duplicate of bug 149483 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149483] Copy/Paste of partial cell contents string with hyperlink in recent versions, string with link appears _twice_
https://bugs.documentfoundation.org/show_bug.cgi?id=149483 m.a.riosv changed: What|Removed |Added CC||web...@att.net --- Comment #3 from m.a.riosv --- *** Bug 152602 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 152588] FILEOPEN, FORMATTING Invalid row height when opening Excel file saved with aspose-cells
https://bugs.documentfoundation.org/show_bug.cgi?id=152588 Rafael Lima changed: What|Removed |Added CC||rafael.palma.l...@gmail.com Keywords||filter:xlsx Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #5 from Rafael Lima --- I can confirm that row 6 has excessive height using LO 7.6 as reported by the user. Now a few more test results: 1) Row 6 opens fine with MS Excel desktop 2) However in Excel Online the row has the same height as in LO 3) OnlyOffice and Google Sheets get the correct row height Tested with Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 01c9c971e43782800ebf63acc763a7e7fba096c1 CPU threads: 12; OS: Linux 5.19; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 59284] [META] Cell border related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=59284 Rafael Lima changed: What|Removed |Added Depends on||152558 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=152558 [Bug 152558] Calc Cell Borders are inconsistent with the drop-down graphic selector. Also, No help page for manual definitions -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152558] Calc Cell Borders are inconsistent with the drop-down graphic selector. Also, No help page for manual definitions
https://bugs.documentfoundation.org/show_bug.cgi?id=152558 Rafael Lima changed: What|Removed |Added Blocks||59284 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=59284 [Bug 59284] [META] Cell border related issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 152558] Calc Cell Borders are inconsistent with the drop-down graphic selector. Also, No help page for manual definitions
https://bugs.documentfoundation.org/show_bug.cgi?id=152558 Rafael Lima changed: What|Removed |Added Blocks||59284 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=59284 [Bug 59284] [META] Cell border related issues -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 152600] Black squares instead of cell references when selecting cells in a formula
https://bugs.documentfoundation.org/show_bug.cgi?id=152600 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #4 from m.a.riosv --- Test updating the driver from Intel. It was a great help for me. https://www.intel.la/content/www/xl/es/support/intel-driver-support-assistant.html -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144141] Remember last used line width (and other settings) for cell borders
https://bugs.documentfoundation.org/show_bug.cgi?id=144141 Rafael Lima changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||2558 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152558] Calc Cell Borders are inconsistent with the drop-down graphic selector. Also, No help page for manual definitions
https://bugs.documentfoundation.org/show_bug.cgi?id=152558 Rafael Lima changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||4141 CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||rafael.palma.l...@gmail.com --- Comment #2 from Rafael Lima --- I also agree that the current default width is too thick. Instead of 0.75pt we could go with 0.5pt or even 0.25pt (which is not available in the dropdown). The previews are also thicker than what you actually get when applying the border. IIRC using the hairline (0.05pt) caused XLSX export issues, making the line appear dashed in MS Excel. Here's a related request: bug 144141. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 152558] Calc Cell Borders are inconsistent with the drop-down graphic selector. Also, No help page for manual definitions
https://bugs.documentfoundation.org/show_bug.cgi?id=152558 Rafael Lima changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||4141 CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||rafael.palma.l...@gmail.com --- Comment #2 from Rafael Lima --- I also agree that the current default width is too thick. Instead of 0.75pt we could go with 0.5pt or even 0.25pt (which is not available in the dropdown). The previews are also thicker than what you actually get when applying the border. IIRC using the hairline (0.05pt) caused XLSX export issues, making the line appear dashed in MS Excel. Here's a related request: bug 144141. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 152602] New: copy of string fails if in a hyperlinked cell (XLSX)
https://bugs.documentfoundation.org/show_bug.cgi?id=152602 Bug ID: 152602 Summary: copy of string fails if in a hyperlinked cell (XLSX) Product: LibreOffice Version: 7.4.2.3 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: web...@att.net Description: I have an XLS with a cell that is hyperlinked. Selecting and copying text does not perform the copy to the clipboard. Steps to Reproduce: 1. open an XLSX where a cell is hyperlinked 2. select the cell 3. select some of the text in the formula field, RMB > Copy (or Ctrl+C) 4. open Notepad, Paste Actual Results: observe nothing is pasted (or some previously selected text is pasted) Expected Results: the selected text should be copied to the clipboard Reproducible: Always User Profile Reset: No Additional Info: n/a -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113395] [META] Color split and group buttons in toolbar and sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=113395 Bug 113395 depends on bug 85592, which changed state. Bug 85592 Summary: Font and highlight colour toolbar buttons dont work in comments https://bugs.documentfoundation.org/show_bug.cgi?id=85592 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 106179] [META] Writer comment bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=106179 Bug 106179 depends on bug 85592, which changed state. Bug 85592 Summary: Font and highlight colour toolbar buttons dont work in comments https://bugs.documentfoundation.org/show_bug.cgi?id=85592 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 85592] Font and highlight colour toolbar buttons dont work in comments
https://bugs.documentfoundation.org/show_bug.cgi?id=85592 Justin L changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |jl...@mail.com |desktop.org | Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #23 from Justin L --- Documented API CHANGE in 7.6 release notes. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152535] "Grand" in subtotal has bad localization.
https://bugs.documentfoundation.org/show_bug.cgi?id=152535 Rafael Lima changed: What|Removed |Added Ever confirmed|0 |1 CC||rafael.palma.l...@gmail.com Status|UNCONFIRMED |NEW --- Comment #1 from Rafael Lima --- I agree with this request. The way the code was created may work well in English, but in other languages it wouldn't be fine. For example, as pointed out by Olivier, in "Grand Average" the word "Grand" would come second in the translation "Média Geral". See the code here: https://opengrok.libreoffice.org/xref/core/sc/source/core/data/table3.cxx?r=a6ec933d#2267 The word "Grand" coming first is hardcoded. To fix this we would have to create a separate string for all possible functions that can be used. For a list, see here: https://opengrok.libreoffice.org/xref/core/sc/source/core/data/table3.cxx?r=a6ec933d#2038 For instance, we could have a STR_TABLE_GRAND_AVG, STR_TABLE_GRAND_COUNT and so on. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 85592] Font and highlight colour toolbar buttons dont work in comments
https://bugs.documentfoundation.org/show_bug.cgi?id=85592 --- Comment #22 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/70d9e7eadb1069b5e7a1909c671b9348b740cca1 tdf#85592 android: .uno:BackColor deprecated, use .uno:CharBackColor It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: android/source
android/source/src/java/org/libreoffice/FontController.java |5 +
android/source/src/java/org/libreoffice/InvalidationHandler.java |2 +-
2 files changed, 2 insertions(+), 5 deletions(-)
New commits:
commit 70d9e7eadb1069b5e7a1909c671b9348b740cca1
Author: Justin Luth
AuthorDate: Tue Sep 20 20:25:37 2022 -0400
Commit: Justin Luth
CommitDate: Tue Dec 20 00:15:43 2022 +
tdf#85592 android: .uno:BackColor deprecated, use .uno:CharBackColor
Follow-up. I didn't want to include it in the main deprecation patch.
No good reason - android is just too different and untestable by me.
Change-Id: I661211aea619af256e38dc685fdd0662e5aa7272
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140284
Reviewed-by: Justin Luth
Tested-by: Jenkins
diff --git a/android/source/src/java/org/libreoffice/FontController.java
b/android/source/src/java/org/libreoffice/FontController.java
index e0161076a5a1..72f35d8b42d8 100644
--- a/android/source/src/java/org/libreoffice/FontController.java
+++ b/android/source/src/java/org/libreoffice/FontController.java
@@ -171,12 +171,9 @@ public class FontController implements
AdapterView.OnItemSelectedListener {
if(mActivity.getTileProvider().isSpreadsheet()){
json.put("BackgroundColor", valueJson);
LOKitShell.sendEvent(new LOEvent(LOEvent.UNO_COMMAND,
".uno:BackgroundColor", json.toString()));
-}else if(mActivity.getTileProvider().isPresentation()){
+}else {
json.put("CharBackColor", valueJson);
LOKitShell.sendEvent(new LOEvent(LOEvent.UNO_COMMAND,
".uno:CharBackColor", json.toString()));
-}else {
-json.put("BackColor", valueJson);
-LOKitShell.sendEvent(new LOEvent(LOEvent.UNO_COMMAND,
".uno:BackColor", json.toString()));
}
changeFontBackColorBoxColor(color);
diff --git a/android/source/src/java/org/libreoffice/InvalidationHandler.java
b/android/source/src/java/org/libreoffice/InvalidationHandler.java
index 0f3f1dd7b889..c48127cce67f 100644
--- a/android/source/src/java/org/libreoffice/InvalidationHandler.java
+++ b/android/source/src/java/org/libreoffice/InvalidationHandler.java
@@ -342,7 +342,7 @@ public class InvalidationHandler implements
Document.MessageCallback, Office.Mes
mContext.getFormattingController().onToggleStateChanged(Document.NUMBERED_LIST,
pressed);
} else if (parts[0].equals(".uno:Color")) {
mContext.getFontController().colorPaletteListener.updateColorPickerPosition(Integer.parseInt(value));
-} else if (mContext.getTileProvider().isTextDocument() &&
parts[0].equals(".uno:BackColor")) {
+} else if (mContext.getTileProvider().isTextDocument() &&
(parts[0].equals(".uno:BackColor") || parts[0].equals(".uno:CharBackColor"))) {
mContext.getFontController().backColorPaletteListener.updateColorPickerPosition(Integer.parseInt(value));
} else if (mContext.getTileProvider().isPresentation() &&
parts[0].equals(".uno:CharBackColor")) {
mContext.getFontController().backColorPaletteListener.updateColorPickerPosition(Integer.parseInt(value));
[Libreoffice-bugs] [Bug 152327] "Select unprotected cells" when no cells are unprotected makes data entry impossible
https://bugs.documentfoundation.org/show_bug.cgi?id=152327 Stéphane Guillou (stragu) changed: What|Removed |Added Whiteboard| QA:needsComment| OS|Windows (All) |All Severity|minor |major Version|6.3.4.2 release |6.2 all versions --- Comment #2 from Stéphane Guillou (stragu) --- Igor, please don't change the OS to Windows if I have already reported the bug being present on Linux. What is the reasoning behind changing the severity value? Finally, please share your version / hardware info when confirming bugs. Bug also present in: Version: 6.2.0.0.beta1 Build ID: d1b41307be3f8c19fe6f1938cf056e7ff1eb1d18 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3; Locale: en-AU (en_AU.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152532] Assign Action dialog does not scroll to the event automatically in kf5
https://bugs.documentfoundation.org/show_bug.cgi?id=152532 Rafael Lima changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #3 from Rafael Lima --- > Do I understand correctly that steps to reproduce are as follows? Hi Michael. Yes, these are the exact steps. Thanks for the detailed info. (In reply to Michael Weghorn from comment #2) > In my case, it isn't visible (scrolled to) for gen either. Could you please > double-check that it actually works for you? I don't know why, but now I'm getting a weird result now. When I follow these steps I get scrolled to in gen, gtk3 and kf5. All of them are working, even with older LO versions. Might this be related to the KDE frameworks version? I'm on Kubuntu 22.10 using framweorks 5.100. Tomorrow I'll run more tests on another machine. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152247] Automatic translation does not work with our own documentation guides
https://bugs.documentfoundation.org/show_bug.cgi?id=152247
--- Comment #8 from Jean-Baptiste Faure ---
(In reply to Dieter from comment #7)
> (In reply to Jean-Baptiste Faure from comment #5)
> > No, it is: https://api-free.deepl.com/v2/translate
>
> Tested with this URL and an authentication key, but result is still the same
> ("Requested clipboard format is not available.") Shall I open new bug report?
I don't know. Now I get the same error message if I try to reproduce my tests,
but doing so I exceeded my 500,000 characters limit. Have you checked the
consumption of your package?
I can't try again before 26/12.
Best regards. JBF
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - postprocess/CustomTarget_images.mk
postprocess/CustomTarget_images.mk | 35 ++- 1 file changed, 22 insertions(+), 13 deletions(-) New commits: commit d4c8a52ced106709cbb09795e6ac19595953d534 Author: Christian Lohmaier AuthorDate: Sat Dec 10 17:52:23 2022 +0100 Commit: Christian Lohmaier CommitDate: Mon Dec 19 22:48:01 2022 + don't rebuild icon-themes if nothing changed Change-Id: I99ab68852d1f6e915a4cd92a4be2d28209e546ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143934 Tested-by: Jenkins Reviewed-by: Christian Lohmaier (cherry picked from commit 0ff4b4a08deace66567d6248af9e41fc7336a1c1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144062 diff --git a/postprocess/CustomTarget_images.mk b/postprocess/CustomTarget_images.mk index b915aacf988a..0207cde533c8 100644 --- a/postprocess/CustomTarget_images.mk +++ b/postprocess/CustomTarget_images.mk @@ -92,21 +92,30 @@ $(packimages_DIR)/sourceimagelist.ilst : \ sed 's/\.png/\.svg/g' $@.png > $@.svg cat $@.png $@.svg > $@ -# commandimagelist.ilst and sorted.lst are phony to rebuild everything each time -.PHONY : $(packimages_DIR)/commandimagelist.ilst $(packimages_DIR)/sorted.lst +packimages_everything := $(shell $(FIND) $(SRCDIR)/icon-themes) +packimages_icon_themes := $(filter %/,$(wildcard $(SRCDIR)/icon-themes/*/)) +# TODO: awkward workaround for windows - the filter call chokes for some reason +# on the full list, and similarly the recursive filtering call from the initial +# version of the patch also fails on windows for some reason +# so don't try to be clever and do it in this awkward/tedious way. +# all this does is filtering everything for png/svg files that have /cmd/ as +# part of their path and then replacing the path to the theme-directory with +# %MODULE% - the surrounding sort not only sorts the lists, but gets rid of +# duplicate filenames that are left after the %MODULE% replacement +packimages_cmd_images := $(sort $(foreach file,$(packimages_everything),\ +$(if $(findstring /cmd/,$(filter %.png %.svg,$(file))),\ +$(foreach theme,$(packimages_icon_themes),\ +$(filter-out $(SRCDIR)/%,$(subst $(theme),%MODULE%/,$(file))) -$(packimages_DIR)/commandimagelist.ilst : - $(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),$(true),PRL,1) - $(call gb_Trace_StartRange,$(subst $(WORKDIR)/,,$@),PRL) - $(call gb_Helper_abbreviate_dirs, \ - $(FIND) $(SRCDIR)/icon-themes -name "*.png" -o -name "*.svg" | \ - grep -e '/cmd/' | sed 's#^.*/icon-themes/[^/]*##' | \ - sed "s#^#%MODULE%#" | \ - LC_ALL=C $(SORT) -u > $@.tmp && \ - $(call gb_Helper_replace_if_different_and_touch,$@.tmp,$@)) - $(call gb_Trace_EndRange,$(subst $(WORKDIR)/,,$@),PRL) +# adding everything as dependencies here, so that file deletion (when only the directory timestamp +# gets updated) will also trigger regeneration of the list +$(packimages_DIR)/commandimagelist.ilst : $(packimages_everything) + $(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),$(true),LST,1) + $(call gb_Trace_StartRange,$(subst $(WORKDIR)/,,$@),LST) + $(file >$@,$(subst $(WHITESPACE),$(NEWLINE),$(packimages_cmd_images))) + $(call gb_Trace_EndRange,$(subst $(WORKDIR)/,,$@),LST) -$(packimages_DIR)/sorted.lst : \ +$(packimages_DIR)/sorted.lst : $(packimages_DIR)/commandimagelist.ilst \ $(SRCDIR)/postprocess/packimages/image-sort.lst \ $(call gb_Postprocess_get_target,AllUIConfigs) \ $(call gb_ExternalExecutable_get_dependencies,python)
[Libreoffice-bugs] [Bug 152327] "Select unprotected cells" when no cells are unprotected makes data entry impossible
https://bugs.documentfoundation.org/show_bug.cgi?id=152327 Igor Piltz changed: What|Removed |Added Severity|major |minor Version|6.3.6.2 release |6.3.4.2 release Hardware|All |x86-64 (AMD64) OS|All |Windows (All) --- Comment #1 from Igor Piltz --- Confirmed. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152597] Drop multi-module template view in Start Center
https://bugs.documentfoundation.org/show_bug.cgi?id=152597 V Stuart Foote changed: What|Removed |Added CC||vsfo...@libreoffice.org --- Comment #1 from V Stuart Foote --- The thumbnail views of templates are useful. Previously they were accessed by split button from SC menu bar. The listbox/drop list was added to the backing window of the SC. We'd looked at doing tabs on the SC backing window when SC was being worked up but rejected it. The SC provides thumbnail previews of existing documents, and thumbnails of the available templates by module. Templates have to sorted/organized in some fashion -old split button, a drop list by module (or all), or a tab by module. The multi-mode/all templates is fine otherwise as it lists them all including any customized/extension based templates (think a corporate setting with well styled templates). What is missing is ability to purge the default bundled templates. -1 to a blanket dropping the multi-mode/all templates view; but open to revisiting template controls as present on the SC backing window. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120638] DOCX: The logical 'or' symbol | in the formula editor is not displayed correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=120638 Rajasekaran Karunanithi changed: What|Removed |Added CC||rajasekara...@gmail.com --- Comment #6 from Rajasekaran Karunanithi --- Still presents in LO 7.6 alpha under Windows 10(x64). Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: ad387d5b984c906505d25685065f710ed55d CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: en-IN (en_IN); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
