[Libreoffice-commits] core.git: include/vcl vcl/source
include/vcl/glyphitemcache.hxx | 10 +- include/vcl/rendercontext/State.hxx |2 +- vcl/source/gdi/impglyphitem.cxx |4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) New commits: commit 286bbda9cd991c0a31c1cb88916507e586469434 Author: Noel Grandin AuthorDate: Tue Oct 10 13:25:36 2023 +0200 Commit: Noel Grandin CommitDate: Thu Oct 12 07:57:20 2023 +0200 cool#7318 Calc rendering acceleration (part2) we are spending a lot of time in SalLayoutGlyphsCache::GetLayoutGlyphs, and most of that is inserting into the GlyphsCache, which has a very very large key. Shrink that key a little bit Change-Id: I6f27c147652521502dba4517afd9a2ae2a6daebb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157754 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/include/vcl/glyphitemcache.hxx b/include/vcl/glyphitemcache.hxx index 6c4c1ea1294b..a5a8ec1518e4 100644 --- a/include/vcl/glyphitemcache.hxx +++ b/include/vcl/glyphitemcache.hxx @@ -80,12 +80,12 @@ private: double fontScaleX; double fontScaleY; MapMode mapMode; -bool rtl; -bool disabledLigatures; // because of fixed pitch -bool artificialItalic; -bool artificialBold; -vcl::text::ComplexTextLayoutFlags layoutMode; LanguageType digitLanguage; +vcl::text::ComplexTextLayoutFlags layoutMode; +bool rtl : 1; +bool disabledLigatures : 1; // because of fixed pitch +bool artificialItalic : 1; +bool artificialBold : 1; size_t hashValue; CachedGlyphsKey(const VclPtr& dev, OUString t, sal_Int32 i, sal_Int32 l, tools::Long w); diff --git a/include/vcl/rendercontext/State.hxx b/include/vcl/rendercontext/State.hxx index 042eb2deca7a..0359a486e4b2 100644 --- a/include/vcl/rendercontext/State.hxx +++ b/include/vcl/rendercontext/State.hxx @@ -73,7 +73,7 @@ namespace vcl::text { // Layout flags for Complex Text Layout // These are flag values, i.e they can be combined -enum class ComplexTextLayoutFlags +enum class ComplexTextLayoutFlags : sal_uInt8 { Default = 0x, BiDiRtl = 0x0001, diff --git a/vcl/source/gdi/impglyphitem.cxx b/vcl/source/gdi/impglyphitem.cxx index 1de52c7597ce..ca8016a1925d 100644 --- a/vcl/source/gdi/impglyphitem.cxx +++ b/vcl/source/gdi/impglyphitem.cxx @@ -490,9 +490,9 @@ SalLayoutGlyphsCache::CachedGlyphsKey::CachedGlyphsKey( // That would occasionally lead to rounding errors (at least differences that would // make checkGlyphsEqual() fail). , mapMode(outputDevice->GetMapMode()) -, rtl(outputDevice->IsRTLEnabled()) -, layoutMode(outputDevice->GetLayoutMode()) , digitLanguage(outputDevice->GetDigitLanguage()) +, layoutMode(outputDevice->GetLayoutMode()) +, rtl(outputDevice->IsRTLEnabled()) { const LogicalFontInstance* fi = outputDevice->GetFontInstance(); fi->GetScale(, );
[Libreoffice-commits] core.git: vcl/source
vcl/source/bitmap/BitmapEx.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 3622404f09448b82c095256140afe6240b522ece Author: Noel Grandin AuthorDate: Wed Oct 11 12:54:43 2023 +0200 Commit: Noel Grandin CommitDate: Thu Oct 12 07:57:02 2023 +0200 tdf#157636 FILEOPEN: PPT: Images have no background regression from commit 81994cb2b8b32453a92bcb011830fcb884f22ff3 Convert internal vcl bitmap formats transparency->alpha (II) Change-Id: Ia0ed01e7c0d41bd909fe48666bc9aca5ff31d2bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157824 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/vcl/source/bitmap/BitmapEx.cxx b/vcl/source/bitmap/BitmapEx.cxx index c9be55521f16..7333aea90cc3 100644 --- a/vcl/source/bitmap/BitmapEx.cxx +++ b/vcl/source/bitmap/BitmapEx.cxx @@ -1447,6 +1447,7 @@ void BitmapEx::CombineMaskOr(Color maskColor, sal_uInt8 nTol) Bitmap aNewMask = maBitmap.CreateMask( maskColor, nTol ); if ( IsAlpha() ) aNewMask.CombineOr( maAlphaMask ); +aNewMask.Invert(); maAlphaMask = aNewMask; }
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/shells/translatehelper.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 44fed6aec98320bf7ec793f08447bb8d455abc4f Author: Mike Kaganski AuthorDate: Wed Oct 11 18:01:19 2023 +0300 Commit: Mike Kaganski CommitDate: Thu Oct 12 07:40:45 2023 +0200 Do not compare SwContentIndex instances from different nodes It fires an assert in dbgutil builds; and it doesn't make sense anyway: we must use the index from the beginning, not a strange minimal value between indices in start node and end node. Change-Id: I4a2b6062f5524703737ca6029f428f30555d25b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157842 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/sw/source/uibase/shells/translatehelper.cxx b/sw/source/uibase/shells/translatehelper.cxx index c62e4a59749c..64cd27e1fe1d 100644 --- a/sw/source/uibase/shells/translatehelper.cxx +++ b/sw/source/uibase/shells/translatehelper.cxx @@ -178,7 +178,7 @@ void TranslateDocumentCancellable(SwWrtShell& rWrtSh, const TranslateAPIConfig& else if (n == startNode) { cursor->SetMark(); -cursor->GetPoint()->nContent = std::min(aPoint.nContent, aMark.nContent); +cursor->GetPoint()->nContent = aPoint.nContent; } else if (n == endNode) {
[Libreoffice-bugs] [Bug 157440] Impress slide images, group exported by HTML are different than single slide export, causing transition bleed through in Shotcut.
https://bugs.documentfoundation.org/show_bug.cgi?id=157440 Stéphane Guillou (stragu) changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #7 from Stéphane Guillou (stragu) --- Thanks for the files. I can see in Shotcut that the two different JPG you provide will behave differently when they have some overlap. Both of them will have the "Dissolve" transition applied automatically on the overlap, but for the HTML-exported pictures, the background becomes visible during the transition, like in your video. So I can confirm your issue with the files your provided, but I am unsure if it needs solving on LO's end or on Shotcut's end. I tried getting the same kind of exports on my end but I couldn't: I get the same as the "good" single-slide export for the two methods. Version: 7.5.7.1 (X86_64) / LibreOffice Community Build ID: 47eb0cf7efbacdee9b19ae25d6752381ede23126 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded I even tried with a build at 26a8966b07f6335450ddbf4b0f5d5206db43bcbf to have a similar version to yours. ImageMagick identify between the provided pictures: - single slide export: JPEG 1821x1024 1821x1024+0+0 8-bit sRGB 276082B 0.000u 0:00.000 - HTML export: JPEG 1920x1079 1920x1079+0+0 8-bit sRGB 210232B 0.000u 0:00.000 ... so I have no idea what the difference between the two files actually is. Can you also send a sample of the presentation file itself? (ODP) My version of Shotcut is 23.09.29. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157634] LibreOffice crashes when I open the "open ..." or "save as ..."-window
https://bugs.documentfoundation.org/show_bug.cgi?id=157634 --- Comment #6 from nikla...@oslomet.no --- I have reinstalled LibreOffice and removed all user-specific configuration files. The error seems to occur when LibreOffice tries to show a window, for example when I paste ctrl+shift+v or open the configuration menu, or similar. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157413] URLlink Button placed on top of a chart presents a URL tip popup when the mouse hovers anywhere over the chart
https://bugs.documentfoundation.org/show_bug.cgi?id=157413 --- Comment #16 from Colin --- (In reply to Colin from comment #2) > What may be another symptom of the problem is that when identifying the file > to which the URL relates, it used to be that one could simply hover the > mouse over the URL type selector and use the mouse scroll wheel to scroll > between "TEXT" & "BUTTON" as opposed to formally entering the list to select > or interacting with the selector button. 7.5.6.2 was only installed > yeaterday and the "feature" identified itself immediately following > installation. > This may be a symptom of a recent windows 10 update. I've just noticed that other - less frequently used apps - that previously permitted "scroll on hover" now also continue scrolling the whole page instead of the selection box. Is it worth anybody verifiying that I haven't just "lost my marbles" -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157634] LibreOffice crashes when I open the "open ..." or "save as ..."-window
https://bugs.documentfoundation.org/show_bug.cgi?id=157634 nikla...@oslomet.no changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157634] LibreOffice crashes when I open the "open ..." or "save as ..."-window
https://bugs.documentfoundation.org/show_bug.cgi?id=157634 --- Comment #5 from nikla...@oslomet.no --- Version: 7.6.2.1 (X86_64) / LibreOffice Community Build ID: 56f7684011345957bbf33a7ee678afaf4d2ba333 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: nb-NO (nb_NO); UI: nb-NO Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157715] CALC FORMAT JUSTIFICATION INDENT Poorly Defined Update
https://bugs.documentfoundation.org/show_bug.cgi?id=157715 --- Comment #1 from Colin --- Created attachment 190161 --> https://bugs.documentfoundation.org/attachment.cgi?id=190161=edit Screen Dump -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157715] New: CALC FORMAT JUSTIFICATION INDENT Poorly Defined Update
https://bugs.documentfoundation.org/show_bug.cgi?id=157715 Bug ID: 157715 Summary: CALC FORMAT JUSTIFICATION INDENT Poorly Defined Update Product: LibreOffice Version: 7.5.7.1 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: that.man.co...@gmail.com Description: The latest update has changed the default automatic increment button from single points to multiples of 10 points. Typing 3 works fine but rolling up three stops gives a thirty-point indent. I can't imagine anybody with any experience of typesetting wanting to indent a CALC cell with such extreme increments. Screen dump attached Steps to Reproduce: Right-click any cell Select Format Cells Select Alignment Select (Horizontal) Left Scroll one increment on the scrollbar Scroll another increment Get bored See attached Screen Dump Actual Results: Excessive adjustment Expected Results: The fine tuning inherent with the use of typographical points - that is 1/72nd of an inch not almost 25% of the default cell width. Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: en-GB Module: SpreadsheetDocument [Information guessed from browser] OS: Windows (All) OS is 64bit: no -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/ooxmlimport/data/SimpleFirst.docx |binary sw/qa/extras/ooxmlimport/data/SimpleFirst.odt |binary sw/qa/extras/ooxmlimport/data/SimpleFirstLeftRight.docx |binary sw/qa/extras/ooxmlimport/data/SimpleFirstLeftRight.odt |binary sw/qa/extras/ooxmlimport/data/SimpleLeftRight.docx |binary sw/qa/extras/ooxmlimport/data/SimpleLeftRight.odt |binary sw/qa/extras/ooxmlimport/ooxmlimport2.cxx | 214 7 files changed, 214 insertions(+) New commits: commit 955ca0eba5c9ec22fbae0fc3e6220914ec3d69be Author: Tomaž Vajngerl AuthorDate: Wed Oct 11 22:46:03 2023 +0900 Commit: Tomaž Vajngerl CommitDate: Thu Oct 12 06:44:26 2023 +0200 sw: prepare tests cases for first, left, right headers and variants This prepares the test case for first, left, right headers, only first and non-first headers, only left and right (no first) headers and make them run for ODF, where they should work as expected. In a follow up commit, the OOXML implementation should be fixed so that the same tests pass for OOXML documents. Change-Id: I1e7f610324c14dd9eb285ff9d46829610de5b1b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157838 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl diff --git a/sw/qa/extras/ooxmlimport/data/SimpleFirst.docx b/sw/qa/extras/ooxmlimport/data/SimpleFirst.docx new file mode 100644 index ..1641a2d084ed Binary files /dev/null and b/sw/qa/extras/ooxmlimport/data/SimpleFirst.docx differ diff --git a/sw/qa/extras/ooxmlimport/data/SimpleFirst.odt b/sw/qa/extras/ooxmlimport/data/SimpleFirst.odt new file mode 100644 index ..fc165e966f85 Binary files /dev/null and b/sw/qa/extras/ooxmlimport/data/SimpleFirst.odt differ diff --git a/sw/qa/extras/ooxmlimport/data/SimpleFirstLeftRight.docx b/sw/qa/extras/ooxmlimport/data/SimpleFirstLeftRight.docx new file mode 100644 index ..2b530a5e324f Binary files /dev/null and b/sw/qa/extras/ooxmlimport/data/SimpleFirstLeftRight.docx differ diff --git a/sw/qa/extras/ooxmlimport/data/SimpleFirstLeftRight.odt b/sw/qa/extras/ooxmlimport/data/SimpleFirstLeftRight.odt new file mode 100644 index ..d5035ac8f581 Binary files /dev/null and b/sw/qa/extras/ooxmlimport/data/SimpleFirstLeftRight.odt differ diff --git a/sw/qa/extras/ooxmlimport/data/SimpleLeftRight.docx b/sw/qa/extras/ooxmlimport/data/SimpleLeftRight.docx new file mode 100644 index ..80dbda0420d7 Binary files /dev/null and b/sw/qa/extras/ooxmlimport/data/SimpleLeftRight.docx differ diff --git a/sw/qa/extras/ooxmlimport/data/SimpleLeftRight.odt b/sw/qa/extras/ooxmlimport/data/SimpleLeftRight.odt new file mode 100644 index ..61302944da30 Binary files /dev/null and b/sw/qa/extras/ooxmlimport/data/SimpleLeftRight.odt differ diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx b/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx index 76210cd2ef20..6b4054c4e38f 100644 --- a/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx +++ b/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx @@ -48,6 +48,10 @@ class Test : public SwModelTestBase { public: +void checkFirstLeftRightHeaderPageStyles(); +void checkFirstRestHeaderPageStyles(); +void checkLeftRightHeaderPageStyles(); + Test() : SwModelTestBase("/sw/qa/extras/ooxmlimport/data/", "Office Open XML Text") { @@ -1194,6 +1198,216 @@ CPPUNIT_TEST_FIXTURE(Test, testTdf141969) CPPUNIT_ASSERT_EQUAL(8.0f, getProperty(xRun, "CharHeight")); } +void Test::checkFirstLeftRightHeaderPageStyles() +{ +// Page 1 +{ +OUString pageStyle; +uno::Reference xPropertySet(getParagraphOrTable(1), uno::UNO_QUERY); + +uno::Reference xTextRange(xPropertySet, uno::UNO_QUERY); +CPPUNIT_ASSERT_EQUAL(OUString("Para 1"), xTextRange->getString()); + +xPropertySet->getPropertyValue("PageStyleName") >>= pageStyle; +CPPUNIT_ASSERT_EQUAL(OUString("Standard"), pageStyle); +} + +// Page 2 +{ +OUString pageStyle; +uno::Reference xPropertySet(getParagraphOrTable(2), uno::UNO_QUERY); + +uno::Reference xTextRange(xPropertySet, uno::UNO_QUERY); +CPPUNIT_ASSERT_EQUAL(OUString("Para 2"), xTextRange->getString()); + +xPropertySet->getPropertyValue("PageStyleName") >>= pageStyle; +CPPUNIT_ASSERT_EQUAL(OUString("Standard"), pageStyle); +} + +// Page 3 +{ +OUString pageStyle; +uno::Reference xPropertySet(getParagraphOrTable(3), uno::UNO_QUERY); + +uno::Reference xTextRange(xPropertySet, uno::UNO_QUERY); +CPPUNIT_ASSERT_EQUAL(OUString("Para 3"), xTextRange->getString()); + +xPropertySet->getPropertyValue("PageStyleName") >>= pageStyle; +CPPUNIT_ASSERT_EQUAL(OUString("Standard"), pageStyle); +} +} + +void Test::checkFirstRestHeaderPageStyles() +{ +// Page 1 +{ +OUString pageStyle; +uno::Reference
[Libreoffice-bugs] [Bug 144892] new-page blank space put in many pages when converting from Word 4 on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=144892 --- Comment #18 from David Sherman --- I just received a message from Bugzilla asking that I check whether this bug us still present. It is. I have downloaded the latest version of LibreOffice (7.6.2.1 running on a MacBook Pro, MacOS version 12.7, and the bug is the same. I use LibreOffice several times a week to convert Word 4 files to .docx (to send to others), and the same bug still appears. A hard page break gets inserted at the end of a line, more or less near the end of each page but not in any consistent place, and definitely not at the page-break point. I have a workaround in Word (after saving he .docx from LibreOffice), which is simply to search for every ^m and delete it, but a global delete won't work because, if the hard break was inserted in the middle of a paragraph, I have to reconnect the split paragraphs into one, whereas if it wasn't, I just delete the hard break. So I have to search for each instance of ^m manually and fix it. It's a bit annoying but manageable, and I have no alternative. I have tens of thousands of files I've written over 35 years in Word 4, and I still access many of them regularly and still write new documents in Word 4 for efficiency. So the bug is still present. Contrary to others on this trail who claimed that the hard breaks were in the original file, they aren't visible in Word 4, and they never showed up before (I used Word's own built-in conversion tools for decades until Microsoft stopped supporting conversion from Word 4 a few years ago). Thanks to anyone who can help solve this. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149376] Allow overlap option for Frame and Graphics styles should be disabled by default
https://bugs.documentfoundation.org/show_bug.cgi?id=149376 Telesto changed: What|Removed |Added CC||tele...@surfxs.nl --- Comment #7 from Telesto --- Bug 105102 is probably a duplicate.. I added it as see also because the status is UNCONFIRMED here. It appears it should be set to NEW based on comment 6 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149376] Allow overlap option for Frame and Graphics styles should be disabled by default
https://bugs.documentfoundation.org/show_bug.cgi?id=149376 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||5102 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 105102] Pasting multiple images to Writer document: doing that at once, causes them to be placed on top of each other
https://bugs.documentfoundation.org/show_bug.cgi?id=105102 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||9376 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 41007] EDITING: Insert image dialog should allow to select multiple images
https://bugs.documentfoundation.org/show_bug.cgi?id=41007 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||5102 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 105102] Pasting multiple images to Writer document: doing that at once, causes them to be placed on top of each other
https://bugs.documentfoundation.org/show_bug.cgi?id=105102 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=41 ||007 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 105102] Pasting multiple images to Writer document: doing that at once, causes them to be placed on top of each other
https://bugs.documentfoundation.org/show_bug.cgi?id=105102 Telesto changed: What|Removed |Added CC||danu.tiho...@gmail.com --- Comment #5 from Telesto --- *** Bug 157641 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157641] Image stacking places pictures on separate pages
https://bugs.documentfoundation.org/show_bug.cgi?id=157641 Telesto changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Telesto --- *** This bug has been marked as a duplicate of bug 105102 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157623] Log Text Marker
https://bugs.documentfoundation.org/show_bug.cgi?id=157623 Telesto changed: What|Removed |Added Status|NEW |UNCONFIRMED Ever confirmed|1 |0 CC||tele...@surfxs.nl -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133870] Page wrap and anchoring changes copy/paste using Windows clipboard (since 6.4)
https://bugs.documentfoundation.org/show_bug.cgi?id=133870 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||7714 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157714] FILESAVE RTF When saving ODT doc as RTF, parallel wrap of image changes to Through
https://bugs.documentfoundation.org/show_bug.cgi?id=157714 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||3870 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113403] [META] RTF (text) shape-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=113403 Aron Budea changed: What|Removed |Added Depends on||157714 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=157714 [Bug 157714] FILESAVE RTF When saving ODT doc as RTF, parallel wrap of image changes to Through -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157714] New: FILESAVE RTF When saving ODT doc as RTF, parallel wrap of image changes to Through
https://bugs.documentfoundation.org/show_bug.cgi?id=157714 Bug ID: 157714 Summary: FILESAVE RTF When saving ODT doc as RTF, parallel wrap of image changes to Through Product: LibreOffice Version: 4.0.0.3 release Hardware: All OS: All Status: UNCONFIRMED Keywords: bibisectRequest, regression Severity: normal Priority: medium Component: filters and storage Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: aron.bu...@gmail.com Blocks: 113403 This report has been inspired by, and is slightly related to bug 133870. - Open attachment 160618, - Save as RTF and reopen. => Shape now covers the text. Saved RTF looks like that in Word, too, so it's an export issue. The shape in the ODT has Parallel wrap. In the saved RTF, it has Through wrap. Observed using LO Version: 24.2.0.0.alpha0+ (7d6ca465224e5e839055e9607deeb2a80a93621b), 4.0.0.3 / Windows. Still ok in 3.6.0.4. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=113403 [Bug 113403] [META] RTF (text) shape-related issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157713] New: User-configuration location for language packs
https://bugs.documentfoundation.org/show_bug.cgi?id=157713 Bug ID: 157713 Summary: User-configuration location for language packs Product: LibreOffice Version: 7.6.2.1 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Localization Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: maxim.courno...@gmail.com Hi, I'm using GNU Guix as my package manager/distribution and would like to package the language packs. It seems like on traditional distributions such as Debian, the data files goes to a global place such as: /usr/lib/libreoffice/program/resource/fr, with additional files put under /usr/lib/libreoffice/share. Guix is a functional package manager, and for this reason it does not follow the file hierachy standard (FHS) and its conventional locations such as /usr/lib. Instead, each package gets installed to its own prefix, e.g. my libreoffice lives at /gnu/store/4z2gglhrzr5w6myw6la86s7lw50zlwml-libreoffice-7.5.4.2, and a user profile is assembled under ~/.guix-profile, e.g. I have: $ ll ~/.guix-profile/lib/libreoffice/ total 2296 -r--r--r-- 7 root root 1842305 31 déc. 1969 CREDITS.fodt dr-xr-xr-x 1 root root 92 31 déc. 1969 help/ -r--r--r-- 7 root root 233913 31 déc. 1969 LICENSE -r--r--r-- 7 root root 263307 31 déc. 1969 LICENSE.html -r--r--r-- 1 root root3706 31 déc. 1969 NOTICE dr-xr-xr-x 1 root root 68 31 déc. 1969 presets/ dr-xr-xr-x 1 root root7894 31 déc. 1969 program/ dr-xr-xr-x 1 root root 24 31 déc. 1969 readmes/ dr-xr-xr-x 1 root root 442 31 déc. 1969 share/ Is there currently a mechanism in LibreOffice to be able to locate them in such an environment? Typically, what is used in Guix for that are environment variables. The use on an environment variable such as LO_LOCPATH would provide the most flexible means of specifying the language packs data location and could be made to work across multiple profiles. Alternatively, if LibreOffice locates the language pack data files relatively to itself, this could work in a given profile where libreoffice is installed along its language packs. For example, LibreOffice could detect it is at /home/maxim/.guix-profile/bin/libreoffice; and try to access its language packs relatively via "../share/libreoffice/language-packs (or some other other default path). I can volunteer to add support for the new LO_LOCPATH environment variable, if that seems reasonable. Thanks! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 58676] EDITING: "Search in all sheets" setting should be persistent after reopening the application
https://bugs.documentfoundation.org/show_bug.cgi?id=58676 --- Comment #17 from Federico Gallo --- Hello, as a candidate to new contributor I would like to add a small perspective on how to workaround this. Currently, the history of Find as well as the state of check-boxes are kept as long as the suite is still open. This means, that if Calc is closed and Writer is opened (while the suite is still opened), the history is there but the checkbox for *All sheets* is obviously not. However, opening Calc again and performing the F action will show the checkbox with its last state/value. So technically, if we see the different modules (Writer, Calc, etc) as part of the whole (the suite), once the suite is closed the history and options are lost. Then the title for this feature request is accurate. And here is the perspective, maybe when a user open a module (Calc for example) finish a task and close the program, maybe the suite should stay active and minimized by default. This could be an option for the user to set. This definitely does not satisfy the feature request but on the other hand this request has more than 10 years of discussion. It will somehow relieve the headache or stress of losing previous searches or options from some users. Because currently while the suite is still open it does it, it keep the state and history -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157440] Impress slide images, group exported by HTML are different than single slide export, causing transition bleed through in Shotcut.
https://bugs.documentfoundation.org/show_bug.cgi?id=157440 --- Comment #6 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157674] Heading Indent lost on Reopening File in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=157674 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157167] saving file.docx as file.odt fails and creates a file.odt.docx if user types quickly
https://bugs.documentfoundation.org/show_bug.cgi?id=157167 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157167] saving file.docx as file.odt fails and creates a file.odt.docx if user types quickly
https://bugs.documentfoundation.org/show_bug.cgi?id=157167 --- Comment #5 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156850] PyQT6 (PySide6) Crashes in Python Macro
https://bugs.documentfoundation.org/show_bug.cgi?id=156850 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156850] PyQT6 (PySide6) Crashes in Python Macro
https://bugs.documentfoundation.org/show_bug.cgi?id=156850 --- Comment #5 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154180] Spelling corrections proposes "it' s" instead of "it's"
https://bugs.documentfoundation.org/show_bug.cgi?id=154180 --- Comment #3 from QA Administrators --- Dear o.rafelsberger, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153912] software changes and adds bookmarks
https://bugs.documentfoundation.org/show_bug.cgi?id=153912 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153912] software changes and adds bookmarks
https://bugs.documentfoundation.org/show_bug.cgi?id=153912 --- Comment #3 from QA Administrators --- Dear CONRAD CABALLERO, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149110] LibreOffice Base slows down if there is an unsaved change to the databse
https://bugs.documentfoundation.org/show_bug.cgi?id=149110 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154534] Can't view the Main menu bar, while choosing the sub design menu.
https://bugs.documentfoundation.org/show_bug.cgi?id=154534 --- Comment #2 from QA Administrators --- Dear Priyanka, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149110] LibreOffice Base slows down if there is an unsaved change to the databse
https://bugs.documentfoundation.org/show_bug.cgi?id=149110 --- Comment #12 from QA Administrators --- Dear Dr. Martinus, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154467] Select and right click pop window not showing the delete option.
https://bugs.documentfoundation.org/show_bug.cgi?id=154467 --- Comment #2 from QA Administrators --- Dear Lajeem shah, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154533] OpenCL: Libreoffice wont start / crash with OpenCL enabled if you have multiple GPUs (Intel+Nvidia) and have dGPU disabled
https://bugs.documentfoundation.org/show_bug.cgi?id=154533 --- Comment #18 from QA Administrators --- Dear makedir, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154497] object clicked and dragged by cursor. cursor visibility size very very small on the drawing page
https://bugs.documentfoundation.org/show_bug.cgi?id=154497 --- Comment #3 from QA Administrators --- Dear Saravanakumar, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154436] Drag the outer circle in the circle diagram at Libre office impress-text is going outside of the circle
https://bugs.documentfoundation.org/show_bug.cgi?id=154436 --- Comment #3 from QA Administrators --- Dear Sangeetha, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153911] Warning when opening files with other files already open
https://bugs.documentfoundation.org/show_bug.cgi?id=153911 --- Comment #10 from QA Administrators --- Dear Nadie Nada Nunca, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 92616] PIVOTTABLE: Grouped Column Fields problems including with drill to details
https://bugs.documentfoundation.org/show_bug.cgi?id=92616 --- Comment #12 from QA Administrators --- Dear alex, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 121135] Function “Navigate By” with "Controls" does not Work if the Design mode for Form Controls is Disabled
https://bugs.documentfoundation.org/show_bug.cgi?id=121135 --- Comment #4 from QA Administrators --- Dear Harald Koester, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144892] new-page blank space put in many pages when converting from Word 4 on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=144892 --- Comment #17 from QA Administrators --- Dear David Sherman, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120921] Function “Navigate By” does not Work Correctly if Cursor is Located in Header or Footer
https://bugs.documentfoundation.org/show_bug.cgi?id=120921 --- Comment #6 from QA Administrators --- Dear Harald Koester, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120894] “Navigate by” Function does not Work Correctly if Form Control are Used
https://bugs.documentfoundation.org/show_bug.cgi?id=120894 --- Comment #7 from QA Administrators --- Dear Harald Koester, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: editeng/qa
editeng/qa/unit/core-test.cxx | 33 + 1 file changed, 13 insertions(+), 20 deletions(-) New commits: commit 4fd6b125751897923428523336a768310a58b36e Author: Tomaž Vajngerl AuthorDate: Wed Oct 11 22:41:02 2023 +0900 Commit: Tomaž Vajngerl CommitDate: Thu Oct 12 05:08:27 2023 +0200 editeng: move the methods into Test class definition This makes makes all the Test class methods contined in the class definition body, so more readable and less noise for the actual test definitions. Change-Id: I3ea177f27aa868a396e537b1682ce91d93c1208e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157837 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl diff --git a/editeng/qa/unit/core-test.cxx b/editeng/qa/unit/core-test.cxx index d3f92ce60c2c..12099ea0a719 100644 --- a/editeng/qa/unit/core-test.cxx +++ b/editeng/qa/unit/core-test.cxx @@ -45,10 +45,20 @@ namespace { class Test : public test::BootstrapFixture { public: -Test(); +Test() {} -virtual void setUp() override; -virtual void tearDown() override; +void setUp() override +{ +test::BootstrapFixture::setUp(); +mpItemPool = new EditEngineItemPool(); +SfxApplication::GetOrCreate(); +} + +void tearDown() override +{ +mpItemPool.clear(); +test::BootstrapFixture::tearDown(); +} #if HAVE_MORE_FONTS /// Test text portions position when percentage line spacing is set @@ -135,23 +145,6 @@ private: rtl::Reference mpItemPool; }; -Test::Test() {} - -void Test::setUp() -{ -test::BootstrapFixture::setUp(); - -mpItemPool = new EditEngineItemPool(); - -SfxApplication::GetOrCreate(); -} - -void Test::tearDown() -{ -mpItemPool.clear(); -test::BootstrapFixture::tearDown(); -} - #if HAVE_MORE_FONTS void Test::testLineSpacing() {
[Libreoffice-bugs] [Bug 157712] New: LibreOffice Calc refuses to save in .UOS format
https://bugs.documentfoundation.org/show_bug.cgi?id=157712 Bug ID: 157712 Summary: LibreOffice Calc refuses to save in .UOS format Product: LibreOffice Version: 7.5.0.3 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: farrell.mar...@gmail.com Description: Final determination: Setting a row as BOLD causes the save to fail as .UOS. I can select a cell and set it to BOLD and no problem. I can set all the columns BOLD one at a time and no problem. I can select the entire spreadsheet and set it to BOLD and no problem. If I select a row and set it to BOLD, the spreadsheet refuses to save as .UOS. Once a row is set as BOLD, you must UNDO to be able to save. Merely changing it by unselecting BOLD has no positive effect. No other formatting seems to affect the ability to save in .UOS format. Mark Thank you in advance. Steps to Reproduce: 1.select row 2.select BOLD 3.Attempt to "Save" or if changing formats "Save as..." .uos Actual Results: Error saving the document xxx.uos: Write Error. The file could not be written. Expected Results: Save spreadsheet in .uos format without error. Reproducible: Always User Profile Reset: No Additional Info: Not sure how far back this goes or if it's particular to my system. Ad far back as the release of Linux Mint 21.0 in terms of dates. At least LibreOffice 7.5.0.3 I think, maybe earlier. CPU FX6300 CPU threads: 6; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded System: Kernel: 5.15.0-86-generic x86_64 bits: 64 Compiler: gcc v: 12.3.0 Desktop: Cinnamon 5.8.4 tk: GTK3 3.24.33 (GTK4 4.6.9 available) wm: muffin dm: LightDM 1.30.0 Distro: Linux Mint 21.1 Vera base: Ubuntu 22.04 jammy Machine: Type: Desktop Mobo: MSI model: 760GM-P23(FX) (MS-7641) v: 3.0 serial: BIOS: American Megatrends v: 17.17 date: 04/22/2015 Mem: 16Gb DDR3 Video: Nvdia GTS450SC 1Gb - driver version 390.157-0ubuntu0.22.04.2 OS: (up to date) Distributor ID: Linuxmint Description:Linux Mint 21.2 Release:21.2 Codename: victoria -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134536] Writer Table Formulas Don't Support RnCn cell references
https://bugs.documentfoundation.org/show_bug.cgi?id=134536 Kira Tubo changed: What|Removed |Added Version|7.0.0.0.alpha0+ |Inherited From OOo CC||kira.t...@gmail.com --- Comment #9 from Kira Tubo --- Reproduced in master build and 3.3: Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 1ec2e39cf4d5fe0a592bc783fd8bcdc4345c8cbd CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155741] Allow insertion of items into master without a selected item
https://bugs.documentfoundation.org/show_bug.cgi?id=155741 --- Comment #18 from Jim Raykowski --- Patches that make the Navigator track master document 'Text' and table of content content types are here: https://gerrit.libreoffice.org/c/core/+/157741/1 https://gerrit.libreoffice.org/c/core/+/157695/2 These make the Navigator less likely to not have an entry selected. For example, opening a new master document will always have the 'Text' entry selected in the Navigator. I poked around with making it possible to insert without having a selected entry in the Navigator. To make it easier to do this I proposed in bug 157610 to not automatically insert 'Text' when inserting a file or index. With the patches above the proposal is not as important. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156714] .uno:IndexMarktoIndex does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=156714 --- Comment #12 from Jim Raykowski --- (In reply to sdc.blanco from comment #11) > (In reply to Jim Raykowski from comment #9) > > Maybe? > Have I interpreted the video correctly, that the patch jumps from an entry > in the index list to heading in the index list? Yes that is what the patch does, but as Michael has explained, this is not the correct interpretation the command. > I would think/expect that the patch should jump from an "index entry" (in > the document) to the "index list" (ideally, to the corresponding item in the > index list). (It did not seem that way in the video). Before checking back here and seeing Michael's comment, I read the help on index entries and realized my misunderstanding of the command. I agree with you on the expected behavior of the command. I'll give trying to make this work another stab now that I think I understand what it is supposed to do. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: writerfilter/source
writerfilter/source/dmapper/DomainMapper_Impl.cxx | 31 +- writerfilter/source/dmapper/DomainMapper_Impl.hxx |6 ++-- writerfilter/source/dmapper/PropertyMap.cxx | 12 writerfilter/source/dmapper/PropertyMap.hxx | 14 - 4 files changed, 29 insertions(+), 34 deletions(-) New commits: commit e3d09d2e525ef6d5b93c6646e3cadc3f01297ea0 Author: Tomaž Vajngerl AuthorDate: Mon Oct 2 08:15:06 2023 +0200 Commit: Tomaž Vajngerl CommitDate: Thu Oct 12 03:33:53 2023 +0200 change PageType (first, left, right) enum to enum class Change-Id: I45bb7947266de1e18028c7ed460149c609e430b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157834 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx b/writerfilter/source/dmapper/DomainMapper_Impl.cxx index cddf8c6f6127..f9f6dbd52d65 100644 --- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx +++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx @@ -3456,7 +3456,7 @@ void DomainMapper_Impl::ConvertHeaderFooterToTextFrame(bool bDynamicHeightTop, b } } -void DomainMapper_Impl::PushPageHeaderFooter(PagePartType ePagePartType, SectionPropertyMap::PageType eType) +void DomainMapper_Impl::PushPageHeaderFooter(PagePartType ePagePartType, PageType eType) { m_bSaveParaHadField = m_bParaHadField; m_aHeaderFooterStack.push(HeaderFooterContext(m_bTextInserted, m_nTableDepth)); @@ -3489,22 +3489,17 @@ void DomainMapper_Impl::PushPageHeaderFooter(PagePartType ePagePartType, Section return; // TODO sw cannot Undo insert header/footer without crashing } -uno::Reference< beans::XPropertySet > xPageStyle = -pSectionContext->GetPageStyle( -*this, -eType == SectionPropertyMap::PAGE_FIRST ); +uno::Reference xPageStyle = pSectionContext->GetPageStyle(*this, eType == PageType::FIRST); if (!xPageStyle.is()) return; try { -bool bLeft = eType == SectionPropertyMap::PAGE_LEFT; -bool bFirst = eType == SectionPropertyMap::PAGE_FIRST; +bool bLeft = eType == PageType::LEFT; +bool bFirst = eType == PageType::FIRST; if (!bLeft || GetSettingsTable()->GetEvenAndOddHeaders()) { //switch on header/footer use -xPageStyle->setPropertyValue( -getPropertyName(ePropIsOn), -uno::Any(true)); +xPageStyle->setPropertyValue(getPropertyName(ePropIsOn), uno::Any(true)); // If the 'Different Even & Odd Pages' flag is turned on - do not ignore it // Even if the 'Even' header/footer is blank - the flag should be imported (so it would look in LO like in Word) @@ -3555,12 +3550,12 @@ void DomainMapper_Impl::PushPageHeaderFooter(PagePartType ePagePartType, Section } } -void DomainMapper_Impl::PushPageHeader(SectionPropertyMap::PageType eType) +void DomainMapper_Impl::PushPageHeader(PageType eType) { PushPageHeaderFooter(PagePartType::Header, eType); } -void DomainMapper_Impl::PushPageFooter(SectionPropertyMap::PageType eType) +void DomainMapper_Impl::PushPageFooter(PageType eType) { PushPageHeaderFooter(PagePartType::Footer, eType); } @@ -9291,22 +9286,22 @@ void DomainMapper_Impl::substream(Id rName, switch( rName ) { case NS_ooxml::LN_headerl: -PushPageHeader(SectionPropertyMap::PAGE_LEFT); +PushPageHeader(PageType::LEFT); break; case NS_ooxml::LN_headerr: -PushPageHeader(SectionPropertyMap::PAGE_RIGHT); +PushPageHeader(PageType::RIGHT); break; case NS_ooxml::LN_headerf: -PushPageHeader(SectionPropertyMap::PAGE_FIRST); +PushPageHeader(PageType::FIRST); break; case NS_ooxml::LN_footerl: -PushPageFooter(SectionPropertyMap::PAGE_LEFT); +PushPageFooter(PageType::LEFT); break; case NS_ooxml::LN_footerr: -PushPageFooter(SectionPropertyMap::PAGE_RIGHT); +PushPageFooter(PageType::RIGHT); break; case NS_ooxml::LN_footerf: -PushPageFooter(SectionPropertyMap::PAGE_FIRST); +PushPageFooter(PageType::FIRST); break; case NS_ooxml::LN_footnote: case NS_ooxml::LN_endnote: diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.hxx b/writerfilter/source/dmapper/DomainMapper_Impl.hxx index 82d7ca06824e..83a804cf618d 100644 --- a/writerfilter/source/dmapper/DomainMapper_Impl.hxx +++ b/writerfilter/source/dmapper/DomainMapper_Impl.hxx @@ -853,8 +853,8 @@ public: /// Get the first pending shape, if there are any. css::uno::Reference PopPendingShape(); -void PushPageHeader(SectionPropertyMap::PageType eType); -void PushPageFooter(SectionPropertyMap::PageType eType); +void PushPageHeader(PageType eType); +void PushPageFooter(PageType
[Libreoffice-bugs] [Bug 87604] Add option to retain direct formatting (and character style) in indices like Table of Contents
https://bugs.documentfoundation.org/show_bug.cgi?id=87604 --- Comment #17 from David Werier --- Perhaps allow for a check box to select or unselect whether the formatting from the character style or direct formatting gets brought into the TOC or other items. This way one can choose whether they want this to happen or not. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113360] [META] Solver-related bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113360 Bug 113360 depends on bug 156815, which changed state. Bug 156815 Summary: Renaming a sheet should update ranges in solver models https://bugs.documentfoundation.org/show_bug.cgi?id=156815 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-4+backports' - external/curl
external/curl/CVE-2023-38545_7.87.0.patch | 134 ++ external/curl/UnpackedTarball_curl.mk |1 2 files changed, 135 insertions(+) New commits: commit 50e42e822f69c400ee90daa3e22d326438ecfd7a Author: Thorsten Behrens AuthorDate: Wed Oct 11 10:41:42 2023 +0200 Commit: Thorsten Behrens CommitDate: Thu Oct 12 02:05:14 2023 +0200 curl: fix socks return error if hostname too long for remote resolve This fixes https://curl.se/docs/CVE-2023-38545.html Change-Id: Id70486c8ec4e7754e7a07d81b22702e435ce6727 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157830 Tested-by: Thorsten Behrens Reviewed-by: Thorsten Behrens diff --git a/external/curl/CVE-2023-38545_7.87.0.patch b/external/curl/CVE-2023-38545_7.87.0.patch new file mode 100644 index ..c15c273ea41e --- /dev/null +++ b/external/curl/CVE-2023-38545_7.87.0.patch @@ -0,0 +1,134 @@ +From 92fd36dd54de9ac845549944692eb33c5aee7343 Mon Sep 17 00:00:00 2001 +From: Jay Satiro +Date: Mon, 9 Oct 2023 17:15:44 -0400 +Subject: [PATCH] socks: return error if hostname too long for remote resolve + +Prior to this change the state machine attempted to change the remote +resolve to a local resolve if the hostname was longer than 255 +characters. Unfortunately that did not work as intended and caused a +security issue. + +This patch applies to curl versions 7.87.0 - 8.1.2. Other versions +that are affected take a different patch. Refer to the CVE advisory +for more information. + +Bug: https://curl.se/docs/CVE-2023-38545.html +--- + lib/socks.c | 8 +++ + tests/data/Makefile.inc | 2 +- + tests/data/test728 | 64 + + 3 files changed, 69 insertions(+), 5 deletions(-) + create mode 100644 tests/data/test728 + +diff --git a/lib/socks.c b/lib/socks.c +index d491e08..e7da5b4 100644 +--- a/lib/socks.c b/lib/socks.c +@@ -539,9 +539,9 @@ static CURLproxycode do_SOCKS5(struct Curl_cfilter *cf, + + /* RFC1928 chapter 5 specifies max 255 chars for domain name in packet */ + if(!socks5_resolve_local && hostname_len > 255) { +- infof(data, "SOCKS5: server resolving disabled for hostnames of " +-"length > 255 [actual len=%zu]", hostname_len); +- socks5_resolve_local = TRUE; ++ failf(data, "SOCKS5: the destination hostname is too long to be " ++"resolved remotely by the proxy."); ++ return CURLPX_LONG_HOSTNAME; + } + + if(auth & ~(CURLAUTH_BASIC | CURLAUTH_GSSAPI)) +@@ -882,7 +882,7 @@ static CURLproxycode do_SOCKS5(struct Curl_cfilter *cf, + } + else { + socksreq[len++] = 3; +-socksreq[len++] = (char) hostname_len; /* one byte address length */ ++socksreq[len++] = (unsigned char) hostname_len; /* one byte length */ + memcpy([len], sx->hostname, hostname_len); /* w/o NULL */ + len += hostname_len; + } +diff --git a/tests/data/Makefile.inc b/tests/data/Makefile.inc +index 3e0221a..64b11de 100644 +--- a/tests/data/Makefile.inc b/tests/data/Makefile.inc +@@ -99,7 +99,7 @@ test679 test680 test681 test682 test683 test684 test685 \ + \ + test700 test701 test702 test703 test704 test705 test706 test707 test708 \ + test709 test710 test711 test712 test713 test714 test715 test716 test717 \ +-test718 test719 test720 test721 \ ++test718 test719 test720 test721 test728 \ + \ + test800 test801 test802 test803 test804 test805 test806 test807 test808 \ + test809 test810 test811 test812 test813 test814 test815 test816 test817 \ +diff --git a/tests/data/test728 b/tests/data/test728 +new file mode 100644 +index 000..05bcf28 +--- /dev/null b/tests/data/test728 +@@ -0,0 +1,64 @@ ++ ++ ++ ++HTTP ++HTTP GET ++SOCKS5 ++SOCKS5h ++followlocation ++ ++ ++ ++# ++# Server-side ++ ++# The hostname in this redirect is 256 characters and too long (> 255) for ++# SOCKS5 remote resolve. curl must return error CURLE_PROXY in this case. ++ ++HTTP/1.1 301 Moved Permanently ++Location: http:/// ++Content-Length: 0 ++Connection: close ++ ++ ++ ++ ++# ++# Client-side ++ ++ ++proxy ++ ++ ++http ++socks5 ++ ++ ++SOCKS5h with HTTP redirect to hostname too long ++ ++ ++--no-progress-meter --location --proxy socks5h://%HOSTIP:%SOCKSPORT http://%HOSTIP:%HTTPPORT/%TESTNUMBER ++ ++ ++ ++# ++# Verify data after the test has been "shot" ++ ++ ++GET /%TESTNUMBER HTTP/1.1 ++Host: %HOSTIP:%HTTPPORT ++User-Agent: curl/%VERSION ++Accept: */* ++ ++ ++ ++97 ++ ++# the error message is verified because error code CURLE_PROXY (97) may be ++# returned for any number of reasons and we need to make sure it is ++# specifically for the reason below so that we know the check is working. ++
[Libreoffice-bugs] [Bug 157404] Tabbed UI: Unselected Page Size options not readable in Win11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=157404 Justin L changed: What|Removed |Added Version|7.5.0.0 alpha1+ |unspecified -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157404] Tabbed UI: Unselected Page Size options not readable in Win11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=157404 Justin L changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Hardware|x86-64 (AMD64) |All OS|Windows (All) |All --- Comment #7 from Justin L --- The Page Size option is not a GTK widget, but a home-grown thing. So it acts differently to pretty much everything else. (A few other things like paragraph styles, fonts are also home-grown.) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 127488] Notebook Bar keyboard accelerators don't work in multiple MUFFIN UI modes
https://bugs.documentfoundation.org/show_bug.cgi?id=127488 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||7344 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107344] Use Alt key combination to access tabbed Notebookbar tabs
https://bugs.documentfoundation.org/show_bug.cgi?id=107344 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||7488 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157681] Add an opportunity to hide any file (but not to delete it) in master document like a slide in a presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=157681 --- Comment #2 from Jim Raykowski --- (In reply to Roman Kuznetsov from comment #0) > Description: > Add an opportunity to hide any file (but not to delete it) in master > document like a slide in a presentation Hi Roman, The 'Edit link' popup menu item opens the 'Edit Section' dialog which gives the opportunity to hide sections. I suppose a 'Hide' check menu item could be added to the Navigator popup menu to bypass the need to open the dialog to hide a section. Let's see what the UX team thinks. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 157681] Add an opportunity to hide any file (but not to delete it) in master document like a slide in a presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=157681 --- Comment #2 from Jim Raykowski --- (In reply to Roman Kuznetsov from comment #0) > Description: > Add an opportunity to hide any file (but not to delete it) in master > document like a slide in a presentation Hi Roman, The 'Edit link' popup menu item opens the 'Edit Section' dialog which gives the opportunity to hide sections. I suppose a 'Hide' check menu item could be added to the Navigator popup menu to bypass the need to open the dialog to hide a section. Let's see what the UX team thinks. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 129661] [META] Right-To-Left (RTL) user interface issues
https://bugs.documentfoundation.org/show_bug.cgi?id=129661 Bug 129661 depends on bug 138440, which changed state. Bug 138440 Summary: Calc missing the Right to Left and Left to Right buttons in Tabbed mode https://bugs.documentfoundation.org/show_bug.cgi?id=138440 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102062] [META] Notebookbar: bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102062 Bug 102062 depends on bug 138440, which changed state. Bug 138440 Summary: Calc missing the Right to Left and Left to Right buttons in Tabbed mode https://bugs.documentfoundation.org/show_bug.cgi?id=138440 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138440] Calc missing the Right to Left and Left to Right buttons in Tabbed mode
https://bugs.documentfoundation.org/show_bug.cgi?id=138440 Justin L changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138440] Calc missing the Right to Left and Left to Right buttons in Tabbed mode
https://bugs.documentfoundation.org/show_bug.cgi?id=138440 --- Comment #4 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c108089ef4b58da819fb0acd372cd66e9684f3b8 tdf#138440 sc notebookbar: add right-to-left to home tab It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138440] Calc missing the Right to Left and Left to Right buttons in Tabbed mode
https://bugs.documentfoundation.org/show_bug.cgi?id=138440 Commit Notification changed: What|Removed |Added Whiteboard||target:24.2.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/uiconfig
sc/uiconfig/scalc/ui/notebookbar.ui | 46 ++-- sc/uiconfig/scalc/ui/notebookbar_compact.ui | 20 2 files changed, 64 insertions(+), 2 deletions(-) New commits: commit c108089ef4b58da819fb0acd372cd66e9684f3b8 Author: Justin Luth AuthorDate: Wed Oct 11 18:00:13 2023 -0400 Commit: Justin Luth CommitDate: Thu Oct 12 01:29:51 2023 +0200 tdf#138440 sc notebookbar: add right-to-left to home tab The UI is pretty packed here, so for non-RTL languages having it on the toolbar would be distracting. So I decided to make it hidden - meaning a RTL user would need to customize the notebookbar to reveal it. However, adding it unconditionally to the dropdown menu is fine, so at least it is readily available there. It already existed in the paragraph menu of groupedcompact. Change-Id: Id4dc2de9c0922428fc44501c4eb2d7e3e51dea82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157851 Tested-by: Jenkins Reviewed-by: Justin Luth diff --git a/sc/uiconfig/scalc/ui/notebookbar.ui b/sc/uiconfig/scalc/ui/notebookbar.ui index 8ba17d99ee6c..54419a9c4385 100644 --- a/sc/uiconfig/scalc/ui/notebookbar.ui +++ b/sc/uiconfig/scalc/ui/notebookbar.ui @@ -907,6 +907,26 @@ False + + +True +False +.uno:ParaLeftToRight + + + + +True +False +.uno:ParaRightToLeft + + + + +True +False + + True @@ -957,7 +977,7 @@ - + True False @@ -991,7 +1011,7 @@ - + True False @@ -3798,6 +3818,17 @@ True + + +False +.uno:ParaLeftToRight +True + + +False +True + + False @@ -3874,6 +3905,17 @@ True + + +False +.uno:ParaRightToLeft +True + + +False +True + + False diff --git a/sc/uiconfig/scalc/ui/notebookbar_compact.ui b/sc/uiconfig/scalc/ui/notebookbar_compact.ui index f05a344b02f9..11c0f3ed963a 100644 --- a/sc/uiconfig/scalc/ui/notebookbar_compact.ui +++ b/sc/uiconfig/scalc/ui/notebookbar_compact.ui @@ -1135,6 +1135,26 @@ False + + +True +False +.uno:ParaLeftToRight + + + + +True +False +.uno:ParaRightToLeft + + + + +True +False + + True
[Libreoffice-commits] core.git: editeng/source
editeng/source/editeng/editeng.cxx | 22 +-- editeng/source/editeng/impedit.hxx | 166 +++ editeng/source/editeng/impedit2.cxx | 252 ++-- editeng/source/editeng/impedit3.cxx | 156 +++--- editeng/source/editeng/impedit4.cxx | 158 +++--- editeng/source/editeng/impedit5.cxx | 114 6 files changed, 432 insertions(+), 436 deletions(-) New commits: commit b63f768941ca870f0930ff400e3bc6ff829bea4a Author: Tomaž Vajngerl AuthorDate: Sat Sep 30 22:56:27 2023 +0200 Commit: Tomaž Vajngerl CommitDate: Thu Oct 12 01:28:05 2023 +0200 prefix some members of ImpEditEngine Change-Id: I9975bed2af853374a10b87c468840ff22b230157 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157833 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl diff --git a/editeng/source/editeng/editeng.cxx b/editeng/source/editeng/editeng.cxx index 0dd24c941069..6cb28954aedc 100644 --- a/editeng/source/editeng/editeng.cxx +++ b/editeng/source/editeng/editeng.cxx @@ -588,7 +588,7 @@ sal_Int32 EditEngine::GetTextLen() const sal_Int32 EditEngine::GetParagraphCount() const { -return pImpEditEngine->aEditDoc.Count(); +return pImpEditEngine->maEditDoc.Count(); } sal_Int32 EditEngine::GetLineCount( sal_Int32 nParagraph ) const @@ -994,7 +994,7 @@ const EditSelectionEngine& EditEngine::GetSelectionEngine() const void EditEngine::SetInSelectionMode(bool b) { -pImpEditEngine->bInSelection = b; +pImpEditEngine->mbInSelection = b; } bool EditEngine::PostKeyEvent( const KeyEvent& rKeyEvent, EditView* pEditView, vcl::Window const * pFrameWin ) @@ -1863,28 +1863,28 @@ void EditEngine::SetFlatMode( bool bFlat) bool EditEngine::IsFlatMode() const { -return !( pImpEditEngine->aStatus.UseCharAttribs() ); +return !( pImpEditEngine->GetStatus().UseCharAttribs() ); } void EditEngine::SetSingleLine(bool bValue) { -if (bValue == pImpEditEngine->aStatus.IsSingleLine()) +if (bValue == pImpEditEngine->GetStatus().IsSingleLine()) return; if (bValue) -pImpEditEngine->aStatus.TurnOnFlags(EEControlBits::SINGLELINE); +pImpEditEngine->GetStatus().TurnOnFlags(EEControlBits::SINGLELINE); else -pImpEditEngine->aStatus.TurnOffFlags(EEControlBits::SINGLELINE); +pImpEditEngine->GetStatus().TurnOffFlags(EEControlBits::SINGLELINE); } void EditEngine::SetControlWord( EEControlBits nWord ) { -if ( nWord == pImpEditEngine->aStatus.GetControlWord() ) +if ( nWord == pImpEditEngine->GetStatus().GetControlWord() ) return; -EEControlBits nPrev = pImpEditEngine->aStatus.GetControlWord(); -pImpEditEngine->aStatus.GetControlWord() = nWord; +EEControlBits nPrev = pImpEditEngine->GetStatus().GetControlWord(); +pImpEditEngine->GetStatus().GetControlWord() = nWord; EEControlBits nChanges = nPrev ^ nWord; if ( pImpEditEngine->IsFormatted() ) @@ -1952,7 +1952,7 @@ void EditEngine::SetControlWord( EEControlBits nWord ) EEControlBits EditEngine::GetControlWord() const { -return pImpEditEngine->aStatus.GetControlWord(); +return pImpEditEngine->GetStatus().GetControlWord(); } tools::Long EditEngine::GetFirstLineStartX( sal_Int32 nParagraph ) @@ -2437,7 +2437,7 @@ EPosition EditEngine::FindDocPosition( const Point& rDocPos ) const EditPaM aPaM = const_cast(this)->pImpEditEngine->GetPaM( rDocPos, false ); if ( aPaM.GetNode() ) { -aPos.nPara = pImpEditEngine->aEditDoc.GetPos( aPaM.GetNode() ); +aPos.nPara = pImpEditEngine->maEditDoc.GetPos( aPaM.GetNode() ); aPos.nIndex = aPaM.GetIndex(); } return aPos; diff --git a/editeng/source/editeng/impedit.hxx b/editeng/source/editeng/impedit.hxx index 2fba7bd778f4..df7a11c97dcb 100644 --- a/editeng/source/editeng/impedit.hxx +++ b/editeng/source/editeng/impedit.hxx @@ -494,17 +494,13 @@ class ImpEditEngine : public SfxListener, public svl::StyleSheetUser private: std::shared_ptr pSharedVCL; - -// Data ... - - // Document Specific data ... -ParaPortionList aParaPortionList; // Formatting -SizeaPaperSize; // Layout -SizeaMinAutoPaperSize; // Layout ? -SizeaMaxAutoPaperSize; // Layout ? +ParaPortionList maParaPortionList; // Formatting +Size maPaperSize; // Layout +Size maMinAutoPaperSize; // Layout ? +Size maMaxAutoPaperSize; // Layout ? tools::Long mnMinColumnWrapHeight = 0; // Corresponds to graphic object height -EditDoc aEditDoc; // Document content +EditDoc maEditDoc; // Document content // Engine Specific data ... EditEngine* pEditEngine; @@ -540,11 +536,11 @@ private: double mfSpacingScaleY; bool mbRoundToNearestPt; -CharCompressTypenAsianCompressionMode; +CharCompressType
[Libreoffice-bugs] [Bug 157711] Enhancement to Unify Office Products from a File View
https://bugs.documentfoundation.org/show_bug.cgi?id=157711 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #2 from m.a.riosv --- Looks like tdf#37134 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157680] Impress export corrupted pdf on MacOS
https://bugs.documentfoundation.org/show_bug.cgi?id=157680 Patrick Luby changed: What|Removed |Added Status|NEW |ASSIGNED See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||6842 Assignee|libreoffice-b...@lists.free |plub...@neooffice.org |desktop.org | --- Comment #12 from Patrick Luby --- So after some debugging, I found that the white areas when exporting to PDF are a result of my fix for https://bugs.documentfoundation.org/show_bug.cgi?id=156842. If I remove that fix, there are no longer any white areas in the exported PDF. But, the 3 images in the box at the bottom of the slide are 1/8th their normal size. So, my first guess is that the scaling fix is getting applied to some other, unintended object. I will post again when I have more news. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157710] Invoking a document among the recently accessed ones no longer does anything if that document is already open
https://bugs.documentfoundation.org/show_bug.cgi?id=157710 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m.a.riosv --- Works for me Version: 7.5.7.1 (X86_64) / LibreOffice Community Build ID: 47eb0cf7efbacdee9b19ae25d6752381ede23126 CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Version: 7.6.1.2 (X86_64) / LibreOffice Community Build ID: f5defcebd022c5bc36bbb79be232cb6926d8f674 CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Vulkan; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 9eb419b0b0f019f5fbc48ff1a11977e8b041edee CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Jumbo -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157706] Chart data table text is not visible anymore
https://bugs.documentfoundation.org/show_bug.cgi?id=157706 m.a.riosv changed: What|Removed |Added Ever confirmed|0 |1 CC||miguelangelrv@libreoffice.o ||rg Status|UNCONFIRMED |NEW --- Comment #2 from m.a.riosv --- Reproducible Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 9eb419b0b0f019f5fbc48ff1a11977e8b041edee CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Jumbo -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157704] language settings for document are not applied
https://bugs.documentfoundation.org/show_bug.cgi?id=157704 m.a.riosv changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||miguelangelrv@libreoffice.o ||rg Ever confirmed|0 |1 --- Comment #1 from m.a.riosv --- What happen if you select the text in one slide, and change the language for it to Spanish. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134312] FILESAVE DOCX Embedded PDF file is not saved as OLE Object
https://bugs.documentfoundation.org/show_bug.cgi?id=134312 m.a.riosv changed: What|Removed |Added CC||ma...@amuchastegui.com --- Comment #10 from m.a.riosv --- *** Bug 157699 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157699] The "Insert OLE object > Display as Icon" feature is not working in DOCX documents
https://bugs.documentfoundation.org/show_bug.cgi?id=157699 m.a.riosv changed: What|Removed |Added Resolution|--- |DUPLICATE CC||miguelangelrv@libreoffice.o ||rg Status|UNCONFIRMED |RESOLVED --- Comment #1 from m.a.riosv --- *** This bug has been marked as a duplicate of bug 134312 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 99391] EDITING Rotating text in a cell rotates also cell background
https://bugs.documentfoundation.org/show_bug.cgi?id=99391 m.a.riosv changed: What|Removed |Added CC||lor...@famlen.de --- Comment #11 from m.a.riosv --- *** Bug 157697 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157697] Cell background color fill error in first column with slanted text
https://bugs.documentfoundation.org/show_bug.cgi?id=157697 m.a.riosv changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE CC||miguelangelrv@libreoffice.o ||rg --- Comment #3 from m.a.riosv --- *** This bug has been marked as a duplicate of bug 99391 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157167] saving file.docx as file.odt fails and creates a file.odt.docx if user types quickly
https://bugs.documentfoundation.org/show_bug.cgi?id=157167 --- Comment #4 from Atramenta --- Still happening on: Version: 7.5.7.1 (X86_64) / LibreOffice Community Build ID: 47eb0cf7efbacdee9b19ae25d6752381ede23126 CPU threads: 8; OS: Linux 6.2; UI render: default; VCL: kf5 (cairo+xcb) Locale: fr-FR (en_US.UTF-8); UI: fr-FR Calc: threaded - I opened a docx document with LibreOffice Writer - I clicked File > Save as (Fichier > Enregistrer sous, with the french UI) - In the file dialog I removed the .docx extension from the filename, then quickly typed .odt and pressed enter. - The file was saved as file.odt.docx - The file "file.odt.docx" is actually an OpenDocument file If I do the exact them thing, slowly, the file is saved as "file.odt" -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - vcl/skia
vcl/skia/osx/gdiimpl.cxx |5 + 1 file changed, 5 insertions(+) New commits: commit e65162fcd7091ee315637301fcc1a3480325f918 Author: Patrick Luby AuthorDate: Wed Oct 11 14:36:12 2023 -0400 Commit: Patrick Luby CommitDate: Thu Oct 12 00:19:04 2023 +0200 tdf#157613 make sure surface is not a null pointer Change-Id: I8e3c1be3f05f7ccc1f3ba00093cd71a564e5ae9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157848 Reviewed-by: Patrick Luby Tested-by: Patrick Luby (cherry picked from commit bacdae0d6b0cec4de39812496f6ffafe04629411) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157871 Tested-by: Jenkins diff --git a/vcl/skia/osx/gdiimpl.cxx b/vcl/skia/osx/gdiimpl.cxx index fcb2d2181fc4..24847a410e7a 100644 --- a/vcl/skia/osx/gdiimpl.cxx +++ b/vcl/skia/osx/gdiimpl.cxx @@ -214,6 +214,11 @@ bool AquaSkiaSalGraphicsImpl::drawNativeControl(ControlType nType, ControlPart n const tools::Rectangle& rControlRegion, ControlState nState, const ImplControlValue& aValue) { +// tdf#157613 make sure surface is not a nullptr +checkSurface(); +if (!mSurface) +return false; + // rControlRegion is not the whole area that the control should be painted to (e.g. highlight // around focused lineedit is outside of it). Since we draw to a temporary bitmap, we need tofind out // the real size. Using getNativeControlRegion() might seem like the function to call, but we need
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - vcl/skia
vcl/skia/osx/gdiimpl.cxx |5 + 1 file changed, 5 insertions(+) New commits: commit 0224f024424c76a05e0c20b6ee1b4490fde11607 Author: Patrick Luby AuthorDate: Wed Oct 11 14:36:12 2023 -0400 Commit: Patrick Luby CommitDate: Thu Oct 12 00:17:36 2023 +0200 tdf#157613 make sure surface is not a null pointer Change-Id: I8e3c1be3f05f7ccc1f3ba00093cd71a564e5ae9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157848 Reviewed-by: Patrick Luby Tested-by: Patrick Luby (cherry picked from commit bacdae0d6b0cec4de39812496f6ffafe04629411) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157870 Tested-by: Jenkins diff --git a/vcl/skia/osx/gdiimpl.cxx b/vcl/skia/osx/gdiimpl.cxx index fd0bdca04333..937a6e40f520 100644 --- a/vcl/skia/osx/gdiimpl.cxx +++ b/vcl/skia/osx/gdiimpl.cxx @@ -214,6 +214,11 @@ bool AquaSkiaSalGraphicsImpl::drawNativeControl(ControlType nType, ControlPart n const tools::Rectangle& rControlRegion, ControlState nState, const ImplControlValue& aValue) { +// tdf#157613 make sure surface is not a nullptr +checkSurface(); +if (!mSurface) +return false; + // rControlRegion is not the whole area that the control should be painted to (e.g. highlight // around focused lineedit is outside of it). Since we draw to a temporary bitmap, we need tofind out // the real size. Using getNativeControlRegion() might seem like the function to call, but we need
[Libreoffice-bugs] [Bug 148121] Let me save and load custom or default User Interface UI layout variants.
https://bugs.documentfoundation.org/show_bug.cgi?id=148121 Justin L changed: What|Removed |Added Depends on||140140 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=140140 [Bug 140140] WRITER Notebookbar configuration window allows for drag and drop, but this has no effect and is reverted once OK is pressed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140140] WRITER Notebookbar configuration window allows for drag and drop, but this has no effect and is reverted once OK is pressed
https://bugs.documentfoundation.org/show_bug.cgi?id=140140 Justin L changed: What|Removed |Added Blocks||148121 --- Comment #4 from Justin L --- Probably just a fancy-worded duplicate of bug 148121. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148121 [Bug 148121] Let me save and load custom or default User Interface UI layout variants. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157693] "Slide" reappears in the Properties side panel after selecting a table
https://bugs.documentfoundation.org/show_bug.cgi?id=157693 --- Comment #6 from robomurphy98 --- Yes, in Safe Mode the same error occurs. Steps I do: 1. Open LibreOffice in safe mode. 2. In the pop up dialog I click on "Restore from backup". 3. Click in "Continue in Safe Mode". 4. Repeat the previous steps. Version: 7.6.2.1 (X86_64) / LibreOffice Community Build ID: 56f7684011345957bbf33a7ee678afaf4d2ba333 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: default; VCL: win Locale: es-ES (es_ES); UI: es-ES Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155500] can not change order of commands in notebookbar (omnibarra)
https://bugs.documentfoundation.org/show_bug.cgi?id=155500 --- Comment #3 from Justin L --- Isn't this a duplicate of bug 148121? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157680] Impress export corrupted pdf on MacOS
https://bugs.documentfoundation.org/show_bug.cgi?id=157680 --- Comment #11 from Patrick Luby --- (In reply to Patrick Luby from comment #10) > I can also reproduce this on macOS Sonoma on versions of LibreOffice > starting from 7.5.7. One more bug: when printing, a different set of areas are an empty color and both the export as PDF and printing bugs occur using Skia/Metal, Skia/Raster, and Skia disabled. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157711] Enhancement to Unify Office Products from a File View
https://bugs.documentfoundation.org/show_bug.cgi?id=157711 --- Comment #1 from Franko --- This would be a fundamental change either in file formats, or the skin a user works inside. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157711] New: Enhancement to Unify Office Products from a File View
https://bugs.documentfoundation.org/show_bug.cgi?id=157711 Bug ID: 157711 Summary: Enhancement to Unify Office Products from a File View Product: LibreOffice Version: 3.3.0 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: franko.wil...@icloud.com Description: “Enjoin” the major office products (Calc, Writer, Impress, ect…) within the “workbook” file format, with each tab/sheet in the file individually linked to the specific software type - like the bottom left of a Calc screen. Quite frequently, in the office world, there is need to have a Word Document, a Spreadsheet/Workbook file, a presentation, and possibly a Visio type file, all required within a single project. There are all the links that users try to keep straight and often cannot, and updating from one file to the next - a lot of waisted time for the end user - maybe things are better now, but I think probably not. If users could open a single "Office File” (that could just be some kind of skin) that had as an example, one tab as a spreadsheet, one tab as a Doc, one a Presentation, the end user would be able to stay in the same file (skin) that has those tabs at the bottom of the working screen - likely linking to itself, all over the place. So the user only has one consolidated file to work with on a specific project, and could use within that file any part of the office system - It might just be a skin as I mentioned and behind the scenes each of the actual calc/doc/presentation… files exist, but it would be way cool if all the separate file types were written into a single consolidated “Office.sdpv" file. That’s the idea. I was an end user, and Excel power user for thirty years, and thought MS Office would do something with that idea a long time ago… By the end of my office work, I had a number of projects that included XL/Word/PowerPoint/Visio files - most of them linked. One interface - incredible. Steps to Reproduce: 1.the idea is when you create a new office file, you can select what types of working screens and protocols will be on each "page/tab" within the file 2.If that could be done, then the links between functions/spreadsheet/writer/presentation would all be within one workbook file 3. Actual Results: Files have to be linked and can get lost Expected Results: A complete renewal of the office experience for multi product users Reproducible: Always User Profile Reset: No Additional Info: This really would be a cool new way to use office products. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157680] Impress export corrupted pdf on MacOS
https://bugs.documentfoundation.org/show_bug.cgi?id=157680 --- Comment #10 from Patrick Luby --- I can also reproduce this on macOS Sonoma on versions of LibreOffice starting from 7.5.7. At first I thought it might be a bug in the Preview application, but the exported PDF looks the same in Adobe Acrobat Reader. I will turn off compression in the exported PDF in my local master build and see if I can find anything in the PDF data that might be causing this bug. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/skia
vcl/skia/osx/gdiimpl.cxx |5 + 1 file changed, 5 insertions(+) New commits: commit 82ed49b81eb0a45c25f3808a7d12efd5161a Author: Patrick Luby AuthorDate: Wed Oct 11 14:36:12 2023 -0400 Commit: Patrick Luby CommitDate: Wed Oct 11 22:46:58 2023 +0200 tdf#157613 make sure surface is not a null pointer Change-Id: I8e3c1be3f05f7ccc1f3ba00093cd71a564e5ae9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157848 Reviewed-by: Patrick Luby Tested-by: Patrick Luby diff --git a/vcl/skia/osx/gdiimpl.cxx b/vcl/skia/osx/gdiimpl.cxx index 752208c0bc41..c4bd75184242 100644 --- a/vcl/skia/osx/gdiimpl.cxx +++ b/vcl/skia/osx/gdiimpl.cxx @@ -224,6 +224,11 @@ bool AquaSkiaSalGraphicsImpl::drawNativeControl(ControlType nType, ControlPart n const tools::Rectangle& rControlRegion, ControlState nState, const ImplControlValue& aValue) { +// tdf#157613 make sure surface is not a nullptr +checkSurface(); +if (!mSurface) +return false; + // rControlRegion is not the whole area that the control should be painted to (e.g. highlight // around focused lineedit is outside of it). Since we draw to a temporary bitmap, we need tofind out // the real size. Using getNativeControlRegion() might seem like the function to call, but we need
[Libreoffice-bugs] [Bug 157465] SQL query produces no output in database with external HSQLDB driver (Windows-only)
https://bugs.documentfoundation.org/show_bug.cgi?id=157465 Julien Nabet changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr |desktop.org | Status|NEW |ASSIGNED CC||lio...@mamane.lu --- Comment #9 from Julien Nabet --- It seems hsql calls JDBC part and when calling getBytes method it throws an exception, I don't know why. So here's an ugly hack here: https://gerrit.libreoffice.org/c/core/+/157849 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157408] LibreOffice - Writer crashed when two databases (ods-files) are involved in one serial-letter.
https://bugs.documentfoundation.org/show_bug.cgi?id=157408 --- Comment #2 from Stéphane Guillou (stragu) --- (and if you see the Crash Report dialog, please do sent a crash report and share the link to it here. Thank you!) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157408] LibreOffice - Writer crashed when two databases (ods-files) are involved in one serial-letter.
https://bugs.documentfoundation.org/show_bug.cgi?id=157408 Stéphane Guillou (stragu) changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||stephane.guillou@libreoffic ||e.org Whiteboard| QA:needsComment| Ever confirmed|0 |1 --- Comment #1 from Stéphane Guillou (stragu) --- Thanks for the report. I tried reproducing the crash with my own sample files but could not. Can you please provide a zip of sample files, with precise steps that reproduce the crash with those files? And how exactly do you to the new ODS? Using "Exchange database"? Version: 7.5.7.1 (X86_64) / LibreOffice Community Build ID: 47eb0cf7efbacdee9b19ae25d6752381ede23126 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102998] [META] Mail merge bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102998 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||146718 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=146718 [Bug 146718] Crash in: SwDBManager::MergeMailFiles(SwWrtShell *,SwMergeDescriptor const &) - Mailmerge print form letter, individual documents, path with non-existing user -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102998] [META] Mail merge bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102998 Bug 102998 depends on bug 146718, which changed state. Bug 146718 Summary: Crash in: SwDBManager::MergeMailFiles(SwWrtShell *,SwMergeDescriptor const &) - Mailmerge print form letter, individual documents, path with non-existing user https://bugs.documentfoundation.org/show_bug.cgi?id=146718 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133092] [META] Crash bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=133092 Bug 133092 depends on bug 146718, which changed state. Bug 146718 Summary: Crash in: SwDBManager::MergeMailFiles(SwWrtShell *,SwMergeDescriptor const &) - Mailmerge print form letter, individual documents, path with non-existing user https://bugs.documentfoundation.org/show_bug.cgi?id=146718 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146718] Crash in: SwDBManager::MergeMailFiles(SwWrtShell *, SwMergeDescriptor const &) - Mailmerge print form letter, individual documents, path with non-existing user
https://bugs.documentfoundation.org/show_bug.cgi?id=146718 Stéphane Guillou (stragu) changed: What|Removed |Added Blocks||102998 CC||stephane.guillou@libreoffic ||e.org, ||vmik...@collabora.com Status|UNCONFIRMED |RESOLVED OS|Windows (All) |All Whiteboard||target:7.5.0 Resolution|--- |FIXED --- Comment #4 from Stéphane Guillou (stragu) --- Using the steps in comment 2, crash reproduced in 7.4: Version: 7.4.7.2 / LibreOffice Community Build ID: 723314e595e8007d3cf785c16538505a1c878ca5 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded However, no crash anymore since 7.5: Version: 7.5.7.1 (X86_64) / LibreOffice Community Build ID: 47eb0cf7efbacdee9b19ae25d6752381ede23126 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded I bibisected the fix with the linux-64-7.5 repo to Miklos' c400c36018e8d89bbf8e551258a480c8f6571efe: commit c400c36018e8d89bbf8e551258a480c8f6571efe author Miklos Vajna Fri Nov 04 18:07:13 2022 +0100 committer Miklos VajnaFri Nov 04 21:07:03 2022 +0100 sw: fix heap-use-after-free in SwDBManager::MergeMailFiles() Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142282 Thank you Miklos! Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102998 [Bug 102998] [META] Mail merge bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - sw/qa writerfilter/source
sw/qa/extras/ooxmlexport/data/tdf155736_PageNumbers_footer.docx |binary sw/qa/extras/ooxmlexport/ooxmlexport18.cxx | 14 ++ writerfilter/source/dmapper/DomainMapper_Impl.cxx | 21 +++--- writerfilter/source/dmapper/DomainMapper_Impl.hxx |2 4 files changed, 30 insertions(+), 7 deletions(-) New commits: commit 4c39b4c93c139ab804c96955149c463a2fb672a8 Author: Satya AuthorDate: Wed Jun 14 18:15:35 2023 +0530 Commit: Skyler Grey CommitDate: Wed Oct 11 21:57:28 2023 +0200 tdf#155736 Modified IsInTOC() to handle IsInHeaderFooter() case. This fixes a problem of page numbers missing in the footer. The importer might start processing the footer before the TOC has finished - m_bStartTOC might be true. In this case we are not actually IsInTOC,and m_bStartTOC should be ignored and make use of IsInHeaderFooter() and m_bStartTOCHeaderFooter to confirm if the footer/header itself has TOC. Change-Id: Ieede9f8e2120556630ba57b9c748935788f3cc9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153052 Reviewed-by: Justin Luth Tested-by: Justin Luth (cherry picked from commit d7dd39e124f8a1fa199dd8322b642e8be04ed360) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157789 Reviewed-by: Skyler Grey Tested-by: Jenkins CollaboraOffice diff --git a/sw/qa/extras/ooxmlexport/data/tdf155736_PageNumbers_footer.docx b/sw/qa/extras/ooxmlexport/data/tdf155736_PageNumbers_footer.docx new file mode 100644 index ..58e36988002a Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf155736_PageNumbers_footer.docx differ diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx index b2f02ce337bc..856efb375d11 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx @@ -715,6 +715,20 @@ CPPUNIT_TEST_FIXTURE(Test, testTdf157136) } } +DECLARE_OOXMLEXPORT_TEST(testTdf155736, "tdf155736_PageNumbers_footer.docx") +{ +CPPUNIT_ASSERT_EQUAL(2, getPages()); + +xmlDocUniquePtr pXmlDoc = parseLayoutDump(); +assertXPath(pXmlDoc, "/root/page[1]/footer"); +assertXPath(pXmlDoc, "/root/page[2]/footer"); +//Without the fix in place, it would have failed with +//- Expected: Page * of * +//- Actual : Page of +CPPUNIT_ASSERT_EQUAL(OUString("Page * of *"), parseDump("/root/page[1]/footer/txt/text()")); +CPPUNIT_ASSERT_EQUAL(OUString("Page * of *"), parseDump("/root/page[2]/footer/txt/text()")); +} + CPPUNIT_PLUGIN_IMPLEMENT(); /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx b/writerfilter/source/dmapper/DomainMapper_Impl.cxx index 8f21f04e03ac..7c6c54182854 100644 --- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx +++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx @@ -2850,7 +2850,7 @@ void DomainMapper_Impl::appendTextPortion( const OUString& rString, const Proper // If we are in comments, then disable CharGrabBag, comment text doesn't support that. uno::Sequence< beans::PropertyValue > aValues = pPropertyMap->GetPropertyValues(/*bCharGrabBag=*/!m_bIsInComments); -if (m_bStartTOC || m_bStartIndex || m_bStartBibliography) +if (IsInTOC() || m_bStartIndex || m_bStartBibliography) for( auto& rValue : asNonConstRange(aValues) ) { if (rValue.Name == "CharHidden") @@ -3263,6 +3263,14 @@ void DomainMapper_Impl::fillEmptyFrameProperties(std::vector(0))); } +bool DomainMapper_Impl::IsInTOC() const +{ +if (IsInHeaderFooter()) +return m_bStartTOCHeaderFooter; +else +return m_bStartTOC; +} + void DomainMapper_Impl::ConvertHeaderFooterToTextFrame(bool bDynamicHeightTop, bool bDynamicHeightBottom) { while (!m_aHeaderFooterTextAppendStack.empty()) @@ -6977,7 +6985,7 @@ void DomainMapper_Impl::CloseFieldCommand() break; } } -if (m_bStartTOC && (aIt->second.eFieldId == FIELD_PAGEREF) ) +if (IsInTOC() && (aIt->second.eFieldId == FIELD_PAGEREF)) { bCreateField = false; } @@ -7365,7 +7373,7 @@ void DomainMapper_Impl::CloseFieldCommand() break; case FIELD_PAGEREF: case FIELD_REF: -if (xFieldProperties.is() && !m_bStartTOC) +if (xFieldProperties.is() && !IsInTOC()) { bool bPageRef = aIt->second.eFieldId == FIELD_PAGEREF; @@ -8047,9 +8055,9 @@ void DomainMapper_Impl::PopFieldContext() else { xToInsert.set(pContext->GetTC(), uno::UNO_QUERY); -if( !xToInsert.is() && !m_bStartTOC && !m_bStartIndex && !m_bStartBibliography ) +if (!xToInsert.is() &&
[Libreoffice-commits] core.git: accessibility/inc basctl/inc bin/find-can-be-private-symbols.functions.results bin/find-unneeded-includes canvas/source chart2/inc comphelper/source config_host/config_
accessibility/inc/pch/precompiled_acc.hxx |2 basctl/inc/pch/precompiled_basctl.hxx |2 bin/find-can-be-private-symbols.functions.results |6 - bin/find-unneeded-includes |1 canvas/source/cairo/cairo_textlayout.cxx |2 canvas/source/directx/dx_textlayout_drawhelper.cxx |2 canvas/source/opengl/ogl_canvashelper.cxx |2 canvas/source/vcl/textlayout.cxx |4 chart2/inc/pch/precompiled_chartcontroller.hxx |2 chart2/inc/pch/precompiled_chartcore.hxx |2 comphelper/source/misc/simplefileaccessinteraction.cxx |2 comphelper/source/misc/stillreadwriteinteraction.cxx |2 comphelper/source/property/propertysetinfo.cxx |4 config_host/config_global.h.in |3 configure.ac | 16 -- cppcanvas/source/inc/implrenderer.hxx |4 cppcanvas/source/mtfrenderer/implrenderer.cxx |2 cppcanvas/source/mtfrenderer/textaction.cxx|4 cppcanvas/source/mtfrenderer/textaction.hxx|7 - cui/inc/pch/precompiled_cui.hxx|2 dbaccess/inc/pch/precompiled_dbu.hxx |2 editeng/inc/outleeng.hxx |4 editeng/inc/pch/precompiled_editeng.hxx|2 editeng/source/editeng/editeng.cxx |2 editeng/source/editeng/impedit3.cxx| 10 - editeng/source/items/svxfont.cxx | 24 ++-- editeng/source/outliner/outleeng.cxx |2 editeng/source/outliner/outliner.cxx |4 editeng/source/uno/unoipset.cxx|2 editeng/source/uno/unotext.cxx |4 filter/source/config/cache/basecontainer.cxx |2 filter/source/config/cache/cacheitem.cxx |4 filter/source/config/cache/cacheitem.hxx |6 - filter/source/config/cache/filtercache.cxx |4 filter/source/config/cache/filtercache.hxx |4 framework/inc/pch/precompiled_fwk.hxx |2 include/comphelper/propertysetinfo.hxx |6 - include/editeng/editeng.hxx|6 - include/editeng/outliner.hxx | 12 +- include/editeng/svxfont.hxx| 13 +- include/editeng/unoipset.hxx |2 include/editeng/unotext.hxx|6 - include/o3tl/span.hxx | 100 - include/sfx2/dispatch.hxx |4 include/svl/itemprop.hxx | 10 - include/svx/sdr/properties/defaultproperties.hxx |4 include/svx/unoprov.hxx|4 include/svx/unoshape.hxx | 12 +- include/ucbhelper/interceptedinteraction.hxx |6 - include/vcl/kernarray.hxx |6 - include/vcl/metaact.hxx|4 include/vcl/outdev.hxx | 12 +- include/vcl/pdfwriter.hxx |2 include/xmloff/txtparae.hxx|6 - linguistic/source/lngopt.cxx |2 o3tl/CppunitTest_o3tl_tests.mk |1 o3tl/qa/test-span.cxx | 60 -- oox/inc/pch/precompiled_oox.hxx|2 reportdesign/inc/pch/precompiled_rpt.hxx |2 reportdesign/inc/pch/precompiled_rptui.hxx |2 sc/inc/optuno.hxx |2 sc/inc/pch/precompiled_sc.hxx |2 sc/source/ui/unoobj/PivotTableDataProvider.cxx |2 sc/source/ui/unoobj/PivotTableDataSequence.cxx |2 sc/source/ui/unoobj/afmtuno.cxx|4 sc/source/ui/unoobj/appluno.cxx|2 sc/source/ui/unoobj/cellsuno.cxx |2 sc/source/ui/unoobj/chart2uno.cxx |4 sc/source/ui/unoobj/condformatuno.cxx | 12 +- sc/source/ui/unoobj/confuno.cxx|2 sc/source/ui/unoobj/dapiuno.cxx|6 - sc/source/ui/unoobj/datauno.cxx|6 - sc/source/ui/unoobj/defltuno.cxx |2 sc/source/ui/unoobj/docuno.cxx |6 - sc/source/ui/unoobj/fmtuno.cxx |2 sc/source/ui/unoobj/linkuno.cxx|2 sc/source/ui/unoobj/nameuno.cxx|4