[Libreoffice-bugs] [Bug 157703] FILESAVE PDF: Since LO 7.6.0 Beta1, Numbered headings result to a Acrobat / PAC2021 "Lbl / LBody" errors
https://bugs.documentfoundation.org/show_bug.cgi?id=157703 Michael Weghorn changed: What|Removed |Added CC||qui...@gmail.com Regression By||Tomaž Vajngerl -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/CppunitTest_vcl_gtk3_a11y.mk
vcl/CppunitTest_vcl_gtk3_a11y.mk |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit ca01deadcbc480b6e79618b227a2b73a61ecb7ff
Author: Michael Weghorn
AuthorDate: Mon Oct 16 11:03:46 2023 +0200
Commit: Michael Weghorn
CommitDate: Tue Oct 17 07:50:37 2023 +0200
gtk3 a11y test: Let xvfb-run auto-determine free server num
As the xvfb-run manpage says, it uses a default server number of 99:
> -n servernumber, --server-num=servernumber
> Use servernumber as the server number (but see the -a,
--auto-servernum option above). The default is 99.
The gtk3 a11y tests use xvfb-run. Running the test multiple
times in parallel (e.g. when doing two separate builds with
tests, as happens on CI) would fall like this on Debian testing:
$ make CppunitTest_vcl_gtk3_a11y
make -j 12 -rs -f
/home/michi/development/git/libreoffice/Makefile.gbuild
CppunitTest_vcl_gtk3_a11y
[CUT] vcl_gtk3_a11y
xvfb-run: error: Xvfb failed to start
Hint: You are currently not seeing messages from other users and the
system.
Users in groups 'adm', 'systemd-journal' can see all messages.
Pass -q to turn off this notice.
No coredumps found.
Error: a unit test failed, please do one of:
make CppunitTest_vcl_gtk3_a11y CPPUNITTRACE="gdb --args"
# for interactive debugging on Linux
make CppunitTest_vcl_gtk3_a11y VALGRIND=memcheck
# for memory checking
make CppunitTest_vcl_gtk3_a11y DEBUGCPPUNIT=TRUE
# for exception catching
You can limit the execution to just one particular test by:
make CPPUNIT_TEST_NAME="testXYZ" ...above mentioned params...
However, it behaves differently on Alma Linux 8, where it
looks like xvfb-run seems then to reuse the existing
Xfvb session, causing the tests to potentially find
the LibreOffice instance from another test run, and
then inspecting the wrong one, leading to failures
like the one in [1]:
equality assertion failed
- Expected: ecclectic.fodt — LibreOfficeDev Writer
- Actual : ecclectic.fodt — LibreOfficeDev Writer 24.2
[9bc2aede99017ed0338e97b21b4735919b705b47]
The fact that the second instance of xvfb-run
reuses the session of the firs one and finds the
LibreOffice there can also be reproduced on Alma Linux 8
by just running these 2 commands in parallel:
1) start LO in xfvb-run session:
$ xvfb-run dbus-launch libreoffice
2) run below Python script that lists the
running applications:
$ xvfb-run dbus-launch python3 /home/vagrant/atspi-list-apps.py
start
[application | soffice]
end
/usr/bin/xvfb-run: line 186: kill: (27078) - No such process
This *should not* list the applications from
the other xfvb-run.
It works as expected when passing `--auto-servernum`:
$ xvfb-run --auto-servernum dbus-launch python3
/home/vagrant/atspi-list-apps.py
start
end
Therefore, pass the `--auto-servernum` arg to xvfb-run, so that it
automatically determines a free server number instead.
> -a, --auto-servernum
> Try to get a free server number, starting at 99, or the
argument to --server-num.
Python script mentioned above used for testing:
$ cat atspi-list-apps.py
#!/usr/bin/python3
import pyatspi
registry = pyatspi.registry.Registry()
apps = list(registry.getDesktop(0))
print('start')
for app in apps:
print(f'{app}')
print('end')
[1]
https://ci.libreoffice.org/job/gerrit_linux_gcc_release/151750/consoleFull#-1985341263d893063f-7f3d-4b7e-b56f-4e0f225817cd
Change-Id: I0673212fb8fed5c9698c9f797b7bf49ba51033b0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158021
Tested-by: Jenkins
Reviewed-by: Colomban Wendling
Reviewed-by: Michael Weghorn
diff --git a/vcl/CppunitTest_vcl_gtk3_a11y.mk b/vcl/CppunitTest_vcl_gtk3_a11y.mk
index 19adbabd4d14..476f80334442 100644
--- a/vcl/CppunitTest_vcl_gtk3_a11y.mk
+++ b/vcl/CppunitTest_vcl_gtk3_a11y.mk
@@ -13,7 +13,7 @@ $(call gb_CppunitTest_get_target,vcl_gtk3_a11y) :
gb_TEST_ENV_VARS += SAL_USE_VC
$(call gb_CppunitTest_get_target,vcl_gtk3_a11y) : gb_TEST_ENV_VARS +=
GDK_BACKEND=x11
ifeq (,$(VCL_GTK3_TESTS_NO_XVFB))
$(call gb_CppunitTest_get_target,vcl_gtk3_a11y) : \
- ICECREAM_RUN += $(XVFB_RUN) $(DBUS_LAUNCH) --exit-with-session
+ ICECREAM_RUN += $(XVFB_RUN) --auto-servernum $(DBUS_LAUNCH)
--exit-with-session
endif
$(eval $(call gb_CppunitTest_CppunitTest,vcl_gtk3_a11y))
[Libreoffice-commits] core.git: 2 commits - cui/source sfx2/source
cui/source/tabpages/paragrph.cxx | 14 +-
sfx2/source/dialog/tabdlg.cxx|3 +--
2 files changed, 6 insertions(+), 11 deletions(-)
New commits:
commit d4efce34e0bd1e99d115ece4442ead39b90b89bb
Author: Mike Kaganski
AuthorDate: Tue Oct 17 06:09:19 2023 +0300
Commit: Mike Kaganski
CommitDate: Tue Oct 17 07:36:59 2023 +0200
tdf#148725: Reset must clear respective items from m_pOutSet
After Reset, the tabbed dialog's output set should restore to the same
state (concerning the current tab page) as immediately after creation.
This state means that pressing OK immediately afer Reset would not try
to set or remove any items in the target. SfxTabDialogController::Ok
has this code:
if (m_pOutSet && m_pOutSet->Count() > 0)
bModified = true;
meaning that m_pOutSet is expected to be empty in case of completely
unmodified dialog; and Reset must make sure this for a given page.
Instead, commit 28fc0962b10519ab84654d189d2ad0cca8f84f95 (weld SwLabDlg,
2018-04-27) made Reset handler to populate the output item set with all
the items from the input set, that belong to the page's which ranges.
This made all the settings set in parents (which therefore appeared in
the input set) to be set directly in the target upon application.
Change-Id: Iacfffb5670cc3ade950ac412b818acb482845255
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158067
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sfx2/source/dialog/tabdlg.cxx b/sfx2/source/dialog/tabdlg.cxx
index 8f0f41426972..57e266a3f198 100644
--- a/sfx2/source/dialog/tabdlg.cxx
+++ b/sfx2/source/dialog/tabdlg.cxx
@@ -457,13 +457,12 @@ IMPL_LINK_NOARG(SfxTabDialogController, ResetHdl,
weld::Button&, void)
if (SfxItemState::SET == m_pSet->GetItemState(nWh, false, ))
{
m_xExampleSet->Put(*pItem);
-m_pOutSet->Put(*pItem);
}
else
{
m_xExampleSet->ClearItem(nWh);
-m_pOutSet->ClearItem(nWh);
}
+m_pOutSet->ClearItem(nWh);
nTmp++;
}
}
commit e134bcf0272929ebba8edc35ae0bdd8f934e624a
Author: Mike Kaganski
AuthorDate: Tue Oct 17 06:00:34 2023 +0300
Commit: Mike Kaganski
CommitDate: Tue Oct 17 07:36:52 2023 +0200
Related: tdf#148725 Fix SvxExtParagraphTabPage::ChangesApplied
It was setting values, instead of saving them, ever since commit
a212ef2b6ebadb22a9abf6d042aa2b5fd9ac1cf0 (tdf#93901: apply handling in
style/edit dialog improved, 2015-09-11).
The same thing in SvxStdParagraphTabPage::ChangesApplied was fixed in
commit 8b0dae14a5af0ad2892bac0e606467af6148c8d1 (weld
SvxStdParagraphTabPage, 2018-06-14); but a similar commit
eb1d6b16e787a87c3d918135ca98c5694d352557 (weld SvxExtParagraphTabPage,
2018-06-14) kept this in SvxExtParagraphTabPage.
Change-Id: I5fb61a9416dab4ccf9fa690eca87a16f7b9378bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158066
Tested-by: Mike Kaganski
Reviewed-by: Mike Kaganski
diff --git a/cui/source/tabpages/paragrph.cxx b/cui/source/tabpages/paragrph.cxx
index 9f5e94833b3b..7c8f2dc225a7 100644
--- a/cui/source/tabpages/paragrph.cxx
+++ b/cui/source/tabpages/paragrph.cxx
@@ -2138,15 +2138,11 @@ void SvxExtParagraphTabPage::ChangesApplied()
m_xHyphenBox->save_state();
m_xHyphenNoCapsBox->save_state();
m_xHyphenNoLastWordBox->save_state();
-m_xExtHyphenBeforeBox->set_value(m_xExtHyphenBeforeBox->get_value());
-m_xExtHyphenAfterBox->set_value(m_xExtHyphenAfterBox->get_value());
-m_xMaxHyphenEdit->set_value(m_xMaxHyphenEdit->get_value());
-m_xMinWordLength->set_value(m_xMinWordLength->get_value());
-SfxItemPool* pPool = GetItemSet().GetPool();
-DBG_ASSERT( pPool, "Where is the pool?" );
-FieldUnit eUnit =
- MapToFieldUnit( pPool->GetMetric( GetWhich(
SID_ATTR_PARA_HYPHENZONE ) ) );
-m_aHyphenZone.set_value(m_aHyphenZone.get_value(eUnit), eUnit);
+m_xExtHyphenBeforeBox->save_value();
+m_xExtHyphenAfterBox->save_value();
+m_xMaxHyphenEdit->save_value();
+m_xMinWordLength->save_value();
+m_aHyphenZone.save_value();
m_xPageBreakBox->save_state();
m_xBreakPositionLB->save_value();
m_xBreakTypeLB->save_value();
[Libreoffice-bugs] [Bug 127250] [META] Text formatting issues when inserting or overwriting
https://bugs.documentfoundation.org/show_bug.cgi?id=127250 Bug 127250 depends on bug 148725, which changed state. Bug 148725 Summary: Paragraph DF is written if DF Paragraph dialog being opened, reset being pressed followed by OK https://bugs.documentfoundation.org/show_bug.cgi?id=148725 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157796] Clone Formatting gets disabled in Single Toolbar UI
https://bugs.documentfoundation.org/show_bug.cgi?id=157796 Kira Tubo changed: What|Removed |Added Version|7.6.2.1 release |7.5.5.2 release Summary|Clone Format not working as |Clone Formatting gets |intended|disabled in Single Toolbar ||UI -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157796] Clone Format not working as intended
https://bugs.documentfoundation.org/show_bug.cgi?id=157796 Kira Tubo changed: What|Removed |Added Keywords||regression Ever confirmed|0 |1 Status|UNCONFIRMED |NEW CC||kira.t...@gmail.com --- Comment #2 from Kira Tubo --- Reproduced on: Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 1ec2e39cf4d5fe0a592bc783fd8bcdc4345c8cbd CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded Version: 7.5.5.2 (X86_64) / LibreOffice Community Build ID: ca8fe7424262805f223b9a2334bc7181abbcbf5e CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded NOT reproduced on: Version: 7.3.3.2 (x64) / LibreOffice Community Build ID: d1d0ea68f081ee2800a922cac8f79445e4603348 CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL To clarify steps: 1. Open calc 2. View > User Interface > Single Toolbar 3. Paste an image 4. Click on pasted image 5. Click on any cell in spreadsheet Result: "Clone formatting" button is grayed out -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/utlui/glbltree.cxx | 28 +++-
1 file changed, 27 insertions(+), 1 deletion(-)
New commits:
commit 2a05fd0fd2b6c4ad8fd900565f3640f1ef47a165
Author: Jim Raykowski
AuthorDate: Mon Oct 9 20:22:04 2023 -0800
Commit: Jim Raykowski
CommitDate: Tue Oct 17 07:24:37 2023 +0200
tdf#144349 related: Make master document navigator track Text content
Done, with a related patch to make the master document navigator track TOX
content, to make the Navigator less likely not to have an item selected, which
may be enough to resolve tdf#155741 - Allow insertion of items into master
without a selected item
Change-Id: I1a9d2a12a01ca2c5f3f162e8da932c04ced9a461
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157741
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
diff --git a/sw/source/uibase/utlui/glbltree.cxx
b/sw/source/uibase/utlui/glbltree.cxx
index fe18195e7c22..8c8fef089161 100644
--- a/sw/source/uibase/utlui/glbltree.cxx
+++ b/sw/source/uibase/utlui/glbltree.cxx
@@ -787,12 +787,12 @@ IMPL_LINK_NOARG(SwGlobalTree, Timeout, Timer *, void)
}
}
+// track GlobalDocContentType at the cursor position in the document
void SwGlobalTree::UpdateTracking()
{
if (!m_pActiveShell)
return;
-// track section at cursor position in document
m_xTreeView->unselect_all();
const SwSection* pActiveShellCurrSection =
m_pActiveShell->GetCurrSection();
@@ -816,6 +816,32 @@ void SwGlobalTree::UpdateTracking()
}
}
}
+else
+{
+const SwCursor* pCursor = m_pActiveShell->GetCursor();
+const SwNode& rNode = pCursor->GetPoint()->GetNode();
+if (rNode.IsTextNode())
+{
+// only the first text node in each series of text nodes is stored
in the
+// SwGlblDocContents array
+SwNodeIndex aIdx(rNode);
+do
+{
+--aIdx;
+} while (aIdx.GetNode().IsTextNode());
+++aIdx;
+SwNodeOffset aTextNodeIndex(aIdx.GetNode().GetIndex());
+for (const std::unique_ptr& rGlblDocContent :
*m_pSwGlblDocContents)
+{
+if (rGlblDocContent->GetType() ==
GlobalDocContentType::GLBLDOC_UNKNOWN
+&& rGlblDocContent->GetDocPos() == aTextNodeIndex)
+{
+const OUString& rId(weld::toId(rGlblDocContent.get()));
+m_xTreeView->select(m_xTreeView->find_id(rId));
+}
+}
+}
+}
Select();
}
[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103378 Aron Budea changed: What|Removed |Added Depends on||157750 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=157750 [Bug 157750] Individual image saved as PDF creates 0-byte file -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157750] Individual image saved as PDF creates 0-byte file
https://bugs.documentfoundation.org/show_bug.cgi?id=157750 Aron Budea changed: What|Removed |Added Blocks||103378 CC||aron.bu...@gmail.com Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103378 [Bug 103378] [META] PDF export bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148725] Paragraph DF is written if DF Paragraph dialog being opened, reset being pressed followed by OK
https://bugs.documentfoundation.org/show_bug.cgi?id=148725 Mike Kaganski changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com |desktop.org | --- Comment #6 from Mike Kaganski --- https://gerrit.libreoffice.org/c/core/+/158066 https://gerrit.libreoffice.org/c/core/+/158067 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/utlui/glbltree.cxx | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
New commits:
commit b97aa4eada3164b20f663a9817e92af78495109f
Author: Jim Raykowski
AuthorDate: Sun Oct 8 22:42:09 2023 -0800
Commit: Jim Raykowski
CommitDate: Tue Oct 17 05:20:05 2023 +0200
tdf#144349 related: Make master document navigator track TOX content
Done, with a related patch to make the master document navigator track
'Text' content, to make the Navigator less likely not to have an item selected,
which may be enough to resolve tdf#155741 - Allow insertion of items into
master without a selected item
Change-Id: I6df1b668c502cadbe057229e031ede9aa4f4089a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157695
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
diff --git a/sw/source/uibase/utlui/glbltree.cxx
b/sw/source/uibase/utlui/glbltree.cxx
index 26dd58f5b7ea..fe18195e7c22 100644
--- a/sw/source/uibase/utlui/glbltree.cxx
+++ b/sw/source/uibase/utlui/glbltree.cxx
@@ -801,7 +801,20 @@ void SwGlobalTree::UpdateTracking()
const SwSection* pSection = pActiveShellCurrSection;
while (SwSection* pParent = pSection->GetParent())
pSection = pParent;
-m_xTreeView->select_text(pSection->GetSectionName());
+for (const std::unique_ptr& rGlblDocContent :
*m_pSwGlblDocContents)
+{
+if (rGlblDocContent->GetType() ==
GlobalDocContentType::GLBLDOC_UNKNOWN)
+continue;
+if ((pSection->GetType() == SectionType::ToxContent
+ && rGlblDocContent->GetTOX() == pSection->GetTOXBase())
+|| (pSection->GetType() != SectionType::ToxContent
+&& rGlblDocContent->GetSection() == pSection))
+{
+const OUString& rId(weld::toId(rGlblDocContent.get()));
+m_xTreeView->select(m_xTreeView->find_id(rId));
+break;
+}
+}
}
Select();
[Libreoffice-bugs] [Bug 157729] Group comment threads in navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=157729 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157498] Window movement and resizes messed up with macOS Sonoma
https://bugs.documentfoundation.org/show_bug.cgi?id=157498 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157729] Group comment threads in navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=157729 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 157729] Group comment threads in navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=157729 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 157537] Character style "blinks" in-and-out of being applied as I type
https://bugs.documentfoundation.org/show_bug.cgi?id=157537 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 157729] Group comment threads in navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=157729 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 128549] Crash when Export as png (MacOS Catalina)
https://bugs.documentfoundation.org/show_bug.cgi?id=128549 --- Comment #10 from QA Administrators --- Dear Arjan, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 109323] [META] Graphic export bugs and enhancements (jpg, png, eps, tiff, gif ...)
https://bugs.documentfoundation.org/show_bug.cgi?id=109323 Bug 109323 depends on bug 128549, which changed state. Bug 128549 Summary: Crash when Export as png (MacOS Catalina) https://bugs.documentfoundation.org/show_bug.cgi?id=128549 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154898] Help
https://bugs.documentfoundation.org/show_bug.cgi?id=154898 --- Comment #2 from QA Administrators --- Dear em...@jefgeorge.com, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154002] LO is in dark mode when restarted after setting to light mode.
https://bugs.documentfoundation.org/show_bug.cgi?id=154002 --- Comment #3 from QA Administrators --- Dear Boudi, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154816] Can't refresh control after selecting it with mouse click
https://bugs.documentfoundation.org/show_bug.cgi?id=154816 --- Comment #2 from QA Administrators --- Dear lowell_friesen, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145156] Copy/Paste to Text editor/Spreadsheet does not work with Table Control of a Form, which is connected to data by a simple SQL command
https://bugs.documentfoundation.org/show_bug.cgi?id=145156 --- Comment #5 from QA Administrators --- Dear intmail01, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 128075] Solver finds solutions for negative goals but "thinks" it has failed
https://bugs.documentfoundation.org/show_bug.cgi?id=128075 --- Comment #16 from QA Administrators --- Dear OfficeUser, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141033] Usability : Base Form Control Property dialog window width is too narrow by default
https://bugs.documentfoundation.org/show_bug.cgi?id=141033 --- Comment #9 from QA Administrators --- Dear frank.derville, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108019] [META] Calc UX bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108019 Bug 108019 depends on bug 112383, which changed state. Bug 112383 Summary: [meta] Regressions introduced by using using multi_type_vector for cell storage https://bugs.documentfoundation.org/show_bug.cgi?id=112383 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112383] [meta] Regressions introduced by using using multi_type_vector for cell storage
https://bugs.documentfoundation.org/show_bug.cgi?id=112383 Kohei Yoshida changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Kohei Yoshida --- I'll mark this as resolved. I don't see any open child bugs. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139141] Make Field > Date (variable) the default and rename
https://bugs.documentfoundation.org/show_bug.cgi?id=139141 Regina Henschel changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||7800 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157800] The insert time and date function will use the current system time no matter when the entry was actually made.
https://bugs.documentfoundation.org/show_bug.cgi?id=157800 Regina Henschel changed: What|Removed |Added Status|UNCONFIRMED |NEW See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||9141 CC||rb.hensc...@t-online.de Ever confirmed|0 |1 --- Comment #1 from Regina Henschel --- The command "Time" (.uno:InsertTimeField) has inserted the "Time (fixed)" field in LibreOffice 5 and 6. It inserts the "Time" field in LibreOffice 7.6. Please see also the discussion in bug 139141 and bug 157337. It is likely duplicate to bug 157337. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157203] CRASH when reset Drawing Background Color to NONE
https://bugs.documentfoundation.org/show_bug.cgi?id=157203 --- Comment #8 from madladdesi...@gmail.com --- Yes, it was through the tabbed user interface. It's fine through the standard toolbar. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5-8' - stoc/Library_javavm.mk stoc/source
stoc/Library_javavm.mk|6 ++
stoc/source/javavm/javavm.cxx | 15 +++
2 files changed, 21 insertions(+)
New commits:
commit 58320647950df01f1a23d07a90425e0b466a7f9d
Author: Patrick Luby
AuthorDate: Sat Oct 14 21:13:26 2023 -0400
Commit: Patrick Luby
CommitDate: Tue Oct 17 00:56:24 2023 +0200
tdf#101376 don't detach thread if it is the main thread on macOS
On macOS, many AWT classes do their work on the main thread
deep in native methods in the java.awt.* classes. The problem
is that Oracle's and OpenJDK's JVMs don't bracket their
"perform on main thread" native calls with "attach/detach
current thread" calls to the JVM.
Change-Id: I0859dc9e20f34bd0b43bb321898507764fd530fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157985
Tested-by: Jenkins
Reviewed-by: Patrick Luby
(cherry picked from commit a0eee8e56b91324470bb0e15c6b8009cfc411335)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157963
Reviewed-by: Adolfo Jayme Barrientos
Tested-by: Patrick Luby
diff --git a/stoc/Library_javavm.mk b/stoc/Library_javavm.mk
index e096565769f9..adcb49691ce1 100644
--- a/stoc/Library_javavm.mk
+++ b/stoc/Library_javavm.mk
@@ -31,4 +31,10 @@ $(eval $(call gb_Library_add_exception_objects,javavm,\
stoc/source/javavm/jvmargs \
))
+ifeq ($(OS),MACOSX)
+$(eval $(call gb_Library_use_system_darwin_frameworks,javavm,\
+CoreFoundation \
+))
+endif
+
# vim:set noet sw=4 ts=4:
diff --git a/stoc/source/javavm/javavm.cxx b/stoc/source/javavm/javavm.cxx
index 12bcc2c904b7..dc22107fbf84 100644
--- a/stoc/source/javavm/javavm.cxx
+++ b/stoc/source/javavm/javavm.cxx
@@ -79,6 +79,12 @@
#define TIMEZONE "MET"
#endif
+#ifdef MACOSX
+#include
+#include
+#include
+#endif
+
/* Within this implementation of the com.sun.star.java.JavaVirtualMachine
* service and com.sun.star.java.theJavaVirtualMachine singleton, the method
* com.sun.star.java.XJavaVM.getJavaVM relies on the following:
@@ -456,6 +462,15 @@ public:
explicit DetachCurrentThread(JavaVM * jvm): m_jvm(jvm) {}
~DetachCurrentThread() {
+#ifdef MACOSX
+// tdf#101376 don't detach thread if it is the main thread on macOS
+// On macOS, many AWT classes do their work on the main thread
+// deep in native methods in the java.awt.* classes. The problem
+// is that Oracle's and OpenJDK's JVMs don't bracket their
+// "perform on main thread" native calls with "attach/detach
+// current thread" calls to the JVM.
+if (CFRunLoopGetCurrent() != CFRunLoopGetMain())
+#endif
if (m_jvm->DetachCurrentThread() != 0) {
OSL_ASSERT(false);
}
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - stoc/Library_javavm.mk stoc/source
stoc/Library_javavm.mk|6 ++
stoc/source/javavm/javavm.cxx | 15 +++
2 files changed, 21 insertions(+)
New commits:
commit a976edfa525d87c7174861bca5eecd4ee804132d
Author: Patrick Luby
AuthorDate: Sat Oct 14 21:13:26 2023 -0400
Commit: Patrick Luby
CommitDate: Tue Oct 17 00:54:47 2023 +0200
tdf#101376 don't detach thread if it is the main thread on macOS
On macOS, many AWT classes do their work on the main thread
deep in native methods in the java.awt.* classes. The problem
is that Oracle's and OpenJDK's JVMs don't bracket their
"perform on main thread" native calls with "attach/detach
current thread" calls to the JVM.
Change-Id: I0859dc9e20f34bd0b43bb321898507764fd530fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157985
Tested-by: Jenkins
Reviewed-by: Patrick Luby
(cherry picked from commit a0eee8e56b91324470bb0e15c6b8009cfc411335)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157962
diff --git a/stoc/Library_javavm.mk b/stoc/Library_javavm.mk
index e096565769f9..adcb49691ce1 100644
--- a/stoc/Library_javavm.mk
+++ b/stoc/Library_javavm.mk
@@ -31,4 +31,10 @@ $(eval $(call gb_Library_add_exception_objects,javavm,\
stoc/source/javavm/jvmargs \
))
+ifeq ($(OS),MACOSX)
+$(eval $(call gb_Library_use_system_darwin_frameworks,javavm,\
+CoreFoundation \
+))
+endif
+
# vim:set noet sw=4 ts=4:
diff --git a/stoc/source/javavm/javavm.cxx b/stoc/source/javavm/javavm.cxx
index 12bcc2c904b7..dc22107fbf84 100644
--- a/stoc/source/javavm/javavm.cxx
+++ b/stoc/source/javavm/javavm.cxx
@@ -79,6 +79,12 @@
#define TIMEZONE "MET"
#endif
+#ifdef MACOSX
+#include
+#include
+#include
+#endif
+
/* Within this implementation of the com.sun.star.java.JavaVirtualMachine
* service and com.sun.star.java.theJavaVirtualMachine singleton, the method
* com.sun.star.java.XJavaVM.getJavaVM relies on the following:
@@ -456,6 +462,15 @@ public:
explicit DetachCurrentThread(JavaVM * jvm): m_jvm(jvm) {}
~DetachCurrentThread() {
+#ifdef MACOSX
+// tdf#101376 don't detach thread if it is the main thread on macOS
+// On macOS, many AWT classes do their work on the main thread
+// deep in native methods in the java.awt.* classes. The problem
+// is that Oracle's and OpenJDK's JVMs don't bracket their
+// "perform on main thread" native calls with "attach/detach
+// current thread" calls to the JVM.
+if (CFRunLoopGetCurrent() != CFRunLoopGetMain())
+#endif
if (m_jvm->DetachCurrentThread() != 0) {
OSL_ASSERT(false);
}
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - stoc/Library_javavm.mk stoc/source
stoc/Library_javavm.mk|6 ++
stoc/source/javavm/javavm.cxx | 15 +++
2 files changed, 21 insertions(+)
New commits:
commit a7340bbc89739ac1ef64ae605d71bf4053b3b3ac
Author: Patrick Luby
AuthorDate: Sat Oct 14 21:13:26 2023 -0400
Commit: Patrick Luby
CommitDate: Tue Oct 17 00:54:12 2023 +0200
tdf#101376 don't detach thread if it is the main thread on macOS
On macOS, many AWT classes do their work on the main thread
deep in native methods in the java.awt.* classes. The problem
is that Oracle's and OpenJDK's JVMs don't bracket their
"perform on main thread" native calls with "attach/detach
current thread" calls to the JVM.
Change-Id: I0859dc9e20f34bd0b43bb321898507764fd530fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157985
Tested-by: Jenkins
Reviewed-by: Patrick Luby
(cherry picked from commit a0eee8e56b91324470bb0e15c6b8009cfc411335)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157961
diff --git a/stoc/Library_javavm.mk b/stoc/Library_javavm.mk
index e096565769f9..adcb49691ce1 100644
--- a/stoc/Library_javavm.mk
+++ b/stoc/Library_javavm.mk
@@ -31,4 +31,10 @@ $(eval $(call gb_Library_add_exception_objects,javavm,\
stoc/source/javavm/jvmargs \
))
+ifeq ($(OS),MACOSX)
+$(eval $(call gb_Library_use_system_darwin_frameworks,javavm,\
+CoreFoundation \
+))
+endif
+
# vim:set noet sw=4 ts=4:
diff --git a/stoc/source/javavm/javavm.cxx b/stoc/source/javavm/javavm.cxx
index 12bcc2c904b7..dc22107fbf84 100644
--- a/stoc/source/javavm/javavm.cxx
+++ b/stoc/source/javavm/javavm.cxx
@@ -79,6 +79,12 @@
#define TIMEZONE "MET"
#endif
+#ifdef MACOSX
+#include
+#include
+#include
+#endif
+
/* Within this implementation of the com.sun.star.java.JavaVirtualMachine
* service and com.sun.star.java.theJavaVirtualMachine singleton, the method
* com.sun.star.java.XJavaVM.getJavaVM relies on the following:
@@ -456,6 +462,15 @@ public:
explicit DetachCurrentThread(JavaVM * jvm): m_jvm(jvm) {}
~DetachCurrentThread() {
+#ifdef MACOSX
+// tdf#101376 don't detach thread if it is the main thread on macOS
+// On macOS, many AWT classes do their work on the main thread
+// deep in native methods in the java.awt.* classes. The problem
+// is that Oracle's and OpenJDK's JVMs don't bracket their
+// "perform on main thread" native calls with "attach/detach
+// current thread" calls to the JVM.
+if (CFRunLoopGetCurrent() != CFRunLoopGetMain())
+#endif
if (m_jvm->DetachCurrentThread() != 0) {
OSL_ASSERT(false);
}
[Libreoffice-bugs] [Bug 108263] Comment is duplicated after copying sheet to new document (see comment 8)
https://bugs.documentfoundation.org/show_bug.cgi?id=108263 m.a.riosv changed: What|Removed |Added CC||jens-libreoffice@spamfreema ||il.de --- Comment #18 from m.a.riosv --- *** Bug 157798 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157798] Duplicating worksheets duplicates comments in the workbook too
https://bugs.documentfoundation.org/show_bug.cgi?id=157798 m.a.riosv changed: What|Removed |Added Resolution|--- |DUPLICATE CC||miguelangelrv@libreoffice.o ||rg Status|UNCONFIRMED |RESOLVED --- Comment #1 from m.a.riosv --- *** This bug has been marked as a duplicate of bug 108263 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 36310] [EDITING]"Insert cross-reference" drag-n-drop mode for navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=36310 --- Comment #8 from loma...@gmail.com --- This feature would be more useful than inserting a link or a copy, so I am surprised that it wasn't the first thing invented for use with the drag and drop feature. Maybe the reason it hasn't been implemented is because of the question of what sort of cross-reference should be inserted. RGB's suggestion of popping up a menu after dragging is fine. Alternatively it could just use whatever format was last set in the cross-references window. Shame to see that this feature was requested over 12 years ago! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157800] New: The insert time and date function will use the current system time no matter when the entry was actually made.
https://bugs.documentfoundation.org/show_bug.cgi?id=157800 Bug ID: 157800 Summary: The insert time and date function will use the current system time no matter when the entry was actually made. Product: LibreOffice Version: 7.6.2.1 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mikefridle...@gmail.com Description: I keep a large running document, and often time and date stamp my entries. After installing LibreOffice 7.6.2.1, this happened, unlike with the previous current version. Specifically: I frequently edit documents that I like to time and date stamp in Writer for LibreOffice. I made a shortcut key combination, and when I used it, the time for each entry was reverted to the current time from the PC. Even though the actual time at the time of previous text entries was done at ITS current system time. My current workaround when editing is to use the toolbar button for field insertion, and have to manually specify that the insert field uses a fixed time or date entry. And I can't use a shortcut key combination. Steps to Reproduce: 1. Open a Writer document for editing. 2. Select insert time from a dialog. 3. Wait for an adequate time period to elapse. 4. Repeat the insert time function and then see what the previous time stamps read in the document. Actual Results: The current system time was put in the insert fields previously inserted. Expected Results: It should have inserted the current system time and left the previous insert time function fields at the time they were actually inserted. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.6.2.1 (X86_64) / LibreOffice Community Build ID: 56f7684011345957bbf33a7ee678afaf4d2ba333 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157729] Group comment threads in navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=157729
--- Comment #3 from loma...@gmail.com ---
(In reply to Heiko Tietze from comment #1)
> Please elaborate on the use case ("I want to achieve Foo by doing Bar and
> get stuck at Baz") and perhaps illustrate what you have in mind. I suspect
> the issue has been requested, so you could save time by browsing through bug
> 106179 resp. bug 107431.
>
> So far I get that you think "Many margin comments/notes are complicated to
> use", bug 38295.
The bugs you linked to are not helpful. The first own is a list of Calc comment
bugs. The second one has nothing in it except some spam comments. The third one
is talking about the display of comments in the comment margin, but I am
talking about the list of comments in the Navigator.
I did try searching for related bugs before I posted but I couldn't find
anything. The search was giving a lot of unrelated results though.
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 157729] Group comment threads in navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=157729
--- Comment #3 from loma...@gmail.com ---
(In reply to Heiko Tietze from comment #1)
> Please elaborate on the use case ("I want to achieve Foo by doing Bar and
> get stuck at Baz") and perhaps illustrate what you have in mind. I suspect
> the issue has been requested, so you could save time by browsing through bug
> 106179 resp. bug 107431.
>
> So far I get that you think "Many margin comments/notes are complicated to
> use", bug 38295.
The bugs you linked to are not helpful. The first own is a list of Calc comment
bugs. The second one has nothing in it except some spam comments. The third one
is talking about the display of comments in the comment margin, but I am
talking about the list of comments in the Navigator.
I did try searching for related bugs before I posted but I couldn't find
anything. The search was giving a lot of unrelated results though.
--
You are receiving this mail because:
You are on the CC list for the bug.
[Libreoffice-ux-advise] [Bug 157729] Group comment threads in navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=157729 --- Comment #2 from loma...@gmail.com --- I don't know what more to say. I am not talking about comments in the margins. I am talking about the Navigator (F5) in Writer, which lists Headings, Tables, Comments, etc. All the comments are listed in a flat list even though they may be comment threads (ie. One person makes a comment in the document and then people reply to that comment). Sometimes there can be several comments forming a conversation at one place in the document. It is unintuitive and a poor use of space to have all those reply comments displayed in the navigator at the same level as the original comments that start the conversations (threads). It makes it difficult to actually navigate the comments in the Navigator on a document with dozens or hundreds of comments. I guess in the Navigator you can see which comments are original and which ones are replies because the replies by default start with "Reply to ..." But in the Navigator view it would be better if that "Reply to..." text wasn't shown and the replies were just nested under the starting comment. It would actually be better, IMHO, if the comments in the Navigator started with the name of the commenter followed by a colon, but that is a separate enhancement request, I guess. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 157729] Group comment threads in navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=157729 --- Comment #2 from loma...@gmail.com --- I don't know what more to say. I am not talking about comments in the margins. I am talking about the Navigator (F5) in Writer, which lists Headings, Tables, Comments, etc. All the comments are listed in a flat list even though they may be comment threads (ie. One person makes a comment in the document and then people reply to that comment). Sometimes there can be several comments forming a conversation at one place in the document. It is unintuitive and a poor use of space to have all those reply comments displayed in the navigator at the same level as the original comments that start the conversations (threads). It makes it difficult to actually navigate the comments in the Navigator on a document with dozens or hundreds of comments. I guess in the Navigator you can see which comments are original and which ones are replies because the replies by default start with "Reply to ..." But in the Navigator view it would be better if that "Reply to..." text wasn't shown and the replies were just nested under the starting comment. It would actually be better, IMHO, if the comments in the Navigator started with the name of the commenter followed by a colon, but that is a separate enhancement request, I guess. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/source
sc/source/core/tool/interpr4.cxx |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit 3161a6c351a2f5f70c0420ee8cccf2eb23de1ecf Author: Eike Rathke AuthorDate: Mon Oct 16 20:35:13 2023 +0200 Commit: Eike Rathke CommitDate: Mon Oct 16 23:35:02 2023 +0200 Resolves: tdf#157797 Let GetCellValue() propagate previous error, if any Change-Id: I27ee8d19e4f45bef81e133c82ac17b825790208f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158064 Reviewed-by: Eike Rathke Tested-by: Jenkins diff --git a/sc/source/core/tool/interpr4.cxx b/sc/source/core/tool/interpr4.cxx index 0ac2e151f5cc..95dff9f1cc18 100644 --- a/sc/source/core/tool/interpr4.cxx +++ b/sc/source/core/tool/interpr4.cxx @@ -181,7 +181,9 @@ double ScInterpreter::GetCellValue( const ScAddress& rPos, ScRefCellValue& rCell FormulaError nErr = nGlobalError; nGlobalError = FormulaError::NONE; double nVal = GetCellValueOrZero(rPos, rCell); -if ( nGlobalError == FormulaError::NONE || nGlobalError == FormulaError::CellNoValue ) +// Propagate previous error, if any; nGlobalError==CellNoValue is not an +// error here, preserve previous error or non-error. +if (nErr != FormulaError::NONE || nGlobalError == FormulaError::CellNoValue) nGlobalError = nErr; return nVal; }
[Libreoffice-bugs] [Bug 157240] PRINTING text lines disappear (in fact become white) when printing in grayscale
https://bugs.documentfoundation.org/show_bug.cgi?id=157240 --- Comment #5 from mmtsuchi --- But, when I set text color to black (for example), I expected it to be black. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157484] Add UI to control personal information to be removed upon save
https://bugs.documentfoundation.org/show_bug.cgi?id=157484 Balázs Varga (allotropia) changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |balazs.varga...@gmail.com |desktop.org | Status|UNCONFIRMED |ASSIGNED Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 157484] Add UI to control personal information to be removed upon save
https://bugs.documentfoundation.org/show_bug.cgi?id=157484 Balázs Varga (allotropia) changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |balazs.varga...@gmail.com |desktop.org | Status|UNCONFIRMED |ASSIGNED Ever confirmed|0 |1 -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-ux-advise] [Bug 157482] Turn Security Warnings popup windows into infobars
https://bugs.documentfoundation.org/show_bug.cgi?id=157482 Balázs Varga (allotropia) changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 116885] [META] Privacy and data security issues
https://bugs.documentfoundation.org/show_bug.cgi?id=116885 Bug 116885 depends on bug 157482, which changed state. Bug 157482 Summary: Turn Security Warnings popup windows into infobars https://bugs.documentfoundation.org/show_bug.cgi?id=157482 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: cui/source include/sfx2 include/unotools sfx2/source
cui/source/factory/dlgfact.cxx |6 ++-
cui/source/factory/dlgfact.hxx |3 -
include/sfx2/objsh.hxx |2 -
include/sfx2/sfxdlg.hxx |2 -
include/sfx2/sfxsids.hrc |1
include/sfx2/strings.hrc |5 --
include/sfx2/viewfrm.hxx |2 +
include/unotools/securityoptions.hxx |2 +
sfx2/source/appl/appserv.cxx |8 +++-
sfx2/source/appl/appuno.cxx |7 ++-
sfx2/source/dialog/infobar.cxx |8
sfx2/source/doc/objserv.cxx | 69 +++
sfx2/source/doc/objstor.cxx | 29 +++---
sfx2/source/view/viewfrm.cxx | 40
sfx2/source/view/viewprn.cxx |3 -
sfx2/source/view/viewsh.cxx | 10 ++---
16 files changed, 116 insertions(+), 81 deletions(-)
New commits:
commit 1f440348eb0892fd2c9597806d87b5fe9d60d49a
Author: Balazs Varga
AuthorDate: Tue Oct 10 21:55:42 2023 +0200
Commit: Balazs Varga
CommitDate: Mon Oct 16 23:18:56 2023 +0200
tdf#157482 UI: Turn Security Warnings popup windows into infobars
In case of all the 4 security warnings we will have a new infobar warning
dialog message with an infobar button which can open the security windows
option settings and we can set which security issues should warn us, and
also
which security infos we want to remove. (etc after saving)
TODO: If the directly the file dialog window pop up the Infobar message
will only
update after closing the file dialog window. That should be fixed later.
Change-Id: Idf0f728fd40089d3691f8f044d3718a4e0d99cad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157797
Tested-by: Jenkins
Reviewed-by: Balazs Varga
diff --git a/cui/source/factory/dlgfact.cxx b/cui/source/factory/dlgfact.cxx
index 086fd01c5af3..63bfdbddbe39 100644
--- a/cui/source/factory/dlgfact.cxx
+++ b/cui/source/factory/dlgfact.cxx
@@ -854,16 +854,18 @@ VclPtr
AbstractDialogFactory_Impl::CreateVclDialog(weld::Wind
}
VclPtr
AbstractDialogFactory_Impl::CreateFrameDialog(weld::Window* pParent, const
Reference< frame::XFrame >& rxFrame,
-sal_uInt32 nResId, const OUString& rParameter )
+sal_uInt32 nResId, sal_uInt16 nPageId, const OUString& rParameter)
{
std::unique_ptr xDlg;
if (SID_OPTIONS_TREEDIALOG == nResId || SID_OPTIONS_DATABASES == nResId)
{
// only activate last page if we don't want to activate a special page
-bool bActivateLastSelection = ( nResId != SID_OPTIONS_DATABASES &&
rParameter.isEmpty() );
+bool bActivateLastSelection = ( nResId != SID_OPTIONS_DATABASES &&
rParameter.isEmpty() && !nPageId);
xDlg = std::make_unique(pParent, rxFrame,
bActivateLastSelection);
if ( nResId == SID_OPTIONS_DATABASES )
xDlg->ActivatePage(SID_SB_DBREGISTEROPTIONS);
+else if (nPageId)
+xDlg->ActivatePage(nPageId);
else if ( !rParameter.isEmpty() )
xDlg->ActivatePage( rParameter );
}
diff --git a/cui/source/factory/dlgfact.hxx b/cui/source/factory/dlgfact.hxx
index 38ca4beded0a..b57fe2995718 100644
--- a/cui/source/factory/dlgfact.hxx
+++ b/cui/source/factory/dlgfact.hxx
@@ -439,8 +439,7 @@ public:
const
SfxItemSet& rAttr,
const
css::uno::Reference< css::frame::XFrame >& rFrame) override;
virtual VclPtrCreateFrameDialog(weld::Window*
pParent, const css::uno::Reference< css::frame::XFrame >& rxFrame,
- sal_uInt32 nResId,
- const OUString&
rParameter ) override;
+ sal_uInt32 nResId,
sal_uInt16 nPageId, const OUString& rParameter) override;
virtual VclPtr CreateAutoCorrTabDialog(weld::Window*
pParent, const SfxItemSet* pAttrSet) override;
virtual VclPtr
CreateCustomizeTabDialog(weld::Window* pParent,
const SfxItemSet* pAttrSet,
diff --git a/include/sfx2/objsh.hxx b/include/sfx2/objsh.hxx
index 7e5cb97827a6..ea2596658a5d 100644
--- a/include/sfx2/objsh.hxx
+++ b/include/sfx2/objsh.hxx
@@ -440,7 +440,7 @@ public:
virtual boolPrepareClose(bool bUI = true);
virtual HiddenInformation GetHiddenInformationState( HiddenInformation
nStates );
-sal_Int16 QueryHiddenInformation( HiddenWarningFact
eFact, weld::Window* pParent );
+voidQueryHiddenInformation( HiddenWarningFact
eFact );
boolIsSecurityOptOpenReadOnly() const;
voidSetSecurityOptOpenReadOnly( bool bOpenReadOnly
);
diff --git a/include/sfx2/sfxdlg.hxx b/include/sfx2/sfxdlg.hxx
index
[Libreoffice-ux-advise] [Bug 157482] Turn Security Warnings popup windows into infobars
https://bugs.documentfoundation.org/show_bug.cgi?id=157482 Commit Notification changed: What|Removed |Added Whiteboard||target:24.2.0 -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-ux-advise] [Bug 157482] Turn Security Warnings popup windows into infobars
https://bugs.documentfoundation.org/show_bug.cgi?id=157482 --- Comment #11 from Commit Notification --- Balazs Varga committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1f440348eb0892fd2c9597806d87b5fe9d60d49a tdf#157482 UI: Turn Security Warnings popup windows into infobars It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 157791] footer display problem
https://bugs.documentfoundation.org/show_bug.cgi?id=157791 m.a.riosv changed: What|Removed |Added Resolution|FIXED |NOTABUG -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157517] possible regression in PDF/UA export: PDF/UA identifier missing when PDF/A also used
https://bugs.documentfoundation.org/show_bug.cgi?id=157517 --- Comment #12 from peter.wy...@pdfa.org --- Created attachment 190246 --> https://bugs.documentfoundation.org/attachment.cgi?id=190246=edit PDF/UA Reference Suite example - complies to both PDF/A and PDF/UA-1 PDF/UA Reference Suite example - complies to both PDF/A and PDF/UA-1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157517] possible regression in PDF/UA export: PDF/UA identifier missing when PDF/A also used
https://bugs.documentfoundation.org/show_bug.cgi?id=157517 --- Comment #11 from peter.wy...@pdfa.org --- I asked the VeraPDF team and this is what they said: * Attachment 189889 has PDF/A identification XMP, but no PDF/UA identification XMP => passes PDF/A validation (veraPDF), but doesn’t pass PDF/UA validation (both veraPDF and PAC2021) * Attachment 189890 has both PDF/A and PDF/UA identification XMPs, BUT has no extension schema for PDF/UA identification => fails PDF/A validation because it uses metadata property “pdfuaid:part” not defined nor in predefined in XMP specs, neither in any embedded extension schemas. Passes PDF/UA validation (both veraPDF and PAC2021). The main issue is that with some combination of version and settings LibreOffice adds both PDF/A and PDF/UA identification XMPs but fails to add the extension schema for pdfuaid properties required for PDF/A compliance. I added an attachment which is one of the files from PDF/UA reference suite, which complies to both PDF/A-2A and PDF/UA-1 and in particular contains the necessary XMP extension schema. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157703] FILESAVE PDF: Since LO 7.6.0 Beta1, Numbered headings result to a Acrobat / PAC2021 "Lbl / LBody" errors
https://bugs.documentfoundation.org/show_bug.cgi?id=157703 Gabor Kelemen (allotropia) changed: What|Removed |Added CC||kelem...@ubuntu.com Keywords||bibisected, bisected --- Comment #4 from Gabor Kelemen (allotropia) --- This broke first in 7.6 with: https://git.libreoffice.org/core/+log/d8de2dc3c55a9013a71167c8058a333e7221a6a0 author Tomaž Vajngerl Sat Jan 28 18:43:51 2023 +0900 committer Tomaž VajngerlWed Feb 01 08:41:30 2023 + xmloff: import of theme structure + import/export/round-trip tests Before this, the PAC did not complain about the PDF/UA PDFs structure. But at this commit Writer started to crash at opening the example file, both in UI mode and with --convert-to pdf. This changed again in commit: https://git.libreoffice.org/core/+/4f347ebabad6355014889f0a81b107dc774590fe author Tomaž Vajngerl Sat Feb 25 19:12:23 2023 +0900 committer Tomaž VajngerlSat Apr 08 07:56:19 2023 +0200 use shared_ptr for model::Theme instead of unique_ptr At this the file can be opened, but the PDF structure is invalid according to PAC. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157785] The font colour of the text in cells is not changed in the editing mode
https://bugs.documentfoundation.org/show_bug.cgi?id=157785 --- Comment #3 from m.a.riosv --- Please, @Stephane, test in Safe Mode. I'm able to reproduce with 7.5.8 with a clean profile. In this case if I delete in the options the Light Theme then it works. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 116412] Bundled python fails to import bz2 on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=116412 --- Comment #24 from elmau --- Fix it, in: Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 2b8b6ced7c67e6a56f06b02e92f0555a796f3b16 CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded Very thanks. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156821] active tab in tabbed dialog box unreadable in dark mode (white font on white background) with macOS System Preference > Accessibility > Display > Increase Contrast enab
https://bugs.documentfoundation.org/show_bug.cgi?id=156821 Stéphane Guillou (stragu) changed: What|Removed |Added Version|24.2.0.0 alpha0+ Master |7.6.0.3 release CC||stephane.guillou@libreoffic ||e.org Whiteboard| QA:needsComment| Status|UNCONFIRMED |NEW Keywords||accessibility Ever confirmed|0 |1 --- Comment #4 from Stéphane Guillou (stragu) --- Thanks Steve. Confirmed via duplicate. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156864] Active tab/button is unreadable on Mac with Increase Contrast enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=156864 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Stéphane Guillou (stragu) --- Thanks Smurf. This was already reported in bug 156821 so marking as duplicate. *** This bug has been marked as a duplicate of bug 156821 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156821] active tab in tabbed dialog box unreadable in dark mode (white font on white background) with macOS System Preference > Accessibility > Display > Increase Contrast enab
https://bugs.documentfoundation.org/show_bug.cgi?id=156821 Stéphane Guillou (stragu) changed: What|Removed |Added CC||pfat...@uchicago.edu --- Comment #3 from Stéphane Guillou (stragu) --- *** Bug 156864 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157497] can't open files since updated to 7.5.7.1: "this file has been locked by another user"
https://bugs.documentfoundation.org/show_bug.cgi?id=157497 --- Comment #20 from Julien Nabet --- (In reply to Stéphane Guillou (stragu) from comment #17) > Thanks for checking, Frank. I'll close as "Not our bug" then, and > consolidate with other similar reports. Something to report to AVG somehow. > > Others copied in, please let us know if the issue is not actually related to > AVG (Other antivirus, or other problem entirely). Thanks! AVG antivirus comes from AVG Technologies, https://en.wikipedia.org/wiki/AVG_Technologies indicates: "Fate Merged into Avast, brand still used" So for the moment, one antivirus impacted so could be indeed an Avast/AVG pb. Hope no other antivirus (not related to Avast/AVG) impacted since it would mean it could finally be an LO pb. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157497] can't open files since updated to 7.5.7.1: "this file has been locked by another user"
https://bugs.documentfoundation.org/show_bug.cgi?id=157497 Stéphane Guillou (stragu) changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=15 | |7545| CC||06jy...@gmail.com --- Comment #19 from Stéphane Guillou (stragu) --- *** Bug 157545 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157545] LibreOffice 7.5.7 - All files read-only ...
https://bugs.documentfoundation.org/show_bug.cgi?id=157545 Stéphane Guillou (stragu) changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=15 | |7497| Resolution|WORKSFORME |DUPLICATE --- Comment #8 from Stéphane Guillou (stragu) --- *** This bug has been marked as a duplicate of bug 157497 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157545] LibreOffice 7.5.7 - All files read-only ...
https://bugs.documentfoundation.org/show_bug.cgi?id=157545 Stéphane Guillou (stragu) changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=15 | |7506| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157497] can't open files since updated to 7.5.7.1: "this file has been locked by another user"
https://bugs.documentfoundation.org/show_bug.cgi?id=157497 Stéphane Guillou (stragu) changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=15 | |7506| CC||jeg...@dencshaza.hu --- Comment #18 from Stéphane Guillou (stragu) --- *** Bug 157506 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157506] locked file
https://bugs.documentfoundation.org/show_bug.cgi?id=157506 Stéphane Guillou (stragu) changed: What|Removed |Added Resolution|WORKSFORME |DUPLICATE See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=15 | |7545, | |https://bugs.documentfounda | |tion.org/show_bug.cgi?id=15 | |7497| --- Comment #8 from Stéphane Guillou (stragu) --- *** This bug has been marked as a duplicate of bug 157497 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157497] can't open files since updated to 7.5.7.1: "this file has been locked by another user"
https://bugs.documentfoundation.org/show_bug.cgi?id=157497 Stéphane Guillou (stragu) changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |NOTOURBUG --- Comment #17 from Stéphane Guillou (stragu) --- Thanks for checking, Frank. I'll close as "Not our bug" then, and consolidate with other similar reports. Something to report to AVG somehow. Others copied in, please let us know if the issue is not actually related to AVG (Other antivirus, or other problem entirely). Thanks! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157750] Individual image saved as PDF creates 0-byte file
https://bugs.documentfoundation.org/show_bug.cgi?id=157750 Julien Nabet changed: What|Removed |Added CC|serval2...@yahoo.fr | --- Comment #5 from Julien Nabet --- JPG a raster format saved in a vector graphic data type (here PDF), I don't know at all what should be done here. Of course, feel free to revert my patch if you feel like. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/core/edit/eddel.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 2247b00230e479e63ab996d4e1694b1d74aeba81
Author: Mike Kaganski
AuthorDate: Mon Oct 16 20:04:10 2023 +0300
Commit: Mike Kaganski
CommitDate: Mon Oct 16 22:06:04 2023 +0200
Simplify a bit
Non-negative nCommentPos implies non-empty selection.
Change-Id: Id3e5701fbddca3159d81513d8c7d54816e45e4c2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158060
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sw/source/core/edit/eddel.cxx b/sw/source/core/edit/eddel.cxx
index 989cddfd3a28..9eb51da617b1 100644
--- a/sw/source/core/edit/eddel.cxx
+++ b/sw/source/core/edit/eddel.cxx
@@ -382,12 +382,12 @@ bool SwEditShell::ReplaceKeepComments( const OUString&
rNewStr)
OUString aSelectedText = pCursor->GetText();
sal_Int32 nCommentPos(aSelectedText.lastIndexOf(CH_TXTATR_INWORD));
// go sure that we have a valid selection and a comment has been
found
-while((nCommentPos > -1) && (aSelectedText.getLength() > 0) &&
(pCursor->HasMark()))
+while (nCommentPos > -1)
{
// select the part of the text after the last found comment
// selection start:
pCursor->GetPoint()->AdjustContent(nCommentPos + 1);
-// selection end ist left where it is -> will be adjusted
later on
+// selection end is left where it is -> will be adjusted later
on
// delete the part of the word after the last found comment
Replace(OUString(), false);
// put the selection start back to the beginning of the word
[Libreoffice-bugs] [Bug 157287] Cross-reference a formula does not work since 7.6x
https://bugs.documentfoundation.org/show_bug.cgi?id=157287 Matti Tyrväinen changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |ma...@uef.fi |desktop.org | --- Comment #11 from Matti Tyrväinen --- > The expand or not expand decision is hard to win, there will be always a > situation where the old behavior was helping some use-case we forgot about. > So restroing the old refmark behavior for now looks like a good idea. And the > next person who wants to change this can now be aware of this catch, to do > better. Thanks. To clarify, the problem isn't whether the behavior helps a use-case, but whether it breaks existing functionality whose implementation depends on the old behavior. I feel this distinction between code changes' effect on UX, and their effect on other code, is worth stressing as their solutions differ. While both can be fixed by restoring the old behavior, implementation bugs can also be fixed by changing the implementation (eg. moving UpdateFieldContent into the object's scope) while workflow-breaking behavior changes would require changing the workflow. The new behavior should actually help in this use-case, as expanding the refmark in the cell by typing also stops it from updating, but until someone reworks the implementation behind the functionality used here, I agree that reverting it is appropriate. > Matti, please submit the patch on gerrit Done: https://gerrit.libreoffice.org/c/core/+/158059 Apologies for spamming Jenkins, couldn't test locally due to bump in GCC's required version. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155865] EDITING: Crash in vtableCall
https://bugs.documentfoundation.org/show_bug.cgi?id=155865 --- Comment #16 from Julien Nabet --- Marc: please don't send an email in private (yours had been considered as a spam, hopefully I check the content of spam folder). So you indicated: " after 3 months I installed the newest daily build and now the bug is back again. Version: 24.2.0.0.alpha0+ (AARCH64) / LibreOffice Community Build ID: adcde78935fb8ca2b93322aa3a558d0b3ccdbfad CPU threads: 8; OS: Windows 10.0 Build 22621; UI render: default; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: threaded What should we do now? Open a new bug report? But I don't know how to create a crash report as it was automatically done in Version 7.4.7.2 - because the Development-Version: 24.2.0.0.alpha0+ just crashes and there is no crash report assistant any more." " Several things: 1) 24.2 is a dev version but it's ok if you want to test it before the release. 2) try https://wiki.documentfoundation.org/QA/FirstSteps 3) if you still got a crash, you can retrieve a backtrace by following https://wiki.documentfoundation.org/QA/BugReport/Debug_Information#Windows:_How_to_get_a_backtrace (it requires a bit of time above all for the first time when you must install some extra components). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156114] UNO commands / menu entries to enable PS/CS spotlight
https://bugs.documentfoundation.org/show_bug.cgi?id=156114 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157497] can't open files since updated to 7.5.7.1: "this file has been locked by another user"
https://bugs.documentfoundation.org/show_bug.cgi?id=157497 --- Comment #16 from Frank --- avg is affecting the files. after restarting and updating computer turned avg off and all files previously affected opened. When I turn avg back on files in document folder become read only. files not in document folder open normally. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/core/layout/ftnfrm.cxx |9 -
1 file changed, 4 insertions(+), 5 deletions(-)
New commits:
commit 2b8b6ced7c67e6a56f06b02e92f0555a796f3b16
Author: Mike Kaganski
AuthorDate: Mon Oct 16 20:05:42 2023 +0300
Commit: Mike Kaganski
CommitDate: Mon Oct 16 20:41:05 2023 +0200
Simplify a bit
Change-Id: Ic621da194d92e3a4202c47ec4828272e8102a146
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158061
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sw/source/core/layout/ftnfrm.cxx b/sw/source/core/layout/ftnfrm.cxx
index 78d25949c91b..4baed772787b 100644
--- a/sw/source/core/layout/ftnfrm.cxx
+++ b/sw/source/core/layout/ftnfrm.cxx
@@ -2558,9 +2558,9 @@ SwTwips SwFootnoteBossFrame::GetVarSpace() const
if( pBody )
{
SwRectFnSet aRectFnSet(this);
+nRet = aRectFnSet.GetHeight(pBody->getFrameArea());
if( IsInSct() )
{
-nRet = 0;
SwTwips nTmp = aRectFnSet.YDiff( aRectFnSet.GetPrtTop(*pBody),
aRectFnSet.GetTop(getFrameArea()) );
const SwSectionFrame* pSect = FindSctFrame();
@@ -2594,12 +2594,11 @@ SwTwips SwFootnoteBossFrame::GetVarSpace() const
}
}
}
-if( nTmp < nRet )
-nRet = nTmp;
+if( nTmp < 0 )
+nRet += nTmp;
}
else
-nRet = - aRectFnSet.GetHeight(pPg->getFramePrintArea())/5;
-nRet += aRectFnSet.GetHeight(pBody->getFrameArea());
+nRet -= aRectFnSet.GetHeight(pPg->getFramePrintArea())/5;
if( nRet < 0 )
nRet = 0;
}
[Libreoffice-bugs] [Bug 157423] No entry possible directly after opening a CALC-file
https://bugs.documentfoundation.org/show_bug.cgi?id=157423 Kira Tubo changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG --- Comment #8 from Kira Tubo --- Thanks for confirming Roland. I'll go ahead and close the ticket. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/source sd/source sw/source
sc/source/ui/view/tabvwsh4.cxx |6 ++
sd/source/ui/view/drviewsa.cxx | 10 ++
sw/source/uibase/uiview/view.cxx |8
3 files changed, 24 insertions(+)
New commits:
commit e99936639379acfe7949b6b77d3b401990f50dde
Author: Paris Oplopoios
AuthorDate: Thu Jul 20 19:49:10 2023 +0300
Commit: Caolán McNamara
CommitDate: Mon Oct 16 20:12:39 2023 +0200
Execute notifyViewRenderState on view constructor
notifyViewRenderState should be executed as soon as a view is created in
order to give a view id to the client
Change-Id: I31b7e61599f546bd5ec134775e6235633a6526f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154681
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Paris Oplopoios
(cherry picked from commit 6c6bb1d434d5c0be2f71470483f3ce56f5210e01)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154709
Tested-by: Jenkins
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/sc/source/ui/view/tabvwsh4.cxx b/sc/source/ui/view/tabvwsh4.cxx
index d82c7e15c11c..c5fe69007fcc 100644
--- a/sc/source/ui/view/tabvwsh4.cxx
+++ b/sc/source/ui/view/tabvwsh4.cxx
@@ -1802,6 +1802,12 @@ ScTabViewShell::ScTabViewShell( SfxViewFrame& rViewFrame,
pInputHdl->SetMode(SC_INPUT_NONE);
}
}
+
+if (comphelper::LibreOfficeKit::isActive())
+{
+ScModelObj* pModel =
comphelper::getFromUnoTunnel(GetCurrentDocument());
+SfxLokHelper::notifyViewRenderState(this, pModel);
+}
}
ScTabViewShell::~ScTabViewShell()
diff --git a/sd/source/ui/view/drviewsa.cxx b/sd/source/ui/view/drviewsa.cxx
index 2868c38d6c90..9bc5c0030f76 100644
--- a/sd/source/ui/view/drviewsa.cxx
+++ b/sd/source/ui/view/drviewsa.cxx
@@ -25,6 +25,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -64,7 +65,10 @@
#include
#include
#include
+#include
#include
+#include
+#include
#include
#include
@@ -130,6 +134,12 @@ DrawViewShell::DrawViewShell( ViewShellBase&
rViewShellBase, vcl::Window* pParen
ConfigureAppBackgroundColor();
SD_MOD()->GetColorConfig().AddListener(this);
maViewOptions.mnDocBackgroundColor =
SD_MOD()->GetColorConfig().GetColorValue(svtools::DOCCOLOR).nColor;
+
+if (comphelper::LibreOfficeKit::isActive())
+{
+SdXImpressDocument* pModel =
comphelper::getFromUnoTunnel(rViewShellBase.GetCurrentDocument());
+SfxLokHelper::notifyViewRenderState(, pModel);
+}
}
DrawViewShell::~DrawViewShell()
diff --git a/sw/source/uibase/uiview/view.cxx b/sw/source/uibase/uiview/view.cxx
index 85138778bf65..3bad54a839b8 100644
--- a/sw/source/uibase/uiview/view.cxx
+++ b/sw/source/uibase/uiview/view.cxx
@@ -87,6 +87,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -106,6 +107,7 @@
#include
#include
+#include
#include
#include
#include
@@ -1113,6 +1115,12 @@ SwView::SwView(SfxViewFrame& _rFrame, SfxViewShell*
pOldSh)
m_aBringToAttentionBlinkTimer.SetInvokeHandler(
LINK(this, SwView, BringToAttentionBlinkTimerHdl));
m_aBringToAttentionBlinkTimer.SetTimeout(350);
+
+if (comphelper::LibreOfficeKit::isActive())
+{
+SwXTextDocument* pModel =
comphelper::getFromUnoTunnel(GetCurrentDocument());
+SfxLokHelper::notifyViewRenderState(this, pModel);
+}
}
SwViewGlueDocShell::SwViewGlueDocShell(SwView& rView, SwDocShell& rDocSh)
[Libreoffice-commits] core.git: sw/source
sw/source/core/text/pormulti.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 00904f994a2f03638ec7f284396aeb730746e68d
Author: Caolán McNamara
AuthorDate: Mon Oct 16 17:01:59 2023 +0100
Commit: Caolán McNamara
CommitDate: Mon Oct 16 20:11:36 2023 +0200
ofz#63295 Null-dereference READ
Change-Id: Ib8bfa814099c1c1f3d65b18026ea812c80b6e9c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158058
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sw/source/core/text/pormulti.cxx b/sw/source/core/text/pormulti.cxx
index 2067adcfc155..7a2e8c44c653 100644
--- a/sw/source/core/text/pormulti.cxx
+++ b/sw/source/core/text/pormulti.cxx
@@ -2505,7 +2505,7 @@ SwLinePortion* SwTextFormatter::MakeRestPortion( const
SwLineLayout* pLine,
pTmp = new SwDoubleLinePortion( *pCreate, nMultiPos );
else if( pHelpMulti->IsBidi() )
pTmp = new SwBidiPortion( nMultiPos, pCreate->nLevel );
-else if (IsIncompleteRuby(*pHelpMulti))
+else if (IsIncompleteRuby(*pHelpMulti) && pCreate->pAttr)
{
TextFrameIndex nRubyOffset = static_cast(pHelpMulti)->GetRubyOffset();
pTmp = new SwRubyPortion( *pCreate, *GetInfo().GetFont(),
[Libreoffice-bugs] [Bug 123412] Base: Unwanted disconnection from Firebird data source error message "connection shutdown caused by isc_service_attach"
https://bugs.documentfoundation.org/show_bug.cgi?id=123412 --- Comment #55 from Tim --- New observation: The bug happens with any of my several data base, and seems it just seems to happen after a certain amount of time, and has nothing to do with edition or modifying data in the data base. After a day doing no change in the data base it happens. During that time I've been working with Writer, Spreadsheet and Presentation files, but not with daa bases. Although the data base is on my laptops hard disc, I also have running a Synology Drive, and I've seen that just opening the data base the file appears in the list as reacently modifyed. Perhaps that has something to do with the issue, as the errior message is about connection to the data source?: The connection to the data source "Miembros_Contactos" could not be established. firebird_sdbc error: *connection shutdown caused by 'isc_service_attach' Error code: 1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157783] FILESAVE PPTX: graphic elements change color on save/reload cycle
https://bugs.documentfoundation.org/show_bug.cgi?id=157783 Regina Henschel changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||7742 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157742] FILESAVE PPTX: Green background from copy slide turns black
https://bugs.documentfoundation.org/show_bug.cgi?id=157742 Regina Henschel changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||7783 CC||rb.hensc...@t-online.de -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157790] White triangles appear around a moving object (instead of the background)
https://bugs.documentfoundation.org/show_bug.cgi?id=157790 BogdanB changed: What|Removed |Added Keywords|bibisectRequest |bibisected, bisected CC||buzea.bog...@libreoffice.or ||g, noelgran...@gmail.com --- Comment #3 from BogdanB --- c21a1c45e2403119c90af25cdb5350f978d5c93b is the first bad commit commit c21a1c45e2403119c90af25cdb5350f978d5c93b Author: Jenkins Build User Date: Tue Jul 25 09:06:10 2023 +0200 source sha:81994cb2b8b32453a92bcb011830fcb884f22ff3 source sha:81994cb2b8b32453a92bcb011830fcb884f22ff3 instdir/program/libchartcontrollerlo.so | Bin 3810384 -> 3810384 bytes instdir/program/libcppcanvaslo.so | Bin 382552 -> 382552 bytes instdir/program/libcuilo.so | Bin 5066680 -> 5066680 bytes instdir/program/libdrawinglayerlo.so| Bin 2067536 -> 2067632 bytes instdir/program/libeditenglo.so | Bin 3336888 -> 3336888 bytes instdir/program/libfrmlo.so | Bin 4274440 -> 4274400 bytes instdir/program/libmsfilterlo.so| Bin 1063760 -> 1063760 bytes instdir/program/libsclo.so | Bin 22502464 -> 22502464 bytes instdir/program/libsdlo.so | Bin 10531352 -> 10531352 bytes instdir/program/libsduilo.so| Bin 2135776 -> 2135776 bytes instdir/program/libsfxlo.so | Bin 7755888 -> 7755888 bytes instdir/program/libslideshowlo.so | Bin 2904968 -> 2905016 bytes instdir/program/libsmlo.so | Bin 2290704 -> 2290704 bytes instdir/program/libspllo.so | Bin 96136 -> 96136 bytes instdir/program/libsvtlo.so | Bin 3063720 -> 3063720 bytes instdir/program/libsvxcorelo.so | Bin 12298416 -> 12298464 bytes instdir/program/libsvxlo.so | Bin 5529544 -> 5529544 bytes instdir/program/libswlo.so | Bin 22729480 -> 22729480 bytes instdir/program/libswuilo.so| Bin 2985632 -> 2985640 bytes instdir/program/libtklo.so | Bin 7023960 -> 7024008 bytes instdir/program/libvclcanvaslo.so | Bin 1014736 -> 1014736 bytes instdir/program/libvcllo.so | Bin 20328320 -> 20332568 bytes instdir/program/libvclplug_gtk3lo.so| Bin 2748840 -> 2748840 bytes instdir/program/libvclplug_qt5lo.so | Bin 2495136 -> 2495032 bytes instdir/program/setuprc | 2 +- instdir/program/versionrc | 2 +- 26 files changed, 2 insertions(+), 2 deletions(-) author Noel Grandin 2021-04-16 20:33:10 +0200 committer Noel Grandin 2023-07-25 08:38:12 +0200 commit 81994cb2b8b32453a92bcb011830fcb884f22ff3 (patch) treeae1750e92421ad2e0ec3f50351c3be6581841598 parent dabedcaf27b0af1e38a611b8d8e48444f848e01d (diff) Convert internal vcl bitmap formats transparency->alpha (II) (Second attempt at landing this) Image formats and graphics APIs use alpha, not transparency, so change our internal formats and data structures to work directly with alpha, so we don't need to modify data before we push it to graphics APIs. Add a couple of new Color constants to make the intention of the vcl code clearer. Notes (*) On macOS, tweaking the logic in CreateWithSalBitmapAndMask to more accurately reflect the requirements of the CGImageCreateWithMask function seems to fix some tests. (*) The vcl code does not properly support gradients with transparency. So the previous code was wrong, and this change is going to result in slightly different wrongness. Change-Id: I9e21c2e98d88ecfdc5f75db13bd17c38db98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114168 Tested-by: Jenkins Reviewed-by: Patrick Luby Reviewed-by: Noel Grandin -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157789] Comment size wrong behavior when zooming document
https://bugs.documentfoundation.org/show_bug.cgi?id=157789 BogdanB changed: What|Removed |Added Keywords|bibisectRequest |bibisected, bisected -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157789] Comment size wrong behavior when zooming document
https://bugs.documentfoundation.org/show_bug.cgi?id=157789 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g, noelgran...@gmail.com --- Comment #3 from BogdanB --- I'm getting this author Noel Grandin 2023-06-13 10:11:08 +0200 committer Caolán McNamara 2023-06-13 17:11:45 +0200 commit 8d18b5af883bb6b56e758801ee730a08bb88a8f5 (patch) treeea230e36ac2af38ae0a75660e1bec4bd86197e58 parent 0ea5dde060df7ef638fbd1f2efe6aa221033e69c (diff) speed up rendering annotatins, cache meta height shaves 2% off scrolling profile on a large word doc Change-Id: I283e3f99c1c385f3d20ea573d15ca59b4629c14d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152978 Tested-by: Jenkins Reviewed-by: Caolán McNamara It is possible to be connected to comments? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156114] UNO commands / menu entries to enable PS/CS spotlight
https://bugs.documentfoundation.org/show_bug.cgi?id=156114 --- Comment #2 from Jim Raykowski --- Created attachment 190244 --> https://bugs.documentfoundation.org/attachment.cgi?id=190244=edit demo of UNO commands and menu entries to enable PS and CS spotlight Had to think about this one for awhile :-) Here is a link to a patch that does this: https://gerrit.libreoffice.org/c/core/+/158055 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 116625] [META] Bugs where document modification status is wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=116625 Bug 116625 depends on bug 157776, which changed state. Bug 157776 Summary: "Save changes to document" appears even after just opening and closing and no edits https://bugs.documentfoundation.org/show_bug.cgi?id=157776 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 90486] [META] Chart bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=90486 Bug 90486 depends on bug 141892, which changed state. Bug 141892 Summary: The type of an embedded chart in Writer is missing https://bugs.documentfoundation.org/show_bug.cgi?id=141892 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: bin/gbuild-to-ide
bin/gbuild-to-ide | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
New commits:
commit f8be1b73847514bb8e2054dc6d8a62e00682ab78
Author: Michael Weghorn
AuthorDate: Mon Oct 16 14:39:42 2023 +0200
Commit: Michael Weghorn
CommitDate: Mon Oct 16 18:29:23 2023 +0200
qtcreator: Specify C++ std version using CONFIG qmake var
Extract the C++ standard version to use that is specified
by a `-std=` or `-std:` compiler flag,
and set that via "CONFIG += " in the .pro files
used by Qt Creator.
This makes the Clang Code Model use the correct mode
and no longer complain about `char8_t` after the
switch to C++20 in my Windows development setup
in Qt Creator:
> accessibletabbarpagelist.hxx:22:10: In included file: use of undeclared
identifier 'char8_t'
> stringutils.hxx:252:31: error occurred here
The previous way of specifying this via
`QMAKE_CXXFLAGS` as introduced in
commit 92c03d9bf644b0f10de52ce0da09f97056e46247
Author: Michael Weghorn
Date: Fri Jun 7 21:44:03 2019 +0200
qtcreator: Take over '-std=...' from CXXFLAGS
appears to not (no longer?) work at least with Qt Creator 11.0.3
on Windows.
On the contrary however, setting only `CONFIG` and
not `QMAKE_CXXFLAGS` causes the exact same problem
in my Linux setup.
Therefore, set both qmake variables.
Note that there is a specific set of accepted values
for the the `CONFIG` variable in .pro files [1],
but at least "c++20" and "c++latest" are accepted
and have the expected meaning, so that should be
fine for now.
[1] https://doc.qt.io/qt-6/qmake-variable-reference.html#config
Change-Id: Idc75b74300c7bdd0f6193fcfc1758b536728b887
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158053
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/bin/gbuild-to-ide b/bin/gbuild-to-ide
index b56cff8585ea..f428f451e990 100755
--- a/bin/gbuild-to-ide
+++ b/bin/gbuild-to-ide
@@ -1718,11 +1718,11 @@ class
QtCreatorIntegrationGenerator(IdeIntegrationGenerator):
if path:
headers_list.append(lopath(path))
-cxxflags_list = []
+cxxstdversionflag = ''
for cxxflag in lib.cxxflags:
# extract flag for C++ standard version
if cxxflag.startswith('-std'):
-cxxflags_list.append(cxxflag)
+cxxstdversionflag = cxxflag
# List all include paths
for hdir in (lib.include + lib.include_sys):
@@ -1749,14 +1749,14 @@ class
QtCreatorIntegrationGenerator(IdeIntegrationGenerator):
if lib_folder in self.data_libs:
self.data_libs[lib_folder]['sources'] |= set(sources_list)
self.data_libs[lib_folder]['headers'] |= set(headers_list)
-self.data_libs[lib_folder]['cxxflags'] |= set(cxxflags_list)
+self.data_libs[lib_folder]['cxxstdversionflag'] =
cxxstdversionflag
self.data_libs[lib_folder]['includepath'] |=
set(includepath_list)
self.data_libs[lib_folder]['defines'] |= set(defines_list)
else:
self.data_libs[lib_folder] = {
'sources': set(sources_list),
'headers': set(headers_list),
-'cxxflags': set(cxxflags_list),
+'cxxstdversionflag': cxxstdversionflag,
'includepath': set(includepath_list),
'defines': set(defines_list),
'loc': lib.location,
@@ -1779,7 +1779,7 @@ class
QtCreatorIntegrationGenerator(IdeIntegrationGenerator):
for lib_folder in subdirs_list:
sources_list = sorted(self.data_libs[lib_folder]['sources'])
headers_list = sorted(self.data_libs[lib_folder]['headers'])
-cxxflags_list = sorted(self.data_libs[lib_folder]['cxxflags'])
+cxxstdversionflag = self.data_libs[lib_folder]['cxxstdversionflag']
includepath_list =
sorted(self.data_libs[lib_folder]['includepath'])
defines_list = sorted(self.data_libs[lib_folder]['defines'])
lib_loc = self.data_libs[lib_folder]['loc']
@@ -1787,16 +1787,18 @@ class
QtCreatorIntegrationGenerator(IdeIntegrationGenerator):
sources = " \\\n".join(sources_list)
headers = " \\\n".join(headers_list)
-cxxflags = " \\\n".join(cxxflags_list)
includepath = " \\\n".join(includepath_list)
defines = " \\\n".join(defines_list)
+# strip '-std=' or '-std:' prefix
+assert(isinstance(cxxstdversionflag, str) and
cxxstdversionflag.startswith('-std'))
+cxxstdversion = cxxstdversionflag[5:]
# create .pro file
subdirs_meta_pro.append(lib_name)
[Libreoffice-commits] core.git: chart2/source xmloff/source
chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx | 15 ++
chart2/source/controller/inc/ChartDocumentWrapper.hxx |4 +
chart2/source/inc/ChartViewHelper.hxx | 14 +-
chart2/source/tools/ChartViewHelper.cxx | 10 +++-
xmloff/source/chart/SchXMLImport.cxx | 22
+-
5 files changed, 58 insertions(+), 7 deletions(-)
New commits:
commit f26bf09a0e93449ea85269a09a8a073a20903349
Author: Mike Kaganski
AuthorDate: Mon Oct 16 15:22:17 2023 +0300
Commit: Mike Kaganski
CommitDate: Mon Oct 16 18:27:49 2023 +0200
tdf#141892: Set chart view to dirty state after loading
Previously, ChartViewHelper::setViewToDirtyState was only called in
ChartModel::impl_notifyModifiedListeners during the load process of
inline charts; after commit 574eec9036c5f185b3572ba1e0ca9d111eb361dc,
the chart doesn't set its modified state when loading, and thus the
view did not get notified about the necessary updates.
This change introduces a hidden property in ChartDocumentWrapper,
named 'ODFImport_UpdateView', which is set in SchXMLImport dtor
to force the notification after the loading.
Change-Id: Id9d82f16d233d2172cd6808a8498822e13b21b21
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158051
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx
b/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx
index 70c9ace455b9..ea01ae000b65 100644
--- a/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx
+++ b/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx
@@ -19,6 +19,7 @@
#include
#include
+#include
#include
#include
#include
@@ -1366,6 +1367,20 @@ void ChartDocumentWrapper::_disposing( const
lang::EventObject& rSource )
m_xChartView.clear();
}
+// XPropertySet
+void SAL_CALL ChartDocumentWrapper::setPropertyValue(const OUString&
rPropertyName, const css::uno::Any& rValue)
+{
+if (rPropertyName == u"ODFImport_UpdateView")
+{
+// A hack used at load time to notify the view that it needs an update
+// See SchXMLImport::~SchXMLImport
+if (auto xChartModel = rValue.query())
+ChartViewHelper::setViewToDirtyState_UNO(xChartModel);
+return;
+}
+ChartDocumentWrapper_Base::setPropertyValue(rPropertyName, rValue);
+}
+
// WrappedPropertySet
Reference< beans::XPropertySet > ChartDocumentWrapper::getInnerPropertySet()
{
diff --git a/chart2/source/controller/inc/ChartDocumentWrapper.hxx
b/chart2/source/controller/inc/ChartDocumentWrapper.hxx
index 04f76d705b6b..a5bded3c8fb7 100644
--- a/chart2/source/controller/inc/ChartDocumentWrapper.hxx
+++ b/chart2/source/controller/inc/ChartDocumentWrapper.hxx
@@ -139,6 +139,10 @@ protected:
virtual std::vector< std::unique_ptr >
createWrappedProperties() override;
virtual css::uno::Reference< css::beans::XPropertySet >
getInnerPropertySet() override;
+// XPropertySet
+virtual void SAL_CALL setPropertyValue(const OUString& rPropertyName,
+ const css::uno::Any& rValue)
override;
+
private: //methods
void impl_resetAddIn();
diff --git a/chart2/source/inc/ChartViewHelper.hxx
b/chart2/source/inc/ChartViewHelper.hxx
index 06fef6a1ff9b..be70dd9fecb4 100644
--- a/chart2/source/inc/ChartViewHelper.hxx
+++ b/chart2/source/inc/ChartViewHelper.hxx
@@ -21,14 +21,22 @@
#include "charttoolsdllapi.hxx"
#include
+#include
+
+namespace com::sun::star::chart2
+{
+class XChartDocument;
+}
+
namespace chart
{
class ChartModel;
-class OOO_DLLPUBLIC_CHARTTOOLS ChartViewHelper
+namespace ChartViewHelper
{
-public:
-static void setViewToDirtyState(const rtl::Reference<::chart::ChartModel>&
xChartModel);
+OOO_DLLPUBLIC_CHARTTOOLS void setViewToDirtyState(const
rtl::Reference& xChartModel);
+OOO_DLLPUBLIC_CHARTTOOLS void
+setViewToDirtyState_UNO(const
css::uno::Reference& xChartModel);
};
} //namespace chart
diff --git a/chart2/source/tools/ChartViewHelper.cxx
b/chart2/source/tools/ChartViewHelper.cxx
index 183d28189531..8011da3c171c 100644
--- a/chart2/source/tools/ChartViewHelper.cxx
+++ b/chart2/source/tools/ChartViewHelper.cxx
@@ -21,8 +21,7 @@
#include
#include
-#include
-#include
+#include
#include
#include
@@ -51,6 +50,13 @@ void ChartViewHelper::setViewToDirtyState(const
rtl::Reference<::chart::ChartMod
DBG_UNHANDLED_EXCEPTION("chart2");
}
}
+
+void ChartViewHelper::setViewToDirtyState_UNO(
+const css::uno::Reference& xChartModel)
+{
+if (auto pChartModel = dynamic_cast(xChartModel.get()))
+setViewToDirtyState(rtl::Reference(pChartModel));
+}
} //namespace chart
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git
[Libreoffice-commits] core.git: 2 commits - chart2/inc chart2/source uitest/libreoffice
chart2/inc/ChartView.hxx |4 +--
chart2/source/view/main/ChartView.cxx | 36 +++---
uitest/libreoffice/connection.py |6 +++--
3 files changed, 39 insertions(+), 7 deletions(-)
New commits:
commit 6506279e3bed2284ce0ec9a0957a0201eb0d72ae
Author: Mike Kaganski
AuthorDate: Mon Oct 16 10:14:49 2023 +0300
Commit: Mike Kaganski
CommitDate: Mon Oct 16 18:27:40 2023 +0200
tdf#157776: Do not set chart and its parent modified when painting
When the chart is painted for the first time, its update may create
the initial set of objects, which used to set modified state after
loading documents.
Change-Id: Ie50ef34875440058020486192fe649b492e4baf9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158015
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/chart2/inc/ChartView.hxx b/chart2/inc/ChartView.hxx
index 9c80ba2ffb55..cbee98d8cb4a 100644
--- a/chart2/inc/ChartView.hxx
+++ b/chart2/inc/ChartView.hxx
@@ -115,7 +115,7 @@ public:
// ___ExplicitValueProvider___
virtual bool getExplicitValuesForAxis(
-rtl::Reference< ::chart::Axis > xAxis
+rtl::Reference< Axis > xAxis
, ExplicitScaleData& rExplicitScale
, ExplicitIncrementData& rExplicitIncrement ) override;
virtual rtl::Reference< SvxShape >
@@ -205,7 +205,7 @@ private: //member
css::uno::Reference< css::uno::XComponentContext> m_xCC;
-chart::ChartModel& mrChartModel;
+ChartModel& mrChartModel;
css::uno::Reference< css::lang::XMultiServiceFactory>
m_xShapeFactory;
diff --git a/chart2/source/view/main/ChartView.cxx
b/chart2/source/view/main/ChartView.cxx
index d499aae6f298..08aaeb69ffe1 100644
--- a/chart2/source/view/main/ChartView.cxx
+++ b/chart2/source/view/main/ChartView.cxx
@@ -75,6 +75,7 @@
#include
#include
#include
+#include
#include
@@ -112,12 +113,9 @@
#include
#include
-namespace com::sun::star::chart2 { class XChartDocument; }
-
namespace chart {
using namespace ::com::sun::star;
-using namespace ::com::sun::star::chart2;
using ::com::sun::star::uno::Reference;
using ::com::sun::star::uno::Sequence;
using ::com::sun::star::uno::Any;
@@ -1413,6 +1411,35 @@ void SAL_CALL ChartView::disposing( const
lang::EventObject& /* rSource */ )
{
}
+namespace
+{
+// Disables setting the chart's modified state, as well as its parent's (if
exists).
+// Painting a chart must not set these states.
+struct ChartModelDisableSetModified
+{
+ChartModel& mrChartModel;
+SfxObjectShell* mpParentShell;
+bool mbWasUnmodified;
+ChartModelDisableSetModified(ChartModel& rChartModel)
+: mrChartModel(rChartModel)
+,
mpParentShell(SfxObjectShell::GetShellFromComponent(rChartModel.getParent()))
+, mbWasUnmodified(!rChartModel.isModified())
+{
+if (mpParentShell && mpParentShell->IsEnableSetModified())
+mpParentShell->EnableSetModified(false);
+else
+mpParentShell = nullptr;
+}
+~ChartModelDisableSetModified()
+{
+if (mbWasUnmodified && mrChartModel.isModified())
+mrChartModel.setModified(false);
+if (mpParentShell)
+mpParentShell->EnableSetModified(true);
+}
+};
+}
+
void ChartView::impl_updateView( bool bCheckLockedCtrler )
{
if( !m_pDrawModelWrapper )
@@ -1443,6 +1470,9 @@ void ChartView::impl_updateView( bool bCheckLockedCtrler )
m_pDrawModelWrapper->lockControllers();
}
+// Rendering the chart must not set its (or its parent) modified status
+ChartModelDisableSetModified dontSetModified(mrChartModel);
+
//create chart view
{
m_bViewDirty = false;
commit be71e660fd29a714466bf041a6b9b394b9fdbf08
Author: Mike Kaganski
AuthorDate: Mon Oct 16 15:18:11 2023 +0300
Commit: Mike Kaganski
CommitDate: Mon Oct 16 18:27:32 2023 +0200
Fix UITests on Windows
... after commit 0d21e1075f0288a007cb427ce508d6fbbf8503dd (uitest:
add signal_handler function, 2023-10-04), which added handlers
unconditionally, for signals unavailable on Windows.
Change-Id: I8b177c4110f869781b2501ee6f15ae7ff4862a94
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158050
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/uitest/libreoffice/connection.py b/uitest/libreoffice/connection.py
index e3b76b4baf44..4f901130f223 100644
--- a/uitest/libreoffice/connection.py
+++ b/uitest/libreoffice/connection.py
@@ -10,6 +10,7 @@ import time
import traceback
import uuid
import os
+import platform
import signal
try:
@@ -37,8 +38,9 @@ class OfficeConnection:
If the connection method is path the instance will be created as a
new subprocess. If the connection method is connect the instance tries
to connect to an existing instance with the specified socket string """
-
[Libreoffice-bugs] [Bug 157799] Import of csv is insecure
https://bugs.documentfoundation.org/show_bug.cgi?id=157799 Mike Kaganski changed: What|Removed |Added Resolution|--- |NOTABUG Status|UNCONFIRMED |RESOLVED --- Comment #1 from Mike Kaganski --- Because your locale used dot as thousand separator; and you didn't mark the IP column as text - so the values that matched three-digit parts separated by thousand separators were recognized as numbers; while those that didn't match that pattern were imported as text. If a column represents what is not a number, then it should be explicitly marked so in the import dialog. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141892] The type of an embedded chart in Writer is missing
https://bugs.documentfoundation.org/show_bug.cgi?id=141892 Mike Kaganski changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com |desktop.org | --- Comment #11 from Mike Kaganski --- https://gerrit.libreoffice.org/c/core/+/158051 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157703] FILESAVE PDF: Since LO 7.6.0 Beta1, Numbered headings result to a Acrobat / PAC2021 "Lbl / LBody" errors
https://bugs.documentfoundation.org/show_bug.cgi?id=157703 raal changed: What|Removed |Added Ever confirmed|0 |1 CC||r...@post.cz Status|UNCONFIRMED |NEW Keywords||filter:pdf --- Comment #3 from raal --- Confirm in Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 9f44f9fad759dea644356b67b9cd0fab030e8b77 CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded VeraPDF checker: Specification: ISO 14289-1:2014, Clause: 7.2, Test number: 18 LBody element should be contained in LI element Failed 1 occurrences Hide SELBody parentStandardType == 'LI' root/document[0]/StructTreeRoot[0](19 0 obj PDStructTreeRoot)/K[0](4 0 obj SEDocument Document)/K[1](6 0 obj SELBody LBody) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157521] "Update available" bubble appears on wrong side of window
https://bugs.documentfoundation.org/show_bug.cgi?id=157521 Stéphane Guillou (stragu) changed: What|Removed |Added Blocks||103182 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103182 [Bug 103182] [META] GTK3-specific bugs -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103182 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||157521 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=157521 [Bug 157521] "Update available" bubble appears on wrong side of window -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157521] "Update available" bubble appears on wrong side of window
https://bugs.documentfoundation.org/show_bug.cgi?id=157521 --- Comment #2 from Stéphane Guillou (stragu) --- Created attachment 190243 --> https://bugs.documentfoundation.org/attachment.cgi?id=190243=edit screenshot of issue in LO 7.2.0.3 Looks like a gtk3-only issue. No issue in placement with gen VCL plugin. With gen, the tooltip of the button _is_ the speech bubble, and appears any time I hover over the button. With gtk3, the button tooltip is the stock tooltip look any button uses, and the speech bubble only appears the first time LO notifies of an update, misplaced. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157742] FILESAVE PPTX: Green background from copy slide turns black
https://bugs.documentfoundation.org/show_bug.cgi?id=157742 raal changed: What|Removed |Added Regression By||Tomaž Vajngerl Keywords|bibisectRequest |bibisected, bisected CC||qui...@gmail.com --- Comment #2 from raal --- This seems to have begun at the below commit in bibisect repository/OS linux-64-7.6. Adding Cc: to Tomaž Vajngerl ; Could you possibly take a look at this one? Thanks 34c4a1709bd20127d98085e08b5c031fb6e613d9 is the first bad commit commit 34c4a1709bd20127d98085e08b5c031fb6e613d9 Author: Jenkins Build User Date: Mon Apr 24 23:52:55 2023 +0200 source sha:c3f7720ff13c34b9cf2c90d9c9b6dcc3d8f4c7a5 149363: oox: extend ThemeExport to export font and format scheme of a theme | https://gerrit.libreoffice.org/c/core/+/149363 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157791] footer display problem
https://bugs.documentfoundation.org/show_bug.cgi?id=157791 RMS I changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |FIXED --- Comment #3 from RMS I --- Many thanks for the quick response problem solved -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157799] New: Import of csv is insecure
https://bugs.documentfoundation.org/show_bug.cgi?id=157799 Bug ID: 157799 Summary: Import of csv is insecure Product: LibreOffice Version: 7.5.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jens.d...@live.de Created attachment 190242 --> https://bugs.documentfoundation.org/attachment.cgi?id=190242=edit csv file from a sql table I imported a csv generated from a sql table. It looked rather good but had several exceptions in the format of the imported data. Subnet triples seperated by two dots in column 2 looked wrong in line 10 and 12+13, but looked good in the other lines. The dot in between had disappeared. Why is it so? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157497] can't open files since updated to 7.5.7.1: "this file has been locked by another user"
https://bugs.documentfoundation.org/show_bug.cgi?id=157497 --- Comment #15 from Stéphane Guillou (stragu) --- Can everyone affected here check that they don't have AVG/Avast interfering with LibreOffice? Frank, which antivirus did you turn off? Do you have maybe several tools installed? No AVG? See also: - https://ask.libreoffice.org/t/when-trying-to-open-some-files-i-get-error-access-denied-or-this-file-has-been-locked-by-another-user/97072 - https://ask.libreoffice.org/t/problem-opening-saved-docs-following-recent-upgrade/96972 Thank you! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: embeddedobj/source svx/source
embeddedobj/source/commonembedding/persistence.cxx |2 +-
svx/source/unodraw/unoshap4.cxx|2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 267be127f2899f2e1b1f15b5a06707a9b83fcab4
Author: Caolán McNamara
AuthorDate: Mon Oct 16 13:25:29 2023 +0100
Commit: Caolán McNamara
CommitDate: Mon Oct 16 17:52:18 2023 +0200
retain Referer information available in OCommonEmbeddedObject ctor
Change-Id: I2cb901e81de3b7db73cd2088348ddad46ae603dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158052
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/embeddedobj/source/commonembedding/persistence.cxx
b/embeddedobj/source/commonembedding/persistence.cxx
index 2fdc6af47d08..ce77c9531db0 100644
--- a/embeddedobj/source/commonembedding/persistence.cxx
+++ b/embeddedobj/source/commonembedding/persistence.cxx
@@ -79,7 +79,7 @@ uno::Sequence< beans::PropertyValue > GetValuableArgs_Impl(
const uno::Sequence<
|| prop.Name == "StartPresentation" || prop.Name == "RepairPackage"
|| prop.Name == "StatusIndicator" || prop.Name == "ViewData"
|| prop.Name == "ViewId" || prop.Name == "MacroExecutionMode"
- || prop.Name == "UpdateDocMode"
+ || prop.Name == "UpdateDocMode" || prop.Name == "Referer"
|| (prop.Name == "DocumentBaseURL" && bCanUseDocumentBaseURL) )
{
aResult.realloc( ++nResLen );
diff --git a/svx/source/unodraw/unoshap4.cxx b/svx/source/unodraw/unoshap4.cxx
index 9e1f265dce2b..faff6e4ba6b7 100644
--- a/svx/source/unodraw/unoshap4.cxx
+++ b/svx/source/unodraw/unoshap4.cxx
@@ -480,7 +480,7 @@ void SvxOle2Shape::createLink( const OUString& aLinkURL )
awt::Size aSz = xObj->getVisualAreaSize( pOle2Obj->GetAspect() );
aRect.SetSize( Size( aSz.Width, aSz.Height ) );
}
-catch( embed::NoVisualAreaSizeException& )
+catch (const uno::Exception&)
{}
pOle2Obj->SetLogicRect( aRect );
}
[Libreoffice-bugs] [Bug 157797] ifna() returns #VALUE! if the input is a sum of a N/A value and another text cell
https://bugs.documentfoundation.org/show_bug.cgi?id=157797 Eike Rathke changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |er...@redhat.com |desktop.org | OS|Linux (All) |All Version|7.5.6.2 release |4.0.0.3 release -- You are receiving this mail because: You are the assignee for the bug.
