[Libreoffice-bugs] [Bug 62332] FORMATTING: Allow to assign Layouts to Master Slides, effectively creating a new "Master Slide+Layout combination" for presentations in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=62332 Stéphane Guillou (stragu) changed: What|Removed |Added URL||https://ask.libreoffice.org ||/t/apply-layout-to-slide-ma ||ster/1848 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: include/comphelper xmloff/qa
include/comphelper/sequenceashashmap.hxx |5 +
xmloff/qa/unit/text.cxx |8
2 files changed, 9 insertions(+), 4 deletions(-)
New commits:
commit 06e3877dc2cf22e00d04b48453e9ab0b948c3ca2
Author: Miklos Vajna
AuthorDate: Wed Nov 15 20:08:48 2023 +0100
Commit: Miklos Vajna
CommitDate: Thu Nov 16 08:31:08 2023 +0100
comphelper: use c++20 contains() instead of find() and end()
Whether an element is contained inside a container is better to be
checked with contains() instead of find() because contains() conveys the
intent more clearly.
Change-Id: I267d915c95fcf9c98b2e11daa89c8fe801e59a75
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159484
Tested-by: Jenkins
Reviewed-by: Miklos Vajna
diff --git a/include/comphelper/sequenceashashmap.hxx
b/include/comphelper/sequenceashashmap.hxx
index 59ab4c298d76..f5af2e28de50 100644
--- a/include/comphelper/sequenceashashmap.hxx
+++ b/include/comphelper/sequenceashashmap.hxx
@@ -405,6 +405,11 @@ class SAL_WARN_UNUSED COMPHELPER_DLLPUBLIC
SequenceAsHashMap
return m_aMap.find(rKey);
}
+bool contains(const OUString& rKey)
+{
+return m_aMap.contains(rKey);
+}
+
iterator erase(iterator it)
{
return m_aMap.erase(it);
diff --git a/xmloff/qa/unit/text.cxx b/xmloff/qa/unit/text.cxx
index 5188770a32ba..2a5350423c0d 100644
--- a/xmloff/qa/unit/text.cxx
+++ b/xmloff/qa/unit/text.cxx
@@ -126,7 +126,7 @@ CPPUNIT_TEST_FIXTURE(XmloffStyleTest,
testBibliographyLocalUrl)
uno::Reference xPortion(xPortionEnum->nextElement(),
uno::UNO_QUERY);
xField.set(xPortion->getPropertyValue("TextField"), uno::UNO_QUERY);
comphelper::SequenceAsHashMap aMap(xField->getPropertyValue("Fields"));
-CPPUNIT_ASSERT(aMap.find("LocalURL") != aMap.end());
+CPPUNIT_ASSERT(aMap.contains("LocalURL"));
auto aActual = aMap["LocalURL"].get();
CPPUNIT_ASSERT_EQUAL(OUString("file:///home/me/test.pdf"), aActual);
}
@@ -165,15 +165,15 @@ CPPUNIT_TEST_FIXTURE(XmloffStyleTest,
testBibliographyTargetURL1)
xField.set(xPortion->getPropertyValue("TextField"), uno::UNO_QUERY);
comphelper::SequenceAsHashMap aMap(xField->getPropertyValue("Fields"));
-CPPUNIT_ASSERT(aMap.find("URL") != aMap.end());
+CPPUNIT_ASSERT(aMap.contains("URL"));
CPPUNIT_ASSERT_EQUAL(OUString("https://display.url/test1.pdf#page=1;),
aMap["URL"].get());
-CPPUNIT_ASSERT(aMap.find("TargetURL") != aMap.end());
+CPPUNIT_ASSERT(aMap.contains("TargetURL"));
CPPUNIT_ASSERT_EQUAL(OUString("https://target.url/test2.pdf#page=2;),
aMap["TargetURL"].get());
-CPPUNIT_ASSERT(aMap.find("TargetType") != aMap.end());
+CPPUNIT_ASSERT(aMap.contains("TargetType"));
CPPUNIT_ASSERT_EQUAL(OUString("1"), aMap["TargetType"].get());
}
[Libreoffice-bugs] [Bug 158236] New: Spell check dialog replaces fields by text
https://bugs.documentfoundation.org/show_bug.cgi?id=158236 Bug ID: 158236 Summary: Spell check dialog replaces fields by text Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: oliver.spe...@cib.de Created attachment 190857 --> https://bugs.documentfoundation.org/attachment.cgi?id=190857=edit Spelling error in a sentence with two fields Open the attached document and start the spell check dialog (F7) Delete the marked word and press correct. -> The sentence looks identical but the date/time are no fields but simple text. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: officecfg/registry unotools/source
officecfg/registry/schema/org/openoffice/Office/Histories.xcs |6 --
unotools/source/config/historyoptions.cxx |3 ---
2 files changed, 9 deletions(-)
New commits:
commit c0fffdc36df687fe8e4eff49e5a00d3a3c1eb370
Author: Samuel Mehrbrodt
AuthorDate: Mon Oct 2 12:35:21 2023 +0200
Commit: Samuel Mehrbrodt
CommitDate: Thu Nov 16 08:17:27 2023 +0100
[API CHANGE] Remove deprecated Password config item
Deprecated since c51ef466f736c9e0e192d2c7feeda0a39bca2011
Change-Id: I9509a17de09e618c5d4b914b7ac1202cb76f506e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157485
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt
diff --git a/officecfg/registry/schema/org/openoffice/Office/Histories.xcs
b/officecfg/registry/schema/org/openoffice/Office/Histories.xcs
index e01534fb9aea..e01d4a159c64 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Histories.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Histories.xcs
@@ -36,12 +36,6 @@
Indicates the title of the URL that is displayed on the
user-interface.
-
-
- Not used anymore
- Contains an encoded password used to open the document.
-
-
Contains a base64 encoded thumbnail of the document.
diff --git a/unotools/source/config/historyoptions.cxx
b/unotools/source/config/historyoptions.cxx
index 52d2292c7932..3d8d8f933bd7 100644
--- a/unotools/source/config/historyoptions.cxx
+++ b/unotools/source/config/historyoptions.cxx
@@ -40,7 +40,6 @@ namespace {
constexpr OUString s_sHistoryItemRef = u"HistoryItemRef"_ustr;
constexpr OUString s_sFilter = u"Filter"_ustr;
constexpr OUString s_sTitle = u"Title"_ustr;
-constexpr OUString s_sPassword = u"Password"_ustr;
constexpr OUString s_sThumbnail = u"Thumbnail"_ustr;
constexpr OUString s_sReadOnly = u"ReadOnly"_ustr;
constexpr OUString s_sPinned = u"Pinned"_ustr;
@@ -153,7 +152,6 @@ std::vector< HistoryItem > GetList( EHistoryType eHistory )
aItem.sURL = sUrl;
xSet->getPropertyValue(s_sFilter) >>= aItem.sFilter;
xSet->getPropertyValue(s_sTitle) >>= aItem.sTitle;
-xSet->getPropertyValue(s_sPassword) >>= aItem.sPassword;
xSet->getPropertyValue(s_sThumbnail) >>= aItem.sThumbnail;
xSet->getPropertyValue(s_sReadOnly) >>= aItem.isReadOnly;
if (xSet->getPropertySetInfo()->hasPropertyByName(s_sPinned))
@@ -285,7 +283,6 @@ void AppendItem(EHistoryType eHistory, const OUString&
sURL, const OUString& sFi
xSet.set(xInst, uno::UNO_QUERY);
xSet->setPropertyValue(s_sFilter, uno::Any(sFilter));
xSet->setPropertyValue(s_sTitle, uno::Any(sTitle));
-xSet->setPropertyValue(s_sPassword, uno::Any(OUString()));
xSet->setPropertyValue(s_sThumbnail,
uno::Any(sThumbnail.value_or(OUString(;
if (oIsReadOnly)
{
[Libreoffice-commits] core.git: cui/source solenv/clang-format
cui/source/options/optaboutconfig.cxx | 364 +-
cui/source/options/optaboutconfig.hxx | 34 +--
solenv/clang-format/excludelist |2
3 files changed, 202 insertions(+), 198 deletions(-)
New commits:
commit f271ec5cd98ae32fd643df33174136d0a91a1941
Author: Samuel Mehrbrodt
AuthorDate: Mon Nov 13 14:22:09 2023 +0100
Commit: Samuel Mehrbrodt
CommitDate: Thu Nov 16 08:04:31 2023 +0100
Format optaboutconfig with clang-format
Change-Id: Ia696e096f972fe722920238c3710d20a3f03b221
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159374
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt
diff --git a/cui/source/options/optaboutconfig.cxx
b/cui/source/options/optaboutconfig.cxx
index 11806faa8477..362af44cfd7d 100644
--- a/cui/source/options/optaboutconfig.cxx
+++ b/cui/source/options/optaboutconfig.cxx
@@ -7,37 +7,37 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
+#include "optaboutconfig.hxx"
#include
#include
-#include "optaboutconfig.hxx"
-#include
-#include
-#include
-#include
#include
#include
#include
#include
#include
#include
+#include
+#include
#include
#include
-#include
+#include
#include
#include
#include
-#include
-#include
#include
+#include
+#include
+#include
+#include
+#include
#include
#include
#include
+#include
#include
#include
#include
-#include
-#include
#include
#include
@@ -52,15 +52,16 @@ using namespace com::sun::star::container;
struct Prop_Impl
{
-OUStringName;
-OUStringProperty;
-Any Value;
-
-Prop_Impl( OUString sName, OUString sProperty, Any aValue )
-: Name(std::move( sName ))
-, Property(std::move( sProperty ))
-, Value(std::move( aValue ))
-{}
+OUString Name;
+OUString Property;
+Any Value;
+
+Prop_Impl(OUString sName, OUString sProperty, Any aValue)
+: Name(std::move(sName))
+, Property(std::move(sProperty))
+, Value(std::move(aValue))
+{
+}
};
struct UserData
@@ -72,20 +73,22 @@ struct UserData
int aLineage;
Reference aXNameAccess;
-explicit UserData( OUString aPropertyPath, OUString aTooltip, bool
isReadOnly )
-: bIsPropertyPath( true )
-, bIsReadOnly( isReadOnly )
+explicit UserData(OUString aPropertyPath, OUString aTooltip, bool
isReadOnly)
+: bIsPropertyPath(true)
+, bIsReadOnly(isReadOnly)
, sPropertyPath(std::move(aPropertyPath))
, sTooltip(std::move(aTooltip))
, aLineage(0)
-{}
+{
+}
-explicit UserData( Reference const & rXNameAccess, int rIndex
)
-: bIsPropertyPath( false )
-, bIsReadOnly( false )
+explicit UserData(Reference const& rXNameAccess, int rIndex)
+: bIsPropertyPath(false)
+, bIsReadOnly(false)
, aLineage(rIndex)
-, aXNameAccess( rXNameAccess )
-{}
+, aXNameAccess(rXNameAccess)
+{
+}
};
CuiAboutConfigTabPage::CuiAboutConfigTabPage(weld::Window* pParent)
@@ -103,24 +106,20 @@
CuiAboutConfigTabPage::CuiAboutConfigTabPage(weld::Window* pParent)
m_xPrefBox->get_height_rows(23));
m_xPrefBox->connect_column_clicked(LINK(this, CuiAboutConfigTabPage,
HeaderBarClick));
-m_xEditBtn->connect_clicked(LINK( this, CuiAboutConfigTabPage,
StandardHdl_Impl));
-m_xResetBtn->connect_clicked(LINK( this, CuiAboutConfigTabPage,
ResetBtnHdl_Impl));
+m_xEditBtn->connect_clicked(LINK(this, CuiAboutConfigTabPage,
StandardHdl_Impl));
+m_xResetBtn->connect_clicked(LINK(this, CuiAboutConfigTabPage,
ResetBtnHdl_Impl));
m_xPrefBox->connect_row_activated(LINK(this, CuiAboutConfigTabPage,
DoubleClickHdl_Impl));
m_xPrefBox->connect_expanding(LINK(this, CuiAboutConfigTabPage,
ExpandingHdl_Impl));
m_xSearchBtn->connect_clicked(LINK(this, CuiAboutConfigTabPage,
SearchHdl_Impl));
m_options.AlgorithmType2 = util::SearchAlgorithms2::ABSOLUTE;
m_options.transliterateFlags |= TransliterationFlags::IGNORE_CASE;
-m_options.searchFlag |= (util::SearchFlags::REG_NOT_BEGINOFLINE |
-util::SearchFlags::REG_NOT_ENDOFLINE);
+m_options.searchFlag
+|= (util::SearchFlags::REG_NOT_BEGINOFLINE |
util::SearchFlags::REG_NOT_ENDOFLINE);
float fWidth = m_xPrefBox->get_approximate_digit_width();
-std::vector aWidths
-{
-o3tl::narrowing(fWidth * 65),
-o3tl::narrowing(fWidth * 20),
-o3tl::narrowing(fWidth * 8)
-};
+std::vector aWidths{ o3tl::narrowing(fWidth * 65),
o3tl::narrowing(fWidth * 20),
+ o3tl::narrowing(fWidth * 8) };
m_xPrefBox->set_column_fixed_widths(aWidths);
m_xPrefBox->connect_query_tooltip(LINK(this, CuiAboutConfigTabPage,
QueryTooltip));
@@ -128,7 +127,7 @@
[Libreoffice-commits] core.git: cui/source cui/uiconfig cui/UIConfig_cui.mk include/cui static/CustomTarget_emscripten_fs_image.mk
cui/UIConfig_cui.mk|1
cui/source/dialogs/dlgname.cxx | 22
cui/source/options/optaboutconfig.cxx | 144 ++---
cui/uiconfig/ui/numberdialog.ui| 128 +
include/cui/dlgname.hxx| 28 +
static/CustomTarget_emscripten_fs_image.mk |1
6 files changed, 273 insertions(+), 51 deletions(-)
New commits:
commit 1f874d384228867ee450d3e1d53c821519b51722
Author: Samuel Mehrbrodt
AuthorDate: Thu Nov 9 16:18:35 2023 +0100
Commit: Samuel Mehrbrodt
CommitDate: Thu Nov 16 08:03:32 2023 +0100
expert config: Proper editing support for numbers
Change-Id: Ib97e027cedfdf2c5bb3c956aeee75af25198e498
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159355
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt
diff --git a/cui/UIConfig_cui.mk b/cui/UIConfig_cui.mk
index e36cfc7f11b6..97a4a56f3ecc 100644
--- a/cui/UIConfig_cui.mk
+++ b/cui/UIConfig_cui.mk
@@ -124,6 +124,7 @@ $(eval $(call gb_UIConfig_add_uifiles,cui,\
cui/uiconfig/ui/newlibdialog \
cui/uiconfig/ui/newtabledialog \
cui/uiconfig/ui/newtoolbardialog \
+ cui/uiconfig/ui/numberdialog \
cui/uiconfig/ui/numberingformatpage \
cui/uiconfig/ui/numberingoptionspage \
cui/uiconfig/ui/numberingpositionpage \
diff --git a/cui/source/dialogs/dlgname.cxx b/cui/source/dialogs/dlgname.cxx
index a1f6283d92b5..a96b59290bbd 100644
--- a/cui/source/dialogs/dlgname.cxx
+++ b/cui/source/dialogs/dlgname.cxx
@@ -60,6 +60,28 @@ IMPL_LINK_NOARG(SvxNameDialog, ModifyHdl, weld::Entry&, void)
m_xEdtName->set_tooltip_text(rTip);
}
+SvxNumberDialog::SvxNumberDialog(weld::Window* pParent, const OUString& rDesc,
sal_Int64 nValue,
+ sal_Int64 nMin, sal_Int64 nMax)
+: GenericDialogController(pParent, "cui/ui/numberdialog.ui",
"NumberDialog")
+, m_xEdtNumber(m_xBuilder->weld_spin_button("number_spinbtn"))
+, m_xFtDescription(m_xBuilder->weld_label("description_label"))
+{
+m_xFtDescription->set_label(rDesc);
+m_xEdtNumber->set_min(nMin);
+m_xEdtNumber->set_max(nMax);
+m_xEdtNumber->set_value(nValue);
+}
+
+SvxDecimalNumberDialog::SvxDecimalNumberDialog(weld::Window* pParent, const
OUString& rDesc,
+ double fValue)
+: GenericDialogController(pParent, "cui/ui/numberdialog.ui",
"NumberDialog")
+, m_xEdtNumber(m_xBuilder->weld_formatted_spin_button("number_spinbtn"))
+, m_xFtDescription(m_xBuilder->weld_label("description_label"))
+{
+m_xFtDescription->set_label(rDesc);
+m_xEdtNumber->GetFormatter().SetValue(fValue);
+}
+
// #i68101#
// Dialog for editing Object Name
// plus uniqueness-callback-linkHandler
diff --git a/cui/source/options/optaboutconfig.cxx
b/cui/source/options/optaboutconfig.cxx
index bdc51afdea51..11806faa8477 100644
--- a/cui/source/options/optaboutconfig.cxx
+++ b/cui/source/options/optaboutconfig.cxx
@@ -654,96 +654,138 @@ IMPL_LINK_NOARG( CuiAboutConfigTabPage,
StandardHdl_Impl, weld::Button&, void )
{
if( bOpenDialog )
{
-SvxNameDialog aNameDialog(m_pParent, sDialogValue, sPropertyName);
-aNameDialog.SetCheckNameHdl( LINK( this, CuiAboutConfigTabPage,
ValidNameHdl ) );
-if (aNameDialog.run() == RET_OK )
+if (sPropertyType == "short" || sPropertyType == "int" ||
sPropertyType == "long")
{
-OUString sNewValue = aNameDialog.GetName();
-bSaveChanges = true;
-if ( sPropertyType == "short")
+sal_Int64 nMin = sPropertyType == "short"
+ ? SAL_MIN_INT16
+ : sPropertyType == "int" ? SAL_MIN_INT32
: SAL_MIN_INT64;
+sal_Int64 nMax = sPropertyType == "short"
+ ? SAL_MAX_INT16
+ : sPropertyType == "int" ? SAL_MAX_INT32
: SAL_MAX_INT64;
+SvxNumberDialog aNumberDialog(m_pParent, sPropertyName,
sDialogValue.toInt64(),
+ nMin, nMax);
+if (aNumberDialog.run() == RET_OK)
{
-sal_Int16 nShort;
-sal_Int32 nNumb = sNewValue.toInt32();
-
-//if the value is 0 and length is not 1, there is
something wrong
-if( ( nNumb==0 && sNewValue.getLength()!=1 ) || nNumb >
SAL_MAX_INT16 || nNumb < SAL_MIN_INT16)
-throw uno::Exception("out of range short", nullptr);
-nShort = static_cast(nNumb);
-pProperty->Value <<= nShort;
-}
-else if( sPropertyType == "int" )
-{
-sal_Int32 nLong = sNewValue.toInt32();
-if( nLong==0 &&
[Libreoffice-bugs] [Bug 107610] FILEOPEN PPTX: wrong default fonts for non English text
https://bugs.documentfoundation.org/show_bug.cgi?id=107610 Kira Tubo changed: What|Removed |Added CC||kira.t...@gmail.com --- Comment #10 from Kira Tubo --- Still reproducible. Middle column set to Calibri. Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 676e0527d2f31556eccae314fbb12ce204f02ec7 CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155851] Phrase checking: in multi-word dictionary items each word is still marked as error
https://bugs.documentfoundation.org/show_bug.cgi?id=155851 Shantanu changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=91 ||031 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 91031] Writer: spellcheck to include brackets
https://bugs.documentfoundation.org/show_bug.cgi?id=91031 Shantanu changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||5851 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158013] lo reseting fonts resets fonts in document
https://bugs.documentfoundation.org/show_bug.cgi?id=158013 Kira Tubo changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||kira.t...@gmail.com Whiteboard| QA:needsComment| --- Comment #1 from Kira Tubo --- Hi Tracey, Can you provide step-by-step instructions for how you reset the default fonts? Thanks! I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the steps are provided -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158032] Hyperlinks should automatically render with lighter colors when using the system dark theme color scheme for documents
https://bugs.documentfoundation.org/show_bug.cgi?id=158032 Kira Tubo changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158032] Hyperlinks should automatically render with lighter colors when using the system dark theme color scheme for documents
https://bugs.documentfoundation.org/show_bug.cgi?id=158032 Kira Tubo changed: What|Removed |Added CC||kira.t...@gmail.com --- Comment #1 from Kira Tubo --- Created attachment 190856 --> https://bugs.documentfoundation.org/attachment.cgi?id=190856=edit 7.5.5.2 dark mode scheme Reproduced in 24.2. Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 676e0527d2f31556eccae314fbb12ce204f02ec7 CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded Interestingly in 7.5.5.2, if you select "LibreOffice Dark" scheme, the visited/unvisited link colors automatically still default to dark blue/red. However, some good color suggestions are provided, though you still have to manually check the checkboxes next to them and apply the changes. Version: 7.5.5.2 (X86_64) / LibreOffice Community Build ID: ca8fe7424262805f223b9a2334bc7181abbcbf5e CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104848] [META] DOC (binary) file opening issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104848 Bug 104848 depends on bug 76219, which changed state. Bug 76219 Summary: HANG i#84870: WW8: large objects in Russian text / DOC with complex header / ... may cause loop (see comment 7 and 8) https://bugs.documentfoundation.org/show_bug.cgi?id=76219 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 101280] [META] Layout loops
https://bugs.documentfoundation.org/show_bug.cgi?id=101280 Bug 101280 depends on bug 76219, which changed state. Bug 76219 Summary: HANG i#84870: WW8: large objects in Russian text / DOC with complex header / ... may cause loop (see comment 7 and 8) https://bugs.documentfoundation.org/show_bug.cgi?id=76219 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 87740] [META] Anchor and text wrapping bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=87740 Bug 87740 depends on bug 76219, which changed state. Bug 76219 Summary: HANG i#84870: WW8: large objects in Russian text / DOC with complex header / ... may cause loop (see comment 7 and 8) https://bugs.documentfoundation.org/show_bug.cgi?id=76219 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 76219] HANG i#84870: WW8: large objects in Russian text / DOC with complex header / ... may cause loop (see comment 7 and 8)
https://bugs.documentfoundation.org/show_bug.cgi?id=76219 Buovjaga changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #33 from Buovjaga --- Testing with the .doc in attachment 120433, it opens with oldest of 7.5 Win bibisect repo, but closing it hangs. With 7.6.2 it works fine. Let's close as WFM. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155851] Phrase checking: in multi-word dictionary items each word is still marked as error
https://bugs.documentfoundation.org/show_bug.cgi?id=155851 Kira Tubo changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 89578] EDITING: spellcheck 2-word phrases where 1 word would be wrong if found outside of the phrase
https://bugs.documentfoundation.org/show_bug.cgi?id=89578 Kira Tubo changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||5851 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155851] Phrase checking: in multi-word dictionary items each word is still marked as error
https://bugs.documentfoundation.org/show_bug.cgi?id=155851 Kira Tubo changed: What|Removed |Added CC||kira.t...@gmail.com Version|7.6.0.0 beta1+ |Inherited From OOo See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=89 ||578 Whiteboard| QA:needsComment| --- Comment #1 from Kira Tubo --- The issue has morphed somewhat: "Ad hoc": this is no longer flagged as an error (expected) "Hoc": not flagged as an error, even though "ad" is missing (not expected) "A hoc": not flagged as an error, even though "ad" is misspelled (not expected) "Ahoc": flagged as an error (expected), BUT spell check does not show "ad hoc" as a possible correction (not expected) "Adhoc": flagged as an error and shows "ad hoc" as possible correction (expected) Notes: - This issue seems somewhat related to Bug 89578. - The issue as originally described has been around since 3.3. Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 676e0527d2f31556eccae314fbb12ce204f02ec7 CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded Version: 7.6.2.1 (X86_64) / LibreOffice Community Build ID: 56f7684011345957bbf33a7ee678afaf4d2ba333 CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded Installed dictionary to work with win64-24.2 repository: https://extensions.libreoffice.org/en/extensions/show/english-dictionaries -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158221] Insert bookmarks dialogue takes a very long time to appear when there are many bookmarks
https://bugs.documentfoundation.org/show_bug.cgi?id=158221 BogdanB changed: What|Removed |Added Keywords|bibisectRequest |bibisected, bisected CC||buzea.bog...@libreoffice.or ||g, ||michael.st...@allotropia.de --- Comment #3 from BogdanB --- Michael, please, could you take a look? author Michael Stahl 2022-07-21 19:31:45 +0200 committer Michael Stahl 2022-07-26 20:15:37 +0200 commit aa6ec3f79607478213272283b7eb17ec2116173c (patch) tree873bdaef7a6d99f891ba55901960155d73480556 parent 96844af26402e4ab26ff7ba02e52989c3b294095 (diff) tdf#150017 sw: allow editing bookmark text in Insert->Bookmarks dialog Enable editing the text of the bookmark if it's "short" enough and doesn't span multiple paragraphs; Replace the text when finished. This will delete any footnotes or text fields in the bookmark text, which isn't ideal but there's Undo. Double-clicking the column via property "editable" only seems to work with native GTK widgets, so provide an additional "Edit Text" button to start the editing. The button requires commit fe38553aef2121f358fb58e450ec69314aad851e to edit the correct column with VCL widgets, and it doesn't work yet with GTK widgets (but with GTK double-clicking works). Change-Id: If9e8a148b039889924e4870b2e9bbe977c977ce9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137355 Tested-by: Jenkins Reviewed-by: Michael Stahl 558b63e80bad2d99c6c5b1acc3640018e1c7c4ec is the first bad commit commit 558b63e80bad2d99c6c5b1acc3640018e1c7c4ec Author: Jenkins Build User Date: Tue Jul 26 20:33:00 2022 +0200 source sha:aa6ec3f79607478213272283b7eb17ec2116173c source sha:aa6ec3f79607478213272283b7eb17ec2116173c instdir/program/libswuilo.so | Bin 2877408 -> 2882528 bytes instdir/program/setuprc| 2 +- instdir/program/versionrc | 2 +- instdir/share/config/images_breeze.zip | Bin 1941312 -> 1941312 bytes instdir/share/config/images_breeze_dark.zip| Bin 1937928 -> 1937928 bytes instdir/share/config/images_breeze_dark_svg.zip| Bin 1604694 -> 1604694 bytes instdir/share/config/images_breeze_svg.zip | Bin 1602278 -> 1602278 bytes instdir/share/config/images_colibre.zip| Bin 2838539 -> 2838539 bytes instdir/share/config/images_colibre_dark.zip | Bin 2738585 -> 2738585 bytes instdir/share/config/images_colibre_dark_svg.zip | Bin 2991760 -> 2991760 bytes instdir/share/config/images_colibre_svg.zip| Bin 3186592 -> 3186592 bytes instdir/share/config/images_elementary.zip | Bin 4255343 -> 4255343 bytes instdir/share/config/images_elementary_svg.zip | Bin 5553386 -> 5553386 bytes instdir/share/config/images_karasa_jaga.zip| Bin 4926692 -> 4926692 bytes instdir/share/config/images_karasa_jaga_svg.zip| Bin 19377292 -> 19377292 bytes instdir/share/config/images_sifr.zip | Bin 2153798 -> 2153798 bytes instdir/share/config/images_sifr_dark.zip | Bin 2158217 -> 2158217 bytes instdir/share/config/images_sifr_dark_svg.zip | Bin 1799085 -> 1799085 bytes instdir/share/config/images_sifr_svg.zip | Bin 1795131 -> 1795131 bytes instdir/share/config/images_sukapura.zip | Bin 3062385 -> 3062385 bytes instdir/share/config/images_sukapura_svg.zip | Bin 4393583 -> 4393583 bytes .../modules/swriter/ui/insertbookmark.ui | 20 ++-- 22 files changed, 20 insertions(+), 4 deletions(-) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158224] EDITING CRASH Cannot convert bitmap to polygons
https://bugs.documentfoundation.org/show_bug.cgi?id=158224 --- Comment #8 from Frank Reibold --- Created attachment 190855 --> https://bugs.documentfoundation.org/attachment.cgi?id=190855=edit 800x600.jpg JPG causes LO Draw to crash -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158224] EDITING CRASH Cannot convert bitmap to polygons
https://bugs.documentfoundation.org/show_bug.cgi?id=158224 --- Comment #7 from Frank Reibold --- Created attachment 190854 --> https://bugs.documentfoundation.org/attachment.cgi?id=190854=edit 800x600.bmp BMP causes LO Draw to crash -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158224] EDITING CRASH Cannot convert bitmap to polygons
https://bugs.documentfoundation.org/show_bug.cgi?id=158224 --- Comment #6 from Frank Reibold --- With LibrerOffice 7.6, 800x600.jpg and 800x600.bmp cause Draw to crash. OpenOffice can convert them. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156017] Printer settings not used by LibreOffice (display, printing or exporting pdf)
https://bugs.documentfoundation.org/show_bug.cgi?id=156017 Kira Tubo changed: What|Removed |Added Whiteboard| QA:needsComment| CC||kira.t...@gmail.com Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #1 from Kira Tubo --- Thank you for reporting the bug. Unfortunately without clear steps to reproduce it, we cannot track down the origin of the problem. Please provide a clearer set of step-by-step instructions on how to reproduce the problem. I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the steps are provided -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153974] Wrong choice of page margins when importing a PDF with RTL paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=153974 --- Comment #5 from Kira Tubo --- Created attachment 190853 --> https://bugs.documentfoundation.org/attachment.cgi?id=190853=edit rectangle exported pdf -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153974] Wrong choice of page margins when importing a PDF with RTL paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=153974 --- Comment #4 from Kira Tubo --- Created attachment 190852 --> https://bugs.documentfoundation.org/attachment.cgi?id=190852=edit original writer file with rectangle shape Steps: 1. Open Writer 2. Insert rectangle shape 3. Export as PDF 4. Open file created in step 3 in Draw Result: margins in Draw do not match the margins from Writer. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158179] Layer tab popup menu in Draw shows layer visibility setting of previous selected tab
https://bugs.documentfoundation.org/show_bug.cgi?id=158179 --- Comment #3 from Commit Notification --- Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7f79b0caf194ff9d7dfa2f85379a5c752c905476 tdf#158179 Fix layer tab menu layer visibility check menu item It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158179] Layer tab popup menu in Draw shows layer visibility setting of previous selected tab
https://bugs.documentfoundation.org/show_bug.cgi?id=158179 Commit Notification changed: What|Removed |Added Whiteboard||target:24.2.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: officecfg/registry sd/source
officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu |
4 ++--
sd/source/ui/dlg/LayerTabBar.cxx |
2 +-
sd/source/ui/view/drviews7.cxx |
2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
New commits:
commit 7f79b0caf194ff9d7dfa2f85379a5c752c905476
Author: Jim Raykowski
AuthorDate: Tue Nov 14 13:55:27 2023 -0900
Commit: Jim Raykowski
CommitDate: Thu Nov 16 04:48:08 2023 +0100
tdf#158179 Fix layer tab menu layer visibility check menu item
Renames/reworks the layer tab context menu visibility check menu item
from 'Show Layer' to 'Hide layer' and fixes a bug that causes the
check menu item to be set as the layer visibility setting of the
previously selected layer tab.
Change-Id: I81f1910f95df50255e61115b5d8de8ed3ef8bd89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159427
Tested-by: Jenkins
Tested-by: Heiko Tietze
Reviewed-by: Heiko Tietze
diff --git
a/officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu
b/officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu
index 311c5d3dff2e..de8d13e78222 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu
@@ -999,10 +999,10 @@
Toggle Layer Visibility
- ~Show Layer
+ ~Hide Layer
- ~Show Layer (Shift+Click)
+ ~Hide Layer (Shift+Click)
1
diff --git a/sd/source/ui/dlg/LayerTabBar.cxx b/sd/source/ui/dlg/LayerTabBar.cxx
index 7e09228e6ed4..96b96068f331 100644
--- a/sd/source/ui/dlg/LayerTabBar.cxx
+++ b/sd/source/ui/dlg/LayerTabBar.cxx
@@ -134,7 +134,7 @@ bool
LayerTabBar::IsRealNameOfStandardLayer(std::u16string_view rName)
void LayerTabBar::Select()
{
SfxDispatcher* pDispatcher = pDrViewSh->GetViewFrame()->GetDispatcher();
-pDispatcher->Execute(SID_SWITCHLAYER, SfxCallMode::ASYNCHRON);
+pDispatcher->Execute(SID_SWITCHLAYER, SfxCallMode::SYNCHRON);
}
void LayerTabBar::MouseButtonDown(const MouseEvent& rMEvt)
diff --git a/sd/source/ui/view/drviews7.cxx b/sd/source/ui/view/drviews7.cxx
index 223493fb29e0..d8dbbac0362d 100644
--- a/sd/source/ui/view/drviews7.cxx
+++ b/sd/source/ui/view/drviews7.cxx
@@ -1278,7 +1278,7 @@ void DrawViewShell::GetMenuState( SfxItemSet )
}
if ( !aActiveLayer.isEmpty() && pPV )
-rSet.Put( SfxBoolItem(SID_TOGGLELAYERVISIBILITY,
pPageView->IsLayerVisible(aActiveLayer)) );
+rSet.Put( SfxBoolItem(SID_TOGGLELAYERVISIBILITY,
!pPageView->IsLayerVisible(aActiveLayer)) );
// are the modules available?
[Libreoffice-bugs] [Bug 153974] Wrong choice of page margins when importing a PDF with RTL paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=153974 Kira Tubo changed: What|Removed |Added CC||kira.t...@gmail.com --- Comment #3 from Kira Tubo --- Created attachment 190851 --> https://bugs.documentfoundation.org/attachment.cgi?id=190851=edit PDF export with LTR Hmmm, I don't think RTL is the issue. If I export the same file, aligning the text to LTR, the margins are the same as the RTL file. It might have to do with the horizontal bar in the document. I get the similar (if not worse) results with a simple rectangle shape created from Writer. I will attach sample files shortly. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154829] FILEOPEN DOCX shape "cloud" is wrongly rendered if it is on a Drawing Canvas
https://bugs.documentfoundation.org/show_bug.cgi?id=154829 Aron Budea changed: What|Removed |Added Whiteboard||target:24.2.0 --- Comment #7 from Aron Budea --- Thanks for implementing this fix, Regina! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158211] Form input writes over protected cells
https://bugs.documentfoundation.org/show_bug.cgi?id=158211 --- Comment #6 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157983] macOS: wrong colors for dropdowns, fields and buttons (white text on white background while in dark mode)
https://bugs.documentfoundation.org/show_bug.cgi?id=157983 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158211] Form input writes over protected cells
https://bugs.documentfoundation.org/show_bug.cgi?id=158211 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158032] Hyperlinks should automatically render with lighter colors when using the system dark theme color scheme for documents
https://bugs.documentfoundation.org/show_bug.cgi?id=158032 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148878] If a CSV file doesn't keep delimiter
https://bugs.documentfoundation.org/show_bug.cgi?id=148878 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148878] If a CSV file doesn't keep delimiter
https://bugs.documentfoundation.org/show_bug.cgi?id=148878 --- Comment #9 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154596] User entered text not rendering properly
https://bugs.documentfoundation.org/show_bug.cgi?id=154596 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155398] Writer file error
https://bugs.documentfoundation.org/show_bug.cgi?id=155398 --- Comment #4 from QA Administrators --- Dear david chen, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154596] User entered text not rendering properly
https://bugs.documentfoundation.org/show_bug.cgi?id=154596 --- Comment #5 from QA Administrators --- Dear Thorn, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147602] Program hangs on copy/paste
https://bugs.documentfoundation.org/show_bug.cgi?id=147602 --- Comment #3 from QA Administrators --- Dear yawning_zone, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 99847] "ENTER" from last page-row of a 3-column table -> cursor halfway down next page
https://bugs.documentfoundation.org/show_bug.cgi?id=99847 --- Comment #26 from QA Administrators --- Dear scott092707, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 67282] EDITING Page style is reset when automatic hyphenation is applied to a paragraph in a table, when the table is at the top of the page/document
https://bugs.documentfoundation.org/show_bug.cgi?id=67282 --- Comment #15 from QA Administrators --- Dear Mike Kaganski, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138722] Custom shortcut for uno:BackgroundColor should set last color not NoFill
https://bugs.documentfoundation.org/show_bug.cgi?id=138722 --- Comment #4 from QA Administrators --- Dear Robert Lacroix, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145673] UI: comment box doesn't expand while typing (scrollbar instead)
https://bugs.documentfoundation.org/show_bug.cgi?id=145673 --- Comment #8 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 117270] Safe mode fails to restart in normal mode if LibreOffice is called in safe mode (Linux-only)
https://bugs.documentfoundation.org/show_bug.cgi?id=117270 --- Comment #9 from QA Administrators --- Dear Xisco Faulí, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - sc/source
sc/source/ui/inc/content.hxx|2 ++
sc/source/ui/navipi/content.cxx | 18 +-
2 files changed, 19 insertions(+), 1 deletion(-)
New commits:
commit 3dff3a50dfda011c8bfb5502f6a8d1e7f8b95d59
Author: Attila Szűcs
AuthorDate: Tue Nov 7 15:03:33 2023 +0100
Commit: Tomaž Vajngerl
CommitDate: Thu Nov 16 04:02:36 2023 +0100
SC navigator: fix changing language of contenttree
Saved the actual language, when ScContentTree is created, and use
that language to localise is text.
Note: Saving language in ScContentTree::ScContentTree caused
problems, so it replaced into where this tree filled with text at
the first time.
In case of LOK, there can be seapate views, with different
languages, that means there can be 2+ ScContentTree, one have text
in English and the other in German.
When new item is created that is listed in navigator, then every
ScContentTree is updated at once... but that would use the global
laguage, not the one what was used when the actual ScContentTree
was created.
Change-Id: I2dedf293e0ad9fb8f3cdd1090e1e1707a9f6cfa4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159077
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Tomaž Vajngerl
diff --git a/sc/source/ui/inc/content.hxx b/sc/source/ui/inc/content.hxx
index 9cd7e977319d..3f179860cce7 100644
--- a/sc/source/ui/inc/content.hxx
+++ b/sc/source/ui/inc/content.hxx
@@ -59,6 +59,8 @@ class ScContentTree
o3tl::enumarray pPosList; // for the sequence
+std::unique_ptr m_pResLocaleForLOK; //it needed only in case
of LOK
+
ScDocShell* GetManualOrCurrent();
voidInitRoot(ScContentId nType);
diff --git a/sc/source/ui/navipi/content.cxx b/sc/source/ui/navipi/content.cxx
index 1387abd44346..7c3d2b7d022b 100644
--- a/sc/source/ui/navipi/content.cxx
+++ b/sc/source/ui/navipi/content.cxx
@@ -188,7 +188,23 @@ void ScContentTree::InitRoot( ScContentId nType )
}
auto const aImage(aContentBmps[static_cast(nType) - 1]);
-OUString aName(ScResId(SCSTR_CONTENT_ARY[static_cast(nType)]));
+
+OUString aName;
+if(comphelper::LibreOfficeKit::isActive())
+{
+//In case of LOK we may have many different languaged ScContentTree
+//At creation time, we store what language we use, and then use it
later too.
+//It not work in the constructor, that is why it is here.
+if (!m_pResLocaleForLOK)
+{
+m_pResLocaleForLOK =
std::make_unique(SC_MOD()->GetResLocale());
+}
+aName = Translate::get(SCSTR_CONTENT_ARY[static_cast(nType)],
*m_pResLocaleForLOK);
+}
+else
+{
+aName = ScResId(SCSTR_CONTENT_ARY[static_cast(nType)]);
+}
// back to the correct position:
sal_uInt16 nPos = nRootType != ScContentId::ROOT ? 0 : pPosList[nType]-1;
m_aRootNodes[nType] = m_xTreeView->make_iterator();
[Libreoffice-bugs] [Bug 158235] New: Spell check not working in LibreOffice Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=158235 Bug ID: 158235 Summary: Spell check not working in LibreOffice Writer Product: LibreOffice Version: 7.4.7.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: bnp2...@gmx.com Description: When entering text into this version of Writer the spell check does not pick up mistakes, including deliberately entered misspelling Steps to Reproduce: 1.enter text with a deliberate mistake 2.click spell check 3.Alternately, highlight the word click spell check Spellcheck box shows no text Actual Results: The spell check box was empty Expected Results: the misspelled word to be highlighted and suggestions made Reproducible: Always User Profile Reset: Yes Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: TextDocument [Information guessed from browser] OS: Windows (All) OS is 64bit: no -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158234] New: FILESAVE: Resolution degraded after saving redacted PDF file
https://bugs.documentfoundation.org/show_bug.cgi?id=158234 Bug ID: 158234 Summary: FILESAVE: Resolution degraded after saving redacted PDF file Product: LibreOffice Version: 7.5.8.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jimglar...@icloud.com The resolution is significantly degraded after saving a redacted PDF file. There is no way to adjust the resolution before saving the file. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158229] Won't start after last update
https://bugs.documentfoundation.org/show_bug.cgi?id=158229 m.a.riosv changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||miguelangelrv@libreoffice.o ||rg Ever confirmed|0 |1 --- Comment #1 from m.a.riosv --- Please try repairing the installation through the 'Add/Remove programs' -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158221] Insert bookmarks dialogue takes a very long time to appear when there are many bookmarks
https://bugs.documentfoundation.org/show_bug.cgi?id=158221 m.a.riosv changed: What|Removed |Added Keywords||bibisectRequest, regression CC||miguelangelrv@libreoffice.o ||rg Status|UNCONFIRMED |NEW OS|Linux (All) |All Ever confirmed|0 |1 --- Comment #2 from m.a.riosv --- Something strange happen to me with Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: c60a9db1f2a8e2a088c6b89bcdff4901b28f2864 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded last working for me Version: 7.4.7.2 (x64) / LibreOffice Community Build ID: 723314e595e8007d3cf785c16538505a1c878ca5 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: es-ES Calc: CL as if it is going through the document, showing the movement, recollecting the bookmarks, take about 20 seconds to show the bookmark box. Hangs without skia enable (Menu/Tools/Options/LibreOffice/View). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Changes to 'refs/tags/cib-6.4-21'
Tag 'cib-6.4-21' created by Thorsten Behrens at 2023-11-16 00:35 + Release CIB Office cib-6.4-21 -BEGIN PGP SIGNATURE- iNUEABYKAH0WIQRV78SO268/dhkw1IIeB5amgXyR5gUCZVVj718UgAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0NTVF RkM0OEVEQkFGM0Y3NjE5MzBENDgyMUUwNzk2QTY4MTdDOTFFNgAKCRAeB5amgXyR 5k3BAP9/kRkm0P0fAjLmtqtQ0rRhuANRBstVY1ovlngTygn25gD/aELeoT9ygfa7 58v5tCYZSthmiuIA3EbKahVJvOieBgQ= =zwPc -END PGP SIGNATURE- Changes since cib-6.4-20-12: --- 0 files changed ---
[Libreoffice-bugs] [Bug 158218] Document is not saved if solely text is pasted since last save
https://bugs.documentfoundation.org/show_bug.cgi?id=158218 --- Comment #3 from m.a.riosv --- Could be, just try. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158232] Major failure in Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=158232 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||5543 --- Comment #1 from Stéphane Guillou (stragu) --- There has been improvements recently in that regard, including the fix for bug 125543. Could you please test version 7.6 and let us know if you can still reproduce? Thank you. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155119] NOTEBOOKBAR: Text format selection is garbled with Hebrew UI
https://bugs.documentfoundation.org/show_bug.cgi?id=155119 Eyal Rozenberg changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #6 from Eyal Rozenberg --- Bug still manifests with: Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 3161a6c351a2f5f70c0420ee8cccf2eb23de1ecf CPU threads: 4; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: he-IL (en_IL); UI: en-US -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 127610] NB Tabbed View Not Centered (macOS)
https://bugs.documentfoundation.org/show_bug.cgi?id=127610 --- Comment #12 from Tex2002ans --- Within the past month, there were 2 more Mac users with this issue: - https://www.reddit.com/r/libreoffice/comments/17gmkiu/lo_for_mac_762_menu_not_aligned_is_there_a_fix/k6nxpni/ - https://www.reddit.com/r/libreoffice/comments/17vo5ji/somethings_wrong_with_my_ui/ They both complained about the "overlapping"/"misaligned" Tabbed View. (The one user's photo looked exactly like the attachment in duplicate #157722.) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148447] Replace All in Writer comments
https://bugs.documentfoundation.org/show_bug.cgi?id=148447 Eyal Rozenberg changed: What|Removed |Added Severity|enhancement |normal --- Comment #4 from Eyal Rozenberg --- A missing piece of the implementation of a feature is a bug, rather than a potential for enhancement... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144255] Table inner border coloring not continued logically when inserting new row after last
https://bugs.documentfoundation.org/show_bug.cgi?id=144255 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||7911 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 96415] Writer: cannot set desired borders (bottom) if cell crosses the page
https://bugs.documentfoundation.org/show_bug.cgi?id=96415 --- Comment #11 from Stéphane Guillou (stragu) --- Created attachment 190850 --> https://bugs.documentfoundation.org/attachment.cgi?id=190850=edit sample ODT with two tables Sample file to test: 1. Add border to first row of first table: border visible, persists in settings. 2. Add border to first row of second table: no border, not persistent in settings. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 128421] TABLE: Don't draw the top and bottom border of the row that breaks across pages
https://bugs.documentfoundation.org/show_bug.cgi?id=128421 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=96 ||415 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 96415] Writer: cannot set desired borders (bottom) if cell crosses the page
https://bugs.documentfoundation.org/show_bug.cgi?id=96415 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||8421 CC||stephane.guillou@libreoffic ||e.org --- Comment #10 from Stéphane Guillou (stragu) --- Agreed this is inconsistent behaviour and needs fixing regardless of if the enhancement suggested in bug 128421 is implemented. Reproduced in recent trunk build: Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 92e5898fa9ffa4dd8742f5f26e790563feef286e CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: oox/inc
oox/inc/drawingml/connectorhelper.hxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 5fe2bf914c251009ec4709fa8fdc45c3b53f676b Author: Andrea Gelmini AuthorDate: Wed Nov 15 12:51:08 2023 +0100 Commit: Julien Nabet CommitDate: Wed Nov 15 23:50:56 2023 +0100 Fix typo Change-Id: Iab90ee3e42390d9f68a5b2ac0e4d0e2e3eb37a80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159439 Tested-by: Julien Nabet Reviewed-by: Julien Nabet diff --git a/oox/inc/drawingml/connectorhelper.hxx b/oox/inc/drawingml/connectorhelper.hxx index cfbf4b75d27c..1e875ab8ee95 100644 --- a/oox/inc/drawingml/connectorhelper.hxx +++ b/oox/inc/drawingml/connectorhelper.hxx @@ -103,6 +103,6 @@ void applyConnections(oox::drawingml::ShapePtr& rConnector, oox::drawingml::Shap */ void applyBentHandleAdjustments(oox::drawingml::ShapePtr pConnector); -} // end namespace ConnecorHelper +} // end namespace ConnectorHelper -/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */ \ No newline at end of file +/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
[Libreoffice-commits] core.git: oox/qa
oox/qa/unit/wpc_drawing_canvas.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 6527c4f75f574105f61561d629f2c8d051483d65
Author: Andrea Gelmini
AuthorDate: Wed Nov 15 12:50:00 2023 +0100
Commit: Julien Nabet
CommitDate: Wed Nov 15 23:49:49 2023 +0100
Fix typo
Change-Id: Ifc1b536a003194de5271b348c363bf4bd9b9a9e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159437
Tested-by: Julien Nabet
Reviewed-by: Julien Nabet
diff --git a/oox/qa/unit/wpc_drawing_canvas.cxx
b/oox/qa/unit/wpc_drawing_canvas.cxx
index a141776c9d6d..0857eb8099cf 100644
--- a/oox/qa/unit/wpc_drawing_canvas.cxx
+++ b/oox/qa/unit/wpc_drawing_canvas.cxx
@@ -132,7 +132,7 @@ CPPUNIT_TEST_FIXTURE(TestWPC, WPC_Glow)
CPPUNIT_TEST_FIXTURE(TestWPC, WPC_BentConnector)
{
-// The document has two shapes connected with a bentConnecor on a drawing
canvas.
+// The document has two shapes connected with a bentConnector on a drawing
canvas.
loadFromURL(u"WPC_BentConnector.docx");
// VML has no information about the target shapes of the connector. The
connector was imported as
@@ -214,7 +214,7 @@ CPPUNIT_TEST_FIXTURE(TestWPC, WPC_tdf104671_Cloud)
// The document has 'cloud' shape on a drawing canvas.
loadFromURL(u"WPC_tdf104671_Cloud.docx");
-// MS Office writes the 'cloud' shape without type to the VML fallback.
Thus the VML import uses
+// MS Office writes the 'cloud' shape without type to the VML fallback.
Thus the VLM import uses
// ClosedBezierShape with several closed polygons. That produces holes
because of the even-odd
// rule, and inner lines. The fix uses the mc:Choice alternative which
provides the type for a
// custom shape.
[Libreoffice-commits] core.git: oox/inc
oox/inc/drawingml/connectorhelper.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 5f72ab66b16d39db124eed5834fc715f8807da21 Author: Andrea Gelmini AuthorDate: Wed Nov 15 12:50:16 2023 +0100 Commit: Julien Nabet CommitDate: Wed Nov 15 23:48:32 2023 +0100 Fix typo Change-Id: I6bbf45f4aaf7412864bdb6697184616f7ef14138 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159438 Tested-by: Julien Nabet Reviewed-by: Julien Nabet diff --git a/oox/inc/drawingml/connectorhelper.hxx b/oox/inc/drawingml/connectorhelper.hxx index dec1deb6a238..cfbf4b75d27c 100644 --- a/oox/inc/drawingml/connectorhelper.hxx +++ b/oox/inc/drawingml/connectorhelper.hxx @@ -70,7 +70,7 @@ void getOOXHandlePositionsHmm(const oox::drawingml::ShapePtr& pConnector, basegfx::B2DHomMatrix getConnectorTransformMatrix(const oox::drawingml::ShapePtr& pConnector); /** - * Calulates the handle positions of a connector of type ConnectorType_STANDARD. Such connector + * Calculates the handle positions of a connector of type ConnectorType_STANDARD. Such connector * corresponds to the OOXML bentConnector shapes, aka "ElbowConnector". The calculation is based on * the actual polygon of the connector. The coordinates are always returned in Hmm, even for shapes * on a text document draw page.
[Libreoffice-commits] core.git: oox/qa
oox/qa/unit/wpc_drawing_canvas.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e562fc75dcf1582ea2201ae91e9c5ac3c99848a7 Author: Andrea Gelmini AuthorDate: Wed Nov 15 12:53:17 2023 +0100 Commit: Julien Nabet CommitDate: Wed Nov 15 23:48:09 2023 +0100 Fix typo Change-Id: I912f5e5a035d00e7640d489b1ff1c7a3c0315b9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159442 Tested-by: Julien Nabet Reviewed-by: Julien Nabet diff --git a/oox/qa/unit/wpc_drawing_canvas.cxx b/oox/qa/unit/wpc_drawing_canvas.cxx index 7e1af1273d1e..a141776c9d6d 100644 --- a/oox/qa/unit/wpc_drawing_canvas.cxx +++ b/oox/qa/unit/wpc_drawing_canvas.cxx @@ -214,7 +214,7 @@ CPPUNIT_TEST_FIXTURE(TestWPC, WPC_tdf104671_Cloud) // The document has 'cloud' shape on a drawing canvas. loadFromURL(u"WPC_tdf104671_Cloud.docx"); -// MS Office writes the 'cloud' shape without type to the VML fallback. Thus the VLM import uses +// MS Office writes the 'cloud' shape without type to the VML fallback. Thus the VML import uses // ClosedBezierShape with several closed polygons. That produces holes because of the even-odd // rule, and inner lines. The fix uses the mc:Choice alternative which provides the type for a // custom shape.
[Libreoffice-commits] core.git: oox/source
oox/source/shape/ShapeContextHandler.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 6e4ea6d73b2a4f3ae56169933d82596f92e88f0d
Author: Andrea Gelmini
AuthorDate: Wed Nov 15 12:52:49 2023 +0100
Commit: Julien Nabet
CommitDate: Wed Nov 15 23:47:22 2023 +0100
Fix typo
Change-Id: I24bda03e65353510810a08a6df6061e21e11915a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159441
Tested-by: Julien Nabet
Reviewed-by: Julien Nabet
diff --git a/oox/source/shape/ShapeContextHandler.cxx
b/oox/source/shape/ShapeContextHandler.cxx
index 1d4ad9d323e4..19c2deb71f57 100644
--- a/oox/source/shape/ShapeContextHandler.cxx
+++ b/oox/source/shape/ShapeContextHandler.cxx
@@ -524,7 +524,7 @@ ShapeContextHandler::getShape()
oox::drawingml::ShapeIdMap aShapeMap;
lcl_createShapeMap(pShape, aShapeMap);
-// Travers aShapeMap and generate edge related properties.
+// Traverse aShapeMap and generate edge related properties.
for (auto& rIt : aShapeMap)
{
if ((rIt.second)->getServiceName() ==
"com.sun.star.drawing.ConnectorShape")
[Libreoffice-commits] core.git: oox/source
oox/source/shape/ShapeContextHandler.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 201e288e9886987eae467035b42863ac032f7e8f Author: Andrea Gelmini AuthorDate: Wed Nov 15 12:51:55 2023 +0100 Commit: Julien Nabet CommitDate: Wed Nov 15 23:46:50 2023 +0100 Fix typo Change-Id: Ia0082b62e8dd6e93267995140fc61b91b6080cb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159440 Tested-by: Julien Nabet Reviewed-by: Julien Nabet diff --git a/oox/source/shape/ShapeContextHandler.cxx b/oox/source/shape/ShapeContextHandler.cxx index 53ddd3f575be..1d4ad9d323e4 100644 --- a/oox/source/shape/ShapeContextHandler.cxx +++ b/oox/source/shape/ShapeContextHandler.cxx @@ -538,7 +538,7 @@ ShapeContextHandler::getShape() ConnectorHelper::applyBentHandleAdjustments(rIt.second); } // else use the default path of LibreOffice -// curveConnecto2 and bentConnector2 do not have handles. +// curvedConnector2 and bentConnector2 do not have handles. // ToDo: OOXML defines a path for curveConnector3, curveConnector4 and // curveConnector5 that is basically incompatible with the way LibreOffice // creates the path.
[Libreoffice-bugs] [Bug 153001] Search for commands: add more styling commands
https://bugs.documentfoundation.org/show_bug.cgi?id=153001 Stéphane Guillou (stragu) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||stephane.guillou@libreoffic ||e.org Resolution|--- |DUPLICATE Whiteboard| QA:needsComment| --- Comment #1 from Stéphane Guillou (stragu) --- Thank you for the suggestion. I understand this to be the same as bug 150814, which requests adding all UNO commands to the Search Commands HUD. *** This bug has been marked as a duplicate of bug 150814 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150814] Search Commands should also search commands _not_ on the menus
https://bugs.documentfoundation.org/show_bug.cgi?id=150814 Stéphane Guillou (stragu) changed: What|Removed |Added CC||avidseek...@protonmail.com --- Comment #7 from Stéphane Guillou (stragu) --- *** Bug 153001 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: include/sfx2 sfx2/source sfx2/uiconfig solenv/sanitizers
include/sfx2/passwd.hxx|3 ++
sfx2/source/dialog/passwd.cxx | 45
sfx2/uiconfig/ui/password.ui | 56 -
solenv/sanitizers/ui/sfx.suppr |4 ++
4 files changed, 96 insertions(+), 12 deletions(-)
New commits:
commit ed72c6fbfa02cf98cb0d0f761ef5a7b9ffb894bc
Author: Sarper Akdemir
AuthorDate: Wed Nov 15 14:54:42 2023 +0300
Commit: Sarper Akdemir
CommitDate: Wed Nov 15 23:05:49 2023 +0100
tdf#157518: enforce password policy on sfx2/ui/password.ui
Change-Id: I115b5b05ed82f2f900bcd70ec4f52c7f749544e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159443
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir
diff --git a/include/sfx2/passwd.hxx b/include/sfx2/passwd.hxx
index bc5e478bbf03..3ddffed196d0 100644
--- a/include/sfx2/passwd.hxx
+++ b/include/sfx2/passwd.hxx
@@ -51,6 +51,7 @@ private:
std::unique_ptr m_xPassword1FT;
std::unique_ptr m_xPassword1ED;
std::unique_ptr m_xPassword1StrengthBar;
+std::unique_ptr m_xPassword1PolicyLabel;
std::unique_ptr m_xConfirm1FT;
std::unique_ptr m_xConfirm1ED;
@@ -58,6 +59,7 @@ private:
std::unique_ptr m_xPassword2FT;
std::unique_ptr m_xPassword2ED;
std::unique_ptr m_xPassword2StrengthBar;
+std::unique_ptr m_xPassword2PolicyLabel;
std::unique_ptr m_xConfirm2FT;
std::unique_ptr m_xConfirm2ED;
@@ -74,6 +76,7 @@ private:
OUStringmaMainPwdStr;
sal_uInt16 mnMinLen;
SfxShowExtras mnExtras;
+std::optional moPasswordPolicy;
boolmbAsciiOnly;
DECL_DLLPRIVATE_LINK(OKHdl, weld::Button&, void);
diff --git a/sfx2/source/dialog/passwd.cxx b/sfx2/source/dialog/passwd.cxx
index a69d0aef352a..b78546722cb9 100644
--- a/sfx2/source/dialog/passwd.cxx
+++ b/sfx2/source/dialog/passwd.cxx
@@ -17,6 +17,7 @@
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
+#include
#include
#include
#include
@@ -38,15 +39,35 @@ void SfxPasswordDialog::ModifyHdl()
bEnable = (bEnable && (m_xPassword2ED->get_text().getLength() >=
mnMinLen));
m_xOKBtn->set_sensitive(bEnable);
+// if there's a confirm entry, the dialog is being used for setting a
password
if (m_xConfirm1ED->get_visible())
{
m_xPassword1StrengthBar->set_percentage(
SvPasswordHelper::GetPasswordStrengthPercentage(aPassword1Text));
+bool bPasswordMeetsPolicy = SvPasswordHelper::PasswordMeetsPolicy(
+aPassword1Text, moPasswordPolicy);
+m_xPassword1ED->set_message_type(bPasswordMeetsPolicy ?
weld::EntryMessageType::Normal
+ :
weld::EntryMessageType::Error);
+m_xPassword1PolicyLabel->set_visible(!bPasswordMeetsPolicy);
}
+
+// if there's a confirm entry, the dialog is being used for setting a
password
if (m_xConfirm2ED->get_visible())
{
+OUString aPassword2Text = m_xPassword2ED->get_text();
+
m_xPassword2StrengthBar->set_percentage(
SvPasswordHelper::GetPasswordStrengthPercentage(m_xPassword2ED->get_text()));
+
+// second password is optional, ignore policy if it is empty
+bool bPasswordMeetsPolicy
+= aPassword2Text.isEmpty()
+ ? true
+ : SvPasswordHelper::PasswordMeetsPolicy(
+ aPassword2Text, moPasswordPolicy);
+m_xPassword2ED->set_message_type(bPasswordMeetsPolicy ?
weld::EntryMessageType::Normal
+ :
weld::EntryMessageType::Error);
+m_xPassword2PolicyLabel->set_visible(!bPasswordMeetsPolicy);
}
}
@@ -81,6 +102,19 @@ IMPL_LINK(SfxPasswordDialog, InsertTextHdl, OUString&,
rTest, bool)
IMPL_LINK_NOARG(SfxPasswordDialog, OKHdl, weld::Button&, void)
{
+if (m_xConfirm1ED->get_visible()
+&& !SvPasswordHelper::PasswordMeetsPolicy(GetPassword(),
moPasswordPolicy))
+{
+m_xPassword1ED->grab_focus();
+return;
+}
+if (m_xConfirm2ED->get_visible() && !GetPassword2().isEmpty()
+&& !SvPasswordHelper::PasswordMeetsPolicy(GetPassword2(),
moPasswordPolicy))
+{
+m_xPassword2ED->grab_focus();
+return;
+}
+
bool bConfirmFailed = bool( mnExtras & SfxShowExtras::CONFIRM ) &&
( GetConfirm() != GetPassword() );
if( ( mnExtras & SfxShowExtras::CONFIRM2 ) && ( m_xConfirm2ED->get_text()
!= GetPassword2() ) )
@@ -114,12 +148,14 @@ SfxPasswordDialog::SfxPasswordDialog(weld::Widget*
pParent, const OUString* pGro
, m_xPassword1FT(m_xBuilder->weld_label("pass1ft"))
, m_xPassword1ED(m_xBuilder->weld_entry("pass1ed"))
, m_xPassword1StrengthBar(m_xBuilder->weld_level_bar("pass1bar"))
+, m_xPassword1PolicyLabel(m_xBuilder->weld_label("pass1policylabel"))
, m_xConfirm1FT(m_xBuilder->weld_label("confirm1ft"))
[Libreoffice-commits] core.git: include/oox oox/source
include/oox/drawingml/connectorshapecontext.hxx |1 +
oox/source/shape/WordprocessingCanvasContext.hxx |1 +
2 files changed, 2 insertions(+)
New commits:
commit 6550c248521b65a367b33ba8db95d17a9a350800
Author: Regina Henschel
AuthorDate: Wed Nov 15 19:24:59 2023 +0100
Commit: Regina Henschel
CommitDate: Wed Nov 15 22:38:39 2023 +0100
Add comments to import of Wordprocessing Canvas
Change-Id: I09af78b08fed886e36beca1770db6fc54a72b707
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159473
Tested-by: Jenkins
Reviewed-by: Regina Henschel
diff --git a/include/oox/drawingml/connectorshapecontext.hxx
b/include/oox/drawingml/connectorshapecontext.hxx
index 9911ce84de53..2b95ff4f3d4c 100644
--- a/include/oox/drawingml/connectorshapecontext.hxx
+++ b/include/oox/drawingml/connectorshapecontext.hxx
@@ -39,6 +39,7 @@ namespace oox::drawingml {
sal_Int32 mnDestGlueId;
};
+/// Handles CT_NonVisualConnectorProperties, used for cNvCnPr (Word) and
cNvCxnSpPr (PP) elements.
class ConnectorShapePropertiesContext : public ::oox::core::ContextHandler2
{
std::vector& mrConnectorShapePropertiesList;
diff --git a/oox/source/shape/WordprocessingCanvasContext.hxx
b/oox/source/shape/WordprocessingCanvasContext.hxx
index dbb2148967e8..d4cc67f6a9ba 100644
--- a/oox/source/shape/WordprocessingCanvasContext.hxx
+++ b/oox/source/shape/WordprocessingCanvasContext.hxx
@@ -14,6 +14,7 @@
namespace oox::shape
{
+/// Handles CT_WordprocessingCanvas, used for wpc element, which is a drawing
canvas for Word.
class WordprocessingCanvasContext final : public oox::core::FragmentHandler2
{
public:
[Libreoffice-bugs] [Bug 136258] FILEOPEN DOCX Long text is not broken in rectangle inside canvas
https://bugs.documentfoundation.org/show_bug.cgi?id=136258 --- Comment #6 from Regina Henschel --- With commit https://cgit.freedesktop.org/libreoffice/core/commit/?id=0430adb42bc38f037b907984e71c144d863796cb the wpc element is used instead of the VML fallback. Now the rectangles are imported as custom shape and the text wraps. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 100490] FILEOPEN: docx graphic import does not honor char color
https://bugs.documentfoundation.org/show_bug.cgi?id=100490 Regina Henschel changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||3110 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 123110] FILEOPEN DOCX Text in shape has wrong color
https://bugs.documentfoundation.org/show_bug.cgi?id=123110 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||0490 --- Comment #10 from Regina Henschel --- Seems to be the same font color problem as in bug 100490. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: cui/source
cui/source/dialogs/SpellDialog.cxx |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit 7a4a5de2d932b6edfc53b6742029e266c52fa127
Author: Oliver Specht
AuthorDate: Wed Nov 15 16:49:58 2023 +0100
Commit: Caolán McNamara
CommitDate: Wed Nov 15 22:19:59 2023 +0100
tdf#157992 update error position after modifying input
a manual fix in the text changes the start/end position of the error
that needs to be updateed to find the correct error text when applying the
change
Change-Id: I91b0801d5a08ee9e2508493cce03b8112c48a542
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159449
Tested-by: Jenkins
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/cui/source/dialogs/SpellDialog.cxx
b/cui/source/dialogs/SpellDialog.cxx
index 80e1301dcaf8..3ad9c2b196b0 100644
--- a/cui/source/dialogs/SpellDialog.cxx
+++ b/cui/source/dialogs/SpellDialog.cxx
@@ -1571,6 +1571,8 @@ bool SentenceEditWindow_Impl::KeyInput(const KeyEvent&
rKeyEvt)
//start position
if (!IsUndoEditMode() && bIsErrorActive)
{
+aAttribList.clear();
+m_xEditEngine->GetCharAttribs(0, aAttribList);
const EECharAttrib* pFontColor = FindCharAttrib(nCursor,
EE_CHAR_COLOR, aAttribList);
const EECharAttrib* pErrorAttrib = FindCharAttrib(m_nErrorStart,
EE_CHAR_GRABBAG, aAttribList);
if (pFontColor && pErrorAttrib)
@@ -2035,7 +2037,6 @@ svx::SpellPortions
SentenceEditWindow_Impl::CreateSpellPortions() const
aPortion1.eLanguage = eLang;
aPortion1.sText = m_xEditEngine->GetText(ESelection(0, nStart,
0, aStart->nPosition));
-
bool bIsIgnoreError = m_aIgnoreErrorsAt.find( nStart ) !=
m_aIgnoreErrorsAt.end();
if( bIsIgnoreError )
{
[Libreoffice-bugs] [Bug 158233] New: the main MSI archive contains translated icons in help directory
https://bugs.documentfoundation.org/show_bug.cgi?id=158233 Bug ID: 158233 Summary: the main MSI archive contains translated icons in help directory Product: LibreOffice Version: 7.6.2.1 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Documentation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jerome.bo...@laposte.net CC: olivier.hal...@libreoffice.org I extracted the content of the LibreOffice_7.6.2_Win_x86-64.msi archive (345MB) with msiextract. I searched for translated content with the below command : find help -type d -name ar -o -name de -o -name es -o -name fr -o -name hu -o -name it I got the below results : help/media/icon-themes/cmd/32/it help/media/icon-themes/cmd/32/hu help/media/icon-themes/cmd/32/de help/media/icon-themes/cmd/32/ar help/media/icon-themes/cmd/32/es help/media/icon-themes/cmd/32/fr help/media/icon-themes/cmd/it help/media/icon-themes/cmd/hu help/media/icon-themes/cmd/de help/media/icon-themes/cmd/ar help/media/icon-themes/cmd/es help/media/icon-themes/cmd/fr The translated icons use ~338 kB for the following translations : ar, de, es, fr, hu, it, km, ko, nl, pl, ru, sl, tr. Could we possibly move those translated icons in their translated help MSI package ? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: uui/source uui/uiconfig
uui/source/masterpasscrtdlg.cxx | 25 ++
uui/source/masterpasscrtdlg.hxx |2 +
uui/uiconfig/ui/setmasterpassworddlg.ui | 44 ++--
3 files changed, 64 insertions(+), 7 deletions(-)
New commits:
commit fed7b3068dcea2ebf65314c4f212350720631706
Author: Sarper Akdemir
AuthorDate: Mon Nov 13 17:19:01 2023 +0300
Commit: Sarper Akdemir
CommitDate: Wed Nov 15 22:02:16 2023 +0100
tdf#157518: enforce password policy on setmasterpassworddlg
Change-Id: I7e7adde8f0d55808d16dc9247954a7645a1d3601
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159384
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir
diff --git a/uui/source/masterpasscrtdlg.cxx b/uui/source/masterpasscrtdlg.cxx
index 2216ea5a1d48..f0c456365646 100644
--- a/uui/source/masterpasscrtdlg.cxx
+++ b/uui/source/masterpasscrtdlg.cxx
@@ -17,6 +17,7 @@
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
+#include
#include
#include
#include
@@ -33,10 +34,27 @@ IMPL_LINK_NOARG(MasterPasswordCreateDialog, EditHdl_Impl,
weld::Entry&, void)
m_xOKBtn->set_sensitive(aPasswordText.getLength() >= 1);
m_xPasswdStrengthBar->set_percentage(
SvPasswordHelper::GetPasswordStrengthPercentage(aPasswordText));
+
+if(m_oPasswordPolicy)
+{
+bool bPasswordMeetsPolicy
+= SvPasswordHelper::PasswordMeetsPolicy(aPasswordText,
m_oPasswordPolicy);
+m_xEDMasterPasswordCrt->set_message_type(bPasswordMeetsPolicy ?
weld::EntryMessageType::Normal
+ :
weld::EntryMessageType::Error);
+m_xPasswordPolicyLabel->set_visible(!bPasswordMeetsPolicy);
+}
}
IMPL_LINK_NOARG(MasterPasswordCreateDialog, OKHdl_Impl, weld::Button&, void)
{
+if (m_oPasswordPolicy
+&&
!SvPasswordHelper::PasswordMeetsPolicy(m_xEDMasterPasswordCrt->get_text(),
+ m_oPasswordPolicy))
+{
+m_xEDMasterPasswordCrt->grab_focus();
+return;
+}
+
// compare both passwords and show message box if there are not equal!!
if (m_xEDMasterPasswordCrt->get_text() ==
m_xEDMasterPasswordRepeat->get_text())
m_xDialog->response(RET_OK);
@@ -57,13 +75,20 @@
MasterPasswordCreateDialog::MasterPasswordCreateDialog(weld::Window* pParent, co
: GenericDialogController(pParent, "uui/ui/setmasterpassworddlg.ui",
"SetMasterPasswordDialog")
, rResLocale(rLocale)
, m_xEDMasterPasswordCrt(m_xBuilder->weld_entry("password1"))
+, m_xPasswordPolicyLabel(m_xBuilder->weld_label("passpolicylabel"))
, m_xEDMasterPasswordRepeat(m_xBuilder->weld_entry("password2"))
, m_xOKBtn(m_xBuilder->weld_button("ok"))
, m_xPasswdStrengthBar(m_xBuilder->weld_level_bar("password1levelbar"))
+,
m_oPasswordPolicy(officecfg::Office::Common::Security::Scripting::PasswordPolicy::get())
{
m_xOKBtn->set_sensitive(false);
m_xOKBtn->connect_clicked( LINK( this, MasterPasswordCreateDialog,
OKHdl_Impl ) );
m_xEDMasterPasswordCrt->connect_changed( LINK( this,
MasterPasswordCreateDialog, EditHdl_Impl ) );
+if (m_oPasswordPolicy)
+{
+m_xPasswordPolicyLabel->set_label(
+
officecfg::Office::Common::Security::Scripting::PasswordPolicyErrorMessage::get());
+}
}
MasterPasswordCreateDialog::~MasterPasswordCreateDialog()
diff --git a/uui/source/masterpasscrtdlg.hxx b/uui/source/masterpasscrtdlg.hxx
index f7f01cda79cc..83f981190bb1 100644
--- a/uui/source/masterpasscrtdlg.hxx
+++ b/uui/source/masterpasscrtdlg.hxx
@@ -27,9 +27,11 @@ private:
const std::locale& rResLocale;
std::unique_ptr m_xEDMasterPasswordCrt;
+std::unique_ptr m_xPasswordPolicyLabel;
std::unique_ptr m_xEDMasterPasswordRepeat;
std::unique_ptr m_xOKBtn;
std::unique_ptr m_xPasswdStrengthBar;
+std::optional m_oPasswordPolicy;
DECL_LINK(OKHdl_Impl, weld::Button&, void);
DECL_LINK(EditHdl_Impl, weld::Entry&, void);
diff --git a/uui/uiconfig/ui/setmasterpassworddlg.ui
b/uui/uiconfig/ui/setmasterpassworddlg.ui
index 52cec48eb30a..1fd06e0e5c57 100644
--- a/uui/uiconfig/ui/setmasterpassworddlg.ui
+++ b/uui/uiconfig/ui/setmasterpassworddlg.ui
@@ -95,14 +95,43 @@
-
+
+
True
-False
-6
-_Enter password:
-True
-password1
-0
+False
+12
+1
+
+
+True
+False
+end
+6
+True
+_Enter password:
+True
+password1
+0
+
+
+0
+0
+
[Libreoffice-bugs] [Bug 58452] FILEOPEN: docx embedded image object does not show up
https://bugs.documentfoundation.org/show_bug.cgi?id=58452 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #14 from Regina Henschel --- It is lockedCanvas not a drawing canvas. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158218] Document is not saved if solely text is pasted since last save
https://bugs.documentfoundation.org/show_bug.cgi?id=158218 firebea...@gmail.com changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #2 from firebea...@gmail.com --- Thanks for the quick reply m.a.riosv, really appreciated I just tested in the safe mode as you described, and I'm still able to reproduce the issue Would a video showing the issue be helpful? The build / system info as requested: Version: 7.5.8.2 (X86_64) / LibreOffice Community Build ID: 50(Build:2) CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: kf5 (cairo+xcb) Locale: en-US (C); UI: en-US 7.5.8-1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103270] [META] Image/Picture dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103270 Bug 103270 depends on bug 147365, which changed state. Bug 147365 Summary: Don't Print but export to PDF - Picture settings should allow to set not to print but show in PDF https://bugs.documentfoundation.org/show_bug.cgi?id=147365 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147365] Don't Print but export to PDF - Picture settings should allow to set not to print but show in PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=147365 Stéphane Guillou (stragu) changed: What|Removed |Added Resolution|--- |WONTFIX Status|UNCONFIRMED |RESOLVED --- Comment #12 from Stéphane Guillou (stragu) --- (In reply to Mannshoch from comment #10) > Ah sorry, it seems I did not understand. I also not know what WF means. > Sorry. "WF" is used here to mean closing a report as "won't fix" - often the case when an enhancement request is considered not worth it or necessary by most. (In reply to V Stuart Foote from comment #11) > What about print to PDF using gs/ps based libs? Why any different? [...] IMHO > => WF Mannshoch just said they didn't know what "WF" meant, so let's try to not overuse abbreviations here. [1] I assume you mean "ghostscript / postscript -based libraries". (In reply to V Stuart Foote from comment #11) > So NO, lets not attempt distinction in handling raster images (i.e. > pictures) between printing filters and export filters [...] In my opinion, the feature does sound like it only affects paper printing. And it does not help that exporting to XHTML _does_ include such a picture. So maybe we need to: * re-label the setting in the dialog to something that clarifies that it applies to both printing and exporting to various file formats. * also change the extended tip, which currently is: "Includes the selected item when you print the document"[2] * expand the help page, currently the same as the extended tip[3] * exclude such pictures from the XHTML export for consistency In any case, closing as won't fix for this particular enhancement request. Mannshoch, please try the method using a graphic style in Writer for all such images, and then switching the Print property on or off just once in the style depending on if you will print or export to PDF. If you need assistance with it, feel free to open a question on ask.libreoffice.org. Thank you! [1]: https://wiki.documentfoundation.org/Development/Acronyms [2]: https://opengrok.libreoffice.org/xref/core/sw/uiconfig/swriter/ui/frmaddpage.ui?r=2721520c#420 [3]: https://help.libreoffice.org/24.2/en-US/text/swriter/01/05060900.html -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 67775] FILESAVE DOCX Incorrect lines connecting shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=67775 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #16 from Regina Henschel --- The connectors should be OK after commit https://cgit.freedesktop.org/libreoffice/core/commit/?id=0430adb42bc38f037b907984e71c144d863796cb Please try it with a daily build, that contains this commit, likely included in daily build from tomorrow. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'feature/cib_contract891c' - configure.ac scp2/source
configure.ac |7 ++-
scp2/source/ooo/vc_redist.scp | 18 ++
2 files changed, 24 insertions(+), 1 deletion(-)
New commits:
commit 137aa1fe40741aa1474cdcd3160317fc51beb564
Author: Michael Stahl
AuthorDate: Fri Jan 19 20:47:03 2018 +0100
Commit: Gabor Kelemen
CommitDate: Wed Nov 15 20:44:38 2023 +0100
scp2: also try VC141_CRT_*.msm
Apparently the MSMs have been renamed in Visual Studio 2017.3 but only
configure was adapted, not scp2.
Not sure if these MSMs are still relevant given the new
gid_File_Vcredist_Exe thing.
Change-Id: I4fe27c8298b3a2024acc62d12ce8ea67e2eca80d
diff --git a/configure.ac b/configure.ac
index d46123ac0fcb..ddcc14b2f7bd 100644
--- a/configure.ac
+++ b/configure.ac
@@ -6741,7 +6741,12 @@ if test $_os = "WINNT"; then
MSVC_DLL_PATH="$msvcdllpath"
MSVC_DLLS="$msvcdlls"
MSM_PATH="$msmdir"
-SCPDEFS="$SCPDEFS -DWITH_VC${VCVER}_REDIST"
+# MSVC 15.3 changed it to VC141
+if echo "$MSVC_DLL_PATH" | grep -q "VC141.CRT$"; then
+SCPDEFS="$SCPDEFS -DWITH_VC141_REDIST"
+else
+SCPDEFS="$SCPDEFS -DWITH_VC${VCVER}_REDIST"
+fi
if test "$UCRT_REDISTDIR" = "no"; then
dnl explicitly disabled
UCRT_REDISTDIR=""
diff --git a/scp2/source/ooo/vc_redist.scp b/scp2/source/ooo/vc_redist.scp
index 9b534a3f27fd..727c13b27615 100644
--- a/scp2/source/ooo/vc_redist.scp
+++ b/scp2/source/ooo/vc_redist.scp
@@ -56,3 +56,21 @@ End
#endif
+#if defined(WITH_VC141_REDIST)
+
+#if defined WINDOWS_X64
+MergeModule gid_MergeModule_Microsoft_VC141_CRT_x64
+#else
+MergeModule gid_MergeModule_Microsoft_VC141_CRT_x86
+#endif
+Feature = gm_Root;
+#if defined WINDOWS_X64
+Name = "Microsoft_VC141_CRT_x64.msm";
+#else
+Name = "Microsoft_VC141_CRT_x86.msm";
+#endif
+RootDir = "TARGETDIR";
+ComponentCondition = "VC_REDIST=1";
+End
+
+#endif
[Libreoffice-bugs] [Bug 154396] FILEOPEN DOCX Connector shape inside canvas gets longer
https://bugs.documentfoundation.org/show_bug.cgi?id=154396 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #3 from Regina Henschel --- I think, it looks OK now with commit https://cgit.freedesktop.org/libreoffice/core/commit/?id=0430adb42bc38f037b907984e71c144d863796cb (Gerrit https://gerrit.libreoffice.org/c/core/+/156629) The commit should be included in the build from tomorrow. Please try it out then. -- You are receiving this mail because: You are the assignee for the bug.
jfeal license statement
All of my past & future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license.
[Libreoffice-bugs] [Bug 158232] New: Major failure in Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=158232 Bug ID: 158232 Summary: Major failure in Draw Product: LibreOffice Version: 7.4.7.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: es...@ieee.org Created attachment 190849 --> https://bugs.documentfoundation.org/attachment.cgi?id=190849=edit tray icon of minimized window I attempted to open a pdf in Draw. It opened but the screen was maximized. This, by the way is a flaw in and of itself. With the availability of 4K screens, like mine, no one would ever want the windows to cover the entire screen by default since the document only occupies a small portion in the center. Nevertheless, I clicked the icon in the title bar to restore the normal view not realizing that Debian Cinnamon never bothered to implement the industry standard of 3 sizing buttons (min, normal and max). . The next thing that happened was that the window disappeared from the screen. It apparently minimized instead of going to normal view. The thumbnail showed so little that it was impossible to tell what was going on. The file was probably still open. I used the rt-lick in the tray to close Draw, verified that the file was intact, and then tried to open it again with Draw. The screen-shot shows the tray. Clicking on the thumbnail does NOT restore the window. If I rt-click on the tray icon and choose maximize, the window maximizes. Double-clicking on the title bar toggles between max and min. I tried dragging the title-bar, which on other apps, pulls it away from maximized and restores the "normal" view. In LO, it is not possible to drag the maximized window so there is no way to get the window to only occupy a part of the screen. This is, IMHO, a serious conceptual design flaw especially given that huge screens, including double-wide curved screens, are becoming more common. If this isn't or can't be fixed I will have no choice but to find a different office suite. I anticipate a response to the effect that "we have no control over how a particular OS or Desktop handles windows". My response would be that the title-bar drag works in LO Writer and LO Calc but it does NOT work in LO Draw. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158031] Writer in editeng: right click doesn't edit hyperlink in when mouse over last half / cursor after hyperlink
https://bugs.documentfoundation.org/show_bug.cgi?id=158031 Justin L changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |jl...@mail.com |desktop.org | OS|Linux (All) |All --- Comment #16 from Justin L --- (In reply to Buovjaga from comment #6) > > The same problem applies to Open, Copy, and Remove, even in Windows/gen, if > > you: > > -right-click on the second half of the hyperlink > > -move the mouse away from the field and the menu (ex. over the footer area) > > -use the keyboard to select one of the hyperlink options. > >-nothing happens. > > After clicking OK, Edit Hyperlink does not open the dialog with gtk3. Kf5 > works, though. But it wouldn't have worked in Kf5 if you followed the Windows/gen breaking steps. It should now that it is fixed. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107733] [META] Hyperlink bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107733 Bug 107733 depends on bug 158031, which changed state. Bug 158031 Summary: Writer in editeng: right click doesn't edit hyperlink in when mouse over last half / cursor after hyperlink https://bugs.documentfoundation.org/show_bug.cgi?id=158031 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158031] Writer in editeng: right click doesn't edit hyperlink in when mouse over last half / cursor after hyperlink
https://bugs.documentfoundation.org/show_bug.cgi?id=158031 --- Comment #15 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/32d0efa9d934ec45f2863a285d250dfc0ab137e8 tdf#158031 editeng: rename GetFieldAtCursor It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158031] Writer in editeng: right click doesn't edit hyperlink in when mouse over last half / cursor after hyperlink
https://bugs.documentfoundation.org/show_bug.cgi?id=158031 --- Comment #14 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/33ec38c5333e0c71aa995292fbddc1a237979e32 tdf#158031 editeng SID_HYPERLINK_GETLINK: use GetFieldAtSelection It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: 2 commits - editeng/source include/editeng sc/source sd/source
editeng/source/editeng/editview.cxx|2 +-
editeng/source/misc/urlfieldhelper.cxx |3 ++-
editeng/source/outliner/outlvw.cxx |5 -
include/editeng/editview.hxx |2 +-
include/editeng/outliner.hxx |4 +---
sc/source/ui/drawfunc/drtxtob.cxx |3 ++-
sc/source/ui/view/editsh.cxx |2 +-
sd/source/ui/view/drviewsf.cxx |3 ++-
8 files changed, 10 insertions(+), 14 deletions(-)
New commits:
commit 32d0efa9d934ec45f2863a285d250dfc0ab137e8
Author: Justin Luth
AuthorDate: Mon Nov 6 16:53:50 2023 -0500
Commit: Justin Luth
CommitDate: Wed Nov 15 20:05:38 2023 +0100
tdf#158031 editeng: rename GetFieldAtCursor
because it doesn't really get the field at the cursor,
and certainly is not similar to SelectFieldAtCursor.
It first gets the field under the mouse.
Then, if there is a selection, it gets the selected field,
else it looks for the field on either side.
There were LOTS of places where it
probably had not been used properly.
Most of those are gone now, so it is easier
to rename the function.
Change-Id: I1a64af24092582cf865509d2a474080258edd76c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159022
Reviewed-by: Justin Luth
Tested-by: Jenkins
diff --git a/editeng/source/editeng/editview.cxx
b/editeng/source/editeng/editview.cxx
index e1229b6918db..81cc8bf1aa56 100644
--- a/editeng/source/editeng/editview.cxx
+++ b/editeng/source/editeng/editview.cxx
@@ -1424,7 +1424,7 @@ void EditView::SelectFieldAtCursor()
assert(std::abs(aSel.nStartPos - aSel.nEndPos) == 1);
}
-const SvxFieldData* EditView::GetFieldAtCursor(bool bAlsoCheckBeforeCursor)
const
+const SvxFieldData* EditView::GetFieldUnderMouseOrInSelectionOrAtCursor(bool
bAlsoCheckBeforeCursor) const
{
const SvxFieldItem* pFieldItem = GetFieldUnderMousePointer();
if (!pFieldItem)
diff --git a/editeng/source/misc/urlfieldhelper.cxx
b/editeng/source/misc/urlfieldhelper.cxx
index d60d7be92934..57f2a042c6b5 100644
--- a/editeng/source/misc/urlfieldhelper.cxx
+++ b/editeng/source/misc/urlfieldhelper.cxx
@@ -38,7 +38,8 @@ bool URLFieldHelper::IsCursorAtURLField(const EditView&
pEditView, bool bAlsoChe
if (!bIsValidSelection)
return false;
-const SvxFieldData* pField =
pEditView.GetFieldAtCursor(bAlsoCheckBeforeCursor);
+const SvxFieldData* pField
+=
pEditView.GetFieldUnderMouseOrInSelectionOrAtCursor(bAlsoCheckBeforeCursor);
if (dynamic_cast(pField))
return true;
diff --git a/editeng/source/outliner/outlvw.cxx
b/editeng/source/outliner/outlvw.cxx
index 2649e865d6d7..136ecd776c26 100644
--- a/editeng/source/outliner/outlvw.cxx
+++ b/editeng/source/outliner/outlvw.cxx
@@ -1345,11 +1345,6 @@ const SvxFieldItem*
OutlinerView::GetFieldAtSelection(bool bAlsoCheckBeforeCurso
return pEditView->GetFieldAtSelection(bAlsoCheckBeforeCursor);
}
-const SvxFieldData* OutlinerView::GetFieldAtCursor() const
-{
-return pEditView->GetFieldAtCursor();
-}
-
void OutlinerView::SelectFieldAtCursor()
{
pEditView->SelectFieldAtCursor();
diff --git a/include/editeng/editview.hxx b/include/editeng/editview.hxx
index b54f6b463e1f..01a0e426c09a 100644
--- a/include/editeng/editview.hxx
+++ b/include/editeng/editview.hxx
@@ -334,7 +334,7 @@ public:
const SvxFieldItem* GetFieldAtSelection(bool* pIsBeforeCursor) const;
/// return field under mouse, at selection, or immediately after (or
before) the current cursor
-const SvxFieldData* GetFieldAtCursor(bool bAlsoCheckBeforeCursor = false)
const;
+const SvxFieldData* GetFieldUnderMouseOrInSelectionOrAtCursor(bool
bAlsoCheckBeforeCursor = false) const;
/// if no selection, select the field immediately after or before the
current cursor
void SelectFieldAtCursor();
/// Converts position in paragraph to logical position without unfolding
fields
diff --git a/include/editeng/outliner.hxx b/include/editeng/outliner.hxx
index 4f8d41e21b9b..35860b762037 100644
--- a/include/editeng/outliner.hxx
+++ b/include/editeng/outliner.hxx
@@ -307,9 +307,7 @@ public:
voidInsertField( const SvxFieldItem& rFld );
const SvxFieldItem* GetFieldUnderMousePointer() const;
const SvxFieldItem* GetFieldAtSelection(bool bAlsoCheckBeforeCursor =
false) const;
-/// Return the field at the current cursor position or nullptr if no field
found
-const SvxFieldData* GetFieldAtCursor() const;
-/// Select the field at the current cursor position
+/// if no selection, select the field immediately after or before the
current cursor
void SelectFieldAtCursor();
/** enables bullets for the selected paragraphs if the bullets/numbering
of the first paragraph is off
diff --git a/sc/source/ui/view/editsh.cxx b/sc/source/ui/view/editsh.cxx
index c48b7772f7e3..9ed398fb9876 100644
--- a/sc/source/ui/view/editsh.cxx
+++
[Libreoffice-bugs] [Bug 158031] Writer in editeng: right click doesn't edit hyperlink in when mouse over last half / cursor after hyperlink
https://bugs.documentfoundation.org/show_bug.cgi?id=158031 --- Comment #11 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/aaca48eb12357fa5cf23054fe77554bcfff74e95 tdf#158031 editeng SID_COPY_HYPERLINK: use AlsoCheckBeforeCursor It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158031] Writer in editeng: right click doesn't edit hyperlink in when mouse over last half / cursor after hyperlink
https://bugs.documentfoundation.org/show_bug.cgi?id=158031 --- Comment #13 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ac0b3ff84522a388e0d44b09bf681af13a8288b2 tdf#158031 editeng SID_REMOVE_HYPERLINK: use AlsoCheckBeforeCursor It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158031] Writer in editeng: right click doesn't edit hyperlink in when mouse over last half / cursor after hyperlink
https://bugs.documentfoundation.org/show_bug.cgi?id=158031 --- Comment #12 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0fc96d9b54e5a64c528bbf7fcdf9b71d74be8920 tdf#158031 editeng SID_OPEN_HYPERLINK: use AlsoCheckBeforeCursor It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158031] Writer in editeng: right click doesn't edit hyperlink in when mouse over last half / cursor after hyperlink
https://bugs.documentfoundation.org/show_bug.cgi?id=158031 --- Comment #10 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/023a2de2a8ef4bdcd9877e60f8739366de3a763c tdf#158031 Revert "Resolves: tdf#137445 use the DisableEditHyperlink state It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: 2 commits - editeng/source sc/source sd/source sw/source
editeng/source/misc/urlfieldhelper.cxx |3 ++-
sc/source/ui/drawfunc/drtxtob.cxx |5 +++--
sc/source/ui/view/editsh.cxx |7 ---
sd/source/ui/view/drviews2.cxx |8 +++-
sd/source/ui/view/drviewsf.cxx |3 ++-
sw/source/uibase/shells/drwtxtex.cxx |4 +++-
6 files changed, 17 insertions(+), 13 deletions(-)
New commits:
commit ac0b3ff84522a388e0d44b09bf681af13a8288b2
Author: Justin Luth
AuthorDate: Mon Nov 6 16:22:26 2023 -0500
Commit: Justin Luth
CommitDate: Wed Nov 15 20:05:07 2023 +0100
tdf#158031 editeng SID_REMOVE_HYPERLINK: use AlsoCheckBeforeCursor
This patch depends on prior patches for this bug report.
This is mostly just a clean-up patch to make it function like the others.
It was a lot like EDIT_HYPERLINK - because it selects the hyperlink first,
so it didn't need any fixing up.
However, there was one instance where KEYBOARD selection of
Remove Hyperlink in Draw could have been cancelled/slot-invalidated
if the mouse had been moved away from the field.
Change-Id: Id1b911f2548b8e2751ae34a2158ee4984dfc9a59
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159018
Reviewed-by: Justin Luth
Tested-by: Jenkins
diff --git a/editeng/source/misc/urlfieldhelper.cxx
b/editeng/source/misc/urlfieldhelper.cxx
index 1ed8647a15ae..d60d7be92934 100644
--- a/editeng/source/misc/urlfieldhelper.cxx
+++ b/editeng/source/misc/urlfieldhelper.cxx
@@ -16,7 +16,8 @@
void URLFieldHelper::RemoveURLField(EditView& pEditView)
{
pEditView.SelectFieldAtCursor();
-const SvxFieldData* pField = pEditView.GetFieldAtCursor();
+const SvxFieldItem* pFieldItem = pEditView.GetFieldAtSelection();
+const SvxFieldData* pField = pFieldItem ? pFieldItem->GetField() : nullptr;
if (auto pUrlField = dynamic_cast(pField))
{
ESelection aSel = pEditView.GetSelection();
diff --git a/sc/source/ui/drawfunc/drtxtob.cxx
b/sc/source/ui/drawfunc/drtxtob.cxx
index 1339e27bc4c1..863e97edc46b 100644
--- a/sc/source/ui/drawfunc/drtxtob.cxx
+++ b/sc/source/ui/drawfunc/drtxtob.cxx
@@ -327,7 +327,6 @@ void ScDrawTextObjectBar::Execute( SfxRequest )
case SID_REMOVE_HYPERLINK:
{
-// Ensure the field is selected first
URLFieldHelper::RemoveURLField(pOutView->GetEditView());
}
break;
diff --git a/sd/source/ui/view/drviews2.cxx b/sd/source/ui/view/drviews2.cxx
index ae77f5593045..90cde7c792f5 100644
--- a/sd/source/ui/view/drviews2.cxx
+++ b/sd/source/ui/view/drviews2.cxx
@@ -1204,13 +1204,9 @@ void DrawViewShell::FuTemporary(SfxRequest& rReq)
{
if (mpDrawView->IsTextEdit())
{
-// First make sure the field is selected
OutlinerView* pOutView = mpDrawView->GetTextEditOutlinerView();
if (pOutView)
-{
-pOutView->SelectFieldAtCursor();
URLFieldHelper::RemoveURLField(pOutView->GetEditView());
-}
}
}
Cancel();
diff --git a/sd/source/ui/view/drviewsf.cxx b/sd/source/ui/view/drviewsf.cxx
index 9246c2cd55ba..7a9d40bfc914 100644
--- a/sd/source/ui/view/drviewsf.cxx
+++ b/sd/source/ui/view/drviewsf.cxx
@@ -539,7 +539,8 @@ void DrawViewShell::GetAttrState( SfxItemSet& rSet )
case SID_REMOVE_HYPERLINK:
{
-if
(!URLFieldHelper::IsCursorAtURLField(mpDrawView->GetTextEditOutlinerView()))
+if
(!URLFieldHelper::IsCursorAtURLField(mpDrawView->GetTextEditOutlinerView(),
+
/*AlsoCheckBeforeCursor=*/true))
rSet.DisableItem(nWhich);
}
break;
commit 0fc96d9b54e5a64c528bbf7fcdf9b71d74be8920
Author: Justin Luth
AuthorDate: Mon Nov 6 14:23:16 2023 -0500
Commit: Justin Luth
CommitDate: Wed Nov 15 20:04:52 2023 +0100
tdf#158031 editeng SID_OPEN_HYPERLINK: use AlsoCheckBeforeCursor
This patch depends on prior patches for this bug report.
This fixes nothing being opened if the mouse was right-clicked
over that second half of the hyperlink (since a "smart" positioning
set the cursor after the field instead of before it).
Note that for some reason, OPEN always seemed to work with the mouse,
even though other hyperlink menu options using the same code
failed to find the field! So this code change is mainly for consistency.
However, I WAS able to make it always fail,
by moving the mouse away once the popup menu arrived,
and then using the KEYBOARD to "Open Hyperlink".
In that case, it always failed (because the field
was not selected, and not under the mouse).
Change-Id: I8fcd0386de6cea8c6a937afb6f63061ed62d4cb1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159016
Tested-by: Jenkins
[Libreoffice-commits] core.git: editeng/source include/editeng sc/source sd/source sw/source
editeng/source/outliner/outlvw.cxx |4 ++--
include/editeng/outliner.hxx |2 +-
sc/source/ui/drawfunc/drtxtob.cxx|4 +++-
sc/source/ui/view/editsh.cxx |4 +++-
sd/source/ui/view/drviews2.cxx |4 +++-
sw/source/uibase/shells/drwtxtex.cxx |4 +++-
6 files changed, 15 insertions(+), 7 deletions(-)
New commits:
commit aaca48eb12357fa5cf23054fe77554bcfff74e95
Author: Justin Luth
AuthorDate: Mon Nov 6 13:41:05 2023 -0500
Commit: Justin Luth
CommitDate: Wed Nov 15 20:04:37 2023 +0100
tdf#158031 editeng SID_COPY_HYPERLINK: use AlsoCheckBeforeCursor
This patch depends on prior patches for this bug report.
This fixes nothing being copied if the mouse was right-clicked
over that second half of the hyperlink (since a "smart" positioning
set the cursor after the field instead of before it).
Change-Id: I6c933224cd8d36f48f4e1f0aafaa1f4e46d3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159015
Reviewed-by: Justin Luth
Tested-by: Jenkins
diff --git a/editeng/source/outliner/outlvw.cxx
b/editeng/source/outliner/outlvw.cxx
index adf75cc54afa..2649e865d6d7 100644
--- a/editeng/source/outliner/outlvw.cxx
+++ b/editeng/source/outliner/outlvw.cxx
@@ -1340,9 +1340,9 @@ const SvxFieldItem*
OutlinerView::GetFieldUnderMousePointer() const
return pEditView->GetFieldUnderMousePointer();
}
-const SvxFieldItem* OutlinerView::GetFieldAtSelection() const
+const SvxFieldItem* OutlinerView::GetFieldAtSelection(bool
bAlsoCheckBeforeCursor) const
{
-return pEditView->GetFieldAtSelection();
+return pEditView->GetFieldAtSelection(bAlsoCheckBeforeCursor);
}
const SvxFieldData* OutlinerView::GetFieldAtCursor() const
diff --git a/include/editeng/outliner.hxx b/include/editeng/outliner.hxx
index cc921f4cd0af..4f8d41e21b9b 100644
--- a/include/editeng/outliner.hxx
+++ b/include/editeng/outliner.hxx
@@ -306,7 +306,7 @@ public:
voidInsertField( const SvxFieldItem& rFld );
const SvxFieldItem* GetFieldUnderMousePointer() const;
-const SvxFieldItem* GetFieldAtSelection() const;
+const SvxFieldItem* GetFieldAtSelection(bool bAlsoCheckBeforeCursor =
false) const;
/// Return the field at the current cursor position or nullptr if no field
found
const SvxFieldData* GetFieldAtCursor() const;
/// Select the field at the current cursor position
diff --git a/sc/source/ui/drawfunc/drtxtob.cxx
b/sc/source/ui/drawfunc/drtxtob.cxx
index ec527db045ac..65da5aac262c 100644
--- a/sc/source/ui/drawfunc/drtxtob.cxx
+++ b/sc/source/ui/drawfunc/drtxtob.cxx
@@ -311,7 +311,9 @@ void ScDrawTextObjectBar::Execute( SfxRequest )
case SID_COPY_HYPERLINK_LOCATION:
{
-const SvxFieldData* pField = pOutView->GetFieldAtCursor();
+const SvxFieldItem* pFieldItem
+=
pOutView->GetFieldAtSelection(/*AlsoCheckBeforeCursor=*/true);
+const SvxFieldData* pField = pFieldItem ?
pFieldItem->GetField() : nullptr;
if (const SvxURLField* pURLField = dynamic_cast(pField))
{
uno::Reference
xClipboard
diff --git a/sc/source/ui/view/editsh.cxx b/sc/source/ui/view/editsh.cxx
index 3393ca3ad090..ba76f89c4651 100644
--- a/sc/source/ui/view/editsh.cxx
+++ b/sc/source/ui/view/editsh.cxx
@@ -655,7 +655,9 @@ void ScEditShell::Execute( SfxRequest& rReq )
break;
case SID_COPY_HYPERLINK_LOCATION:
{
-const SvxFieldData* pField = pEditView->GetFieldAtCursor();
+const SvxFieldItem* pFieldItem
+=
pEditView->GetFieldAtSelection(/*AlsoCheckBeforeCursor=*/true);
+const SvxFieldData* pField = pFieldItem ?
pFieldItem->GetField() : nullptr;
if (const SvxURLField* pURLField = dynamic_cast(pField))
{
uno::Reference
xClipboard
diff --git a/sd/source/ui/view/drviews2.cxx b/sd/source/ui/view/drviews2.cxx
index b49e7bfc497a..fab59b59f00a 100644
--- a/sd/source/ui/view/drviews2.cxx
+++ b/sd/source/ui/view/drviews2.cxx
@@ -2280,7 +2280,9 @@ void DrawViewShell::FuTemporary(SfxRequest& rReq)
OutlinerView* pOutView = mpDrawView->GetTextEditOutlinerView();
if ( pOutView )
{
-const SvxFieldData* pField = pOutView->GetFieldAtCursor();
+const SvxFieldItem* pFieldItem
+=
pOutView->GetFieldAtSelection(/*AlsoCheckBeforeCursor=*/true);
+const SvxFieldData* pField = pFieldItem ?
pFieldItem->GetField() : nullptr;
if (const SvxURLField* pURLField = dynamic_cast(pField))
{
uno::Reference
xClipboard
diff --git a/sw/source/uibase/shells/drwtxtex.cxx
b/sw/source/uibase/shells/drwtxtex.cxx
index db76755474e4..dc10ba46f143 100644
--- a/sw/source/uibase/shells/drwtxtex.cxx
+++
[Libreoffice-bugs] [Bug 158031] Writer in editeng: right click doesn't edit hyperlink in when mouse over last half / cursor after hyperlink
https://bugs.documentfoundation.org/show_bug.cgi?id=158031 --- Comment #7 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/213c6ae84f084978391c16276017078bf9ed related tdf#158031 editeng: GetFieldAtSel...(+look before cursor) It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sd/source
sd/source/ui/inc/DrawViewShell.hxx |5 -
sd/source/ui/view/drviews4.cxx | 14 --
sd/source/ui/view/drviews7.cxx | 14 +++---
3 files changed, 3 insertions(+), 30 deletions(-)
New commits:
commit 023a2de2a8ef4bdcd9877e60f8739366de3a763c
Author: Justin Luth
AuthorDate: Mon Nov 6 08:57:20 2023 -0500
Commit: Justin Luth
CommitDate: Wed Nov 15 20:04:16 2023 +0100
tdf#158031 Revert "Resolves: tdf#137445 use the DisableEditHyperlink state
... as of menu launch time"
This code is now obsolete from generic changes for bug 158031,
so revert 7.1 commit eb395e21a7b1f15de664c4b207dc9e130aa635cf.
It was a fine idea, but overly complex, dependent on invalidations,
and hard to re-implement everywhere it would be needed.
Instead, just also check before cursor for a field.
Change-Id: I08354e32fefb66ff051458097d3bd07946198a4f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159014
Tested-by: Jenkins
Reviewed-by: Justin Luth
diff --git a/sd/source/ui/inc/DrawViewShell.hxx
b/sd/source/ui/inc/DrawViewShell.hxx
index d1e9b74af198..3043ba007bf2 100644
--- a/sd/source/ui/inc/DrawViewShell.hxx
+++ b/sd/source/ui/inc/DrawViewShell.hxx
@@ -456,11 +456,6 @@ private:
VclPtr maTabControl;
EditModemeEditMode;
PageKindmePageKind;
-// tdf#137445 at context menu popup time set if the EditHyperlink entry
-// should be disabled and use that state if queried about it if
-// EditHyperlink is dispatched from the menu. So ignoring where the mouse
-// currently happens to be when the menu was dismissed.
-std::optional moAtContextMenu_DisableEditHyperlink;
boolmbZoomOnPage;
boolmbIsRulerDrag;
sal_uLong mnLockCount;
diff --git a/sd/source/ui/view/drviews4.cxx b/sd/source/ui/view/drviews4.cxx
index 986aec295bea..4226f0e4e8d8 100644
--- a/sd/source/ui/view/drviews4.cxx
+++ b/sd/source/ui/view/drviews4.cxx
@@ -804,10 +804,6 @@ void DrawViewShell::Command(const CommandEvent& rCEvt,
::sd::Window* pWin)
{
GetActiveWindow()->ReleaseMouse();
-// tdf#137445 at this context menu popup time get what the
-// DisableEditHyperlink would be for this position
-bool bShouldDisableEditHyperlink = ShouldDisableEditHyperlink();
-
if(rCEvt.IsMouseEvent())
GetViewFrame()->GetDispatcher()->ExecutePopup( aPopupId );
else
@@ -839,16 +835,6 @@ void DrawViewShell::Command(const CommandEvent& rCEvt,
::sd::Window* pWin)
//open context menu at that point
GetViewFrame()->GetDispatcher()->ExecutePopup( aPopupId,
GetActiveWindow(), );
}
-
-if (!bShouldDisableEditHyperlink)
-{
-SfxBindings& rBindings = GetViewFrame()->GetBindings();
-// tdf#137445 set what the menu popup state for this was
-moAtContextMenu_DisableEditHyperlink =
bShouldDisableEditHyperlink;
-// ensure moAtContextMenu_DisableEditHyperlink will be cleared
-// in the case that EditHyperlink is not dispatched by the menu
-rBindings.Invalidate(SID_EDIT_HYPERLINK);
-}
}
}
else
diff --git a/sd/source/ui/view/drviews7.cxx b/sd/source/ui/view/drviews7.cxx
index 3bace958df28..223493fb29e0 100644
--- a/sd/source/ui/view/drviews7.cxx
+++ b/sd/source/ui/view/drviews7.cxx
@@ -293,7 +293,8 @@ bool DrawViewShell::ShouldDisableEditHyperlink() const
bool bDisableEditHyperlink = true;
if( mpDrawView->IsTextEdit() )
{
-if
(URLFieldHelper::IsCursorAtURLField(mpDrawView->GetTextEditOutlinerView()))
+if
(URLFieldHelper::IsCursorAtURLField(mpDrawView->GetTextEditOutlinerView(),
+ /*AlsoCheckBeforeCursor=*/true))
bDisableEditHyperlink = false;
}
else
@@ -1479,16 +1480,7 @@ void DrawViewShell::GetMenuState( SfxItemSet )
// Menuoption: Edit->Hyperlink
// Disable, if there is no hyperlink
-bool bDisableEditHyperlink;
-if (!moAtContextMenu_DisableEditHyperlink.has_value())
-bDisableEditHyperlink = ShouldDisableEditHyperlink();
-else
-{
-// tdf#137445 if a popup menu was active, use the state as of when the
popup was launched and then drop
-// moAtContextMenu_DisableEditHyperlink
-bDisableEditHyperlink = *moAtContextMenu_DisableEditHyperlink;
-moAtContextMenu_DisableEditHyperlink.reset();
-}
+bool bDisableEditHyperlink = ShouldDisableEditHyperlink();
//highlight selected custom shape
{
[Libreoffice-bugs] [Bug 158031] Writer in editeng: right click doesn't edit hyperlink in when mouse over last half / cursor after hyperlink
https://bugs.documentfoundation.org/show_bug.cgi?id=158031 --- Comment #9 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/61d2d34b882b2b89c6702b04764058931ba70d60 tdf#158031 Revert "tdf#140361 use the DisableEditHyperlink state It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
