[Bug 150884] [META] Sparklines bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=150884 Bug 150884 depends on bug 152929, which changed state. Bug 152929 Summary: Sparkline ignore "High points" color when all values are negative https://bugs.documentfoundation.org/show_bug.cgi?id=152929 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
core.git: chart2/source
chart2/source/controller/dialogs/ChartResourceGroups.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 4eb875d95622fb4346d3f8b24327a1b84230eca1
Author: Julien Nabet
AuthorDate: Wed Dec 13 21:23:30 2023 +0100
Commit: Julien Nabet
CommitDate: Thu Dec 14 08:48:48 2023 +0100
tdf#158684: CHART XY Scatter Chart: line type "stepped" ignores parameters
Regression from 65752e649872edfd98915035b61aca510ae8f271
Date: Fri Mar 24 10:52:13 2023 +0100
jsdialog: enable and make async chart line prop dialog
Change-Id: I1532c45ae72d2c45ace72bcc099fcc8baa265b99
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160715
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/chart2/source/controller/dialogs/ChartResourceGroups.cxx
b/chart2/source/controller/dialogs/ChartResourceGroups.cxx
index 3cf5996ed300..e1550d2766c7 100644
--- a/chart2/source/controller/dialogs/ChartResourceGroups.cxx
+++ b/chart2/source/controller/dialogs/ChartResourceGroups.cxx
@@ -328,7 +328,7 @@ IMPL_LINK_NOARG(SplineResourceGroup,
SteppedDetailsDialogHdl, weld::Button&, voi
weld::GenericDialogController::runAsync(
xDlg, [this, xDlg, aOldParameter, iOldLineTypePos](sal_Int32 nResult) {
m_xSteppedPropertiesDialog = nullptr;
-auto xNewDlg = getSplinePropertiesDialog();
+auto xNewDlg = getSteppedPropertiesDialog();
if (nResult == RET_OK)
{
[Bug 158696] New: UI. A checkbox for default column width rather odd UI choice width downsides
https://bugs.documentfoundation.org/show_bug.cgi?id=158696 Bug ID: 158696 Summary: UI. A checkbox for default column width rather odd UI choice width downsides Product: LibreOffice Version: 24.2.0.0 alpha1+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: UI. A checkbox for default column width rather odd UI choice width downsides Steps to Reproduce: 1. Open Calc 2. Right click on column A 3. Select Column width 4. Uncheck default value 5. Press OK 6. Reopen the dialog Column width -> checkbox checked again. So it's not an independent setting. It will be checked if the value is 2,26 cm 7. Go into width field, change the value by removing 6 by backspace and pressing 0 8. Notice that default value is still being checked. It only updates when you exit the spinbox. However the dialog isn't that big to be inclined to do so. So it appears to be the default value Actual Results: Unchecking default value does nothing Expected Results: Instead of a checkbox a button labeled: default value Reproducible: Always User Profile Reset: No Additional Info: Version: 24.2.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 5ff701226b00963312cb2a78e77966d012b79c82 CPU threads: 8; OS: macOS 13.4.1; UI render: Skia/Raster; VCL: osx Locale: nl-NL (nl_NL.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
hot tub , pool and sauna room supplier
Your reader does not support HTML Hello dear, Good day and hope this email find you well. I am Sunshine on behalf of MEXDA SPA and FSPA. We are a professional factory manufacture in outdoor spa , swim SPA , ice bath, massage bathtub, steam sauna room since 1995 . E-catalog could be sent by email or wetransfer if needed. Any question, feel free to contact me. Thanks and have a nice day. -- Best Regards, Sunshine Gaoming Yuehua Sanitary Co., Ltd Add:No. 568 Yang Town, Gaoming District, Foshan City, Guangdong Province, China What's app:0086-13539324235 Wechat:sansan-0713 Facebook:sunshine.du.7169
[Bug 158686] FILEOPEN RTF Crash when changing to print preview
https://bugs.documentfoundation.org/show_bug.cgi?id=158686 --- Comment #4 from Miklos Vajna --- It happened for me on Linux with gtk3. I'll try to find a fix; failing that I'll post more info here (backtrace, etc). -- You are receiving this mail because: You are the assignee for the bug.
core.git: sw/CppunitTest_sw_ww8export.mk sw/qa
sw/CppunitTest_sw_ww8export.mk |4 sw/qa/extras/ww8export/data/cell-bg-color.odt|binary sw/qa/extras/ww8export/data/cjklist30.doc|binary sw/qa/extras/ww8export/data/cjklist31.doc|binary sw/qa/extras/ww8export/data/cjklist34.doc|binary sw/qa/extras/ww8export/data/cjklist35.doc|binary sw/qa/extras/ww8export/data/fdo68967.doc |binary sw/qa/extras/ww8export/data/i120158.doc |binary sw/qa/extras/ww8export/data/n760294.doc |binary sw/qa/extras/ww8export/data/new-page-styles.doc |binary sw/qa/extras/ww8export/data/ooo92948-1.doc |binary sw/qa/extras/ww8export/data/redline-export-1.odt |binary sw/qa/extras/ww8export/data/redline-export-2.odt |binary sw/qa/extras/ww8export/data/redline-export-3.odt |binary sw/qa/extras/ww8export/data/tdf118564.doc|binary sw/qa/extras/ww8export/data/tdf130262.doc|binary sw/qa/extras/ww8export/data/tdf46441-2.odt |binary sw/qa/extras/ww8export/data/tdf59896.doc |binary sw/qa/extras/ww8export/data/tdf95576.doc |binary 19 files changed, 4 insertions(+) New commits: commit c5b71a7f6c9673074871ad84df655faeb6a036eb Author: Miklos Vajna AuthorDate: Wed Dec 13 19:57:38 2023 +0100 Commit: Miklos Vajna CommitDate: Thu Dec 14 08:20:25 2023 +0100 CppunitTest_sw_ww8export: avoid external fonts - sw/qa/extras/ww8export/data/cell-bg-color.odt: - missing font: 'Helvetica' try: Liberation Sans instead - sw/qa/extras/ww8export/data/tdf46441-2.odt: - missing font: 'Times Regular' try: Noto Sans instead - sw/qa/extras/ww8export/data/ooo92948-1.doc: - missing font: 'Baskerville MT' try: Noto Sans instead - missing font: 'Futura Book' try: Noto Sans instead - sw/qa/extras/ww8export/data/i120158.doc: - missing font: 'SimSun' try: Noto Serif instead - sw/qa/extras/ww8export/data/fdo68967.doc: - missing font: 'Arial Rounded MT Bold' try: Noto Sans instead - sw/qa/extras/ww8export/data/n760294.doc: - missing font: 'Thorndale AMT' try: Liberation Serif instead - sw/qa/extras/ww8export/data/new-page-styles.doc: - missing font: 'Raytheon Corporate Logo' try: Noto Sans instead - sw/qa/extras/ww8export/data/redline-export-1.odt: - missing font: 'Helvetica' try: Liberation Sans instead - sw/qa/extras/ww8export/data/redline-export-2.odt: - missing font: 'Helvetica' try: Liberation Sans instead - sw/qa/extras/ww8export/data/redline-export-3.odt: - missing font: 'Helvetica' try: Liberation Sans instead - sw/qa/extras/ww8export/data/tdf118564.doc: - missing font: 'FangSong_GB2312' try: Noto Sans instead - missing font: 'SimSun' try: Noto Serif instead - missing font: 'FangSong' try: Noto Sans instead - sw/qa/extras/ww8export/data/tdf130262.doc: - missing font: 'Univers' try: Noto Sans instead - sw/qa/extras/ww8export/data/tdf59896.doc (WW6): - missing font: 'MS Sans Serif' try: DejaVu Sans instead - sw/qa/extras/ww8export/data/tdf95576.doc: - missing font: 'Calibri Light' try: Noto Sans instead - sw/qa/extras/ww8export/data/cjklist30.doc: - missing font: '新細明體' try: Noto Sans instead - missing font: 'PMingLiU' try: Noto Sans instead - sw/qa/extras/ww8export/data/cjklist31.doc: - missing font: '新細明體' try: Noto Sans instead - missing font: 'PMingLiU' try: Noto Sans instead - sw/qa/extras/ww8export/data/cjklist34.doc: - missing font: '新細明體' try: Noto Sans instead - missing font: 'PMingLiU' try: Noto Sans instead - sw/qa/extras/ww8export/data/cjklist35.doc: - missing font: '新細明體' try: Noto Sans instead - missing font: 'PMingLiU' try: Noto Sans instead The .doc files are edited with Word (convert to DOCX, edit there, convert back), the single WW6 file is binary patched, using spaces as padding for the shorter new font name. Change-Id: Ic023a0ba6e542ac0f3782dfef5986bdcf69f3056 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160713 Tested-by: Jenkins Reviewed-by: Miklos Vajna diff --git a/sw/CppunitTest_sw_ww8export.mk b/sw/CppunitTest_sw_ww8export.mk index 306337889cc9..74d6ab2face0 100644 --- a/sw/CppunitTest_sw_ww8export.mk +++ b/sw/CppunitTest_sw_ww8export.mk @@ -18,4 +18,8 @@ $(eval $(call gb_CppunitTest_use_uiconfigs,sw_ww8export, \ svt \ )) +ifneq ($(filter MORE_FONTS,$(BUILD_TYPE)),) +$(eval $(call gb_CppunitTest_set_non_application_font_use,sw_ww8export,abort)) +endif + # vim: set noet sw=4 ts=4: diff --git a/sw/qa/extras/ww8export/data/cell-bg-color.odt b/sw/qa/extras/ww8export/data/cell-bg-color.odt index 3565f40c210e..0a6a3076e5f5 100644 Binary files a/sw/qa/extras/ww8export/data/cell-bg-color.odt and b/sw/qa/extras/ww8export/data/cell-bg-color.odt differ diff --git a/sw/qa/extras/ww8export/data/cjklist30.doc b/sw/qa/extras/ww8export/data/cjklist30.doc index
core.git: uui/source uui/uiconfig
uui/source/secmacrowarnings.cxx| 13 +
uui/source/secmacrowarnings.hxx|1 +
uui/uiconfig/ui/macrowarnmedium.ui | 19 ++-
3 files changed, 28 insertions(+), 5 deletions(-)
New commits:
commit a383794fba07cb6a356274febd55968fb25f77e4
Author: Samuel Mehrbrodt
AuthorDate: Mon Dec 11 14:11:42 2023 +0100
Commit: Samuel Mehrbrodt
CommitDate: Thu Dec 14 08:19:35 2023 +0100
tdf#158576 This button shows a certificate when only one signature found
"Show signatures" should only be shown when there are multiple signatures,
otherwise the button label must be "Show certificate"
Change-Id: Iaed2d10b8e94bf6decad937dafef4795b7ed40dc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160596
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt
diff --git a/uui/source/secmacrowarnings.cxx b/uui/source/secmacrowarnings.cxx
index e5e1a46fdb97..e526b6da8b99 100644
--- a/uui/source/secmacrowarnings.cxx
+++ b/uui/source/secmacrowarnings.cxx
@@ -43,6 +43,7 @@ MacroWarning::MacroWarning(weld::Window* pParent, bool
_bWithSignatures)
, mxNotYetValid(m_xBuilder->weld_label("certNotYetValidLabel"))
, mxNoLongerValid(m_xBuilder->weld_label("certNoLongerValidLabel"))
, mxViewSignsBtn(m_xBuilder->weld_button("viewSignsButton"))
+, mxViewCertBtn(m_xBuilder->weld_button("viewCertButton"))
, mxAlwaysTrustCB(m_xBuilder->weld_check_button("alwaysTrustCheckbutton"))
, mxEnableBtn(m_xBuilder->weld_button("ok"))
, mxDisableBtn(m_xBuilder->weld_button("cancel"))
@@ -131,10 +132,12 @@ void MacroWarning::InitControls()
// show signature controls?
if (mbShowSignatures)
{
+mxAlwaysTrustCB->connect_toggled(LINK(this, MacroWarning,
AlwaysTrustCheckHdl));
mxAlwaysTrustCB->set_sensitive(false);
mxViewSignsBtn->connect_clicked(LINK(this, MacroWarning,
ViewSignsBtnHdl));
-mxViewSignsBtn->set_sensitive(false);
-mxAlwaysTrustCB->connect_toggled(LINK(this, MacroWarning,
AlwaysTrustCheckHdl));
+mxViewSignsBtn->set_visible(false);
+mxViewCertBtn->connect_clicked(LINK(this, MacroWarning,
ViewSignsBtnHdl));
+mxViewCertBtn->set_visible(false);
mnActSecLevel = SvtSecurityOptions::GetMacroSecurityLevel();
if ( mnActSecLevel >= 2 )
@@ -168,7 +171,8 @@ void MacroWarning::SetStorage( const css::uno::Reference <
css::embed::XStorage
}
mxSignsFI->set_label(s.makeStringAndClear());
-mxViewSignsBtn->set_sensitive(true);
+mxViewSignsBtn->set_visible(true);
+mxViewCertBtn->set_visible(false);
}
void MacroWarning::SetCertificate( const css::uno::Reference<
css::security::XCertificate >& _rxCert )
@@ -186,7 +190,8 @@ void MacroWarning::SetCertificate( const
css::uno::Reference< css::security::XCe
utl::typeConvert( mxCert->getNotValidAfter(), aDateTimeEnd );
mxNotYetValid->set_visible(now < aDateTimeStart);
mxNoLongerValid->set_visible(now > aDateTimeEnd);
-mxViewSignsBtn->set_sensitive(true);
+mxViewSignsBtn->set_visible(false);
+mxViewCertBtn->set_visible(true);
}
}
diff --git a/uui/source/secmacrowarnings.hxx b/uui/source/secmacrowarnings.hxx
index 1a6e7f0b7380..80f1fb76599e 100644
--- a/uui/source/secmacrowarnings.hxx
+++ b/uui/source/secmacrowarnings.hxx
@@ -35,6 +35,7 @@ private:
std::unique_ptr mxNotYetValid;
std::unique_ptr mxNoLongerValid;
std::unique_ptr mxViewSignsBtn;
+std::unique_ptr mxViewCertBtn;
std::unique_ptr mxAlwaysTrustCB;
std::unique_ptr mxEnableBtn;
std::unique_ptr mxDisableBtn;
diff --git a/uui/uiconfig/ui/macrowarnmedium.ui
b/uui/uiconfig/ui/macrowarnmedium.ui
index 810fbbb6d12b..4d7a416e83e9 100644
--- a/uui/uiconfig/ui/macrowarnmedium.ui
+++ b/uui/uiconfig/ui/macrowarnmedium.ui
@@ -125,7 +125,7 @@ Macros may contain viruses. Disabling macros for a document
is always safe. If y
-_View Signatures…
+_Show Signatures…
True
True
True
@@ -140,6 +140,23 @@ Macros may contain viruses. Disabling macros for a
document is always safe. If y
1
+
+
+_Show Certificate…
+True
+True
+True
+end
+start
+True
+True
+
+
+False
+True
+2
+
+
0
[Bug 158695] --convert-to bogusly needs libcui
https://bugs.documentfoundation.org/show_bug.cgi?id=158695 Rene Engelhard changed: What|Removed |Added Summary|--convert-to needs libcui |--convert-to bogusly needs ||libcui -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158695] New: --convert-to needs libcui
https://bugs.documentfoundation.org/show_bug.cgi?id=158695 Bug ID: 158695 Summary: --convert-to needs libcui Product: LibreOffice Version: 7.6.0.0 alpha0+ Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: r...@debian.org Description: [similar as https://bugs.documentfoundation.org/show_bug.cgi?id=155411 ] See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1052052 and bugs.debian.org/1058653. See the strace log in the bug. Apparently --convert-to for a writer documents now needs libcui present (which is excluded in Debians libreoffice-core-nogui since it's "common UI"[1] and thus is definitely not needed - at least by the name). If you add --disable-gui please keep it working. --convert-to doesn't need GUI. [1] https://salsa.debian.org/libreoffice-team/libreoffice/libreoffice/-/blob/master/rules#L3350 Steps to Reproduce: 1. build LO with --disable-gui 2. rm libcuilo.so 3. libreoffice --writer --convert-to pdf of a file Actual Results: Error: source file could not be loaded Expected Results: Converts fine Reproducible: Always User Profile Reset: No Additional Info: . -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158689] Calc Format>Columns>Optimal Width reverts to default value
https://bugs.documentfoundation.org/show_bug.cgi?id=158689 David Lynch changed: What|Removed |Added CC||dlynch1...@googlemail.com --- Comment #2 from David Lynch --- I agree that the width in step f depends on the contents of selected cells. Call this width x. If A1="1", x=.53. Step g should do nothing, all it does is invoke the Optimal width dialog, change nothing and close the dialog. Yet the column width in step h changes to x-.2cm. If I enter w in cell A1, x=.59cm, and the width at step h changes to .39cm=x-.2cm. -- You are receiving this mail because: You are the assignee for the bug.
core.git: uui/source
uui/source/secmacrowarnings.cxx | 29 ++---
1 file changed, 14 insertions(+), 15 deletions(-)
New commits:
commit 37b381e2877c60c84547b22117663a72ab02fadc
Author: Samuel Mehrbrodt
AuthorDate: Mon Dec 11 15:06:54 2023 +0100
Commit: Samuel Mehrbrodt
CommitDate: Thu Dec 14 08:11:04 2023 +0100
tdf#158576 Allow trusting certificates only once
Macro mode "high" says that only signed macros from trusted sources can be
run.
When opening a document with a signed macro from an untrusted certificate,
the user can either disable macros, or add the certificate to the list of
trusted sources permanently and enable macros.
This adds the possibility to trust the certificate only for the current
document
in the given scenario.
Change-Id: Idf272498d930afc8a3f8be7f30889b77bf402d52
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160598
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt
diff --git a/uui/source/secmacrowarnings.cxx b/uui/source/secmacrowarnings.cxx
index 0a295fba30a4..e5e1a46fdb97 100644
--- a/uui/source/secmacrowarnings.cxx
+++ b/uui/source/secmacrowarnings.cxx
@@ -78,20 +78,19 @@ IMPL_LINK_NOARG(MacroWarning, ViewSignsBtnHdl,
weld::Button&, void)
uno::Reference< security::XDocumentDigitalSignatures > xD(
security::DocumentDigitalSignatures::createWithVersion(comphelper::getProcessComponentContext(),
maODFVersion));
-if( xD.is() )
-{
-xD->setParentWindow(m_xDialog->GetXWindow());
-if( mxCert.is() )
-{
-xD->showCertificate( mxCert );
-mxAlwaysTrustCB->set_sensitive(true);
-}
-else if( mxStore.is() )
-{
-xD->showScriptingContentSignatures( mxStore, uno::Reference<
io::XInputStream >() );
-mxAlwaysTrustCB->set_sensitive(true);
-}
-}
+if( !xD.is() )
+return;
+
+xD->setParentWindow(m_xDialog->GetXWindow());
+if( mxCert.is() )
+xD->showCertificate( mxCert );
+else if( mxStore.is() )
+xD->showScriptingContentSignatures( mxStore, uno::Reference<
io::XInputStream >() );
+else
+return;
+
+mxAlwaysTrustCB->set_sensitive(true);
+mxEnableBtn->set_sensitive(true);
}
IMPL_LINK_NOARG(MacroWarning, EnableBtnHdl, weld::Button&, void)
@@ -122,7 +121,7 @@ IMPL_LINK_NOARG(MacroWarning, DisableBtnHdl, weld::Button&,
void)
IMPL_LINK_NOARG(MacroWarning, AlwaysTrustCheckHdl, weld::Toggleable&, void)
{
-const bool bEnable = (mnActSecLevel < 2 || mxAlwaysTrustCB->get_active());
+const bool bEnable = (mnActSecLevel < 3 || mxAlwaysTrustCB->get_active());
mxEnableBtn->set_sensitive(bEnable);
mxDisableBtn->set_sensitive(!mxAlwaysTrustCB->get_active());
}
core.git: solenv/sanitizers uui/source uui/uiconfig
solenv/sanitizers/ui/uui.suppr |2 ++
uui/source/secmacrowarnings.cxx| 12
uui/source/secmacrowarnings.hxx|2 ++
uui/uiconfig/ui/macrowarnmedium.ui | 28 ++--
4 files changed, 42 insertions(+), 2 deletions(-)
New commits:
commit 69814fc26fe21a258cf32fca021945f5bc69f59c
Author: Samuel Mehrbrodt
AuthorDate: Mon Dec 11 11:00:44 2023 +0100
Commit: Samuel Mehrbrodt
CommitDate: Thu Dec 14 08:09:51 2023 +0100
tdf#158576 Show warning when cert is not yet/no longer valid
Change-Id: I4f517a5e2b33d508d1a501323c4d97dc025edfbc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160566
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt
diff --git a/solenv/sanitizers/ui/uui.suppr b/solenv/sanitizers/ui/uui.suppr
index 96d00fc94920..3c7ab206bbe2 100644
--- a/solenv/sanitizers/ui/uui.suppr
+++ b/solenv/sanitizers/ui/uui.suppr
@@ -12,6 +12,8 @@ uui/uiconfig/ui/logindialog.ui://GtkLabel[@id='requestinfo']
orphan-label
uui/uiconfig/ui/logindialog.ui://GtkLabel[@id='errorinfo'] orphan-label
uui/uiconfig/ui/macrowarnmedium.ui://GtkLabel[@id='descr1Label'] orphan-label
uui/uiconfig/ui/macrowarnmedium.ui://GtkLabel[@id='signsLabel'] orphan-label
+uui/uiconfig/ui/macrowarnmedium.ui://GtkLabel[@id='certNotYetValidLabel']
orphan-label
+uui/uiconfig/ui/macrowarnmedium.ui://GtkLabel[@id='certNoLongerValidLabel']
orphan-label
uui/uiconfig/ui/setmasterpassworddlg.ui://GtkLabel[@id='label1'] orphan-label
uui/uiconfig/ui/setmasterpassworddlg.ui://GtkLabel[@id='label4'] orphan-label
uui/uiconfig/ui/simplenameclash.ui://GtkLabel[@id='warning'] orphan-label
diff --git a/uui/source/secmacrowarnings.cxx b/uui/source/secmacrowarnings.cxx
index 9422ff232033..ae53aa3eeb88 100644
--- a/uui/source/secmacrowarnings.cxx
+++ b/uui/source/secmacrowarnings.cxx
@@ -24,7 +24,9 @@
#include
#include
#include
+#include
#include
+#include
#include
#include
@@ -38,6 +40,8 @@ MacroWarning::MacroWarning(weld::Window* pParent, bool
_bWithSignatures)
: MessageDialogController(pParent, "uui/ui/macrowarnmedium.ui",
"MacroWarnMedium", "grid")
, mxGrid(m_xBuilder->weld_widget("grid"))
, mxSignsFI(m_xBuilder->weld_label("signsLabel"))
+, mxNotYetValid(m_xBuilder->weld_label("certNotYetValidLabel"))
+, mxNoLongerValid(m_xBuilder->weld_label("certNoLongerValidLabel"))
, mxViewSignsBtn(m_xBuilder->weld_button("viewSignsButton"))
, mxAlwaysTrustCB(m_xBuilder->weld_check_button("alwaysTrustCheckbutton"))
, mxEnableBtn(m_xBuilder->weld_button("ok"))
@@ -179,6 +183,14 @@ void MacroWarning::SetCertificate( const
css::uno::Reference< css::security::XCe
{
OUString s(xmlsec::GetContentPart(mxCert->getSubjectName(),
mxCert->getCertificateKind()));
mxSignsFI->set_label(s);
+
+::DateTime now( ::DateTime::SYSTEM );
+DateTime aDateTimeStart( DateTime::EMPTY );
+DateTime aDateTimeEnd( DateTime::EMPTY );
+utl::typeConvert( mxCert->getNotValidBefore(), aDateTimeStart );
+utl::typeConvert( mxCert->getNotValidAfter(), aDateTimeEnd );
+mxNotYetValid->set_visible(now < aDateTimeStart);
+mxNoLongerValid->set_visible(now > aDateTimeEnd);
mxViewSignsBtn->set_sensitive(true);
}
}
diff --git a/uui/source/secmacrowarnings.hxx b/uui/source/secmacrowarnings.hxx
index 300a5477bea5..1a6e7f0b7380 100644
--- a/uui/source/secmacrowarnings.hxx
+++ b/uui/source/secmacrowarnings.hxx
@@ -32,6 +32,8 @@ class MacroWarning : public weld::MessageDialogController
private:
std::unique_ptr mxGrid;
std::unique_ptr mxSignsFI;
+std::unique_ptr mxNotYetValid;
+std::unique_ptr mxNoLongerValid;
std::unique_ptr mxViewSignsBtn;
std::unique_ptr mxAlwaysTrustCB;
std::unique_ptr mxEnableBtn;
diff --git a/uui/uiconfig/ui/macrowarnmedium.ui
b/uui/uiconfig/ui/macrowarnmedium.ui
index d3a00f7a0d0a..810fbbb6d12b 100644
--- a/uui/uiconfig/ui/macrowarnmedium.ui
+++ b/uui/uiconfig/ui/macrowarnmedium.ui
@@ -75,7 +75,7 @@ Macros may contain viruses. Disabling macros for a document
is always safe. If y
-
+
True
False
@@ -104,7 +104,7 @@ Macros may contain viruses. Disabling macros for a document
is always safe. If y
0
-2
+4
@@ -146,6 +146,30 @@ Macros may contain viruses. Disabling macros for a
document is always safe. If y
1
+
+
+False
+start
+True
+Warning: The certificate is no
longer valid.
+
+
+0
+2
+
+
+
+
+False
+start
+True
+
core.git: uui/source
uui/source/secmacrowarnings.cxx |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) New commits: commit 4a859b3d2ffa4f427cd24bc4aacdc055d4c7826e Author: Samuel Mehrbrodt AuthorDate: Mon Dec 11 12:47:07 2023 +0100 Commit: Samuel Mehrbrodt CommitDate: Thu Dec 14 08:10:06 2023 +0100 This dialog is no longer called when MacroTrustedAuthors is readonly Change-Id: I73bc43cf57f6a1ed3613f2cf30e469ce6d841248 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160591 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt diff --git a/uui/source/secmacrowarnings.cxx b/uui/source/secmacrowarnings.cxx index ae53aa3eeb88..0a295fba30a4 100644 --- a/uui/source/secmacrowarnings.cxx +++ b/uui/source/secmacrowarnings.cxx @@ -135,11 +135,7 @@ void MacroWarning::InitControls() mxAlwaysTrustCB->set_sensitive(false); mxViewSignsBtn->connect_clicked(LINK(this, MacroWarning, ViewSignsBtnHdl)); mxViewSignsBtn->set_sensitive(false); - -if (!SvtSecurityOptions::IsReadOnly(SvtSecurityOptions::EOption::MacroTrustedAuthors)) -mxAlwaysTrustCB->connect_toggled(LINK(this, MacroWarning, AlwaysTrustCheckHdl)); -else -mxAlwaysTrustCB->set_visible(false); +mxAlwaysTrustCB->connect_toggled(LINK(this, MacroWarning, AlwaysTrustCheckHdl)); mnActSecLevel = SvtSecurityOptions::GetMacroSecurityLevel(); if ( mnActSecLevel >= 2 )
core.git: Branch 'libreoffice-24-2' - desktop/source
desktop/source/app/updater.cxx |8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
New commits:
commit acf00a90166bd17198e5b3c9fb2417dd0bd45deb
Author: Stephan Bergmann
AuthorDate: Wed Dec 13 09:58:29 2023 +0100
Commit: Stephan Bergmann
CommitDate: Thu Dec 14 08:07:32 2023 +0100
Fix number of actual arguments
Change-Id: I04bb3462948aeab24d46ee7ee910fdae8da2aa65
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160674
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
(cherry picked from commit 8adfdb2a6dad7b6d67c1557c2a0160a53eec7cfe)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160649
diff --git a/desktop/source/app/updater.cxx b/desktop/source/app/updater.cxx
index 5596028b0f79..fa3836596cc3 100644
--- a/desktop/source/app/updater.cxx
+++ b/desktop/source/app/updater.cxx
@@ -165,7 +165,7 @@ void createStr(const OUString& rStr, CharT** pArgs, size_t
i)
pArgs[i] = pStr;
}
-CharT** createCommandLine()
+CharT** createCommandLine(int * argc)
{
OUString aInstallDir = Updater::getInstallationPath();
@@ -231,6 +231,7 @@ CharT** createCommandLine()
pArgs[nArgs - 1] = nullptr;
+*argc = nArgs - 1;
return pArgs;
}
@@ -297,7 +298,8 @@ bool update()
OUString aUpdaterPath = getPathFromURL(aTempDirURL + "/" +
OUString::fromUtf8(pUpdaterName));
Updater::log("Calling the updater with parameters: ");
-CharT** pArgs = createCommandLine();
+int argc;
+CharT** pArgs = createCommandLine();
bool bSuccess = true;
const char* pUpdaterTestReplace = std::getenv("LIBO_UPDATER_TEST_REPLACE");
@@ -311,7 +313,7 @@ bool update()
bSuccess = false;
}
#elif defined(_WIN32)
-bSuccess = WinLaunchChild((wchar_t*)aUpdaterPath.getStr(), 8, pArgs);
+bSuccess = WinLaunchChild((wchar_t*)aUpdaterPath.getStr(), argc,
pArgs);
#endif
}
else
[Bug 158670] EDITING: Deleting a drilldown table created by a pivot, the pivot table is transformed in a normal table
https://bugs.documentfoundation.org/show_bug.cgi?id=158670 Stéphane Guillou (stragu) changed: What|Removed |Added Resolution|FIXED |DUPLICATE --- Comment #7 from Stéphane Guillou (stragu) --- Thanks for testing and for the quick answer! Let's mark as duplicate of bug 158223 then. *** This bug has been marked as a duplicate of bug 158223 *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158673] Drop Cap Style disappears
https://bugs.documentfoundation.org/show_bug.cgi?id=158673 BogdanB changed: What|Removed |Added Version|7.6.4.1 release |7.4.0.0 alpha0+ CC||buzea.bog...@libreoffice.or ||g OS|Windows (All) |All Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #7 from BogdanB --- I tried to reproduce like this: Open the document provided by the reporter. Select the first paragraph from the new chapter 3. Apply Drop cap style. Edit that style and choose from the Drop cap tab: Display drop caps. Everything seems fine in the document. Save. Reload. The drop cap style is gone. Check "Display drop caps". It is not checked any more. Version: 7.6.2.1 (X86_64) / LibreOffice Community Build ID: 56f7684011345957bbf33a7ee678afaf4d2ba333 CPU threads: 16; OS: Linux 6.2; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded Repro with Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: b419eb4bd407c26ee813a347fdf14424908379e1 CPU threads: 16; OS: Linux 6.2; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded Also with Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 10981fb2fa26474f432e85165b1babbca6d74e16 CPU threads: 16; OS: Linux 6.2; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded Could be a limitation in docx. I don't reproduce with a .odt file Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 10981fb2fa26474f432e85165b1babbca6d74e16 CPU threads: 16; OS: Linux 6.2; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158694] TEXT() function is not formatting months correctly.
https://bugs.documentfoundation.org/show_bug.cgi?id=158694 Mike Kaganski changed: What|Removed |Added Resolution|--- |NOTABUG Status|UNCONFIRMED |RESOLVED --- Comment #2 from Mike Kaganski --- format code in TEXT function expects that the number that is being formatted is a *date* (i.e., a number of days since the date defined at Options->Calc->Calculate, by default 1899-12-30). But you pass there a number returned by MONTH function, i.e. an integer between 1 and 12. Your formula should be =TEXT(cell-id,"") -- You are receiving this mail because: You are the assignee for the bug.
[Bug 76595] ooxml image deletion reappears in ODF odt
https://bugs.documentfoundation.org/show_bug.cgi?id=76595 --- Comment #44 from maya prakash --- Thank you for sharing this amazing post. If you have any more questions about IT, please continue and don't hesitate to visit my website. We are glad to assist. https://www.sstechnetwork.com/ -- You are receiving this mail because: You are the assignee for the bug.
[Bug 76595] ooxml image deletion reappears in ODF odt
https://bugs.documentfoundation.org/show_bug.cgi?id=76595 maya prakash changed: What|Removed |Added Keywords|regression |skillDesign URL|https://bmi-calculatoronlin |https://www.sstechnetwork.c |e.com/ |om/ -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158386] Windows Excel File locks up Libre Calc vers. 7.6.2.1 while trying to open it.
https://bugs.documentfoundation.org/show_bug.cgi?id=158386 --- Comment #5 from Mike Kaganski --- Right; so it seems that the question is, should we allow the non-standard extension that Excel allows; and if yes, then to what extent (question in comment 3). See also: https://learn.microsoft.com/en-us/office/vba/Language/Reference/user-interface-help/constant-expression-required -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158694] TEXT() function is not formatting months correctly.
https://bugs.documentfoundation.org/show_bug.cgi?id=158694 Stephen Drake changed: What|Removed |Added CC||stephendrak...@gmail.com --- Comment #1 from Stephen Drake --- Created attachment 191419 --> https://bugs.documentfoundation.org/attachment.cgi?id=191419=edit Spreadsheet demonstrating the bug. If you need any further information or evidence from me, please contact me. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158694] New: TEXT() function is not formatting months correctly.
https://bugs.documentfoundation.org/show_bug.cgi?id=158694 Bug ID: 158694 Summary: TEXT() function is not formatting months correctly. Product: LibreOffice Version: 7.6.4.1 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: stephendrak...@gmail.com Description: I want to display the current month name from a date-formatted cell. I am using the TEXT function as follows: =TEXT(month(cell-id),""). Cell-id is the cell containing the date. Steps to Reproduce: 1.Enter 1/1/23 in cell A1, 1/2/23 in A2, 1/3/23 in A3, etc until 1/12/23 in A12. 2.Enter =MONTH(A1) in B1, =MONTH(A2) in B2, and copy down to MONTH(A12) in B12. 3.Enter =TEXT(B1,"") in C1. Copy down to and including C12. Actual Results: C1 shows "December". C2 - C12 all show "January". Expected Results: C1 should show January, C2 February, C3 March and so on down to C12 which should show December. Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.6.4.1 (X86_64) / LibreOffice Community Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1 CPU threads: 8; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: en-AU (en_AU); UI: en-GB Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 108728] [META] Dictionaries bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108728 Tex2002ans changed: What|Removed |Added Depends on||158573 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158573 [Bug 158573] Turkish spell check dictionary update -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158573] Turkish spell check dictionary update
https://bugs.documentfoundation.org/show_bug.cgi?id=158573 Tex2002ans changed: What|Removed |Added CC||Tex2002ans+LibreOffice@gmai ||l.com Blocks||108728 --- Comment #1 from Tex2002ans --- Hey Turab, Thanks for the info. I'm also marking this with the "Dictionaries" metabug, so it'll be easier to find + ping more people who are interested in this topic. :) - - - It looks like LibreOffice's current Turkish dictionary is: hunspell-tr (harunzafer) - Version 1.2.0 (Apr 4, 2015) - https://github.com/harunzafer/hunspell-tr and Turab linked to an updated/expanded one called: hunspell-tr (tdd-ai) - Version 1.1.0 (Jan 7, 2022) - https://github.com/tdd-ai/hunspell-tr/ - - - Side Note: This was initially brought up in the Collabora Forums: https://forum.collaboraonline.com/t/can-not-localize-collabora-code/2162/5 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108728 [Bug 108728] [META] Dictionaries bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 128425] Add XMATCH function in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=128425 Thorsten Behrens (allotropia) changed: What|Removed |Added CC||t...@libreoffice.org Assignee|libreoffice-b...@lists.free |t...@libreoffice.org |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Bug 127293] Add XLOOKUP function in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=127293 Thorsten Behrens (allotropia) changed: What|Removed |Added CC||t...@libreoffice.org Assignee|libreoffice-b...@lists.free |t...@libreoffice.org |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Bug 126573] Add array functions in Calc: FILTER, SORT, SORTBY, UNIQUE, SEQUENCE, RANDARRAY
https://bugs.documentfoundation.org/show_bug.cgi?id=126573 Thorsten Behrens (allotropia) changed: What|Removed |Added CC||t...@libreoffice.org Assignee|libreoffice-b...@lists.free |t...@libreoffice.org |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158432] CSV IMPORT: add option to keep (not overwrite) target cell formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=158432 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158402] Blank dialog or menus after standby or change in screen resolution (Win11)
https://bugs.documentfoundation.org/show_bug.cgi?id=158402 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158402] Blank dialog or menus after standby or change in screen resolution (Win11)
https://bugs.documentfoundation.org/show_bug.cgi?id=158402 --- Comment #11 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158428] Fillable PDF Forms in Libreoffice Draw cannot have textboxes that scale their font to fit the textbox
https://bugs.documentfoundation.org/show_bug.cgi?id=158428 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 137543] Add a LET function into Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=137543 Thorsten Behrens (allotropia) changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |t...@libreoffice.org |desktop.org | CC||t...@libreoffice.org -- You are receiving this mail because: You are the assignee for the bug.
[Bug 155339] XAccessibleStateSet Raise error on import in LO 7.5
https://bugs.documentfoundation.org/show_bug.cgi?id=155339 --- Comment #10 from QA Administrators --- Dear vibrationoflife, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Bug 155336] EDITING: freeze and crash after editing header
https://bugs.documentfoundation.org/show_bug.cgi?id=155336 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 155339] XAccessibleStateSet Raise error on import in LO 7.5
https://bugs.documentfoundation.org/show_bug.cgi?id=155339 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Bug 155336] EDITING: freeze and crash after editing header
https://bugs.documentfoundation.org/show_bug.cgi?id=155336 --- Comment #5 from QA Administrators --- Dear sunnypony03, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Bug 155317] Numbering of sections if there are hidden ones
https://bugs.documentfoundation.org/show_bug.cgi?id=155317 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Bug 155317] Numbering of sections if there are hidden ones
https://bugs.documentfoundation.org/show_bug.cgi?id=155317 --- Comment #3 from QA Administrators --- Dear Vladimir, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Bug 98913] Autocomplete multi-line text ignores new line white spaces when filling cell value
https://bugs.documentfoundation.org/show_bug.cgi?id=98913 --- Comment #7 from QA Administrators --- Dear teo8976, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 155233] Saving then reopening a document with tables
https://bugs.documentfoundation.org/show_bug.cgi?id=155233 --- Comment #3 from QA Administrators --- Dear TonyB, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Bug 155233] Saving then reopening a document with tables
https://bugs.documentfoundation.org/show_bug.cgi?id=155233 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 146010] Insert->Caption menu it disabled when (some) cells of a table are selected
https://bugs.documentfoundation.org/show_bug.cgi?id=146010 --- Comment #2 from QA Administrators --- Dear Mike Kaganski, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 143881] FORMULA: abs{x}^2 is formatted with unexpected operator precedence
https://bugs.documentfoundation.org/show_bug.cgi?id=143881 --- Comment #11 from QA Administrators --- Dear hardy, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 145931] Auto-capitalize activated when pressing CTRL+ENTER in a merged cell for splitting text manually after exit
https://bugs.documentfoundation.org/show_bug.cgi?id=145931 --- Comment #10 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 128571] Draw LayerManager context doesn't work through "basic" editor
https://bugs.documentfoundation.org/show_bug.cgi?id=128571 --- Comment #4 from QA Administrators --- Dear paour, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 109305] The column attribute style:rel-column-width is wrongly read
https://bugs.documentfoundation.org/show_bug.cgi?id=109305 --- Comment #8 from QA Administrators --- Dear Regina Henschel, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 122884] Performance: GTK3 VCL Slow Using NX Xserver
https://bugs.documentfoundation.org/show_bug.cgi?id=122884 --- Comment #14 from QA Administrators --- Dear Dave Richards, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'libreoffice-24-2' - external/clucene helpcompiler/source RepositoryExternal.mk
RepositoryExternal.mk |1
external/clucene/UnpackedTarball_clucene.mk |1
external/clucene/patches/clucene-reprobuild.patch.1 | 61
helpcompiler/source/HelpIndexer.cxx |5 +
4 files changed, 68 insertions(+)
New commits:
commit 018070500f7f001233f5622d656fc29494620d3f
Author: Thorsten Behrens
AuthorDate: Thu Nov 2 18:17:50 2023 +0100
Commit: Thorsten Behrens
CommitDate: Thu Dec 14 03:09:08 2023 +0100
reprobuild: don't write timestamps to clucene index files
Our embedded clucene by default write a random current-time
millisecond value into version fields, in an attempt to
randomise. Clearly this is not needed for our static help, and it also
prevents builds from being reproducible.
Change-Id: I011388b5bc72b5d86bc1900f5439036ede60c020
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158845
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160668
diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index 9659ec7c163f..da11a7d153f2 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -2847,6 +2847,7 @@ ifneq ($(SYSTEM_CLUCENE),)
define gb_LinkTarget__use_clucene
$(call gb_LinkTarget_add_defs,$(1),\
$(filter-out -I% -isystem%,$(subst -isystem
/,-isystem/,$(CLUCENE_CFLAGS))) \
+ -DSYSTEM_CLUCENE \
)
$(call gb_LinkTarget_set_include,$(1),\
diff --git a/external/clucene/UnpackedTarball_clucene.mk
b/external/clucene/UnpackedTarball_clucene.mk
index 7a1eed67d2f7..76fdfe6aca56 100644
--- a/external/clucene/UnpackedTarball_clucene.mk
+++ b/external/clucene/UnpackedTarball_clucene.mk
@@ -54,6 +54,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,clucene,\
external/clucene/patches/nullstring.patch \
external/clucene/patches/binary_function.patch \
external/clucene/patches/clucene-pure-virtual.patch \
+ external/clucene/patches/clucene-reprobuild.patch.1 \
))
ifneq ($(OS),WNT)
diff --git a/external/clucene/patches/clucene-reprobuild.patch.1
b/external/clucene/patches/clucene-reprobuild.patch.1
new file mode 100644
index ..2c5a0b95135f
--- /dev/null
+++ b/external/clucene/patches/clucene-reprobuild.patch.1
@@ -0,0 +1,61 @@
+diff -ur clucene.org/src/core/CLucene/index/IndexWriter.cpp
clucene/src/core/CLucene/index/IndexWriter.cpp
+--- clucene.org/src/core/CLucene/index/IndexWriter.cpp 2023-11-02
17:31:00.110168174 +0100
clucene/src/core/CLucene/index/IndexWriter.cpp 2023-11-02
17:33:22.507665912 +0100
+@@ -366,6 +366,10 @@
+ }
+ }
+
++void IndexWriter::setSegmentInfoStartVersion(int64_t startVersion) {
++ this->segmentInfos->setStartVersion(startVersion);
++}
++
+ int32_t IndexWriter::getMaxBufferedDocs() {
+ ensureOpen();
+ return docWriter->getMaxBufferedDocs();
+diff -ur clucene.org/src/core/CLucene/index/IndexWriter.h
clucene/src/core/CLucene/index/IndexWriter.h
+--- clucene.org/src/core/CLucene/index/IndexWriter.h 2023-11-02
17:31:00.113501525 +0100
clucene/src/core/CLucene/index/IndexWriter.h 2023-11-02
17:33:43.547787510 +0100
+@@ -336,6 +336,12 @@
+ int64_t getWriteLockTimeout();
+
+ /**
++ * Sets the 0th segmentinfo version. Default is current system time
++ * in milliseconds
++ */
++ void setSegmentInfoStartVersion(int64_t startVersion);
++
++ /**
+* Sets the maximum time to wait for a commit lock (in milliseconds).
+*/
+ void setCommitLockTimeout(int64_t commitLockTimeout);
+diff -ur clucene.org/src/core/CLucene/index/SegmentInfos.cpp
clucene/src/core/CLucene/index/SegmentInfos.cpp
+--- clucene.org/src/core/CLucene/index/SegmentInfos.cpp2023-11-02
17:31:00.110168174 +0100
clucene/src/core/CLucene/index/SegmentInfos.cpp2023-11-02
18:04:43.855243418 +0100
+@@ -662,6 +662,10 @@
+ return IndexFileNames::fileNameFromGeneration(
IndexFileNames::SEGMENTS, "", nextGeneration );
+ }
+
++ void SegmentInfos::setStartVersion(int64_t version) {
++ this->version = version;
++ }
++
+ void SegmentInfos::clearto(size_t from, size_t end){
+ size_t range = end - from;
+ if ( (infos.size() - from) >= range) { // Make sure we actually need to
remove
+diff -ur clucene.org/src/core/CLucene/index/_SegmentInfos.h
clucene/src/core/CLucene/index/_SegmentInfos.h
+--- clucene.org/src/core/CLucene/index/_SegmentInfos.h 2023-11-02
17:31:00.106834824 +0100
clucene/src/core/CLucene/index/_SegmentInfos.h 2023-11-02
18:04:51.178598463 +0100
+@@ -347,6 +347,13 @@
+ */
+ std::string getNextSegmentFileName();
+
++ /**
++ * Set version value to start from
++
++ Defaults to current time in milliseconds
++ */
++void setStartVersion(int64_t version);
++
+ /* public vector-like operations */
+ //delete and clears objects
[Bug 158681] FILEOPEN: DOCX: Missing textbox in document
https://bugs.documentfoundation.org/show_bug.cgi?id=158681 Commit Notification changed: What|Removed |Added Whiteboard|target:24.8.0 |target:24.8.0 ||target:24.2.0.0.beta2 -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'libreoffice-24-2' - sw/qa writerfilter/source
dev/null |binary
sw/qa/extras/ooxmlexport/data/tdf153613_textboxAfterPgBreak3.docx |binary
sw/qa/extras/ooxmlexport/ooxmlexport18.cxx| 20
+++---
writerfilter/source/dmapper/DomainMapper.cxx | 16
4 files changed, 14 insertions(+), 22 deletions(-)
New commits:
commit de773a115c25c36993f5bb5a463ea5db452b5be5
Author: Justin Luth
AuthorDate: Wed Dec 13 16:09:52 2023 -0500
Commit: Justin Luth
CommitDate: Thu Dec 14 02:55:31 2023 +0100
tdf#158681 Revert "tdf#153613 writerfilter: don't always split para
... for shape w/ pagebreak"
This reverts 7.6 commit a9bc19c2d4a35606668aa2dcc53355651b71ee78.
The commit in general is probably fine. However, it fails in case
of an empty paragraph (with only anchors).
Unfortunately, there is no way of knowing ahead of time,
so either everything needs to be processed after a delay,
or else the paragraph needs to be split and then re-joined
in case it is not an empty paragraph.
Both options are extremely non-trivial - I don't know how
to do either of them.
In this case it is also the last paragraph in the document,
again something not known during import and which has
special-casing in MSO.
make CppunitTest_sw_ooxmlexport18 \
CPPUNIT_TEST_NAME=testTdf153613_textboxAfterPgBreak3
Change-Id: I4471e216b6523032b85178d85795434694cc1e22
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160720
Tested-by: Jenkins
Reviewed-by: Justin Luth
(cherry picked from commit d58cd70f550e8967c2518ebb2179e15f5a3a84ea)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160695
diff --git a/sw/qa/extras/ooxmlexport/data/tdf153613_textboxAfterPgBreak.docx
b/sw/qa/extras/ooxmlexport/data/tdf153613_textboxAfterPgBreak.docx
deleted file mode 100644
index 4ad4dfba8110..
Binary files a/sw/qa/extras/ooxmlexport/data/tdf153613_textboxAfterPgBreak.docx
and /dev/null differ
diff --git a/sw/qa/extras/ooxmlexport/data/tdf153613_textboxAfterPgBreak2.docx
b/sw/qa/extras/ooxmlexport/data/tdf153613_textboxAfterPgBreak2.docx
deleted file mode 100644
index 26006abd2fe3..
Binary files
a/sw/qa/extras/ooxmlexport/data/tdf153613_textboxAfterPgBreak2.docx and
/dev/null differ
diff --git a/sw/qa/extras/ooxmlexport/data/tdf153613_textboxAfterPgBreak3.docx
b/sw/qa/extras/ooxmlexport/data/tdf153613_textboxAfterPgBreak3.docx
new file mode 100644
index ..29c63ad71ed3
Binary files /dev/null and
b/sw/qa/extras/ooxmlexport/data/tdf153613_textboxAfterPgBreak3.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
index de52a56ff0d2..967a4f24183e 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
@@ -357,26 +357,18 @@
DECLARE_OOXMLEXPORT_TEST(testTdf153613_inlineAfterPgBreak2, "tdf153613_inlineAft
assertXPath(pLayout, "//page[2]//anchored"_ostr, 1);
}
-DECLARE_OOXMLEXPORT_TEST(testTdf153613_textboxAfterPgBreak,
"tdf153613_textboxAfterPgBreak.docx")
+DECLARE_OOXMLEXPORT_TEST(testTdf153613_sdtAfterPgBreak,
"tdf153613_sdtAfterPgBreak.docx")
{
-CPPUNIT_ASSERT_EQUAL(3, getParagraphs());
-
-const auto& pLayout = parseLayoutDump();
-assertXPathContent(pLayout, "//page[2]/body/txt"_ostr, "There should be no
prior carriage return.");
+CPPUNIT_ASSERT_EQUAL(2, getPages());
}
-DECLARE_OOXMLEXPORT_TEST(testTdf153613_textboxAfterPgBreak2,
"tdf153613_textboxAfterPgBreak2.docx")
+DECLARE_OOXMLEXPORT_TEST(testTdf153613_textboxAfterPgBreak3,
"tdf153613_textboxAfterPgBreak3.docx")
{
-// same as previous example, except that it is the first paragraph in the
section.
-CPPUNIT_ASSERT_EQUAL(2, getParagraphs());
+// both textboxes on on the second (last) page
+CPPUNIT_ASSERT_EQUAL(2, getPages());
const auto& pLayout = parseLayoutDump();
-assertXPathContent(pLayout, "//page[2]/body/txt"_ostr, "There should be no
prior carriage return.");
-}
-
-DECLARE_OOXMLEXPORT_TEST(testTdf153613_sdtAfterPgBreak,
"tdf153613_sdtAfterPgBreak.docx")
-{
-CPPUNIT_ASSERT_EQUAL(2, getPages());
+assertXPath(pLayout, "//page[2]/body/txt/anchored/fly"_ostr, 2);
}
DECLARE_OOXMLEXPORT_TEST(testTdf153964_topMarginAfterBreak14,
"tdf153964_topMarginAfterBreak14.docx")
diff --git a/writerfilter/source/dmapper/DomainMapper.cxx
b/writerfilter/source/dmapper/DomainMapper.cxx
index 70fc7820844c..98d763b709b6 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -3744,14 +3744,14 @@ void
DomainMapper::lcl_startShape(uno::Reference const& xShape)
// started shape will be on the correct page.
if (m_pImpl->isBreakDeferred(PAGE_BREAK))
{
-// RTF doesn't properly report IsFirstRun, so in order to prevent
[Bug 158693] New: LO 7.6 Impress Remote App Does not show up in the Apple App Store on iPhone or iPad
https://bugs.documentfoundation.org/show_bug.cgi?id=158693 Bug ID: 158693 Summary: LO 7.6 Impress Remote App Does not show up in the Apple App Store on iPhone or iPad Product: Impress Remote Version: unspecified Hardware: All OS: iOS Status: UNCONFIRMED Severity: normal Priority: medium Component: iOS Remote App Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: environment...@gmail.com Description: While it is mentioned in the Help of LO 7.6 ( link below) that the Impress Remote App is available for Apple Devices ( iPad , iPhone), it does not show up searching in the Apple App store ( Like it does in the Google Play Store). https://help.libreoffice.org/latest/en-US/text/simpress/guide/impress_remote.html?DbPAR=IMPRESS#bm_id180820171850105346 It can be confirmed on any iPhone or iPad via the app store -> Impress Remote app does not show up however you search for it ( “Libre Office Remote for Impress” , “Impress Remote” , “LibreOffice Impress Remote” etc.). The app does not show up and hence cannot be installed. The manual page above at the very bottom of the page has a link to "iTunes store" and shows an apple store page where this app seems to be listed. This information in the documentation appears to be outdated. As LibreOffice is available for both Windows and iOS, it will be very helpful if the Impress Remote App is also restored in the apple app store. Thanks Steps to Reproduce: 1. Use an iPhone or IPad 2. Open the App Store 3. Search for the impress remote app using terms like “Libre Office Remote for Impress” , “Impress Remote” , “LibreOffice Impress Remote” Actual Results: The app does not show up and hence cannot be installed on the iPhone or iPad Expected Results: The Impress Remote App must show up in the List of Apps that can be installed from the App Store Reproducible: Always User Profile Reset: No Additional Info: The mention in the documentation page to the app being on the iTunes store should also be updated after app is restored in the app store. -- You are receiving this mail because: You are the assignee for the bug.
ESC meeting agenda: 2023-12-14 16:00 CET
Hi, The prototype agenda is below. Extra items are appreciated either in this document or as a reply to this mail: https://pad.documentfoundation.org/p/esc You can join using Jitsi here: https://jitsi.documentfoundation.org/esc Regards, Miklos --- * Present: + * Completed Action Items: * Pending Action Items: + Update Stephan’s affiliation at https://www.documentfoundation.org/engineering-sc/ (Ilmari) + enable Android builds for libreoffice-7-6 Jenkins builds (Cloph) + contact Gwyn about the security list (Stephan) * Release Engineering update (Cloph) + 7.6: 7.6.5 RC1 in 7 weeks? + 24.2: RC 1 next week? + late features (Michael S) + working on the new ODF encryption + may or may not be ready by the feature freeze, password-based + should be not encrypting all files separately anymore + only enabled with experimental features * Documentation (Olivier) + Bugzilla Documentation statistics 274(274) bugs open + Updates: BZ changes 1 week 1 month 3 months 12 months created 5(1)13(2) 42(-4)265(-3) commented 10(4)35(0) 107(-35) 941(-33) resolved 3(2) 4(1) 14(-1)138(-3) + top 10 contributors: Stéphane Guillou made 26 changes in 1 month, and 337 changes in 1 year Jérôme made 14 changes in 1 month, and 23 changes in 1 year Kaganski, Mike made 11 changes in 1 month, and 77 changes in 1 year Heiko Tietze made 8 changes in 1 month, and 105 changes in 1 year Caolán McNamara made 4 changes in 1 month, and 4 changes in 1 year m.a.riosv made 4 changes in 1 month, and 11 changes in 1 year Raal made 4 changes in 1 month, and 6 changes in 1 year Seth Chaiklin made 4 changes in 1 month, and 320 changes in 1 year Werner Tietz made 4 changes in 1 month, and 4 changes in 1 year Balland-Poirier, Laurent made 3 changes in 1 month, and 3 changes in 1 year * UX Update (Heiko) + Bugzilla (topicUI) statistics 253(253) (topicUI) bugs open, 46(46) (needsUXEval) needs to be evaluated by the UXteam + Updates: BZ changes 1 week1 month 3 months 12 months added 6(1) 13(1) 16(0) 29(0) commented 111(28) 294(84) 543(53)2255(66) removed 0(-1) 1(0) 3(0) 15(0) resolved 7(-6)28(3) 78(-3) 334(1) + top 10 contributors: Heiko Tietze made 149 changes in 1 month, and 1335 changes in 1 year Stéphane Guillou made 107 changes in 1 month, and 624 changes in 1 year ady made 33 changes in 1 month, and 133 changes in 1 year Dieter made 30 changes in 1 month, and 233 changes in 1 year Vernon, Stuart Foote made 24 changes in 1 month, and 308 changes in 1 year Ilmari Lauhakangas made 20 changes in 1 month, and 226 changes in 1 year Seth Chaiklin made 16 changes in 1 month, and 81 changes in 1 year Rafael Lima made 15 changes in 1 month, and 119 changes in 1 year Eyal Rozenberg made 12 changes in 1 month, and 218 changes in 1 year Matt K made 11 changes in 1 month, and 17 changes in 1 year * Crash Testing (Caolan) + 25(+1) import failure, 3(+0) export failures + ??? coverity issues + Google / ossfuzz: ?? fuzzers active now * Crash Reporting (Xisco) + 7.6.1.210294(+365) + 7.6.2.130731(+2648) + 7.6.3.22930(+1073) + 7.6.4.1709(+0) * Mentoring (Hossein) committer... 1 week 1 month 3 months12 months open 62(-11)137(3) 137(-35) 137(-35) reviews 326(-56) 1332(12)2950(20)11698(0) merged 250(-48) 1087(-49) 2893(36)12233(67) abandoned 38(27) 103(29) 186(19) 627(20) own commits 180(-61)835(-84) 2343(8) 9741(-13) review commits 57(-13)237(6) 658(9) 2953(0) contributor... 1 week 1 month 3 months12 months open 177(-18)258(-11)260(-16) 261(-16) reviews 796(-50) 2910(-90) 7312(60)30698(-158) merged 30(17) 76(-12)389(8) 2516(-87) abandoned 13(10) 57(8) 116(10) 620(0) own commits 21(6) 70(6) 208(7) 1007(5) review commits 0(0)0(0)0(0) 0(0) + easyHack statistics: needsDevEval 8(8) needsUXEval 1(1) cleanup_comments 318(318) total 408(408) assigned 23(23) open 357(357) + top 10 contributors: Armin Le Grand (allotropia) made 10 patches in 1 month, and 65 patches in 1 year Matt K made 5 patches in 1 month, and 12 patches in 1 year
core.git: sc/source
sc/source/ui/inc/SparklineRenderer.hxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit b2fd2c247f7f62f9ae6826c4f1b9065a50313217
Author: Julien Nabet
AuthorDate: Wed Dec 13 22:11:03 2023 +0100
Commit: Tomaž Vajngerl
CommitDate: Thu Dec 14 01:40:05 2023 +0100
tdf#152929: Sparkline ignore "High points" color when all values are
negative
See https://en.cppreference.com/w/cpp/types/numeric_limits/min
"min() returns the minimum positive value"
https://en.cppreference.com/w/cpp/types/numeric_limits/lowest (since C++11)
"Returns the lowest finite value representable by the numeric type T, that
is, a finite value x such that there is no other finite value y where y < x."
Change-Id: I322cd84f8124aa6f3f306c168f33cb633418b3f8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160719
Reviewed-by: Julien Nabet
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/sc/source/ui/inc/SparklineRenderer.hxx
b/sc/source/ui/inc/SparklineRenderer.hxx
index 23d62d6d6ae6..1a8adc39a828 100644
--- a/sc/source/ui/inc/SparklineRenderer.hxx
+++ b/sc/source/ui/inc/SparklineRenderer.hxx
@@ -72,7 +72,7 @@ public:
size_t mnLastIndex = 0;
double mfMinimum = std::numeric_limits::max();
-double mfMaximum = std::numeric_limits::min();
+double mfMaximum = std::numeric_limits::lowest();
std::vector const& getValuesList() const { return
maValueList; }
Re: Need help for bug 158451
Hi all, I can now narrow down the error somewhat. Look at method SwTextFrame::FormatImpl() in https://opengrok.libreoffice.org/xref/core/sw/source/core/text/frmform.cxx?r=7d7ca347#1832 It creates SwTextFormatInfo aInf( pRenderContext, this ); Later down in the for-loop, aInf is used. The for-loop iterates over pObj = aInf.GetTextFly().GetAnchoredObjList() and performs aInf.GetTextFly().AnchoredObjToRect(pObj, aRect) AnchoredObjToRect crashes then because of an invalid pObj. You see the AnchoredObjList with these steps: aInf > SwTextPaintInfo > m_aTextFly > mpAnchoredObjList When aInf is created, mpAnchoredObjList is empty. After line #1863 Format_( aLine, aInf ); you can see the invalid item in that list. This happens not always. When you use the example file of the bug report, first the text of the shape inside the group is handled. That works. Then the line where the group is anchored is handled. And there it happens. If the inline anchored object is not a group but a simple shape with text, first the line is handled and then the text of the shape. Next I have examined Format_( aLine, aInf ) for the crash case. It is void SwTextFrame::Format_( SwTextFormatter , SwTextFormatInfo const bool bAdjust ) in https://opengrok.libreoffice.org/xref/core/sw/source/core/text/frmform.cxx?r=7d7ca347#1431 Here watch parameter rInf. It is OK till #1671. After line #1672 bFormat = FormatLine( rLine, bPrev ); rInf has the invalid object. That is surprising. The method does no have rInf as parameter. This method is bool SwTextFrame::FormatLine( SwTextFormatter , const bool bPrev ) in https://opengrok.libreoffice.org/xref/core/sw/source/core/text/frmform.cxx?r=7d7ca347#1296 The adding of the faulty object happens there in #1672 in bFormat = FormatLine( rLine, bPrev ); That method is bool SwTextFrame::FormatLine( SwTextFormatter , const bool bPrev ) in https://opengrok.libreoffice.org/xref/core/sw/source/core/text/frmform.cxx?r=7d7ca347#1296 And there I'm now. I have no idea, how something there changes the parameter rInfo of SwTextFrame::Format_(). And I still do not know, which object is really needed in the above mentioned for-loop. And I still don't know, whether the problem would be solved, when somehow first the line and then the group would be handled. I appreciate any help. Kind regards, Regina Regina Henschel schrieb am 11.12.2023 um 03:15: Hi all, I need help for bug 158451. Problem: A group or a drawing canvas in a docx file crashes Writer, in case it is anchored 'inline' and has a child shape with text. The crash happens in SwAnchoredObject::GetObjRectWithSpaces(). There is no crash, if such group is in an odt file. It is not a new problem, but it will effect more users now, because the drawing canvas and not the VML fallback is imported now and the drawing canvas is anchored 'inline' as default in Word. Steps before the crash are SwTextFormatter::NewPortion() SwTextFormatter::CalcFlyWidth() SwTextFly::GetFrame() SwTextFly::ForEach() SwAnchoredObject::GetObjRectWithSpaces() I think the crash should be fixed till release, but I'm not familiar with these frames. Do you have tips for me? Do you have an idea why a group from docx is different from a group from odt, for example? Attila Bakos had worked in that area, but NISZ does no longer exist. Kind regards, Regina
[Bug 158692] The data could not be loaded completely because the maximum number of rows per sheet was exceeded.
https://bugs.documentfoundation.org/show_bug.cgi?id=158692 --- Comment #2 from ady --- In addition to enabling (or not) "very large spreadsheets", users could simply: 1. Open a new empty Calc worksheet. 2. [CTRL]+[DownArrow]. The Row Header shows the maximum number of rows. 3. (Optional) Type-in the formula: =ROW() and press [ENTER]. Now the maximum number of rows is shown on the cell. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158689] Calc Format>Columns>Optimal Width reverts to default value
https://bugs.documentfoundation.org/show_bug.cgi?id=158689 --- Comment #1 from ady --- (In reply to David Lynch from comment #0) > Do the following: > a. File>New>Spreadsheet > b. Select all cells > c. Format>Columns>Optimal Width enter 0 in Add, unselect Default value [OK] > d. Enter 1 in cell A1 > e. Select column A, double-click right column separator in column A. > f. Column width changes to .53cm > g. Format>Columns>Optimal Width Add still shows 0, just do [OK] > h. Column width changes to .33cm > > The correct column width value is at step h: the value at step f is that > with the default add value of 2mm, rather than the correct value of 0. I don't understand what you mean. The resulting width in step f depends on the content of the selected cells (cell A1 in this case) for step e. So I don't see how the width of the column in step f would result in some specific expected value (which would be incorrect in Calc according to your description in comment 0?) Additionally, the width also depends on other factors, such as the size of the font and the zoom value. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158681] FILEOPEN: DOCX: Missing textbox in document
https://bugs.documentfoundation.org/show_bug.cgi?id=158681 --- Comment #2 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6cd6df7e0d6b0ff8150c9a95a35b17800942026a tdf#158681 Revert "tdf#153613 writerfilter: don't always split para It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158681] FILEOPEN: DOCX: Missing textbox in document
https://bugs.documentfoundation.org/show_bug.cgi?id=158681 Commit Notification changed: What|Removed |Added Whiteboard||target:24.8.0 -- You are receiving this mail because: You are the assignee for the bug.
core.git: sw/qa writerfilter/source
dev/null |binary
sw/qa/extras/ooxmlexport/data/tdf153613_textboxAfterPgBreak3.docx |binary
sw/qa/extras/ooxmlexport/ooxmlexport18.cxx| 20
+++---
writerfilter/source/dmapper/DomainMapper.cxx | 16
4 files changed, 14 insertions(+), 22 deletions(-)
New commits:
commit 6cd6df7e0d6b0ff8150c9a95a35b17800942026a
Author: Justin Luth
AuthorDate: Wed Dec 13 16:09:52 2023 -0500
Commit: Justin Luth
CommitDate: Thu Dec 14 00:31:23 2023 +0100
tdf#158681 Revert "tdf#153613 writerfilter: don't always split para
... for shape w/ pagebreak"
This reverts 7.6 commit a9bc19c2d4a35606668aa2dcc53355651b71ee78.
The commit in general is probably fine. However, it fails in case
of an empty paragraph (with only anchors).
Unfortunately, there is no way of knowing ahead of time,
so either everything needs to be processed after a delay,
or else the paragraph needs to be split and then re-joined
in case it is not an empty paragraph.
Both options are extremely non-trivial - I don't know how
to do either of them.
In this case it is also the last paragraph in the document,
again something not known during import and which has
special-casing in MSO.
make CppunitTest_sw_ooxmlexport18 \
CPPUNIT_TEST_NAME=testTdf153613_textboxAfterPgBreak3
Change-Id: I4471e216b6523032b85178d85795434694cc1e22
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160720
Tested-by: Jenkins
Reviewed-by: Justin Luth
diff --git a/sw/qa/extras/ooxmlexport/data/tdf153613_textboxAfterPgBreak.docx
b/sw/qa/extras/ooxmlexport/data/tdf153613_textboxAfterPgBreak.docx
deleted file mode 100644
index 4ad4dfba8110..
Binary files a/sw/qa/extras/ooxmlexport/data/tdf153613_textboxAfterPgBreak.docx
and /dev/null differ
diff --git a/sw/qa/extras/ooxmlexport/data/tdf153613_textboxAfterPgBreak2.docx
b/sw/qa/extras/ooxmlexport/data/tdf153613_textboxAfterPgBreak2.docx
deleted file mode 100644
index 26006abd2fe3..
Binary files
a/sw/qa/extras/ooxmlexport/data/tdf153613_textboxAfterPgBreak2.docx and
/dev/null differ
diff --git a/sw/qa/extras/ooxmlexport/data/tdf153613_textboxAfterPgBreak3.docx
b/sw/qa/extras/ooxmlexport/data/tdf153613_textboxAfterPgBreak3.docx
new file mode 100644
index ..29c63ad71ed3
Binary files /dev/null and
b/sw/qa/extras/ooxmlexport/data/tdf153613_textboxAfterPgBreak3.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
index de52a56ff0d2..967a4f24183e 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
@@ -357,26 +357,18 @@
DECLARE_OOXMLEXPORT_TEST(testTdf153613_inlineAfterPgBreak2, "tdf153613_inlineAft
assertXPath(pLayout, "//page[2]//anchored"_ostr, 1);
}
-DECLARE_OOXMLEXPORT_TEST(testTdf153613_textboxAfterPgBreak,
"tdf153613_textboxAfterPgBreak.docx")
+DECLARE_OOXMLEXPORT_TEST(testTdf153613_sdtAfterPgBreak,
"tdf153613_sdtAfterPgBreak.docx")
{
-CPPUNIT_ASSERT_EQUAL(3, getParagraphs());
-
-const auto& pLayout = parseLayoutDump();
-assertXPathContent(pLayout, "//page[2]/body/txt"_ostr, "There should be no
prior carriage return.");
+CPPUNIT_ASSERT_EQUAL(2, getPages());
}
-DECLARE_OOXMLEXPORT_TEST(testTdf153613_textboxAfterPgBreak2,
"tdf153613_textboxAfterPgBreak2.docx")
+DECLARE_OOXMLEXPORT_TEST(testTdf153613_textboxAfterPgBreak3,
"tdf153613_textboxAfterPgBreak3.docx")
{
-// same as previous example, except that it is the first paragraph in the
section.
-CPPUNIT_ASSERT_EQUAL(2, getParagraphs());
+// both textboxes on on the second (last) page
+CPPUNIT_ASSERT_EQUAL(2, getPages());
const auto& pLayout = parseLayoutDump();
-assertXPathContent(pLayout, "//page[2]/body/txt"_ostr, "There should be no
prior carriage return.");
-}
-
-DECLARE_OOXMLEXPORT_TEST(testTdf153613_sdtAfterPgBreak,
"tdf153613_sdtAfterPgBreak.docx")
-{
-CPPUNIT_ASSERT_EQUAL(2, getPages());
+assertXPath(pLayout, "//page[2]/body/txt/anchored/fly"_ostr, 2);
}
DECLARE_OOXMLEXPORT_TEST(testTdf153964_topMarginAfterBreak14,
"tdf153964_topMarginAfterBreak14.docx")
diff --git a/writerfilter/source/dmapper/DomainMapper.cxx
b/writerfilter/source/dmapper/DomainMapper.cxx
index 70fc7820844c..98d763b709b6 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -3744,14 +3744,14 @@ void
DomainMapper::lcl_startShape(uno::Reference const& xShape)
// started shape will be on the correct page.
if (m_pImpl->isBreakDeferred(PAGE_BREAK))
{
-// RTF doesn't properly report IsFirstRun, so in order to prevent
regressions
-// always split the paragraph for RTF since that is the way it has
been done lately.
-if
[Bug 158692] The data could not be loaded completely because the maximum number of rows per sheet was exceeded.
https://bugs.documentfoundation.org/show_bug.cgi?id=158692 m.a.riosv changed: What|Removed |Added Severity|normal |enhancement Status|UNCONFIRMED |NEW Ever confirmed|0 |1 CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m.a.riosv --- To me, this is a request for enhancement. With Menu/Tools/Options/LibreOffice/Advanced/Experimental features enable. Menu/Tools/Options/LibreOffice Calc/Default/Enable very large spreadsheet the limit is 16 million of rows. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158625] Dateformat not preserved in calc
https://bugs.documentfoundation.org/show_bug.cgi?id=158625 --- Comment #11 from ady --- (In reply to Guus Ellenkamp from comment #0) > Steps to Reproduce: > 1. Format cell to date format mm/dd/yy. > 2. Save file. > 3. Open file. > 4. Date changed back to mm-dd-yy. @Guus, I am trying to reproduce your steps using your attachment 191354 (an xlsx spreadsheet file), but I must be misunderstanding something. When I open attachment 191354 I see 2 worksheets. "Sheet2" has nothing relevant to this report. "Sheet1" has a list of dates. The cells containing the dates are already formatted as "MM/DD/YY" and are displayed accordingly, meaning that there is nothing to initially change or re-format (trying to follow your steps), but rather save the file "as-is" (using a different name). Saving the file with the same xlsx format (with a different name), closing and re-opening it, I still see the dates formatted as MM/DD/YY and displayed in the same way. So, there is no "Date changed back to mm-dd-yy" (and it never was). Perhaps we need more specific steps, and/or a different spreadsheet file. It is also possible that I am seeing different things than you are. Or maybe I am misunderstanding something. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158680] Leading space if using variables
https://bugs.documentfoundation.org/show_bug.cgi?id=158680 m.a.riosv changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m.a.riosv --- Please attach a sample file. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158692] New: The data could not be loaded completely because the maximum number of rows per sheet was exceeded.
https://bugs.documentfoundation.org/show_bug.cgi?id=158692 Bug ID: 158692 Summary: The data could not be loaded completely because the maximum number of rows per sheet was exceeded. Product: LibreOffice Version: 7.6.4.1 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: j...@jguk.org Created attachment 191418 --> https://bugs.documentfoundation.org/attachment.cgi?id=191418=edit Current behavor Could this dialog be updated to show what the limit is? Looks like the limit is 1,048,576 rows. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158691] Calc not responding with Windows' "Offer suggested actions" set ON
https://bugs.documentfoundation.org/show_bug.cgi?id=158691 ady changed: What|Removed |Added Summary|On copying multiple cells |Calc not responding with |Calc goes into Not |Windows' "Offer suggested |Responding, locks up and|actions" set ON |freezes.| -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158670] EDITING: Deleting a drilldown table created by a pivot, the pivot table is transformed in a normal table
https://bugs.documentfoundation.org/show_bug.cgi?id=158670 td changed: What|Removed |Added Resolution|--- |FIXED Status|NEEDINFO|RESOLVED --- Comment #6 from td --- Can confirm, its fixed in 7.6.5-dev Great, thanks! This bug cost me a couple of hours. Thanks for your work! -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158139] Writer, Word Completion does not function
https://bugs.documentfoundation.org/show_bug.cgi?id=158139 --- Comment #13 from PawelS --- It stopped working for me in November too. I use Writer irregularly, so I can't associate it with Windows Update, I think I might notice it after using "check spelling" button. Version: 7.6.4.1 (X86_64) / LibreOffice Community Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1 CPU threads: 12; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: en-GB (pl_PL); UI: pl-PL Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
core.git: vcl/source
vcl/source/pdf/XmpMetadata.cxx |8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
New commits:
commit 297a6673175308168669870882c016b496652a76
Author: Stephan Bergmann
AuthorDate: Wed Dec 13 13:11:03 2023 +0100
Commit: Stephan Bergmann
CommitDate: Wed Dec 13 23:15:01 2023 +0100
Work around strange error seen at least with VS 2022 Preview 17.9.0 Preview
2.0
> vcl/source/pdf/XmpMetadata.cxx(39): error C2440: '':
cannot convert from 'initializer list' to 'rtl::OStringLiteral<55>'
> vcl/source/pdf/XmpMetadata.cxx(39): note: Invalid aggregate initialization
> vcl/source/pdf/XmpMetadata.cxx(39): note: too many initializers
(Smells like a bug in that compiler's u8"..." handling, where it maybe gets
tripped by the 3-byte UTF-8 encoding of \uFEFF?)
Change-Id: I1c6a856a67c8328ed5fcc2f2fa6bb26f16319f55
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160681
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/vcl/source/pdf/XmpMetadata.cxx b/vcl/source/pdf/XmpMetadata.cxx
index 53bf3902ab2b..ddd638551bd5 100644
--- a/vcl/source/pdf/XmpMetadata.cxx
+++ b/vcl/source/pdf/XmpMetadata.cxx
@@ -8,6 +8,10 @@
*
*/
+#include
+
+#include
+
#include
#include
@@ -35,8 +39,8 @@ void XmpMetadata::write()
mpMemoryStream = std::make_unique(4096 /*Initial*/, 64
/*Resize*/);
// Header
-mpMemoryStream->WriteOString(
-OStringLiteral(u8"\n"));
+mpMemoryStream->WriteOString(std::string_view(reinterpret_cast(
+u8"\n")));
{
tools::XmlWriter aXmlWriter(mpMemoryStream.get());
[Bug 158673] Drop Cap Style disappears
https://bugs.documentfoundation.org/show_bug.cgi?id=158673 --- Comment #6 from Chris Hamill --- Created attachment 191417 --> https://bugs.documentfoundation.org/attachment.cgi?id=191417=edit a couple chapters from the book I'm translating and formatting. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158402] Blank dialog or menus after standby or change in screen resolution (Win11)
https://bugs.documentfoundation.org/show_bug.cgi?id=158402 V Stuart Foote changed: What|Removed |Added Summary|Blank dialog or menus after |Blank dialog or menus after |standby or change in screen |standby or change in screen |resolution |resolution (Win11) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158325] Option to start row at 0
https://bugs.documentfoundation.org/show_bug.cgi?id=158325 --- Comment #4 from m.a.riosv --- Please, could you show or link the convoluted solution in Excel. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158685] Implement a simple calculation of values to input size and position of draw objects
https://bugs.documentfoundation.org/show_bug.cgi?id=158685 V Stuart Foote changed: What|Removed |Added Summary|Feature request - Draw -|Implement a simple |add formula when resize an |calculation of values to |object |input size and position of ||draw objects Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||vsfo...@libreoffice.org Status|NEW |UNCONFIRMED Ever confirmed|1 |0 --- Comment #2 from V Stuart Foote --- Guess this input method would be implemented on the "Position and Size..." dialog and tab. Kind of a stretch for *needing* to do the simple calculations in the input field of the UI, but we already have spin box and direct unit conversion, so might be of use? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158685] Implement a simple calculation of values to input size and position of draw objects
https://bugs.documentfoundation.org/show_bug.cgi?id=158685 V Stuart Foote changed: What|Removed |Added Summary|Feature request - Draw -|Implement a simple |add formula when resize an |calculation of values to |object |input size and position of ||draw objects Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||vsfo...@libreoffice.org Status|NEW |UNCONFIRMED Ever confirmed|1 |0 --- Comment #2 from V Stuart Foote --- Guess this input method would be implemented on the "Position and Size..." dialog and tab. Kind of a stretch for *needing* to do the simple calculations in the input field of the UI, but we already have spin box and direct unit conversion, so might be of use? -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 158625] Dateformat not preserved in calc
https://bugs.documentfoundation.org/show_bug.cgi?id=158625 --- Comment #10 from m.a.riosv --- Then please attach another sample file -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158670] EDITING: Deleting a drilldown table created by a pivot, the pivot table is transformed in a normal table
https://bugs.documentfoundation.org/show_bug.cgi?id=158670 Stéphane Guillou (stragu) changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||stephane.guillou@libreoffic ||e.org Ever confirmed|0 |1 --- Comment #5 from Stéphane Guillou (stragu) --- I have witnessed this in my testing of bug 158054, a duplicate of bug 158223, which should be fixed in the upcoming 7.6.5 version. Can you please test a daily build of 7.6.5 and let us know if it is fixed in that version? https://dev-builds.libreoffice.org/daily/libreoffice-7-6/ -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158673] Drop Cap Style disappears
https://bugs.documentfoundation.org/show_bug.cgi?id=158673 --- Comment #5 from m.a.riosv --- Please attach a sample file, and paste the information in Menu/Help/About LibreOffice, there is an icon to copy. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158670] EDITING: Deleting a drilldown table created by a pivot, the pivot table is transformed in a normal table
https://bugs.documentfoundation.org/show_bug.cgi?id=158670 --- Comment #4 from m.a.riosv --- Reduce the data at minimum, and use find and replace to depersonalize it. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158402] Blank dialog or menus after standby or change in screen resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=158402 --- Comment #10 from Mike Grace --- Created attachment 191416 --> https://bugs.documentfoundation.org/attachment.cgi?id=191416=edit Windows Theme -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158402] Blank dialog or menus after standby or change in screen resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=158402 --- Comment #9 from Mike Grace --- (In reply to Stéphane Guillou (stragu) from comment #6) > Thanks. > (In reply to Mike Grace from comment #5) > > It will also happen on Resolution changes > This sounds very similar to bug 151756, which was about black text on black > background in menus, after sleep or when connecting another display. > However, that bug was closed because of the improvements to dark mode > support in version 7.5. > Bug 156205 also shows a blank dialog. > Bug 157695 has blank menus on a multimonitor setup with different > resolutions. > > Which Windows appearance settings are you using? And I assume that Tools > > Options > LibreOffice > View > Appearance uses "System"? Yep - it's there as system. Windows appearance is Dark with attached options (This might all be useless info. but I thought I'd add it.) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158402] Blank dialog or menus after standby or change in screen resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=158402 --- Comment #8 from Mike Grace --- Created attachment 191415 --> https://bugs.documentfoundation.org/attachment.cgi?id=191415=edit No theme -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158386] Windows Excel File locks up Libre Calc vers. 7.6.2.1 while trying to open it.
https://bugs.documentfoundation.org/show_bug.cgi?id=158386 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org --- Comment #4 from Stéphane Guillou (stragu) --- For reference, the Visual Basic documentation that Andreas quoted is: https://learn.microsoft.com/en-us/dotnet/visual-basic/programming-guide/language-features/procedures/optional-parameters Also in VBA documentation[1]: "defaultvalue: Any constant or constant expression." So even MS Office shouldn't allow an argument default that uses a function, right? [1]: https://learn.microsoft.com/en-us/office/vba/language/reference/user-interface-help/function-statement -- You are receiving this mail because: You are the assignee for the bug.
[Bug 152929] Sparkline ignore "High points" color when all values are negative
https://bugs.documentfoundation.org/show_bug.cgi?id=152929 Julien Nabet changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr |desktop.org | --- Comment #2 from Julien Nabet --- https://gerrit.libreoffice.org/c/core/+/160719 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 105844] FILESAVE: Very slow saving with password compared to 5.2.5
https://bugs.documentfoundation.org/show_bug.cgi?id=105844 --- Comment #33 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/09f23a3dc5cd571df347cba9b003195de35f3ddd tdf#105844 package,sfx2: remove checksum infoleak when using AEAD It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
core.git: offapi/com package/inc package/source sfx2/source
offapi/com/sun/star/xml/crypto/CipherID.idl|2
package/inc/EncryptionData.hxx | 14 ++-
package/inc/ZipFile.hxx|4 -
package/inc/ZipPackage.hxx |4 -
package/inc/ZipPackageStream.hxx |6 +
package/source/manifest/ManifestExport.cxx | 31 ---
package/source/manifest/ManifestImport.cxx |6 -
package/source/zipapi/XUnbufferedStream.cxx|1
package/source/zipapi/ZipFile.cxx | 98 +++--
package/source/zipapi/ZipOutputEntry.cxx | 13 ++-
package/source/zippackage/ZipPackage.cxx | 68 -
package/source/zippackage/ZipPackageStream.cxx | 37 +++--
sfx2/source/doc/objstor.cxx|2
13 files changed, 209 insertions(+), 77 deletions(-)
New commits:
commit 09f23a3dc5cd571df347cba9b003195de35f3ddd
Author: Michael Stahl
AuthorDate: Wed Dec 13 18:36:15 2023 +0100
Commit: Michael Stahl
CommitDate: Wed Dec 13 22:02:52 2023 +0100
tdf#105844 package,sfx2: remove checksum infoleak when using AEAD
AEAD provides the verification of the password automatically, by reading
the entire stream the tag at the end will be verified.
The existing attributes manifest:checksum-type/manifest:checksum leak
information about the plain text.
This was mitigated with the addChaffWhenEncryptedStorage() functions
(see commit f57baefbd3c4c5d8e5ec28e8702c91d60ffc5de2) but a better
solution that also works for non-XML streams is to simply omit the
attributes; authenticated encryption provides better verification
without any leak.
* "ChecksumAlgorithm" property can be set to void now to remove the
checksum
* change a bunch of members in EncryptionData, ZipPackage,
ZipPackageStream to optional
* change ZipFile::checkValidPassword() to open the stream and return it
Change-Id: Id95288d0c238c4f9940fc5a185df814e8edcbad3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160711
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/offapi/com/sun/star/xml/crypto/CipherID.idl
b/offapi/com/sun/star/xml/crypto/CipherID.idl
index c1ecd297a741..3d9bbc000cfb 100644
--- a/offapi/com/sun/star/xml/crypto/CipherID.idl
+++ b/offapi/com/sun/star/xml/crypto/CipherID.idl
@@ -46,7 +46,7 @@ constants CipherID
@see https://www.w3.org/TR/xmlenc-core1/#sec-AES-GCM
-@since LO 24.2
+@since LibreOffice 24.2
*/
const long AES_GCM_W3C = 3;
};
diff --git a/package/inc/EncryptionData.hxx b/package/inc/EncryptionData.hxx
index 73408a090faf..f2d5c0b126b0 100644
--- a/package/inc/EncryptionData.hxx
+++ b/package/inc/EncryptionData.hxx
@@ -22,6 +22,8 @@
#include
#include
+#include
+
class BaseEncryptionData : public cppu::OWeakObject
{
public:
@@ -47,16 +49,20 @@ class EncryptionData final : public BaseEncryptionData
public:
css::uno::Sequence < sal_Int8 > m_aKey;
sal_Int32 m_nEncAlg;
-sal_Int32 m_nCheckAlg;
+::std::optional m_oCheckAlg;
sal_Int32 m_nDerivedKeySize;
sal_Int32 m_nStartKeyGenID;
bool m_bTryWrongSHA1;
-EncryptionData(const BaseEncryptionData& aData, const css::uno::Sequence<
sal_Int8 >& aKey, sal_Int32 nEncAlg, sal_Int32 nCheckAlg, sal_Int32
nDerivedKeySize, sal_Int32 nStartKeyGenID, bool const bTryWrongSHA1)
+EncryptionData(const BaseEncryptionData& aData,
+const css::uno::Sequence& aKey, sal_Int32 const nEncAlg,
+::std::optional const oCheckAlg,
+sal_Int32 const nDerivedKeySize, sal_Int32 const nStartKeyGenID,
+bool const bTryWrongSHA1)
: BaseEncryptionData( aData )
, m_aKey( aKey )
, m_nEncAlg( nEncAlg )
-, m_nCheckAlg( nCheckAlg )
+, m_oCheckAlg( oCheckAlg )
, m_nDerivedKeySize( nDerivedKeySize )
, m_nStartKeyGenID( nStartKeyGenID )
, m_bTryWrongSHA1(bTryWrongSHA1)
@@ -66,7 +72,7 @@ public:
: BaseEncryptionData( aData )
, m_aKey( aData.m_aKey )
, m_nEncAlg( aData.m_nEncAlg )
-, m_nCheckAlg( aData.m_nCheckAlg )
+, m_oCheckAlg( aData.m_oCheckAlg )
, m_nDerivedKeySize( aData.m_nDerivedKeySize )
, m_nStartKeyGenID( aData.m_nStartKeyGenID )
, m_bTryWrongSHA1(aData.m_bTryWrongSHA1)
diff --git a/package/inc/ZipFile.hxx b/package/inc/ZipFile.hxx
index f6b184994729..2d42ed403136 100644
--- a/package/inc/ZipFile.hxx
+++ b/package/inc/ZipFile.hxx
@@ -70,7 +70,9 @@ class ZipFile
const bool bUseBufferedStream = true,
const OUString& aMediaType = OUString() );
-bool hasValidPassword ( ZipEntry const & rEntry, const rtl::Reference <
EncryptionData > );
+css::uno::Reference checkValidPassword(
+ZipEntry const& rEntry, rtl::Reference const&
rData,
+rtl::Reference const& rMutexHolder);
bool checkSizeAndCRC( const ZipEntry& aEntry );
diff --git a/package/inc/ZipPackage.hxx
core.git: sfx2/source
sfx2/source/doc/docfile.cxx |3 ---
1 file changed, 3 deletions(-)
New commits:
commit df23f570536c939ab4b44125ac8f62a8500e6f7c
Author: Michael Stahl
AuthorDate: Wed Dec 13 19:49:23 2023 +0100
Commit: Michael Stahl
CommitDate: Wed Dec 13 22:02:20 2023 +0100
sfx2: remove wrong asserts
Mike Kaganski points out that "soffice -n anything.docx" triggers the
one in GetOutStream(), called from SfxMedium::CreateTempFile()
!bTransferSuccess path, so the assumption of which parts of SfxMedium
can be in use concurrently was wrong.
Change-Id: I40f321d71297cadcdf4bf9ba6f07c4db3d2ac523
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160712
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/sfx2/source/doc/docfile.cxx b/sfx2/source/doc/docfile.cxx
index 319615bacd20..adc22797f6c3 100644
--- a/sfx2/source/doc/docfile.cxx
+++ b/sfx2/source/doc/docfile.cxx
@@ -678,7 +678,6 @@ bool SfxMedium::IsSkipImages() const
SvStream* SfxMedium::GetInStream()
{
-//assert(!pImpl->xStorage); // either SvStream or Storage
if ( pImpl->m_pInStream )
return pImpl->m_pInStream.get();
@@ -749,7 +748,6 @@ void SfxMedium::CloseInStream_Impl(bool bInDestruction)
SvStream* SfxMedium::GetOutStream()
{
-assert(!pImpl->xStorage); // either SvStream or Storage
if ( !pImpl->m_pOutStream )
{
// Create a temp. file if there is none because we always
@@ -1760,7 +1758,6 @@ uno::Reference < embed::XStorage > SfxMedium::GetStorage(
bool bCreateTempFile )
if ( pImpl->xStorage.is() || pImpl->m_bTriedStorage )
return pImpl->xStorage;
-assert(!pImpl->m_pOutStream /*&& !pImpl->m_pInStream*/); // either
SvStream or Storage
uno::Sequence< uno::Any > aArgs( 2 );
auto pArgs = aArgs.getArray();
core.git: vcl/source
vcl/source/filter/png/PngImageWriter.cxx |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
New commits:
commit 1956bd5f27fa10a336b9cf9e27751eca5ff907b5
Author: Patrick Luby
AuthorDate: Wed Dec 13 09:03:12 2023 -0500
Commit: Patrick Luby
CommitDate: Wed Dec 13 21:37:51 2023 +0100
Fix unit test failure when using Skia in debug builds
Calling aBitmap.HasGreyPalette8Bit() hits an assert when
using Skia in a debug build so query the palette through
the bitmap read access object.
Change-Id: I12fad6783ec7d6df6c99db197aaa52fd4b01ed69
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160684
Tested-by: Jenkins
Reviewed-by: Patrick Luby
diff --git a/vcl/source/filter/png/PngImageWriter.cxx
b/vcl/source/filter/png/PngImageWriter.cxx
index 584487fabdd5..1674f80e14a0 100644
--- a/vcl/source/filter/png/PngImageWriter.cxx
+++ b/vcl/source/filter/png/PngImageWriter.cxx
@@ -209,7 +209,10 @@ static bool pngWrite(SvStream& rStream, const Graphic&
rGraphic, int nCompressio
}
case ScanlineFormat::N8BitPal:
{
-if (!aBitmap.HasGreyPalette8Bit())
+// Calling aBitmap.HasGreyPalette8Bit() hits an assert when
+// using Skia in a debug build so query the palette through
+// the bitmap read access object.
+if (!pAccess->HasPalette() ||
!pAccess->GetPalette().IsGreyPalette8Bit())
colorType = PNG_COLOR_TYPE_PALETTE;
else
{
[Bug 158684] CALC CHART XY Scatter Chart: line type "stepped" ignores parameters (de: "Streudiagramm / Stufen")
https://bugs.documentfoundation.org/show_bug.cgi?id=158684 Julien Nabet changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr |desktop.org | --- Comment #2 from Julien Nabet --- https://gerrit.libreoffice.org/c/core/+/160715 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158684] CALC CHART XY Scatter Chart: line type "stepped" ignores parameters (de: "Streudiagramm / Stufen")
https://bugs.documentfoundation.org/show_bug.cgi?id=158684 Julien Nabet changed: What|Removed |Added Severity|normal |major Ever confirmed|0 |1 Keywords||regression Status|UNCONFIRMED |NEW OS|Windows (All) |All --- Comment #1 from Julien Nabet --- On pc Debian x86-64 with master sources updated today, I could reproduce this. Regression from 65752e649872edfd98915035b61aca510ae8f271 jsdialog: enable and make async chart line prop dialog -- You are receiving this mail because: You are the assignee for the bug.
[Bug 148523] Table properties changes only a cell in Impress (full table expected)
https://bugs.documentfoundation.org/show_bug.cgi?id=148523 --- Comment #5 from Andrew Rowland --- Also in 7.5.9.2 I would add that changing the whole table, unless only certain cells are selected, is the logical and intuitive thing to do. If I select Table Properties, I expect my changes to apply to the table, not a small part of it. I was surprised today by its behaviour, and had to find out that I had to select all the cells by trial and error. An option, 'Selected cells only' or similar would make it all explicit and transparent. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158673] Drop Cap Style disappears
https://bugs.documentfoundation.org/show_bug.cgi?id=158673 --- Comment #4 from Chris Hamill --- Don't know what info is needed now. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158691] New: On copying multiple cells Calc goes into Not Responding, locks up and freezes.
https://bugs.documentfoundation.org/show_bug.cgi?id=158691 Bug ID: 158691 Summary: On copying multiple cells Calc goes into Not Responding, locks up and freezes. Product: LibreOffice Version: 7.6.4.1 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: myuf...@gmail.com Description: Copying multiple cells causes Calc to not respond and memory use to increase rapidly and appears would use all available memory given time. I close the program before it goes over a Gig or so as I wasn't interested in causing OOM errors on my OS. The Calc application CPU stays around 8-12%. There are multiple ways to reproduce this issue. However, making a new spreadsheet copying a 2x2 is enough to freeze it. There is no need to change the cells or for a specific spreadsheet file. I just installed LibreOffice and this laptop is brand new. I wouldn't expect problems like this. Steps to Reproduce: 1. In the Windows search menu search "Offer suggested actions" and it should take you to a setting in System > Clipboard. Toggle "Suggested actions" on 2. Open Calc and new file or existing file whatever you prefer. 3. Copy multiple cells or copy a whole row or copy a whole column. 4. Attempt any other action. Calc should be frozen and will go not responding in a few minutes. 5. Check Task Manager and the Calc process memory usage will be climbing and continue to climb. Careful, I don't not know the max it will climb. It could cause OOM if left alone for too long. 6. Stop Calc from task bar or kill the process from Task Manager. Actual Results: Calc stops responding and freezes Expected Results: Calc to copy cells to the Windows clipboard and continue to be responsive. Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.6.4.1 (X86_64) / LibreOffice CommunityBuild ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1CPU threads: 20; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: winLocale: en-US (en_US); UI: en-USCalc: CL threaded My system info. Edition Windows 11 Pro Version 22H2 Installed on 12/5/2023 OS build 22621.2792 Experience Windows Feature Experience Pack 1000.22681.1000.0 Troubleshooting steps I remember taking: Safemode Safemode disable hardware acceleration Disable JRE Multiple reboots Install repair Delete LibreOffice profile Updating Windows and Laptop drivers (Just because) This appears to be due to the Windows clipboard "Suggested actions" feature. When I disabled that feature the issue is now resolved. Workaround: In the Windows search menu search "Offer suggested actions" and it should take you to a setting in System > Clipboard. Toggle "Suggested actions" off. It says this is for getting suggestions for actions when you copy a date, time, or phone number. I found the workaround from the suggestions in this thread. https://ask.libreoffice.org/t/calc-freezes-on-copy-nov-22-solution-recomendations-make-no-difference/87840/8 Request: Fix the compatibility issue between LibreOffice and Windows clipboard features such as the "Suggested actions". It also seems the clipboard history feature might affect LibreOffice as well based on other reports, but I didn't test enabling that feature. P.S this is my first bug report. I hope I am doing this correctly. For the priority, I thought normal fits because of the high visibility to users because Windows is setting "Offer suggested actions" is enabled by default. It wasn't easy finding the answer and I could see new users giving up on LibreOffice if this is their initial experience. The issue was starting to disappoint me to switch to something else. Anyway, the clipboard feature is new and I haven't been able to use it to comment on it's value, but it looks nice from what I have seen. It is a shame I have to disable it for LibreOffice. -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'libreoffice-24-2' - sfx2/source
sfx2/source/control/recentdocsviewitem.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 944b5a435c14435841d70f09bc922a6a5c0a741c
Author: Michael Stahl
AuthorDate: Wed Dec 13 12:55:48 2023 +0100
Commit: Michael Stahl
CommitDate: Wed Dec 13 20:55:48 2023 +0100
sfx2: reduce warning spam from IsDocEncrypted()
Change-Id: I76b9d550c297db7c6f8d1d9a2739fbe050727faf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160680
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 152e10996fe9c788daec940bab6fe897097ba992)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160692
diff --git a/sfx2/source/control/recentdocsviewitem.cxx
b/sfx2/source/control/recentdocsviewitem.cxx
index 369e219e98c5..c114be951cfc 100644
--- a/sfx2/source/control/recentdocsviewitem.cxx
+++ b/sfx2/source/control/recentdocsviewitem.cxx
@@ -65,7 +65,7 @@ bool IsDocEncrypted(const OUString& rURL)
}
catch (const uno::Exception&)
{
-TOOLS_WARN_EXCEPTION("sfx", "caught exception trying to find out if
doc <"
+TOOLS_INFO_EXCEPTION("sfx", "caught exception trying to find out if
doc <"
<< rURL << "> is encrypted:");
}
core.git: framework/source
framework/source/services/desktop.cxx |2 --
1 file changed, 2 deletions(-)
New commits:
commit 13b7905ba142d78b6061c52a8cc191125b0d7d5f
Author: Stephan Bergmann
AuthorDate: Wed Dec 13 10:18:00 2023 +0100
Commit: Stephan Bergmann
CommitDate: Wed Dec 13 20:48:27 2023 +0100
Remove misleading comment
...that had been added with 33fa50e1191c75fd2fcbf6f852ec1d76af58a577 "Drop
some
pointless assertions" back in 2011, but is no longer meaningful now that
this is
a proper assert since 6e35794cad555485955c3b43593497dcdbf29840 "terminate
XDesktop properly in unit tests"
Change-Id: Id8592df03f2a4c070af3cc691a0aa65ba8c2c061
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160675
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/framework/source/services/desktop.cxx
b/framework/source/services/desktop.cxx
index 237d35afc6a5..12a45fa93117 100644
--- a/framework/source/services/desktop.cxx
+++ b/framework/source/services/desktop.cxx
@@ -1038,8 +1038,6 @@ void SAL_CALL Desktop::disposing()
// Safe impossible cases
// It's a programming error if dispose is called before terminate!
-// But if you just ignore the assertion (which happens in unit
-// tests for instance in sc/qa/unit) nothing bad happens.
assert(m_bIsShutdown && "Desktop disposed before terminating it");
{
core.git: sc/source
sc/source/ui/view/cellsh1.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 8dd210c44268850195204cd7b7ca5e7aab0b33e8
Author: Caolán McNamara
AuthorDate: Tue Dec 12 16:40:31 2023 +
Commit: Caolán McNamara
CommitDate: Wed Dec 13 20:35:35 2023 +0100
add a notifier for the "Edit Existing Cond Formats" warning dialog
otherwise in --enable-dbgutil this assert with:
vcl::Window::SetLOKNotifier(vcl::Window * const this, const
vcl::ILibreOfficeKitNotifier * pNotifier, bool bParent)
(vcl/source/window/window.cxx:3193)
libmergedlo.so!Dialog::ImplStartExecute(Dialog * const this)
(vcl/source/window/dialog.cxx:940)
libmergedlo.so!Dialog::StartExecuteAsync(Dialog * const this,
VclAbstractDialog::AsyncContext & rCtx) (vcl/source/window/dialog.cxx:)
...
libsclo.so!ScCellShell::ExecuteEdit(ScCellShell * const this, SfxRequest &
rReq) (sc/source/ui/view/cellsh1.cxx:2352)
Change-Id: I8be89a1e5d7fa2498118bad7a94ed6aad743095b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160634
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sc/source/ui/view/cellsh1.cxx b/sc/source/ui/view/cellsh1.cxx
index 558d5a816615..35e4eec23ebc 100644
--- a/sc/source/ui/view/cellsh1.cxx
+++ b/sc/source/ui/view/cellsh1.cxx
@@ -2347,7 +2347,7 @@ void ScCellShell::ExecuteEdit( SfxRequest& rReq )
{
std::unique_ptr
xQueryBox(Application::CreateMessageDialog(pTabViewShell->GetFrameWeld(),
VclMessageType::Question, VclButtonsType::YesNo,
-
ScResId(STR_EDIT_EXISTING_COND_FORMATS)));
+
ScResId(STR_EDIT_EXISTING_COND_FORMATS), pTabViewShell));
xQueryBox->set_default_response(RET_YES);
bool bEditExisting = xQueryBox->run() == RET_YES;
if (bEditExisting)
core.git: Branch 'libreoffice-7-6' - sw/qa sw/source
sw/qa/core/text/data/tdf158505.odt |binary
sw/qa/core/text/text.cxx| 12
sw/source/core/text/EnhancedPDFExportHelper.cxx |5 -
sw/source/uibase/shells/textidx.cxx |6 ++
4 files changed, 22 insertions(+), 1 deletion(-)
New commits:
commit 924fb10b2a7a513b6626610e12ff3a5d21aa492a
Author: Vojtěch Doležal
AuthorDate: Sat Dec 9 11:03:05 2023 +0100
Commit: Adolfo Jayme Barrientos
CommitDate: Wed Dec 13 20:27:18 2023 +0100
tdf#158505 - Fix PDF export when bibliography is last paragraph
Change-Id: Iadafff97ba19d5c24be768238bddb4d684edde1c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160509
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
(cherry picked from commit 94d18ea557a03c1f2d450454908787f7d3af8a6e)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160647
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/sw/qa/core/text/data/tdf158505.odt
b/sw/qa/core/text/data/tdf158505.odt
new file mode 100644
index ..c9a71033a2de
Binary files /dev/null and b/sw/qa/core/text/data/tdf158505.odt differ
diff --git a/sw/qa/core/text/text.cxx b/sw/qa/core/text/text.cxx
index c68a0fa99cbe..0c90549e844e 100644
--- a/sw/qa/core/text/text.cxx
+++ b/sw/qa/core/text/text.cxx
@@ -103,6 +103,18 @@ CPPUNIT_TEST_FIXTURE(SwCoreTextTest,
testSemiTransparentText)
assertXPath(pXmlDoc, "//floattransparent");
}
+CPPUNIT_TEST_FIXTURE(SwCoreTextTest, testLastBibliographyPdfExport)
+{
+// Given a document with a bibliography as the last paragraph:
+createSwDoc("tdf158505.odt");
+
+// It should be possible to export to PDF:
+save("writer_pdf_Export");
+
+// Without the accompanying fix, the export to PDF would get stuck in an
infinite loop
+CPPUNIT_ASSERT(true);
+}
+
CPPUNIT_TEST_FIXTURE(SwCoreTextTest, testBibliographyUrlPdfExport)
{
// Given a document with a bibliography entry field:
diff --git a/sw/source/core/text/EnhancedPDFExportHelper.cxx
b/sw/source/core/text/EnhancedPDFExportHelper.cxx
index 17750dc4f038..e9a7363c37cf 100644
--- a/sw/source/core/text/EnhancedPDFExportHelper.cxx
+++ b/sw/source/core/text/EnhancedPDFExportHelper.cxx
@@ -2722,7 +2722,10 @@ void
SwEnhancedPDFExportHelper::ExportAuthorityEntryLinks()
}
}
}
-mrSh.MovePara(GoNextPara, fnParaStart);
+if (!mrSh.MovePara(GoNextPara, fnParaStart))
+{ // Cursor is stuck in the TOX due to document ending
immediately afterwards
+break;
+}
}
}
}
diff --git a/sw/source/uibase/shells/textidx.cxx
b/sw/source/uibase/shells/textidx.cxx
index 45d9df2c70b6..35642a73f198 100644
--- a/sw/source/uibase/shells/textidx.cxx
+++ b/sw/source/uibase/shells/textidx.cxx
@@ -127,6 +127,12 @@ void SwTextShell::ExecIdx(SfxRequest const )
rShell.GetCursor_()->GetPoint()->Assign(*pTableRowNode);
rShell.UpdateTableOf(*pCurrentTOX);
}
+else
+{
+// I think this ideally should be a pop-up warning,
right?
+SAL_WARN("sw", "No matching bibliography mark found. "
+"This feature is only guaranteed to
work if the bibliography table is up to date.");
+}
}
}
[Bug 158505] Crash exporting Writer file with bibliography to PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=158505 --- Comment #10 from Commit Notification --- Vojtěch Doležal committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/core/commit/924fb10b2a7a513b6626610e12ff3a5d21aa492a tdf#158505 - Fix PDF export when bibliography is last paragraph It will be available in 7.6.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158505] Crash exporting Writer file with bibliography to PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=158505 Commit Notification changed: What|Removed |Added Whiteboard|target:24.8.0 |target:24.8.0 target:7.6.5 -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'libreoffice-24-2' - package/source
package/source/zipapi/ZipFile.cxx | 81 +++---
1 file changed, 41 insertions(+), 40 deletions(-)
New commits:
commit 07d5a8b413c5bda33f3121d67f6ed13443b4f054
Author: Michael Stahl
AuthorDate: Tue Dec 12 21:07:46 2023 +0100
Commit: Michael Stahl
CommitDate: Wed Dec 13 20:20:55 2023 +0100
package: move function down
Change-Id: I92742a28cf60a9dfc80001f9ca3c5551fe94472d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160677
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 6e3a6ca0500f38f082dd699802fec367cb559200)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160690
diff --git a/package/source/zipapi/ZipFile.cxx
b/package/source/zipapi/ZipFile.cxx
index f700b2722a71..1b4b7ec2e8f8 100644
--- a/package/source/zipapi/ZipFile.cxx
+++ b/package/source/zipapi/ZipFile.cxx
@@ -394,46 +394,6 @@ bool ZipFile::StaticFillData ( ::rtl::Reference<
BaseEncryptionData > const & r
return bOk;
}
-uno::Reference< XInputStream > ZipFile::StaticGetDataFromRawStream( const
rtl::Reference< comphelper::RefCountedMutex >& aMutexHolder,
-const
uno::Reference< uno::XComponentContext >& rxContext,
-const
uno::Reference< XInputStream >& xStream,
-const
::rtl::Reference< EncryptionData > )
-{
-if ( !rData.is() )
-throw ZipIOException("Encrypted stream without encryption data!" );
-
-if ( !rData->m_aKey.hasElements() )
-throw packages::WrongPasswordException(THROW_WHERE );
-
-uno::Reference< XSeekable > xSeek( xStream, UNO_QUERY );
-if ( !xSeek.is() )
-throw ZipIOException("The stream must be seekable!" );
-
-// if we have a digest, then this file is an encrypted one and we should
-// check if we can decrypt it or not
-OSL_ENSURE( rData->m_aDigest.hasElements(), "Can't detect password
correctness without digest!" );
-if ( rData->m_aDigest.hasElements() )
-{
-sal_Int32 nSize = sal::static_int_cast< sal_Int32 >(
xSeek->getLength() );
-if ( nSize > n_ConstDigestLength + 32 )
-nSize = n_ConstDigestLength + 32;
-
-// skip header
-xSeek->seek( n_ConstHeaderSize + rData->m_aInitVector.getLength() +
-rData->m_aSalt.getLength() +
rData->m_aDigest.getLength() );
-
-// Only want to read enough to verify the digest
-Sequence < sal_Int8 > aReadBuffer ( nSize );
-
-xStream->readBytes( aReadBuffer, nSize );
-
-if ( !StaticHasValidPassword( rxContext, aReadBuffer, rData ) )
-throw packages::WrongPasswordException(THROW_WHERE );
-}
-
-return new XUnbufferedStream( aMutexHolder, xStream, rData );
-}
-
#if 0
// for debugging purposes
void CheckSequence( const uno::Sequence< sal_Int8 >& aSequence )
@@ -670,6 +630,47 @@ uno::Reference< XInputStream >
ZipFile::createStreamForZipEntry(
return xBufStream;
}
+uno::Reference< XInputStream > ZipFile::StaticGetDataFromRawStream(
+const rtl::Reference& rMutexHolder,
+const uno::Reference& rxContext,
+const uno::Reference& xStream,
+const ::rtl::Reference )
+{
+if (!rData.is())
+throw ZipIOException("Encrypted stream without encryption data!" );
+
+if (!rData->m_aKey.hasElements())
+throw packages::WrongPasswordException(THROW_WHERE);
+
+uno::Reference xSeek(xStream, UNO_QUERY);
+if (!xSeek.is())
+throw ZipIOException("The stream must be seekable!");
+
+// if we have a digest, then this file is an encrypted one and we should
+// check if we can decrypt it or not
+OSL_ENSURE(rData->m_aDigest.hasElements(), "Can't detect password
correctness without digest!");
+if (rData->m_aDigest.hasElements())
+{
+sal_Int32 nSize = sal::static_int_cast(xSeek->getLength());
+if (nSize > n_ConstDigestLength + 32)
+nSize = n_ConstDigestLength + 32;
+
+// skip header
+xSeek->seek(n_ConstHeaderSize + rData->m_aInitVector.getLength() +
+rData->m_aSalt.getLength() + rData->m_aDigest.getLength());
+
+// Only want to read enough to verify the digest
+Sequence aReadBuffer(nSize);
+
+xStream->readBytes(aReadBuffer, nSize);
+
+if (!StaticHasValidPassword(rxContext, aReadBuffer, rData))
+throw packages::WrongPasswordException(THROW_WHERE);
+}
+
+return new XUnbufferedStream(rMutexHolder, xStream, rData);
+}
+
ZipEnumeration ZipFile::entries()
{
return aEntries;
[Bug 158690] FILEOPEN RTF Frame lost from header
https://bugs.documentfoundation.org/show_bug.cgi?id=158690 Gabor Kelemen (allotropia) changed: What|Removed |Added Regression By||Michael Stahl Keywords||bibisected, bisected, ||regression CC||michael.st...@allotropia.de -- You are receiving this mail because: You are the assignee for the bug.
[Bug 81234] [META] RTF filter issues
https://bugs.documentfoundation.org/show_bug.cgi?id=81234 Gabor Kelemen (allotropia) changed: What|Removed |Added Depends on||158690 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158690 [Bug 158690] FILEOPEN RTF Frame lost from header -- You are receiving this mail because: You are the assignee for the bug.
[Bug 152865] FILEOPEN RTF Paragraph below frame wrapped differently than in Word
https://bugs.documentfoundation.org/show_bug.cgi?id=152865 Gabor Kelemen (allotropia) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||8690 -- You are receiving this mail because: You are the assignee for the bug.
