[Bug 147974] Writer has an issue with multiple .csv address book data source connections

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147974

--- Comment #10 from Buovjaga  ---
(In reply to David from comment #9)
> Created attachment 191579 [details]
> A writer document detailing how I set up and use the mail merge function.
> 
> I have recently updated the documents I use with the mail merge function. 
> Do you want new files?  How can I send multiple files to you?

You attach multiple files one by one.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158847] IMSIN, IMCOM, IMTAN, and SUMIFS functions are not searchable in certain regional help pages

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158847

--- Comment #1 from nobu  ---
The three of the four candidates that appeared when searching for Sumif were
completely unrelated links.
IMSIN
IMCOM
IMTAN

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158847] New: IMSIN, IMCOM, IMTAN, and SUMIFS functions are not searchable in certain regional help pages

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158847

Bug ID: 158847
   Summary: IMSIN, IMCOM, IMTAN, and SUMIFS functions are not
searchable in certain regional help pages
   Product: LibreOffice
   Version: 6.0.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tac...@hotmail.co.jp
CC: olivier.hal...@libreoffice.org

Description:
IMSIN, IMCOM, IMTAN, and SUMIFS functions are not searchable in certain
regional help pages.

Steps to Reproduce:
1. Open US-English Help Page.
  https://help.libreoffice.org/latest/en-US/text/scalc/main.html
2. Type "SUMIF" in the Index search on the left side of the page.
3. The following two search suggestions appear.
SUMIF function
SUMIFS function
4. Change the language to South Africa.  [ English(SA) ]
5. There are 4 "SUMIF" in the search suggestions and "SUMIF" does not appear.
6. Add "S" to Index search to find "SUMIFS".

Actual Results:
7. Search results are gone.

Expected Results:
7. "SUMIFS" should appear in the search results.


Reproducible: Always


User Profile Reset: No

Additional Info:
We have selected the "South African" language for clarity of explanation, but
the problem can also be observed in the following other languages.
Japanese, Korean, Macedonian, Omoro.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158846] New: Crash Report Upload Missing on LibreOffice

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158846

Bug ID: 158846
   Summary: Crash Report Upload Missing on LibreOffice
   Product: LibreOffice
   Version: 7.5.9.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ktop...@gmail.com

Description:
Random crashes when I switch apps to LibreOffice on Windows.
The crash upload that I seen on other versions is completely missing.
There is just the document recovery dialogue when I re-open LibreOffice.
7.5.9.2 is supposed to be stable.
How do you fix crashes without crash reports.

Steps to Reproduce:
Program randomly crashes when I switch to it from other apps on Windows 

Actual Results:
No crash report upload dialogue. There is only document recovery dialogue.

Expected Results:
Crash Report Upload facility to ask for crash report upload when program
restart  after a crash


Reproducible: Always


User Profile Reset: No

Additional Info:
On other versions, I have seen Crash Report Upload facility to ask for crash
report upload when I restart LibreOffice after a crash.
I mean does it auto upload crash report without asking ? or
How do you fix crashes without crash reports?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158545] UI: Original size button in image properties -> position and size tab doesn't restore original size for paper size exceeding images in Writer (and breaks image ratio)

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158545

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158615] Simplify storing of the "zero date" setting in Calc settings

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158615

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158545] UI: Original size button in image properties -> position and size tab doesn't restore original size for paper size exceeding images in Writer (and breaks image ratio)

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158545

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158365] Unremovable thin black line around embedded videos (x11, Mesa, gstreamer)

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158365

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158834] Border box

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158834

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158832] Templates

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158832

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158365] Unremovable thin black line around embedded videos (x11, Mesa, gstreamer)

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158365

--- Comment #7 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 142494] Word Count not 0 when no words are selected

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142494

--- Comment #4 from QA Administrators  ---
Dear Jamie Douglass,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 149284] LO Base freeze when using a form with macro to enter MySQL data

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149284

--- Comment #8 from QA Administrators  ---
Dear J-Paul,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158365] Unremovable thin black line around embedded videos (x11, Mesa, gstreamer)

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158365

--- Comment #6 from Ian Graham  ---
The video is not set to fill the screen, and screenshots are above.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158365] Unremovable thin black line around embedded videos (x11, Mesa, gstreamer)

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158365

--- Comment #4 from Ian Graham  ---
Created attachment 191580
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191580=edit
screenshot of video w/ x11 and Mesa i915

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158365] Unremovable thin black line around embedded videos (x11, Mesa, gstreamer)

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158365

--- Comment #5 from Ian Graham  ---
Created attachment 191581
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191581=edit
screenshot of video w/ wayland and Mesa i915

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: include/comphelper

2023-12-23 Thread Caolán McNamara (via logerrit)
 include/comphelper/interfacecontainer3.hxx |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit 28616cf0989dab2ca2a1710c64f6fb1c1d78c584
Author: Caolán McNamara 
AuthorDate: Sat Dec 23 20:43:27 2023 +
Commit: Caolán McNamara 
CommitDate: Sun Dec 24 00:50:18 2023 +0100

OInterfaceIteratorHelper3 always copies maData contents in ctor

while I think the idea is that the copy on write should only
be done by OInterfaceContainerHelper3, i.e. that ownership
really transfers to OInterfaceIteratorHelper3 and OInterfaceContainerHelper3
makes a new one if that turns out to be necessary

Change-Id: I6e97e3b303f133edbbb35ac23f39cf5348ad49fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161257
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/include/comphelper/interfacecontainer3.hxx 
b/include/comphelper/interfacecontainer3.hxx
index 4b3d44bab69d..02f96658dcd2 100644
--- a/include/comphelper/interfacecontainer3.hxx
+++ b/include/comphelper/interfacecontainer3.hxx
@@ -63,7 +63,8 @@ public:
 OInterfaceIteratorHelper3(OInterfaceContainerHelper3& rCont_)
 : rCont(rCont_)
 , maData(rCont.maData)
-, nRemain(maData->size())
+// const_cast so we don't trigger make_unique via 
o3tl::cow_wrapper::operator->
+, nRemain(std::as_const(maData)->size())
 {
 }
 
@@ -96,12 +97,12 @@ template 
 const css::uno::Reference& 
OInterfaceIteratorHelper3::next()
 {
 nRemain--;
-return (*maData)[nRemain];
+return (*std::as_const(maData))[nRemain];
 }
 
 template  void OInterfaceIteratorHelper3::remove()
 {
-rCont.removeInterface((*maData)[nRemain]);
+rCont.removeInterface((*std::as_const(maData))[nRemain]);
 }
 
 /**


core.git: external/zxcvbn-c

2023-12-23 Thread Thorsten Behrens (via logerrit)
 external/zxcvbn-c/ExternalProject_zxcvbn-c.mk |2 ++
 external/zxcvbn-c/StaticLibrary_zxcvbn-c.mk   |2 ++
 2 files changed, 4 insertions(+)

New commits:
commit cfd333f13f85eaf6eaf564e791b55a2092841376
Author: Thorsten Behrens 
AuthorDate: Sat Dec 23 22:37:26 2023 +0100
Commit: Thorsten Behrens 
CommitDate: Sun Dec 24 00:29:50 2023 +0100

zxcvbn-c: disable warnings

Change-Id: I348dc5f92f41fc3e8c1aee8743d5e1cf86fa3bbb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161259
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/external/zxcvbn-c/ExternalProject_zxcvbn-c.mk 
b/external/zxcvbn-c/ExternalProject_zxcvbn-c.mk
index 51b60a9c2ecb..bd652464ca15 100644
--- a/external/zxcvbn-c/ExternalProject_zxcvbn-c.mk
+++ b/external/zxcvbn-c/ExternalProject_zxcvbn-c.mk
@@ -9,6 +9,8 @@
 
 $(eval $(call gb_ExternalProject_ExternalProject,zxcvbn-c))
 
+$(eval $(call gb_Library_set_warnings_disabled,zxcvbn-c))
+
 $(eval $(call gb_ExternalProject_register_targets,zxcvbn-c,\
generate-dictionary-nodes \
 ))
diff --git a/external/zxcvbn-c/StaticLibrary_zxcvbn-c.mk 
b/external/zxcvbn-c/StaticLibrary_zxcvbn-c.mk
index 9748ef850c55..ac670ad6ed5b 100644
--- a/external/zxcvbn-c/StaticLibrary_zxcvbn-c.mk
+++ b/external/zxcvbn-c/StaticLibrary_zxcvbn-c.mk
@@ -11,6 +11,8 @@ $(eval $(call gb_StaticLibrary_StaticLibrary,zxcvbn-c))
 
 $(eval $(call gb_StaticLibrary_use_unpacked,zxcvbn-c,zxcvbn-c))
 
+$(eval $(call gb_StaticLibrary_set_warnings_disabled,zxcvbn-c))
+
 # zxcvbn-c static library depends on generation of dictionary nodes resulting 
in dict-src.h
 $(eval $(call gb_StaticLibrary_use_external_project,zxcvbn-c,zxcvbn-c,full))
 


core.git: xmlsecurity/source

2023-12-23 Thread Thorsten Behrens (via logerrit)
 xmlsecurity/source/xmlsec/nss/ciphercontext.cxx |   22 +++---
 1 file changed, 11 insertions(+), 11 deletions(-)

New commits:
commit 4a532e651b9fd4c9b24b017d2e1d099ee76ceed8
Author: Thorsten Behrens 
AuthorDate: Fri Dec 22 22:44:15 2023 +0100
Commit: Thorsten Behrens 
CommitDate: Sun Dec 24 00:29:34 2023 +0100

xmlsecurity: fix AES-GCM code differently

With PCH, the earlier workaround with NSS_PKCS11_2_0_COMPAT breaks -
so lets fix this with conditionals, its only two places.

Follow-up commit to 9276d5338ef04209b007bbc705e4c023cf181456

Change-Id: I7d3292304d83d784ee9dce5cdc62b4a028ff333a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161204
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/xmlsecurity/source/xmlsec/nss/ciphercontext.cxx 
b/xmlsecurity/source/xmlsec/nss/ciphercontext.cxx
index b053db901ccd..c3bbfdb0f2ef 100644
--- a/xmlsecurity/source/xmlsec/nss/ciphercontext.cxx
+++ b/xmlsecurity/source/xmlsec/nss/ciphercontext.cxx
@@ -24,12 +24,6 @@
 #include 
 #include 
 
-#if defined(__GNUC__)
-#pragma GCC diagnostic ignored "-Wunused-macros"
-#endif
-// see TODO below
-#define NSS_PKCS11_2_0_COMPAT 1
-
 #include "ciphercontext.hxx"
 #include  // for NSS_VMINOR
 #include 
@@ -63,12 +57,14 @@ uno::Reference< xml::crypto::XCipherContext > 
OCipherContext::Create( CK_MECHANI
 
 if (nNSSCipherID == CKM_AES_GCM)
 {
-// TODO: when runtime requirements are raised to NSS 3.52, replace this
-// according to https://fedoraproject.org/wiki/Changes/NssGCMParams
+// TODO: when runtime requirements are raised to NSS 3.52,
+// cleanup according to
+// https://fedoraproject.org/wiki/Changes/NssGCMParams
 #if NSS_VMINOR >= 52
-static_assert(sizeof(CK_GCM_PARAMS) == sizeof(CK_NSS_GCM_PARAMS));
+xResult->m_pSecParam = SECITEM_AllocItem(nullptr, nullptr, 
sizeof(CK_NSS_GCM_PARAMS));
+#else
+xResult->m_pSecParam = SECITEM_AllocItem(nullptr, nullptr, 
sizeof(CK_GCM_PARAMS));
 #endif
-xResult->m_pSecParam = SECITEM_AllocItem(nullptr, nullptr, 
sizeof(/*CK_NSS_GCM_PARAMS*/CK_GCM_PARAMS));
 if (!xResult->m_pSecParam)
 {
 SAL_WARN("xmlsecurity.nss", "SECITEM_AllocItem failed");
@@ -76,7 +72,11 @@ uno::Reference< xml::crypto::XCipherContext > 
OCipherContext::Create( CK_MECHANI
 }
 assert(aInitializationVector.getLength() == nAESGCMIVSize);
 xResult->m_AESGCMIV = aInitializationVector;
-auto *const pParams = 
reinterpret_cast(xResult->m_pSecParam->data);
+#if NSS_VMINOR >= 52
+auto *const pParams = 
reinterpret_cast(xResult->m_pSecParam->data);
+#else
+auto *const pParams = 
reinterpret_cast(xResult->m_pSecParam->data);
+#endif
 pParams->pIv = const_cast(reinterpret_cast(xResult->m_AESGCMIV.getConstArray()));
 pParams->ulIvLen = 
sal::static_int_cast(xResult->m_AESGCMIV.getLength());
 pParams->pAAD = nullptr;


core.git: bin/get-bugzilla-attachments-by-mimetype

2023-12-23 Thread Thorsten Behrens (via logerrit)
 bin/get-bugzilla-attachments-by-mimetype |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit dbe05a624ca53db83bedbc049791cc215ee6d46b
Author: Thorsten Behrens 
AuthorDate: Sun Dec 24 00:04:10 2023 +0100
Commit: Thorsten Behrens 
CommitDate: Sun Dec 24 00:20:21 2023 +0100

get-bz-attachments: switch to python3

Nothing left to do, just switch the interpreter.

Change-Id: I6a0ff0a019a66f6baf39794c853655f273676ea2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161261
Tested-by: Thorsten Behrens 
Reviewed-by: Thorsten Behrens 

diff --git a/bin/get-bugzilla-attachments-by-mimetype 
b/bin/get-bugzilla-attachments-by-mimetype
index 924a522ebff7..c9942189be58 100755
--- a/bin/get-bugzilla-attachments-by-mimetype
+++ b/bin/get-bugzilla-attachments-by-mimetype
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # -*- coding: utf-8 -*-
 #
 # This file is part of the LibreOffice project.


core.git: bin/get-bugzilla-attachments-by-mimetype

2023-12-23 Thread Thorsten Behrens (via logerrit)
 bin/get-bugzilla-attachments-by-mimetype |8 
 1 file changed, 8 insertions(+)

New commits:
commit 750f53a73fe6b817edc76329488d4b508d57c19b
Author: Thorsten Behrens 
AuthorDate: Tue Dec 19 19:54:55 2023 +0100
Commit: Thorsten Behrens 
CommitDate: Sun Dec 24 00:19:56 2023 +0100

get-bz-attachments: set speaking thread names for job queue

Change-Id: I38d637b8dd0f19330329565bf2e63c3c8463536c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161004
Tested-by: Thorsten Behrens 
Reviewed-by: Thorsten Behrens 

diff --git a/bin/get-bugzilla-attachments-by-mimetype 
b/bin/get-bugzilla-attachments-by-mimetype
index 9df55914360e..924a522ebff7 100755
--- a/bin/get-bugzilla-attachments-by-mimetype
+++ b/bin/get-bugzilla-attachments-by-mimetype
@@ -422,6 +422,14 @@ class manage_threads(threading.Thread):
 # Use job parameters to call our query
 # Then let the queue know we are done with this job
 (uri, mimetype, prefix, extension) = jobs.get(True, 6)
+try:
+# set thread name for easier debugging, if process
+# ctl package is available
+import prctl
+prctl.set_name(prefix[:3] + ': ' + mimetype[-10:])
+except ImportError:
+pass
+
 try:
 get_through_rss_query(uri, mimetype, prefix, extension)
 finally:


core.git: bin/get-bugzilla-attachments-by-mimetype

2023-12-23 Thread Thorsten Behrens (via logerrit)
 bin/get-bugzilla-attachments-by-mimetype |  278 +--
 1 file changed, 161 insertions(+), 117 deletions(-)

New commits:
commit 17f79d80484c5d5b492efd46e2e52481a17e0095
Author: Thorsten Behrens 
AuthorDate: Tue Dec 19 19:42:00 2023 +0100
Commit: Thorsten Behrens 
CommitDate: Sun Dec 24 00:19:27 2023 +0100

get-bz-attachments: some flake8 cleanup

- fix the most obvious stylistic problems
- add some brief doc strings
- remove one instance of dead code, left over from this change:
  commit bd2eee0bd4ae83ff453522b7cf09b69f1b8b5e1b
  Date:   Wed Jun 3 23:41:32 2015 +0200

get-bugzilla-attachments: avoid FDO-TDF duplicates...

Change-Id: I88672ae99bc42e9af09ea6033f87240463b2c038
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161003
Tested-by: Thorsten Behrens 
Reviewed-by: Thorsten Behrens 

diff --git a/bin/get-bugzilla-attachments-by-mimetype 
b/bin/get-bugzilla-attachments-by-mimetype
index c9a0d41cf5cc..9df55914360e 100755
--- a/bin/get-bugzilla-attachments-by-mimetype
+++ b/bin/get-bugzilla-attachments-by-mimetype
@@ -23,53 +23,61 @@
 # it is already downloaded by a previous run, and up-to-date.
 
 from __future__ import print_function
-import feedparser
+
 import base64
 import datetime
 import glob
+import os
+import os.path
 import re
-import os, os.path
 import stat
 import sys
 import threading
 try:
 import queue
-except:
+except Exception:
 import Queue as queue
 try:
 from urllib.request import urlopen
-except:
+except Exception:
 from urllib import urlopen
 try:
 import xmlrpc.client as xmlrpclib
-except:
+except Exception:
 import xmlrpclib
 from xml.dom import minidom
 from xml.sax.saxutils import escape
+
 from attachment_mimetypes import mimetypes
 
+import feedparser
+
+
 def urlopen_retry(url):
+"""Open url, retry 3 times."""
 maxretries = 3
 for i in range(maxretries + 1):
 try:
 return urlopen(url)
 except IOError as e:
-print("caught IOError: " + str(e))
+print('caught IOError: ' + str(e))
 if maxretries == i:
 raise
-print("retrying...")
+print('retrying...')
+
 
 def get_from_bug_url_via_xml(url, mimetype, prefix, suffix):
-id = url.rsplit('=', 2)[1]
-print("id is " + prefix + id + " " + suffix)
-print("parsing " + id)
-sock = urlopen_retry(url+"=xml")
+"""Parse bug xml, download attachments with matching suffix."""
+bugid = url.rsplit('=', 2)[1]
+print('id is ' + prefix + bugid + ' ' + suffix)
+print('parsing ' + bugid)
+sock = urlopen_retry(url+'=xml')
 dom = minidom.parse(sock)
 sock.close()
-attachmentid=0
+attachmentid = 0
 for attachment in dom.getElementsByTagName('attachment'):
 attachmentid += 1
-print(" mimetype is", end=' ')
+print(' mimetype is', end=' ')
 for node in attachment.childNodes:
 if node.nodeName == 'type':
 # check if attachment is deleted
@@ -87,53 +95,58 @@ def get_from_bug_url_via_xml(url, mimetype, prefix, suffix):
 print('deleted attachment, skipping')
 continue
 
-download = suffix + '/' +prefix + id + '-' + str(attachmentid) 
+ '.' + suffix
+download = (suffix + '/' + prefix + bugid + '-' +
+str(attachmentid) + '.' + suffix)
 if os.path.isfile(download):
-print("assuming " + download + " is up to date")
+print('assuming ' + download + ' is up to date')
 continue
 
 # prevent re-downloading FDO attachments from TDF
-if prefix == "tdf" and int(id) < 88776:
-fdodownload = download.replace("tdf", "fdo")
+if prefix == 'tdf' and int(bugid) < 88776:
+fdodownload = download.replace('tdf', 'fdo')
 if os.path.isfile(fdodownload):
-print("assuming FDO " + fdodownload + " is up to date")
+print('assuming FDO ' + fdodownload + ' is up to date')
 continue
 
 print('downloading as ' + download)
-tmpfile = download + ".tmp"
+tmpfile = download + '.tmp'
 f = open(tmpfile, 'wb')
 f.write(base64.b64decode(node.firstChild.nodeValue))
 f.close()
 os.rename(tmpfile, download)
 break
 
+
 def get_novell_bug_via_xml(url, mimetype, prefix, suffix):
-id = url.rsplit('=', 2)[1]
-print("id is " + prefix + id + " " + suffix)
-print("parsing " + id)
-sock = urlopen_retry(url+"=xml")
+"""Parse bug xml, download attachments with matching suffix."""
+bugid = url.rsplit('=', 2)[1]
+print('id is ' + prefix + bugid + ' ' + suffix)
+

[Bug 103157] [META] Full screen mode bugs and enhancements

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103157
Bug 103157 depends on bug 153690, which changed state.

Bug 153690 Summary: UI: Calc doesn't show dialogs in full screen mode and 
freezes
https://bugs.documentfoundation.org/show_bug.cgi?id=153690

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158844] copy-paste-undo problems with as-char anchored group

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158844

m.a.riosv  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||miguelangelrv@libreoffice.o
   ||rg
 Status|UNCONFIRMED |NEW

--- Comment #2 from m.a.riosv  ---
Reproducible
Version: 7.6.4.1 (X86_64) / LibreOffice Community
Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL threaded
and
Version: 24.2.0.0.beta1 (X86_64) / LibreOffice Community
Build ID: 5f390384195b7264c6e52add9e90a39790285249
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL threaded

Can it be in relation with tdf#148715?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 154929] [META] Accessibility Check sidebar deck, Automatic Accessibility Checking

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154929
Bug 154929 depends on bug 158114, which changed state.

Bug 158114 Summary: Make it easier to find (and deal with) broken linked images 
in Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=158114

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 112581] [META] Linked (non-embedded) external files bugs and enhancements

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112581
Bug 112581 depends on bug 158114, which changed state.

Bug 158114 Summary: Make it easier to find (and deal with) broken linked images 
in Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=158114

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 103030] [META] Navigator sidebar deck and floating window (also "Target in Document")

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103030
Bug 103030 depends on bug 158114, which changed state.

Bug 158114 Summary: Make it easier to find (and deal with) broken linked images 
in Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=158114

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 43784] Show infobar when document has broken linked files

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=43784
Bug 43784 depends on bug 158114, which changed state.

Bug 158114 Summary: Make it easier to find (and deal with) broken linked images 
in Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=158114

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 147974] Writer has an issue with multiple .csv address book data source connections

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147974

David  changed:

   What|Removed |Added

 CC||farfenoo...@outlook.com

--- Comment #9 from David  ---
Created attachment 191579
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191579=edit
A writer document detailing how I set up and use the mail merge function.

I have recently updated the documents I use with the mail merge function.  Do
you want new files?  How can I send multiple files to you?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 99648] [META] Improve Layer Handling

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=99648
Bug 99648 depends on bug 157255, which changed state.

Bug 157255 Summary: Identify the layer of the object in focus
https://bugs.documentfoundation.org/show_bug.cgi?id=157255

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 86066] [META] Bugs and improvements to the statusbar

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=86066
Bug 86066 depends on bug 157255, which changed state.

Bug 157255 Summary: Identify the layer of the object in focus
https://bugs.documentfoundation.org/show_bug.cgi?id=157255

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 157244] Black elliptic discs around images in imported PDF of browser-exported web page

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157244

--- Comment #6 from Jim Raykowski  ---
(In reply to Commit Notification from comment #5)
> Jim Raykowski committed a patch related to this issue.
> It has been pushed to "master":
> 
> https://git.libreoffice.org/core/commit/
> d6a94c51130f62b17b29060fab6befe576e8c078
> 
> tdf#157244 Enhancement to identify objects in a layer
> 
> It will be available in 24.8.0.
> 
> The patch should be included in the daily builds available at
> https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
> information about daily builds can be found at:
> https://wiki.documentfoundation.org/Testing_Daily_Builds
> 
> Affected users are encouraged to test the fix and report feedback.

Sorry for the noise, this patch is for tdf#157255

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158842] 2-finger swipping up/down inverses direction: scrolling vertical becomes horizontal when scrolling up beyond row 1

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158842

Telesto  changed:

   What|Removed |Added

Summary|2-finger swipping up/down   |2-finger swipping up/down
   |inverses direction: |inverses direction:
   |scrolling horizontal|scrolling vertical becomes
   |scrolling when hitting row  |horizontal when scrolling
   |1   |up beyond row 1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158845] function NUM.SETTIMANA (or NUM.WEEK in english) gives wrong results for a leap year

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158845

Regina Henschel  changed:

   What|Removed |Added

 Resolution|--- |NOTABUG
 CC||rb.hensc...@t-online.de
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Regina Henschel  ---
Please notice, that there exists several functions to calculate a week number:

ISOWEEKNUM

WEEKNUM

WEEKNUM_EXCEL2003

Notice, that functions WEEKNUM and WEEKNUM_EXCEL2003 have a second parameter
'Mode' to determine the start of a week and the calculation method.

If you do not need interoperability with older, foreign applications, you
should use IOSWEEKNUM which follows the 'ISO 1806' standard. 

You are likely looking for WEEKNUM_EXCEL2003 with MODE=1 (Week starts on
Sunday) or MODE=2 (Week starts on Monday).

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: include/oox svx/source

2023-12-23 Thread Caolán McNamara (via logerrit)
 include/oox/helper/refmap.hxx  |   12 ++--
 svx/source/form/formcontroller.cxx |7 +++
 2 files changed, 9 insertions(+), 10 deletions(-)

New commits:
commit 3c6942a8c64ab35cae7c14b3f64059da4d6ca19b
Author: Caolán McNamara 
AuthorDate: Sat Dec 23 18:55:09 2023 +
Commit: Caolán McNamara 
CommitDate: Sat Dec 23 20:54:05 2023 +0100

cid#1545525 COPY_INSTEAD_OF_MOVE

and

cid#1545519 COPY_INSTEAD_OF_MOVE
cid#1545516 COPY_INSTEAD_OF_MOVE
cid#1545501 COPY_INSTEAD_OF_MOVE

Change-Id: Icc6efaf8c8fe06c7acd629ef77eac6b228b98f4b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161255
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/include/oox/helper/refmap.hxx b/include/oox/helper/refmap.hxx
index db7cbffe2e02..4e5efe6c233c 100644
--- a/include/oox/helper/refmap.hxx
+++ b/include/oox/helper/refmap.hxx
@@ -48,17 +48,17 @@ public:
 public:
 /** Returns true, if the object associated to the passed key exists.
 Returns false, if the key exists but points to an empty reference. */
-boolhas( key_type nKey ) const
+boolhas(const key_type& rKey) const
 {
-const mapped_type* pxRef = getRef( nKey );
+const mapped_type* pxRef = getRef(rKey);
 return pxRef && pxRef->get();
 }
 
 /** Returns a reference to the object associated to the passed key, or an
 empty reference on error. */
-mapped_type get( key_type nKey ) const
+mapped_type get(const key_type& rKey) const
 {
-if( const mapped_type* pxRef = getRef( nKey ) ) 
return *pxRef;
+if( const mapped_type* pxRef = getRef(rKey) ) 
return *pxRef;
 return mapped_type();
 }
 
@@ -129,9 +129,9 @@ private:
 void operator()( const value_type& rValue ) { if( 
rValue.second.get() ) maFunctor( rValue.first, *rValue.second ); }
 };
 
-const mapped_type* getRef( key_type nKey ) const
+const mapped_type* getRef(const key_type& rKey) const
 {
-typename container_type::const_iterator aIt = this->find( nKey );
+typename container_type::const_iterator aIt = this->find(rKey);
 return (aIt == this->end()) ? nullptr : >second;
 }
 };
diff --git a/svx/source/form/formcontroller.cxx 
b/svx/source/form/formcontroller.cxx
index 4198c5c367ae..0fb1bd64c942 100644
--- a/svx/source/form/formcontroller.cxx
+++ b/svx/source/form/formcontroller.cxx
@@ -3081,10 +3081,9 @@ void 
FormController::setFilter(::std::vector& rFieldInfos)
 if (aRow.find(rFieldInfo.xText) != aRow.end())
 {
 OString aVal = 
m_pParser->getContext().getIntlKeywordAscii(IParseContext::InternationalKeyCode::And);
-OUString aCompText = aRow[rFieldInfo.xText] + " "  
+
-OStringToOUString(aVal, 
RTL_TEXTENCODING_ASCII_US) + " " +
-::comphelper::getString(rRefValue.Value);
-aRow[rFieldInfo.xText] = aCompText;
+aRow[rFieldInfo.xText] = aRow[rFieldInfo.xText] + 
" "  +
+
OStringToOUString(aVal, RTL_TEXTENCODING_ASCII_US) + " " +
+
::comphelper::getString(rRefValue.Value);
 }
 else
 {


[Bug 51510] FILESAVE: Exporting documents with embedded SVG (e.g. QR code) to doc or docx converts the image to low-resolution pixel graphics

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=51510

--- Comment #45 from Buovjaga  ---
(In reply to Roland Baudin from comment #44)
> So, I don't understand why the patch has been reverted. Could you explain?

If you click the commit hash in the revert commit notification, you can read
the reason:

Reason for revert: This can cause compatibility issues with OOXML when they are
saved like this because this is not the correct way how SVG should be saved to
the OOXML document - it needs to use the OOXML SVG extension so that the image
is still shown in old MSO versions. See more 
info in https://gerrit.libreoffice.org/c/core/+/157729.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158845] New: function NUM.SETTIMANA (or NUM.WEEK in english) gives wrong results for a leap year

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158845

Bug ID: 158845
   Summary: function NUM.SETTIMANA  (or NUM.WEEK in english) gives
wrong results for a leap year
   Product: LibreOffice
   Version: 7.6.2.1 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kalosand...@hotmail.it

Description:
function NUM.SETTIMANA  (or NUM.WEEK in english) in Libreoffice Calc gives 1
for the date of 30/12/2024 rather than 53 !
Then next year is a leap year!

Steps to Reproduce:
1.set A1 value to 30/12/2024
2.set B1 to formula =NUM.SETTIMANA(A1)
3.

Actual Results:
1

Expected Results:
53


Reproducible: Always


User Profile Reset: No

Additional Info:
The next year has 29 february.
The same function in other spreadsheets gives the correct answer that is 53

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 51510] FILESAVE: Exporting documents with embedded SVG (e.g. QR code) to doc or docx converts the image to low-resolution pixel graphics

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=51510

--- Comment #44 from Roland Baudin  ---
Hi again,

I've seen in comment #34 above that a simple patch has first been applied to
solve the issue and then immediately reverted.

I tried the patch (with some adaptation to make it compile) and indeed it fixed
the issue.

Here is the patch I applied:

--- a/oox/source/export/drawingml.cxx   2023-12-23 20:06:52.649102333 +0100
+++ b/oox/source/export/drawingml.cxx   2023-12-23 20:06:18.597399308 +0100
@@ -1456,6 +1456,10 @@
 sMediaType = u"image/png"_ustr;
 aExtension = u"png"_ustr;
 break;
+case GfxLinkType::NativeSvg:
+sMediaType = u"image/svg"_ustr;
+aExtension = u"svg"_ustr;
+break;
 case GfxLinkType::NativeTif:
 sMediaType = u"image/tiff"_ustr;
 aExtension = u"tif"_ustr;


So, I don't understand why the patch has been reverted. Could you explain?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 105844] FILESAVE: Very slow saving with password compared to 5.2.5

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105844

--- Comment #45 from Commit Notification 
 ---
Thorsten Behrens committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/401e9408d14dc2b9d07183a04c223831a59f71a3

tdf#105844 argon2: add vcxproj files for WinARM64 builds

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 157244] Black elliptic discs around images in imported PDF of browser-exported web page

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157244

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:24.8.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 157244] Black elliptic discs around images in imported PDF of browser-exported web page

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157244

--- Comment #5 from Commit Notification 
 ---
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d6a94c51130f62b17b29060fab6befe576e8c078

tdf#157244 Enhancement to identify objects in a layer

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: configure.ac external/argon2

2023-12-23 Thread Thorsten Behrens (via logerrit)
 configure.ac   |1 
 external/argon2/0002-Add-WinARM64-vcxproj-config.patch |  185 +
 external/argon2/UnpackedTarball_argon2.mk  |1 
 3 files changed, 187 insertions(+)

New commits:
commit 401e9408d14dc2b9d07183a04c223831a59f71a3
Author: Thorsten Behrens 
AuthorDate: Sat Dec 23 01:08:09 2023 +0100
Commit: Thorsten Behrens 
CommitDate: Sat Dec 23 20:10:57 2023 +0100

tdf#105844 argon2: add vcxproj files for WinARM64 builds

Also add argon2 to crossbuild tools side.

Change-Id: I8704b2d8362a051c2d634b9db7416cdc2cf9add4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161206
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 
Reviewed-by: Thorsten Behrens 

diff --git a/configure.ac b/configure.ac
index 788342733d1c..1c2a9c86cf5e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -5883,6 +5883,7 @@ if test "$cross_compiling" = "yes"; then
 
 # filter permitted build targets
 PERMITTED_BUILD_TARGETS="
+ARGON2
 AVMEDIA
 BOOST
 BZIP2
diff --git a/external/argon2/0002-Add-WinARM64-vcxproj-config.patch 
b/external/argon2/0002-Add-WinARM64-vcxproj-config.patch
new file mode 100644
index ..063296dd107c
--- /dev/null
+++ b/external/argon2/0002-Add-WinARM64-vcxproj-config.patch
@@ -0,0 +1,185 @@
+diff -ur argon2.org/vs2015/Argon2OptDll/Argon2OptDll.vcxproj 
argon2/vs2015/Argon2OptDll/Argon2OptDll.vcxproj
+--- argon2.org/vs2015/Argon2OptDll/Argon2OptDll.vcxproj2023-12-23 
01:00:49.231059537 +0100
 argon2/vs2015/Argon2OptDll/Argon2OptDll.vcxproj2023-12-23 
01:02:40.375527010 +0100
+@@ -13,6 +13,10 @@
+   ReleaseStatic
+   x64
+ 
++
++  Release
++  AMR64
++
+ 
+   Release
+   Win32
+@@ -50,6 +54,12 @@
+ true
+ MultiByte
+   
++  
++DynamicLibrary
++false
++true
++MultiByte
++  
+   
+ DynamicLibrary
+ false
+@@ -84,6 +94,9 @@
+   
+ 
+   
++  
++
++  
+   
+ 
+   
+@@ -107,6 +120,11 @@
+ $(SolutionDir)vs2015uild\$(ProjectName)\
+ $(SolutionDir)include;$(IncludePath)
+   
++  
++$(SolutionDir)vs2015uild\
++$(SolutionDir)vs2015uild\$(ProjectName)\
++$(SolutionDir)include;$(IncludePath)
++  
+   
+ $(SolutionDir)vs2015uild\
+ $(SolutionDir)vs2015uild\$(ProjectName)\
+@@ -158,6 +176,21 @@
+   true
+ 
+   
++  
++
++  Level3
++  MaxSpeed
++  true
++  false
++  true
++  
_CRT_SECURE_NO_WARNINGS;%(PreprocessorDefinitions)
++
++
++  true
++  true
++  true
++
++  
+   
+ 
+   Level3
+@@ -209,7 +242,6 @@
+ 
+ 
+ 
+-
+ 
+ 
+@@ -221,7 +253,7 @@
+ 
+ 
+-
++
+ 
+   
+   
+Only in argon2/vs2015/Argon2OptDll: Argon2OptDll.vcxproj~
+diff -ur argon2.org/vs2015/Argon2OptTestCI/Argon2OptTestCI.vcxproj 
argon2/vs2015/Argon2OptTestCI/Argon2OptTestCI.vcxproj
+--- argon2.org/vs2015/Argon2OptTestCI/Argon2OptTestCI.vcxproj  2023-12-23 
01:00:49.231059537 +0100
 argon2/vs2015/Argon2OptTestCI/Argon2OptTestCI.vcxproj  2023-12-23 
01:02:12.518576081 +0100
+@@ -17,6 +17,10 @@
+   Release
+   Win32
+ 
++
++  Release
++  ARM64
++
+ 
+   Debug
+   x64
+@@ -51,6 +55,12 @@
+ true
+ MultiByte
+   
++  
++Application
++false
++true
++MultiByte
++  
+   
+ Application
+ false
+@@ -85,6 +95,9 @@
+   
+ 
+   
++  
++
++  
+   
+ 
+   
+@@ -108,6 +121,11 @@
+ $(SolutionDir)vs2015uild\
+ $(SolutionDir)vs2015uild\$(ProjectName)\
+   
++  
++$(SolutionDir)include;$(IncludePath)
++$(SolutionDir)vs2015uild\
++$(SolutionDir)vs2015uild\$(ProjectName)\
++  
+   
+ $(SolutionDir)include;$(IncludePath)
+ $(SolutionDir)vs2015uild\
+@@ -162,6 +180,21 @@
+   true
+ 
+   
++  
++
++  Level3
++  MaxSpeed
++  true
++  false
++  true
++  
_CRT_SECURE_NO_WARNINGS;%(PreprocessorDefinitions)
++
++
++  true
++  true
++  true
++
++  
+   
+ 
+   Level3
+@@ -214,7 +247,7 @@
+ 
+ 
+-
++
+ 
+ 
+   
+@@ -222,7 +255,6 @@
+ 
+ 
+ 
+-
+ 
+ 
+@@ -232,4 +264,4 @@
+   
+   
+   
+-
+\ No newline at end of file
++
+Only in argon2/vs2015/Argon2OptTestCI: Argon2OptTestCI.vcxproj~
diff --git a/external/argon2/UnpackedTarball_argon2.mk 
b/external/argon2/UnpackedTarball_argon2.mk
index 0b35c2f58caf..3addfad639d5 100644
--- a/external/argon2/UnpackedTarball_argon2.mk
+++ b/external/argon2/UnpackedTarball_argon2.mk
@@ -15,6 +15,7 @@ $(eval $(call gb_UnpackedTarball_set_patchlevel,argon2,1))
 
 $(eval $(call gb_UnpackedTarball_add_patches,argon2,\

external/argon2/0001-Fix-possible-compiler-error-due-to-undefined-_MSC_VE.patch 
\
+   external/argon2/0002-Add-WinARM64-vcxproj-config.patch \
 ))
 
 # vim: set noet sw=4 ts=4:


core.git: sd/source

2023-12-23 Thread Jim Raykowski (via logerrit)
 sd/source/ui/dlg/LayerTabBar.cxx |   95 ++-
 sd/source/ui/inc/LayerTabBar.hxx |9 +++
 2 files changed, 103 insertions(+), 1 deletion(-)

New commits:
commit d6a94c51130f62b17b29060fab6befe576e8c078
Author: Jim Raykowski 
AuthorDate: Sun Nov 12 17:52:09 2023 -0900
Commit: Jim Raykowski 
CommitDate: Sat Dec 23 20:10:25 2023 +0100

tdf#157244 Enhancement to identify objects in a layer

Show an invert overlay on objects of a layer after a 1/2 second delay
when the mouse pointer is on a layer tab.

Change-Id: Ifcb2d82d73b8745ad9aecddd18b22193525ed756
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159358
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 

diff --git a/sd/source/ui/dlg/LayerTabBar.cxx b/sd/source/ui/dlg/LayerTabBar.cxx
index 96b96068f331..ece1e0884bcf 100644
--- a/sd/source/ui/dlg/LayerTabBar.cxx
+++ b/sd/source/ui/dlg/LayerTabBar.cxx
@@ -39,6 +39,12 @@
 #include 
 #include 
 
+#include 
+#include 
+#include 
+#include 
+#include 
+
 namespace sd {
 
 /**
@@ -47,12 +53,17 @@ namespace sd {
 LayerTabBar::LayerTabBar(DrawViewShell* pViewSh, vcl::Window* pParent)
 : TabBar( pParent, WinBits( WB_BORDER | WB_3DLOOK | WB_SCROLL ) ),
 DropTargetHelper( this ),
-pDrViewSh(pViewSh)
+pDrViewSh(pViewSh),
+m_aBringLayerObjectsToAttentionDelayTimer("LayerTabBar 
m_aBringLayerObjectsToAttentionDelayTimer")
 {
 EnableEditMode();
 SetSizePixel(Size(0, 0));
 SetMaxPageWidth( 150 );
 SetHelpId( HID_SD_TABBAR_LAYERS );
+
+m_aBringLayerObjectsToAttentionDelayTimer.SetInvokeHandler(
+LINK(this, LayerTabBar, 
BringLayerObjectsToAttentionDelayTimerHdl));
+m_aBringLayerObjectsToAttentionDelayTimer.SetTimeout(500);
 }
 
 LayerTabBar::~LayerTabBar()
@@ -137,6 +148,87 @@ void LayerTabBar::Select()
 pDispatcher->Execute(SID_SWITCHLAYER, SfxCallMode::SYNCHRON);
 }
 
+void LayerTabBar::MouseMove(const MouseEvent )
+{
+sal_uInt16 nPageId = 0;
+if (!rMEvt.IsLeaveWindow())
+nPageId = GetPageId(rMEvt.GetPosPixel());
+BringLayerObjectsToAttention(nPageId);
+return;
+}
+
+void LayerTabBar::BringLayerObjectsToAttention(const sal_uInt16 nPageId)
+{
+if (nPageId == m_nBringLayerObjectsToAttentionLastPageId)
+return;
+
+m_aBringLayerObjectsToAttentionDelayTimer.Stop();
+
+m_nBringLayerObjectsToAttentionLastPageId = nPageId;
+
+std::vector aRanges;
+
+if (nPageId != 0)
+{
+OUString aLayerName(GetLayerName(nPageId));
+if (pDrViewSh->GetView()->GetSdrPageView()->IsLayerVisible(aLayerName))
+{
+SdrLayerAdmin& rLayerAdmin = pDrViewSh->GetDoc()->GetLayerAdmin();
+SdrObjListIter aIter(pDrViewSh->GetActualPage(), 
SdrIterMode::DeepWithGroups);
+while (aIter.IsMore())
+{
+SdrObject* pObj = aIter.Next();
+assert(pObj != nullptr);
+if (pObj && (aLayerName == 
rLayerAdmin.GetLayerPerID(pObj->GetLayer())->GetName()))
+{
+::tools::Rectangle aRect(pObj->GetLogicRect());
+if (!aRect.IsEmpty())
+aRanges.emplace_back(aRect.Left(), aRect.Top(), 
aRect.Right(), aRect.Bottom());
+// skip over objects in groups
+if (pObj->IsGroupObject())
+{
+SdrObjListIter aSubListIter(pObj->GetSubList(), 
SdrIterMode::DeepWithGroups);
+while (aSubListIter.IsMore())
+{
+aIter.Next();
+aSubListIter.Next();
+}
+}
+}
+}
+}
+}
+
+if (m_xOverlayObject && m_xOverlayObject->getOverlayManager())
+m_xOverlayObject->getOverlayManager()->remove(*m_xOverlayObject);
+if (aRanges.empty())
+m_xOverlayObject.reset();
+else
+{
+m_xOverlayObject.reset(new sdr::overlay::OverlaySelection(
+   sdr::overlay::OverlayType::Invert,
+   Color(), std::move(aRanges), true/*unused 
for Invert type*/));
+m_aBringLayerObjectsToAttentionDelayTimer.Start();
+}
+}
+
+IMPL_LINK_NOARG(LayerTabBar, BringLayerObjectsToAttentionDelayTimerHdl, Timer 
*, void)
+{
+m_aBringLayerObjectsToAttentionDelayTimer.Stop();
+if (m_xOverlayObject)
+{
+if (SdrView* pView = pDrViewSh->GetDrawView())
+{
+if (SdrPaintWindow* pPaintWindow = pView->GetPaintWindow(0))
+{
+const rtl::Reference& 
xOverlayManager =
+pPaintWindow->GetOverlayManager();
+xOverlayManager->add(*m_xOverlayObject);
+}
+}
+}
+}
+
 void LayerTabBar::MouseButtonDown(const MouseEvent& rMEvt)
 {
 bool bSetPageID=false;
@@ -302,6 +394,7 @@ void  

[Bug 147974] Writer has an issue with multiple .csv address book data source connections

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147974

--- Comment #8 from Dieter  ---
Tested with

Version: 24.2.0.0.beta1 (X86_64) / LibreOffice Community
Build ID: 5f390384195b7264c6e52add9e90a39790285249
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL threaded

But I failed to test (perhaps I'm not familiar enough with mail merge)

My steps:
1. Download attachment 179145
2. Open attachment 179147 (envelope.odt) and attachment 179148 (member
letter.odt)
3. In document "member letter" Strg+P => Message "Your document contains
address database fields. Do you want to print a form letter?"
4. Yes => Message "The file file:///C:/Users/Downloads/memberlist.csv could not
be loaded. at
C:/cygwin64/home/buildslave/source/libo-core/connectivity/source/commontools/dbexception.cxx:403"
5. ?

David can you add the correct steps?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158844] copy-paste-undo problems with as-char anchored group

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158844

--- Comment #1 from Regina Henschel  ---
Created attachment 191578
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191578=edit
Error message and call stack of the crash

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: basctl/source drawinglayer/source framework/source lingucomponent/source sc/source sd/source sfx2/source slideshow/source svx/source sw/source toolkit/source vcl/inc vcl/jsdialog vcl/workben

2023-12-23 Thread Caolán McNamara (via logerrit)
 basctl/source/basicide/basides1.cxx|6 +-
 basctl/source/basicide/localizationmgr.cxx |3 -
 drawinglayer/source/primitive2d/mediaprimitive2d.cxx   |5 +-
 framework/source/uiconfiguration/uiconfigurationmanager.cxx|4 -
 framework/source/uielement/spinfieldtoolbarcontroller.cxx  |9 ++-
 lingucomponent/source/thesaurus/libnth/nthesimp.cxx|3 -
 sc/source/filter/xcl97/XclImpChangeTrack.cxx   |3 -
 sc/source/ui/docshell/docsh4.cxx   |7 +-
 sc/source/ui/drawfunc/drawsh.cxx   |   12 ++---
 sd/source/console/PresenterScrollBar.cxx   |4 -
 sd/source/ui/slidesorter/view/SlsInsertAnimator.cxx|2 
 sd/source/ui/view/drviews3.cxx |2 
 sfx2/source/appl/workwin.cxx   |3 -
 slideshow/source/engine/animationnodes/animationaudionode.cxx  |6 +-
 slideshow/source/engine/animationnodes/basenode.cxx|4 -
 slideshow/source/engine/animationnodes/sequentialtimecontainer.cxx |2 
 svx/source/sdr/primitive2d/sdrdecompositiontools.cxx   |3 -
 svx/source/svdraw/svdotextdecomposition.cxx|3 -
 sw/source/uibase/shells/tabsh.cxx  |   11 ++--
 toolkit/source/awt/vclxprinter.cxx |6 --
 vcl/inc/jsdialog/jsdialogbuilder.hxx   |4 -
 vcl/jsdialog/jsdialogbuilder.cxx   |4 -
 vcl/workben/vcldemo.cxx|   24 
+-
 writerfilter/source/dmapper/DomainMapper.cxx   |2 
 writerfilter/source/dmapper/DomainMapper.hxx   |2 
 writerfilter/source/dmapper/FontTable.cxx  |2 
 writerfilter/source/dmapper/FontTable.hxx  |2 
 writerfilter/source/dmapper/GraphicImport.cxx  |2 
 writerfilter/source/dmapper/GraphicImport.hxx  |2 
 writerfilter/source/dmapper/LoggedResources.hxx|2 
 writerfilter/source/dmapper/NumberingManager.cxx   |2 
 writerfilter/source/dmapper/NumberingManager.hxx   |2 
 writerfilter/source/dmapper/SettingsTable.cxx  |2 
 writerfilter/source/dmapper/SettingsTable.hxx  |2 
 writerfilter/source/dmapper/StyleSheetTable.cxx|2 
 writerfilter/source/dmapper/StyleSheetTable.hxx|2 
 xmloff/source/table/XMLTableImport.cxx |3 -
 37 files changed, 77 insertions(+), 82 deletions(-)

New commits:
commit 9a6298aedb663513c039efccc516dec3188dd8fa
Author: Caolán McNamara 
AuthorDate: Sat Dec 23 14:13:05 2023 +
Commit: Caolán McNamara 
CommitDate: Sat Dec 23 19:52:50 2023 +0100

cid#1546006 COPY_INSTEAD_OF_MOVE

and

cid#1545999 COPY_INSTEAD_OF_MOVE
cid#1545995 COPY_INSTEAD_OF_MOVE
cid#1545994 COPY_INSTEAD_OF_MOVE
cid#1545989 COPY_INSTEAD_OF_MOVE
cid#1545982 COPY_INSTEAD_OF_MOVE
cid#1545977 COPY_INSTEAD_OF_MOVE
cid#1545970 COPY_INSTEAD_OF_MOVE
cid#1545856 COPY_INSTEAD_OF_MOVE
cid#1545845 COPY_INSTEAD_OF_MOVE
cid#1545838 COPY_INSTEAD_OF_MOVE
cid#1545776 COPY_INSTEAD_OF_MOVE
cid#1545774 COPY_INSTEAD_OF_MOVE
cid#1545744 COPY_INSTEAD_OF_MOVE
cid#1545719 COPY_INSTEAD_OF_MOVE
cid#1545716 COPY_INSTEAD_OF_MOVE
cid#1545687 COPY_INSTEAD_OF_MOVE
cid#1545648 COPY_INSTEAD_OF_MOVE
cid#1545643 COPY_INSTEAD_OF_MOVE
cid#1545641 COPY_INSTEAD_OF_MOVE
cid#1545604 COPY_INSTEAD_OF_MOVE
cid#1545531 COPY_INSTEAD_OF_MOVE
cid#1545530 COPY_INSTEAD_OF_MOVE
cid#1545524 COPY_INSTEAD_OF_MOVE
cid#1545516 COPY_INSTEAD_OF_MOVE
cid#1545501 COPY_INSTEAD_OF_MOVE
cid#1545486 COPY_INSTEAD_OF_MOVE

Change-Id: Idcf3e27bb9e81b6a77d5ef75c9376eb1d6aff8c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161245
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/basctl/source/basicide/basides1.cxx 
b/basctl/source/basicide/basides1.cxx
index 806ce96a88a2..4f2918dcc6d9 100644
--- a/basctl/source/basicide/basides1.cxx
+++ b/basctl/source/basicide/basides1.cxx
@@ -791,11 +791,11 @@ void Shell::ExecuteGlobal( SfxRequest& rReq )
 
 case SID_BASICIDE_MANAGE_LANG:
 {
-auto pRequest = std::make_shared(rReq);
+auto xRequest = std::make_shared(rReq);
 rReq.Ignore(); // the 'old' request is not relevant any more
 auto xDlg = std::make_shared(pCurWin ? 
pCurWin->GetFrameWeld() : nullptr, m_pCurLocalizationMgr);
-weld::DialogController::runAsync(xDlg, 

[Bug 158796] CRASH: pasting and undoing a WPC

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158796

Regina Henschel  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||8844

--- Comment #3 from Regina Henschel  ---
Bug 158451 is fixed, but the problems here remain :(

But there are problems with undo and as-char anchored groups, see but 158844.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158844] copy-paste-undo problems with as-char anchored group

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158844

Regina Henschel  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||8796

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 147828] "Select to Next Sentence" does not work properly when the current sentence ends with a period and the next sentence does not have a capital letter at the beginning of the first word

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147828

Dieter  changed:

   What|Removed |Added

 CC||michael.st...@allotropia.de

--- Comment #13 from Dieter  ---
(In reply to V Stuart Foote from comment #11)
> Michael S. did the last substantive rework of the view shell and cursor mgmt
> here.

Michael, so any comment from your side?

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: comphelper/source

2023-12-23 Thread Caolán McNamara (via logerrit)
 comphelper/source/misc/configuration.cxx |4 
 1 file changed, 4 insertions(+)

New commits:
commit f82b8bf05a76ad9cc3fe950f4180c90bce56d79b
Author: Caolán McNamara 
AuthorDate: Sat Dec 23 15:58:51 2023 +
Commit: Caolán McNamara 
CommitDate: Sat Dec 23 19:48:34 2023 +0100

ofz#65295 Abrt

Change-Id: I074a43191c4af304a2702012d0b810aad801d0d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161249
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/comphelper/source/misc/configuration.cxx 
b/comphelper/source/misc/configuration.cxx
index 6e500f619232..1ef359c7a9b6 100644
--- a/comphelper/source/misc/configuration.cxx
+++ b/comphelper/source/misc/configuration.cxx
@@ -183,6 +183,9 @@ css::uno::Any 
comphelper::detail::ConfigurationWrapper::getPropertyValue(OUStrin
 std::scoped_lock aGuard(maMutex);
 if (mbDisposed)
 throw css::lang::DisposedException();
+#if defined(FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION)
+return css::uno::Any();
+#else
 // Cache the configuration access, since some of the keys are used in hot 
code.
 auto it = maPropertyCache.find(path);
 if( it != maPropertyCache.end())
@@ -198,6 +201,7 @@ css::uno::Any 
comphelper::detail::ConfigurationWrapper::getPropertyValue(OUStrin
 css::uno::Any property = access->getByName(childName);
 maPropertyCache.emplace(path, property);
 return property;
+#endif
 }
 
 void comphelper::detail::ConfigurationWrapper::setPropertyValue(


[Bug 158844] New: copy-paste-undo problems with as-char anchored group

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158844

Bug ID: 158844
   Summary: copy-paste-undo problems with as-char anchored group
   Product: LibreOffice
   Version: 7.6.4.1 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de

Created attachment 191577
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191577=edit
Document to reproduce the crash

Open attached document. It has a group anchored as-char. The group contains a
rectangle without fill and stroke and a green rectangle with text.

Copy the group. Go to last paragraph and paste the clipboard. Undo.

Error: The text is still visible.

Go to the end of the first paragraph. Add a blank. Wait a little bit.

Crash.

I see the problems in
Version: 7.6.4.1 (X86_64) / LibreOffice Community
Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1
CPU threads: 32; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win
Locale: de-DE (de_DE); UI: en-US
Calc: threaded

The problems are still there with a build containing the fix for bug 158451.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 147872] Lists in sidebar won't scroll fully when LO is tiled; can't access entries at bottom

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147872

Dieter  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #7 from Dieter  ---
R. Green, is the problem still present in an actual version of LO?
=> NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 103270] [META] Image/Picture dialog bugs and enhancements

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103270

Dieter  changed:

   What|Removed |Added

 Depends on||158545


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=158545
[Bug 158545] UI: Original size button in image properties -> position and size
tab doesn't restore original size for paper size exceeding images in Writer
(and breaks image ratio)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158545] UI: Original size button in image properties -> position and size tab doesn't restore original size for paper size exceeding images in Writer (and breaks image ratio)

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158545

Dieter  changed:

   What|Removed |Added

 Blocks||103270
 CC||dgp-m...@gmx.de,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval

--- Comment #1 from Dieter  ---
I cinfirmed the described behaviour with

Version: 24.2.0.0.beta1 (X86_64) / LibreOffice Community
Build ID: 5f390384195b7264c6e52add9e90a39790285249
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL threaded

Additional observation:
Values in Scale are wrong after pressing "origional size" button, because they
are not in line with Image size and the result.

would call it enhancemnt (of the dialog) request
Adding design-team for further ideas


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103270
[Bug 103270] [META] Image/Picture dialog bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158545] UI: Original size button in image properties -> position and size tab doesn't restore original size for paper size exceeding images in Writer (and breaks image ratio)

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158545

Dieter  changed:

   What|Removed |Added

 Blocks||103270
 CC||dgp-m...@gmx.de,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval

--- Comment #1 from Dieter  ---
I cinfirmed the described behaviour with

Version: 24.2.0.0.beta1 (X86_64) / LibreOffice Community
Build ID: 5f390384195b7264c6e52add9e90a39790285249
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL threaded

Additional observation:
Values in Scale are wrong after pressing "origional size" button, because they
are not in line with Image size and the result.

would call it enhancemnt (of the dialog) request
Adding design-team for further ideas


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103270
[Bug 103270] [META] Image/Picture dialog bugs and enhancements
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158807] FILESAVE: PPT: transparency converted to black

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158807

--- Comment #4 from Commit Notification 
 ---
Patrick Luby committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3e582d9e3fbed8cb94284ac1ab6105cf74eccfe0

Related: tdf#158807 mutex must be locked when disposing a VirtualDevice

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158807] FILESAVE: PPT: transparency converted to black

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158807

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:24.8.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: drawinglayer/source

2023-12-23 Thread Patrick Luby (via logerrit)
 drawinglayer/source/primitive2d/graphicprimitivehelper2d.cxx |   18 +++
 1 file changed, 18 insertions(+)

New commits:
commit 3e582d9e3fbed8cb94284ac1ab6105cf74eccfe0
Author: Patrick Luby 
AuthorDate: Sat Dec 23 09:35:06 2023 -0500
Commit: Patrick Luby 
CommitDate: Sat Dec 23 19:32:24 2023 +0100

Related: tdf#158807 mutex must be locked when disposing a VirtualDevice

If the following .ppt document is opened in a debug build
and the document is left open for a minute or two without
changing any content, this destructor will be called on a
non-main thread with the mutex unlocked:

  https://bugs.documentfoundation.org/attachment.cgi?id=46801

This hits an assert in VirtualDevice::ReleaseGraphics() so
explicitly lock the mutex and explicitly dispose and clear
the VirtualDevice instances variables.

Change-Id: I5d371a4e99fca4aae2b6edc8b53eca10cb143aef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161243
Tested-by: Jenkins
Reviewed-by: Patrick Luby 

diff --git a/drawinglayer/source/primitive2d/graphicprimitivehelper2d.cxx 
b/drawinglayer/source/primitive2d/graphicprimitivehelper2d.cxx
index 7562459e0b70..cdda7d660e7e 100644
--- a/drawinglayer/source/primitive2d/graphicprimitivehelper2d.cxx
+++ b/drawinglayer/source/primitive2d/graphicprimitivehelper2d.cxx
@@ -358,6 +358,7 @@ namespace drawinglayer::primitive2d
 AnimatedGraphicPrimitive2D(
 const Graphic& rGraphic,
 basegfx::B2DHomMatrix aTransform);
+virtual ~AnimatedGraphicPrimitive2D();
 
 /// data read access
 const basegfx::B2DHomMatrix& getTransform() const { return 
maTransform; }
@@ -421,6 +422,23 @@ namespace drawinglayer::primitive2d
 }
 }
 
+AnimatedGraphicPrimitive2D::~AnimatedGraphicPrimitive2D()
+{
+// Related: tdf#158807 mutex must be locked when disposing a 
VirtualDevice
+// If the following .ppt document is opened in a debug build
+// and the document is left open for a minute or two without
+// changing any content, this destructor will be called on a
+// non-main thread with the mutex unlocked:
+//   https://bugs.documentfoundation.org/attachment.cgi?id=46801
+// This hits an assert in VirtualDevice::ReleaseGraphics() so
+// explicitly lock the mutex and explicitly dispose and clear
+// the VirtualDevice instances variables.
+const SolarMutexGuard aSolarGuard;
+
+maVirtualDevice.disposeAndClear();
+maVirtualDeviceMask.disposeAndClear();
+}
+
 bool AnimatedGraphicPrimitive2D::operator==(const BasePrimitive2D& 
rPrimitive) const
 {
 // do not use 'GroupPrimitive2D::operator==' here, that would 
compare


[Bug 158423] CppunitTest_unoxml_domtest failing with libxml-2.12

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158423

--- Comment #3 from Buovjaga  ---
Ah, now Jan gave more info in the patch (which I merged):

Yes, the header clean-ups broke too many projects (see
https://github.com/NixOS/nixpkgs/pull/269060#issuecomment-1837213807 for a
partial list of projects needing similar patches), so 2.12.3 reintroduced the
cyclic reference between headers.

The patch is therefore not strictly necessary any more. But it is probably
still a good idea to include proper header for each symbol rather than relying
on transitive includes.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158843] merging the po files of a translation would reduce the total size of mo files and the MSI archive size

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158843

Jérôme  changed:

   What|Removed |Added

 Blocks||97991


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=97991
[Bug 97991] Reducing the size of the Windows Installer
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 97991] Reducing the size of the Windows Installer

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=97991

Jérôme  changed:

   What|Removed |Added

 Depends on||158843


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=158843
[Bug 158843] merging the po files of a translation would reduce the total size
of mo files and the MSI archive size
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158843] New: merging the po files of a translation would reduce the total size of mo files and the MSI archive size

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158843

Bug ID: 158843
   Summary: merging the po files of a translation would reduce the
total size of mo files and the MSI archive size
   Product: LibreOffice
   Version: 24.8.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Localization
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jerome.bo...@laposte.net

For example, in french translation, there are 33 ".mo" files in the main MSI
archive.

If we could merge those mo files, we could possibly avoid duplicate
translation.

In addition, a single mo file for this translation would be better compressed
into the MSI main archive (one compression per file).

This would require you to manually merge the po files or to use an automatic
tool (msgmerge or msgcat?) to generate a single temporary po file.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158842] New: 2-finger swipping up/down inverses direction: scrolling horizontal scrolling when hitting row 1

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158842

Bug ID: 158842
   Summary: 2-finger swipping up/down inverses direction:
scrolling horizontal scrolling when hitting row 1
   Product: LibreOffice
   Version: 24.8.0.0 alpha0+ Master
  Hardware: All
OS: macOS (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
2-finger swipping up/down inverses direction: scrolling horizontal scrolling
when hitting row 1

Same happens swiping left/right. Hitting row will convert scroll to vertical

Steps to Reproduce:
1. Open calc
2. Swipe little down and forcefully up.. scrolls horizontal. From column A to
AE in no time
3. Try to scroll back to column A horizontally with some force.. I'm at row 300
in no time

Actual Results:
Scroll doesn't stop at row 1 or column A, but inverses direction

Expected Results:
Stops at A1


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 90b12c9bad55e8f50b75a6d7b68caa27d82cc2b9
CPU threads: 8; OS: macOS 13.4.1; UI render: Skia/Raster; VCL: osx
Locale: nl-NL (nl_NL.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

libvisio.git: src/test

2023-12-23 Thread Libreoffice Gerrit user
 src/test/importtest.cpp |1 +
 1 file changed, 1 insertion(+)

New commits:
commit e7d32634cfeceea700f24af3176090f4501d534e
Author: Jan Tojnar 
AuthorDate: Sun Dec 10 15:42:24 2023 +0100
Commit: Ilmari Lauhakangas 
CommitDate: Sat Dec 23 17:43:39 2023 +0100

tests: Fix build with libxml 2.12

libxml 2.12.0 reorganized the headers, which removed `xmlParseMemory` 
function from the scope.

Change-Id: Ibd747fe7f83eb7c3a8b8cf57ac4a06e365986d46
Reviewed-on: https://gerrit.libreoffice.org/c/libvisio/+/160542
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 

diff --git a/src/test/importtest.cpp b/src/test/importtest.cpp
index 9a01473..4a26b4a 100644
--- a/src/test/importtest.cpp
+++ b/src/test/importtest.cpp
@@ -14,6 +14,7 @@
 
 #include 
 
+#include 
 #include 
 
 #include "xmldrawinggenerator.h"


[Bug 158841] Numbering of the chapters is wrong

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158841

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #1 from m.a.riosv  ---
Please attach sample files.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: vcl/source

2023-12-23 Thread Samuel Mehrbrodt (via logerrit)
 vcl/source/window/dlgctrl.cxx |   11 ---
 1 file changed, 8 insertions(+), 3 deletions(-)

New commits:
commit ea1421747985bd09ad40565da8536e857b5c2e9a
Author: Samuel Mehrbrodt 
AuthorDate: Fri Dec 22 09:25:53 2023 +0100
Commit: Samuel Mehrbrodt 
CommitDate: Sat Dec 23 17:37:02 2023 +0100

tdf#157649 Allow omitting Alt key when focus is in dialog action area

Adapt to usual Windows experience: Allow triggering the Ok, Cancel, etc
buttons in the dialog action area without pressing the Alt key - when
the focus is in that area (and the accelerator is unique in that dialog).

Change-Id: I85b544867cf5507a15240b2972a26a1c248c4f82
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161146
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt 

diff --git a/vcl/source/window/dlgctrl.cxx b/vcl/source/window/dlgctrl.cxx
index adf416b21769..90cdf353f8c0 100644
--- a/vcl/source/window/dlgctrl.cxx
+++ b/vcl/source/window/dlgctrl.cxx
@@ -941,7 +941,7 @@ bool Window::ImplDlgCtrl( const KeyEvent& rKEvt, bool 
bKeyInput )
 }
 }
 }
-else if (aKeyCode.IsMod2()) // tdf#151385
+else
 {
 sal_Unicode c = rKEvt.GetCharCode();
 if ( c )
@@ -952,8 +952,13 @@ bool Window::ImplDlgCtrl( const KeyEvent& rKEvt, bool 
bKeyInput )
 GetFocusFlags nGetFocusFlags = GetFocusFlags::Mnemonic;
 if ( pSWindow == ::ImplFindAccelWindow( this, i, c, 
nFormStart, nFormEnd ) )
 nGetFocusFlags |= GetFocusFlags::UniqueMnemonic;
-pSWindow->ImplControlFocus( nGetFocusFlags );
-return true;
+// tdf#157649 Allow omitting the Alt key when focus is in 
the dialog action area:
+bool bIsButtonBox = 
dynamic_cast(pSWindow->GetParent()) != nullptr;
+if ((bIsButtonBox && 
pSWindow->GetParent()->HasChildPathFocus(true)) || aKeyCode.IsMod2())
+{
+pSWindow->ImplControlFocus( nGetFocusFlags );
+return true;
+}
 }
 }
 }


[Bug 158841] New: Numbering of the chapters is wrong

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158841

Bug ID: 158841
   Summary: Numbering of the chapters is wrong
   Product: LibreOffice
   Version: 7.6.4.1 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: fran...@atlas.cz

Description:
The numbering of the chapters in the table of contents, where it is correct,
and in the text, where it is incorrect, do not match. The document is generated
from the master document (.odm).

For example after export to pdf:
https://drive.google.com/file/d/1a5h55aKlWwXgDj695CsvWch6qNcTrOkw/view?usp=sharing

Thank You
Frantisek vil9m

Steps to Reproduce:
1. Open .odm
2. Export to pdf

Actual Results:
For example after export to pdf:
https://drive.google.com/file/d/1a5h55aKlWwXgDj695CsvWch6qNcTrOkw/view?

Expected Results:
I expect correct chapter numbering.


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.6.4.1 (X86_64) / LibreOffice Community
Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: cs-CZ (cs_CZ); UI: cs-CZ
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158779] duplicate opens___.ttf file in main MSI archive and deb packages

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158779

--- Comment #3 from Jérôme  ---
Could we use a symbolic link file ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158778] duplicate libcrypto-3.dll file in main MSI archive

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158778

--- Comment #4 from Jérôme  ---
Symbolic links exist in Windows also with relative path :
https://learn.microsoft.com/en-gb/windows/win32/fileio/creating-symbolic-links

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158840] New: In libreoffice writer, i want to insert cross reference of a numbered paragraph with out the before and after fields

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158840

Bug ID: 158840
   Summary: In libreoffice writer, i want to insert cross
reference of a numbered paragraph with out the before
and after fields
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: malnaa...@gmail.com

Description:
In LibreOffice writer, i want to insert the number in a numbered paragraph as a
cross reference without the before and after fields, this is necessary for
research papers where the numbered paragraph has square brackets [ and ] around
the number but not in their cross reference. 

Steps to Reproduce:
1. Make a numbered paragraph with [ and ] before and after the number
2. Insert the number as cross refrence.
3. the [ and ] appear in the cross reference

Actual Results:
the [ and ] appear in the cross reference

Expected Results:
I don't want them to appear


Reproducible: Always


User Profile Reset: No

Additional Info:
necessary for research papers

-- 
You are receiving this mail because:
You are the assignee for the bug.

dev-tools.git: help3/xhpeditor

2023-12-23 Thread Olivier Hallot (via logerrit)
 help3/xhpeditor/links.txt.xsl |   71 +++---
 1 file changed, 46 insertions(+), 25 deletions(-)

New commits:
commit cec75a82cb8b42c2c41734e286b7ee7ccb4cff57
Author: Olivier Hallot 
AuthorDate: Sat Dec 23 12:31:39 2023 -0300
Commit: Olivier Hallot 
CommitDate: Sat Dec 23 16:54:21 2023 +0100

Update icon replacement table from recent builds

Change-Id: I0ee978a36947eca46d1ddf8434554883098e15fc
Reviewed-on: https://gerrit.libreoffice.org/c/dev-tools/+/161247
Tested-by: Olivier Hallot 
Reviewed-by: Olivier Hallot 

diff --git a/help3/xhpeditor/links.txt.xsl b/help3/xhpeditor/links.txt.xsl
index 434b5bb8..d3aed42a 100644
--- a/help3/xhpeditor/links.txt.xsl
+++ b/help3/xhpeditor/links.txt.xsl
@@ -94,12 +94,7 @@
 cmd/32/insertframe.svg
 cmd/32/timefield.svg
 cmd/32/newdoc.svg
-cmd/32/outlinebullet.svg
-cmd/32/numberformatstandard.svg
-cmd/32/paragraphdialog.svg
-cmd/32/insertdraw.svg
-cmd/32/trackchanges.svg
-cmd/32/showtrackedchanges.svg
+cmd/32/insertpagenumberfield.svg
 cmd/lc_fontdialog.svg
 cmd/lc_addfield.svg
 cmd/lc_avmediaplayer.svg
@@ -138,12 +133,7 @@
 cmd/lc_insertframe.svg
 cmd/lc_timefield.svg
 cmd/lc_newdoc.svg
-cmd/lc_outlinebullet.svg
-cmd/lc_numberformatstandard.svg
-cmd/lc_paragraphdialog.svg
-cmd/lc_insertdraw.svg
-cmd/lc_trackchanges.svg
-cmd/lc_showtrackedchanges.svg
+cmd/lc_insertpagenumberfield.svg
 cmd/sc_fontdialog.svg
 cmd/sc_addfield.svg
 cmd/sc_avmediaplayer.svg
@@ -182,12 +172,7 @@
 cmd/sc_insertframe.svg
 cmd/sc_timefield.svg
 cmd/sc_newdoc.svg
-cmd/sc_outlinebullet.svg
-cmd/sc_numberformatstandard.svg
-cmd/sc_paragraphdialog.svg
-cmd/sc_insertdraw.svg
-cmd/sc_trackchanges.svg
-cmd/sc_showtrackedchanges.svg
+cmd/sc_insertpagenumberfield.svg
 cmd/32/trackchanges.svg
 cmd/sc_trackchanges.svg
 cmd/lc_trackchanges.svg
@@ -348,6 +333,8 @@
 cmd/32/ar/defaultnumbering.svg
 cmd/32/ar/deleterecord.svg
 cmd/32/ar/insertneutralparagraph.svg
+cmd/32/ar/jumpdownthislevel.svg
+cmd/32/ar/jumpupthislevel.svg
 cmd/32/ar/linenumberingdialog.svg
 cmd/32/ar/linenumberingdialog.svg
 cmd/32/ar/newrecord.svg
@@ -381,6 +368,8 @@
 cmd/32/ar/defaultnumbering.svg
 cmd/32/ar/deleterecord.svg
 cmd/32/ar/insertneutralparagraph.svg
+cmd/32/ar/jumpdownthislevel.svg
+cmd/32/ar/jumpupthislevel.svg
 cmd/32/ar/linenumberingdialog.svg
 cmd/32/ar/linenumberingdialog.svg
 cmd/32/ar/newrecord.svg
@@ -468,6 +457,8 @@
 cmd/32/ar/defaultnumbering.svg
 cmd/32/ar/deleterecord.svg
 cmd/32/ar/insertneutralparagraph.svg
+cmd/32/ar/jumpdownthislevel.svg
+cmd/32/ar/jumpupthislevel.svg
 cmd/32/ar/linenumberingdialog.svg
 cmd/32/ar/linenumberingdialog.svg
 cmd/32/ar/newrecord.svg
@@ -515,6 +506,8 @@
 cmd/ar/lc_defaultnumbering.svg
 cmd/ar/lc_deleterecord.svg
 cmd/ar/lc_insertneutralparagraph.svg
+cmd/ar/lc_jumpdownthislevel.svg
+cmd/ar/lc_jumpupthislevel.svg
 cmd/ar/lc_linenumberingdialog.svg
 cmd/ar/sc_linenumberingdialog.svg
 cmd/ar/lc_newrecord.svg
@@ -540,6 +533,8 @@
 cmd/ar/sc_defaultnumbering.svg
 cmd/ar/sc_deleterecord.svg
 cmd/ar/sc_insertneutralparagraph.svg
+cmd/ar/sc_jumpdownthislevel.svg
+cmd/ar/sc_jumpupthislevel.svg
 cmd/ar/sc_linenumberingdialog.svg
 cmd/ar/sc_linenumberingdialog.svg
 cmd/ar/sc_newrecord.svg
@@ -581,6 +576,8 @@
 cmd/ar/lc_defaultnumbering.svg
 cmd/ar/lc_deleterecord.svg
 cmd/ar/lc_insertneutralparagraph.svg
+cmd/ar/lc_jumpdownthislevel.svg
+cmd/ar/lc_jumpupthislevel.svg
 cmd/ar/lc_linenumberingdialog.svg
 cmd/ar/lc_linenumberingdialog.svg
 cmd/ar/lc_newrecord.svg
@@ -606,6 +603,8 @@
 cmd/ar/sc_defaultnumbering.svg
 cmd/ar/sc_deleterecord.svg
 cmd/ar/sc_insertneutralparagraph.svg
+cmd/ar/sc_jumpdownthislevel.svg
+cmd/ar/sc_jumpupthislevel.svg
 cmd/ar/sc_linenumberingdialog.svg
 cmd/ar/sc_linenumberingdialog.svg
 cmd/ar/sc_newrecord.svg
@@ -755,6 +754,8 @@
 cmd/ar/lc_defaultnumbering.svg
 cmd/ar/lc_deleterecord.svg
 cmd/ar/lc_insertneutralparagraph.svg
+cmd/ar/lc_jumpdownthislevel.svg
+cmd/ar/lc_jumpupthislevel.svg
 cmd/ar/lc_linenumberingdialog.svg
 cmd/ar/lc_linenumberingdialog.svg
 cmd/ar/lc_newrecord.svg
@@ -780,6 +781,8 @@
 cmd/ar/sc_defaultnumbering.svg
 cmd/ar/sc_deleterecord.svg
 cmd/ar/sc_insertneutralparagraph.svg
+cmd/ar/lc_jumpdownthislevel.svg
+cmd/ar/lc_jumpupthislevel.svg
 cmd/ar/sc_linenumberingdialog.svg
 cmd/ar/sc_linenumberingdialog.svg
 cmd/ar/sc_newrecord.svg
@@ -1180,19 +1183,19 @@
 cmd/lc_open.svg
 cmd/sc_open.svg
 cmd/32/ellipse.svg
-cmd/32/basicshapes.diamond.svg
+cmd/32/graphic.svg
 cmd/32/rect.svg
 cmd/32/ellipse.svg
 cmd/32/freeline_unfilled.svg
 cmd/32/rect.svg
 cmd/lc_ellipse.svg
-cmd/lc_basicshapes.diamond.svg
+cmd/lc_graphic.svg
 cmd/lc_rect.svg
 cmd/lc_ellipse.svg
 cmd/lc_freeline_unfilled.svg
 cmd/lc_rect.svg
 cmd/sc_ellipse.svg
-cmd/sc_basicshapes.diamond.svg
+cmd/sc_graphic.svg
 cmd/sc_rect.svg
 cmd/sc_ellipse.svg
 cmd/sc_freeline_unfilled.svg
@@ -1930,6 +1933,7 @@
 cmd/sc_showsinglepage.svg
 cmd/lc_diaeffect.svg
 cmd/sc_colorsettings.svg
+cmd/lc_insertmath.svg
 cmd/lc_dbviewfunctions.svg
 

dev-tools.git: help3/xhpeditor

2023-12-23 Thread Olivier Hallot (via logerrit)
 help3/xhpeditor/DisplayArea.css |   65 ++--
 1 file changed, 36 insertions(+), 29 deletions(-)

New commits:
commit 13f010b2187a779473655bf563fa121b7f6ad68d
Author: Olivier Hallot 
AuthorDate: Sat Dec 23 12:29:30 2023 -0300
Commit: Olivier Hallot 
CommitDate: Sat Dec 23 16:54:03 2023 +0100

Help editor: Housekeeping on CSS

Bring some classes and settings from recent CSS in help/default.css

Change-Id: I9287c1570e4e76c9eb5bc19f248d6db3a7cb6a45
Reviewed-on: https://gerrit.libreoffice.org/c/dev-tools/+/161246
Tested-by: Olivier Hallot 
Reviewed-by: Olivier Hallot 

diff --git a/help3/xhpeditor/DisplayArea.css b/help3/xhpeditor/DisplayArea.css
index 6b4df043..c6351c0f 100644
--- a/help3/xhpeditor/DisplayArea.css
+++ b/help3/xhpeditor/DisplayArea.css
@@ -9,6 +9,14 @@
 
 
 /* Imported from default css for DisplayArea */
+
+:root {
+  --font_mono: Menlo, "Cascadia Mono", "Cascadia Code", Consolas, "DejaVu Sans 
Mono", monospace;
+  --font_body: Ubuntu, Cantarell, "Segoe UI Variable", "Segoe UI", "Noto 
Sans", "DejaVu Sans", "Lucida Grande", sans-serif, FreeSerif, NanumGothic, 
"Noto Sans Tibetan", Taprom;
+  --background-color: #f7f8f7;
+  --module-color: #18A303;
+}
+
 #DisplayArea {
 background-color: white;
 overflow: auto;
@@ -26,14 +34,14 @@
 .listitemintable,
 .paragraph,
 .tablecontent {
-font-family: -apple-system, system-ui, "Segoe UI", Roboto, Ubuntu, 
Cantarell, "Noto Sans", "DejaVu Sans", "Lucida Grande", "Helvetica Neue", 
Helvetica, Arial, sans-serif, FreeSerif, NanumGothic, "Noto Sans Tibetan", 
Taprom;
+font-family: var(--font_body);
 }
 .input {
 background-color: rgba(0,0,0,0.04);
 transition-property: background-color;
 transition-duration: 150ms;
 border-bottom: 1px dashed rgba(0,0,0,0.1);
-font-family: Menlo, Consolas, "DejaVu Sans Mono", "Nimbus Mono L", "Lucida 
Sans Typewriter", "Courier New", Courier, Monaco, monospace;
+font-family: var(--font_mono);
 }
 
 #DisplayArea  ::selection {
@@ -60,12 +68,16 @@
 border-radius: 2px;
 display: inline;
 padding: 1px 3px;
-font-family: Menlo, Consolas, "DejaVu Sans Mono", "Nimbus Mono L", "Lucida 
Sans Typewriter", "Courier New", Courier, Monaco, monospace;
+font-family: var(--font_mono);
+word-wrap: anywhere;
+}
+.literal {
+white-space: normal;
 }
 .smathcode {
 border-radius: 2px;
 padding: 1px 3px;
-font-family: Menlo, Consolas, "DejaVu Sans Mono", "Nimbus Mono L", "Lucida 
Sans Typewriter", "Courier New", Courier, Monaco, monospace;
+font-family: var(--font_mono);
 }
 
 .acronym {
@@ -82,7 +94,7 @@
 }
 .keycode {
 /*font-weight: bold;*/
-font-family: Menlo, Consolas, "DejaVu Sans Mono", "Nimbus Mono L", "Lucida 
Sans Typewriter", "Courier New", Courier, Monaco, monospace;
+font-family: var(--font_mono);
 }
 .widget{
 padding: 1px 10px;
@@ -100,33 +112,27 @@
 .warning {
 display:flex;
 align-items: center;
-border-radius: 0 4px 4px 0;
-box-shadow: 0 2px 2px -2px rgba(0,0,0,0.2);
+border-radius: 2px;
+box-shadow: 0 2px 5px -3px rgb(0 0 0 / 10%);
 padding: 0.2em;
 margin-top: 15px;
 }
 .note {
-border-left: 4px solid #FFDE09;
-background-color: #FFF4D0;
+border-left: 2px solid #309048;
+background-color: #d9f1dd;
 }
 .tip {
-border-left: 4px solid #38618C;
-background-color: #DAE2EA;
+border-left: 2px solid #0063b1;
+background-color: #cde5f7;
 }
 .warning {
-border-left: 4px solid #FF5964;
-background-color: #FFE0E2;
-}
-.noteicon {
-padding:0.3em;
-transition: transform .2s; /* Animation */
-}
-.noteicon:hover {
-transform: scale(2.0); /* (200% zoom - Note: if the zoom is too large, it 
will go outside of the viewport) */
+border-left: 2px solid #ed8733;
+background-color: #f6f1d2;
 }
-.notetext {
+.noteicon, .notetext {
 padding:0.3em;
 }
+
 #DisplayArea h1,
 #DisplayArea h2,
 #DisplayArea h3,
@@ -207,19 +213,13 @@
 border-bottom: 1px solid #E8E8E8;
 }
 /* Special case of icon table*/
-icontable {
+.icontable {
 display:flex;
 align-items:center;
 }
 .iconcell {
 padding:0.3em;
 }
-.imageicon {
-transition: transform .2s; /* Animation */
-}
-.imageicon:hover{
-transform: scale(2.0); /* (200% zoom - Note: if the zoom is too large, it 
will go outside of the viewport) */
-}
 
 #DisplayArea table {
 box-shadow: rgba(0,0,0,0.1) 0px 1px 3px 0px;
@@ -235,16 +235,23 @@ icontable {
 border-right: 0;
 padding: 0.3em;
 }
+
 .tablehead,
 .tableheadintable {
 font-weight: bold;
 margin-top: 0px;
 }
+
 .tableheadcell {
-background: #148603;
+background: var(--module-color);
 color: white;
 vertical-align:top;
 }
+
+.table_font_small {
+font-size: 0.98rem;
+}
+
 #DisplayArea footer {
 border-top: 2px solid #148603;
 padding: 15px 10px 0 10px;


[Bug 157724] GPG key cannot be selected in (macOS appstore MAS version)

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157724

--- Comment #3 from steve  ---
The MacGPG version you checked was probably installed separately. LO comes with
gpgme, and an outdated version of that.

@Sebastian: Could you try the standalone download and if key selection works as
expected in version 7.6.4?
https://www.libreoffice.org/download/download-libreoffice/

-- 
You are receiving this mail because:
You are the assignee for the bug.

dev-tools.git: help3/xhpeditor

2023-12-23 Thread Juan José González (via logerrit)
 help3/xhpeditor/index.php   |   42 --
 help3/xhpeditor/logo.png|binary
 help3/xhpeditor/views/empty_preview.php |   11 +++
 help3/xhpeditor/xhp2html.js |2 
 help3/xhpeditor/xhpeditor.css   |   93 +++-
 5 files changed, 117 insertions(+), 31 deletions(-)

New commits:
commit 0a2990a97b20220cd8c2f7dc2ba227488fc65349
Author: Juan José González 
AuthorDate: Fri Dec 22 07:17:30 2023 -0700
Commit: Olivier Hallot 
CommitDate: Sat Dec 23 16:41:28 2023 +0100

Add header, menu bar and toolbar takes the whole width of the window

empty preview message.

A couple of screenshots


https://s3.us-west-1.amazonaws.com/juanjosegzl.com/images/xhpeditorempty+message.png

https://s3.us-west-1.amazonaws.com/juanjosegzl.com/images/xhpeditorrender.png

Change-Id: If0790ac728cf4f5ea8725a4c691d75b6a36fc607
Reviewed-on: https://gerrit.libreoffice.org/c/dev-tools/+/161208
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/help3/xhpeditor/index.php b/help3/xhpeditor/index.php
index 710f8adb..1af632e5 100644
--- a/help3/xhpeditor/index.php
+++ b/help3/xhpeditor/index.php
@@ -9,7 +9,11 @@
 xpath("//filename");
+}
 ?>
 
 
@@ -52,32 +56,38 @@ $xhp = $_POST["xhpdoc"];
 
 
 
-
-LibreOffice Documentation XHP Editor
-
-
-
+  
+
+  
+  LibreOffice Documentation XHP Editor
+  
+  
+  
+
+
+
+  
 
 
 
 
 
 xpath("//filename");
 if (isset($_POST["render_page"])) {
-echo 'Rendered page: 
'.$xhp_filename[0];
-echo 'System: ';
+echo '';
+echo 'System: ';
 $opSys = array("MAC", "WIN", "UNIX");
 foreach ($opSys as $value) {
-   echo ''.$value.'';
+   echo ''.$value.'';
}
-echo ' Module: ';
+echo 'Module: ';
 $appModule = array("WRITER", "CALC", "IMPRESS", "DRAW", "BASE", 
"MATH", "CHART");
 foreach ($appModule as $value){
-echo ''.$value.'';
+echo ''.$value.'';
 }
-echo '';
+echo '';
 $xml = new DOMDocument();
 $xml->loadXML($xhp);
 $xsl = new DOMDocument;
@@ -87,7 +97,7 @@ $xhp = $_POST["xhpdoc"];
 $proc->setParameter("","productname",$CONFIG["productname"]);
 $proc->setParameter("","iconpath",$CONFIG["icon_path"]);
 $proc->importStyleSheet($xsl);
-echo $proc->transformToXml($xml);
+echo @$proc->transformToXml($xml);
 echo "";
 }elseif (isset($_POST["check_xhp"])) {
 libxml_use_internal_errors(true);
@@ -153,7 +163,7 @@ $xhp = $_POST["xhpdoc"];
 echo "";
 } else {
 echo '';
-echo 'Viewing Area';
+  include 'views/empty_preview.php';
 echo "";
 };
 ?>
diff --git a/help3/xhpeditor/logo.png b/help3/xhpeditor/logo.png
new file mode 100644
index ..ad22bf16
Binary files /dev/null and b/help3/xhpeditor/logo.png differ
diff --git a/help3/xhpeditor/views/empty_preview.php 
b/help3/xhpeditor/views/empty_preview.php
new file mode 100644
index ..6bb4afbf
--- /dev/null
+++ b/help3/xhpeditor/views/empty_preview.php
@@ -0,0 +1,11 @@
+
+  
+
+  Create or open a file
+
+
+  Start working on a new 
file. Or
+  Open an existing 
file.
+
+  
+
diff --git a/help3/xhpeditor/xhp2html.js b/help3/xhpeditor/xhp2html.js
index 930b451b..4ce2886f 100644
--- a/help3/xhpeditor/xhp2html.js
+++ b/help3/xhpeditor/xhp2html.js
@@ -37,7 +37,7 @@ var editor = 
CodeMirror.fromTextArea(document.getElementById("xhpeditor"), {
 hintOptions: {schemaInfo: this.xhptags}
 });
 
-const height = window.innerHeight - 
document.getElementById('editorpageheader').offsetHeight - 16;
+const height = window.innerHeight - 
document.getElementById('editorpageheader').offsetHeight;
 editor.setSize(null, height);
 
 function readSingleFile(e) {
diff --git a/help3/xhpeditor/xhpeditor.css b/help3/xhpeditor/xhpeditor.css
index 7d9bdce4..c4b91e49 100644
--- a/help3/xhpeditor/xhpeditor.css
+++ b/help3/xhpeditor/xhpeditor.css
@@ -1,4 +1,4 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/* -*- Mode: css; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
 /*
  * This file is part of the LibreOffice project.
  *
@@ -19,6 +19,25 @@ ol, ul {
 
 /* css for the main editor  web page */
 
+*, ::after, ::before {
+box-sizing: border-box;
+}
+
+#editorpageheader img {
+height: 50px;
+}
+
+#editorpageheader h1 {
+font-size: 1em;
+}
+
+#editorpageheader header {
+display: flex;
+align-items: center;
+justify-content: space-between;
+padding: 0 1em;
+}
+
 .form_area{
 border:1px solid grey;
 height: 

[Bug 158839] [META] OpenPGP bugs and enhancements

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158839

steve  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158839] [META] OpenPGP bugs and enhancements

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158839

steve  changed:

   What|Removed |Added

  Alias||OpenPGP

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 152524] macOS: LibreOffice crashes (gpgme / gpgmeio)

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152524

steve  changed:

   What|Removed |Added

   Priority|medium  |high

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 152524] macOS: LibreOffice crashes (gpgme / gpgmeio)

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152524

--- Comment #18 from steve  ---
Created attachment 191576
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191576=edit
Screenshot 2023-12-23 LO main build, crash after launch

Upping priority to high. Those crashes keep happening with latest main build
resulting in slow startups (beachball showing for ~30 seconds until macOS crash
report pops up) making LO frustrating and inefficient to use.

We are now at gpgme 1.23.2:
https://git.gnupg.org/cgi-bin/gitweb.cgi?p=gpgme.git
Still wondering if updating gpgme would be worth a try.

I am beginning to think that the crash here has the same cause as
https://bugs.documentfoundation.org/show_bug.cgi?id=156352 which also is
reproducible and crashes since save as dialog was fixed on macOS back in July
2023.

It seems any OpenPGP operation or interaction with gpgme crashes LO. Was there
some testing on macOS for this? If so, which version combination (gpgme, LO,
macOS) is known to be functional.

To give an idea of what using LibreOffice currently looks like, I attached a
screenshot.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 152524] macOS: LibreOffice crashes (gpgme / gpgmeio)

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152524

steve  changed:

   What|Removed |Added

 Blocks||158839


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=158839
[Bug 158839] [META] OpenPGP bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158839] [META] OpenPGP bugs and enhancements

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158839

steve  changed:

   What|Removed |Added

 Depends on||152524


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=152524
[Bug 152524] macOS: LibreOffice crashes (gpgme / gpgmeio)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 156352] macOS: Save as > Encrypt with GPG key results in hang / crash

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156352

steve  changed:

   What|Removed |Added

 Blocks||158839


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=158839
[Bug 158839] [META] OpenPGP bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158839] [META] OpenPGP bugs and enhancements

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158839

steve  changed:

   What|Removed |Added

 Depends on||156352


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=156352
[Bug 156352] macOS: Save as > Encrypt with GPG key results in hang / crash
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158839] [META] OpenPGP bugs and enhancements

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158839

steve  changed:

   What|Removed |Added

 Depends on||155125
 CC||l...@disr.it


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=155125
[Bug 155125] "Encrypt with GPG key" option missing when using System File
Dialog on macOS
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158839] [META] OpenPGP bugs and enhancements

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158839

steve  changed:

   What|Removed |Added

 Depends on||157724


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157724
[Bug 157724] GPG key cannot be selected in (macOS appstore MAS version)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 157724] GPG key cannot be selected in (macOS appstore MAS version)

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157724

steve  changed:

   What|Removed |Added

 Blocks||158839


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=158839
[Bug 158839] [META] OpenPGP bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158839] New: [META] OpenPGP bugs and enhancements

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158839

Bug ID: 158839
   Summary: [META] OpenPGP bugs and enhancements
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: l...@disr.it

Description:
Meta bug for known issues and open feature requests around OpenPGP usage in
LibreOffice.

Steps to Reproduce:
meta bug

Actual Results:
meta bug

Expected Results:
still a meta bug


Reproducible: Always


User Profile Reset: No

Additional Info:
meta bug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158838] UNO action to toggle applied styles like and

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158838

--- Comment #2 from j.a.sw...@gmail.com ---
The approach of using "remove applied character style," if not ideal, seems
like at least something. But "remove applied character style" has no effect on
 and . (When I made a word emphatic or strong and then
clicked the "A" icon, nothing happened.)

And as I said, even if this approach would work it would be less than ideal.
For italic I can toggle with Ctrl-I and Ctrl+!. For  I'd need
something like, say, Ctrl-I, Ctrl-R. Uninuitive.

Let's see what the UX people say.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158838] UNO action to toggle applied styles like and

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158838

--- Comment #2 from j.a.sw...@gmail.com ---
The approach of using "remove applied character style," if not ideal, seems
like at least something. But "remove applied character style" has no effect on
 and . (When I made a word emphatic or strong and then
clicked the "A" icon, nothing happened.)

And as I said, even if this approach would work it would be less than ideal.
For italic I can toggle with Ctrl-I and Ctrl+!. For  I'd need
something like, say, Ctrl-I, Ctrl-R. Uninuitive.

Let's see what the UX people say.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Jan Tojnar (license statement)

2023-12-23 Thread jtojnar

All of my past & future contributions to LibreOffice may be
licensed under the MPLv2/LGPLv3+ dual license.




core.git: svx/source sw/source

2023-12-23 Thread Caolán McNamara (via logerrit)
 svx/source/form/datanavi.cxx|2 +-
 sw/source/uibase/shells/grfshex.cxx |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 25d4fae8d3f69dc4d03c1a04233e6ed670742ed5
Author: Caolán McNamara 
AuthorDate: Sat Dec 23 14:00:26 2023 +
Commit: Caolán McNamara 
CommitDate: Sat Dec 23 16:03:30 2023 +0100

cid#1546064 COPY_INSTEAD_OF_MOVE

and

cid#1546034 COPY_INSTEAD_OF_MOVE

Change-Id: If533400b570f20d80f1c41431ceba81579e0e25d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161242
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/svx/source/form/datanavi.cxx b/svx/source/form/datanavi.cxx
index 0178a82c5947..9116c0eb075f 100644
--- a/svx/source/form/datanavi.cxx
+++ b/svx/source/form/datanavi.cxx
@@ -306,7 +306,7 @@ namespace svxform
 
 // tdf#154535 create the OXFormsDescriptor on-demand so we don't cause 
an unwanted
 // Binding to be created unless we are forced to.
-auto fnCreateFormsDescriptor = [this, szName, xNode, xPropSet](){
+auto fnCreateFormsDescriptor = [this, szName=std::move(szName), 
xNode=std::move(xNode), xPropSet=std::move(xPropSet)](){
 OXFormsDescriptor desc;
 desc.szName = szName;
 if (xNode) {
diff --git a/sw/source/uibase/shells/grfshex.cxx 
b/sw/source/uibase/shells/grfshex.cxx
index 45d40764525b..a9af8799b009 100644
--- a/sw/source/uibase/shells/grfshex.cxx
+++ b/sw/source/uibase/shells/grfshex.cxx
@@ -80,7 +80,7 @@ bool SwTextShell::InsertMediaDlg( SfxRequest const & rReq )
 css::uno::Reference 
xDispatchProvider(GetView().GetViewFrame().GetFrame().GetFrameInterface(), 
css::uno::UNO_QUERY);
 
 rtl::Reference xPlayerListener(new 
avmedia::PlayerListener(
-[xDispatchProvider, aURL, bLink](const 
css::uno::Reference& rPlayer){
+[xDispatchProvider=std::move(xDispatchProvider), aURL, 
bLink](const css::uno::Reference& rPlayer){
 css::awt::Size aSize = 
rPlayer->getPreferredPlayerWindowSize();
 
avmedia::MediaWindow::dispatchInsertAVMedia(xDispatchProvider, aSize, aURL, 
bLink);
 }));


core.git: svl/source

2023-12-23 Thread Caolán McNamara (via logerrit)
 svl/source/items/itemset.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b803b3a7a1eda1b9862112f399c0a8b988c1f930
Author: Caolán McNamara 
AuthorDate: Sat Dec 23 13:52:09 2023 +
Commit: Caolán McNamara 
CommitDate: Sat Dec 23 15:51:39 2023 +0100

cid#1559884 Uninitialized scalar variable

etc, since:

commit e9e3576ada06d53de12efed041fb309fe5388e01
Date:   Thu Dec 21 22:49:27 2023 +0100

svl: fix build with --enable-debug

Change-Id: I1c3c82f0f1674cb46fa6a36d5f9f5cc4435ebef1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161241
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/svl/source/items/itemset.cxx b/svl/source/items/itemset.cxx
index 4a1c6351c7f3..4cadfa6b596e 100644
--- a/svl/source/items/itemset.cxx
+++ b/svl/source/items/itemset.cxx
@@ -61,7 +61,7 @@ static bool g_bItemClassicMode(getenv("ITEM_CLASSIC_MODE"));
 SfxPoolItemHolder::SfxPoolItemHolder()
 : m_pPool(nullptr)
 , m_pItem(nullptr)
-#ifdef DBG_UTIL
+#ifndef NDEBUG
 , m_bDeleted(false)
 #endif
 {


core.git: svx/source

2023-12-23 Thread Armin Le Grand (allotropia) (via logerrit)
 svx/source/sdr/primitive2d/sdrcustomshapeprimitive2d.cxx |2 --
 1 file changed, 2 deletions(-)

New commits:
commit 1582bde861ad8e556fcf06657e7228980ff284e9
Author: Armin Le Grand (allotropia) 
AuthorDate: Fri Dec 22 17:20:21 2023 +0100
Commit: Armin Le Grand 
CommitDate: Sat Dec 23 15:49:08 2023 +0100

Add flush mechanism to buffered Primitives III

There seem to be problems with re-creation of
SdrCustomShapePrimitive2D primitive presentation
due to SdrText not being held as
uno::Reference everywhere. For now,
try if excluding SdrCustomShapePrimitive2D from
being flushed helps - may give hints already...

Change-Id: I58373f7dcd81dd24fbf7a0687bb782326ad290fd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161190
Tested-by: Jenkins
Reviewed-by: Armin Le Grand 

diff --git a/svx/source/sdr/primitive2d/sdrcustomshapeprimitive2d.cxx 
b/svx/source/sdr/primitive2d/sdrcustomshapeprimitive2d.cxx
index b58274106211..19717e2eb121 100644
--- a/svx/source/sdr/primitive2d/sdrcustomshapeprimitive2d.cxx
+++ b/svx/source/sdr/primitive2d/sdrcustomshapeprimitive2d.cxx
@@ -102,8 +102,6 @@ namespace drawinglayer::primitive2d
 mb3DShape(b3DShape),
 maTransform(std::move(aTransform))
 {
-// activate callback to flush buffered decomposition content
-setCallbackSeconds(10);
 }
 
 bool SdrCustomShapePrimitive2D::operator==(const BasePrimitive2D& 
rPrimitive) const


[Bug 158838] UNO action to toggle applied styles like and

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158838

V Stuart Foote  changed:

   What|Removed |Added

 Blocks||86899
Summary|Let shortcut keys toggle|UNO action to toggle
   |for styles like   |applied styles like
   |and | and 


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=86899
[Bug 86899] [META] Requests for the addition of UNO commands
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 86899] [META] Requests for the addition of UNO commands

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=86899

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||158838


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=158838
[Bug 158838] UNO action to toggle applied styles like  and 
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158838] UNO action to toggle applied styles like and

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158838

V Stuart Foote  changed:

   What|Removed |Added

 Blocks||86899
Summary|Let shortcut keys toggle|UNO action to toggle
   |for styles like   |applied styles like
   |and | and 


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=86899
[Bug 86899] [META] Requests for the addition of UNO commands
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158838] Let shortcut keys toggle for styles like and

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158838

V Stuart Foote  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||vsfo...@libreoffice.org
   Keywords||needsUXEval

--- Comment #1 from V Stuart Foote  ---
Applied char styles don't really toggle, rather we have .uno:DefaultCharStyle
"No Character Style" to remove an applied Style from an active selection.

You can see this in use on the alternate View -> Toolbars 'Formatting (Styles)'
toolbar, the "A" icon with tooltip "Remove applied character style". Likewise
on the Styles menu.

It can also be assigned by Tools -> Customize... dialog  as a Keyboard or
Context menu shortcut. Just note that it is held with other 'Style' ->
'Character' category functions.

Guess there could be benefit to implementing a style toggle (apply|remove) for
the current TB buttons for users of the 'Formatting (Styles)' and if that
provided a hook for keyboard, menu customization even better.

Throwing it in the UX-advise pool.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158838] Let shortcut keys toggle for styles like and

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158838

V Stuart Foote  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||vsfo...@libreoffice.org
   Keywords||needsUXEval

--- Comment #1 from V Stuart Foote  ---
Applied char styles don't really toggle, rather we have .uno:DefaultCharStyle
"No Character Style" to remove an applied Style from an active selection.

You can see this in use on the alternate View -> Toolbars 'Formatting (Styles)'
toolbar, the "A" icon with tooltip "Remove applied character style". Likewise
on the Styles menu.

It can also be assigned by Tools -> Customize... dialog  as a Keyboard or
Context menu shortcut. Just note that it is held with other 'Style' ->
'Character' category functions.

Guess there could be benefit to implementing a style toggle (apply|remove) for
the current TB buttons for users of the 'Formatting (Styles)' and if that
provided a hook for keyboard, menu customization even better.

Throwing it in the UX-advise pool.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Declan Fodor license statement

2023-12-23 Thread Declan Fodor
All of my past & future contributions to LibreOffice may be
licensed under the MPLv2/LGPLv3+ dual license.

Looking forward to contributing,
Declan Fodor


[Bug 158423] CppunitTest_unoxml_domtest failing with libxml-2.12

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158423

Buovjaga  changed:

   What|Removed |Added

 CC||ilmari.lauhakangas@libreoff
   ||ice.org
 Whiteboard| QA:needsComment|

--- Comment #2 from Buovjaga  ---
(In reply to Gwyn Ciesla from comment #0)
> Complete log:
> https://kojipkgs.fedoraproject.org//work/tasks/2557/109622557/build.log

The link is 404.

I noticed there is a patch:
https://gerrit.libreoffice.org/c/libvisio/+/160542
tests: Fix build with libxml 2.12
libxml 2.12.0 reorganized the headers, which removed `xmlParseMemory` function
from the scope.

Gwyn: can you try, if the fix for unoxml/qa/unit/domtest.cxx would be likewise
simple?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 143082] SVG export of slide shows blank in some apps, hides objects with

2023-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143082

raal  changed:

   What|Removed |Added

  Regression By||Marco Cecchetti
   Keywords|bibisectRequest |bibisected, bisected
 CC||mrcek...@gmail.com,
   ||r...@post.cz

--- Comment #11 from raal  ---
This seems to have begun at the below commit in bibisect repository/OS
bibisect-linux-64-5.2.
Adding Cc: to Marco Cecchetti ; Could you possibly take a look at this one?
Thanks

ec0e5b057dc3cbbda20e94e608eb7005432d6b68 is the first bad commit
commit ec0e5b057dc3cbbda20e94e608eb7005432d6b68
Author: Jenkins Build User 
Date:   Thu Dec 7 10:57:55 2017 +0100

source sha:154521777f8c551f10ffbe414891df9d2a529ae3

20459: svg export: no more an experimental feature |
https://gerrit.libreoffice.org/c/core/+/20459

-- 
You are receiving this mail because:
You are the assignee for the bug.

  1   2   >