Re: Problem with RTFSprms::equals() method in RTF import

2024-01-15 Thread Miklos Vajna
Hi Regina,

On Mon, Jan 15, 2024 at 04:12:34PM +0100, Regina Henschel 
 wrote:
> I see a problem with the RTFSprms::equals() method. The problem is described
> in Bug 158950 - Paste as Rich Text Format loses character color and
> paragraph alignment from styles
> https://bugs.documentfoundation.org/show_bug.cgi?id=158950#c8
> 
> Miklos, as far as I see you have implemented the RTF import. Could you
> please have a look at that problem and comment?

At the end, you ask:

> I wonder about this RTFSprms::equals() method. It compares a vector of (Id, 
> RTFValue) items with a single RTFValue? I would expect that its input 
> parameter is a vector of (Id, RTFValues) and the iteration is parallel about 
> both vectors.

RTFValue is a recursive structure. The Value interface in writerfilter/
can kind of contain anything that comes from an XML file:

- XML element (called SPRM)
- XML attribute (called Attribute)
- string
- number
- boolean
- etc.

So that we try to make sure here is that in case you compare two
RTFValues then either the type is a simple one (string, boolean, etc) or
the Id ("name") is the same and all the sub-values (SPRMs, Attributes)
are also the same.

> If I disable the comparison
> if (!m_pAttributes->equals(rOther))
> return false;
> in RTFValue::equals(const RTFValue& rOther), then the example document loads 
> with the correct colors.

That's a clever hack, but you can see that not comparing attributes in
general is incorrect. For example, if I have paragraph borders, then
I'll have various attributes for that, and in case I consider different
border attributes as the same, that'll lead to an incorrect import
result.

So probably the root of the problem you're looking at will be somewhere
else, but likely still in writerfilter/.

I hope this gets you a little bit further. :-)

Regards,

Miklos


[Bug 105537] [META] Assertion failed crashes

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105537

Telesto  changed:

   What|Removed |Added

 Depends on||157080


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157080
[Bug 157080] Assertion in Tools > Options > Font
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 133092] [META] Crash bugs

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133092

Telesto  changed:

   What|Removed |Added

 Depends on|157080  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157080
[Bug 157080] Assertion in Tools > Options > Font
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 157080] Assertion in Tools > Options > Font

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157080

Telesto  changed:

   What|Removed |Added

 Blocks|133092  |105537


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105537
[Bug 105537] [META] Assertion failed crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=133092
[Bug 133092] [META] Crash bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.

Libreoffice Calculations

2024-01-15 Thread Tony Castronovo
I have a LO Form that has multiple fields that need to be added and result 
placed in another field.



Example: My form is for a Bounce House Company and has:



Fields rent1 thru rent8 and as each field is entered in the contract I need the 
contract Total field named totalrent accumulated with the total amounts of 
rent1 thru rent8 only for new contracts.



I have tried multiple resolutions using Querys or SQL statements and nothing 
works. When I include SQL or Querys to the totalrent the form loads as blank 
with a SQL error.



Can anyone help me. If a reasonable fee is required I am open to that.



Thanks Tony mailto:the...@zoho.com ​



     



Sent using https://www.zoho.com/mail/

Re: Crosscompiling LO

2024-01-15 Thread drei97

is it planned to bring this on the agenda again? The mingw support was
dropped quite 7 years ago, maybe there is some progress.


On the other hand, it will come with huge amount of work, I know!



Am 15.01.24 um 08:45 schrieb Miklos Vajna:

For building on Linux for Windows: we tried that in the past (mingw) and
it didn't really work out, see core.git commit
8646ab97dc37c0606b19057686bf3d610f9c15ee (Remove MinGW support,
2017-02-10) for more details.

Regards,

Miklos


[Bug 151162] Inserting a Word Joiner Unicode character doesn't always prevent a line break from occurring

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151162

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
Version|7.3.2.2 release |3.5.0 release
 Ever confirmed|0   |1

--- Comment #5 from Buovjaga  ---
(In reply to ask4support from comment #4)
> Created attachment 189793 [details]
> Demonstration file with a tutorial
> 
> I'm sorry, I do not currently have the opportunity to record a video
> tutorial, but I've compiled an ODT tutorial with the piece of form that let
> me discover this bug.

Thanks. I tried again and noticed that it can be reproduced with a very
specific width of the box. So writing out the instructions from your file and
modifying them a bit

1. Insert - Frame - Frame...
2. In Position and Size tab, Width: 2,92 " or 7,41 cm
3. In Borders tab, all padding to 0
4. Copy and paste the text from the frame in attachment 189793

Note that the font should be Liberation Sans and size 8 pt.

I could reproduce already in version 3.5.0

Arch Linux 64-bit, X11
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 5703d3af04b8fe78fdd4dbef14b08d8446402779
CPU threads: 8; OS: Linux 6.6; UI render: default; VCL: kf5 (cairo+xcb)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 14 January 2024

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: sw/source vcl/jsdialog

2024-01-15 Thread Méven Car (via logerrit)
 sw/source/ui/dialog/swdlgfact.cxx|5 +
 sw/source/ui/dialog/swdlgfact.hxx|1 +
 sw/source/ui/dialog/uiregionsw.cxx   |7 +--
 sw/source/uibase/dialog/regionsw.cxx |   16 +---
 vcl/jsdialog/enabled.cxx |1 +
 5 files changed, 21 insertions(+), 9 deletions(-)

New commits:
commit 0ffa0f103f928da3785f8b6a71d2956ba51b6989
Author: Méven Car 
AuthorDate: Tue Jan 9 15:15:23 2024 +0100
Commit: Andras Timar 
CommitDate: Tue Jan 16 07:59:51 2024 +0100

cool#1770 sw: make Edit Sections dialog async and mark it a jsdialog

We want our dialogs to be async so they don't lock documents when opened
and to allow concurrent edition.

In SwEditRegionDlg, we need to make sure the reference to the SwWrtShell
isn't read from 'this' after `response()`, as it is now the dialog is 
disposed of earlier in the async case.

How to test: Create a new Writer document, insert a section, right-click 
inside the section, pick the 'edit section' menu item to trigger this dialog.

Change-Id: Ibafca69542f13d16beef5a8fca006428cbcfe5c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161828
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161830
Tested-by: Jenkins
Reviewed-by: Andras Timar 

diff --git a/sw/source/ui/dialog/swdlgfact.cxx 
b/sw/source/ui/dialog/swdlgfact.cxx
index 66ac1ec21a25..30e41e4edaf4 100644
--- a/sw/source/ui/dialog/swdlgfact.cxx
+++ b/sw/source/ui/dialog/swdlgfact.cxx
@@ -307,6 +307,11 @@ short AbstractEditRegionDlg_Impl::Execute()
 return m_xDlg->run();
 }
 
+bool AbstractEditRegionDlg_Impl::StartExecuteAsync(AsyncContext )
+{
+return weld::DialogController::runAsync(m_xDlg, rCtx.maEndDialogFn);
+}
+
 short AbstractInsertSectionTabDialog_Impl::Execute()
 {
 return m_xDlg->run();
diff --git a/sw/source/ui/dialog/swdlgfact.hxx 
b/sw/source/ui/dialog/swdlgfact.hxx
index d5c1c43806d8..c2c043bb3eb6 100644
--- a/sw/source/ui/dialog/swdlgfact.hxx
+++ b/sw/source/ui/dialog/swdlgfact.hxx
@@ -663,6 +663,7 @@ public:
 {
 }
 virtual short Execute() override;
+virtual bool StartExecuteAsync(AsyncContext ) override;
 virtual voidSelectSection(const OUString& rSectionName) override;
 };
 
diff --git a/sw/source/ui/dialog/uiregionsw.cxx 
b/sw/source/ui/dialog/uiregionsw.cxx
index e3b56283f5cc..f1499b6a28ca 100644
--- a/sw/source/ui/dialog/uiregionsw.cxx
+++ b/sw/source/ui/dialog/uiregionsw.cxx
@@ -820,12 +820,15 @@ IMPL_LINK_NOARG(SwEditRegionDlg, OkHdl, weld::Button&, 
void)
 
 aOrigArray.clear();
 
+SwWrtShell& rSh = m_rSh;
+
 // response must be called ahead of EndAction's end,
 // otherwise ScrollError can occur.
 m_xDialog->response(RET_OK);
 
-m_rSh.EndUndo();
-m_rSh.EndAllAction();
+// accessing 'this' after response isn't safe, as the callback might cause 
the dialog to be disposed
+rSh.EndUndo();
+rSh.EndAllAction();
 }
 
 // Toggle protect
diff --git a/sw/source/uibase/dialog/regionsw.cxx 
b/sw/source/uibase/dialog/regionsw.cxx
index 9eaa64c89456..71f0c165b458 100644
--- a/sw/source/uibase/dialog/regionsw.cxx
+++ b/sw/source/uibase/dialog/regionsw.cxx
@@ -217,15 +217,17 @@ void SwBaseShell::EditRegionDialog(SfxRequest const & 
rReq)
 case FN_EDIT_CURRENT_REGION:
 {
 weld::Window* pParentWin = GetView().GetFrameWeld();
+
+SwAbstractDialogFactory* pFact = SwAbstractDialogFactory::Create();
+VclPtr 
pEditRegionDlg(pFact->CreateEditRegionDlg(pParentWin, rWrtShell));
+
+if(auto pStringItem = dynamic_cast< const SfxStringItem *>( pItem 
))
 {
-SwAbstractDialogFactory* pFact = 
SwAbstractDialogFactory::Create();
-ScopedVclPtr 
pEditRegionDlg(pFact->CreateEditRegionDlg(pParentWin, rWrtShell));
-if(auto pStringItem = dynamic_cast< const SfxStringItem *>( 
pItem ))
-{
-pEditRegionDlg->SelectSection(pStringItem->GetValue());
-}
-pEditRegionDlg->Execute();
+pEditRegionDlg->SelectSection(pStringItem->GetValue());
 }
+pEditRegionDlg->StartExecuteAsync([pEditRegionDlg](sal_Int32 
/*nResult */){
+pEditRegionDlg->disposeOnce();
+});
 }
 break;
 }
diff --git a/vcl/jsdialog/enabled.cxx b/vcl/jsdialog/enabled.cxx
index 058880a97835..c8ed0d73efad 100644
--- a/vcl/jsdialog/enabled.cxx
+++ b/vcl/jsdialog/enabled.cxx
@@ -178,6 +178,7 @@ bool isBuilderEnabled(std::u16string_view rUIFile, bool 
bMobile)
 || rUIFile == u"modules/swriter/ui/contentcontrollistitemdlg.ui"
 || rUIFile == u"modules/swriter/ui/dropcapspage.ui"
 || rUIFile == u"modules/swriter/ui/dropdownfielddialog.ui"
+|| rUIFile == u"modules/swriter/ui/editsectiondialog.ui"
 || rUIFile == 

core.git: sw/source sw/uiconfig

2024-01-15 Thread Méven Car (via logerrit)
 sw/source/ui/dialog/uiregionsw.cxx  |2 ++
 sw/source/uibase/inc/regionsw.hxx   |1 +
 sw/uiconfig/swriter/ui/editsectiondialog.ui |2 +-
 3 files changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 777b549242ab188eb68a8201cd0659d706f627e9
Author: Méven Car 
AuthorDate: Wed Jan 10 10:26:38 2024 +0100
Commit: Andras Timar 
CommitDate: Tue Jan 16 07:58:21 2024 +0100

sw Edit Sections: hide Link section in LOK case

In the LibreOfficeKit case the section does not make sense as the
application has only restricted access to files, so hide it.

Test: In Writer new document, insert a section, right click on section,
Edit section..., Link section is visible.

In LOK case the Link section is not present.

Change-Id: I7aab8b384909d25e52f5fca2bf54f86e5c662b54
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161878
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 
(cherry picked from commit f9546a5e9e204fc058365aaddfb0dfa8f9a26418)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162130
Tested-by: Jenkins
Reviewed-by: Andras Timar 

diff --git a/sw/source/ui/dialog/uiregionsw.cxx 
b/sw/source/ui/dialog/uiregionsw.cxx
index f0318a4cafe3..e3b56283f5cc 100644
--- a/sw/source/ui/dialog/uiregionsw.cxx
+++ b/sw/source/ui/dialog/uiregionsw.cxx
@@ -357,6 +357,7 @@ SwEditRegionDlg::SwEditRegionDlg(weld::Window* pParent, 
SwWrtShell& rWrtSh)
 , m_xOptionsPB(m_xBuilder->weld_button("options"))
 , m_xDismiss(m_xBuilder->weld_button("remove"))
 , m_xHideFrame(m_xBuilder->weld_widget("hideframe"))
+, m_xLinkFrame(m_xBuilder->weld_frame("linkframe"))
 {
 m_xTree->set_size_request(-1, m_xTree->get_height_rows(16));
 m_xFileCB->set_state(TRISTATE_FALSE);
@@ -418,6 +419,7 @@ SwEditRegionDlg::SwEditRegionDlg(weld::Window* pParent, 
SwWrtShell& rWrtSh)
 
 if(comphelper::LibreOfficeKit::isActive())
 {
+m_xLinkFrame->hide();
 m_xDDECB->hide();
 m_xDDECommandFT->hide();
 m_xFileNameFT->hide();
diff --git a/sw/source/uibase/inc/regionsw.hxx 
b/sw/source/uibase/inc/regionsw.hxx
index 410b9d6db8a7..ad425df898e5 100644
--- a/sw/source/uibase/inc/regionsw.hxx
+++ b/sw/source/uibase/inc/regionsw.hxx
@@ -77,6 +77,7 @@ class SwEditRegionDlg final : public SfxDialogController
 std::unique_ptr m_xOptionsPB;
 std::unique_ptr m_xDismiss;
 std::unique_ptr m_xHideFrame;
+std::unique_ptr m_xLinkFrame;
 
 voidRecurseList(const SwSectionFormat* pFormat, const weld::TreeIter* 
pIter);
 size_t  FindArrPos(const SwSectionFormat* pFormat);
diff --git a/sw/uiconfig/swriter/ui/editsectiondialog.ui 
b/sw/uiconfig/swriter/ui/editsectiondialog.ui
index 3a571100684f..2c358fa69fa5 100644
--- a/sw/uiconfig/swriter/ui/editsectiondialog.ui
+++ b/sw/uiconfig/swriter/ui/editsectiondialog.ui
@@ -237,7 +237,7 @@
 12
 12
 
-  
+  
 True
 False
 True


core.git: comphelper/source compilerplugins/clang include/sfx2 include/tools sc/source sfx2/source sw/source uui/source

2024-01-15 Thread Noel Grandin (via logerrit)
 comphelper/source/misc/logging.cxx  |4 
 compilerplugins/clang/unusedfields.only-used-in-constructor.results |   56 
+
 compilerplugins/clang/unusedfields.readonly.results |   34 
+++--
 compilerplugins/clang/unusedfields.untouched.results|   44 
---
 compilerplugins/clang/unusedfields.writeonly.results|   60 
++
 include/sfx2/lokhelper.hxx  |1 
 include/tools/inetstrm.hxx  |2 
 sc/source/filter/inc/lotattr.hxx|1 
 sc/source/filter/lotus/lotattr.cxx  |2 
 sfx2/source/view/lokhelper.cxx  |7 -
 sw/source/uibase/inc/mailmrge.hxx   |1 
 uui/source/iahndl.hxx   |9 -
 12 files changed, 115 insertions(+), 106 deletions(-)

New commits:
commit 6d91b6b7718704c0037cfbfdaa42ba259a0d791a
Author: Noel Grandin 
AuthorDate: Mon Jan 15 15:31:06 2024 +0200
Commit: Noel Grandin 
CommitDate: Tue Jan 16 07:43:00 2024 +0100

loplugin:unusedfields

Change-Id: Ic53aacfc76cb73902cf5e304153975fa02509da2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162110
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/comphelper/source/misc/logging.cxx 
b/comphelper/source/misc/logging.cxx
index ae150290bedd..a7785d46a747 100644
--- a/comphelper/source/misc/logging.cxx
+++ b/comphelper/source/misc/logging.cxx
@@ -38,7 +38,6 @@ namespace comphelper
 class EventLogger_Impl
 {
 private:
-Reference< XComponentContext >  m_aContext;
 Reference< XLogger >m_xLogger;
 
 public:
@@ -70,8 +69,7 @@ namespace comphelper
 }
 
 EventLogger_Impl::EventLogger_Impl(const Reference< XComponentContext >& 
_rxContext, const OUString& rLoggerName)
-: m_aContext(_rxContext)
-, m_xLogger(createLogger(_rxContext, rLoggerName))
+: m_xLogger(createLogger(_rxContext, rLoggerName))
 {
 }
 
diff --git 
a/compilerplugins/clang/unusedfields.only-used-in-constructor.results 
b/compilerplugins/clang/unusedfields.only-used-in-constructor.results
index fe92d48c4b9d..4ef9ab5fd47d 100644
--- a/compilerplugins/clang/unusedfields.only-used-in-constructor.results
+++ b/compilerplugins/clang/unusedfields.only-used-in-constructor.results
@@ -42,6 +42,8 @@ chart2/source/controller/inc/dlg_View3D.hxx:46
 chart::View3DDialog m_aControllerLocker ControllerLockHelper
 chart2/source/controller/inc/RangeSelectionListener.hxx:65
 chart::RangeSelectionListener m_aControllerLockGuard ControllerLockGuardUNO
+chart2/source/view/charttypes/AreaChart.hxx:68
+chart::AreaChart m_aMainPosHelper PlottingPositionHelper
 connectivity/source/commontools/RowFunctionParser.cxx:373
 connectivity::(anonymous namespace)::ExpressionGrammar::definition 
unaryFunction ::boost::spirit::classic::rule
 connectivity/source/commontools/RowFunctionParser.cxx:374
@@ -160,9 +162,7 @@ cui/source/inc/tabstpge.hxx:86
 SvxTabulatorTabPage m_aCenterWin TabWin_Impl
 cui/source/inc/tabstpge.hxx:87
 SvxTabulatorTabPage m_aDezWin TabWin_Impl
-cui/source/options/optaboutconfig.hxx:55
-CuiAboutConfigTabPage m_pParent weld::Window *
-cui/source/options/optcolor.cxx:274
+cui/source/options/optcolor.cxx:282
 (anonymous namespace)::ColorConfigWindow_Impl::Entry m_aDefaultColor Color
 dbaccess/source/core/api/RowSet.hxx:108
 dbaccess::ORowSet m_aURL OUString
@@ -198,8 +198,8 @@ drawinglayer/source/tools/emfphelperdata.hxx:198
 emfplushelper::EmfPlusHelperData mnFrameRight sal_Int32
 drawinglayer/source/tools/emfphelperdata.hxx:199
 emfplushelper::EmfPlusHelperData mnFrameBottom sal_Int32
-editeng/source/editeng/impedit.hxx:528
-ImpEditEngine aSelFuncSet EditSelFunctionSet
+editeng/source/editeng/impedit.hxx:552
+ImpEditEngine maSelFuncSet EditSelFunctionSet
 embeddedobj/source/msole/olecomponent.hxx:51
 OleComponent m_pInterfaceContainer 
comphelper::OMultiTypeInterfaceContainerHelper2 *
 embeddedobj/source/msole/olecomponent.hxx:53
@@ -238,8 +238,6 @@ filter/source/graphicfilter/icgm/chart.hxx:51
 DataNode nBoxY2 sal_Int16
 helpcompiler/inc/HelpCompiler.hxx:200
 HelpCompiler lang const std::string
-include/basic/basmgr.hxx:59
-BasicError nReason BasicErrorReason
 include/comphelper/seqstream.hxx:75
 comphelper::SequenceInputStream m_aData const css::uno::Sequence
 include/docmodel/theme/FormatScheme.hxx:373
@@ -266,6 +264,8 @@ include/registry/registry.hxx:34
 Registry_Api acquire void (*)(RegHandle)
 include/sfx2/classificationhelper.hxx:134
 sfx::ClassificationKeyCreator m_ePolicyType const 
SfxClassificationPolicyType
+include/sfx2/lokhelper.hxx:258
+SfxLokLanguageGuard m_pNewShell const SfxViewShell *
 include/sfx2/msg.hxx:116
 

[Bug 60428] Duplex Printing - HP Officejet Pro 8600 Plus

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=60428

rosgn...@gmx.ch changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #49 from rosgn...@gmx.ch ---
I have a new printer, so I'm not certain, but as I remember it did work after
one of the updates.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 64679] [META] Printer settings related issues

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=64679
Bug 64679 depends on bug 60428, which changed state.

Bug 60428 Summary: Duplex Printing - HP Officejet Pro 8600 Plus
https://bugs.documentfoundation.org/show_bug.cgi?id=60428

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

dev-tools.git: help3/xhpeditor

2024-01-15 Thread Juan José González (via logerrit)
 help3/xhpeditor/api/check_xhp.php |   61 ++
 1 file changed, 61 insertions(+)

New commits:
commit b347baf1eaefc0c5538ec6a4ea6b4a5ba2f8a895
Author: Juan José González 
AuthorDate: Sun Jan 14 11:12:01 2024 -0600
Commit: Olivier Hallot 
CommitDate: Tue Jan 16 06:24:34 2024 +0100

Add check xhp async endpoint.

I am adding the endpoint first before the client using it, to prevent what 
happend with the render endpoint returning 404.

Change-Id: I118b4adacf026ef85781f9e8d91d9cfdd00719f5
Reviewed-on: https://gerrit.libreoffice.org/c/dev-tools/+/162050
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/help3/xhpeditor/api/check_xhp.php 
b/help3/xhpeditor/api/check_xhp.php
new file mode 100644
index ..7c0ca865
--- /dev/null
+++ b/help3/xhpeditor/api/check_xhp.php
@@ -0,0 +1,61 @@
+ 'XHP is required'], 400);
+}
+
+$xhp = $data['xhpdoc'];
+
+$all_errors = [
+'xhp_errors' => [],
+'duplicated_ids' => [],
+];
+
+libxml_use_internal_errors(true);
+libxml_clear_errors();
+
+$root = 'helpdocument';
+$old = new DOMDocument;
+
+if (!$old->loadXML($xhp)) {
+$all_errors['xhp_errors'] = libxml_get_errors();
+libxml_clear_errors();
+} else {
+$creator = new DOMImplementation;
+$doctype = $creator->createDocumentType($root, null, '../xmlhelp.dtd');
+$new = $creator->createDocument(null, null, $doctype);
+$new->encoding = "utf-8";
+
+$oldNode = $old->getElementsByTagName($root)->item(0);
+$newNode = $new->importNode($oldNode, true);
+$new->appendChild($newNode);
+libxml_clear_errors();
+
+if(!$new->validate()) {
+$all_errors['xhp_errors'] = libxml_get_errors();
+libxml_clear_errors();
+}
+
+$tags_id_uniq = 
array('paragraph','note','warning','tip','h1','h2','h3','h4','h5','h6');
+$xmlarray = simplexml_load_string($xhp);
+$i = 0;
+foreach($tags_id_uniq as $tag_uniq) {
+foreach ($xmlarray->xpath("//$tag_uniq") as $tag){
+$idarray[$i] = $tag['id'];
+++$i;
+}
+}
+$dupped_array =  array_values(array_unique(array_diff_key($idarray, 
array_unique($idarray;
+$all_errors['duplicated_ids'] = $dupped_array;
+}
+
+respond(['errors' => $all_errors]);
+}
+catch (Exception $e) {
+respond(['message' => 'Unexpected error'], 500);
+}


[Bug 159211] New: Test failure 24.2.0.1 final only on s390x: testTdf157635::TestBody

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159211

Bug ID: 159211
   Summary: Test failure 24.2.0.1 final only on s390x:
testTdf157635::TestBody
   Product: LibreOffice
   Version: 24.2.0.1 rc
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gw...@protonmail.com

[_RUN_] testTdf99729::TestBody
testTdf99729::TestBody finished in: 139ms
PNGExportTests.cxx:300:Assertion
Test name: testTdf156808::TestBody
greater assertion failed
- Expected greater than: 9000
- Actual  : 0

PNGExportTests.cxx:551:Assertion
Test name: testTdf157635::TestBody
greater assertion failed
- Expected greater than: 7100
- Actual  : 0


https://download.copr.fedorainfracloud.org/results/limb/lo22/fedora-rawhide-s390x/06905891-libreoffice/builder-live.log.gz

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159166] WRITER: section spanning inconsistent in page vs. section

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159166

Mike Kaganski  changed:

   What|Removed |Added

URL||https://ask.libreoffice.org
   ||/t/one-column-title-on-two-
   ||column-page-style/100586

--- Comment #1 from Mike Kaganski  ---
IMO, it would not be correct.
The discussion in
https://ask.libreoffice.org/t/one-column-title-on-two-column-page-style/100586
was about a "single-column header, multi-column chapter". The problem was, that
it is easier to format page style as two-column at once, then apply the
single-column properties (e.g., sections) to headings.

1. From the *logical document structure* point of view, this would be wrong. It
makes headings *nested deeper* (the chapter text is some direct descendant of
the document, while the heading is nested into a section in the document);
while the logical structure is "chapter text is a child of a higher-level
outline object".

2. From the operational point of view, there is an equally easy workaround:
select all text, place into a multi-column section, then put headings into
single-column section. (From the structure PoV, this creates the same "nested
deeper" situation.)

If the proposal of this report would be implemented, it would require that the
page columns be split into separate pieces by the sections. The text would need
to balance itself not to the page column(s), but to some page(s) area between
sections. It looks odd, when the text fills some *part* of the first column,
then (while there is still space in the first column) jumps to a *part* of the
second column; then it jumps back to the first column to insert a section there
(spanning both columns); and then the following text continues on the first
column...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 134906] [META] Regressions from implementing soft edge and glow effects

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134906
Bug 134906 depends on bug 138402, which changed state.

Bug 138402 Summary: EDITING: Embedded chart in PPT is black after returning 
from OLE editor
https://bugs.documentfoundation.org/show_bug.cgi?id=138402

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 58323] [META] OLE objects interoperability issues

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=58323
Bug 58323 depends on bug 138402, which changed state.

Bug 138402 Summary: EDITING: Embedded chart in PPT is black after returning 
from OLE editor
https://bugs.documentfoundation.org/show_bug.cgi?id=138402

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 138402] EDITING: Embedded chart in PPT is black after returning from OLE editor

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138402

Aron Budea  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #6 from Aron Budea  ---
I can't reproduce the bug even when checking out the same commit in the 7.1
bibisect repo. Maybe it was a GPU driver issue, how knows... let's close.

-- 
You are receiving this mail because:
You are the assignee for the bug.

New Defects reported by Coverity Scan for LibreOffice

2024-01-15 Thread scan-admin
Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found 
with Coverity Scan.

3 new defect(s) introduced to LibreOffice found with Coverity Scan.
22 defect(s), reported by Coverity Scan earlier, were marked fixed in the 
recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1586339:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/sc/inc/fstalgorithm.hxx: 67 in sc::buildSpanWithValue::PatternSpan>(std::vector> &, mdds::flat_segment_tree::const_iterator, 
mdds::flat_segment_tree::const_iterator)()



*** CID 1586339:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/sc/inc/fstalgorithm.hxx: 67 in sc::buildSpanWithValue::PatternSpan>(std::vector> &, mdds::flat_segment_tree::const_iterator, 
mdds::flat_segment_tree::const_iterator)()
61 Key nIndex1 = nLastPos;
62 Key nIndex2 = nThisPos-1;
63 rSpans.push_back(Span(nIndex1, nIndex2, nLastVal));
64 }
65 
66 nLastPos = nThisPos;
>>> CID 1586339:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
>>> "nThisVal" is copied in a call to copy assignment "operator =", when it 
>>> could be moved instead.
67 nLastVal = nThisVal;
68 }
69 }
70 
71 /**
72  * Convert a flat_segment_tree structure whose value type is boolean, 
into

** CID 1586338:(UNINIT)



*** CID 1586338:(UNINIT)
/sw/source/core/unocore/unodraw.cxx: 1333 in SwXShape::setPropertyValue(const 
rtl::OUString &, const com::sun::star::uno::Any &)()
1327 }
1328 //anchor position has to be inserted after the 
text attribute has been inserted
1329 aNewAnchor.SetAnchor( aPam.GetPoint() );
1330 aSet.Put( aNewAnchor );
1331 pFormat->SetFormatAttr(aSet);
1332 bSetAttr = false;
>>> CID 1586338:(UNINIT)
>>> Using uninitialized value 
>>> "aNewAnchor.m_oContentAnchor._M_payload._M_payload" when calling 
>>> "~SwFormatAnchor".
1333 }
1334 if( text::TextContentAnchorType_AS_CHARACTER == 
eNewAnchor &&
1335 (RndStdIds::FLY_AS_CHAR != eOldAnchorId))
1336 {
1337 SwPaM aPam(pDoc->GetNodes().GetEndOfContent());
1338 if( 
pDoc->getIDocumentLayoutAccess().GetCurrentLayout() )
/sw/source/core/unocore/unodraw.cxx: 1360 in SwXShape::setPropertyValue(const 
rtl::OUString &, const com::sun::star::uno::Any &)()
1354 aPam.GetPoint()->GetContentIndex(), 0 );
1355 aPam.GetPoint()->AdjustContent(-1); // 
InsertItem moved it
1356 SwFormatAnchor aNewAnchor(
1357 aSet.Get(RES_ANCHOR));
1358 aNewAnchor.SetAnchor( aPam.GetPoint() );
1359 aSet.Put( aNewAnchor );
>>> CID 1586338:(UNINIT)
>>> Using uninitialized value 
>>> "aNewAnchor.m_oContentAnchor._M_payload._M_payload" when calling 
>>> "~SwFormatAnchor".
1360 }
1361 if( bSetAttr )
1362 pFormat->SetFormatAttr(aSet);
1363 
1364 // If this property is an anchor change, and there 
is a group shape with textboxes
1365 // do anchor sync in time unless the anchor sync 
in the porfly will cause crash during

** CID 1586337:  Uninitialized variables  (UNINIT)



*** CID 1586337:  Uninitialized variables  (UNINIT)
/sw/source/core/doc/docdraw.cxx: 291 in SwDoc::GroupSelection(SdrView &)()
285 
286 if( pUndo )
287 {
288 pUndo->SetGroupFormat( pFormat );
289 GetIDocumentUndoRedo().AppendUndo( std::move(pUndo) );
290 }
>>> CID 1586337:  Uninitialized variables  (UNINIT)
>>> Using uninitialized value 
>>> "aAnch.m_oContentAnchor._M_payload._M_payload" when calling 
>>> "~SwFormatAnchor".
291 }
292 else
293 {
294 if (GetIDocumentUndoRedo().DoesUndo())
295 {
296 GetIDocumentUndoRedo().ClearRedo();



To view the defects in Coverity Scan visit, 

[Bug 155337] Writer Has Repeatable Crash

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155337

--- Comment #11 from QA Administrators  ---
Dear BrendaEM,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159189] Cropping rectangles missing on left hand side middle and bottom

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159189

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 60428] Duplex Printing - HP Officejet Pro 8600 Plus

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=60428

--- Comment #48 from QA Administrators  ---
Dear rosgnilk,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159189] Cropping rectangles missing on left hand side middle and bottom

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159189

--- Comment #6 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 73085] Function TYPE returns value 8, but that value does not exist in specification

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=73085

--- Comment #11 from QA Administrators  ---
Dear Regina Henschel,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 151451] SearchDescriptor returns wrong result when Tracking enabled (macro search finds not-displayed redline text)

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151451

--- Comment #4 from Mae Inman  ---
Thanks for the useful reply here. https://tiny-fishing.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'distro/collabora/co-24.04' - sal/osl

2024-01-15 Thread Aron Budea (via logerrit)
 sal/osl/unx/file.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d8963d03ed9c349447a0073d2dabfebc3f2a875d
Author: Aron Budea 
AuthorDate: Tue Jan 16 12:24:36 2024 +1030
Commit: Aron Budea 
CommitDate: Tue Jan 16 12:26:01 2024 +1030

Fix build

Change-Id: I4c097d4c18f2f6793cde1f3bf3beab2b4c733be4

diff --git a/sal/osl/unx/file.cxx b/sal/osl/unx/file.cxx
index 848a586ad2ce..ecd721cfc31c 100644
--- a/sal/osl/unx/file.cxx
+++ b/sal/osl/unx/file.cxx
@@ -35,6 +35,7 @@
 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -61,7 +62,6 @@
 #include 
 #include 
 #include 
-#include 
 #endif
 
 namespace {


[Bug 158167] Calc: Move selected row and scroll sheet extremely slow with CPU in local debug build

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158167

Aron Budea  changed:

   What|Removed |Added

   Keywords|bibisectRequest |notBibisectable

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 83689] VIEWING: Fix these bugs in Calc and I will pay you money

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=83689

--- Comment #4 from fencerdye  ---
Hello everyone,
How can I check the character encoding settings in the formula editor and the
application?
Contact me via: https://spacebarclicker.co

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 154863] Crash when moving images around in a multipage table

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154863

Matt K  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |matt...@gmail.com
   |desktop.org |

--- Comment #7 from Matt K  ---
Fix is tracked in: https://gerrit.libreoffice.org/c/core/+/162151

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159210] Jumping to Last Page (Ctrl+End) in Document Extremely Slow

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159210

Tex2002ans  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||8556
   Keywords||perf
 CC||mikekagan...@hotmail.com,
   ||Tex2002ans+LibreOffice@gmai
   ||l.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158556] DOCX Document That Opens/Loads Extremely Slowly

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158556

Tex2002ans  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||9210

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159210] New: Jumping to Last Page (Ctrl+End) in Document Extremely Slow

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159210

Bug ID: 159210
   Summary: Jumping to Last Page (Ctrl+End) in Document Extremely
Slow
   Product: LibreOffice
   Version: 7.6.3.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tex2002ans+libreoff...@gmail.com

Description:
After loading this document... Jumping to last page, then going to next-to-last
page takes LO >1 hour vs. Microsoft Word's <30 seconds.

Steps to Reproduce:
0) Open attachment 191261.
   - It'll take a while... it's ~2 million words + ~1450 DOCX pages.

After file finishes opening:

1) Press CTRL+END
   - To jump to final page.

2) Press PAGE UP.
   - To jump up one page.

- - - - - - - - -

This is how long it takes:

Microsoft Word 2016:

1) 28 secs
2) instant

LibreOffice 7.6.3:

1) 7 mins 42 secs
2) >37 mins
- (I gave up after 37 mins.)

Actual Results:
>1 hour of waiting.

Expected Results:
<2 minutes of waiting.


Reproducible: Always


User Profile Reset: No

Additional Info:
Tested on:

Version: 7.6.3.2 (X86_64) / LibreOffice Community
Build ID: 29d686fea9f6705b262d369fede658f824154cc0
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

and:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 25276df12abd9d002f7f899900434617b256f745
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

- - - - - - - - -

For a little more info, also see:

- Bug #158556 (Comment 2 and beyond)
   - Issue focuses on very slow open.
   - Mike Kaganski recommended I open a separate bug for this
performance-after-load issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 81234] [META] RTF filter issues

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=81234
Bug 81234 depends on bug 85390, which changed state.

Bug 85390 Summary: FILEOPEN RTF linemod0 keyword triggers line numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=85390

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 85390] FILEOPEN RTF linemod0 keyword triggers line numbering

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=85390

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||kelem...@ubuntu.com
 Status|NEW |RESOLVED

--- Comment #9 from Gabor Kelemen (allotropia)  ---
Seems to be fixed in 6.4 since

https://git.libreoffice.org/core/+/de5a0023695584a4c2c5a2729284186d43fc7d82

author  Xisco Fauli Thu Mar 26 15:50:59
2020 +0100
committer   Michael Stahl Wed Apr 08 11:32:37
2020 +0200
tree057d85ddb9be47eb78e190366f650ea17c3418d0
parent  7eb78233b46652f4317aef34a1bac4d084b00e2d [diff]

tdf#131594: switch line numbering off if w:countBy="0"

*** This bug has been marked as a duplicate of bug 131594 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158874] Want MS-Word like auto-formatting of beginning of list item

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158874

--- Comment #8 from Eyal Rozenberg  ---
(In reply to Heiko Tietze from comment #7)
> There is no character formatting happening,

Yes, there is. (An MSO user complained about this to me and I reproduced it.)

If you're not seeing it, I suppose I could create a screencast...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158874] Want MS-Word like auto-formatting of beginning of list item

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158874

--- Comment #8 from Eyal Rozenberg  ---
(In reply to Heiko Tietze from comment #7)
> There is no character formatting happening,

Yes, there is. (An MSO user complained about this to me and I reproduced it.)

If you're not seeing it, I suppose I could create a screencast...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 159203] Writer crashes after clicking on hidden "Export" button

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159203

Rafael Lima  changed:

   What|Removed |Added

 CC||rafael.palma.l...@gmail.com

--- Comment #3 from Rafael Lima  ---
I can reproduce the issue in:

Version: 7.6.4.1 (X86_64) / LibreOffice Community
Build ID: 60(Build:1)
CPU threads: 12; OS: Linux 6.5; UI render: default; VCL: kf5 (cairo+wayland)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Ubuntu package version: 4:7.6.4-0ubuntu0.23.10.1
Calc: threaded

But I can't reproduce under X11... so this seems to be a Wayland issue.

In the latest master (built today), the problem does not happen, even on
wayland.

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b2ee028d0f805124d823a32aed70bcaf63377757
CPU threads: 12; OS: Linux 6.5; UI render: default; VCL: kf5 (cairo+wayland)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 146828] FILEOPEN: The export RTF opens differently. Vertical height appears to be bigger

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146828

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 CC||kelem...@ubuntu.com

--- Comment #7 from Gabor Kelemen (allotropia)  ---
Created attachment 191978
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191978=edit
The documents after enabling the Do not add leading between lines of text
option

Looks like this example is affected by the "Do not add leading (external space)
between lines of text" option. Enabling it makes the little extra space above
the text disappear.

But at the same time, fixing the RTF export of the other mentioned compat
options would make sense, those may eventually bite us elsewhere.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 146828] FILEOPEN: The export RTF opens differently. Vertical height appears to be bigger

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146828

--- Comment #6 from Gabor Kelemen (allotropia)  ---
Created attachment 191977
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191977=edit
The ODT and its RTF export side by side, with Compatibility settings

To me it looks like several compatibility options are not saved correctly to
RTF format:
- Do not add leading (extra space) between lines of text -> disabled
- Consider wrapping style when positioning object -> disabled
- Word-compatible trailing blanks -> enabled
- Tolerate white lines that may appear in PDF page backgrounds -> disabled
- Hide paragraphs of database fields with an empty value -> enabled

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 130699] Assert on undo/redo table captions SwIndexReg::~SwIndexReg(

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=130699

--- Comment #9 from Tex2002ans  ---
> I think asserts are only active in debug builds. That is probably why nothing 
> happened for you.

Ahhh, okay. Thanks for the info. So a debug-only issue. Strange.

Well, always good to poke at the backlog.

And I'll have to keep an eye out for Crash-Asserts in the future. :)

(I just searched, then was just randomly picking and choosing some older
still-open bugs to retest.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159209] Footers appear as headers when opening old Mac Word 5.1 format documents

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159209

--- Comment #4 from tk...@swbell.net ---
Created attachment 191976
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191976=edit
Word Document in Mac Word 4.0 format with header and footer

Opening this document in LibreOffice will display correctly

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159209] Footers appear as headers when opening old Mac Word 5.1 format documents

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159209

--- Comment #3 from tk...@swbell.net ---
Created attachment 191975
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191975=edit
Word Document in Mac Word 5.1 format with header and footer

Opening this document in LibreOffice will display correctly

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159209] Footers appear as headers when opening old Mac Word 5.1 format documents

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159209

--- Comment #2 from tk...@swbell.net ---
Created attachment 191974
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191974=edit
Word Document in Mac Word 4.0 format with footer only

Opening this document in LibreOffice will erroneously show the footer as a
header.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159209] Footers appear as headers when opening old Mac Word 5.1 format documents

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159209

--- Comment #1 from tk...@swbell.net ---
Created attachment 191973
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191973=edit
Word Document in Mac Word 5.1 format with footer only

Opening this document in LibreOffice will errouneusly show the footer as a
header.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159209] New: Footers appear as headers when opening old Mac Word 5.1 format documents

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159209

Bug ID: 159209
   Summary: Footers appear as headers when opening old Mac Word
5.1 format documents
   Product: LibreOffice
   Version: 7.5.9.2 release
  Hardware: x86 (IA32)
OS: macOS (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tk...@swbell.net

Description:
When I open old Mac Microsoft Word 4.0 and 5.1 format documents that have
footers, but no headers, the footer appears instead as a header. (However, If
the old document has both header and footer, they are handled correctly.)


Steps to Reproduce:
1.Open an old Mac Word Document from Word versions 4.0, 5.0, or 5.1 that has a
footer but no header
2.View the displayed file. The footer appears instead as a header.

Actual Results:
Footer appears as a header

Expected Results:
Footer should appear as a footer like it did in the old version of Microsoft
Word for Mac


Reproducible: Always


User Profile Reset: Yes

Additional Info:
I will attach some old Mac Word documents in formats for Word 4.0 and Word 5.1,
with footer only and again with footer and header. The documents with Footer
only demonstrate the problem. The documents with Footer and Header display
correctly.  These documents are test documents with only a few words and do NOT
contain any meaningful or confidential content.

I tested this only with LibreOffice 7.5.9.2 and used two Macs, one with OS X
10.14 and the other with Mac OS Ventura (13.6.1).


Version: 7.5.9.2 (X86_64) / LibreOffice Community
Build ID: cdeefe45c17511d326101eed8008ac4092f278a9
CPU threads: 8; OS: Mac OS X 10.14.6; UI render: Skia/Metal; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159208] add "portrait" page style for manual page break

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159208

libretist  changed:

   What|Removed |Added

 CC||s...@wolke7.net

--- Comment #1 from libretist  ---
To clarify:
In the description above
« I'd expect to see both (out-of-the-box) »
means
« I'd expect to see both "landscape" and "portrait" page styles out-of-the-box
»

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159208] New: add "portrait" page style for manual page break

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159208

Bug ID: 159208
   Summary: add "portrait" page style for manual page break
   Product: LibreOffice
   Version: 7.5.9.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: s...@wolke7.net

Description:
Out of the box, there is a "landscape" page style, but no equivalent "portrait"
page style. Please add.

Steps to Reproduce:
 Steps to reproduce the issue in LibreOffice Writer:

1. insert > more breaks > manual break


Actual Results:
in the "page style" drop down list, you see "landscape" but not "portrait"

Expected Results:
I'd expect to see both (out-of-the-box):
1) for the sake of consistency (if there is a landscape, logically there should
also be portrait)
2) If I create a portrait document (so page 1 is landscape) and then want to
continue with portrait on page 2, I have to select "first page" as the page
style for the manual break -- which is weird, because it actually is NOT the
first page, but the second page!
(There might be some inner logic to that terminology, but for beginners it's
very confusing and drives them away from using your product.)


Reproducible: Always


User Profile Reset: No

Additional Info:
-

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159204] Import of a text .srt file skips characters between ellipses

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159204

--- Comment #4 from Eltomito  ---
(In reply to m_a_riosv from comment #3)
> You need to select the filter
> On the box at the right of the filename, select 'Text (*.txt)
> On the file name: *.srt
> Select the file.

Maybe that works but if you just right click on the file in a file manager and
open it with LO then LO automatically does something wrong and that's what this
bug report is about.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 132913] Crash in: swlo.dll

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132913

--- Comment #8 from Patrick Luby  ---
(In reply to Patrick Luby from comment #7)
> Created attachment 191972 [details]
> Crash log using steps in comment 6

I am hitting an assert in my local macOS Sonoma build. Not sure if you are
hitting the same assert with downloaded build.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 132913] Crash in: swlo.dll

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132913

--- Comment #7 from Patrick Luby  ---
Created attachment 191972
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191972=edit
Crash log using steps in comment 6

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159189] Cropping rectangles missing on left hand side middle and bottom

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159189

--- Comment #5 from Stefan Lüer  ---
(In reply to Regina Henschel from comment #3)
> (In reply to Stefan Lüer from comment #0)
> > Description:
> > The blue rectangles for cropping pictures are not shown on the left hand
> > side in the middle and at the bottom.
> 
> And the other handle are wrong in your screenshot.
> 
> That is likely connected with the display resolution (dpi) and the icon set.
> Please tell us your display dpi and your chosen icon set.
Regarding the dpi https://www.sven.de/dpi/ says
Display size: 15.08" × 8.48" = 127.89in² (38.3cm × 21.54cm = 825.07cm²) at
254.67 PPI, 0.0997mm dot pitch, 64857 PPI²

The directory with the icons contains the following files:
15.01.2024  22:57 1.462 cropmarkers.png
15.01.2024  22:56   256 doc_modified_no.png
15.01.2024  23:28 0 list.txt
15.01.2024  22:57   383 marker-circ9-5.png
15.01.2024  22:57   552 marker-cross.png
15.01.2024  22:57   448 marker-elli11x9-5.png
15.01.2024  22:57   460 marker-elli9x11-5.png
15.01.2024  22:56   111 marker-rect9-1.png
15.01.2024  22:56   111 marker-rect9-3.png
15.01.2024  22:56   573 pageshadow35x35.png
15.01.2024  22:56   847 rectbtns.png
15.01.2024  22:56   486 signet_11x16.png
15.01.2024  22:56   145 slidezoombutton_10.png
15.01.2024  22:56   177 slidezoomin_10.png
15.01.2024  22:56   118 slidezoomout_10.png
15.01.2024  22:56   405 zoom_page_statusbar.png

> 
> Other possible reason: If you use a svg-icon set, png-icons are generated on
> first use and then cached. These cached icons might have a wrong size. For
> the crop handle the file is 'cropmarkers.png' in this folder: parent of
> 'user' folder > Cache > your icon set name > resolution in percent > svx >
> res.
> If you have such 'cropmarkers.png' file, please tell us its pixel-size.

See above. I have never explicitly changed any icon setting.

Thx,
Stefan

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 154703] [META] Export DOCX flies with framePr instead of DrawingDML

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154703

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||9207

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 113340] [META] RTF (text) paragraph-related issues

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113340

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Depends on||159207


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=159207
[Bug 159207] FILEOPEN DOCX/RTF Frame opens with unwanted left border
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159207] New: FILEOPEN DOCX/RTF Frame opens with unwanted left border

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159207

Bug ID: 159207
   Summary: FILEOPEN DOCX/RTF Frame opens with unwanted left
border
   Product: LibreOffice
   Version: 24.2.0.0 alpha0+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kelem...@ubuntu.com
Blocks: 113340

Created attachment 191971
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191971=edit
The example file in Word 2016 and current master

When opening attachment 151650 from bug 125473, the footer contains a frame,
which has a left border set.

1. Open attachment 151650 
-> there is a frame in the footer, which should not have a left border.

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 25276df12abd9d002f7f899900434617b256f745
CPU threads: 15; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (hu_HU); UI: de-DE
Calc: threaded

Looks the same if saved as docx in Word.
This happens since commit:

https://git.libreoffice.org/core/+/31ea6305b6a763ee48f639562313d9bd109a2923%5E%21/#F2

author  Justin Luth  Sat Apr 08 08:22:45 2023 -0400
committer   Justin Luth Sat Apr 08 20:10:09 2023 +0200
tree6032ceaafca3ba4514811453ca20af8b136dcb25
parent  02bf9a2e65042afc224f52680cbcfcf30e298ad1 [diff]

tdf#154703 writerfilter framePr: avoid exception with hasValue

Before this the frame was not imported at all, so not a regression.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113340
[Bug 113340] [META] RTF (text) paragraph-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 125473] FILEOPEN RTF Paragraph border missing if paragraph is inside a frame

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125473

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||9207

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 154863] Crash when moving images around in a multipage table

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154863

Matt K  changed:

   What|Removed |Added

Version|7.6.0.0 alpha0+ |3.3.0 release

--- Comment #6 from Matt K  ---
I have reliable set of repro steps to make it crash, so I tried to bibisect it,
but it crashes even in 3.3, so not a regression.  Updated version.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159178] EXPORT as xhtml in calc misformatted; embedded pictures are displayed over tables

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159178

m_a_riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #7 from m_a_riosv  ---
Reproducible with
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 25276df12abd9d002f7f899900434617b256f745
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded

Anchoring the graphic to page, makes it not exported.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159189] Cropping rectangles missing on left hand side middle and bottom

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159189

--- Comment #4 from Stefan Lüer  ---
Updated to Version: 7.6.4.1 (X86_64) / LibreOffice Community
Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1
CPU threads: 12; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded
=> no improvement

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158746] Precise object positioning is a game of patience.

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158746

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #5 from Regina Henschel  ---
For exact positioning use
the Position dialog,
or set snap points or lines,
or use positioning relative to other object with the align-toolbar,
or enable snap to grid,
or use Alt+Arrow to move objects in pixel steps,
or use a large zoom.

When working in Draw it is helpful to show the "Options" toolbar, which
collects some snap and grid toggles.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159203] Writer crashes after clicking on hidden "Export" button

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159203

--- Comment #2 from medmedin2014  ---
Created attachment 191970
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191970=edit
Writer crash

See attached video for more info.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159178] EXPORT as xhtml in calc misformatted; embedded pictures are displayed over tables

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159178

--- Comment #6 from Daniel Rieder  ---
Created attachment 191969
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191969=edit
misformatted xhtml export file created by LibreOffice calc version 7.5.9.2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159178] EXPORT as xhtml in calc misformatted; embedded pictures are displayed over tables

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159178

--- Comment #5 from Daniel Rieder  ---
Created attachment 191968
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191968=edit
correct formatted xhtml file exported with LibreOffice calc version 7.3.5.2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159189] Cropping rectangles missing on left hand side middle and bottom

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159189

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #3 from Regina Henschel  ---
(In reply to Stefan Lüer from comment #0)
> Description:
> The blue rectangles for cropping pictures are not shown on the left hand
> side in the middle and at the bottom.

And the other handle are wrong in your screenshot.

That is likely connected with the display resolution (dpi) and the icon set.
Please tell us your display dpi and your chosen icon set.

Other possible reason: If you use a svg-icon set, png-icons are generated on
first use and then cached. These cached icons might have a wrong size. For the
crop handle the file is 'cropmarkers.png' in this folder: parent of 'user'
folder > Cache > your icon set name > resolution in percent > svx > res.
If you have such 'cropmarkers.png' file, please tell us its pixel-size.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159178] EXPORT as xhtml in calc misformatted; embedded pictures are displayed over tables

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159178

--- Comment #4 from Daniel Rieder  ---
Created attachment 191967
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191967=edit
Sample calc file that leads to bugy xhtml file with LibreOffice version 7.5.9.2
or 7.6.4.1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159206] FILEOPEN RTF Table embedded in floating table slips together

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159206

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||regression

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159206] New: FILEOPEN RTF Table embedded in floating table slips together

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159206

Bug ID: 159206
   Summary: FILEOPEN RTF Table embedded in floating table slips
together
   Product: LibreOffice
   Version: 24.8.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kelem...@ubuntu.com
CC: jl...@mail.com, vmik...@collabora.com
Blocks: 155045

Created attachment 191966
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191966=edit
The example file in Word and current master

This is a followup to bug 96276

attachment 121062 has two tables, one floating, another embedded into it.
Recently the embedded one started to slip upwards into the floating ones area.

1. Open attachment 121062
-> tables are slipping into each other.

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 25276df12abd9d002f7f899900434617b256f745
CPU threads: 15; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (hu_HU); UI: de-DE
Calc: threaded

Started with:

https://git.libreoffice.org/core/+/016f779ee6c7f601be3ae19dc57497e63a5bf817

author  Justin Luth  Mon Dec 18 12:29:25 2023 -0500
committer   Miklos Vajna Tue Dec 19 09:08:57
2023 +0100
tree1b00ac2f1e81e92a0383bcb3ad1b0ceea85f695e
parent  e915d9f6973c742a1d810c460d895a93522d3308 [diff]

tdf#158586 RTF writerfilter: substitute hasProperties for inFrame

It was not good before either, the two tables were placed on two pages instead
of one, since:

https://git.libreoffice.org/core/+/9a5d1c250cbaac855b3e63d8c5fa0882ba7d14a2

author  Miklos Vajna Tue Jul 18 08:30:04 2023 +0200
committer   Miklos Vajna Tue Jul 18 11:41:10
2023 +0200
treeef844fba0a4668b5e19cf3f4a528ca2ddbf02b7d
parent  007ef352c2e6a061c52a45a35d3930d318b8ca8b [diff]

tdf#120262 sw floattable, legacy: go outside body only for page frame vert pos

Before this the tables looked ~good.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=155045
[Bug 155045] [META] RTF Floating table related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 96276] Fileopen: RTF paragraph line spacing 1.15 instead of Single

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=96276

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||9206

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158586] FILEOPEN RTF: missing page break

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158586

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||9206

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 155045] [META] RTF Floating table related issues

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155045

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Depends on||159206


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=159206
[Bug 159206] FILEOPEN RTF Table embedded in floating table slips together
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159205] number formatting lost when insert new row

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159205

m_a_riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #1 from m_a_riosv  ---
Test with
Menu/Tools/Options/LibreOffice Calc/General - Expand formatting.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159204] Import of a text .srt file skips characters between ellipses

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159204

m_a_riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #3 from m_a_riosv  ---
You need to select the filter
On the box at the right of the filename, select 'Text (*.txt)
On the file name: *.srt
Select the file.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 53614] FILEOPEN: Document In Use Dialog appearing after cancelling Text Import dialog

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=53614

Andreas Heinisch  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |andreas.heini...@yahoo.de
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159203] Writer crashes after clicking on hidden "Export" button

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159203

m_a_riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m_a_riosv  ---
Not reproducible on Windows.
Version: 7.6.4.1 (X86_64) / LibreOffice Community
Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159201] User-defined indexes don’t work anymore when created from styles

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159201

m_a_riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #2 from m_a_riosv  ---
With Menu/Tools/Updates/Update all, shows the TOC.
Version: 7.6.4.1 (X86_64) / LibreOffice Community
Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159205] New: number formatting lost when insert new row

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159205

Bug ID: 159205
   Summary: number formatting lost when insert new row
   Product: LibreOffice
   Version: 7.5.9.2 release
  Hardware: x86 (IA32)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: stuart.gel...@gmail.com

In a column with existing number formatting (like 2 decimal places, or dollar
sign), a new row inserted in the middle of the column has no assigned
formatting. That forces me to clone the formatting every time I insert a new
row.

I see similar bugs reported in the "possible duplicates" list, but none that
matches that description exactly. Anyway, their status is "resolved/fixed" and
I assure you the problem is NOT fixed in version 7.5.9.2.

Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159204] Import of a text .srt file skips characters between ellipses

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159204

--- Comment #2 from Eltomito  ---
Find the something.srt file attached for testing.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159204] Import of a text .srt file skips characters between ellipses

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159204

--- Comment #1 from Eltomito  ---
Created attachment 191965
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191965=edit
File to recreate the bug.

This file can be used to demonstrate the bug as described in the original buf
report.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159204] New: Import of a text .srt file skips characters between ellipses

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159204

Bug ID: 159204
   Summary: Import of a text .srt file skips characters between
ellipses
   Product: LibreOffice
   Version: 7.6.4.1 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tomaspa...@centrum.cz

Description:
When I open a .srt file (which is really just plain text) with LO, the result
seems normal except that all text after the first (and every odd) ellipsis in
the file is dropped (not imported at all) until the next ellipsis is
encountered.


Steps to Reproduce:
1. Create a plain text file with the following content and save it as
"something.srt":
 FILE CONTENT 
This is imported…

THIS IS NOT IMPORTED

Neither is this…

And this is imported again.

What about this… BLAH BLAH… Is it there?
 END OF FILE CONTENT 
2. Open the file with LibreOffice Writer
3. Behold the text with the parts between the ellipses missing (it's the text
in bold, for convenience)


Actual Results:
The parts between adjacent pairs of ellipses are missing.

Expected Results:
The parts between adjacent pairs of ellipses should NOT be missing.


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Version: 7.6.4.1 (X86_64) / LibreOffice Community
Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1
CPU threads: 12; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: vcl/unx

2024-01-15 Thread Julien Nabet (via logerrit)
 vcl/unx/generic/printer/cpdmgr.cxx|5 +++--
 vcl/unx/gtk3/salnativewidgets-gtk.cxx |1 +
 2 files changed, 4 insertions(+), 2 deletions(-)

New commits:
commit 877014b0b7050ba3fce1c0126279125640117313
Author: Julien Nabet 
AuthorDate: Mon Jan 15 19:42:05 2024 +0100
Commit: Julien Nabet 
CommitDate: Mon Jan 15 22:07:52 2024 +0100

Add missing g_free in salnativewidgets-gtk + reorder ones in cpdmgr (vcl)

Change-Id: I2608a2fe238d124f3a158438e8219fbc63f750d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162126
Reviewed-by: Julien Nabet 
Reviewed-by: Caolán McNamara 
Tested-by: Jenkins

diff --git a/vcl/unx/generic/printer/cpdmgr.cxx 
b/vcl/unx/generic/printer/cpdmgr.cxx
index 834c1383efba..03cf85a7b75b 100644
--- a/vcl/unx/generic/printer/cpdmgr.cxx
+++ b/vcl/unx/generic/printer/cpdmgr.cxx
@@ -81,9 +81,9 @@ void CPDManager::onNameAcquired (GDBusConnection *connection,
   G_DBUS_CALL_FLAGS_NONE,
   -1, nullptr, nullptr, nullptr);
 
-g_free(contents);
 g_object_unref(proxy);
 g_dbus_node_info_unref(introspection_data);
+g_free(contents);
 }
 g_free(backend.second);
 }
@@ -122,10 +122,10 @@ void CPDManager::printerAdded (GDBusConnection 
*connection,
nullptr,
nullptr);
 
-g_free(contents);
 g_dbus_node_info_unref(introspection_data);
 std::pair new_backend (sender_name, 
proxy);
 current->addBackend(std::move(new_backend));
+g_free(contents);
 }
 }
 CPDPrinter *pDest = static_cast(malloc(sizeof(CPDPrinter)));
@@ -262,6 +262,7 @@ CPDManager* CPDManager::tryLoadCPD()
 {
 std::pair new_tbackend (filename, 
contents);
 pManager->addTempBackend(new_tbackend);
+g_free(contents);
 }
 }
 g_dir_close(dir);
diff --git a/vcl/unx/gtk3/salnativewidgets-gtk.cxx 
b/vcl/unx/gtk3/salnativewidgets-gtk.cxx
index a3a82edaa1ac..bfdeed423846 100644
--- a/vcl/unx/gtk3/salnativewidgets-gtk.cxx
+++ b/vcl/unx/gtk3/salnativewidgets-gtk.cxx
@@ -2332,6 +2332,7 @@ bool GtkSalGraphics::updateSettings(AllSettings& 
rSettings)
 gchar* pFontname = nullptr;
 g_object_get(pSettings, "gtk-font-name", , nullptr);
 PangoFontDescription* pFontDesc = 
pango_font_description_from_string(pFontname);
+g_free(pFontname);
 vcl::Font aFont(pango_to_vcl(pFontDesc, 
rSettings.GetUILanguageTag().getLocale()));
 pango_font_description_free(pFontDesc);
 #else


[Bug 159203] Writer crashes after clicking on hidden "Export" button

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159203

medmedin2014  changed:

   What|Removed |Added

Summary|Writer crashes when Export  |Writer crashes after
   |button is hidden|clicking on hidden "Export"
   ||button

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159203] New: Writer crashes when Export button is hidden

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159203

Bug ID: 159203
   Summary: Writer crashes when Export button is hidden
   Product: LibreOffice
   Version: 7.6.4.1 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: med.medin.2...@gmail.com

Steps:
1. Using "Tabbed" user interface, try to resize Writer window until "Export"
button in "File" tab is hidden under expand ">>" button,
2. Click on expand ">>" button then "Export" button

Expected result:
Export dialog opens.

Observed result:
Writer crashes.


Info:

Version: 7.6.4.1 (X86_64) / LibreOffice Community
Build ID: 60(Build:1)
CPU threads: 2; OS: Linux 6.7; UI render: default; VCL: kf5 (cairo+wayland)
Locale: en-US (en_US.UTF-8); UI: en-US
7.6.4-2
Calc: threaded

Operating System: Manjaro Linux 
KDE Plasma Version: 5.27.10
KDE Frameworks Version: 5.114.0
Qt Version: 5.15.12
Kernel Version: 6.7.0-2-MANJARO (64-bit)
Graphics Platform: Wayland

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159152] EDITING: Paste Special of Formula only Overwrites Comment in Destination Cell.

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159152

m_a_riosv  changed:

   What|Removed |Added

 Status|VERIFIED|RESOLVED

--- Comment #3 from m_a_riosv  ---
Verified, it's when the patch is known.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'libreoffice-24-2' - distro-configs/LibreOfficeFlatpak.conf solenv/flatpak-manifest.in

2024-01-15 Thread Stephan Bergmann (via logerrit)
 distro-configs/LibreOfficeFlatpak.conf |1 +
 solenv/flatpak-manifest.in |7 +++
 2 files changed, 8 insertions(+)

New commits:
commit 8f72aa782500f456f02f18fa74f6b3b6c9b5e90c
Author: Stephan Bergmann 
AuthorDate: Mon Jan 15 16:00:53 2024 +0100
Commit: Xisco Fauli 
CommitDate: Mon Jan 15 21:45:00 2024 +0100

Flatpak: Work around patched libpng in org.freedesktop.Sdk

see


"Work around patched libpng in org.freedesktop.Sdk":

...which carries


"elements/base/libpng.bst: Add support for animated PNGs", thus handles 
"acTL"
chunks by itself, thus doesn't call the LibreOffice handle_unknown_chunk
function (in vcl/source/filter/png/PngImageReader.cxx) for such chunks, thus
never sets APNGInfo::mbIsApng to true, so causes CppunitTest_vcl_png_test to
fail with

> PngFilterTest.cxx:382:Assertion
> Test name: PngFilterTest::testApng
> assertion failed
> - Expression: aGraphic.IsAnimated()

() since


"tdf#104877 Add basic APNG format support".

The patch appears to originate from
, and it might be possible to
adapt the LibreOffice code to also work with such a patched libpng (whose 
png.h
defines PNG_APGN_SUPPORTED).  However, for now just use LibreOffice's own
external/libpng instead of the patched one.

Change-Id: Ib67056d11dfa6456920a18216a3b2bbec45f3662
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162112
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 
(cherry picked from commit 223bfa24cdeee2ed45ff8d9ab7bb0b92eb8af587)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162107
Reviewed-by: Xisco Fauli 

diff --git a/distro-configs/LibreOfficeFlatpak.conf 
b/distro-configs/LibreOfficeFlatpak.conf
index 3850269ace0f..911184c337eb 100644
--- a/distro-configs/LibreOfficeFlatpak.conf
+++ b/distro-configs/LibreOfficeFlatpak.conf
@@ -41,6 +41,7 @@
 --without-system-libnumbertext
 --without-system-libodfgen
 --without-system-libpagemaker
+--without-system-libpng
 --without-system-libqxp
 --without-system-librevenge
 --without-system-libstaroffice
diff --git a/solenv/flatpak-manifest.in b/solenv/flatpak-manifest.in
index a8d8b88394a8..74beb39f21b9 100644
--- a/solenv/flatpak-manifest.in
+++ b/solenv/flatpak-manifest.in
@@ -793,6 +793,13 @@
 "dest": "external/tarballs",
 "dest-filename": "@ARGON2_TARBALL@"
 },
+{
+"url": 
"https://dev-www.libreoffice.org/src/@LIBPNG_TARBALL@;,
+"sha256": "@LIBPNG_SHA256SUM@",
+"type": "file",
+"dest": "external/tarballs",
+"dest-filename": "@LIBPNG_TARBALL@"
+},
 {
 "url": 
"https://dev-www.libreoffice.org/extern/@OPENSYMBOL_TTF@;,
 "sha256": "@OPENSYMBOL_SHA256SUM@",


core.git: sc/qa

2024-01-15 Thread Xisco Fauli (via logerrit)
 sc/qa/unit/ucalc.cxx |   14 ++
 1 file changed, 14 insertions(+)

New commits:
commit e96956e82c5b792ad9c6a2a2f2b0406488be4de0
Author: Xisco Fauli 
AuthorDate: Mon Jan 15 12:29:52 2024 +0100
Commit: Xisco Fauli 
CommitDate: Mon Jan 15 21:40:47 2024 +0100

tdf#159148: sc_ucalc: Add unittest

Change-Id: I748529b2a35fdfcac52fe33ecd39006471ed8e76
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162086
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 370f2d1f5c80..e300b4b5ccbb 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -3691,6 +3691,20 @@ CPPUNIT_TEST_FIXTURE(Test, testTdf76836)
 m_pDoc->DeleteTab(0);
 }
 
+CPPUNIT_TEST_FIXTURE(Test, testTdf151752)
+{
+m_pDoc->InsertTab(0, "Test");
+
+m_pDoc->SetString(ScAddress(0,0,0), "66000:00");
+
+// Without the fix in place, this test would have failed with
+// - Expected: 66000:00:00
+// - Actual  : 464:00:00
+CPPUNIT_ASSERT_EQUAL(OUString("66000:00:00"), 
m_pDoc->GetString(ScAddress(0,0,0)));
+
+m_pDoc->DeleteTab(0);
+}
+
 CPPUNIT_TEST_FIXTURE(Test, testTdf142186)
 {
 m_pDoc->InsertTab(0, "Test");


[Bug 158044] RTF import paragraph style attribute handling wrong

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158044

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:24.2.0 target:7.6.4  |target:24.2.0 target:7.6.4
   |target:24.8.0   |target:24.8.0
   |target:24.2.0.0.beta2   |target:24.2.0.0.beta2
   ||target:24.2.1

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'libreoffice-24-2' - sw/qa writerfilter/source

2024-01-15 Thread Oliver Specht (via logerrit)
 sw/qa/extras/rtfexport/data/tdf158830.rtf |  237 
 sw/qa/extras/rtfexport/data/tdf158978.rtf |  350 ++
 sw/qa/extras/rtfexport/data/tdf158982.rtf |  281 
 sw/qa/extras/rtfexport/rtfexport8.cxx |   45 +++
 writerfilter/source/rtftok/rtfsprm.cxx|2 
 5 files changed, 914 insertions(+), 1 deletion(-)

New commits:
commit b65a2bc14c1553846bd0f4910951a0a964b3cde5
Author: Oliver Specht 
AuthorDate: Tue Jan 9 11:39:58 2024 +0100
Commit: Xisco Fauli 
CommitDate: Mon Jan 15 21:40:14 2024 +0100

tdf#158830 fixes regression introduces with tdf#158044

Removing paragraph attributes equal to style attributes now works also
for paragraphs within tables.
This fixes also the regressions documented in tdf#158978 and tdf#158982

Change-Id: I9f430e23fd33cff4d6ec1d1954969666f0080574
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161824
Tested-by: Jenkins
Tested-by: Xisco Fauli 
Reviewed-by: Xisco Fauli 
Tested-by: Gabor Kelemen 
Reviewed-by: Gabor Kelemen 
(cherry picked from commit 204d50a07501bf8445a8a0526f68987373834318)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162109

diff --git a/sw/qa/extras/rtfexport/data/tdf158830.rtf 
b/sw/qa/extras/rtfexport/data/tdf158830.rtf
new file mode 100755
index ..f6408a63b4c6
--- /dev/null
+++ b/sw/qa/extras/rtfexport/data/tdf158830.rtf
@@ -0,0 +1,237 @@
+{
tf1deflang1025nsinsicpg1250\uc1deff1\deff0\stshfdbch0\stshfloch0\stshfhich0\stshfbi0\deflang1038\deflangfe1038
  hemelang1035hemelangfe0 hemelangcs0{onttbl{0bidi roman
charset0prq2{\*\panose 02020603050405020304}Times New Roman{\*alt Times New 
Roman};}
+{1bidi swisscharset0prq2{\*\panose 020b0604020202020204}Arial{\*alt 
Helvetica};}{1bidi swisscharset0prq2{\*\panose 
020b0604020202020204}Arial{\*alt Helvetica};}
+{39bidi swisscharset0prq2{\*\panose 020f0502020204030204}Calibri;}{40
bidi swisscharset0prq2{\*\panose }Tahoma;}{42bidi 
romancharset0prq2{\*\panose 02040503050406030204}Cambria;}
+{lomajor31500bidi romancharset0prq2{\*\panose 02020603050405020304}Times 
New Roman{\*alt Times New Roman};}{dbmajor31501bidi romancharset0
prq2{\*\panose 02020603050405020304}Times New Roman{\*alt Times New Roman};}
+{himajor31502bidi romancharset0prq2{\*\panose 
02040503050406030204}Cambria;}{bimajor31503bidi romancharset0
prq2{\*\panose 02020603050405020304}Times New Roman{\*alt Times New Roman};}
+{lominor31504bidi romancharset0prq2{\*\panose 02020603050405020304}Times 
New Roman{\*alt Times New Roman};}{dbminor31505bidi romancharset0
prq2{\*\panose 02020603050405020304}Times New Roman{\*alt Times New Roman};}
+{himinor31506bidi swisscharset0prq2{\*\panose 
020f0502020204030204}Calibri;}{biminor31507bidi romancharset0
prq2{\*\panose 02020603050405020304}Times New Roman{\*alt Times New Roman};}
+{359bidi romancharset238prq2 Times New Roman CE{\*alt Times New 
Roman};}{360bidi romancharset204prq2 Times New Roman Cyr{\*alt Times New 
Roman};}
+{362bidi romancharset161prq2 Times New Roman Greek{\*alt Times New 
Roman};}{363bidi romancharset162prq2 Times New Roman Tur{\*alt Times New 
Roman};}
+{364bidi romancharset177prq2 Times New Roman (Hebrew){\*alt Times New 
Roman};}{365bidi romancharset178prq2 Times New Roman (Arabic){\*alt Times 
New Roman};}
+{366bidi romancharset186prq2 Times New Roman Baltic{\*alt Times New 
Roman};}{367bidi romancharset163prq2 Times New Roman (Vietnamese){\*alt 
Times New Roman};}{369bidi swisscharset238prq2 Arial CE{\*alt Helvetica};}
+{370bidi swisscharset204prq2 Arial Cyr{\*alt Helvetica};}{372bidi 
swisscharset161prq2 Arial Greek{\*alt Helvetica};}{373bidi swiss
charset162prq2 Arial Tur{\*alt Helvetica};}
+{374bidi swisscharset177prq2 Arial (Hebrew){\*alt Helvetica};}{375bidi 
swisscharset178prq2 Arial (Arabic){\*alt Helvetica};}{376bidi swiss
charset186prq2 Arial Baltic{\*alt Helvetica};}
+{377bidi swisscharset163prq2 Arial (Vietnamese){\*alt Helvetica};}{369
bidi swisscharset238prq2 Arial CE{\*alt Helvetica};}{370bidi swiss
charset204prq2 Arial Cyr{\*alt Helvetica};}
+{372bidi swisscharset161prq2 Arial Greek{\*alt Helvetica};}{373bidi 
swisscharset162prq2 Arial Tur{\*alt Helvetica};}{374bidi swisscharset177
prq2 Arial (Hebrew){\*alt Helvetica};}
+{375bidi swisscharset178prq2 Arial (Arabic){\*alt Helvetica};}{376bidi 
swisscharset186prq2 Arial Baltic{\*alt Helvetica};}{377bidi swiss
charset163prq2 Arial (Vietnamese){\*alt Helvetica};}
+{749bidi swisscharset238prq2 Calibri CE;}{750bidi swisscharset204
prq2 Calibri Cyr;}{752bidi swisscharset161prq2 Calibri Greek;}{753bidi 
swisscharset162prq2 Calibri Tur;}
+{754bidi swisscharset177prq2 Calibri 

[Bug 158830] FILEOPEN RTF Table header styled texts alignment changed

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158830

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:24.8.0   |target:24.8.0 target:24.2.1

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: sc/qa

2024-01-15 Thread Xisco Fauli (via logerrit)
 sc/qa/unit/uicalc/uicalc.cxx |   19 +++
 1 file changed, 19 insertions(+)

New commits:
commit 3d4ee5ee34da11d3580f0b778406424556ed0ed6
Author: Xisco Fauli 
AuthorDate: Mon Jan 15 13:39:56 2024 +0100
Commit: Xisco Fauli 
CommitDate: Mon Jan 15 21:39:51 2024 +0100

tdf#159174: sc_uicalc: Add unittest

Change-Id: I5df0a4b4e0e9d0af5b9187def68e2971b2c86dff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162089
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sc/qa/unit/uicalc/uicalc.cxx b/sc/qa/unit/uicalc/uicalc.cxx
index 19571c064fed..53f4a7e2b2b5 100644
--- a/sc/qa/unit/uicalc/uicalc.cxx
+++ b/sc/qa/unit/uicalc/uicalc.cxx
@@ -2156,6 +2156,25 @@ CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testTdf158551)
 CPPUNIT_ASSERT_EQUAL(OUString("10"), pDoc->GetString(ScAddress(1, 0, 0)));
 }
 
+CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testTdf159174)
+{
+createScDoc();
+
+dispatchCommand(mxComponent, ".uno:SelectUnprotectedCells", {});
+dispatchCommand(mxComponent, ".uno:Copy", {});
+
+uno::Sequence aPropertyValues = 
comphelper::InitPropertySequence(
+{ { "SelectedFormat", 
uno::Any(static_cast(SotClipboardFormatId::BITMAP)) } });
+
+// Without the fix in place, this test would have crashed
+dispatchCommand(mxComponent, ".uno:ClipboardFormatItems", aPropertyValues);
+
+ScModelObj* pModelObj = 
comphelper::getFromUnoTunnel(mxComponent);
+uno::Reference 
xPage(pModelObj->getDrawPages()->getByIndex(0),
+ uno::UNO_QUERY_THROW);
+CPPUNIT_ASSERT_EQUAL(static_cast(0), xPage->getCount());
+}
+
 CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testKeyboardMergeRef)
 {
 createScDoc();


[Bug 159172] LO crashes on Run macro, if extension installed for user

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159172

--- Comment #2 from Julien Nabet  ---
I also got a crash with all users but not right away after having select "Run
macro", I tried to expand "Application Macros".

I noticed this on gdb:
#7  0x7f73fa637693 in CuiConfigGroupListBox::FillScriptList
(this=0x556a0da106a0, xRootNode=uno::Reference to
(browsenodefactory::(anonymous namespace)::LocationBrowseNode *)
0x556a0ddf5ee8, 
pParentEntry=0x7ffd53181780) at
/home/julien/lo/libreoffice/cui/source/customize/cfgutil.cxx:582
582 if ( rxNode->getType() ==
browse::BrowseNodeTypes::CONTAINER )
(gdb) p grandchildren
$1 = uno::Sequence of length 1 = {empty uno::Reference}

Now I don't know if an empty uno::Ref may be expected in grandchildren (which
comes from theChild->getChildNodes()).
If it's expected, this patch prevents from the crash:
diff --git a/cui/source/customize/cfgutil.cxx
b/cui/source/customize/cfgutil.cxx
index 3a2cdbc1b05e..e22e6d5ef81e 100644
--- a/cui/source/customize/cfgutil.cxx
+++ b/cui/source/customize/cfgutil.cxx
@@ -579,7 +579,7 @@ void CuiConfigGroupListBox::FillScriptList(const
css::uno::Reference< css::scrip

 for ( const auto& rxNode : grandchildren )
 {
-if ( rxNode->getType() ==
browse::BrowseNodeTypes::CONTAINER )
+if ( rxNode.is() && rxNode->getType() ==
browse::BrowseNodeTypes::CONTAINER )
 {
 bChildOnDemand = true;
 break;
@@ -893,7 +893,7 @@ void CuiConfigGroupListBox::GroupSelected()

 for ( const Reference< browse::XBrowseNode >&
childNode : children )
 {
-if (childNode->getType() ==
browse::BrowseNodeTypes::SCRIPT)
+if (childNode.is() && childNode->getType() ==
browse::BrowseNodeTypes::SCRIPT)
 {
 OUString uri, description;

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'distro/collabora/co-24.04' - editeng/source

2024-01-15 Thread Pranam Lashkari (via logerrit)
 editeng/source/uno/unotext.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit a7ef4590e878f6c8014575c417479ab541f8a028
Author: Pranam Lashkari 
AuthorDate: Fri Dec 15 10:10:12 2023 +0530
Commit: Andras Timar 
CommitDate: Mon Jan 15 21:26:00 2024 +0100

Keep selection as after copying the text

This also aligns code with 'else' branch behaviour

problem:
in online when coping a slide with comment,
comment text was never copied in online,
it required document to reload to show it correctly

Change-Id: I6d444c10808ef23f282370b4b305c41eb5043b76
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160812
Tested-by: Jenkins CollaboraOffice 
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 
(cherry picked from commit db7faa06762ac902ff56ecbab3fff763951146e1)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160943
Tested-by: Jenkins

diff --git a/editeng/source/uno/unotext.cxx b/editeng/source/uno/unotext.cxx
index f74d7f67c328..a10fd66fdf9a 100644
--- a/editeng/source/uno/unotext.cxx
+++ b/editeng/source/uno/unotext.cxx
@@ -2217,6 +2217,7 @@ void SvxUnoTextBase::copyText(
 {
 pTextForwarder->CopyText( *pSourceTextForwarder );
 pEditSource->UpdateData();
+SetSelection(pSource->GetSelection());
 }
 }
 else


core.git: Branch 'distro/collabora/co-24.04' - 8 commits - desktop/source include/osl include/sfx2 include/svx include/tools include/unotools sal/osl sal/qa sal/util sc/source sd/inc sd/source sfx2/so

2024-01-15 Thread Szymon Kłos (via logerrit)
 desktop/source/lib/init.cxx|   25 +
 include/osl/file.h |   48 +
 include/osl/file.hxx   |   52 ++
 include/sfx2/lokhelper.hxx |3 
 include/svx/PaletteManager.hxx |4 
 include/svx/theme/IThemeColorChanger.hxx   |   10 +-
 include/svx/theme/ThemeColorChangerCommon.hxx  |5 +
 include/svx/theme/ThemeColorPaletteManager.hxx |3 
 include/tools/hostfilter.hxx   |   28 +
 include/unotools/pathoptions.hxx   |1 
 sal/osl/unx/file.cxx   |  124 +
 sal/osl/unx/file_impl.hxx  |2 
 sal/osl/unx/file_misc.cxx  |   34 ++
 sal/osl/unx/file_stat.cxx  |6 +
 sal/osl/unx/file_volume.cxx|4 
 sal/osl/unx/pipe.cxx   |4 
 sal/osl/unx/process.cxx|5 -
 sal/osl/unx/profile.cxx|4 
 sal/qa/osl/file/osl_File.cxx   |  118 +++
 sal/util/sal.map   |6 +
 sc/source/core/tool/webservicelink.cxx |8 +
 sc/source/filter/html/htmlpars.cxx |   10 ++
 sc/source/ui/docshell/externalrefmgr.cxx   |5 -
 sc/source/ui/drawfunc/fuins1.cxx   |   11 ++
 sc/source/ui/inc/ThemeColorChanger.hxx |2 
 sc/source/ui/theme/ThemeColorChanger.cxx   |4 
 sc/source/ui/view/tabvwshc.cxx |9 +
 sd/inc/theme/ThemeColorChanger.hxx |2 
 sd/source/core/ThemeColorChanger.cxx   |4 
 sd/source/ui/func/fuinsert.cxx |   14 ++
 sd/source/ui/inc/ViewShellBase.hxx |2 
 sd/source/ui/view/ViewShellBase.cxx|   15 +++
 sd/source/ui/view/drviews2.cxx |8 -
 sfx2/source/view/lokhelper.cxx |   17 +++
 svx/source/tbxctrls/PaletteManager.cxx |   36 +++
 svx/source/theme/ThemeColorChangerCommon.cxx   |   56 +++
 svx/source/theme/ThemeColorPaletteManager.cxx  |9 -
 sw/source/core/inc/ThemeColorChanger.hxx   |2 
 sw/source/core/model/ThemeColorChanger.cxx |4 
 sw/source/filter/html/htmlgrin.cxx |6 +
 sw/source/uibase/shells/basesh.cxx |7 -
 sw/source/uibase/uiview/view.cxx   |7 -
 sw/source/uibase/uiview/view2.cxx  |   10 ++
 tools/Library_tl.mk|1 
 tools/source/inet/hostfilter.cxx   |   31 ++
 ucb/source/ucp/webdav-curl/CurlSession.cxx |7 +
 unotools/source/config/pathoptions.cxx |6 +
 47 files changed, 718 insertions(+), 61 deletions(-)

New commits:
commit 88281b55c1d781f73a663188229c639a290c53bc
Author: Szymon Kłos 
AuthorDate: Mon Jan 8 18:46:13 2024 +0100
Commit: Szymon Kłos 
CommitDate: Mon Jan 15 21:07:28 2024 +0100

Send document colors with lok callback

First step for publishing any palette for LOK.
Let's start with Document colors (colors used in the
document) which can be extracted similar to theme
colors from SfxViewShell.

Modify generateJSON function so it appends palette into
existing ptree/JSON.

In the next step we can make it more generic so it will
be able to send any palette managed by PaletteManager.

Change-Id: Ibb56690af6dfd59ee232e88b28e7a3d312d0e16c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161798
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Tomaž Vajngerl 
(cherry picked from commit 0460be8848b0ce02c07183e41dd7137ac3b94164)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161941
Tested-by: Jenkins
Reviewed-by: Szymon Kłos 

diff --git a/include/svx/PaletteManager.hxx b/include/svx/PaletteManager.hxx
index 81f30ea7de76..90fa00de59fe 100644
--- a/include/svx/PaletteManager.hxx
+++ b/include/svx/PaletteManager.hxx
@@ -27,6 +27,7 @@
 #include 
 #include 
 #include 
+#include 
 
 namespace com::sun::star::uno { class XComponentContext; }
 namespace svx { class ToolboxButtonColorUpdaterBase; }
@@ -86,6 +87,9 @@ public:
 bool GetLumModOff(sal_uInt16 nThemeIndex, sal_uInt16 nEffect, sal_Int16& 
rLumMod, sal_Int16& rLumOff);
 
 static void DispatchColorCommand(const OUString& aCommand, const 
NamedColor& rColor);
+
+/// Appends node for Document Colors into the ptree
+static void generateJSON(boost::property_tree::ptree& aTree, const 
std::set& rColors);
 };
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/svx/theme/IThemeColorChanger.hxx 
b/include/svx/theme/IThemeColorChanger.hxx
index 0b3b88d60afa..035494f12324 100644
--- a/include/svx/theme/IThemeColorChanger.hxx
+++ b/include/svx/theme/IThemeColorChanger.hxx
@@ -22,7 +22,7 @@ public:
 void apply(std::shared_ptr const& pColorSet)
 {

[Bug 158914] Calc leaks RAM in response to any action

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158914

--- Comment #7 from Allen Belletti  ---
It turns out that @kdub is absolutely correct. I use a Logitech Marble Mouse
(the trackball) and in order to enable quick scrolling, I've been running a
little tool called "Smart Scroll" (https://www.marcmoini.com/sx_en.html) for
years. Long enough to mostly forget it's there.

Smart Scroll has 7 main functions (with many options under each.) Two of them,
"Hover Scroll" and "Auto Scroll" seem to trigger this behavior merely by being
enabled. The rest do not, as far as I can tell. Fortunately I'm only using
"Grab Scroll" which can be enabled with no harmful effects.

For my situation, this constitutes a fix. I've exercised Calc a considerable
amount over the last couple of days and memory usage stays where it ought.
~230MB in the case of my most important document. Granted, Visicalc ran in 48K
but it was hardly feature complete by modern standards. ;-)

I'm going to reach out to the author of Smart Scroll and let him know what I've
found. Perhaps the fact that it shows up with two specific features but not
others will provide some sort of hint as to what's happening.

Meanwhile, this does feel a bit like a "double bug", ie, a bug in Smart Scroll
triggering another in Calc. I say that only because none of my other apps
(including LibreOffice Writer) have this reaction to Smart Scroll. On the other
hand, I'm not a front-end guy at all so this is pure speculation. I'll
understand if this is promptly closed.

Thanks for your time & attention!

Cheers,
Allen

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159175] 2 GB of ram used when clicking open new calc document 10 times

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159175

--- Comment #1 from Telesto  ---
On Windows:

567 mb for 10 windows with
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 25276df12abd9d002f7f899900434617b256f745
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL threaded

345MBB for 10 windows with 
Version: 7.6.3.0.0+ (X86_64) / LibreOffice Community
Build ID: 35f19e5cb93ce218787904e99c2bedfd40e725cc
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL threaded

370 MB with for 10 windows with
Version: 7.3.8.0.0+ (x64) / LibreOffice Community
Build ID: e1ad83ddb2f39419fb5d7c69eba51e2b9f49c788
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

555 mb for 10 windows with
Version: 7.3.0.0.alpha1+ (x64) / LibreOffice Community
Build ID: 229123ccc6f90ebf66b3e659bebbd53f8a9bdd3a
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159172] LO crashes on Run macro, if extension installed for user

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159172

Julien Nabet  changed:

   What|Removed |Added

   Keywords||haveBacktrace
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159172] LO crashes on Run macro, if extension installed for user

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159172

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #1 from Julien Nabet  ---
Created attachment 191964
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191964=edit
bt with debug symbols

On pc Debian x86-64 with master sources updated today, I got an assertion.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: vcl/unx

2024-01-15 Thread Julien Nabet (via logerrit)
 vcl/unx/gtk3/gtkdata.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b2ee028d0f805124d823a32aed70bcaf63377757
Author: Julien Nabet 
AuthorDate: Mon Jan 15 18:16:26 2024 +0100
Commit: Caolán McNamara 
CommitDate: Mon Jan 15 20:42:04 2024 +0100

Replace deprecated "gdk_cursor_unref" by "g_object_unref"

Change-Id: I593f5d8f0775e07e67cce66432bab52723f3afff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162116
Reviewed-by: Julien Nabet 
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/gtkdata.cxx b/vcl/unx/gtk3/gtkdata.cxx
index f595369f8b53..4c97e74aec01 100644
--- a/vcl/unx/gtk3/gtkdata.cxx
+++ b/vcl/unx/gtk3/gtkdata.cxx
@@ -69,7 +69,7 @@ GtkSalDisplay::~GtkSalDisplay()
 
 for(GdkCursor* & rpCsr : m_aCursors)
 if( rpCsr )
-gdk_cursor_unref( rpCsr );
+g_object_unref(rpCsr);
 #endif
 }
 


core.git: vcl/unx

2024-01-15 Thread Julien Nabet (via logerrit)
 vcl/unx/gtk3/glomenu.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1ca7f0abc04f7b6bfa098c305481cb6ae4cd5443
Author: Julien Nabet 
AuthorDate: Mon Jan 15 18:16:03 2024 +0100
Commit: Caolán McNamara 
CommitDate: Mon Jan 15 20:41:48 2024 +0100

Fix location of an g_object_unref in vcl/glomenu

Change-Id: Icef8e74867758c815e1a55ae0906dead9b70ae6d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162115
Reviewed-by: Julien Nabet 
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/glomenu.cxx b/vcl/unx/gtk3/glomenu.cxx
index a391649bbb6d..779d20f9b879 100644
--- a/vcl/unx/gtk3/glomenu.cxx
+++ b/vcl/unx/gtk3/glomenu.cxx
@@ -560,8 +560,8 @@ g_lo_menu_new_submenu_in_item_in_section (GLOMenu *menu,
 
 g_menu_model_items_changed (G_MENU_MODEL (model), position, 1, 1);
 
-g_object_unref (model);
 }
+g_object_unref (model);
 }
 
 GLOMenu *


[Bug 159189] Cropping rectangles missing on left hand side middle and bottom

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159189

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #2 from Julien Nabet  ---
On pc Debian x86-64 with LO Debian package 7.6.4 + gen rendering, I don't
reproduce this.

Could you try:
- upgrade to LO 7.6.4
- https://wiki.documentfoundation.org/QA/FirstSteps
?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159189] Cropping rectangles missing on left hand side middle and bottom

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159189

Julien Nabet  changed:

   What|Removed |Added

Summary|Cropping rectagles missing  |Cropping rectangles missing
   |on left hand side middle|on left hand side middle
   |und bottom  |and bottom

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 113423] [META] RTF (text) header and footer-related issues

2024-01-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113423
Bug 113423 depends on bug 125474, which changed state.

Bug 125474 Summary: FILEOPEN RTF Paragraph in frame gets extra spacing below
https://bugs.documentfoundation.org/show_bug.cgi?id=125474

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

  1   2   3   4   >