core.git: sw/qa sw/source
sw/qa/extras/htmlexport/htmlexport.cxx |8 ++--
sw/source/core/text/inftxt.cxx | 16
sw/source/core/text/itrpaint.cxx | 17 +
sw/source/core/text/porfly.hxx |1 +
4 files changed, 40 insertions(+), 2 deletions(-)
New commits:
commit 42876f0a99e2ae7cb7529dd7fb4d94c5e9298b21
Author: Mike Kaganski
AuthorDate: Tue Apr 30 22:16:12 2024 +0500
Commit: Mike Kaganski
CommitDate: Wed May 1 06:59:40 2024 +0200
tdf#160867: export as-char frames' hyperlinks to image map
Change-Id: Idc8d41a27c8ee9cdd12fb5e17a328ec6aa104a16
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166935
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sw/qa/extras/htmlexport/htmlexport.cxx
b/sw/qa/extras/htmlexport/htmlexport.cxx
index 329be9231bb9..1fc731b8b21d 100644
--- a/sw/qa/extras/htmlexport/htmlexport.cxx
+++ b/sw/qa/extras/htmlexport/htmlexport.cxx
@@ -3093,13 +3093,17 @@ CPPUNIT_TEST_FIXTURE(SwHtmlDomExportTest,
testHTML_160867)
CPPUNIT_ASSERT(pDoc);
assertXPath(pDoc, "/html/body/p"_ostr, 2);
-// Test export of text hyperlink in the image map. TODO: implement export
of image hyperlink.
+// Test export of image and text hyperlinks in the image map.
// Without the fix, the test would fail with
// - Expected: 1
// - Actual : 0
// - In <>, XPath '/html/body/p[2]/map' number of nodes is incorrect
const OUString mapName = getXPath(pDoc, "/html/body/p[2]/map"_ostr,
"name"_ostr);
-assertXPath(pDoc, "/html/body/p[2]/map/area"_ostr, "shape"_ostr,
u"rect"_ustr);
+assertXPath(pDoc, "/html/body/p[2]/map/area[1]"_ostr, "shape"_ostr,
u"rect"_ustr);
+CPPUNIT_ASSERT(
+getXPath(pDoc, "/html/body/p[2]/map/area[1]"_ostr,
"href"_ostr).endsWith("foo/bar"));
+assertXPath(pDoc, "/html/body/p[2]/map/area[2]"_ostr, "shape"_ostr,
u"rect"_ustr);
+CPPUNIT_ASSERT(getXPath(pDoc, "/html/body/p[2]/map/area[2]"_ostr,
"href"_ostr).endsWith("baz"));
assertXPath(pDoc, "/html/body/p[2]/img"_ostr, "usemap"_ostr, "#" +
mapName);
}
diff --git a/sw/source/core/text/inftxt.cxx b/sw/source/core/text/inftxt.cxx
index a1a3bb89a87b..ddcca31668db 100644
--- a/sw/source/core/text/inftxt.cxx
+++ b/sw/source/core/text/inftxt.cxx
@@ -44,6 +44,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -51,6 +52,7 @@
#include
#include "inftxt.hxx"
#include
+#include "porfly.hxx"
#include "porftn.hxx"
#include "porrst.hxx"
#include "itratr.hxx"
@@ -1479,6 +1481,20 @@ void SwTextPaintInfo::NotifyURL_(const SwLinePortion&
rPor) const
const SwFormatINetFormat& rFormat = pAttr->GetINetFormat();
pNoteURL->InsertURLNote(rFormat.GetValue(),
rFormat.GetTargetFrame(), aIntersect);
}
+else if (rPor.IsFlyCntPortion())
+{
+if (auto* pFlyContentPortion = dynamic_cast())
+{
+if (auto* pFlyFtame = pFlyContentPortion->GetFlyFrame())
+{
+if (auto* pFormat = pFlyFtame->GetFormat())
+{
+auto& url = pFormat->GetURL(); // TODO: url.GetMap() ?
+pNoteURL->InsertURLNote(url.GetURL(),
url.GetTargetFrameName(), aIntersect);
+}
+}
+}
+}
}
}
diff --git a/sw/source/core/text/itrpaint.cxx b/sw/source/core/text/itrpaint.cxx
index 8fa9ca45f5fd..f02beed8ce5b 100644
--- a/sw/source/core/text/itrpaint.cxx
+++ b/sw/source/core/text/itrpaint.cxx
@@ -33,6 +33,7 @@
#include
#include "txtpaint.hxx"
#include "porfld.hxx"
+#include "porfly.hxx"
#include "portab.hxx"
#include
#include
@@ -40,6 +41,7 @@
#include "porrst.hxx"
#include "pormulti.hxx"
#include
+#include
// Returns, if we have an underline breaking situation
// Adding some more conditions here means you also have to change them
@@ -461,6 +463,21 @@ void SwTextPainter::DrawTextLine( const SwRect ,
SwSaveClip ,
if (GetFnt()->IsURL() && pPor->InTextGrp())
GetInfo().NotifyURL(*pPor);
+else if (pPor->IsFlyCntPortion())
+{
+if (auto* pFlyContentPortion =
dynamic_cast(pPor))
+{
+if (auto* pFlyFrame = pFlyContentPortion->GetFlyFrame())
+{
+if (auto* pFormat = pFlyFrame->GetFormat())
+{
+auto& url = pFormat->GetURL();
+if (!url.GetURL().isEmpty()) // TODO: url.GetMap() ?
+GetInfo().NotifyURL(*pPor);
+}
+}
+}
+}
bFirst &= !pPor->GetLen();
if( pNext || !pPor->IsMarginPortion() )
diff --git a/sw/source/core/text/porfly.hxx b/sw/source/core/text/porfly.hxx
index a519c1109c87..2c56563a4436 100644
--- a/sw/source/core/text/porfly.hxx
+++ b/sw/source/core/text/porfly.hxx
@@ -76,6
[Bug 108014] [META] Writer character style bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108014 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||148949 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148949 [Bug 148949] Libreoffice crash when trying to delete the "Standard" character style using API. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 127592] [META] LibreOffice Basic macros incl."Option Compatible" modules
https://bugs.documentfoundation.org/show_bug.cgi?id=127592 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||148949 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148949 [Bug 148949] Libreoffice crash when trying to delete the "Standard" character style using API. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 148949] Libreoffice crash when trying to delete the "Standard" character style using API.
https://bugs.documentfoundation.org/show_bug.cgi?id=148949 Stéphane Guillou (stragu) changed: What|Removed |Added Version|3.3.0 release |Inherited From OOo CC||stephane.guillou@libreoffic ||e.org, ||vmik...@collabora.com Crash report or||["SwUndoFormatDelete::SwUnd crash signature||oFormatDelete","libswlo.so" ||] Blocks||127592, 108014 --- Comment #7 from Stéphane Guillou (stragu) --- Still reproduced in recent daily build: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: f4ef5435df5560e6b6b061ce4053c71e2819bf51 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: CL threaded Getting crash signature "libswlo.so" in 24.2.2: https://crashreport.libreoffice.org/stats/crash_details/9335bff0-065d-4fb3-8adc-6a1ecb80111f And "SwUndoFormatDelete::SwUndoFormatDelete" in 6.2.0.3 and 6.3.0.4: - https://crashreport.libreoffice.org/stats/crash_details/820f9935-060f-4ed7-b36d-c0e8298dbf1c - https://crashreport.libreoffice.org/stats/crash_details/550ba548-9293-459e-8592-dd8d68dda885 Running the same macro in 6.1.0.3 and earlier, it does not crash, and instead can't find the "Standard" character style: BASIC runtime error. An exception occurred Type: com.sun.star.container.NoSuchElementException Message: . Name "Standard" exists since: commit 9d754a59154c40235c240bb0e7f47a2006fa85bd author Miklos VajnaMon Jul 09 18:03:04 2018 +0200 committerMiklos VajnaMon Jul 09 20:04:26 2018 +0200 sw: give the 'Default Style' char style a programmatic name Reviewed-on: https://gerrit.libreoffice.org/57191 (this is [eaeddeb2c1de88ee0ee9f4be7316efefe0e44f24] in linux-64-6.2 bibisect repo) So one can crash it earlier than 6.2 by using e.g. "Default Style" instead. Back in OOo 3.3, it would be "Default" and would crash all the same. (Miklos, copying you in in case you're interested) Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108014 [Bug 108014] [META] Writer character style bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=127592 [Bug 127592] [META] LibreOffice Basic macros incl."Option Compatible" modules -- You are receiving this mail because: You are the assignee for the bug.
[Bug 127592] [META] LibreOffice Basic macros incl."Option Compatible" modules
https://bugs.documentfoundation.org/show_bug.cgi?id=127592 Stéphane Guillou (stragu) changed: What|Removed |Added Summary|[META] LibreOffice Basic|[META] LibreOffice Basic |incl."Option Compatible"|macros incl."Option |modules |Compatible" modules -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160739] Raise a matrix to an exponential with Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=160739 --- Comment #6 from xhertan --- Today I updated to version 24.2 and this error persists. Version: 24.2.2.1 (X86_64) Build ID: 420(Build:1) I noticed that this report remains UNCONFIRMED. Any progress on this? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156807] LibreOffice Calc and Writer - button and input line decoration offset, rendered on canvas
https://bugs.documentfoundation.org/show_bug.cgi?id=156807 Stéphane Guillou (stragu) changed: What|Removed |Added Summary|Libreoffice calc and writer |LibreOffice Calc and Writer |- gray marks on interface |- button and input line |rendering |decoration offset, rendered ||on canvas Blocks||112286 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=112286 [Bug 112286] [META] gtk3 themeing -- You are receiving this mail because: You are the assignee for the bug.
[Bug 112286] [META] gtk3 themeing
https://bugs.documentfoundation.org/show_bug.cgi?id=112286 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||156807 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=156807 [Bug 156807] LibreOffice Calc and Writer - button and input line decoration offset, rendered on canvas -- You are receiving this mail because: You are the assignee for the bug.
[Bug 133686] Crash or lag/freeze changing master slide on several slides (Linux with gen backend)
https://bugs.documentfoundation.org/show_bug.cgi?id=133686 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org Blocks||103460 Keywords||perf Summary|Crash or lag changing |Crash or lag/freeze |templates (Linux with gen |changing master slide on |backend)|several slides (Linux with ||gen backend) --- Comment #4 from Stéphane Guillou (stragu) --- Still struggling/hanging with gen VCL plugin; not reproduced with gtk3, kf5, win. Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: f4ef5435df5560e6b6b061ce4053c71e2819bf51 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: x11 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: CL threaded Telesto, can you still crash it? Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103460 [Bug 103460] [META] Master Slides deck/tab of the sidebar -- You are receiving this mail because: You are the assignee for the bug.
[Bug 103460] [META] Master Slides deck/tab of the sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=103460 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||133686 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=133686 [Bug 133686] Crash or lag/freeze changing master slide on several slides (Linux with gen backend) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160659] LibreOffice crashed while adding Google Drive service
https://bugs.documentfoundation.org/show_bug.cgi?id=160659 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160509] Modal Window on FILEOPEN for Read-Only (e.g. out of an eMail) SECOND file is hidden behind
https://bugs.documentfoundation.org/show_bug.cgi?id=160509 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160701] OpenPGP warning when encrypting with an untrusted public key: rename from "Error" to "Warning"
https://bugs.documentfoundation.org/show_bug.cgi?id=160701 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160694] One user interface does not have the same menu as another
https://bugs.documentfoundation.org/show_bug.cgi?id=160694 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160697] Writer opens blank window temporarily at launch
https://bugs.documentfoundation.org/show_bug.cgi?id=160697 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 113196] [META] Korean language-specific CJK issues
https://bugs.documentfoundation.org/show_bug.cgi?id=113196 Bug 113196 depends on bug 157280, which changed state. Bug 157280 Summary: Impress's parenthesis rendering is wrong on Korean texts https://bugs.documentfoundation.org/show_bug.cgi?id=157280 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157280] Impress's parenthesis rendering is wrong on Korean texts
https://bugs.documentfoundation.org/show_bug.cgi?id=157280 --- Comment #10 from QA Administrators --- Dear DaeHyun Sung, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156807] Libreoffice calc and writer - gray marks on interface rendering
https://bugs.documentfoundation.org/show_bug.cgi?id=156807 --- Comment #13 from QA Administrators --- Dear Barabba, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158042] FILEOPEN : PDF : Error when opening PDF file
https://bugs.documentfoundation.org/show_bug.cgi?id=158042 --- Comment #6 from QA Administrators --- Dear intmail01, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Bug 98162] Page-anchored image skips to edge when moved by mouse
https://bugs.documentfoundation.org/show_bug.cgi?id=98162 --- Comment #5 from QA Administrators --- Dear Stanislav Horacek, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157938] Possible missing font for %kappa in pdf with embedded fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=157938 --- Comment #2 from QA Administrators --- Dear Dan Brown, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Bug 129826] Storing language based user defined format codes of cells does not work for color code based entries.
https://bugs.documentfoundation.org/show_bug.cgi?id=129826 --- Comment #8 from QA Administrators --- Dear Ralf Hendel, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 132410] UI: Image properties Keep ratio is inherent from previous session
https://bugs.documentfoundation.org/show_bug.cgi?id=132410 --- Comment #5 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 148532] FILEOPEN RTF Line shapes anchored in table are positioned vertically lower than in Word
https://bugs.documentfoundation.org/show_bug.cgi?id=148532 --- Comment #3 from QA Administrators --- Dear Gabor Kelemen (allotropia), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 126873] Rotated text boxes have abnormally large hit area / hot zone
https://bugs.documentfoundation.org/show_bug.cgi?id=126873 --- Comment #13 from QA Administrators --- Dear DarkTrick, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 104009] Layout and visibility cell content changes while zooming out (with non-monospace fonts)
https://bugs.documentfoundation.org/show_bug.cgi?id=104009 --- Comment #8 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 141578] Libreoffice unusable with different scale factors used for different screens in multimonitor setup (on kf5/qt5/qt6 vcl + wayland)
https://bugs.documentfoundation.org/show_bug.cgi?id=141578 --- Comment #58 from typing...@gmail.com --- (In reply to Michael Weghorn from comment #45) > * The LO window is displayed properly on one of the screens at least, so > moving the window to that screen should be a functioning workaround. In my case, I have two monitors: 1080p (secondary) and 4K (main), and LO looks normal on the 1080p, and looks tiny on the 4K. So, "moving the window to that screen" is not really a good workaround, because I have to work on the small secondary monitor. Unless... there is a way to choose on which of the two monitors LO can look normal? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160878] Crash in: vcl::Window::ImplGetWinData()
https://bugs.documentfoundation.org/show_bug.cgi?id=160878 --- Comment #2 from Stéphane Guillou (stragu) --- (In reply to Stéphane Guillou (stragu) from comment #1) > Result: > - picture fits the margins automatically when inserted > - no crash Tested with: Version: 24.2.2.2 (X86_64) / LibreOffice Community Build ID: d56cc158d8a96260b836f100ef4b4ef25d6f1a01 CPU threads: 4; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160878] Crash in: vcl::Window::ImplGetWinData()
https://bugs.documentfoundation.org/show_bug.cgi?id=160878 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org OS|All |Windows (All) Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO Hardware|All |x86-64 (AMD64) --- Comment #1 from Stéphane Guillou (stragu) --- Thank you for the report, Ellen. I tested the following: 1. Open Writer 24.2.2 2. Insert this large PNG picture: https://upload.wikimedia.org/wikipedia/commons/thumb/e/e2/Large_Magellanic_Cloud_rendered_from_Gaia_EDR3.png/2048px-Large_Magellanic_Cloud_rendered_from_Gaia_EDR3.png 3. Make smaller using top right corner 4. Make smaller using bottom right corner Result: - picture fits the margins automatically when inserted - no crash If you are able to reproduce with more precise steps, and attach a sample document/image to use, it would be very much appreciated! Please also share the version info copied with the button in Help > About LibreOffice. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 115518] [META] Old user profile causing problems when upgrading to new release
https://bugs.documentfoundation.org/show_bug.cgi?id=115518 Bug 115518 depends on bug 160879, which changed state. Bug 160879 Summary: Find and replace only work in safe mode https://bugs.documentfoundation.org/show_bug.cgi?id=160879 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Bug 115518] [META] Old user profile causing problems when upgrading to new release
https://bugs.documentfoundation.org/show_bug.cgi?id=115518 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||160879 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160879 [Bug 160879] Find and replace only work in safe mode -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160879] Find and replace only work in safe mode
https://bugs.documentfoundation.org/show_bug.cgi?id=160879 Stéphane Guillou (stragu) changed: What|Removed |Added Resolution|--- |WORKSFORME Version|7.6.6.3 release |7.2.3.2 release Status|UNCONFIRMED |RESOLVED Blocks||115518 CC||stephane.guillou@libreoffic ||e.org --- Comment #2 from Stéphane Guillou (stragu) --- Thanks for the report, Ray. Let's mark as "works for me" as your issue is resolved after a full reinstall, and it will be difficult to investigate further without profiles to compare + knowledge of which LO version you were using before going from 6 to 7. For good measure I tested: 1. create a new user profile with LO 6.4.8+ (linux-64-6.4 bibisect repo's master) 2. copy across that profile to an installation of LO 7.2.8+ (linux-64-7.2 bibisect repo's master) 3. Test Ctrl + H with Writer 7.2: it works. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115518 [Bug 115518] [META] Old user profile causing problems when upgrading to new release -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160880] Poor visibility of enabled menu items in dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=160880 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #2 from Stéphane Guillou (stragu) --- Thanks for the report. Which Windows theme are you using? Looks like the same issue as bug 152534. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160879] Find and replace only work in safe mode
https://bugs.documentfoundation.org/show_bug.cgi?id=160879 --- Comment #1 from Ray Shain --- The bug originally appeared after an update. I just completely deleted Libre Office from my machine, including Appdata entries but without editing the registry. I then did a clean install, and find and replace works in normal mode. This seems to indicate some issue with the automating scripts in the upgrade process of the install program. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160880] Poor visibility of enabled menu items in dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=160880 ZhongLi changed: What|Removed |Added CC||ryanjiang2...@21cn.com --- Comment #1 from ZhongLi --- Created attachment 193914 --> https://bugs.documentfoundation.org/attachment.cgi?id=193914=edit Unreadable Text image -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160880] New: Poor visibility of enabled menu items in dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=160880 Bug ID: 160880 Summary: Poor visibility of enabled menu items in dark mode Product: LibreOffice Version: 24.2.0.0 alpha0+ Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: enhancement Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ryanjiang2...@21cn.com Description: in Writer, I chose the tabstrip layout, and it turns out that the light yellow background of the enabled items and the white text makes it hard to read. I am using this version of LibreOffice Version: 24.2.2.2 (X86_64) / LibreOffice Community Build ID: d56cc158d8a96260b836f100ef4b4ef25d6f1a01 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win Locale: zh-CN (zh_CN); UI: zh-CN Calc: CL threaded Steps to Reproduce: 1. Open Writer in dark mode 2. choose Tabstrip UI mode 3. Click on any tabstrip with an enabled item Actual Results: "Enabled" items were shown with a white font on a light yellow background, making the text unreadable Expected Results: The text become black or the background become dark blue, etc, making the text more clear. Reproducible: Always User Profile Reset: Yes Additional Info: Version: 24.2.2.2 (X86_64) / LibreOffice Community Build ID: d56cc158d8a96260b836f100ef4b4ef25d6f1a01 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win Locale: zh-CN (zh_CN); UI: zh-CN Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160879] New: Find and replace only work in safe mode
https://bugs.documentfoundation.org/show_bug.cgi?id=160879 Bug ID: 160879 Summary: Find and replace only work in safe mode Product: LibreOffice Version: 7.6.6.3 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: raysh...@gmail.com Created attachment 193913 --> https://bugs.documentfoundation.org/attachment.cgi?id=193913=edit Windows config from about This problem occurs in version 7.6.6.3, and in the prior version I was using, 7.2.3.2. When in normal mode, neither clicking the find and replace menu item under edit nor the keyboard CTRL-H will bring up the find and replace dialog window. When I reopen Writer in safe mode, all works as intended. My machine info is attached as windows spec.jpg. I have no user installed extensions in writer. I've restarted in safe mode, resetting my entire user profile to factory settings and archiving my old profile. After testing find and replace successfully, I've restarted in normal mode, saving as appropriate, and the function again fails to appear when selected. I first noticed this issue when I went from version 6 to version 7. I was trying to wait for a fix in later versions, but the same thing happens after each update. -- You are receiving this mail because: You are the assignee for the bug.
core.git: vcl/jsdialog
vcl/jsdialog/enabled.cxx |8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
New commits:
commit ce454f382d0d005dd3de021c7820be3ffa0bb582
Author: Tomaž Vajngerl
AuthorDate: Tue Apr 30 12:48:40 2024 +0900
Commit: Tomaž Vajngerl
CommitDate: Wed May 1 03:51:22 2024 +0200
jsdialog: enable a11y checker sidebar
Change-Id: I46f276f16ded08a55b6672d92c39924ec3c4a628
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166881
Reviewed-by: Tomaž Vajngerl
Tested-by: Jenkins
diff --git a/vcl/jsdialog/enabled.cxx b/vcl/jsdialog/enabled.cxx
index c7973fad4d57..fd05cc3ff569 100644
--- a/vcl/jsdialog/enabled.cxx
+++ b/vcl/jsdialog/enabled.cxx
@@ -327,7 +327,7 @@ bool isBuilderEnabledForPopup(std::u16string_view rUIFile)
bool isBuilderEnabledForSidebar(std::u16string_view rUIFile)
{
-if (// scalc
+return // scalc
rUIFile == u"modules/scalc/ui/functionpanel.ui"
|| rUIFile == u"modules/scalc/ui/navigatorpanel.ui"
|| rUIFile == u"modules/scalc/ui/sidebaralignment.ui"
@@ -354,6 +354,7 @@ bool isBuilderEnabledForSidebar(std::u16string_view rUIFile)
|| rUIFile == u"modules/smath/ui/sidebarelements_math.ui"
|| rUIFile == u"modules/smath/ui/sidebarproperties_math.ui"
// swriter
+|| rUIFile == u"modules/swriter/ui/a11ycheckissuespanel.ui"
|| rUIFile == u"modules/swriter/ui/managechangessidebar.ui"
|| rUIFile == u"modules/swriter/ui/navigatorpanel.ui"
|| rUIFile == u"modules/swriter/ui/pagefooterpanel.ui"
@@ -383,10 +384,7 @@ bool isBuilderEnabledForSidebar(std::u16string_view
rUIFile)
|| rUIFile == u"svx/ui/sidebarpossize.ui"
|| rUIFile == u"svx/ui/sidebarshadow.ui"
|| rUIFile == u"svx/ui/sidebarstylespanel.ui"
-|| rUIFile == u"svx/ui/sidebartextpanel.ui")
-return true;
-
-return false;
+|| rUIFile == u"svx/ui/sidebartextpanel.ui";
}
bool isInterimBuilderEnabledForNotebookbar(std::u16string_view rUIFile)
[Bug 160878] New: Crash in: vcl::Window::ImplGetWinData()
https://bugs.documentfoundation.org/show_bug.cgi?id=160878 Bug ID: 160878 Summary: Crash in: vcl::Window::ImplGetWinData() Product: LibreOffice Version: 24.2.2.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ellen.sann...@alumni.stanford.edu This bug was filed from the crash reporting server and is br-174bc3b2-33dd-48fe-9de6-174e9ebe5259. = I was resizing a photo that I had added to my document because it did not fit within the margins. I change it from the top the first time using the right corner arrow to proportionally shorten the photo. Then I looked at the bottom of the page and the picture was still too long for the page. I attempted to resize the photo from the bottom right and it crashed. The photo was a .png of white text on a black background. FORMATTING -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160873] Usability: "OLE Object" probably not familiar language (Menu: Insert/OLE Object)
https://bugs.documentfoundation.org/show_bug.cgi?id=160873 Stéphane Guillou (stragu) changed: What|Removed |Added Component|Writer |UI --- Comment #2 from Stéphane Guillou (stragu) --- (changed component to "UI" because it would have to be changed outside of Writer too, e.g. in Calc) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160873] Usability: "OLE Object" probably not familiar language (Menu: Insert/OLE Object)
https://bugs.documentfoundation.org/show_bug.cgi?id=160873 Stéphane Guillou (stragu) changed: What|Removed |Added Component|Writer |UI --- Comment #2 from Stéphane Guillou (stragu) --- (changed component to "UI" because it would have to be changed outside of Writer too, e.g. in Calc) -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 85811] [META] Main menu bar bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=85811 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||160873 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160873 [Bug 160873] Usability: "OLE Object" probably not familiar language (Menu: Insert/OLE Object) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160873] Usability: "OLE Object" probably not familiar language (Menu: Insert/OLE Object)
https://bugs.documentfoundation.org/show_bug.cgi?id=160873 Stéphane Guillou (stragu) changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||stephane.guillou@libreoffic ||e.org Blocks||85811 --- Comment #1 from Stéphane Guillou (stragu) --- In essence, I agree that users might not use that submenu because of how obscure the name is to them. But if we go further and actually rename from "OLE object" to something else, there are many places where the term is used, including the Navigator. And then there's hundreds of updates for help pages and guides. How would one differentiate OLE objects from others then? It would have to be more verbose, like "Linked or Embedded Objects". So I guess my opinion is: OK to not use "OLE" in the menu, but against changing it to something else elsewhere. (In reply to jan d from comment #0) > I could not find out if QR-Code actually uses OLE, > since there is no editing capability exposed and the result seems to be > handeled as an image, which is what OLE actually should overcome. I was actually wondering about that. Seems like QR/Barcode shouldn't be in there anyway. And when the feature was recently shared on social media, users were surprised it was so hidden away. +1 to pull those out of the OLE submenu if possible, or use a more intuitive categorisation so it doesn't get too big. (It's already the biggest menu in Writer with View and Format.) Also: chart is not in the OLE submenu, but it is an OLE object! Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=85811 [Bug 85811] [META] Main menu bar bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160873] Usability: "OLE Object" probably not familiar language (Menu: Insert/OLE Object)
https://bugs.documentfoundation.org/show_bug.cgi?id=160873 Stéphane Guillou (stragu) changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||stephane.guillou@libreoffic ||e.org Blocks||85811 --- Comment #1 from Stéphane Guillou (stragu) --- In essence, I agree that users might not use that submenu because of how obscure the name is to them. But if we go further and actually rename from "OLE object" to something else, there are many places where the term is used, including the Navigator. And then there's hundreds of updates for help pages and guides. How would one differentiate OLE objects from others then? It would have to be more verbose, like "Linked or Embedded Objects". So I guess my opinion is: OK to not use "OLE" in the menu, but against changing it to something else elsewhere. (In reply to jan d from comment #0) > I could not find out if QR-Code actually uses OLE, > since there is no editing capability exposed and the result seems to be > handeled as an image, which is what OLE actually should overcome. I was actually wondering about that. Seems like QR/Barcode shouldn't be in there anyway. And when the feature was recently shared on social media, users were surprised it was so hidden away. +1 to pull those out of the OLE submenu if possible, or use a more intuitive categorisation so it doesn't get too big. (It's already the biggest menu in Writer with View and Format.) Also: chart is not in the OLE submenu, but it is an OLE object! Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=85811 [Bug 85811] [META] Main menu bar bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 160732] Rename "Navigation" toolbar to clarify its role, avoid confusion, and relate to "Navigate by - Recency"
https://bugs.documentfoundation.org/show_bug.cgi?id=160732 --- Comment #12 from Stéphane Guillou (stragu) --- (In reply to V Stuart Foote from comment #11) > (In reply to Eyal Rozenberg from comment #10) > > How about "Navigate History" or "Navigate Positions"? > I think the idea is to remove navigate/navigation/navigator from the mix and > avoid any potential to misidentify. Indeed, and it has the added benefit of being able to use the same string in Navigate By (without repeating "Navigate"). I think we need both "history" for the familiarity with browsers, and "position" to clarify it's about cursor position (and not age of objects). -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160732] Rename "Navigation" toolbar to clarify its role, avoid confusion, and relate to "Navigate by - Recency"
https://bugs.documentfoundation.org/show_bug.cgi?id=160732 --- Comment #12 from Stéphane Guillou (stragu) --- (In reply to V Stuart Foote from comment #11) > (In reply to Eyal Rozenberg from comment #10) > > How about "Navigate History" or "Navigate Positions"? > I think the idea is to remove navigate/navigation/navigator from the mix and > avoid any potential to misidentify. Indeed, and it has the added benefit of being able to use the same string in Navigate By (without repeating "Navigate"). I think we need both "history" for the familiarity with browsers, and "position" to clarify it's about cursor position (and not age of objects). -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 155633] Can't use a custom bibliography database source for Insert > TOC & Indexes > Bibliography Entry
https://bugs.documentfoundation.org/show_bug.cgi?id=155633 Stéphane Guillou (stragu) changed: What|Removed |Added Status|NEEDINFO|NEW -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160732] Rename "Navigation" toolbar to clarify its role, avoid confusion, and relate to "Navigate by - Recency"
https://bugs.documentfoundation.org/show_bug.cgi?id=160732 --- Comment #11 from V Stuart Foote --- (In reply to Eyal Rozenberg from comment #10) > How about "Navigate History" or "Navigate Positions"? > > I'm also ok with "Position History", although I like that less. I think the idea is to remove navigate/navigation/navigator from the mix and avoid any potential to misidentify. "Position History" seems to work best in that context. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 160732] Rename "Navigation" toolbar to clarify its role, avoid confusion, and relate to "Navigate by - Recency"
https://bugs.documentfoundation.org/show_bug.cgi?id=160732 --- Comment #11 from V Stuart Foote --- (In reply to Eyal Rozenberg from comment #10) > How about "Navigate History" or "Navigate Positions"? > > I'm also ok with "Position History", although I like that less. I think the idea is to remove navigate/navigation/navigator from the mix and avoid any potential to misidentify. "Position History" seems to work best in that context. -- You are receiving this mail because: You are the assignee for the bug.
core.git: sw/source
sw/source/writerfilter/dmapper/GraphicImport.cxx |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
New commits:
commit bc7501d30ab9a3a5edec66d2f0022177f85d6127
Author: Justin Luth
AuthorDate: Sat Apr 20 19:45:39 2024 -0400
Commit: Justin Luth
CommitDate: Wed May 1 00:44:37 2024 +0200
NFC GraphicImport.cxx: address nit x2
less emphasis on minimizing "if logic"
and more emphasis on readability
(especially since the comment comes after the logic).
In the most common cases, this version
should actually finish sooner too.
I didn't remember doing a copy/paste,
so the first time I only fixed the one instance...
Change-Id: I71deded7da16fd4aef2d7f5ab9f777b616312eca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166379
Reviewed-by: Justin Luth
Tested-by: Jenkins
diff --git a/sw/source/writerfilter/dmapper/GraphicImport.cxx
b/sw/source/writerfilter/dmapper/GraphicImport.cxx
index 0320c671c47f..3a60e63dbefb 100644
--- a/sw/source/writerfilter/dmapper/GraphicImport.cxx
+++ b/sw/source/writerfilter/dmapper/GraphicImport.cxx
@@ -1304,9 +1304,10 @@ void GraphicImport::lcl_attribute(Id nName, Value&
rValue)
}
if (m_pImpl->m_nHoriRelation ==
text::RelOrientation::FRAME
-&& m_pImpl->m_nHoriOrient >
text::HoriOrientation::NONE
-&& m_pImpl->m_nHoriOrient !=
text::HoriOrientation::CENTER
-&& m_pImpl->m_nHoriOrient <
text::HoriOrientation::FULL)
+&& (m_pImpl->m_nHoriOrient ==
text::HoriOrientation::LEFT
+|| m_pImpl->m_nHoriOrient ==
text::HoriOrientation::RIGHT
+|| m_pImpl->m_nHoriOrient ==
text::HoriOrientation::INSIDE
+|| m_pImpl->m_nHoriOrient ==
text::HoriOrientation::OUTSIDE))
{
// before compat15, relative
left/right/inside/outside honored margins.
if
(m_pImpl->m_rDomainMapper.GetSettingsTable()->GetWordCompatibilityMode() < 15)
[Bug 160810] Writer: comment thread broken for comments without selected text
https://bugs.documentfoundation.org/show_bug.cgi?id=160810 Timur changed: What|Removed |Added Summary|Writer: comment thread |Writer: comment thread |broken |broken for comments without ||selected text -- You are receiving this mail because: You are the assignee for the bug.
core.git: sc/inc sc/qa sc/source
sc/inc/document.hxx |2
sc/inc/queryiter.hxx|2
sc/inc/rangecache.hxx |3
sc/qa/unit/data/functions/spreadsheet/fods/xlookup.fods | 678 +++-
sc/source/core/data/documen2.cxx|4
sc/source/core/data/queryiter.cxx | 79 -
sc/source/core/tool/interpr1.cxx|9
sc/source/core/tool/rangecache.cxx | 43 -
8 files changed, 384 insertions(+), 436 deletions(-)
New commits:
commit e2c9d38d95a1a0b5cf754fb04f2fd73c6ddb8004
Author: Balazs Varga
AuthorDate: Sun Apr 21 13:39:58 2024 +0200
Commit: Balazs Varga
CommitDate: Tue Apr 30 23:32:49 2024 +0200
tdf#160725 - Fix XLOOKUP has different result for approximate
search than Excel.
Some rework for xlookup binary search in rows to get the correct results
when we are searching with binary mode in rows.
Change-Id: I7ef710c4ae638e2cf5d4bee45810cec7057f5d4b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166451
Reviewed-by: Balazs Varga
Tested-by: Jenkins
diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index d9c3f1866947..4dbce67d2928 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -1413,7 +1413,7 @@ public:
doesn't already exist. */
ScLookupCache & GetLookupCache( const ScRange & rRange,
ScInterpreterContext* pContext );
ScSortedRangeCache & GetSortedRangeCache( const ScRange & rRange, const
ScQueryParam& param,
- ScInterpreterContext* pContext );
+ ScInterpreterContext* pContext,
sal_uInt8 nSortedBinarySearch = 0x00 );
/** Only ScLookupCache dtor uses RemoveLookupCache(), do
not use elsewhere! */
voidRemoveLookupCache( ScLookupCache & rCache );
diff --git a/sc/inc/queryiter.hxx b/sc/inc/queryiter.hxx
index 2d54b40c469c..c6cd1906a4fb 100644
--- a/sc/inc/queryiter.hxx
+++ b/sc/inc/queryiter.hxx
@@ -103,7 +103,7 @@ public:
protected:
ScQueryCellIteratorAccessSpecific( ScDocument& rDocument,
ScInterpreterContext& rContext,
const ScQueryParam& rParam, bool bReverseSearch );
-void InitPosStart();
+void InitPosStart(sal_uInt8 nSortedBinarySearch = 0x00);
void InitPosFinish( SCROW beforeRow, SCROW lastRow, bool bFirstMatch );
void IncPos() { IncPosImpl(); }
bool IncPosFast() { return IncPosImpl(); }
diff --git a/sc/inc/rangecache.hxx b/sc/inc/rangecache.hxx
index c65e8653a458..bca9554a5e6a 100644
--- a/sc/inc/rangecache.hxx
+++ b/sc/inc/rangecache.hxx
@@ -46,7 +46,8 @@ class ScSortedRangeCache final : public SvtListener
public:
/// MUST be new'd because Notify() deletes.
ScSortedRangeCache(ScDocument* pDoc, const ScRange& rRange, const
ScQueryParam& param,
- ScInterpreterContext* context, bool invalid = false);
+ ScInterpreterContext* context, bool invalid = false,
+ sal_uInt8 nSortedBinarySearch = 0x00);
/// Returns if the cache is usable.
bool isValid() const { return mValid; }
diff --git a/sc/qa/unit/data/functions/spreadsheet/fods/xlookup.fods
b/sc/qa/unit/data/functions/spreadsheet/fods/xlookup.fods
index 8da1a44240bd..41a5789f73a1 100644
--- a/sc/qa/unit/data/functions/spreadsheet/fods/xlookup.fods
+++ b/sc/qa/unit/data/functions/spreadsheet/fods/xlookup.fods
@@ -1,7 +1,7 @@
http://openoffice.org/2004/office;
xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0"
xmlns:xlink="http://www.w3.org/1999/xlink;
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0"
xmlns:dc="http://purl.org/dc/elements/1.1/;
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0"
xmlns:style="urn:oasis:names:tc:opendocument:xmlns:style:1.0"
xmlns:text="urn:oasis:names:tc:opendocument:xmlns:text:1.0"
xmlns:rpt="http://openoffice.org/2005/report;
xmlns:draw="urn:oasis:names:tc:opendocument:xmlns:drawing:1.0"
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0"
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0"
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0"
xmlns:table="urn:oasis:names:tc:opendocument:xmlns:table:1.0"
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0"
xmlns:ooow="http://openoffice.org/200
4/writer" xmlns:oooc="http://openoffice.org/2004/calc;
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2"
xmlns:xforms="http://www.w3.org/2002/xforms;
xmlns:tableooo="http://openoffice.org/2009/table;
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
xmlns:drawooo="http://openoffice.org/2010/draw;
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
[Bug 160877] New: Paragraph Signature deleted after visualizing printout or when opening (paragraph signed) file
https://bugs.documentfoundation.org/show_bug.cgi?id=160877 Bug ID: 160877 Summary: Paragraph Signature deleted after visualizing printout or when opening (paragraph signed) file Product: LibreOffice Version: 24.2.2.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: framework Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: olivier.hal...@libreoffice.org Blocks: 123810 Summary: After signing several paragraphs, print visualization remove all signatures. Steps: 1) create a new text file 2) add text 3) Sign paragraph 4) Visualize printout 5) close visualization Results: all paragraph signatures are gone Expected results: all signatures maintained. Similar issue when opening writer file 1) sign paragraph in a text files 2) save 3) close file 4) open file Results: all paragraph signatures are gone Expected results: all signatures preserved. Version: 24.2.2.2 (X86_64) / LibreOffice Community Build ID: d56cc158d8a96260b836f100ef4b4ef25d6f1a01 CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: pt-BR Calc: threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=123810 [Bug 123810] [META] Classification bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 123810] [META] Classification bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=123810 Olivier Hallot changed: What|Removed |Added Depends on||160877 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160877 [Bug 160877] Paragraph Signature deleted after visualizing printout or when opening (paragraph signed) file -- You are receiving this mail because: You are the assignee for the bug.
[Bug 85094] When printing ODT with mixed portrait and landscape, last page has incorrect orientation
https://bugs.documentfoundation.org/show_bug.cgi?id=85094
Julien Nabet changed:
What|Removed |Added
CC||serval2...@yahoo.fr
--- Comment #18 from Julien Nabet ---
Just for the record, if I use this patch to revert print part in old Armin's
patch:
diff --git a/vcl/source/gdi/print.cxx b/vcl/source/gdi/print.cxx
index 06625a4227bd..dbdf8c9bafe2 100644
--- a/vcl/source/gdi/print.cxx
+++ b/vcl/source/gdi/print.cxx
@@ -1307,23 +1307,10 @@ bool Printer::SetPaperSizeUser( const Size& rSize )
const Size aPixSize = LogicToPixel( rSize );
const Size aPageSize = PixelToLogic(aPixSize,
MapMode(MapUnit::Map100thMM));
-bool bNeedToChange(maJobSetup.ImplGetConstData().GetPaperWidth() !=
aPageSize.Width() ||
-maJobSetup.ImplGetConstData().GetPaperHeight() != aPageSize.Height());
-
-if(!bNeedToChange)
-{
-// #i122984# only need to change when Paper is different from
PAPER_USER and
-// the mapped Paper which will created below in the call to
ImplFindPaperFormatForUserSize
-// and will replace maJobSetup.ImplGetConstData()->GetPaperFormat().
This leads to
-// unnecessary JobSetups, e.g. when printing a multi-page fax, but
also with
-// normal print
-const Paper aPaper = ImplGetPaperFormat(aPageSize.Width(),
aPageSize.Height());
-
-bNeedToChange = maJobSetup.ImplGetConstData().GetPaperFormat() !=
PAPER_USER &&
-maJobSetup.ImplGetConstData().GetPaperFormat() != aPaper;
-}
-
-if(bNeedToChange)
+if ( (maJobSetup.ImplGetConstData().GetPaperFormat() != PAPER_USER) ||
+ (maJobSetup.ImplGetConstData().GetPaperWidth() != aPageSize.Width())
||
+ (maJobSetup.ImplGetConstData().GetPaperHeight() !=
aPageSize.Height())
+)
{
JobSetup aJobSetup = maJobSetup;
ImplJobSetup& rData = aJobSetup.ImplGetData();
preview in print dialog works well (first page in portrait, second in
landscape, third in portrait)
Also we've been using libtiff since 2022-05 so perhaps the whole patch is
obsolete.
"itiff.cxx" is now in vcl/source/filter/itiff and only contains 360 lines
"ccidecom.hxx" and "ccidecom.cxx" don't exist anymore in LO codebase.
To be sure, we'd need someone who has a fax and able to test a build with the
above patch, not simple I suppose...
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 155633] Can't use a custom bibliography database source for Insert > TOC & Indexes > Bibliography Entry
https://bugs.documentfoundation.org/show_bug.cgi?id=155633 --- Comment #4 from ajlittoz --- (In reply to Stéphane Guillou (stragu) from comment #3) > (In reply to ajlittoz from comment #2) > ajlittoz, do you agree these are the steps? Yes -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'distro/collabora/co-23.05' - configure.ac
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 47028e9e99e418d064c93bbb9c6d322f7e84c150 Author: Aron Budea AuthorDate: Tue Apr 30 23:06:13 2024 +0200 Commit: Aron Budea CommitDate: Tue Apr 30 23:06:13 2024 +0200 Bump version to 23.05.11.1 Change-Id: I334fcc501e067d6a7e11fda2931228c97b3aa424 diff --git a/configure.ac b/configure.ac index ea178f56c8e4..bae560edb635 100644 --- a/configure.ac +++ b/configure.ac @@ -9,7 +9,7 @@ dnl in order to create a configure script. # several non-alphanumeric characters, those are split off and used only for the # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no idea. -AC_INIT([Collabora Office],[23.05.10.1],[],[],[https://collaboraoffice.com/]) +AC_INIT([Collabora Office],[23.05.11.1],[],[],[https://collaboraoffice.com/]) dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just fine if it is installed dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails hard
[Bug 160836] unable to resize table row height with mouse, if contains an image which cropped by the fixed row height
https://bugs.documentfoundation.org/show_bug.cgi?id=160836 --- Comment #3 from Commit Notification --- László Németh committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/38b6e89c9483fdfe3d26bef3b25f890528aef84e tdf#160836 sw: fix narrow selection area of cell border It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
core.git: sw/source
sw/source/uibase/docvw/edtwin.cxx |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
New commits:
commit 38b6e89c9483fdfe3d26bef3b25f890528aef84e
Author: László Németh
AuthorDate: Mon Apr 29 21:39:41 2024 +0200
Commit: László Németh
CommitDate: Tue Apr 30 23:02:01 2024 +0200
tdf#160836 sw: fix narrow selection area of cell border
Remove ShouldObjectBeSelected() condition to fix the
selection area around the horizontal border. (Its purpose
was to avoid of selection of the border, when covered by
an image: but that would be !ShouldObjectBeSelected(), with
the same problem: halved selection area.)
Clean-up commit commit 30de13743f144aced83bc43d310592f82788c910
"tdf#160836 sw: resize rows at images cropped by row height".
Change-Id: I6c812a150b67431c7ea3131f29489bda919c1724
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166877
Tested-by: Jenkins
Reviewed-by: László Németh
diff --git a/sw/source/uibase/docvw/edtwin.cxx
b/sw/source/uibase/docvw/edtwin.cxx
index c0d4a0837f17..b50c67811774 100644
--- a/sw/source/uibase/docvw/edtwin.cxx
+++ b/sw/source/uibase/docvw/edtwin.cxx
@@ -3159,8 +3159,7 @@ void SwEditWin::MouseButtonDown(const MouseEvent& _rMEvt)
SwTab::COL_NONE != (nMouseTabCol = rSh.WhichMouseTabCol( aDocPos ) )
&&
( !rSh.IsObjSelectable( aDocPos ) ||
// allow resizing row height, if the image is anchored as
character in the cell
- ( rSh.ShouldObjectBeSelected(aDocPos) &&
- !( SwTab::COL_VERT == nMouseTabCol || SwTab::COL_HORI ==
nMouseTabCol ) ) ) )
+ !( SwTab::COL_VERT == nMouseTabCol || SwTab::COL_HORI ==
nMouseTabCol ) ) )
{
// Enhanced table selection
if ( SwTab::SEL_HORI <= nMouseTabCol && SwTab::COLSEL_VERT >=
nMouseTabCol )
@@ -4033,8 +4032,7 @@ bool SwEditWin::changeMousePointer(Point const &
rDocPoint)
if ( SwTab::COL_NONE != (nMouseTabCol = rShell.WhichMouseTabCol( rDocPoint
) ) &&
( !rShell.IsObjSelectable( rDocPoint ) ||
// allow resizing row height, if the image is anchored as
character in the cell
- ( rShell.ShouldObjectBeSelected(rDocPoint) &&
- !( SwTab::COL_VERT == nMouseTabCol || SwTab::COL_HORI ==
nMouseTabCol ) ) ) )
+ !( SwTab::COL_VERT == nMouseTabCol || SwTab::COL_HORI ==
nMouseTabCol ) ) )
{
PointerStyle nPointer = PointerStyle::Null;
bool bChkTableSel = false;
[Bug 160870] Continues footnote number is flipped
https://bugs.documentfoundation.org/show_bug.cgi?id=160870 ardv changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.
[Bug 56408] Writer always breaks lines at text direction change, leaving orphan bracket
https://bugs.documentfoundation.org/show_bug.cgi?id=56408 خالد حسني changed: What|Removed |Added CC||kava...@yahoo.com --- Comment #27 from خالد حسني --- *** Bug 160854 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160854] in Arabic right to left text parenthesis will be broke
https://bugs.documentfoundation.org/show_bug.cgi?id=160854 خالد حسني changed: What|Removed |Added CC||kha...@libreoffice.org Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from خالد حسني --- *** This bug has been marked as a duplicate of bug 56408 *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160874] Calc fails to suggest correction for formula cell without equal sign
https://bugs.documentfoundation.org/show_bug.cgi?id=160874 --- Comment #3 from ady --- (In reply to ady from comment #2) > If this behavior is implemented, it would mean that instead of the current > suggestion (i.e. adding the apostrophe and changing the value from numerical > to text), the new behavior would silently skip any suggestion and would > automatically add the initial equal sign, turning the cell into a formula. I would like to suggest, if the request from comment 0 is implemented, instead of being silently and automatically converted into a formula, that a suggestion should still be presented, as it is currently the case (just with a different suggestion, converting the cell into a formula rather than into a text cell). A silent and automatic action would allow mistakes that would not be easy to spot in real time, especially when the current behavior would stop such mistake. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160876] New: user.documentfoundation.org account generation fails
https://bugs.documentfoundation.org/show_bug.cgi?id=160876 Bug ID: 160876 Summary: user.documentfoundation.org account generation fails Product: LibreOffice Version: 7.5.7.1 release Hardware: Other OS: macOS (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: dbaker...@dlbaker.us Description: I tried to create an account on user.documentfoundation.org, after getting sent there by LibreOffice Online Help. It seemed to go well until I tried to log in - only to find that what I had just entered was Invalid. Cheers or Jeers Actual Results: Invalid Account notice Expected Results: I expected it to work Reproducible: Didn't try User Profile Reset: No Additional Info: Accepted what I had just put into it. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160874] Calc fails to suggest correction for formula cell without equal sign
https://bugs.documentfoundation.org/show_bug.cgi?id=160874 --- Comment #2 from ady --- IMHO, there are enough issues with unary operators. If the cell contains a simple negative numeric value and users want to modify the cell to contain instead a formula, then the initial equal sign should also be (manually) added by the user. That's just my personal subjective opinion. Having Calc guessing the user's intention is nice, until each user wants the guess to be different. That's how we (users) get the "initial sometimes-hidden apostrophe" (which some users are unaware of, or don't understand its meaning), or "why this column in my csv file is imported as text instead of as numbers", or the exact opposite reports/questions. Now, if the request from comment 0 (to automatically add the equal sign when the user modifies a simple negative/positive numeric value, turning it into what could probably be interpreted as a formula), then all sorts of regression tests should be added too, in order to reduce follow-ups such as "my csv is imported differently now", or, if some other behavior is modified as a consequence, it should be clearly described too (instead of finding out just by chance, in the best case). If this behavior is implemented, it would mean that instead of the current suggestion (i.e. adding the apostrophe and changing the value from numerical to text), the new behavior would silently skip any suggestion and would automatically add the initial equal sign, turning the cell into a formula. When there is no additional operator edited, clicking on another cell should leave the original cell without change and the clicked-on cell would be the new active cell. This is the current behavior and should not change. Please note that the reported behavior happens not only with negative values, but with any numerical value. Please also note that the reported behavior happens only when editing existing numerical values. When the cell has no prior content (and it is not pre-formatted as text), then the initial equal sign is indeed automatically added when clicking on some other cell. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160875] New: Calc partially fails, requires computer restart
https://bugs.documentfoundation.org/show_bug.cgi?id=160875 Bug ID: 160875 Summary: Calc partially fails, requires computer restart Product: LibreOffice Version: 7.5.7.1 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: dbaker...@dlbaker.us 2023 Mac M2 mini, Sonoma 14.4.1 I tried to edit a graph in Calc, and the Format Axis box refused to allow me to change the number type. Clicking on the format types did not respond. Furthermore, About LibreOffice does not respond. Restarting LibreOffice doesn't work. I have to restart the computer. In the middle of my work. At least I was able to save it. -- You are receiving this mail because: You are the assignee for the bug.
core.git: bridges/source canvas/source extensions/source include/basegfx registry/source stoc/source
bridges/source/cpp_uno/msvc_win32_x86-64/except.cxx |1 +
canvas/source/directx/dx_canvasbitmap.cxx |1 +
extensions/source/scanner/twain32shim.cxx |1 +
include/basegfx/raster/rasterconvert3d.hxx |3 ++-
registry/source/regkey.cxx |2 +-
stoc/source/corereflection/criface.cxx |1 +
stoc/source/proxy_factory/proxyfac.cxx |8
7 files changed, 11 insertions(+), 6 deletions(-)
New commits:
commit a2623abe07c5fe369c6b7315ae53de3884750839
Author: Caolán McNamara
AuthorDate: Tue Apr 30 19:39:52 2024 +0100
Commit: Caolán McNamara
CommitDate: Tue Apr 30 22:04:11 2024 +0200
WaE: C6011 Dereferencing NULL pointer warnings
Change-Id: I498c10e8bc134b41e3606d8a05cf3103a9274735
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166937
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/bridges/source/cpp_uno/msvc_win32_x86-64/except.cxx
b/bridges/source/cpp_uno/msvc_win32_x86-64/except.cxx
index e5836dd11d98..7dd6df9cb6ce 100644
--- a/bridges/source/cpp_uno/msvc_win32_x86-64/except.cxx
+++ b/bridges/source/cpp_uno/msvc_win32_x86-64/except.cxx
@@ -410,6 +410,7 @@ RaiseInfo::RaiseInfo(typelib_TypeDescription* pTD) noexcept
// 32 bit offsets
const int totalSize = codeSize + typeInfoArraySize + excTypeAddLen;
unsigned char* pCode = _code = static_cast(std::malloc(totalSize));
+assert(pCode && "Don't handle OOM conditions");
int pCodeOffset = 0;
// New base of types array, starts after Trampoline D-Tor / C-Tors
diff --git a/canvas/source/directx/dx_canvasbitmap.cxx
b/canvas/source/directx/dx_canvasbitmap.cxx
index fb06288ada86..cfef86a536ec 100644
--- a/canvas/source/directx/dx_canvasbitmap.cxx
+++ b/canvas/source/directx/dx_canvasbitmap.cxx
@@ -208,6 +208,7 @@ namespace dxcanvas
const sal_Int32 nScanWidth((aSize.getWidth() + 3) & ~3);
std::unique_ptr pAlphaBits( new
sal_uInt8[nScanWidth*aSize.getHeight()] );
const sal_uInt8*
pInBits=static_cast(aBmpData.Scan0);
+assert(pInBits);
pInBits+=3;
for( sal_Int32 y=0; y(GlobalLock(aCap.hContainer));
+assert(pVal);
pVal->ItemType = TWTY_INT16;
pVal->Item = 1;
diff --git a/include/basegfx/raster/rasterconvert3d.hxx
b/include/basegfx/raster/rasterconvert3d.hxx
index 83f753e3184b..25cf2a333f06 100644
--- a/include/basegfx/raster/rasterconvert3d.hxx
+++ b/include/basegfx/raster/rasterconvert3d.hxx
@@ -21,6 +21,7 @@
#include
#include
+#include
#include
#include
@@ -395,7 +396,7 @@ namespace basegfx
{
bool operator()(const RasterConversionLineEntry3D* pA, const
RasterConversionLineEntry3D* pB)
{
-OSL_ENSURE(pA && pB, "lineComparator: empty pointer (!)");
+assert(pA && pB && "lineComparator: empty pointer (!)");
return pA->getX().getVal() < pB->getX().getVal();
}
};
diff --git a/registry/source/regkey.cxx b/registry/source/regkey.cxx
index b2eeb63e67a6..c9fc096eaf48 100644
--- a/registry/source/regkey.cxx
+++ b/registry/source/regkey.cxx
@@ -439,7 +439,7 @@ RegError REGISTRY_CALLTYPE getStringListValue(RegKeyHandle
hKey,
char*** pValueList,
sal_uInt32* pLen)
{
-OSL_PRECOND((pValueList != nullptr) && (pLen != nullptr),
"registry::getStringListValue(): invalid parameter");
+assert(pValueList != nullptr && pLen != nullptr &&
"registry::getStringListValue(): invalid parameter");
*pValueList = nullptr;
*pLen = 0;
diff --git a/stoc/source/corereflection/criface.cxx
b/stoc/source/corereflection/criface.cxx
index 23d3d9bae278..130ff546e278 100644
--- a/stoc/source/corereflection/criface.cxx
+++ b/stoc/source/corereflection/criface.cxx
@@ -508,6 +508,7 @@ Any SAL_CALL IdlInterfaceMethodImpl::invoke( const Any &
rObj, Sequence< Any > &
ppParamTypes[nPos] = nullptr;
TYPELIB_DANGER_GET( ppParamTypes + nPos, pParams[nPos].pTypeRef );
typelib_TypeDescription * pTD = ppParamTypes[nPos];
+assert(pTD);
ppUnoArgs[nPos] = alloca( pTD->nSize );
if (pParams[nPos].bIn)
diff --git a/stoc/source/proxy_factory/proxyfac.cxx
b/stoc/source/proxy_factory/proxyfac.cxx
index 6745d0163c70..a22bcc3fcafe 100644
--- a/stoc/source/proxy_factory/proxyfac.cxx
+++ b/stoc/source/proxy_factory/proxyfac.cxx
@@ -181,7 +181,7 @@ static void binuno_proxy_acquire( uno_Interface * pUnoI )
// rebirth of zombie
uno_ExtEnvironment * uno_env =
that->m_root->m_factory->m_uno_env.get()->pExtEnv;
-OSL_ASSERT( uno_env != nullptr );
+assert(uno_env != nullptr);
(*uno_env->registerProxyInterface)(
uno_env, reinterpret_cast< void
[Bug 158221] Insert bookmarks dialogue takes a very long time to appear when there are many bookmarks
https://bugs.documentfoundation.org/show_bug.cgi?id=158221 BogdanB changed: What|Removed |Added Regression By||Michael Stahl -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158221] Insert bookmarks dialogue takes a very long time to appear when there are many bookmarks
https://bugs.documentfoundation.org/show_bug.cgi?id=158221 --- Comment #5 from bdgri...@mailbolt.com --- Insert > Bookmark also fails for me in version 7.6.2.1 and also in the latest version 24.2. It looks like the same problem. I select Insert > Bookmark and just after the Bookmark dialog appears, the document starts paging through the pages on its own. This will go on for 15 minutes or so. If I don't want for it to finish and instead click on any of the document pages as it is flipping by, it freezes the paging, but displays a hourglass (blue rotating circle) and appears to hang with all of Writer controls being disabled. There are hundreds of pages in the document. The last version where Insert > Bookmarks WORKED for me was: Version: 7.4.7.2 (x64) / LibreOffice Community Build ID: 723314e595e8007d3cf785c16538505a1c878ca5 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: default; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded So a change must have been added after 7.4.7.2 that caused this problem. It has been nearly 6 months since this problem has been reported. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160324] Column resize handle touch-target too small
https://bugs.documentfoundation.org/show_bug.cgi?id=160324 --- Comment #7 from Eyal Rozenberg --- (In reply to jon.macca...@gmail.com from comment #0) > The column resize handle touch target is only 1-2px wide, It's at least 4 px wide, if not 5, for me. Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: ffccbf4762a9ae810bcdd21c41fccdd436e7bfc9 CPU threads: 4; OS: Linux 6.6; UI render: default; VCL: gtk3 Locale: he-IL (en_IL); UI: en-US Could this be a Windows-specific problem? -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 160324] Column resize handle touch-target too small
https://bugs.documentfoundation.org/show_bug.cgi?id=160324 --- Comment #7 from Eyal Rozenberg --- (In reply to jon.macca...@gmail.com from comment #0) > The column resize handle touch target is only 1-2px wide, It's at least 4 px wide, if not 5, for me. Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: ffccbf4762a9ae810bcdd21c41fccdd436e7bfc9 CPU threads: 4; OS: Linux 6.6; UI render: default; VCL: gtk3 Locale: he-IL (en_IL); UI: en-US Could this be a Windows-specific problem? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160732] Rename "Navigation" toolbar to clarify its role, avoid confusion, and relate to "Navigate by - Recency"
https://bugs.documentfoundation.org/show_bug.cgi?id=160732 --- Comment #10 from Eyal Rozenberg --- How about "Navigate History" or "Navigate Positions"? I'm also ok with "Position History", although I like that less. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 160732] Rename "Navigation" toolbar to clarify its role, avoid confusion, and relate to "Navigate by - Recency"
https://bugs.documentfoundation.org/show_bug.cgi?id=160732 --- Comment #10 from Eyal Rozenberg --- How about "Navigate History" or "Navigate Positions"? I'm also ok with "Position History", although I like that less. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 143387] CRASH: undoing paste ( debug build )
https://bugs.documentfoundation.org/show_bug.cgi?id=143387 --- Comment #14 from Commit Notification --- Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/17b2f3d96fb21dcfc2fb8e54ca9670a8c58840f1 tdf#143320, tdf#143387: sw_uiwriter4: Add unittest It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 143387] CRASH: undoing paste ( debug build )
https://bugs.documentfoundation.org/show_bug.cgi?id=143387 Commit Notification changed: What|Removed |Added Whiteboard||target:24.8.0 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 143320] Crash at paste/undo paste again (swlo!BigPtrArray::Index2Block+0xc8)
https://bugs.documentfoundation.org/show_bug.cgi?id=143320 Commit Notification changed: What|Removed |Added Whiteboard|target:7.3.0 target:7.2.0.2 |target:7.3.0 target:7.2.0.2 ||target:24.8.0 -- You are receiving this mail because: You are the assignee for the bug.
core.git: 2 commits - sw/qa sw/source
sw/qa/extras/uiwriter/data/tdf143320.odt |binary
sw/qa/extras/uiwriter/uiwriter4.cxx | 37 +++
sw/source/core/frmedt/fefly1.cxx |4 +--
3 files changed, 39 insertions(+), 2 deletions(-)
New commits:
commit 17b2f3d96fb21dcfc2fb8e54ca9670a8c58840f1
Author: Xisco Fauli
AuthorDate: Wed Jul 14 14:41:24 2021 +0200
Commit: Xisco Fauli
CommitDate: Tue Apr 30 21:14:00 2024 +0200
tdf#143320, tdf#143387: sw_uiwriter4: Add unittest
Change-Id: I45aaa88c8ed70f3eebd30dfcd29edc4e1e4a5694
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118908
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sw/qa/extras/uiwriter/data/tdf143320.odt
b/sw/qa/extras/uiwriter/data/tdf143320.odt
new file mode 100644
index ..b7aef0c34bb0
Binary files /dev/null and b/sw/qa/extras/uiwriter/data/tdf143320.odt differ
diff --git a/sw/qa/extras/uiwriter/uiwriter4.cxx
b/sw/qa/extras/uiwriter/uiwriter4.cxx
index 7757ceb9701e..c361ddfb80e0 100644
--- a/sw/qa/extras/uiwriter/uiwriter4.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter4.cxx
@@ -2572,6 +2572,43 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest4, testTdf142157)
CPPUNIT_ASSERT_EQUAL(sal_Int32(1), xSections->getCount());
}
+CPPUNIT_TEST_FIXTURE(SwUiWriterTest4, testTdf143320)
+{
+createSwDoc("tdf143320.odt");
+SwDoc* pDoc = getSwDoc();
+SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+
+CPPUNIT_ASSERT_EQUAL(1, getPages());
+CPPUNIT_ASSERT(getParagraph(1)->getString().startsWith("x"));
+
+dispatchCommand(mxComponent, ".uno:SelectAll", {});
+
+dispatchCommand(mxComponent, ".uno:Copy", {});
+
+// Create a new document
+createSwDoc();
+pDoc = getSwDoc();
+pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+CPPUNIT_ASSERT(pWrtShell);
+
+dispatchCommand(mxComponent, ".uno:Paste", {});
+
+CPPUNIT_ASSERT_EQUAL(1, getPages());
+CPPUNIT_ASSERT(getParagraph(1)->getString().startsWith("x"));
+
+dispatchCommand(mxComponent, ".uno:Undo", {});
+Scheduler::ProcessEventsToIdle();
+
+CPPUNIT_ASSERT_EQUAL(1, getPages());
+CPPUNIT_ASSERT_EQUAL(OUString(""), getParagraph(1)->getString());
+
+// Without the fix in place, this test would have crashed here
+dispatchCommand(mxComponent, ".uno:Paste", {});
+
+CPPUNIT_ASSERT_EQUAL(1, getPages());
+CPPUNIT_ASSERT(getParagraph(1)->getString().startsWith("x"));
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
commit acad40220d21e73b5fb699404ae1a2dc29218faa
Author: Xisco Fauli
AuthorDate: Tue Apr 30 10:07:23 2024 +0200
Commit: Xisco Fauli
CommitDate: Tue Apr 30 21:13:52 2024 +0200
Fix UBSan failure (part 2)
Introduced by 495b5db74f0db59395ff68bacc8d8ca67595b66e
"sw: check GetUserCall"
https: //gerrit.libreoffice.org/c/core/+/166824/comments/8db24a41_2f4e7e4e
Change-Id: Ib6f981aa3055f0d37d0b83e3284842d310fe6ef0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166913
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sw/source/core/frmedt/fefly1.cxx b/sw/source/core/frmedt/fefly1.cxx
index 280166ed888b..eca71843557b 100644
--- a/sw/source/core/frmedt/fefly1.cxx
+++ b/sw/source/core/frmedt/fefly1.cxx
@@ -386,7 +386,7 @@ const SwFrameFormat* SwFEShell::IsFlyInFly()
return nullptr;
SdrObject *pObj = rMrkList.GetMark( 0 )->GetMarkedSdrObj();
-SwDrawContact *pContact = static_cast(GetUserCall(pObj));
+SwContact* pContact = GetUserCall( pObj );
if (!pContact)
return nullptr;
@@ -400,7 +400,7 @@ const SwFrameFormat* SwFEShell::IsFlyInFly()
}
else
{
-pFly = pContact->GetAnchorFrame(pObj);
+pFly = static_cast(pContact)->GetAnchorFrame(pObj);
}
OSL_ENSURE( pFly, "IsFlyInFly: Where's my anchor?" );
[Bug 160806] Cannot ascend accessibility tree from calc document to app
https://bugs.documentfoundation.org/show_bug.cgi?id=160806 Michael Weghorn changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |m.wegh...@posteo.de |desktop.org | Status|NEW |ASSIGNED --- Comment #9 from Michael Weghorn --- (In reply to Joanmarie Diggs from comment #0) > Steps to Reproduce: > 1. Launch Calc > 2. Launch the attached accessible-event listener in a terminal The order is actually relevant: The issue is (more) reproducible when starting Calc before starting running the script. The commit from comment 7 makes the case when AT is started before LO more reliable, but further analysis + fixing is needed in particular for the case where LO is started first. (I have an approach in mind now.) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160806] Cannot ascend accessibility tree from calc document to app
https://bugs.documentfoundation.org/show_bug.cgi?id=160806 --- Comment #8 from Commit Notification --- Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/be543e321552d4331e7dddca954a2b57f4c7f379 tdf#159369 tdf#160806 gtk3 a11y: Drop fallback dummy a11y obj It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159369] Cursor off screen at high document zoom level and high Gnome magnification (Wayland)
https://bugs.documentfoundation.org/show_bug.cgi?id=159369 --- Comment #13 from Commit Notification --- Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/be543e321552d4331e7dddca954a2b57f4c7f379 tdf#159369 tdf#160806 gtk3 a11y: Drop fallback dummy a11y obj It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160837] ACCESSIBILITY: toolbar positions are incorrectly reported to AT-SPI2
https://bugs.documentfoundation.org/show_bug.cgi?id=160837 --- Comment #2 from Commit Notification --- Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/252b1591d5e4e3adbf7063b56c2b578fe046ad3d tdf#159369 tdf#160806 tdf#160837 gtk3 a11y: Don't skip parents one way It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160806] Cannot ascend accessibility tree from calc document to app
https://bugs.documentfoundation.org/show_bug.cgi?id=160806 Commit Notification changed: What|Removed |Added Whiteboard||target:24.8.0 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160837] ACCESSIBILITY: toolbar positions are incorrectly reported to AT-SPI2
https://bugs.documentfoundation.org/show_bug.cgi?id=160837 Commit Notification changed: What|Removed |Added Whiteboard||target:24.8.0 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160806] Cannot ascend accessibility tree from calc document to app
https://bugs.documentfoundation.org/show_bug.cgi?id=160806 --- Comment #7 from Commit Notification --- Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/252b1591d5e4e3adbf7063b56c2b578fe046ad3d tdf#159369 tdf#160806 tdf#160837 gtk3 a11y: Don't skip parents one way It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159369] Cursor off screen at high document zoom level and high Gnome magnification (Wayland)
https://bugs.documentfoundation.org/show_bug.cgi?id=159369 Commit Notification changed: What|Removed |Added Whiteboard||target:24.8.0 -- You are receiving this mail because: You are the assignee for the bug.
core.git: 2 commits - vcl/unx
vcl/unx/gtk3/a11y/atkfactory.cxx | 83 +--
1 file changed, 12 insertions(+), 71 deletions(-)
New commits:
commit be543e321552d4331e7dddca954a2b57f4c7f379
Author: Michael Weghorn
AuthorDate: Tue Apr 30 16:17:25 2024 +0200
Commit: Michael Weghorn
CommitDate: Tue Apr 30 20:53:20 2024 +0200
tdf#159369 tdf#160806 gtk3 a11y: Drop fallback dummy a11y obj
No longer return a dummy AtkObject in
`wrapper_factory_create_accessible`, but drop the
implementation of that dummy object completely.
As far as I understand, the code path previously
creating those dummy objects should never be triggered,
so add asserts to detect any cases where it does.
However, gracefully return nullptr for release builds
for now at least.
This dummy implementation was originally added
as part of:
commit 62f451cb03d5202e2f15bf440c53a61b2efd99f8
Date: Fri May 5 09:54:24 2006 +
INTEGRATION: CWS atkbridge (1.1.2); FILE ADDED
2006/03/31 12:19:39 obr 1.1.2.12: #i63583# eliminated warnings
2006/03/28 10:49:45 obr 1.1.2.11: #i47890# redid the last patch to
make it more clear
2006/03/23 14:45:26 obr 1.1.2.10: fixed endless loop problem with
tooltips
2006/02/15 10:59:22 obr 1.1.2.9: #i47890# replaced tabs with spaces
2006/01/05 14:06:31 obr 1.1.2.8: #i47890# override toolkit name and
version and reworked bridge initialization
2005/11/16 12:29:16 obr 1.1.2.7: no longer return NULL in
factory_create_accessible
2005/11/16 09:09:20 obr 1.1.2.6: gail rev. 1.8.6 fixes the things
we needed gsignalhook for
2005/10/20 07:09:09 obr 1.1.2.5: #i47890# made cxx files
standalone, avoid queryInterface on each API call and demacrofied try/catch to
include appropriate warnings
2005/09/28 07:24:12 obr 1.1.2.4: #i47890# changed ref-counting/life
cycle once again, adjust tree and role of dialogs and filter sub-menu windows
2005/09/26 11:01:00 obr 1.1.2.3: #i47890# reworked lifecycle of atk
wrapper objects
2005/06/14 13:57:23 obr 1.1.2.2: #i47890# global focus event
listening stuff
2005/04/21 14:59:24 mmeeks 1.1.2.1: Issue number: i#47890#
Submitted by: mmeeks
Hacked up prototype of atk bridge
Change-Id: Ibdc525412ba6cc4b449c775a74dcd919c4045b6c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166934
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/vcl/unx/gtk3/a11y/atkfactory.cxx b/vcl/unx/gtk3/a11y/atkfactory.cxx
index c9702c9f85d8..3c8e6222e896 100644
--- a/vcl/unx/gtk3/a11y/atkfactory.cxx
+++ b/vcl/unx/gtk3/a11y/atkfactory.cxx
@@ -27,68 +27,6 @@ using namespace ::com::sun::star;
extern "C" {
-/*
- * Instances of this dummy object class are returned whenever we have to
- * create an AtkObject, but can't touch the OOo object anymore since it
- * is already disposed.
- */
-
-static AtkStateSet *
-noop_wrapper_ref_state_set( AtkObject * )
-{
-AtkStateSet *state_set = atk_state_set_new();
-atk_state_set_add_state( state_set, ATK_STATE_DEFUNCT );
-return state_set;
-}
-
-static void
-atk_noop_object_wrapper_class_init(gpointer klass_, gpointer)
-{
-auto const klass = static_cast(klass_);
-AtkObjectClass *atk_class = ATK_OBJECT_CLASS( klass );
-atk_class->ref_state_set = noop_wrapper_ref_state_set;
-}
-
-static GType
-atk_noop_object_wrapper_get_type()
-{
-static GType type = 0;
-
-if (!type)
-{
-static const GTypeInfo typeInfo =
-{
-sizeof (AtkNoOpObjectClass),
-nullptr,
-nullptr,
-atk_noop_object_wrapper_class_init,
-nullptr,
-nullptr,
-sizeof (AtkObjectWrapper),
-0,
-nullptr,
-nullptr
-} ;
-
-type = g_type_register_static (ATK_TYPE_OBJECT, "OOoAtkNoOpObj",
, GTypeFlags(0)) ;
-}
-return type;
-}
-
-static AtkObject*
-atk_noop_object_wrapper_new()
-{
- AtkObject *accessible;
-
- accessible = static_cast(g_object_new
(atk_noop_object_wrapper_get_type(), nullptr));
- g_return_val_if_fail (accessible != nullptr, nullptr);
-
- accessible->role = ATK_ROLE_INVALID;
- accessible->layer = ATK_LAYER_INVALID;
-
- return accessible;
-}
-
/*
* The wrapper factory
*/
@@ -103,24 +41,27 @@ static AtkObject*
wrapper_factory_create_accessible( GObject *obj )
{
GtkWidget* pEventBox = gtk_widget_get_parent(GTK_WIDGET(obj));
-
-// gail_container_real_remove_gtk tries to re-instantiate an accessible
-// for a widget that is about to vanish ..
+assert(pEventBox);
if (!pEventBox)
-return atk_noop_object_wrapper_new();
+return nullptr;
GtkWidget* pTopLevelGrid = gtk_widget_get_parent(pEventBox);
+assert(pTopLevelGrid);
if (!pTopLevelGrid)
-return
[Bug 159375] Opening Tools > Options dialog takes too long
https://bugs.documentfoundation.org/show_bug.cgi?id=159375
Bayram Çiçek changed:
What|Removed |Added
CC||kolafl...@kolahilft.de
--- Comment #14 from Bayram Çiçek ---
(In reply to kolAflash from comment
https://bugs.documentfoundation.org/show_bug.cgi?id=49895#c30) (Moving &
replying the comment here)
> @Bayram Çiçek
>
> It seems your patch slowed down loading the options dialog noticeably.
> https://git.libreoffice.org/core/+/
> a4633dadb4233ad5587bd238449671d610540c81%5E%21
> With LibreOffice-24.2 it's about 10 times slower than with LibreOffice-7.6.
> (before LibreOffice-7.1 the options loaded slow because of bug 146852)
>
> It's not a disaster. But on slower computers you really have to wait
> multiple seconds since LibreOffice-24.2. I guess on older computers this can
> exceed 10 seconds while being 1 second in LibreOffice-7.6.
Yes, unfortunately we have to initialize all dialogs to get their UI string
values to include them in searching. Otherwise, they are not accessible...
> Reproduction:
> Tools -> Options
> Measure the time until the Options window is opened.
> NOTE:
> It's just the first time the Options are being opened after starting
> LibreOffice. For repeating the test you have to restart LibreOffice.
That's true. We save the UI strings -at the time of opening Tools>Options- into
a list and they live until the LibreOffice application closes. In that way, we
don't need to initialize the all dialogs again and again; we just read the
strings from the list, if the Options dialog is opened again (without closing
the LO application)
> I've tested exactly your commit using this Git repo with binaries.
> https://bibisect.libreoffice.org/linux-64-24.2.git
> See also: https://wiki.documentfoundation.org/QA/Bibisect
> The binary commit 418e06688 in that repo corresponds to the a4633dadb commit
> in https://git.libreoffice.org/core/
> 418e06688^ is fast and 418e06688 is slow.
>
> On my Ryzen-5650U @ 2.3 GHz (4.2 GHz boost) notebook CPU it's just half a
> second. But if I slow down the CPU to the minimum of 1.6 GHz and disable the
> boost it's already over a second. While LibreOffice-7.6 stays nicely below
> half a second.
> /sys/devices/system/cpu/cpufreq/boost
> /sys/devices/system/cpu/cpu*/cpufreq/{boost,scaling_max_freq}
>
> I've got a low power Celeron-J4105 CPU system on which it's below 1 second
> with 418e06688^ and over 4 seconds with 418e06688
> If I throttle the CPU to 800 MHz 418e06688^ stays below 1 second while
> 418e06688 needs over 8 seconds.
> And I guess on a Raspberry Pi 4 or 5 used as a desktop computer it's even
> slower.
>
>
> Even on high speed CPUs you can see it clearly if you "cpulimit" to limit
> the computing power available to the process. On my Ryzen-5650U limited to
> 1.6 GHz with boost disabled this is over 8 seconds with 418e06688
> https://packages.debian.org/bookworm/cpulimit
> # first shell (limit process to CPU core 0)
> soffice
> # second shell
> sudo cpulimit -fv -l2 -e soffice.bin
>
> Operating system on all machines: Debian-12
> Same results for Upstream-LibreOffice-7.6, Debian-12-LibreOffice-7.4 and
> LibreOffice 418e06688^
>
>
>
> The problem seems to boil down to this eager preloading.
> initializeFirstNDialog(25);
> https://git.libreoffice.org/core/+/3b50600e8f817409f5a21249871d9f82728e4987/
> cui/source/options/treeopt.cxx#1201
I was expecting that slowness on low-power systems. There are almost 70 dialogs
need to be initialized. If 25 of them are so slow, then I can't imagine the
slowness of initializing the 70 of them during search...
> Although if I reduce the number from 25 to 1, I get a strange effect that
> didn't exist in 418e06688^. Some sections in the options dialog like
> LibreOffice->View get loaded really slow when clicking them. But not all
> sections are affected.
I need to check that strange effect. I remember we had issues like that in some
OSes (especially on Windows)
>
> So I'd consider removing this preloading (equivalent to setting the value to
> 1) less bad than the situation since LibreOffice-24.2. Because then you've
> only have to wait when clicking one of the slow sections or when using the
> search function (initializing the search takes some time with a value of 1).
> Ideally a user would only have to wait when using the new search feature.
> But I haven't figured out yet if or how that's possible.
I asked myself & thought the same while working on Options dialog. However, as
I mentioned earlier, you can't access anything without open/initialize the
dialog(s). This makes the implementation very difficult than it should be.
(regarding the topic, see also:
https://bayramcicek.github.io/libreoffice-dev/2023/06/18/week-03-gsoc-report.html)
> (very ideally a user never has to wait ;-) but I guess the new search
> feature just needs time to
[Bug 160646] GIF don't animate in edit mode; are rendered as still images
https://bugs.documentfoundation.org/show_bug.cgi?id=160646 Telesto changed: What|Removed |Added OS|All |Windows (All) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159375] Opening Tools > Options dialog takes too long
https://bugs.documentfoundation.org/show_bug.cgi?id=159375 --- Comment #13 from Mike Kaganski --- Is it possible to start gathering the strings in a dedicated thread (immediately at dialog start, but without blocking it)? And if a user starts searching, block until that thread finished. I bet, that in 90%+, users won't be that fast to notice the delay. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160874] Calc fails to suggest correction for formula cell without equal sign
https://bugs.documentfoundation.org/show_bug.cgi?id=160874 --- Comment #1 from Dan Dascalescu --- Created attachment 193912 --> https://bugs.documentfoundation.org/attachment.cgi?id=193912=edit Spreadsheet to reproduce the bug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160874] New: Calc fails to suggest correction for formula cell without equal sign
https://bugs.documentfoundation.org/show_bug.cgi?id=160874 Bug ID: 160874 Summary: Calc fails to suggest correction for formula cell without equal sign Product: LibreOffice Version: 24.2.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ddascalescu+freedesk...@gmail.com Created attachment 193911 --> https://bugs.documentfoundation.org/attachment.cgi?id=193911=edit Screencast If you edit a cell and type an incomplete formula, e.g. `=-5 *` then click a cell, Calc will paste the cell's address at the cursor in the formula, e.g. `=-5 * A3`. If you edit a cell that contains a negative number, e.g. `-5` and add `* 2`, Calc will correctly interpret that as a formula, `-5 * 2`. But if you edit a cell consisting of a negative number, type an operator (e.g. `-5 * `), then click another cell, Calc won't paste that cell's address. Please see the attached screencast, recorded with the attached spreadsheet. Version: 24.2.0.3 (X86_64) / LibreOffice Community Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1 CPU threads: 20; OS: Linux 6.7; UI render: default; VCL: kf5 (cairo+wayland) Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
core.git: 2 commits - accessibility/source sw/source
accessibility/source/extended/AccessibleBrowseBoxTableBase.cxx |6 -
accessibility/source/extended/AccessibleGridControlTable.cxx |6 -
accessibility/source/extended/AccessibleGridControlTableBase.cxx |6 -
accessibility/source/extended/accessibleiconchoicectrlentry.cxx |2
accessibility/source/extended/accessiblelistboxentry.cxx | 14 +-
accessibility/source/extended/accessibletablistbox.cxx |2
accessibility/source/extended/textwindowaccessibility.cxx| 48
+-
accessibility/source/helper/acc_factory.cxx |4
accessibility/source/standard/vclxaccessibleedit.cxx |2
accessibility/source/standard/vclxaccessibleheaderbaritem.cxx|4
accessibility/source/standard/vclxaccessiblelist.cxx |4
accessibility/source/standard/vclxaccessiblelistbox.cxx |4
accessibility/source/standard/vclxaccessiblelistitem.cxx |8 -
accessibility/source/standard/vclxaccessiblemenubar.cxx |4
accessibility/source/standard/vclxaccessiblemenuitem.cxx |4
accessibility/source/standard/vclxaccessiblemenuseparator.cxx|4
accessibility/source/standard/vclxaccessibleradiobutton.cxx |4
sw/source/writerfilter/dmapper/FormControlHelper.cxx | 37 ++-
sw/source/writerfilter/dmapper/FormControlHelper.hxx |6 -
19 files changed, 79 insertions(+), 90 deletions(-)
New commits:
commit 6e8f12c44bfe3483f69127f7d5429536249f6c2b
Author: Noel Grandin
AuthorDate: Tue Apr 30 13:48:08 2024 +0200
Commit: Noel Grandin
CommitDate: Tue Apr 30 19:35:48 2024 +0200
loplugin:ostr in accessibility
Change-Id: Iff3e6af9627aa5d31b00ad48bc6c6ea8d3913fe9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166927
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/accessibility/source/extended/AccessibleBrowseBoxTableBase.cxx
b/accessibility/source/extended/AccessibleBrowseBoxTableBase.cxx
index a1ae5a969dcb..044a85958e98 100644
--- a/accessibility/source/extended/AccessibleBrowseBoxTableBase.cxx
+++ b/accessibility/source/extended/AccessibleBrowseBoxTableBase.cxx
@@ -263,13 +263,13 @@ void
AccessibleBrowseBoxTableBase::implGetSelectedColumns( Sequence< sal_Int32 >
void AccessibleBrowseBoxTableBase::ensureIsValidRow( sal_Int32 nRow )
{
if( nRow >= implGetRowCount() )
-throw lang::IndexOutOfBoundsException( "row index is invalid", *this );
+throw lang::IndexOutOfBoundsException( u"row index is invalid"_ustr,
*this );
}
void AccessibleBrowseBoxTableBase::ensureIsValidColumn( sal_Int32 nColumn )
{
if( nColumn >= implGetColumnCount() )
-throw lang::IndexOutOfBoundsException( "column index is invalid",
*this );
+throw lang::IndexOutOfBoundsException( u"column index is
invalid"_ustr, *this );
}
void AccessibleBrowseBoxTableBase::ensureIsValidAddress(
@@ -282,7 +282,7 @@ void AccessibleBrowseBoxTableBase::ensureIsValidAddress(
void AccessibleBrowseBoxTableBase::ensureIsValidIndex( sal_Int64 nChildIndex )
{
if( nChildIndex >= implGetChildCount() )
-throw lang::IndexOutOfBoundsException( "child index is invalid", *this
);
+throw lang::IndexOutOfBoundsException( u"child index is invalid"_ustr,
*this );
}
diff --git a/accessibility/source/extended/AccessibleGridControlTable.cxx
b/accessibility/source/extended/AccessibleGridControlTable.cxx
index 3b8f0138267e..1f1a0436951c 100644
--- a/accessibility/source/extended/AccessibleGridControlTable.cxx
+++ b/accessibility/source/extended/AccessibleGridControlTable.cxx
@@ -116,7 +116,7 @@ OUString SAL_CALL
AccessibleGridControlTable::getAccessibleRowDescription( sal_I
ensureIsAlive();
ensureIsValidRow( nRow );
-return "row description";
+return u"row description"_ustr;
}
OUString SAL_CALL AccessibleGridControlTable::getAccessibleColumnDescription(
sal_Int32 nColumn )
@@ -125,7 +125,7 @@ OUString SAL_CALL
AccessibleGridControlTable::getAccessibleColumnDescription( sa
ensureIsAlive();
ensureIsValidColumn( nColumn );
-return "col description";
+return u"col description"_ustr;
}
Reference< XAccessibleTable > SAL_CALL
AccessibleGridControlTable::getAccessibleRowHeaders()
@@ -253,7 +253,7 @@ AccessibleGridControlTable::getSelectedAccessibleChild(
sal_Int64 nSelectedChild
ensureIsAlive();
if (nSelectedChildIndex < 0 || nSelectedChildIndex >=
getSelectedAccessibleChildCount())
-throw lang::IndexOutOfBoundsException("Invalid index into selection",
*this);
+throw lang::IndexOutOfBoundsException(u"Invalid index into
selection"_ustr, *this);
const sal_Int32 nColCount = getAccessibleColumnCount();
assert(nColCount > 0 && "Column count non-positive, but child count > 0");
diff --git a/accessibility/source/extended/AccessibleGridControlTableBase.cxx
core.git: sw/inc sw/source
sw/inc/unotxdoc.hxx |2 ++
sw/source/uibase/uno/unotxdoc.cxx |7 +++
sw/source/writerfilter/dmapper/OLEHandler.cxx | 17 +++--
sw/source/writerfilter/dmapper/OLEHandler.hxx |4 +++-
4 files changed, 19 insertions(+), 11 deletions(-)
New commits:
commit 29a19f25f001ae63c60864c6a650220ecb3d0ca1
Author: Noel Grandin
AuthorDate: Thu Apr 25 16:10:21 2024 +0200
Commit: Noel Grandin
CommitDate: Tue Apr 30 19:34:56 2024 +0200
use more concrete UNO classes in writerfilter (SvXMLEmbeddedObjectHelper)
Change-Id: Ic813596204070a17d66d0f469bcdf30e16b16b35
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166811
Tested-by: Noel Grandin
Reviewed-by: Noel Grandin
diff --git a/sw/inc/unotxdoc.hxx b/sw/inc/unotxdoc.hxx
index b4a84c62029b..b690a290b7b9 100644
--- a/sw/inc/unotxdoc.hxx
+++ b/sw/inc/unotxdoc.hxx
@@ -118,6 +118,7 @@ class SwXTextGraphicObject;
class SwXPageStyle;
class SwXContentControl;
class SwXTextEmbeddedObject;
+class SvXMLEmbeddedObjectHelper;
namespace com::sun::star::container { class XNameContainer; }
namespace com::sun::star::frame { class XController; }
namespace com::sun::star::lang { struct Locale; }
@@ -535,6 +536,7 @@ public:
SW_DLLPUBLIC rtl::Reference createFootnote();
SW_DLLPUBLIC rtl::Reference createEndnote();
SW_DLLPUBLIC rtl::Reference
createTextEmbeddedObject();
+SW_DLLPUBLIC rtl::Reference
createEmbeddedObjectResolver();
};
class SwXLinkTargetSupplier final : public cppu::WeakImplHelper
diff --git a/sw/source/uibase/uno/unotxdoc.cxx
b/sw/source/uibase/uno/unotxdoc.cxx
index c06ea2b32a0e..d9debd315fab 100644
--- a/sw/source/uibase/uno/unotxdoc.cxx
+++ b/sw/source/uibase/uno/unotxdoc.cxx
@@ -1764,6 +1764,13 @@ rtl::Reference< SwXTextEmbeddedObject >
SwXTextDocument::createTextEmbeddedObjec
return SwXTextEmbeddedObject::CreateXTextEmbeddedObject(GetDocOrThrow(),
nullptr);
}
+rtl::Reference< SvXMLEmbeddedObjectHelper >
SwXTextDocument::createEmbeddedObjectResolver()
+{
+SolarMutexGuard aGuard;
+ThrowIfInvalid();
+return new SvXMLEmbeddedObjectHelper(*m_pDocShell,
SvXMLEmbeddedObjectHelperMode::Read);
+}
+
Reference< XInterface > SwXTextDocument::createInstance(const OUString&
rServiceName)
{
return create(rServiceName, nullptr);
diff --git a/sw/source/writerfilter/dmapper/OLEHandler.cxx
b/sw/source/writerfilter/dmapper/OLEHandler.cxx
index e0671c8a21b6..3c1d198d74eb 100644
--- a/sw/source/writerfilter/dmapper/OLEHandler.cxx
+++ b/sw/source/writerfilter/dmapper/OLEHandler.cxx
@@ -42,6 +42,8 @@
#include
#include
#include
+#include
+#include
namespace writerfilter::dmapper {
@@ -277,23 +279,19 @@ OUString const & OLEHandler::GetVisAreaHeight() const
return m_sVisAreaHeight;
}
-OUString OLEHandler::copyOLEOStream(
-uno::Reference const& xTextDocument)
+OUString OLEHandler::copyOLEOStream(rtl::Reference const&
xTextDocument)
{
OUString sRet;
if( !m_xInputStream.is( ) )
return sRet;
try
{
-uno::Reference < lang::XMultiServiceFactory > xFactory(xTextDocument,
uno::UNO_QUERY_THROW);
-uno::Reference< document::XEmbeddedObjectResolver > xEmbeddedResolver(
-
xFactory->createInstance("com.sun.star.document.ImportEmbeddedObjectResolver"),
uno::UNO_QUERY_THROW );
+rtl::Reference< SvXMLEmbeddedObjectHelper > xEmbeddedResolver =
xTextDocument->createEmbeddedObjectResolver();
//hack to work with the ImportEmbeddedObjectResolver
static sal_Int32 nObjectCount = 100;
-uno::Reference< container::XNameAccess > xNA( xEmbeddedResolver,
uno::UNO_QUERY_THROW );
OUString aURL = "Obj" + OUString::number( nObjectCount++ );
uno::Reference < io::XOutputStream > xOLEStream;
-if( (xNA->getByName( aURL ) >>= xOLEStream) && xOLEStream.is() )
+if( (xEmbeddedResolver->getByName( aURL ) >>= xOLEStream) &&
xOLEStream.is() )
{
const sal_Int32 nReadRequest = 0x1000;
uno::Sequence< sal_Int8 > aData;
@@ -309,14 +307,13 @@ OUString OLEHandler::copyOLEOStream(
}
}
-::oox::ole::SaveInteropProperties(xTextDocument, aURL, nullptr,
m_sProgId);
+
::oox::ole::SaveInteropProperties(static_cast(xTextDocument.get()),
aURL, nullptr, m_sProgId);
OUString aPersistName(
xEmbeddedResolver->resolveEmbeddedObjectURL( aURL ) );
sRet = aPersistName.copy( strlen("vnd.sun.star.EmbeddedObject:") );
}
-uno::Reference< lang::XComponent > xComp( xEmbeddedResolver,
uno::UNO_QUERY_THROW );
-xComp->dispose();
+xEmbeddedResolver->dispose();
m_aURL = aURL;
}
catch( const uno::Exception& )
diff --git a/sw/source/writerfilter/dmapper/OLEHandler.hxx
b/sw/source/writerfilter/dmapper/OLEHandler.hxx
index 67fed0128186..1a7e40b6cecd 100644
---
core.git: sw/source
sw/source/writerfilter/rtftok/rtfdispatchdestination.cxx |2 -
sw/source/writerfilter/rtftok/rtfdispatchflag.cxx| 15 --
sw/source/writerfilter/rtftok/rtfdocumentimpl.cxx| 22 +--
sw/source/writerfilter/rtftok/rtfdocumentimpl.hxx|6
sw/source/writerfilter/rtftok/rtfsdrimport.cxx |6 ++--
5 files changed, 20 insertions(+), 31 deletions(-)
New commits:
commit bd343716f505bb955ddfb9fa20002468df3fb19c
Author: Noel Grandin
AuthorDate: Thu Apr 25 10:55:07 2024 +0200
Commit: Noel Grandin
CommitDate: Tue Apr 30 19:34:23 2024 +0200
use more concrete UNO classes in writerfilter rtf
Change-Id: I54dded3ffce1fbe6fee1b93370eb5b44bb719339
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166810
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/source/writerfilter/rtftok/rtfdispatchdestination.cxx
b/sw/source/writerfilter/rtftok/rtfdispatchdestination.cxx
index 4ff4fade6867..30b2acb58f80 100644
--- a/sw/source/writerfilter/rtftok/rtfdispatchdestination.cxx
+++ b/sw/source/writerfilter/rtftok/rtfdispatchdestination.cxx
@@ -613,7 +613,7 @@ RTFError RTFDocumentImpl::dispatchDestination(RTFKeyword
nKeyword)
if (!aLookahead.hasTable())
{
uno::Reference xGroupShape(
-
m_xModelFactory->createInstance("com.sun.star.drawing.GroupShape"),
+
getTextDocument()->createInstance("com.sun.star.drawing.GroupShape"),
uno::UNO_QUERY);
if (m_xDstDoc)
{
diff --git a/sw/source/writerfilter/rtftok/rtfdispatchflag.cxx
b/sw/source/writerfilter/rtftok/rtfdispatchflag.cxx
index 434936da2e53..af97b36812f9 100644
--- a/sw/source/writerfilter/rtftok/rtfdispatchflag.cxx
+++ b/sw/source/writerfilter/rtftok/rtfdispatchflag.cxx
@@ -28,6 +28,7 @@
#include "rtfsdrimport.hxx"
#include "rtfskipdestination.hxx"
#include
+#include
using namespace com::sun::star;
@@ -1039,7 +1040,7 @@ RTFError RTFDocumentImpl::dispatchFlag(RTFKeyword
nKeyword)
case RTFKeyword::DPLINE:
{
uno::Reference xShape(
-
getModelFactory()->createInstance("com.sun.star.drawing.LineShape"),
+
getTextDocument()->createInstance("com.sun.star.drawing.LineShape"),
uno::UNO_QUERY);
m_aStates.top().getDrawingObject().setShape(xShape);
break;
@@ -1048,7 +1049,7 @@ RTFError RTFDocumentImpl::dispatchFlag(RTFKeyword
nKeyword)
{
// The reason this is not a simple CustomShape is that in
the old syntax we have no ViewBox info.
uno::Reference xShape(
-
getModelFactory()->createInstance("com.sun.star.drawing.PolyLineShape"),
+
getTextDocument()->createInstance("com.sun.star.drawing.PolyLineShape"),
uno::UNO_QUERY);
m_aStates.top().getDrawingObject().setShape(xShape);
break;
@@ -1056,7 +1057,7 @@ RTFError RTFDocumentImpl::dispatchFlag(RTFKeyword
nKeyword)
case RTFKeyword::DPPOLYGON:
{
uno::Reference xShape(
-
getModelFactory()->createInstance("com.sun.star.drawing.PolyPolygonShape"),
+
getTextDocument()->createInstance("com.sun.star.drawing.PolyPolygonShape"),
uno::UNO_QUERY);
m_aStates.top().getDrawingObject().setShape(xShape);
break;
@@ -1064,7 +1065,7 @@ RTFError RTFDocumentImpl::dispatchFlag(RTFKeyword
nKeyword)
case RTFKeyword::DPRECT:
{
uno::Reference xShape(
-
getModelFactory()->createInstance("com.sun.star.drawing.RectangleShape"),
+
getTextDocument()->createInstance("com.sun.star.drawing.RectangleShape"),
uno::UNO_QUERY);
m_aStates.top().getDrawingObject().setShape(xShape);
break;
@@ -1074,9 +1075,7 @@ RTFError RTFDocumentImpl::dispatchFlag(RTFKeyword
nKeyword)
break;
case RTFKeyword::DPTXBX:
{
-uno::Reference xShape(
-
getModelFactory()->createInstance("com.sun.star.text.TextFrame"),
-uno::UNO_QUERY);
+rtl::Reference
xShape(getTextDocument()->createTextFrame());
m_aStates.top().getDrawingObject().setShape(xShape);
std::vector aDefaults
= RTFSdrImport::getTextFrameDefaults(false);
@@ -1099,7 +1098,7 @@ RTFError RTFDocumentImpl::dispatchFlag(RTFKeyword
nKeyword)
if (nType)
{
[Bug 159375] Opening Tools > Options dialog takes too long
https://bugs.documentfoundation.org/show_bug.cgi?id=159375 Bayram Çiçek changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=49 ||895 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 114287] fo:text-indent and fo:margin-left from paragraph style has to overrule those from list style
https://bugs.documentfoundation.org/show_bug.cgi?id=114287 Michael Stahl (allotropia) changed: What|Removed |Added Whiteboard|target:7.6.0 target:24.8.0 |odf target:7.6.0 |target:7.6.8 target:24.2.4 |target:24.8.0 target:7.6.8 ||target:24.2.4 Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #9 from Michael Stahl (allotropia) --- 1. the bug in the description, we already concluded last year that it's a bad idea to fix it because it would break interop with other ODF applications like Word 2. the bug that the commits were about is a different bug best described by https://bugs.documentfoundation.org/show_bug.cgi?id=156146#c3 but now it turned out that fixing that is also a bad idea; it would improve interop with Word, but break other things and it turns out that Word can't even roundtrip this thing itself -- You are receiving this mail because: You are the assignee for the bug.
[Bug 145318] direct formatting indentation does override style indentation in lists
https://bugs.documentfoundation.org/show_bug.cgi?id=145318 Bug 145318 depends on bug 114287, which changed state. Bug 114287 Summary: fo:text-indent and fo:margin-left from paragraph style has to overrule those from list style https://bugs.documentfoundation.org/show_bug.cgi?id=114287 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug.
[Bug 78175] Changing paragraph style does not change first line indent
https://bugs.documentfoundation.org/show_bug.cgi?id=78175 Bug 78175 depends on bug 114287, which changed state. Bug 114287 Summary: fo:text-indent and fo:margin-left from paragraph style has to overrule those from list style https://bugs.documentfoundation.org/show_bug.cgi?id=114287 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug.
[Bug 94587] [META] Properly support existing ODF features
https://bugs.documentfoundation.org/show_bug.cgi?id=94587 Bug 94587 depends on bug 114287, which changed state. Bug 114287 Summary: fo:text-indent and fo:margin-left from paragraph style has to overrule those from list style https://bugs.documentfoundation.org/show_bug.cgi?id=114287 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug.
[Bug 92762] WRITER paragraph with list style is different from paragraph style + separate list style
https://bugs.documentfoundation.org/show_bug.cgi?id=92762 Bug 92762 depends on bug 114287, which changed state. Bug 114287 Summary: fo:text-indent and fo:margin-left from paragraph style has to overrule those from list style https://bugs.documentfoundation.org/show_bug.cgi?id=114287 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug.
