[Libreoffice-commits] core.git: Changes to 'refs/changes/03/903/1'

2014-09-29 Thread René Kjellerup

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Changes to 'refs/changes/03/903/2'

2014-09-29 Thread René Kjellerup

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Changes to 'refs/changes/03/903/4'

2014-09-29 Thread René Kjellerup

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Changes to 'refs/changes/85/885/1'

2014-09-29 Thread René Kjellerup

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Changes to 'refs/changes/91/891/1'

2014-09-29 Thread René Kjellerup

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Changes to 'refs/changes/98/898/1'

2014-09-29 Thread René Kjellerup

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Changes to 'refs/changes/91/891/2'

2014-09-29 Thread René Kjellerup

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


My license of contributions

2012-05-04 Thread René Kjellerup
All my contributions, past, present and future, are under the dual license
of MPL/LGPLv3+
(Mozilla Public License / GNU Lesser General Public License version 3 or
later)

Thank you
René Kjellerup

sent from my phone
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] C++0x and LibreOffice

2010-11-25 Thread René Kjellerup
Well, the version 4.4.3 of gcc on my system seems to support it.

One way to see when it's available would be to look up gcc's documentation
in the changelog for the 4.4.x series

I took a quick look at gnu's web site and found this:
http://gcc.gnu.org/projects/cxx0x.html

(looks like a little of the C++0x is available as early as 4.3)

kr
René

sent from my phone
On Nov 25, 2010 9:26 PM, Caolán McNamara caol...@redhat.com wrote:
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] Fwd: Re: [PATCH] Use a generic unxgcc.mk

2010-11-17 Thread René Kjellerup
sent from my phone
-- Forwarded message --
From: René Kjellerup rk.katana.st...@gmail.com
Date: Nov 17, 2010 5:17 PM
Subject: Re: [Libreoffice] [PATCH] Use a generic unxgcc.mk
To: Caolán McNamara caol...@redhat.com

Why the oracle copyright notice in the new file too?
Shouldn't they have a TDF notice instead ?

Just asking

Regards
René
On Nov 17, 2010 4:33 PM, Caolán McNamara caol...@redhat.com wrote:
 On Wed, 2010-11-17 at 15:13 +0100, Robert Nagy wrote:
 Move unxlng.mk to unxgcc.mk and use that on OpenBSD and Linux
 too as a default and then overwrite or add variables.

 Oh good, wanted to unify those things. As far as I can see it looks
 good, Linux is building for me at the moment and it all seems ok.

 C.

 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] a few mixed patches to calc

2010-11-15 Thread René Kjellerup
the highlights
translations of a few comments
removal of some dead code


thanks
René Kjellerup
-- 
-- as life grows older, I gain experience.


0001-Comment-translation-and-removing-FASTBOOL-reference.patch
Description: Binary data


0001-Macro-update-and-Comment-translation.patch
Description: Binary data


0002-Removing-dead-code-in-ScDrawView.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] Warning free sc module

2010-11-03 Thread René Kjellerup
Hi

I looked in to the warnings in 'sc' and changed a few things around to
satisfy the compiler ^_^

I haven't said so yet, but I'll let you choose the licensing best fitted for
all my contributions.
(general guideline: the same as the code I've modified ;))

comments are most welcome.

René
-- 
-- as life grows older, I gain experience.
diff --git a/sc/source/core/tool/docoptio.cxx b/sc/source/core/tool/docoptio.cxx
index 50fb8cb..54ac0fd 100644
--- a/sc/source/core/tool/docoptio.cxx
+++ b/sc/source/core/tool/docoptio.cxx
@@ -385,7 +385,7 @@ ScDocCfg::ScDocCfg() :
 aValues = aCalcItem.GetProperties(aNames);
 aCalcItem.EnableNotification(aNames);
 pValues = aValues.getConstArray();
-DBG_ASSERT(aValues.getLength() == aNames.getLength(), GetProperties 
failed);
+OSL_ENSURE(aValues.getLength() == aNames.getLength(), GetProperties 
failed);
 if(aValues.getLength() == aNames.getLength())
 {
 for(int nProp = 0; nProp  aNames.getLength(); nProp++)
@@ -631,6 +631,7 @@ IMPL_LINK( ScDocCfg, FormulaCommitHdl, void *, EMPTYARG )
 {
 case ::formula::FormulaGrammar::GRAM_NATIVE_XL_A1:nVal 
= 1; break;
 case ::formula::FormulaGrammar::GRAM_NATIVE_XL_R1C1:  nVal 
= 2; break;
+default: break;
 }
 pValues[nProp] = nVal;
 }
diff --git a/sc/source/filter/excel/xeescher.cxx 
b/sc/source/filter/excel/xeescher.cxx
index 43abdbe..e930a86 100644
--- a/sc/source/filter/excel/xeescher.cxx
+++ b/sc/source/filter/excel/xeescher.cxx
@@ -117,6 +117,8 @@ using ::oox::drawingml::ChartExport;
 
 #define  HMM2XL(x)((x)/26.5)+0.5
 
+#ifdef XLSX_OOXML_FUTURE
+// these function are only used within that context
 // Static Function Helpers
 static const char *ToHorizAlign( SdrTextHorzAdjust eAdjust )
 {
@@ -167,6 +169,7 @@ static void lcl_WriteAnchorVertex( 
sax_fastparser::FSHelperPtr rComments, Rectan
 rComments-writeEscaped( OUString::valueOf( aRect.Bottom() ) );
 rComments-endElement( FSNS( XML_xdr, XML_rowOff ) );
 }
+#endif
 
 static void lcl_GetFromTo( const XclExpRoot rRoot, const Rectangle aRect, 
INT32 nTab, Rectangle aFrom, Rectangle aTo )
 {
diff --git a/sc/source/filter/excel/xiname.cxx 
b/sc/source/filter/excel/xiname.cxx
index 26f6c44..fa11a8e 100644
--- a/sc/source/filter/excel/xiname.cxx
+++ b/sc/source/filter/excel/xiname.cxx
@@ -232,7 +232,7 @@ XclImpName::XclImpName( XclImpStream rStrm, sal_uInt16 
nXclNameIdx ) :
 // discard deleted ranges ( for the moment at least )
 if ( pData-IsValidReference( aRange ) )
 {
-ScExtTabSettings rTabSett = 
GetExtDocOptions().GetOrCreateTabSettings( nXclTab );
+/* ScExtTabSettings rTabSett = */ 
GetExtDocOptions().GetOrCreateTabSettings( nXclTab );
 // create a mapping between the unmodified localname to
 // the name in the global name container for named ranges
 OSL_TRACE( mapping local name to global name for tab %d 
which exists? %s, nXclTab, GetDoc().HasTable( mnScTab ) ? true : false );
diff --git a/sc/source/filter/xcl97/xcl97rec.cxx 
b/sc/source/filter/xcl97/xcl97rec.cxx
index 6564c7a..2c90d80 100644
--- a/sc/source/filter/xcl97/xcl97rec.cxx
+++ b/sc/source/filter/xcl97/xcl97rec.cxx
@@ -103,9 +103,9 @@ sal_Int32 XclExpObjList::mnVmlCount;
 
 XclExpObjList::XclExpObjList( const XclExpRoot rRoot, XclEscherEx rEscherEx 
) :
 XclExpRoot( rRoot ),
+mnScTab( rRoot.GetCurrScTab() ),
 mrEscherEx( rEscherEx ),
-pSolverContainer( 0 ),
-mnScTab( rRoot.GetCurrScTab() )
+pSolverContainer( 0 )
 {
 pMsodrawingPerSheet = new XclExpMsoDrawing( rEscherEx );
 // open the DGCONTAINER and the patriarch group shape
@@ -972,6 +972,8 @@ void XclObjAny::WriteFromTo( XclExpXmlStream rStrm, const 
XclObjAny rObj )
 WriteFromTo( rStrm, rObj.GetShape(), rObj.GetTab() );
 }
 
+/* is this function (WritePicPr) exported or only local, if such I'll remove 
it */
+/*
 static void
 WritePicPr( sax_fastparser::FSHelperPtr pDrawing, sal_Int32 nId, Reference 
XPropertySet  xPropSet )
 {
@@ -1006,7 +1008,7 @@ WritePicPr( sax_fastparser::FSHelperPtr pDrawing, 
sal_Int32 nId, Reference XPro
 pDrawing-endElement( FSNS( XML_xdr, XML_cNvPicPr ) );
 pDrawing-endElement( FSNS( XML_xdr, XML_nvPicPr ) );
 }
-
+*/
 
 static const char*
 GetEditAs( XclObjAny rObj )
diff --git a/sc/source/ui/vba/excelvbahelper.cxx 
b/sc/source/ui/vba/excelvbahelper.cxx
index 3ca5ba8..b3213a7 100644
--- a/sc/source/ui/vba/excelvbahelper.cxx
+++ b/sc/source/ui/vba/excelvbahelper.cxx
@@ -377,7 +377,7 @@ void CompileExcelFormulaToODF( ScDocument* pDoc, const 
String rOldFormula, Stri
 }
 ScCompiler aCompiler( pDoc, ScAddress() );
 aCompiler.SetGrammar( excel::GetFormulaGrammar( pDoc, ScAddress(), 
uno::Any( rtl::OUString( rOldFormula ) ) ) );
-ScTokenArray* pCode = 

Re: [Libreoffice] FOO_GTK error when running autogen.sh

2010-11-03 Thread René Kjellerup
Okay a crazy question, do you have pkgconfig installed then?

K.r.
René Kj.
On Nov 3, 2010 9:28 PM, Terrell Prudeapos; Jr. micro...@cmosnetworks.com
wrote:
 Wols Lists wrote:
 On 03/11/10 19:44, Terrell Prude' Jr. wrote:

 OK, folks, I've got another issue, this time when running autogen.sh.

 Here's the command I'm running (OS is CentOS 5).

 ./autogen.sh --with-git --with-num-cpus=3 --without-junit --disable-kde4

 I get the following configure error:

 checking for autoconf... yes
 checking for flex... yes
 checking for bison... yes
 checking for ccache... no
 checking for distcc... no
 checking for widget sets... checking for FOO_GTK... no
 configure: error: Gtk+ library requirements were not met

 If I throw the --disable-gtk switch, autogen.sh is happy. I
 checked, and I'm seeing the gtk+-devel and gtk2-devel packages
installed.
 BTW, this is a new box, a 64-bit Core 2 Duo running 64-bit CentOS 5.
 Both the 32- and 64-bit versions of the gtk+ and gtk2 binaries and
 -devel packages appear to be installed. I made sure by yum
 install'ing these packages, and they're showing up as already installed.

 Suggestions?


 First thing. Have you got a file gtk+-2.0.pc in /usr/lib/pkgconfig? If
 not, any ideas why not? If a similar file, what's that called?

 configure.in is using pkgconfig to see what libraries you have on your
 system, and that's the library it's looking for. If it can't find it,
 that's why it's moaning that gtk isn't present.

 Let me know more, and I'll dig deeper (I'm trying to get the Qt version
 of this test working correctly :-)

 Cheers,
 Wol
 Just checked. Looks like the file is there. Here's an ls -l, and the
 contents of the file.

 [r...@tprude01 pkgconfig]# ls -l gtk*
 -rw-r--r-- 1 root root 322 May 24 2008 gtk+-2.0.pc
 -rw-r--r-- 1 root root 373 Mar 14 2007 gtk2-java.pc
 -rw-r--r-- 1 root root 156 Mar 14 2007 gtk-engines-2.pc
 -rw-r--r-- 1 root root 171 Mar 14 2007 gtk+.pc
 -rw-r--r-- 1 root root 294 May 24 2008 gtk+-unix-print-2.0.pc
 -rw-r--r-- 1 root root 322 May 24 2008 gtk+-x11-2.0.pc
 [r...@tprude01 pkgconfig]# pwd
 /usr/lib/pkgconfig
 [r...@tprude01 pkgconfig]# more gtk+-2.0.pc
 prefix=/usr
 exec_prefix=/usr
 libdir=/usr/lib
 includedir=/usr/include
 target=x11

 gtk_binary_version=2.10.0
 gtk_host=i686-redhat-linux-gnu

 Name: GTK+
 Description: GIMP Tool Kit (${target} target)
 Version: 2.10.4
 Requires: gdk-${target}-2.0 atk cairo
 Libs: -L${libdir} -lgtk-${target}-2.0
 Cflags: -I${includedir}/gtk-2.0
 [r...@tprude01 pkgconfig]#

 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] the basic macro editor

2010-10-27 Thread René Kjellerup
On Wed, Oct 27, 2010 at 11:29 AM, Michael Meeks michael.me...@novell.comwrote:


 On Tue, 2010-10-26 at 21:39 +0200, René Kjellerup wrote:
  Very understandable then, I've had build issues since the 17th...

Nasty - can we help out with them ? perhaps the solver is out of
 sync
 somehow - Norbert's recommendation to remove build/libreoffice/solver in
 its entirety may help there.

well maybe... I do, whenever I can, update my build tree (once a day
usually) and just before I retry:
loroot$ git pull -r
if that failse (cause of locally modified files)
loroot$ git fetch ; git merge origin
then
loroot$ bin/g fetch ; bin/g merge origin

loroot$ make clean
loroot$ ./autogen.sh options
loroot$ make

if you'd have some git pointer if I need to update my build tree otherwise


  and no real time to look into it. I apologize for having brought it up
  so late.

No problem ! :-)

  Nice to see it has been solved. Thanks

Thanks for your persistence in debugging ! lets try to get you a
 working build ...

yeah, I thought I had one yesterday evening
however a perl script failed for make dev-install (ooinstall)

I'll post a new tread about it and let this one die as it should ^_^



All the best,

Michael.

 --
  michael.me...@novell.com  , Pseudo Engineer, itinerant idiot



I try to at least read up on the issues posted at the mailing list.

thanks for everything,

René
-- 
-- as life grows older, I gain experience.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] Dev-install failed

2010-10-27 Thread René Kjellerup
ooinstall perl script failed with this message:

Reading setup from ./setup
Running OOo installer
Subroutine installer::epmfile::getcwd redefined at
/usr/lib64/perl5/5.8.8/Exporter.pm line 65.
 at /usr/lib64/perl5/5.8.8/x86_64-linux/POSIX.pm line 19
Unquoted string ppc may clash with future reserved word at
/mnt/newdisk/loffice/build/build/libreoffice-3.2.99.2/solenv/bin/modules/installer/
epmfile.pm line 2836.
sh: line 1: 14217 Segmentation fault  perl -d:DProf -w
/mnt/newdisk/loffice/build/build/libreoffice-3.2.99.2/solenv/bin/
make_installer.pl -f openoffice.lst -l en-US -p LibreOffice -buildid 1
-simple /mnt/newdisk/loffice/install
Failed to install: No such file or directory at solenv/bin/ooinstall line
96.
Installing extra dictionaries...

the build ended with:

Making:../unxlngx6.pro/bin/hid.lst
warn: two longnames have the same ID: HID_BG_BTN_IMG4 and HID_BG_BTN_IMG14
share ID 34300
warn: two longnames have the same ID: HID_DSADMIN_USESSL_LDAP and
HID_DSADMIN_DBASE_PATH share ID 39007
warn: two longnames have the same ID: RID_TABPAGE_PARA_NUMBERING and
FN_GOTO_NEXT_MARK share ID 20976
warn: two longnames have the same ID: RID_TOOLBOX_INSERT and 1 share ID 1
warn: two longnames have the same ID: RID_UNDO_DELETE_WARNING and
FN_FORMULA_APPLY share ID 20558
warn: two longnames have the same ID: SID_DRAW_FONTWORK and
RID_SVX_FONTWORK_BAR share ID 10987
warn: two longnames have the same ID: SID_DRAW_TEXT_VERTICAL and
SID_ATTR_CHAR_VERTICAL share ID 10905
warn: two longnames have the same ID: SID_FONTWORK_KERN_CHARACTER_PAIRS and
RID_SVX_EXTRUSION_BAR share ID 10986
warn: two longnames have the same ID: UID_RPT_PROP_FORMULA and
HID_RPT_GROUPSORT_MOVE_UP share ID 64531
warn: two longnames have the same ID:
chart2:TabPage:TP_WIZARD_TITLEANDOBJECTS and
CHART2:FL_GRIDS:TP_WIZARD_TITLEANDOBJECTS share ID 551813120
warn: two longnames have the same ID: dbaccess:TabPage:PAGE_MYSQL_JDBC and
DBACCESS:FT_JDBCDRIVERCLASS:PAGE_MYSQL_JDBC share ID 851771392
warn: two longnames have the same ID: dbaccess:TabPage:PAGE_MYSQL_NATIVE and
DBACCESS:FL_SEPARATOR2:PAGE_MYSQL_NATIVE share ID 851836928
warn: two longnames have the same ID: dbaccess:TabPage:PAGE_ORACLE_JDBC and
DBACCESS:FT_JDBCDRIVERCLASS:PAGE_ORACLE_JDBC share ID 851886080
warn: two longnames have the same ID: extensions:ModalDialog:RID_SANE_DIALOG
and EXTENSIONS:MODALDIALOG:RID_DLG_SELECTLABELCONTROL share ID 1090125824
warn: two longnames have the same ID: filter:ModalDialog:DLG_OPTIONS and
EXTENSIONS:MODALDIALOG:RID_DLG_OEMWIZARD share ID 1090519040
warn: two longnames have the same ID: padmin:ModalDialog:RID_PADIALOG and
EXTENSIONS:MODALDIALOG:RID_SANE_DIALOG share ID 1090125824
warn: two longnames have the same ID: padmin:ModalDialog:RID_PPDIMPORT_DLG
and EXTENSIONS:MODALDIALOG:RID_DLG_NEW_DATA_TYPE share ID 1090191360
warn: two longnames have the same ID: padmin:ModalDialog:RID_STRINGQUERYDLG
and EXTENSIONS:MODALDIALOG:RID_DLG_SELECTION share ID 1090174976
warn: two longnames have the same ID:
padmin:PushButton:RID_PADIALOG:RID_PA_BTN_DEL and
EXTENSIONS:PUSHBUTTON:RID_SANE_DIALOG:RID_DEVICEINFO_BTN share ID 1090130435
warn: two longnames have the same ID:
sd:ModalDialog:RID_SD_DLG_MASTER_LAYOUT and
EXTENSIONS:MODALDIALOG:RID_DLG_TABORDER share ID 1090142208
warn: two longnames have the same ID: svx:ModalDialog:DLG_CHINESEDICTIONARY
and SVX:CB_REVERSE:DLG_CHINESEDICTIONARY share ID 1078673408
warn: two longnames have the same ID: svx:ModalDialog:DLG_CHINESETRANSLATION
and SVX:CB_USE_VARIANTS:DLG_CHINESETRANSLATION share ID 1078657024
warn: two longnames have the same ID: svx:ModalDialog:RID_DEFAULTABOUT and
SVX:ABOUT_BTN_OK:RID_DEFAULTABOUT share ID 1078001664
warn: two longnames have the same ID:
xmlsecurity:PushButton:RID_XMLSECDLG_DIGSIG:BTN_ADDCERT and
PADMIN:PUSHBUTTON:RID_PADIALOG:RID_PA_BTN_STD share ID 1090130434
warn: two longnames have the same ID:
xmlsecurity:PushButton:RID_XMLSECDLG_DIGSIG:BTN_REMOVECERT and
PADMIN:PUSHBUTTON:RID_PADIALOG:RID_PA_BTN_DEL share ID 1090130435
errror: Longname not in hid.lst:
/mnt/newdisk/loffice/build/build/libreoffice-3.2.99.2/solver/330/
unxlngx6.pro/bin/win/dial_d_h.winsw:NumericField:DLG_PAGEPREVIEW_PRINTOPTIONS:NF_ROWS
errror: Longname not in hid.lst:
/mnt/newdisk/loffice/build/build/libreoffice-3.2.99.2/solver/330/
unxlngx6.pro/bin/win/dial_d_h.winsw:NumericField:DLG_PAGEPREVIEW_PRINTOPTIONS:NF_COLS
errror: Longname not in hid.lst:
/mnt/newdisk/loffice/build/build/libreoffice-3.2.99.2/solver/330/
unxlngx6.pro/bin/win/dial_d_h.winsw:MetricField:DLG_PAGEPREVIEW_PRINTOPTIONS:MF_LMARGIN
errror: Longname not in hid.lst:
/mnt/newdisk/loffice/build/build/libreoffice-3.2.99.2/solver/330/
unxlngx6.pro/bin/win/dial_d_h.winsw:MetricField:DLG_PAGEPREVIEW_PRINTOPTIONS:MF_RMARGIN
errror: Longname not in hid.lst:
/mnt/newdisk/loffice/build/build/libreoffice-3.2.99.2/solver/330/
unxlngx6.pro/bin/win/dial_d_h.winsw:MetricField:DLG_PAGEPREVIEW_PRINTOPTIONS:MF_TMARGIN
errror: Longname not in hid.lst:

Re: [Libreoffice] the basic macro editor

2010-10-25 Thread René Kjellerup
finally had time (although not to complete another build) to run the test
again,

the procedure I did was:
Tools-Macros-Organize macros-basic
select Main and click on the Edit button

I've attached the back-trace of the crash

René

On Sun, Oct 24, 2010 at 2:21 PM, Caolán McNamara caol...@redhat.com wrote:

 On Sun, 2010-10-24 at 00:27 +0200, René Kjellerup wrote:
 
  I'm having troubles with the macro editor, when trying to open it
  it crashes soffice.bin

 What dialog exactly, tools-macros-organize macros-basic ? FWIW that's
 working here.

 Might get a more useful backtrace with...


 gdb /mnt/newdisk/loffice/install/program/soffice.bin
 (gdb) run -writer
 get it to crash, and then type bt, i.e.
 (gdb) bt

 C.




-- 
-- as life grows older, I gain experience.
(gdb) run -calc
Starting program: /mnt/newdisk/loffice/install/program/soffice.bin -calc
[Thread debugging using libthread_db enabled]
[New Thread 0x7fffee68b710 (LWP 8393)]
[New Thread 0x7fffe4077710 (LWP 8395)]
[New Thread 0x7fffe2c87710 (LWP 8396)]
[New Thread 0x7fffde7fb710 (LWP 8397)]
[New Thread 0x7fffd7e3c710 (LWP 8401)]
[Thread 0x7fffd7e3c710 (LWP 8401) exited]
[New Thread 0x7fffd7e3c710 (LWP 8402)]
[Thread 0x7fffd7e3c710 (LWP 8402) exited]

Program received signal SIGSEGV, Segmentation fault.
0x77a31265 in rtl_ustr_ascii_compare_WithLength () from 
/mnt/newdisk/loffice/install/program/../basis-link/ure-link/lib/libuno_sal.so.3
(gdb) bt
#0  0x77a31265 in rtl_ustr_ascii_compare_WithLength () from 
/mnt/newdisk/loffice/install/program/../basis-link/ure-link/lib/libuno_sal.so.3
#1  0x7fffd69a78c3 in 
basctl::DocumentEventNotifier_Impl::notifyEvent(com::sun::star::document::EventObject
 const) () from /mnt/newdisk/loffice/install/basis3.3/program/libbasctllx.so
#2  0x75300a9a in void 
cppu::OInterfaceContainerHelper::notifyEachcom::sun::star::document::XEventListener,
 com::sun::star::document::EventObject(void 
(com::sun::star::document::XEventListener::*)(com::sun::star::document::EventObject
 const), com::sun::star::document::EventObject const) () from 
/mnt/newdisk/loffice/install/program/../basis-link/program/libsfxlx.so
#3  0x752f8eb7 in 
SfxGlobalEvents_Impl::implts_notifyListener(com::sun::star::document::DocumentEvent
 const) ()
   from /mnt/newdisk/loffice/install/program/../basis-link/program/libsfxlx.so
#4  0x752fe774 in 
SfxGlobalEvents_Impl::notifyEvent(com::sun::star::document::EventObject const) 
() from /mnt/newdisk/loffice/install/program/../basis-link/program/libsfxlx.so
#5  0x75218b04 in SfxBaseModel::postEvent_Impl(rtl::OUString) () from 
/mnt/newdisk/loffice/install/program/../basis-link/program/libsfxlx.so
#6  0x7522abfb in SfxBaseModel::Notify(SfxBroadcaster, SfxHint const) 
() from /mnt/newdisk/loffice/install/program/../basis-link/program/libsfxlx.so
#7  0x74daf6a4 in SfxBroadcaster::Broadcast(SfxHint const) () from 
/mnt/newdisk/loffice/install/program/../basis-link/program/libsvllx.so
#8  0x751aae4d in SfxObjectShell::SetInitialized_Impl(bool) () from 
/mnt/newdisk/loffice/install/program/../basis-link/program/libsfxlx.so
#9  0x751c263f in SfxObjectShell::DoInitNew(SfxMedium*) () from 
/mnt/newdisk/loffice/install/program/../basis-link/program/libsfxlx.so
#10 0x7510d00a in SfxApplication::OfaExec_Impl(SfxRequest) () from 
/mnt/newdisk/loffice/install/program/../basis-link/program/libsfxlx.so
#11 0x752d547e in SfxShell::CallExec(void (*)(SfxShell*, SfxRequest), 
SfxRequest) () from 
/mnt/newdisk/loffice/install/program/../basis-link/program/libsfxlx.so
#12 0x752e91c5 in SfxShell::ExecuteSlot(SfxRequest, SfxInterface 
const*) () from 
/mnt/newdisk/loffice/install/program/../basis-link/program/libsfxlx.so
#13 0x7fffd69844a9 in MacroChooser::ButtonHdl(Button*) () from 
/mnt/newdisk/loffice/install/basis3.3/program/libbasctllx.so
#14 0x733a46ae in Control::ImplCallEventListenersAndHandler(unsigned 
long, Link const, void*) () from 
/mnt/newdisk/loffice/install/program/../basis-link/program/libvcllx.so
#15 0x73392813 in Window::EndTracking(unsigned short) () from 
/mnt/newdisk/loffice/install/program/../basis-link/program/libvcllx.so
#16 0x7338dcca in ImplHandleMouseEvent(Window*, unsigned short, 
unsigned char, long, long, unsigned long, unsigned short, unsigned short) ()
   from /mnt/newdisk/loffice/install/program/../basis-link/program/libvcllx.so
#17 0x7339011d in ImplHandleSalMouseButtonUp(Window*, SalMouseEvent*) 
() from /mnt/newdisk/loffice/install/program/../basis-link/program/libvcllx.so
#18 0x7338f008 in ImplWindowFrameProc(Window*, SalFrame*, unsigned 
short, void const*) () from 
/mnt/newdisk/loffice/install/program/../basis-link/program/libvcllx.so
#19 0x7fffedc65fb9 in GtkSalFrame::signalButton(_GtkWidget*, 
_GdkEventButton*, void*) () from 
/mnt/newdisk/loffice/install/basis3.3/program/libvclplug_gtklx.so
#20 0x7fffed751988 in ?? () from /usr/lib

[Libreoffice] translations in calc/sc and DBG_* clean up

2010-10-21 Thread René Kjellerup
hi' all

while looking for the formula functions and such I decided to do a few more
translations and minor clean up

it's nice looking in to the code
all my bests
René
-- 
-- as life grows older, I gain experience.
diff --git a/sc/source/core/data/document.cxx b/sc/source/core/data/document.cxx
index 517c1d1..077109a 100644
--- a/sc/source/core/data/document.cxx
+++ b/sc/source/core/data/document.cxx
@@ -127,10 +127,10 @@ void ScDocument::MakeTable( SCTAB nTab,bool 
_bNeedsNameCheck )
 {
 if ( ValidTab(nTab)  !pTab[nTab] )
 {
-String aString = ScGlobal::GetRscString(STR_TABLE_DEF); //Tabelle
+String aString = ScGlobal::GetRscString(STR_TABLE_DEF); //Table
 aString += String::CreateFromInt32(nTab+1);
 if ( _bNeedsNameCheck )
-CreateValidTabName( aString ); // keine doppelten
+CreateValidTabName( aString ); // no doubles
 
 pTab[nTab] = new ScTable(this, nTab, aString);
 pTab[nTab]-SetLoadingMedium(bLoadingMedium);
@@ -272,18 +272,17 @@ void ScDocument::CreateValidTabName(String rName) const
 {
 if ( !ValidTabName(rName) )
 {
-// neu erzeugen
+// Find new one
 
 const String aStrTable( ScResId(SCSTR_TABLE) );
 BOOLbOk   = FALSE;
 
-// vorneweg testen, ob der Prefix als gueltig erkannt wird
-// wenn nicht, nur doppelte vermeiden
+// First test if the prefix is valid, if so only avoid doubles
 BOOL bPrefix = ValidTabName( aStrTable );
-DBG_ASSERT(bPrefix, ungueltiger Tabellenname);
+OSL_ENSURE(bPrefix, Invalid Table Name);
 SCTAB nDummy;
 
-SCTAB nLoops = 0;  // zur Sicherheit
+SCTAB nLoops = 0;  // for safety messures
 for ( SCTAB i = nMaxTableNumber+1; !bOk  nLoops = MAXTAB; i++ )
 {
 rName  = aStrTable;
@@ -295,13 +294,13 @@ void ScDocument::CreateValidTabName(String rName) const
 ++nLoops;
 }
 
-DBG_ASSERT(bOk, kein gueltiger Tabellenname gefunden);
+OSL_ENSURE(bOk, No Valid Table name found.);
 if ( !bOk )
 rName = aStrTable;
 }
 else
 {
-// uebergebenen Namen ueberpruefen
+// testing the surplied Name
 
 if ( !ValidNewTabName(rName) )
 {
@@ -326,7 +325,7 @@ BOOL ScDocument::InsertTab( SCTAB nPos, const String rName,
 {
 SCTAB  nTabCount = GetTableCount();
 BOOL   bValid = ValidTab(nTabCount);
-if ( !bExternalDocument )  // sonst rName == 'Doc'!Tab, vorher pruefen
+if ( !bExternalDocument )  // else test rName == 'Doc'!Tab first
 bValid = (bValid  ValidNewTabName(rName));
 if (bValid)
 {
@@ -413,7 +412,7 @@ BOOL ScDocument::DeleteTab( SCTAB nTab, ScDocument* 
pRefUndoDoc )
 if (nTabCount  1)
 {
 BOOL bOldAutoCalc = GetAutoCalc();
-SetAutoCalc( FALSE );  // Mehrfachberechnungen vermeiden
+SetAutoCalc( FALSE );  // avoid multiple calculations
 ScRange aRange( 0, 0, nTab, MAXCOL, MAXROW, nTab );
 DelBroadcastAreasInRange( aRange );
 
@@ -468,8 +467,8 @@ BOOL ScDocument::DeleteTab( SCTAB nTab, ScDocument* 
pRefUndoDoc )
 for (i = 0; i = MAXTAB; i++)
 if (pTab[i])
 pTab[i]-UpdateCompile();
-// Excel-Filter loescht einige Tables waehrend des Ladens,
-// Listener werden erst nach dem Laden aufgesetzt
+// Excel-Filter deletes some Tables while loading, Listeners 
will
+// only be triggered after the loading is done.
 if ( !bInsertingFromOtherDoc )
 {
 for (i = 0; i = MAXTAB; i++)
@@ -498,7 +497,7 @@ BOOL ScDocument::RenameTab( SCTAB nTab, const String 
rName, BOOL /* bUpdateRef
 if (pTab[nTab])
 {
 if ( bExternalDocument )
-bValid = TRUE; // zusammengesetzter Name
+bValid = TRUE; // composed name
 else
 bValid = ValidTabName(rName);
 for (i=0; (i=MAXTAB)  bValid; i++)
@@ -605,7 +604,7 @@ void ScDocument::SetLayoutRTL( SCTAB nTab, BOOL bRTL )
 if (pDrawLayer)
 {
 SdrPage* pPage = 
pDrawLayer-GetPage(static_castsal_uInt16(nTab));
-DBG_ASSERT(pPage,Page ?);
+OSL_ENSURE(pPage,Page ?);
 if (pPage)
 {
 SdrObjListIter aIter( *pPage, IM_DEEPNOGROUPS );
@@ -646,12 +645,12 @@ BOOL ScDocument::IsNegativePage( SCTAB nTab ) const
 
 
 /* 
-benutzten Bereich suchen:
+used search area:
 
-GetCellArea - nur Daten
-GetTableArea - Daten / Attribute
-GetPrintArea - beruecksichtigt auch Zeichenobjekte,
-streicht Attribute bis 

Re: [Libreoffice] Building on gentoo ...

2010-10-20 Thread René Kjellerup
As for disable it per default, look at another enable clause. But the quick
glance at it tells me the then and else blocks needs to be reversed
if test z$enable_kde != zyes; then
   orig else block
else
   orig then block
fi

Hope it makes sense
René
On Oct 20, 2010 8:00 PM, Wols Lists antli...@youngman.org.uk wrote:
 On 20/10/10 14:39, Wols Lists wrote:
 On 20/10/10 08:28, Sebastian Spaeth wrote:
 On Tue, 19 Oct 2010 23:45:11 +0200, René Kjellerup 
rk.katana.st...@gmail.com wrote:

 On the other matter unless you're still running kde 3 then you need
 --disable-kde else the config will fail when it can't find Qt 3.x
 On that matter can, we please --disable-kde by default. I don't know of
 recent distros that ship kde3 but not KDE4, and those who do can turn it
 on in their distro-specific defaults.
 Forgive the newbie question, but while I've got a lot of programming
 experience large chunks of detail here (gnu tools, frinstance) are new
 to me.

 I've dug a bit, found configure.in, and found

 AC_ARG_ENABLE(kde,
 [
 --disable-kde Disables KDE native widgets.],
 ,)

 Does this switch it on? Will deleting it disable kde by default?

 If it will, I'll put a patch in.
 Even better, our make should detect the lack of qt3 headers and disable
 it automatically rather than bailing out.
 That's a bit deeper ... won't stop me having a go if someone would care
 to give me a few guidelines :-)

 Sebastian

 Cheers,
 Wol
 ___


 Just found a bit more ...

 if test $enable_kde != no; then
 if test z$with_win32 = z -a z`uname -s` != zDarwin -a
 z$with_distro != zCrossWin32; then
 OOO_WIDGET_FLAGS=--enable-kde
 widget_sets=kde
 fi
 else
 OOO_WIDGET_FLAGS=--disable-kde
 fi

 I'm going to try changing != no to = yes - is that a sensible thing
 to do? I'm sure it'll work for me, but will it make it blow up when
 people want kde3 - does enable default to a value of yes?

 Cheers,
 Wol
 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] Building on gentoo ...

2010-10-19 Thread René Kjellerup
Yeah, I even tried installing junit too.
On the other matter unless you're still running kde 3 then you need
--disable-kde else the config will fail when it can't find Qt 3.x
On Oct 19, 2010 10:01 PM, Wols Lists antli...@youngman.org.uk wrote:
 On 18/10/10 23:34, René Kjellerup wrote:

 I've build on gentle, I had to disable kde to do so --enable-kde=no
 --enable-kde4=no --without-junit


 Hmm .. I've just hit the junit problem too - another little fix needed
 for the develop page ...

 The Bests
 René


 Cheers,
 Wol

 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] Dynamic arrays in chartitempool

2010-10-16 Thread René Kjellerup
added the SAL_N_ELEMENTS to construction and destruction, removed unused
code and includes

I removed some commented OSL_TRACE statements... but were they really needed
still?

best wishes
René

On Sat, Oct 16, 2010 at 6:47 PM, René Kjellerup
rk.katana.st...@gmail.comwrote:

 Wow... a simple symbol mistake of the brain, all the includes seemed to
 have hxx extension so

 It complies now pulling a diff together.
  On Oct 16, 2010 3:30 PM, René Kjellerup rk.katana.st...@gmail.com
 wrote:
  Okay I've now a beginning of a build of chart2 and I've added:
  #include sal/macros.h
  To the file, but the compilation says that the file is not found,
  So where do one add the sal depends to the module? (or simply the
 includes)
  On Oct 14, 2010 10:11 PM, Michael Meeks michael.me...@novell.com
 wrote:
  Hi Rene,
 
  On Thu, 2010-10-14 at 19:05 +0200, René Kjellerup wrote:
  I've looked through the calc's chart2 source and translated and spell
  corrected a few comments in the view code
 
  Cool - nice work thanks for that; I pushed it.
 
  in the ChartItemPool I've added the use of SAL_N_ELEMENTS(array) too
 
  Yep; the slight issue here though is that we need to re-arrange the
  code a bit. Your changes would work, but only if SCH_ATTR_START == 0 -
  since the range is offset otherwise. It would work if we had:
 
  - for( i = SCHATTR_START; i = SCHATTR_END; i++ )
  + for( i = 0; i = SAL_N_ELEMENTS(pItemInfos); i++ )
  {
  - pItemInfos[i - SCHATTR_START]._nSID = 0;
  + pItemInfos[i]._nSID = 0;
 
  etc. ;-) it could perhaps be re-factored like that if you want, but
  prolly best to compile/test it.
 
  Anyhow - thanks for your work ! looking forward to what you work on
  next - is there any area of LibreOffice you're particularly interested
  in contributing to ?
 
  All the best,
 
  Michael.
 
  --
  michael.me...@novell.com , Pseudo Engineer, itinerant idiot
 
 




-- 
-- as life grows older, I gain experience.
diff --git a/chart2/source/inc/chartview/ChartSfxItemIds.hxx 
b/chart2/source/inc/chartview/ChartSfxItemIds.hxx
index 86871a5..ec62da1 100644
--- a/chart2/source/inc/chartview/ChartSfxItemIds.hxx
+++ b/chart2/source/inc/chartview/ChartSfxItemIds.hxx
@@ -29,15 +29,11 @@
 
 #include sfx2/sfxdefs.hxx
 
-/*
-// header for SID_OBJ1_START
-#include sfx2/sfxsids.hrc
-*/
-
 // 
 // SCHATTR
 // 
 
+// can't this be changed to 0?
 #define SCHATTR_START  1
 
 #define SCHATTR_DATADESCR_STARTSCHATTR_START
@@ -56,8 +52,7 @@
 #define SCHATTR_LEGEND_END 
SCHATTR_LEGEND_POS
 
 #define SCHATTR_TEXT_START 
(SCHATTR_LEGEND_END + 1)
-// #define SCHATTR_TEXT_ORIENT 
SCHATTR_TEXT_START
-// name changed:
+// name changed, was SCHATTR_TEXT_ORIENT:
 #define SCHATTR_TEXT_STACKED   SCHATTR_TEXT_START
 #define SCHATTR_TEXT_ORDER 
(SCHATTR_TEXT_START + 1)
 #define SCHATTR_TEXT_END   
SCHATTR_TEXT_ORDER
@@ -124,7 +119,7 @@
 
 #define SCHATTR_TEXT2_START ( SCHATTR_STAT_END + 1)
 #define SCHATTR_TEXT_DEGREES( SCHATTR_TEXT2_START   )
-#define SCHATTR_TEXT_OVERLAP(SCHATTR_TEXT2_START +1)
+#define SCHATTR_TEXT_OVERLAP( SCHATTR_TEXT2_START +1 )
 #define SCHATTR_TEXT2_END   ( SCHATTR_TEXT_OVERLAP )
 
 // 
@@ -153,7 +148,7 @@
 // --
 
 #define SCHATTR_AXIS   (SCHATTR_STYLE_END + 
1)// see chtmodel.hxx defines CHART_AXIS_PRIMARY_X, etc.
-//Ummappen:
+//Re-mapped:
 #define SCHATTR_AXIS_START (SCHATTR_AXIS + 1)
 #define SCHATTR_AXIS_AUTO_MIN   SCHATTR_AXIS_START
 #define SCHATTR_AXIS_MIN   (SCHATTR_AXIS_START + 1)
@@ -167,7 +162,7 @@
 #define SCHATTR_AXIS_LOGARITHM (SCHATTR_AXIS_START + 8)
 #define SCHATTR_AXIS_AUTO_ORIGIN   (SCHATTR_AXIS_START + 9)
 #define SCHATTR_AXIS_ORIGIN(SCHATTR_AXIS_START + 
10)
-//Neu:
+//New:
 #define SCHATTR_AXIS_TICKS (SCHATTR_AXIS_START + 
11)
 #define SCHATTR_AXIS_NUMFMT(SCHATTR_AXIS_START + 
12)
 #define SCHATTR_AXIS_NUMFMTPERCENT (SCHATTR_AXIS_START + 13)
@@ -241,8 +236,8 @@
 #define CHART_AXIS_Z2
 
 // values for SCHATTR_STYLE_SHAPE items
-#define CHART_SHAPE3D_IGNORE  -2 //intern! (GetChartShapeStyle()!)
-#define CHART_SHAPE3D_ANY-1 //undefinierter Typ (GetChartShapeStyle()!)
+#define CHART_SHAPE3D_IGNORE  -2 //internal! (GetChartShapeStyle()!)
+#define CHART_SHAPE3D_ANY-1

Re: [Libreoffice] Error Building, vcl segmentation fault

2010-10-15 Thread René Kjellerup
Hi,

I read on the Linux game publishing blog something about forcing gcc to
resolve of the link library location, unfortunate the blog is down for the
time being. However looking at gcc manual, it could have been the -Bprefix
option.

Hope that it might help.

The Best
René
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] Error Building, vcl segmentation fault

2010-10-15 Thread René Kjellerup
A slight correction, a bit of further searching and I found the correct
linker option, namely ld's rpath

Used to force the search path of the dynamic linking
(from gcc: $ gcc -Wl,-rpath=path to the local port of the stl )
On Oct 15, 2010 1:04 PM, René Kjellerup rk.katana.st...@gmail.com wrote:
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] comment translation

2010-10-14 Thread René Kjellerup
hi' Libre Office mailing list,

I've looked through the calc's chart2 source and translated and spell
corrected a few
comments in the view code

in the ChartItemPool I've added the use of SAL_N_ELEMENTS(array) too

greetings
René Kjellerup
(aka Katana Steel)
-- 
-- as life grows older, I gain experience.
diff --git a/chart2/source/view/main/ChartItemPool.cxx 
b/chart2/source/view/main/ChartItemPool.cxx
index face424..f3b6205 100644
--- a/chart2/source/view/main/ChartItemPool.cxx
+++ b/chart2/source/view/main/ChartItemPool.cxx
@@ -131,11 +131,11 @@ ChartItemPool::ChartItemPool():
 ppPoolDefaults[SCHATTR_STYLE_LINES- SCHATTR_START] = new SfxBoolItem 
(SCHATTR_STYLE_LINES, 0);
 ppPoolDefaults[SCHATTR_STYLE_PERCENT  - SCHATTR_START] = new SfxBoolItem 
(SCHATTR_STYLE_PERCENT, 0);
 ppPoolDefaults[SCHATTR_STYLE_STACKED  - SCHATTR_START] = new SfxBoolItem 
(SCHATTR_STYLE_STACKED, 0);
-ppPoolDefaults[SCHATTR_STYLE_SPLINES  - SCHATTR_START] = new SfxInt32Item 
(SCHATTR_STYLE_SPLINES, 0); //Bug: war Bool! -Fileformat testen (betrifft nur 
5er)
+ppPoolDefaults[SCHATTR_STYLE_SPLINES   - SCHATTR_START] = new 
SfxInt32Item (SCHATTR_STYLE_SPLINES, 0); //Bug: was Bool! test -Fileformat 
(touches only 5's)
 ppPoolDefaults[SCHATTR_STYLE_SYMBOL   - SCHATTR_START] = new SfxInt32Item 
(SCHATTR_STYLE_SYMBOL, 0);
 ppPoolDefaults[SCHATTR_STYLE_SHAPE- SCHATTR_START] = new SfxInt32Item 
(SCHATTR_STYLE_SHAPE, 0);
 
-ppPoolDefaults[SCHATTR_AXIS- 
SCHATTR_START] = new SfxInt32Item(SCHATTR_AXIS,2); //2 = Y-Achse!!!
+ppPoolDefaults[SCHATTR_AXIS- 
SCHATTR_START] = new SfxInt32Item(SCHATTR_AXIS,2); //2 = Y-Axis!!!
 
 ppPoolDefaults[SCHATTR_AXIS_AUTO_MIN   - SCHATTR_START] = new 
SfxBoolItem(SCHATTR_AXIS_AUTO_MIN);
 ppPoolDefaults[SCHATTR_AXIS_MIN- 
SCHATTR_START] = new SvxDoubleItem(0.0, SCHATTR_AXIS_MIN);
@@ -201,7 +201,7 @@ ChartItemPool::ChartItemPool():
 pItemInfos = new SfxItemInfo[SCHATTR_END - SCHATTR_START + 1];
 
 USHORT i;
-for( i = SCHATTR_START; i = SCHATTR_END; i++ )
+for( i = SCHATTR_START; i = SAL_N_ELEMENTS(pItemInfos); i++ )
 {
 pItemInfos[i - SCHATTR_START]._nSID = 0;
 pItemInfos[i - SCHATTR_START]._nFlags = SFX_ITEM_POOLABLE;
@@ -229,7 +229,7 @@ ChartItemPool::~ChartItemPool()
 
 delete[] pItemInfos;
 
-const USHORT nMax = SCHATTR_END - SCHATTR_START + 1;
+const USHORT nMax = SAL_N_ELEMENTS(ppPoolDefaults);
 for( USHORT i=0; inMax; ++i )
 {
 SetRefCount(*ppPoolDefaults[i], 0);
diff --git a/chart2/source/view/main/ChartView.cxx 
b/chart2/source/view/main/ChartView.cxx
index 3a55690..c44b819 100644
--- a/chart2/source/view/main/ChartView.cxx
+++ b/chart2/source/view/main/ChartView.cxx
@@ -621,7 +621,7 @@ void 
SeriesPlotterContainer::initializeCooSysAndSeriesPlotter(
   const uno::Reference frame::XModel  xChartModel )
 {
 // get model series from model
-sal_Int32 nDiagramIndex = 0;//todo if more than one diagam is supported
+sal_Int32 nDiagramIndex = 0;//todo if more than one diagram is supported
 uno::Reference XDiagram  xDiagram( ChartModelHelper::findDiagram( 
xChartModel ) );
 if( !xDiagram.is())
 return;
@@ -699,7 +699,7 @@ void 
SeriesPlotterContainer::initializeCooSysAndSeriesPlotter(
 if(pVCooSys)
 pVCooSys-addMinimumAndMaximumSupplier(pPlotter);
 
-// add series to plotter and thus prepare him for 
providing minimum and maximum values
+// add series to plotter and thus prepare him(it) for 
providing minimum and maximum values
 uno::Reference XDataSeriesContainer  xDataSeriesContainer( 
xChartType, uno::UNO_QUERY );
 OSL_ASSERT( xDataSeriesContainer.is());
 if( !xDataSeriesContainer.is() )
@@ -860,7 +860,7 @@ void SeriesPlotterContainer::setScalesFromCooSysToPlotter()
 
 void SeriesPlotterContainer::setNumberFormatsFromAxes()
 {
-//set numberfarmats to plotter to enable them to display the data labels 
in the numberfromat of teh axis
+//set numberformats to plotter to enable them to display the data labels 
in the numberformat of the axis
 
 ::std::vector VSeriesPlotter* ::const_iterator   aPlotterIter = 
m_aSeriesPlotterList.begin();
 const ::std::vector VSeriesPlotter* ::const_iterator aPlotterEnd  = 
m_aSeriesPlotterList.end();
@@ -1851,7 +1851,7 @@ sal_Int32 lcl_getExplicitNumberFormatKeyForAxis(
 
 if( nDimensionIndex == 1 )
 {
-//only take those series into accoutn that are 
attached to this axis
+//only take those series into account that are 
attached to this axis
 sal_Int32 nAttachedAxisIndex = 
DataSeriesHelper::getAttachedAxisIndex(xDataSeries