[Bug 148415] More detailed, better explained loplugin errors

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148415

--- Comment #2 from QA Administrators  ---
Dear Gabor Kelemen (allotropia),

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 148252] (LO Calc) Background Colours Malfunction = when an image is sent to background, while Value Highlighting is active

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148252

--- Comment #5 from QA Administrators  ---
Dear David Smith,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 132900] 2 seconds delay when opening customize dialog the first time (Windows-only)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132900

--- Comment #28 from QA Administrators  ---
Dear Dieter,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 131414] FILESAVE PPT: video insertion in slideshow (Comment 20)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131414

--- Comment #21 from QA Administrators  ---
Dear bachibouzouc,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120978] dxf file missing text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120978

--- Comment #9 from QA Administrators  ---
Dear david chen,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 121792] Main table inherits table style of the inserted embedded table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121792

--- Comment #7 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 114390] Enter can't be assigned to insert a manual row break

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114390

--- Comment #9 from QA Administrators  ---
Dear Sophie Freud,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 109526] FILEOPEN: ODT: Glitches displayed on first time at import time

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109526

--- Comment #6 from QA Administrators  ---
Dear Xisco Faulí,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 107002] EDITING: Selecting multiple slide transitions in a row will rendered all transitions sequentially

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107002

--- Comment #11 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 108728] [META] Dictionaries bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108728
Bug 108728 depends on bug 151914, which changed state.

Bug 151914 Summary: Allow to add / edit words with tags in custom dictionaries
https://bugs.documentfoundation.org/show_bug.cgi?id=151914

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|NOTABUG |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 96000] [META] Spelling checking bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96000
Bug 96000 depends on bug 151914, which changed state.

Bug 151914 Summary: Allow to add / edit words with tags in custom dictionaries
https://bugs.documentfoundation.org/show_bug.cgi?id=151914

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|NOTABUG |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 151914] Allow to add / edit words with tags in custom dictionaries

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151914

Shantanu  changed:

   What|Removed |Added

 Resolution|NOTABUG |---
 Status|RESOLVED|REOPENED

--- Comment #8 from Shantanu  ---
>> "crowdfund" is the new word (missing from the American English dictionary), 
>> and "fund" is the model word in the new "Grammar By" field.

This enhancement request suggest that please allow crowdfund/xy (assuming the
original dict file has an entry like fund/xy)
Using hunspell tags directly in custom dict is very useful option for
power-users. They do not need to guess the matching entry. If no tags are used
then the user is free to use "Grammar By" option.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161405] New: ScriptForge's RunApplication functions cannot be opened if the filename contains CJK

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161405

Bug ID: 161405
   Summary: ScriptForge's RunApplication functions cannot be
opened if the filename contains CJK
   Product: LibreOffice
   Version: 24.8.0.0 alpha1+ Master
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: BASIC
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tac...@hotmail.co.jp

Description:
ScriptForge's RunApplication functions cannot be opened if the filename
contains CJK.

Steps to Reproduce:
1. open new calc and save as "D:\表.ods"
2. execute basic macro

Sub OpenFile_hyou_jp
  GlobalScope.BasicLibraries.LoadLibrary("ScriptForge")
 Dim session As Variant
  session = CreateScriptService("Session")
  session.RunApplication("D:\表.ods")
End Sub

Actual Results:
3. Error
The following script will also fail.
  session.RunApplication(ConvertToURL("D:\表.ods"))

Expected Results:
3. Open "D:\表.ods".


Reproducible: Always


User Profile Reset: No

Additional Info:
The script below works.
Sub OpenFile_hyou_jp_Shell
  Shell("soffice.exe", 1, "D:\表.ods")
End Sub

Reproducible with
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: f4ef5435df5560e6b6b061ce4053c71e2819bf51
CPU threads: 4; OS: Windows 10.0 Build 10240; UI render: Skia/Raster; VCL: win
Locale: ja-JP (ja_JP); UI: ja-JP
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161339] UI freeze when saving

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161339

Tracey C  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #3 from Tracey C  ---
I am experiencing this same bug with Libre Office 24.2.2.2. I'm happy to
provide any information that might help the developers fix this.

Version: 24.2.2.2 (X86_64) / LibreOffice Community
Build ID: 420(Build:2)
CPU threads: 16; OS: Linux 6.8; UI render: default; VCL: kf6 (cairo+xcb)
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

I was only able to reproduce this on Plasma 6, not the Budgie desktop
environment (on Linux).

When launching from command line, I see this output after the freeze:


❯ libreoffice --calc


qt.core.qobject.connect: QObject::connect: No such signal
Solid::Backends::Fstab::FstabStorageAccess::repairRequested(QString)
qt.core.qobject.connect: QObject::connect: No such signal
Solid::Backends::Fstab::FstabStorageAccess::repairDone(Solid::ErrorType,
QVariant, QString)
kf.kio.filewidgets.kfilefiltercombo: Could not find file filter
QAbstractAnimation::pause: Cannot pause a stopped animation



System information
Operating System: Solus 4.5
KDE Plasma Version: 6.0.5
KDE Frameworks Version: 6.2.0
Qt Version: 6.7.1
Kernel Version: 6.8.11-292.current (64-bit)
Graphics Platform: X11

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161404] Background is sometimes saved sometimes not saved with exporting from Draw as PNG

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161404

--- Comment #3 from DrC  ---
Created attachment 194531
  --> https://bugs.documentfoundation.org/attachment.cgi?id=194531=edit
this one turned out without a backfround

I tried w/ and w/o transparency and got the same output

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161404] Background is sometimes saved sometimes not saved with exporting from Draw as PNG

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161404

--- Comment #2 from DrC  ---
Created attachment 194530
  --> https://bugs.documentfoundation.org/attachment.cgi?id=194530=edit
this one turned out the way I expected

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161404] Background is sometimes saved sometimes not saved with exporting from Draw as PNG

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161404

--- Comment #1 from DrC  ---
Created attachment 194529
  --> https://bugs.documentfoundation.org/attachment.cgi?id=194529=edit
source file (draw file)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161404] New: Background is sometimes saved sometimes not saved with exporting from Draw as PNG

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161404

Bug ID: 161404
   Summary: Background is sometimes saved sometimes not saved with
exporting from Draw as PNG
   Product: LibreOffice
   Version: 24.2.3.2 release
  Hardware: x86-64 (AMD64)
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kevin.coo...@gmail.com

Description:
I exported a very simple diagram as PNG. my artistic efforts were limited to
giving a 0.5" x 1" page a blue background and a text box with three characters.
 When I export it as a PNG (default settings except I changed the DPI to 300). 
I change one character, re-export it with the same settings and now it has no
background (which is  problem since the characters are white...makes it really
hard to see).  It seemed like switching off the save transparency fixed the
problem--but the next time I went to save something (granted I had chanced a
whole two characters this time!) it did not matter whether it was selected or
not (there is no transparency in the background color, BTW).  So, a bit
perplexed why sometimes it saves the page background color when it exports to
PNG and otherwise doesn't bother.

Steps to Reproduce:
1. Export -> PNG -> works
2. Export -> PNG -> does not work
3. Export -> PNG -> maybe works

Actual Results:
No background /transparent.

Expected Results:
My background color


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 24.2.3.2 (X86_64) / LibreOffice Community
Build ID: 420(Build:2)
CPU threads: 8; OS: Linux 6.9; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 155251] Relative size of image changes when opening image properties & pressing OK without touching anything

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155251

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #7 from Stéphane Guillou (stragu) 
 ---
Verified in:

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 1f15d097cace14ca6e44e7652f460aa3fa7bd150
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

No change in size, but still an "Apply attributes" undo step - which I feel is
pretty standard in many dialogs when clicking OK without changing anything. Not
the focus here anyway.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159746] MacMini M2Pro (Mac OS Sonoma 14.3.1) HUNG while editing a .docx document using LibreOffice Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159746

Patrick Luby (volunteer)  changed:

   What|Removed |Added

 CC||guibomac...@gmail.com

--- Comment #12 from Patrick Luby (volunteer)  ---
(In reply to Alex Thurgood from comment #9)
> The Apple dump file you provided shows a sigtramp being generated:
> 
>   11  -[AquaA11yWrapper accessibilityAttributeNames] + 272
> (libvclplug_osxlo.dylib + 290612) [0x100aeef34]
>   11  SwAccessibleGraphic::getAccessibleRole() + 60 (libswlo.dylib + 87324)
> [0x3b91d951c]
>   11  _sigtramp + 56 (libsystem_platform.dylib + 14884) [0x186bc1a24]
>   11  (anonymous namespace)::signalHandlerFunction(int, __siginfo*, void*) +
> 152 (libuno_sal.dylib.3 + 213896) [0x100e14388]
>   11  callSignalHandler(oslSignalInfo*) + 40 (libuno_sal.dylib.3 + 33280)
> [0x100de8200]
>   11  VCLExceptionSignal_impl(void*, oslSignalInfo*) + 340 (libvcllo.dylib +
> 4077336) [0x1058df718]
> 
> related to the accessibility code, but this might be a red herring.

I cannot reproduce this bug with my local build, but the above snippet of dump
file looks like LibreOffice's macOS accessibility code is trying to query a
LibreOffice object that has already been deleted.

I recently committed a fix for a similar "macOS querying deleted LibreOffice
objects" bug while working on tdf#158914. That fix will be in the upcoming
LibreOffice 24.2.4 release (expected release is within the next week).

When LibreOffice 24.2.4 is released, can you see if the bug still exists in
that version?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 89606] [META] Table of Contents and Indexes bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89606

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||161150


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=161150
[Bug 161150] Rename "phonetic reading"
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 83066] [META] CJK (Chinese, Japanese, Korean, and Vietnamese) language issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83066

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||161150


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=161150
[Bug 161150] Rename "phonetic reading"
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161150] Rename "phonetic reading"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161150

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Blocks||83066, 89606
 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #2 from Stéphane Guillou (stragu) 
 ---
Looks like it's mostly used for the Index Entry dialog. See:
* source:
https://opengrok.libreoffice.org/search?project=core=%22phonetic+reading%22===1=full=full
* help page:
https://help.libreoffice.org/latest/en-US/text/swriter/01/04120100.html

>From help page:

> # Phonetic reading
> Enter the phonetic reading for the corresponding entry. For example, if a
> Japanese Kanji word has more than one pronunciation, enter the correct 
> pronunciation as a Katakana word. The Kanji word is then sorted according to 
> the phonetic reading entry. This option is only available if Asian language 
> support is enabled.

To see it in the UI:
1. Tools > Options > Languages and Locales > Default languages for documents >
Asian (ticked)
2. Insert > Table of Contents and Index > Index Entry

I see how some might want to make the wording more consistent with the Asian
Phonetic Guide feature, but my understanding is that Rubi characters refer to
text annotations and their placement along text, whereas the Index dialog only
refers to prononciation for sorting. So maybe the wording needs to remain
distinct.

(In reply to Tuomas Hietala from comment #0) 
> In LO, it appears to be related to the readings of Japanese kanji. In
> English, the readings of kanji are called just "readings", though:
> https://en.wikipedia.org/wiki/Kanji#Readings
> I suggest that "phonetic reading" should be changed to "reading", unless it
> for some reason refers to e.g. on'yomi specifically (as opposed to
> kun'yomi), in which case it would be better to change it to "on'yomi".

I'm wondering if it should be kept generic, e.g. using the term
"pronunciation", as users might use the feature for other languages than
Japanese.

(I have no first-hand knowledge of CJK languages so would refer to the language
communities here.)


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=83066
[Bug 83066] [META] CJK (Chinese, Japanese, Korean, and Vietnamese) language
issues
https://bugs.documentfoundation.org/show_bug.cgi?id=89606
[Bug 89606] [META] Table of Contents and Indexes bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 108456] [META] Style modify dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108456

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||161388


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=161388
[Bug 161388] Rename 'Organizer' to 'General' in style dialogs
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161402] [LOCALHELP] Rename 'Organizer' to 'General' in style dialogs Help pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161402

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||stephane.guillou@libreoffic
   ||e.org
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=16
   ||1388
 Status|UNCONFIRMED |NEW

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
Since bug 161388 and 797e879990f9db3373197a5a83639ad5aebba8c8.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161398] auto-filter very slow

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161398

--- Comment #3 from ady  ---
I can reproduce the problem on MS Windows too with recent LO 24.8 alpha.

Anything I do with attachment 194528 is slow. Even opening the file is so slow
that Calc does not respond for several seconds (i.e. it temporarily hangs).

After testing several features, I found out that:
1. removing the second worksheet, named "lookup",
2. then save the file, close and reopen it,

...anything that was slow before is now much, much faster.

I am not saying that other factors are not relevant, but the factor that
impacted more was removing the second worksheet.

So, maybe the formula on the "lookup" worksheet is what makes everything slow,
and not the AutoFilter in particular.

If others can confirm the behavior I am describing, then the Summary field
should be changed from the current "auto-filter very slow" into something more
relevant to what actually makes attachment 194528 so slow (up to temporal
hanging) in Calc.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161398] auto-filter very slow

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161398

--- Comment #2 from Pierre Fortin  ---
Created attachment 194528
  --> https://bugs.documentfoundation.org/attachment.cgi?id=194528=edit
spreadsheet which has issue

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 1f15d097cace14ca6e44e7652f460aa3fa7bd150
CPU threads: 20; OS: Linux 6.6; UI render: default; VCL: kf5 (cairo+wayland)
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded Jumbo

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: svtools/source

[Caolán McNamara (via logerrit)]

 svtools/source/control/scrolladaptor.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 8501cb20627e5bc36d760b53b0990f4105c4ff65
Author: Caolán McNamara 
AuthorDate: Mon Jun 3 21:30:52 2024 +0100
Commit: Caolán McNamara 
CommitDate: Tue Jun 4 00:43:18 2024 +0200

tdf#160844 we don't want scrollbars to be a target for Ctrl+F6, etc

Change-Id: Ie24c10fa16889a70717cbee15aef38a20308934d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168390
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/svtools/source/control/scrolladaptor.cxx 
b/svtools/source/control/scrolladaptor.cxx
index 98c4fe7d672c..290468254149 100644
--- a/svtools/source/control/scrolladaptor.cxx
+++ b/svtools/source/control/scrolladaptor.cxx
@@ -24,6 +24,8 @@ ScrollAdaptor::ScrollAdaptor(vcl::Window* pWin, bool bHoriz)
 , m_xScrollBar(m_xBuilder->weld_scrollbar(bHoriz ? u"horizontal"_ustr : 
u"vertical"_ustr))
 , m_bHori(bHoriz)
 {
+// tdf#160844 we don't want scrollbars to be a default target for Ctrl+F6, 
etc
+SetStyle(GetStyle() & ~WB_TABSTOP);
 m_xScrollBar->show();
 SetSizePixel(GetOptimalSize());
 }

[Bug 161394] The buttons on some spreadsheets with embedded images go to a solid colour obscuring the button's text.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161394

--- Comment #3 from Michael  ---
I just realized one other thing. If the Sacramento spreadsheet is saved with
"good buttons", it is about 13 M in size. When the spreadsheet is opened,
the buttons will be opaque. If the spreadsheet is then saved, the size of
the spreadsheet will be twice as large. The image files are about 13 M in
size.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 151878] LibreCalc buttons change color, horizontal lines from the top and bottoms of buttons radiate across a background image and buttons briefly appear and disappear in the wrong place.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151878

--- Comment #19 from Michael  ---
(In reply to Michael from comment #18)
> I just realized one other thing. If the Sacramento spreadsheet is saved with
> "good buttons", it is about 13 M in size. When the spreadsheet is opened,
> the buttons will be opaque. If the spreadsheet is then saved, the size of
> the spreadsheet will be twice as large. The image files are about 13 M in
> size.

Sorry, wrong bug. Bad eyes on y part.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 151878] LibreCalc buttons change color, horizontal lines from the top and bottoms of buttons radiate across a background image and buttons briefly appear and disappear in the wrong place.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151878

--- Comment #18 from Michael  ---
I just realized one other thing. If the Sacramento spreadsheet is saved with
"good buttons", it is about 13 M in size. When the spreadsheet is opened, the
buttons will be opaque. If the spreadsheet is then saved, the size of the
spreadsheet will be twice as large. The image files are about 13 M in size.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161403] LibreOffice writer fails in calculations inside table cells when the origin cells are spanned between pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161403

--- Comment #4 from acastan  ---
Created attachment 194527
  --> https://bugs.documentfoundation.org/attachment.cgi?id=194527=edit
file with a table . The cells to add are spanned in two pages. The formula at
left cell add all 10 cells at right.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161384] Insert Rows Above duplicates formatting of next row above

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161384

--- Comment #2 from s...@neonspecter.com ---
This occurs with 24.2.3.2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 157449] add to dictionary -- not like "word" but "word*" wild char...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157449

--- Comment #2 from László Németh  ---
Since LibreOffice 6.0, it's possible to specify a dictionary word for every
custom word to allow affixation and compound word support:

https://wiki.documentfoundation.org/ReleaseNotes/6.0/id#%E2%80%9CGrammar_By%E2%80%9D_spell_checking
 

Screencast:

https://www.youtube.com/watch?v=EsS3gaBTfOo

(In Hungarian: http://libreoffice.hu/innovacio-a-libreoffice-6-0-ban/)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 96000] [META] Spelling checking bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96000
Bug 96000 depends on bug 151914, which changed state.

Bug 151914 Summary: Allow to add / edit words with tags in custom dictionaries
https://bugs.documentfoundation.org/show_bug.cgi?id=151914

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 151914] Allow to add / edit words with tags in custom dictionaries

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151914

László Németh  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |NOTABUG
   Keywords|needsDevEval|

--- Comment #7 from László Németh  ---
Since LibreOffice 6.0, it's possible to specify a dictionary word for every
custom word to allow affixation and compound word support:

https://wiki.documentfoundation.org/ReleaseNotes/6.0/id#%E2%80%9CGrammar_By%E2%80%9D_spell_checking
 

Screencast:

https://www.youtube.com/watch?v=EsS3gaBTfOo

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 108728] [META] Dictionaries bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108728
Bug 108728 depends on bug 151914, which changed state.

Bug 151914 Summary: Allow to add / edit words with tags in custom dictionaries
https://bugs.documentfoundation.org/show_bug.cgi?id=151914

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161403] LibreOffice writer fails in calculations inside table cells when the origin cells are spanned between pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161403

m_a_riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #3 from m_a_riosv  ---
Please attach a sample file, reduce the size as much as possible without
private information, and paste the information in Menu/Help/About LibreOffice,
there is a copy icon.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120883] [META] Hyphenation bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120883
Bug 120883 depends on bug 160518, which changed state.

Bug 160518 Summary: DOCX: fix layout of hyphenated text by supporting 
allowHyphenationAtTrackBottom and useWord2013TrackBottomHyphenation
https://bugs.documentfoundation.org/show_bug.cgi?id=160518

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160518] DOCX: fix layout of hyphenated text by supporting allowHyphenationAtTrackBottom and useWord2013TrackBottomHyphenation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160518

László Németh  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
   Assignee|nem...@numbertext.org   |libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160170] FILEOPEN .DOCX: words pulled together, characters overlap in some line of hyphenated paragraph

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160170

László Németh  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |nem...@numbertext.org
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 77388] Images, inserted in a table cell, go out of cell borders when the document (and thus the table) is zoomed.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=77388

--- Comment #17 from László Németh  ---
Created attachment 194526
  --> https://bugs.documentfoundation.org/attachment.cgi?id=194526=edit
screenshots: also zero padding resulted missing border before

left: missing border because of zero padding (missing left and top borders) and
cropping by cell bondary (missing right and bottom borders).

right: visible borders after the fix

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 77388] Images, inserted in a table cell, go out of cell borders when the document (and thus the table) is zoomed.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=77388

--- Comment #16 from László Németh  ---
Created attachment 194525
  --> https://bugs.documentfoundation.org/attachment.cgi?id=194525=edit
screenshot about the problem (missing border), and its resolution

-- 
You are receiving this mail because:
You are the assignee for the bug.

GSOC More and Better Tests: Weekly Update

[Adam Seskunas]

Hello everyone,

This is my weekly update for More and Better tests. Last week I finished 
porting framework/qa/complex/XTitle/CheckXTitle.java over to CppUnit. The patch 
is in Gerrit here
https://gerrit.libreoffice.org/c/core/+/168168 


Xisco has noted that, if commit 4355137901e18e24de2ab123fd0454147f1f3890 is 
reverted, the test fails, which means the test is working as intended. 
Hopefully having this test in c++ will help anyone in the future who runs into 
a test failure by making the test easier to understand and easier to debug. 

After submitting CheckXTitle to Gerrit, I began working on 
framework/qa/complex/checkdispatchapi.java. After talking it over with Xisco 
and Hossein, it was decided to split this test into two Gerrit submissions, one 
for the database portion and one for everything else in the test suite. The 
database portion of the test suite had been disabled and the hope is to be able 
to get it working in CppUnit again. Submitting it separately will allow some 
time for CI testing while I finish porting the rest of the test suite. As of 
now, I’m close to getting the first part submitted, I’ve been reading the 
Developers Guide database documentation and working on importing the database 
components with a database connection. 

After finishing the porting of checkdispatchapi.java, I tentatively plan to 
start working on framework/qa/complex/api_internal/CheckAPI.java. 

Have a good week,
Adam Seskunas

[Bug 161399] Support Spilled range reference (# operator) in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161399

Óvári  changed:

   What|Removed |Added

Summary|Support Spilled range   |Support Spilled range
   |operator in Calc|reference (# operator) in
   ||Calc

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161399] Support Spilled range operator in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161399

Óvári  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: 2 commits - sc/source sw/source

[Caolán McNamara (via logerrit)]

 sc/source/ui/navipi/content.cxx |2 +-
 sw/source/core/doc/docsort.cxx  |   21 +++--
 2 files changed, 12 insertions(+), 11 deletions(-)

New commits:
commit 2c0157fbe9b9338f98e66d300664fe3c710eb415
Author: Caolán McNamara 
AuthorDate: Mon Jun 3 20:09:16 2024 +0100
Commit: Caolán McNamara 
CommitDate: Mon Jun 3 22:44:16 2024 +0200

cid#1602449 Resource leak

Change-Id: Ide5575adb3346a0ad36a484078dc02ef46a4c043
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168389
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sw/source/core/doc/docsort.cxx b/sw/source/core/doc/docsort.cxx
index df5aaf6e5c89..8f5e70d5110d 100644
--- a/sw/source/core/doc/docsort.cxx
+++ b/sw/source/core/doc/docsort.cxx
@@ -313,7 +313,7 @@ bool SwDoc::SortText(const SwPaM& rPaM, const 
SwSortOptions& rOpt)
 }
 
 std::optional pRedlPam;
-SwUndoRedlineSort* pRedlUndo = nullptr;
+std::unique_ptr xRedlUndo;
 SwUndoSort* pUndoSort = nullptr;
 
 // To-Do - add 'SwExtraRedlineTable' also ?
@@ -328,7 +328,7 @@ bool SwDoc::SortText(const SwPaM& rPaM, const 
SwSortOptions& rOpt)
 {
 if( bUndo )
 {
-pRedlUndo = new SwUndoRedlineSort( *pRedlPam,rOpt );
+xRedlUndo.reset(new SwUndoRedlineSort(*pRedlPam, rOpt));
 GetIDocumentUndoRedo().DoUndo(false);
 }
 // First copy the range
@@ -356,8 +356,8 @@ bool SwDoc::SortText(const SwPaM& rPaM, const 
SwSortOptions& rOpt)
 if (pCNd)
 pRedlPam->GetPoint()->SetContent( nCLen );
 
-if( pRedlUndo )
-pRedlUndo->SetValues( rPaM );
+if (xRedlUndo)
+xRedlUndo->SetValues(rPaM);
 }
 else
 {
@@ -380,7 +380,7 @@ bool SwDoc::SortText(const SwPaM& rPaM, const 
SwSortOptions& rOpt)
 SwNodeOffset nBeg = pStart->GetNodeIndex();
 SwNodeRange aRg( aStart, aStart );
 
-if( bUndo && !pRedlUndo )
+if (bUndo && !xRedlUndo)
 {
 pUndoSort = new SwUndoSort(rPaM, rOpt);
 GetIDocumentUndoRedo().AppendUndo(std::unique_ptr(pUndoSort));
@@ -412,12 +412,13 @@ bool SwDoc::SortText(const SwPaM& rPaM, const 
SwSortOptions& rOpt)
 
 if( pRedlPam )
 {
-if( pRedlUndo )
+SwUndoRedlineSort* pRedlUndo = xRedlUndo.get();
+if (pRedlUndo)
 {
-pRedlUndo->SetSaveRange( *pRedlPam );
+xRedlUndo->SetSaveRange(*pRedlPam);
 // UGLY: temp. enable Undo
 GetIDocumentUndoRedo().DoUndo(true);
-GetIDocumentUndoRedo().AppendUndo( 
std::unique_ptr(pRedlUndo) );
+GetIDocumentUndoRedo().AppendUndo(std::move(xRedlUndo));
 GetIDocumentUndoRedo().DoUndo(false);
 }
 
@@ -437,13 +438,13 @@ bool SwDoc::SortText(const SwPaM& rPaM, const 
SwSortOptions& rOpt)
 // the sorted range is inserted
 getIDocumentRedlineAccess().AppendRedline( new SwRangeRedline( 
RedlineType::Insert, *pRedlPam ), true);
 
-if( pRedlUndo )
+if (pRedlUndo)
 {
 SwNodeIndex aInsEndIdx( pRedlPam->GetMark()->GetNode(), -1 );
 SwContentNode *const pContentNode = 
aInsEndIdx.GetNode().GetContentNode();
 pRedlPam->GetMark()->Assign( *pContentNode, pContentNode->Len() );
 
-pRedlUndo->SetValues( *pRedlPam );
+pRedlUndo->SetValues(*pRedlPam);
 }
 
 pRedlPam.reset();
commit 16b0ad3cf76d9932ebbd169af64b7ad292e68426
Author: Caolán McNamara 
AuthorDate: Mon Jun 3 20:03:07 2024 +0100
Commit: Caolán McNamara 
CommitDate: Mon Jun 3 22:44:08 2024 +0200

cid#1459023 Dereference null return value

Change-Id: I3ff5f121a76a30d07a80b46d469b669010318701
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168388
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/source/ui/navipi/content.cxx b/sc/source/ui/navipi/content.cxx
index 0ae1b45de7ee..c0e06a0f2b01 100644
--- a/sc/source/ui/navipi/content.cxx
+++ b/sc/source/ui/navipi/content.cxx
@@ -386,7 +386,7 @@ IMPL_LINK_NOARG(ScContentTree, ContentDoubleClickHdl, 
weld::TreeView&, bool)
 pParentWindow->SetCurrentCell( aPos.Col(), aPos.Row() );
 // Check whether the comment is currently visible and toggle 
its visibility
 ScDocument* pSrcDoc = GetSourceDocument();
-if (ScPostIt* pNote = pSrcDoc->GetNote(aPos.Col(), aPos.Row(), 
aPos.Tab()))
+if (ScPostIt* pNote = pSrcDoc ? pSrcDoc->GetNote(aPos.Col(), 
aPos.Row(), aPos.Tab()) : nullptr)
 {
 bool bVisible = pNote->IsCaptionShown();
 // Effectivelly set the visibility of the comment

core.git: svx/source

[Caolán McNamara (via logerrit)]

 svx/source/fmcomp/gridctrl.cxx |7 +++
 1 file changed, 7 insertions(+)

New commits:
commit 6f2b5043613bea755f01b413fd86ece0b3a29e5d
Author: Caolán McNamara 
AuthorDate: Mon Jun 3 17:22:21 2024 +0100
Commit: Caolán McNamara 
CommitDate: Mon Jun 3 22:43:45 2024 +0200

crashtesting: BrowseBox::GetControlArea crash

see with forums/ods/forum-en-11050.ods

Change-Id: I2b1dadf51ab8efa1b66f5b7463b05ad4dc52f91d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168386
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/svx/source/fmcomp/gridctrl.cxx b/svx/source/fmcomp/gridctrl.cxx
index faedec67aa66..b6fb24d05df7 100644
--- a/svx/source/fmcomp/gridctrl.cxx
+++ b/svx/source/fmcomp/gridctrl.cxx
@@ -817,11 +817,15 @@ void DbGridControl::dispose()
 
 m_aBar.disposeAndClear();
 
+m_aRearrangeIdle.Stop();
+
 EditBrowseBox::dispose();
 }
 
 void DbGridControl::RearrangeAtIdle()
 {
+if (isDisposed())
+return;
 m_aRearrangeIdle.Start();
 }
 
@@ -2642,6 +2646,9 @@ IMPL_LINK_NOARG(DbGridControl, OnDelete, void*, void)
 
 IMPL_LINK_NOARG(DbGridControl, RearrangeHdl, Timer*, void)
 {
+if (isDisposed())
+return;
+
 // and give it a chance to rearrange
 Point aPoint = GetControlArea().TopLeft();
 sal_uInt16 nX = static_cast(aPoint.X());

[Bug 148154] Reordering Conditional Formats in Manage CF dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148154

--- Comment #6 from barruel  ---
It is worth noticing that the condition being applied is always the matching
condition with an older creation date.

This is a nightmare when it comes to manage even an amount as small as 2 o 3
overlapping ranges.

I've just found out that editing the conditions for a range or even the range
itself doesn't change the creation date of the rule. Because there is no way to
debug the priority of the rules, this leads to the weird situation that it
becomes easier and faster to delete the whole range than to edit it, which
won't change priority because the ranges, even when edited, keep their original
creation date and thus the priority remains unchanged.

In the current state of the main "Manage conditional formatting" dialog, it is
impossible to tell which is the priority with which the ranges (with their set
of rules) are being applied. If not a way to change the priorities in such
dialog, at least an indication of which range is older and is then taking
priority is absolutely needed, because otherwise the is no point in changing
the ranges when there are overlapping ranges involved. Even with a couple of up
and down buttons to reorder the ranges as proposed above, they would be
meaningless if the creation date of the range (which determines its priority)
or a number showing the priority is not shown.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161403] LibreOffice writer fails in calculations inside table cells when the origin cells are spanned between pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161403

--- Comment #2 from acastan  ---
Created attachment 194524
  --> https://bugs.documentfoundation.org/attachment.cgi?id=194524=edit
The same table. I just added some lines at the start of the page. Now the cells
to add are in the same page. The result is fine, 38

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161403] LibreOffice writer fails in calculations inside table cells when the origin cells are spanned between pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161403

--- Comment #1 from acastan  ---
Created attachment 194523
  --> https://bugs.documentfoundation.org/attachment.cgi?id=194523=edit
The cells to add are spanned in two pages. The result should be 38 but only
adds 16 (the cells tha remains in first page)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160844] Ctrl+F6 does not switch to (bring the focus back to) the document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160844

Caolán McNamara  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |caolan.mcnamara@collabora.c
   |desktop.org |om
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161403] New: LibreOffice writer fails in calculations inside table cells when the origin cells are spanned between pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161403

Bug ID: 161403
   Summary: LibreOffice writer fails in calculations inside table
cells when the origin cells are spanned between pages
   Product: LibreOffice
   Version: 24.2.3.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: a...@probeta.net

Description:
Excuse my poor English

LibreOffice writer fails in calculations inside table cells when the origin
cells are spanned between pages.

The bug is easily reproducible:

Look this two screenshots. Look the marked cells. The cell in the left column
is a formula adding the the nine cells at right column.

In the first screenshot, all the cells are in the same page and the
calculations is fine.

In the second screenshot I had to move the table few lines down and now the
cells used for the calculation are spanned in two pages, As you can see, now
the formula for a strange reason is adding only the cells in the firs page.
This is unexpected behavior

Steps to Reproduce:
1.Create a table with two columns and many rows, Merge the cells of the left
column.
2. Write numbers in the right cells. Add a Table formula in the left cell
adding all the right cells.
3. The result is fine, but if you move the table down in the way that some rows
are in firs page and some rows are in second page, the formula only adds the
rows in one page

Actual Results:
If the table rows to add are spanned in two pages, it only add the rows of one
page

Expected Results:
If the table rows to add are spanned in two pages, still should add all the
rows of the formula


Reproducible: Always


User Profile Reset: Yes

Additional Info:
LibreOffice 24.2.3.2

3 june 2024

Linux Debian Testing amd64

I can send you screenshots where you see clearly the bug

-- 
You are receiving this mail because:
You are the assignee for the bug.

ODF problems with 3D-objects

[Regina Henschel]

Hi all, hi Armin,

(A)
The UI-option "Double-Sided Illumination" (= UNO property 
D3DSceneTwoSidedLighting) is mapped to ODF scene attribute 
dr3d:lighting-mode (19.99.3, part 3, ODF 1.3).
Its specification is, "The dr3d:lighting-mode attribute specifies 
whether lighting is used in a three-dimensional scene.".


That is not implemented in LO. Lighting is always used in LibreOffice. 
Not using lighting would mean, that the fill color is not modulated but 
drawn as if the object is two-dimensional.



The ODF graphic property dr3d:lighting-mode(20.86, part3, ODF 1.3) fits 
neither. Its values are,
"double-sided: the front and back sides of all planes are displayed if 
they are visible from the viewer's perspective."
"standard: Depending on the value of the dr3d:normals-direction 20.87 
attribute, only the front or only the back side sides of the plane are 
displayed. The opposite sides are not displayed, whether they are 
visible from the viewer's perspective or not."

That is not about lighting, but about the visibility of object faces.


(B)
The UI-option "Invert Normals" (= UNO property D3DNormalsInvert) is 
mapped to ODF graphic property dr3d:normals-direction (20.87, part 3, 
ODF 1.3). Thereby the value D3DNormalsInvert=true is mapped to 
dr3d:normals-direction="normal" and D3DNormalsInvert=false is mapped to 
dr3d:normals-direction="invert".


For dr3d:normals-direction is specified, "The dr3d:normals-direction 
attribute has no effect if the dr3d:lighting-mode 20.86 attribute has 
the value double-sided". But the graphic property dr3d:lighting-mode 
20.86 is not implemented in LibreOffice at all. Its value is not read 
and not written.



(C)
The light position is determined by Svx3DLightControl() in the UI. It is 
associated with UNO properties D3DSceneLightDirection1 to 
D3DSceneLightDirection8. A position in the center in front of the sphere 
in the control results in D3DSceneLightDirection1 = {DirectionX=0, 
DirectionY=0, DirectionZ=1}, for example. This is mapped to ODF 
attribute dr3d:direction (19.95, part 3, ODF 1.3) as dr3d:direction="(0 
0 1)" for the example. The attribute dr3d:direction is specified as, 
"The dr3d:direction attribute specifies the direction in which light is 
emitted.".


So LO uses it as position, but for ODF it is a direction, a vector.


(D)
The UI-option "Double-Sided" (=UNO property D3DDoubleSided) is mapped to 
ODF graphic property dr3d:backface-culling (20.76, part3, ODF 1.3). In 
my understanding, if "backface-culling" is enabled it means, that object 
polygons, which are not visible to the viewer are skipped on rendering. 
In case of solid filling this would have no effect on the final result, 
but only reduces the time for rendering. But in LO the effect is, that 
object polygons, which are not visible because the viewer looks on the 
back face, become visible when backface-culling is disabled. That 
behavior would more fit to ODF dr3d:lighting-mode="double-sided" (20.86).


(E)
In my understanding, a normal determines which side of an object polygon 
is the front face and which is the back face. When I assume an object 
polygon is not visible because the viewer looks on the back face, then 
when changing the state of "Invers Normals" those polygons which were 
invisible become visible and vice versa. But that is not the case in 
LibreOffice.


Is my view in (D) and (E) correct?


Do you agree, that there is a mess? And if yes, how we can fix it?

Kind regards,
Regina

core.git: Changes to 'refs/tags/mimo-7.5.9.2.M3'

[Aron Budea (via logerrit)]

Tag 'mimo-7.5.9.2.M3' created by Aron Budea  at 
2024-06-03 19:55 +

mimo-7.5.9.2.M3

Changes since mimo-7.5.9.2.M2-1:
---
 0 files changed
---

[Bug 160836] unable to resize table row height with mouse, if contains an image which cropped by the fixed row height

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160836

--- Comment #6 from László Németh  ---
This fixes also the missing (hovered) cell border of
https://bugs.documentfoundation.org/attachment.cgi?id=193871 (tdf#160836 test
document).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160836] unable to resize table row height with mouse, if contains an image which cropped by the fixed row height

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160836

László Németh  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=77
   ||388

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 103302] [META] Writer's web layout/view bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103302
Bug 103302 depends on bug 77388, which changed state.

Bug 77388 Summary: Images, inserted in a table cell, go out of cell borders 
when the document (and thus the table) is zoomed.
https://bugs.documentfoundation.org/show_bug.cgi?id=77388

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 103152] [META] Writer image bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103152
Bug 103152 depends on bug 77388, which changed state.

Bug 77388 Summary: Images, inserted in a table cell, go out of cell borders 
when the document (and thus the table) is zoomed.
https://bugs.documentfoundation.org/show_bug.cgi?id=77388

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 77388] Images, inserted in a table cell, go out of cell borders when the document (and thus the table) is zoomed.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=77388

László Németh  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=16
   ||0836
 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 77388] Images, inserted in a table cell, go out of cell borders when the document (and thus the table) is zoomed.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=77388

--- Comment #15 from László Németh  ---
Commit description:

tdf#77388 sw: fix missing table border at cropped images

At images cropped by the bottom or right cell boundaries,
or at images with zero padding in table cells (e.g, in
test document of tdf#160836), table borders were hovered
by the image, resulting missing table borders.

First paint the cell content, and after that the DOCX-like
"collapsing" cell borders in SwTabFrame::PaintSwFrame.

Note: this doesn't modify painting of the objects
anchored to characters (which still hovers the cell borders),
and painting of the text content of the cells (which are
still hovered by the cell borders at zero padding, despite
their non-transparent background color).

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: sw/source

[László Németh (via logerrit)]

 sw/source/core/layout/paintfrm.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 03aa8a1d9bfe4af2f37df0bde42193c2cf90ffb4
Author: László Németh 
AuthorDate: Mon Jun 3 16:27:55 2024 +0200
Commit: László Németh 
CommitDate: Mon Jun 3 21:50:26 2024 +0200

tdf#77388 sw: fix missing table border at cropped images

At images cropped by the bottom or right cell boundaries,
or at images with zero padding in table cells (e.g, in
test document of tdf#160836), table borders were hovered
by the image, resulting missing table borders.

First paint the cell content, and after that the DOCX-like
"collapsing" cell borders in SwTabFrame::PaintSwFrame.

Note: this doesn't modify painting of the objects
anchored to characters (which still hovers the cell borders),
and painting of the text content of the cells (which are
still hovered by the cell borders at zero padding, despite
their non-transparent background color).

Change-Id: Ie41ab275fd101bb9e26d4165362063f0332ac3c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168384
Tested-by: Jenkins
Reviewed-by: László Németh 

diff --git a/sw/source/core/layout/paintfrm.cxx 
b/sw/source/core/layout/paintfrm.cxx
index c572585e597a..fd426234a652 100644
--- a/sw/source/core/layout/paintfrm.cxx
+++ b/sw/source/core/layout/paintfrm.cxx
@@ -4667,6 +4667,8 @@ void SwTabFrame::PaintSwFrame(vcl::RenderContext& 
rRenderContext, SwRect const&
 const SwViewOption* pViewOption = gProp.pSGlobalShell->GetViewOptions();
 if (pViewOption->IsTable())
 {
+SwLayoutFrame::PaintSwFrame( rRenderContext, rRect );
+
 // #i29550#
 if ( IsCollapsingBorders() )
 {
@@ -4684,8 +4686,6 @@ void SwTabFrame::PaintSwFrame(vcl::RenderContext& 
rRenderContext, SwRect const&
 SwTabFramePainter aHelper(*this);
 aHelper.PaintLines(rRenderContext, rRect);
 }
-
-SwLayoutFrame::PaintSwFrame( rRenderContext, rRect );
 }
 // #i6467# - no light grey rectangle for page preview
 else if ( gProp.pSGlobalShell->GetWin() && 
!gProp.pSGlobalShell->IsPreview() )

[Bug 77388] Images, inserted in a table cell, go out of cell borders when the document (and thus the table) is zoomed.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=77388

--- Comment #14 from Commit Notification 
 ---
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/03aa8a1d9bfe4af2f37df0bde42193c2cf90ffb4

tdf#77388 sw: fix missing table border at cropped images

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 77388] Images, inserted in a table cell, go out of cell borders when the document (and thus the table) is zoomed.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=77388

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:24.8.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Changes to 'refs/tags/mimo-7.3.7.2.M10'

[Aron Budea (via logerrit)]

Tag 'mimo-7.3.7.2.M10' created by Aron Budea  at 
2024-06-03 19:45 +

mimo-7.3.7.2.M10

Changes since mimo-7.3.7.2.M9-1:
---
 0 files changed
---

core.git: Changes to 'refs/tags/mimo-7.2.7.2.M17'

[Aron Budea (via logerrit)]

Tag 'mimo-7.2.7.2.M17' created by Aron Budea  at 
2024-06-03 19:44 +

mimo-7.2.7.2.M17

Changes since mimo-7.2.7.2.M15-3:
---
 0 files changed
---

[Bug 103152] [META] Writer image bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103152
Bug 103152 depends on bug 155251, which changed state.

Bug 155251 Summary: Relative size of image changes when opening image 
properties & pressing OK without touching anything
https://bugs.documentfoundation.org/show_bug.cgi?id=155251

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 155251] Relative size of image changes when opening image properties & pressing OK without touching anything

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155251

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Caolán McNamara  ---
This seems to be fixed now since:

commit a3150fc8a59662ce8630cfc64fec9cd083ac7d36 (HEAD)
Author: Miklos Vajna 
Date:   Fri May 24 12:06:55 2024 +0200

tdf#145972 sw image dialog: fix bad rel width w/ pt units and kept aspect
ratio

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Changes to 'refs/tags/mimo-7.1.8.1.M7'

[Aron Budea (via logerrit)]

Tag 'mimo-7.1.8.1.M7' created by Aron Budea  at 
2024-06-03 19:38 +

7.1.8.1.M7

Changes since mimo-7.1.8.1.M6-3:
---
 0 files changed
---

core.git: Changes to 'refs/tags/mimo-7.0.7.0.M15'

[Stephan Bergmann (via logerrit)]

Tag 'mimo-7.0.7.0.M15' created by Aron Budea  at 
2024-06-03 19:30 +

mimo-7.0.7.0.M15

Changes since mimo-7.0.7.0.M14-3:
---
 0 files changed
---

core.git: Changes to 'refs/tags/mimo-6.2.8.2.M14'

[Stephan Bergmann (via logerrit)]

Tag 'mimo-6.2.8.2.M14' created by Aron Budea  at 
2024-06-03 19:28 +

mimo-6.2.8.2.M14

Changes since mimo-6.2.8.2.M13-5:
---
 0 files changed
---

core.git: Changes to 'refs/tags/mimo-6.4.7.2.M11'

[Stephan Bergmann (via logerrit)]

Tag 'mimo-6.4.7.2.M11' created by Aron Budea  at 
2024-06-03 19:24 +

mimo-6.4.7.2.M11

Changes since mimo-6.4.7.2.M10-3:
---
 0 files changed
---

[Bug 161255] Expand heuristic for enabling RTL-CTL and/or CJK language support when installing/creating new profile

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161255

Eyal Rozenberg  changed:

   What|Removed |Added

Summary|Heuristically enable|Expand heuristic for
   |RTL-CTL and/or CJK language |enabling RTL-CTL and/or CJK
   |support when installing |language support when
   ||installing/creating new
   ||profile

--- Comment #12 from Eyal Rozenberg  ---
(In reply to Mike Kaganski from comment #9)

> I further said explicitly, that it is *expected*
> that this locale setting is *set* automatically according to the OS settings
> (whichever algorithm there is). 

Ok, so that's what I misunderstood.

Anyway, I'm not even sure that makes sense. I mean, if I download a localized
version from the libreoffice.org website, shouldn't that locale trump whatever
LO determines as the OS locale?

Regardless of what locale is set, there's the 


> I even wrote explicitly, that *if* it doesn't work for a *specific* OS, or a
> specific locale, then that is a bug

TBH I don't know whether it _ever_ works, as I always get Hindi CTL locale for
some reason, and assumed that's some hard-coded default. Guess I'll go file
that bug. Anyway, limiting the bug's scope to reflect what you've said.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: sc/qa

[Xisco Fauli (via logerrit)]

 sc/qa/unit/data/xlsx/tdf160371.xlsx |binary
 sc/qa/unit/subsequent_filters_test2.cxx |   13 +
 2 files changed, 13 insertions(+)

New commits:
commit e10ca8d250b39cc2778e9df47a06fd6ba4f2fced
Author: Xisco Fauli 
AuthorDate: Mon Jun 3 15:58:57 2024 +0200
Commit: Xisco Fauli 
CommitDate: Mon Jun 3 20:52:58 2024 +0200

tdf#160371: sc_subsequent_filters_test2: Add unittest

Change-Id: Ife3a319359391f0614260170c9ddfbac16e13cbd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168379
Reviewed-by: Xisco Fauli 
Tested-by: Jenkins

diff --git a/sc/qa/unit/data/xlsx/tdf160371.xlsx 
b/sc/qa/unit/data/xlsx/tdf160371.xlsx
new file mode 100644
index ..798db83d9c18
Binary files /dev/null and b/sc/qa/unit/data/xlsx/tdf160371.xlsx differ
diff --git a/sc/qa/unit/subsequent_filters_test2.cxx 
b/sc/qa/unit/subsequent_filters_test2.cxx
index 74eea5b91efa..60966f08bc5c 100644
--- a/sc/qa/unit/subsequent_filters_test2.cxx
+++ b/sc/qa/unit/subsequent_filters_test2.cxx
@@ -730,6 +730,19 @@ CPPUNIT_TEST_FIXTURE(ScFiltersTest2, 
testErrorOnExternalReferences)
  pDoc->GetFormula(0, 0, 0));
 }
 
+CPPUNIT_TEST_FIXTURE(ScFiltersTest2, testTdf160371)
+{
+createScDoc("xlsx/tdf160371.xlsx");
+
+ScDocument* pDoc = getScDoc();
+
+// Without the fix in place, this test would have failed with
+// - Expected: =INDIRECT(B2)!INDIRECT(B3)
+// - Actual  : =INDIRECT(B2) INDIRECT(B3)
+CPPUNIT_ASSERT_EQUAL(u"=INDIRECT(B2)!INDIRECT(B3)"_ustr, 
pDoc->GetFormula(1, 3, 0));
+CPPUNIT_ASSERT_EQUAL(1.0, pDoc->GetValue(ScAddress(1, 3, 0)));
+}
+
 CPPUNIT_TEST_FIXTURE(ScFiltersTest2, testTdf145054)
 {
 createScDoc("xlsx/tdf145054.xlsx");

[Bug 161399] Support Spilled range operator in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161399

m_a_riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m_a_riosv  ---
+1, If it is affordable, it is promising.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161398] auto-filter very slow

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161398

m_a_riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m_a_riosv  ---
Please attach the sample file here, and paste the information in
Menu/Help/About LibreOffice, there is a copy icon.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161397] Issues with copy & pasting Arabic/Persian text with colored characters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161397

Eyal Rozenberg  changed:

   What|Removed |Added

   Keywords||regression

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120543] [META] Bugs and enhancements around hyperlinks in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120543

BogdanB  changed:

   What|Removed |Added

 Depends on||161329


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=161329
[Bug 161329] If you copy a shape the hyperlink property is not copied
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161329] If you copy a shape the hyperlink property is not copied

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161329

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g
Summary|If you copy a shape the |If you copy a shape the
   |hyperlink property is not   |hyperlink property is not
   |copied. |copied
 Blocks||120543


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=120543
[Bug 120543] [META] Bugs and enhancements around hyperlinks in Calc
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161386] Disappearing headers in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161386

m_a_riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #2 from m_a_riosv  ---
In any case, please link the existing bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 81234] [META] RTF filter issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=81234

BogdanB  changed:

   What|Removed |Added

 Depends on||161359


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=161359
[Bug 161359] rtf no'open
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161359] rtf no'open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161359

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g
 Blocks||81234


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=81234
[Bug 81234] [META] RTF filter issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161400] [LOCALHELP] Document Calc AutoFill improvements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161400

Buovjaga  changed:

   What|Removed |Added

 CC||ilmari.lauhakangas@libreoff
   ||ice.org

--- Comment #1 from Buovjaga  ---
Got this reply now:

The improvement is actually "making AutoFill work by calling it explicitly with
Uno commands". AutoFill was only working with mouseUp events, but now this is
changed, we can also use it without relying on mouse events.

It does not change/add any visible improvement on the UI, it is just a small
improvement. We already have copy-cells by ctrl-dragging & fill-series by
dragging, those behaviors were not changed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 112874] [META] Bugs related with odd and even pages, header and footer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112874

BogdanB  changed:

   What|Removed |Added

 Depends on||161356


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=161356
[Bug 161356] Undo puts previous text to a wrong position
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 105948] [META] Undo/Redo bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105948

BogdanB  changed:

   What|Removed |Added

 Depends on||161356


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=161356
[Bug 161356] Undo puts previous text to a wrong position
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 104522] [META] DOCX (OOXML) header & footer-related issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104522

BogdanB  changed:

   What|Removed |Added

 Depends on||161356


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=161356
[Bug 161356] Undo puts previous text to a wrong position
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161356] Undo puts previous text to a wrong position

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161356

BogdanB  changed:

   What|Removed |Added

 Blocks||104522, 112874, 105948
 CC||buzea.bog...@libreoffice.or
   ||g


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104522
[Bug 104522] [META] DOCX (OOXML) header & footer-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=105948
[Bug 105948] [META] Undo/Redo bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=112874
[Bug 112874] [META] Bugs related with odd and even pages, header and footer
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 69724] There is no ability to set/configure the default number/bullet styles

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=69724

--- Comment #23 from Commit Notification 
 ---
Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b8a89b3356275e95e3fc78c79f55a209f8056556

tdf#69724 Disable 'Change Bullet' btn until selection exists

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: cui/source

[Samuel Mehrbrodt (via logerrit)]

 cui/source/tabpages/numpages.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit b8a89b3356275e95e3fc78c79f55a209f8056556
Author: Samuel Mehrbrodt 
AuthorDate: Mon Jun 3 11:08:52 2024 +0200
Commit: Samuel Mehrbrodt 
CommitDate: Mon Jun 3 20:22:23 2024 +0200

tdf#69724 Disable 'Change Bullet' btn until selection exists

Change-Id: I9c1fdeb4423a8fe45121ff58097582dcccdd12ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168359
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt 

diff --git a/cui/source/tabpages/numpages.cxx b/cui/source/tabpages/numpages.cxx
index 343b0ce9c7f0..c0495541ca61 100644
--- a/cui/source/tabpages/numpages.cxx
+++ b/cui/source/tabpages/numpages.cxx
@@ -330,6 +330,7 @@ SvxBulletPickTabPage::SvxBulletPickTabPage(weld::Container* 
pPage, weld::DialogC
 , m_xExamplesVSWin(new weld::CustomWeld(*m_xBuilder, u"valueset"_ustr, 
*m_xExamplesVS))
 {
 SetExchangeSupport();
+m_xBtChangeBullet->set_sensitive(false);
 m_xExamplesVS->init(NumberingPageType::BULLET);
 m_xExamplesVS->SetSelectHdl(LINK(this, SvxBulletPickTabPage, 
NumSelectHdl_Impl));
 m_xExamplesVS->SetDoubleClickHdl(LINK(this, SvxBulletPickTabPage, 
DoubleClickHdl_Impl));
@@ -426,6 +427,8 @@ IMPL_LINK_NOARG(SvxBulletPickTabPage, NumSelectHdl_Impl, 
ValueSet*, void)
 if(!pActNum)
 return;
 
+m_xBtChangeBullet->set_sensitive(true);
+
 bPreset = false;
 bModified = true;
 sal_uInt16 nIndex = m_xExamplesVS->GetSelectedItemId() - 1;

[Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103341

BogdanB  changed:

   What|Removed |Added

 Depends on||161380


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=161380
[Bug 161380] "reputationally" is marked as a misspelled work
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161380] "reputationally" is marked as a misspelled work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161380

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g
 Blocks||103341


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103341
[Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 113079] [META] Unformatted text paste special bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113079

BogdanB  changed:

   What|Removed |Added

 Depends on||161397


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=161397
[Bug 161397] Issues with copy & pasting Arabic/Persian text with colored
characters
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 112810] [META] Arabic & Farsi language-specific RTL issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112810

BogdanB  changed:

   What|Removed |Added

 Depends on||161397


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=161397
[Bug 161397] Issues with copy & pasting Arabic/Persian text with colored
characters
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161397] Issues with copy & pasting Arabic/Persian text with colored characters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161397

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g
 Blocks||112810, 113079


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=112810
[Bug 112810] [META] Arabic & Farsi language-specific RTL issues
https://bugs.documentfoundation.org/show_bug.cgi?id=113079
[Bug 113079] [META] Unformatted text paste special bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'libreoffice-24-2-4' - desktop/source

[Stephan Bergmann (via logerrit)]

 desktop/source/app/updater.cxx |   34 +-
 desktop/source/app/updater.hxx |2 --
 2 files changed, 9 insertions(+), 27 deletions(-)

New commits:
commit 5c9c8a230d9e98c6d54c2ada2d4824e2c20b42c8
Author: Stephan Bergmann 
AuthorDate: Thu May 30 13:36:49 2024 +0200
Commit: Christian Lohmaier 
CommitDate: Mon Jun 3 20:17:28 2024 +0200

Consolidate on a single Updater::log overload

Change-Id: Id812788f30ac4a327d450255cfe19181c69ae81e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168257
Reviewed-by: Stephan Bergmann 
Tested-by: Jenkins
(cherry picked from commit 253bd05e95ae5093e61a4685a9d28f31edc6f585)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168296
Reviewed-by: Christian Lohmaier 
(cherry picked from commit aff07e946a08608a96fcc853152d0e57b7a00e8e)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168381
Tested-by: Christian Lohmaier 
Reviewed-by: Xisco Fauli 

diff --git a/desktop/source/app/updater.cxx b/desktop/source/app/updater.cxx
index aed765d6eb3d..d60c006f6b6f 100644
--- a/desktop/source/app/updater.cxx
+++ b/desktop/source/app/updater.cxx
@@ -29,7 +29,9 @@
 #include 
 #include 
 #include 
+#include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -553,7 +555,7 @@ size_t WriteCallbackFile(void *ptr, size_t size,
 
 std::string download_content(const OString& rURL, bool bFile, OUString& rHash)
 {
-Updater::log("Download: " + rURL);
+Updater::log("Download: " + OStringToOUString(rURL, 
osl_getThreadTextEncoding()));
 std::unique_ptr> curl(
 curl_easy_init(), [](CURL * p) { curl_easy_cleanup(p); });
 
@@ -729,7 +731,7 @@ void update_checker()
 OUString aDownloadCheckURL = aDownloadCheckBaseURL + "update/check/1/" + 
aProductName +
 "/" + aBuildID + "/" + aBuildTarget + "/" + aChannel;
 OString aURL = OUStringToOString(aDownloadCheckURL, RTL_TEXTENCODING_UTF8);
-Updater::log("Update check: " + aURL);
+Updater::log("Update check: " + OStringToOUString(aURL, 
osl_getThreadTextEncoding()));
 
 try
 {
@@ -779,27 +781,27 @@ void update_checker()
 catch (const invalid_update_info&)
 {
 SAL_WARN("desktop.updater", "invalid update information");
-Updater::log(OString("warning: invalid update info"));
+Updater::log("warning: invalid update info");
 }
 catch (const error_updater& e)
 {
 SAL_WARN("desktop.updater", "error during the update check: " << 
e.what());
-Updater::log(OString("warning: error by the updater") + e.what());
+Updater::log("warning: error by the updater" + 
o3tl::runtimeToOUString(e.what()));
 }
 catch (const invalid_size& e)
 {
 SAL_WARN("desktop.updater", e.what());
-Updater::log(OString("warning: invalid size"));
+Updater::log("warning: invalid size");
 }
 catch (const invalid_hash& e)
 {
 SAL_WARN("desktop.updater", e.what());
-Updater::log(OString("warning: invalid hash"));
+Updater::log("warning: invalid hash");
 }
 catch (...)
 {
 SAL_WARN("desktop.updater", "unknown error during the update check");
-Updater::log(OString("warning: unknown exception"));
+Updater::log("warning: unknown exception");
 }
 }
 
@@ -843,24 +845,6 @@ void Updater::log(const OUString& rMessage)
 aLog.WriteLine(OUStringToOString(rMessage, RTL_TEXTENCODING_UTF8));
 }
 
-void Updater::log(const OString& rMessage)
-{
-SAL_INFO("desktop.updater", rMessage);
-OUString aUpdateLog = getUpdateInfoLog();
-SvFileStream aLog(aUpdateLog, StreamMode::STD_READWRITE);
-aLog.Seek(aLog.Tell() + aLog.remainingSize()); // make sure we are at the 
end
-aLog.WriteLine(rMessage);
-}
-
-void Updater::log(const char* pMessage)
-{
-SAL_INFO("desktop.updater", pMessage);
-OUString aUpdateLog = getUpdateInfoLog();
-SvFileStream aLog(aUpdateLog, StreamMode::STD_READWRITE);
-aLog.Seek(aLog.Tell() + aLog.remainingSize()); // make sure we are at the 
end
-aLog.WriteOString(pMessage);
-}
-
 OUString Updater::getBuildID()
 {
 OUString aBuildID("${$BRAND_BASE_DIR/" LIBO_ETC_FOLDER "/" 
SAL_CONFIGFILE("version") ":buildid}");
diff --git a/desktop/source/app/updater.hxx b/desktop/source/app/updater.hxx
index 8989f1f684a0..3fc767748094 100644
--- a/desktop/source/app/updater.hxx
+++ b/desktop/source/app/updater.hxx
@@ -27,8 +27,6 @@ public:
 static OUString getUpdateChannel();
 
 static void log(const OUString& rMessage);
-static void log(const OString& rMessage);
-static void log(const char* pMessage);
 
 static void removeUpdateFiles();
 };

core.git: Branch 'libreoffice-24-2-4' - desktop/source

[Stephan Bergmann (via logerrit)]

 desktop/source/app/updater.cxx |   14 --
 desktop/source/app/updater.hxx |1 -
 2 files changed, 4 insertions(+), 11 deletions(-)

New commits:
commit b01f7e8f4b931f56a55d5bfc661f7bb7416afa58
Author: Stephan Bergmann 
AuthorDate: Thu May 30 13:44:49 2024 +0200
Commit: Christian Lohmaier 
CommitDate: Mon Jun 3 20:17:10 2024 +0200

Make sure updates dir exists when writing updating.log

Change-Id: Ib652fedde970d01b701ad4b61e75028cd43974f6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168258
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 
(cherry picked from commit 48190a8f3783135c65538977cd38f34ba733f071)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168297
Reviewed-by: Christian Lohmaier 
(cherry picked from commit 44d8490f615cd6c56a1336d6d4da10219f572ccb)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168382
Reviewed-by: Xisco Fauli 
Tested-by: Christian Lohmaier 

diff --git a/desktop/source/app/updater.cxx b/desktop/source/app/updater.cxx
index 12bb4969a68c..aed765d6eb3d 100644
--- a/desktop/source/app/updater.cxx
+++ b/desktop/source/app/updater.cxx
@@ -803,14 +803,6 @@ void update_checker()
 }
 }
 
-OUString Updater::getUpdateInfoLog()
-{
-OUString aUpdateInfoURL("${$BRAND_BASE_DIR/" LIBO_ETC_FOLDER "/" 
SAL_CONFIGFILE("bootstrap") ":UserInstallation}/updates/updating.log");
-rtl::Bootstrap::expandMacros(aUpdateInfoURL);
-
-return aUpdateInfoURL;
-}
-
 OUString Updater::getPatchDirURL()
 {
 OUString aPatchDirURL("${$BRAND_BASE_DIR/" LIBO_ETC_FOLDER "/" 
SAL_CONFIGFILE("bootstrap") ":UserInstallation}/updates/0/");
@@ -843,8 +835,10 @@ OUString Updater::getExecutableDirURL()
 void Updater::log(const OUString& rMessage)
 {
 SAL_INFO("desktop.updater", rMessage);
-OUString aUpdateLog = getUpdateInfoLog();
-SvFileStream aLog(aUpdateLog, StreamMode::STD_READWRITE);
+OUString dir("${$BRAND_BASE_DIR/" LIBO_ETC_FOLDER "/" 
SAL_CONFIGFILE("bootstrap") ":UserInstallation}/updates");
+rtl::Bootstrap::expandMacros(dir);
+osl::Directory::create(dir);
+SvFileStream aLog(dir + "/updating.log", StreamMode::STD_READWRITE);
 aLog.Seek(aLog.Tell() + aLog.remainingSize()); // make sure we are at the 
end
 aLog.WriteLine(OUStringToOString(rMessage, RTL_TEXTENCODING_UTF8));
 }
diff --git a/desktop/source/app/updater.hxx b/desktop/source/app/updater.hxx
index 7f1ea920fbe9..8989f1f684a0 100644
--- a/desktop/source/app/updater.hxx
+++ b/desktop/source/app/updater.hxx
@@ -18,7 +18,6 @@ void update_checker();
 class Updater
 {
 public:
-static OUString getUpdateInfoLog();
 static OUString getPatchDirURL();
 static OUString getUpdateFileURL();
 static OUString getExecutableDirURL();

core.git: Branch 'libreoffice-24-2-4' - external/onlineupdate

[Stephan Bergmann (via logerrit)]

 external/onlineupdate/lo.patch |8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

New commits:
commit ada4296497bae971c3cb293f934f5e6240f23185
Author: Stephan Bergmann 
AuthorDate: Fri May 31 10:35:06 2024 +0200
Commit: Christian Lohmaier 
CommitDate: Mon Jun 3 20:16:34 2024 +0200

tdf#161292: Fix create-partial-info for newly added files

084c64982ef6187292fd73e6deaa4448e0b6f3de "Create MAR updates from msi rather
than from archive" had patched make_add_instruction (in
workdir/UnpackedTarball/onlineupdate/tools/update-packagin/common.sh) to
unconditionally use add-if (with the file itself as test file) rather than 
plain
add (because we can't reuse Mozilla's extension logic there to determine
optional installation parts), and it noted in its commit message that 
"addition
of files will cause a MAR update to miss them".

Which turned out to be a problem with

,
updating from 24.2.2.1 with instdir/program/python-core-3.8.18/ to 24.2.2.2 
with
instdir/program/python-core-3.8.19/:  All the files in python-core-3.8.19 
were
recorded as add-if testing on themselves, so were never added.

So a better approach is, for newly added files to make them add (so they get
added unconditionally, even if they are part of some optional component that
happens to not be installed; this hopefully won't cause further issues) 
instead
of add-if.  (Existing files that are added instead of patched still use 
add-if,
though.)  This does not address the create-update-info target for full mar
updates (which is not used currently?), just the create-partial-info target.

(The existing calls to make_add_instruction in the upstream Mozilla code 
already
have a seemingly rotten mix of two-argument calls and calls with three 
arguments
where the third argument is ignored, and would check for a fourth "forced"
argument but which is never passed in.  So avoid extending that mess 
further,
and just replace this never-use-add-if call to make_add_instruction directly
with that function's (accordingly tweaked) body.)

Change-Id: Ib596f3aa72c3ab9f896b20f7d623bc574eb15fd8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168285
Reviewed-by: Stephan Bergmann 
Tested-by: Jenkins
(cherry picked from commit c00014019e6d33bfb4729c563062db1645c48e9d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168310
Reviewed-by: Christian Lohmaier 
(cherry picked from commit f7bd624cf1f2ad51a5f7d0edf23a1f19a9063823)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168319
Tested-by: Christian Lohmaier 

diff --git a/external/onlineupdate/lo.patch b/external/onlineupdate/lo.patch
index 35dfb2f80fb8..571cea560d3c 100644
--- a/external/onlineupdate/lo.patch
+++ b/external/onlineupdate/lo.patch
@@ -372,7 +372,13 @@
fi
  fi
else
-@@ -270,7 +270,7 @@
+@@ -266,11 +266,12 @@
+   if check_for_add_if_not_update "$f"; then
+ make_add_if_not_instruction "$f" "$updatemanifestv3"
+   else
+-make_add_instruction "$f" "$updatemanifestv3"
++verbose_notice " add \"$f\""
++echo "add \"$f\"" >> "$updatemanifestv3"
fi
  
  

[Bug 102946] [META] Styles bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102946

Eyal Rozenberg  changed:

   What|Removed |Added

 Depends on||161078


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=161078
[Bug 161078] Allow direct formatting for page sequences instead of editing the
style
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161078] Allow direct formatting for page sequences instead of editing the style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161078

Eyal Rozenberg  changed:

   What|Removed |Added

 Blocks||102946


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102946
[Bug 102946] [META] Styles bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: sw/source

[Noel Grandin (via logerrit)]

 sw/source/uibase/sidebar/A11yCheckIssuesPanel.cxx |   57 +-
 sw/source/uibase/sidebar/PageColumnControl.cxx|   24 +++
 sw/source/uibase/sidebar/PageColumnPopup.cxx  |4 -
 sw/source/uibase/sidebar/PageFooterPanel.cxx  |   14 ++--
 sw/source/uibase/sidebar/PageFormatPanel.cxx  |   16 ++---
 sw/source/uibase/sidebar/PageHeaderPanel.cxx  |   16 ++---
 sw/source/uibase/sidebar/PageMarginControl.cxx|   44 ++---
 sw/source/uibase/sidebar/PageMarginPopup.cxx  |4 -
 sw/source/uibase/sidebar/PageOrientationControl.cxx   |8 +-
 sw/source/uibase/sidebar/PageOrientationPopup.cxx |4 -
 sw/source/uibase/sidebar/PageSizeControl.cxx  |8 +-
 sw/source/uibase/sidebar/PageSizePopup.cxx|4 -
 sw/source/uibase/sidebar/PageStylesPanel.cxx  |   24 +++
 sw/source/uibase/sidebar/QuickFindPanel.cxx   |   10 +--
 sw/source/uibase/sidebar/StylePresetsPanel.cxx|6 -
 sw/source/uibase/sidebar/SwPanelFactory.cxx   |   16 ++---
 sw/source/uibase/sidebar/TableEditPanel.cxx   |   36 +--
 sw/source/uibase/sidebar/ThemePanel.cxx   |8 +-
 sw/source/uibase/sidebar/WrapPropertyPanel.cxx|   12 +--
 sw/source/uibase/sidebar/WriterInspectorTextPanel.cxx |   33 +-
 20 files changed, 175 insertions(+), 173 deletions(-)

New commits:
commit 782f7c23af25187b9205e7ca036cb819834be2df
Author: Noel Grandin 
AuthorDate: Mon Jun 3 14:37:41 2024 +0200
Commit: Noel Grandin 
CommitDate: Mon Jun 3 19:35:46 2024 +0200

loplugin:ostr in sw/.../sidebar

Change-Id: Ic905099e9b7266998a414416c288fe0db87a618c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168373
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sw/source/uibase/sidebar/A11yCheckIssuesPanel.cxx 
b/sw/source/uibase/sidebar/A11yCheckIssuesPanel.cxx
index 8a41db78f0ac..bf5333ac6456 100644
--- a/sw/source/uibase/sidebar/A11yCheckIssuesPanel.cxx
+++ b/sw/source/uibase/sidebar/A11yCheckIssuesPanel.cxx
@@ -32,11 +32,11 @@ namespace sw::sidebar
 {
 AccessibilityCheckEntry::AccessibilityCheckEntry(
 weld::Container* pParent, std::shared_ptr const& 
rAccessibilityIssue)
-: m_xBuilder(Application::CreateBuilder(pParent, 
"svx/ui/accessibilitycheckentry.ui"))
-, m_xContainer(m_xBuilder->weld_container("accessibilityCheckEntryBox"))
-, m_xLabel(m_xBuilder->weld_label("accessibilityCheckEntryLabel"))
-, 
m_xGotoButton(m_xBuilder->weld_link_button("accessibilityCheckEntryLinkButton"))
-, m_xFixButton(m_xBuilder->weld_button("accessibilityCheckEntryFixButton"))
+: m_xBuilder(Application::CreateBuilder(pParent, 
u"svx/ui/accessibilitycheckentry.ui"_ustr))
+, 
m_xContainer(m_xBuilder->weld_container(u"accessibilityCheckEntryBox"_ustr))
+, m_xLabel(m_xBuilder->weld_label(u"accessibilityCheckEntryLabel"_ustr))
+, 
m_xGotoButton(m_xBuilder->weld_link_button(u"accessibilityCheckEntryLinkButton"_ustr))
+, 
m_xFixButton(m_xBuilder->weld_button(u"accessibilityCheckEntryFixButton"_ustr))
 , m_pAccessibilityIssue(rAccessibilityIssue)
 {
 // lock in the height as including the button so all rows are the same 
height
@@ -97,39 +97,40 @@ std::unique_ptr 
A11yCheckIssuesPanel::Create(weld::Widget* pParent,
 {
 if (pParent == nullptr)
 throw ::com::sun::star::lang::IllegalArgumentException(
-"no parent window given to A11yCheckIssuesPanel::Create", nullptr, 
0);
+u"no parent window given to A11yCheckIssuesPanel::Create"_ustr, 
nullptr, 0);
 return std::make_unique(pParent, pBindings);
 }
 
 A11yCheckIssuesPanel::A11yCheckIssuesPanel(weld::Widget* pParent, SfxBindings* 
pBindings)
-: PanelLayout(pParent, "A11yCheckIssuesPanel", 
"modules/swriter/ui/a11ycheckissuespanel.ui")
+: PanelLayout(pParent, u"A11yCheckIssuesPanel"_ustr,
+  u"modules/swriter/ui/a11ycheckissuespanel.ui"_ustr)
 , mpBindings(pBindings)
 , mpDoc(nullptr)
 , maA11yCheckController(FN_STAT_ACCESSIBILITY_CHECK, *pBindings, *this)
 , mnIssueCount(0)
 , mbAutomaticCheckEnabled(false)
 {
-m_xExpanders[0] = m_xBuilder->weld_expander("expand_document");
-m_xExpanders[1] = m_xBuilder->weld_expander("expand_styles");
-m_xExpanders[2] = m_xBuilder->weld_expander("expand_linked");
-m_xExpanders[3] = m_xBuilder->weld_expander("expand_no_alt");
-m_xExpanders[4] = m_xBuilder->weld_expander("expand_table");
-m_xExpanders[5] = m_xBuilder->weld_expander("expand_formatting");
-m_xExpanders[6] = m_xBuilder->weld_expander("expand_hyperlink");
-m_xExpanders[7] = m_xBuilder->weld_expander("expand_fakes");
-m_xExpanders[8] = m_xBuilder->weld_expander("expand_numbering");
-m_xExpanders[9] = m_xBuilder->weld_expander("expand_other");
-
-m_xBoxes[0] = m_xBuilder->weld_box("box_document");
-m_xBoxes[1] = m_xBuilder->weld_box("box_styles");
-