[Libreoffice-commits] .: sc/qa sw/qa

2013-01-09 Thread Libreoffice Gerrit user 
 sc/qa/unit/subsequent_filters-test.cxx |   10 --
 sw/qa/core/swdoc-test.cxx  |1 -
 2 files changed, 11 deletions(-)

New commits:
commit 4d1a877dbf74b8e6e5908bb2c0eec570a5fb3184
Author: Miklos Vajna vmik...@suse.cz
Date:   Wed Jan 9 07:28:52 2013 +0100

Revert fix a few /tmp file leaks

This reverts commit 92045e69dab8be60a1c84774f04c437066c3c2bf. Broke a
unit test and made all tinderboxes red.

Requested-by: Stephan Bergmann sberg...@redhat.com

diff --git a/sc/qa/unit/subsequent_filters-test.cxx 
b/sc/qa/unit/subsequent_filters-test.cxx
index a7ec15b..f56bd66 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -926,8 +926,6 @@ void ScFiltersTest::testBordersOoo33()
 }
 }
 }
-
-xDocSh-DoClose();
 }
 
 void ScFiltersTest::testBugFixesODS()
@@ -1770,8 +1768,6 @@ void ScFiltersTest::testColorScaleODS()
 rtl::OUStringBuffer aBuffer(getSrcRootPath());
 
aBuffer.append(m_aBaseString).append(rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(/reference/)));
 testColorScale_Impl(pDoc, aBuffer.makeStringAndClear());
-
-xDocSh-DoClose();
 }
 
 void ScFiltersTest::testColorScaleXLSX()
@@ -1796,8 +1792,6 @@ void ScFiltersTest::testColorScaleXLSX()
 rtl::OUStringBuffer aBuffer(getSrcRootPath());
 
aBuffer.append(m_aBaseString).append(rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(/reference/)));
 testColorScale_Impl(pDoc, aBuffer.makeStringAndClear());
-
-xDocSh-DoClose();
 }
 
 void ScFiltersTest::testDataBarODS()
@@ -1827,8 +1821,6 @@ void ScFiltersTest::testNewCondFormat()
 rtl::OUString aCSVPath;
 createCSVPath( aCSVFile, aCSVPath );
 testCondFile(aCSVPath, pDoc, 0);
-
-xDocSh-DoClose();
 }
 
 void ScFiltersTest::testFormulaDependency()
@@ -1857,8 +1849,6 @@ void ScFiltersTest::testFormulaDependency()
 
 // check that the number format is implicity inherited
 // CPPUNIT_ASSERT_EQUAL(pDoc-GetString(0,4,0), pDoc-GetString(0,5,0));
-
-xDocSh-DoClose();
 }
 
 ScFiltersTest::ScFiltersTest()
diff --git a/sw/qa/core/swdoc-test.cxx b/sw/qa/core/swdoc-test.cxx
index f818cba..de9828e 100644
--- a/sw/qa/core/swdoc-test.cxx
+++ b/sw/qa/core/swdoc-test.cxx
@@ -886,7 +886,6 @@ void SwDocTest::setUp()
 
 void SwDocTest::tearDown()
 {
-m_xDocShRef-DoClose();
 m_xDocShRef.Clear();
 delete m_pDoc;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: sc/qa sw/qa

2013-01-08 Thread Libreoffice Gerrit user 
 sc/qa/unit/subsequent_filters-test.cxx |   10 ++
 sw/qa/core/swdoc-test.cxx  |1 +
 2 files changed, 11 insertions(+)

New commits:
commit 92045e69dab8be60a1c84774f04c437066c3c2bf
Author: Michael Meeks michael.me...@suse.com
Date:   Tue Jan 8 18:20:16 2013 +

fix a few /tmp file leaks

Thanks to Jean-Baptiste Faure for digging for these.

diff --git a/sc/qa/unit/subsequent_filters-test.cxx 
b/sc/qa/unit/subsequent_filters-test.cxx
index f56bd66..a7ec15b 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -926,6 +926,8 @@ void ScFiltersTest::testBordersOoo33()
 }
 }
 }
+
+xDocSh-DoClose();
 }
 
 void ScFiltersTest::testBugFixesODS()
@@ -1768,6 +1770,8 @@ void ScFiltersTest::testColorScaleODS()
 rtl::OUStringBuffer aBuffer(getSrcRootPath());
 
aBuffer.append(m_aBaseString).append(rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(/reference/)));
 testColorScale_Impl(pDoc, aBuffer.makeStringAndClear());
+
+xDocSh-DoClose();
 }
 
 void ScFiltersTest::testColorScaleXLSX()
@@ -1792,6 +1796,8 @@ void ScFiltersTest::testColorScaleXLSX()
 rtl::OUStringBuffer aBuffer(getSrcRootPath());
 
aBuffer.append(m_aBaseString).append(rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(/reference/)));
 testColorScale_Impl(pDoc, aBuffer.makeStringAndClear());
+
+xDocSh-DoClose();
 }
 
 void ScFiltersTest::testDataBarODS()
@@ -1821,6 +1827,8 @@ void ScFiltersTest::testNewCondFormat()
 rtl::OUString aCSVPath;
 createCSVPath( aCSVFile, aCSVPath );
 testCondFile(aCSVPath, pDoc, 0);
+
+xDocSh-DoClose();
 }
 
 void ScFiltersTest::testFormulaDependency()
@@ -1849,6 +1857,8 @@ void ScFiltersTest::testFormulaDependency()
 
 // check that the number format is implicity inherited
 // CPPUNIT_ASSERT_EQUAL(pDoc-GetString(0,4,0), pDoc-GetString(0,5,0));
+
+xDocSh-DoClose();
 }
 
 ScFiltersTest::ScFiltersTest()
diff --git a/sw/qa/core/swdoc-test.cxx b/sw/qa/core/swdoc-test.cxx
index de9828e..f818cba 100644
--- a/sw/qa/core/swdoc-test.cxx
+++ b/sw/qa/core/swdoc-test.cxx
@@ -886,6 +886,7 @@ void SwDocTest::setUp()
 
 void SwDocTest::tearDown()
 {
+m_xDocShRef-DoClose();
 m_xDocShRef.Clear();
 delete m_pDoc;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits