[Libreoffice-commits] core.git: 3 commits - basegfx/source basegfx/test comphelper/source compilerplugins/clang sfx2/source svx/source vcl/headless vcl/source vcl/unx

2021-08-18 Thread Noel Grandin (via logerrit) 
 basegfx/source/polygon/b2dtrapezoid.cxx |6 +++---
 basegfx/test/boxclipper.cxx |2 +-
 comphelper/source/processfactory/processfactory.cxx |3 ++-
 compilerplugins/clang/sequenceloop.cxx  |5 -
 sfx2/source/appl/appopen.cxx|2 --
 svx/source/sdr/contact/viewcontactofsdrpathobj.cxx  |2 +-
 svx/source/svdraw/svdotextpathdecomposition.cxx |2 +-
 vcl/headless/svpgdi.cxx |2 +-
 vcl/source/filter/wmf/emfwr.cxx |4 ++--
 vcl/source/filter/wmf/wmfwr.cxx |4 ++--
 vcl/source/gdi/FileDefinitionWidgetDraw.cxx |2 +-
 vcl/source/gdi/lineinfo.cxx |4 ++--
 vcl/source/outdev/line.cxx  |8 
 vcl/source/outdev/polygon.cxx   |4 ++--
 vcl/source/outdev/transparent.cxx   |4 ++--
 vcl/unx/generic/gdi/salgdi.cxx  |2 +-
 16 files changed, 29 insertions(+), 27 deletions(-)

New commits:
commit f29ef71073bb31f05d6cc50f952e827134868c2d
Author: Noel Grandin 
AuthorDate: Tue Aug 17 14:46:29 2021 +0200
Commit: Noel Grandin 
CommitDate: Wed Aug 18 08:55:23 2021 +0200

avoid constructing OUString on hot path (tdf#105575)

Change-Id: I7c9925fc7f68cdc9bd1a9c1834daabff09c8cf6e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120604
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/comphelper/source/processfactory/processfactory.cxx 
b/comphelper/source/processfactory/processfactory.cxx
index 8df1e244ca19..ea5595646e4c 100644
--- a/comphelper/source/processfactory/processfactory.cxx
+++ b/comphelper/source/processfactory/processfactory.cxx
@@ -86,8 +86,9 @@ Reference< XComponentContext > getComponentContext(
 Reference< XComponentContext > xRet;
 uno::Reference const xProps( factory, uno::UNO_QUERY 
);
 if (xProps.is()) {
+static constexpr OUStringLiteral DEFAULT_CONTEXT = u"DefaultContext";
 try {
-xRet.set( xProps->getPropertyValue("DefaultContext"),
+xRet.set( xProps->getPropertyValue(DEFAULT_CONTEXT),
   uno::UNO_QUERY );
 }
 catch (beans::UnknownPropertyException & e) {
commit cc9bc379de14a5ecfcb7b510fe74beeab768f875
Author: Noel Grandin 
AuthorDate: Tue Aug 17 20:14:27 2021 +0200
Commit: Noel Grandin 
CommitDate: Wed Aug 18 08:54:56 2021 +0200

remove dead code

ever since
commit fd069bee7e57ad529c3c0974559fd2d84ec3151a
Date:   Mon Sep 18 16:07:07 2000 +
initial import

Change-Id: I1fd724f2e4f31353da60d2615e6c840bbb88dfcb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120619
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sfx2/source/appl/appopen.cxx b/sfx2/source/appl/appopen.cxx
index 15c47a31c0e5..5936accbfedb 100644
--- a/sfx2/source/appl/appopen.cxx
+++ b/sfx2/source/appl/appopen.cxx
@@ -504,8 +504,6 @@ void SfxApplication::NewDocExec_Impl( SfxRequest& rReq )
 }
 
 ErrCode lErr = ERRCODE_NONE;
-SfxItemSet* pSet = new SfxAllItemSet( GetPool() );
-pSet->Put( SfxBoolItem( SID_TEMPLATE, true ) );
 if ( !bDirect )
 {
 SfxDocumentTemplates aTmpFac;
commit f46740abc225f5b4c7f604bf3ef32c503c7fc858
Author: Noel Grandin 
AuthorDate: Tue Aug 17 20:16:33 2021 +0200
Commit: Noel Grandin 
CommitDate: Wed Aug 18 08:54:36 2021 +0200

loplugin:sequenceloop also check for B2DPolyPolygon

which has the same problem

Change-Id: I98f9924626f26739e91d6a9d21e4276473ea314d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120620
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/basegfx/source/polygon/b2dtrapezoid.cxx 
b/basegfx/source/polygon/b2dtrapezoid.cxx
index f30001f52d2a..3a255c18a7a3 100644
--- a/basegfx/source/polygon/b2dtrapezoid.cxx
+++ b/basegfx/source/polygon/b2dtrapezoid.cxx
@@ -496,7 +496,7 @@ namespace basegfx::trapezoidhelper
 aSource = aSource.getDefaultAdaptiveSubdivision();
 }
 
-for(const auto& aPolygonCandidate : aSource)
+for(const auto& aPolygonCandidate : std::as_const(aSource))
 {
 // 1st run: count points
 const sal_uInt32 nCount(aPolygonCandidate.count());
@@ -513,7 +513,7 @@ namespace basegfx::trapezoidhelper
 // after 2nd loop since pointers to it are used in the 
edges
 maPoints.reserve(nAllPointCount);
 
-for(const auto& aPolygonCandidate : aSource)
+for(const auto& aPolygonCandidate : std::as_const(aSource))
 {
 // 2nd run: add points
 const sal_uInt32 nCount(aPolygonCandidate.count());
@@ -533,7 +533,7 @@ namespace

[Libreoffice-commits] core.git: 3 commits - basegfx/source

2017-08-25 Thread Michael Stahl 
 basegfx/source/matrix/b3dhommatrix.cxx|   13 ++--
 basegfx/source/polygon/b2dpolygon.cxx |   31 --
 basegfx/source/polygon/b2dpolypolygon.cxx |9 ++--
 3 files changed, 27 insertions(+), 26 deletions(-)

New commits:
commit 64ced968cc82b552e178da033e7a3b5af6996ae1
Author: Michael Stahl 
Date:   Fri Aug 25 20:56:28 2017 +0200

basegfx: remove global ImplB2DPolyPolygon

Change-Id: I6035aaf8aabf71062bb63a4d416c253378fb4756

diff --git a/basegfx/source/polygon/b2dpolypolygon.cxx 
b/basegfx/source/polygon/b2dpolypolygon.cxx
index 9c6b1eb50fe9..eaed3bacdc54 100644
--- a/basegfx/source/polygon/b2dpolypolygon.cxx
+++ b/basegfx/source/polygon/b2dpolypolygon.cxx
@@ -21,7 +21,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 
 #include 
@@ -170,11 +169,9 @@ public:
 
 namespace basegfx
 {
-namespace { struct DefaultPolyPolygon: public 
rtl::Static {}; }
 
-B2DPolyPolygon::B2DPolyPolygon() :
-mpPolyPolygon(DefaultPolyPolygon::get())
+B2DPolyPolygon::B2DPolyPolygon()
+: mpPolyPolygon()
 {
 }
 
@@ -325,7 +322,7 @@ namespace basegfx
 
 void B2DPolyPolygon::clear()
 {
-mpPolyPolygon = DefaultPolyPolygon::get();
+*mpPolyPolygon = ImplB2DPolyPolygon();
 }
 
 bool B2DPolyPolygon::isClosed() const
commit 7e911e9cd469d30369c213aa529675b3f7c4f0e8
Author: Michael Stahl 
Date:   Fri Aug 25 20:51:22 2017 +0200

basegfx: remove global ImplB2DPolygon

Change-Id: Ibd97ba1d7cc4e04203142057c47a74034cc4f70f

diff --git a/basegfx/source/polygon/b2dpolygon.cxx 
b/basegfx/source/polygon/b2dpolygon.cxx
index 00eaa89d1282..aa528ad861ac 100644
--- a/basegfx/source/polygon/b2dpolygon.cxx
+++ b/basegfx/source/polygon/b2dpolygon.cxx
@@ -23,7 +23,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -632,7 +631,24 @@ public:
 }
 }
 
-ImplB2DPolygon& operator=( const ImplB2DPolygon& ) = delete;
+ImplB2DPolygon& operator=(const ImplB2DPolygon& rOther)
+{
+if (this != )
+{
+mpControlVector.reset();
+mpBufferedData.reset();
+maPoints = rOther.maPoints;
+mbIsClosed = rOther.mbIsClosed;
+if (rOther.mpControlVector && rOther.mpControlVector->isUsed())
+{
+mpControlVector.reset( new 
ControlVectorArray2D(*rOther.mpControlVector) );
+
+if(!mpControlVector->isUsed())
+mpControlVector.reset();
+}
+}
+return *this;
+}
 
 sal_uInt32 count() const
 {
@@ -1091,17 +1107,12 @@ public:
 
 namespace basegfx
 {
-namespace
-{
-struct DefaultPolygon: public rtl::Static {};
-}
-
 B2DPolygon::B2DPolygon()
-:   mpPolygon(DefaultPolygon::get())
+: mpPolygon()
 {}
 
 B2DPolygon::B2DPolygon(std::initializer_list aPoints)
-: mpPolygon(DefaultPolygon::get())
+: mpPolygon()
 {
 for (const basegfx::B2DPoint& rPoint : aPoints)
 {
@@ -1432,7 +1443,7 @@ namespace basegfx
 
 void B2DPolygon::clear()
 {
-mpPolygon = DefaultPolygon::get();
+*mpPolygon = ImplB2DPolygon();
 }
 
 bool B2DPolygon::isClosed() const
commit 0157f98861d589caa60f1ef3dacebb0137d23afe
Author: Michael Stahl 
Date:   Fri Aug 25 20:27:34 2017 +0200

basegfx: remove global 3D IdentityMatrix thread safety hazard

On a tinderbox, CppunitTest_chart2_export crashed in
basegfx::B3DHomMatrix::isEqual(), with other threads in other basegfx
code.

The UnsafeRefCountingPolicy on the global IdentityMatrix is likely the
problem.

Change-Id: Ib142c6f286453d61bd948fb0c184cd68fd313b0f

diff --git a/basegfx/source/matrix/b3dhommatrix.cxx 
b/basegfx/source/matrix/b3dhommatrix.cxx
index 1a88c8b5c777..e6a2bd3b4f88 100644
--- a/basegfx/source/matrix/b3dhommatrix.cxx
+++ b/basegfx/source/matrix/b3dhommatrix.cxx
@@ -17,7 +17,6 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include 
 #include 
 #include 
 #include 
@@ -30,11 +29,8 @@ namespace basegfx
 {
 };
 
-namespace { struct IdentityMatrix : public rtl::Static< 
B3DHomMatrix::ImplType,
-IdentityMatrix > 
{}; }
-
-B3DHomMatrix::B3DHomMatrix() :
-mpImpl( IdentityMatrix::get() ) // use common identity matrix
+B3DHomMatrix::B3DHomMatrix()
+: mpImpl() // identity
 {
 }
 
@@ -81,15 +77,12 @@ namespace basegfx
 
 bool B3DHomMatrix::isIdentity() const
 {
-if(mpImpl.same_object(IdentityMatrix::get()))
-return true;
-
 return mpImpl->isIdentity();
 }
 
 void

[Libreoffice-commits] core.git: 3 commits - basegfx/source external/libabw external/libcdr external/libebook external/libetonyek external/libexttextcat external/libfreehand external/libmspub external/

2017-02-23 Thread David Tardon 
 basegfx/source/polygon/b2dpolygonclipper.cxx   |4 +--
 external/libabw/README |2 -
 external/libcdr/README |2 -
 external/libebook/README   |2 +
 external/libetonyek/README |2 +
 external/libexttextcat/README  |2 -
 external/libfreehand/README|2 +
 external/libmspub/README   |2 +
 external/libpagemaker/README   |2 +
 external/libvisio/README   |3 --
 external/libzmf/README |4 ---
 framework/source/services/autorecovery.cxx |8 +++
 sd/source/ui/inc/tools/TimerBasedTaskExecution.hxx |2 -
 sdext/source/presenter/PresenterSlideSorter.cxx|2 -
 sdext/source/presenter/PresenterTextView.cxx   |6 ++---
 sdext/source/presenter/PresenterTimer.cxx  |   22 ++---
 sdext/source/presenter/PresenterTimer.hxx  |6 ++---
 vcl/source/gdi/regionband.cxx  |2 -
 18 files changed, 41 insertions(+), 34 deletions(-)

New commits:
commit d132f85faddbbfc640d6d9cba2b8f62e2adfc207
Author: David Tardon 
Date:   Thu Feb 23 12:58:08 2017 +0100

add upstream URL to READMEs

Change-Id: I9cde5f94c81c59ff99b8f5af9765b94b6f57184a

diff --git a/external/libabw/README b/external/libabw/README
index 96432f4..ce20990 100644
--- a/external/libabw/README
+++ b/external/libabw/README
@@ -1,3 +1,3 @@
 AbiWord file word processor format import library from
 
-I couldn't find an upstream for this library - although I did only try a 
primitive Google search.
+[https://wiki.documentfoundation.org/DLP/Libraries/libabw]
diff --git a/external/libcdr/README b/external/libcdr/README
index d3ba94d..4337b72 100644
--- a/external/libcdr/README
+++ b/external/libcdr/README
@@ -1,3 +1,3 @@
 Library parsing the Corel cdr documents.
 
-I couldn't find an upstream for this library - although I did only try a 
primitive Google search.
+[https://wiki.documentfoundation.org/DLP/Libraries/libcdr]
diff --git a/external/libebook/README b/external/libebook/README
index 440db7d..804de5c 100644
--- a/external/libebook/README
+++ b/external/libebook/README
@@ -1 +1,3 @@
 Library for import of various non-HTML reflowable e-book formats.
+
+[https://sourceforge.net/projects/libebook/]
diff --git a/external/libetonyek/README b/external/libetonyek/README
index 1db5831..5fe6253 100644
--- a/external/libetonyek/README
+++ b/external/libetonyek/README
@@ -1 +1,3 @@
 Library for import of Apple Keynote presentations.
+
+[https://wiki.documentfoundation.org/DLP/Libraries/libetonyek]
diff --git a/external/libfreehand/README b/external/libfreehand/README
index dafad78..7403eb1 100644
--- a/external/libfreehand/README
+++ b/external/libfreehand/README
@@ -1 +1,3 @@
 Library for import of FreeHand drawings.
+
+[https://wiki.documentfoundation.org/DLP/Libraries/libfreehand]
diff --git a/external/libmspub/README b/external/libmspub/README
index 6d2765a..5a6625f 100644
--- a/external/libmspub/README
+++ b/external/libmspub/README
@@ -1 +1,3 @@
 Library parsing the Microsoft Publisher documents.
+
+[https://wiki.documentfoundation.org/DLP/Libraries/libmspub]
diff --git a/external/libpagemaker/README b/external/libpagemaker/README
index e60dbd7..309aa82 100644
--- a/external/libpagemaker/README
+++ b/external/libpagemaker/README
@@ -1 +1,3 @@
 Library parsing Adobe PageMaker documents.
+
+[https://wiki.documentfoundation.org/DLP/Libraries/libpagemaker]
diff --git a/external/libvisio/README b/external/libvisio/README
index 05ef170..d3ddc6c 100644
--- a/external/libvisio/README
+++ b/external/libvisio/README
@@ -1,4 +1,3 @@
 Libvisio is library providing ability to interpret and import visio diagrams 
into various applications.
 
-See also:
 [https://wiki.documentfoundation.org/DLP/Libraries/libvisio]
diff --git a/external/libzmf/README b/external/libzmf/README
index 26e05fc..ceb21ba 100644
--- a/external/libzmf/README
+++ b/external/libzmf/README
@@ -1,6 +1,4 @@
 libzmf is a library and a set of tools for reading and converting
 Zoner Draw and Zebra file formats.
 
-libzmf requires boost and librevenge to build.
-
-The library is available under MPL 2.0+ license.
+[https://wiki.documentfoundation.org/DLP/Libraries/libzmf]
commit 3f69d7b8f5faed61c3d904b865919f0a3347e77b
Author: David Tardon 
Date:   Thu Feb 23 12:54:18 2017 +0100

update upstream link

Change-Id: I1ef0e9079c7af6eddae3e3dae11ca8c3899fd59e

diff --git a/external/libexttextcat/README b/external/libexttextcat/README
index 5aceab3..ee8ab0c 100644
--- a/external/libexttextcat/README
+++ b/external/libexttextcat/README
@@ -3,4 +3,4 @@ N-Gram-Based Text Categorization library
 This guesses the language that input text is written in. Fundamentally
 an adaption of wiseguys libtextcat extended to

[Libreoffice-commits] core.git: 3 commits - basegfx/source basegfx/test include/basegfx sw/source

2017-01-06 Thread Caolán McNamara 
 basegfx/source/color/bcolortools.cxx  |   11 ---
 basegfx/test/basegfx2d.cxx|   13 -
 include/basegfx/color/bcolortools.hxx |4 
 sw/source/core/draw/dcontact.cxx  |6 +++---
 4 files changed, 3 insertions(+), 31 deletions(-)

New commits:
commit 6af9609284e33c9a8501cbda9ef4c82f30a16b41
Author: Caolán McNamara 
Date:   Fri Jan 6 20:31:49 2017 +

coverity#1398369 Unchecked dynamic_cast

Change-Id: I33b5a2343eb7701a478c8d039d818e679471d4c0

diff --git a/sw/source/core/draw/dcontact.cxx b/sw/source/core/draw/dcontact.cxx
index 06e9f66..c0755c0 100644
--- a/sw/source/core/draw/dcontact.cxx
+++ b/sw/source/core/draw/dcontact.cxx
@@ -587,7 +587,7 @@ void SwFlyDrawContact::SwClientNotify(const SwModify& rMod, 
const SfxHint& rHint
 // This also needs to work when no layout exists. Thus, for
 // FlyFrames an alternative method is used now in that case.
 auto pFormat(dynamic_cast());
-if(pFormat->Which() == RES_FLYFRMFMT && 
!pFormat->getIDocumentLayoutAccess().GetCurrentViewShell())
+if (pFormat && pFormat->Which() == RES_FLYFRMFMT && 
!pFormat->getIDocumentLayoutAccess().GetCurrentViewShell())
 pGetZOrdnerHint->m_rnZOrder = GetMaster()->GetOrdNum();
 }
 }
@@ -598,9 +598,9 @@ bool CheckControlLayer( const SdrObject *pObj )
 {
 if ( SdrInventor::FmForm == pObj->GetObjInventor() )
 return true;
-if (const SdrObjList *pObjLst = dynamic_cast(pObj))
+if (const SdrObjGroup *pObjGroup = dynamic_cast(pObj))
 {
-const SdrObjList *pLst = pObjLst->GetSubList();
+const SdrObjList *pLst = pObjGroup->GetSubList();
 for ( size_t i = 0; i < pLst->GetObjCount(); ++i )
 {
 if ( ::CheckControlLayer( pLst->GetObj( i ) ) )
commit fb92ec82caa96f2ddf4ab4bca8c51503ae9fba82
Author: Caolán McNamara 
Date:   Fri Jan 6 20:28:49 2017 +

dynamic cast followed by static cast

Change-Id: I425692130bd7ef6b8a9ebce3592c1976fa44dafc

diff --git a/sw/source/core/draw/dcontact.cxx b/sw/source/core/draw/dcontact.cxx
index 977841b..06e9f66 100644
--- a/sw/source/core/draw/dcontact.cxx
+++ b/sw/source/core/draw/dcontact.cxx
@@ -598,9 +598,9 @@ bool CheckControlLayer( const SdrObject *pObj )
 {
 if ( SdrInventor::FmForm == pObj->GetObjInventor() )
 return true;
-if ( dynamic_cast( pObj) !=  nullptr )
+if (const SdrObjList *pObjLst = dynamic_cast(pObj))
 {
-const SdrObjList *pLst = static_cast(pObj)->GetSubList();
+const SdrObjList *pLst = pObjLst->GetSubList();
 for ( size_t i = 0; i < pLst->GetObjCount(); ++i )
 {
 if ( ::CheckControlLayer( pLst->GetObj( i ) ) )
commit 9e7ff6a7e4415ce18b7a68c857bdb86f142a8e5d
Author: Caolán McNamara 
Date:   Fri Jan 6 20:36:56 2017 +

coverity#1398371 Useless call

Change-Id: I3614bb162cec889ee102e0284b6a3a33a98df470

diff --git a/basegfx/source/color/bcolortools.cxx 
b/basegfx/source/color/bcolortools.cxx
index 7e139ac..095ea50 100644
--- a/basegfx/source/color/bcolortools.cxx
+++ b/basegfx/source/color/bcolortools.cxx
@@ -189,17 +189,6 @@ namespace basegfx { namespace tools
 }
 }
 
-BColor rgb2ciexyz( const BColor& rRGBColor )
-{
-// from Poynton color faq, and SMPTE RP 177-1993, Derivation
-// of Basic Television Color Equations
-const double r=rRGBColor.getRed(), g=rRGBColor.getGreen(), 
b=rRGBColor.getBlue();
-return BColor(
-0.412453*r + 0.35758*g  + 0.180423*b,
-0.212671*r + 0.71516*g  + 0.072169*b,
-0.019334*r + 0.119193*g + 0.950227*b);
-}
-
 } } // end of namespace basegfx
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/basegfx/test/basegfx2d.cxx b/basegfx/test/basegfx2d.cxx
index 502f784..b0b27ef 100644
--- a/basegfx/test/basegfx2d.cxx
+++ b/basegfx/test/basegfx2d.cxx
@@ -1211,18 +1211,6 @@ public:
tools::rgb2hsv(BColor(.5,.25,.25)) == 
BColor(0,.5,.5));
 }
 
-void ciexyzTest()
-{
-tools::rgb2ciexyz(maWhite);
-tools::rgb2ciexyz(maBlack);
-tools::rgb2ciexyz(maRed);
-tools::rgb2ciexyz(maGreen);
-tools::rgb2ciexyz(maBlue);
-tools::rgb2ciexyz(maYellow);
-tools::rgb2ciexyz(maMagenta);
-tools::rgb2ciexyz(maCyan);
-}
-
 // Change the following lines only, if you add, remove or rename
 // member functions of the current class,
 // because these macros are need by auto register mechanism.
@@ -1230,7 +1218,6 @@ public:
 CPPUNIT_TEST_SUITE(bcolor);
 CPPUNIT_TEST(hslTest);
 CPPUNIT_TEST(hsvTest);
-CPPUNIT_TEST(ciexyzTest);
 CPPUNIT_TEST_SUITE_END();
 }; // class b2dvector
 
diff --git a/include/basegfx/color/bcolortools.hxx 
b/include/basegfx/color/bcolortools.hxx
index 2f4222f..64cdc95 100644
---

[Libreoffice-commits] core.git: 3 commits - basegfx/source chart2/source filter/source fpicker/source include/filter include/sfx2 oox/source rsc/source sd/source sfx2/source starmath/source svgio/inc

2013-11-23 Thread Julien Nabet 
 basegfx/source/range/b2xrange.cxx|2 
 chart2/source/controller/dialogs/tp_DataSource.cxx   |6 +-
 chart2/source/controller/dialogs/tp_RangeChooser.cxx |6 +-
 chart2/source/view/charttypes/VSeriesPlotter.cxx |6 +-
 chart2/source/view/main/VLegend.cxx  |8 +-
 filter/source/msfilter/escherex.cxx  |2 
 filter/source/msfilter/eschesdo.cxx  |   12 ++--
 filter/source/msfilter/msdffimp.cxx  |   56 +--
 fpicker/source/office/OfficeFilePicker.cxx   |6 +-
 include/filter/msfilter/escherex.hxx |2 
 include/sfx2/templatecontaineritem.hxx   |2 
 include/sfx2/templateviewitem.hxx|2 
 include/sfx2/thumbnailviewitem.hxx   |4 -
 oox/source/vml/vmlshape.cxx  |2 
 rsc/source/res/rscclass.cxx  |2 
 sd/source/filter/eppt/epptso.cxx |   12 ++--
 sfx2/source/control/templatecontaineritem.cxx|4 -
 sfx2/source/control/templateviewitem.cxx |6 +-
 sfx2/source/control/thumbnailview.cxx|6 +-
 sfx2/source/control/thumbnailviewitem.cxx|4 -
 starmath/source/node.cxx |2 
 svgio/inc/svgio/svgreader/svgtools.hxx   |2 
 svx/source/table/svdotable.cxx   |8 +-
 sw/source/ui/frmdlg/colex.cxx|2 
 sw/source/ui/frmdlg/column.cxx   |2 
 vcl/source/filter/wmf/winmtf.cxx |6 +-
 26 files changed, 86 insertions(+), 86 deletions(-)

New commits:
commit b3c2cf2ae1644088a7fc5c325cce71f71d2b37fd
Author: Julien Nabet serval2...@yahoo.fr
Date:   Sat Nov 23 23:21:52 2013 +0100

widht - width

Change-Id: I661eeb167a95540a223ce72aac51789daf3767dc

diff --git a/chart2/source/controller/dialogs/tp_DataSource.cxx 
b/chart2/source/controller/dialogs/tp_DataSource.cxx
index c0232ae..7132f4a 100644
--- a/chart2/source/controller/dialogs/tp_DataSource.cxx
+++ b/chart2/source/controller/dialogs/tp_DataSource.cxx
@@ -141,11 +141,11 @@ void lcl_ShowChooserButton(
 if( rChooserButton.IsVisible() != bShow )
 {
 rChooserButton.Show( bShow );
-sal_Int32 nWidhtDiff = 12 + 4;
+sal_Int32 nWidthDiff = 12 + 4;
 if( bShow )
-nWidhtDiff = -nWidhtDiff;
+nWidthDiff = -nWidthDiff;
 Size aSize = rChooserButton.PixelToLogic( rEditField.GetSizePixel(), 
MAP_APPFONT );
-aSize.setWidth( aSize.getWidth() + nWidhtDiff );
+aSize.setWidth( aSize.getWidth() + nWidthDiff );
 rEditField.SetSizePixel( rChooserButton.LogicToPixel( aSize, 
MAP_APPFONT ));
 }
 }
diff --git a/chart2/source/controller/dialogs/tp_RangeChooser.cxx 
b/chart2/source/controller/dialogs/tp_RangeChooser.cxx
index 2eb5f5e..3514e91 100644
--- a/chart2/source/controller/dialogs/tp_RangeChooser.cxx
+++ b/chart2/source/controller/dialogs/tp_RangeChooser.cxx
@@ -41,11 +41,11 @@ void lcl_ShowChooserButton(
 if( rChooserButton.IsVisible() != bShow )
 {
 rChooserButton.Show( bShow );
-sal_Int32 nWidhtDiff = 10 + 2;
+sal_Int32 nWidthDiff = 10 + 2;
 if( bShow )
-nWidhtDiff = -nWidhtDiff;
+nWidthDiff = -nWidthDiff;
 Size aSize = rChooserButton.PixelToLogic( rEditField.GetSizePixel(), 
MAP_APPFONT );
-aSize.setWidth( aSize.getWidth() + nWidhtDiff );
+aSize.setWidth( aSize.getWidth() + nWidthDiff );
 rEditField.SetSizePixel( rChooserButton.LogicToPixel( aSize, 
MAP_APPFONT ));
 }
 }
diff --git a/chart2/source/view/charttypes/VSeriesPlotter.cxx 
b/chart2/source/view/charttypes/VSeriesPlotter.cxx
index 44e4c58..1e6c96d 100644
--- a/chart2/source/view/charttypes/VSeriesPlotter.cxx
+++ b/chart2/source/view/charttypes/VSeriesPlotter.cxx
@@ -456,14 +456,14 @@ uno::Reference drawing::XShape  
VSeriesPlotter::createDataLabel( const uno::Re
 Reference drawing::XShape  xSymbol;
 if(pLabel-ShowLegendSymbol)
 {
-sal_Int32 nSymbolHeigth = static_cast sal_Int32 ( fViewFontSize 
* 0.6  );
+sal_Int32 nSymbolHeight = static_cast sal_Int32 ( fViewFontSize 
* 0.6  );
 awt::Size aCurrentRatio = this-getPreferredLegendKeyAspectRatio();
 sal_Int32 nSymbolWidth = aCurrentRatio.Width;
 if( aCurrentRatio.Height  0 )
 {
-nSymbolWidth = nSymbolHeigth* 
aCurrentRatio.Width/aCurrentRatio.Height;
+nSymbolWidth = nSymbolHeight* 
aCurrentRatio.Width/aCurrentRatio.Height;
 }
-awt::Size aMaxSymbolExtent( nSymbolWidth, nSymbolHeigth );
+awt::Size aMaxSymbolExtent( nSymbolWidth, nSymbolHeight );
 
 if( rDataSeries.isVaryColorsByPoint() )
 xSymbol.set(

[Libreoffice-commits] core.git: 3 commits - basegfx/source extensions/source include/basegfx sc/source vcl/source vcl/win

2013-08-14 Thread Caolán McNamara 
 basegfx/source/matrix/b2dhommatrixtools.cxx |   41 
 basegfx/source/polygon/b2dpolygon.cxx   |2 
 basegfx/source/polygon/b2dpolygontools.cxx  |   33 +
 basegfx/source/polygon/b2dpolypolygoncutter.cxx |   77 ++-
 basegfx/source/polygon/b2dpolypolygontools.cxx  |   17 +
 extensions/source/bibliography/toolbar.cxx  |   15 ++--
 extensions/source/bibliography/toolbar.hxx  |8 +-
 extensions/source/propctrlr/browserline.cxx |4 -
 extensions/source/propctrlr/browserline.hxx |4 -
 extensions/source/update/ui/updatecheckui.cxx   |   29 +++-
 include/basegfx/matrix/b2dhommatrixtools.hxx|6 +
 include/basegfx/polygon/b2dpolygontools.hxx |5 +
 include/basegfx/polygon/b2dpolypolygontools.hxx |5 +
 include/basegfx/tuple/b2dtuple.hxx  |4 -
 include/basegfx/tuple/b3dtuple.hxx  |4 -
 sc/source/ui/inc/output.hxx |2 
 sc/source/ui/view/gridwin.cxx   |8 +-
 sc/source/ui/view/output.cxx|   34 +-
 vcl/source/gdi/region.cxx   |5 -
 vcl/source/window/builder.cxx   |1 
 vcl/win/source/gdi/salgdi.cxx   |   80 
 21 files changed, 311 insertions(+), 73 deletions(-)

New commits:
commit f0b9a27703db603a6a2fcf1d6f4db87e0bf4823b
Author: Caolán McNamara caol...@redhat.com
Date:   Wed Aug 14 10:00:48 2013 +0100

make extensions XubString free

Change-Id: I0216d11ade872af889fc805e4c2a9241f7f230c5

diff --git a/extensions/source/bibliography/toolbar.cxx 
b/extensions/source/bibliography/toolbar.cxx
index ea3999f..0c3c90b 100644
--- a/extensions/source/bibliography/toolbar.cxx
+++ b/extensions/source/bibliography/toolbar.cxx
@@ -104,7 +104,7 @@ void BibTBListBoxListener::statusChanged(const 
::com::sun::star::frame::FeatureS
 const OUString* pStringArray = (const 
OUString*)pStringSeq-getConstArray();
 
 sal_uInt32 nCount = pStringSeq-getLength();
-XubString aEntry;
+OUString aEntry;
 for( sal_uInt32 i=0; inCount; i++ )
 {
 aEntry = String(pStringArray[i]);
@@ -113,8 +113,7 @@ void BibTBListBoxListener::statusChanged(const 
::com::sun::star::frame::FeatureS
 pToolBar-UpdateSourceList(sal_True);
 }
 
-XubString aStr = String(rEvt.FeatureDescriptor);
-pToolBar-SelectSourceEntry(aStr);
+pToolBar-SelectSourceEntry(rEvt.FeatureDescriptor);
 }
 };
 
@@ -219,7 +218,7 @@ BibToolBar::BibToolBar(Window* pParent, Link aLink, WinBits 
nStyle):
 aEdQuery.SetSizePixel(aLBSource.GetSizePixel());
 aEdQuery.Show();
 
-XubString aStr=GetItemText(TBC_FT_SOURCE);
+OUString aStr=GetItemText(TBC_FT_SOURCE);
 Rectangle aRect=GetItemRect(TBC_FT_SOURCE);
 aFtSource.SetText(aStr);
 aFtSource.SetSizePixel(aRect.GetSize());
@@ -377,7 +376,7 @@ void BibToolBar::ClearFilterMenu()
 aPopupMenu.Clear();
 nMenuId=0;
 }
-sal_uInt16 BibToolBar::InsertFilterItem(const XubString aMenuEntry)
+sal_uInt16 BibToolBar::InsertFilterItem(const OUString aMenuEntry)
 {
 nMenuId++;
 aPopupMenu.InsertItem(nMenuId,aMenuEntry);
@@ -407,12 +406,12 @@ void BibToolBar::UpdateSourceList(sal_Bool bFlag)
 aLBSource.SetUpdateMode(bFlag);
 }
 
-void BibToolBar::InsertSourceEntry(const XubString aEntry, sal_uInt16 nPos)
+void BibToolBar::InsertSourceEntry(const OUString aEntry, sal_uInt16 nPos)
 {
 aLBSource.InsertEntry(aEntry, nPos);
 }
 
-void BibToolBar::SelectSourceEntry(const XubString aStr)
+void BibToolBar::SelectSourceEntry(const OUString aStr)
 {
 aLBSource.SelectEntry(aStr);
 }
@@ -423,7 +422,7 @@ void BibToolBar::EnableQuery(sal_Bool bFlag)
 aEdQuery.Enable(bFlag);
 }
 
-void BibToolBar::SetQueryString(const XubString aStr)
+void BibToolBar::SetQueryString(const OUString aStr)
 {
 aEdQuery.SetText(aStr);
 }
diff --git a/extensions/source/bibliography/toolbar.hxx 
b/extensions/source/bibliography/toolbar.hxx
index 877931c..b7cc0f5 100644
--- a/extensions/source/bibliography/toolbar.hxx
+++ b/extensions/source/bibliography/toolbar.hxx
@@ -156,15 +156,15 @@ class BibToolBar:   public ToolBox
 voidClearSourceList();
 voidUpdateSourceList(sal_Bool bFlag=sal_True);
 voidEnableSourceList(sal_Bool bFlag=sal_True);
-voidInsertSourceEntry(const XubString,sal_uInt16 
nPos=LISTBOX_APPEND );
-voidSelectSourceEntry(const XubString );
+voidInsertSourceEntry(const OUString,sal_uInt16 
nPos=LISTBOX_APPEND );
+voidSelectSourceEntry(const OUString );
 
 voidEnableQuery(sal_Bool bFlag=sal_True);
-voidSetQueryString(const XubString );
+voidSetQueryString(const OUString );
 voidAdjustToolBox();
 
 voidClearFilterMenu();
-sal_uInt16