Re: [PATCH] Bug 38838 - Removal/Replacement of the String/UniString with OUString once and for all.
Hi Jean-Noël, First thank you for this big patch! Perhaps I missed it but I didn't find a license statement from you. Could you send a post with it? (you can take example from http://nabble.documentfoundation.org/License-Statement-td4027832.html) Thank you in advance. Julien -- View this message in context: http://nabble.documentfoundation.org/PATCH-Bug-38838-Removal-Replacement-of-the-String-UniString-with-OUString-once-and-for-all-tp4027737p4027922.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Bug 38838 - Removal/Replacement of the String/UniString with OUString once and for all.
2013/1/9 julien2412 serval2...@yahoo.fr Perhaps I missed it but I didn't find a license statement from you. Could you send a post with it? (you can take example from http://nabble.documentfoundation.org/License-Statement-td4027832.html) Hi Julien, I hereby declare that: All my contributions, past and future, to LibreOffice are licensed under the terms of the MPL / LGPLv3+. Thank you, Jean-Noel Rouvignac ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Bug 38838 - Removal/Replacement of the String/UniString with OUString once and for all.
I forgot to mention that there are a few strange cases that are doign the same that the old code was doing: The following code converts a sal_uIntPtr to sal_Int32: +OUString info = OUString::valueOf( static_castsal_Int32( pProgrInfo-GetCurObj() ) ) ++ OUString::valueOf( static_castsal_Int32( pProgrInfo-GetObjCount() ) ); +info = OUString::valueOf( static_castsal_Int32( pProgrInfo-GetCurAction() ) ) ++ OUString::valueOf( static_castsal_Int32( pProgrInfo-GetActionCount() ) ); +info = OUString::valueOf( static_castsal_Int32( pProgrInfo-GetCurInsert() ) ) ++ OUString::valueOf( static_castsal_Int32( pProgrInfo-GetInsertCount() ) ); The following code converts a sal_uInt32 to sal_Int32: +rText.Append( OUString::valueOf( static_castsal_Int32( nCount ) ) ); +rText.Append( OUString::valueOf( static_castsal_Int32( GetValue( i ).nValue ) ) ); I just converted the code to do what the old code was doing, but I find these dodgy. Should OUString be enhanced to support these types? Thanks, Jean-Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
