Re: [Libreoffice] Failed at slideshow(fpicker) with ‘class KFileDialog’ has no member named ‘setConfirmOverwrite’
On Fri, Dec 17, 2010 at 07:27:12AM +0100, David Tardon wrote: On Fri, Dec 17, 2010 at 02:18:04PM +0800, imacat wrote: Dear all, Hi. This is imacat from Taiwan. I tried to compile LibreOffice 3.3.0.1 on my Debian Lenny x86_64 5.0.6, gcc 4.3.2, glibc 2.7. It failed at the slideshow module, and when I digged inside as suggested, it complainted ‘class KFileDialog’ has no member named ‘setConfirmOverwrite’. Your KDE is too old--the setConfirmOverwrite function was added in 4.2 (http://api.kde.org/4.5-api/kdelibs-apidocs/kio/html/classKFileDialog.html#558b1932c57dfd55e278e17fc4a34dd8). Then configure should check for that. Grüße/Regards, René -- .''`. René Engelhard -- Debian GNU/Linux Developer : :' : http://www.debian.org | http://people.debian.org/~rene/ `. `' r...@debian.org | GnuPG-Key ID: D03E3E70 `- Fingerprint: E12D EA46 7506 70CF A960 801D 0AA0 4571 D03E 3E70 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Failed at slideshow(fpicker) with ‘class KFileDialog’ has no member named ‘setConfirmOverwrite’
On Fri, Dec 17, 2010 at 09:27:40AM +0100, Rene Engelhard wrote: On Fri, Dec 17, 2010 at 07:27:12AM +0100, David Tardon wrote: On Fri, Dec 17, 2010 at 02:18:04PM +0800, imacat wrote: Dear all, Hi. This is imacat from Taiwan. I tried to compile LibreOffice 3.3.0.1 on my Debian Lenny x86_64 5.0.6, gcc 4.3.2, glibc 2.7. It failed at the slideshow module, and when I digged inside as suggested, it complainted ‘class KFileDialog’ has no member named ‘setConfirmOverwrite’. Your KDE is too old--the setConfirmOverwrite function was added in 4.2 (http://api.kde.org/4.5-api/kdelibs-apidocs/kio/html/classKFileDialog.html#558b1932c57dfd55e278e17fc4a34dd8). Then configure should check for that. True. I'll add a test for it. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Failed at slideshow(fpicker) with ‘class KFileDialog’ has no member named ‘setConfirmOverwrite’
On Fri, Dec 17, 2010 at 09:27:40AM +0100, Rene Engelhard wrote:
On Fri, Dec 17, 2010 at 07:27:12AM +0100, David Tardon wrote:
On Fri, Dec 17, 2010 at 02:18:04PM +0800, imacat wrote:
Dear all,
Hi. This is imacat from Taiwan. I tried to compile LibreOffice
3.3.0.1 on my Debian Lenny x86_64 5.0.6, gcc 4.3.2, glibc 2.7. It
failed at the slideshow module, and when I digged inside as suggested,
it complainted ‘class KFileDialog’ has no member named
‘setConfirmOverwrite’.
Your KDE is too old--the setConfirmOverwrite function was added in 4.2
(http://api.kde.org/4.5-api/kdelibs-apidocs/kio/html/classKFileDialog.html#558b1932c57dfd55e278e17fc4a34dd8).
Then configure should check for that.
Please someone review and sign-off for libreoffice-3-3 (probably we should
check for the function and not for the version, but anyways ;)):
diff --git a/configure.in b/configure.in
index 1537b4d..1df6b5f 100644
--- a/configure.in
+++ b/configure.in
@@ -6992,6 +6992,21 @@ the root of your Qt installation by exporting QT4DIR befo
KDE4_CFLAGS=`pkg-config --cflags QtCore` `pkg-config --cflags QtGui` -I$kde
KDE4_LIBS=-L$kde_libdir -L$qt_lib_dir -lkdeui -lkdecore -lQtCore -lQtGui
+ AC_LANG_PUSH([C++])
+ save_CXXFLAGS=$CXXFLAGS
+ CXXFLAGS=$CXXFLAGS $KDE4_CFLAGS
+ AC_MSG_CHECKING([whether KDE is = 4.2])
+ AC_TRY_RUN([
+#include kdeversion.h
+
+int main(int argc, char **argv) {
+ if (KDE_VERSION_MAJOR == 4 KDE_VERSION_MINOR = 2) return 0;
+ else return 1;
+}
+ ], [AC_MSG_RESULT([yes])], [AC_MSG_ERROR([KDE version too old])])
+ CXXFLAGS=$save_CXXFLAGS
+ AC_LANG_POP([C++])
+
# Glib is needed for properly handling Qt event loop with Qt's Glib integrat
PKG_CHECK_MODULES(KDE_GLIB,[glib-2.0 = 2.4],
[KDE_HAVE_GLIB=1],
(cut'n'pasted and adapted from the check for KDE3s kab)
Grüße/Regards,
René
--
.''`. René Engelhard -- Debian GNU/Linux Developer
: :' : http://www.debian.org | http://people.debian.org/~rene/
`. `' r...@debian.org | GnuPG-Key ID: D03E3E70
`- Fingerprint: E12D EA46 7506 70CF A960 801D 0AA0 4571 D03E 3E70
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Failed at slideshow(fpicker) with ‘class KFileDialog’ has no member named ‘setConfirmOverwrite’
On Fri, Dec 17, 2010 at 10:23:24AM +0100, Rene Engelhard wrote: On Fri, Dec 17, 2010 at 09:27:40AM +0100, Rene Engelhard wrote: On Fri, Dec 17, 2010 at 07:27:12AM +0100, David Tardon wrote: On Fri, Dec 17, 2010 at 02:18:04PM +0800, imacat wrote: Dear all, Hi. This is imacat from Taiwan. I tried to compile LibreOffice 3.3.0.1 on my Debian Lenny x86_64 5.0.6, gcc 4.3.2, glibc 2.7. It failed at the slideshow module, and when I digged inside as suggested, it complainted ‘class KFileDialog’ has no member named ‘setConfirmOverwrite’. Your KDE is too old--the setConfirmOverwrite function was added in 4.2 (http://api.kde.org/4.5-api/kdelibs-apidocs/kio/html/classKFileDialog.html#558b1932c57dfd55e278e17fc4a34dd8). Then configure should check for that. Please someone review and sign-off for libreoffice-3-3 (probably we should check for the function and not for the version, but anyways ;)): Done. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Failed at slideshow(fpicker) with ‘class KFileDialog’ has no member named ‘setConfirmOverwrite’
On Fri, 2010-12-17 at 10:23 +0100, Rene Engelhard wrote: Please someone review and sign-off for libreoffice-3-3 (probably we should check for the function and not for the version, but anyways ;)): And PKG_CONFIG is supposed to be broken compared to this ? ;-) I just read the 100 lines of qt / kde checking in configure.in and was nearly ill ;-) And to think that almost all of this could all be evaporated trivially by encouraging kde-libs to install a single 10 line file into /usr/lib/pkgconfig/ - shame. Either way, the check looks fine to me; I notice it is pushed to libreoffice-3-3, but (apparently) not to master, is that intentional ? ATB, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Failed at slideshow(fpicker) with ‘class KFileDialog’ has no member named ‘setConfirmOverwrite’
On Fri, Dec 17, 2010 at 10:06:55AM +, Michael Meeks wrote: And PKG_CONFIG is supposed to be broken compared to this ? ;-) I just read the 100 lines of qt / kde checking in configure.in and was nearly ill ;-) And to think that almost all of this could all be evaporated trivially by encouraging kde-libs to install a single 10 line file into /usr/lib/pkgconfig/ - shame. Yeah. Also look at the db check, which greatly could benefit if Oracle(!) would ship a .pc Either way, the check looks fine to me; I notice it is pushed to libreoffice-3-3, but (apparently) not to master, is that intentional ? Well, as we agreed that libreoffice-3-3 gets git merge'd to master, I don't think one needs a manual commit there. Grüße/Regards, René ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Failed at slideshow(fpicker) with ‘class KFileDialog’ has no member named ‘setConfirmOverwrite’
On Fri, 2010-12-17 at 11:16 +0100, Rene Engelhard wrote: Either way, the check looks fine to me; I notice it is pushed to libreoffice-3-3, but (apparently) not to master, is that intentional ? Well, as we agreed that libreoffice-3-3 gets git merge'd to master, I don't think one needs a manual commit there. Ah - silly me; I've been cherry picking both ways interchangeably as I went; presumably the merge will cope with that. ATB, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Failed at slideshow(fpicker) with ‘class KFileDialog’ has no member named ‘setConfirmOverwrite’
Hi Michael, On 2010-12-17 at 14:12 +, Michael Meeks wrote: Well, as we agreed that libreoffice-3-3 gets git merge'd to master, I don't think one needs a manual commit there. Ah - silly me; I've been cherry picking both ways interchangeably as I went; presumably the merge will cope with that. It usually does reasonably well :-) I want to merge libreoffice-3-3 into master as soon as the RC2 is tagged. Regards, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Failed at slideshow(fpicker) with ‘class KFileDialog’ has no member named ‘setConfirmOverwrite’
On Fri, Dec 17, 2010 at 02:18:04PM +0800, imacat wrote: Dear all, Hi. This is imacat from Taiwan. I tried to compile LibreOffice 3.3.0.1 on my Debian Lenny x86_64 5.0.6, gcc 4.3.2, glibc 2.7. It failed at the slideshow module, and when I digged inside as suggested, it complainted ‘class KFileDialog’ has no member named ‘setConfirmOverwrite’. Your KDE is too old--the setConfirmOverwrite function was added in 4.2 (http://api.kde.org/4.5-api/kdelibs-apidocs/kio/html/classKFileDialog.html#558b1932c57dfd55e278e17fc4a34dd8). Any suggestion how to solve this? Thank you very much. Update KDE .-) D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
