[Libreoffice-bugs] [Bug 124022] Unhardcode different driver default settings
https://bugs.documentfoundation.org/show_bug.cgi?id=124022 --- Comment #7 from QA Administrators --- Dear Mike Kaganski, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 124022] Unhardcode different driver default settings
https://bugs.documentfoundation.org/show_bug.cgi?id=124022 --- Comment #6 from QA Administrators --- Dear Mike Kaganski, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124022] Unhardcode different driver default settings
https://bugs.documentfoundation.org/show_bug.cgi?id=124022 --- Comment #5 from Christian Lohmaier --- adding commend from outage: https://lists.freedesktop.org/archives/libreoffice-bugs/2019-March/176627.html --- Comment #5 from Lionel Elie Mamane --- (In reply to Mike Kaganski from comment #0) > so effectively this mandates that all drivers have > same defaults which are equal to those in > ODatabaseModelImpl::getDefaultDataSourceSettings, breaking the per-driver > mechanism. IMO, having per-driver defaults is important. SDBC drivers that know which database they connect to (e.g. MySQL, PostgreSQL, as opposed to e.g. ODBC, JDBC, ADO) should just set the right values by default silently, and not even give the user UI to change them to known non-working values. > Additionally, skipping writing of the settings to ODB which are equal to > defaults creates another problem: an ODB only has settings which are not > equal to the defaults *of the version which was used for its last saving* - > and if opened in another version with changed defaults, the missing settings > take new default values, which may break the connection. In the context of DBMS-specific drivers, on the other hand, when the default is wrong, it allows changing the default, and fixing the connection in newer LibreOffice versions. Else, we fix it only for files created in the new LibreOffice version. https://lists.freedesktop.org/archives/libreoffice-bugs/2019-March/176630.html --- Comment #6 from Mike Kaganski --- (In reply to Lionel Elie Mamane from comment #5) > IMO, having per-driver defaults is important. SDBC drivers that know which > database they connect to (e.g. MySQL, PostgreSQL, as opposed to e.g. ODBC, > JDBC, ADO) should just set the right values by default silently, and not > even give the user UI to change them to known non-working values. No doubt here. My point is that currently that is broken, and must be fixed by removing the mess when some pieces of code take one set of defaults into account, and other takes other set, which leads to errors. > In the context of DBMS-specific drivers, on the other hand, when the default > is wrong, it allows changing the default, and fixing the connection in newer > LibreOffice versions. Else, we fix it only for files created in the new > LibreOffice version. I don't believe this is something actually useful. If we have a broken default, then a newly created connection of that type would be broken - so it would be hardly usable from the beginning. On the other hand, *if* some connection happens to be already working with this given default (even if we consider it broken), it doesn't make sense to "fix" it (don't fix what is not broken) with the risk of making it work unexpectedly for the user (which might have applied some workarounds expecting the way it worked before). I don't think that it's more important to be able to silently fix *partially created* connections (I mean, that apparently users would start such a connection, and then abandon because of the broken default; or edit it manually in the ODB anyway) than to have stable connections. https://lists.freedesktop.org/archives/libreoffice-bugs/2019-March/176631.html --- Comment #7 from Mike Kaganski --- ... and there could be an option like "Set all inner settings to new defaults" in the advanced settings dialog. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124022] Unhardcode different driver default settings
https://bugs.documentfoundation.org/show_bug.cgi?id=124022 --- Comment #7 from Mike Kaganski --- ... and there could be an option like "Set all inner settings to new defaults" in the advanced settings dialog. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124022] Unhardcode different driver default settings
https://bugs.documentfoundation.org/show_bug.cgi?id=124022 --- Comment #6 from Mike Kaganski --- (In reply to Lionel Elie Mamane from comment #5) > IMO, having per-driver defaults is important. SDBC drivers that know which > database they connect to (e.g. MySQL, PostgreSQL, as opposed to e.g. ODBC, > JDBC, ADO) should just set the right values by default silently, and not > even give the user UI to change them to known non-working values. No doubt here. My point is that currently that is broken, and must be fixed by removing the mess when some pieces of code take one set of defaults into account, and other takes other set, which leads to errors. > In the context of DBMS-specific drivers, on the other hand, when the default > is wrong, it allows changing the default, and fixing the connection in newer > LibreOffice versions. Else, we fix it only for files created in the new > LibreOffice version. I don't believe this is something actually useful. If we have a broken default, then a newly created connection of that type would be broken - so it would be hardly usable from the beginning. On the other hand, *if* some connection happens to be already working with this given default (even if we consider it broken), it doesn't make sense to "fix" it (don't fix what is not broken) with the risk of making it work unexpectedly for the user (which might have applied some workarounds expecting the way it worked before). I don't think that it's more important to be able to silently fix *partially created* connections (I mean, that apparently users would start such a connection, and then abandon because of the broken default; or edit it manually in the ODB anyway) than to have stable connections. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124022] Unhardcode different driver default settings
https://bugs.documentfoundation.org/show_bug.cgi?id=124022 --- Comment #5 from Lionel Elie Mamane --- (In reply to Mike Kaganski from comment #0) > so effectively this mandates that all drivers have > same defaults which are equal to those in > ODatabaseModelImpl::getDefaultDataSourceSettings, breaking the per-driver > mechanism. IMO, having per-driver defaults is important. SDBC drivers that know which database they connect to (e.g. MySQL, PostgreSQL, as opposed to e.g. ODBC, JDBC, ADO) should just set the right values by default silently, and not even give the user UI to change them to known non-working values. > Additionally, skipping writing of the settings to ODB which are equal to > defaults creates another problem: an ODB only has settings which are not > equal to the defaults *of the version which was used for its last saving* - > and if opened in another version with changed defaults, the missing settings > take new default values, which may break the connection. In the context of DBMS-specific drivers, on the other hand, when the default is wrong, it allows changing the default, and fixing the connection in newer LibreOffice versions. Else, we fix it only for files created in the new LibreOffice version. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124022] Unhardcode different driver default settings
https://bugs.documentfoundation.org/show_bug.cgi?id=124022 --- Comment #4 from Xisco Faulí --- Yep, sure, I'm not saying you should mentor it. Do you think it should be discussed in the dev list first ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124022] Unhardcode different driver default settings
https://bugs.documentfoundation.org/show_bug.cgi?id=124022 --- Comment #3 from Mike Kaganski --- (In reply to Xisco Faulí from comment #2) Possibly - but: 1. I wanted to have some discussion first - I know too little about the topic, and it happened to me when I tried to fix a bug, not because of deep understanding; 2. Even if it's worth doing, as I mentioned, I'm not able to mentor. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124022] Unhardcode different driver default settings
https://bugs.documentfoundation.org/show_bug.cgi?id=124022 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org --- Comment #2 from Xisco Faulí --- Hello Mike, Do you think this could become a task for GSOC ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124022] Unhardcode different driver default settings
https://bugs.documentfoundation.org/show_bug.cgi?id=124022 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Let's set this to NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124022] Unhardcode different driver default settings
https://bugs.documentfoundation.org/show_bug.cgi?id=124022 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||104790 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104790 [Bug 104790] [META] Database connectivity interfaces (ODBC, JDBC..) and external databases -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
